WebKit-https.git
6 years agoDo not set CMAKE_BUILD_TYPE if it is not defined
paroga@webkit.org [Tue, 9 Apr 2013 07:20:01 +0000 (07:20 +0000)]
Do not set CMAKE_BUILD_TYPE if it is not defined
https://bugs.webkit.org/show_bug.cgi?id=114243

Reviewed by Geoffrey Garen.

Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.

* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the gyp files for Tools
benjamin@webkit.org [Tue, 9 Apr 2013 07:12:31 +0000 (07:12 +0000)]
Remove the gyp files for Tools
https://bugs.webkit.org/show_bug.cgi?id=114248

Reviewed by Ryosuke Niwa.

* DumpRenderTree/DumpRenderTree.gyp: Removed.
* DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
* DumpRenderTree/DumpRenderTree.gypi: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
* TestWebKitAPI/TestWebKitAPI.gypi: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove yarr.gyp
rniwa@webkit.org [Tue, 9 Apr 2013 07:07:13 +0000 (07:07 +0000)]
Remove yarr.gyp
https://bugs.webkit.org/show_bug.cgi?id=114247

Reviewed by Benjamin Poulain.

* yarr/yarr.gyp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove gyp from ThirdParty
benjamin@webkit.org [Tue, 9 Apr 2013 06:59:13 +0000 (06:59 +0000)]
Remove gyp from ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=114244

Rubberstamped by Ryosuke Niwa.

* gyp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove ANGLE.gyp
rniwa@webkit.org [Tue, 9 Apr 2013 06:57:21 +0000 (06:57 +0000)]
Remove ANGLE.gyp
https://bugs.webkit.org/show_bug.cgi?id=114245

Unreviewed. Just removing an empty directory.

* ANGLE.gyp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove WebCore.gyp/gypi
rniwa@webkit.org [Tue, 9 Apr 2013 06:49:33 +0000 (06:49 +0000)]
Remove WebCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114239

Reviewed by Benjamin Poulain.

* WebCore.gyp: Removed.
* WebCore.gyp/.gitignore: Removed.
* WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Removed.
* WebCore.gyp/MakeNames.gypi: Removed.
* WebCore.gyp/WebCore.gyp: Removed.
* WebCore.gyp/mac: Removed.
* WebCore.gyp/mac/adjust_visibility.sh: Removed.
* WebCore.gyp/mac/check_objc_rename.sh: Removed.
* WebCore.gyp/scripts: Removed.
* WebCore.gyp/scripts/action_csspropertynames.py: Removed.
* WebCore.gyp/scripts/action_cssvaluekeywords.py: Removed.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py: Removed.
* WebCore.gyp/scripts/action_makenames.py: Removed.
* WebCore.gyp/scripts/action_useragentstylesheets.py: Removed.
* WebCore.gyp/scripts/rule_bison.py: Removed.
* WebCore.gyp/scripts/supplemental_idl_files.py: Removed.
* WebCore.gypi: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove JavaScriptCore.gyp/gypi
rniwa@webkit.org [Tue, 9 Apr 2013 06:46:40 +0000 (06:46 +0000)]
Remove JavaScriptCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114238

Reviewed by Benjamin Poulain.

* JavaScriptCore.gyp: Removed.
* JavaScriptCore.gyp/.gitignore: Removed.
* JavaScriptCore.gypi: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdds fromCharCode intrinsic support.
commit-queue@webkit.org [Tue, 9 Apr 2013 06:45:16 +0000 (06:45 +0000)]
Adds fromCharCode intrinsic support.
https://bugs.webkit.org/show_bug.cgi?id=104807

Patch by Vahag Vardanyan <vaag@ispras.ru> on 2013-04-08
Reviewed by Oliver Hunt.

Switch to using fromCharCode intrinsic instead of call operation in some cases.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC):
* runtime/StringConstructor.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWKR (new-commit-bot) is too slow
rniwa@webkit.org [Tue, 9 Apr 2013 06:44:56 +0000 (06:44 +0000)]
WKR (new-commit-bot) is too slow
https://bugs.webkit.org/show_bug.cgi?id=110087

Reviewed by Geoffrey Garen.

Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
Just run "svn log -r <revision>" instead to cut down the delay.

Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot.next_work_item):
(NewCommitBot._is_empty_log):
(NewCommitBot._update_checkout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRollout r147756: performance regression
commit-queue@webkit.org [Tue, 9 Apr 2013 06:16:14 +0000 (06:16 +0000)]
Rollout r147756: performance regression
https://bugs.webkit.org/show_bug.cgi?id=114176

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-08
Reviewed by Alexis Menard.

Source/WebCore:

Rolling out the patch for https://bugs.webkit.org/show_bug.cgi?id=74144 "[CSS Regions] Elements in a region
should be assignable to a named flow" because of the performance regression in Parser/html5-full-render.html .

No new tests (because this is a rollout patch).

* dom/Element.cpp:
* dom/Element.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/NodeRenderingContext.h:
* dom/PseudoElement.h:
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer):
* dom/Text.h:
* rendering/FlowThreadController.cpp:
* rendering/FlowThreadController.h:
* rendering/RenderObject.h:
* rendering/RenderRegion.h:
* svg/SVGElement.cpp:
* svg/SVGElement.h:

LayoutTests:

* fast/regions/flow-body-in-html-expected.txt: Removed.
* fast/regions/flow-body-in-html.html: Removed.
* fast/regions/region-content-flown-into-region-expected.html: Removed.
* fast/regions/region-content-flown-into-region.html: Removed.
* fast/regions/universal-selector-children-to-the-same-region-expected.txt: Removed.
* fast/regions/universal-selector-children-to-the-same-region.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix. Can't remove appendCustomBuildFlags.
rniwa@webkit.org [Tue, 9 Apr 2013 05:55:28 +0000 (05:55 +0000)]
Build fix. Can't remove appendCustomBuildFlags.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium builders from build.webkit.org
rniwa@webkit.org [Tue, 9 Apr 2013 05:35:14 +0000 (05:35 +0000)]
Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990

Reviewed by Benjamin Poulain.

Removed.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(InstallGtkDependencies):
(RunUnitTests.start):
(RunWebKit2Tests.start):
(Factory.__init__):
(unitTestsSupported):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
(BuildAndPerfTestFactory.__init__):
(BuildAndPerfTestWebKit2Factory.__init__):
(DownloadAndPerfTestFactory.__init__):
(loadBuilderConfig):
* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove WTF.gyp/WTF.gypi
rniwa@webkit.org [Tue, 9 Apr 2013 04:53:46 +0000 (04:53 +0000)]
Remove WTF.gyp/WTF.gypi
https://bugs.webkit.org/show_bug.cgi?id=114237

Reviewed by Maciej Stachowiak.

* WTF.gyp: Removed.
* WTF.gyp/.gitignore: Removed.
* WTF.gyp/WTF.gyp: Removed.
* WTF.gypi: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove HTML Notification
benjamin@webkit.org [Tue, 9 Apr 2013 03:15:52 +0000 (03:15 +0000)]
Remove HTML Notification
https://bugs.webkit.org/show_bug.cgi?id=114231

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

The feature is dead. It was only kept in the tree because of chromium.

* Configurations/FeatureDefines.xcconfig:
* Modules/notifications/Notification.cpp:
(WebCore):
(WebCore::Notification::Notification):
* Modules/notifications/Notification.h:
(Notification):
* Modules/notifications/NotificationCenter.h:
(NotificationCenter):
* Modules/notifications/NotificationCenter.idl:
* page/FeatureObserver.h:

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/qt:

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* qmake/mkspecs/features/features.pri:

LayoutTests:

* fast/notifications/notifications-with-permission-expected.txt:
* fast/notifications/notifications-with-permission.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac][WebKit2] destroy-during-async-npp-new.html does not crash anymore
benjamin@webkit.org [Tue, 9 Apr 2013 03:09:51 +0000 (03:09 +0000)]
[Mac][WebKit2] destroy-during-async-npp-new.html does not crash anymore

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08

* platform/mac-wk2/TestExpectations:
The test destroy-during-async-npp-new.html has not crashed in a long time. Re-enable
it to see how the bots like it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't try to remove a non-existent snapshot
dino@apple.com [Tue, 9 Apr 2013 02:43:24 +0000 (02:43 +0000)]
Don't try to remove a non-existent snapshot
https://bugs.webkit.org/show_bug.cgi?id=114226
<rdar://problem/13604480>

Reviewed by Darin Adler.

We don't need to trigger the timer to remove a snapshot
if there was never a snapshot displayed.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::setDisplayState): Detect if we're moving from the DisplayingSnapshot state.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Guard against a missing renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agowtf/dtoa/* uses a confusing name to reference its buffers
benjamin@webkit.org [Tue, 9 Apr 2013 02:26:38 +0000 (02:26 +0000)]
wtf/dtoa/* uses a confusing name to reference its buffers
https://bugs.webkit.org/show_bug.cgi?id=109709

Reviewed by Darin Adler.

The data structure Vector in wtf/dtoa has nothing to do with a traditional
vector, is it just a pointer and the length of the pointed buffer.

Rename it to BufferReference to avoid mistakes.

* wtf/dtoa/bignum-dtoa.cc:
* wtf/dtoa/bignum-dtoa.h:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/bignum.h:
(Bignum):
* wtf/dtoa/double-conversion.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/fast-dtoa.h:
* wtf/dtoa/fixed-dtoa.cc:
* wtf/dtoa/fixed-dtoa.h:
(double_conversion):
* wtf/dtoa/strtod.cc:
* wtf/dtoa/strtod.h:
(double_conversion):
* wtf/dtoa/utils.h:
(double_conversion):
(WTF::double_conversion::BufferReference::BufferReference):
(WTF::double_conversion::BufferReference::SubBufferReference):
(StringBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDo not define CAN_THEME_URL_ICON for PLATFORM(WIN_CAIRO)
paroga@webkit.org [Tue, 9 Apr 2013 01:45:50 +0000 (01:45 +0000)]
Do not define CAN_THEME_URL_ICON for PLATFORM(WIN_CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=108444

Reviewed by Darin Adler.

Image::loadPlatformResource("urlIcon") returns nothing
since r30961 on Windows which makes the code useless.

* loader/icon/IconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
roger_fong@apple.com [Tue, 9 Apr 2013 01:40:56 +0000 (01:40 +0000)]
Build fix.

* platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
* WebKit.vcproj/WebKitExports.def.in:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] WebPage: fix build due to type mismatches
commit-queue@webkit.org [Tue, 9 Apr 2013 01:34:05 +0000 (01:34 +0000)]
[BlackBerry] WebPage: fix build due to type mismatches
https://bugs.webkit.org/show_bug.cgi?id=114148

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.

Add explicit conversions between LayoutUnit and int, and between
LayoutRect and IntRect.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rectForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
commit-queue@webkit.org [Tue, 9 Apr 2013 01:27:49 +0000 (01:27 +0000)]
[BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
https://bugs.webkit.org/show_bug.cgi?id=112683

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.

After calls to signbit and friends were prefixed with std:: in
r143232, the BlackBerry port no longer compiles.

The solution is to get rid of the macros defined in math.h and use
the real functions instead.

* wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Fix test expectations for ietestcenter/css3/grid/grid-items-003.htm
benjamin@webkit.org [Tue, 9 Apr 2013 01:06:55 +0000 (01:06 +0000)]
[Mac] Fix test expectations for ietestcenter/css3/grid/grid-items-003.htm

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08

* platform/mac-wk2/TestExpectations: The test pass on WebKit2 Mountain Lion Release builds.
* platform/mac/TestExpectations: The test is flaky on Mountain Lion Release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac][WebKit2] fast/css/sticky/sticky-top-zoomed.html is flaky on Mountain Lion
benjamin@webkit.org [Tue, 9 Apr 2013 00:50:36 +0000 (00:50 +0000)]
[Mac][WebKit2] fast/css/sticky/sticky-top-zoomed.html is flaky on Mountain Lion

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
The test is flaky on MountainLion for WebKit1 and WebKit2. It fails systematically
in Debug or on older OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTests for exceptions of type DOMException.TYPE_ERR in encrypted-media-syntax.html...
commit-queue@webkit.org [Tue, 9 Apr 2013 00:45:28 +0000 (00:45 +0000)]
Tests for exceptions of type DOMException.TYPE_ERR in encrypted-media-syntax.html are broken
https://bugs.webkit.org/show_bug.cgi?id=113119

Renames testException() to testDOMException() and tweaks the check.
Also adds a new testException() helper for checking non-DOM exceptions.

Patch by Steve Block <steveblock@chromium.org> on 2013-04-08
Reviewed by Darin Adler.

* media/encrypted-media/encrypted-media-not-loaded.html:
* media/encrypted-media/encrypted-media-syntax-expected.txt:
* media/encrypted-media/encrypted-media-syntax.html:
* media/encrypted-media/encrypted-media-v2-syntax.html:
* media/media-fullscreen.js:
(buttonClickHandler):
(canplaythrough):
* media/track/track-add-remove-cue.html:
* media/track/track-addtrack-kind.html:
* media/track/track-cue-mutable.html:
* media/video-buffered.html:
* media/video-play-require-user-gesture.html:
* media/video-seek-no-src-exception.html:
* media/video-seekable.html:
* media/video-test.js:
(testDOMException):
* media/video-volume.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip async plugin test while fixing the failure.
beidson@apple.com [Tue, 9 Apr 2013 00:39:31 +0000 (00:39 +0000)]
Skip async plugin test while fixing the failure.
https://bugs.webkit.org/show_bug.cgi?id=114217

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBug 110293 uses read -d which is a non-portable bashism
mrobinson@webkit.org [Tue, 9 Apr 2013 00:31:54 +0000 (00:31 +0000)]
Bug 110293 uses read -d which is a non-portable bashism
https://bugs.webkit.org/show_bug.cgi?id=113349

Reviewed by Gustavo Noronha Silva.

* Source/autotools/SetupWebKitFeatures.m4: Pass the default feature set to the
feature script in a more portable way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove chromium EWS support, and fix broken test.
glenn@skynav.com [Tue, 9 Apr 2013 00:22:33 +0000 (00:22 +0000)]
Remove chromium EWS support, and fix broken test.
https://bugs.webkit.org/show_bug.cgi?id=114221

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractChromiumEWS): Removed.
(ChromiumLinuxEWS): Removed.
(ChromiumLinuxDebugEWS): Removed.
(ChromiumWindowsEWS): Removed.
(ChromiumAndroidEWS): Removed.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest): Fix misspelled class name.
(test_ewses): Fix entry point name to ensure test is run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG should be able to inline string equality comparisons
fpizlo@apple.com [Tue, 9 Apr 2013 00:10:16 +0000 (00:10 +0000)]
DFG should be able to inline string equality comparisons
https://bugs.webkit.org/show_bug.cgi?id=114224

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Inline 8-bit string equality, go to slow path for 16-bit strings. 2x speed-up for string equality
comparisons on 8-bit strings. 20-50% speed-up on JSRegress/HashMap tests. 30% speed-up on
string-fasta. 2% speed-up on SunSpider overall. Some small speed-ups elsewhere.

This is a gnarly change but we have loads of test coverage already between the HashMap tests and
preexisting DFG string equality tests (which appear to have been designed to test OSR exits, but
also give us good overall coverage on string equality behavior).

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):

LayoutTests:

Reviewed by Oliver Hunt.

* fast/js/regress/script-tests/string-equality.js: Added.
(foo):
* fast/js/regress/string-equality-expected.txt: Added.
* fast/js/regress/string-equality.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't run primary plugin detection if plugin snapshotting is off
timothy_horton@apple.com [Mon, 8 Apr 2013 23:59:24 +0000 (23:59 +0000)]
Don't run primary plugin detection if plugin snapshotting is off
https://bugs.webkit.org/show_bug.cgi?id=114222
<rdar://problem/13603988>

Reviewed by Dean Jackson.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WIN] Remove WebKit2 source code
paroga@webkit.org [Mon, 8 Apr 2013 23:53:51 +0000 (23:53 +0000)]
[WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096

Reviewed by Anders Carlsson.

Source/WebKit2:

Remove conditional includes for the windows platform.

* Shared/API/c/WKBase.h:
* UIProcess/API/C/WKAPICast.h:

Tools:

Remove the windows specific parts of the MiniBrowser.

* MiniBrowser/MiniBrowser.vcproj: Removed.
* MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
* MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
* MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
* MiniBrowser/win/BrowserView.cpp: Removed.
* MiniBrowser/win/BrowserView.h: Removed.
* MiniBrowser/win/BrowserWindow.cpp: Removed.
* MiniBrowser/win/BrowserWindow.h: Removed.
* MiniBrowser/win/MiniBrowser.cpp: Removed.
* MiniBrowser/win/MiniBrowser.h: Removed.
* MiniBrowser/win/MiniBrowser.rc: Removed.
* MiniBrowser/win/main.cpp: Removed.
* MiniBrowser/win/resource.h: Removed.
* MiniBrowser/win/stdafx.cpp: Removed.
* MiniBrowser/win/stdafx.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop #include-ing all of JavaScriptCore in every DOM-related file
ggaren@apple.com [Mon, 8 Apr 2013 23:41:02 +0000 (23:41 +0000)]
Stop #include-ing all of JavaScriptCore in every DOM-related file
https://bugs.webkit.org/show_bug.cgi?id=114220

Reviewed by Sam Weinig.

../JavaScriptCore:

I separated WeakInlines.h from Weak.h so WebCore data types that need
to declare a Weak<T> data member don't have to #include all of the
infrastructure for accessing that data member.

This also required separating Weak<T> from PassWeak<T> by removing the
WeakImplAccessor class template and pushing code down into its subclasses.

* API/JSWeakObjectMapRefPrivate.cpp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/UnlinkedCodeBlock.h:
* heap/PassWeak.h:
(JSC):
(PassWeak):
(JSC::::PassWeak):
(JSC::::operator):
(JSC::::get):
* heap/SlotVisitorInlines.h:
* heap/Weak.h:
(JSC):
(Weak):
* heap/WeakInlines.h: Copied from Source/JavaScriptCore/heap/Weak.h.
(JSC):
(JSC::::Weak):
(JSC::::operator):
(JSC::::get):
(JSC::::was):
(JSC::weakClear):
* jit/JITThunks.h:
* runtime/RegExpCache.h:
* runtime/Structure.h:
* runtime/WeakGCMap.h:

../WebCore:

I separated ScriptWrappableInlines.h from ScriptWrappable.h so
WebCore data types that inherit from ScriptWrappable don't
have to #include all of the infrastructure for accessing that data member.

* ForwardingHeaders/heap/PassWeak.h: Added.
* ForwardingHeaders/heap/WeakInlines.h: Added.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMWrapperWorld.h:
* bindings/js/JSDOMBinding.h:
(JSC):
* bindings/js/JSEventListener.h:
* bindings/js/JSMutationCallback.cpp:
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/ScriptWrappable.h:
(JSC):
(WebCore):
(ScriptWrappable):
* bindings/js/ScriptWrappableInlines.h: Added.
(WebCore):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):
* bridge/qt/qt_instance.h:
* bridge/qt/qt_runtime.h:
* bridge/runtime_root.cpp:
* bridge/runtime_root.h:
* css/StylePropertySet.cpp:
* dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* inspector/InspectorDebuggerAgent.cpp:
* inspector/NetworkResourcesData.cpp:
* loader/cache/CachedSVGDocument.cpp:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):

../WebKit2:

* Shared/WebCoreArgumentCoders.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac][WebKit2] The test images-enabled-unset-can-block-image-and-can-reload-in-place...
benjamin@webkit.org [Mon, 8 Apr 2013 23:27:25 +0000 (23:27 +0000)]
[Mac][WebKit2] The test images-enabled-unset-can-block-image-and-can-reload-in-place.html passes

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08

* platform/mac-wk2/TestExpectations:
This test have been passing reliably for many revisions and pass locally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Update BlackBerry JavaScript API
commit-queue@webkit.org [Mon, 8 Apr 2013 23:18:01 +0000 (23:18 +0000)]
[BlackBerry] Update BlackBerry JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=114065

Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-08
Reviewed by Rob Buis.

.:

Internal PR 317350
Export JSC symbols in BlackBerry build.

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit:

Internal PR 317350
Remove obsolete files.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Internal PR 317350
Add new API for determining if user gesture is being processed.
Remove obsolete files.
Properly expose JSC global context.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(BlackBerry::WebKit::WebPage::globalContext):
(BlackBerry::WebKit::WebPage::isProcessingUserGesture):
(WebKit):
* Api/WebPage.h:
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
* WebCoreSupport/ClientExtension.cpp: Removed.
* WebCoreSupport/ClientExtension.h: Removed.
* WebCoreSupport/ExternalExtension.cpp: Removed.
* WebCoreSupport/ExternalExtension.h: Removed.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate the Mac WebKit2 TestExpectations for http/tests/canvas/canvas-slow-font-loadin...
benjamin@webkit.org [Mon, 8 Apr 2013 23:01:59 +0000 (23:01 +0000)]
Update the Mac WebKit2 TestExpectations for http/tests/canvas/canvas-slow-font-loading.html

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08

* platform/mac-wk2/TestExpectations: The test is flaky in release. Mark it as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Clean up render theme code.
commit-queue@webkit.org [Mon, 8 Apr 2013 22:46:12 +0000 (22:46 +0000)]
[BlackBerry] Clean up render theme code.
https://bugs.webkit.org/show_bug.cgi?id=114216

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-08
Reviewed by Rob Buis.

BlackBerry PR 323062

Clean up redundant code.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse port 6665 instead of 6667 since the latter doesn't seem to work well.
rniwa@webkit.org [Mon, 8 Apr 2013 22:19:50 +0000 (22:19 +0000)]
Use port 6665 instead of 6667 since the latter doesn't seem to work well.

* Scripts/webkitpy/common/config/irc.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCall Netscape Plugin's toString() and valueOf() instead of providing default implemen...
andersca@apple.com [Mon, 8 Apr 2013 22:05:24 +0000 (22:05 +0000)]
Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
https://bugs.webkit.org/show_bug.cgi?id=113139

Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-08
Reviewed by Anders Carlsson.

Source/WebCore:

Tests: plugins/npruntime/tostring.html
       plugins/npruntime/valueof.html

* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::~CInstance):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(Bindings):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::stringValue):
(JSC::Bindings::CInstance::booleanValue):
(JSC::Bindings::CInstance::valueOf):
(JSC::Bindings::CInstance::toJSPrimitive):
* bridge/c/c_instance.h:
(CInstance):

Tools:

* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
(ToStringAndValueOfObject):
(ToStringAndValueOfObject::ToStringAndValueOfObject):
(ScriptableObject):
(ToStringAndValueOfObject::ScriptableObject::hasMethod):
(ToStringAndValueOfObject::ScriptableObject::invoke):
(ToStringAndValueOfObject::ScriptableObject::pluginTest):
(ToStringAndValueOfObject::NPP_GetValue):
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:

LayoutTests:

* platform/qt-mac/TestExpectations:
* platform/wk2/TestExpectations:
* plugins/npruntime/tostring-expected.txt: Added.
* plugins/npruntime/tostring.html: Added.
* plugins/npruntime/valueof-expected.txt: Added.
* plugins/npruntime/valueof.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r138858): Crash in WebCore::FrameLoader::~FrameLoader() when opening...
timothy_horton@apple.com [Mon, 8 Apr 2013 21:43:15 +0000 (21:43 +0000)]
REGRESSION (r138858): Crash in WebCore::FrameLoader::~FrameLoader() when opening page in a background tab
https://bugs.webkit.org/show_bug.cgi?id=109935
<rdar://problem/13225963>

Reviewed by Brady Eidson.

Previously, we were deciding if a Page could go into
the PageCache by blacklisting certain load types. Instead,
whitelist the load types that we know can go into the cache,
so that newly-added load types are not cached unless
that is explicitly desired.

The crash occurs when a page which is actively loading
is put into the page cache while doing a redirect with
FrameLoadTypeRedirectWithLockedBackForwardList (note that
this is a redirect that was not covered in the blacklist),
and then promptly removed from the page cache, resulting
in resources from the redirect target (the now-active page)
being incorrectly destroyed.

No new tests, only known crash repro case is extremely
timing dependent (and only happens in WebKit2, with tiled
drawing, in background tabs).

* history/PageCache.cpp:
(WebCore::PageCache::canCache):

Adjust a test which depended on slow-redirects going
into the page cache (which will no longer happen)
to instead click on a link.

* fast/history/timed-refresh-in-cached-frame.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
andersca@apple.com [Mon, 8 Apr 2013 21:41:30 +0000 (21:41 +0000)]
Fix build.

* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::continueDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb/Plugin process deadlock initializing async plugins.
beidson@apple.com [Mon, 8 Apr 2013 21:31:52 +0000 (21:31 +0000)]
Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217

Reviewed by Anders Carlsson.

       The "Async initialization complete" messages probably don't have to be synchronous.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously): Notify of initialization success/failure asynchronously.
* WebProcess/Plugins/PluginProxy.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd an async version of ResourceHandle::didReceiveResponse
andersca@apple.com [Mon, 8 Apr 2013 21:24:33 +0000 (21:24 +0000)]
Add an async version of ResourceHandle::didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=114215

Reviewed by Sam Weinig.

Source/WebCore:

In order to support converting NSURLConnections to NSURLDownloads when using the network process
we need an async version of didReceiveResponse.

* WebCore.exp.in:
* platform/network/ResourceHandleClient.cpp:
(WebCore::ResourceHandleClient::didReceiveResponseAsync):
Just call continueDidReceiveResponse().

* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::continueWillSendRequest):
Split up a single condition in two, making it easier to see which assertion fails.

(WebCore::ResourceHandle::continueDidReceiveResponse):
Call -[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse].

(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):
Split up a single condition in two, making it easier to see which assertion fails.

* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse]):
Signal the semaphore.

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
Call didReceiveResponseAsync on the main thread and wait on the semaphore.

Source/WebKit2:

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Send the message and then call continueDidReceiveResponse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Configure should verify ICU is installed on mingw
commit-queue@webkit.org [Mon, 8 Apr 2013 21:07:45 +0000 (21:07 +0000)]
[GTK] Configure should verify ICU is installed on mingw
https://bugs.webkit.org/show_bug.cgi?id=113645

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-04-08
Reviewed by Gustavo Noronha Silva.

* Source/autotools/FindDependencies.m4: When falling back to hard-coded compiler flags
for ICU and mingw, check that headers do exist on the system and error out otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWindows build fix fix.
roger_fong@apple.com [Mon, 8 Apr 2013 21:01:50 +0000 (21:01 +0000)]
Windows build fix fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in ScrollingCoordinator::mainThreadScrollingReasons() when going back
bdakin@apple.com [Mon, 8 Apr 2013 21:00:12 +0000 (21:00 +0000)]
Crash in ScrollingCoordinator::mainThreadScrollingReasons() when going back
https://bugs.webkit.org/show_bug.cgi?id=114214
-and corresponding-
<rdar://problem/13208616>

Reviewed by Anders Carlsson.

When a page is restoring from the page cache, the mainFrame can have a null
Document. So we should null-check the Document here.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWindows build fix.
roger_fong@apple.com [Mon, 8 Apr 2013 20:51:40 +0000 (20:51 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake resolve more robust in the face of lookup misses
oliver@apple.com [Mon, 8 Apr 2013 20:25:13 +0000 (20:25 +0000)]
Make resolve more robust in the face of lookup misses
https://bugs.webkit.org/show_bug.cgi?id=114211

Reviewed by Filip Pizlo.

This simply short circuits the resolve operations in the
event that we don't find a path to a property.  There's no
repro case for this happening unfortunately.

* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Bump gnome-themes-standard to 3.6.0
commit-queue@webkit.org [Mon, 8 Apr 2013 20:09:17 +0000 (20:09 +0000)]
[GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-08
Reviewed by Martin Robinson.

* gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
dependency of gnome-themes-standard accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] More null checks for m_mainFrame
commit-queue@webkit.org [Mon, 8 Apr 2013 20:05:42 +0000 (20:05 +0000)]
[BlackBerry] More null checks for m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=114172

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.

After r147744, some unit tests were crashing on WebPage
shutdown, because BackingStorePrivate::repaint() now uses
pixelContentsRect() (accessing m_webPage->contentsRect())
instead of BackingStoreClient::contentsRect(). In m_webPage,
m_mainFrame had already been set to 0.

Make us more robust against these errors by checking
the existence of m_mainFrame more diligently.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
(BlackBerry::WebKit::WebPagePrivate::contentsSize):
(BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
(BlackBerry::WebKit::WebPagePrivate::setViewMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove my watchlist entries.
levin@chromium.org [Mon, 8 Apr 2013 19:35:52 +0000 (19:35 +0000)]
Remove my watchlist entries.
https://bugs.webkit.org/show_bug.cgi?id=114180

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Remove expected results added by r147824.
jer.noble@apple.com [Mon, 8 Apr 2013 19:18:47 +0000 (19:18 +0000)]
Unreviewed gardening. Remove expected results added by r147824.

* platform/mac-future/accessibility/press-action-is-first-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify ContainerNode::removeChildren
abucur@adobe.com [Mon, 8 Apr 2013 19:10:43 +0000 (19:10 +0000)]
Simplify ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=113517

Reviewed by Darin Adler.

The patch is based on the work made by Elliott Sprehn. He kindly agreed
for me to finalize the last bits and pieces of the fix.

Source/WebCore:

Simplify ContainerNode::removeChildren by merging the loops and removing
willRemoveChildren. This removes two traversals of the children, avoids
refing and derefing all the children once, avoids allocating a second
NodeVector of children, and means we detach() in the same order as
normal removal.

This does mean you can get into an infinite loop with DOMNodeRemoved
listeners by continously adding nodes but this is true in all other browsers
and the current behavior is bad because it means you don't get notified
of nodes added during removal (which other browsers do notify of). This
patch removes the containerNode.html test that originally tested for this
infinite loop and adds a new one that tests that all nodes get notified.

This makes PerformanceTests/Parser/innerHTML-setter.html 2-6% faster.

There's also a new test verifying ranges remain consistent if modified
inside an mutation event handler. Without the patch it's possible to create
a range with boundaries outside of the DOM tree.

Tests: fast/dom/Range/range-remove-children-event.html
       fast/events/mutation-during-innerHTML.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
* dom/Document.cpp:
* dom/Document.h: nodeChildrenWillBeRemoved is not needed any more.
* dom/Range.cpp:
* dom/Range.h: nodeChildrenWillBeRemoved is not needed any more.

LayoutTests:

Remove containerNode.html test since it was checking for an infinite
loop when adding DOM nodes inside a DOMNodeRemoved mutation event
handler, but we actually do want to allow an infinite loop here for
correctness and compatability with other browsers.

Also added mutation-during-innerHTML which checks that all nodes
are notified of being removed even if they were added during the
DOMNodeRemoved notification.

There's a new test range-remove-children-event that verifies the
ranges modified inside a mutation event handler remain consistent.

* fast/dom/MutationObserver/added-out-of-order-expected.txt:
* fast/dom/MutationObserver/added-out-of-order.html:
* fast/dom/Range/range-remove-children-event-expected.txt: Added.
* fast/dom/Range/range-remove-children-event.html: Added.
* fast/dom/containerNode-expected.txt: Removed.
* fast/dom/containerNode.html: Removed.
* fast/events/mutation-during-innerHTML-expected.txt: Added.
* fast/events/mutation-during-innerHTML.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
oliver@apple.com [Mon, 8 Apr 2013 19:06:57 +0000 (19:06 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove some #includes in headers in rendering code
simon.fraser@apple.com [Mon, 8 Apr 2013 18:39:24 +0000 (18:39 +0000)]
Remove some #includes in headers in rendering code
https://bugs.webkit.org/show_bug.cgi?id=114079

Reviewed by Sam Weinig.

Clean up #includes in RenderObject, RenderLayer etc.
Moved makeMatrixRenderable() into RenderLayer.app, allowing
the removal of a TransformationMatrix.h include.

Make some RenderLayer functions that deal with filters not inline,
to avoid including RenderLayerFilterInfo.h.

* platform/graphics/GraphicsLayer.h:
* platform/graphics/ImageOrientation.cpp:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/transforms/AffineTransform.cpp:
* platform/graphics/transforms/AffineTransform.h:
* rendering/RenderBoxModelObject.h:
* rendering/RenderLayer.cpp:
(WebCore::makeMatrixRenderable):
(WebCore::RenderLayer::filterRenderer):
(WebCore::RenderLayer::filterInfo):
(WebCore::RenderLayer::ensureFilterInfo):
(WebCore::RenderLayer::removeFilterInfoIfNeeded):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.h:
* rendering/RenderLineBoxList.h:
* rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r147850.
robert@webkit.org [Mon, 8 Apr 2013 18:38:26 +0000 (18:38 +0000)]
Unreviewed, rolling out r147850.
http://trac.webkit.org/changeset/147850
https://bugs.webkit.org/show_bug.cgi?id=113706

Changeset crossed paths with 147505, which is the same fix.

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):

LayoutTests:

* fast/inline/inline-with-empty-inline-children-expected.txt:
* fast/inline/inline-with-empty-inline-children.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago <rdar://problem/12834449> Crashes in WebSocketChannel::processFrame when...
ap@apple.com [Mon, 8 Apr 2013 18:17:19 +0000 (18:17 +0000)]
    <rdar://problem/12834449> Crashes in WebSocketChannel::processFrame when processing a ping
        https://bugs.webkit.org/show_bug.cgi?id=114178

        Reviewed by Brady Eidson.

        No test, I could never reproduce even manually.

        Calling enqueueRawFrame() could change incoming buffer, so a subsequent skipBuffer()
        would operate on wrong assumptions. This happened because enqueueRawFrame() actually
        tried to process the queue, and send failure sometimed clears m_buffer.

        Fixing this by decoupling enqueuing from sending, and making sure that skipBuffer()
        in ping frame processing case is performed at a safe time.

        * Modules/websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::send):
        (WebCore::WebSocketChannel::startClosingHandshake):
        (WebCore::WebSocketChannel::processFrame):
        (WebCore::WebSocketChannel::enqueueTextFrame):
        (WebCore::WebSocketChannel::enqueueRawFrame):
        (WebCore::WebSocketChannel::enqueueBlobFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r147502): Animations of CA filters broken
mvujovic@adobe.com [Mon, 8 Apr 2013 18:09:01 +0000 (18:09 +0000)]
REGRESSION (r147502): Animations of CA filters broken
https://bugs.webkit.org/show_bug.cgi?id=114067

Reviewed by Dean Jackson.

Revert r147502 [1] because it broke CA filter animations.

[1]: http://trac.webkit.org/changeset/147502

Source/WebCore:

* platform/graphics/IntRectExtent.h:
(WebCore::IntRectExtent::isZero):
(IntRectExtent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::needsCompositingLayersRebuiltForOverflow):
(WebCore):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateFilters):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

Source/WTF:

* wtf/Platform.h:

LayoutTests:

* compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
* compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
* compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
* compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
* css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Removed.
* css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Removed.
* css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Removed.
* css3/filters/composited-layer-bounds-with-composited-blur.html: Removed.
* css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Removed.
* css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Removed.
* css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Removed.
* css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Removed.
* css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Removed.
* css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Removed.
* css3/filters/filter-change-repaint-composited-expected.png:
* css3/filters/filter-change-repaint-composited.html:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Force horizontal list to be horizontal scrollable.
commit-queue@webkit.org [Mon, 8 Apr 2013 17:54:03 +0000 (17:54 +0000)]
[BlackBerry] Force horizontal list to be horizontal scrollable.
https://bugs.webkit.org/show_bug.cgi?id=114173

Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.

Force content to be horizontal/vertical overscrollable if it
scrolls in horizontal/vertical way.

PR 237440
Internally Reviewed by Arvid Nilsson.

* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow KeywordLookupGenerator.py to work on Windows with Windows style line endings
commit-queue@webkit.org [Mon, 8 Apr 2013 17:51:01 +0000 (17:51 +0000)]
Allow KeywordLookupGenerator.py to work on Windows with Windows style line endings
https://bugs.webkit.org/show_bug.cgi?id=63234

Patch by Justin Haygood <jhaygood@reaktix.com> on 2013-04-08
Reviewed by Oliver Hunt.

* KeywordLookupGenerator.py:
(parseKeywords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/JavaScriptCore: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT...
fpizlo@apple.com [Mon, 8 Apr 2013 17:48:28 +0000 (17:48 +0000)]
Source/JavaScriptCore: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129
<rdar://problem/13594898>

Reviewed by Darin Adler.

The check to see if we need a cell check when simplifying a GetById or PutById needs to be hoisted to
above where we abstractly execute the instruction, since after we abstracting execute it, it will
seem like it no longer needs the cell check.

* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):

LayoutTests: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129 and https://bugs.webkit.org/show_bug.cgi?id=90649
<rdar://problem/13594898> and <rdar://problem/11815727>

Reviewed by Darin Adler.

Unskip these tests because they give us DFG coverage and they are now passing.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Avoid "QFont::setPixelSize: Pixel size <= 0 (0)"
jocelyn.turcotte@digia.com [Mon, 8 Apr 2013 17:46:55 +0000 (17:46 +0000)]
[Qt] Avoid "QFont::setPixelSize: Pixel size <= 0 (0)"
https://bugs.webkit.org/show_bug.cgi?id=114175

Reviewed by Allan Sandfeld Jensen.

QFont doesn't support a 0-size but WebCore does.
Leave our QFont in its default state in this case to avoid the warning.

* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCounter still gets incremented when counter-increment is set to none
commit-queue@webkit.org [Mon, 8 Apr 2013 17:41:06 +0000 (17:41 +0000)]
Counter still gets incremented when counter-increment is set to none
https://bugs.webkit.org/show_bug.cgi?id=84985

Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-08
Reviewed by Darin Adler.

When the counter-increment is set to none, no counters are incremented.

Source/WebCore:

Tests: New test cases added in fast/css/counters/counter-increment-tests.htm

* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyCounter::applyValue):

LayoutTests:

* fast/css/counters/counter-increment-tests-expected.txt: Added new test cases.
* fast/css/counters/counter-increment-tests.htm: Added new test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r147894): Broke WTFReportBacktrace() on Mac.
akling@apple.com [Mon, 8 Apr 2013 17:37:55 +0000 (17:37 +0000)]
REGRESSION(r147894): Broke WTFReportBacktrace() on Mac.
<http://webkit.org/b/114174>

Reviewed by Anders Carlsson.

An #elif !OS(ANDROID) block was erroneously removed, turn it into an #else instead since
that path will still be taken for OS(DARWIN).

* wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in WebCore::ElementRuleCollector::collectMatchingRulesForList
commit-queue@webkit.org [Mon, 8 Apr 2013 17:26:01 +0000 (17:26 +0000)]
Crash in WebCore::ElementRuleCollector::collectMatchingRulesForList
https://bugs.webkit.org/show_bug.cgi?id=113458

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-04-08
Reviewed by Darin Adler.

Source/WebCore:

A stylesheet which has been invalidated (type changed from "" or
"text/css") was not correctly removed from the list of active
style sheets when its children are changed.

This change releases StyleElement::m_sheet in advance of calling
DocumentStyleSheetCollection::updateActiveStyleSheets.

(StyleElement::clearSheet calls CSSStyleSheet::clearOwnerNode calls
CSSStyleSheet::didMutate calls Document::styleResolverChanged calls
DocumentStyleSheetCollection::updateActiveStyleSheets)

Test: fast/css/style-element-invalidation-crash.html

* dom/StyleElement.cpp:
(WebCore::StyleElement::clearSheet): Release m_sheet before we
  trigger an update of the active style sheets.

LayoutTests:

* fast/css/style-element-invalidation-crash-expected.txt: Added.
* fast/css/style-element-invalidation-crash.html: Added.
* fast/css/stylesheet.innerHTML-calls-didmutate.html: Removed.
* fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Build Platform as a separate static library
carlosgc@webkit.org [Mon, 8 Apr 2013 17:24:50 +0000 (17:24 +0000)]
[GTK] Build Platform as a separate static library
https://bugs.webkit.org/show_bug.cgi?id=114164

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Add webkit2platform_sources definition.

Source/WebKit2:

This way we reduce a bit the amount of files compiled twice
because of the plugin process.

* GNUmakefile.am:
* GNUmakefile.list.am:
* Platform/gtk/WorkQueueGtk.cpp: Remove unused header.
* Platform/unix/SharedMemoryUnix.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrac...
graouts@apple.com [Mon, 8 Apr 2013 17:23:37 +0000 (17:23 +0000)]
Stop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
https://bugs.webkit.org/show_bug.cgi?id=104255

Updated test to match the one hosted by W3C which has corrected the reported error.

Reviewed by Eric Carlson.

* media/track/opera/interfaces/TextTrack/cues-expected.txt:
* media/track/opera/interfaces/TextTrack/cues.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] DOM objects created wrapping a base class have incorrect GObject type
carlosgc@webkit.org [Mon, 8 Apr 2013 17:20:32 +0000 (17:20 +0000)]
[GTK] DOM objects created wrapping a base class have incorrect GObject type
https://bugs.webkit.org/show_bug.cgi?id=113132

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Some of the DOM methods can create a concrete instance of another
object, but return a base class. GObject bindings provide custom
kit implementations for Node, Element, Event and EvenTarget, so
any concrete HTMLElement wrapped as an HTMLElement ends up
wrapping the right WebCore object but in the wrong GObject type.
This affects not only HTMLElements, but any polymorphic object
wrapped using a base class.
This patch changes the way objects are created, so that all
classes have their own kit implementation, but for polymorphic
objects the kit implementation of the base class is always
used. The kit method of polymorphic base classes use a generic
wrap method instead of the wrapFoo method like all other
classes. In the static code we provide the implementation of the
generic wrap method for every polimorphic base class, falling back
to their wrapFoo method if the concrete object can't be used to
wrap the object.
Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
implementations of wrap and have been renamed to WebKitDOMPrivate
and WebKitDOMHTMLPrivate.

* bindings/gobject/GNUmakefile.am:
* bindings/gobject/WebKitDOMBinding.cpp: Removed.
* bindings/gobject/WebKitDOMEventTarget.cpp:
(WebKit::kit): Moved kit implementation from WebKitDOMBinding for
consistency with all other objects that have their own kit.
(WebKit::core): Updated to match the core implementation fo all
other objects.
* bindings/gobject/WebKitDOMEventTargetPrivate.h:
(WebCore):
(WebKit):
* bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.
(WebKit): Use preprocessor macros to define and set the wrap
functions of all HTML elements, removing a lot of boilerplate code
and making it easier to add new wrap functions in the future.
(WebKit::wrap):
* bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.
(WebCore):
(WebKit):
* bindings/gobject/WebKitDOMObject.cpp:
* bindings/gobject/WebKitDOMPrivate.cpp: Added.
(WebKit):
(WebKit::wrap):
* bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.
(WebCore):
(WebKit):
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
* bindings/scripts/CodeGeneratorGObject.pm:
(IsBaseType): Helper function to check if a type is a base class.
(GetBaseClass): Helper function to get the base class for a given
parent type.
(GenerateFunction): Remove special case for EventTarget since the
kit prototype of EventTarget is in its private header like all
other objects.
(GenerateCFile): Add a kit implementation for all objects.
(IsPolymorphic): Helper function to check if the given type is the
base class of a polymorphic object.
(Generate): Include the private header of the base class for
polymorphic objects.
(WriteData): Remove the special case for WebKitDOMNode since now
all objects has a kit method.
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::kit):
* bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
(WebKit):
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:
(WebKit):

Source/WebKit/gtk:

Remove WebKitDOMBindindg.h include from several files because it's
been renamed and it was not actually needed.

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/EditorClientGtk.cpp:
* webkit/webkithittestresult.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build with strict GCC 4.8
abecsi@webkit.org [Mon, 8 Apr 2013 17:04:30 +0000 (17:04 +0000)]
Fix the build with strict GCC 4.8

Unreviewed build fix.

Initialize dragImage to suppress GCC's warning about it being possibly used uninitialized,
which results is a build failure with GCC 4.8 that sets -Werror=maybe-uninitialized.

No new tests needed.

* page/DragController.cpp:
(WebCore::DragController::doImageDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the unused LayoutTestSupport class
zandobersek@gmail.com [Mon, 8 Apr 2013 16:52:09 +0000 (16:52 +0000)]
Remove the unused LayoutTestSupport class
https://bugs.webkit.org/show_bug.cgi?id=114170

Reviewed by Alexey Proskuryakov.

The LayoutTestSupport class is not used by any port anywhere in the code and should be removed.

No new tests - no changes in functionality.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/LayoutTestSupport.cpp: Removed.
* platform/LayoutTestSupport.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove WebCore::(enable|disable)SecureTextInput methods
zandobersek@gmail.com [Mon, 8 Apr 2013 16:51:01 +0000 (16:51 +0000)]
Remove WebCore::(enable|disable)SecureTextInput methods
https://bugs.webkit.org/show_bug.cgi?id=114126

Reviewed by Alexey Proskuryakov.

Remove the enableSecureTextInput and disableSecureTextInput methods and all the codepaths leading to them.
These were used only by the Chromium port and are as such not required anymore.

No new tests - no changes in functionality.

* GNUmakefile.list.am:
* WebCore.order:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(Document):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::focusedOrActiveStateChanged):
* editing/FrameSelection.h:
(FrameSelection):
* html/PasswordInputType.cpp:
* html/PasswordInputType.h:
(PasswordInputType):
* page/Frame.cpp:
(WebCore::Frame::setDocument):
* platform/SecureTextInput.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix; r147892 moved an export definition out of
jer.noble@apple.com [Mon, 8 Apr 2013 16:29:51 +0000 (16:29 +0000)]
Unreviewed build fix; r147892 moved an export definition out of
a protective #ifdef, causing a link error on platforms which do
not define that method.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
oliver@apple.com [Mon, 8 Apr 2013 16:26:00 +0000 (16:26 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Enable text tracks from track elements
commit-queue@webkit.org [Mon, 8 Apr 2013 16:13:47 +0000 (16:13 +0000)]
[Qt] Enable text tracks from track elements
https://bugs.webkit.org/show_bug.cgi?id=113522

Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-08
Reviewed by Jocelyn Turcotte.

No new tests because they're already there. This just enables the feature.

* Target.pri:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Toggle OverWrite mode when pressing the Insert key
sergio@webkit.org [Mon, 8 Apr 2013 16:05:52 +0000 (16:05 +0000)]
[GTK] Toggle OverWrite mode when pressing the Insert key
https://bugs.webkit.org/show_bug.cgi?id=113384

Reviewed by Martin Robinson.

Perform an OverWrite command as a response to the emission of the
toggle-overwrite signal. Due to the nature of the command it will
only do that when being on a richly editable web content.

* platform/gtk/KeyBindingTranslator.cpp:
(WebCore::toggleOverwriteCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Provide more specific error description for SocketStreamError
commit-queue@webkit.org [Mon, 8 Apr 2013 15:30:04 +0000 (15:30 +0000)]
[BlackBerry] Provide more specific error description for SocketStreamError
https://bugs.webkit.org/show_bug.cgi?id=114134

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-08
Reviewed by Rob Buis.

Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().

* platform/network/blackberry/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::notifyStatusReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][EFL] HEAD requests changed to GET after 303 redirection
commit-queue@webkit.org [Mon, 8 Apr 2013 15:26:39 +0000 (15:26 +0000)]
[GTK][EFL] HEAD requests changed to GET after 303 redirection
https://bugs.webkit.org/show_bug.cgi?id=110127

Patch by Youenn Fablet <youennf@gmail.com> on 2013-04-08
Reviewed by Martin Robinson.

Source/WebCore:

Made shouldRedirectAsGET always return false for HEAD requests.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::shouldRedirectAsGET):

LayoutTests:

Added tests checking HEAD redirection.
Redirected HEAD requests are expected to remain HEAD requests.
(http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-21#section-7.4)

* http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
* http/tests/xmlhttprequest/head-redirection.html: Added.
* http/tests/xmlhttprequest/resources/get_method.php: Added.
* http/tests/xmlhttprequest/resources/redirect_methods.php: Added.
* platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][EFL] WebView: Add callbacks to the WKViewClient to remove direct access to...
mikhail.pozdnyakov@intel.com [Mon, 8 Apr 2013 14:49:47 +0000 (14:49 +0000)]
[WK2][EFL] WebView: Add callbacks to the WKViewClient to remove direct access to page viewport controller
https://bugs.webkit.org/show_bug.cgi?id=110741

Reviewed by Anders Carlsson.

Provided WKViewClient with didRequestScroll, didRenderFrame and didCompletePageTransition
callbacks so that direct access from WebView to page viewport controller is avoided.

Implementation of callbacks is also added to keep the current EFL WK2 functionality.

* UIProcess/API/C/efl/WKView.h:
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

    Moved here code from deleted WebView::didCommitLoad.

* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::ViewClientEfl):
* UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
* UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
* UIProcess/efl/WebViewClient.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDragImage should not depend on Frame and CachedImage
carlosgc@webkit.org [Mon, 8 Apr 2013 13:35:18 +0000 (13:35 +0000)]
DragImage should not depend on Frame and CachedImage
https://bugs.webkit.org/show_bug.cgi?id=21357

Reviewed by Sam Weinig.

Remove Frame and CachedImage dependencies from DragImage.

* dom/Clipboard.h:
(WebCore): Add forward delcaration for CacheImage since it's not
included anymore in DragImage.h.
* page/DragController.cpp:
(WebCore::DragController::startDrag): Use
Frame::dragImageForSelection() and call
dissolveDragImageToFraction() for the returned DragImage. Pass the
font rendering mode to createDragImageForLink, instead of a Frame
that is only used to get the font rendering mode.
(WebCore::DragController::doImageDrag): Get the suggested filename
for the cached image and pass it to
createDragImageIconForCachedImageFilename().
* platform/DragImage.cpp:
(WebCore::createDragImageForLink): Receive a FontRenderingMode
instead of a Frame.
* platform/DragImage.h:
(WebCore): Remove createDragImageForSelection, change
createDragImageForLink to receive a FontRenderingMode instead of a
frame, and rename createDragImageIconForCachedImage as
createDragImageIconForCachedImageFilename since it nows received
the suggested filename of the cached image.
* platform/blackberry/DragImageBlackBerry.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
* platform/efl/DragImageEfl.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
* platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
* platform/mac/DragImageMac.mm:
(WebCore::dissolveDragImageToFraction): Return early if the passed
image is NULL.
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
(WebCore::createDragImageForLink): Ditto.
* platform/qt/DragImageQt.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
(WebCore::createDragImageForLink): Ditto.
* platform/wx/DragImageWx.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] REGRESSION(r147743): Use the correct `operator new' override in RenderThemeEfl.
rakuco@webkit.org [Mon, 8 Apr 2013 13:11:06 +0000 (13:11 +0000)]
[EFL] REGRESSION(r147743): Use the correct `operator new' override in RenderThemeEfl.
https://bugs.webkit.org/show_bug.cgi?id=114166

Reviewed by Alexis Menard.

r147743 disabled GLOBAL_FAST_MALLOC_NEW on the EFL port, but this has
caused some pixel tests in WK1 to crash.

The problem stems from RenderThemeEfl::applyEdjeRTLState() directly
calling `operator new(size_t)' for some allocations.
RefCounted<RenderTheme>, on its turn, has a WTF_MAKE_FAST_ALLOCATED
call which adds some `operator new' overrides to the class. Our direct
calls in applyEdjeRTLState() made the scope resolution rules choose the
WTF_MAKE_FAST_ALLOCATED version (which uses FastMalloc's allocator),
while WTF::deleteOwnedPtr() calls the global `operator delete' (which
uses the system's free() implementation).

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeRTLState): Explicitly choose the
global `operator new' when calling it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed trivial buildfix after r147799.
ossy@webkit.org [Mon, 8 Apr 2013 12:57:40 +0000 (12:57 +0000)]
Unreviewed trivial buildfix after r147799.

Add an ifdef guard to ensure Qt uses its own monotonicallyIncreasingTime()
implemenation instead of the GLIB based one.

* wtf/CurrentTime.cpp:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] WebView's interactive property is not fully respected
abecsi@webkit.org [Mon, 8 Apr 2013 11:13:20 +0000 (11:13 +0000)]
[Qt][WK2] WebView's interactive property is not fully respected
https://bugs.webkit.org/show_bug.cgi?id=113066

Reviewed by Jocelyn Turcotte.

WK2 sign-off by Benjamin Poulain.

The QML WebView inherits the "interactive" property from Flickable
which is true by default, and disables the interaction with the
Flickable if set to false.
Resulting from the design of the WebView panning and flicking is
disabled by Flickable but to be consistent we also need to disable
double-tap gestures and pinch gestures since they would trigger
scale and position changes.

* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleDoubleTapEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Mark ShouldGoToBackForwardListItem API test as failing
ch.dumez@sisa.samsung.com [Mon, 8 Apr 2013 10:32:59 +0000 (10:32 +0000)]
[EFL] Mark ShouldGoToBackForwardListItem API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114161

Reviewed by Gyuyoung Kim.

Mark ShouldGoToBackForwardListItem API test as failing for EFL port
as it is crashing due to Bug 111074.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 8 Apr 2013 09:46:20 +0000 (09:46 +0000)]
Unreviewed EFL gardening.

Marked a few tests as failing.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK build fix.
zandobersek@gmail.com [Mon, 8 Apr 2013 09:39:02 +0000 (09:39 +0000)]
Unreviewed GTK build fix.

* Source/autotools/symbols.filter: Exporting a bunch of symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] WebPage: misc build fixes
commit-queue@webkit.org [Mon, 8 Apr 2013 09:27:27 +0000 (09:27 +0000)]
[BlackBerry] WebPage: misc build fixes
https://bugs.webkit.org/show_bug.cgi?id=114152

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Carlos Garcia Campos.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
(BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
(BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
(BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
Remove unused parameters.

(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPage::blockZoom):
Replace TAAUTO with TASTART (this changed in r120495).

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
r142220).

(BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
r113514).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Mon, 8 Apr 2013 09:27:13 +0000 (09:27 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk1/fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added after r147829.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 8 Apr 2013 09:02:02 +0000 (09:02 +0000)]
Unreviewed EFL gardening.

Mark fast/forms/select/popup-closes-on-blur.html as failing for EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Move some inspector tests to efl-wk1/TestExpectation
commit-queue@webkit.org [Mon, 8 Apr 2013 08:56:09 +0000 (08:56 +0000)]
[EFL] Move some inspector tests to efl-wk1/TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=114147

Unreviewed EFL gardening.

Some inspector tests fail on only EFL-WK1 since it does not support plugins yet.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-08

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
ch.dumez@sisa.samsung.com [Mon, 8 Apr 2013 08:54:36 +0000 (08:54 +0000)]
Unreviewed gardening.

Skip fast/harness/use-page-cache.html for WK2 as WKTR does not support
overriding WebKitUsesPageCachePreferenceKey yet.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 8 Apr 2013 08:46:20 +0000 (08:46 +0000)]
Unreviewed EFL gardening.

Mark new accessibility test introduced in r147801 as failing for EFL.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 8 Apr 2013 08:38:07 +0000 (08:38 +0000)]
Unreviewed EFL gardening.

Mark several ref tests as failure for EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression(r147893) Caused several editing tests to fail
benjamin@webkit.org [Mon, 8 Apr 2013 08:26:32 +0000 (08:26 +0000)]
Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143

Unreviewed.

* editing/deleting/delete-ligature-003-expected.txt:
* editing/deleting/delete-ligature-003.html:
* editing/selection/context-menu-text-selection-expected.txt:
* editing/selection/context-menu-text-selection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] rendering was broken when scrolled ewk_view_single
ryuan.choi@samsung.com [Mon, 8 Apr 2013 07:25:12 +0000 (07:25 +0000)]
[EFL] rendering was broken when scrolled ewk_view_single
https://bugs.webkit.org/show_bug.cgi?id=114135

Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-04-08
Reviewed by Gyuyoung Kim.

ewk_view_single use memcpy() to copy previous buffer for scrolling, but
memcpy() should not be used when source buffer and destination buffer are
overwrapped.

* ewk/ewk_view_single.cpp:
(_ewk_view_screen_move):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression(r147893) Caused several editing tests to fail
benjamin@webkit.org [Mon, 8 Apr 2013 06:53:14 +0000 (06:53 +0000)]
Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143

Patch by Christophe Dumez <ch.dumez@sisa.samsung.com> on 2013-04-07
Reviewed by Benjamin Poulain.

r147893 removed some Android code from WebCore but failed to update the
layout tests accordingly. This patch remove Android-specific tests from
several editing layout tests.

* editing/deleting/paragraph-in-preserveNewline-expected.txt:
* editing/deleting/paragraph-in-preserveNewline.html:
* editing/deleting/whitespace-pre-1-expected.txt:
* editing/deleting/whitespace-pre-1.html:
* editing/execCommand/script-tests/toggle-compound-styles.js:
* editing/execCommand/toggle-compound-styles-expected.txt:
* editing/selection/5354455-1-expected.txt:
* editing/selection/5354455-1.html:
* editing/selection/click-in-margins-inside-editable-div-expected.txt:
* editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
* editing/selection/extend-after-mouse-selection-expected.txt:
* editing/selection/extend-after-mouse-selection.html:
* editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
* editing/selection/programmatic-selection-on-mac-is-directionless.html:
* editing/selection/script-tests/click-in-margins-inside-editable-div.js:
* editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
* editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
* editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModify .gitignore file to remove entries for chromium generated files
vivek.vg@samsung.com [Mon, 8 Apr 2013 06:31:04 +0000 (06:31 +0000)]
Modify .gitignore file to remove entries for chromium generated files
https://bugs.webkit.org/show_bug.cgi?id=114141

Reviewed by Gyuyoung Kim.

* .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the android code from WebKit Template Framework
benjamin@webkit.org [Mon, 8 Apr 2013 06:20:12 +0000 (06:20 +0000)]
Remove the android code from WebKit Template Framework
https://bugs.webkit.org/show_bug.cgi?id=114138

Reviewed by Dirk Schulze.

* wtf/Assertions.cpp:
* wtf/Atomics.h:
* wtf/MathExtras.h:
* wtf/Platform.h:
* wtf/ThreadIdentifierDataPthreads.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the android code from WebCore
benjamin@webkit.org [Mon, 8 Apr 2013 04:20:38 +0000 (04:20 +0000)]
Remove the android code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114136

Reviewed by Anders Carlsson.

* WebCore.exp.in:
* dom/ViewportArguments.cpp:
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):
* editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
* editing/EditingBehaviorTypes.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongTap):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
* page/Settings.cpp:
(WebCore):
(WebCore::editingBehaviorTypeForPlatform):
* platform/graphics/FontCache.h:
(FontCache):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::getRenderStyleForStrike):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEditingBehavior):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd bounds checking for WTF::Vector::operator[]
oliver@apple.com [Mon, 8 Apr 2013 04:14:50 +0000 (04:14 +0000)]
Add bounds checking for WTF::Vector::operator[]
https://bugs.webkit.org/show_bug.cgi?id=89600

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Make a few JSC classes opt-out of release mode bounds checking.

* assembler/AssemblerBuffer.h:
(AssemblerBuffer):
* assembler/AssemblerBufferWithConstantPool.h:
(AssemblerBufferWithConstantPool):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::bytecodeOffset):
(JSC):
(JSC::replaceExistingEntries):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
(JSC::CodeBlock::callReturnIndexVector):
(JSC::CodeBlock::codeOrigins):
(RareData):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedEvalCodeBlock::adoptVariables):
(UnlinkedEvalCodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(CallArguments):
(JSC::BytecodeGenerator::instructions):
(BytecodeGenerator):
* bytecompiler/StaticPropertyAnalysis.h:
(JSC::StaticPropertyAnalysis::create):
(JSC::StaticPropertyAnalysis::StaticPropertyAnalysis):
(StaticPropertyAnalysis):
* bytecompiler/StaticPropertyAnalyzer.h:
(StaticPropertyAnalyzer):
(JSC::StaticPropertyAnalyzer::StaticPropertyAnalyzer):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* parser/ASTBuilder.h:
(ASTBuilder):
* runtime/ArgList.h:
(MarkedArgumentBuffer):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):

Source/WebCore:

Fix exports

* WebCore.exp.in:

Source/WTF:

Add a template parameter to Vector<> that controls whether
bounds checking is performed in release builds or not.
Defaults to crashing on overflow.

* wtf/Forward.h:
(WTF):
* wtf/Vector.h:
(WTF):
(Vector):
(WTF::Vector::at):
(WTF::Vector::removeLast):
(WTF::::Vector):
(WTF::=):
(WTF::::contains):
(WTF::::find):
(WTF::::reverseFind):
(WTF::::fill):
(WTF::::appendRange):
(WTF::::expandCapacity):
(WTF::::tryExpandCapacity):
(WTF::::resize):
(WTF::::shrink):
(WTF::::grow):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::append):
(WTF::::tryAppend):
(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):
(WTF::::appendVector):
(WTF::::insert):
(WTF::::prepend):
(WTF::::remove):
(WTF::::reverse):
(WTF::::releaseBuffer):
(WTF::::checkConsistency):
(WTF::deleteAllValues):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the android part of editing/selection/rtl-move-selection-right-left.html
benjamin@webkit.org [Mon, 8 Apr 2013 04:10:29 +0000 (04:10 +0000)]
Remove the android part of editing/selection/rtl-move-selection-right-left.html
https://bugs.webkit.org/show_bug.cgi?id=114137

Reviewed by Anders Carlsson.

* editing/selection/rtl-move-selection-right-left-expected.txt:
* editing/selection/rtl-move-selection-right-left.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify the page "Getting the Code" on WebKit.org
benjamin@webkit.org [Mon, 8 Apr 2013 01:09:50 +0000 (01:09 +0000)]
Simplify the page "Getting the Code" on WebKit.org
https://bugs.webkit.org/show_bug.cgi?id=113980

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-07
Reviewed by Sam Weinig.

* building/checkout.html:
Instead of interleaving instructions for Mac and Windows, just
copy the things that make sense and have two clear sections.

Also mention Linux, it is the exact same instructions as Mac OS X.

Make svn checkout the alternative to a download of the tarball. It is
almost impossible to do a svn checkout on slow networks nowadays.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDo not allocate static AtomicStrings when searching for alternate font names
benjamin@webkit.org [Mon, 8 Apr 2013 01:01:22 +0000 (01:01 +0000)]
Do not allocate static AtomicStrings when searching for alternate font names
https://bugs.webkit.org/show_bug.cgi?id=114110

Reviewed by Geoffrey Garen.

FontCache's alternateFamilyName does some font name substitutions
when a font is not found for a given name.

In the vast majority of cases, no substitutions are made and
alternateFamilyName returns the null atom.
Given the usage the function had a couple of problems:
-It created 6 static AtomicString.
-It did a case insensitive comparison with 6 differents strings
 before failing.

This patch aims at solving both issues.

Instead of creating all AtomicString statically, the alternate name
are simply created on the fly as needed. Because the operation is so
unfrequent, and it uses the fast constructor, doing so should not slow
down the function.

To avoid comparing the input to every string, every time, the length of
the input is first evaluated, and we only do the necessary string comparisons.

On x86_64, this reduces the binary size by 2128 bytes.

* platform/graphics/FontCache.cpp:
(WebCore::familyNameEqualIgnoringCase):
When comparing strings, we know:
-The family name is non null.
-The length of both strings is equal.
-The length is not null.
Make the comparison accordingly.

(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147889 268f45cc-cd09-0410-ab3c-d52691b4dbfc