WebKit-https.git
11 years agoWebCore:
jianli@chromium.org [Thu, 30 Jul 2009 01:10:06 +0000 (01:10 +0000)]
WebCore:

2009-07-29  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Adler.

        Workers need to throw an exception when presented with invalid URLs.
        https://bugs.webkit.org/show_bug.cgi?id=27770

        Tests covered by worker-constructor.html and worker-redirect.html.

        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::constructWorker):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * workers/Worker.cpp:
        (WebCore::Worker::Worker):
        * workers/Worker.h:
        (WebCore::Worker::create):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::importScripts):
        * workers/WorkerScriptLoader.cpp:
        (WebCore::WorkerScriptLoader::loadSynchronously):
        (WebCore::WorkerScriptLoader::loadAsynchronously):
        (WebCore::WorkerScriptLoader::createResourceRequest):
        * workers/WorkerScriptLoader.h:

LayoutTests:

2009-07-29  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Adler.

        Workers need to throw an exception when presented with invalid URLs.
        https://bugs.webkit.org/show_bug.cgi?id=27770

        Update worker-constructor.html and worker-redirect.html per the behavior change.

        * fast/workers/worker-constructor-expected.txt:
        * fast/workers/worker-constructor.html:
        * http/tests/workers/worker-redirect-expected.txt:
        * http/tests/workers/worker-redirect.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 30 Jul 2009 00:33:41 +0000 (00:33 +0000)]
2009-07-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        (REGRESSION: r46039) Should restore previous connections-per-host limit for non-http(s) hosts
        https://bugs.webkit.org/show_bug.cgi?id=27822 and <rdar://problem/7091659>

        * loader/loader.cpp:
        (WebCore::Loader::Host::servePendingRequests): For non-http(s) hosts, restore the previous behavior of
          only limiting connections while parsing and still trying to figure out stylesheet urls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Yong Li <yong.li@torchmobile.com>
staikos@webkit.org [Thu, 30 Jul 2009 00:17:41 +0000 (00:17 +0000)]
2009-07-29  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        WINCE PORT: Add WebCore/page/wince/FrameWince.cpp
        https://bugs.webkit.org/show_bug.cgi?id=27729

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
rniwa@webkit.org [Thu, 30 Jul 2009 00:13:50 +0000 (00:13 +0000)]
WebCore:

2009-07-29  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Justin Garcia.

        REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
        https://bugs.webkit.org/show_bug.cgi?id=27809

        The patch primarily rebaselines the tests but also fixes the bug in currentlyHasStyle.
        To determine that a particular text decoration is present, currentlyHasStyle should refer to
        -webkit-text-decorations-in-effect to take care of styles set by u, s, strike tags and ancestors' CSS.
        We also need to update layout to accommodate the changes made within ApplyStyleCommand.

        * editing/ApplyStyleCommand.cpp: ditto
        (WebCore::StyleChange::currentlyHasStyle): ditto

LayoutTests:

2009-07-29  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Justin Garcia.

        REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
        https://bugs.webkit.org/show_bug.cgi?id=27809

        Since new behavior is consistent with Firefox, we rebaseline the test cases.
        The patch converts remove-underline-from-stylesheet and remove-underline-in-bold to dumpAsText tests
        with markup printed explicitly because pixel tests did not detect the disappearance of underline.

        * editing/style/remove-underline-from-stylesheet-expected.txt: Added.
        * editing/style/remove-underline-from-stylesheet.html:
        * editing/style/remove-underline-in-bold-expected.txt: Added.
        * editing/style/remove-underline-in-bold.html:
        * platform/mac/editing/style/remove-underline-from-stylesheet-expected.checksum: Removed.
        * platform/mac/editing/style/remove-underline-from-stylesheet-expected.png: Removed.
        * platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
        * platform/mac/editing/style/remove-underline-in-bold-expected.checksum: Removed.
        * platform/mac/editing/style/remove-underline-in-bold-expected.png: Removed.
        * platform/mac/editing/style/remove-underline-in-bold-expected.txt: Removed.
        * platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
        * platform/qt/editing/style/remove-underline-in-bold-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Yong Li <yong.li@torchmobile.com>
staikos@webkit.org [Thu, 30 Jul 2009 00:08:34 +0000 (00:08 +0000)]
2009-07-29  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        WINCE PORT: changes to platform/text files
        https://bugs.webkit.org/show_bug.cgi?id=27715

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <http://webkit.org/b/27788> Don't export WebPluginController.h as a private...
ddkilzer@apple.com [Thu, 30 Jul 2009 00:08:20 +0000 (00:08 +0000)]
    <webkit.org/b/27788> Don't export WebPluginController.h as a private header

        Reviewed by Mark Rowe.

WebKit:

        WebPluginController.h includes WebPluginContainerCheck.h, which
        is not a private header.  Since WebPluginController.h doesn't
        appear to be used anywhere, remove its private header status.

        * WebKit.xcodeproj/project.pbxproj: Remove private header
        attribute from WebPluginController.h.

WebKit/mac:

        * Plugins/WebPluginController.h: Changed #import of
        WebPluginContainerCheck.h to use a framework-style include in
        case other platforms wish to export WebPluginController.h as a
        private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Yong Li <yong.li@torchmobile.com>
staikos@webkit.org [Wed, 29 Jul 2009 23:48:26 +0000 (23:48 +0000)]
2009-07-29  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Adam Roben.

        FIX: HDC leaks in PopupMenuWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=27817

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land...
ddkilzer@apple.com [Wed, 29 Jul 2009 23:48:25 +0000 (23:48 +0000)]
    <webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches

        Reviewed by David Levin.

        * Scripts/bugzilla-tool:
        (LandPatchesFromBugs.__init__): Added --no-close switch.
        (LandPatchesFromBugs.land_patches): Don't close the bug if the
        --no-close switch was used.  Always clear the review+ flag on
        every landed patch using the commit_text message when cleared.
        This prevents patches from showing up in the commit queue if
        reopened and provides consistency with all landed patches.
        * Scripts/modules/bugzilla.py:
        (Bugzilla.clear_attachment_review_flag): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 29 Jul 2009 23:42:07 +0000 (23:42 +0000)]
2009-07-29  Darin Adler  <darin@apple.com>

        * platform/gtk/Skipped: Added ol-start-parsing.html since it has no result yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 29 Jul 2009 23:29:06 +0000 (23:29 +0000)]
2009-07-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
        https://bugs.webkit.org/show_bug.cgi?id=27810

        Test: fast/lists/ol-start-parsing.html

        * html/HTMLOListElement.cpp:
        (WebCore::HTMLOListElement::parseMappedAttribute): Check the result of toInt
        and use the value 1 if it failed to parse. Before we were getting toInt's default
        behavior, which is to return 0.

2009-07-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
        https://bugs.webkit.org/show_bug.cgi?id=27810

        Couldn't make a text-only test because list numbers do not show up in
        text dumps. This matches the other fast/lists tests.

        * fast/lists/ol-start-parsing.html: Added.
        * platform/mac/fast/lists/ol-start-parsing-expected.checksum: Added.
        * platform/mac/fast/lists/ol-start-parsing-expected.png: Added.
        * platform/mac/fast/lists/ol-start-parsing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWas doing the build fix wrong, NotImplemented.h is in WebCore.
bweinstein@apple.com [Wed, 29 Jul 2009 22:49:47 +0000 (22:49 +0000)]
Was doing the build fix wrong, NotImplemented.h is in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix.
bweinstein@apple.com [Wed, 29 Jul 2009 22:32:39 +0000 (22:32 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Wed, 29 Jul 2009 22:12:05 +0000 (22:12 +0000)]
WebCore:

2009-07-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin Adler.

        Added foundation work to allow a testing infrastructure for the Web
        Inspector.

        * inspector/InspectorClient.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::scriptObjectReady): Tell the testing
        harness that the window object is ready.
        * loader/EmptyClients.h: Empty class support for SVG.
        (WebCore::EmptyInspectorClient::inspectorWindowObjectCleared):

WebKit/gtk:

2009-07-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin Adler.

        Added foundation work to allow a testing infrastructure for the Web
        Inspector.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::inspectorWindowObjectCleared):
        * WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2009-07-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin Adler.

        Added foundation work to allow a testing infrastructure for the Web
        Inspector.

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::inspectorWindowObjectCleared): Send the delegate
        callback.
        * WebView/WebDelegateImplementationCaching.h:
        * WebView/WebView.mm:
        (-[WebView _cacheFrameLoadDelegateImplementations]):
        * WebView/WebViewPrivate.h: The delegate SPI.

WebKit/qt:

2009-07-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin Adler.

        Added foundation work to allow a testing infrastructure for the Web
        Inspector.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::inspectorWindowObjectCleared):
        * WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2009-07-29  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin Adler.

        Added foundation work to allow a testing infrastructure for the Web
        Inspector.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::inspectorWindowObjectCleared): Empty definition
        to let Windows compile but we should implement this at some point so
        that the tests can be run on Windows too.
        * WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Windows build breakage.
cfleizach@apple.com [Wed, 29 Jul 2009 21:45:33 +0000 (21:45 +0000)]
Fix Windows build breakage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Wed, 29 Jul 2009 21:44:32 +0000 (21:44 +0000)]
2009-07-29  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Update getComputedStyle expected results on Windows to match updated Mac results.

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 27807 - AX: move re-usable code into more common areas for other platforms
cfleizach@apple.com [Wed, 29 Jul 2009 21:35:05 +0000 (21:35 +0000)]
Bug 27807 - AX: move re-usable code into more common areas for other platforms
https://bugs.webkit.org/show_bug.cgi?id=27807

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commi...
ddkilzer@apple.com [Wed, 29 Jul 2009 20:53:36 +0000 (20:53 +0000)]
    <webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command

        Reviewed by Eric Seidel.

        * Scripts/bugzilla-tool:
        (PostDiffAsPatchToBug.execute): Changed default patch name from
        "patch" to "Patch v1".
        (PostCommitsAsPatchesToBug.__init__): Added -m/--description
        switch.
        (PostCommitsAsPatchesToBug.execute): Use description provided by
        -m/--description switch first, else fall back to the commit
        message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
mitz@apple.com [Wed, 29 Jul 2009 20:35:16 +0000 (20:35 +0000)]
    Reviewed by Simon Fraser.

        Inset box shadows are incorrectly accounted for in visual overflow
        computations
        https://bugs.webkit.org/show_bug.cgi?id=27811

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Use
            getBoxShadowHorizontalExtent().
        (WebCore::InlineFlowBox::placeBoxesVertically): Use
            getBoxShadowVerticalExtent(). Removed duplicate code to get the
            text-shadow overflow.
        (WebCore::InlineFlowBox::paint): Use getBoxShadowHorizontalExtent().
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight): Use
            getBoxShadowVerticalExtent().
        (WebCore::RenderBlock::overflowWidth): Use
            getBoxShadowHorizontalExtent().
        (WebCore::RenderBlock::overflowLeft): Ditto.
        (WebCore::RenderBlock::overflowTop): Use getBoxShadowVerticalExtent().
        (WebCore::RenderBlock::overflowRect): Use getBoxShadowExtent().
        (WebCore::RenderBlock::layoutBlock): Ditto.
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateRects): Exclude inset shadows.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Use
            getBoxShadowHorizontalExtent() and getBoxShadowVerticalExtent().
        (WebCore::RenderObject::adjustRectForOutlineAndShadow): Exclude inset
            shadows.
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setTextShadow): Also assert that text-shadows are
            not inset.
        (WebCore::RenderStyle::getBoxShadowExtent): Added. Excludes inset
            shadows.
        (WebCore::RenderStyle::getBoxShadowHorizontalExtent): Ditto.
        (WebCore::RenderStyle::getBoxShadowVerticalExtent): Ditto.
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Jul 2009 20:26:33 +0000 (20:26 +0000)]
2009-07-29  Brady Eidson  <beidson@apple.com>

        Rubber-stamped by Mark Rowe

        * platform/gtk/Skipped: Disable the new test on GTK, as they don't dump resource load callbacks
          in their DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Jul 2009 20:13:57 +0000 (20:13 +0000)]
2009-07-29  Brady Eidson  <beidson@apple.com>

        Rubber-stamped by Jon Honeycutt

        Check in Tiger-specific results for the new test, as it is known they send willCacheResponse
        callbacks in a different order.

        * platform/mac-tiger/http/tests/loading: Added.
        * platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Jul 2009 20:07:14 +0000 (20:07 +0000)]
2009-07-29  Brady Eidson  <beidson@apple.com>

        Adding my new test to the Windows skipped list until I can figure out what's going on.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 29 Jul 2009 19:48:57 +0000 (19:48 +0000)]
2009-07-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix crash when an element with display: table-row is composited (e.g. via a 3d-transform)
        https://bugs.webkit.org/show_bug.cgi?id=27796

        Avoid repainting when a layer becomes composited if the renderer is not parented
        yet, because it makes no sense to do so.

        If the table row is a repaint container, default to the RenderBox implementation
        of clippedOverflowRectForRepaint(), because we cannot hand off the repaint rect
        computation to something that is above the repaint container.

        Test: fast/table/table-row-compositing-repaint-crash.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::repaintOnCompositingChange):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::clippedOverflowRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Wed, 29 Jul 2009 18:22:35 +0000 (18:22 +0000)]
WebCore:

2009-07-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=27791
        307 redirects of POSTs should use POST, not GET

        Test: http/tests/loading/redirect-methods.html

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest):

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

LayoutTests:

2009-07-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=27791
        307 redirects of POSTs should use POST, not GET

        * http/tests/loading/redirect-methods-expected.txt: Added.
        * http/tests/loading/redirect-methods.html: Added.
        * http/tests/loading/resources/redirect-methods-form.html: Added.
        * http/tests/loading/resources/redirect-methods-result.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Adding -webkit-animation-play-state back in
cmarrin@apple.com [Wed, 29 Jul 2009 18:03:03 +0000 (18:03 +0000)]
    Adding -webkit-animation-play-state back in
        https://bugs.webkit.org/show_bug.cgi?id=26867

        We've decided to keep -webkit-animation-play-state. So this
        just adds back in the code from https://bugs.webkit.org/show_bug.cgi?id=22907.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Jakub Wieczorek <faw217@gmail.com>
kenneth@webkit.org [Wed, 29 Jul 2009 17:02:13 +0000 (17:02 +0000)]
2009-07-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        Expose the default plugin directories and the current directory set of
        the plugin database as public API.

        https://bugs.webkit.org/show_bug.cgi?id=27651

        * plugins/PluginDatabase.h:
        (WebCore::PluginDatabase::pluginDirectories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Alpha Lam <hclam@chromium.org>
levin@chromium.org [Wed, 29 Jul 2009 16:30:19 +0000 (16:30 +0000)]
2009-07-29  Alpha Lam  <hclam@chromium.org>

        Reviewed by David Levin.

        [chromium] Font size for current time display in media controls panel
        is affected by body font size.
        https://bugs.webkit.org/show_bug.cgi?id=27799

        Fixing the problem of rendering by explicitly setting the font size
        for the time displays.

        No new tests since this is covered by existing media tests.

        * css/mediaControlsChromium.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Mike Fenton <mike.fenton@torchmobile.com>
levin@chromium.org [Wed, 29 Jul 2009 16:30:13 +0000 (16:30 +0000)]
2009-07-29  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by David Levin.

        Update WebCore/page/ContextMenuController.cpp to conform to WebKit
        Style Guidelines as identified by cpp_style.py.
        https://bugs.webkit.org/show_bug.cgi?id=27613

        * page/ContextMenuController.cpp:
        (WebCore::openNewWindow):
        (WebCore::ContextMenuController::contextMenuItemSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Dean McNamee <deanm@chromium.org>
dglazkov@chromium.org [Wed, 29 Jul 2009 16:17:43 +0000 (16:17 +0000)]
2009-07-29  Dean McNamee  <deanm@chromium.org>

        Reviewed by Dimitri Glazkov.

        Removed unused wrapCPointer/extractCPointer from the v8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=27805

        * bindings/v8/V8DOMWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Wed, 29 Jul 2009 15:13:30 +0000 (15:13 +0000)]
2009-07-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Dave Levin.

        Make check-webkit-style support files as arguments.
        https://bugs.webkit.org/show_bug.cgi?id=27549

        * Scripts/check-webkit-style:
        Support files as argument. Change documentation and use basename
        on the binary name when used in the documentation. Also do not
        die when printing something containing non-ASCII characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Jakub Wieczorek <faw217@gmail.com>
kenneth@webkit.org [Wed, 29 Jul 2009 14:54:58 +0000 (14:54 +0000)]
2009-07-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        Expose the PluginDatabase::pluginForMIMEType() function as public API.
        https://bugs.webkit.org/show_bug.cgi?id=27651

        It can be used to determine the appropriate plugin for a mime type,
        without guessing the mimetype from the extension.

        * plugins/PluginDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Jakub Wieczorek <faw217@gmail.com>
kenneth@webkit.org [Wed, 29 Jul 2009 14:36:15 +0000 (14:36 +0000)]
2009-07-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Treat.

        Allow to enable/disable particular plugin packages.
        https://bugs.webkit.org/show_bug.cgi?id=27651

        Disabled plugins will not be picked up when looking for a plugin
        supporting the requested mimetypes.

        Client applications may want to use that API to disable specific
        plugins.

        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::pluginForMIMEType):
        (WebCore::PluginDatabase::MIMETypeForExtension):
        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::PluginPackage):
        (WebCore::PluginPackage::setEnabled):
        * plugins/PluginPackage.h:
        (WebCore::PluginPackage::isEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
zimmermann@webkit.org [Wed, 29 Jul 2009 13:18:30 +0000 (13:18 +0000)]
2009-07-29  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by Adam Treat.

        [WML] Running WML tests in random order multiple times exposes subtle bugs
        https://bugs.webkit.org/show_bug.cgi?id=27801

        Some changes to fix random order WML tests, simplilfy WMLTestCase.js and reset testDocument
        properly in enter-first-card-with-events.js. fast/wml/err-multi-access.wml still creates a layout
        test difference on consecutive runs, though that's related to bug 27721, which has to be fixed first.

        * wml/resources/WMLTestCase.js:
        * wml/resources/enter-first-card-with-events.js:
        (setupTestDocument):
        (prepareTest):
        (executeTest):

2009-07-29  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by Adam Treat.

        [WML] Running WML tests in random order multiple times exposes subtle bugs
        https://bugs.webkit.org/show_bug.cgi?id=27801

        Remove superflous assertions regarding the parent node. Under certain circumstances
        these can even fire (related to garbage collection while destructing). Fixes random order
        WML tests (run-webkit-tests fast/wml wml http/tests/wml fast/wml ... --random)

        The wml/enter-first-card-with-events.html test relied on a bug in our implementation of
        WMLPageState::reset() - the history stack should still contain the current card afterwards.
        Fix that bug by preserving the first item in BackForwardList::clearWMLPageHistory().

        * history/BackForwardList.cpp: Preserve first item in history stack, as demanded by the spec.
        (WebCore::BackForwardList::clearWMLPageHistory):
        * wml/WMLDoElement.cpp:
        (WebCore::WMLDoElement::insertedIntoDocument):
        (WebCore::WMLDoElement::removedFromDocument):
        * wml/WMLNoopElement.cpp:
        (WebCore::WMLNoopElement::insertedIntoDocument):
        * wml/WMLOnEventElement.cpp:
        (WebCore::eventHandlingParent):
        * wml/WMLPostfieldElement.cpp:
        (WebCore::WMLPostfieldElement::insertedIntoDocument):
        (WebCore::WMLPostfieldElement::removedFromDocument):
        * wml/WMLSetvarElement.cpp:
        (WebCore::WMLSetvarElement::insertedIntoDocument):
        (WebCore::WMLSetvarElement::removedFromDocument):
        * wml/WMLTaskElement.cpp:
        (WebCore::WMLTaskElement::insertedIntoDocument):
        (WebCore::WMLTaskElement::removedFromDocument):
        * wml/WMLTimerElement.cpp:
        (WebCore::WMLTimerElement::insertedIntoDocument):
        (WebCore::WMLTimerElement::removedFromDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command
ddkilzer@apple.com [Wed, 29 Jul 2009 11:35:09 +0000 (11:35 +0000)]
    <webkit.org/b/27119> bugzilla-tool: Add create-bug command

        Reviewed by David Levin.

        Implement "create-bug" command for bugzilla-tool.

        * Scripts/bugzilla-tool: Added CreateBug class.
        (CreateBug.__init__): Added.
        (CreateBug.create_bug_from_commit): Added.
        (CreateBug.create_bug_from_patch): Added.
        (CreateBug.prompt_for_bug_title_and_comment): Added.
        (CreateBug.execute): Added.
        (BugzillaTool.__init__): Added create-bug command.
        * Scripts/modules/bugzilla.py:
        (Bugzilla.prompt_for_component): Added.
        (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added.
        (Bugzilla.create_bug_with_patch): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 29 Jul 2009 11:18:16 +0000 (11:18 +0000)]
2009-07-29  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Eric Seidel and Xan Lopez.

        [Gtk] Enable http/tests/appcache tests
        https://bugs.webkit.org/show_bug.cgi?id=27674

        * GNUmakefile.am: Add webkit/webkitapplicationcache.cpp

        Enable passing http/tests/appcache tests.

        * platform/gtk/Skipped:

        Add 'enable-offline-web-application-cache' WebSetting to enable
        or disable the appcache. Also, Add appcache SPI for DRT to use.

        * webkit/webkitapplicationcache.cpp: Added.
        (webkit_application_cache_set_maximum_size):
        * webkit/webkitprivate.cpp:
        (webkit_init):
        * webkit/webkitprivate.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

        Add support for testing http/tests/appcache tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setAppCacheMaximumSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 29 Jul 2009 10:50:21 +0000 (10:50 +0000)]
2009-07-29  Simon Hausmann  <simon.hausmann@nokia.com>

        Update Qt-specific results for computed-style tests, like in r46512.

        * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Yongjun Zhang <yongjun.zhang@nokia.com>
hausmann@webkit.org [Wed, 29 Jul 2009 10:33:20 +0000 (10:33 +0000)]
2009-07-29  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=26848
        [Qt] ResourceHandle::willLoadFromCache needs to be implemented QtWebKit.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem):
        * platform/network/ResourceHandle.h:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::willLoadFromCache):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::willLoadFromCache):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::willLoadFromCache):
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::willLoadFromCache):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Alpha Lam <hclam@chromium.org>
levin@chromium.org [Wed, 29 Jul 2009 09:53:02 +0000 (09:53 +0000)]
2009-07-29  Alpha Lam  <hclam@chromium.org>

        Reviewed by David Levin.

        Media control panel for <video> in MediaDocument is mis-placed
        https://bugs.webkit.org/show_bug.cgi?id=27798

        Fixing a rendering problem: When <video> is displayed in MediaDocument,
        the media control panel overlaps with the video by 16 pixels.

        No new tests as this is covered by existing media tests.

        * css/mediaControlsChromium.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert r46532 (build-webkit: Reorder logic for determining the baseProductDir)
vestbo@webkit.org [Wed, 29 Jul 2009 09:48:47 +0000 (09:48 +0000)]
Revert r46532 (build-webkit: Reorder logic for determining the baseProductDir)

Broke the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Wed, 29 Jul 2009 09:37:31 +0000 (09:37 +0000)]
2009-07-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Eric Seidel.

        build-webkit: Reorder logic for determining the baseProductDir

        https://bugs.webkit.org/show_bug.cgi?id=27699

        We now do port-spesific probing for the product dir first, and then
        fall back to either the generic WEBKITOUTPUTDIR (which now also works
        on Mac), or WebKitBuild.

        Then we add the git branch if the git branch build option is enabled.

        Finally we massage the product dir based on the port. For example the
        Mac port will now always set the SYMROOT and OBJROOT configuration for
        XCode.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 29 Jul 2009 08:36:52 +0000 (08:36 +0000)]
2009-07-29  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix for Chromium.  Those last two patches weren't
        independent despite the clean merge.

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
hausmann@webkit.org [Wed, 29 Jul 2009 08:34:47 +0000 (08:34 +0000)]
2009-07-29  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] In debug mode, this fix frees cached resources
        and other unreferenced objects (by calling the
        garbage collector) to remove the LEAK messages.
        https://bugs.webkit.org/show_bug.cgi?id=27767

        * Api/qwebframe.cpp:
        (qt_drt_cache_clear):
        * QtLauncher/main.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Avi Drissman <avi@chromium.org>
abarth@webkit.org [Wed, 29 Jul 2009 08:11:05 +0000 (08:11 +0000)]
2009-07-29  Avi Drissman  <avi@chromium.org>

        Reviewed by Darin Adler.

        ImageSourceCG makes bad data refs (race condition causes blank images)
        https://bugs.webkit.org/show_bug.cgi?id=27777

        Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
        backs the CFDataRef will be long enough.

        No new tests, as this fixes a bug with a race condition that is
        difficult to trigger.

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::setData):

2009-07-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Fix a bug that HTMLOptionElement::value() returns an incorrect
        value in a case that the element has a label attribute and no
        value attribute.
        https://bugs.webkit.org/show_bug.cgi?id=27760

        * fast/forms/option-value-and-label-expected.txt: Added.
        * fast/forms/option-value-and-label.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
levin@chromium.org [Wed, 29 Jul 2009 08:04:19 +0000 (08:04 +0000)]
2009-07-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        Resolve class/struct mixup in forward declarations
        https://bugs.webkit.org/show_bug.cgi?id=27708

        * API/JSClassRef.h:
        * bytecode/SamplingTool.h:
        * interpreter/Interpreter.h:
        * jit/JIT.h:
        * profiler/ProfileGenerator.h:
        * profiler/Profiler.h:
        * runtime/ClassInfo.h:
        * runtime/ExceptionHelpers.h:
        * runtime/JSByteArray.h:
        * runtime/JSCell.h:
        * runtime/JSFunction.h:
        * runtime/JSGlobalData.h:
        * runtime/JSObject.h:
        * runtime/JSString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Avi Drissman <avi@chromium.org>
levin@chromium.org [Wed, 29 Jul 2009 08:04:09 +0000 (08:04 +0000)]
2009-07-29  Avi Drissman  <avi@chromium.org>

        Reviewed by Darin Adler.

        ImageSourceCG makes bad data refs (race condition causes blank images)
        https://bugs.webkit.org/show_bug.cgi?id=27777

        Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
        backs the CFDataRef will be long enough.

        No new tests, as this fixes a bug with a race condition that is
        difficult to trigger.

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::setData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Keishi Hattori <casey.hattori@gmail.com>
levin@chromium.org [Wed, 29 Jul 2009 08:04:04 +0000 (08:04 +0000)]
2009-07-29  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Console should show completions for the command line APIs
        https://bugs.webkit.org/show_bug.cgi?id=27696

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._reportCompletions): Adds properties from _inspectorCommandLineAPI to
        completions when available.
        * inspector/front-end/utilities.js:
        (Object.properties): Added.
        (Object.sortedProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Wed, 29 Jul 2009 08:03:58 +0000 (08:03 +0000)]
2009-07-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Refactor the first step of layout in RenderFlexibleBox.cpp
        https://bugs.webkit.org/show_bug.cgi?id=27704

        No new tests as this change is just a refactoring.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::gatherFlexChildrenInfo):
        (WebCore::RenderFlexibleBox::layoutHorizontalBox):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Kent Tamura <tkent@chromium.org>
levin@chromium.org [Wed, 29 Jul 2009 08:03:52 +0000 (08:03 +0000)]
2009-07-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Fix a bug that HTMLOptionElement::value() returns an incorrect
        value in a case that the element has a label attribute and no
        value attribute.
        https://bugs.webkit.org/show_bug.cgi?id=27760

WebCore:

        Test: fast/forms/option-value-and-label.html

        * dom/OptionElement.cpp:
        (WebCore::OptionElement::collectOptionLabelOrText):
        (WebCore::OptionElement::collectOptionInnerText):
        (WebCore::OptionElement::normalizeText):
        (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
        (WebCore::OptionElement::collectOptionValue):
        * dom/OptionElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::text):
        * wml/WMLOptionElement.cpp:
        (WebCore::WMLOptionElement::text):

LayoutTests:

        * fast/forms/option-value-and-label-expected.txt: Added.
        * fast/forms/option-value-and-label.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 29 Jul 2009 07:59:40 +0000 (07:59 +0000)]
2009-07-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Teach V8Proxy::context about isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=27701

        Change V8Proxy::context(Frame*) to understand isolated worlds.  Audit
        all callers of this method to make sure they want isolated worlds.  In
        cases where we really want the main world, I've changed the call to
        V8Proxy::mainWorldContext(Frame*).

        The main visible change is to the document.open method when called with
        more than two arguments.  This design seems more likely to lead to
        future correct code.

        Test: http/tests/security/isolatedWorld/document-open.html

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture):
        (WebCore::ScriptController::evaluate):
        (WebCore::ScriptController::bindToWindowObject):
        (WebCore::ScriptController::collectGarbage):
        (WebCore::createScriptObject):
        (WebCore::ScriptController::createScriptObjectForPluginElement):
        * bindings/v8/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject):
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::handleEvent):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getConstructor):
        (WebCore::V8DOMWrapper::setHiddenWindowReference):
        (WebCore::V8DOMWrapper::convertNodeToV8Object):
        (WebCore::V8DOMWrapper::convertWindowToV8Object):
        * bindings/v8/V8Helpers.cpp:
        (WebCore::toV8Context):
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::getListenerFunction):
        (WebCore::V8LazyEventListener::getWrappedListenerFunction):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::context):
        (WebCore::V8Proxy::mainWorldContext):
        (WebCore::V8Proxy::bindJsObjectToWindow):
        * bindings/v8/V8Proxy.h:

2009-07-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [V8] Teach V8Proxy::context about isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=27701

        Test that calling document.open with more than two arguments calls the
        window.open method from the correct world.

        * http/tests/security/isolatedWorld/document-open-expected.txt: Added.
        * http/tests/security/isolatedWorld/document-open.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-29 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
hausmann@webkit.org [Wed, 29 Jul 2009 07:25:44 +0000 (07:25 +0000)]
2009-07-29  Balazs Kelemen  <kelemen.balazs.3@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Fix the Qt build, add missing file.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 29 Jul 2009 07:13:04 +0000 (07:13 +0000)]
2009-07-28  Jon Honeycutt  <jhoneycutt@apple.com>

        Speculative fix for <rdar://problem/7005077> WER: Crash in
        WebCore::PluginStream::destroyStream+279 (1310510882)

        Reviewed by Oliver Hunt.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::destroyStream):
        Move the "protector" RefPtr out of the block that dispatches
        notifications and into the function level; if NPN_DestroyStream were
        called from NPP_NewStream as the comment warns, we would be deleted at
        the end of the block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAllow tabbing through the Web Inspector DOM Storage grid cells when editing.
timothy@apple.com [Wed, 29 Jul 2009 04:54:07 +0000 (04:54 +0000)]
Allow tabbing through the Web Inspector DOM Storage grid cells when editing.

2009-07-28  Joseph Pecoraro  <joepeck02@gmail.com>

        Inspector: Tab Through the DOM Storage DataGrid when Editing

        https://bugs.webkit.org/show_bug.cgi?id=27746

        Reviewed by Timothy Hatcher.

        * inspector/front-end/DOMStorageDataGrid.js:
        (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): refactored to directly edit and select a column
        (WebInspector.DOMStorageDataGrid.prototype._startEditing):
        (WebInspector.DOMStorageDataGrid.prototype._editingCommitted.moveToNextIfNeeded): handles moveDirection on a commit
        (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): uses moveToNext to traverse appropriately

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAllow creating new DOM Storage items in the Web Inspector.
timothy@apple.com [Wed, 29 Jul 2009 04:54:00 +0000 (04:54 +0000)]
Allow creating new DOM Storage items in the Web Inspector.

2009-07-28  Joseph Pecoraro  <joepeck02@gmail.com>

        Inspector: Create New DOM Storage Items via DataGrid

        https://bugs.webkit.org/show_bug.cgi?id=27322

        Reviewed by Timothy Hatcher.

        * inspector/front-end/DOMStorageDataGrid.js:
        (WebInspector.DOMStorageDataGrid.prototype._startEditing): click anyway means creationNode
        (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): fix unintended globals
        (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow): creationNode is special case
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid.prototype.addCreationNode): maintain a quick ref to the single creationNode
        (WebInspector.CreationDataGridNode): new type of node
        (WebInspector.CreationDataGridNode.prototype.makeNormal): convert to a normal node
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): add a creationNode to the GridData

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAutomatically refresh DOM Storage grids in the Web Inspector.
timothy@apple.com [Wed, 29 Jul 2009 04:53:53 +0000 (04:53 +0000)]
Automatically refresh DOM Storage grids in the Web Inspector.

2009-07-28  Joseph Pecoraro  <joepeck02@gmail.com>

        Inspector: Automatically Refresh DOM Storage Grids on "storage" event

        https://bugs.webkit.org/show_bug.cgi?id=27400

        Reviewed by Timothy Hatcher.

        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype.show): trigger adding the listener
        (WebInspector.DatabasesPanel.prototype.reset): trigger removing the listener
        (WebInspector.DatabasesPanel.prototype._registerStorageEventListener): register the listener on the inspected window
        (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): unregister the listener on the inspected window
        (WebInspector.DatabasesPanel.prototype._storageEvent): handle the storage event

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded support for inspect() in the Web Inspector command line.
timothy@apple.com [Wed, 29 Jul 2009 04:53:45 +0000 (04:53 +0000)]
Added support for inspect() in the Web Inspector command line.

2009-07-28  Keishi Hattori  <casey.hattori@gmail.com>

        Inspector should support inspect() in the command line.

        https://bugs.webkit.org/show_bug.cgi?id=19874
        rdar://problem/6070225

        Reviewed by Timothy Hatcher.

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._ensureCommandLineAPIInstalled.inspectObject):
        (WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype.revealAndSelectDomStorage): Added.
        (WebInspector.DatabasesPanel.prototype.revealAndSelectDatabase): Added.
        (WebInspector.DatabasesPanel.prototype.showDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoThe rest of: Web Inspector: Add inspected node using public console API.
timothy@apple.com [Wed, 29 Jul 2009 04:53:39 +0000 (04:53 +0000)]
The rest of: Web Inspector: Add inspected node using public console API.

2009-07-28  Keishi Hattori  <casey.hattori@gmail.com>

        The rest of: Web Inspector: Add inspected node using public console API.

        https://bugs.webkit.org/show_bug.cgi?id=27758

        Reviewed by Timothy Hatcher.

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Removed _inspectorCommandLineAPI._addInspectedNode.
        (WebInspector.Console.prototype.addInspectedNode): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 29 Jul 2009 04:40:17 +0000 (04:40 +0000)]
2009-07-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Accept autocomplete on 'End' key pressed.

        https://bugs.webkit.org/show_bug.cgi?id=27447.

        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt.prototype.handleKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
levin@chromium.org [Wed, 29 Jul 2009 02:27:28 +0000 (02:27 +0000)]
2009-07-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by David Levin.

        [Qt] Build fix after r46502
        https://bugs.webkit.org/show_bug.cgi?id=27789

        * WebCore.pro: Remove StorageArea.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFollow-on fix to r35582. Replace main thread assertions with WebCoreObjCScheduleDeal...
mrowe@apple.com [Wed, 29 Jul 2009 01:42:05 +0000 (01:42 +0000)]
Follow-on fix to r35582.  Replace main thread assertions with WebCoreObjCScheduleDeallocateOnMainThread in -dealloc overrides in DOMObject subclasses.

Reviewed by Darin Adler.

* bindings/scripts/CodeGeneratorObjC.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update Window-specific results with the non-prefixed border-radius
mitz@apple.com [Wed, 29 Jul 2009 01:23:03 +0000 (01:23 +0000)]
    Update Window-specific results with the non-prefixed border-radius
        properties

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
adachan@apple.com [Wed, 29 Jul 2009 01:09:02 +0000 (01:09 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27236
        - Implement TCMalloc_SystemRelease and TCMalloc_SystemCommit for Windows.
        - Use a background thread to periodically scavenge memory to release back to the system.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::init):
        (WTF::TCMalloc_PageHeap::runScavengerThread):
        (WTF::TCMalloc_PageHeap::scavenge):
        (WTF::TCMalloc_PageHeap::shouldContinueScavenging):
        (WTF::TCMalloc_PageHeap::New):
        (WTF::TCMalloc_PageHeap::AllocLarge):
        (WTF::TCMalloc_PageHeap::Delete):
        (WTF::TCMalloc_PageHeap::GrowHeap):
        (WTF::sleep):
        (WTF::TCMalloc_PageHeap::scavengerThread):
        * wtf/TCSystemAlloc.cpp:
        (TCMalloc_SystemRelease):
        (TCMalloc_SystemCommit):
        * wtf/TCSystemAlloc.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
zimmermann@webkit.org [Wed, 29 Jul 2009 00:49:58 +0000 (00:49 +0000)]
2009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by Adam Treat.

        [WML] WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument()
        https://bugs.webkit.org/show_bug.cgi?id=27786

        WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument().
        The only case where this is relevant in WML is error handling. The parsed WML
        tree fragment is inserted in an XHTML compound error document. This requires
        removedFromDocument() to be correctly implemented otherwhise we run into
        trouble (visible when using run-webkit-tests fast/wml --random).

        * wml/WMLAnchorElement.cpp:
        (WebCore::WMLAnchorElement::registerTask):
        (WebCore::WMLAnchorElement::deregisterTask):
        * wml/WMLAnchorElement.h:
        * wml/WMLDoElement.cpp:
        (WebCore::WMLDoElement::removedFromDocument):
        (WebCore::WMLDoElement::registerTask):
        (WebCore::WMLDoElement::deregisterTask):
        * wml/WMLDoElement.h:
        * wml/WMLEventHandlingElement.cpp:
        (WebCore::WMLEventHandlingElement::registerDoElement):
        (WebCore::WMLEventHandlingElement::deregisterDoElement):
        * wml/WMLEventHandlingElement.h:
        * wml/WMLFieldSetElement.cpp:
        (WebCore::WMLFieldSetElement::removedFromDocument):
        * wml/WMLGoElement.cpp:
        (WebCore::WMLGoElement::registerPostfieldElement):
        (WebCore::WMLGoElement::deregisterPostfieldElement):
        * wml/WMLGoElement.h:
        * wml/WMLIntrinsicEventHandler.cpp:
        (WebCore::WMLIntrinsicEventHandler::deregisterIntrinsicEvent):
        * wml/WMLIntrinsicEventHandler.h:
        * wml/WMLOnEventElement.cpp:
        (WebCore::eventHandlingParent):
        (WebCore::WMLOnEventElement::registerTask):
        (WebCore::WMLOnEventElement::deregisterTask):
        * wml/WMLOnEventElement.h:
        * wml/WMLPostfieldElement.cpp:
        (WebCore::WMLPostfieldElement::removedFromDocument):
        * wml/WMLPostfieldElement.h:
        * wml/WMLSetvarElement.cpp:
        (WebCore::WMLSetvarElement::removedFromDocument):
        * wml/WMLSetvarElement.h:
        * wml/WMLTaskElement.cpp:
        (WebCore::WMLTaskElement::removedFromDocument):
        (WebCore::WMLTaskElement::registerVariableSetter):
        (WebCore::WMLTaskElement::deregisterVariableSetter):
        (WebCore::WMLTaskElement::storeVariableState):
        * wml/WMLTaskElement.h:
        * wml/WMLTimerElement.cpp:
        (WebCore::WMLTimerElement::removedFromDocument):
        * wml/WMLTimerElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 29 Jul 2009 00:33:35 +0000 (00:33 +0000)]
2009-07-28  David Levin  <levin@chromium.org>

        Suggested by Drew Wilson.

        Speculative gtk build fix, follow up to:
        https://bugs.webkit.org/show_bug.cgi?id=27697

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Wed, 29 Jul 2009 00:16:53 +0000 (00:16 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        [CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
        properties
        https://bugs.webkit.org/show_bug.cgi?id=27578

        [CSS3 Backgrounds and Borders] Handle the / and 4 values in
        border-radius
        https://bugs.webkit.org/show_bug.cgi?id=27584

        Test: fast/borders/border-radius-parsing.html

        Dropped the -webkit- prefix from the individual corner border-radius
        properties. Added border-radius with the / and 4-value syntax, and
        maintained -webkit-border-radius with legacy 2-value syntax.

        * css/CSSComputedStyleDeclaration.cpp:
        (computedProperties): Removed Webkit prefix.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Removed Webkit prefix from the
            single-corner properties. Call out to parseBorderRadius() to parse
            border-radius and -webkit-border-radius.
        (WebCore::completeBorderRadii): Added this helper function that
            completes the values for all four corners when fewer than four are
            specified.
        (WebCore::CSSParser::parseBorderRadius): Added.
        (WebCore::cssPropertyID): Map -webkit-border-*-*-radius to the
            unprefixed property.
        * css/CSSParser.h:
        * css/CSSPropertyLonghand.cpp:
        (WebCore::initShorthandMap): Removed the Webkit prefix. Added an entry
            for border-radius. Kept the entry for -webkit-border-radius.
        * css/CSSPropertyNames.in: Removed the -webkit- prefix from the
            single-corenr properties. Added border-radius. Kept
            -webkit-border-radius because of its conflicting syntax.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Removed the Webkit prefix.
        * page/animation/AnimationBase.cpp:
        (WebCore::ensurePropertyMap): Ditto.

LayoutTests:

        Reviewed by Simon Fraser.

        New test, updated test, and updated test results for:

        [CSS3 Backgrounds and Borders] Drop the prefix from the border-radius
        properties
        https://bugs.webkit.org/show_bug.cgi?id=27578

        [CSS3 Backgrounds and Borders] Handle the / and 4 values in
        border-radius
        https://bugs.webkit.org/show_bug.cgi?id=27584

        * fast/borders/border-radius-parsing-expected.txt: Added.
        * fast/borders/border-radius-parsing.html: Added.
        * fast/css/remove-shorthand-expected.txt:
        * fast/css/remove-shorthand.html: Added a test for border-radius.
        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Drew Wilson <atwilson@google.com>
levin@chromium.org [Wed, 29 Jul 2009 00:08:02 +0000 (00:08 +0000)]
2009-07-28  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        Refactored dedicated-worker-specific code from WorkerThread into DedicatedWorkerThread class.

        WorkerThread needs to be refactored to separate out dedicated-worker functionality.
        https://bugs.webkit.org/show_bug.cgi?id=27697

        This is just a refactoring, so existing tests suffice.

        * GNUmakefile.am:
        Added DedicatedWorkerThread.h/.cpp
        * WebCore.gypi:
        Added DedicatedWorkerThread.h/.cpp
        * WebCore.pro:
        Added DedicatedWorkerThread.h/.cpp
        * WebCore.vcproj/WebCore.vcproj:
        Added DedicatedWorkerThread.h/.cpp
        * WebCore.xcodeproj/project.pbxproj:
        Added DedicatedWorkerThread.h/.cpp
        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        Removed code to track pending activity - this is handled by DedicatedWorkerContext::importScripts() now.
        * workers/DedicatedWorkerContext.cpp:
        (WebCore::DedicatedWorkerContext::DedicatedWorkerContext):
        (WebCore::DedicatedWorkerContext::addMessage):
        Forwards console messages to parent document.
        (WebCore::DedicatedWorkerContext::importScripts):
        Now sends the updated pending activity status after importing scripts.
        (WebCore::DedicatedWorkerContext::thread):
        Helper routine that casts WorkerThread to DedicatedWorkerThread.
        * workers/DedicatedWorkerContext.h:
        (WebCore::DedicatedWorkerContext::create):
        * workers/DedicatedWorkerThread.cpp: Added.
        (WebCore::DedicatedWorkerThread::create):
        (WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
        (WebCore::DedicatedWorkerThread::~DedicatedWorkerThread):
        (WebCore::DedicatedWorkerThread::createWorkerContext):
        Implementation of the base class factory method to create the appropriate worker context.
        (WebCore::DedicatedWorkerThread::runEventLoop):
        Reports pending activity before running the event loop.
        * workers/DedicatedWorkerThread.h: Added.
        (WebCore::DedicatedWorkerThread::workerObjectProxy):
        Moved from base class.
        * workers/WorkerContext.cpp:
        * workers/WorkerContext.h:
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::startWorkerContext):
        Now creates DedicatedWorkerThread.
        (WebCore::WorkerMessagingProxy::workerThreadCreated):
        Now is passed a DedicatedWorkerThread.
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::WorkerThread):
        Moved workerObjectProxy param into derived class constructor.
        (WebCore::WorkerThread::workerThread):
        (WebCore::WorkerThread::runEventLoop):
        Moved the event loop execution into a virtual function so DedicatedWorkerThread could report pending activity first.
        * workers/WorkerThread.h:
        (WebCore::WorkerThread::workerContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 28 Jul 2009 23:29:55 +0000 (23:29 +0000)]
2009-07-28  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Add two tests that failed on release (not debug) back to skipped list.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPrevent nightly builds of WebKit from launching against old Safari versions that...
mrowe@apple.com [Tue, 28 Jul 2009 23:15:42 +0000 (23:15 +0000)]
Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with.

Reviewed by Oliver Hunt.

* WebKitLauncher/main.m:
(checkSafariVersion): Add a minimum required Safari version of 4.0.  This matches the requirement on Windows.
(main): If the minimum version requirement is not met, display an alert and bail out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 28 Jul 2009 23:12:04 +0000 (23:12 +0000)]
2009-07-28  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        Fix V8NPUtils' handling of UTF8 identifiers.

        https://bugs.webkit.org/show_bug.cgi?id=27782

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 28 Jul 2009 22:38:55 +0000 (22:38 +0000)]
2009-07-28  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Steve Falkenburg.

        Remove a lot of tests from Windows Skip list which now pass. Will watch buildbot
        to make sure there are no regressions/this commit doesn't cause failures.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 28 Jul 2009 22:26:16 +0000 (22:26 +0000)]
2009-07-28  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Eric Seidel.

        Misc cleanup in DOM Storage.
        https://bugs.webkit.org/show_bug.cgi?id=27517

        The StorageAreaImpl changes are all for Chromium.  Because the DOM Storage implementation
        runs in a different process from where the Frame object lives, Chromium passes in NULL
        for the sourceFrame.  This affects events and handling privateBrowsing.  Chromium's
        incognito mode does not use the private browsing setting, so that's not a concern.  As for
        events, I've decided to simply disable them for now.

        The StorageNamespaceImpl changes get rid of a stale comment (path is .copy'ed for thread-
        safety) and to add an assert that .copy is only ever called on a SessionStorage namespace.

        Also cleaned up tailing whitespace in several parts of StorageAreaImpl.cpp

        * storage/StorageArea.cpp: Removed.  (It was empty anyway.)
        * storage/StorageAreaImpl.cpp:
        (WebCore::privateBrowsingEnabled): Factored out the check.
        (WebCore::StorageAreaImpl::setItem): Make frame optional.
        (WebCore::StorageAreaImpl::removeItem): ditto
        (WebCore::StorageAreaImpl::clear): ditto
        (WebCore::StorageAreaImpl::dispatchStorageEvent): Disable in Chromium for now.
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): Remove stale comment.
        (WebCore::StorageNamespaceImpl::copy): Add assert that it's SessionStorage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Alpha Lam <hclam@google.com>
levin@chromium.org [Tue, 28 Jul 2009 21:57:14 +0000 (21:57 +0000)]
2009-07-28  Alpha Lam  <hclam@google.com>

        Reviewed by David Levin.

        [chromium] Default UI controls for <video> has rendering problems
        https://bugs.webkit.org/show_bug.cgi?id=27669

        Fixes the bug that <video> in MediaDocument is 1 pixel tall if
        it is playing an audio file by changing the style to be 32px
        tall.

        Also fixes a problem of default styled audio tag that hides the
        all the time digits by expanding the width to 300px.

        Changed the size and position of the current time and remaining
        display to give enough space for the hour digit to be shown.

        There are no new tests provided because this is already covered
        by existing tests.

        * css/mediaControlsChromium.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 28 Jul 2009 20:53:51 +0000 (20:53 +0000)]
2009-07-28  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Add some checks to existing SessionStorage LayoutTests.
        https://bugs.webkit.org/show_bug.cgi?id=27776

        This is a mixed bag of tweaks to existing tests.  This is the sessionStorage
        side of https://bugs.webkit.org/show_bug.cgi?id=27695

        * storage/domstorage/sessionstorage/delete-removal-expected.txt:
        * storage/domstorage/sessionstorage/delete-removal.html:
              Made output more readable, added redundant deletes, added deletes to
              keys with the same name in different case.
        * storage/domstorage/sessionstorage/enumerate-storage.html:
              Removed dead code.
        * storage/domstorage/sessionstorage/enumerate-with-length-and-key-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage-expected.txt.
        * storage/domstorage/sessionstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/sessionstorage/enumerate-storage.html.
              Test enumerating by hand (with length+key).
        * storage/domstorage/sessionstorage/iframe-events-expected.txt:
        * storage/domstorage/sessionstorage/iframe-events.html:
              Test removeItem and clear in addition to setItem.
        * storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt.
        * storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html.
              Test using window.onstorage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Jakub Wieczorek <faw217@gmail.com>
kenneth@webkit.org [Tue, 28 Jul 2009 20:29:19 +0000 (20:29 +0000)]
2009-07-28  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        Fix style in PluginPackage and PluginDatabase.
        Part of https://bugs.webkit.org/show_bug.cgi?id=27651

        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::refresh):
        (WebCore::PluginDatabase::findPlugin):
        * plugins/PluginDatabase.h:
        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::~PluginPackage):
        (WebCore::PluginPackage::freeLibrarySoon):
        (WebCore::PluginPackage::freeLibraryTimerFired):
        (WebCore::PluginPackage::unloadWithoutShutdown):
        (WebCore::PluginPackage::initializeBrowserFuncs):
        * plugins/PluginPackage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 28 Jul 2009 20:28:40 +0000 (20:28 +0000)]
2009-07-28  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Add some checks to existing DOM Storage LayoutTests.
        https://bugs.webkit.org/show_bug.cgi?id=27695

        This is really a mixed bag of tweaks to existing tests.

        * storage/domstorage/localstorage/delete-removal-expected.txt:
        * storage/domstorage/localstorage/delete-removal.html:
              Made output more readable, added redundant deletes, added deletes to
              keys with the same name in different case.
        * storage/domstorage/localstorage/enumerate-storage.html:
              Removed dead code.
        * storage/domstorage/localstorage/enumerate-with-length-and-key-expected.txt: Added.
        * storage/domstorage/localstorage/enumerate-with-length-and-key.html: Copied from LayoutTests/storage/domstorage/localstorage/enumerate-storage.html.
              Test enumerating by hand (with length+key).
        * storage/domstorage/localstorage/iframe-events-expected.txt:
        * storage/domstorage/localstorage/iframe-events.html:
              Test removeItem and clear in addition to setItem.
        * storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt.
        * storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Copied from LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html.
              Test using window.onstorage.
        * storage/domstorage/window-attributes-exist-expected.txt:
        * storage/domstorage/window-attributes-exist.html:
              Verify that two consecutive calls to window.____Storage will equal each other.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Tue, 28 Jul 2009 19:46:00 +0000 (19:46 +0000)]
2009-07-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Fix the Qt build by adapting to the changes of ScriptObject.

        * Api/qwebelement.cpp:
        (setupScriptObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Anantanarayanan Iyengar <ananta@chromium.org>
dglazkov@chromium.org [Tue, 28 Jul 2009 19:33:00 +0000 (19:33 +0000)]
2009-07-28  Anantanarayanan Iyengar  <ananta@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=27769
        The V8 bindings function V8Proxy::createNewContext can be
        called during frame shutdown where the activeDocumentLoader
        function in FrameLoader can return NULL. Added a check for the
        same.

        No new tests added as this is an edge case where the V8
        bindings code is reentered via NPAPI during shutdown. It is
        difficult to write a consistently reproducible test for this.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::createNewContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Ivan Posva <iposva@chromium.org>
dglazkov@chromium.org [Tue, 28 Jul 2009 19:25:00 +0000 (19:25 +0000)]
2009-07-28  Ivan Posva  <iposva@chromium.org>

        Reviewed by Dimitri Glazkov.

        Associate the CanvasPixelData backing store with the
        indexed properties of the wrapper object.

        https://bugs.webkit.org/show_bug.cgi?id=27773

        No new tests: Relying on existing Canvas tests.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        (WebCore::V8DOMWrapper::convertToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Maxime Simon <simon.maxime@gmail.com>
levin@chromium.org [Tue, 28 Jul 2009 18:58:51 +0000 (18:58 +0000)]
2009-07-28  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by David Levin.

        Added FrameLoaderClient for Haiku WebCore support.
        https://bugs.webkit.org/show_bug.cgi?id=26952

        * haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp: Added.
        (WebCore::FrameLoaderClientHaiku::FrameLoaderClientHaiku):
        (WebCore::FrameLoaderClientHaiku::setFrame):
        (WebCore::FrameLoaderClientHaiku::setWebView):
        (WebCore::FrameLoaderClientHaiku::detachFrameLoader):
        (WebCore::FrameLoaderClientHaiku::hasWebView):
        (WebCore::FrameLoaderClientHaiku::hasBackForwardList):
        (WebCore::FrameLoaderClientHaiku::resetBackForwardList):
        (WebCore::FrameLoaderClientHaiku::provisionalItemIsTarget):
        (WebCore::FrameLoaderClientHaiku::makeRepresentation):
        (WebCore::FrameLoaderClientHaiku::forceLayout):
        (WebCore::FrameLoaderClientHaiku::forceLayoutForNonHTML):
        (WebCore::FrameLoaderClientHaiku::updateHistoryForCommit):
        (WebCore::FrameLoaderClientHaiku::updateHistoryForBackForwardNavigation):
        (WebCore::FrameLoaderClientHaiku::updateHistoryForReload):
        (WebCore::FrameLoaderClientHaiku::updateHistoryForStandardLoad):
        (WebCore::FrameLoaderClientHaiku::updateHistoryForInternalLoad):
        (WebCore::FrameLoaderClientHaiku::updateHistoryAfterClientRedirect):
        (WebCore::FrameLoaderClientHaiku::setCopiesOnScroll):
        (WebCore::FrameLoaderClientHaiku::tokenForLoadErrorReset):
        (WebCore::FrameLoaderClientHaiku::resetAfterLoadError):
        (WebCore::FrameLoaderClientHaiku::doNotResetAfterLoadError):
        (WebCore::FrameLoaderClientHaiku::willCloseDocument):
        (WebCore::FrameLoaderClientHaiku::detachedFromParent2):
        (WebCore::FrameLoaderClientHaiku::detachedFromParent3):
        (WebCore::FrameLoaderClientHaiku::dispatchDidHandleOnloadEvents):
        (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebCore::FrameLoaderClientHaiku::dispatchDidCancelClientRedirect):
        (WebCore::FrameLoaderClientHaiku::dispatchWillPerformClientRedirect):
        (WebCore::FrameLoaderClientHaiku::dispatchDidChangeLocationWithinPage):
        (WebCore::FrameLoaderClientHaiku::dispatchWillClose):
        (WebCore::FrameLoaderClientHaiku::dispatchDidStartProvisionalLoad):
        (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientHaiku::dispatchDidCommitLoad):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoad):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFirstLayout):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFirstVisuallyNonEmptyLayout):
        (WebCore::FrameLoaderClientHaiku::dispatchShow):
        (WebCore::FrameLoaderClientHaiku::cancelPolicyCheck):
        (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm):
        (WebCore::FrameLoaderClientHaiku::dispatchDidLoadMainResource):
        (WebCore::FrameLoaderClientHaiku::revertToProvisionalState):
        (WebCore::FrameLoaderClientHaiku::postProgressStartedNotification):
        (WebCore::FrameLoaderClientHaiku::postProgressEstimateChangedNotification):
        (WebCore::FrameLoaderClientHaiku::postProgressFinishedNotification):
        (WebCore::FrameLoaderClientHaiku::progressStarted):
        (WebCore::FrameLoaderClientHaiku::progressCompleted):
        (WebCore::FrameLoaderClientHaiku::setMainFrameDocumentReady):
        (WebCore::FrameLoaderClientHaiku::willChangeTitle):
        (WebCore::FrameLoaderClientHaiku::didChangeTitle):
        (WebCore::FrameLoaderClientHaiku::finishedLoading):
        (WebCore::FrameLoaderClientHaiku::canShowMIMEType):
        (WebCore::FrameLoaderClientHaiku::representationExistsForURLScheme):
        (WebCore::FrameLoaderClientHaiku::generatedMIMETypeForURLScheme):
        (WebCore::FrameLoaderClientHaiku::frameLoadCompleted):
        (WebCore::FrameLoaderClientHaiku::saveViewStateToItem):
        (WebCore::FrameLoaderClientHaiku::restoreViewState):
        (WebCore::FrameLoaderClientHaiku::restoreScrollPositionAndViewState):
        (WebCore::FrameLoaderClientHaiku::provisionalLoadStarted):
        (WebCore::FrameLoaderClientHaiku::shouldTreatURLAsSameAsCurrent):
        (WebCore::FrameLoaderClientHaiku::addHistoryItemForFragmentScroll):
        (WebCore::FrameLoaderClientHaiku::didFinishLoad):
        (WebCore::FrameLoaderClientHaiku::prepareForDataSourceReplacement):
        (WebCore::FrameLoaderClientHaiku::setTitle):
        (WebCore::FrameLoaderClientHaiku::userAgent):
        (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveIcon):
        (WebCore::FrameLoaderClientHaiku::frameLoaderDestroyed):
        (WebCore::FrameLoaderClientHaiku::canHandleRequest):
        (WebCore::FrameLoaderClientHaiku::partClearedInBegin):
        (WebCore::FrameLoaderClientHaiku::updateGlobalHistory):
        (WebCore::FrameLoaderClientHaiku::updateGlobalHistoryRedirectLinks):
        (WebCore::FrameLoaderClientHaiku::shouldGoToHistoryItem):
        (WebCore::FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem):
        (WebCore::FrameLoaderClientHaiku::canCachePage):
        (WebCore::FrameLoaderClientHaiku::setMainDocumentError):
        (WebCore::FrameLoaderClientHaiku::committedLoad):
        (WebCore::FrameLoaderClientHaiku::cancelledError):
        (WebCore::FrameLoaderClientHaiku::blockedError):
        (WebCore::FrameLoaderClientHaiku::cannotShowURLError):
        (WebCore::FrameLoaderClientHaiku::interruptForPolicyChangeError):
        (WebCore::FrameLoaderClientHaiku::cannotShowMIMETypeError):
        (WebCore::FrameLoaderClientHaiku::fileDoesNotExistError):
        (WebCore::FrameLoaderClientHaiku::shouldFallBack):
        (WebCore::FrameLoaderClientHaiku::createDocumentLoader):
        (WebCore::FrameLoaderClientHaiku::download):
        (WebCore::FrameLoaderClientHaiku::assignIdentifierToInitialRequest):
        (WebCore::FrameLoaderClientHaiku::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientHaiku::shouldUseCredentialStorage):
        (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveAuthenticationChallenge):
        (WebCore::FrameLoaderClientHaiku::dispatchDidCancelAuthenticationChallenge):
        (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveResponse):
        (WebCore::FrameLoaderClientHaiku::dispatchDidReceiveContentLength):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFinishLoading):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoading):
        (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceFromMemoryCache):
        (WebCore::FrameLoaderClientHaiku::dispatchDidLoadResourceByXMLHttpRequest):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFailProvisionalLoad):
        (WebCore::FrameLoaderClientHaiku::dispatchDidFailLoad):
        (WebCore::FrameLoaderClientHaiku::dispatchCreatePage):
        (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType):
        (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction):
        (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction):
        (WebCore::FrameLoaderClientHaiku::dispatchUnableToImplementPolicy):
        (WebCore::FrameLoaderClientHaiku::startDownload):
        (WebCore::FrameLoaderClientHaiku::createFrame):
        (WebCore::FrameLoaderClientHaiku::objectContentType):
        (WebCore::FrameLoaderClientHaiku::createPlugin):
        (WebCore::FrameLoaderClientHaiku::redirectDataToPlugin):
        (WebCore::FrameLoaderClientHaiku::pluginWillHandleLoadError):
        (WebCore::FrameLoaderClientHaiku::createJavaAppletWidget):
        (WebCore::FrameLoaderClientHaiku::overrideMediaType):
        (WebCore::FrameLoaderClientHaiku::windowObjectCleared):
        (WebCore::FrameLoaderClientHaiku::documentElementAvailable):
        (WebCore::FrameLoaderClientHaiku::didPerformFirstNavigation):
        (WebCore::FrameLoaderClientHaiku::registerForIconNotification):
        (WebCore::FrameLoaderClientHaiku::savePlatformDataToCachedFrame):
        (WebCore::FrameLoaderClientHaiku::transitionToCommittedFromCachedFrame):
        (WebCore::FrameLoaderClientHaiku::transitionToCommittedForNewPage):
        * haiku/WebCoreSupport/FrameLoaderClientHaiku.h: Added.
        (WebCore::FrameLoaderClientHaiku::~FrameLoaderClientHaiku):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Maxime Simon <simon.maxime@gmail.com>
levin@chromium.org [Tue, 28 Jul 2009 18:58:45 +0000 (18:58 +0000)]
2009-07-28  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by David Levin.

        Added ChromeClient for Haiku WebCore support.
        https://bugs.webkit.org/show_bug.cgi?id=26952

        * haiku/WebCoreSupport/ChromeClientHaiku.cpp: Added.
        (WebCore::ChromeClientHaiku::ChromeClientHaiku):
        (WebCore::ChromeClientHaiku::~ChromeClientHaiku):
        (WebCore::ChromeClientHaiku::chromeDestroyed):
        (WebCore::ChromeClientHaiku::setWindowRect):
        (WebCore::ChromeClientHaiku::windowRect):
        (WebCore::ChromeClientHaiku::pageRect):
        (WebCore::ChromeClientHaiku::scaleFactor):
        (WebCore::ChromeClientHaiku::focus):
        (WebCore::ChromeClientHaiku::unfocus):
        (WebCore::ChromeClientHaiku::canTakeFocus):
        (WebCore::ChromeClientHaiku::takeFocus):
        (WebCore::ChromeClientHaiku::createWindow):
        (WebCore::ChromeClientHaiku::createModalDialog):
        (WebCore::ChromeClientHaiku::show):
        (WebCore::ChromeClientHaiku::canRunModal):
        (WebCore::ChromeClientHaiku::runModal):
        (WebCore::ChromeClientHaiku::setToolbarsVisible):
        (WebCore::ChromeClientHaiku::toolbarsVisible):
        (WebCore::ChromeClientHaiku::setStatusbarVisible):
        (WebCore::ChromeClientHaiku::statusbarVisible):
        (WebCore::ChromeClientHaiku::setScrollbarsVisible):
        (WebCore::ChromeClientHaiku::scrollbarsVisible):
        (WebCore::ChromeClientHaiku::setMenubarVisible):
        (WebCore::ChromeClientHaiku::menubarVisible):
        (WebCore::ChromeClientHaiku::setResizable):
        (WebCore::ChromeClientHaiku::addMessageToConsole):
        (WebCore::ChromeClientHaiku::canRunBeforeUnloadConfirmPanel):
        (WebCore::ChromeClientHaiku::runBeforeUnloadConfirmPanel):
        (WebCore::ChromeClientHaiku::closeWindowSoon):
        (WebCore::ChromeClientHaiku::runJavaScriptAlert):
        (WebCore::ChromeClientHaiku::runJavaScriptConfirm):
        (WebCore::ChromeClientHaiku::runJavaScriptPrompt):
        (WebCore::ChromeClientHaiku::setStatusbarText):
        (WebCore::ChromeClientHaiku::shouldInterruptJavaScript):
        (WebCore::ChromeClientHaiku::tabsToLinks):
        (WebCore::ChromeClientHaiku::windowResizerRect):
        (WebCore::ChromeClientHaiku::repaint):
        (WebCore::ChromeClientHaiku::scroll):
        (WebCore::ChromeClientHaiku::screenToWindow):
        (WebCore::ChromeClientHaiku::windowToScreen):
        (WebCore::ChromeClientHaiku::platformWindow):
        (WebCore::ChromeClientHaiku::contentsSizeChanged):
        (WebCore::ChromeClientHaiku::scrollRectIntoView):
        (WebCore::ChromeClientHaiku::addToDirtyRegion):
        (WebCore::ChromeClientHaiku::scrollBackingStore):
        (WebCore::ChromeClientHaiku::updateBackingStore):
        (WebCore::ChromeClientHaiku::mouseDidMoveOverElement):
        (WebCore::ChromeClientHaiku::setToolTip):
        (WebCore::ChromeClientHaiku::print):
        (WebCore::ChromeClientHaiku::exceededDatabaseQuota):
        (WebCore::ChromeClientWx::reachedMaxAppCacheSize):
        (WebCore::ChromeClientHaiku::requestGeolocationPermissionForFrame):
        (WebCore::ChromeClientHaiku::runOpenPanel):
        (WebCore::ChromeClientHaiku::setCursor):
        (WebCore::ChromeClientHaiku::formStateDidChange):
        (WebCore::ChromeClientHaiku::createHTMLParserQuirks):
        * haiku/WebCoreSupport/ChromeClientHaiku.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Jul 2009 17:34:41 +0000 (17:34 +0000)]
2009-07-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Nuke all references to JSWorkerContextBase.lut.h, it was removed
        back in April.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>
hausmann@webkit.org [Tue, 28 Jul 2009 16:52:15 +0000 (16:52 +0000)]
2009-07-28  Robert Agoston  <Agoston.Robert@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Fixed references to script generate-webkitversion.pl, and
        removed duplicated generate-webkitversion.pl

        https://bugs.webkit.org/show_bug.cgi?id=27158

        * WebCore.pro:
        * platform/generate-webkitversion.pl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 28 Jul 2009 16:04:34 +0000 (16:04 +0000)]
2009-07-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dmitry Glazkov.

        Web Inspector: encapsulate ScriptState into the ScriptObject, get rid of
        InspectorJSONObject.

        https://bugs.webkit.org/show_bug.cgi?id=27766

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/ScriptArray.cpp:
        (WebCore::ScriptArray::ScriptArray):
        (WebCore::ScriptArray::set):
        (WebCore::ScriptArray::length):
        (WebCore::ScriptArray::createNew):
        * bindings/js/ScriptArray.h:
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::construct):
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::ScriptObject):
        (WebCore::ScriptObject::set):
        (WebCore::ScriptObject::createNew):
        (WebCore::ScriptGlobalObject::get):
        * bindings/js/ScriptObject.h:
        * bindings/js/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject):
        * bindings/v8/ScriptArray.cpp:
        (WebCore::ScriptArray::ScriptArray):
        (WebCore::ScriptArray::set):
        (WebCore::ScriptArray::length):
        (WebCore::ScriptArray::createNew):
        * bindings/v8/ScriptArray.h:
        * bindings/v8/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::construct):
        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptObject::ScriptObject):
        (WebCore::ScriptObject::set):
        (WebCore::ScriptObject::createNew):
        (WebCore::ScriptGlobalObject::get):
        * bindings/v8/ScriptObject.h:
        (WebCore::ScriptObject::ScriptObject):
        * bindings/v8/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::bind):
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::newScriptArray):
        (WebCore::InspectorFrontend::newScriptObject):
        (WebCore::InspectorFrontend::addMessageToConsole):
        (WebCore::InspectorFrontend::addResource):
        (WebCore::InspectorFrontend::updateResource):
        (WebCore::InspectorFrontend::addDatabase):
        (WebCore::InspectorFrontend::addDOMStorage):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorJSONObject.cpp: Removed.
        * inspector/InspectorJSONObject.h: Removed.
        * inspector/InspectorResource.cpp:
        (WebCore::populateHeadersObject):
        (WebCore::InspectorResource::createScriptObject):
        (WebCore::InspectorResource::updateScriptObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 28 Jul 2009 15:35:41 +0000 (15:35 +0000)]
2009-07-28  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        cpplint* should be named cpp_style*
        https://bugs.webkit.org/show_bug.cgi?id=27752

        The files were renamed. A few renames were done:
          CppLint -> CppStyle
          cpplint -> cpp_style

        * Scripts/check-webkit-style:
        * Scripts/modules/cpp_style.py: Copied from cpplint.py and
          did name fix ups.
        * Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and
          did name fix ups.
        * Scripts/modules/cpplint.py: Removed.
        * Scripts/modules/cpplint_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
zimmermann@webkit.org [Tue, 28 Jul 2009 15:34:05 +0000 (15:34 +0000)]
2009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] Variable substitution recursion seems to have bugs
        https://bugs.webkit.org/show_bug.cgi?id=27726

        Allow <setvar> elements to depend on the value specified by preceeding <setvar> elements.
        Required by the specification - assure it only works in linear order. A setvar element may
        not depend on the variable state of a following setvar element, only the previous ones.

        Extend wml/variable-reference-valid.html layout test to cover these cases.

        * wml/WMLTaskElement.cpp:
        (WebCore::WMLTaskElement::storeVariableState):

2009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] Variable substitution recursion seems to have bugs
        https://bugs.webkit.org/show_bug.cgi?id=27726

        Extend variable-reference-valid.html to test <setvar> attribute values depending on each other.

        * wml/resources/variable-reference-valid.js:
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/variable-reference-valid-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
zimmermann@webkit.org [Tue, 28 Jul 2009 15:03:09 +0000 (15:03 +0000)]
2009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] Page title doesn't update after variable substitution, if it contained variables
        https://bugs.webkit.org/show_bug.cgi?id=27725

        Fix bug in containsVariableReference() function, we we're decreasing the nameEndPosition
        too much, leading to a bug with 1-char variable names, which were not detected properly.

        Extend wml/variable-reference-valid.html layout test to cover 1-char variable names.
        Also fixes manual-tests/wml/task-refresh-in-anchor.wml, which happened to use 1-char variable names.

        * wml/WMLVariables.cpp:
        (WebCore::containsVariableReference):

2009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] Page title doesn't update after variable substitution, if it contained variables
        https://bugs.webkit.org/show_bug.cgi?id=27725

        Extend variable-reference-valid.html test to include one-character variable tests.

        * wml/resources/variable-reference-valid.js:
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/variable-reference-valid-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Tue, 28 Jul 2009 14:58:54 +0000 (14:58 +0000)]
WebCore:

2009-07-28  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Simon Hausmann.

        Add WebKit version API to Qt.

        Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
        at compile time and make it available to webkit ports through WebKitVersion.h.

        https://bugs.webkit.org/show_bug.cgi?id=27158

        * WebCore.pro: Call generate-webkitversion.pl

WebKit:

2009-07-28  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Simon Hausmann.

        Add WebKit version API to Qt.

        Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
        at compile time and make it available to webkit ports through WebKitVersion.h.

        https://bugs.webkit.org/show_bug.cgi?id=27158

        * scripts/generate-webkitversion.pl: Added

WebKit/qt:

2009-07-28  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Simon Hausmann.

        Add WebKit version API to Qt.

        Get the current version of WebKit from WebKit/mac/Configurations/Version.xcconfig
        at compile time and make it available to Qt applications through
        qWebKitVersion().

        Also amend the User Agent string to place the Safari clause outside
        the final bracket and to the end of the UA string.

        https://bugs.webkit.org/show_bug.cgi?id=27158

        Minor build tweak by Simon Hausmann (adding export macros to new functions).

        * Api/headers.pri:
        * Api/qwebkitversion.cpp: Added.
        (webKitVersion):
        (webKitMajorVersion):
        (webKitMinorVersion):
        * Api/qwebkitversion.h: Added.
        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):
        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::getWebKitVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 28 Jul 2009 14:57:46 +0000 (14:57 +0000)]
2009-07-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

Unreviewed make dist build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Mike Fenton <mike.fenton@torchmobile.com>
treat@webkit.org [Tue, 28 Jul 2009 14:41:33 +0000 (14:41 +0000)]
2009-07-28  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Replace hardcoded separator text with proper separator.
        Also adjusts include order as per style guidelines.

        https://bugs.webkit.org/show_bug.cgi?id=27763

        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 28 Jul 2009 14:26:49 +0000 (14:26 +0000)]
2009-07-28  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        Fix compilation with the precompiled header.

        * WebKit_pch.h: Don't include JSDOMBinding.h and MathObject.h,
        as they include AtomicString.h. AtomicString.cpp needs to enable
        a #define before including AtomicString.h, which breaks if the PCH
        forces the inclusion beforehand.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Jul 2009 13:34:03 +0000 (13:34 +0000)]
2009-07-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Use automake 1.11 SILENT_RULES when present, for cleaner build
        output. You can disable it by passing --disable-silent-rules to
        configure or V=1 to make.

        * autotools/dolt.m4:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 28 Jul 2009 13:33:23 +0000 (13:33 +0000)]
2009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Steve Falkenburg.

        Add output directory for VS pre-build steps to enable out-of-tree builds

        https://bugs.webkit.org/show_bug.cgi?id=27700

        The tmp.obj file is now placed in the intermediate build directory.

        * WebCore.vcproj/WebCoreCommon.vsprops:

2009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Steve Falkenburg.

        Add output directory for VS pre-build steps to enable out-of-tree builds

        https://bugs.webkit.org/show_bug.cgi?id=27700

        The tmp.obj file is now placed in the intermediate build directory.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 28 Jul 2009 13:30:36 +0000 (13:30 +0000)]
2009-07-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Add inspected node using public console API.

        https://bugs.webkit.org/show_bug.cgi?id=27758

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype.addInspectedNode):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Tue, 28 Jul 2009 13:26:14 +0000 (13:26 +0000)]
2009-07-28  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        Added tests to ensure that scroll position can be changed
        programmatically, even when the scroll bar policy is set to off.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 28 Jul 2009 13:23:42 +0000 (13:23 +0000)]
2009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Rubber-stamped by Holger Freyther.

        Add Steve Falkenburg to bugzilla-tools' reviewers list

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 28 Jul 2009 13:12:24 +0000 (13:12 +0000)]
2009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Fix a few compilation warnings in the QWebFrame tests.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Andre Pedralho <andre.pedralho@openbossa.org>
hausmann@webkit.org [Tue, 28 Jul 2009 13:04:32 +0000 (13:04 +0000)]
2009-07-28  Andre Pedralho  <andre.pedralho@openbossa.org>

         Reviewed by Simon Hausmann.

         Fixed tst_QWebFrame::hasSetFocus test which was using
         an undefined resource.
         https://bugs.webkit.org/show_bug.cgi?id=27512

         * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
zimmermann@webkit.org [Tue, 28 Jul 2009 12:47:27 +0000 (12:47 +0000)]
2009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] <do> elements with a <noop> task shouldn't be exposed to the user
        https://bugs.webkit.org/show_bug.cgi?id=27724

        Fix WMLNoopElement to disable it's parent WMLDoElement, as required by the spec.
        Moved manual-tests/wml/task-noop-in-do.wml to LayoutTests/fast/wml/task-noop-in-do.wml.

        * manual-tests/wml/task-noop-in-do.wml: Removed.
        * wml/WMLNoopElement.cpp:
        (WebCore::WMLNoopElement::insertedIntoDocument):

2009-07-28  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] <do> elements with a <noop> task shouldn't be exposed to the user
        https://bugs.webkit.org/show_bug.cgi?id=27724

        Add new layout test covering noop elements in do elements.

        * fast/wml/task-noop-in-do.wml: Copied from WebCore/manual-tests/wml/task-noop-in-do.wml.
        * platform/mac/fast/wml/task-noop-in-do-expected.checksum: Added.
        * platform/mac/fast/wml/task-noop-in-do-expected.png: Added.
        * platform/mac/fast/wml/task-noop-in-do-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Jul 2009 12:40:33 +0000 (12:40 +0000)]
2009-07-28  Xan Lopez  <xlopez@igalia.com>

        Add new files, fixes distcheck.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
hausmann@webkit.org [Tue, 28 Jul 2009 12:35:02 +0000 (12:35 +0000)]
2009-07-28  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Determining whether to use JIT or interpreter
        moved from JavaScriptCore.pri to Platform.h

        * JavaScriptCore.pri:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.:
hausmann@webkit.org [Tue, 28 Jul 2009 12:27:00 +0000 (12:27 +0000)]
.:

2009-07-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Disable some compiler warnings for the win build
        https://bugs.webkit.org/show_bug.cgi?id=27709

        * WebKit.pri:

WebCore:

2009-07-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Disable some compiler warnings for the win build
        https://bugs.webkit.org/show_bug.cgi?id=27709

        * WebCore.pro: Move the msvc options to WebKit.pri

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-28 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
hausmann@webkit.org [Tue, 28 Jul 2009 11:48:40 +0000 (11:48 +0000)]
2009-07-28  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Implement test result archive support for the Qt port.

        * BuildSlaveSupport/test-result-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46470 268f45cc-cd09-0410-ab3c-d52691b4dbfc