WebKit-https.git
13 years agohttp/tests/incremental/slow-utf8-html-diffs.txt
ap [Sun, 3 Sep 2006 17:28:07 +0000 (17:28 +0000)]
http/tests/incremental/slow-utf8-html-diffs.txt
Set executable bit that was lost when re-applying the patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
ap [Sun, 3 Sep 2006 16:59:12 +0000 (16:59 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10697
        REGRESSION (r16175): Errors in incremental decoding of UTF-8

        Tests:
        - http/tests/incremental/slow-utf8-html.pl
        - fast/encoding/charset-invalid.html

        * loader/Decoder.cpp:
        (Decoder::Decoder): Ensure that we have a valid encoding. Get its name via TextEncoding, to match
        the logic in setEncodingName().
        (Decoder::setEncodingName): Only set m_encodingName if the encoding is valid. Rely on TextEncoding
        constructor to lowercase it if necessary.
        (Decoder::decode): Use setEncodingName() to apply encoding from BOM. Don't try to ensure the
        validity of encoding - it is enforced by class constructor and setEncodingName().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes build for regression tests.
weinig [Sun, 3 Sep 2006 13:45:00 +0000 (13:45 +0000)]
Fixes build for regression tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
ap [Sun, 3 Sep 2006 09:25:59 +0000 (09:25 +0000)]
    Reviewed by Tim H.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=4508
        Layout tests access an external server

        * fast/backgrounds/repeat/noRepeatCorrectClip.html: Use a local resource (it was already present,
        but the test still pointed to a remote one).
        * fast/dom/HTMLImageElement/image-src-absolute-url-expected.txt:
        * fast/dom/HTMLImageElement/image-src-absolute-url.html: Use a non-existent file URL instead of
        a non-existent http one.
        * fast/loader/docLoaderFrame-expected.checksum: Removed.
        * fast/loader/docLoaderFrame-expected.png: Removed.
        * fast/loader/docLoaderFrame-expected.txt: Removed.
        * fast/loader/docLoaderFrame.html: Removed.
        * http/tests/xmlhttprequest/docLoaderFrame-expected.txt: Added.
        * http/tests/xmlhttprequest/docLoaderFrame.html: Added.
        * http/tests/xmlhttprequest/resources/docLoaderFrame-data.html: Added.
        Use a local resource. Also, turned the test into a text one, and used waitUntilDone to make it
        actually work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Sun, 3 Sep 2006 02:10:16 +0000 (02:10 +0000)]
WebCore:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684
          Auto-generate the Objective-C DOM CSS bindings

          Auto-generates DOMCSSCharsetRule, DOMCSSFontFaceRule, DOMCSSImportRule,
          DOMCSSMediaRule, DOMCSSPageRule, DOMCSSPrimitiveValue, DOMCSSRule,
          DOMCSSRuleList, DOMCSSStyleDeclaration, DOMCSSStyleRule, DOMCSSStyleSheet,
          DOMCSSUnknownRule, DOMCSSValue, DOMCSSValueList, DOMCounter, and DOMRect.

          Splits DOMRGBColor into its own files.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMCSS.h:
        * bindings/objc/DOMCSS.mm:
        (+[DOMCSSStyleSheet _CSSStyleSheetWith:]):
        (+[DOMCSSPrimitiveValue _valueWith:]):
        * bindings/objc/DOMCSSInternal.h:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMRGBColor.h: Added.
        * bindings/objc/DOMRGBColor.mm: Added.
        (getWrapperForRGB):
        (setWrapperForRGB):
        (removeWrapperForRGB):
        (-[DOMRGBColor dealloc]):
        (-[DOMRGBColor finalize]):
        (-[DOMRGBColor red]):
        (-[DOMRGBColor green]):
        (-[DOMRGBColor blue]):
        (-[DOMRGBColor alpha]):
        (-[DOMRGBColor color]):
        (-[DOMRGBColor _initWithRGB:WebCore::]):
        (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSCharsetRule.idl: Added.
        * css/CSSFontFaceRule.idl: Added.
        * css/CSSImportRule.idl: Added.
        * css/CSSMediaRule.idl: Added.
        * css/CSSPageRule.idl: Added.
        * css/CSSRule.idl:
        * css/CSSStyleDeclaration.idl:
        * css/CSSStyleRule.idl: Added.
        * css/CSSStyleSheet.idl: Added.
        * css/CSSUnknownRule.idl: Added.
        * css/CSSValue.idl:
        * css/MediaList.idl:
        * css/RGBColor.idl: Added.
        * css/Rect.idl:
        * css/RectImpl.h:

WebKit:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684
          Auto-generate the Objective-C DOM CSS bindings

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
thatcher [Sat, 2 Sep 2006 19:19:28 +0000 (19:19 +0000)]
LayoutTests:

        Reviewed by Justin.

        Testcase for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
        AppleStyleCommand::applyBlockStyle crash

        * editing/style/table-selection-expected.checksum: Added.
        * editing/style/table-selection-expected.png: Added.
        * editing/style/table-selection-expected.txt: Added.
        * editing/style/table-selection.html: Added.

WebCore:

        Reviewed by Justin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
        AppleStyleCommand::applyBlockStyle crash

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle): Prevent a crash by
        making sure that the 'beyondEnd' node is after the start node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
thatcher [Sat, 2 Sep 2006 19:15:52 +0000 (19:15 +0000)]
JavaScriptCore:

        Reviewed by Tim H.

        Bug 10454: Unix bakefile fixes
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

        * JavaScriptCoreSources.bkl:

WebCore:

        Reviewed by Tim H.

        Bug 10454: Unix bakefile fixes
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

        * WebCoreSources.bkl:
        * platform/gdk/RenderPopupMenuGdk.cpp:
        (WebCore::RenderPopupMenuGdk::RenderPopupMenuGdk):
        * platform/gdk/RenderPopupMenuGdk.h:
        * platform/gdk/RenderThemeGdk.cpp:
        (WebCore::RenderThemeGdk::createPopupMenu):
        (WebCore::RenderThemeGdk::systemFont):
        * platform/gdk/RenderThemeGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        * webcore-base.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
adele [Sat, 2 Sep 2006 17:25:46 +0000 (17:25 +0000)]
    Reviewed by Anders.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10667
          Password: Double-click should select-all to avoid exposing word boundaries

        Test: fast/forms/password-doubleclick-selection.html

        * editing/visible_units.cpp:
        (WebCore::previousBoundary): When searching for boundaries in renderers that use the textSecurity property,
         convert characters in strings to alpha-numeric characters (in this case, all 'x's) so that every character
         isn't treated as a punctuation boundary.
        (WebCore::nextBoundary): ditto.
        * editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Updated to use the renderer's
          string instead of the node value.  This matches the base class implementation of handleTextNode.

        Code cleanup.
        * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
          Avoid unnecessary check for password field case if the smart replace condition is false.
        * page/Frame.cpp: (WebCore::Frame::mayCopy): Removed duplicate code.  Calls isSelectionInPasswordField now.
        * rendering/RenderText.cpp: (WebCore::RenderText::setText): Updated formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for 10682, refine the FOUC paint suppression logic so that it
hyatt [Sat, 2 Sep 2006 01:43:36 +0000 (01:43 +0000)]
    Fix for 10682, refine the FOUC paint suppression logic so that it
        is only triggered when FOUC would really have occurred.

        Reviewed by aroben

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::styleForElement):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::updateLayoutIgnorePendingStylesheets):
        (WebCore::Document::updateStyleSelector):
        * dom/Document.h:
        (WebCore::Document::haveStylesheetsLoaded):
        (WebCore::Document::):
        (WebCore::Document::didLayoutWithPendingStylesheets):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintChildren):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-01 MorganL <morlmor@yahoo.com>
aroben [Sat, 2 Sep 2006 01:10:26 +0000 (01:10 +0000)]
2006-09-01  MorganL  <morlmor@yahoo.com>

        Reviewed by Darin. Updated/landed by Adam.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10553
        Windows build fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Omernick
beidson [Sat, 2 Sep 2006 00:57:49 +0000 (00:57 +0000)]
    Reviewed by Tim Omernick

        Added an SQLDatabase logging channel.  Changed all SQLDatabase and SQLStatement errors to use this new channel.
        Also, as a popular request from other contributers, added a log for all prepare(), step(), finalize(), and reset()s
        Also, fixed a grammar error in my previous ChangeLog entry.

        * bridge/mac/WebCorePageBridge.mm:
        (initializeLoggingChannelsIfNecessary): Initialize the new channel
        * loader/icon/SQLDatabase.cpp:
        (WebCore::SQLDatabase::setBusyTimeout): Use SQLDatabase logging channel
        (WebCore::SQLDatabase::setBusyHandler): ditto
        (WebCore::SQLDatabase::clearAllTables): ditto
        (WebCore::SQLDatabase::runVacuumCommand): ditto
        * loader/icon/SQLStatement.cpp:
        (WebCore::SQLStatement::prepare): Added a log
        (WebCore::SQLStatement::step): ditto
        (WebCore::SQLStatement::finalize): ditto
        (WebCore::SQLStatement::reset): ditto
        (WebCore::SQLStatement::getColumnBlob): Use SQLDatabase logging channel
        (WebCore::SQLStatement::returnTextResults): ditto
        (WebCore::SQLStatement::returnTextResults16): ditto
        (WebCore::SQLStatement::returnIntResults): ditto
        (WebCore::SQLStatement::returnInt64Results): ditto
        (WebCore::SQLStatement::returnDoubleResults): ditto
        * platform/Logging.cpp:
        (WebCore::): Added new logging channel
        * platform/Logging.h: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Sat, 2 Sep 2006 00:55:34 +0000 (00:55 +0000)]
LayoutTests:

        Reviewed by Tim Omernick.

        Updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=6990
        Switch to use new text field implementation for <input type="password">

        * dom/html/level2/html/HTMLInputElement22-expected.txt:
        * dom/xhtml/level2/html/HTMLInputElement22-expected.txt:
        * fast/events/event-sender-mouse-click.html:
        * fast/forms/input-appearance-height-expected.checksum:
        * fast/forms/input-appearance-height-expected.txt:
        * fast/forms/input-type-change-in-onfocus-mouse-expected.txt:
        * fast/forms/input-value-expected.checksum:
        * fast/forms/input-value-expected.png:
        * fast/forms/input-value-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
        * tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

        Updated from switch to style-able selects
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.png:
        * fast/forms/option-strip-whitespace-expected.txt:

WebCore:

        Reviewed by Tim Omernick.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6990
        Switch to use new text field implementation for <input type="password">

        * css/html4.css: Give input[password] the same style properties as normal text fields.
        * html/HTMLInputElement.cpp: Removed checks for TextFieldAppearance.
        (WebCore::HTMLInputElement::selectionStart):
        (WebCore::HTMLInputElement::selectionEnd):
        (WebCore::HTMLInputElement::setSelectionStart):
        (WebCore::HTMLInputElement::setSelectionEnd):
        (WebCore::HTMLInputElement::select):
        (WebCore::HTMLInputElement::setSelectionRange):
        (WebCore::HTMLInputElement::createRenderer):
        * html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John (though Sarge review a previous patch of mine in an attempt...
beidson [Sat, 2 Sep 2006 00:03:47 +0000 (00:03 +0000)]
    Reviewed by John (though Sarge review a previous patch of mine in an attempt to review this one)

        Added some constants for SQL Result Codes to SQLDatabase.h
        This way, users of SQLDatabase can access all necessary SQLite functionality
        without having access to sqlite3.h.
        Also reordered some files in the xcodeproj and some #includes

        * WebCore.xcodeproj/project.pbxproj:  Reordered some files
        * loader/icon/IconDataCache.cpp:
        (WebCore::IconDataCache::writeToDatabase): Use our new result codes
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::sharedIconDatabase): Use our new result codes
        (WebCore::IconDatabase::retainIconForPageURL): Use our new result codes
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Use our new result codes
        (WebCore::IconDatabase::addIconForIconURLQuery): Use our new result codes
        (WebCore::IconDatabase::hasIconForIconURLQuery): Use our new result codes
        * loader/icon/SQLDatabase.cpp:
        (WebCore::SQLDatabase::lastError): Moved from header to eliminate dependency on sqlite3.h in header
        (WebCore::SQLDatabase::lastErrorMsg): Ditto
        * loader/icon/SQLDatabase.h: Removed #include <sqlite3.h>
        * loader/icon/SQLStatement.cpp: Added #include <sqlite3.h>
        * loader/icon/SQLStatement.h: Removed #include <sqlite3.h>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMy ChangeLog grammar needs reviewing, apparently (fixed last ChangeLog)
beidson [Fri, 1 Sep 2006 23:53:55 +0000 (23:53 +0000)]
My ChangeLog grammar needs reviewing, apparently (fixed last ChangeLog)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
beidson [Fri, 1 Sep 2006 23:20:19 +0000 (23:20 +0000)]
    Reviewed by Darin

        A "never should be reach" method was reached - lets not release the shared database bridge, esp
        since we never retain it!

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase _applicationWillTerminate:]): Don't release the bridge

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd flexbox test.
hyatt [Fri, 1 Sep 2006 22:57:05 +0000 (22:57 +0000)]
Add flexbox test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for 10680, contrained flexbox is not shrinking flexible children
hyatt [Fri, 1 Sep 2006 22:56:06 +0000 (22:56 +0000)]
    Fix for 10680, contrained flexbox is not shrinking flexible children
        properly.  (Fixing in case it's hit by the file upload control.)

        Reviewed by aroben

        Adding 026.html to fast/flexbox.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::allowedChildFlex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-01 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Fri, 1 Sep 2006 21:52:12 +0000 (21:52 +0000)]
2006-09-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Implement support for multiple parents in the SVG idls.

        For class "FooBar" go through all parents recursively,
        collect their attributes & functions & constants and
        add them directly into the class "FooBar".

        (Note: It is NOT enabled by default for now - still some things related to SVGAnimated* need to be solved first)

        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/generate-bindings.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-02 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Fri, 1 Sep 2006 21:50:06 +0000 (21:50 +0000)]
2006-09-02  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by hyatt.  Landed by eseidel.

        Fix build on Linux.

        * CMakeLists.txt: Add platform/CString.cpp.
        * platform/qt/FrameQt.cpp: Correct repsondToChangedContents() signature
        * platform/qt/FrameQt.h:: Correct respondToChangedContents() signature

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin [Fri, 1 Sep 2006 21:41:28 +0000 (21:41 +0000)]
WebCore:

        Reviewed by Brady.

        - a few small tweaks to the icon database bridge

        * bridge/mac/WebCoreIconDatabaseBridge.h: Removed unnecessary declarations.
        Renamed sharedBridgeInstance to sharedInstance.
        * bridge/mac/WebCoreIconDatabaseBridge.mm: Put functions inside WebCore namespace.
        (WebCore::IconDatabase::loadIconFromURL): Updated for sharedInstance namespace.

WebKit:

        Reviewed by Brady.

        - a few small tweaks to the icon database bridge

        * Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Updated for name change.

        * WebCoreSupport/WebIconDatabaseBridge.h: Removed unneeded declarations.
        * WebCoreSupport/WebIconDatabaseBridge.m:
        (-[WebIconDatabaseBridge init]): Added. Always returns nil since you're not supposed
        to allocate one of these.
        (-[WebIconDatabaseBridge _init]): Renamed from init. Used internally to make the
        shared instance. Added the "self = [super init]" idiom even though it's not important
        in this case just to be consistent.
        (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): Moved this up in the file
        so it can be called without declaring it in the header.
        (+[WebIconDatabaseBridge sharedInstance]): Renamed. Calls the new _init. Also use
        CFRetain for compatibility.
        (-[WebIconDatabaseBridge dealloc]): Emptied this out and made it just assert (false).
        (-[WebIconDatabaseBridge finalize]): Added and made it assert (false) too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
thatcher [Fri, 1 Sep 2006 21:21:32 +0000 (21:21 +0000)]
    Reviewed by Adele.

        Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10677

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
thatcher [Fri, 1 Sep 2006 20:09:18 +0000 (20:09 +0000)]
LayoutTests:

        Reviewed by Darin.

        - updated results, null is not round-tripped through the bindings
          because of regressions the original change caused in other applications.
        - added an echo for "undefined".

        * plugins/bindings-test-expected.txt:
        * plugins/bindings-test.html:

WebCore:

        Reviewed by Darin.

        <rdar://problem/4651318> REGRESSION: can't drag library items to widget in Dashcode
        <rdar://problem/4701626> REGRESSION: Unit Converter widget doesn't work convert data in its fields

        jsNull should not be returned as NSNull because existing applications do not
        expect that return value. Return as nil for backwards compatibility.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-01 Nikolas Zimmermann <zimmermann@kde.org>
ap [Fri, 1 Sep 2006 20:05:39 +0000 (20:05 +0000)]
2006-09-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by ap.

        Fix build on Linux (C89 without gcc extensions enabled).

        * pcre/pcre_internal.h: Use C style comments.
        * wtf/Assertions.h: Use C style comments.
        * wtf/Platform.h: Use C style comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
ap [Fri, 1 Sep 2006 19:48:28 +0000 (19:48 +0000)]
    Build fix.

        * loader/Decoder.cpp:
        (Decoder::Decoder): Use String::latin1().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
ap [Fri, 1 Sep 2006 19:36:06 +0000 (19:36 +0000)]
    Reviewed by Eric.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=5620
        Should only honor encoding from <meta> in HTML

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9783
        An XML declaration without an explicit encoding incorrectly triggers
        UTF-8 encoding in an HTML document

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=10155
        CSS2: @charset is not supported

WebCore:
        * loader/Decoder.cpp:
        (Decoder::Decoder): Decoder now knows what kind of content it is decoding.
        Also, the browser default encoding can now be passed directly to the constructor,
        to streamline the logic.
        (Decoder::decode): Add support for @charset, differentiate between HTML and XML.
        (Decoder::setEncodingName): Style cleanup.
        (Decoder::encodingName): Ditto.
        (Decoder::flush): Ditto.
        * loader/Decoder.h:
        (WebCore::Decoder::):

        * bridge/mac/WebCoreEncodings.mm: Pass a content type of text/html to Decoder.

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        (WebCore::CachedCSSStyleSheet::setCharset):
        (WebCore::CachedCSSStyleSheet::data):
        * loader/CachedCSSStyleSheet.h:
        Use Decoder instead of TextEncoding::toUnicode() to enable @charset support.

        * loader/CachedXBLDocument.cpp:
        (WebCore::CachedXBLDocument::CachedXBLDocument): Pass a content type.
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): Ditto.
        (WebCore::CachedXSLStyleSheet::data): Flush the decoder to be safe.

        * page/Frame.cpp:
        (WebCore::Frame::write): Pass a content type and a default encoding to
        the Decoder.
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource): Pass the output document
        MIME type.
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::receivedData): Ditto.

LayoutTests:
        * fast/encoding/css-charset-expected.txt: Added.
        * fast/encoding/css-charset.css: Added.
        * fast/encoding/css-charset.html: Added.
        * fast/encoding/css-charset-evil-expected.txt: Added.
        * fast/encoding/css-charset-evil.css: Added.
        * fast/encoding/css-charset-evil.html: Added.
        * fast/encoding/default-xhtml-encoding-expected.txt: Added.
        * fast/encoding/default-xhtml-encoding.xhtml: Added.
        * fast/encoding/meta-in-xhtml-expected.txt: Added.
        * fast/encoding/meta-in-xhtml.xhtml: Added.
        * fast/encoding/pseudo-xml-2-expected.txt: Added.
        * fast/encoding/pseudo-xml-2.html: Added.
        * fast/encoding/pseudo-xml-3-expected.txt: Added.
        * fast/encoding/pseudo-xml-3.html: Added.
        * fast/encoding/pseudo-xml-4-expected.txt: Added.
        * fast/encoding/pseudo-xml-4.html: Added.
        * fast/encoding/pseudo-xml-expected.txt: Added.
        * fast/encoding/pseudo-xml.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
adele [Fri, 1 Sep 2006 19:01:29 +0000 (19:01 +0000)]
    Reviewed by John.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10580
          Password: New secure text field allows non-Roman text entry

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode.
        (WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
        * bridge/mac/FrameMac.h: ditto.
        * page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
        * page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
adele [Fri, 1 Sep 2006 17:21:48 +0000 (17:21 +0000)]
    Reviewed by John.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10665
          Password: Disable smartReplace for new password fields

        * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
          Don't smart replace when the selection being replaces is in a password field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Fri, 1 Sep 2006 04:08:14 +0000 (04:08 +0000)]
WebCore:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10669
          Auto-generate the remaining Objective-C HTML DOM bindings

          Auto-generates DOMHTMLAnchorElement, DOMHTMLAreaElement,
          DOMHTMLBaseFontElement, DOMHTMLFontElement, DOMHTMLFrameElement,
          DOMHTMLFrameSetElement, DOMHTMLHRElement, DOMHTMLIFrameElement,
          DOMHTMLImageElement, DOMHTMLMapElement, DOMHTMLModElement,
          DOMHTMLObjectElement, DOMHTMLParamElement, DOMHTMLScriptElement,
          DOMHTMLTableCaptionElement, DOMHTMLTableCellElement,
          DOMHTMLTableColElement, DOMHTMLTableElement, DOMHTMLTableRowElement,
          and DOMHTMLTableSectionElement.

          Splits DOMHTMLAppletElement and DOMHTMLOptionElement into their own
          files.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLAnchorElement absoluteLinkURL]):
        (-[DOMHTMLImageElement altDisplayString]):
        (-[DOMHTMLImageElement absoluteImageURL]):
        (-[DOMHTMLImageElement WebCore::]):
        (-[DOMHTMLObjectElement absoluteImageURL]):
        (-[DOMHTMLObjectElement WebCore::]):
        (+[DOMHTMLTableCaptionElement _tableCaptionElementWith:]):
        (-[DOMHTMLTableCaptionElement _tableCaptionElement]):
        (+[DOMHTMLTableSectionElement _tableSectionElementWith:]):
        (-[DOMHTMLTableSectionElement _tableSectionElement]):
        (+[DOMHTMLTableElement _tableElementWith:]):
        (-[DOMHTMLTableElement _tableElement]):
        (+[DOMHTMLTableCellElement _tableCellElementWith:]):
        (-[DOMHTMLTableCellElement _tableCellElement]):
        * bindings/objc/DOMHTMLAppletElement.h: Added.
        * bindings/objc/DOMHTMLAppletElement.mm: Added.
        (-[DOMHTMLAppletElement WebCore::]):
        (-[DOMHTMLAppletElement align]):
        (-[DOMHTMLAppletElement setAlign:]):
        (-[DOMHTMLAppletElement alt]):
        (-[DOMHTMLAppletElement setAlt:]):
        (-[DOMHTMLAppletElement archive]):
        (-[DOMHTMLAppletElement setArchive:]):
        (-[DOMHTMLAppletElement code]):
        (-[DOMHTMLAppletElement setCode:]):
        (-[DOMHTMLAppletElement codeBase]):
        (-[DOMHTMLAppletElement setCodeBase:]):
        (-[DOMHTMLAppletElement height]):
        (-[DOMHTMLAppletElement setHeight:]):
        (-[DOMHTMLAppletElement hspace]):
        (-[DOMHTMLAppletElement setHspace:]):
        (-[DOMHTMLAppletElement name]):
        (-[DOMHTMLAppletElement setName:]):
        (-[DOMHTMLAppletElement object]):
        (-[DOMHTMLAppletElement setObject:]):
        (-[DOMHTMLAppletElement vspace]):
        (-[DOMHTMLAppletElement setVspace:]):
        (-[DOMHTMLAppletElement width]):
        (-[DOMHTMLAppletElement setWidth:]):
        * bindings/objc/DOMHTMLInternal.h:
        * bindings/objc/DOMHTMLOptionElement.h: Added.
        * bindings/objc/DOMHTMLOptionElement.mm: Added.
        (-[DOMHTMLOptionElement WebCore::]):
        (-[DOMHTMLOptionElement form]):
        (-[DOMHTMLOptionElement defaultSelected]):
        (-[DOMHTMLOptionElement setDefaultSelected:]):
        (-[DOMHTMLOptionElement text]):
        (-[DOMHTMLOptionElement index]):
        (-[DOMHTMLOptionElement disabled]):
        (-[DOMHTMLOptionElement setDisabled:]):
        (-[DOMHTMLOptionElement label]):
        (-[DOMHTMLOptionElement setLabel:]):
        (-[DOMHTMLOptionElement selected]):
        (-[DOMHTMLOptionElement setSelected:]):
        (-[DOMHTMLOptionElement value]):
        (-[DOMHTMLOptionElement setValue:]):
        * bindings/objc/DOMPrivate.h:
        * bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10669
          Auto-generate the remaining Objective-C HTML DOM bindings

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
aliceli1 [Fri, 1 Sep 2006 02:28:53 +0000 (02:28 +0000)]
LayoutTests:

        Reviewed by Darin.

        Revised expected results for an isindex element because of
        <rdar://problem/4463870> Switch to use new text field implementation for <isindex>
        Now the field is rendered as a textfield

        * fast/dom/isindex-002-expected.checksum:
        * fast/dom/isindex-002-expected.png:
        * fast/dom/isindex-002-expected.txt:

WebCore:

        Reviewed by Darin.

        Fixed <rdar://problem/4463870> Switch to use new text field implementation for <isindex>

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement _isTextField]):
        moved isindex from the list of nonTextInputTypes to the list of textInputTypes
        * css/html4.css:
        added isindex to certain rules that applied to input fields
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::canHaveSelection):
        (WebCore::HTMLInputElement::selectionStart):
        (WebCore::HTMLInputElement::selectionEnd):
        (WebCore::HTMLInputElement::setSelectionStart):
        (WebCore::HTMLInputElement::setSelectionEnd):
        (WebCore::HTMLInputElement::select):
        (WebCore::HTMLInputElement::setSelectionRange):
        (WebCore::HTMLInputElement::createRenderer):
        for the 8 methods above, moved the case for isindex to the same case as text
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isNonWidgetTextField):
        added isindex to this test
        * html/HTMLIsIndexElement.idl:
        HTMLIsIndexElement inherits from HTMLInputElement
        * rendering/RenderLineEdit.cpp:
        (WebCore::RenderLineEdit::RenderLineEdit):
        removed the case for isindex since we changed the renderer type from a RenderLineEdit
        to a RenderTextControl in WebCore::HTMLInputElement::createRenderer()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * Scripts/do-webcore-rename: Prepare for another round of renaming.
darin [Fri, 1 Sep 2006 01:57:17 +0000 (01:57 +0000)]
    * Scripts/do-webcore-rename: Prepare for another round of renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
harrison [Fri, 1 Sep 2006 01:13:35 +0000 (01:13 +0000)]
    Reviewed by Adele.

        <rdar://problem/4708119> REGRESSION: Cannot observe an AXTextField element directly

        ... and most of
        <rdar://problem/4708022> REGRESSION: TextRange-based attributes are missing from text fields
        <rdar://problem/4709515> REGRESSION: Expose text areas

        Remaining work for those two bugs in new bugs:

        <rdar://problem/4712101> Support NSAccessibilityVisibleCharacterRangeAttribute for AXTextField and AXTextArea elements
        <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
        <rdar://problem/4712125> Support setting NSAccessibilitySelectedTextAttribute for AXTextField and AXTextArea elements

        * bridge/AXObjectCache.h:
        (WebCore::AXObjectCache::postNotificationToElement):
        * bridge/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::postNotificationToElement):
        Removed postNotificationToTopWebArea.
        postNotification now posts to input element or top web area, as appropriate.
        postNotificationToElement posts to the specified element itself.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::respondToChangedContents):
        Take a selection.  Pass the starting position's renderer to postNotification so that postNotification can post to the appropriate input element, if any.

        * bridge/mac/WebCoreAXObject.h:
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject isWebArea]):
        (-[WebCoreAXObject isAnchor]):
        (-[WebCoreAXObject isTextRange]):
        New convenience methods.

        (-[WebCoreAXObject role]):
        (-[WebCoreAXObject roleDescription])
        (-[WebCoreAXObject value]):
        (-[WebCoreAXObject accessibilityDescription]):
        Support AXTextField and AXTextArea.

        (-[WebCoreAXObject accessibilityShouldUseUniqueId]):
        Register AXTextField and AXTextArea elements so notifications to them can be observed.

        (-[WebCoreAXObject accessibilityIsIgnored]):
        Use new convenience method isWebArea.

        (-[WebCoreAXObject accessibilityAttributeNames]):
        Simplify the array creation.
        Add text range support.

        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Add text range support.

        (-[WebCoreAXObject canSetFocusAttribute]):
        (-[WebCoreAXObject canSetValueAttribute]):
        (-[WebCoreAXObject canSetTextRangeAttributes]):
        New convenience methods.

        (-[WebCoreAXObject accessibilityIsAttributeSettable:]):
        (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
        Add text range support.

        (-[WebCoreAXObject observableObject]):
        New to locate text field or text area to notify.

        * dom/Document.cpp:
        (WebCore::Document::updateSelection):
        Post AXSelectedTextChanged notification with new selection's start node.
        postNotification will send it to the input element, if there is one, or the top WebArea.

        (WebCore::Document::implicitClose):
        Use postNotificationToElement now that it acts like the old postNotification.

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::appliedEditing):
        (WebCore::Frame::unappliedEditing):
        (WebCore::Frame::reappliedEditing):
        Pass the selection of interest to respondToChangedContents.

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        Use postNotificationToElement now that it acts like the old postNotification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-01 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 1 Sep 2006 01:12:35 +0000 (01:12 +0000)]
2006-09-01  Steve Falkenburg  <sfalken@apple.com>

        Fix build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/dftables/dftables.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Fri, 1 Sep 2006 00:17:45 +0000 (00:17 +0000)]
WebCore:

        Reviewed by Darin.

        WebCore part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
        Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionInPasswordField]): Added.
        * page/Frame.cpp: (WebCore::Frame::isSelectionInPasswordField): Added.
        * page/Frame.h:

WebKit:

        Reviewed by Darin.

        WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
        Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

        * DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
          Check that the selection isn't in a password field before adding these items to the default editing context menu.
              Search In Google, Search In Spotlight, Look up in Dictionary, Spelling, Font, Speech, Writing Direction
        * WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionInPasswordField]): Added.
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot the ChangeLog
andersca [Thu, 31 Aug 2006 23:43:23 +0000 (23:43 +0000)]
Forgot the ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-31 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 31 Aug 2006 22:59:26 +0000 (22:59 +0000)]
2006-08-31  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Add new portability functions to MathExtras.h and add StringExtras.h which is for
        string portability functions.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * bindings/c/c_instance.cpp:
        * kjs/date_object.cpp:
        * wtf/MathExtras.h:
        (copysign):
        (isfinite):
        * wtf/StringExtras.h: Added.
        (snprintf):
        (strncasecmp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-31 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 31 Aug 2006 22:55:47 +0000 (22:55 +0000)]
2006-08-31  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim H.

        Fix Windows build.

        * JavaScriptCore.vcproj/dftables/dftables.vcproj:
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix to avoid a property name conflict warning.
thatcher [Thu, 31 Aug 2006 22:44:15 +0000 (22:44 +0000)]
Build fix to avoid a property name conflict warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix ChangeLog
andersca [Thu, 31 Aug 2006 22:31:15 +0000 (22:31 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-31 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 31 Aug 2006 22:26:36 +0000 (22:26 +0000)]
2006-08-31  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim H, Hyatt.

        * WebCore.xcodeproj/project.pbxproj:
        Add KURLCFNet.cpp

        * platform/KURL.h:
        Get rid of include, add KURL constructor that takes a CFURLRef.

        * platform/PlatformString.h:
        * platform/StringImpl.h:
        Get rid of include.

        * platform/cf/KURLCFNet.cpp:
        (WebCore::KURL::KURL):
        Add constructor.

        * platform/cf/ResourceLoaderCFNet.cpp:
        Fix includes.

        * platform/cf/StringCF.cpp:
        (WebCore::String::createCFString):
        Move this here from PlatformString.h

        * platform/cf/StringImplCF.cpp:
        (WebCore::StringImpl::createCFString):
        Fix cast.

        * platform/mac/KURLMac.mm:
        Move createCFURL() to KURLCFNet.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake ScrollBar.cpp able to be compiled on Win32.
hyatt [Thu, 31 Aug 2006 21:59:35 +0000 (21:59 +0000)]
Make ScrollBar.cpp able to be compiled on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fixes for ppc64 and x86_64, and fixes needed now that we use -Wshorten-64-to-32.
thatcher [Thu, 31 Aug 2006 21:54:15 +0000 (21:54 +0000)]
Build fixes for ppc64 and x86_64, and fixes needed now that we use -Wshorten-64-to-32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRenamed an argument in a header for clarity (meant to go with last checkin)
beidson [Thu, 31 Aug 2006 21:52:30 +0000 (21:52 +0000)]
Renamed an argument in a header for clarity (meant to go with last checkin)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fixes for ppc64 and x86_64 now that we use -Wshorten-64-to-32.
thatcher [Thu, 31 Aug 2006 21:44:39 +0000 (21:44 +0000)]
Build fixes for ppc64 and x86_64 now that we use -Wshorten-64-to-32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
thatcher [Thu, 31 Aug 2006 21:28:29 +0000 (21:28 +0000)]
    Reviewed by Geoff.

        Band-aid fix for PCRE to compile for ppc64 and x86_64 now that
        we use -Wshorten-64-to-32. Adds an INT_CAST macro that ASSERTs
        the value <= INT_MAX.

        I filed <rdar://problem/4712064> to track the need to verify
        PCRE's 64-bit compliance.

        * pcre/pcre_compile.c:
        (complete_callout):
        (compile_branch):
        (compile_regex):
        (pcre_compile2):
        * pcre/pcre_exec.c:
        (match):
        (pcre_exec):
        * pcre/pcre_get.c:
        (pcre_get_substring_list):
        * pcre/pcre_internal.h:
        * pcre/pcre_tables.c:
        * pcre/pcre_try_flipped.c:
        (_pcre_try_flipped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John
beidson [Thu, 31 Aug 2006 21:26:07 +0000 (21:26 +0000)]
    Reviewed by John

        Cleaned up my last patch after further considerations

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Uses the new checkForDanglingPageURLs to check
          for and fix danglers.  Does so in all builds (changed from debug only in my last patch)
        (WebCore::IconDatabase::syncDatabase): Uses the new checkForDanglingPageURLs to check for danglers
        (WebCore::IconDatabase::checkForDanglingPageURLs): This checks and, if asked via an arg, prunes the dangling pageURLs
        * loader/icon/IconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-31 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 31 Aug 2006 21:05:51 +0000 (21:05 +0000)]
2006-08-31  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        Add CString. CString is a simple, null-terminated byte buffer that supports data
        sharing. Its main use is to be a better const char*.

        Also add latin1 and utf8 methods to String which returns CStrings.

        * platform/CString.cpp: Added.
        (WebCore::CString::CString):
        (WebCore::CString::init):
        (WebCore::CString::data):
        (WebCore::CString::length):
        (WebCore::CString::deprecatedCString):
        * platform/CString.h: Added.
        (WebCore::CStringBuffer::CStringBuffer):
        (WebCore::CStringBuffer::data):
        (WebCore::CStringBuffer::length):
        (WebCore::CString::CString):
        (WebCore::CString::operator const char*):
        (WebCore::CString::isNull):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::latin1):
        (WebCore::String::utf8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt
beidson [Thu, 31 Aug 2006 20:26:01 +0000 (20:26 +0000)]
    Reviewed by Hyatt

        Previously mentioned ASSERT was hit right away by folks, as we first need to bring their old icon.db into consistency
        Changed the ASSERT to a LOG_ERROR and added a method for debug builds to bring a DB back together.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Check for the danglers and prune them out
        (WebCore::IconDatabase::syncDatabase): Check for the danglers and log the error
        (WebCore::IconDatabase::pruneDanglingPageURLs): Prune the danglers
        * loader/icon/IconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix to avoid name conflicts with generated properties.
thatcher [Thu, 31 Aug 2006 18:22:54 +0000 (18:22 +0000)]
Build fix to avoid name conflicts with generated properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt
beidson [Thu, 31 Aug 2006 17:38:19 +0000 (17:38 +0000)]
    Reviewed by Hyatt

        Fixed an error where an Icon's IconID could change without the change being reflected in the PageURL table,
        causing icons to be pruned before their time and pages to lose their icons.  This is because I misunderstood
        how SQLite handles the "ON CONFLICT REPLACE" condition, which is to delete the row and re-insert instead of
        perform an update.  Also added an assertion to make sure this doesn't happen again.

        * loader/icon/IconDataCache.cpp:
        (WebCore::IconDataCache::writeToDatabase): Instead of one INSERT relying on SQLites conflict handling, broke
          this into an UPDATE attempt followed by the initial INSERT
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::createDatabaseTables): Slight tweak to the database schema to prevent this from happening
          in the future.  Note this change will not cause incompatibility with the current schema, therefore I didn't update
          the official database version number
        (WebCore::IconDatabase::syncDatabase): Added an ASSERT to look for this condition in the future
        * loader/icon/SQLDatabase.cpp:
        (WebCore::SQLDatabase::lastChanges): Added this SQLite accessor to see if an UPDATE command actually changed a row
        * loader/icon/SQLDatabase.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Thu, 31 Aug 2006 17:20:14 +0000 (17:20 +0000)]
WebCore:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653
          Auto-generate another 20 Objective-C DOM HTML bindings

          Auto-generates DOMHTMLBRElement, DOMHTMLButtonElement, DOMHTMLDListElement,
          DOMHTMLDirectoryElement, DOMHTMLDivElement, DOMHTMLFieldSetElement,
          DOMHTMLHeadingElement, DOMHTMLInputElement, DOMHTMLLIElement, DOMHTMLLabelElement,
          DOMHTMLLegendElement, DOMHTMLMenuElement, DOMHTMLOListElement, DOMHTMLOptGroupElement,
          DOMHTMLParagraphElement, DOMHTMLPreElement, DOMHTMLQuoteElement, DOMHTMLSelectElement,
          DOMHTMLTextAreaElement, and DOMHTMLUListElement.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement altDisplayString]):
        (-[DOMHTMLInputElement absoluteImageURL]):
        (-[DOMHTMLInputElement WebCore::]):
        (-[DOMHTMLInputElement _rectOnScreen]):
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
        (-[DOMHTMLInputElement _selectedRange]):
        (-[DOMHTMLInputElement _setAutofilled:]):
        * bindings/objc/DOMHTMLInternal.h:
        * bindings/objc/DOMPrivate.h:
        * bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653
          Auto-generate another 20 Objective-C DOM HTML bindings

        * MigrateHeaders.make:
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Thu, 31 Aug 2006 16:31:30 +0000 (16:31 +0000)]
WebCore:

        Reviewed by John Sullivan.

        Removing use of SPI in favor of Carbon API to enable and disable secure event input.

        * WebCore.exp: Removed wkSecureEventInput and wkSetSecureEventInput.
        * platform/mac/WebCoreSystemInterface.h: ditto.
        * platform/mac/WebCoreSystemInterface.mm: ditto.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setSecureKeyboardEntry): Uses EnableSecureEventInput and DisableSecureEventInput.
        (WebCore::FrameMac::secureKeyboardEntry): Uses IsSecureEventInputEnabled.

WebKit:

        Reviewed by John Sullivan.

        Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

        Reviewed by John Sullivan.

        Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Omernick
sullivan [Thu, 31 Aug 2006 16:25:26 +0000 (16:25 +0000)]
    Reviewed by Tim Omernick

        - fixed <rdar://problem/4711200> Loading history would be faster if it bypassed
        NSURL API for local files

        * History/WebHistory.m:
        (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
        Load file URLs using [NSDictionary dictionaryWithContentsOfFile:]. I also cleaned up some minor
        style issues in this method, and I removed the support for old NSArray-style history files (which we
        stopped using before Safari 1.0).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by "common sense" (and Maciej)
beidson [Thu, 31 Aug 2006 06:22:07 +0000 (06:22 +0000)]
    Reviewed by "common sense" (and Maciej)

        Fixed two logging typos

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::syncDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Adding missing nil check for focus node.
adele [Thu, 31 Aug 2006 02:09:49 +0000 (02:09 +0000)]
    Adding missing nil check for focus node.

        * page/Frame.cpp: (WebCore::Frame::setIsActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Thu, 31 Aug 2006 01:50:51 +0000 (01:50 +0000)]
WebCore:

        Reviewed by Hyatt.

        WebCore part of fix for  http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
        Enable secure input mode for new password fields

        * WebCore.exp: Added wkSetSecureEventInput and wkSecureEventInput.
        * platform/mac/WebCoreSystemInterface.h: ditto.
        * platform/mac/WebCoreSystemInterface.mm: ditto.

        * page/Frame.cpp: (WebCore::Frame::setIsActive): Enables and disables secure keyboard entry based on whether the frame becomes active.
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setSecureKeyboardEntry): Added. Calls wkSetSecureEventInput.
        (WebCore::FrameMac::secureKeyboardEntry): Added. Calls wkSecureEventInput.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::dispatchFocusEvent): For password fields, enable secure keyboard entry.
        (WebCore::HTMLInputElement::dispatchBlurEvent): For password fields, disable secure keyboard entry.
        * page/Frame.h:
        (WebCore::Frame::setSecureKeyboardEntry):
        (WebCore::Frame::secureKeyboardEntry):

WebKit:

        Reviewed by Hyatt.

        WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
        Enable secure input mode for new password fields

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

        Reviewed by Hyatt.

        Updated for http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
        Enable secure input mode for new password fields

        * WebKitSystemInterface.h: Added WKSetSecureEventInput and WKSecureEventInput;
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Thu, 31 Aug 2006 01:15:41 +0000 (01:15 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Thu, 31 Aug 2006 00:20:18 +0000 (00:20 +0000)]
    Reviewed by Tim Hatcher.

        - eliminated the need for UsesPassRefPtr in IDL files
        - got rid of the category mechanism for ObjC generated DOM headers
          (after discussions with Tim H where we decided it's not needed)
        - simplified use of macro inside ObjC generated code

        * ForwardingHeaders/wtf/GetPtr.h: Added.

        * bindings/scripts/CodeGeneratorObjC.pm: Removed code to handle
        categories. Eliminated use of DOM_cast since that's for the protection
        of human programmers -- the script won't make mistakes that it needs
        to catch. Changed macro to always be named IMPL instead of incorporating
        the class name. Use WTF::getPtr to extract the pointer, and removed the
        code that uses .get() to extract the pointer in the PassRefPtr case.

        * dom/Attr.idl: Removed all uses of UsesPassRefPtr and ObjCCatagory.
        * dom/DOMImplementation.idl: Ditto.
        * dom/Document.idl: Ditto.
        * dom/Element.idl: Ditto.
        * dom/NamedNodeMap.idl: Ditto.
        * html/HTMLDocument.idl: Ditto.
        * html/HTMLElement.idl: Ditto.
        * html/HTMLFormElement.idl: Ditto.
        * html/HTMLMapElement.idl: Ditto.
        * html/HTMLSelectElement.idl: Ditto.
        * html/HTMLTableElement.idl: Ditto.
        * html/HTMLTableRowElement.idl: Ditto.
        * html/HTMLTableSectionElement.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Thu, 31 Aug 2006 00:12:08 +0000 (00:12 +0000)]
    Reviewed by Tim Hatcher.

        - add WTF::getPtr, a function template that makes it possible to write
          generic code that gets a raw pointer out of any of our pointer types

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/GetPtr.h: Added.
        * wtf/ListRefPtr.h: (WTF::getPtr): Added.
        * wtf/OwnArrayPtr.h: (WTF::getPtr): Added.
        * wtf/OwnPtr.h: (WTF::getPtr): Added.
        * wtf/PassRefPtr.h: (WTF::getPtr): Added.
        * wtf/RefPtr.h: (WTF::getPtr): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 30 Aug 2006 23:32:07 +0000 (23:32 +0000)]
WebCore:

        Reviewed by John

        <rdar://problem/4707718> - Instead of faking the user out with an in-memory icon database if their
        ~/Library/Safari/Icons is unwritable, we'll actually fail to open the icon database and the app will
        run as if it was disabled via a preference.
        Also took the opportunity to change some ASSERTS() to reasonable behavior

        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): NSLog on failure so the user has a chance to figure
          out there's a problem.
        (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
        (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): From here on, just replaced ASSERTS() with reasonable behavior
        (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
        (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
        (-[WebCoreIconDatabaseBridge retainIconForURL:]):
        (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
        (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
        (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
        (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
        (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open): If we fail to open, return false
        (WebCore::IconDatabase::~IconDatabase): cleanup better
        * loader/icon/IconDatabase.h:

WebKit:

        Reviewed by John

        <rdar://problem/4707718> Change behavior so if the WebCore::IconDatabase can't open, WebKit releases the bridge and
        continues on as if the IconDatabase is disabled.

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]): Release the bridge on failure to open
        * WebCoreSupport/WebIconDatabaseBridge.m:
        (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved static shared instance out as a global
        (-[WebIconDatabaseBridge dealloc]): Clear pointer to the shared instance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Wed, 30 Aug 2006 23:27:45 +0000 (23:27 +0000)]
    Reviewed by Darin.

        Simplify the header copies from WebCore and JavaScriptCore.
        Headers that need to be migrated from the other projects need
        to be added to MigrateHeaders.make.

        * MigrateHeaders.make: Added.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
harrison [Wed, 30 Aug 2006 22:09:16 +0000 (22:09 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4708007> REGRESSION: text field inside a webpage no longer has settable AXValueAttribute
        <rdar://problem/4707479> REGRESSION: controls inside a webpage no longer have settable AXFocusedAttribute

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject canSetFocusAttribute]):
        (-[WebCoreAXObject canSetValueAttribute]):
        New utility methods.  Text fields and buttons are focusable.
        Text fields can have their value set. We need not make
        popupbutton value settable because AppKit does not.

        (-[WebCoreAXObject accessibilityIsAttributeSettable:]):
        Call new utility methods.

        (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
        Set focus for text field or button.
        Set value for text field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bugs 9000 and 10606. Add code to suppress painting when
hyatt [Wed, 30 Aug 2006 21:46:29 +0000 (21:46 +0000)]
    Fix for bugs 9000 and 10606.  Add code to suppress painting when
        a FOUC situation would otherwise occur.  There will still typically be
        a flash to white, but at least the wrong content won't show.

        Reviewed by darin

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::updateLayoutIgnorePendingStylesheets):
        (WebCore::Document::preferredStylesheetSet):
        (WebCore::Document::selectedStylesheetSet):
        (WebCore::Document::setSelectedStylesheetSet):
        (WebCore::Document::stylesheetLoaded):
        (WebCore::Document::updateStyleSelector):
        * dom/Document.h:
        (WebCore::Document::haveStylesheetsLoaded):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintChildren):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):
        (WebCore::isSubframe):
        (WebCore::RenderLayer::hitTest):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix build for Drosera.
weinig [Wed, 30 Aug 2006 21:19:57 +0000 (21:19 +0000)]
Fix build for Drosera.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-31 Nikolas Zimmermann <zimmermann@kde.org>
rwlbuis [Wed, 30 Aug 2006 20:47:21 +0000 (20:47 +0000)]
2006-08-31  Nikolas Zimmermann  <zimmermann@kde.org>

         Reviewed by Eric. Landed by rwlbuis.

         Apply Rob's fixes in RenderPathQt too -> unbreak build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Wed, 30 Aug 2006 20:36:11 +0000 (20:36 +0000)]
WebCore:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10640
          Auto-generate 10 more Objective-C DOM HTML bindings

          Auto-generates DOMHTMLBaseElement, DOMHTMLBodyElement, DOMHTMLHeadElement,
          DOMHTMLHtmlElement, DOMHTMLIsIndexElement, DOMHTMLLinkElement,
          DOMHTMLMetaElement, DOMHTMLStyleElement and DOMHTMLTitleElement.

          Splits DOMHTMLDocument into it's own files.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMHTML.mm:
        * bindings/objc/DOMHTMLDocument.h: Added.
        * bindings/objc/DOMHTMLDocument.mm: Added.
        (-[DOMHTMLDocument WebCore::]):
        (-[DOMHTMLDocument title]):
        (-[DOMHTMLDocument setTitle:]):
        (-[DOMHTMLDocument referrer]):
        (-[DOMHTMLDocument domain]):
        (-[DOMHTMLDocument URL]):
        (-[DOMHTMLDocument body]):
        (-[DOMHTMLDocument setBody:]):
        (-[DOMHTMLDocument images]):
        (-[DOMHTMLDocument applets]):
        (-[DOMHTMLDocument links]):
        (-[DOMHTMLDocument forms]):
        (-[DOMHTMLDocument anchors]):
        (-[DOMHTMLDocument cookie]):
        (-[DOMHTMLDocument setCookie:]):
        (-[DOMHTMLDocument open]):
        (-[DOMHTMLDocument close]):
        (-[DOMHTMLDocument write:]):
        (-[DOMHTMLDocument writeln:]):
        (-[DOMHTMLDocument getElementById:]):
        (-[DOMHTMLDocument getElementsByName:]):
        (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]):
        (-[DOMHTMLDocument createDocumentFragmentWithText:]):
        * bindings/objc/DOMHTMLInternal.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * html/HTMLDocument.idl:

WebKit:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10640
          Auto-generate 10 more Objective-C DOM HTML bindings

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-30 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Wed, 30 Aug 2006 20:24:32 +0000 (20:24 +0000)]
2006-08-30  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.

        Use QColor <-> Color conversion operator, instead of faking it.

        * platform/qt/FontQt.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Wed, 30 Aug 2006 20:20:38 +0000 (20:20 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10586
        pointer-events has issues when things are not stroked/filled

        Add a param to fillContains/strokeContains to indicate
        whether we still want hit testing when there is no fill/stroke.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 30 Aug 2006 20:00:37 +0000 (20:00 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4700297>
        REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line

        Fixed:
        * editing/pasteboard/smart-paste-002-expected.checksum:
        * editing/pasteboard/smart-paste-002-expected.png:
        * editing/pasteboard/smart-paste-002-expected.txt:
        Added to demonstrate fix:
        * editing/pasteboard/4700297-expected.checksum: Added.
        * editing/pasteboard/4700297-expected.png: Added.
        * editing/pasteboard/4700297-expected.txt: Added.
        * editing/pasteboard/4700297.html: Added.
        Removed a superfluous style span:
        * editing/deleting/pruning-after-merge-1-expected.txt:
        * editing/pasteboard/interchange-newline-1-expected.txt:
        * editing/pasteboard/paste-text-019-expected.checksum:
        * editing/pasteboard/paste-text-019-expected.png:
        * editing/pasteboard/paste-text-019-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        Accidently checked in bad results yesterday:
        * editing/pasteboard/copy-paste-bidi-expected.txt:
        Equivalent render tree:
        * editing/pasteboard/smart-paste-001-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4700297>
        REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Rebalance whitespace
        around insertionPos before insertion because the content might
        cause a collapse, e.g. inserting <div>foo</div> at hello^ world.
        * editing/htmlediting.cpp:
        (WebCore::rebalanceWhitespaceInTextNode): Rebalance with all nbsps
        for simplicity, we can produce sequences of regular spaces and
        nbsps on serialization (10636).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-30 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Wed, 30 Aug 2006 19:37:39 +0000 (19:37 +0000)]
2006-08-30  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.

        The old solution was slow & does not work correctly.
        Move the QString -> DeprecatedString conversion into
        DeprectedString.cpp, to be able to access allocateHandle().

        * platform/DeprecatedString.cpp:
        (WebCore::DeprecatedString::DeprecatedString):
        * platform/qt/StringQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed/landed by Adam.
aroben [Wed, 30 Aug 2006 19:16:01 +0000 (19:16 +0000)]
    Reviewed/landed by Adam.

        Implement containsCharacters() / determinePitch() functions.

        * platform/qt/FontDataQt.cpp:
        (WebCore::FontData::containsCharacters):
        (WebCore::FontData::determinePitch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin's rubberstamp
beidson [Wed, 30 Aug 2006 18:58:52 +0000 (18:58 +0000)]
    Reviewed by Darin's rubberstamp

        We apparently have a fancy delateAllValues() helper for HashMap/Sets - I'll use that instead

        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::removeAllIcons):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ggaren.
ggaren [Wed, 30 Aug 2006 18:48:52 +0000 (18:48 +0000)]
    Reviewed by ggaren.

        - Verification of exceptions thrown in a plugin.  Test for bug 10114.
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/ObjCPlugin.m:
        (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
        (+[ObjCPlugin webScriptNameForSelector:]):
        (-[ObjCPlugin throwIfArgumentIsNotHello:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren [Wed, 30 Aug 2006 18:45:07 +0000 (18:45 +0000)]
JavaScriptCore:

        Reviewed, tweaked by ggaren.

        - Added storage and accessor functions for ExecState as a fix for
          http://bugzilla.opendarwin.org/show_bug.cgi?id=10114

        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        * kjs/ExecState.h:
        * kjs/context.h:
        (KJS::Context::setExecState):
        (KJS::Context::execState):

LayoutTests:

        Reviewed by ggaren.

        - Updated test to check for exceptions thrown in a plug-in.  This is
          a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10114.
        * plugins/bindings-test-expected.txt:
        * plugins/bindings-test.html:

WebCore:

        Reviewed, tweaked by ggaren.

        - Changed to use ExecState on current context rather than global.
          Part of the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10114
        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):
        (-[WebScriptObject setException:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Wed, 30 Aug 2006 18:32:40 +0000 (18:32 +0000)]
WebCore:

        Reviewed by Darin.

        - WebCore part of fix for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
        Disallow copy from new password fields

        * page/Frame.cpp: (WebCore::Frame::mayCopy): Added. Checks to see if the selection is within a password field.
        * page/Frame.h: Added mayCopy.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::handleMouseMoveEvent): Checks mayCopy before starting a drag.
        (WebCore::FrameMac::mayDHTMLCut): Renamed to match the bridge method.  This also checks mayCopy now.
        (WebCore::FrameMac::mayDHTMLCopy): ditto.
        (WebCore::FrameMac::tryDHTMLCut): ditto.
        (WebCore::FrameMac::tryDHTMLCopy): ditto.
        (WebCore::FrameMac::mayDHTMLPaste): Renamed to match the bridge function.
        (WebCore::FrameMac::tryDHTMLPaste): ditto.
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge mayCopy]): Calls the renamed method on frame.
        (-[WebCoreFrameBridge mayDHTMLCut]): ditto.
        (-[WebCoreFrameBridge mayDHTMLCopy]): ditto.
        (-[WebCoreFrameBridge mayDHTMLPaste]): ditto.
        (-[WebCoreFrameBridge tryDHTMLCut]): ditto.
        (-[WebCoreFrameBridge tryDHTMLCopy]): ditto.
        (-[WebCoreFrameBridge tryDHTMLPaste]): ditto.

        * css/html4.css: Added !important to the -webkit-text-security property for password fields.

WebKit:

        Reviewed by Darin.

        WebKit part of fix for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
        Disallow copy from new password fields

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _canCopy]): Now also calls across the bridge to ask if it mayCopy.
        (-[WebHTMLView _canCut]): Calls _canCopy now.
        (-[NSArray validateUserInterfaceItem:]): Calls _canCut when validating the "Cut" menu item.
         This used to call _canDelete (which used to be the same as _canCut), but now _canCut also checks _canCopy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
thatcher [Wed, 30 Aug 2006 18:29:55 +0000 (18:29 +0000)]
JavaScriptCore:

        Reviewed by Tim H.

        Commit KDE related tweaks, to be able to
        differentiate between a Qt-only or a KDE build.

        * CMakeLists.txt: Install wtf-unity library.
        * wtf/Platform.h: Add define for the KDE platform.

WebCore:

        Reviewed by Tim H.

        Commit KDE related tweaks, to be able to
        differentiate between a Qt-only or a KDE build.

        * CMakeLists.txt: Move global variables up to trunk/CMakeLists.txt.
                          Also rename USE_WEBKIT_SVG_SUPPORT to WEBKIT_USE_SVG_SUPPORT.

WebKitTools:

        Reviewed by Tim H.

        Commit KDE related tweaks, to be able to
        differentiate between a Qt-only or a KDE build.

        * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Add ksvg2/ includes.
        * QtLauncher/CMakeLists.txt: Add ksvg2/ includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Brady.
thatcher [Wed, 30 Aug 2006 18:24:18 +0000 (18:24 +0000)]
    Rubber-stamped by Brady.

        Fix for the generated headers to make the build work
        during "installhdrs" builds. Also export DOM headers
        using the #import <WebCore/DOM*.h> syntax.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorObjC.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric and Tim H.
thatcher [Wed, 30 Aug 2006 16:50:36 +0000 (16:50 +0000)]
    Reviewed by Eric and Tim H.

        Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10634

        Remove the check for canShowFile: from _web_bestURL: since
        it shouldn't be concerned with whether or not the view
        can show the URL, merely return the most appropriate URL.

        * Misc/WebNSPasteboardExtras.m:
        (-[NSPasteboard _web_bestURL]):
        * Misc/WebNSViewExtras.m:
        (-[NSView _web_dragOperationForDraggingInfo:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 30 Aug 2006 08:11:17 +0000 (08:11 +0000)]
WebCore:

        Reviewed by Kevin Decker (Sarge)

        <rdar://problem/4678414> - New IconDB needs to delete icons when asked
        <rdar://problem/4707718> - If user's Icon directory is unwritable, Safari will crash at startup

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge removeAllIcons]):  Added
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open): If DB file is not writeable, create an in-memory DB for this session
        (WebCore::IconDatabase::close): Use new deleteAllPreparedStatements()
        (WebCore::IconDatabase::removeAllIcons): Actually implemented
        (WebCore::IconDatabase::deleteAllPreparedStatements): Added for convinience/consistency
        (WebCore::IconDatabase::setPrivateBrowsingEnabled): Use new SQLDatabase::clearAllTables()
        * loader/icon/IconDatabase.h:
        * loader/icon/SQLDatabase.cpp:
        (WebCore::SQLDatabase::clearAllTables): Moved this from IconDatabase as it actually belongs here
        (WebCore::SQLDatabase::vacuum): Added
        * loader/icon/SQLDatabase.h:
        (WebCore::SQLDatabase::path): changed name from getPath()

WebKit:

        Reviewed by Kevin Decker (Sarge)

        <rdar://problem/4678414> - New IconDB needs to delete icons when asked

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase removeAllIcons]): Call through to WebCore to remove icons, then send notification

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 30 Aug 2006 05:07:28 +0000 (05:07 +0000)]
WebCore:

        Reviewed by Alice

        Added a truth value to setIconURLForPageURL so WebKit can avoid sending a notification
        This is a win on the iBench

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::setIconURLForPageURL):
        * loader/icon/IconDatabase.h:

WebKit:

        Reviewed by Alice

        Added a truth value check for to setIconURL:forURL so WebKit can avoid sending a notification
        This is a win on the iBench

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase _setIconURL:forURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
aliceli1 [Wed, 30 Aug 2006 04:59:30 +0000 (04:59 +0000)]
    Reviewed by Brady.

        Fixed <rdar://problem/4702021> REGRESSION: WebClip and Weather widgets shift downward vertically on screen after I drag them out from dashboard configure bar

        * platform/mac/ScreenMac.mm:
        (WebCore::flipScreenRect):
        reverted the one line in this method back to what it was before r15765.  This changed caused window.screenY to be incorrect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Wed, 30 Aug 2006 00:48:40 +0000 (00:48 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)

        * fast/css/computed-style-negative-top-expected.txt: Added.
        * fast/css/computed-style-negative-top.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)

        The bug was that we would return "none" for computed style properties when they were
        exactly "-1px".

        Test: fast/css/computed-style-negative-top.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForLength): Moved special case for "undefined length" out of here.
        (WebCore::valueForMaxLength): Moved it into here.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Use valueForMaxLength
        only for max-height and max-width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-29 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Tue, 29 Aug 2006 23:35:57 +0000 (23:35 +0000)]
2006-08-29  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.

        Add path-related SVG JavaScript bindings to generation.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-29 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 29 Aug 2006 23:19:33 +0000 (23:19 +0000)]
2006-08-29  Eric Seidel  <eric@eseidel.com>

        Reviewed by kevin.

        Re-enable path-related SVG JavaScript bindings.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10623
        Split all SVGPathSeg*.idl files into Abs and Rel pieces.
        Move all SVGPath*.idl files into ksvg2/svg

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorJS.pm: Special case Abs and Rel header includes
        * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathElement.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSeg.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegList.idl: Removed.
        * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Removed.
        * ksvg2/ksvg.h: move SVGPathSegment enum
        * ksvg2/svg/SVGPathElement.cpp: move SVGPathSegment enum
        (WebCore::SVGPathElement::toPathData):
        * ksvg2/svg/SVGPathSeg.cpp:
        (WebCore::SVGPathSeg::SVGPathSeg):
        * ksvg2/svg/SVGPathSeg.h:
        (WebCore::SVGPathSeg::):
        * ksvg2/svg/SVGPathSegArcAbs.idl: Added.
        * ksvg2/svg/SVGPathSegArcRel.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Added.
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Added.
        * ksvg2/svg/SVGPathSegLinetoAbs.idl: Added.
        * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl: Added.
        * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl: Added.
        * ksvg2/svg/SVGPathSegLinetoRel.idl: Added.
        * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl: Added.
        * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl: Added.
        * ksvg2/svg/SVGPathSegMovetoAbs.idl: Added.
        * ksvg2/svg/SVGPathSegMovetoRel.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot this
andersca [Tue, 29 Aug 2006 23:13:34 +0000 (23:13 +0000)]
Forgot this

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Tue, 29 Aug 2006 22:52:30 +0000 (22:52 +0000)]
    Reviewed by Tim Hatcher.

        * Scripts/gdb-safari: Set DYLD_FRAMEWORK_PATH inside gdb instead of setting it in gdb's environment
        to work around what seems to be a bug in some versions of gdb.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Tue, 29 Aug 2006 22:49:41 +0000 (22:49 +0000)]
2006-08-28  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric, landed by Anders.

        Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

        Finish Unity merging. Remove libcurl usage, in favour of KIO.
        This makes the regression testing fly! IO processing is way faster now.

        * CMakeLists.txt:
        * platform/ResourceLoaderInternal.h:
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::openURL):
        (WebCore::FrameQt::submitForm):
        (WebCore::FrameQt::urlSelected):
        (WebCore::FrameQt::createEmptyDocument):
        (WebCore::FrameQt::receivedData):
        (WebCore::FrameQt::receivedAllData):
        * platform/qt/FrameQt.h:
        * platform/qt/ResourceLoaderCurl.cpp: Removed.
        * platform/qt/ResourceLoaderManager.cpp:
        (WebCore::ResourceLoaderManager::ResourceLoaderManager):
        (WebCore::ResourceLoaderManager::~ResourceLoaderManager):
        (WebCore::ResourceLoaderManager::self):
        (WebCore::ResourceLoaderManager::slotData):
        (WebCore::ResourceLoaderManager::slotMimetype):
        (WebCore::ResourceLoaderManager::slotResult):
        (WebCore::ResourceLoaderManager::remove):
        (WebCore::ResourceLoaderManager::add):
        * platform/qt/ResourceLoaderManager.h:
        * platform/qt/ResourceLoaderQt.cpp: Added.
        (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
        (WebCore::ResourceLoader::~ResourceLoader):
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::cancel):
        (WebCore::ResourceLoader::assembleResponseHeaders):
        (WebCore::ResourceLoader::retrieveCharset):
        (WebCore::ResourceLoader::receivedResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatchers rubber stamp
beidson [Tue, 29 Aug 2006 22:37:27 +0000 (22:37 +0000)]
    Reviewed by Tim Hatchers rubber stamp

        Removed some accidentally left-in console spew during the conversion to the new DB

        * Misc/WebIconDatabase.m:
        (objectFromPathForKey): Nuked some NSLogs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
tomernic [Tue, 29 Aug 2006 22:14:42 +0000 (22:14 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/4688618> REGRESSION(10.4.7-9A241): JMol java applet fails in Safari not Firefox

        No layout test for now because Java doesn't work in DumpRenderTree.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]):
        Add each plug-in MIME type to registeredMIMETypes, even if we don't register a document view class for the
        MIME type.  This fixes -[WebPluginDatabase isMIMETypeRegistered:] and thus fallback content for Java applets
        (we were always rendering fallback content, if any, for Java applets).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
thatcher [Tue, 29 Aug 2006 21:58:08 +0000 (21:58 +0000)]
    Reviewed by Eric.

        Bug 10632: Objective-C DOM should use the @property syntax for DOM attributes
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10632

        Generate @property when MACOSX_DEPLOYMENT_TARGET is >= 10.5.
        This is backwards compatible with the getter/setter methods.
        Generate setter arguments with a "new" prefix to avoid the property
        name conflict warning. Also removes some whitespace and the comments
        that we added to the headers. This makes the headers look like what we ship now.

        * bindings/objc/DOMCSS.mm:
        (-[DOMDocument getComputedStyle::]): renamed a local variable to avoid the property name conflict.
        (-[DOMDocument getMatchedCSSRules::]): ditto.
        * bindings/scripts/CodeGeneratorObjC.pm: generate @property in the headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-30 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Tue, 29 Aug 2006 21:40:29 +0000 (21:40 +0000)]
2006-08-30  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Fix time calculation, by using a correct calculation. Calling time()
        returns a number of seconds, aka. an integer. Fix it by using gettimeofday().
        Patch originally proposed by Ronan Meneu <rmeneu@origyn.fr>

        * platform/qt/SystemTimeQt.cpp:
        (WebCore::currentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Tue, 29 Aug 2006 20:33:54 +0000 (20:33 +0000)]
WebCore:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10628
          Auto-generate the remaining Objective-C DOM bindings

          Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
          and DOMHTMLOptionsCollection, and lays groundwork for the rest of the
          HTML DOM bindings by adding/fixing the appropriate IDL's and updating
          the CodeGeneratorObjC.pm build script.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMHTML.mm:
        * bindings/objc/DOMHTMLInternal.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * html/HTMLAnchorElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLBaseFontElement.idl:
        * html/HTMLBodyElement.idl:
        * html/HTMLButtonElement.idl:
        * html/HTMLCollection.idl: Added.
        * html/HTMLDocument.idl:
        * html/HTMLElement.idl:
        * html/HTMLFormElement.idl:
        * html/HTMLFrameElement.idl: Added.
        * html/HTMLFrameSetElement.idl: Added.
        * html/HTMLIFrameElement.idl: Added.
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLLabelElement.idl:
        * html/HTMLLegendElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLMapElement.idl:
        * html/HTMLObjectElement.idl: Added.
        * html/HTMLOptionsCollection.idl:
        * html/HTMLPreElement.idl:
        * html/HTMLSelectElement.idl: Added.
        * html/HTMLStyleElement.idl:
        * html/HTMLTableCaptionElement.idl: Added.
        * html/HTMLTableCellElement.idl: Added.
        * html/HTMLTableColElement.idl: Added.
        * html/HTMLTableElement.idl: Added.
        * html/HTMLTableRowElement.idl: Added.
        * html/HTMLTableSectionElement.idl: Added.
        * html/HTMLTextAreaElement.idl:

WebKit:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10628
          Auto-generate the remaining Objective-C DOM bindings

          Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
          and DOMHTMLOptionsCollection.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-29 Nikolas Zimmermann <zimmermann@kde.org>
ap [Tue, 29 Aug 2006 20:05:09 +0000 (20:05 +0000)]
2006-08-29  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by ap.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10629.
        Drawing convex polygons is broken in the Qt platform.

        * platform/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawConvexPolygon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
ggaren [Tue, 29 Aug 2006 19:16:12 +0000 (19:16 +0000)]
    Reviewed by Eric.

        Implementing font hashing properly, fixes weird crashes in HashMap.

        * platform/qt/FontPlatformData.h:
        * platform/qt/FontPlatformDataQt.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ggaren.
ggaren [Tue, 29 Aug 2006 19:11:39 +0000 (19:11 +0000)]
    Reviewed by ggaren.

        Fix scrollbars to reappear after the first layouting.

        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::suppressScrollBars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-29 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 29 Aug 2006 18:58:58 +0000 (18:58 +0000)]
2006-08-29  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin and Geoff.

        Move the CF String functions to separate files in platform/cf.
        Also, move the files in platform/cfnet to platform/cf.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/PlatformString.h:
        * platform/StringImpl.h:
        * platform/cf/StringCF.cpp: Added.
        (WebCore::String::String):
        * platform/cf/StringImplCF.cpp: Added.
        (WebCore::StringImpl::createCFString):
        * platform/cfnet/KURLCFNet.cpp: Removed.
        * platform/cfnet/ResourceLoaderCFNet.cpp: Removed.
        * platform/mac/StringImplMac.mm:
        * platform/mac/StringMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rolling out a change I included by accident in my last commit.
ggaren [Tue, 29 Aug 2006 18:56:12 +0000 (18:56 +0000)]
    Rolling out a change I included by accident in my last commit.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::passMouseDownEventToWidget):
        * platform/mac/SharedTimerMac.cpp:
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
beidson [Tue, 29 Aug 2006 17:25:51 +0000 (17:25 +0000)]
    Reviewed by Darin

        Short of a few small snippets that still need to be pushed to WebCore, this
        is a final prune of WebIconDatabase.  WebFileDatabase and WebLRUFileList are gone
        and the small remaining snippets of WebFileDatabase code that were still important
        are now in static functions in WebIconDatabase.m

        * Loader/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]): Removed the flag
        * Misc/WebFileDatabase.h: Removed.
        * Misc/WebFileDatabase.m: Removed.
        * Misc/WebIconDatabase.m:
        (+[WebIconDatabase sharedIconDatabase]):
        (-[WebIconDatabase init]):
        (-[WebIconDatabase iconForURL:withSize:cache:]):
        (-[WebIconDatabase iconURLForURL:]):
        (-[WebIconDatabase defaultIconWithSize:]):
        (-[WebIconDatabase retainIconForURL:]):
        (-[WebIconDatabase releaseIconForURL:]):
        (-[WebIconDatabase _isEnabled]):
        (-[WebIconDatabase _setIconData:forIconURL:]):
        (-[WebIconDatabase _setHaveNoIconForIconURL:]):
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _hasEntryForIconURL:]):
        (-[WebIconDatabase _applicationWillTerminate:]):
        (-[WebIconDatabase _resetCachedWebPreferences:]):
        (uniqueFilePathForKey): Added from WebFileDatabase
        (objectFromPathForKey): Added from WebFileDatabase
        (iconDataFromPathForIconURL):
        (-[WebIconDatabase _convertToWebCoreFormat]): Make use of static functions and local variables
          instead of using WebFileDatabase and WebIconDatabase variables that are now obsolete
        * Misc/WebIconDatabasePrivate.h: Removed alot of obsoleted members
        * Misc/WebLRUFileList.h: Removed.
        * Misc/WebLRUFileList.m: Removed.
        * WebKit.xcodeproj/project.pbxproj: Deleted 4 files
        * WebKitPrefix.h: Removed ICONDEBUG

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ggaren [Tue, 29 Aug 2006 01:13:33 +0000 (01:13 +0000)]
    Reviewed by Maciej.

        Added support for experimental CFNetwork-based loader (not turned on yet).

        While I was there, I did the following platform cleanup:
        - Windows now uses USE(WININET) instead of PLATFORM(WIN_OS), to match the
          USE(CFNETWORK) idiom.
        - Removed some #includes of windows.h in platform-independent headers.
        - Changed #ifdef __APPLE__ to PLATFORM(MAC)
        - Fixed some build bustage, including case-sensitive filesystem bustage.

        * loader/loader.cpp:
        (WebCore::Loader::receivedAllData):
        * platform/Cursor.h:
        * platform/KURL.h:
        * platform/ResourceLoader.h:
        * platform/ResourceLoaderClient.h:
        * platform/ResourceLoaderInternal.h:
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/cfnet/KURLCFNet.cpp: Added.
        (WebCore::KURL::createCFURL):
        * platform/cfnet/ResourceLoaderCFNet.cpp: Added.
        (WebCore::willSendRequest):
        (WebCore::didReceiveChallenge):
        (WebCore::didCancelChallenge):
        (WebCore::didReceiveResponse):
        (WebCore::didReceiveData):
        (WebCore::didFinishLoading):
        (WebCore::didFail):
        (WebCore::willCacheResponse):
        (WebCore::addHeadersFromString):
        (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
        (WebCore::ResourceLoader::~ResourceLoader):
        (WebCore::arrayFromFormData):
        (WebCore::emptyPerform):
        (WebCore::runLoaderThread):
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::cancel):
        * platform/win/CursorWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 29 Aug 2006 00:35:05 +0000 (00:35 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/inserting/redo-expected.checksum: Added.
        * editing/inserting/redo-expected.png: Added.
        * editing/inserting/redo-expected.txt: Added.
        * editing/inserting/redo.html: Added.
        * editing/pasteboard/copy-paste-bidi-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4700341>
        REGRESSION: In new mail message, caret isn't placed at end of line after redoing typing

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME.
        * page/Frame.cpp:
        (WebCore::Frame::reappliedEditing): Restore the endingSelection(), not the startingSelection().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
tomernic [Tue, 29 Aug 2006 00:30:05 +0000 (00:30 +0000)]
    Reviewed by Darin Adler.

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView createPluginScriptableObject]):
        Removed a bogus typecast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16087 268f45cc-cd09-0410-ab3c-d52691b4dbfc