WebKit-https.git
8 years agoREGRESSION: We should allow null modificationTime when snapshot metadata is given
kinuko@chromium.org [Wed, 30 May 2012 09:08:43 +0000 (09:08 +0000)]
REGRESSION: We should allow null modificationTime when snapshot metadata is given
https://bugs.webkit.org/show_bug.cgi?id=86811

Reviewed by Jian Li.

r117432 has introduced a new File constructor which allows the caller
to pass in a snapshot file metadata. In the change we had considered the
given metadata is valid if "metadata.length >= 0 AND metadata.lastModifiedDate != 0",
but we should drop the latter condition (lastModifiedDate != 0) because

1. the value 0 is used to indicate the time information is unavailable in File, and
2. it is valid per spec (http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate says the UA must return null if the information is not available).

(Note: the current js/v8 binding returns Date(0) for the time value 0,
which is still valid as epoch time but would fail to indicate the
unavailability of the information. In this patch I added FIXME in
File.idl and filed a separate issue http://webkit.org/b/87709)

No new tests as this change does not affect regular files/filesystems behavior.
(Tests in Chrome OS port should be able to verify this)

* fileapi/File.cpp:
(WebCore::File::lastModifiedDate):
(WebCore::File::size):
(WebCore::File::captureSnapshot):
* fileapi/File.h:
(File):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Gardening. Shadow DOM is disabled on Qt.
ossy@webkit.org [Wed, 30 May 2012 08:32:40 +0000 (08:32 +0000)]
[Qt] Gardening. Shadow DOM is disabled on Qt.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-30
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip fast/dom/shadow/shadow-element.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test expectations for tests duplicated in Skipped
commit-queue@webkit.org [Wed, 30 May 2012 08:20:45 +0000 (08:20 +0000)]
Update test expectations for tests duplicated in Skipped
https://bugs.webkit.org/show_bug.cgi?id=87822

Unreviewed gardening; updating test expectations.

Patch by David Barr <davidbarr@chromium.org> on 2012-05-30

* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
* platform/qt/Skipped:
* platform/qt/test_expectations.txt:
* platform/qt-5.0-wk1/Skipped:
* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix WebKit2GTK+ API tests in the bots.
carlosgc@webkit.org [Wed, 30 May 2012 08:17:31 +0000 (08:17 +0000)]
Unreviewed. Fix WebKit2GTK+ API tests in the bots.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewCanShowMIMEType): Remove the check for multimedia and
plugins MIME types since they depend on the configuration and they
are not available in the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Update test expectations after r118841.
commit-queue@webkit.org [Wed, 30 May 2012 07:33:22 +0000 (07:33 +0000)]
[GTK] Update test expectations after r118841.
https://bugs.webkit.org/show_bug.cgi?id=87827

Unreviewed gardening; updating test expectations

Patch by David Barr <davidbarr@chromium.org> on 2012-05-30

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow DOM] HTMLContentElement and HTMLShadowElement constructors should be visible.
morrita@google.com [Wed, 30 May 2012 07:26:37 +0000 (07:26 +0000)]
[Shadow DOM] HTMLContentElement and HTMLShadowElement constructors should be visible.
https://bugs.webkit.org/show_bug.cgi?id=87818

Source/WebCore:

Reviewed by Kentaro Hara.

Added them as DOMWindow properties

Tests: fast/dom/shadow/content-element-api.html
       fast/dom/shadow/shadow-element.html

* page/DOMWindow.idl:

LayoutTests:

Added constructor checks.

Reviewed by Kentaro Hara.

* fast/dom/shadow/content-element-api-expected.txt:
* fast/dom/shadow/content-element-api.html:
* fast/dom/shadow/shadow-element-expected.txt:
* fast/dom/shadow/shadow-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118868.
commit-queue@webkit.org [Wed, 30 May 2012 07:17:05 +0000 (07:17 +0000)]
Unreviewed, rolling out r118868.
http://trac.webkit.org/changeset/118868
https://bugs.webkit.org/show_bug.cgi?id=87828

introduced ~20 crashes on Mac and Qt bots (Requested by pizlo_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-30

* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::sweepWeakSet):
(JSC):
* heap/MarkedSpace.cpp:
(JSC::SweepWeakSet::operator()):
(JSC):
(JSC::MarkedSpace::sweepWeakSets):
* heap/MarkedSpace.h:
(MarkedSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS3 calc: Implement CSSOM support
mikelawther@chromium.org [Wed, 30 May 2012 07:01:08 +0000 (07:01 +0000)]
CSS3 calc: Implement CSSOM support
https://bugs.webkit.org/show_bug.cgi?id=84551

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a pretty printer for the calc expression tree.

Test: css3/calc/cssom.html

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::customCssText):
(WebCore::CSSCalcPrimitiveValue::customCssText):
(WebCore::CSSCalcBinaryOperation::customCssText):
(CSSCalcBinaryOperation):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):

LayoutTests:

* css3/calc/cssom-expected.txt: Added.
* css3/calc/cssom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[perf-test] Add a benchmark for querySelector()
haraken@chromium.org [Wed, 30 May 2012 07:00:50 +0000 (07:00 +0000)]
[perf-test] Add a benchmark for querySelector()
https://bugs.webkit.org/show_bug.cgi?id=87742

Reviewed by Ryosuke Niwa.

Now I am optimizing querySelector() (bug 87625).
This patch adds a performance test for querySelector().
query-selector-first.html queries an element that appears
at the head of the document. On the other hand,
query-selector-last.html queries an element that appears
at the tail of the document.

Test results in my desktop:

[query-selector-first.html]
RESULT Parser: query-selector-first= 252.339803014 runs/s
median= 253.646265594 runs/s, stdev= 2.32610873209 runs/s, min= 248.138957816 runs/s, max= 254.777070064 runs/s

RESULT Parser: query-selector-first= 252.688468897 runs/s
median= 252.684876579 runs/s, stdev= 3.60008778708 runs/s, min= 246.002460025 runs/s, max= 258.397932817 runs/s

RESULT Parser: query-selector-first= 253.466019656 runs/s
median= 254.129606099 runs/s, stdev= 1.78002675664 runs/s, min= 247.831474597 runs/s, max= 254.777070064 runs/s

RESULT Parser: query-selector-first= 256.245078189 runs/s
median= 257.06940874 runs/s, stdev= 2.84722072201 runs/s, min= 249.687890137 runs/s, max= 259.74025974 runs/s

RESULT Parser: query-selector-first= 252.203100497 runs/s
median= 252.047989175 runs/s, stdev= 1.75233446036 runs/s, min= 248.138957816 runs/s, max= 255.427841635 runs/s

[query-selector-last.html]
RESULT Parser: query-selector-last= 356.009616076 runs/s
median= 355.781448539 runs/s, stdev= 0.841519086864 runs/s, min= 354.430379747 runs/s, max= 358.056265985 runs/s

RESULT Parser: query-selector-last= 360.735271001 runs/s
median= 361.057532424 runs/s, stdev= 1.12253219867 runs/s, min= 358.514724712 runs/s, max= 362.225097025 runs/s

RESULT Parser: query-selector-last= 359.598592463 runs/s
median= 359.435173299 runs/s, stdev= 0.816538258728 runs/s, min= 358.056265985 runs/s, max= 360.824742268 runs/s

RESULT Parser: query-selector-last= 357.260651715 runs/s
median= 357.598978289 runs/s, stdev= 1.17393159885 runs/s, min= 353.982300885 runs/s, max= 358.974358974 runs/s

RESULT Parser: query-selector-last= 351.696240713 runs/s
median= 351.980025916 runs/s, stdev= 1.14200564038 runs/s, min= 348.692403487 runs/s, max= 353.535353535 runs/s

* Parser/query-selector-first.html: Added.
* Parser/query-selector-last.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
ossy@webkit.org [Wed, 30 May 2012 06:37:54 +0000 (06:37 +0000)]
[Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
(They only used to check for Skipped in platform/qt-5.0-wk1)
https://bugs.webkit.org/show_bug.cgi?id=87376

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-29
Reviewed by Csaba Osztrogonác.

* Scripts/old-run-webkit-tests:
(buildPlatformResultHierarchy):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[FileAPI] The result attribute of FileReader shuold use null to replace empty string
commit-queue@webkit.org [Wed, 30 May 2012 06:34:18 +0000 (06:34 +0000)]
[FileAPI] The result attribute of FileReader shuold use null to replace empty string
https://bugs.webkit.org/show_bug.cgi?id=87578

Patch by Li Yin <li.yin@intel.com> on 2012-05-29
Reviewed by Jian Li.

Source/WebCore:

Spec: http://www.w3.org/TR/FileAPI/#dfn-result
If the readyState is EMPTY (no read method has been called) or an error
in reading the File or Blob has occurred (using any read method), then the
result attribute MUST return null.

Currently, Firefox11, Opera and IE 10 follows the spec, but Webkit based
browser doesn't.
WebKit should change the returned value empty string into null to keep
conformance with the spec.

Tests: fast/files/read-file-async.html
       fast/files/workers/worker-read-file-async.html

* fileapi/FileReader.cpp:
(WebCore::FileReader::arrayBufferResult):
(WebCore::FileReader::stringResult):

LayoutTests:

Spec: http://www.w3.org/TR/FileAPI/#dfn-result
If the readyState is EMPTY (no read method has been called) or an error in
reading the File or Blob has occurred (using any read method), then the result
attribute MUST return null.

Currently, webkit return empty string, not null.

* fast/files/read-file-async-expected.txt:
* fast/files/resources/read-common.js:
(logResult):
(loadFailed):
* fast/files/resources/read-file-test-cases.js:
(testReadAgainAfterFailedReadStep1):
* fast/files/workers/worker-read-file-async-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNoticeable delay taking an HTML5 trailer fullscreen.
jer.noble@apple.com [Wed, 30 May 2012 06:33:40 +0000 (06:33 +0000)]
Noticeable delay taking an HTML5 trailer fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=87794

Reviewed by Darin Adler.

Work around a not-entirely understood delay when using the results of a CGWindowListCreateImage()
call as the contents of a placeholder view.  The backing of the resulting CGImageRef resides on
the WindowServer, and drawing that image requires synchronous calls to the WindowServer process.
By copying the image data, up front, into our own process, we can avoid those synchronous calls
later and avoid the delay-causing drawing behavior.

* UIProcess/mac/WKFullScreenWindowController.mm:
(CGImageDeepCopy): Added a helper function which copies the image data into a new CGImage.
(-[WKFullScreenWindowController enterFullScreen:]): Use the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
commit-queue@webkit.org [Wed, 30 May 2012 06:17:46 +0000 (06:17 +0000)]
[BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
https://bugs.webkit.org/show_bug.cgi?id=87817

Patch by Max Feil <mfeil@rim.com> on 2012-05-29
Reviewed by Antonio Gomes.

This bug fix in WebKit/blackberry is needed by the changes for
fullscreen media control sizing in WebCore (bug 87551). The sizing
of controls depends on the page's deviceScaleFactor(), which was
not being maintained properly due to errors in logic. Viewport
changes from non-default to default were being erroneously
thrown out. Also, when the viewport did change back to default
the deviceScaleFactor was not being updated.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move fileExists to Platform.h
pilgrim@chromium.org [Wed, 30 May 2012 05:08:36 +0000 (05:08 +0000)]
[Chromium] Move fileExists to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Call fileExists through fileUtilities(), not directly.

Source/Platform:

* chromium/public/Platform.h:
(Platform):

Source/WebCore:

* platform/chromium/FileSystemChromium.cpp:
(WebCore::fileExists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update.
tkent@chromium.org [Wed, 30 May 2012 04:37:43 +0000 (04:37 +0000)]
[Chromium] Test expectation update.

Rebaseline for placeholder-related tests.

* platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png: Added.
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
* platform/chromium-mac/fast/css/text-overflow-input-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png: Added.
* platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/chromium-mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/css/text-overflow-input-expected.txt:
* platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
* platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove a dummy style sheet from CSSParser::parseFlowThread()
haraken@chromium.org [Wed, 30 May 2012 04:37:21 +0000 (04:37 +0000)]
Remove a dummy style sheet from CSSParser::parseFlowThread()
https://bugs.webkit.org/show_bug.cgi?id=87715

Reviewed by Darin Adler.

r118736 changed CSSGrammar.y so that it works fine with no style sheet.
r118736 removed a dummy style sheet from CSSParser::parserSelector().
Now we can safely remove a dummy style sheet from parserFlowThread().

Tests: fast/regions. No change in test results.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlowThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
yosin@chromium.org [Wed, 30 May 2012 04:34:33 +0000 (04:34 +0000)]
REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
https://bugs.webkit.org/show_bug.cgi?id=87719

Reviewed by Kent Tamura.

Source/WebCore:

This patch added checking of "option" element for CSS pseudo class :enabled as same as
:disabled to selector checker. Before r111497, it was done by using isFormControlElement.
After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.

Test: fast/form/select/optgroup-rendering.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
as PseudoDisabled in PseudoEnabled case.

LayoutTests:

* platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
* platform/chromium/test_expectations.txt: Update comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduces ComposedShadowTreeParentWalker, extracted from ComposedShadowTreeWalker.
hayato@chromium.org [Wed, 30 May 2012 04:20:02 +0000 (04:20 +0000)]
Introduces ComposedShadowTreeParentWalker, extracted from ComposedShadowTreeWalker.
https://bugs.webkit.org/show_bug.cgi?id=87004

Reviewed by Dimitri Glazkov.

Introduces a ComposedShadowTreeParentWalker, which is only used
for traversing a parent node (including shadow roots and insertion
points) and get rid of an equivalent function from
ComposedShadowTreeWalker.

Before this patch, there is an inconsistency inside of
ComposedShadowTreeWalker. The Walker uses 'Policy' to decide
whether it should visit shadow roots or not, but
parentIncludingInsertionPointAndShadowRoot() member function
ignores the policy.  We can not add an assertion in its
constructor due to this inconsistency.  To resolve it, we could
add yet another special policy, but that makes the implementation
complex and may add some overhead in runtime.  So separate the
functionality into another class as ComposedShadowTreeParentWalker.

No new tests, no new functionality except for assertion.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeParentWalker::ComposedShadowTreeParentWalker):
(WebCore):
(WebCore::ComposedShadowTreeParentWalker::parentIncludingInsertionPointAndShadowRoot):
(WebCore::ComposedShadowTreeParentWalker::traverseParentIncludingInsertionPointAndShadowRoot):
* dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(WebCore):
(ComposedShadowTreeParentWalker):
(WebCore::ComposedShadowTreeParentWalker::get):
* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventDispatcher::ensureEventAncestors):
* page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd assertions to make sure that event's target and relatedTarget are accessible.
hayato@chromium.org [Wed, 30 May 2012 04:05:53 +0000 (04:05 +0000)]
Add assertions to make sure that event's target and relatedTarget are accessible.
https://bugs.webkit.org/show_bug.cgi?id=87641

Reviewed by Dimitri Glazkov.

No new tests. No new functionality except for assertions.

* dom/EventContext.cpp:
(WebCore::EventContext::EventContext):
* dom/EventContext.h:
(WebCore):
(EventContext):
(WebCore::EventContext::setRelatedTarget):
(WebCore::EventContext::accessible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix inefficient usage of traverseNextNode()
tkent@chromium.org [Wed, 30 May 2012 04:03:07 +0000 (04:03 +0000)]
Fix inefficient usage of traverseNextNode()
https://bugs.webkit.org/show_bug.cgi?id=87804

Reviewed by Ryosuke Niwa.

foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
firstChild() is more efficient.

No new tests because of no behavior change.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Replace traverseNextNode() with firstChild(), and shorten a variable name.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
Replace traverseNextNode() with firstChild().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Loading media data with http authentication
commit-queue@webkit.org [Wed, 30 May 2012 03:51:23 +0000 (03:51 +0000)]
[BlackBerry] Loading media data with http authentication
https://bugs.webkit.org/show_bug.cgi?id=84214

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-29
Reviewed by George Staikos.

.:

Added a manual test case which needs user to provide a HTTP server
with HTTP authentication support when loading the specified media
resource. The test case will test if the media resource is successfully
loaded.

* ManualTests/blackberry/video-load-with-authentication.html: Added.

Source/WebCore:

RIM PR: 117618
Implemented http authentication feature for media by implementing
two interface functions in class MediaPlayerPrivate:
onAuthenticationNeeded(): this function is triggered when MMR
engine requires http authentication. We search the CredentialStorage
to see if we have already stored existing credential information,
or challenge user to provide it.
OnAuthenticationAccepted(): this function is triggered when MMR
engine accepts the credential information, and we need to save
it in CredentialStorage for later use.

Internally reviewed by Max Feil <mfeil@qnx.com>.

Manual test case: blackberry/video-load-with-authentication.html

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::generateProtectionSpaceFromMMRAuthChallenge):
(WebCore):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::onAuthenticationAccepted):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow DOM] Node distribution should be orthogonal from node attachment
morrita@google.com [Wed, 30 May 2012 03:33:21 +0000 (03:33 +0000)]
[Shadow DOM] Node distribution should be orthogonal from node attachment
https://bugs.webkit.org/show_bug.cgi?id=87223

Reviewed by Dimitri Glazkov.

This chagne reorganizes Shadow DOM subtree distribution implementation.

Originally, it was interleaved across attach() of several classes like
InsertionPoint and ShadowRoot. Its invalidation was also mixed as a part of
the style recalculation and detach()-es.

This change extracts these bits of code to a set of ContentDistributor methods, which are
facaded by two ElementShadow API. Following two API are the primary entry points:

- ElementShadow::ensureDistribution()
- ElementShadow::invalidateDistribution()

The actual implementations are ContentDistributor::distribute() and
ContentDistributor::invalidate() respectively.

When clients need to traverse composed tree, before attach() for
example, they should call ensureDistribution() to make sure that
the traversal data structure ("the distribution") is ready.  When
there is any DOM mutation which can result a composed tree
mutation, then clients should call invalidateDistribution() to
mark the distribution being dated.

Here are such DOM mutations:

- The children of any ShadowRoots are changed,
- The children of any InsertionPoints are changed,
- The children of any host elements are changed,
- Any insertion point is inserted to or removed from the shadow tree,
- @select attribute of <content> is modified and
- New ShadowRoot is added to the shadow tree.

Note that the validity of the distribution is tracked and
unnecessary distribution requests are ignored.

After the invalidation, that shadow subtrees are detached once and
request  their  re-attachment  through  the  style  recalculation.
Then,  on the  responding  style recalculation  and attach(),  new
distribution will be computed.

No new tests. Covered by existing tests.

* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::childrenChanged):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::ensureDistribution):
(WebCore::ElementShadow::invalidateDistribution):
* dom/ElementShadow.h:
(ElementShadow):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setApplyAuthorStyles):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::childrenChanged):
(WebCore):
* dom/ShadowRoot.h:
(ShadowRoot):
* html/HTMLFormControlElement.cpp:
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
(WebCore::ContentDistributor::finishInivalidation):
(WebCore::ContentDistributor::distributeSelectionsTo):
(WebCore::ContentDistributor::distributeShadowChildrenTo):
(WebCore::ContentDistributor::invalidateDistributionIn):
* html/shadow/ContentDistributor.h:
(WebCore::ContentDistributor::needsInvalidation):
(ContentDistributor):
(WebCore::ContentDistributor::needsDistribution):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::nextTo):
(WebCore::InsertionPoint::previousTo):
(WebCore::InsertionPoint::childrenChanged):
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::setDistribution):
(WebCore::InsertionPoint::clearDistribution):
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement post-landing feedback for WebKitCSSTransformValue::customCSSText().
macpherson@chromium.org [Wed, 30 May 2012 03:30:23 +0000 (03:30 +0000)]
Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
https://bugs.webkit.org/show_bug.cgi?id=87684

Reviewed by Darin Adler.

Darin provided some style suggesting on https://bugs.webkit.org/show_bug.cgi?id=87462 after it landed.
This patch incorporates those suggestions, namely using 0 instead of empty string for UnknownTransformOperation
and WTF_ARRAY_LENGTH instead of hard coding the array length.

Covered by existing transform tests.

* css/WebKitCSSTransformValue.cpp:
(WebCore):
(WebCore::WebKitCSSTransformValue::customCssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a linter error for pngs that lack an embedded checksum
ojan@chromium.org [Wed, 30 May 2012 03:15:25 +0000 (03:15 +0000)]
Add a linter error for pngs that lack an embedded checksum
https://bugs.webkit.org/show_bug.cgi?id=87793

Reviewed by Dirk Pranke.

* Scripts/read-checksum-from-png:
* Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
(read_checksum):
* Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
(ReadChecksumFromPngTest):
(ReadChecksumFromPngTest.test_read_checksum):
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless>
eric@webkit.org [Wed, 30 May 2012 02:28:17 +0000 (02:28 +0000)]
Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless>
https://bugs.webkit.org/show_bug.cgi?id=87646

Reviewed by Adam Barth.

In the process of moving the seamless feature out of github and into bugs.webkit.org
multiple versions of the shouldDisplaySeamlessly function got written
(and moved from HTMLIFrameElement to Document), but only one of them was wrapped
in ENABLE_IFRAME_SEAMLESS.  HTMLIFrameElement was checking mayDisplaySeamlessly
directly (as was my original design), which got around the ENABLE_IFRAME_SEAMLESS check.
I've fixed this oversight, and the feature is now off when we tell it to be off.

This is covered by many existing tests.  I've verified locally that
all tests fail when ENABLE_IFRAME_SEAMLESS is disabled instead of
only some of them.

* dom/SecurityContext.h:
(SecurityContext):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShow an error in the pretty diff when an image lacks a checksum
ojan@chromium.org [Wed, 30 May 2012 02:18:08 +0000 (02:18 +0000)]
Show an error in the pretty diff when an image lacks a checksum
https://bugs.webkit.org/show_bug.cgi?id=87791

Reviewed by Dirk Pranke.

* PrettyPatch/PrettyPatch.rb:
* PrettyPatch/PrettyPatch_test.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor shadow-dom-event-dispatching.html.
hayato@chromium.org [Wed, 30 May 2012 02:13:30 +0000 (02:13 +0000)]
Refactor shadow-dom-event-dispatching.html.
https://bugs.webkit.org/show_bug.cgi?id=87626

Reviewed by Dimitri Glazkov.

There are badly named functions in shadow-dom-event-dispatching.html.
e.g. prepareDOMTree1, prepareDOMTree2 and so on.
That should have better namings which make the intention of each test clear.

* fast/dom/shadow/shadow-dom-event-dispatching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix warning in preprocessing Source/WebCore/dom/DOMError.idl
commit-queue@webkit.org [Wed, 30 May 2012 01:36:55 +0000 (01:36 +0000)]
Fix warning in preprocessing Source/WebCore/dom/DOMError.idl
https://bugs.webkit.org/show_bug.cgi?id=87763

Patch by Scott Graham <scottmg@chromium.org> on 2012-05-29
Reviewed by Adam Barth.

Add newline at end of file to avoid warning:
../dom/DOMError.idl:35:2: warning: no newline at end of file

* dom/DOMError.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move fileExists to Platform.h
pilgrim@chromium.org [Wed, 30 May 2012 01:33:50 +0000 (01:33 +0000)]
[Chromium] Move fileExists to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKit::Platform::fileExists):
(Platform):

Source/WebCore:

* platform/chromium/FileSystemChromium.cpp:
(WebCore::fileExists):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening after r118845 and r118851.
rakuco@webkit.org [Wed, 30 May 2012 01:17:49 +0000 (01:17 +0000)]
[EFL] Gardening after r118845 and r118851.

Apparently some baselines were not updated as expected, fixing
that now.

* platform/efl/fast/ruby/ruby-text-before-after-content-expected.png: Added.
* platform/efl/fast/ruby/ruby-text-before-after-content-expected.txt:
* platform/efl/fast/selectors/166-expected.png:
* platform/efl/fast/selectors/166-expected.txt:
* platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
* platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Added.
* platform/efl/svg/batik/text/textAnchor-expected.txt:
* platform/efl/svg/batik/text/textOnPath3-expected.txt:
* platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/efl/svg/carto.net/tabgroup-expected.txt:
* platform/efl/transitions/cross-fade-background-image-expected.txt: Added.
* platform/efl/transitions/cross-fade-border-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRolled back in r118646, now that
ggaren@apple.com [Wed, 30 May 2012 01:05:35 +0000 (01:05 +0000)]
Rolled back in r118646, now that
https://bugs.webkit.org/show_bug.cgi?id=87784 is fixed.

http://trac.webkit.org/changeset/118646
https://bugs.webkit.org/show_bug.cgi?id=87599

* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* heap/MarkedBlock.h:
(JSC):
* heap/MarkedSpace.cpp:
(JSC):
* heap/MarkedSpace.h:
(MarkedSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Rename v8Null() to v8NullWithCheck()
haraken@chromium.org [Wed, 30 May 2012 00:34:15 +0000 (00:34 +0000)]
[V8] Rename v8Null() to v8NullWithCheck()
https://bugs.webkit.org/show_bug.cgi?id=87713

Reviewed by Adam Barth.

In IRC, cmarcelo@ pointed out that v8::Null() and v8Null()
are confusing. This patch renames v8Null() to v8NullWithCheck().

No tests. No behavior change.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
* bindings/v8/V8Binding.h:
(WebCore::v8NullWithCheck):
(WebCore::v8DateOrNull):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSome Content Security Policy console messages are missing line numbers in JSC
commit-queue@webkit.org [Wed, 30 May 2012 00:25:12 +0000 (00:25 +0000)]
Some Content Security Policy console messages are missing line numbers in JSC
https://bugs.webkit.org/show_bug.cgi?id=87558

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-29
Reviewed by Adam Barth.

Source/WebCore:

Make ScriptController::eventHandlerPosition() behave the same way on
JSC than V8. This means that TextPosition::minimumPosition() is
returned if parser is null, instead of
TextPosition::belowRangePosition(). The line numbers are now correctly
printed in the output of Content Security Policy tests.

Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
       http/tests/security/contentSecurityPolicy/javascript-url-blocked.html

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::eventHandlerPosition):

LayoutTests:

Remove Mac/EFL/GTK/Qt-specific expectations for Content Security Policy
tests now that the line numbers are correctly printed.

* platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
* platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
* platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
* platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
* platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
* platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
* platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87720
slewis@apple.com [Wed, 30 May 2012 00:03:28 +0000 (00:03 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87720
WebProcess is often killed due to being unresponsive on the bots

Reviewed by Alexey Proskuryakov.

Blind attempt to improve flakiness on the bots by reducing the number
of crashes due to an unresponsive process.  This helped on my personal machine
under stress conditions.  I don't have enough cores to hit the problem
under normal conditions.

* WebKitTestRunner/TestController.cpp:
(WTR):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoString should be move enabled/optimized
andersca@apple.com [Tue, 29 May 2012 23:46:52 +0000 (23:46 +0000)]
String should be move enabled/optimized
https://bugs.webkit.org/show_bug.cgi?id=87596

Reviewed by Andreas Kling.

Add move constructors and move assignment operators to String and AtomicString when building with
compilers that support rvalue references. This gets rid of ref-churn when the source of the
constructor or assignment is a temporary object.

* wtf/text/AtomicString.h:
(AtomicString):
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::operator=):
* wtf/text/WTFString.h:
(String):
(WTF::String::String):
(WTF::String::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should keep captured variables alive until the (inline) return.
fpizlo@apple.com [Tue, 29 May 2012 23:43:16 +0000 (23:43 +0000)]
DFG should keep captured variables alive until the (inline) return.
https://bugs.webkit.org/show_bug.cgi?id=87205

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Changes the way we do flushing for captured variables and arguments. Instead of flushing
each SetLocal immediately, we flush at kill points. So a SetLocal will cause a Flush of
whatever was live in the variable previously, and a return will cause a Flush of all
captured variables and all arguments.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForArgument):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

LayoutTests:

Reviewed by Gavin Barraclough.

* fast/js/dfg-inline-arguments-osr-exit-and-capture-expected.txt: Added.
* fast/js/dfg-inline-arguments-osr-exit-and-capture.html: Added.
* fast/js/script-tests/dfg-inline-arguments-osr-exit-and-capture.js: Added.
(foo):
(bar):
(baz):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] make WebTransformationMatrix object usable by non-webkit code
shawnsingh@chromium.org [Tue, 29 May 2012 23:42:28 +0000 (23:42 +0000)]
[chromium] make WebTransformationMatrix object usable by non-webkit code
https://bugs.webkit.org/show_bug.cgi?id=87315

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebTransformationMatrix.h:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebTransformationMatrix):

Source/WebCore:

This change is covered by existing tests and by whether it
compiles. There should be no changes in behavior.

* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
(WebKit::WebTransformationMatrix::mapRect):
(WebKit::WebTransformationMatrix::mapPoint):
(WebKit::WebTransformationMatrix::mapQuad):
(WebKit::WebTransformationMatrix::projectPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeakGCMap should be lazy-finalization-safe
ggaren@apple.com [Tue, 29 May 2012 23:40:26 +0000 (23:40 +0000)]
WeakGCMap should be lazy-finalization-safe
https://bugs.webkit.org/show_bug.cgi?id=87784

Reviewed by Darin Adler.

* runtime/WeakGCMap.h:
(JSC::WeakGCMap::get): Since this is a map of raw WeakImpl pointers, and
not Weak<T>, we need to verify manually that the WeakImpl is live before
we return its payload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: rename 'rm' to 'delete' in rebaseline scm output
dpranke@chromium.org [Tue, 29 May 2012 23:31:35 +0000 (23:31 +0000)]
webkitpy: rename 'rm' to 'delete' in rebaseline scm output
https://bugs.webkit.org/show_bug.cgi?id=87779

Reviewed by Eric Seidel.

Update output to match the names in scm.py as per
https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_test_and_print_scm_changes):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaselineall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport WebKit log messages on Android
commit-queue@webkit.org [Tue, 29 May 2012 23:27:59 +0000 (23:27 +0000)]
Support WebKit log messages on Android
https://bugs.webkit.org/show_bug.cgi?id=87773

Patch by Alexandre Elias <aelias@google.com> on 2012-05-29
Reviewed by Darin Adler.

This sends WebKit log messages to the Android "logcat" facility, as
Android sends stderr to /dev/null.

* wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS3 Backgrounds and Borders] Implement box-decoration-break parsing.
alexis.menard@openbossa.org [Tue, 29 May 2012 23:24:58 +0000 (23:24 +0000)]
[CSS3 Backgrounds and Borders] Implement box-decoration-break parsing.
https://bugs.webkit.org/show_bug.cgi?id=87678

Reviewed by Eric Seidel.

Source/WebCore:

Implement the parsing part of box-decoration-break. The specification
is located at http://www.w3.org/TR/css3-background/#box-decoration-break.
So far Opera implements it. This patch only implements the parsing part of
the property. A following patch will implement the rendering part. Despite
the rendering part missing it improves http://css3test.com by 1%.

Test: fast/box-decoration-break/box-decoration-break-parsing.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleBoxData.cpp:
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):
* rendering/style/StyleBoxData.h:
(WebCore::StyleBoxData::boxDecorationBreak):
(StyleBoxData):

LayoutTests:

Add a new test to cover the parsing part of the new css property. Also rebase the
existing tests which are listing the css properties of the style.

* fast/box-decoration-break/box-decoration-break-parsing-expected.txt: Added.
* fast/box-decoration-break/box-decoration-break-parsing.html: Added.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/svg/css/getComputedStyle-basic-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[text-overflow: ellipsis] WebKit should ignore the ellipsis for the purpose of dispat...
commit-queue@webkit.org [Tue, 29 May 2012 23:20:56 +0000 (23:20 +0000)]
[text-overflow: ellipsis] WebKit should ignore the ellipsis for the purpose of dispatching mouse events
https://bugs.webkit.org/show_bug.cgi?id=63781

Patch by David Barr <davidbarr@chromium.org> on 2012-05-29
Reviewed by Eric Seidel.

Source/WebCore:

"Ellipsing only affects rendering and must not affect layout nor dispatching of pointer events."
http://www.w3.org/TR/2012/WD-css3-ui-20120117/#text-overflow

Test: fast/css/text-overflow-ellipsis-hit-test.html

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint): Always return false.

LayoutTests:

* fast/css/text-overflow-ellipsis-hit-test-expected.txt: Added.
* fast/css/text-overflow-ellipsis-hit-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Tue, 29 May 2012 23:15:48 +0000 (23:15 +0000)]
[EFL] Unreviewed gardening.

Unskip a lot of fast/selectors tests which were really passing all
the time, they just needed updated baselines after the jhbuild and
font commits.

* platform/efl/Skipped:
* platform/efl/fast/selectors/001-expected.png:
* platform/efl/fast/selectors/002-expected.png:
* platform/efl/fast/selectors/003-expected.png:
* platform/efl/fast/selectors/004-expected.png:
* platform/efl/fast/selectors/005-expected.png:
* platform/efl/fast/selectors/006-expected.png:
* platform/efl/fast/selectors/007a-expected.png:
* platform/efl/fast/selectors/007b-expected.png:
* platform/efl/fast/selectors/008-expected.png:
* platform/efl/fast/selectors/009-expected.png:
* platform/efl/fast/selectors/010-expected.png:
* platform/efl/fast/selectors/011-expected.png:
* platform/efl/fast/selectors/012-expected.png:
* platform/efl/fast/selectors/013-expected.png:
* platform/efl/fast/selectors/014-expected.png:
* platform/efl/fast/selectors/015-expected.png:
* platform/efl/fast/selectors/018-expected.png:
* platform/efl/fast/selectors/018b-expected.png:
* platform/efl/fast/selectors/021-expected.png:
* platform/efl/fast/selectors/021b-expected.png:
* platform/efl/fast/selectors/032-expected.png:
* platform/efl/fast/selectors/034-expected.png:
* platform/efl/fast/selectors/038-expected.png:
* platform/efl/fast/selectors/040-expected.png:
* platform/efl/fast/selectors/043-expected.png:
* platform/efl/fast/selectors/043b-expected.png:
* platform/efl/fast/selectors/044-expected.png:
* platform/efl/fast/selectors/044b-expected.png:
* platform/efl/fast/selectors/044c-expected.png:
* platform/efl/fast/selectors/044d-expected.png:
* platform/efl/fast/selectors/045-expected.png:
* platform/efl/fast/selectors/045b-expected.png:
* platform/efl/fast/selectors/045c-expected.png:
* platform/efl/fast/selectors/046-expected.png:
* platform/efl/fast/selectors/054-expected.png:
* platform/efl/fast/selectors/056-expected.png:
* platform/efl/fast/selectors/058-expected.png:
* platform/efl/fast/selectors/059-expected.png:
* platform/efl/fast/selectors/060-expected.png:
* platform/efl/fast/selectors/061-expected.png:
* platform/efl/fast/selectors/063-expected.png:
* platform/efl/fast/selectors/064-expected.png:
* platform/efl/fast/selectors/066-expected.png:
* platform/efl/fast/selectors/066b-expected.png:
* platform/efl/fast/selectors/072-expected.png:
* platform/efl/fast/selectors/072b-expected.png:
* platform/efl/fast/selectors/077-expected.png:
* platform/efl/fast/selectors/077b-expected.png:
* platform/efl/fast/selectors/078b-expected.png:
* platform/efl/fast/selectors/083-expected.png:
* platform/efl/fast/selectors/087b-expected.png:
* platform/efl/fast/selectors/090b-expected.png:
* platform/efl/fast/selectors/154-expected.png:
* platform/efl/fast/selectors/155-expected.png:
* platform/efl/fast/selectors/155a-expected.png:
* platform/efl/fast/selectors/155b-expected.png:
* platform/efl/fast/selectors/155c-expected.png:
* platform/efl/fast/selectors/155d-expected.png:
* platform/efl/fast/selectors/156b-expected.png:
* platform/efl/fast/selectors/157-expected.png:
* platform/efl/fast/selectors/158-expected.png:
* platform/efl/fast/selectors/160-expected.png:
* platform/efl/fast/selectors/168-expected.png:
* platform/efl/fast/selectors/168a-expected.png:
* platform/efl/fast/selectors/169-expected.png:
* platform/efl/fast/selectors/169a-expected.png:
* platform/efl/fast/selectors/lang-inheritance-expected.png:
* platform/efl/fast/selectors/lang-inheritance2-expected.png:
* platform/efl/fast/selectors/lang-vs-xml-lang-expected.png:
* platform/efl/fast/selectors/lang-vs-xml-lang-xhtml-expected.png:
* platform/efl/fast/selectors/visited-descendant-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] WebOverlay build fixes and bug fixes
commit-queue@webkit.org [Tue, 29 May 2012 23:12:38 +0000 (23:12 +0000)]
[BlackBerry] WebOverlay build fixes and bug fixes
https://bugs.webkit.org/show_bug.cgi?id=87780

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Fix build when accelerated compositing disabled, or debug build.

Also fix a bug where the selection overlay would not disappear properly
because of a typo in WebPage::removeOverlay(). Also convert said method
to early return style.

Debug build fixes contributed by Ming Xie.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlay::addAnimation):
(BlackBerry::WebKit::WebOverlay::setContentsToImage):
(WebKit):
(BlackBerry::WebKit::WebOverlay::setContentsToColor):
(BlackBerry::WebKit::WebOverlay::setDrawsContent):
(BlackBerry::WebKit::WebOverlay::invalidate):
(BlackBerry::WebKit::WebOverlay::setClient):
(BlackBerry::WebKit::WebOverlay::override):
(BlackBerry::WebKit::WebOverlay::resetOverrides):
* Api/WebOverlayOverride.cpp:
(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
* Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::removeOverlay):
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<progress> element is unsupported on Windows
jberlin@webkit.org [Tue, 29 May 2012 23:12:01 +0000 (23:12 +0000)]
<progress> element is unsupported on Windows
https://bugs.webkit.org/show_bug.cgi?id=49769

Add platform-specific results for tests that use the progress element on Windows.

* platform/win/fast/forms/label: Added.
* platform/win/fast/forms/label/labelable-elements-expected.txt: Added.
* platform/win/fast/forms/label/labels-add-htmlFor-label-expected.txt: Added.
* platform/win/fast/forms/label/labels-add-parent-label-expected.txt: Added.
* platform/win/fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Added.
* platform/win/fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
* platform/win/fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
* platform/win/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Added.
* platform/win/fast/forms/label/labels-remove-htmlFor-label-expected.txt: Added.
* platform/win/fast/forms/label/labels-remove-parent-label-expected.txt: Added.
* platform/win/fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove assertions on state in Prerender.cpp
gavinp@chromium.org [Tue, 29 May 2012 23:07:49 +0000 (23:07 +0000)]
[Chromium] Remove assertions on state in Prerender.cpp
https://bugs.webkit.org/show_bug.cgi?id=87746

Chrome was crashing in the new Prerender API on Google Web Search; this was because the DOM would stop(), setting the
state of the Prerenders in the document to Inactive, but an asyncronous GC would later come come along and trigger the
removedFromDocument behaviour on each element, including the <link> element launching the prerender.  This causes an
assertion failure.

I believe the late-deletion of the DOM, and the HTMLElement::removedFromDocument calls are legal, and it was the
overzealous assertions in Prerender that were inappropriate.

Reviewed by Adam Barth.

No new automated tests, working on a Chromium browser test. Manually test by entering many prerender and non-prerendered
queries into Google Web Search.

* platform/chromium/Prerender.cpp:
(WebCore::Prerender::Prerender):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
* platform/chromium/Prerender.h:
(Prerender):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add malloc info to about:memory page
commit-queue@webkit.org [Tue, 29 May 2012 22:59:15 +0000 (22:59 +0000)]
[BlackBerry] Add malloc info to about:memory page
https://bugs.webkit.org/show_bug.cgi?id=87676

Patch by Yong Li <yoli@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Detailed malloc info can tell us how much memory
in the heaps is being in use.

* WebCoreSupport/AboutData.cpp:
(WebCore::memoryPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating test expectation (media/track/track-cues-missed CRASH).
rafaelw@chromium.org [Tue, 29 May 2012 22:59:04 +0000 (22:59 +0000)]
Updating test expectation (media/track/track-cues-missed CRASH).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Tue, 29 May 2012 22:53:27 +0000 (22:53 +0000)]
[EFL] Unreviewed gardening.

House cleaning on Skipped: remove tests which do not exist, unskip
some which are passing and add expectations for some which were
lacking them.

* platform/efl/Skipped:
* platform/efl/editing/selection/fake-doubleclick-expected.png: Added.
* platform/efl/editing/selection/fake-doubleclick-expected.txt: Added.
* platform/efl/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/efl/fast/borders/border-image-slice-constrained-expected.txt: Added.
* platform/efl/fast/borders/border-mixed-alpha-expected.png: Added.
* platform/efl/fast/borders/borderRadiusArcs01-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusDouble01-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusDouble02-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusDouble03-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusGroove01-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusGroove02-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusInset01-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusOutset01-expected.txt: Added.
* platform/efl/fast/borders/borderRadiusRidge01-expected.txt: Added.
* platform/efl/fast/borders/scaled-border-image-expected.png: Added.
* platform/efl/fast/borders/scaled-border-image-expected.txt: Added.
* platform/efl/fast/forms/input-appearance-disabled-expected.png: Added.
* platform/efl/fast/forms/input-appearance-disabled-expected.txt: Added.
* platform/efl/fast/forms/input-appearance-readonly-expected.png: Added.
* platform/efl/fast/forms/input-appearance-readonly-expected.txt: Added.
* platform/efl/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
* platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
* platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
* platform/efl/fast/forms/textarea-scrollbar-expected.png: Added.
* platform/efl/fast/forms/textarea-scrollbar-expected.txt: Added.
* platform/efl/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/efl/fast/line-grid/line-grid-floating-expected.txt: Added.
* platform/efl/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
* platform/efl/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/efl/fast/line-grid/line-grid-into-floats-expected.txt: Added.
* platform/efl/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/efl/fast/line-grid/line-grid-positioned-expected.txt: Added.
* platform/efl/fast/repaint/4774354-expected.png: Added.
* platform/efl/fast/repaint/4774354-expected.txt: Added.
* platform/efl/fast/repaint/4776765-expected.png: Added.
* platform/efl/fast/repaint/4776765-expected.txt: Added.
* platform/efl/fast/repaint/delete-into-nested-block-expected.png: Added.
* platform/efl/fast/repaint/delete-into-nested-block-expected.txt: Added.
* platform/efl/fast/repaint/inline-outline-repaint-expected.png: Added.
* platform/efl/fast/repaint/inline-outline-repaint-expected.txt: Added.
* platform/efl/fast/repaint/selection-after-delete-expected.png: Added.
* platform/efl/fast/repaint/selection-after-delete-expected.txt: Added.
* platform/efl/fast/selectors/159-expected.png: Added.
* platform/efl/fast/selectors/159-expected.txt: Added.
* platform/efl/fast/selectors/177a-expected.png: Added.
* platform/efl/fast/selectors/177a-expected.txt: Added.
* platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
* platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.
* platform/efl/fast/table/colspanMinWidth-vertical-expected.png:
* platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/efl/fast/text/delete-hard-break-character-expected.png: Added.
* platform/efl/fast/text/delete-hard-break-character-expected.txt: Added.
* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png: Added.
* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt: Added.
* platform/efl/mathml/presentation/roots-expected.png: Added.
* platform/efl/mathml/presentation/roots-expected.txt: Added.
* platform/efl/mathml/presentation/row-alignment-expected.png: Added.
* platform/efl/mathml/presentation/row-alignment-expected.txt: Added.
* platform/efl/media/controls-styling-expected.png: Added.
* platform/efl/media/controls-styling-expected.txt: Added.
* platform/efl/svg/batik/text/textAnchor-expected.png: Added.
* platform/efl/svg/batik/text/textOnPath3-expected.png: Added.
* platform/efl/svg/batik/text/verticalTextOnPath-expected.png: Added.
* platform/efl/svg/carto.net/tabgroup-expected.png: Added.
* platform/efl/transitions/cross-fade-background-image-expected.png: Added.
* platform/efl/transitions/cross-fade-border-image-expected.png: Added.
* platform/efl/transitions/default-timing-function-expected.png:
* platform/efl/transitions/default-timing-function-expected.txt:
* platform/efl/transitions/move-after-transition-expected.png:
* platform/efl/transitions/move-after-transition-expected.txt:
* platform/efl/transitions/svg-text-shadow-transition-expected.png:
* platform/efl/transitions/svg-text-shadow-transition-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating test expectations (fast/forms/form-associated-element-removal MISSING).
rafaelw@chromium.org [Tue, 29 May 2012 22:36:59 +0000 (22:36 +0000)]
Updating test expectations (fast/forms/form-associated-element-removal MISSING).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87711
slewis@apple.com [Tue, 29 May 2012 22:33:35 +0000 (22:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87711

Reviewed by Jessie Berlin.

Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
are better maintained.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisplay cues in the controls area
commit-queue@webkit.org [Tue, 29 May 2012 22:28:15 +0000 (22:28 +0000)]
Display cues in the controls area
https://bugs.webkit.org/show_bug.cgi?id=87591

Patch by Victor Carbune <victor@rosedu.org> on 2012-05-29
Reviewed by Eric Carlson.

Source/WebCore:

Changed the behaviour to implicitly hide the volume slidebar
if the controls are hidden (due mouse moving out of the video
area or controls are toggled through JS).

This seems to be the simplest fix to this issue, otherwise
on toggling the display:none property on the controls the
volume slidebar might appear below the video.

Re-enabled failing tests for this functionality.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::makeTransparent): Re-enabled
timer to set the display:none property on the controls.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::hide): Added a call to hide
the volume slider.
(WebCore::MediaControlRootElement::makeTransparent): Same.
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::hide): Same.
(WebCore::MediaControlRootElementChromium::makeTransparent): Same.

LayoutTests:

* media/media-volume-slider-rendered-normal-expected.txt: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none-expected.txt.
* media/media-volume-slider-rendered-normal.html: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none.html.
* platform/chromium/test_expectations.txt: Unmarked tests.
* platform/efl/test_expectations.txt: Unmarked tests.
* platform/mac/test_expectations.txt: Unmarked tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix transparent iframes with composited contents in WK1 on Mac
enne@google.com [Tue, 29 May 2012 22:24:47 +0000 (22:24 +0000)]
Fix transparent iframes with composited contents in WK1 on Mac
https://bugs.webkit.org/show_bug.cgi?id=76478

Reviewed by Simon Fraser.

Test: compositing/iframes/repaint-after-losing-scrollbars.html

* page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87787
hyatt@apple.com [Tue, 29 May 2012 22:22:42 +0000 (22:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87787

[New Multicolumn] Refactor the region and flow thread code so that it can pick up the correct column widths
and heights when determining the logical width and height of the flow thread itself.

This patch adds new virtual methods to RenderRegion: logicalWidthForFlowThreadContent and logicalHeightForFlowThreadContent.
For normal regions, these methods return the contentWidth and contentHeight of the regions themselves. For column sets,
however, these methods actually return the column widths and heights.

This allows the flow thread to properly lay out according to the column width.

Region invalidation is also done properly by using these new methods.

In some cases the code is actually simplified, since we can get rid of some isHorizontalWritingMode() switching.

With this patch the flow thread now actually lays out and paints at the right width (spilling out of the region set in a single unbroken
column).

Reviewed by Dan Bernstein.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::isRenderMultiColumnBlock):
(RenderMultiColumnBlock):
(WebCore::toRenderMultiColumnBlock):
(WebCore):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::computeLogicalWidth):
(WebCore):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):
* rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::setColumnWidthAndCount):
(RenderMultiColumnSet):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMultiColumnBlock):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::logicalWidthForFlowThreadContent):
(WebCore):
(WebCore::RenderRegion::logicalHeightForFlowThreadContent):
(WebCore::RenderRegion::layout):
* rendering/RenderRegion.h:
(RenderRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch optimize-baselines should add/delete files in batches from the vcs
dpranke@chromium.org [Tue, 29 May 2012 21:46:29 +0000 (21:46 +0000)]
webkit-patch optimize-baselines should add/delete files in batches from the vcs
https://bugs.webkit.org/show_bug.cgi?id=87538

Reviewed by Ojan Vafai.

Invoking git and svn on one file at a time is kinda slow. We
should batch the add and rm operations together.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._move_baselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening. Unskip passing test.
rakuco@webkit.org [Tue, 29 May 2012 21:39:07 +0000 (21:39 +0000)]
[EFL] Gardening. Unskip passing test.

* platform/efl/Skipped:
* platform/efl/editing/input/emacs-ctrl-o-expected.png: Added.
* platform/efl/editing/input/emacs-ctrl-o-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should rebaseline baselines in parallel
dpranke@chromium.org [Tue, 29 May 2012 21:30:41 +0000 (21:30 +0000)]
garden-o-matic should rebaseline baselines in parallel
https://bugs.webkit.org/show_bug.cgi?id=87451

Reviewed by Ojan Vafai.

This modifies garden-o-matic so that we will fetch all
of the baselines in parallel from the bots, and then
optimize the baselines serially (since that should be fairly
quick and we get into trouble if we optimize in parallel due
to concurrent access to the source control system).

This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
so that the files that need to be modified in the SCM are returned to
garden-o-matic rather than actually added or removed. This is done so that
we can run multiple rebaseline-tests in parallel (we can't modify the SCM
concurrently). In order to safely return the files (as a JSON dict) I
needed to shift all of the logging in rebaseline-test to use the logging
module (and hence log to stderr).

I also had to stub out a line in chromium.py that would get confused if
the skia overrides file didn't exist in a mock checkout.

* Scripts/webkitpy/common/system/executive.py:
(Executive.popen):
(Executive):
(Executive.run_in_parallel):
(_run_command_thunk):
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.run_in_parallel):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_run_in_parallel):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._expectations_file_contents):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand.__init__):
(RebaselineTest.__init__):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._save_baseline):
(RebaselineTest):
(RebaselineTest._add_to_scm):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
(RebaselineExpectations._rebaseline_port):
(RebaselineExpectations.execute):
(Rebaseline._builder_to_pull_from):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_expectations):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler._rebaseline_commands):
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler._files_to_add):
(GardeningHTTPRequestHandler._optimize_baselines):
(GardeningHTTPRequestHandler.rebaselineall):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest._post_to_path):
(GardeningServerTest.test_rebaselineall):
(GardeningServerTest.test_rebaselineall.run_command):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Align codes and names for IDB-specific and DOM-specific errors/exceptions
commit-queue@webkit.org [Tue, 29 May 2012 21:20:30 +0000 (21:20 +0000)]
IndexedDB: Align codes and names for IDB-specific and DOM-specific errors/exceptions
https://bugs.webkit.org/show_bug.cgi?id=87276

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-29
Reviewed by Tony Chang.

Source/WebCore:

No new tests. Existing tests have been updated to use the new
exception constant values.

The IDB spec has evolved to DOM4-style DOMExceptions, which are
referred to with MixedCase, string-based style names for
exceptions rather than UNDERSCORE_CONSTANT_ERR codes. Change to
use MixedCase error/exception names, and tease out the
IDB-specific exception/error codes/names from the system-level
codes. Make sure that the legacy IDB-masked exception code values
match the DOM exception values. Make sure that
IDBDatabaseException[exception.name] still works.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
* Modules/indexeddb/IDBDatabaseException.cpp:
(IDBDatabaseExceptionNameDescription):
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):
* Modules/indexeddb/IDBDatabaseException.h:
* Modules/indexeddb/IDBDatabaseException.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::abort):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::objectStore):

Source/WebKit/chromium:

* public/WebIDBDatabaseException.h:
* src/AssertMatchingEnums.cpp:

LayoutTests:

* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/resources/constants.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new failing tests
ossy@webkit.org [Tue, 29 May 2012 21:17:12 +0000 (21:17 +0000)]
[Qt] Unreviewed gardening, skip new failing tests
because of missing LayoutTestController implementation.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unskip scroll related layout tests
commit-queue@webkit.org [Tue, 29 May 2012 21:13:17 +0000 (21:13 +0000)]
[EFL] Unskip scroll related layout tests
https://bugs.webkit.org/show_bug.cgi?id=87765

Unreviewed EFL gardening.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-29

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87775
hyatt@apple.com [Tue, 29 May 2012 21:13:05 +0000 (21:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87775

[New Multicolumn] Make sure RenderMultiColumnSets have their own copy of the count, width and height of their columns.

Reviewed by Anders Carlsson.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::columnWidth):
(WebCore::RenderMultiColumnBlock::columnCount):
(RenderMultiColumnBlock):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
* rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::columnWidth):
(WebCore::RenderMultiColumnSet::columnHeight):
(RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::setColumnWidthAndCount):
(WebCore::RenderMultiColumnSet::setColumnHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: windows DRT needs to implement ::press
jberlin@webkit.org [Tue, 29 May 2012 20:58:16 +0000 (20:58 +0000)]
AX: windows DRT needs to implement ::press
https://bugs.webkit.org/show_bug.cgi?id=36145

Add more tests that use press to the Windows Skipped list.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago fast/events/message-port-close.html hits ASSERT in Debug
ap@apple.com [Tue, 29 May 2012 20:56:15 +0000 (20:56 +0000)]
    fast/events/message-port-close.html hits ASSERT in Debug
        https://bugs.webkit.org/show_bug.cgi?id=85811

        * platform/mac/Skipped: I think that it's just this one test with a delayed effect. Skipping
        it, and unskipping a victim.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating chromium test_expectations (svg/dom/viewspec-parser timeouts)
rafaelw@chromium.org [Tue, 29 May 2012 20:49:23 +0000 (20:49 +0000)]
Updating chromium test_expectations (svg/dom/viewspec-parser timeouts)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncomplete repaint on twitter.com when replying to a tweet
simon.fraser@apple.com [Tue, 29 May 2012 20:49:15 +0000 (20:49 +0000)]
Incomplete repaint on twitter.com when replying to a tweet
https://bugs.webkit.org/show_bug.cgi?id=87553

Reviewed by Dean Jackson.

Manual test that adds a transform to a layer, forcing that
layer to gain backing store.

* ManualTests/compositing/requires-backing-change.html: Added.

Source/WebCore:

Reviewed by Dean Jackson.

Style changes can cause a compositing layer to change between
requiring its own backing store or not, e.g. with the addition
or removal of a transform.

When that happens, we need to repaint the ancesetor layer that
this layer was, or will be drawing into.

Factored some code out of layerWillBeRemoved() to be able to
also call it from setRequiresOwnBackingStore().

New manual test, ManualTests/compositing/requires-backing-change.html.
I was not able to get an automated pixel test to work.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Remove trailing whitespace.
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSC doesn't support heap profiling.
jberlin@webkit.org [Tue, 29 May 2012 20:35:46 +0000 (20:35 +0000)]
JSC doesn't support heap profiling.
https://bugs.webkit.org/show_bug.cgi?id=50485

Add another heap profiling test to the Mac and Windows Skipped lists.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87771
hyatt@apple.com [Tue, 29 May 2012 20:27:43 +0000 (20:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87771

[New Multicolumn] Make sure we have one column set by default and add it to the flow thread's region list.

Reviewed by Anders Carlsson.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago WTR doesn't support beginDragWithFiles.
ap@apple.com [Tue, 29 May 2012 20:26:58 +0000 (20:26 +0000)]
    WTR doesn't support beginDragWithFiles.

        * platform/wk2/Skipped: Added fast/files/file-list-test.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up the Windows WK2 Skipped list.
jberlin@webkit.org [Tue, 29 May 2012 20:19:35 +0000 (20:19 +0000)]
Clean up the Windows WK2 Skipped list.

Update it for the moves / renames in r96918, r102226, and r108612.

* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
rafaelw@chromium.org [Tue, 29 May 2012 20:03:22 +0000 (20:03 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSC doesn't support heap profiling.
jberlin@webkit.org [Tue, 29 May 2012 19:59:07 +0000 (19:59 +0000)]
JSC doesn't support heap profiling.
https://bugs.webkit.org/show_bug.cgi?id=50485

Add two heap profiling tests to the Windows Skipped list.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the type of dispatch_time() offset
benjamin@webkit.org [Tue, 29 May 2012 19:42:00 +0000 (19:42 +0000)]
Fix the type of dispatch_time() offset

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-29
Rubber-stamped by Joseph Pecoraro.

In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().

* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate label for blacklisted plug-in
sullivan@apple.com [Tue, 29 May 2012 19:33:02 +0000 (19:33 +0000)]
Update label for blacklisted plug-in
https://bugs.webkit.org/show_bug.cgi?id=87767
rdar://problem/11550048

Reviewed by Kevin Decker.

* English.lproj/Localizable.strings:
Regenerated.

* platform/LocalizedStrings.cpp:
(WebCore::insecurePluginVersionText):
Changed this string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
jchaffraix@webkit.org [Tue, 29 May 2012 19:30:43 +0000 (19:30 +0000)]
REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
https://bugs.webkit.org/show_bug.cgi?id=87536

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html
       fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html
       fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html
       fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html

The change in r111742 completely ignored border-sizing (following the table's code lead unfortunately).
The issue is that we would count the borders and paddings twice for the border-box case which would lead
to the content-box including them too. From a web-author, this behavior is equivalent to ignoring box-sizing.

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
Reworked the function to properly use computeBorderBoxLogicalWidth() for correctness. This matches
what RenderBox and the rendering code does generally. Also refactored the code to avoid the need
for local variables and make it more readable.

LayoutTests:

* fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html: Added.
This test covers the regression.

* fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html: Added.
* fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html: Added.
* fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html: Added.
Those test ensured I didn't regress and document our current behavior ie that column and column group fixed
width apply to the cell's border-box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAbsolute positioned elements in a relative positioned CSS3 Flexbox fail to display...
ojan@chromium.org [Tue, 29 May 2012 19:28:04 +0000 (19:28 +0000)]
Absolute positioned elements in a relative positioned CSS3 Flexbox fail to display properly
https://bugs.webkit.org/show_bug.cgi?id=58453

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/align-absolute-child.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild):
When adjusting positioned items, adjust their static position, not their location.
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/align-absolute-child-expected.txt: Added.
* css3/flexbox/align-absolute-child.html: Added.
* css3/flexbox/position-absolute-child-expected.txt:
* css3/flexbox/position-absolute-child.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] ~1/2 of all the iframe seamless tests fail
jberlin@webkit.org [Tue, 29 May 2012 19:23:23 +0000 (19:23 +0000)]
[Win] ~1/2 of all the iframe seamless tests fail
https://bugs.webkit.org/show_bug.cgi?id=87543

Rubber-stamped by Eric Seidel.

WebKitLibraries:

Finish enabling IFRAME_SEAMLESS on Windows.

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Remove the platform-specific results as they are no longer needed.

* platform/win/fast/frames/seamless/seamless-basic-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-get-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-get-named-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-post-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-post-named-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-hyperlink-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-hyperlink-named-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-inherited-document-style-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-location-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-location-href-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-open-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash due to text fragment destruction when updating first-letter block.
inferno@chromium.org [Tue, 29 May 2012 19:15:26 +0000 (19:15 +0000)]
Crash due to text fragment destruction when updating first-letter block.
https://bugs.webkit.org/show_bug.cgi?id=87751

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/text/text-fragment-first-letter-update-crash.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):

LayoutTests:

* fast/text/text-fragment-first-letter-update-crash-expected.txt: Added.
* fast/text/text-fragment-first-letter-update-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87764
hyatt@apple.com [Tue, 29 May 2012 19:12:34 +0000 (19:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87764

Add implementation of checkForPaginationLogicalHeightChange to RenderMultiColumnBlock.

Also stub out ensureColumnSets() and write a comment describing how it's going to work.

Reviewed by Anders Carlsson.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::columnHeight):
(WebCore::RenderMultiColumnBlock::setColumnHeight):
(RenderMultiColumnBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening of failing tests and new passes
commit-queue@webkit.org [Tue, 29 May 2012 18:48:19 +0000 (18:48 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=87754

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-29

* platform/efl/Skipped:
* platform/efl/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/efl/fast/forms/select/optgroup-rendering-expected.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118620.
commit-queue@webkit.org [Tue, 29 May 2012 18:42:01 +0000 (18:42 +0000)]
Unreviewed, rolling out r118620.
http://trac.webkit.org/changeset/118620
https://bugs.webkit.org/show_bug.cgi?id=87760

This patch causes regression to read an empty file/blob via
FileReader (Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-29

Source/WebCore:

* fileapi/FileReader.cpp:
(WebCore::FileReader::stringResult):

LayoutTests:

* fast/files/blob-slice-test-expected.txt:
* fast/files/read-blob-async-expected.txt:
* fast/files/read-file-async-expected.txt:
* fast/files/resources/read-common.js:
(logResult):
* fast/files/workers/worker-read-blob-async-expected.txt:
* fast/files/workers/worker-read-file-async-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
jberlin@webkit.org [Tue, 29 May 2012 18:39:32 +0000 (18:39 +0000)]
[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
fast/loader/reload-zero-byte-plugin.html

Skip the test on Windows to get the bots greener.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCopiedSpace::doneCopying could start another collection
mhahnenberg@apple.com [Tue, 29 May 2012 18:38:14 +0000 (18:38 +0000)]
CopiedSpace::doneCopying could start another collection
https://bugs.webkit.org/show_bug.cgi?id=86538

Reviewed by Geoffrey Garen.

It's possible that if we don't have anything at the head of to-space
after a collection and the BlockAllocator doesn't have any fresh blocks
to give us right now we could start another collection while still in
the middle of the first collection when we call CopiedSpace::addNewBlock().

One way to resolve this would be to have Heap::shouldCollect() check that
m_operationInProgress is NoOperation. This would prevent the path in
getFreshBlock() that starts the collection if we're already in the middle of one.

I could not come up with a test case to reproduce this crash on ToT.

* heap/Heap.h:
(JSC::Heap::shouldCollect): We shouldn't collect if we're already in the middle
of a collection, i.e. the current operation should be NoOperation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake StylePropertySet a variable-sized object to reduce memory use.
kling@webkit.org [Tue, 29 May 2012 18:19:59 +0000 (18:19 +0000)]
Make StylePropertySet a variable-sized object to reduce memory use.
<http://webkit.org/b/87506>

Reviewed by Antti Koivisto.

Make immutable StylePropertySet objects variable-sized and allocate exactly
the space needed to hold the CSSProperty objects passed at construction.
This lets us avoid the memory overhead of Vector<CSSProperty, 4>.

Renamed StylePropertySet::adopt* to create and createImmutable since they no
longer adopt the incoming vector. More cleanup will follow in this area.

This reduces memory usage across the board - the more CSS declarations,
the bigger the benefit. As an example, we save around ~0.5MB on wsj.com.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSParser.cpp:
(WebCore::CSSParser::createStylePropertySet):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::averageSizeInBytes):
(SameSizeAsStylePropertySet):
(WebCore::StylePropertySet::append):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::propertyAt):
(WebCore::StylePropertySet::propertyCount):
(WebCore::StylePropertySet::isEmpty):
(WebCore::StylePropertySet::array):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87759
hyatt@apple.com [Tue, 29 May 2012 18:15:03 +0000 (18:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87759

Pull the initial page logical height checking for columns into its own separate function. This
will allow the derived RenderMultiColumnBlock class to do its own setup there. It also has the
effect of cleaning up layoutBlock even for the existing code.

Reviewed by Anders Carlsson.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderBlock.h:
(RenderBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding VISTA timeout expectations to a number of viewport tests. Also, narrowing...
rafaelw@chromium.org [Tue, 29 May 2012 18:13:07 +0000 (18:13 +0000)]
Adding VISTA timeout expectations to a number of viewport tests. Also, narrowing optgroup-clicking.html
to be just MAC.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate cue event dispatching for zero and negative duration cues
commit-queue@webkit.org [Tue, 29 May 2012 17:55:52 +0000 (17:55 +0000)]
Update cue event dispatching for zero and negative duration cues
https://bugs.webkit.org/show_bug.cgi?id=85143

Patch by Victor Carbune <victor@rosedu.org> on 2012-05-29
Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Explicitly
treated event dispatching for zero and negative duration cues.
(WebCore::HTMLMediaElement::textTrackAddCue): Interval tree doesn't
handle invalid cues with intervals - negative cues need to be treated
as zero-length cues as they are always missed cues anyway.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.

LayoutTests:

* media/track/captions-webvtt/missed-cues.vtt: Added negative
duration cue and changed a missed cue to have zero-length.
* media/track/track-cues-missed-expected.txt: Updated.
* media/track/track-cues-missed.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
commit-queue@webkit.org [Tue, 29 May 2012 17:50:56 +0000 (17:50 +0000)]
[BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
https://bugs.webkit.org/show_bug.cgi?id=87604

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Antonio Gomes.

Also add a new method to allow the embedder to use the default tap
highlight instead of replacing it with a custom one just to keep track
of the "shouldHideAfterScroll" flag.

PR #160262.

* Api/WebTapHighlight.h:
* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
* WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::shouldHideAfterScroll):
(DefaultTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShadowRoot.getElementById() returns removed node.
morrita@google.com [Tue, 29 May 2012 17:50:03 +0000 (17:50 +0000)]
ShadowRoot.getElementById() returns removed node.
https://bugs.webkit.org/show_bug.cgi?id=62184

Source/WebCore:

Deregitration of m_elementsById map is done at Element::removedFrom()
But the tree scope of the removed node is already reset from a shadow root
to a document.

This change lookup the old shadow root through its parent node and
deregitrater the node against it.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/get-element-by-id-in-shadow-mutation.html

* dom/Element.cpp:
(WebCore::treeScopeOfParent):
(WebCore):
(WebCore::Element::removedFrom):
* dom/Element.h:
(Element):
(WebCore::Element::updateId):
(WebCore):

LayoutTests:

Reviewed by Dimitri Glazkov.

* fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt: Added.
* fast/dom/shadow/get-element-by-id-in-shadow-mutation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect
danakj@chromium.org [Tue, 29 May 2012 17:46:03 +0000 (17:46 +0000)]
[chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect
https://bugs.webkit.org/show_bug.cgi?id=87677

Reviewed by Adrienne Walker.

Source/WebCore:

When a contributing surface is visited, and we have not visited another
surface, then we know the surface is completely unoccluded. However, the
root scissor rect should still be applied, and anything outside of it
should be considered occluded.

Unit test: WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor

* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::targetRenderSurface):
(WebCore):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::targetRenderSurface):
(WebCore):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago * platform/mac/Skipped: Skipping a heap profiler test (unsupported functional...
ap@apple.com [Tue, 29 May 2012 17:23:02 +0000 (17:23 +0000)]
    * platform/mac/Skipped: Skipping a heap profiler test (unsupported functionality).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Refactoring http/proxy authentication to use authcallback mechanism...
commit-queue@webkit.org [Tue, 29 May 2012 17:14:19 +0000 (17:14 +0000)]
[BlackBerry] Refactoring http/proxy authentication to use authcallback mechanism introduced with libcurl
https://bugs.webkit.org/show_bug.cgi?id=87706

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-29
Reviewed by Antonio Gomes.

Because we use authentication callback mechanism of libcurl,
which will take care of all the authentication communication
between UA and server, so the only thing we need to do is to
provide credential information when authentication callback
is triggered. By using this we don't need to process
intermediate headers for each http authentication scheme.

Implemented interface function notifyAuthReceived() in
NetworkJob to handle the authentication notification from
networking thread.
When the authentication callback is triggered, we should
cancel the current loading request and restart a new one with
credential information attached which comes from
credentialStorage or user input.

Internally reviewed by Joe Mason <jmason@rim.com>.

No new tests since there is no behavior change.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore):
(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] http authentication challenge issue when loading subresource
commit-queue@webkit.org [Tue, 29 May 2012 16:57:19 +0000 (16:57 +0000)]
[BlackBerry] http authentication challenge issue when loading subresource
https://bugs.webkit.org/show_bug.cgi?id=87660

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-29
Reviewed by Rob Buis.

We should try to store the credential information as soon as we
receive http status notification which indicates that the
authentication succeeds, instead of storing credentials when the
main resource receives notify done which is too late for loading
subresource.

Internally reviewed by Joe Mason <jmason@rim.com>

No new tests since there is no change in behavior.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Move DefaultFonts.plist to C++ code
ap@apple.com [Tue, 29 May 2012 16:52:42 +0000 (16:52 +0000)]
[Mac] Move DefaultFonts.plist to C++ code
https://bugs.webkit.org/show_bug.cgi?id=87560
<rdar://problem/11466119>

Reviewed by Dan Bernstein.

* DerivedSources.make:
* Resources/DefaultFonts.plist.in: Removed.
* WebCore.xcodeproj/project.pbxproj:
* page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):
Instead of having a separate configuration file, just hardcode the settings in C++.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression: fast/forms/select/optgroup-clicking.html is failing / timing out
jberlin@webkit.org [Tue, 29 May 2012 16:49:11 +0000 (16:49 +0000)]
Regression: fast/forms/select/optgroup-clicking.html is failing / timing out
https://bugs.webkit.org/show_bug.cgi?id=87748

This test times out on Mac if there is no interaction with the keyboard. Skip it to keep the
bots green.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WK2] Reproducible crash in performDragControllerAction
commit-queue@webkit.org [Tue, 29 May 2012 16:48:54 +0000 (16:48 +0000)]
[GTK] [WK2] Reproducible crash in performDragControllerAction
https://bugs.webkit.org/show_bug.cgi?id=87744

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-29
Reviewed by Martin Robinson.

Fix a crash by using deref() instead of delete to dereference and
release the platformData of DragData.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
commit-queue@webkit.org [Tue, 29 May 2012 16:47:03 +0000 (16:47 +0000)]
[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=87745

Patch by Simon Pena <spena@igalia.com> on 2012-05-29
Reviewed by Carlos Garcia Campos.

Add missing initializers for WKPageLoaderClient and
WKPageUIClient, for callbacks WKPagePluginDidFailCallback and
WKPageUnavailablePluginButtonClickedCallback, introduced in
revision r116716.

* UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView): Initialize WKPagePluginDidFailCallback
* UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView): Initialize callback
WKPageUnavailablePluginButtonClickedCallback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Policy decision headers are not included in the main webkit2.h header
carlosgc@webkit.org [Tue, 29 May 2012 16:44:29 +0000 (16:44 +0000)]
[GTK] Policy decision headers are not included in the main webkit2.h header
https://bugs.webkit.org/show_bug.cgi?id=87753

Reviewed by Martin Robinson.

* UIProcess/API/gtk/webkit2.h: Include
WebKitNavigationPolicyDecision.h and WebKitResponsePolicyDecision.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Retainers are missing for all objects
commit-queue@webkit.org [Tue, 29 May 2012 16:36:08 +0000 (16:36 +0000)]
Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):

LayoutTests:

* inspector/profiler/heap-snapshot-summary-retainers-expected.txt: Added.
* inspector/profiler/heap-snapshot-summary-retainers.html: Added.
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] fast tests needs rebaseline after r118733
commit-queue@webkit.org [Tue, 29 May 2012 16:31:58 +0000 (16:31 +0000)]
[GTK] fast tests needs rebaseline after r118733
https://bugs.webkit.org/show_bug.cgi?id=87729

Unreviewed GTK gardening, updated fast pngs.

Patch by Simon Pena <spena@igalia.com> on 2012-05-29

* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/gtk/fast/forms/placeholder-position-expected.png:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
* platform/gtk/fast/forms/search-styled-expected.png:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.png:
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] fast/forms/select/optgroup-rendering.html "failing" since introduction in r118772
jberlin@webkit.org [Tue, 29 May 2012 16:29:31 +0000 (16:29 +0000)]
[Mac] fast/forms/select/optgroup-rendering.html "failing" since introduction in r118772
https://bugs.webkit.org/show_bug.cgi?id=87752

Add expected (failing?) results to get the bots green.

* platform/mac/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/mac/fast/forms/select/optgroup-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118791 268f45cc-cd09-0410-ab3c-d52691b4dbfc