WebKit-https.git
7 years agotables/mozilla/bugs/bug53690-1.html has never worked
abarth@webkit.org [Fri, 14 Oct 2011 10:23:46 +0000 (10:23 +0000)]
tables/mozilla/bugs/bug53690-1.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67745

Reviewed by Eric Seidel.

Previously, this script had just errored out.  This patch removes the
script, making the results more sane.

* platform/chromium-win/tables/mozilla/bugs/bug53690-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug53690-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug53690-1-expected.txt:
* tables/mozilla/bugs/bug53690-1.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Build is broken with new ld
carlosgc@webkit.org [Fri, 14 Oct 2011 10:15:47 +0000 (10:15 +0000)]
[GTK] Build is broken with new ld
https://bugs.webkit.org/show_bug.cgi?id=70097

Reviewed by Philippe Normand.

* UIProcess/API/gtk/tests/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Fix build after QSGItem API changes
hausmann@webkit.org [Fri, 14 Oct 2011 10:14:15 +0000 (10:14 +0000)]
[Qt][WK2] Fix build after QSGItem API changes
https://bugs.webkit.org/show_bug.cgi?id=69926

Reviewed by Kenneth Rohde Christiansen.

Commit c825865cdd88445aa1db94cdf0da89426919acdb in qtdeclarative changed the
signatures of the Drag & Drop event handlers in QSGItem. The SG specific events
were replaced with the plain QDrag* events, which are now used for widgets as well
as the Qt scene graph.

This patch adapts the desktop webview as well as the page proxy to handle these
kind of events.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragLeaveEvent):
(QDesktopWebView::dropEvent):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleDragEnterEvent):
(QDesktopWebPageProxy::handleDragLeaveEvent):
(QDesktopWebPageProxy::handleDragMoveEvent):
(QDesktopWebPageProxy::handleDropEvent):
* UIProcess/qt/qdesktopwebpageproxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotables/mozilla/bugs/bug9024.html has never worked
abarth@webkit.org [Fri, 14 Oct 2011 09:55:07 +0000 (09:55 +0000)]
tables/mozilla/bugs/bug9024.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67744

Reviewed by Eric Seidel.

Previously, this script had just errored out.  This patch removes the
scripts, which lets us share the same baseline across all the ports.

* platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Removed.
* tables/mozilla/bugs/bug9024-expected.txt: Added.
* tables/mozilla/bugs/bug9024.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update.
tkent@chromium.org [Fri, 14 Oct 2011 09:42:55 +0000 (09:42 +0000)]
[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=70013

* platform/chromium/test_expectations.txt:
Add more canvas crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Change -webkit-flow to -webkit-flow-into
mihnea@adobe.com [Fri, 14 Oct 2011 09:28:45 +0000 (09:28 +0000)]
[CSS Regions] Change -webkit-flow to -webkit-flow-into
https://bugs.webkit.org/show_bug.cgi?id=70014

Reviewed by David Hyatt.

1. -webkit-flow is renamed to -webkit-flow-into
2. -webkit-flow-into takes <ident> instead of strings

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::validFlowName):
(WebCore::CSSParser::parseFlowThread):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/regions/bottom-overflow-out-of-first-region.html:
* fast/regions/content-flowed-into-regions-no-scroll.html:
* fast/regions/float-pushed-width-change.html:
* fast/regions/floats-basic-in-variable-width-regions.html:
* fast/regions/flow-anonymous-children.html:
* fast/regions/flow-content-basic-vertical-rl.html:
* fast/regions/flow-content-basic-vertical.html:
* fast/regions/flow-content-basic.html:
* fast/regions/flows-dependency-dynamic-remove.html:
* fast/regions/flows-dependency-same-flow.html:
* fast/regions/hit-test-float.html:
* fast/regions/multiple-directionality-changes-in-variable-width-regions.html:
* fast/regions/no-split-line-box.html:
* fast/regions/outline-sides-in-region.html:
* fast/regions/overflow-in-uniform-regions-dynamic.html:
* fast/regions/overflow-in-uniform-regions.html:
* fast/regions/overflow-in-variable-width-regions.html:
* fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
* fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
* fast/regions/overflow-rtl-in-variable-width-regions.html:
* fast/regions/overflow-size-change-in-variable-width-regions.html:
* fast/regions/overflow-size-change-with-stacking-context-rtl.html:
* fast/regions/overflow-size-change-with-stacking-context.html:
* fast/regions/percentage-margins-mixed-ltr-dominant-regions.html:
* fast/regions/percentage-margins-mixed-rtl-dominant-regions.html:
* fast/regions/percentage-margins-rtl-variable-width-regions.html:
* fast/regions/percentage-margins-variable-width-regions.html:
* fast/regions/position-writing-modes-in-variable-width-regions.html:
* fast/regions/positioned-objects-block-static-in-regions.html:
* fast/regions/positioned-objects-block-static-in-rtl-regions.html:
* fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
* fast/regions/positioned-objects-block-static-spanning-regions.html:
* fast/regions/positioned-objects-in-regions.html:
* fast/regions/positioned-objects-in-rtl-regions.html:
* fast/regions/positioned-objects-inline-static-in-regions.html:
* fast/regions/positioned-objects-inline-static-in-rtl-regions.html:
* fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html:
* fast/regions/positioned-objects-inline-static-spanning-regions.html:
* fast/regions/positioned-objects-perpendicular-flows-in-regions.html:
* fast/regions/positioned-objects-spanning-regions.html:
* fast/regions/region-overflow-auto-overflow-hidden.html:
* fast/regions/region-overflow-auto-overflow-visible.html:
* fast/regions/region-overflow-break.html:
* fast/regions/resources/region-style.css:
(.flowArticle):
* fast/regions/script-tests/webkit-flow-parsing.js:
(test):
(testComputedStyle):
(testNotInherited):
* fast/regions/text-region-breaks.html:
* fast/regions/text-region-split-after-resize.html:
* fast/regions/text-region-split-horizontal-bt.html:
* fast/regions/text-region-split-small-pagination.html:
* fast/regions/text-region-split-vertical-rl.html:
* fast/regions/text-region-split-vertical.html:
* fast/regions/text-region-split.html:
* fast/regions/top-overflow-out-of-second-region.html:
* fast/regions/webkit-flow-double-pagination-float-push.html:
* fast/regions/webkit-flow-float-pushed-to-last-region.html:
* fast/regions/webkit-flow-float-unable-to-push.html:
* fast/regions/webkit-flow-floats-inside-regions-bounds.html:
* fast/regions/webkit-flow-inlines-dynamic.html:
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
* fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
* fast/regions/webkit-flow-parsing-expected.txt:
* fast/regions/webkit-flow-renderer-layer.html:
* fast/regions/webkit-flow-renderer-nested.html:
* fast/regions/webkit-flow-renderer.html:
* fast/repaint/japanese-rl-selection-repaint-in-regions.html:
* fast/repaint/line-flow-with-floats-in-regions.html:
* fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
* fast/repaint/region-painting-via-layout.html:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove SQLite backing store
hans@chromium.org [Fri, 14 Oct 2011 09:15:37 +0000 (09:15 +0000)]
IndexedDB: Remove SQLite backing store
https://bugs.webkit.org/show_bug.cgi?id=69620

Reviewed by Darin Fisher.

Remove the SQLite backing store implementation; it is not used anymore.
Also remove the maximumSize parameter, it is not used either.

Source/WebCore:

No new functionality, so no new tests.

* GNUmakefile.list.am:
* WebCore.gypi:
* storage/IDBBackingStore.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::computeFileIdentifier):
(WebCore::computeUniqueIdentifier):
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
* storage/IDBLevelDBBackingStore.h:
* storage/IDBSQLiteBackingStore.cpp: Removed.
* storage/IDBSQLiteBackingStore.h: Removed.

Source/WebKit/chromium:

* public/WebIDBFactory.h:
(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):
* src/AssertMatchingEnums.cpp:
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 14 Oct 2011 09:06:45 +0000 (09:06 +0000)]
2011-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix mac builds. r97448 broke them.

        * WebCore.xcodeproj/project.pbxproj: Set ImageBySizeCache.h role to private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClear WebMediaPlayerClientImpl back pointer on destruction
jschuh@chromium.org [Fri, 14 Oct 2011 08:36:20 +0000 (08:36 +0000)]
Clear WebMediaPlayerClientImpl back pointer on destruction
https://bugs.webkit.org/show_bug.cgi?id=69973

Reviewed by James Robinson.

Clear the backpointer and remove the unused m_currentFrame

Source/WebCore:

* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::releaseProvider):
* platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
* src/WebMediaPlayerClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Make IDBCursor.value() return an IDBAny object
hans@chromium.org [Fri, 14 Oct 2011 08:34:05 +0000 (08:34 +0000)]
IndexedDB: Make IDBCursor.value() return an IDBAny object
https://bugs.webkit.org/show_bug.cgi?id=70024

Reviewed by Tony Chang.

Source/WebCore:

This is to work around the fact that the V8 bindings mechanism does
eager deserialization of SerializedScriptValue attributes. This means
that the value is fetched from the back-end only once, when the
IDBCursor is first wrapped. When the cursor's value changes, this is
not reflected.

We work around this by making IDBCursor.value() return the
SerializedScriptValue wrapped in an IDBAny object.

* storage/IDBCursor.cpp:
(WebCore::IDBCursor::value):
* storage/IDBCursor.h:
* storage/IDBCursorWithValue.idl:

LayoutTests:

Update test expectations since more of this test now passes.

* storage/indexeddb/cursor-inconsistency-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix compilation when the JS Debugger is disabled.
commit-queue@webkit.org [Fri, 14 Oct 2011 08:12:59 +0000 (08:12 +0000)]
Fix compilation when the JS Debugger is disabled.
https://bugs.webkit.org/show_bug.cgi?id=70007

Patch by RĂ©mi Duraffort <remi.duraffort@st.com> on 2011-10-14
Reviewed by Antti Koivisto.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
* inspector/InspectorRuntimeAgent.cpp:
* inspector/InspectorRuntimeAgent.h:
* inspector/WorkerInspectorController.cpp:
* inspector/WorkerInspectorController.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 14 Oct 2011 08:08:51 +0000 (08:08 +0000)]
2011-10-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Prepare SVGImage intrinsic size negotiation: Introduce an IntSize <-> SVGImage cache in CachedImage
        https://bugs.webkit.org/show_bug.cgi?id=69416

        Reviewed by Antti Koivisto.

        Refactor ImageBySizeCache out of CSSImageGeneratorValue as CachedImage wants to use the same type of cache for its purposes.
        When introducing the SVGImage intrinsic size negotiation the container size of an SVGImage is dependant on the place where
        it gets embedded (eg width/height attributes of host documents <img> force a certain size).

        Currently CachedImage only contains a single RefPtr<Image>, which it constructs out of the decoded data.
        Multiple RenderObjects share the same CachedImages, when embedding eg. a SVG document in a <html:img> or using it in a background-image for a <div>.
        Consider the case where two RenderObjects use the same CachedImage, each with a different container size (200x100 vs 100x200) and the embedded
        document contains a viewBox and some arbitary preserveAspectRatio settings. To honour these we have to relayout the document with the desired
        size (percentual unit resolving etc, all depend on the RenderSVGRoots size).

        With the current design this is hard to realize, w/o requring to relayout the embedded document for each embedder that uses an SVGImage.
        This patch introduces a cache right within CachedImage, which manages a map of images to certain sizes, by utilizing the new ImageBySizeCache.

        CachedImage::imageForRenderer() takes a RenderObject* parameter, which it uses to look up the last set image container size for a renderer.
        Using that size it queries the cache whether it already has an SVGImage for that size, if not it gets created, by creating a whole
        new instance of SVGImage, filling it with the already decoded data, and passing on a fixed image container size, which overrides the
        size that RenderSVGRoot reports, when computeReplacedLogicalWidth/Height is called and thus laying out the document at the desired size.
        This image is then put in the cache for further reusability.

        Likewise CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter and stores that in the cache with an associated container size.
        It requires to touch several files which use CachedImage throughout WebCore/WebKit/WebKit2.

        The actual cache is not yet turned on yet, so this is not a functional change so far, as it needs some other changes to SVGImage,
        which will come with the master patch in bug 47156.

        No new tests yet, as the new cache isn't turned on yet.

        * CMakeLists.txt: Add rendering/ImageBySizeCache.* to build.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use new CachedImage::imageSizeForRenderer(RenderObject*) method.
        * bindings/objc/DOM.mm: Ditto (for CachedImage::image()).
        (-[DOMElement image]):
        (-[DOMElement _imageTIFFRepresentation]):
        * bridge/qt/qt_pixmapruntime.cpp:
        (JSC::Bindings::QtPixmapInstance::variantFromObject): Ditto (for CachedImage::image()).
        * css/CSSCanvasValue.cpp: s/m_clients/clients()/, which now live in the ImageBySizeCache instead of CSSImageGeneratorValue.
        (WebCore::CSSCanvasValue::canvasChanged):
        (WebCore::CSSCanvasValue::canvasResized):
        (WebCore::CSSCanvasValue::image):
        * css/CSSGradientValue.cpp: Ditto.
        (WebCore::CSSGradientValue::image):
        * css/CSSImageGeneratorValue.cpp: Move the sizes/clients/images cache into a new ImageBySizeCache class, to make it usable for CachedImage as well.
        (WebCore::CSSImageGeneratorValue::addClient): Adapt to move.
        (WebCore::CSSImageGeneratorValue::removeClient): Ditto.
        (WebCore::CSSImageGeneratorValue::getImage): Ditto.
        (WebCore::CSSImageGeneratorValue::putImage): Ditto.
        * css/CSSImageGeneratorValue.h:
        (WebCore::CSSImageGeneratorValue::clients): Forwarded to the ImageBySizeCache.
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement): CachedImage::canRender() now takes a RenderObject* parameter.
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::width): Use new CachedImage::imageSizeForRenderer(RenderObject*) method.
        (WebCore::HTMLImageElement::height): Ditto.
        (WebCore::HTMLImageElement::naturalWidth): Ditto.
        (WebCore::HTMLImageElement::naturalHeight): Ditto.
        * html/ImageDocument.cpp:
        (WebCore::ImageDocumentParser::finish): Ditto.
        (WebCore::ImageDocument::scale): Ditto.
        (WebCore::ImageDocument::resizeImageToFit): Ditto.
        (WebCore::ImageDocument::imageUpdated): Ditto.
        (WebCore::ImageDocument::restoreImageSize): Ditto.
        (WebCore::ImageDocument::imageFitsInWindow): Ditto.
        * html/canvas/CanvasRenderingContext.cpp:
        (WebCore::CanvasRenderingContext::wouldTaintOrigin): Use new CachedImage::imageForRenderer(RenderObject*) method.
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::isOriginClean): Ditto.
        (WebCore::size): Ditto (for CachedImage::imageSizeForRenderer()).
        (WebCore::CanvasRenderingContext2D::drawImage): Ditto.
        (WebCore::CanvasRenderingContext2D::createPattern): Ditto.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::texImage2D): Ditto.
        (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
        * loader/cache/CachedImage.cpp: Add currently _disabled_ cache for SVGImages. The intrinsic size negotiation will need to use multiple SVGImages
        for each requested size (equal to the size of the embedding place for the image) - make it possible to cache these SVGImages, and maintain a cache
        for them. The hash code is a 1:1 refactoring from the already present code in CSSImageGeneratorValue, now named 'ImageBySizeCache'.
        (WebCore::CachedImage::lookupImageForSize): Looks up an Image from the cache for a given IntSize. Currently turned off.
        (WebCore::CachedImage::lookupImageForRenderer): Looks up an Image from the cache for a given renderer. Currently turned off.
        (WebCore::CachedImage::lookupOrCreateImageForRenderer): Looks up an Image from the cache or creates a new SVGImage for a given size and caches it, if possible. Currently turned off.
        All following changes share this: Don't operate on m_image directly, instead always look up one from the cache for a given size or renderer - if that's not present fallback to m_image.
        When an SVGImage is first created by CachedImage::createImage() and stored in m_image, the cache remains empty.

        If eg. <img width="30" height="70" src="foo.svg"> is used which implies a container size of 30x70 a new SVGImage is created with the additional information of a 30x70 container size
        which is immediately passed to the SVGImage after its creation. This SVGImage is put in the ImageBySizeCache associated with a container size of 30x70.
        We now have two SVGImage objects present, one living in CachedImage::m_image, created by createImage() during data decoding, and one living in the ImageBySizeCache
        created by lookupOrCreateImageForRenderer() associated with the 30x70 container. The first SVGImage::size() will return a value as defined in the referenced foo.svg,
        whereas the SVGImage::size() call of the new SVGImage living in the cache reports 30x70 and renders according to that.

        Whenever any method of CachedImage is called with a RenderObject* or IntSize, we can't just operate on m_image anymore but instead have to lookup the right
        images for a certain renderer/size from the cache and operate on these. When calling eg. CachedImage::image() with a null renderer, m_image is returned.
        When passing with a valid renderer only cache lookups are done if the m_image is actually a SVGImage, otherwhise lookupImageForSize/Renderer will just return the m_image.
        There is no logical change induced for non-SVGImage derived images.

        CachedImage::image() of course needs a RenderObject* parameter now, to identify which of the images from the cache to use, if the underlying image is a SVGImage.
        Luckily these information are already present in StyleCachedImage/StyleImage & friends and only need to be added for some additional methods.
        (WebCore::CachedImage::image): FIXME
        (WebCore::CachedImage::imageForRenderer): Call lookupOrCreateImageForRenderer() instead of returning m_image, if it's not null. Its a no-op for non SVGImage derived objects.
        (WebCore::CachedImage::setContainerSizeForRenderer): For non-SVGImages, just pass on the size to the m_image. For SVGImages, associate the passed in renderer with the IntSize in the cache.
                                                             This does NOT create the SVGImage yet, this is delayed until imageForRenderer() is called for a given renderer that wants this size.
        (WebCore::CachedImage::imageSize): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
        (WebCore::CachedImage::imageRect): Ditto.
        (WebCore::CachedImage::clear): Force clearing the m_svgImageCache.
        (WebCore::CachedImage::data): Call m_image->size() instead of imageSize(), to avoid having to pass a null renderer to imageSize() as here no renderer is available yet.
        (WebCore::CachedImage::destroyDecodedData): Don't destroy decoded data for SVG images, as m_data needs to be accessable at any time to construct a cloned SVGImage.
                                                    In future we don't need this anymore if we make sure multiple SVGImages share the same trees, but that's for a follow-up patch.
        (WebCore::CachedImage::decodedSizeChanged): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
        (WebCore::CachedImage::didDraw): Ditto.
        (WebCore::CachedImage::shouldPauseAnimation): Ditto.
        (WebCore::CachedImage::animationAdvanced): Ditto.
        (WebCore::CachedImage::changedInRect): Ditto. (eg. when leaving out this change animated SVG images wouldn't update anymore, as the animation didn't happen on m_image!)
        * loader/cache/CachedImage.h: imageForRenderer/canRender/setContainerSizeForRenderer/imageSizeForRenderer now all take a RenderObject* parameter to identifiy the current user of the image.
        (WebCore::CachedImage::canRender): Pass on the incoming renderer to imageSizeForRenderer().
        * page/DragController.cpp:
        (WebCore::getImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectCursor): Ditto.
        * page/PageSerializer.cpp:
        (WebCore::PageSerializer::serializeFrame): Ditto.
        (WebCore::PageSerializer::addImageToResources): Ditto.
        (WebCore::PageSerializer::retrieveResourcesForCSSDeclaration): Ditto.
        * page/PageSerializer.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::writeImageToDataObject): Ditto.
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeImage): Ditto.
        * platform/graphics/Image.h:
        (WebCore::Image::isSVGImage): Add boolean helper to identify SVGImages, just like isBitmapImage().
        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::declareAndWriteDragImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeImage): Ditto.
        * platform/mac/HTMLConverter.mm:
        (fileWrapperForElement): Ditto.
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage): Ditto.
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage): Ditto.
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeImage): Ditto.
        * platform/win/ClipboardWin.cpp:
        (WebCore::writeImageToDataObject): Ditto.
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeImage): Ditto.
        * platform/wince/PasteboardWinCE.cpp:
        (WebCore::Pasteboard::writeImage): Ditto.
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::image): Ditto.
        * rendering/ImageBySizeCache.cpp: Copied from WebCore/css/CSSImageGeneratorValue.cpp, to preserve history for the original cache code.
        (WebCore::ImageBySizeCache::ImageBySizeCache): Straight copy from CSSImageGeneratorValue, renamed to ImageBySizeCache, removing all but the cache relevant code.
        (WebCore::ImageBySizeCache::addClient): Ditto.
        (WebCore::ImageBySizeCache::removeClient): Ditto.
        (WebCore::ImageBySizeCache::getImage): Ditto.
        (WebCore::ImageBySizeCache::putImage): Ditto.
        (WebCore::ImageBySizeCache::clear): New function, that clears the cache, introduced for the needs of CachedImage.
        (WebCore::ImageBySizeCache::imageForSize): New function to query an Image* for a given IntSize, introduced for the needs of CachedImage.
        (WebCore::ImageBySizeCache::sizeForClient): New function to query an IntSize for a given renderer.
        * rendering/ImageBySizeCache.h: Copied from WebCore/css/CSSImageGeneratorValue.h.
        (WebCore::ImageBySizeCache::clients):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintFillLayer): CachedImage::canRender() now takes a RenderObject* parameter.
        (WebCore::InlineFlowBox::paintBoxDecorations): Ditto.
        (WebCore::InlineFlowBox::paintMask): Ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMaskImages): Ditto.
        (WebCore::RenderBox::repaintLayerRectsForImage): Ditto.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended): Ditto.
        (WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto (for CachedImage::setContainerSizeForRenderer()).
        (WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageSizeForError): Use new CachedImage::imageForRenderer(RenderObject*) method.
        (WebCore::RenderImage::setImageSizeForAltText): Ditto.
        (WebCore::RenderImage::computeReplacedLogicalWidth): FIXME
        * rendering/RenderImageResource.cpp:
        (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass on m_renderer to CachedImage::setContainerSizeForRenderer().
        * rendering/RenderImageResource.h: Remove constness from setContainerSizeForRenderer.
        (WebCore::RenderImageResource::image): Pass on m_renderer to CachedImage::image().
        (WebCore::RenderImageResource::imageSize): Pass on m_renderer to CachedImage::imageSizeForRenderer().
        * rendering/RenderImageResourceStyleImage.h:
        (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Remove constness, pass on m_renderer to StyleImage::setContainerSizeForRenderer().
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
        (WebCore::RenderLayerBacking::updateImageContents): Ditto.
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::computePreferredLogicalWidths): CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter.
        * rendering/RenderObject.cpp:
        (WebCore::mustRepaintFillLayers): CachedImage::canRender() now takes a RenderObject* parameter.
        (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Ditto.
        * rendering/style/StyleCachedImage.cpp:
        (WebCore::StyleCachedImage::canRender): Pass on incoming renderer to CachedImage::canRender().
        (WebCore::StyleCachedImage::imageSize): Pass on incoming renderer to CachedImage::imageSizeForRenderer().
        (WebCore::StyleCachedImage::setContainerSizeForRenderer): Pass on incoming renderer to CachedImage::setContainerSizeForRenderer().
        (WebCore::StyleCachedImage::addClient): Remove unneeded return statment in void method.
        (WebCore::StyleCachedImage::removeClient): Ditto.
        (WebCore::StyleCachedImage::image): Pass on incoming renderer to CachedImage::image().
        * rendering/style/StyleCachedImage.h: Add RenderObject* parameter to canRender()/setContainerSizeForRenderer(). image() already has one, that was unused so far.
        * rendering/style/StyleGeneratedImage.cpp: Inlined setContainerSizeForRenderer.
        * rendering/style/StyleGeneratedImage.h:
        (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Add RenderObject* parameter.
        * rendering/style/StyleImage.h:
        (WebCore::StyleImage::canRender): Ditto.
        * rendering/style/StylePendingImage.h:
        (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::build): Use new CachedImage::imageForRenderer(RenderObject*) method.
        * svg/graphics/SVGImage.cpp: Cleanup file, the include hack seems not needed anymore.
        (WebCore::SVGImage::setContainerSize): s/LayoutSize/IntSize/ to match the code in platform/.
        * svg/graphics/SVGImage.h: Ditto.
        (WebCore::SVGImage::isSVGImage): Return true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake it possible for plugins to get current fullscreen element.
commit-queue@webkit.org [Fri, 14 Oct 2011 08:04:53 +0000 (08:04 +0000)]
Make it possible for plugins to get current fullscreen element.
WebCore::Document already has webkitCurrentFullScreenElement().
Add a wrapper for it in WebKit::WebDocument.
https://bugs.webkit.org/show_bug.cgi?id=70076

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-14
Reviewed by Darin Fisher.

* public/WebDocument.h:
* src/WebDocument.cpp:
(WebKit::WebDocument::securityOrigin):
(WebKit::WebDocument::isHTMLDocument):
(WebKit::WebDocument::isPluginDocument):
(WebKit::WebDocument::fullScreenElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculation failures in ValueToInt32 are causing a 2x slow-down
fpizlo@apple.com [Fri, 14 Oct 2011 07:07:46 +0000 (07:07 +0000)]
Speculation failures in ValueToInt32 are causing a 2x slow-down
in Kraken/stanford-crypto-pbkdf2
https://bugs.webkit.org/show_bug.cgi?id=70089

Reviewed by Gavin Barraclough.

If we can't truncate to Int32 using machine code, then don't fail
speculation. Just call JSC::toInt32.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Uninitialized read in WebCore::*Font* / HB_GSUB_Select_Feature
bashi@chromium.org [Fri, 14 Oct 2011 06:57:10 +0000 (06:57 +0000)]
[Chromium] Uninitialized read in WebCore::*Font* / HB_GSUB_Select_Feature
https://bugs.webkit.org/show_bug.cgi?id=70087

Reviewed by Kent Tamura.

Initialize local variables in ComplexTextControllerLinux::setupfontFeatures.

No new tests because there is no behavior change. Manually tested with valgrind.

* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::setupFontFeatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose layer debug borders to WebLayer
commit-queue@webkit.org [Fri, 14 Oct 2011 06:24:10 +0000 (06:24 +0000)]
Expose layer debug borders to WebLayer
https://bugs.webkit.org/show_bug.cgi?id=70079

Patch by Antoine Labour <piman@chromium.org> on 2011-10-13
Reviewed by Darin Fisher.

* public/WebLayer.h:
* src/WebLayer.cpp:
(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Unreviewed buildfix after r97433.
ossy@webkit.org [Fri, 14 Oct 2011 06:14:54 +0000 (06:14 +0000)]
[Qt][Win] Unreviewed buildfix after r97433.

* platform/MemoryPressureHandler.h: Add a missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-13 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 14 Oct 2011 05:21:51 +0000 (05:21 +0000)]
2011-10-13  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, updating Chromium expectations for http/tests/media/video-play-stall.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpelling error in v8WebSocket::constructorCallback error
abarth@webkit.org [Fri, 14 Oct 2011 05:12:32 +0000 (05:12 +0000)]
Spelling error in v8WebSocket::constructorCallback error
https://bugs.webkit.org/show_bug.cgi?id=63943

Reviewed by Kent Tamura.

Source/WebCore:

Fix typo.

* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):

LayoutTests:

* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd missing result. Yes, it's supposed to be blank.
abarth@webkit.org [Fri, 14 Oct 2011 05:08:29 +0000 (05:08 +0000)]
Add missing result.  Yes, it's supposed to be blank.

* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update test expectation.
tkent@chromium.org [Fri, 14 Oct 2011 03:32:09 +0000 (03:32 +0000)]
[Chromium] Update test expectation.

- Mark some tests flaky on Windows GPU
- Update Leopard-specific images.

* platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WEBKIT2] Add WebKitSettings GTK+ API.
mrobinson@webkit.org [Fri, 14 Oct 2011 03:18:30 +0000 (03:18 +0000)]
[GTK][WEBKIT2] Add WebKitSettings GTK+ API.
https://bugs.webkit.org/show_bug.cgi?id=68371

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-13
Reviewed by Martin Robinson.

WebKitSettings GTK+ object is created and first set of
API's are written to get or set the properties of WebKitSettings.

* GNUmakefile.am: Added new files for compilation.
* UIProcess/API/gtk/WebKitSettings.cpp: Added.
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Constructor.
(webKitSettingsSetProperty): Set property function.
(webKitSettingsGetProperty): Get property function.
(webKitSettingsFinalize): Class finalize function.
(webkit_settings_class_init): Class init function.
(webkit_settings_init): Instance init function.
(webkit_settings_new): Creates WebKitSettings GObject.
(webkit_settings_get_enable_javascript): Function to get 'enable-javascript' property.
(webkit_settings_set_enable_javascript): Function to set 'enable-javascript' property.
(webkit_settings_get_auto_load_images): Get the 'auto-load-images' property.
(webkit_settings_set_auto_load_images): Set the 'auto-load-images' property.
(webkit_settings_get_load_icons_ignoring_image_load_setting): Function to get
'load-icons-ignoring-image-load-setting' property.
(webkit_settings_set_load_icons_ignoring_image_load_setting): Function to set
'load-icons-ignoring-image-load-setting' property.
(webkit_settings_get_enable_offline_web_application_cache): Function to get
'enable-offline-web-application-cache' property.
(webkit_settings_set_enable_offline_web_application_cache): Function to set
'enable-offline-web-application-cache' property.
(webkit_settings_get_enable_html5_local_storage): Get the property 'enable-html5-local-storage'.
(webkit_settings_set_enable_html5_local_storage): Set the property 'enable-html5-local-storage'.
(webkit_settings_get_enable_html5_database): Get the property 'enable-html5-database'.
(webkit_settings_set_enable_html5_database): Set the property 'enable-html5-database'.
(webkit_settings_get_enable_xss_auditor): Get property 'enable-xss-editor'.
(webkit_settings_set_enable_xss_auditor): Set property 'enable-xss-editor'.
(webkit_settings_get_enable_frame_flattening): Get the property 'enable-frame-flattening'.
(webkit_settings_set_enable_frame_flattening): Set the property 'enable-frame-flattening'.
(webkit_settings_get_enable_plugins): Get the property 'enable-plugins'.
(webkit_settings_set_enable_plugins): Set the property 'enable-plugins'.
(webkit_settings_get_enable_java): Function to get 'enable-java' property.
(webkit_settings_set_enable_java): Function to set 'enable-java' property.
(webkit_settings_get_javascript_can_open_windows_automatically): Get the property
'javascript-can-open-windows-automatically'.
(webkit_settings_set_javascript_can_open_windows_automatically): Set the property
'javascript-can-open-windows-automatically'.
(webkit_settings_get_enable_hyperlink_auditing): Get 'enable-hyperlink-auditing' property.
(webkit_settings_set_enable_hyperlink_auditing): Set 'enable-hyperlink-auditing' property.
* UIProcess/API/gtk/WebKitSettings.h: Added. Public API's.
* UIProcess/API/gtk/tests/GNUmakefile.am: Added new test.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp: Added.
(testWebKitSettings): Add WebKitSetting unit test.
(beforeAll): Pre-test function.
(afterAll): Post-test function.
* UIProcess/API/gtk/webkit2.h: Add WebKitSettings.h to exposed API list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake filter-build-webkit exit 1 if the build fails.
ojan@chromium.org [Fri, 14 Oct 2011 03:11:24 +0000 (03:11 +0000)]
Make filter-build-webkit exit 1 if the build fails.
https://bugs.webkit.org/show_bug.cgi?id=70080

Reviewed by Eric Seidel.

This only works if you redirect stderr to stdout, but it at least makes it possible.
This is useful if you want to run a followup command (e.g. run-webkit-tests) but
only if the build succeeds.

* Scripts/filter-build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename virtual getConstructData to getConstructDataVirtual
mhahnenberg@apple.com [Fri, 14 Oct 2011 02:22:41 +0000 (02:22 +0000)]
Rename virtual getConstructData to getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=69872

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::getConstructDataVirtual):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getConstructDataVirtual):
* API/JSObjectRef.cpp:
(JSObjectIsConstructor):
(JSObjectCallAsConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getConstructDataVirtual):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getConstructDataVirtual):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getConstructDataVirtual):
* runtime/DateConstructor.h:
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::getConstructDataVirtual):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getConstructDataVirtual):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getConstructDataVirtual):
* runtime/FunctionConstructor.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getConstructDataVirtual):
* runtime/JSCell.h:
(JSC::getConstructData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getConstructDataVirtual):
* runtime/JSFunction.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getConstructDataVirtual):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getConstructDataVirtual):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getConstructDataVirtual):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getConstructDataVirtual):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getConstructDataVirtual):
* runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

* WebCore.exp.in:
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::getConstructDataVirtual):
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::getConstructDataVirtual):
* bindings/js/JSImageConstructor.h:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::getConstructDataVirtual):
* bindings/js/JSOptionConstructor.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::construct):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructDataVirtual):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getConstructDataVirtual):
* bridge/runtime_object.h:

Source/WebKit/mac:

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::construct):

Source/WebKit2:

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getConstructDataVirtual):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWould be nice if the review-tool offered to show the corresponding header
abarth@webkit.org [Fri, 14 Oct 2011 01:40:23 +0000 (01:40 +0000)]
Would be nice if the review-tool offered to show the corresponding header
https://bugs.webkit.org/show_bug.cgi?id=63963

Reviewed by Ojan Vafai.

This is a first cut at adding links to the header file in the review
tool.  If folks like this feature, we can cover more cases in the
future.

* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove #include of <QuartzCore/QuartzCore.h> in a widely-used header.
simon.fraser@apple.com [Fri, 14 Oct 2011 01:22:42 +0000 (01:22 +0000)]
Remove #include of <QuartzCore/QuartzCore.h> in a widely-used header.

Reviewed by Sam Weinig.

* platform/PlatformScreen.h: Typedef PlatformDisplayID to a uint32_t.
* platform/graphics/DisplayRefreshMonitor.h: Typedef CVDisplayLinkRef as
an opaque type to avoid bringing in QuartzCore.h, and move displayLinkCallback
to the .cpp file since it uses Core Video types.
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::displayLinkCallback): Make this a local static function, that
calls a member fuction on the object.
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: High frequency memory warnings cause Safari to hog the CPU doing useless...
msaboff@apple.com [Fri, 14 Oct 2011 01:16:52 +0000 (01:16 +0000)]
REGRESSION: High frequency memory warnings cause Safari to hog the CPU doing useless garbage collection
https://bugs.webkit.org/show_bug.cgi?id=69774

Throttle the processing of memory pressure events to no more often than once every 5 seconds.

Reviewed by Geoffrey Garen.

No new tests.

* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
* platform/MemoryPressureHandler.h:
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRubber stamped Stephanie Lewis.
fpizlo@apple.com [Fri, 14 Oct 2011 01:01:45 +0000 (01:01 +0000)]
Rubber stamped Stephanie Lewis.

DFG_ENABLE() macro was always returning false.

* dfg/DFGNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement an OverflowEvent constructor for V8
haraken@chromium.org [Fri, 14 Oct 2011 00:57:31 +0000 (00:57 +0000)]
Implement an OverflowEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=70017

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/overflow-event-constructor.html

* bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
* dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother SnowLeopard build fix.
weinig@apple.com [Fri, 14 Oct 2011 00:42:06 +0000 (00:42 +0000)]
Another SnowLeopard build fix.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):
(-[WKPasteboardOwner initWithImage:WebCore::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=70064
inferno@chromium.org [Fri, 14 Oct 2011 00:37:56 +0000 (00:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70064

The NPObjectWrapper class used by V8 bindings in Chromium to wrap the window
script object was allocating an instance of itself in the NPAllocate
implementation and returning this pointer. It should be returning a pointer
to the wrapped NPObject structure (NPProxyObject). The member function
getUnderlyingNPObject should return 0 if we fail to find the underlying NPObject
for the call. It was incorrectly returning a pointer to the same NPObject in
this case which could cause recursion.

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2011-10-13
Reviewed by Nate Chapin.

No new tests as there is no change in functionality.

* bindings/v8/NPObjectWrapper.cpp:
(WebCore::NPObjectWrapper::getObjectForCall):
(WebCore::NPObjectWrapper::NPAllocate):
* bindings/v8/NPObjectWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix SnowLeopard build.
weinig@apple.com [Fri, 14 Oct 2011 00:35:11 +0000 (00:35 +0000)]
Fix SnowLeopard build.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setCursor):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoland-cowboy should at least check style.
dglazkov@chromium.org [Fri, 14 Oct 2011 00:29:15 +0000 (00:29 +0000)]
land-cowboy should at least check style.
https://bugs.webkit.org/show_bug.cgi?id=70073

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnsure font loaded before calling Skia to drawPosText in Chrome sandbox
simonjam@chromium.org [Fri, 14 Oct 2011 00:17:22 +0000 (00:17 +0000)]
Ensure font loaded before calling Skia to drawPosText in Chrome sandbox
https://bugs.webkit.org/show_bug.cgi?id=69370

Patch by Arthur Hsu <arthurhsu@chromium.org> on 2011-10-13
Reviewed by James Robinson.

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove layerX / layerY from the Chromium API
jchaffraix@webkit.org [Thu, 13 Oct 2011 23:51:59 +0000 (23:51 +0000)]
Remove layerX / layerY from the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=70052

Reviewed by Darin Fisher.

* public/WebDOMMouseEvent.h:
* src/WebDOMMouseEvent.cpp:
Just remove the 2 properties without considering the ABI stability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
haraken@chromium.org [Thu, 13 Oct 2011 23:45:43 +0000 (23:45 +0000)]
Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
https://bugs.webkit.org/show_bug.cgi?id=69801

As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.

Reviewed by Adam Barth.

No new tests, since no change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.
(GenerateConstructorCallback):
* bindings/scripts/test/TestInterface.idl: Ditto.
* fileapi/FileReader.idl: Ditto.
* p2p/PeerConnection.idl: Ditto.
* page/EventSource.idl: Ditto.
* workers/Worker.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConstructor should not be called if the object is being constructed inside WebCore
haraken@chromium.org [Thu, 13 Oct 2011 23:39:11 +0000 (23:39 +0000)]
Constructor should not be called if the object is being constructed inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=70015

Reviewed by Adam Barth.

Summary: A DOM object can be created from the JS context and from the WebCore context.
Constructor should be called if the object is created from the JS context,
but should not be called if the object is created from the WebCore context.

Details:
- Expected behavior when the object is created from the JS context (e.g. "new Event()"):
(1) V8XXXX::constructorCallback() is called.
(2) V8XXXX::constructorCallback() calls XXXX::create().
(3) XXXX::create() creates a C++ object.
(4) V8XXXX::constructorCallback() calls toV8() for the C++ object.
(5) toV8() wraps the C++ object and returns the wrapped JS object.

- Actual behavior when the object is created from the JS context (e.g. "new Event()"):
As described above (1) - (5). That's fine!!

- Expected behavior when the object is created from the WebCore context.
(e.g. "window.addEventListener("load", function (event) { ... });". In this case,
the Event object is created inside the WebCore context):
(1) WebCore calls XXXX::create().
(2) XXXX::create() creates a C++ object.
(3) WebCore calls toV8() for the C++ object.
(4) toV8() wraps the C++ object and returns the wrapped JS object.

- Actual behavior when the object is created from the WebCore context.
(e.g. "window.addEventListener("load", function (event) { ... });"):
(1) WebCore calls XXXX::create().
(2) XXXX::create() creates a C++ object.
(3) WebCore calls toV8() for the C++ object.
(4) toV8() can call XXXX::constructorCallback(). (Whether or not toV8() calls
XXXX::constructorCallback() depends on the implementation of toV8().)
(5) V8XXXX::constructorCallback() calls XXXX::create().
(6) XXXX::create() creates __another__ C++ object.
(7) V8XXXX::constructorCallback() calls toV8() for the C++ object.
(8) toV8() wraps the C++ object and returns the wrapped JS object.

This actual behavior definitely causes the following problems:

- Problem1: The object returned to JS is not the object created in (2)
but the object created in (6). However, I do not yet know a test case that causes
some visible bug because of this problem.

- Problem2: In (4), XXXX::constructorCallback() can be called with no argument.
If XXXX::constructorCallback() expects at least one argument, XXXX::constructorCallback()
throws TypeError, resulting in crash. For example, Event caused this problem
when I implemented constructor for Event. Based on the discussion with Dominicc,
we solved this problem by adding the following two lines of code to Event::constructorCallback()
(See here: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp&exact_package=chromium&q=allowallocation&type=cs):

XXXX::constructorCallback(...) {
    ...;
    if (AllowAllocation::current())
        return args.Holder();
    ...;
}

This if check means "XXXX::constructorCallback() returns immediately if it is called
from the WebCore context".

With these observations, we think that all constructorCallback() should have the above
if check. This patch adds the if check to CodeGeneratorV8.pm. After this patch is landed,
I would like to add the if check to all existing custom V8 constructors.

No new tests, since we could not find a test case that causes some visible bug without the if check.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Generates a constructor so that it returns immediately without doing anything if the constructor is called from the WebCore context.
* bindings/scripts/test/V8/V8TestInterface.cpp: Updated the result.
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::V8TestObj::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [Mac] PDF Documents at epo.org look very blurry
ap@apple.com [Thu, 13 Oct 2011 23:38:32 +0000 (23:38 +0000)]
    [Mac] PDF Documents at epo.org look very blurry
        https://bugs.webkit.org/show_bug.cgi?id=70072

        Reviewed by Dan Bernstein.

        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::paintContent):
        Ensure integral coordinates. <rdar://problem/10283382> tracks lifting this limitation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
commit-queue@webkit.org [Thu, 13 Oct 2011 23:37:35 +0000 (23:37 +0000)]
[EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=70002

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-13
Reviewed by Joseph Pecoraro.

Adapt to the changes introduced in r97336 and r97338 by using a vector
of strings instead of a single string in runOpenPanel().

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::runOpenPanel):
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(ewk_view_run_open_panel): Change signature; accept a Vector<String>
instead of a char*. Build an Eina_List to pass for child classes.
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofix regex in layout test times dashboard
tony@chromium.org [Thu, 13 Oct 2011 23:22:53 +0000 (23:22 +0000)]
fix regex in layout test times dashboard
https://bugs.webkit.org/show_bug.cgi?id=70059

This fixes the treemapfocus query param.

Reviewed by Ojan Vafai.

* TestResultServer/static-dashboards/treemap.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement a BeforeLoadEvent constructor for V8
haraken@chromium.org [Thu, 13 Oct 2011 23:16:09 +0000 (23:16 +0000)]
Implement a BeforeLoadEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69980

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/before-load-event-constructor.html

* bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
* dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add a colon to make expectation valid.
dglazkov@chromium.org [Thu, 13 Oct 2011 23:14:19 +0000 (23:14 +0000)]
[Chromium] Add a colon to make expectation valid.

* platform/chromium/test_expectations.txt: Jeez.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomake IDBFactory.open wait for pending setVersion transactions to complete
commit-queue@webkit.org [Thu, 13 Oct 2011 23:08:13 +0000 (23:08 +0000)]
make IDBFactory.open wait for pending setVersion transactions to complete
https://bugs.webkit.org/show_bug.cgi?id=69307

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-13
Reviewed by Tony Chang.

Source/WebCore:

Added a queue of pending open calls, similar to the queue of pending
setVersion calls. Ensure pending calls are processed in the correct
order when transactions complete.

Tests: storage/indexeddb/open-close-version.html
       storage/indexeddb/two-version-changes.html
       storage/indexeddb/version-change-exclusive.html

* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transactionStarted):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::start):
(WebCore::IDBTransactionBackendImpl::commit):

LayoutTests:

Some tests marked FAIL due to crbug.com/100123

* storage/indexeddb/open-close-version-expected.txt: Added.
* storage/indexeddb/open-close-version.html: Added.
* storage/indexeddb/two-version-changes-expected.txt: Added.
* storage/indexeddb/two-version-changes.html: Added.
* storage/indexeddb/version-change-exclusive-expected.txt: Added.
* storage/indexeddb/version-change-exclusive.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=70069
dglazkov@chromium.org [Thu, 13 Oct 2011 22:54:02 +0000 (22:54 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70069
REGRESSION (r63637): [Chromium] http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php reports as MISSING results.

* platform/chromium/test_expectations.txt: Added expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Automatically pull clang on `update-webkit --chromium` on mac
thakis@chromium.org [Thu, 13 Oct 2011 22:51:44 +0000 (22:51 +0000)]
[chromium] Automatically pull clang on `update-webkit --chromium` on mac
https://bugs.webkit.org/show_bug.cgi?id=70058

Reviewed by Adam Barth.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTweaking moar expectations.
dglazkov@chromium.org [Thu, 13 Oct 2011 22:39:24 +0000 (22:39 +0000)]
Tweaking moar expectations.

* platform/chromium/test_expectations.txt: Tweakage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLeopard build fix
cmarrin@apple.com [Thu, 13 Oct 2011 22:34:34 +0000 (22:34 +0000)]
Leopard build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative build fix for !DFG builds.
barraclough@apple.com [Thu, 13 Oct 2011 22:30:05 +0000 (22:30 +0000)]
Speculative build fix for !DFG builds.

* jit/JIT.cpp:
(JSC::JIT::privateCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [Mac] Wheel event handler counter is incorrect with PDF views
ap@apple.com [Thu, 13 Oct 2011 22:25:05 +0000 (22:25 +0000)]
    [Mac] Wheel event handler counter is incorrect with PDF views
        https://bugs.webkit.org/show_bug.cgi?id=70062

        Reviewed by Dan Bernstein.

        * WebProcess/Plugins/PDF/BuiltInPDFView.h:
        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
        (WebKit::BuiltInPDFView::didAddVerticalScrollbar): Added forgotten override for vertical case.
        (WebKit::BuiltInPDFView::willRemoveVerticalScrollbar): Ditto.
        (WebKit::BuiltInPDFView::createScrollbar): Notify self, do not make a shortcut to ScrollAnimator.
        (WebKit::BuiltInPDFView::destroyScrollbar): Ditto.
        (WebKit::BuiltInPDFView::destroy): Actually destroy the scrollbars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix performance of ValueToInt32 node when predicting double
oliver@apple.com [Thu, 13 Oct 2011 22:23:47 +0000 (22:23 +0000)]
Fix performance of ValueToInt32 node when predicting double
https://bugs.webkit.org/show_bug.cgi?id=70063

Reviewed by Filip Pizlo.

Currently we fail to inline double to int conversion when
performing a ValueToInt32 operation on a value we predict
to be a double.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
   Apply correct filter for the double prediction path
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
   Support double parameters even when value has been spilled.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
   Moved old valueToInt32 code to this function, and added
   path for double prediction
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
   Made the two implementations of ValueToInt32 call a single
   shared compileValueToInt32 function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] GeolocationClient cleanups
commit-queue@webkit.org [Thu, 13 Oct 2011 22:11:36 +0000 (22:11 +0000)]
[Qt] GeolocationClient cleanups
https://bugs.webkit.org/show_bug.cgi?id=69737

Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-10-13
Reviewed by Kenneth Rohde Christiansen.

Qt5 has a location module, so no need to use an external
library like Qt Mobility. This patch will allow the GeolocationClientQt
to compile with both Qt5 and Qt4.

* QtWebKit.pro:
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::positionUpdated):
* WebCoreSupport/GeolocationClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSync requestAnimationFrame callback to CVDisplayLink on Mac
barraclough@apple.com [Thu, 13 Oct 2011 22:11:13 +0000 (22:11 +0000)]
Sync requestAnimationFrame callback to CVDisplayLink on Mac
https://bugs.webkit.org/show_bug.cgi?id=68911

Patch by Chris Marrin <cmarrin@apple.com> on 2011-10-13
Reviewed by Simon Fraser.

Add REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for implementations
that use the DisplayRefreshMonitor logic.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=70050
bdakin@apple.com [Thu, 13 Oct 2011 22:09:33 +0000 (22:09 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70050
DRT and WRT should have HiDPI testing capabilities

Reviewed by Darin Adler.

Source/WebKit/mac:

New method _backingScaleFactor matches SPI of a similar name that I added
recently to WKPage in WebKit2. Equivalent functionality is needed for
DumpRenderTree's HiDPI support.
* WebView/WebView.mm:
(-[WebView _backingScaleFactor]):
* WebView/WebViewPrivate.h:

Tools:

New layoutTestController function setBackingScaleFactor takes a double for a scale
factor and a callback function to call once the backing scale factor has
successfully been set for the view.
* DumpRenderTree/LayoutTestController.cpp:
(setBackingScaleFactorCallback):
(LayoutTestController::staticFunctions):

On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other
platforms do nothing.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setBackingScaleFactor):

Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a
value of 0, which resets to the system default.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):

When generating the pixel dump, create a Bitmap of the appropriate size based on
the backing scale factor. If it is a HiDPI view, paint into the context using
displayRectIgnoringOpacity.
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):

And now the same stuff for WK2. Again, new layoutTestController function
setBackingScaleFactor takes a double for a scale factor and a callback function.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setBackingScaleFactor):
(WTR::LayoutTestController::callSetBackingScaleFactorCallback):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

The InjectedBundle sends a message to the UI process to set the backing scale
factor. It also processes a message the UI process will send back once it
completes this task, and at that time, the InjectedBundle calls the callback.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postSetBackingScaleFactor):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:

Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor
with a value of 0, which resets to the system default.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

Upon receiving the SetBackingScaleFactor message, call
WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message
back to InjectedBundle to say it has been done.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a
window's scale factor so we have to avoid that.
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

LayoutTests:

New HiDPI tests and results. These should be skipped on all non-Lion platforms.
* fast/hidpi: Added.
* fast/hidpi/broken-image-icon-hidpi.html: Added.
* fast/hidpi/broken-image-with-size-hidpi.html: Added.
* fast/hidpi/clip-text-in-hidpi.html: Added.
* fast/hidpi/resize-corner-hidpi.html: Added.
* fast/hidpi/video-controls-in-hidpi.html: Added.
* platform/gtk-wk2/Skipped:
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac/fast/hidpi: Added.
* platform/mac/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/resize-corner-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate expectations after gdi->skia switch.
dglazkov@chromium.org [Thu, 13 Oct 2011 22:01:15 +0000 (22:01 +0000)]
Update expectations after gdi->skia switch.

* platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png.
* platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/css/text-shadow-multiple-expected.png.
* platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Removed.
* platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSync requestAnimationFrame callback to CVDisplayLink on Mac
cmarrin@apple.com [Thu, 13 Oct 2011 21:59:25 +0000 (21:59 +0000)]
Sync requestAnimationFrame callback to CVDisplayLink on Mac
https://bugs.webkit.org/show_bug.cgi?id=68911

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Add REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for implementations
that use the DisplayRefreshMonitor logic.

* wtf/Platform.h:

Source/WebCore:

Test: fast/animation/request-animation-frame-iframe.html

Implement CVDisplayLink which checks to see if any scheduleAnimation requests
have come in. If so, remember the timestamp and do a callOnMainThread to fire
the callbacks. A DisplayRefreshMonitorManager is a singleton which has a list
of DisplayRefreshMonitors, one for each display. Each monitor has one or more
DisplayRefreshMonitorClients, which is a abstract virtual class implemented
by ScriptAnimationController. When an animation is scheduled, the
displayRefreshFired method is called on the client, which in turn calls the
requestAnimationFrame callbacks.

DisplayRefreshMonitor and therefore the CVDisplayLink it owns is discarded
when it no longer has any clients. This minimizes the number of concurrent
CVDisplayLink threads.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::windowScreenDidChange):
(WebCore::Document::webkitRequestAnimationFrame):
* dom/Document.h:
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
* dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::displayRefreshFired):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::windowScreenDidChange):
* page/Page.h:
(WebCore::Page::displayID):
* platform/PlatformScreen.h:
* platform/graphics/DisplayRefreshMonitor.cpp: Added.
(WebCore::DisplayRefreshMonitorClient::DisplayRefreshMonitorClient):
(WebCore::DisplayRefreshMonitorClient::~DisplayRefreshMonitorClient):
(WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded):
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::refreshDisplayOnMainThread):
(WebCore::DisplayRefreshMonitorManager::sharedManager):
(WebCore::DisplayRefreshMonitorManager::findMonitor):
(WebCore::DisplayRefreshMonitorManager::registerClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation):
(WebCore::DisplayRefreshMonitorManager::windowScreenDidChange):
* platform/graphics/DisplayRefreshMonitor.h: Added.
(WebCore::DisplayRefreshMonitorClient::scheduleAnimation):
(WebCore::DisplayRefreshMonitor::hasClients):
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitor::removeClient):
(WebCore::DisplayRefreshMonitor::displayID):
(WebCore::DisplayRefreshMonitorManager::DisplayRefreshMonitorManager):
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp: Added.
(WebCore::DisplayRefreshMonitor::displayLinkCallback):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::scheduleAnimation):

Source/WebKit/mac:

Add windowDidChangeScreen function which listens for the window changing
screens and passes the new displayID along to WebCore::Page. It also sends
one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's
created.

* WebView/WebView.mm:
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _windowDidChangeScreen:]):
(-[WebView _windowWillOrderOnScreen:]):

Source/WebKit2:

Add windowDidChangeScreen function which listens for the window changing
screens and passes the new displayID along to WebCore::Page. It also sends
one on windowDidBecomeKey, so the Page has a fresh displayID after it's
created. Event is generated in the UIProcess and then sent over to the
WebProcess, which actually sends it to WebCore::Page.

* UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView _windowDidChangeScreen:]):
(-[WKView _windowDidBecomeKey:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowScreenDidChange):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowScreenDidChange):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

Test to make sure requestAnimationFrame events fire inside iframe

* fast/animation/request-animation-frame-iframe-expected.txt: Added.
* fast/animation/request-animation-frame-iframe.html: Added.
* fast/animation/script-tests/request-animation-frame-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Qt compile fix.
inferno@chromium.org [Thu, 13 Oct 2011 21:52:12 +0000 (21:52 +0000)]
Unreviewed. Qt compile fix.

* css/CSSFontFaceSource.cpp: include Document.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Register custom fonts at their creation time,
inferno@chromium.org [Thu, 13 Oct 2011 21:37:04 +0000 (21:37 +0000)]
Source/WebCore: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929

Reviewed by Dan Bernstein.

Test: fast/text/custom-font-data-crash2.html

* css/CSSFontFace.cpp:
* css/CSSFontFace.h: remove function added in r94508,
which is no longer needed. We now register custom fonts
at creation time.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSFontFaceSource::getFontData): register custom
font to document's m_customFonts.
* css/CSSFontSelector.cpp:
* css/CSSFontSelector.h: remove function added in r94508,
which is no longer needed. We now register custom fonts
at creation time.
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSSegmentedFontFace::getFontData): register custom
font to document's m_customFonts.
* dom/Document.cpp: Change function names to registerCustomFont
, deleteCustomFonts and local to m_customFont.
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle): yanking out the comment. We
no longer keep retired custom fonts. We clear all custom fonts
on Document destruction.
(WebCore::Document::registerCustomFont):
(WebCore::Document::deleteCustomFonts):
* dom/Document.h:

LayoutTests: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929

Reviewed by Dan Bernstein.

* fast/text/custom-font-data-crash2-expected.txt: Added.
* fast/text/custom-font-data-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd results to keep the bots quiet.
simon.fraser@apple.com [Thu, 13 Oct 2011 21:28:13 +0000 (21:28 +0000)]
Add results to keep the bots quiet.

* fast/images/color-jpeg-with-color-profile-expected.png: Added.
* fast/images/color-jpeg-with-color-profile-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTweak flakiness expectation.
dglazkov@chromium.org [Thu, 13 Oct 2011 21:25:29 +0000 (21:25 +0000)]
Tweak flakiness expectation.

* platform/chromium/test_expectations.txt: Tweaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
jesus@webkit.org [Thu, 13 Oct 2011 21:20:59 +0000 (21:20 +0000)]
[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
https://bugs.webkit.org/show_bug.cgi?id=70053

Reviewed by Kenneth Rohde Christiansen.

Now we will be aligned with WKError.h and WebError.h by using the shared
and pre-defined enum for error codes and WebError::webkitErrorDomain().

* WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] WebViews are emitting loadFailed for "private" error codes
jesus@webkit.org [Thu, 13 Oct 2011 21:16:27 +0000 (21:16 +0000)]
[Qt][WK2] WebViews are emitting loadFailed for "private" error codes
https://bugs.webkit.org/show_bug.cgi?id=70047

Reviewed by Kenneth Rohde Christiansen.

Both QDesktopWebView and QTouchWebView are emitting loadFailed for private errors
like the ones defined in Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp.

We now filter these by not emitting this signal for FrameLoadInterruptedByPolicyChange,
PlugInWillHandleLoad and Cancellation, following previous decisions from WebKit 1.

* UIProcess/qt/ClientImpl.cpp:
(dispatchLoadFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd GPU crashes that cropped up.
dglazkov@chromium.org [Thu, 13 Oct 2011 21:11:17 +0000 (21:11 +0000)]
Add GPU crashes that cropped up.

* platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove expectations of failure after r97149.
dglazkov@chromium.org [Thu, 13 Oct 2011 21:05:33 +0000 (21:05 +0000)]
Remove expectations of failure after r97149.

* platform/chromium/test_expectations.txt: Yipee.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in DeleteSelectionCommand::handleGeneralDelete
rniwa@webkit.org [Thu, 13 Oct 2011 20:58:42 +0000 (20:58 +0000)]
Crash in DeleteSelectionCommand::handleGeneralDelete
https://bugs.webkit.org/show_bug.cgi?id=70045

Reviewed by Darin Adler.

Exit early when m_upstreamStart is null.

No new tests because we don't have a reduction.

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update expectations after r97378.
dglazkov@chromium.org [Thu, 13 Oct 2011 20:54:53 +0000 (20:54 +0000)]
[Chromium] Update expectations after r97378.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoterminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell
barraclough@apple.com [Thu, 13 Oct 2011 20:51:20 +0000 (20:51 +0000)]
terminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell

Rubber stamped by Filip Pizlo

This is breaking fast/canvas/canvas-composite-alpha.html on 32_64 DFG JIT.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update expectations after r97369.
dglazkov@chromium.org [Thu, 13 Oct 2011 20:48:00 +0000 (20:48 +0000)]
[Chromium] Update expectations after r97369.

* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-win/fast/repaint/region-painting-via-layout-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* platform/chromium/fast/repaint/region-painting-via-layout-expected.png: Added.
* platform/chromium/test_expectations.txt: Removed failure expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=70049
hyatt@apple.com [Thu, 13 Oct 2011 20:37:28 +0000 (20:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70049

[CSS Regions] Add a test of a float being pushed down because it can't fit
next to another float and make sure it re-evaluates its position when it changes
regions as a result of the push.

Reviewed by Sam Weinig.

Source/WebCore:

Added new test in fast/regions.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):

LayoutTests:

* fast/regions/float-pushed-width-change.html: Added.
* platform/mac/fast/regions/float-pushed-width-change-expected.png: Added.
* platform/mac/fast/regions/float-pushed-width-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlatform-specific results for r97378
robert@webkit.org [Thu, 13 Oct 2011 20:22:35 +0000 (20:22 +0000)]
Platform-specific results for r97378

Unreviewed, new platform-specific results.

* platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline for webkit bug 69503
commit-queue@webkit.org [Thu, 13 Oct 2011 20:18:19 +0000 (20:18 +0000)]
Rebaseline for webkit bug 69503
https://bugs.webkit.org/show_bug.cgi?id=69818

Patch by Ben Wells <benwells@chromium.org> on 2011-10-13
Reviewed by Tony Chang.

* platform/chromium-cg-mac-leopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-linux/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium-mac-leopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-win/fast/css/text-transform-select-expected.png: Added.
* platform/chromium-win/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium/fast/css/text-transform-select-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove XSTL to script-src in Content-Security-Policy
abarth@webkit.org [Thu, 13 Oct 2011 20:03:36 +0000 (20:03 +0000)]
Move XSTL to script-src in Content-Security-Policy
https://bugs.webkit.org/show_bug.cgi?id=63637

Reviewed by Eric Seidel.

Source/WebCore:

The spec was unclear about how to treat XSLT.  My reading was that they
should fall under style-src, but further discussion on the mailing list
settled on using script-src because an XSLT can inject arbitrary DOM
and script into a page, which is more risky than including style.

Tests: http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php
       http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

* http/tests/security/contentSecurityPolicy/xsl-allowed.php:
* http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-blocked.php:
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QtWebKit build error for Mac 32bit
commit-queue@webkit.org [Thu, 13 Oct 2011 19:47:27 +0000 (19:47 +0000)]
[Qt] QtWebKit build error for Mac 32bit
https://bugs.webkit.org/show_bug.cgi?id=69914

In WebCore.pro and QtWebKit.pro we define NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
when compiling with ENABLE_VIDEO and with WTF_USE_QTKIT.
But this is meant to be defined in NSGeometry.h under certain preconditions.
Without setting NS_BUILD_32_LIKE_64 none of these preconditions is
met and therefore NSGeometry.h will create several conflicting type definitions.

With this patch we create consistent definitions again.
Due to the order of include files we cannot remove
NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES from WebCore.pro.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-13
Reviewed by Andreas Kling.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert border radius clips (r95239) for Chromium due to performance issues. Update...
commit-queue@webkit.org [Thu, 13 Oct 2011 19:37:57 +0000 (19:37 +0000)]
Revert border radius clips (r95239) for Chromium due to performance issues. Update test expectations to skip border radius clip layout tests.
https://bugs.webkit.org/show_bug.cgi?id=69844

Patch by Tom Hudson <tomhudson@google.com> on 2011-10-13
Reviewed by Simon Fraser.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect): Only process border radius clips #if !PLATFORM(CHROMIUM)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement TextChecker for WebKit2 GTK+
commit-queue@webkit.org [Thu, 13 Oct 2011 19:36:34 +0000 (19:36 +0000)]
Implement TextChecker for WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=68548

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-10-13
Reviewed by Anders Carlsson.

Added implementation for all functions in TextCheckerGtk.cpp removing earlier stubbed implementations.
Moved couple of API earlier specific to win port to common section and added stubbed implementation
of the same for remaining ports of Qt, Efl and Mac.

* GNUmakefile.am: Added TextChecker implementation files.
* UIProcess/TextChecker.h: Moved spellCheckingEnabled and grammarCheckingEnabled API outside of win port.
* UIProcess/efl/TextCheckerEfl.cpp: Stubbed implementation of API which was moved outside win port.
* UIProcess/gtk/TextCheckerGtk.cpp: Implementation of all TextChecker API.
(WebKit::TextChecker::state):
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
* UIProcess/mac/TextCheckerMac.mm: Implementation of API which was moved outside win port.
* UIProcess/qt/TextCheckerQt.cpp: Stubbed implementation of API which was moved outside win port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebase some editing/spelling results for Lion.
simon.fraser@apple.com [Thu, 13 Oct 2011 19:30:41 +0000 (19:30 +0000)]
Rebase some editing/spelling results for Lion.

* platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
* platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix layout test result on Lion to account for content-order removal patch.
hyatt@apple.com [Thu, 13 Oct 2011 19:29:28 +0000 (19:29 +0000)]
Fix layout test result on Lion to account for content-order removal patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd regression test: canvas.toDataURL("image/jpeg") should not crash
noel.gordon@gmail.com [Thu, 13 Oct 2011 19:24:53 +0000 (19:24 +0000)]
Add regression test: canvas.toDataURL("image/jpeg") should not crash
https://bugs.webkit.org/show_bug.cgi?id=69991

Reviewed by Kenneth Russell.

* fast/canvas/canvas-toDataURL-jpeg-crash-expected.txt: Added.
* fast/canvas/canvas-toDataURL-jpeg-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDe-virtualized JSCell::toNumber
mhahnenberg@apple.com [Thu, 13 Oct 2011 19:24:53 +0000 (19:24 +0000)]
De-virtualized JSCell::toNumber
https://bugs.webkit.org/show_bug.cgi?id=69858

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Removed JSCallbackObject::toNumber because its no longer necessary since
JSObject::toNumber now suffices since we implicitly add valueOf to an object's
prototype whenever a convertToType callback is provided.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

De-virtualized JSCell::toNumber, JSObject::toNumber, and JSString::toNumber.
* runtime/JSCell.cpp:
(JSC::JSCell::toNumber):
* runtime/JSCell.h:
* runtime/JSObject.h:
* runtime/JSString.h:

Removed JSNotAnObject::toNumber because its result doesn't matter and it implements
defaultValue, therefore JSObject::toNumber can cover its case.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:

Source/JavaScriptGlue:

Removed UserObjectImp::toNumber because it's no longer necessary since
JSObject::toNumber can cover this case.
* UserObjectImp.cpp:
* UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDeprecate event.layerX and event.layerY in WebKit
jchaffraix@webkit.org [Thu, 13 Oct 2011 19:07:00 +0000 (19:07 +0000)]
Deprecate event.layerX and event.layerY in WebKit
https://bugs.webkit.org/show_bug.cgi?id=69951

Reviewed by Darin Adler.

Source/WebCore:

layerX and layerY were concepts of the old Netscape code that stayed
in WebKit for a long time without changes. Now the code is completely
wrong and Mozilla has expressed some interest in removing it from their
API too.

This is a first step in the removal as layerX and layerY are exposed
in some APIs. Chromium and Win are fine with removing the property
directly, but ObjC needs to deprecate them first.

* bindings/objc/PublicDOMInterfaces.h: Mark the API as deprecated.

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):
* dom/UIEvent.cpp:
(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
Added a call to warnDeprecatedLayerXYUsage in the previous functions.

(WebCore::UIEvent::warnDeprecatedLayerXYUsage): Print a warning in the
console about the removal of event.layerX and event.layerY in the near future.

* dom/UIEvent.h: Added warnDeprecatedLayerXYUsage.

LayoutTests:

* fast/dom/Window/window-xy-properties-expected.txt:
* fast/events/init-events-expected.txt:
* fast/events/mouse-relative-position-expected.txt:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/events/simulated-click-coords-expected.txt:
* jquery/events-expected.txt:
Updated those tests with the console messages to keep our existing
coverage until we remove the 2 properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Allow building without speech input enabled.
jknotten@chromium.org [Thu, 13 Oct 2011 19:06:43 +0000 (19:06 +0000)]
[Chromium] Allow building without speech input enabled.
https://bugs.webkit.org/show_bug.cgi?id=69867

Reviewed by Darin Fisher.

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:
* src/WebSpeechInputControllerMockImpl.cpp:
(WebKit::WebSpeechInputControllerMock::create):
* src/WebSpeechInputControllerMockImpl.h:
* src/WebSpeechInputResult.cpp:

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::addMockSpeechInputResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: inline-replaced-height-008.htm
robert@webkit.org [Thu, 13 Oct 2011 19:04:43 +0000 (19:04 +0000)]
CSS 2.1 failure: inline-replaced-height-008.htm
https://bugs.webkit.org/show_bug.cgi?id=69273

Reviewed by Simon Fraser.

Source/WebCore:

Test: css2.1/20110323/inline-block-replaced-height-008.html

Per http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height,  if 'height' has computed value of
'auto', the replaced element has an intrinsic ratio and its used width is known or resolved, then
the used value of 'height' is determined by the equation (used width) / (intrinsic ratio).

* rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalHeight):
* rendering/RenderReplaced.h:

LayoutTests:

* css2.1/20110323/floating-replaced-height-008.htm: Added.
* css2.1/20110323/inline-block-replaced-height-008.htm: Added.
* css2.1/20110323/inline-replaced-height-008.htm: Added.
* css2.1/20110323/support/60x60-green.png: Added
* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip MutationObserver tests on wincairo.
adamk@chromium.org [Thu, 13 Oct 2011 19:02:03 +0000 (19:02 +0000)]
Unreviewed, skip MutationObserver tests on wincairo.
These tests are not yet enabled on any platform.

* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd stallFor URL parameter for http/tests/media/video-play-stall.html test.
scherkus@chromium.org [Thu, 13 Oct 2011 18:51:16 +0000 (18:51 +0000)]
Add stallFor URL parameter for http/tests/media/video-play-stall.html test.
https://bugs.webkit.org/show_bug.cgi?id=69974

Without the call to sleep(), the test server will issue a TCP
connection close earlier than the 3 second wait time required to issue
a stalled event.

Reviewed by Eric Carlson.

* http/tests/media/video-play-stall.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
commit-queue@webkit.org [Thu, 13 Oct 2011 18:44:02 +0000 (18:44 +0000)]
[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
https://bugs.webkit.org/show_bug.cgi?id=69832

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-10-13
Reviewed by Kenneth Rohde Christiansen.

We implement decidePolicyForResponse in our PolicyClient in order to
decide whether a given ResourceResponse should be downloaded or loaded.

* UIProcess/qt/ClientImpl.cpp:
(qt_wk_decidePolicyForResponse):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac test expectation update for the bug 69999.
rniwa@webkit.org [Thu, 13 Oct 2011 18:31:26 +0000 (18:31 +0000)]
Mac test expectation update for the bug 69999.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update expectations while waiting on results from bots.
dglazkov@chromium.org [Thu, 13 Oct 2011 18:28:32 +0000 (18:28 +0000)]
[Chromium] Update expectations while waiting on results from bots.

* platform/chromium/test_expectations.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r97362.
commit-queue@webkit.org [Thu, 13 Oct 2011 18:02:10 +0000 (18:02 +0000)]
Unreviewed, rolling out r97362.
http://trac.webkit.org/changeset/97362
https://bugs.webkit.org/show_bug.cgi?id=70039

Relies on V8 APIs that have been reverted upstream. (Requested
by dglazkov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-13

Source/WebCore:

* English.lproj/localizedStrings.js:
* bindings/js/ScriptProfiler.cpp:
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptProfiler.cpp:
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
* inspector/front-end/HeapSnapshotProxy.js:
* inspector/front-end/RemoteObject.js:
* inspector/front-end/heapProfiler.css:

LayoutTests:

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse realloc() to expand/shrink StringBuilder buffer
commit-queue@webkit.org [Thu, 13 Oct 2011 17:00:59 +0000 (17:00 +0000)]
Use realloc() to expand/shrink StringBuilder buffer
https://bugs.webkit.org/show_bug.cgi?id=69913

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-10-13
Reviewed by Darin Adler.

* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::reallocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate): Added to allow StringBuilder to reallocate the buffer.
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69932
hyatt@apple.com [Thu, 13 Oct 2011 16:55:13 +0000 (16:55 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69932

Layout repainting messed up for objects in regions. There were two bugs here.
The first is that the regionOverflowRect needs to at least be the size of the
region's rect. When you're in the middle of layout, you haven't computed the
overflow rect for the flow thread yet (the flow thread's height could even be 0),
and so you just need to enforce a minimum size. Also removed the region-overflow:break
clipping behavior, since it was established that was wrong.

The second bug is that when you tell a region to repaint, you need to disable layout state,
since applying layout deltas from the flow thread makes no sense. The region is in a totally
different place in the render tree, so the current flow thread layout state can't be used
to determine your coordinate offset.

Reviewed by Dan Bernstein.

Added fast/repaint test.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=69932

Layout repainting messed up for objects in regions. Add a repaint test to
illustrate the issue.

Reviewed by Dan Bernstein.

* fast/repaint/region-painting-via-layout.html: Added.
* platform/mac/fast/regions/region-overflow-break-expected.png:
* platform/mac/fast/repaint/region-painting-via-layout-expected.png: Added.
* platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFEComponentTransfer element doesn't support dynamic invalidation
reni@webkit.org [Thu, 13 Oct 2011 16:33:19 +0000 (16:33 +0000)]
FEComponentTransfer element doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=69747

Source/WebCore:

The dynamic changes are captured by the svgAttributeChange() function, and
invalidate the filter primitive if necessary.
invalidateFilterPrimitiveParent() is a new free function in
SVGFilterPrimitiveStanardAttributes what makes the invalidation possible
by objects not inherited from SVGFilterPrimitiveStanardAttributes too.
This solution was used in SVGFEMergeNodeElement::svgAttributeChanged()
previously and now it can use this new function too.

Reviewed by Nikolas Zimmermann.

Tests: svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop.html
       svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop.html

* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged):
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::invalidateFilterPrimitiveParent):
* svg/SVGFilterPrimitiveStandardAttributes.h:

LayoutTests:

Adding new tests for feComponentTransfer dynamic changes.

Reviewed by Nikolas Zimmermann.

* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop.html: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-amplitude-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-exponent-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-intercept-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-offset-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-slope-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-tableValues-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-type-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-amplitude-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-exponent-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-intercept-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-offset-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-slope-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-tableValues-prop.js: Added.
(SVGNumberListToString):
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-type-prop.js: Added.
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a selectionBounds() method to WebWidget.
commit-queue@webkit.org [Thu, 13 Oct 2011 16:12:48 +0000 (16:12 +0000)]
[chromium] Add a selectionBounds() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69028

Patch by Peng Huang <shawn.p.huang@gmail.com> on 2011-10-13
Reviewed by Darin Fisher.

* public/WebWidget.h:
(WebKit::WebWidget::selectionBounds):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionRange):
(WebKit::WebViewImpl::selectionBounds):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r95381): Standalone video can be focused and draws a focus ring.
commit-queue@webkit.org [Thu, 13 Oct 2011 15:57:09 +0000 (15:57 +0000)]
REGRESSION (r95381): Standalone video can be focused and draws a focus ring.
https://bugs.webkit.org/show_bug.cgi?id=69097

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-10-13
Reviewed by Eric Carlson.

Source/WebCore:

We don't want to focus a media element in a standalone document.

Test: fast/events/media-focus-in-standalone-media-document.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFocus): return false if media element is in a standalone media document.

LayoutTests:

New test to check that media element in a standalone document are not focussed.

* fast/events/media-focus-in-standalone-media-document-expected.txt: Added.
* fast/events/media-focus-in-standalone-media-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
carlosgc@webkit.org [Thu, 13 Oct 2011 15:28:38 +0000 (15:28 +0000)]
[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
https://bugs.webkit.org/show_bug.cgi?id=70010

Reviewed by Martin Robinson.

With this class tests using a soup server only need to implement
the soup server callback.

* UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp: Use WebKitTestServer.
(testLoadingStatus):
(testLoadingError):
(testLoadAlternateContent):
(testWebViewReload):
(testLoadProgress):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/WebKitTestServer.cpp: Added.
(WebKitTestServer::WebKitTestServer):
(WebKitTestServer::~WebKitTestServer):
(WebKitTestServer::run): Run the soup server and adds the given
soup server callback to handle requests.
(WebKitTestServer::getURIForPath): Returns the server absolute URI
for the given relative path.
* UIProcess/API/gtk/tests/WebKitTestServer.h: Added.
(WebKitTestServer::baseURI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed; revert some changes introduced in r97329 which are
leandro@webkit.org [Thu, 13 Oct 2011 14:31:38 +0000 (14:31 +0000)]
Unreviewed; revert some changes introduced in r97329 which are
unrelated to the patch and reverted other patches themselves.

* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del): Remove warning again.
(ewk_frame_contents_size_get): Check for Frame and FrameView again.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Revert back default font size change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation.
commit-queue@webkit.org [Thu, 13 Oct 2011 13:58:48 +0000 (13:58 +0000)]
[WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation.
https://bugs.webkit.org/show_bug.cgi?id=69928

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-13
Reviewed by Philippe Normand.

Patch fixes the warnings reported by gtk-doc while generating
WebKit2-GTK+ documentation.

* UIProcess/API/gtk/WebKitWebContext.h: Correct the documentation comment.
* UIProcess/API/gtk/WebKitWebView.cpp: Parameter name correction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaselined GTK SVG test result.
sergio@webkit.org [Thu, 13 Oct 2011 11:13:32 +0000 (11:13 +0000)]
Unreviewed, rebaselined GTK SVG test result.

* platform/gtk/svg/hixie/cascade/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Chromium] Add an ability to look up and explore an object from a...
mnaganov@chromium.org [Thu, 13 Oct 2011 11:08:49 +0000 (11:08 +0000)]
Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
https://bugs.webkit.org/show_bug.cgi?id=61179

This is exteremely helpful when dealing with DOM wrappers, as
their properties are mostly implemented with getters and thus not
stored in heap snapshots.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._showObjectPopover):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.get flags):
(WebInspector.HeapSnapshotNode.prototype.get isDOMWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.get nodeFlags):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.fromError):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight):

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix test expectations.
tkent@chromium.org [Thu, 13 Oct 2011 10:59:31 +0000 (10:59 +0000)]
[Chromium] Fix test expectations.

* platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoscript-src * should allow all URLs
abarth@webkit.org [Thu, 13 Oct 2011 10:16:40 +0000 (10:16 +0000)]
script-src * should allow all URLs
https://bugs.webkit.org/show_bug.cgi?id=70011

Reviewed by Eric Seidel.

Source/WebCore:

This patch gets us slightly ahead of the spec.  Technically, script-src
means "any host" and inherits the current scheme.  However, that's not
what developers expect and it's even contradicted by examples in the
spec itself.  After this patch, * matches all URLs.

Test: http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::CSPSourceList):
(WebCore::CSPSourceList::matches):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::addSourceStar):

LayoutTests:

Test that using * in script-src matches URLs with other schemes.

* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update test expectation.
tkent@chromium.org [Thu, 13 Oct 2011 10:12:34 +0000 (10:12 +0000)]
[Chromium] Update test expectation.

* fast/borders/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-different-width-001-expected.txt.
* fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt.
* platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/border-radius-different-width-001-expected.png: Removed.
* platform/chromium-cg-mac/fast/borders/mixed-border-styles-radius-expected.png: Removed.
* platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png: Added.
* platform/chromium-mac/fast/borders/border-radius-different-width-001-expected.png: Removed.
* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: Removed.
* platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.txt.
* platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.txt.
* platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png: Added.
* platform/chromium-win/fast/borders/border-radius-different-width-001-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-win/fast/css/outline-narrowLine-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/css/outline-narrowLine-expected.png.
* platform/chromium-win/fast/css/outline-narrowLine-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/outline-narrowLine-expected.txt.
* platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
* platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt.
* platform/chromium/fast/css/outline-narrowLine-expected.png: Added.
* platform/chromium/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/borders/border-radius-different-width-001-expected.txt: Removed.
* platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.
* platform/qt/fast/borders/border-radius-different-width-001-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97359 268f45cc-cd09-0410-ab3c-d52691b4dbfc