WebKit-https.git
10 years ago2009-12-18 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 18 Dec 2009 17:47:21 +0000 (17:47 +0000)]
2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        Check one space before end of line comments.
        https://bugs.webkit.org/show_bug.cgi?id=32597

        Fix to check one space before end of line comments in whitespace and build/header_guard.
        Also fix build/header_guard to use WebKit header guard defines.

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoV8 build fix
aroben@apple.com [Fri, 18 Dec 2009 17:47:09 +0000 (17:47 +0000)]
V8 build fix

* bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK build fix
aroben@apple.com [Fri, 18 Dec 2009 17:45:38 +0000 (17:45 +0000)]
GTK build fix

* webkit/webkitprivate.cpp: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK (and others?) build fix
aroben@apple.com [Fri, 18 Dec 2009 17:42:33 +0000 (17:42 +0000)]
GTK (and others?) build fix

* platform/text/StringImpl.h: Added #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReduce #includes in a few high-use headers
aroben@apple.com [Fri, 18 Dec 2009 17:38:45 +0000 (17:38 +0000)]
Reduce #includes in a few high-use headers

Removed unnecessary #includes in these headers:
  - Frame.h
  - FrameWin.h
  - Node.h
  - Page.h
  - StringImpl.h

The rest of the patch is all adding #includes to source files that now
require them.

Fixes <http://webkit.org/b/32718>.

Rubber-stamped by Anders Carlsson.

WebCore:

* dom/Node.h:
* page/Frame.h:
* page/Page.h:
* page/win/FrameWin.h:
* platform/text/StringImpl.h:
Removed unnecessary #includes.

* accessibility/win/AXObjectCacheWin.cpp:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* dom/Document.cpp:
* dom/InputElement.cpp:
* dom/Node.cpp:
* dom/SelectElement.cpp:
* editing/EditorCommand.cpp:
* html/HTMLFormControlElement.cpp:
* html/HTMLFormElement.cpp:
* html/HTMLMediaElement.cpp:
* html/HTMLParser.cpp:
* html/HTMLTextAreaElement.cpp:
* html/HTMLVideoElement.cpp:
* inspector/InspectorController.cpp:
* loader/FrameLoader.cpp:
* loader/HistoryController.cpp:
* loader/appcache/ApplicationCacheGroup.cpp:
* page/Console.cpp:
* page/EventHandler.cpp:
* page/Frame.cpp:
* page/FrameView.cpp:
* page/Navigator.cpp:
* page/PageGroup.cpp:
* page/Settings.cpp:
* page/mac/EventHandlerMac.mm:
* platform/KURL.h:
* platform/ScrollbarThemeComposite.cpp:
* platform/cf/BinaryPropertyList.cpp:
* platform/graphics/mac/GraphicsLayerCA.h:
* platform/graphics/win/WKCACFLayerRenderer.cpp:
* platform/mac/PopupMenuMac.mm:
* platform/mac/WidgetMac.mm:
* platform/network/cf/DNSCFNet.cpp:
* platform/text/StringImpl.cpp:
* platform/win/FileSystemWin.cpp:
* platform/win/PlatformScreenWin.cpp:
* platform/win/PopupMenuWin.cpp:
* platform/win/WidgetWin.cpp:
* plugins/PluginView.cpp:
* plugins/win/PluginViewWin.cpp:
* rendering/InlineTextBox.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderInline.cpp:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderObject.cpp:
* rendering/RootInlineBox.cpp:
* storage/DatabaseTracker.cpp:
* storage/DatabaseTracker.h:
* storage/SQLTransactionClient.cpp:
* svg/graphics/SVGImage.cpp:
Added now-needed #includes.

WebKit/mac:

Add #includes needed after WebCore clean-up

* WebView/WebFrame.mm:
* WebView/WebFrameView.mm:
* WebView/WebView.mm:

WebKit/win:

Add #includes needed after WebCore clean-up

* WebCoreSupport/WebContextMenuClient.cpp:
* WebDataSource.cpp:
* WebHTMLRepresentation.cpp:
* WebView.cpp:
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Clean up the qmake build system to distinguish between trunk builds and package...
hausmann@webkit.org [Fri, 18 Dec 2009 17:06:24 +0000 (17:06 +0000)]
[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=32716

.:

* WebKit.pri: Use standalone_package instead of QTDIR_build

JavaScriptCore:

* pcre/pcre.pri: Use standalone_package instead of QTDIR_build

WebCore:

Introduce standalone_package as config that is set when QTDIR_build is set or when
the directory for the generated files is present.

Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
Others remain as they are specific to building inside Qt.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Fri, 18 Dec 2009 16:40:57 +0000 (16:40 +0000)]
2009-12-18  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Darin Adler.

        New test cases for isId support.
        https://bugs.webkit.org/show_bug.cgi?id=5578

        * dom/xhtml/level3/core/attrisid04-expected.txt:
        * dom/xhtml/level3/core/attrisid04.js:
        (setUpPage):
        * dom/xhtml/level3/core/attrisid05-expected.txt:
        * dom/xhtml/level3/core/attrisid05.js:
        (setUpPage):
        * fast/dom/Element/attrisid-extra01-expected.txt: Added.
        * fast/dom/Element/attrisid-extra01.html: Added.
        * fast/dom/Element/id-in-applet-expected.txt: Added.
        * fast/dom/Element/id-in-applet.html: Added.
        * fast/dom/Element/id-in-deletebutton-expected.txt: Added.
        * fast/dom/Element/id-in-deletebutton.html: Added.
        * fast/dom/Element/id-in-formcollection-expected.txt: Added.
        * fast/dom/Element/id-in-formcollection.html: Added.
        * fast/dom/Element/id-in-frame-expected.txt: Added.
        * fast/dom/Element/id-in-frame.html: Added.
        * fast/dom/Element/id-in-frameset-expected.txt: Added.
        * fast/dom/Element/id-in-frameset.html: Added.
        * fast/dom/Element/id-in-getelement01-expected.txt: Added.
        * fast/dom/Element/id-in-getelement01.html: Added.
        * fast/dom/Element/id-in-insert-hr-expected.txt: Added.
        * fast/dom/Element/id-in-insert-hr.html: Added.
        * fast/dom/Element/id-in-map-expected.txt: Added.
        * fast/dom/Element/id-in-map.html: Added.
        * fast/dom/Element/id-in-param-expected.txt: Added.
        * fast/dom/Element/id-in-param.html: Added.
2009-12-18  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Darin Adler.

        Implemented isId as specified by DOM Level 3. See detailed description below.
        https://bugs.webkit.org/show_bug.cgi?id=5578

        Added isId property and implementation:
        Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
               fast/dom/Element/attrisid-extra01.html
        * dom/Attr.cpp:
        (WebCore::Attr::isId):
        * dom/Attr.h:
        * dom/Attr.idl:

        Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
        for the reason that id attribute name could be customized to a different
        string other than "id". A test case is associated to each code change.
        * dom/Document.cpp:
        (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
        * dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
        (WebCore::Element::setAttribute):
        (WebCore::Element::setAttributeMap):
        (WebCore::Element::insertedIntoDocument):
        (WebCore::Element::removedFromDocument):
        (WebCore::Element::formatForDebugger):
        (WebCore::Element::rareIDAttributeName):
        * dom/Element.h: Added function idAttributeName().
        (WebCore::Element::idAttributeName):
        * dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData.
        (WebCore::ElementRareData::ElementRareData):
        * dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
        (WebCore::NamedNodeMap::setNamedItem):
        (WebCore::NamedNodeMap::removeNamedItem):
        (WebCore::NamedNodeMap::setAttributes):
        * dom/Node.cpp: Removed ASSERT as it may not hold any more.
        (WebCore::Node::querySelector):
        * dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more.
        (WebCore::createSelectorNodeList):
        * dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
        (WebCore::StyledElement::parseMappedAttribute):
        * editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html
        (WebCore::DeleteButtonController::createDeletionUI):
        * editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html
        (WebCore::executeInsertHorizontalRule):
        * html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html
        (WebCore::HTMLAppletElement::parseMappedAttribute):
        (WebCore::HTMLAppletElement::createRenderer):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html
        (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html
        (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute):
        * html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html
        (WebCore::HTMLFormCollection::getNamedFormItem):
        (WebCore::HTMLFormCollection::nextNamedItem):
        (WebCore::HTMLFormCollection::updateNameCache):
        * html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
        * html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html
        (WebCore::HTMLMapElement::parseMappedAttribute):
        * html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html
        (WebCore::HTMLNameCollection::itemAfter):
        * html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        * html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html
        (WebCore::HTMLParamElement::parseMappedAttribute):
        * loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html
        (WebCore::CachedFont::getSVGFontById):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
        * rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg
        (WebCore::writeRenderResources):
        * svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html
        (WebCore::SVGElement::insertedIntoDocument):
        * svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg
        (WebCore::SVGStyledElement::isKnownAttribute):
        * wml/WMLElement.cpp:
        (WebCore::WMLElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Joe Ligman <joseph.ligman@nokia.com>
eric@webkit.org [Fri, 18 Dec 2009 15:04:00 +0000 (15:04 +0000)]
2009-12-18  Joe Ligman  <joseph.ligman@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add new API to QWebFrame to scrollRecursively starting with any css overflow
        then checking current frame and then ancestors
        https://bugs.webkit.org/show_bug.cgi?id=32668

        * Api/qwebframe.cpp:
        (QWebFramePrivate::scrollOverflow):
        (QWebFrame::scrollRecursively):
        * Api/qwebframe.h:
        * Api/qwebframe_p.h:
        * tests/qwebframe/qwebframe.qrc:
        * tests/qwebframe/testiframe.html: Added.
        * tests/qwebframe/testiframe2.html: Added.
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix the build on Symbian.
hausmann@webkit.org [Fri, 18 Dec 2009 14:03:51 +0000 (14:03 +0000)]
[Qt] Fix the build on Symbian.

Reviewed by Tor Arne Vestbø.

Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
which is a missing symbol in Qt 4.6.0 on Symbian.

Functionally they should be equivalent, according to the source.

* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 18 Dec 2009 14:01:19 +0000 (14:01 +0000)]
2009-12-18  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] segfault during controls initialization if not GTK theme is present.
        https://bugs.webkit.org/show_bug.cgi?id=32705

        Create empty images for the controls if no GTK theme is set.

        * platform/graphics/gtk/ImageGtk.cpp:
        (WebCore::getThemeIconFileName):
        (WebCore::loadImageFromFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r52305, since it breaks many http tests. We will try a better
kov@webkit.org [Fri, 18 Dec 2009 13:38:22 +0000 (13:38 +0000)]
Revert r52305, since it breaks many http tests. We will try a better
solution for Soup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix infinite recursion in touch mocking.
hausmann@webkit.org [Fri, 18 Dec 2009 13:32:53 +0000 (13:32 +0000)]
[Qt] Fix infinite recursion in touch mocking.

Reviewed by Tor Arne Vestbø.

Don't send the fake touch events to the view, as that'll trigger the
event filter again.

* QtLauncher/main.cpp:
(MainWindow::sendTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex...
eric@webkit.org [Fri, 18 Dec 2009 12:00:29 +0000 (12:00 +0000)]
2009-12-18  Kalle Vahlman  <kalle.vahlman@movial.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the fragment identifier from url before passing it to libsoup.
otte@webkit.org [Fri, 18 Dec 2009 10:51:35 +0000 (10:51 +0000)]
Remove the fragment identifier from url before passing it to libsoup.

In newer releases libsoup emits a warning when it gets handed a
fragment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Fri, 18 Dec 2009 10:37:51 +0000 (10:37 +0000)]
2009-12-18  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Compile warning from line 29 of GRefPtr.cpp
        https://bugs.webkit.org/show_bug.cgi?id=32703

        Fix memory leak and compiler warning in GRefPtr GHashTable template
        specialization.

        * wtf/gtk/GRefPtr.cpp:
        (WTF::refGPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-18 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Fri, 18 Dec 2009 09:50:26 +0000 (09:50 +0000)]
2009-12-18  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Darin Adler.

        REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
        at the beginning.
        https://bugs.webkit.org/show_bug.cgi?id=31920

        Added test showing the problem described in the bug.

        * editing/selection/wrapped-line-caret-3.html:
        * editing/selection/wrapped-line-caret-3-expected.txt:
2009-12-18  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Darin Adler.

        REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
        at the beginning.
        https://bugs.webkit.org/show_bug.cgi?id=31920

        Moving up from a position after the end of the previous lines
        should use UPSTREAM affinity to render the caret in the previous
        line.

        Test: editing/selection/wrapped-line-caret-3.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 18 Dec 2009 07:17:12 +0000 (07:17 +0000)]
2009-12-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
        https://bugs.webkit.org/show_bug.cgi?id=32675

        Use the double constant 2.0 instead of static_cast<double>(2).

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepMismatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Dirk Pranke <dpranke@chromium.org>
eric@webkit.org [Fri, 18 Dec 2009 06:39:50 +0000 (06:39 +0000)]
2009-12-17  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Upstreaming an XSS test from chromium.org.
        https://bugs.webkit.org/show_bug.cgi?id=32685

        * http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
        * http/tests/security/xss-DENIED-assign-location-href-javascript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Justin Schuh <jschuh@chromium.org>
eric@webkit.org [Fri, 18 Dec 2009 06:12:35 +0000 (06:12 +0000)]
2009-12-17  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dan Bernstein.

        Bug 32357: SVG test case crashes WebKit (invalid font URL)
        https://bugs.webkit.org/show_bug.cgi?id=32357

        Added check for NULL return value from DocLoader::requestFont()

        * svg/text/text-font-uri-invalid-expected.txt: Added.
        * svg/text/text-font-uri-invalid.svg: Added.
2009-12-17  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dan Bernstein.

        Bug 32357: SVG test case crashes WebKit (invalid font URL)
        https://bugs.webkit.org/show_bug.cgi?id=32357

        Added check for NULL return value from DocLoader::requestFont()

        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::loadFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 18 Dec 2009 05:42:26 +0000 (05:42 +0000)]
2009-12-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        marquee with display:inline causes crash
        https://bugs.webkit.org/show_bug.cgi?id=32374

        * fast/inline/inline-marquee-crash-expected.txt: Added.
        * fast/inline/inline-marquee-crash.html: Added.
2009-12-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        marquee with display:inline causes crash
        https://bugs.webkit.org/show_bug.cgi?id=32374

        Test: fast/inline/inline-marquee-crash.html

        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::start):
        (WebCore::HTMLMarqueeElement::stop):
        (WebCore::HTMLMarqueeElement::suspend):
        (WebCore::HTMLMarqueeElement::resume):
        (WebCore::HTMLMarqueeElement::renderMarquee):
        * html/HTMLMarqueeElement.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::styleChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.
weinig@apple.com [Fri, 18 Dec 2009 04:14:02 +0000 (04:14 +0000)]
JavaScriptCore: Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.

Reviewed by Mark Rowe.

* wtf/Platform.h:

WebKitTools: Add BUILDING_ON_SNOW_LEOPARD #define.

Reviewed by Mark Rowe.

* DumpRenderTree/mac/DumpRenderTreeMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Unskip websocket tests
ukai@chromium.org [Fri, 18 Dec 2009 04:12:50 +0000 (04:12 +0000)]
Unreviewed. Unskip websocket tests

New pywebsocket (0.4.5) landed at WebKit r52296, so
sub-protocol-with-space.html should pass.

* platform/mac/Skipped: delete websocket/tests/sub-protocol-with-space.html
* platform/win/Skipped: delete websocket/tests/sub-protocol-with-space.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yuzo Fujishima <yuzo@google.com>
ukai@chromium.org [Fri, 18 Dec 2009 02:38:01 +0000 (02:38 +0000)]
2009-12-17  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Update pywebsocket to 0.4.5 and make handshake checking stricter
        https://bugs.webkit.org/show_bug.cgi?id=32249

        * Scripts/run-webkit-tests:
        * pywebsocket/mod_pywebsocket/handshake.py:
        * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:
        * pywebsocket/test/test_handshake.py:
        * pywebsocket/test/test_memorizingfile.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 18 Dec 2009 01:28:27 +0000 (01:28 +0000)]
2009-12-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Command.show_in_main_help should default to False
        https://bugs.webkit.org/show_bug.cgi?id=32686

        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/multicommandtool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Fri, 18 Dec 2009 00:51:13 +0000 (00:51 +0000)]
2009-12-17  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for inspector's classes
        https://bugs.webkit.org/show_bug.cgi?id=32660

        Inherits the following classes from Noncopyable because these are
        instantiated by 'new' and no need to be copyable:

        class name                  - instantiated at:  WebCore/'location'

        class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
        class ConsoleMessage        - inspector/InspectorController.cpp:329
        class InspectorController   - page/Page.cpp:119

        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.h:
        * inspector/JavaScriptDebugServer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 23:22:35 +0000 (23:22 +0000)]
2009-12-17  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52291.
        http://trac.webkit.org/changeset/52291
        https://bugs.webkit.org/show_bug.cgi?id=32618

        Darin Fisher points out that this will likely break
        the SSL security indicator in Chromium.  Rolling out for now.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 17 Dec 2009 22:37:17 +0000 (22:37 +0000)]
2009-12-17  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Fixes HTMLInputElement::stepMismatch() to avoid ambiguous overload of pow().
        https://bugs.webkit.org/show_bug.cgi?id=32675

        Build fix only, no new tests.

        * html/HTMLInputElement.cpp: Modified.
        (WebCore::HTMLInputElement::stepMismatch): Cast first argument of pow to double to force 'double pow(double, int)'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 22:14:38 +0000 (22:14 +0000)]
2009-12-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Eric Seidel.

        Disable memory cache client calls so that a new identifier isn't created
        for the same resource on reload.

        With the calls enabled, duplicate entries for cached resources are created
        in the Web Inspector. Safari for Windows disables the calls near the point of the
        Frame instance creation, and we just follow this for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=32618

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Thu, 17 Dec 2009 22:10:30 +0000 (22:10 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Marc-Antoine Ruel <maruel@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 21:52:14 +0000 (21:52 +0000)]
2009-12-17  Marc-Antoine Ruel  <maruel@chromium.org>

        Reviewed by Eric Seidel.

        Fix link failure on LTCG builds on Windows for chromium port.

        Reenable SVGAllInOne.cpp. This required some fixups.

        Namely, there was conflicts in constants between HTMLNames and
        SVGNames, and conflicts between static functions names.

        No new tests as functionality has not changed.

        * WebCore.gyp/WebCore.gyp:
        * svg/SVGAllInOne.cpp:
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::rebuildFontFace):
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::invalidateGlyphCache):
        (WebCore::SVGGlyphElement::buildGlyphIdentifier):
        * svg/SVGHKernElement.cpp:
        (WebCore::SVGHKernElement::insertedIntoDocument):
        (WebCore::SVGHKernElement::removedFromDocument):
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::type):
        (WebCore::SVGStyleElement::setType):
        (WebCore::SVGStyleElement::media):
        (WebCore::SVGStyleElement::setMedia):
        (WebCore::SVGStyleElement::title):
        (WebCore::SVGStyleElement::setTitle):
        (WebCore::SVGStyleElement::parseMappedAttribute):
        * svg/SVGStyledElement.cpp:
        (WebCore::mapAttributeToCSSProperty):
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
        * svg/SVGStyledElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix VI
aroben@apple.com [Thu, 17 Dec 2009 21:38:53 +0000 (21:38 +0000)]
Chromium build fix VI

* svg/animation/SMILTimeContainer.h: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix V
aroben@apple.com [Thu, 17 Dec 2009 21:37:32 +0000 (21:37 +0000)]
Chromium build fix V

* platform/KURLGoogle.cpp: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix IV
aroben@apple.com [Thu, 17 Dec 2009 21:29:36 +0000 (21:29 +0000)]
Chromium build fix IV

* loader/CrossOriginPreflightResultCache.h: Added now-needed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Thu, 17 Dec 2009 21:26:02 +0000 (21:26 +0000)]
2009-12-17  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Eric Seidel.

        Added the key WebKitEnableCaretBrowsing to the
        layoutTestController.overridePreference in order to activate caret
        browsing.
        https://bugs.webkit.org/show_bug.cgi?id=32612

        * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
        the setting.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
        key in the keytable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix III
aroben@apple.com [Thu, 17 Dec 2009 21:19:24 +0000 (21:19 +0000)]
Chromium build fix III

* platform/graphics/Font.h: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix II
aroben@apple.com [Thu, 17 Dec 2009 21:10:20 +0000 (21:10 +0000)]
Chromium build fix II

* dom/EventTarget.h: Added now-needed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 21:09:37 +0000 (21:09 +0000)]
2009-12-17  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Eric Seidel.

        Allow custom memory allocation control for js bindings
        https://bugs.webkit.org/show_bug.cgi?id=32655

        Inherits the following classes from Noncopyable because these are instantiated
        by 'new' and no need to be copyable:

        class name                  - instantiated at:  WebCore/'location'

        class ScriptCachedFrameData - history/CachedFrame.cpp:117
        class WebCoreJSClientData   - bindings/js/JSDOMWindowBase.cpp:162
        class ScheduledAction       - bindings/js/ScheduledAction.cpp:58

        * bindings/js/JSDOMBinding.h:
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptCachedFrameData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix
aroben@apple.com [Thu, 17 Dec 2009 20:56:58 +0000 (20:56 +0000)]
Chromium build fix

* dom/QualifiedName.h: Added now-needed #include of HashTraits.h
(which itself #includes HashFunctions.h).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
eric@webkit.org [Thu, 17 Dec 2009 20:53:12 +0000 (20:53 +0000)]
2009-12-17  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Incorrect Doctype.

        REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
        https://bugs.webkit.org/show_bug.cgi?id=32671

        * inspector/elements-panel-structure-expected.txt:
        * inspector/elements-panel-structure.html:
2009-12-17  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Incorrect Doctype.

        REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
        https://bugs.webkit.org/show_bug.cgi?id=32671

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't include all JSC headers everywhere
aroben@apple.com [Thu, 17 Dec 2009 20:38:57 +0000 (20:38 +0000)]
Don't include all JSC headers everywhere

https://bugs.webkit.org/show_bug.cgi?id=32663

Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.

Remove HashMap HashSet and OwnPtr includes from PlatformString.h.
Reduces code size of Gtk build by another 5%.

* platform/text/PlatformString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix
aroben@apple.com [Thu, 17 Dec 2009 20:32:45 +0000 (20:32 +0000)]
Mac build fix

* WebView/WebVideoFullscreenController.mm: Added now-needed #import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac/Qt build fixes
aroben@apple.com [Thu, 17 Dec 2009 20:22:52 +0000 (20:22 +0000)]
Mac/Qt build fixes

* platform/graphics/mac/Canvas3DLayer.mm:
* platform/graphics/mac/GraphicsContext3DMac.cpp:
* platform/qt/Localizations.cpp:
Added missing #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't include all JSC headers everywhere
aroben@apple.com [Thu, 17 Dec 2009 20:00:50 +0000 (20:00 +0000)]
Don't include all JSC headers everywhere

https://bugs.webkit.org/show_bug.cgi?id=32663

Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.

WebCore:

PlatformString.h included almost all of JSC via runtime/Identifier.h.
This patch gets rid of this include by forward-declaring the required
classes instead.
This reduces the build size of the object files on a Gtk debug build
by 10%. The resulting libwebkit.so gets 5% smaller.

No new tests as it's just a build improvement.

* platform/gtk/LocalizedStringsGtk.cpp:
include math.h here (it used to be pulled by JSC)
* platform/text/PlatformString.h:
* platform/text/String.cpp:

WebKit/win:

* WebCoreLocalizedStrings.cpp: Added now-needed #include of
MathExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 19:59:43 +0000 (19:59 +0000)]
2009-12-17  Evan Martin  <evan@chromium.org>

        Reviewed by Xan Lopez.

        Always use all WebCore include paths in GtkWebKit.

        With this patch, I can disable all optional features and still build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed layout test fix.
cfleizach@apple.com [Thu, 17 Dec 2009 19:58:13 +0000 (19:58 +0000)]
Unreviewed layout test fix.

WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299

The test for this patch shouldn't be run on Tiger.

* platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: DRT needs to support URL for accessibility
cfleizach@apple.com [Thu, 17 Dec 2009 19:48:00 +0000 (19:48 +0000)]
AX: DRT needs to support URL for accessibility
https://bugs.webkit.org/show_bug.cgi?id=32666

Reviewed by David Kilzer.

* DumpRenderTree/AccessibilityUIElement.cpp:
(getURLCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::url):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::url):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed; added myself to committers
philn@webkit.org [Thu, 17 Dec 2009 19:36:07 +0000 (19:36 +0000)]
    Unreviewed; added myself to committers

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 17 Dec 2009 19:23:19 +0000 (19:23 +0000)]
2009-12-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        More make distcheck fixes. Use a more robust solution to making
        sure we are in the correct directory for running these tests.

        * tests/testmimehandling.c:
        (main):
        * tests/testwebview.c:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; added myself to committers
otte@webkit.org [Thu, 17 Dec 2009 19:21:18 +0000 (19:21 +0000)]
Unreviewed; added myself to committers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yaar Schnitman <yaar@chromium.org>
yaar@google.com [Thu, 17 Dec 2009 19:18:40 +0000 (19:18 +0000)]
2009-12-17  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Added WebPageSerializer to WebKit API and enriched the WebNode hierarchy to support
        downstream unit-testing of serialization.

        WebPageSerializer was adapted from Chromium's dom_serializer, originally authored by Johnny Ding.

        https://bugs.webkit.org/show_bug.cgi?id=31737

        * WebKit.gyp:
        * public/WebDocument.h: Added.
        (WebKit::WebDocument::WebDocument):
        (WebKit::WebDocument::operator=):
        (WebKit::WebDocument::assign):
        * public/WebElement.h:
        * public/WebFormElement.h:
        (WebKit::WebFormElement::operator=):
        * public/WebFrame.h:
        * public/WebNode.h:
        (WebKit::WebNode::):
        (WebKit::WebNode::toConstElement):
        * public/WebNodeCollection.h: Added.
        (WebKit::WebNodeCollection::~WebNodeCollection):
        (WebKit::WebNodeCollection::WebNodeCollection):
        (WebKit::WebNodeCollection::operator=):
        * public/WebNodeList.h: Added.
        (WebKit::WebNodeList::~WebNodeList):
        (WebKit::WebNodeList::WebNodeList):
        (WebKit::WebNodeList::operator=):
        * public/WebPageSerializer.h: Added.
        * public/WebPageSerializerClient.h: Added.
        (WebKit::WebPageSerializerClient::):
        (WebKit::WebPageSerializerClient::WebPageSerializerClient):
        (WebKit::WebPageSerializerClient::~WebPageSerializerClient):
        * public/WebString.h:
        * public/WebView.h:
        * src/AssertMatchingEnums.cpp:
        * src/DOMUtilitiesPrivate.cpp:
        (WebKit::elementHasLegalLinkAttribute):
        * src/DOMUtilitiesPrivate.h:
        * src/WebDocument.cpp: Added.
        (WebKit::WebDocument::WebDocument):
        (WebKit::WebDocument::operator=):
        (WebKit::WebDocument::operator WTF::PassRefPtr<Document>):
        (WebKit::WebDocument::frame):
        (WebKit::WebDocument::isHTMLDocument):
        (WebKit::WebDocument::baseURL):
        (WebKit::WebDocument::body):
        (WebKit::WebDocument::head):
        (WebKit::WebDocument::all):
        (WebKit::WebDocument::completeURL):
        * src/WebElement.cpp:
        (WebKit::WebElement::hasTagName):
        (WebKit::WebElement::hasAttribute):
        (WebKit::WebElement::getAttribute):
        * src/WebEntities.cpp: Added.
        (WebKit::populateMap):
        (WebKit::):
        (WebKit::WebEntities::WebEntities):
        (WebKit::WebEntities::entityNameByCode):
        (WebKit::WebEntities::convertEntitiesInString):
        * src/WebEntities.h: Added.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrame::fromFrameOwnerElement):
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::document):
        (WebKit::WebFrameImpl::fromFrameOwnerElement):
        * src/WebFrameImpl.h:
        * src/WebNode.cpp:
        (WebKit::WebNode::nodeType):
        (WebKit::WebNode::nodeValue):
        (WebKit::WebNode::document):
        (WebKit::WebNode::firstChild):
        (WebKit::WebNode::lastChild):
        (WebKit::WebNode::previousSibling):
        (WebKit::WebNode::nextSibling):
        (WebKit::WebNode::hasChildNodes):
        (WebKit::WebNode::childNodes):
        (WebKit::WebNode::createMarkup):
        (WebKit::WebNode::isTextNode):
        (WebKit::WebNode::isElementNode):
        * src/WebNodeCollection.cpp: Added.
        (WebKit::WebNodeCollection::reset):
        (WebKit::WebNodeCollection::assign):
        (WebKit::WebNodeCollection::WebNodeCollection):
        (WebKit::WebNodeCollection::length):
        (WebKit::WebNodeCollection::nextItem):
        (WebKit::WebNodeCollection::firstItem):
        * src/WebNodeList.cpp: Added.
        (WebKit::WebNodeList::reset):
        (WebKit::WebNodeList::assign):
        (WebKit::WebNodeList::WebNodeList):
        (WebKit::WebNodeList::length):
        (WebKit::WebNodeList::item):
        * src/WebPageSerializer.cpp: Added.
        (WebKit::WebPageSerializer::serialize):
        (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
        (WebKit::WebPageSerializer::generateMarkOfTheWebDeclaration):
        (WebKit::WebPageSerializer::generateBaseTagDeclaration):
        * src/WebPageSerializerImpl.cpp: Added.
        (WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam):
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeEndTag):
        (WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag):
        (WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer):
        (WebKit::WebPageSerializerImpl::openTagToString):
        (WebKit::WebPageSerializerImpl::endTagToString):
        (WebKit::WebPageSerializerImpl::buildContentForNode):
        (WebKit::WebPageSerializerImpl::WebPageSerializerImpl):
        (WebKit::WebPageSerializerImpl::collectTargetFrames):
        (WebKit::WebPageSerializerImpl::serialize):
        * src/WebPageSerializerImpl.h: Added.
        * src/WebString.cpp:
        (WebKit::WebString::WebString):
        (WebKit::WebString::operator=):
        * src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 17 Dec 2009 19:14:33 +0000 (19:14 +0000)]
2009-12-17  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Don't assume downloads are always synchronous
        http://bugs.webkit.org/show_bug.cgi?id=32359

        * tests/testdownload.c:
        (download_requested_cb):
        (set_filename):
        (test_webkit_download_perform):
        (test_webkit_download_synch):
        (test_webkit_download_asynch):
        (main): Test downloads synchronously and asynchronously.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init):
        (webkit_web_view_request_download): Only try to start a requested
        download if the destination URI is set and clarify the documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge branch 'bug/26304' into staging
philn@webkit.org [Thu, 17 Dec 2009 19:13:42 +0000 (19:13 +0000)]
Merge branch 'bug/26304' into staging

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the source tree
aroben@apple.com [Thu, 17 Dec 2009 19:12:38 +0000 (19:12 +0000)]
Sync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the source tree

Fixes <http://webkit.org/b/32665>.

Reviewed by Ada Chan.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Moved
around files and filters so that the structure matches
JavaScriptCore.xcodeproj and the source tree. A few headers that were
previously omitted have been added, as well as JSZombie.{cpp,h}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove HeavyProfile and TreeProfile completely
aroben@apple.com [Thu, 17 Dec 2009 19:12:26 +0000 (19:12 +0000)]
Remove HeavyProfile and TreeProfile completely

These were mostly removed in r42808, but the empty files were left in
place.

Fixes <http://webkit.org/b/32664>.

Reviewed by John Sullivan.

* Android.mk:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCoreSources.bkl:
Removed HeavyProfile/TreeProfile source files.

* profiler/HeavyProfile.cpp: Removed.
* profiler/HeavyProfile.h: Removed.
* profiler/TreeProfile.cpp: Removed.
* profiler/TreeProfile.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove WebKit.sln's Debug_All and Debug_Internal configurations
aroben@apple.com [Thu, 17 Dec 2009 19:12:03 +0000 (19:12 +0000)]
Remove WebKit.sln's Debug_All and Debug_Internal configurations

These configurations aren't buildable by people outside of Apple, and
Apple doesn't use this solution file.

Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
should default to Debug instead of Debug_all.

Rubber-stamped by Dan Bernstein.

* WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 17 Dec 2009 19:09:33 +0000 (19:09 +0000)]
2009-12-17  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Xan Lopez.

        Deprecate the title-changed signal of WebKitWebFrame.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Thu, 17 Dec 2009 18:39:42 +0000 (18:39 +0000)]
2009-12-17  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] support navigator.onLine and ononline/onoffline events.
        https://bugs.webkit.org/show_bug.cgi?id=32555

        Hooked up Bearer Management to NetworkStateNotifier. This solution is available
        only if QtMobility's Bearer Management is installed.

        * WebCore.pro:
        * platform/network/NetworkStateNotifier.h:
        * platform/network/qt/NetworkStateNotifierPrivate.h: Added.
        * platform/network/qt/NetworkStateNotifierQt.cpp: Added.
        (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
        (WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
        (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate):
        (WebCore::NetworkStateNotifier::updateState):
        (WebCore::NetworkStateNotifier::NetworkStateNotifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Dec 2009 18:25:38 +0000 (18:25 +0000)]
2009-12-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Switch to 11px as default for source-code in WebKit.

        https://bugs.webkit.org/show_bug.cgi?id=32646

        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
hausmann@webkit.org [Thu, 17 Dec 2009 17:57:17 +0000 (17:57 +0000)]
[Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
make sure we pick up the header file from QtCore. That is where the implementation
is compiled.

Reviewed by Tor Arne Vestbø.

* dom/XMLTokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Thu, 17 Dec 2009 17:44:11 +0000 (17:44 +0000)]
2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Implement GRefPtr, a smart pointer for reference counted GObject types.

        * GNUmakefile.am:
        * wtf/gtk/GOwnPtr.cpp:
        (WTF::GDir):
        * wtf/gtk/GRefPtr.h: Added.
        (WTF::):
        (WTF::GRefPtr::GRefPtr):
        (WTF::GRefPtr::~GRefPtr):
        (WTF::GRefPtr::clear):
        (WTF::GRefPtr::get):
        (WTF::GRefPtr::operator*):
        (WTF::GRefPtr::operator->):
        (WTF::GRefPtr::operator!):
        (WTF::GRefPtr::operator UnspecifiedBoolType):
        (WTF::GRefPtr::hashTableDeletedValue):
        (WTF::::operator):
        (WTF::::swap):
        (WTF::swap):
        (WTF::operator==):
        (WTF::operator!=):
        (WTF::static_pointer_cast):
        (WTF::const_pointer_cast):
        (WTF::getPtr):
        (WTF::adoptGRef):
        (WTF::refGPtr):
        (WTF::derefGPtr):
2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Add GRefPtr support for GTK types to WebCore, as JSC does not link against
        GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.

        No new tests as functionality has not changed.

        * GNUmakefile.am:
        * platform/PopupMenu.h:
        * platform/gtk/GRefPtrGtk.cpp: Added.
        (WTF::refGPtr):
        (WTF::derefGPtr):
        * platform/gtk/GRefPtrGtk.h: Added.
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::menuRemoveItem):
2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Convert a use of GOwnPtr for a reference counted type to GRefPtr.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Thu, 17 Dec 2009 17:21:40 +0000 (17:21 +0000)]
2009-12-17  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add support for mocking touch events with Q(GV)Launcher
        https://bugs.webkit.org/show_bug.cgi?id=32434

        The event delivery should go through QCoreApplication::sendEvent()

        * QtLauncher/main.cpp:
        (MainWindow::sendTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Thu, 17 Dec 2009 17:09:23 +0000 (17:09 +0000)]
2009-12-17  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.

        [Qt] Add support for touch events in QWebView and QGraphicsWebView
        https://bugs.webkit.org/show_bug.cgi?id=32432

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::QGraphicsWebView):
        (QGraphicsWebView::sceneEvent):
        * Api/qwebview.cpp:
        (QWebView::QWebView):
        (QWebView::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 17 Dec 2009 17:06:01 +0000 (17:06 +0000)]
2009-12-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by David Levin.

        Provide explicit implementation of 'non-template' WebVector<T>::operator=

        https://bugs.webkit.org/show_bug.cgi?id=32363

        * public/WebVector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 15:56:47 +0000 (15:56 +0000)]
2009-12-17  Evan Martin  <evan@chromium.org>

        Reviewed by Xan Lopez.

        Expose the page workarounds ("quirks") setting to the GTK+ WebKit API.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 15:34:33 +0000 (15:34 +0000)]
2009-12-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Advice links to source code in CPU profiler to open in debugger,
        not in resources tab.

        Also work around the case when resources are disabled, but scripts are present.

        https://bugs.webkit.org/show_bug.cgi?id=32610

        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.updateMainViewWidth):
        (WebInspector.Panel.prototype.canShowSourceLineForURL):
        (WebInspector.Panel.prototype.showSourceLineForURL):
        * inspector/front-end/ProfileDataGridTree.js:
        (WebInspector.ProfileDataGridNode.prototype.createCell):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.canShowSourceLineForURL):
        (WebInspector.ResourcesPanel.prototype.showSourceLineForURL):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.scriptForURL):
        (WebInspector.ScriptsPanel.prototype.canShowSourceLineForURL):
        (WebInspector.ScriptsPanel.prototype.showSourceLineForURL):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/inspector.js:
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector._choosePanelToShowSourceLineForURL):
        (WebInspector.canShowSourceLineForURL):
        (WebInspector.showSourceLineForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping one test that needs overriding of standard preferences,
kov@webkit.org [Thu, 17 Dec 2009 14:42:40 +0000 (14:42 +0000)]
Skipping one test that needs overriding of standard preferences,
and a new one.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Xan Lopez.
philn@webkit.org [Thu, 17 Dec 2009 14:27:00 +0000 (14:27 +0000)]
    Reviewed by Xan Lopez.

        [GTK] display FPS stats for video element
        https://bugs.webkit.org/show_bug.cgi?id=32560

        Display FPS statistics if WEBKIT_DEBUG environment variable
        contains the Media log category. This feature requires a very
        recent (>= 0.10.18) version of gst-plugins-bad.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Thu, 17 Dec 2009 14:01:48 +0000 (14:01 +0000)]
2009-12-17  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.

        [Qt] Add support for mocking touch events with QtLauncher
        https://bugs.webkit.org/show_bug.cgi?id=32434

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):
        (MainWindow::sendTouchEvent):
        (MainWindow::eventFilter):
        (MainWindow::setTouchMocking):
        (MainWindow::setupUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReverting 52246 and 52248 because they crash tests.
kov@webkit.org [Thu, 17 Dec 2009 13:05:40 +0000 (13:05 +0000)]
Reverting 52246 and 52248 because they crash tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Landing files I forgot to commit.
kov@webkit.org [Thu, 17 Dec 2009 12:30:37 +0000 (12:30 +0000)]
Build fix. Landing files I forgot to commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 17 Dec 2009 12:13:04 +0000 (12:13 +0000)]
2009-12-16  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] segfault during volume notification
        https://bugs.webkit.org/show_bug.cgi?id=32603

        Emit volumeChanged and durationChanged upon notification from
        GStreamer. Also don't reset the volume property on playbin, it is
        not needed as it is 1.0 by default both on playbin and in the
        MediaPlayer.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback):
        (WebCore::mediaPlayerPrivateVolumeChangedCallback):
        (WebCore::notifyVolumeIdleCallback):
        (WebCore::doGstInit):
        (WebCore::MediaPlayerPrivate::isAvailable):
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::volumeChanged):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::durationChanged):
        (WebCore::mimeTypeCache):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2009-11-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should emit {networkState,readyState,volume,time,size,rate,duration}Changed signals
        https://bugs.webkit.org/show_bug.cgi?id=30377

        Emit volumeChanged and durationChanged upon notification from
        GStreamer.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback):
        (WebCore::mediaPlayerPrivateVolumeCallback):
        (WebCore::notify_volume_idle_cb):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::durationChanged):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore
kov@webkit.org [Thu, 17 Dec 2009 12:02:21 +0000 (12:02 +0000)]
WebCore

2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Add GRefPtr support for GTK types to WebCore, as JSC does not link against
        GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.

        No new tests as functionality has not changed.

        * GNUmakefile.am:
        * platform/PopupMenu.h:
        * platform/gtk/GRefPtrGtk.cpp: Added.
        (WTF::refGPtr):
        (WTF::derefGPtr):
        * platform/gtk/GRefPtrGtk.h: Added.
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::menuRemoveItem):

JavaScriptCore

2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Implement GRefPtr, a smart pointer for reference counted GObject types.

        * GNUmakefile.am:
        * wtf/gtk/GOwnPtr.cpp:
        (WTF::GDir):
        * wtf/gtk/GRefPtr.h: Added.
        (WTF::):
        (WTF::GRefPtr::GRefPtr):
        (WTF::GRefPtr::~GRefPtr):
        (WTF::GRefPtr::clear):
        (WTF::GRefPtr::get):
        (WTF::GRefPtr::operator*):
        (WTF::GRefPtr::operator->):
        (WTF::GRefPtr::operator!):
        (WTF::GRefPtr::operator UnspecifiedBoolType):
        (WTF::GRefPtr::hashTableDeletedValue):
        (WTF::::operator):
        (WTF::::swap):
        (WTF::swap):
        (WTF::operator==):
        (WTF::operator!=):
        (WTF::static_pointer_cast):
        (WTF::const_pointer_cast):
        (WTF::getPtr):
        (WTF::adoptGRef):
        (WTF::refGPtr):
        (WTF::derefGPtr):

WebKit/gtk

2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
        https://bugs.webkit.org/show_bug.cgi?id=21599

        Convert a use of GOwnPtr for a reference counted type to GRefPtr.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 17 Dec 2009 11:48:53 +0000 (11:48 +0000)]
2009-12-17  Evan Martin  <evan@chromium.org>

        Reviewed by Xan Lopez.

        gtk: always use standard include paths, regardless of settings.
        WebKit style is to wrap the body of a header in #if ENABLE(FOO),
        so they're always safe to include whether the features are enabled or
        not.

        This fixes building with --disable-database and other flags.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Build fixes for make distcheck.
kov@webkit.org [Thu, 17 Dec 2009 11:33:55 +0000 (11:33 +0000)]
Unreviewed. Build fixes for make distcheck.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Gustavo Noronha Silva.
philn@webkit.org [Thu, 17 Dec 2009 11:14:08 +0000 (11:14 +0000)]
    Rubber-stamped by Gustavo Noronha Silva.

        Trivial WebKit coding style fix.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 08:27:25 +0000 (08:27 +0000)]
2009-12-17  Adam Barth  <abarth@webkit.org>

        Rubber stamp by Seidel.

        Clean up exception handling in WorkQueue.  Basically, a bunch of the
        delegate messages can throw exceptions because of network errors.  We
        want the queues to keep on ticking instead of erroring out.  That means
        we want to catch generic exceptions and continue looping.

        Also, cleaned up the exception handling in the EWS to properly log
        failures.

        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/workqueue.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:52:52 +0000 (07:52 +0000)]
2009-12-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Make UpdateStep quiet
        https://bugs.webkit.org/show_bug.cgi?id=32599

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/buildsteps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Evan Martin <evan@chromium.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:41:11 +0000 (07:41 +0000)]
2009-12-16  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Add Gtk to the early warning system WebKit port list.

        https://bugs.webkit.org/show_bug.cgi?id=32629

        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/webkitport.py:
        * Scripts/modules/webkitport_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:40:27 +0000 (07:40 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        post-diff is failing with exception under guess_reviewer_from_bug
        https://bugs.webkit.org/show_bug.cgi?id=32642

        Also refactor output capturing code into
        OutputCapture.assert_outputs to share more code between tests.

        * Scripts/modules/buildsteps.py:
         - Add the missing include.
         - Give guess_reviewer_from_bug a private underscore.
        * Scripts/modules/buildsteps_unittest.py: Added.
         - Test to make sure _guess_reviewer_from_bug works as expected.
        * Scripts/modules/commands/commandtest.py:
         - Custom code is now obsoleted by OutputCapture.assert_outputs
        * Scripts/modules/commands/queues_unittest.py:
         - ditto
        * Scripts/modules/credentials_unittest.py:
         - ditto
        * Scripts/modules/mock_bugzillatool.py:
         - fetch_reviewed_patches_from_bug can never return None
        * Scripts/modules/multicommandtool_unittest.py:
         - Custom code is now obsoleted by OutputCapture.assert_outputs
        * Scripts/modules/outputcapture.py:
         - Add assert_outputs to share more code between tests.
        * Scripts/run-webkit-unittests:
         - Add buildsteps_unittest.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Dec 2009 07:37:09 +0000 (07:37 +0000)]
2009-12-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Added a default argument to _update_status so that callers
        don't have to explictly pass None when they don't have a patch object.

        * Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
ukai@chromium.org [Thu, 17 Dec 2009 07:17:55 +0000 (07:17 +0000)]
Unreviewed, build fix.

[Chromium] Add EditableTextRole to catch up with
http://trac.webkit.org/changeset/52233

* public/WebAccessibilityRole.h:
(WebKit::): Added WebAccessibilityRoleEditableText
* src/AssertMatchingEnums.cpp: Added matching compile assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDel...
ossy@webkit.org [Thu, 17 Dec 2009 07:05:26 +0000 (07:05 +0000)]
[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDeleteEnabled().

* platform/qt/Skipped: editing/selection/doubleclick-beside-cr-span.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-15 MORITA Hajime <morrita@gmail.com>
hamaji@chromium.org [Thu, 17 Dec 2009 06:30:20 +0000 (06:30 +0000)]
2009-12-15 MORITA Hajime <morrita@gmail.com>

        Reviewed by Eric Seidel.

        Bug 28306: double-clicking a word inside <b> beside newline select two words
        https://bugs.webkit.org/show_bug.cgi?id=28306

        SimplifiedBackwardsTextIterator missed trailing whitespaces just
        before folding line-break, which is used to detect word
        boundaries. This fix checks strings on RenderText and expand text
        range on SimplifiedBackwardsTextIterator to include trailing
        whitespaces if availble.

        Test: editing/selection/doubleclick-beside-cr-span.html

        * editing/TextIterator.cpp:
        (WebCore::collapsedSpaceLength):
        (WebCore::maxOffsetIncludingCollapsedSpaces):
        (WebCore::SimplifiedBackwardsTextIterator::advance):
2009-12-16  MORITA Hajime <morrita@gmail.com>

        Reviewed by Eric Seidel.

        Bug 28306: double-clicking a word inside <b> beside newline select two words
        https://bugs.webkit.org/show_bug.cgi?id=28306

        SimplifiedBackwardsTextIterator missed trailing whitespaces just
        before folding line-break, which is used to detect word
        boundaries. This fix checks strings on RenderText and expand text
        range on SimplifiedBackwardsTextIterator to include trailing
        whitespaces if availble.

        * editing/selection/doubleclick-beside-cr-span-expected.txt: Added.
        * editing/selection/doubleclick-beside-cr-span.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 17 Dec 2009 06:19:05 +0000 (06:19 +0000)]
2009-12-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix flakiness in WebSocket handshake console message.
        https://bugs.webkit.org/show_bug.cgi?id=32598

        In chromium, LayoutTests/websocket/tests/handshake-error.html is
        flaky, because it outputs the following console message several times:
          CONSOLE MESSAGE: line 0: Unexpected response code:101
        Update m_mode in WebSocketHandshake correctly: Once it finds
        error in handshake message, set m_mode to Failed and don't try
        reading handshake message again.  If handshake message is not yet
        fully received, set m_mode to Incomplete, so next didReceiveData()
        will try to check handshake message again.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didReceiveData):
        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readServerHandshake):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 17 Dec 2009 05:58:00 +0000 (05:58 +0000)]
2009-12-16  Jon Honeycutt  <jhoneycutt@apple.com>

        MSAA: Accessibility role of text nodes is wrong

        https://bugs.webkit.org/show_bug.cgi?id=32631
        <rdar://problem/7369084>

        Reviewed by Alice Liu.

        Test: platform/win/accessibility/text-role.html

        WebCore/:
        * accessibility/AccessibilityObject.h:
        (WebCore::):
        Add a new role to the enum.
        (WebCore::AccessibilityObject::roleValueForMSAA):
        Declare a function to return the accessibility role for MSAA; the base
        implementation returns the old role value.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
        Initialize m_roleForMSAA.
        (WebCore::AccessibilityRenderObject::roleValueForMSAA):
        If m_roleForMSAA has been set, return it. If the renderer is a
        RenderText, set the role to EditableTextRole to match IE and Firefox.
        Otherwise, set the role for MSAA to the old role value.

        * accessibility/AccessibilityRenderObject.h:
        Add a member to hold the role for MSAA, and declare an override of
        roleValueForMSAA().

        WebKit/win/:
        * AccessibleBase.cpp:
        (MSAARole):
        If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT.
        (AccessibleBase::role):
        Call roleValueForMSAA().

        LayoutTests/:
        * platform/win/accessibility/text-role-expected.txt: Added.
        * platform/win/accessibility/text-role.html: Added.
        Check that the role of the text node that is the first child of the
        <a> tag has the "editable text" role.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Dec 2009 05:30:45 +0000 (05:30 +0000)]
2009-12-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by David Levin.

        check-webkit-style supports for TAB check against text files.
        https://bugs.webkit.org/show_bug.cgi?id=32538

        * Scripts/check-webkit-style:
          Move process_patch() to style.py.
        * Scripts/modules/cpp_style.py:
          Add can_handle().
        * Scripts/modules/cpp_style_unittest.py:
          Add tests for can_handle().
        * Scripts/modules/style.py:
          Added. This is a front-end of cpp_style and text_style. It dispatches
          files to an appropriate linter.
        * Scripts/modules/text_style.py:
          Added. This is a linter module for generic text files. It supports
          only for TAB checking at this moment.
        * Scripts/modules/text_style_unittest.py:
          Added. Tests for text_style.py.
        * Scripts/run-webkit-unittests:
          Add text_style_unittest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
ggaren@apple.com [Thu, 17 Dec 2009 03:50:37 +0000 (03:50 +0000)]
Fixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
bloated code

Reviewed by Oliver Hunt.

This patch cuts Interpreter stack use by about a third.

* bytecode/Opcode.h: Changed Opcode to const void* to work with the
const static initiliazation we want to do in Interpreter::privateExecute.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter): Moved hashtable initialization here to
avoid polluting Interpreter::privateExecute's stack, and changed it from a
series of add() calls to one add() call in a loop, to cut down on code size.

(JSC::Interpreter::privateExecute): Changed a series of label computations
to a copy of a compile-time constant array to cut down on code size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 17 Dec 2009 00:44:10 +0000 (00:44 +0000)]
2009-12-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Darin Adler.

        Fix LayoutTests/websocket/tests/url-with-query-for-no-query.html
        https://bugs.webkit.org/show_bug.cgi?id=32606

        It should test with /websocket/tests/no-query

        * websocket/tests/script-tests/url-with-query-for-no-query.js:
        * websocket/tests/url-with-query-for-no-query-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 00:41:04 +0000 (00:41 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52206.
        http://trac.webkit.org/changeset/52206
        https://bugs.webkit.org/show_bug.cgi?id=31187

        This broke pixel tests on Mac.  Presumably the code in
        ImageCG is wrong here.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/haiku/ImageHaiku.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::drawBitmapPattern):
        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::drawPattern):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::drawPattern):
        (WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 17 Dec 2009 00:40:10 +0000 (00:40 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        bugzilla-tool should not require users to install mechanize
        https://bugs.webkit.org/show_bug.cgi?id=32635

        Centralize our import logic.

        * Scripts/modules/bugzilla.py: use webkit_mechanize
        * Scripts/modules/statusbot.py: use webkit_mechanize
        * Scripts/modules/webkit_mechanize.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
ossy@webkit.org [Thu, 17 Dec 2009 00:31:39 +0000 (00:31 +0000)]
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639

Test was refactored by r52226, and now it passes.

* platform/qt/Skipped: unskip editing/selection/empty-cell-right-click.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevised version of the test for:
enrica@apple.com [Thu, 17 Dec 2009 00:15:52 +0000 (00:15 +0000)]
Revised version of the test for:
<rdar://problem/5565465
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Adele Peterson.

* editing/selection/empty-cell-right-click-expected.txt:
* editing/selection/empty-cell-right-click.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Thu, 17 Dec 2009 00:07:03 +0000 (00:07 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639

* platform/qt/Skipped: editing/selection/empty-cell-right-click.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Dec 2009 00:03:49 +0000 (00:03 +0000)]
2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=32637
        [V8] Generate most named property getters.

        Covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 16 Dec 2009 23:52:38 +0000 (23:52 +0000)]
2009-12-16  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement combobox delegate for Qt
        https://bugs.webkit.org/show_bug.cgi?id=32550

        Abstract popup menu factory.

        A static method from QtAbstractPopupMenu is used to create its instances. If a factory
        has been suplied to class QtAbstractPopupMenu the factory will be used to create the
        objects. If not an instance of QtFallbackPopupMenu will be created.

        The objective is to make it easy to replace the combobox popup at WebCore layer providing
        support to the combobox popup delegation API. Future patches will make it possible to
        replace the combobox popup at WebKit layer.

        No behavior changes.

        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu):
        * platform/qt/QtAbstractWebPopup.cpp:
        (WebCore::QtAbstractWebPopup::setFactory):
        (WebCore::QtAbstractWebPopup::create):
        * platform/qt/QtAbstractWebPopup.h:
        * platform/qt/QtFallbackWebPopup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Disable debug variants of WebKit frameworks.
mrowe@apple.com [Wed, 16 Dec 2009 23:39:35 +0000 (23:39 +0000)]
Build fix.  Disable debug variants of WebKit frameworks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 22:19:54 +0000 (22:19 +0000)]
2009-12-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Generalize commit-queue recent status page for all queues
        https://bugs.webkit.org/show_bug.cgi?id=32633

        * QueueStatusServer/index.html:
         - Generalize to support other queues.
        * QueueStatusServer/queue_status.py:
         - Generalize MainPage to support other queues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Right clicking in a table cell creates a selection that extends into the...
enrica@apple.com [Wed, 16 Dec 2009 22:02:03 +0000 (22:02 +0000)]
WebCore: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Eric Seidel.

Avoid extending the selection to the next cell if we start from an empty cell.

Test: editing/selection/empty-cell-right-click.html

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Replaced the code that check for empty table cell
with a call to the new function.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Extends the
selection only if we are not starting from an empty table cell.
* editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Added a function since this check is performed now in two places.
* editing/htmlediting.h: Added isEmptyTableCell declaration.

LayoutTests: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622

Reviewed by Eric Seidel.

* editing/selection/empty-cell-right-click-expected.txt: Added.
* editing/selection/empty-cell-right-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 16 Dec 2009 21:56:54 +0000 (21:56 +0000)]
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        feMerge crahses if feMergeNodes attribute in is empty
        https://bugs.webkit.org/show_bug.cgi?id=32489

        The previous test only checked if feMerge works on empty node
        without a last effect. In this case we get a source image and
        everything works fine. This test also covers the case if there
        is a last effect.

        * platform/mac/svg/custom/empty-merge-expected.checksum:
        * platform/mac/svg/custom/empty-merge-expected.png:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * svg/custom/empty-merge.svg:
2009-12-16  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        feMerge crahses if feMergeNodes attribute in is empty
        https://bugs.webkit.org/show_bug.cgi?id=32489

        SVGFEMergeElement only stored pointers to all effects of it's nodes
        in a list. But it should store the RefPtr otherwise the effects get
        dereferenced and WebKit crashes.
        I also made a short clean-up in SVGFilterBuilder. No change in
        functionality.

        Test: I updated svg/custom/empty-merge.svg to cover this problem.

        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::FEMerge):
        (WebCore::FEMerge::create):
        (WebCore::FEMerge::mergeInputs):
        (WebCore::FEMerge::setMergeInputs):
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFilterBuilder.cpp:
        (WebCore::SVGFilterBuilder::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-16 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 16 Dec 2009 21:24:08 +0000 (21:24 +0000)]
2009-12-16  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Early warning system server should display output as UTF-8.

        https://bugs.webkit.org/show_bug.cgi?id=32625

        * QueueStatusServer/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52218 268f45cc-cd09-0410-ab3c-d52691b4dbfc