WebKit-https.git
4 years agoDisable database handle statement caching to fix Internal Server Errors
ddkilzer@apple.com [Fri, 17 Oct 2014 23:15:51 +0000 (23:15 +0000)]
Disable database handle statement caching to fix Internal Server Errors

* Bugzilla/User.pm:
(Bugzilla::User::visible_bugs): Disable database handle
statement caching.  Apparently these statements would go bad
without the DBD module noticing, causing errors on numerous
pages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDon't create cached functions that access lexicalGlobalObject()
msaboff@apple.com [Fri, 17 Oct 2014 22:58:33 +0000 (22:58 +0000)]
Don't create cached functions that access lexicalGlobalObject()
https://bugs.webkit.org/show_bug.cgi?id=137839

Reviewed by Geoffrey Garen.

Source/WebCore:

Made it so that all the JSDOMWindow special functions blur(), close(), focus() and postMessage()
are always created as needed for every prototype.  Made it so that JSHTMLDocument does
the same for open().  Updated test to account for these methods not being cached

Updated tests accordingly.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot): Updated to always create cached versions of the
special functions.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot): Added to create an uncached open() method when
it is first accessed.
* html/HTMLDocument.idl: Added CustomGetOwnPropertySlot and implemented it in JSHTMLDocumentCustom.cpp.

LayoutTests:

Updadted test that check for

* fast/dom/wrapper-scope-expected.txt:
* fast/dom/wrapper-scope.html:
Removed "close" and "postMessage" from functions to check for wrapper scope.

* http/tests/security/cross-frame-access-put-expected.txt:
* http/tests/security/resources/cross-frame-iframe-for-put-test.html:
Removed "blur", "close" and "focus" from the functions to test, since this tests that
a parent's and child window's instances are the same.  Now they are always different.

* js/dom/global-function-resolve-expected.txt:
* js/dom/script-tests/global-function-resolve.js:
Removed "close" from this lists of functions to check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Speculative fix for a crash under RenderLayerCompositor::updateScrollCoordinate...
simon.fraser@apple.com [Fri, 17 Oct 2014 22:30:43 +0000 (22:30 +0000)]
[iOS] Speculative fix for a crash under RenderLayerCompositor::updateScrollCoordinatedLayer()
https://bugs.webkit.org/show_bug.cgi?id=137837
rdar://problem/18545452

Reviewed by Tim Horton.

Crash logs suggest that an iframe's RenderView's RenderLayer's backing can be null
in a call to updateScrollCoordinatedLayer(), so add an assertion (to help find a reproducible case)
and a null check.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::attachScrollingNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
commit-queue@webkit.org [Fri, 17 Oct 2014 22:28:53 +0000 (22:28 +0000)]
Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
https://bugs.webkit.org/show_bug.cgi?id=137835

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-17
Reviewed by Andreas Kling.

* Scripts/run-inspector-perf-tests.py: Removed.
This script is stale, as PerformanceTests/inspector no longer exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
simon.fraser@apple.com [Fri, 17 Oct 2014 22:12:57 +0000 (22:12 +0000)]
Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRe-arrange parentheses for compilation purposes.
akling@apple.com [Fri, 17 Oct 2014 22:10:48 +0000 (22:10 +0000)]
Re-arrange parentheses for compilation purposes.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix after r174838.
akling@apple.com [Fri, 17 Oct 2014 22:05:38 +0000 (22:05 +0000)]
Unreviewed build fix after r174838.

Use StackAllocator::addressOf() instead of the old way of grabbing at a stack reference.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBuild fix for 32-bit Yosemite
timothy_horton@apple.com [Fri, 17 Oct 2014 21:52:39 +0000 (21:52 +0000)]
Build fix for 32-bit Yosemite

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::contextMenuForEvent):
Avoid using NSItemProvider in 32-bit, because it doesn't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUse is<>() / downcast<>() for RenderBox
cdumez@apple.com [Fri, 17 Oct 2014 21:25:10 +0000 (21:25 +0000)]
Use is<>() / downcast<>() for RenderBox
https://bugs.webkit.org/show_bug.cgi?id=137804

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for RenderBox and clean up the surrounding
code.

Source/WebCore:

No new tests, no behavior change.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLElement scrollYOffset]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
* bindings/objc/DOMUIKitExtensions.mm:
(-[DOMNode borderRadii]):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::sizingBox):
(WebCore::computedTransform):
(WebCore::zoomAdjustedPaddingOrMarginPixelValue):
(WebCore::ComputedStyleExtractor::propertyValue):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getLowerRightCorner):
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
* dom/Element.cpp:
(WebCore::Element::scrollByUnits):
* dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
* dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
* editing/FrameSelection.cpp:
(WebCore::CaretBase::paintCaret):
* editing/TextIterator.cpp:
(WebCore::fullyClipsContents):
(WebCore::shouldEmitExtraNewlineForNode):
* editing/htmlediting.cpp:
(WebCore::absoluteBoundsForLocalCaretRect):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isFocusable):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
* inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementInfo):
* page/AutoscrollController.cpp:
(WebCore::AutoscrollController::updateAutoscrollRenderer):
* page/EventHandler.cpp:
(WebCore::EventHandler::startPanScrolling):
* page/FrameView.cpp:
(WebCore::FrameView::embeddedContentBox):
* page/GestureTapHighlighter.cpp:
* page/SpatialNavigation.cpp:
(WebCore::isScrollableNode):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::baselinePosition):
* plugins/PluginView.cpp:
(WebCore::PluginView::invalidateWindowlessPluginRect):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::adjustPosition):
* rendering/InlineElementBox.cpp:
(WebCore::InlineElementBox::deleteLine):
(WebCore::InlineElementBox::extractLine):
(WebCore::InlineElementBox::attachLine):
(WebCore::InlineElementBox::paint):
(WebCore::InlineElementBox::nodeAtPoint):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
(WebCore::RenderBlock::clearPercentHeightDescendantsFrom):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutLineBoxes):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::findAutoscrollable):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::positionForPoint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
* rendering/RenderBox.h:
(WebCore::RenderBox::previousSiblingBox):
(WebCore::RenderBox::nextSiblingBox):
(WebCore::RenderBox::parentBox):
(WebCore::RenderBox::firstChildBox):
(WebCore::RenderBox::lastChildBox):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
(WebCore::RenderBoxModelObject::constrainingRectForStickyPosition):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::findLegend):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderFlowThread::currentActiveRenderBox):
* rendering/RenderFlowThread.h:
* rendering/RenderFullScreen.cpp:
(WebCore::RenderFullScreen::unwrapRenderer):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::layoutShadowControls):
(WebCore::RenderImage::computeIntrinsicRatioInformation):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::perspectiveTransform):
(WebCore::RenderLayer::perspectiveOrigin):
(WebCore::parentLayerCrossFrame):
(WebCore::RenderLayer::enclosingScrollableLayer):
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::scrollsOverflow):
(WebCore::computeReferenceBox):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::contentsBox):
(WebCore::RenderLayerBacking::backgroundBoxForPainting):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect):
* rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::layout):
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::firstColumnSetOrSpanner):
(WebCore::RenderMultiColumnFlowThread::nextColumnSetOrSpannerSiblingOf):
(WebCore::RenderMultiColumnFlowThread::previousColumnSetOrSpannerSiblingOf):
(WebCore::RenderMultiColumnFlowThread::resolveMovedChild):
(WebCore::isValidColumnSpanner):
(WebCore::RenderMultiColumnFlowThread::handleSpannerRemoval):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::getRanges):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::showRegionsInformation):
(WebCore::RenderObject::showRenderObject):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::addAnnotatedRegions):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::baselinePosition):
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::baselinePosition):
(WebCore::centerRectVerticallyInParentInputElement):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::baselinePosition):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::baselinePosition):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::externalRepresentation):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::setLineBreakInfo):
* rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleReplaced):
* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::embeddedContentBox):

Source/WebKit/mac:

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::clientFloatRectForNode):
* WebView/WebFrame.mm:
(-[WebFrame renderedSizeOfNode:constrainedToWidth:]):

Source/WebKit/win:

* WebView.cpp:
(WebView::gestureNotify):

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
(WebKit::WebPage::plugInIsPrimarySize):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGet rid of wrapperContext() in DOM bindings.
akling@apple.com [Fri, 17 Oct 2014 21:24:11 +0000 (21:24 +0000)]
Get rid of wrapperContext() in DOM bindings.
<https://webkit.org/b/137834>

Reviewed by Chris Dumez.

The "wrapper context" is always the DOMWrapperWorld, and since we're passing that around
already, we don't need a separate mechanism to get at the context.

The context is extra data stored in the DOM object's JSC::Weak (the wrapper GC object.)

* bindings/js/JSDOMBinding.h:
(WebCore::setInlineCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::wrapperContext): Deleted.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake a better use of the available registers when compiling nested selector lists
benjamin@webkit.org [Fri, 17 Oct 2014 21:21:00 +0000 (21:21 +0000)]
Make a better use of the available registers when compiling nested selector lists
https://bugs.webkit.org/show_bug.cgi?id=137802

Reviewed by Andreas Kling.

Source/WebCore:

Previously, when compiling a nested selector list, the compiler would start by pushing all
the allocated registers to the stack to free them for the compiled selector list.
While neat to ensure register allocation is correct, this is very inefficient.

This patch brings the first step for reducing the overhead. Instead of pushing everything
to the stack, we just push as many registers as we need for compiling the selector list.

In most cases, we have so many registers that we don't even need to push anything to the stack.

Test: fast/selectors/nth-child-of-register-requirement.html

* cssjit/SelectorCompiler.cpp:
Add an explicit type for SelectorList to keep information aggregated from all
SelectorFragmentList inside it.

SelectorFragmentList is also extended to include its register and stack requirements.
This information is then used to create a SelectorList and to compile the SelectorFragmentList.

(WebCore::SelectorCompiler::hasAnyCombinators):
We only change the elementAddressRegister when moving over combinators. This is used to detect
if a selector list clobber the elementAddressRegister or leave it untouched.

(WebCore::SelectorCompiler::computeBacktrackingMemoryRequirements):
(WebCore::SelectorCompiler::computeBacktrackingInformation):
Instead of returning a BacktrackingMemoryRequirements, update the SelectorFragmentList and SelectorList directly.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
This is where the fun happen.
First step is keep the input untouched. For now it is simply pushed on the stack. This can be improved later.

Then we find how many allocated registers we need to save to compile the input selector list. We push those registers
to the stack and give them back to the register allocator.

With enough registers we can now compile the nested selector list. The code has changed a bit for efficiency. Instead
of creating a shortcut for success case, the code now exit on error and proceed on success. This is the general pattern
of SelectorCompiler and it is quite a bit more efficient in the common cases.

Finally, we reallocate the registers and get their values back from the stack. The "tail" is duplicated but that's fine
because in the vast majority of cases it is 1 or 2 pop.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):
* cssjit/StackAllocator.h:
(WebCore::StackAllocator::push):

LayoutTests:

The register pressure cases are already well covered by fast/selectors/nth-child-of-boundaries-*.
The new test covers the maximum register pressure inside :nth-child(of) and having the selector with
max pressure inside a selector list instead of being alone/first.

* fast/selectors/nth-child-of-register-requirement-expected.txt: Added.
* fast/selectors/nth-child-of-register-requirement.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the build with the public SDK.
timothy_horton@apple.com [Fri, 17 Oct 2014 21:12:46 +0000 (21:12 +0000)]
Fix the build with the public SDK.

* WebCoreSupport/WebSelectionServiceController.mm:
We should transition all this SPI to real SPI headers as soon as possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUse is<>() / downcast<>() for StyleImage
cdumez@apple.com [Fri, 17 Oct 2014 21:12:42 +0000 (21:12 +0000)]
Use is<>() / downcast<>() for StyleImage
https://bugs.webkit.org/show_bug.cgi?id=137824

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for StyleImage and clean up the surrouding
code.

No new tests, no behavior change.

* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::detachPendingImage):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedImageURL):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::detachPendingImage):
(WebCore::CSSImageSetValue::~CSSImageSetValue):
(WebCore::CSSImageSetValue::cachedImageSet):
(WebCore::CSSImageSetValue::hasFailedOrCanceledSubresources):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::detachPendingImage):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::hasFailedOrCanceledSubresources):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingShapeImage):
(WebCore::StyleResolver::loadPendingImages):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleCachedImageSet.h:
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StyleImage.h:
* rendering/style/StylePendingImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Simplify test fallback paths for iOS Simulator testing
simon.fraser@apple.com [Fri, 17 Oct 2014 21:06:21 +0000 (21:06 +0000)]
[iOS] Simplify test fallback paths for iOS Simulator testing
https://bugs.webkit.org/show_bug.cgi?id=137830

Reviewed by Zalan Bujtas.

Make the fallback paths be:
    ios-simulator -> generic
    ios-simulator-wk2->ios-simulator -> generic

so don't include mac in the fallback path. Also remove the
version handling for simplicity.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort):
(IOSSimulatorPort.default_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix typos in Dashboard config
dburkart@apple.com [Fri, 17 Oct 2014 21:03:40 +0000 (21:03 +0000)]
Fix typos in Dashboard config

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Unreviewed test gardening. Mark some tests as passing that have benefitted...
bfulgham@apple.com [Fri, 17 Oct 2014 20:51:51 +0000 (20:51 +0000)]
[Win] Unreviewed test gardening. Mark some tests as passing that have benefitted from recent bug fixes.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Media] Always update controls for <audio> since they are always visible
dino@apple.com [Fri, 17 Oct 2014 20:35:06 +0000 (20:35 +0000)]
[Media] Always update controls for <audio> since they are always visible
https://bugs.webkit.org/show_bug.cgi?id=137829
<rdar://problem/18693987>

Reviewed by Brent Fulgham.

Revision 174756 made a change to only update the display of the controls
while they are visible. However, <audio> elements didn't detect visibility
the same way, since their controls do not auto-hide.

Change controlsAreHidden to check if we're an audio element.

* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.controlsAreHidden): Audio elements do not auto-hide their controls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Allow WinLauncher to specify Custom User Agent strings
bfulgham@apple.com [Fri, 17 Oct 2014 20:02:17 +0000 (20:02 +0000)]
[Win] Allow WinLauncher to specify Custom User Agent strings
https://bugs.webkit.org/show_bug.cgi?id=137828

Reviewed by Dean Jackson.

* WinLauncher/Common.cpp: Add support for custom user agent strings.
* WinLauncher/WinLauncher.cpp: Add some convenience methods to get
and set the user agent strings.
* WinLauncher/WinLauncher.h:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
resources and dialog for setting custom User Agent strings.
* WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WinCairo] Accelerated compositing is not implemented.
commit-queue@webkit.org [Fri, 17 Oct 2014 19:50:09 +0000 (19:50 +0000)]
[WinCairo] Accelerated compositing is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=137345

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-10-17
Reviewed by Brent Fulgham.

This patch is based on GTK, and the texture mapper graphics layer type.

Source/WebCore:

* WebCore.vcxproj/copyForwardingHeaders.cmd: Copy texmap headers.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: Added method and flag indicating whether animation has started.
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h: Ditto.
(WebCore::GraphicsLayerTextureMapper::startedAnimation):
* platform/graphics/texmap/TextureMapperShaderProgram.cpp: Use same precision for uniform in vertex shader as in fragment shader.
Otherwise glLinkProgram() will fail, and nothing will be rendered.

Source/WebKit:

* WebKit.vcxproj/WebKit/WebKit.vcxproj: Added new accelerated compositing source files.
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.

Source/WebKit/win:

* WebCoreSupport/AcceleratedCompositingContext.cpp: Added.
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::getWebViewSize):
(WebKit::AcceleratedCompositingContext::initialize):
(WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::stopAnyPendingLayerFlush):
(WebKit::AcceleratedCompositingContext::enabled):
(WebKit::AcceleratedCompositingContext::prepareForRendering):
(WebKit::AcceleratedCompositingContext::startedAnimation):
(WebKit::AcceleratedCompositingContext::compositeLayersToContext):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):
(WebKit::AcceleratedCompositingContext::setNonCompositedContentsNeedDisplay):
(WebKit::AcceleratedCompositingContext::setNeedsDisplayInRect):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::scrollNonCompositedContents):
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush):
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::flushPendingLayerChangesSoon):
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):
(WebKit::AcceleratedCompositingContext::layerFlushTimerFired):
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):
(WebKit::AcceleratedCompositingContext::paintContents):
* WebCoreSupport/AcceleratedCompositingContext.h: Added.
(WebKit::AcceleratedCompositingContext::LayerFlushTimer::LayerFlushTimer):
(WebKit::AcceleratedCompositingContext::LayerFlushTimer::fired):
* WebView.cpp:
(WebView::WebView):
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
(WebView::sizeChanged):
(WebView::paint):
(WebView::setRootChildLayer):
(WebView::flushPendingGraphicsLayerChangesSoon):
(WebView::setAcceleratedCompositing):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd test for innerHTML mutations that yield identical DOM.
akling@apple.com [Fri, 17 Oct 2014 19:16:51 +0000 (19:16 +0000)]
Add test for innerHTML mutations that yield identical DOM.
<https://webkit.org/b/137823>

Reviewed by Chris Dumez.

I made this test while working on an optimization, and it seems useful
to have in the tree since it adds additional coverage. The optimization
may come later.

The test works by creating little DOM subtrees like so:

    <foo><bar>some text</bar></foo>

It then overwrites that subtree with an identical one by mutating the
containing element's innerHTML property. It then verifies that the DOM
structure is correct and that Node wrappers retain any custom properties
set on them.

* fast/innerHTML/identical-mutations-expected.txt: Added.
* fast/innerHTML/identical-mutations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Crash when load is canceled while waiting for the user to type HTTP authenticat...
ap@apple.com [Fri, 17 Oct 2014 18:49:02 +0000 (18:49 +0000)]
[iOS] Crash when load is canceled while waiting for the user to type HTTP authentication credentials
https://bugs.webkit.org/show_bug.cgi?id=137826
rdar://problem/17329599

Reviewed by Brady Eidson.

No new tests, as we don't have a way to simulate details of user interaction with
an auth dialog.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::receivedRequestToPerformDefaultHandling):
(WebCore::ResourceHandle::receivedChallengeRejection):
Added null checks before passing m_connection for CFNetwork functions, making this
match what Mac code does when sending a message to a nil receiver.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the iOS build.
simon.fraser@apple.com [Fri, 17 Oct 2014 17:41:27 +0000 (17:41 +0000)]
Fix the iOS build.

* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVMediaSelectionOption):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Turn off font autosizing for iOS WebKitTestRunner
simon.fraser@apple.com [Fri, 17 Oct 2014 17:30:54 +0000 (17:30 +0000)]
[iOS] Turn off font autosizing for iOS WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=137806

Reviewed by Sam Weinig.
Source/WebKit2:

Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
to disable font autosizing.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMinimumZoomFontSize):
(WKPreferencesGetMinimumZoomFontSize):
* UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
to disable font autosizing.

Add platformResetPreferencesToConsistentValues() and implement it in the iOS
test controller to set platform-specific prefs.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::TestController::platformResetPreferencesToConsistentValues):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetPreferencesToConsistentValues):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformResetPreferencesToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] Represent AVMediaSelectionOptions as AudioTracks
jer.noble@apple.com [Fri, 17 Oct 2014 16:40:14 +0000 (16:40 +0000)]
[Mac] Represent AVMediaSelectionOptions as AudioTracks
https://bugs.webkit.org/show_bug.cgi?id=137474

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/media/hls/hls-audio-tracks.html

Support selecting audio "tracks" in HLS streams by exposing AVMediaSelectionOptions
as entries in the video's AudioTrackList.

AVMediaSessionGroups and AVPlayerItems don't have KVO or notifications to track when options
are selected and deselected, so wrap AVMediaSessionGroup and AVMediaSessionOption in C++
wrappers. Each AVMediaSelectionGroup can have only one AVMediaSelectionOption selected at a
time, so the wrapper will take care of answering which AVMediaSelectionOption is currently
selected, as without KVO notifications, asking the AVMediaSelectionGroup directly is
inconsistent. Because setting the selected option multiple times in the same run-loop can
cause flakiness, coalesce calls to setSelectedOption() by setting a one-shot timer to do
the actual selection in the next run-loop.

* platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h: Added.
(WebCore::MediaSelectionOptionAVFObjC::avMediaSelectionOption):
(WebCore::MediaSelectionOptionAVFObjC::clearGroup): Clear backpointer to group from option.
(WebCore::MediaSelectionGroupAVFObjC::selectedOption): Simple accessor.
(WebCore::MediaSelectionGroupAVFObjC::options):  Simple accessor.
(WebCore::MediaSelectionGroupAVFObjC::avMediaSelectionGroup): Simple accessor.
* platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm: Added.
(WebCore::MediaSelectionOptionAVFObjC::create): Simple factory method.
(WebCore::MediaSelectionOptionAVFObjC::MediaSelectionOptionAVFObjC): Simple constructor.
(WebCore::MediaSelectionOptionAVFObjC::setSelected): Pass through to MediaSelectionGroupAVFObjC.
(WebCore::MediaSelectionOptionAVFObjC::selected): Ditto.
(WebCore::MediaSelectionOptionAVFObjC::index): Return index of this object in the group's object.
(WebCore::MediaSelectionGroupAVFObjC::create):
(WebCore::MediaSelectionGroupAVFObjC::MediaSelectionGroupAVFObjC):
(WebCore::MediaSelectionGroupAVFObjC::~MediaSelectionGroupAVFObjC):
(WebCore::MediaSelectionGroupAVFObjC::updateOptions): Discover added or removed options.
(WebCore::MediaSelectionGroupAVFObjC::setSelectedOption): Set a one shot timer to coalesce multiple calls.
(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired): Set the selected AVSelectionOption.

Modify AVTrackPrivateAVFObjCImpl to support both AVPlayerItemTracks and these new
MediaSelectionOptionAVFObjC objects.

* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:
(WebCore::AVTrackPrivateAVFObjCImpl::mediaSelectionOption): Simple accessor.
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl):  Simple constructor.
(WebCore::AVTrackPrivateAVFObjCImpl::~AVTrackPrivateAVFObjCImpl): Simple destructor.
(WebCore::AVTrackPrivateAVFObjCImpl::enabled): Use MediaSelectionOptionAVFObjC, if present.
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::index): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::id): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::label): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::language): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVMediaSelectionOption): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::trackID): Ditto.

Allow AudioTrackPrivateAVFObjC and VideoTrackPrivateAVFObjC to be created with
a MediaSelectionOptionAVFObjC.

* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
(WebCore::AudioTrackPrivateAVFObjC::create): Takes a MediaSelectionOptionAVFObjC.
* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Simple constructor.
(WebCore::AudioTrackPrivateAVFObjC::setMediaSelectionOption): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::mediaSelectionOption): Simple accessor.
* platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Simple constructor.
(WebCore::VideoTrackPrivateAVFObjC::setMediaSelectonOption): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::mediaSelectionOption): Simple accessor.
* platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:

Because IDs are not necessarily unique across AVPlayerItemTracks and AVMediaSelectionOptions,
use the index of the track or option instead of it's self-declared ID for ordering for the
trackIndex.

* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
* platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm:
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):

Rather than making allowing the AVPlayerItem to automatically select the "best"
AVMediaSelectionOption, select the automatic options when creating the AVPlayerItem
and thereafter allow the users manual selections "stick".

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::ensureAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::ensureAVPlayerItem):

Determine whether any MediaSelectionOptionsAVFObjC have been added or removed and send trackChange events accordingly.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::determineChangedTracksFromNewTracksAndOldItems): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Search for updated selection options.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia): Return selection group, if available.
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange): Filter out AVPlayerItemTracks without
    AVAssetTracks, as these will be represented by MediaSelectionGroupObjCs instead.

Add new files to project.
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

* http/tests/media/hls/hls-audio-tracks-expected.txt: Added.
* http/tests/media/hls/hls-audio-tracks.html: Added.
* http/tests/media/resources/hls/audio-tracks.m3u8: Added.
* http/tests/media/resources/hls/bipbop/iframe_index.m3u8: Added.
* http/tests/media/resources/hls/bipbop/main0.ts: Added.
* http/tests/media/resources/hls/bipbop/main1.ts: Added.
* http/tests/media/resources/hls/bipbop/prog_index.m3u8: Added.
* http/tests/media/resources/hls/french/main.aac: Added.
* http/tests/media/resources/hls/french/prog_index.m3u8: Added.
* http/tests/media/resources/hls/spanish/main.aac: Added.
* http/tests/media/resources/hls/spanish/prog_index.m3u8: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Test gardening after r174796.
bfulgham@apple.com [Fri, 17 Oct 2014 16:13:55 +0000 (16:13 +0000)]
[Win] Test gardening after r174796.

Now that Windows DRT matches Mac's output, we can get rid of some custom test expecations.

* platform/win/fast/dom/window-load-crash-expected.txt: Removed.
* platform/win/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
* platform/win/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
* platform/win/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
* platform/win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Removed.
* platform/win/loader/image-loader-adoptNode-assert-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoVarious arguments optimisations in codegen fail to account for arguments being in...
oliver@apple.com [Fri, 17 Oct 2014 16:07:08 +0000 (16:07 +0000)]
Various arguments optimisations in codegen fail to account for arguments being in lexical record
https://bugs.webkit.org/show_bug.cgi?id=137617

Reviewed by Michael Saboff.

Rework the way we track |arguments| references so that we don't try
to use the |arguments| reference on the stack if it's not safe.

To do this without nuking performance it was necessary to update
the parser to track modification of the |arguments| reference
itself.

* bytecode/CodeBlock.cpp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::willResolveToArguments):
(JSC::BytecodeGenerator::uncheckedLocalArgumentsRegister):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::uncheckedRegisterForArguments): Deleted.
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::hasSafeLocalArgumentsRegister):
* bytecompiler/NodesCodegen.cpp:
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::getArgumentByVal):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):
* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::existingArguments):
* parser/Nodes.h:
(JSC::ScopeNode::modifiesArguments):
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
* parser/Parser.h:
(JSC::Scope::getCapturedVariables):
* parser/ParserModes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] REGRESSION(r173929): It broke the Web Inspector
gyuyoung.kim@samsung.com [Fri, 17 Oct 2014 10:51:08 +0000 (10:51 +0000)]
[EFL] REGRESSION(r173929): It broke the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=137522

Reviewed by Csaba Osztrogonác.

r173929 let web inspector use a separate web process. Besides it changed that the inspector is shown
as docking mode by default. However EFL port doesn't support to show web inspector as docking window yet.
This patch is to show web inspector on EFL new window as before. Docking mode should be implemented by
upcoming patch.

* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformAttach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] window.screen.width returns wrong value if more displays are available
g.czajkowski@samsung.com [Fri, 17 Oct 2014 10:43:54 +0000 (10:43 +0000)]
[EFL] window.screen.width returns wrong value if more displays are available
https://bugs.webkit.org/show_bug.cgi?id=137778

Reviewed by Gyuyoung Kim.

ecore_x_screen_size_get() retrieves the size of Ecore_X_Screen, for example,
having two displays of 1680x1050, it will return 3360x1050.

Unlike EFL's MiniBrowser, Firefox and Chrome return screen of the current display.

No new tests. Hardware specific bug including multiple displays.

* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):
Use ecore's xrandr to determine the screen on which browser window is displayed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GLIB] Add API to GMainLoopSource to schedule sources after a delay in microseconds
carlosgc@webkit.org [Fri, 17 Oct 2014 10:10:47 +0000 (10:10 +0000)]
[GLIB] Add API to GMainLoopSource to schedule sources after a delay in microseconds
https://bugs.webkit.org/show_bug.cgi?id=137782

Reviewed by Sergio Villar Senin.

Source/WebCore:

* platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireInterval): Use microseconds instead of
milliseconds.

Source/WebKit2:

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::layerFlushTimerFired): Use microseconds
instead of milliseconds.

Source/WTF:

In some cases when we have a double with the time in seconds, the
conversion to milliseconds ends up truncating the value to 0, and
the source scheduled immediately.

* wtf/gobject/GMainLoopSource.cpp:
(WTF::createMicrosecondsTimeoutSource): Use a custom timeout
source that handles the interval in microseconds instead of milliseconds.
(WTF::GMainLoopSource::scheduleAfterDelay): Use MicrosecondsTimeoutSource.
(WTF::GMainLoopSource::scheduleAfterDelayAndDeleteOnDestroy): Ditto.
* wtf/gobject/GMainLoopSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Move touch events handling from Platform to WebKit2
carlosgc@webkit.org [Fri, 17 Oct 2014 10:04:37 +0000 (10:04 +0000)]
[GTK] Move touch events handling from Platform to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=137735

Reviewed by Sergio Villar Senin.

Source/WebCore:

Remove GtkTouchContextHelper.

* PlatformGTK.cmake:
* platform/gtk/GtkTouchContextHelper.cpp: Removed.
* platform/gtk/GtkTouchContextHelper.h: Removed.

Source/WebKit2:

GtkTouchContextHelper was only used by WebKitWebViewBase, since
it's the only one that can create touch events. The code has been
simplified by processing the events in the view, and the native
touch events are now created with the native event and touch points.

* Shared/NativeWebTouchEvent.h:
(WebKit::NativeWebTouchEvent::touchContext): Deleted.
* Shared/gtk/NativeWebTouchEventGtk.cpp:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent): Pass touch
points instead of touch context to WebEventFactory::createWebTouchEvent().
* Shared/gtk/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent): Create the
WebTouchEvent for the given native event and points.
(WebKit::touchPhaseFromEvents): Deleted.
(WebKit::appendTouchEvent): Deleted.
* Shared/gtk/WebEventFactory.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(appendTouchEvent): Helper function to create a
WebPlatformTouchPoint for the given native event and add it to the
list of touch points.
(webkitWebViewBaseGetTouchPointForEvent): Build the touch point
list for the event.
(webkitWebViewBaseTouchEvent): Process the touch event.
(webkitWebViewBaseDragDataReceived): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused function in WorkerThreadableLoader.h
gyuyoung.kim@samsung.com [Fri, 17 Oct 2014 10:00:09 +0000 (10:00 +0000)]
Remove unused function in WorkerThreadableLoader.h
https://bugs.webkit.org/show_bug.cgi?id=137811

Reviewed by Csaba Osztrogonác.

mainThreadCreateLoader() isn't used anywhere. Even there is no implementation.

* loader/WorkerThreadableLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse WTF::move() instead of std::move() to help ensure move semantics in JavaScriptCore
gyuyoung.kim@samsung.com [Fri, 17 Oct 2014 09:54:14 +0000 (09:54 +0000)]
Use WTF::move() instead of std::move() to help ensure move semantics in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=137809

Reviewed by Csaba Osztrogonác.

Substitution of WTF::move() for std::move(). Clean up std::move() in JavaScriptCore.

* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
* bytecode/PutByIdVariant.cpp:
(JSC::PutByIdVariant::setter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReverted incorrect build fix attempt.
mitz@apple.com [Fri, 17 Oct 2014 08:27:56 +0000 (08:27 +0000)]
Reverted incorrect build fix attempt.

* wtf/Threading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTried to fix the Yosemite build.
mitz@apple.com [Fri, 17 Oct 2014 08:23:24 +0000 (08:23 +0000)]
Tried to fix the Yosemite build.

* wtf/Threading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(CMake): [GTK] WebKitSettings:enable-smooth-scrolling does nothing
carlosgc@webkit.org [Fri, 17 Oct 2014 06:31:20 +0000 (06:31 +0000)]
REGRESSION(CMake): [GTK] WebKitSettings:enable-smooth-scrolling does nothing
https://bugs.webkit.org/show_bug.cgi?id=137781

Reviewed by Martin Robinson.

We used to enable smooth scrolling unconditionally in autotools
(via WebKitFeatures.m4), but since the switch to CMake it's
unconditionally disabled, so changing the setting doesn't have any
effect.

* Source/cmake/OptionsGTK.cmake: Enable smooth scrolling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS Selectors Level 4: Implement :matches in SelectorChecker
utatane.tea@gmail.com [Fri, 17 Oct 2014 05:34:47 +0000 (05:34 +0000)]
CSS Selectors Level 4: Implement :matches in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=137393

Reviewed by Benjamin Poulain.

Source/WebCore:

In this patch, we introduce initial :matches implementation.
In this current implementation, we don't consider pseudo elements.

Test: fast/selectors/querySelector-matches.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):

LayoutTests:

* fast/selectors/matches-selector-list-expected.txt: Added.
* fast/selectors/matches-selector-list.html: Added.
* fast/selectors/querySelector-matches-expected.txt: Added.
* fast/selectors/querySelector-matches.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS JIT: Introduce StackAllocator::addressOf
utatane.tea@gmail.com [Fri, 17 Oct 2014 05:17:44 +0000 (05:17 +0000)]
CSS JIT: Introduce StackAllocator::addressOf
https://bugs.webkit.org/show_bug.cgi?id=137771

Reviewed by Benjamin Poulain.

Introduce StackAllocator::addressOf and drop offsetToStackReference, it's too primitive.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateParentElementTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::loadCheckingContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAdjacentBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDescendantBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstLink):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateStoreLastVisitedElement):
* cssjit/StackAllocator.h:
(WebCore::StackAllocator::addressOf):
(WebCore::StackAllocator::offsetToStackReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoOSObjectPtr is missing leakRef()
mitz@apple.com [Fri, 17 Oct 2014 05:14:25 +0000 (05:14 +0000)]
OSObjectPtr is missing leakRef()
https://bugs.webkit.org/show_bug.cgi?id=137798

Reviewed by Sam Weinig.

Source/WTF:

* wtf/OSObjectPtr.h:

Tools:

* TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
(TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate target platform to remove Leopard, Snow Leopard, Lion.
lforschler@apple.com [Fri, 17 Oct 2014 03:26:22 +0000 (03:26 +0000)]
Update target platform to remove Leopard, Snow Leopard, Lion.
Add Yosemite.

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r169024): Undetermined text is not displayed in the search field of Adobe...
ap@apple.com [Fri, 17 Oct 2014 02:17:14 +0000 (02:17 +0000)]
REGRESSION (r169024): Undetermined text is not displayed in the search field of Adobe Help Website
https://bugs.webkit.org/show_bug.cgi?id=137679
rdar://problem/18450335

Reviewed by Enrica Casucci.

Source/WebCore:

Test: platform/mac/editing/input/selected-composed-text-painting.html

* rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): We do not paint
selection beckground for unconfirmed text with underlines, so we should use a regular
style for text painting, as well.

LayoutTests:

* platform/mac/editing/input/selected-composed-text-painting-expected.html: Added.
* platform/mac/editing/input/selected-composed-text-painting.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse is<>() / downcast<>() for BasicShape subclasses
cdumez@apple.com [Fri, 17 Oct 2014 01:54:17 +0000 (01:54 +0000)]
Use is<>() / downcast<>() for BasicShape subclasses
https://bugs.webkit.org/show_bug.cgi?id=137766

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for BasicShape subclasses and clean up the
surrounding code.

No new tests, no behavior change.

* css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
* css/BasicShapeFunctions.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::shapePropertyValue):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
* rendering/ClipPathOperation.h:
(WebCore::ShapeClipPathOperation::create):
Take a PassRef<BasicShape> in argument to make it obvious it is never
null.

(WebCore::ShapeClipPathOperation::basicShape):
Return a reference instead of a pointer as it can never return null.

(WebCore::ShapeClipPathOperation::windRule):
(WebCore::ShapeClipPathOperation::pathForReferenceRect):
Make it non-const due to the const-correctness of Ref::get().

(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupClipPath):
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
* rendering/shapes/Shape.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computedShape):
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeCircle::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInset::blend):
* rendering/style/BasicShapes.h:
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLeverage the new RenderElement::m_isCSSAnimating flag in more places
cdumez@apple.com [Fri, 17 Oct 2014 01:53:09 +0000 (01:53 +0000)]
Leverage the new RenderElement::m_isCSSAnimating flag in more places
https://bugs.webkit.org/show_bug.cgi?id=137786

Reviewed by Simon Fraser.

Leverage the new RenderElement::m_isCSSAnimating flag that was introduced
in r174703 in more places, for performance. This avoids doing extra work
for renderers on which we are not running animations on. This patch also
updates the API a bit to use more references instead of pointers, making
it clear the RenderElement cannot be null and thus avoiding unnecessary
null checks.

No new tests, no behavior change.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
* page/animation/AnimationController.h:
* page/animation/AnimationControllerPrivate.h:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeDestroyed):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::notifyAnimationStarted):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoving CUSTOM_PROTOCOLS guard
commit-queue@webkit.org [Fri, 17 Oct 2014 01:14:24 +0000 (01:14 +0000)]
Removing CUSTOM_PROTOCOLS guard
https://bugs.webkit.org/show_bug.cgi?id=137741

Patch by Pascal Jacquemart <p.jacquemart@samsung.com> on 2014-10-16
Reviewed by Benjamin Poulain.

.:

* Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
* Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
* Shared/Network/CustomProtocols/CustomProtocolManager.h:
* Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
* Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
* Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
* Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp:
* Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
* Shared/Network/NetworkProcessCreationParameters.h:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/soup/WKAPICastSoup.h:
* UIProcess/API/C/soup/WKSoupCustomProtocolRequestManager.cpp:
(WKSoupCustomProtocolRequestManagerGetTypeID):
(WKSoupCustomProtocolRequestManagerSetClient):
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
* UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
* UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:
* UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:
* UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.h:
* UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.cpp:
* UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManagerClient.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers):
(WebKit::WebContext::unregisterSchemeForCustomProtocol):
* UIProcess/WebContext.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInitializeNetworkProcess):
* WebKit2Prefix.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
* WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
* WebProcess/soup/WebKitSoupRequestGeneric.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMissing RefPtr.release() calls in TextureMapper
commit-queue@webkit.org [Fri, 17 Oct 2014 01:12:51 +0000 (01:12 +0000)]
Missing RefPtr.release() calls in TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=137777

Patch by Adrien Destugues <pulkomandy@gmail.com> on 2014-10-16
Reviewed by Chris Dumez.

No new tests: no functional change, cleanup/optimization.

Avoids useless ref/deref cycle when returning from functions.

* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintIntoSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse is<>() / downcast<>() for ContentData subclasses
cdumez@apple.com [Fri, 17 Oct 2014 00:35:59 +0000 (00:35 +0000)]
Use is<>() / downcast<>() for ContentData subclasses
https://bugs.webkit.org/show_bug.cgi?id=137768

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for ContentData subclasses.

No new tests, no behavior change.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImages):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
* rendering/style/ContentData.h:
(WebCore::operator==):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agocommit-queue: fails to replace OO-PS! with reviewer name
ddkilzer@apple.com [Thu, 16 Oct 2014 23:55:59 +0000 (23:55 +0000)]
commit-queue: fails to replace OO-PS! with reviewer name
<http://webkit.org/b/137795>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
email addresses to unauthenticated page loads, so we must always
authenticate before getting bug data so we get full email
addresses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrash under RemoteLayerTreeHost::getLayer() when closing a tab
simon.fraser@apple.com [Thu, 16 Oct 2014 23:39:09 +0000 (23:39 +0000)]
Crash under RemoteLayerTreeHost::getLayer() when closing a tab
https://bugs.webkit.org/show_bug.cgi?id=137796
rdar://problem/18547565

Reviewed by Tim Horton.

CA can call our animation delegate after the RemoteLayerTreeHost has been
destroyed. CAAnimation retains its delegate, so it's safe for us to null out
the WKAnimationDelegate's pointer to the RemoteLayerTreeHost when tearing down
the RemoteLayerTreeHost.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::animationDidEnd):
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(-[WKAnimationDelegate invalidate]):
(-[WKAnimationDelegate animationDidStart:]):
(-[WKAnimationDelegate animationDidStop:finished:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Unreviewed gardening.
zalan@apple.com [Thu, 16 Oct 2014 22:43:18 +0000 (22:43 +0000)]
[Mac] Unreviewed gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agocommit-queue: fails to close bugs after successfully landing patches
ddkilzer@apple.com [Thu, 16 Oct 2014 22:43:02 +0000 (22:43 +0000)]
commit-queue: fails to close bugs after successfully landing patches
<http://webkit.org/b/137794>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
tell Mechanize to use the second <textarea> on the page with
name="comment".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Update DRT to match Mac Logic
bfulgham@apple.com [Thu, 16 Oct 2014 22:08:12 +0000 (22:08 +0000)]
[Win] Update DRT to match Mac Logic
https://bugs.webkit.org/show_bug.cgi?id=137787

Reviewed by Dean Jackson.

* DumpRenderTree/win/DumpRenderTree.cpp:
(initialize): 0 -> nullptr
(runTest): Initialize MSG structure before using.
(main): Add CRT debug flags if building DRT with debug malloc on Windows.
Also, cleanly shut down COM when exiting.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
header and add printf to match Mac.
(FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
* DumpRenderTree/win/FrameLoadDelegate.h:
(FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
(FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(isLocalhost): Added.
(hostIsUsedBySomeTestsToGenerateError): Added.
(ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
of certain error and redirect host names.
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
anything should be output to the console. This modifies behavior to match the Mac.
(UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
(UIDelegate::webViewAddMessageToConsole): Ditto.
* WinLauncher/PageLoadTestClient.cpp:
(PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
added last week.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse a single allocation for the Arguments object
oliver@apple.com [Thu, 16 Oct 2014 22:02:16 +0000 (22:02 +0000)]
Use a single allocation for the Arguments object
https://bugs.webkit.org/show_bug.cgi?id=137751

Reviewed by Filip Pizlo.

This patch removes the secondary allocation for parameters in the Arguments
object.  This is faily simple, but we needed to make it possible for the JIT
to allocate a variable GC object.  To do this i've added a new
emitAllocateVariableSizedJSObject function to the JIT that does the work to
find the correct heap for a variable sized allocation and then bump that
allocator.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateArguments):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateVariableSizedJSObject):
* heap/CopyToken.h:
* heap/Heap.h:
(JSC::Heap::subspaceForObjectWithoutDestructor):
(JSC::Heap::subspaceForObjectNormalDestructor):
(JSC::Heap::subspaceForObjectsWithImmortalStructure):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::subspaceForObjectsWithNormalDestructor):
(JSC::MarkedSpace::subspaceForObjectsWithImmortalStructure):
(JSC::MarkedSpace::subspaceForObjectsWithoutDestructor):
* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::createArguments):
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
(JSC::Arguments::copyBackingStore):
(JSC::Arguments::tearOff):
(JSC::Arguments::allocateRegisterArray): Deleted.
* runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::isTornOff):
(JSC::Arguments::offsetOfRegisterArray):
(JSC::Arguments::registerArraySizeInBytes):
(JSC::Arguments::registerArray):
(JSC::Arguments::allocationSize): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r174744.
commit-queue@webkit.org [Thu, 16 Oct 2014 21:58:06 +0000 (21:58 +0000)]
Unreviewed, rolling out r174744.
https://bugs.webkit.org/show_bug.cgi?id=137790

Caused another WebGL conformance test to fail (Requested by
rfong on #webkit).

Reverted changeset:

"glReadPixels on NVIDIA cards returns the wrong values for the
alpha channel when alpha is off."
https://bugs.webkit.org/show_bug.cgi?id=137752
http://trac.webkit.org/changeset/174744

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r174754.
commit-queue@webkit.org [Thu, 16 Oct 2014 21:57:49 +0000 (21:57 +0000)]
Unreviewed, rolling out r174754.
https://bugs.webkit.org/show_bug.cgi?id=137789

Speculative fix for Windows test was ineffective. (Requested
by rfong on #webkit).

Reverted changeset:

"[Windows] Add some more logging to debug Windows test
issues."
http://trac.webkit.org/changeset/174754

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Unreviewed gardening.
zalan@apple.com [Thu, 16 Oct 2014 21:33:50 +0000 (21:33 +0000)]
[Mac] Unreviewed gardening.

Unskip more subpixel related tests.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement selection services menu for Legacy WebKit
timothy_horton@apple.com [Thu, 16 Oct 2014 20:13:35 +0000 (20:13 +0000)]
Implement selection services menu for Legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=137582
<rdar://problem/18604241>

Reviewed by Brady Eidson.

* WebCore.exp.in:
* editing/Editor.h:
* editing/ios/EditorIOS.mm:
(WebCore::Editor::replaceSelectionWithAttributedString):
* editing/mac/EditorMac.mm:
(WebCore::Editor::replaceSelectionWithAttributedString):
Add replaceSelectionWithAttributedString, which replaces the selection
with the given attributed string (converting to plain text if the destination
is not richly editable).

* WebKit.xcodeproj/project.pbxproj:

* Misc/WebSharingServicePickerController.h:
Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
Add WebSharingServicePickerClient, which other classes can implement
instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.

* Misc/WebSharingServicePickerController.mm:
Pass in NSSharingServicePickerStyle, so that clients can specify the style.

(-[WebSharingServicePickerController clear]):
(-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
(-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
(-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
(-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
(-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
Make use of WebSharingServicePickerClient.

(-[WebSharingServicePickerController sharingService:didShareItems:]):
If we're returned a NSAttributedString, paste it on top of the current selection,
similar to what the WebKit2 implementation currently does.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::handleTelephoneNumberClick):
(WebChromeClient::handleSelectionServiceClick):
(WebChromeClient::hasRelevantSelectionServices):
Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.

* WebCoreSupport/WebContextMenuClient.h:
* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::sharingServicePickerWillBeDestroyed):
(WebContextMenuClient::pageForSharingServicePicker):
(WebContextMenuClient::windowForSharingServicePicker):
(WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
(WebContextMenuClient::imageForCurrentSharingServicePickerItem):
(WebContextMenuClient::contextMenuForEvent):
(WebContextMenuClient::screenRectForHitTestNode): Deleted.
(WebContextMenuClient::renderedImageForControlledImage): Deleted.
(WebContextMenuClient::clearSharingServicePickerController): Deleted.
Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
having WebSharingServicePickerController tightly bound to it.
Make an NSItemProvider array when instantiating WebSharingServicePickerController
instead of handing it data directly.

* WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
* WebCoreSupport/WebSelectionServiceController.mm: Added.
(WebSelectionServiceController::WebSelectionServiceController):
Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
for selection services.

(WebSelectionServiceController::handleSelectionServiceClick):
Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.

(hasCompatibleServicesForItems):
(WebSelectionServiceController::hasRelevantSelectionServices):
Determine whether or not services are available.

(WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
(WebSelectionServiceController::pageForSharingServicePicker):
(WebSelectionServiceController::windowForSharingServicePicker):
Implement the rest of the WebSharingServicePickerClient overrides.

(WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
(WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
These are only useful for image sharing services, so we don't need to
implement them (WebContextMenuClient does, on the other hand).

* WebView/WebView.mm:
(-[WebView _selectionServiceController]):
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
* WebView/WebViewInternal.h:
Keep a WebSelectionServiceController.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):
Add a note that we should transition to using replaceSelectionWithAttributedString.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleSelectionServiceClick):
Allow editor services in editable-but-not-rich-text areas, just like in WebKit1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoApparently we've had a hole in arguments capture all along
fpizlo@apple.com [Thu, 16 Oct 2014 19:56:25 +0000 (19:56 +0000)]
Apparently we've had a hole in arguments capture all along
https://bugs.webkit.org/show_bug.cgi?id=137767

Reviewed by Oliver Hunt.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArgument):
* tests/stress/arguments-captured.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoHave the ProfileType node in the DFG convert to a structure check where it can
saambarati1@gmail.com [Thu, 16 Oct 2014 19:55:14 +0000 (19:55 +0000)]
Have the ProfileType node in the DFG convert to a structure check where it can
https://bugs.webkit.org/show_bug.cgi?id=137596

Reviewed by Filip Pizlo.

TypeSet now keeps track of the live set of Structures it has seen.
It no longer nukes everything during GC. It now only removes unmarked
structures during GC. This modification allows the ProfileType node
to convert into a CheckStructure node safely in the DFG.

This change brings up the conversion rate from ProfileType to Check
or CheckStructrue from ~45% to ~65%. This change also speeds the
type profiler up significantly: consistently between 2x-20x faster.

This patch also does some slight refactoring: a few type profiler
related fields are moved from VM to TypeProfiler.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToCheckStructure):
* heap/Heap.cpp:
(JSC::Heap::collect):
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::uniqueIDForVariable):
* runtime/SymbolTable.h:
* runtime/TypeLocationCache.cpp:
(JSC::TypeLocationCache::getTypeLocation):
* runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::TypeProfiler):
(JSC::TypeProfiler::nextTypeLocation):
(JSC::TypeProfiler::invalidateTypeSetCache):
(JSC::TypeProfiler::dumpTypeProfilerData):
* runtime/TypeProfiler.h:
(JSC::TypeProfiler::getNextUniqueVariableID):
* runtime/TypeProfilerLog.cpp:
(JSC::TypeProfilerLog::processLogEntries):
* runtime/TypeSet.cpp:
(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::invalidateCache):
* runtime/TypeSet.h:
(JSC::TypeSet::structureSet):
* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::enableTypeProfiler):
(JSC::VM::disableTypeProfiler):
(JSC::VM::dumpTypeProfilerData):
(JSC::VM::nextTypeLocation): Deleted.
(JSC::VM::invalidateTypeSetCache): Deleted.
* runtime/VM.h:
(JSC::VM::typeProfiler):
(JSC::VM::getNextUniqueVariableID): Deleted.
* tests/typeProfiler/dfg-jit-optimizations.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVarious crashes in ViewGestureControllerIOS when closing a tab while a swipe gesture...
timothy_horton@apple.com [Thu, 16 Oct 2014 19:53:12 +0000 (19:53 +0000)]
Various crashes in ViewGestureControllerIOS when closing a tab while a swipe gesture is in progress
https://bugs.webkit.org/show_bug.cgi?id=137770
<rdar://problem/17916459>

Reviewed by Dan Bernstein.

When tearing down a WKWebView in the middle of a swipe gesture, a variety of
UI process crashes were observed. First, two uses of potentially deleted objects
(the WebBackForwardListItem and ViewGestureController), which were fixed by
extending the object's lifetime and checking for its liveness, respectively.
Second, a potential null-deref of DrawingArea if the timing of endSwipeGesture
vs. page teardown was such that DrawingArea was null but everything else was in line.
Lastly, another case of messaging a potentially deleted object (specifically,
the _UIViewControllerTransitionContext's animator) in a callback from CA, which
was fixed by nulling out the animator (and a few other properties) when tearing
down the ViewGestureController.

* UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController invalidate]):
Clear the soon-to-be-invalid ViewGestureController pointer.

(WebKit::ViewGestureController::~ViewGestureController):
Call [WKSwipeTransitionController invalidate] upon destruction.
Clear our transition context's interactor and animator, and inform it that
the transition is not in flight. This avoids a crash when calling back
to the already-destroyed animator later.

(WebKit::ViewGestureController::beginSwipeGesture):
Keep a reference to the target WebBackForwardListItem; this avoids
it being deleted between here and the transition completion block firing.

Look up the ViewGestureController by pageID, just like we do in endSwipeGesture,
to avoid situations where the callback fires after the WKWebView/ViewGestureController
have gone away.

Hold on to our _UIViewControllerOneToOneTransitionContext, so that we can do the
aforementioned clearing upon deallocation.

(WebKit::ViewGestureController::endSwipeGesture):
Null check the DrawingArea. If it is null, instead of doing our normal delayed logic
for swipe snapshot teardown, just put things back together immediately.

(WebKit::ViewGestureController::removeSwipeSnapshot):
Clear m_swipeTransitionContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrashes in ResourceHandleCFURLConnectionDelegateWithOperationQueue due to unimplement...
ap@apple.com [Thu, 16 Oct 2014 19:45:31 +0000 (19:45 +0000)]
Crashes in ResourceHandleCFURLConnectionDelegateWithOperationQueue due to unimplemented retain/release
https://bugs.webkit.org/show_bug.cgi?id=137779
rdar://problem/18679320

Reviewed by Brady Eidson.

* platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegate::retain):
(WebCore::ResourceHandleCFURLConnectionDelegate::release):
(WebCore::ResourceHandleCFURLConnectionDelegate::makeConnectionClient):
* platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:
Implemented retain/release. They are necessary, as ResourceHandle goes away when
it's canceled, and there is noone else to keep the client object alive but
CFURLConnection itself.

* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
Added a FIXME about potential improvements that I spotted while invsestigating this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Unreviewed gardening.
zalan@apple.com [Thu, 16 Oct 2014 19:14:42 +0000 (19:14 +0000)]
[Mac] Unreviewed gardening.

Unskip subpixel border tests.

* platform/mac/TestExpectations:
* platform/mac/css1/units/length_units-expected.txt:
* platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt:
* platform/mac/media/video-zoom-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix JavaScript alert() about missing search terms when submitting patch review
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:37 +0000 (16:01 +0000)]
Fix JavaScript alert() about missing search terms when submitting patch review

* template/en/default/attachment/reviewform.html.tmpl: Pass
hide_content=1 argument when including global/header.html.tmpl.
* template/en/default/global/header.html.tmpl: Add hide_content argument
that hides header content when including the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRe-enable WebKit-based user matching
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:36 +0000 (16:01 +0000)]
Re-enable WebKit-based user matching

* data/params: Disable Bugzilla's own user matching, which also
requires the JSON::RPC Perl module.
* template/en/default/global/footer.html.tmpl: Include
committers-autocomplete.js everywhere. Every. Where.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix loading of legacy comments from older Bugzillas
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:35 +0000 (16:01 +0000)]
Fix loading of legacy comments from older Bugzillas

* code-review.js:
(fetchHistory): We must support both the old-style and new-style
formats for attachment comments since the old-style format is
quoted and stored as text in the database forever.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate proxy URL parameter used by Bugzilla
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:34 +0000 (16:01 +0000)]
Update proxy URL parameter used by Bugzilla

* data/params: Update proxy URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix maximum unshared memory size of Apache processes
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:33 +0000 (16:01 +0000)]
Fix maximum unshared memory size of Apache processes

* mod_perl.pl: Set the maximum unshared memory size of Apache
processes to 700 MB.  According to the manpage, this is the
correct way to do it in a mod_perl config file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unneeded rule from .htaccess
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:32 +0000 (16:01 +0000)]
Remove unneeded rule from .htaccess

* .htaccess: Remove an old rule that doesn't match any files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpgrade to Bugzilla 4.2.11.
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:32 +0000 (16:01 +0000)]
Upgrade to Bugzilla 4.2.11.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove template/en/custom files onto template/en/default
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:28 +0000 (16:01 +0000)]
Move template/en/custom files onto template/en/default

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDo not hide details on attachment edit page
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:24 +0000 (16:01 +0000)]
Do not hide details on attachment edit page

* template/en/custom/attachment/edit.html.tmpl: Comment out the
call to toggle_attachment_details_visibility() that initially
hides the details.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRe-fix Bug 26950: Make the summary and alias fields support click-to-edit <https...
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:23 +0000 (16:01 +0000)]
Re-fix Bug 26950: Make the summary and alias fields support click-to-edit <https://bugs.webkit.org/show_bug.cgi?id=26950>

* js/field.js: Port the changes from r45538 to Bugzilla 4.2.5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agomigrate.pl: remove unnecessary change
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:23 +0000 (16:01 +0000)]
migrate.pl: remove unnecessary change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix "View Diff" buttons on edit attachment page
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:22 +0000 (16:01 +0000)]
Fix "View Diff" buttons on edit attachment page

* js/attachment.js:
(viewPrettyPatch): Change code syntax from Perl to JavaScript.
When I moved this method from
template/en/custom/attachment/edit.html.tmpl into
js/attachment.js during the Bugzilla 4.2.1 merge, I wrote some
of the code using Perl syntax.
* template/en/custom/attachment/edit.html.tmpl:
- Fix 120-column truncation of code.  (That's what you get for
  copying and pasting code from 'git diff' in a terminal
  window.)
- Pass attachment_id into the viewPrettyPatch() method since
  the method expects it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove references to Rietveld from bugs.webkit.org
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:21 +0000 (16:01 +0000)]
Remove references to Rietveld from bugs.webkit.org

Rietveld was an experiment that was added by Google.  It was
never enabled for everyone, so it's safe to remove the changes
that reference it.

* Bugzilla/Flag.pm: Remove code that prevented mail messages from
being sent for patches reviewed in Rietveld.
* attachment.cgi: Remove reference to the "rietveldreview"
template.
* template/en/custom/attachment/list.html.tmpl: Remove code
that handled the Rietveld review flag.
* template/en/custom/attachment/reviewform.html.tmpl: Remove code
that handled the "rietveldReview" CGI parameter.
* template/en/custom/attachment/rietveldreview.html.tmpl: Delete.
* template/en/custom/flag/list.html.tmpl: Delete.  After
removing the code to handle Rietveld reviews, there were no more
local WebKit changes to the custom template file, so it could be
removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDisplay legal text when uploading a patch with a new bug
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:19 +0000 (16:01 +0000)]
Display legal text when uploading a patch with a new bug

* js/attachment.js:
(setContentTypeDisabledState): Make this work on the Enter Bug
page so that the "Submit Bug" button changes to
"Agree and Submit Bug" when the "patch" checkbox is checked, and
it changes back to "Submit Bug" when unchecked.
* template/en/custom/attachment/createformcontents.html.tmpl:
Include the attachment/patchlegalese.html.tmpl template when
returning the page so that it will be shown when the "patch"
checkbox is checked.  Set the 'product' variable from the CGI
variable of the same name.
* template/en/custom/attachment/patchlegalese.html.tmpl: Add the
'expert_fields' class to the <tr> element so that it gets
shown/hidden when the Show/Hide Advanced Fields links are
clicked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of large blank area when adding non-patch attachment
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:18 +0000 (16:01 +0000)]
Get rid of large blank area when adding non-patch attachment

* js/attachment.js:
* template/en/custom/attachment/patchlegalese.html.tmpl:
- Use 'display: none;' and 'display: table-row;' instead of
  'visibility: collapse;' and 'visibility: visible;' to hide and
  show the text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove patch legalese into its own template file for reuse
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:17 +0000 (16:01 +0000)]
Move patch legalese into its own template file for reuse

* template/en/custom/attachment/create.html.tmpl:
* template/en/custom/attachment/patchlegalese.html.tmpl:
- Extract patch legalese into its own file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix review form after Bugzilla 4.2.5 update
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:16 +0000 (16:01 +0000)]
Fix review form after Bugzilla 4.2.5 update

* code-review.js:
(fetchHistory):
- Trim author since new format adds a space before the name.
- Update comment_marker to match the text now used by Bugzilla.

* template/en/custom/attachment/reviewform.html.tmpl:
- Add global/header.html.tmpl to make sure we get the standard
  HTML for including CSS, JavaScript, etc.
  - Remove redundant <link> tags.
  - Add CSS in local <style> to hide the header.
  - Change local <script> to be passed as an argument into
    global/header.html.tmpl when it is processed.
  - NOTE: local <style> tag should be passed as an argument into
    global/header.html.tmpl, but that breaks page layout, so it
    was skipped for now.
- Fix fallout form moving flag_types into the attachment object
  when processing flag/list.html.tmpl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd back "WebKit Bugzilla" text in page header
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:15 +0000 (16:01 +0000)]
Add back "WebKit Bugzilla" text in page header

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd .htaccess files created by checksetup.pl
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:14 +0000 (16:01 +0000)]
Add .htaccess files created by checksetup.pl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agodata/params: update after running checksetup.pl
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:13 +0000 (16:01 +0000)]
data/params: update after running checksetup.pl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpgrade to Bugzilla 4.2.7.
ddkilzer@apple.com [Thu, 16 Oct 2014 16:01:12 +0000 (16:01 +0000)]
Upgrade to Bugzilla 4.2.7.

Conflicts:
    buglist.cgi
    report.cgi

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpgrade bugs.webkit.org to Bugzilla 4.2
ddkilzer@apple.com [Thu, 16 Oct 2014 16:00:58 +0000 (16:00 +0000)]
Upgrade bugs.webkit.org to Bugzilla 4.2
<http://webkit.org/b/55882>

Upgrade to Bugzilla 4.2.1.

Conflicts:
    .htaccess
    Bugzilla.pm
    Bugzilla/Auth.pm
    Bugzilla/Auth/Login/CGI.pm
    Bugzilla/Auth/Persist/Cookie.pm
    Bugzilla/Bug.pm
    Bugzilla/BugMail.pm
    Bugzilla/CGI.pm
    Bugzilla/Config/Attachment.pm
    Bugzilla/Config/Common.pm
    Bugzilla/Config/General.pm
    Bugzilla/Constants.pm
    Bugzilla/DB/Mysql.pm
    Bugzilla/DB/Oracle.pm
    Bugzilla/DB/Schema.pm
    Bugzilla/DB/Schema/Oracle.pm
    Bugzilla/Error.pm
    Bugzilla/Flag.pm
    Bugzilla/FlagType.pm
    Bugzilla/Hook.pm
    Bugzilla/Install/DB.pm
    Bugzilla/Install/Filesystem.pm
    Bugzilla/Install/Localconfig.pm
    Bugzilla/Install/Requirements.pm
    Bugzilla/Install/Util.pm
    Bugzilla/Mailer.pm
    Bugzilla/Product.pm
    Bugzilla/Search.pm
    Bugzilla/Search/Quicksearch.pm
    Bugzilla/Search/Saved.pm
    Bugzilla/Series.pm
    Bugzilla/Template.pm
    Bugzilla/Template/Plugin/Hook.pm
    Bugzilla/Token.pm
    Bugzilla/User.pm
    Bugzilla/Util.pm
    Bugzilla/WebService.pm
    Bugzilla/WebService/Bug.pm
    Bugzilla/WebService/Bugzilla.pm
    Bugzilla/WebService/Constants.pm
    Bugzilla/WebService/Product.pm
    Bugzilla/WebService/User.pm
    attachment.cgi
    buglist.cgi
    checksetup.pl
    colchange.cgi
    collectstats.pl
    contrib/bugzilla_ldapsync.rb
    contrib/bzdbcopy.pl
    contrib/gnats2bz.pl
    contrib/recode.pl
    contrib/sendbugmail.pl
    contrib/yp_nomail.sh
    docs/en/xml/Bugzilla-Guide.xml
    docs/en/xml/about.xml
    docs/en/xml/installation.xml
    docs/en/xml/security.xml
    docs/en/xml/troubleshooting.xml
    editflagtypes.cgi
    editparams.cgi
    editproducts.cgi
    editvalues.cgi
    editwhines.cgi
    email_in.pl
    enter_bug.cgi
    extensions/BmpConvert/Config.pm
    extensions/OldBugMove/template/en/default/admin/params/oldbugmove.html.tmpl
    extensions/Voting/template/en/default/hook/bug/process/header-title.html.tmpl
    extensions/Voting/template/en/default/hook/search/search-report-select-rep_fields.html.tmpl
    extensions/example/code/webservice-error_codes.pl
    extensions/example/version.pl
    images/favicon.ico
    importxml.pl
    index.cgi
    install-module.pl
    js/field.js
    js/util.js
    long_list.cgi
    mod_perl.pl
    post_bug.cgi
    process_bug.cgi
    quips.cgi
    sanitycheck.cgi
    show_bug.cgi
    showattachment.cgi
    sidebar.cgi
    skins/contrib/Dusk/global.css
    skins/contrib/Dusk/index.css
    skins/standard/global.css
    skins/standard/show_bug.css
    t/008filter.t
    template/en/custom/attachment/review.html.tmpl
    template/en/default/account/prefs/saved-searches.html.tmpl
    template/en/default/admin/classifications/delete.html.tmpl
    template/en/default/admin/classifications/edit-common.html.tmpl
    template/en/default/admin/classifications/footer.html.tmpl
    template/en/default/admin/components/create.html.tmpl
    template/en/default/admin/components/edit.html.tmpl
    template/en/default/admin/params/attachment.html.tmpl
    template/en/default/admin/sanitycheck/messages.html.tmpl
    template/en/default/admin/users/confirm-delete.html.tmpl
    template/en/default/admin/workflow/edit.html.tmpl
    template/en/default/attachment/created.html.tmpl
    template/en/default/attachment/diff-header.html.tmpl
    template/en/default/attachment/edit.html.tmpl
    template/en/default/attachment/list.html.tmpl
    template/en/default/attachment/updated.html.tmpl
    template/en/default/bug/comments.html.tmpl
    template/en/default/bug/create/create-guided.html.tmpl
    template/en/default/bug/create/create.html.tmpl
    template/en/default/bug/create/created.html.tmpl
    template/en/default/bug/edit.html.tmpl
    template/en/default/bug/field.html.tmpl
    template/en/default/bug/process/header.html.tmpl
    template/en/default/bug/show.html.tmpl
    template/en/default/bug/show.xml.tmpl
    template/en/default/config.rdf.tmpl
    template/en/default/email/whine.txt.tmpl
    template/en/default/filterexceptions.pl
    template/en/default/flag/list.html.tmpl
    template/en/default/global/common-links.html.tmpl
    template/en/default/global/confirm-action.html.tmpl
    template/en/default/global/field-descs.none.tmpl
    template/en/default/global/footer.html.tmpl
    template/en/default/global/header.html.tmpl
    template/en/default/global/user-error.html.tmpl
    template/en/default/global/userselect.html.tmpl
    template/en/default/list/edit-multiple.html.tmpl
    template/en/default/list/list.html.tmpl
    template/en/default/pages/fields.html.tmpl
    template/en/default/pages/release-notes.html.tmpl
    template/en/default/search/boolean-charts.html.tmpl
    template/en/default/search/form.html.tmpl
    template/en/default/search/search-report-graph.html.tmpl
    template/en/default/search/search-report-table.html.tmpl
    template/en/default/setup/strings.txt.pl
    token.cgi
    userprefs.cgi
    xml.cgi
    xmlrpc.cgi

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r173356): Downloading a disk image appends ".txt" to it
antti@apple.com [Thu, 16 Oct 2014 15:26:14 +0000 (15:26 +0000)]
REGRESSION (r173356): Downloading a disk image appends ".txt" to it
https://bugs.webkit.org/show_bug.cgi?id=137493
<rdar://problem/18321947>

Reviewed by Alexey Proskuryakov.

* Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::startWithHandle):
* Shared/Downloads/mac/DownloadMac.mm:
(WebKit::Download::startWithHandle):

    It appears that the synthesized NS/CFURLResponse fails to serialize the suggested filename correctly
    unless it has been accessed first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse isnan from std namespace in ProfileGenerator.cpp
commit-queue@webkit.org [Thu, 16 Oct 2014 13:29:55 +0000 (13:29 +0000)]
Use isnan from std namespace in ProfileGenerator.cpp
https://bugs.webkit.org/show_bug.cgi?id=137653

Patch by Adrien Destugues <pulkomandy@gmail.com> on 2014-10-16
Reviewed by Darin Adler.

The C++ isnan() function is in the std namespace. The unprefixed isnan
may be available because of C99 headers leakage in C++, but should not
be used.

No new tests: no functional change, build fix on platforms which don't
export C99 functions in C++.

* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause):
(JSC::ProfileGenerator::didContinue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoASSERTION FAILED in WebCore::RenderFlowThread::getRegionRangeForBox
abucur@adobe.com [Thu, 16 Oct 2014 06:50:30 +0000 (06:50 +0000)]
ASSERTION  FAILED in WebCore::RenderFlowThread::getRegionRangeForBox
https://bugs.webkit.org/show_bug.cgi?id=135563

Reviewed by David Hyatt.

Source/WebCore:

The new multi-column code doesn't work correctly when the document contains nested fragmentation
contexts. The problem is the current flow thread concept that can store only one RenderFlowThread
at a time and use it during layout.

The stored flow thread is always correct for regions because named flow threads are absolutley positioned
so every child renderer is contained inside them (with the expcetion of fixed positioned elements which are
treated separately).

For multi-column elements this is no longer the case. An absolutely positioned element inside a static
multi-column element will be contained by a block outside the fragmentation context. It can even be
contained by a different multi-column element in the case of nested flow threads.

The patch below explores a solution that's not based on a current flow thread stored globally. The proposed
patch makes every block to store a pointer to its fragmentation context and a flag that states if this pointer
needs to be updated or not. If the renderer is not a block it will get its flow thread from the containing
block. Once the containing flow thread is requested for the block, the pointer is computed and cached until
invalidated:
- when a subtree is removed from a flow thread
- when the position property of an element inside a flow thread changes

The process is recursive and it doesn't affect elements that are not nested inside a flow thread. If a block
changes position from relative to static, any element that was contained by it can only be contained by an
ancestor of the block. This ancestor will still be outside of any flow thread. This ensures that non-fragmentation
code is not affected from a performance perspective.

The patch affects the results of the performance tests:
- the regions layout tests have a decreased performance raging from 2% to 5-6%
- the regions selection tests have an increased performance raging from 1-2% to 10%
- the multicolumn layout tests (now pending review in b137687) have an increased performance
raging from 1.8% to 5%

Tests: fast/multicol/multicol-all-positioned-crash.html
       fast/multicol/multicol-transform-containing-block.html

* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::FlowThreadController):
* rendering/FlowThreadController.h:
(WebCore::FlowThreadController::currentRenderFlowThread): Deleted.
(WebCore::FlowThreadController::setCurrentRenderFlowThread): Deleted.
* rendering/LayoutState.h:
(WebCore::LayoutState::currentRenderFlowThread):
(WebCore::LayoutState::setCurrentRenderFlowThread):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::cachedFlowThreadContainingBlock):
(WebCore::RenderBlock::cachedFlowThreadContainingBlockNeedsUpdate):
(WebCore::RenderBlock::setCachedFlowThreadContainingBlockNeedsUpdate):
(WebCore::RenderBlock::updateCachedFlowThreadContainingBlock):
(WebCore::RenderBlock::locateFlowThreadContainingBlock):
* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleWillChange):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer): Deleted.
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer): Deleted.
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler): Deleted.
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler): Deleted.
* rendering/RenderFlowThread.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::showRegionsInformation):
(WebCore::RenderObject::insertedIntoTree):
(WebCore::RenderObject::removeFromRenderFlowThread):
(WebCore::RenderObject::removeFromRenderFlowThreadIncludingDescendants):
(WebCore::RenderObject::invalidateFlowThreadContainingBlockIncludingDescendants):
(WebCore::RenderObject::currentRenderNamedFlowFragment):
(WebCore::RenderObject::locateFlowThreadContainingBlock):
(WebCore::RenderObject::locateFlowThreadContainingBlockNoCache): Deleted.
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive): Deleted.
* rendering/RenderObject.h:
(WebCore::RenderObject::flowThreadContainingBlock):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::computeOverflowFromFlowThread):
* rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutStateForCurrentFlowThread):
(WebCore::RenderView::popLayoutStateForCurrentFlowThread):
* rendering/RenderView.h:

LayoutTests:

A test verifying that positioned elements inside multi-column containers don't
cause assertions or crashes.

* fast/multicol/multicol-all-positioned-crash-expected.txt: Added.
* fast/multicol/multicol-all-positioned-crash.html: Added.
* fast/multicol/multicol-transform-containing-block-expected.txt: Added.
* fast/multicol/multicol-transform-containing-block.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, add myself to CoordinatedGraphics watchers.
gyuyoung.kim@samsung.com [Thu, 16 Oct 2014 06:45:53 +0000 (06:45 +0000)]
Unreviewed, add myself to CoordinatedGraphics watchers.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse is<>() / downcast<>() for list-related render objects
cdumez@apple.com [Thu, 16 Oct 2014 06:04:36 +0000 (06:04 +0000)]
Use is<>() / downcast<>() for list-related render objects
https://bugs.webkit.org/show_bug.cgi?id=137764

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for list-related render objects and clean up
the surrounding code.

No new tests, no behavior change.

* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::visibleChildren):
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::elementRect):
* accessibility/AccessibilityObject.cpp:
(WebCore::renderListItemContainerForNode):
* accessibility/atk/WebKitAccessibleHyperlink.cpp:
(getRangeLengthForObject):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(accessibilityObjectLength):
(offsetAdjustmentForListItem):
(webkitAccessibleTextGetText):
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::didAttachRenderers):
(WebCore::HTMLLIElement::parseValue):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
* html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
* rendering/RenderCounter.cpp:
(WebCore::planCounter):
* rendering/RenderListBox.h:
* rendering/RenderListItem.cpp:
(WebCore::nextListItem):
(WebCore::previousListItem):
* rendering/RenderListItem.h:
* rendering/RenderListMarker.h:
* rendering/RenderMenuList.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::markerTextForListItem):
* rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustNodeSizes):
* rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleReplaced):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* testing/Internals.cpp:
(WebCore::Internals::isSelectPopupVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse std::unique_ptr for CachedResource
gyuyoung.kim@samsung.com [Thu, 16 Oct 2014 03:57:28 +0000 (03:57 +0000)]
Use std::unique_ptr for CachedResource
https://bugs.webkit.org/show_bug.cgi?id=137736

Reviewed by Darin Adler.

No new tests, no behavior change.

* loader/cache/CachedResource.cpp: Use std::unique_ptr instead of PassOwnPtr|OwnPtr.
(WebCore::CachedResource::removeClient):
* loader/cache/CachedResource.h: Set ctor from private to public.
(WebCore::CachedResource::CachedResourceCallback::schedule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove TextCodec classes to std::unique_ptr
gyuyoung.kim@samsung.com [Thu, 16 Oct 2014 02:50:59 +0000 (02:50 +0000)]
Move TextCodec classes to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=137738

Reviewed by Darin Adler.

Replace uses of PassOwnPtr in code under TextCodecFoo class with std::unique_ptr.
To do this, ctor of TextCodecFoo classes is changed from private to public. Besides
related classes follow this change as well.

No new tests, no behavior change.

* html/parser/HTMLMetaCharsetParser.h:
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::setEncoding):
(WebCore::TextResourceDecoder::flush):
* loader/TextResourceDecoder.h:
* platform/text/TextCodec.h:
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::create):
* platform/text/TextCodecICU.h:
* platform/text/TextCodecLatin1.cpp:
(WebCore::newStreamingTextDecoderWindowsLatin1):
* platform/text/TextCodecUTF16.cpp:
(WebCore::newStreamingTextDecoderUTF16LE):
(WebCore::newStreamingTextDecoderUTF16BE):
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::create):
* platform/text/TextCodecUTF8.h:
* platform/text/TextCodecUserDefined.cpp:
(WebCore::newStreamingTextDecoderUserDefined):
* platform/text/TextEncodingRegistry.cpp:
(WebCore::newTextCodec):
* platform/text/TextEncodingRegistry.h:
* platform/text/mac/TextCodecMac.cpp:
(WebCore::newTextCodecMac):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Media] Reduce style updates (painting) in controls
dino@apple.com [Thu, 16 Oct 2014 02:25:34 +0000 (02:25 +0000)]
[Media] Reduce style updates (painting) in controls
https://bugs.webkit.org/show_bug.cgi?id=137763
<rdar://problem/17833045>

Reviewed by Simon Fraser.

Media controls were causing a lot of repaints they were
constantly updating the style of the widgets, the value
of the forms, or the text in the display.

This is necessary when the controls are visible, but not
necessary when they are hidden. Return immediately in that case.

* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Initialise the slider to a zero value.
(Controller.prototype.handleDurationChange): Force an update even though we might be hidden.
(Controller.prototype.updateProgress): Don't update if we're hidden.
(Controller.prototype.updateTime): Ditto.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.updateProgress): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r174753.
commit-queue@webkit.org [Thu, 16 Oct 2014 01:41:23 +0000 (01:41 +0000)]
Unreviewed, rolling out r174753.
https://bugs.webkit.org/show_bug.cgi?id=137761

caused layout tests to fail. (Requested by zalan on #webkit).

Reverted changeset:

"[Mac] Unreviewed gardening."
http://trac.webkit.org/changeset/174753

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Windows] Speculative Windows test fix.
roger_fong@apple.com [Thu, 16 Oct 2014 01:16:36 +0000 (01:16 +0000)]
[Windows] Speculative Windows test fix.
Also add some more test logging.

* DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read): Add logging for testing purposes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Unreviewed gardening.
zalan@apple.com [Thu, 16 Oct 2014 00:56:05 +0000 (00:56 +0000)]
[Mac] Unreviewed gardening.

Unskip subpixel border tests.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix. Rolling back changes in http://trac.webkit.org/changeset/174721.
jonowells@apple.com [Thu, 16 Oct 2014 00:29:37 +0000 (00:29 +0000)]
Build fix. Rolling back changes in trac.webkit.org/changeset/174721.

* Scripts/copy-user-interface-resources.pl:
* UserInterface/External/ESLint/LICENSE: Removed.
* UserInterface/External/ESLint/eslint.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Unreviewed gardening(mountain-lion).
zalan@apple.com [Thu, 16 Oct 2014 00:17:59 +0000 (00:17 +0000)]
[Mac] Unreviewed gardening(mountain-lion).

* platform/mac-mountainlion/fast/text/international/hindi-spacing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r174025): remote inspector crashes frequently when executing inspector...
msaboff@apple.com [Thu, 16 Oct 2014 00:14:28 +0000 (00:14 +0000)]
REGRESSION(r174025): remote inspector crashes frequently when executing inspector frontend's JavaScript
https://bugs.webkit.org/show_bug.cgi?id=137758

Rubber stamped by Filip Pizlo.

Reverted r174025 for just PutByOffset Nodes.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoimport-w3c-test rewrites relative src paths in ref files incorrectly
commit-queue@webkit.org [Thu, 16 Oct 2014 00:13:17 +0000 (00:13 +0000)]
import-w3c-test rewrites relative src paths in ref files incorrectly
https://bugs.webkit.org/show_bug.cgi?id=137586

This patch fixes a bug in test_converter.py where src paths were getting
rewritten as ../../some-path instead of <script src="../../some-path>".
It also adds support for rewriting src paths in style  elements, which was
missing before and it adds tests for this case.

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-10-15
Reviewed by Bem Jones-Bey.

* Scripts/webkitpy/w3c/test_converter.py:
(_W3CTestConverter.convert_attributes_if_needed):
* Scripts/webkitpy/w3c/test_converter_unittest.py:
(test_convert_attributes_if_needed):
(verify_reference_relative_paths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Fix inefficiencies in ResourceResponse::platformLazyInit(InitLevel) - Part 2
cdumez@apple.com [Thu, 16 Oct 2014 00:09:57 +0000 (00:09 +0000)]
[Mac] Fix inefficiencies in ResourceResponse::platformLazyInit(InitLevel) - Part 2
https://bugs.webkit.org/show_bug.cgi?id=137721

Reviewed by Darin Adler.

Follow-up patch to r174717 addressing review comments made after the patch landed:
- Use modern C++ loop
- Remove explicit calls to String(NSString*) constructor

No new tests, no new tests.

* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse is<>() / downcast<>() for InlineBox subclasses
cdumez@apple.com [Thu, 16 Oct 2014 00:05:37 +0000 (00:05 +0000)]
Use is<>() / downcast<>() for InlineBox subclasses
https://bugs.webkit.org/show_bug.cgi?id=137749

Reviewed by Darin Adler.

Use is<>() / downcast<>() for InlineBox subclasses and clean up the
surrounding code.

No new tests, no behavior change.

* dom/Position.cpp:
(WebCore::Position::upstream):
(WebCore::Position::downstream):
* editing/VisibleUnits.cpp:
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::root):
(WebCore::InlineBox::nextLeafChild):
(WebCore::InlineBox::prevLeafChild):
(WebCore::InlineBox::nextLeafChildIgnoringLineBreak):
* rendering/InlineBox.h:
* rendering/InlineElementBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::getFlowSpacingLogicalWidth):
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeMaxLogicalTop):
(WebCore::InlineFlowBox::flipLinesInBlockDirection):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::firstLeafChild):
(WebCore::InlineFlowBox::lastLeafChild):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::positionForBox):
* rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::firstRootBox):
(WebCore::RenderBlockFlow::lastRootBox):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::createLineBoxes):
(WebCore::RenderBlockFlow::constructLine):
(WebCore::setLogicalWidthForTextRun):
(WebCore::computeExpansionForJustifiedText):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::isHyphenated):
(WebCore::RootInlineBox::ascentAndDescentForBox):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::positionForPoint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
* rendering/svg/SVGInlineFlowBox.h:
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeRenderSVGTextBox):
(WebCore::writeSVGInlineTextBoxes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
* rendering/svg/SVGRootInlineBox.h:
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Unreviewed gardening.
zalan@apple.com [Wed, 15 Oct 2014 22:36:08 +0000 (22:36 +0000)]
[Mac] Unreviewed gardening.

Rebaselining.

* platform/mac/TestExpectations:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/fast/events/constructors/mouse-event-constructor-expected.txt: Added.
* platform/mac/fast/events/constructors/wheel-event-constructor-expected.txt: Added.
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/mac/fast/text/orientation-sideways-expected.txt:
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174745 268f45cc-cd09-0410-ab3c-d52691b4dbfc