WebKit-https.git
6 years agoFix layout test that was actually testing incorrect behaviour.
oliver@apple.com [Fri, 8 Nov 2013 19:28:06 +0000 (19:28 +0000)]
Fix layout test that was actually testing incorrect behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MathML] Center of stretched curly bracket not always vertically centered
mrobinson@webkit.org [Fri, 8 Nov 2013 19:27:03 +0000 (19:27 +0000)]
[MathML] Center of stretched curly bracket not always vertically centered
https://bugs.webkit.org/show_bug.cgi?id=123715

Reviewed by Brent Fulgham.

Source/WebCore:

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
handle the case where two glyph pieces abut.
(WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().

LayoutTests:

* TestExpectations: Unskip mo-stretch.html. It was skipped originally,
because MathML is changing rapidly, but we need it to test these changes.
* mathml/presentation/mo-stretch.html: Update to show stretching characteristics
of all stretchable glyphs.
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd WKRemoteObjectRegistry to WKConnection
andersca@apple.com [Fri, 8 Nov 2013 19:10:27 +0000 (19:10 +0000)]
Add WKRemoteObjectRegistry to WKConnection
https://bugs.webkit.org/show_bug.cgi?id=124054

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKConnection.h:
* UIProcess/API/mac/WKConnection.mm:
(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMap.forEach crashes on deleted values
oliver@apple.com [Fri, 8 Nov 2013 18:47:26 +0000 (18:47 +0000)]
Map.forEach crashes on deleted values
https://bugs.webkit.org/show_bug.cgi?id=124017

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

MapData iterator did not consider the case of the first entries
being holes.  To fix this I've refactored iteration so that we
can perform an initialisation increment on construction, whle
retaining the useful assertion in MapData::const_iterator::operator++

* runtime/MapData.h:
(JSC::MapData::const_iterator::operator++):
(JSC::MapData::const_iterator::internalIncrement):
(JSC::MapData::const_iterator::const_iterator):

LayoutTests:

Test case

* js/map-iterate-first-entry-is-a-hole-expected.txt: Added.
* js/map-iterate-first-entry-is-a-hole.html: Added.
* js/script-tests/map-iterate-first-entry-is-a-hole.js: Added.
(set map0):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MSE] Bring SourceBuffer.append up to the most recent spec.
jer.noble@apple.com [Fri, 8 Nov 2013 18:30:29 +0000 (18:30 +0000)]
[MSE] Bring SourceBuffer.append up to the most recent spec.
https://bugs.webkit.org/show_bug.cgi?id=123377

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-append-failed.html

Bring the MediaSource append() implementation up to the current spec.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::appendBufferTimerFired):
* platform/graphics/SourceBufferPrivate.h:
* platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::evictCodedFrames):
(WebCore::MockSourceBufferPrivate::isFull):
* platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

* media/media-source/media-source-append-failed-expected.txt: Added.
* media/media-source/media-source-append-failed.html: Added.
* media/media-source/mock-media-source.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEncode and decode NSURLRequests using NSCoder
andersca@apple.com [Fri, 8 Nov 2013 18:28:06 +0000 (18:28 +0000)]
Encode and decode NSURLRequests using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124051

Reviewed by Sam Weinig.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::archiveAndEncodeObject):
(CoreIPC::decodeAndUnarchiveObject):
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r158883): Fix crashes for ARM architecture.
commit-queue@webkit.org [Fri, 8 Nov 2013 18:25:52 +0000 (18:25 +0000)]
REGRESSION(r158883): Fix crashes for ARM architecture.
https://bugs.webkit.org/show_bug.cgi?id=124038

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

* jit/GPRInfo.h: Remove r11 from the temporary register set, use a free register for
nonPreservedNonReturnGPR and remove obsolete declaration of bucketCounterRegister.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
* jit/JITOperations.cpp: Frame pointer register is r11 for ARM_TRADITIONAL and
r7 for ARM_THUMB2 instead of r5 since r158883.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r158883): Fix crashes for MIPS architecture.
commit-queue@webkit.org [Fri, 8 Nov 2013 18:24:32 +0000 (18:24 +0000)]
REGRESSION(r158883): Fix crashes for MIPS architecture.
https://bugs.webkit.org/show_bug.cgi?id=124044

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

* jit/JITOperations.cpp: Frame pointer register is fp instead of s0 since r158883 for MIPS.
* jit/ThunkGenerators.cpp: Save and restore the new frame pointer register.
(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracks...
jer.noble@apple.com [Fri, 8 Nov 2013 17:55:39 +0000 (17:55 +0000)]
[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange + 26
https://bugs.webkit.org/show_bug.cgi?id=124031

Reviewed by Eric Carlson.

WTF::bind() causes errors when given a bare id pointer as a parameter,
when that parameter is casted to a specific NS type pointer (in this
case, a NSArray*) in order to pass it as a parameter to the bound
function.

Instead of passing around bare id pointers, wrap them in RetainPtr<>
objects before passing them to WTF::bind().

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] JavaScript crash in getHostCallReturnValue.
commit-queue@webkit.org [Fri, 8 Nov 2013 17:12:27 +0000 (17:12 +0000)]
[Win] JavaScript crash in getHostCallReturnValue.
https://bugs.webkit.org/show_bug.cgi?id=124040

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-08
Reviewed by Geoffrey Garen.

* jit/JITOperations.cpp: Update MSVC assembler code in getHostCallReturnValue according to gcc x86 version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Fri, 8 Nov 2013 15:27:09 +0000 (15:27 +0000)]
Unreviewed EFL gardening

Add test expectations for failing tests.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd line layout performance test that exercises more cases
antti@apple.com [Fri, 8 Nov 2013 14:57:51 +0000 (14:57 +0000)]
Add line layout performance test that exercises more cases
https://bugs.webkit.org/show_bug.cgi?id=124041

Reviewed by Anders Carlsson.

The existing line-layout.html covers the most basic left-aligned case only.
Add a test with more coverage for things that are mostly not yet supported by the simple
line layout path:

- centered text
- right aligned text
- justified text
- pre
- white-space:pre-wrap
- text with simple inlines
- text with br

* Layout/line-layout-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add new GTK-specific layout test results for vertical text
commit-queue@webkit.org [Fri, 8 Nov 2013 14:42:22 +0000 (14:42 +0000)]
[GTK] Add new GTK-specific layout test results for vertical text
https://bugs.webkit.org/show_bug.cgi?id=124000

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Rebaselined some expected results for tests that use vertical text.
These tests are now working fine after the fix from Bug 50619.
They have specific results for WebKit2 GTK+ because WebKit1 has a
permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.

* fast/repaint/japanese-rl-selection-clear-expected.txt:
* fast/repaint/japanese-rl-selection-repaint-expected.txt:
* fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* fast/text/international/vertical-text-glyph-test-expected.txt:
* fast/text/justify-ideograph-vertical-expected.txt:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
* platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
* platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Removed.
* platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-clear-expected.txt.
* platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-repaint-expected.txt.
* platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
* platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/fast/text/international/vertical-text-glyph-test-expected.txt.
* platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/fast/text/justify-ideograph-vertical-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTemplated LChar/UChar paths for simple line layout
antti@apple.com [Fri, 8 Nov 2013 12:53:19 +0000 (12:53 +0000)]
Templated LChar/UChar paths for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=124035

Reviewed by Andreas Kling.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):

    Use a templated function to check for illegal characters.

(WebCore::SimpleLineLayout::skipWhitespaces):

    Make a template function.

(WebCore::SimpleLineLayout::textWidth):

    Make a template function plus some argument changes.

(WebCore::SimpleLineLayout::createTextRuns):

    Template function for creating runs while operating with either LChars or UChar.
    Also simplified line breaking and text width measuring logic.

(WebCore::SimpleLineLayout::create):

    Pick the template.

* rendering/break_lines.cpp:
* rendering/break_lines.h:

    Move the implementation to the header (except for the table) so we can use the template
    versions directly.

(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] accessibility/aria-link-supports-press.html
commit-queue@webkit.org [Fri, 8 Nov 2013 12:16:33 +0000 (12:16 +0000)]
[EFL] accessibility/aria-link-supports-press.html
https://bugs.webkit.org/show_bug.cgi?id=111987

Unreviewed EFL gardening, passes after r158913.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08

* platform/efl-wk1/TestExpectations: test is no longer failing.
* platform/efl-wk2/TestExpectations: test is no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[mips] Fix typo (introduced in r158751).
ossy@webkit.org [Fri, 8 Nov 2013 11:26:24 +0000 (11:26 +0000)]
[mips] Fix typo (introduced in r158751).
https://bugs.webkit.org/show_bug.cgi?id=124033.

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Csaba Osztrogonác.

* jit/ThunkGenerators.cpp:
(JSC::callToJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
ossy@webkit.org [Fri, 8 Nov 2013 11:22:04 +0000 (11:22 +0000)]
[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
https://bugs.webkit.org/show_bug.cgi?id=123891

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

Although patchableBranch32 is implemented in MacroAssemblerARM.h, the used implementation
is the generic one in MacroAssembler.h. This patch fixes it and also implements the
patchableJump() function for CPU(ARM_TRADITIONAL). These specific implementations are
needed for this architecture backend to ensure that these jumps can be relinked.

* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::patchableJump):
* jit/GPRInfo.h: Remove static_cast that are generating warnings in debug builds.
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: [ATK] <span> elements exposed through ATK when not needed
mario@webkit.org [Fri, 8 Nov 2013 10:55:38 +0000 (10:55 +0000)]
AX: [ATK] <span> elements exposed through ATK when not needed
https://bugs.webkit.org/show_bug.cgi?id=123885

Reviewed by Chris Fleizach.

Source/WebCore:

As per SVN r158195, the way it's decided whether <span> elements
should be ignored or not has slightly changed, causing that the
GTK/EFL ports expose them in cases that they should be ignored,
such as for text elements that neither are focusable (e.g. by
explicitly setting tabindex) nor have a meaningful accessible name
suggesting they should be exposed.

As a result, the flattening that ATK based ports normally do for
this kind of elements (by folding them into their parents) do not
work correctly anymore, making two tests to fail:

    platform/gtk/accessibility/spans-paragraphs-and-divs.html
    platform/gtk/accessibility/spans.html

This patch encapsulates the part of the logic that affects this in
the computeAccessibilityIsIgnored() method, placing it in a
new method of AccessibilityObject that we can call from ATK's
accessibilityPlatformIncludesObject() to ensure we hide those
<span> elements when they don't fulfill those requirements.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion):
New virtual method encapsulating part of the logic from the function
that computes whether accessibility should be ignored or not.
* accessibility/AccessibilityObject.h:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion):
Override of the new method adding additional checks, as extracted from
the original bits in computeAccessibilityIsIgnored().
* accessibility/AccessibilityNodeObject.h:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Use the newly added function where we had the original code before.

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make sure <span> elements are ignored if they are not focusable
and they don't have a meaningful accessible name.

LayoutTests:

Removed failure expectations for tests now passing.

* platform/gtk/TestExpectations: Removed expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] accessibility/aria-link-supports-press.html is failing
commit-queue@webkit.org [Fri, 8 Nov 2013 10:24:39 +0000 (10:24 +0000)]
[GTK] accessibility/aria-link-supports-press.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98355

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Tools:

Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectation.

* platform/gtk/TestExpectations: test is no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[JHBUILD] Jhbuild Makefile build bug workaround
commit-queue@webkit.org [Fri, 8 Nov 2013 09:43:44 +0000 (09:43 +0000)]
[JHBUILD] Jhbuild Makefile build bug workaround
https://bugs.webkit.org/show_bug.cgi?id=123971

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-08
Reviewed by Ryosuke Niwa.

After Jhbuild repository is cloned (for instance when you use
Tools/Scripts/update-webkitefl-libs) it is built from sources.
If you have GREP_OPTIONS grep env variable set (for instance
GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
uses shell grep. For specific GREP_OPTIONS grep output will be
different than expected one by Jhbuild and there is an error
with Jhbuild build. Jhbuild will not be built and then WebKit
source also will not be built. This patch is a workaround to this
issue. It disables GREP_OPTIONS for Jhbuild build time.

* jhbuild/jhbuild-wrapper:
(install_jhbuild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd back expectation for test that went missing in r158813.
akling@apple.com [Fri, 8 Nov 2013 09:06:21 +0000 (09:06 +0000)]
Add back expectation for test that went missing in r158813.

* svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
carlosgc@webkit.org [Fri, 8 Nov 2013 08:16:08 +0000 (08:16 +0000)]
[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
https://bugs.webkit.org/show_bug.cgi?id=123990

Reviewed by Philippe Normand.

Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to the
symbols files.

* bindings/gobject/WebKitDOMEventTarget.symbols:
* bindings/gobject/webkitdom.symbols:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Ignore deprecated macros when generating gtk-doc
carlosgc@webkit.org [Fri, 8 Nov 2013 08:14:08 +0000 (08:14 +0000)]
[GTK] Ignore deprecated macros when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=123988

Reviewed by Philippe Normand.

* gtk/generate-gtkdoc:
(get_common_options): Ignore also WEBKIT_DEPRECATED and
WEBKIT_DEPRECATED_FOR decorators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Pass the library namespace to gtkdoc-mkdb
carlosgc@webkit.org [Fri, 8 Nov 2013 08:12:09 +0000 (08:12 +0000)]
[GTK] Pass the library namespace to gtkdoc-mkdb
https://bugs.webkit.org/show_bug.cgi?id=123900

Reviewed by Martin Robinson.

This fixes the generation of the index of symbols in the API
documentation.

* gtk/generate-gtkdoc:
(get_webkit2_options): Define namespace as WebKit.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Define namespace as WebKitDOM.
* gtk/gtkdoc.py:
(GTKDoc.__init__): Add namespace option.
(GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
carlosgc@webkit.org [Fri, 8 Nov 2013 08:09:23 +0000 (08:09 +0000)]
[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=123899

Reviewed by Martin Robinson.

Do not include deprecated API when compiling with
WEBKIT_DISABLE_DEPRECATED option.

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnhance SQL journal_mode setting code to be less likely to log an error.
beidson@apple.com [Fri, 8 Nov 2013 06:08:41 +0000 (06:08 +0000)]
Enhance SQL journal_mode setting code to be less likely to log an error.
<rdar://problem/15418577> and https://bugs.webkit.org/show_bug.cgi?id=124018

Reviewed by Anders Carlsson.

Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned.
Change the code to handle that.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open): Save the statement result value, and accept SQLITE_OK as a non-error condition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Layout tests with vertical texts need to be rebaselined
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 05:52:07 +0000 (05:52 +0000)]
[EFL] Layout tests with vertical texts need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=123985

Unreviewed, EFL port needs to do rebaseline since r158848.

* platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/efl/TestExpectations:
* platform/efl/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
* platform/efl/fast/dynamic/text-combine-expected.txt:
* platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
* platform/efl/fast/text/decorations-with-text-combine-expected.txt:
* platform/efl/fast/text/emphasis-combined-text-expected.txt:
* platform/efl/fast/text/emphasis-vertical-expected.txt:
* platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/efl/fast/text/international/text-spliced-font-expected.txt:
* platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
* platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Added.
* platform/efl/fast/text/orientation-sideways-expected.txt:
* platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
* platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/efl/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-text-expected.txt:
* platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/efl/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
* platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
* platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate an out-dated ASSERT in IconDatabase code.
beidson@apple.com [Fri, 8 Nov 2013 05:40:19 +0000 (05:40 +0000)]
Update an out-dated ASSERT in IconDatabase code.
<rdar://problem/15171118> and https://bugs.webkit.org/show_bug.cgi?id=124030.

Reviewed by Andreas Kling.

With the asynchronous interfaces that have been added and the support for WK2 that has been added,
this ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL): Update an invalid ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderSVGResource helpers should take RenderStyle by const reference.
akling@apple.com [Fri, 8 Nov 2013 05:24:20 +0000 (05:24 +0000)]
RenderSVGResource helpers should take RenderStyle by const reference.
<https://webkit.org/b/124029>

Take const RenderStyle& instead of RenderStyle* in a few more places
so we can get rid of some ampersands and assertions.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 05:21:32 +0000 (05:21 +0000)]
[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
https://bugs.webkit.org/show_bug.cgi?id=123984

Reviewed by Mario Sanchez Prada.

As a step to let static_cast<> use TYPE_CASTS_BASE, AccessibilityTableRow|Column|Cell use
ACCESSIBILITY_OBJECT_TYPE_CASTS which can support more helper functions rather than manual
static_cast<>. This change will help to detect bad type casts further.

No new tests, no behavior changes.

* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cellForColumnAndRow):
* accessibility/AccessibilityTableCell.h:
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
* accessibility/AccessibilityTableRow.h:
* accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(cellAtIndex):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableCellParent]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of the regT* definitions in JSInterfaceJIT.h.
mark.lam@apple.com [Fri, 8 Nov 2013 04:05:27 +0000 (04:05 +0000)]
Get rid of the regT* definitions in JSInterfaceJIT.h.
https://bugs.webkit.org/show_bug.cgi?id=123806.

Reviewed by Geoffrey Garen.

JSInterfaceJIT now inherits from GPRInfo and FPRInfo, and relies on them
to provide all the register definitions.

* jit/GPRInfo.h:
(JSC::GPRInfo::toArgumentRegister):
* jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompile):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_loop_hint):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
* jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
* jit/ThunkGenerators.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r154375): Image is oriented incorrectly
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 03:55:30 +0000 (03:55 +0000)]
REGRESSION (r154375): Image is oriented incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123831

Reviewed by Antonio Gomes.

r154375 made that shouldRespectImageOrientation() isn't used by drawImage().
It causes an image isn't oriented correctly. This patch sets shouldRespectImageOrientation()
value by default.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r158846.
gyuyoung.kim@samsung.com [Fri, 8 Nov 2013 03:54:46 +0000 (03:54 +0000)]
Unreviewed, rolling out r158846.
http://trac.webkit.org/changeset/158846

r158846 was duplicating gardening against r158837.

* platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
* platform/efl/http/tests/media/video-cookie-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
* platform/efl/media/context-menu-actions-expected.txt: Removed.
* platform/efl/media/media-can-play-flac-audio-expected.txt: Removed.
* platform/efl/media/media-can-play-webm-expected.txt: Removed.
* platform/efl/media/media-volume-slider-rendered-below-expected.txt: Removed.
* platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Removed.
* platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Removed.
* platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Removed.
* platform/efl/media/track/track-cue-mutable-text-expected.txt: Removed.
* platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Removed.
* platform/efl/media/track/track-language-preference-expected.txt: Removed.
* platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Removed.
* platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Removed.
* platform/efl/media/video-controls-fullscreen-volume-expected.txt: Removed.
* platform/efl/media/video-controls-toggling-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
hmuller@adobe.com [Fri, 8 Nov 2013 03:50:52 +0000 (03:50 +0000)]
[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123934

Reviewed by Andreas Kling.

Source/WebCore:

RasterShapeIntervals::getExcludedIntervals() was returning an empty
list when the line overlapped any vertical gap in the image. This short-circuit
had been mistakenly copied from getIncludedIntervals(), where it makes sense.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html

* rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::getExcludedIntervals):

LayoutTests:

* fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake contents layer borders more visible
simon.fraser@apple.com [Fri, 8 Nov 2013 03:07:41 +0000 (03:07 +0000)]
Make contents layer borders more visible
https://bugs.webkit.org/show_bug.cgi?id=124025

Reviewed by Tim Horton.

Layer borders for contents layers are impossible to see when the
contentsLayer has the same bounds as its parent; make the contents
layer border 4px thick to make it more visible.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setupContentsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize baselines: svg/filters
akling@apple.com [Fri, 8 Nov 2013 02:57:58 +0000 (02:57 +0000)]
Optimize baselines: svg/filters

Unreviewed; run "webkit-patch optimize-baselines svg/filters"

* platform/gtk/svg/filters/animate-fill-expected.png: Removed.
* platform/gtk/svg/filters/feColorMatrix-default-type-expected.png: Removed.
* platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Removed.
* platform/gtk/svg/filters/feColorMatrix-values-expected.png: Removed.
* platform/gtk/svg/filters/feComposite-expected.txt: Removed.
* platform/gtk/svg/filters/feDisplacementMap-expected.txt: Removed.
* platform/gtk/svg/filters/feDropShadow-subregion-expected.png: Removed.
* platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.png: Removed.
* platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
* platform/gtk/svg/filters/feGaussianBlur-subregion-expected.png: Removed.
* platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.png: Removed.
* platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
* platform/gtk/svg/filters/feImage-change-target-id-expected.png: Removed.
* platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
* platform/gtk/svg/filters/feImage-remove-target-expected.png: Removed.
* platform/gtk/svg/filters/feLighting-crash-expected.png: Removed.
* platform/gtk/svg/filters/feMerge-wrong-input-expected.png: Removed.
* platform/gtk/svg/filters/filter-empty-g-expected.png: Removed.
* platform/gtk/svg/filters/filter-hidden-content-expected.txt: Removed.
* platform/gtk/svg/filters/filter-on-filter-for-text-expected.png: Removed.
* platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt: Removed.
* platform/gtk/svg/filters/filter-on-tspan-expected.txt: Removed.
* platform/gtk/svg/filters/filter-refresh-expected.png: Removed.
* platform/gtk/svg/filters/filter-rounding-issues-expected.png: Removed.
* platform/gtk/svg/filters/filter-width-update-expected.txt: Removed.
* platform/gtk/svg/filters/filterRes-expected.txt: Removed.
* platform/gtk/svg/filters/filterRes2-expected.png: Removed.
* platform/gtk/svg/filters/filteredImage-expected.png: Removed.
* platform/gtk/svg/filters/sourceAlpha-expected.png: Removed.
* platform/gtk/svg/filters/sourceAlpha-expected.txt: Removed.
* platform/mac/svg/filters/feDisplacementMap-expected.txt: Removed.
* platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
* platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
* platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
* platform/mac/svg/filters/filter-hidden-content-expected.txt: Removed.
* platform/mac/svg/filters/filterRes-expected.txt: Removed.
* platform/win-future/svg/filters/feImage-reference-svg-primitive-expected.png: Renamed from LayoutTests/svg/filters/feImage-reference-svg-primitive-expected.png.
* svg/filters/animate-fill-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/animate-fill-expected.png.
* svg/filters/feColorMatrix-default-type-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-default-type-expected.png.
* svg/filters/feColorMatrix-offset-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-offset-expected.png.
* svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-values-expected.png.
* svg/filters/feComposite-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feComposite-expected.txt.
* svg/filters/feDisplacementMap-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDisplacementMap-expected.txt.
* svg/filters/feDropShadow-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-subregion-expected.png.
* svg/filters/feDropShadow-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png.
* svg/filters/feDropShadow-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt.
* svg/filters/feGaussianBlur-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-subregion-expected.png.
* svg/filters/feGaussianBlur-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png.
* svg/filters/feGaussianBlur-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt.
* svg/filters/feImage-change-target-id-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-change-target-id-expected.png.
* svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt.
* svg/filters/feImage-remove-target-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-remove-target-expected.png.
* svg/filters/feLighting-crash-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feLighting-crash-expected.png.
* svg/filters/feMerge-wrong-input-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feMerge-wrong-input-expected.png.
* svg/filters/filter-empty-g-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-empty-g-expected.png.
* svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-hidden-content-expected.txt.
* svg/filters/filter-on-filter-for-text-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.png.
* svg/filters/filter-on-filter-for-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.txt.
* svg/filters/filter-on-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-tspan-expected.txt.
* svg/filters/filter-refresh-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-refresh-expected.png.
* svg/filters/filter-rounding-issues-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-rounding-issues-expected.png.
* svg/filters/filter-width-update-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-width-update-expected.txt.
* svg/filters/filterRes-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filterRes-expected.txt.
* svg/filters/filterRes2-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filterRes2-expected.png.
* svg/filters/filteredImage-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filteredImage-expected.png.
* svg/filters/sourceAlpha-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.png.
* svg/filters/sourceAlpha-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEncode and decode NSURLResponse objects using NSCoder
andersca@apple.com [Fri, 8 Nov 2013 02:47:20 +0000 (02:47 +0000)]
Encode and decode NSURLResponse objects using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124028

Reviewed by Andreas Kling.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInlineFlowBox always has a RenderBoxModelObject, take advantage.
akling@apple.com [Fri, 8 Nov 2013 02:43:22 +0000 (02:43 +0000)]
InlineFlowBox always has a RenderBoxModelObject, take advantage.
<https://webkit.org/b/124024>

Since InlineFlowBox already has the branch-less renderer() returning
a RenderBoxModelObject&, avoid using InlineBox::boxModelObject()
wherever we have a tightly-typed box. One branch disappears from
every call site.

Deleted boxModelObject() on InlineFlowBox to prevent new code from
calling the less efficient function.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCTTE: Scrolling tree nodes should always have a ScrollingTree&.
akling@apple.com [Fri, 8 Nov 2013 02:41:19 +0000 (02:41 +0000)]
CTTE: Scrolling tree nodes should always have a ScrollingTree&.
<https://webkit.org/b/124022>

Let ScrollingTreeNode and subclasses store the backpointer to the
tree as a ScrollingTree& reference.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove m_destinationID to MessageDecoder
andersca@apple.com [Fri, 8 Nov 2013 02:22:40 +0000 (02:22 +0000)]
Move m_destinationID to MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=124026

Reviewed by Andreas Kling.

* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/MessageDecoder.h:
(CoreIPC::MessageDecoder::destinationID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL should support NewArray
fpizlo@apple.com [Fri, 8 Nov 2013 01:55:49 +0000 (01:55 +0000)]
FTL should support NewArray
https://bugs.webkit.org/show_bug.cgi?id=124010

Reviewed by Oliver Hunt.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::allocateBasicStorageAndGetEnd):
(JSC::FTL::LowerDFGToLLVM::ArrayValues::ArrayValues):
(JSC::FTL::LowerDFGToLLVM::allocateJSArray):
* ftl/FTLOutput.h:
(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::storeDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of the out-of-line memory attachment type
andersca@apple.com [Fri, 8 Nov 2013 01:54:28 +0000 (01:54 +0000)]
Get rid of the out-of-line memory attachment type
https://bugs.webkit.org/show_bug.cgi?id=124023

Reviewed by Andreas Kling.

We're only using out-of-line memory for when the message body is too big, so
isolate that code in Connection and get rid of the out of line attachment type.

* Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::Attachment):
* Platform/CoreIPC/Attachment.h:
(CoreIPC::Attachment::port):
(CoreIPC::Attachment::disposition):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createMessageDecoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLots of layers get solid color but transparent contents layers now
simon.fraser@apple.com [Fri, 8 Nov 2013 01:42:59 +0000 (01:42 +0000)]
Lots of layers get solid color but transparent contents layers now
https://bugs.webkit.org/show_bug.cgi?id=123537

Source/WebCore:

Reviewed by Tim Horton.

We call rendererBackgroundColor() to determine the layer's background color,
but on most elements this returns the transparent color (a valid color).
This caused us to allocate a contentsLayer, and use the transparent color as its
backgroundColor, which was wasteful.

Fix by only making a background-color layer if the color is not transparent (zero alpha).

Also avoid making a new contents layer on every color change, and make sure that
we don't do implicit animations for backgroundColor, and some other properties
that were omitted by mistake.

Layer tree dumps don't dump content layers, so no way to test easily.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(nullActionsDictionary):

Source/WebKit2:

Reviewed by Tim Horton.

Add some properties to the list of things not to implicitly animate.

* Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::disableActionsForLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Windows WebKit makefile fixes.
roger_fong@apple.com [Fri, 8 Nov 2013 01:07:37 +0000 (01:07 +0000)]
Unreviewed. Windows WebKit makefile fixes.

No need to copy over WebKit.resources.

* WebKit.vcxproj/WebKit.make:
* WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove a PLATFORM(IOS) from WebKit Private Header
commit-queue@webkit.org [Thu, 7 Nov 2013 23:46:21 +0000 (23:46 +0000)]
Remove a PLATFORM(IOS) from WebKit Private Header
https://bugs.webkit.org/show_bug.cgi?id=124014

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-07
Reviewed by Timothy Hatcher.

Source/WebKit/ios:

* WebKit.iOS.exp:

Source/WebKit/mac:

Make the previously iOS only WebInspectorDidStartSearchingForNode
and WebInspectorDidStopSearchingForNode notifications non iOS specific.

* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didSetSearchingForNode):
* WebInspector/WebInspector.h:
* WebInspector/WebInspector.mm:
* WebKit.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange CallFrameRegister to architected frame pointer register
msaboff@apple.com [Thu, 7 Nov 2013 23:45:56 +0000 (23:45 +0000)]
Change CallFrameRegister to architected frame pointer register
https://bugs.webkit.org/show_bug.cgi?id=123956

Reviewed by Geoffrey Garen.

Changed X86 and ARM variants as well as MIPS to use their respective architected
frame pointer registers.  The freed up callFrameRegisteris are made available to
the DFG register allocator.  Modified the FTL OSR exit compiler to use a temporary
register as a stand in for the destination callFrameRegister since the FTL frame
pointer register is needed to extract values from the FTL stack.

Reviewed by Geoffrey Garen.

* assembler/ARMAssembler.h:
* assembler/ARMv7Assembler.h:
* assembler/MacroAssemblerMIPS.h:
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::addressFor):
* jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
* jit/JITOperations.cpp:
* jit/JSInterfaceJIT.h:
* jit/ThunkGenerators.cpp:
(JSC::callToJavaScript):
* offlineasm/arm.rb:
* offlineasm/arm64.rb:
* offlineasm/mips.rb:
* offlineasm/x86.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: CSS Regions: Use a Map object to store the ContentFlows
achicu@adobe.com [Thu, 7 Nov 2013 23:34:47 +0000 (23:34 +0000)]
Web Inspector: CSS Regions: Use a Map object to store the ContentFlows
https://bugs.webkit.org/show_bug.cgi?id=124015

Reviewed by Joseph Pecoraro.

Changed the Object hashmap to a Map based hashmap when storing the flows in DOMTreeManager.

* UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
(WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove more dead code
andersca@apple.com [Thu, 7 Nov 2013 23:31:08 +0000 (23:31 +0000)]
Remove more dead code
https://bugs.webkit.org/show_bug.cgi?id=124016

Reviewed by Beth Dakin.

We're always layer backed now so we never scroll using the PageClient.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::canScrollView):
(WebKit::PageClientImpl::scrollView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix up some sidebar switching details to make selections persist better.
timothy@apple.com [Thu, 7 Nov 2013 23:26:35 +0000 (23:26 +0000)]
Fix up some sidebar switching details to make selections persist better.

Translate represented objects between sidebars so the same item can be reselected
as you switch between frames and main reources. Also fix some null checks that are
needed on selectedSidebarPanel.

https://bugs.webkit.org/show_bug.cgi?id=124001

Reviewed by Joseph Pecoraro.

* UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype.treeElementForRepresentedObject): Added. Translate a Frame
representedObject into a main resource representedObject.
* UserInterface/Main.js:
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar): Null check selectedSidebarPanel.
(WebInspector._updateNavigationSidebarForCurrentContentView): Fix a logic error to match other code.
allowedNavigationSidebarPanels.length needs to have a length before using contains.
(WebInspector._contentBrowserCurrentContentViewDidChange): Null check selectedSidebarPanel.
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject): Translate a main resource
representedObject into a Frame representedObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDOMTokenList::add can add duplicated values if arguments had duplicated values
rniwa@webkit.org [Thu, 7 Nov 2013 23:16:26 +0000 (23:16 +0000)]
DOMTokenList::add can add duplicated values if arguments had duplicated values
https://bugs.webkit.org/show_bug.cgi?id=123962

Reviewed by Benjamin Poulain.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/bd3822ad4ae3fc5d8f89f433a7bf04f697334305

In case we do element.classList.add('a', 'a') we need to ensure that we do not add the same token twice.
See http://dom.spec.whatwg.org/#dom-domtokenlist-add

* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::add): Make sure filtered tokens are unique among themselves.

LayoutTests:

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModify email order list for James Craig so his primary email is first.
cfleizach@apple.com [Thu, 7 Nov 2013 23:01:31 +0000 (23:01 +0000)]
Modify email order list for James Craig so his primary email is first.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReproducible crash when using Map (affects Web Inspector)
oliver@apple.com [Thu, 7 Nov 2013 22:19:58 +0000 (22:19 +0000)]
Reproducible crash when using Map (affects Web Inspector)
https://bugs.webkit.org/show_bug.cgi?id=123940

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Trivial fix.  Once again we get bitten by attempting to be clever when
growing while adding entries to indexing maps.

Now we simply do a find(), and then add() _after_ we've ensured there is
sufficient space in the MapData list.

* runtime/MapData.cpp:
(JSC::MapData::add):

LayoutTests:

Add testcases

* js/map-grow-with-holes-expected.txt: Added.
* js/map-grow-with-holes.html: Added.
* js/script-tests/map-grow-with-holes.js: Added.
(get map):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove npr.org specific hack in HTMLMediaElement
eric.carlson@apple.com [Thu, 7 Nov 2013 22:08:21 +0000 (22:08 +0000)]
Remove npr.org specific hack in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=123859

Reviewed by Jer Noble.

Remove the site specific hack added in r57820, it is no longer necessary.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_dispatchingCanPlayEvent.
(HTMLMediaElement::play): Don't special case npr.org.
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempt to fix the 32-bit build. Virtual thunks seem to have different
simon.fraser@apple.com [Thu, 7 Nov 2013 21:56:17 +0000 (21:56 +0000)]
Attempt to fix the 32-bit build. Virtual thunks seem to have different
symbol names between 32- and 64-bit.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't repaint the view when the web process crashes
andersca@apple.com [Thu, 7 Nov 2013 21:54:36 +0000 (21:54 +0000)]
Don't repaint the view when the web process crashes
https://bugs.webkit.org/show_bug.cgi?id=124013

Reviewed by Dan Bernstein.

It's up to each individual port to decide whether the view should be repainted when the web process crashes.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Thu, 7 Nov 2013 21:51:49 +0000 (21:51 +0000)]
Unreviewed EFL gardening

Remove failure test expectations from passing tests.

* platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Removed.
* platform/efl/TestExpectations:
* platform/efl/fast/repaint/caret-with-transformation-expected.png: Added.
* platform/efl/fast/repaint/caret-with-transformation-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in HTMLMediaElement::contextDestroyed
rniwa@webkit.org [Thu, 7 Nov 2013 21:47:32 +0000 (21:47 +0000)]
Crash in HTMLMediaElement::contextDestroyed
https://bugs.webkit.org/show_bug.cgi?id=123963

Reviewed by Eric Carlson.

Merge https://chromium.googlesource.com/chromium/blink/+/177999cdb34b707465670f0feff723922939f278

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Crash at com.apple.WebCore: -[WebCoreAVFMovieObserver observeValueForKeyPath...
jer.noble@apple.com [Thu, 7 Nov 2013 21:43:22 +0000 (21:43 +0000)]
[Mac] Crash at com.apple.WebCore: -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:] + 2084
https://bugs.webkit.org/show_bug.cgi?id=124012

Reviewed by Eric Carlson.

The value of the 'duration' key is a NSConcreteValue wrapping a CMTime, not a NSNumber.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash when submitting form in a document with null encoding
rniwa@webkit.org [Thu, 7 Nov 2013 21:39:49 +0000 (21:39 +0000)]
Crash when submitting form in a document with null encoding
https://bugs.webkit.org/show_bug.cgi?id=123975

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/bba01a7fff09e3053ada96ababac2a6e4261fe5f

The CString object which is passed to normalizeLineEndingsToCRLF() can be
a null string. It is created in FormDataList::appendString(), and it
produces a null CString if FormDataList::m_encoding is a null encoding.

Test: fast/forms/form-submit-in-image-document.html

* platform/text/LineEnding.cpp:
(internalNormalizeLineEndingsToCRLF):

LayoutTests:

* fast/forms/form-submit-in-image-document-expected.txt: Added.
* fast/forms/form-submit-in-image-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse std::function for all policy continuation functions
andersca@apple.com [Thu, 7 Nov 2013 21:37:36 +0000 (21:37 +0000)]
Use std::function for all policy continuation functions
https://bugs.webkit.org/show_bug.cgi?id=124011

Reviewed by Sam Weinig.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::responseReceived):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadPostRequest):
* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::clear):
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::clearRequest):
(WebCore::PolicyCallback::cancel):
* loader/PolicyCallback.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):
* loader/PolicyChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Gtk] Disable LTO when building cairo
commit-queue@webkit.org [Thu, 7 Nov 2013 21:30:58 +0000 (21:30 +0000)]
[Gtk] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123954

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.

Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.
- See: https://bugs.freedesktop.org/show_bug.cgi?id=60852

With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse SQLite journal mode WAL (WriteAheadLogging)
beidson@apple.com [Thu, 7 Nov 2013 20:49:56 +0000 (20:49 +0000)]
Use SQLite journal mode WAL (WriteAheadLogging)
https://bugs.webkit.org/show_bug.cgi?id=124009

Reviewed by Anders Carlsson.

WriteAheadLogging journalling is better than the traditional rollback model.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open): Use a PRAGMA to set journal_mode to WAL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Fix in-band track tests after r158743
commit-queue@webkit.org [Thu, 7 Nov 2013 20:26:16 +0000 (20:26 +0000)]
[GStreamer] Fix in-band track tests after r158743
https://bugs.webkit.org/show_bug.cgi?id=124007

Add a new line to a bunch of tests to match changes made in r158743.

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Eric Carlson.

* media/track/audio/audio-track-mkv-vorbis-language-expected.txt:
* media/track/in-band/track-in-band-kate-ogg-addtrack-expected.txt:
* media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt:
* media/track/in-band/track-in-band-kate-ogg-kind-expected.txt:
* media/track/in-band/track-in-band-kate-ogg-language-expected.txt:
* media/track/in-band/track-in-band-kate-ogg-mode-expected.txt:
* media/track/in-band/track-in-band-kate-ogg-style-expected.txt:
* media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt:
* media/track/in-band/track-in-band-mkv-chapters-expected.txt:
* media/track/in-band/track-in-band-srt-mkv-addtrack-expected.txt:
* media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt:
* media/track/in-band/track-in-band-srt-mkv-kind-expected.txt:
* media/track/in-band/track-in-band-srt-mkv-language-expected.txt:
* media/track/in-band/track-in-band-srt-mkv-mode-expected.txt:
* media/track/in-band/track-in-band-srt-mkv-style-expected.txt:
* media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt:
* media/track/video/video-track-mkv-theora-language-expected.txt:
* media/track/video/video-track-mkv-theora-selected-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReport error on unknown template class usage.
commit-queue@webkit.org [Thu, 7 Nov 2013 20:19:13 +0000 (20:19 +0000)]
Report error on unknown template class usage.
https://bugs.webkit.org/show_bug.cgi?id=123096

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-07
Reviewed by Darin Adler.

Report error when template class is not found in the dictionary.

* Scripts/webkit2/messages.py:
(class_template_headers):
(class_template_headers.template):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCosmetic: rename xxxId to xxxID for ScriptId, SourceId, and BreakpointId.
mark.lam@apple.com [Thu, 7 Nov 2013 20:17:13 +0000 (20:17 +0000)]
Cosmetic: rename xxxId to xxxID for ScriptId, SourceId, and BreakpointId.
https://bugs.webkit.org/show_bug.cgi?id=123945.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):
* debugger/DebuggerCallFrame.h:

Source/WebCore:

No new tests.

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionDetails):
* bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::sourceID):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::pauseIfNeeded):
* bindings/js/ScriptDebugServer.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::compileScript):
(WebCore::InspectorDebuggerAgent::runScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):
(WebCore::InspectorDebuggerAgent::reset):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
* inspector/InspectorInstrumentation.h:
* inspector/ScriptDebugListener.h:

Source/WebKit/mac:

* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid invalid cairo matrix when drawing surfaces too small
commit-queue@webkit.org [Thu, 7 Nov 2013 20:11:13 +0000 (20:11 +0000)]
Avoid invalid cairo matrix when drawing surfaces too small
https://bugs.webkit.org/show_bug.cgi?id=123810

Drawing surfaces too small makes inverse matrix with values too big,
when this happen, cairo context is not valid anymore and it stops to draw anything.

Patch by Cidorvan Leite <cidorvan.leite@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.

Test: fast/canvas/drawImage-with-small-values.html

* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimple line layout crashes with SVG fonts
antti@apple.com [Thu, 7 Nov 2013 19:45:13 +0000 (19:45 +0000)]
Simple line layout crashes with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=124002

Source/WebCore:

Reviewed by Simon Fraser.

Don't use simple line layout for flows using SVG fonts. They crash if kerning is enabled.

Test: fast/text/svg-font-simple-line-crash.html

* platform/graphics/Font.h:
(WebCore::Font::isSVGFont):

    Add isSVGFont() so callers don't need to go via primaryFont().

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::constructTextRun):
* rendering/RenderBlock.cpp:
(WebCore::constructTextRunInternal):
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

    Disallow SVG fonts.

* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):
(WebCore::SVGTextMetrics::SVGTextMetrics):
* rendering/svg/SVGTextRunRenderingContext.h:

    Get rid of the abstract textRunNeedsRenderingContext in favor of just testing isSVGFont().

LayoutTests:

Reviewed by Simon Fraser.

* fast/text/svg-font-simple-line-crash-expected.txt: Added.
* fast/text/svg-font-simple-line-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow customization of the contentsScale of TileController tiles
simon.fraser@apple.com [Thu, 7 Nov 2013 19:34:01 +0000 (19:34 +0000)]
Allow customization of the contentsScale of TileController tiles
https://bugs.webkit.org/show_bug.cgi?id=124004

Reviewed by Tim Horton.

On some platorms, zooming out on pages with TiledBacking compositing
layers can cause very high memory use, because the TiledBacking retains
the original page scale while the zoom is in flight, but can be asked
to cover a large area.

Make it possible to reduce memory use in this case by allowing RenderLayerCompositor
to provide an additional scale factor for newly created tiles. Platforms can
then customize this to create low-res tiles when necessary.

* WebCore.exp.in:
* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::contentsScaleMultiplierForNewTiles):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerContentsScaleMultiplierForNewTiles):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerContentsScaleMultiplierForNewTiles):
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::setScale):
(WebCore::TileController::createTileLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentsScaleMultiplierForNewTiles):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoreturnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
msaboff@apple.com [Thu, 7 Nov 2013 19:33:17 +0000 (19:33 +0000)]
returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
https://bugs.webkit.org/show_bug.cgi?id=124006

Rubber stamped by Mark Hahnenberg.

Changed the push() calls to pop().

* jit/ThunkGenerators.cpp:
(JSC::returnFromJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC)
msaboff@apple.com [Thu, 7 Nov 2013 19:23:12 +0000 (19:23 +0000)]
Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC)
https://bugs.webkit.org/show_bug.cgi?id=123998

Reviewed by Mark Lam.

Dead code removal.  Passing esp as the first "C" argument to a JavaScript
function is no longer needed.

* jit/ThunkGenerators.cpp:
(JSC::callToJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Win build fix after r158855; wrap shapeInfoForFloat() in an ENABLE(CSS_SHA...
jer.noble@apple.com [Thu, 7 Nov 2013 19:04:53 +0000 (19:04 +0000)]
Unreviewed Win build fix after r158855; wrap shapeInfoForFloat() in an ENABLE(CSS_SHAPES) guard.

* rendering/FloatingObjects.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefactor logical left/right offset for line methods
bjonesbe@adobe.com [Thu, 7 Nov 2013 18:11:43 +0000 (18:11 +0000)]
Refactor logical left/right offset for line methods
https://bugs.webkit.org/show_bug.cgi?id=123898

Reviewed by David Hyatt.

Simplify the logical left/right offset for line methods and their
implementation, including the ComputeFloatOffsetAdapter. This also
reduces the number of line offset methods in RenderBlock.

No new tests, no behavior change.

* rendering/FloatingObjects.cpp:
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetAdapter::offset): Add a method to return
    the offset instead of using a confusing out parameter.
(WebCore::::shapeOffset): Method to return the offset modified by the
    shape delta. Moving the computation to this method allowed for
    simplification of the users of ComputeFloatOffsetAdapter.
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat): Added this
    method so that ShapeOutsideFloatOffsetMode isn't needed. Returns the
    offset based on the float margin box.
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat): Ditto.
(WebCore::FloatingObjects::logicalLeftOffset): This now only returns
    the offset based on the shape's contour.
(WebCore::FloatingObjects::logicalRightOffset): Ditto.
(WebCore::::heightRemaining): Rename to properly follow the getter
    naming convention.
* rendering/FloatingObjects.h:
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Update to remove
    use of ShapeOutsideFloatOffsetMode and heightRemaining.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalRightFloatOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine): Ditto.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::logicalLeftOffsetForPositioningFloat):
    Positioning a float is the only case where the float margin box
    should be used, and also the only case where heightRemaining is
    needed. This handles that case.
(WebCore::RenderBlockFlow::logicalRightOffsetForPositioningFloat):
    Ditto.
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat): Update to
    use logical(Left|Right)OffsetForPositioningFloatOnLine.
(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine): Update to
    remove use for ShapeOutsideFloatOffsetMode and heightRemaining.
(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine): Ditto.
* rendering/RenderBlockFlow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: CSS Regions: Removing a content node of a ContentFlow from the DOM...
achicu@adobe.com [Thu, 7 Nov 2013 18:05:55 +0000 (18:05 +0000)]
Web Inspector: CSS Regions: Removing a content node of a ContentFlow from the DOM will send a 0 nodeId
https://bugs.webkit.org/show_bug.cgi?id=123577

Source/WebCore:

Reviewed by Timothy Hatcher.

Test: inspector-protocol/model/content-flow-content-removal.html

Do not send unregister events for the content nodes of a flow when the element is not part of the DOM
anymore. We already send an unbind event, so the inspector is already notified that the node was removed.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):

Source/WebInspectorUI:

Reviewed by  Timothy Hatcher.

Fixed the content node removal from the content flow.

* UserInterface/ContentFlowTreeContentView.js:
* UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload): Registered all the content nodes
in the _contentNodesToFlowsMap.
(WebInspector.DOMTreeManager.prototype._unbind): Added call to _removeContentNodeFromFlowIfNeeded.
(WebInspector.DOMTreeManager.prototype._removeContentNodeFromFlowIfNeeded): Called from _unbind to check
and remove a node from it's parent content flow if needed.
(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):

LayoutTests:

Reviewed by Timothy Hatcher.

Added test to check that the notification that an element was removed from the ContentFlow is handled
correctly in the WebInspector even if the element is not part of the DOM anymore.

* inspector-protocol/model/content-flow-content-removal-expected.txt: Added.
* inspector-protocol/model/content-flow-content-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MSE] Add mock MediaSource classes for testing.
jer.noble@apple.com [Thu, 7 Nov 2013 17:58:57 +0000 (17:58 +0000)]
[MSE] Add mock MediaSource classes for testing.
https://bugs.webkit.org/show_bug.cgi?id=123322

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/media-source/media-source-addsourcebuffer.html
       media/media-source/media-source-append-buffer.html
       media/media-source/media-source-canplaythrough.html
       media/media-source/media-source-closed.html
       media/media-source/media-source-play.html
       media/media-source/media-source-track-enabled.html
       media/media-source/media-source-tracks.html

Add mock implementation of platform MediaSource classes, allowing ports to test the
MediaSource API without having a platform implementation.

The MockMediaSource will support a byteformat defined in MockBox.h: a simple box-style media
format with an initialization segment containing a number of tracks, followed by a list of
samples.

Add a means to insert a new media engine factory at runtime, so the internals object can add
a MockMediaSourceMediaPlayer:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayerFactorySupport::callRegisterMediaEngine):
* platform/graphics/MediaPlayer.h:
* testing/Internals.cpp:
(WebCore::Internals::initializeMockMediaSource):
* testing/Internals.h:
* testing/Internals.idl:

For non-media-source supporting media engines, fail immediately when asked to load a media
source, so that the MockMediaSourceMediaPlayer will be instantiated as a fall-back:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):

Add new files to the project:
* WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/WebCore.exp.in:

Update the MediaSource implementation:
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::monitorSourceBuffers): Add a link to the spec.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::buffered): Ditto.
(WebCore::SourceBuffer::setTimestampOffset): Ditto.
(WebCore::SourceBuffer::validateInitializationSegment): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Ditto. Also,
    bring the implementation up to date with part of the spec.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Remove "Predicate" from
    SampleIsRandomAccessPredicate.

Add utility classes to parse and represent the bytestream supported by the MockMediaSource:
* platform/mock/mediasource/MockBox.cpp: Added.
(WebCore::MockBox::MockBox):
(WebCore::MockBox::peekType):
(WebCore::MockBox::peekLength):
(WebCore::MockTrackBox::MockTrackBox):
(WebCore::MockTrackBox::type):
(WebCore::MockInitializationBox::MockInitializationBox):
(WebCore::MockInitializationBox::type):
(WebCore::MockSampleBox::MockSampleBox):
(WebCore::MockSampleBox::type):
* platform/mock/mediasource/MockBox.h: Added.
(WebCore::MockBox::length):
(WebCore::MockBox::type):
(WebCore::MockTrackBox::trackID):
(WebCore::MockTrackBox::codec):
(WebCore::MockTrackBox::kind):
(WebCore::MockInitializationBox::duration):
(WebCore::MockInitializationBox::tracks):
(WebCore::MockSampleBox::presentationTimestamp):
(WebCore::MockSampleBox::decodeTimestamp):
(WebCore::MockSampleBox::duration):
(WebCore::MockSampleBox::trackID):
(WebCore::MockSampleBox::flags):
(WebCore::MockSampleBox::isSync):

Add a MediaPlayerPrivate implementation which uses MockMediaSource:
* platform/mock/mediasource/MockMediaPlayerMediaSource.cpp: Added.
(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):
(WebCore::MockMediaPlayerMediaSource::create):
(WebCore::mimeTypeCache):
(WebCore::MockMediaPlayerMediaSource::getSupportedTypes):
(WebCore::MockMediaPlayerMediaSource::supportsType):
(WebCore::MockMediaPlayerMediaSource::MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::~MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::load):
(WebCore::MockMediaPlayerMediaSource::cancelLoad):
(WebCore::MockMediaPlayerMediaSource::play):
(WebCore::MockMediaPlayerMediaSource::pause):
(WebCore::MockMediaPlayerMediaSource::naturalSize):
(WebCore::MockMediaPlayerMediaSource::hasVideo):
(WebCore::MockMediaPlayerMediaSource::hasAudio):
(WebCore::MockMediaPlayerMediaSource::setVisible):
(WebCore::MockMediaPlayerMediaSource::seeking):
(WebCore::MockMediaPlayerMediaSource::paused):
(WebCore::MockMediaPlayerMediaSource::networkState):
(WebCore::MockMediaPlayerMediaSource::readyState):
(WebCore::MockMediaPlayerMediaSource::buffered):
(WebCore::MockMediaPlayerMediaSource::didLoadingProgress):
(WebCore::MockMediaPlayerMediaSource::setSize):
(WebCore::MockMediaPlayerMediaSource::paint):
(WebCore::MockMediaPlayerMediaSource::currentTimeDouble):
(WebCore::MockMediaPlayerMediaSource::durationDouble):
(WebCore::MockMediaPlayerMediaSource::seekDouble):
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):
(WebCore::MockMediaPlayerMediaSource::updateDuration):
(WebCore::MockMediaPlayerMediaSource::setReadyState):
* platform/mock/mediasource/MockMediaPlayerMediaSource.h: Added.

Add a mock implementation of MediaSourcePrivate, which uses MockSourceBuffer:
* platform/mock/mediasource/MockMediaSourcePrivate.cpp: Added.
(WebCore::MockMediaSourcePrivate::create):
(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::~MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::addSourceBuffer):
(WebCore::MockMediaSourcePrivate::removeSourceBuffer):
(WebCore::MockMediaSourcePrivate::duration):
(WebCore::MockMediaSourcePrivate::setDuration):
(WebCore::MockMediaSourcePrivate::markEndOfStream):
(WebCore::MockMediaSourcePrivate::unmarkEndOfStream):
(WebCore::MockMediaSourcePrivate::readyState):
(WebCore::MockMediaSourcePrivate::setReadyState):
(WebCore::MockMediaSourcePrivate::sourceBufferPrivateDidChangeActiveState):
(WebCore::MockSourceBufferPrivateHasAudio):
(WebCore::MockMediaSourcePrivate::hasAudio):
(WebCore::MockSourceBufferPrivateHasVideo):
(WebCore::MockMediaSourcePrivate::hasVideo):
* platform/mock/mediasource/MockMediaSourcePrivate.h: Added.
(WebCore::MockMediaSourcePrivate::activeSourceBuffers):
(WebCore::MockMediaSourcePrivate::player):

Add a mock implementation of SourceBufferPrivate, which uses MockBoxes to parse the
bytestream provided by SourceBuffer:
* platform/mock/mediasource/MockSourceBufferPrivate.cpp: Added.
(WebCore::MockMediaSample::create):
(WebCore::MockMediaSample::~MockMediaSample):
(WebCore::MockMediaSample::MockMediaSample):
(WebCore::MockMediaSample::platformSample):
(WebCore::MockMediaDescription::create):
(WebCore::MockMediaDescription::~MockMediaDescription):
(WebCore::MockMediaDescription::MockMediaDescription):
(WebCore::MockSourceBufferPrivate::create):
(WebCore::MockSourceBufferPrivate::MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::~MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::setClient):
(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::didReceiveInitializationSegment):
(WebCore::MockSourceBufferPrivate::didReceiveSample):
(WebCore::MockSourceBufferPrivate::abort):
(WebCore::MockSourceBufferPrivate::removedFromMediaSource):
(WebCore::MockSourceBufferPrivate::readyState):
(WebCore::MockSourceBufferPrivate::setReadyState):
(WebCore::MockSourceBufferPrivate::hasVideo):
(WebCore::MockSourceBufferPrivate::hasAudio):
* platform/mock/mediasource/MockSourceBufferPrivate.h: Added.

Create mock implementations of AudioTrackPrivate, VideoTrackPrivate, and TextTrackPrivate
which wrap the MockTrackBox class:
* platform/mock/mediasource/MockTracks.cpp: Added.
* platform/mock/mediasource/MockTracks.h: Added.
(WebCore::MockAudioTrackPrivate::create):
(WebCore::MockAudioTrackPrivate::~MockAudioTrackPrivate):
(WebCore::MockAudioTrackPrivate::id):
(WebCore::MockAudioTrackPrivate::MockAudioTrackPrivate):
(WebCore::MockTextTrackPrivate::create):
(WebCore::MockTextTrackPrivate::~MockTextTrackPrivate):
(WebCore::MockTextTrackPrivate::id):
(WebCore::MockTextTrackPrivate::MockTextTrackPrivate):
(WebCore::MockVideoTrackPrivate::create):
(WebCore::MockVideoTrackPrivate::~MockVideoTrackPrivate):
(WebCore::MockVideoTrackPrivate::id):
(WebCore::MockVideoTrackPrivate::MockVideoTrackPrivate):

LayoutTests:

* media/media-source/media-source-addsourcebuffer-expected.txt: Added.
* media/media-source/media-source-addsourcebuffer.html: Added.
* media/media-source/media-source-append-buffer-expected.txt: Added.
* media/media-source/media-source-append-buffer.html: Added.
* media/media-source/media-source-canplaythrough-expected.txt: Added.
* media/media-source/media-source-canplaythrough.html: Added.
* media/media-source/media-source-closed-expected.txt: Added.
* media/media-source/media-source-closed.html: Added.
* media/media-source/media-source-play-expected.txt: Added.
* media/media-source/media-source-play.html: Added.
* media/media-source/mock-media-source.js: Added.
* media/video-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: DRT AccessibilityUIElement::isFocused methods should be finished.
samuel_white@apple.com [Thu, 7 Nov 2013 17:56:05 +0000 (17:56 +0000)]
AX: DRT AccessibilityUIElement::isFocused methods should be finished.
https://bugs.webkit.org/show_bug.cgi?id=123774

Reviewed by Chris Fleizach.

Tools:

Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isFocused):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isFocused):

LayoutTests:

Added Mac platform test so we can validate our AccessibilityUIElement convenience method expectations.

* platform/mac/accessibility/test-convenience-methods-expected.txt: Added.
* platform/mac/accessibility/test-convenience-methods.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved retrieveQMakespecVar function
commit-queue@webkit.org [Thu, 7 Nov 2013 17:17:36 +0000 (17:17 +0000)]
Removed retrieveQMakespecVar function
https://bugs.webkit.org/show_bug.cgi?id=123996

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved QMake related filters
commit-queue@webkit.org [Thu, 7 Nov 2013 17:11:34 +0000 (17:11 +0000)]
Removed QMake related filters
https://bugs.webkit.org/show_bug.cgi?id=123992

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline):
(TestRebaselineExpectations.test_rebaseline_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChanging MediaStreamDescriptor to MediaStreamPrivate
commit-queue@webkit.org [Thu, 7 Nov 2013 16:21:53 +0000 (16:21 +0000)]
Changing MediaStreamDescriptor to MediaStreamPrivate
https://bugs.webkit.org/show_bug.cgi?id=123935

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-07
Reviewed by Eric Carlson.

Source/WebCore:

No new tests needed.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::ended):
(WebCore::MediaStream::setEnded):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::removeRemoteSource):
* Modules/mediastream/MediaStream.h:
* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerURL):
(WebCore::MediaStreamRegistry::unregisterURL):
(WebCore::MediaStreamRegistry::lookupMediaStreamPrivate):
* Modules/mediastream/MediaStreamRegistry.h:
* Modules/mediastream/MediaStreamTrack.cpp:
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::callSuccessHandler):
* Modules/mediastream/UserMediaRequest.h:
* Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.cpp:
(HTMLMediaElement::loadResource):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::toWebMediaStreamPrivate):
(WebCore::MediaPlayerPrivate::lookupMediaStream):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
* platform/mediastream/MediaStreamCenter.cpp:
* platform/mediastream/MediaStreamCreationClient.h:
* platform/mediastream/MediaStreamPrivate.cpp: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp.
(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::addSource):
(WebCore::MediaStreamPrivate::removeSource):
(WebCore::MediaStreamPrivate::addRemoteSource):
(WebCore::MediaStreamPrivate::removeRemoteSource):
(WebCore::MediaStreamPrivate::addRemoteTrack):
(WebCore::MediaStreamPrivate::removeRemoteTrack):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::setEnded):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):
* platform/mediastream/MediaStreamPrivate.h: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.h.
(WebCore::MediaStreamPrivateClient::~MediaStreamPrivateClient):
(WebCore::MediaStreamPrivate::~MediaStreamPrivate):
(WebCore::MediaStreamPrivate::client):
(WebCore::MediaStreamPrivate::setClient):
(WebCore::MediaStreamPrivate::id):
(WebCore::MediaStreamPrivate::numberOfAudioSources):
(WebCore::MediaStreamPrivate::audioSources):
(WebCore::MediaStreamPrivate::numberOfVideoSources):
(WebCore::MediaStreamPrivate::videoSources):
(WebCore::MediaStreamPrivate::numberOfAudioTracks):
(WebCore::MediaStreamPrivate::audioTracks):
(WebCore::MediaStreamPrivate::numberOfVideoTracks):
(WebCore::MediaStreamPrivate::videoTracks):
(WebCore::MediaStreamPrivate::ended):
* platform/mediastream/MediaStreamSource.cpp:
* platform/mediastream/MediaStreamSource.h:
* platform/mediastream/RTCPeerConnectionHandler.h:
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
* platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
* platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
* platform/mediastream/mac/MediaStreamCenterMac.cpp:
(WebCore::MediaStreamCenterMac::createMediaStream):
* platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::createMediaStream):
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::addStream):
(WebCore::RTCPeerConnectionHandlerMock::removeStream):
* platform/mock/RTCPeerConnectionHandlerMock.h:

Source/WebKit/blackberry:

* WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore::toMediaStreamPrivate):
(WebCore::WebUserMediaRequestClientImpl::requestSucceeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise
mario@webkit.org [Thu, 7 Nov 2013 15:18:43 +0000 (15:18 +0000)]
[GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise
https://bugs.webkit.org/show_bug.cgi?id=50619

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-07
Reviewed by Martin Robinson.

Source/WebCore:

Implemented the OPENTYPE_VERTICAL feature for the GTK+ port. It resolves
the 90 degrees rotation problem of CJK characters when displaying
vertical text.

New tests are not required as the existing tests for vertical text will
work properly now.

* GNUmakefile.list.am: Added OpenTypeVerticalData.cpp and
OpenTypeVerticalData.h to platformgtk_sources.
* PlatformEfl.cmake: Added OpenTypeVerticalData.cpp.
* PlatformGTK.cmake: Added OpenTypeVerticalData.cpp.
* platform/graphics/FontCache.cpp: Originally the HashMap for
OpenTypeVerticalData was designed with FontFileKey as integer in the
Chromium port, which was an unique number provided by Skia. Since other
ports use FontFileKey as string, new generic hash functions had to be
implemented instead of using the specific ones for integers.
(WebCore::FontVerticalDataCacheKeyHash::hash): New hash function for
HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyHash::equal): New function for
comparing hash indexes in the HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyTraits::emptyValue): New function for
giving an empty FontFileKey.
(WebCore::FontVerticalDataCacheKeyTraits::constructDeletedValue): New
function to create a FontFileKey for deleted values.
(WebCore::FontVerticalDataCacheKeyTraits::isDeletedValue): New function
to check if a HashMap entry is available.
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Added font
orientation as a parameter to the FontPlatformData constructor.
* platform/graphics/freetype/FontPlatformData.h: Added m_orientation to
store the font orientation and m_horizontalOrientationMatrix to store
the Cairo matrix for horizontal orientation, which can be restored in
setOrientation().
(WebCore::FontPlatformData::FontPlatformData): Added font orientation as
a parameter.
(WebCore::FontPlatformData::orientation): Implemented this function
based on m_orientation.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp: Added new
helper function rotateCairoMatrixForVerticalOrientation() to rotate the
Cairo matrix in case of vertical orientation.
(WebCore::FontPlatformData::FontPlatformData): Initialized
m_orientation.
(WebCore::FontPlatformData::operator=): Added m_orientation and
m_horizontalOrientationMatrix to the assignment operator.
(WebCore::FontPlatformData::operator==): Added m_orientation to the
equal operator.
(WebCore::FontPlatformData::initializeWithFontFace): Rotated and
translated fonts if orientation is vertical. Also stored the horizontal
Cairo matrix.
(WebCore::FontPlatformData::verticalData): Returned the vertical data
from the font cache.
(WebCore::FontPlatformData::openTypeTable): Loaded the font table into
a shared buffer.
(WebCore::FontPlatformData::setOrientation): Replaced the scaled font
data by rotating fonts according to the new orientation.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit): Set the glyph's height and
width according to the font orientation. It also sets EM.
(WebCore::SimpleFontData::platformCreateScaledFontData): Added
orientation to the FontPlatformData constructor.
(WebCore::SimpleFontData::platformWidthForGlyph): Returned the glyph's
width according the orientation.
* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::CairoGetGlyphWidthAndExtents): Obtained the character advance
and extents according to the font orientation.

Source/Platform:

Added WebCore/platform/graphics/opentype to the include path.

* GNUmakefile.am:

Source/WTF:

Enabled OPENTYPE_VERTICAL by default on GTK+ and EFL ports, which are
currently using Freetype.

* wtf/Platform.h:

Source/WebKit:

Added WebCore/platform/graphics/opentype to the include path.

* PlatformEfl.cmake:

Source/WebKit2:

Added WebCore/platform/graphics/opentype to the include path.

* PlatformEfl.cmake:
* PlatformGTK.cmake:

LayoutTests:

Updated existing test results that uses vertical texts.

* platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Updated.
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Updated.
* platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Updated.
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Updated.
* platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.png: Updated.
* platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Updated.
* platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Updated.
* platform/gtk/fast/dynamic/text-combine-expected.png: Updated.
* platform/gtk/fast/dynamic/text-combine-expected.txt: Updated.
* platform/gtk/fast/html/details-writing-mode-expected.png: Updated.
* platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.png: Updated.
* platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.png: Updated.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Updated.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Updated.
* platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Updated.
* platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Updated.
* platform/gtk/fast/ruby/base-shorter-than-text-expected.png: Updated.
* platform/gtk/fast/ruby/base-shorter-than-text-expected.txt: Updated.
* platform/gtk/fast/text/decorations-with-text-combine-expected.png: Updated.
* platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Updated.
* platform/gtk/fast/text/emphasis-combined-text-expected.png: Updated.
* platform/gtk/fast/text/emphasis-combined-text-expected.txt: Updated.
* platform/gtk/fast/text/emphasis-vertical-expected.png: Updated.
* platform/gtk/fast/text/emphasis-vertical-expected.txt: Updated.
* platform/gtk/fast/text/international/text-combine-image-test-expected.png: Updated.
* platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Updated.
* platform/gtk/fast/text/international/text-spliced-font-expected.png: Updated.
* platform/gtk/fast/text/international/text-spliced-font-expected.txt: Updated.
* platform/gtk/fast/text/international/vertical-text-glyph-test-expected.png: Updated.
* platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
* platform/gtk/fast/text/justify-ideograph-vertical-expected.png: Updated.
* platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Added.
* platform/gtk/fast/text/orientation-sideways-expected.png: Updated.
* platform/gtk/fast/text/orientation-sideways-expected.txt: Updated.
* platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Updated.
* platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
* platform/gtk/fast/writing-mode/border-vertical-lr-expected.png: Updated.
* platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt: Updated.
* platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.png: Updated.
* platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Updated.
* platform/gtk/fast/writing-mode/broken-ideographic-font-expected.png: Updated.
* platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt: Updated.
* platform/gtk/fast/writing-mode/fallback-orientation-expected.png: Updated.
* platform/gtk/fast/writing-mode/fallback-orientation-expected.txt: Updated.
* platform/gtk/fast/writing-mode/japanese-lr-selection-expected.png: Updated.
* platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt: Updated.
* platform/gtk/fast/writing-mode/japanese-lr-text-expected.png: Updated.
* platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt: Updated.
* platform/gtk/fast/writing-mode/japanese-rl-selection-expected.png: Updated.
* platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt: Updated.
* platform/gtk/fast/writing-mode/japanese-rl-text-expected.png: Updated.
* platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt: Updated.
* platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Updated.
* platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Updated.
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Updated.
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Updated.
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Updated.
* platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Updated.
* platform/gtk/fast/writing-mode/text-orientation-basic-expected.png: Updated.
* platform/gtk/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Updated.
* platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Updated.
* platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.png: Updated.
* platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt: Updated.
* platform/gtk/fast/writing-mode/vertical-font-fallback-expected.png: Updated.
* platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening. Expectations are finally the same for
mario@webkit.org [Thu, 7 Nov 2013 13:43:05 +0000 (13:43 +0000)]
Unreviewed GTK gardening. Expectations are finally the same for
WK1 and WK2 so, besides needing a rebaseline, we now can share them.

* platform/gtk-wk1/accessibility/table-attributes-expected.txt: Removed.
* platform/gtk-wk1/accessibility/table-sections-expected.txt: Removed.
* platform/gtk/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-attributes-expected.txt.
* platform/gtk/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-sections-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, Add new baselines to EFL port since r158743 as well as do rebaseline.
gyuyoung.kim@samsung.com [Thu, 7 Nov 2013 12:51:41 +0000 (12:51 +0000)]
Unreviewed, Add new baselines to EFL port since r158743 as well as do rebaseline.
Because r158743 didn't update EFL port.

* platform/efl/fullscreen/video-controls-override-expected.txt: Added.
* platform/efl/http/tests/media/video-cookie-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
* platform/efl/media/context-menu-actions-expected.txt: Added.
* platform/efl/media/media-can-play-flac-audio-expected.txt: Added.
* platform/efl/media/media-can-play-webm-expected.txt: Added.
* platform/efl/media/media-volume-slider-rendered-below-expected.txt: Added.
* platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Added.
* platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Added.
* platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Added.
* platform/efl/media/track/track-cue-mutable-text-expected.txt: Added.
* platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Added.
* platform/efl/media/track/track-language-preference-expected.txt: Added.
* platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Added.
* platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Added.
* platform/efl/media/video-controls-fullscreen-volume-expected.txt: Added.
* platform/efl/media/video-controls-toggling-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Efl] Disable LTO when building cairo
commit-queue@webkit.org [Thu, 7 Nov 2013 12:46:32 +0000 (12:46 +0000)]
[Efl] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123947

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Gyuyoung Kim.

Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.
- See: https://bugs.freedesktop.org/show_bug.cgi?id=60852

With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'

* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[AX] Use toAccessibilityRenderObject() instead of using static_cast<>
gyuyoung.kim@samsung.com [Thu, 7 Nov 2013 12:29:10 +0000 (12:29 +0000)]
[AX] Use toAccessibilityRenderObject() instead of using static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123986

Reviewed by Mario Sanchez Prada.

Though there is toAccessibilityRenderObject(), static_cast<> are being used by many places.
To use toAccessibilityRenderObject() is more helpful to find bad type cast.

No new tests, no behavior changes.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
* accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetElement):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[AX] Use toAccessibilityTable() instead of using manual static_cast<>
gyuyoung.kim@samsung.com [Thu, 7 Nov 2013 12:10:39 +0000 (12:10 +0000)]
[AX] Use toAccessibilityTable() instead of using manual static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123982

Reviewed by Mario Sanchez Prada.

Though there is toAccessibilityTable(), static_cast<> are being used by many places.
We need to use toAccessibilityTable().

No new tests, no behavior changes.

* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(cell):
(cellAtIndex):
(webkitAccessibleTableGetIndexAt):
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableParent]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse tighter InlineBox subtypes in some places.
akling@apple.com [Thu, 7 Nov 2013 12:04:02 +0000 (12:04 +0000)]
Use tighter InlineBox subtypes in some places.
<https://webkit.org/b/123980>

RenderLineBreak and RenderBox line box wrappers are always going to
be InlineElementBox, so codify this with tighter types. Also made
the various positionLine() functions take tighter reference types.

All the casting to renderer-appropriate box types happens inside of
RenderBlockFlow::computeBlockDirectionPositionsForLine() and
propagates from there.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: [ATK] Video and audio elements are not properly exposed
mario@webkit.org [Thu, 7 Nov 2013 11:12:23 +0000 (11:12 +0000)]
AX: [ATK] Video and audio elements are not properly exposed
https://bugs.webkit.org/show_bug.cgi?id=123894

Reviewed by Chris Fleizach.

Source/WebCore:

Expose <audio> and <video> elements with ATK_ROLE_EMBEDDED, so we
can identify them properly from ATK/AT-SPI based ATs.

Tests: platform/gtk/accessibility/media-controls-panel-title.html
       platform/efl/accessibility/media-emits-object-replacement.html
       platform/gtk/accessibility/media-emits-object-replacement.html

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Add the new mapping.

Tools:

Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.

LayoutTests:

Updated tests and expectations according to the new behavior.

Updated failing test to reflect the new reality.
* platform/gtk/accessibility/media-element-expected.txt: Updated.

Extended GTK specific test by adding an <audio> element besides
the <video> one and printing all the information about those
related to their media nature.

* platform/gtk/accessibility/media-controls-panel-title.html: Extended.
* platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated.

Added new tests for GTK and EFL to check that the replaced
character is being properly emitter for both <video> and <audio>
elements. Inspired in the ones in platform/mac, we use a different
approach here to print the test since we don't have the
textMarkerRangeForElement functionality in our DRT/WKTR, and
because we expect embedded objects to show up in the results in a
GTK/EFL specific way (using the "<obj>" string).

* platform/efl/accessibility/media-emits-object-replacement-expected.txt: Added.
* platform/efl/accessibility/media-emits-object-replacement.html: Added.
* platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Added.
* platform/gtk/accessibility/media-emits-object-replacement.html: Added.

Removed tests with failure expectations that are now passing.

* platform/gtk/TestExpectations: Removed passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix crash in BitmapImage::destroyDecodedData()
commit-queue@webkit.org [Thu, 7 Nov 2013 11:04:16 +0000 (11:04 +0000)]
Fix crash in BitmapImage::destroyDecodedData()
https://bugs.webkit.org/show_bug.cgi?id=116494

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

Merge from https://chromium.googlesource.com/chromium/blink/+/6b6887bf53068f8537908e501fdc7317ad2c6d86

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] CSSParser should reject <track-list> without a <track-size>
svillar@igalia.com [Thu, 7 Nov 2013 10:53:17 +0000 (10:53 +0000)]
[CSS Grid Layout] CSSParser should reject <track-list> without a <track-size>
https://bugs.webkit.org/show_bug.cgi?id=118025

Reviewed by Andreas Kling.

Source/WebCore:

From Blink r152914 by <jchaffraix@chromium.org>

Make sure that we parse at least 1 <track-size> inside each
<track-list>. The old parser code allowed track-lists exclusively
made of <track-name>. The way it was implemented eases the future
addition of parsing for the repeat() function.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackList):
* css/StyleResolver.cpp:
(WebCore::createGridTrackList): ASSERT if we don't find any
<track-size> now that we detect their absence in the parser.

LayoutTests:

Added a new test that verifies that <track-list> exclusively made
of <track-name> are not supported.

* fast/css-grid-layout/named-grid-line-get-set-expected.txt:
* fast/css-grid-layout/named-grid-line-get-set.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
svillar@igalia.com [Thu, 7 Nov 2013 10:45:54 +0000 (10:45 +0000)]
[CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
https://bugs.webkit.org/show_bug.cgi?id=115401

Reviewed by Andreas Kling.

Source/WebCore:

From Blink r150585 by <jchaffraix@chromium.org>

Added support for 'inherit' and 'initial' special values to
grid-auto-{columns|rows} and grid-definition-{columns|rows}.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): Resolve 'initial' and 'inherit'.
* rendering/style/RenderStyle.h: Added initialNamedGrid{Column|Row}Lines().
* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData): Initialize m_namedGrid{Column|Row}Lines.

LayoutTests:

Added 'inherit' and 'initial' testing support to existing tests.

* fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
* fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
* fast/css-grid-layout/grid-auto-flow-get-set.html:
* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
(testInherit): New helper function.
(testInitial): Ditto.
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
(testInherit): New helper function.
(testInitial): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening
m.pakula@samsung.com [Thu, 7 Nov 2013 10:36:25 +0000 (10:36 +0000)]
Unreviewed gardening

Adjust test expectations after r158743.

* fullscreen/video-controls-override-expected.txt:
* http/tests/media/video-cookie-expected.txt:
* media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt:
* media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
* media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt:
* media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt:
* media/context-menu-actions-expected.txt:
* media/media-can-play-flac-audio-expected.txt:
* media/media-volume-slider-rendered-below-expected.txt:
* media/media-volume-slider-rendered-normal-expected.txt:
* media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt:
* media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt:
* media/track/track-cue-mutable-text-expected.txt:
* media/track/track-cue-rendering-mode-changed-expected.txt:
* media/track/track-language-preference-expected.txt:
* media/track/video/video-track-mkv-theora-addtrack-expected.txt:
* media/video-controls-fullscreen-volume-expected.txt:
* media/video-controls-toggling-expected.txt:
* media/video-controls-visible-exiting-fullscreen-expected.txt:
* media/video-seek-past-end-paused-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
* platform/efl/media/media-can-play-webm-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize baselines: svg/batik
akling@apple.com [Thu, 7 Nov 2013 10:27:16 +0000 (10:27 +0000)]
Optimize baselines: svg/batik

Unreviewed; run "webkit-patch optimize-baselines svg/batik"

* platform/gtk/svg/batik/filters/feTile-expected.txt: Removed.
* platform/gtk/svg/batik/filters/filterRegions-expected.txt: Removed.
* platform/gtk/svg/batik/masking/maskRegions-expected.txt: Removed.
* platform/gtk/svg/batik/paints/gradientLimit-expected.txt: Removed.
* platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
* platform/gtk/svg/batik/paints/patternRegionA-expected.txt: Removed.
* platform/gtk/svg/batik/paints/patternRegions-expected.txt: Removed.
* platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
* platform/gtk/svg/batik/text/longTextOnPath-expected.txt: Removed.
* platform/gtk/svg/batik/text/smallFonts-expected.txt: Removed.
* platform/gtk/svg/batik/text/textAnchor-expected.txt: Removed.
* platform/gtk/svg/batik/text/textAnchor2-expected.txt: Removed.
* platform/gtk/svg/batik/text/textAnchor3-expected.txt: Removed.
* platform/gtk/svg/batik/text/textDecoration-expected.txt: Removed.
* platform/gtk/svg/batik/text/textDecoration2-expected.txt: Removed.
* platform/gtk/svg/batik/text/textEffect-expected.txt: Removed.
* platform/gtk/svg/batik/text/textEffect2-expected.txt: Removed.
* platform/gtk/svg/batik/text/textEffect3-expected.txt: Removed.
* platform/gtk/svg/batik/text/textFeatures-expected.txt: Removed.
* platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Removed.
* platform/gtk/svg/batik/text/textLayout-expected.txt: Removed.
* platform/gtk/svg/batik/text/textLayout2-expected.txt: Removed.
* platform/gtk/svg/batik/text/textLength-expected.txt: Removed.
* platform/gtk/svg/batik/text/textOnPath-expected.txt: Removed.
* platform/gtk/svg/batik/text/textOnPath2-expected.txt: Removed.
* platform/gtk/svg/batik/text/textOnPath3-expected.txt: Removed.
* platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
* platform/gtk/svg/batik/text/textPCDATA-expected.txt: Removed.
* platform/gtk/svg/batik/text/textPosition-expected.txt: Removed.
* platform/gtk/svg/batik/text/textProperties-expected.txt: Removed.
* platform/gtk/svg/batik/text/textProperties2-expected.txt: Removed.
* platform/gtk/svg/batik/text/textStyles-expected.txt: Removed.
* platform/gtk/svg/batik/text/verticalText-expected.txt: Removed.
* platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt: Removed.
* platform/gtk/svg/batik/text/xmlSpace-expected.txt: Removed.
* svg/batik/filters/feTile-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/feTile-expected.txt.
* svg/batik/filters/filterRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/filterRegions-expected.txt.
* svg/batik/masking/maskRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/masking/maskRegions-expected.txt.
* svg/batik/paints/gradientLimit-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/gradientLimit-expected.txt.
* svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt.
* svg/batik/paints/patternRegionA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegionA-expected.txt.
* svg/batik/paints/patternRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-expected.txt.
* svg/batik/paints/patternRegions-positioned-objects-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt.
* svg/batik/text/longTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/longTextOnPath-expected.txt.
* svg/batik/text/smallFonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/smallFonts-expected.txt.
* svg/batik/text/textAnchor-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor-expected.txt.
* svg/batik/text/textAnchor2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor2-expected.txt.
* svg/batik/text/textAnchor3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor3-expected.txt.
* svg/batik/text/textDecoration-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration-expected.txt.
* svg/batik/text/textDecoration2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration2-expected.txt.
* svg/batik/text/textEffect-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect-expected.txt.
* svg/batik/text/textEffect2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect2-expected.txt.
* svg/batik/text/textEffect3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect3-expected.txt.
* svg/batik/text/textFeatures-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textFeatures-expected.txt.
* svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt.
* svg/batik/text/textLayout-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout-expected.txt.
* svg/batik/text/textLayout2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout2-expected.txt.
* svg/batik/text/textLength-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLength-expected.txt.
* svg/batik/text/textOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath-expected.txt.
* svg/batik/text/textOnPath2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath2-expected.txt.
* svg/batik/text/textOnPath3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath3-expected.txt.
* svg/batik/text/textOnPathSpaces-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPathSpaces-expected.txt.
* svg/batik/text/textPCDATA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPCDATA-expected.txt.
* svg/batik/text/textPosition-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPosition-expected.txt.
* svg/batik/text/textProperties-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties-expected.txt.
* svg/batik/text/textProperties2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties2-expected.txt.
* svg/batik/text/textStyles-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textStyles-expected.txt.
* svg/batik/text/verticalText-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalText-expected.txt.
* svg/batik/text/verticalTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalTextOnPath-expected.txt.
* svg/batik/text/xmlSpace-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/xmlSpace-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize baselines: svg/as-background-image
akling@apple.com [Thu, 7 Nov 2013 10:18:43 +0000 (10:18 +0000)]
Optimize baselines: svg/as-background-image

Unreviewed; run "webkit-patch optimize-baselines svg/as-background-image"

* platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
* platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
* platform/efl/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
* platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-expected.png: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.png: Removed.
* platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.png: Removed.
* platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.txt: Removed.
* platform/win-future/svg/as-background-image/svg-as-background-1-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-1-expected.txt.
* platform/win-future/svg/as-background-image/svg-as-background-2-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-2-expected.txt.
* platform/win-future/svg/as-background-image/svg-as-background-3-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-3-expected.txt.
* platform/win-future/svg/as-background-image/svg-as-background-4-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-4-expected.txt.
* platform/win-future/svg/as-background-image/svg-as-background-5-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-5-expected.txt.
* platform/win-future/svg/as-background-image/svg-as-background-6-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-6-expected.txt.
* svg/as-background-image/animated-svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt.
* svg/as-background-image/svg-as-background-1-expected.txt:
* svg/as-background-image/svg-as-background-2-expected.txt:
* svg/as-background-image/svg-as-background-3-expected.txt:
* svg/as-background-image/svg-as-background-4-expected.txt:
* svg/as-background-image/svg-as-background-5-expected.txt:
* svg/as-background-image/svg-as-background-6-expected.txt:
* svg/as-background-image/svg-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.png.
* svg/as-background-image/svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.txt.
* svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt.
* svg/as-background-image/svg-as-background-with-viewBox-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.png.
* svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt.
* svg/as-background-image/svg-as-tiled-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.png.
* svg/as-background-image/svg-as-tiled-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt.
* svg/as-background-image/svg-width-100p-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.png.
* svg/as-background-image/svg-width-100p-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up BidiRun a little bit.
akling@apple.com [Thu, 7 Nov 2013 10:12:36 +0000 (10:12 +0000)]
Clean up BidiRun a little bit.
<https://webkit.org/b/123964>

Make BidiRun's member variables private and add accessors for them.
In doing so, codify the following:

    - BidiRun always has a corresponding RenderObject.
    - The inline box is never cleared after being set.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore CSSPrimitiveValue constructors should return PassRef.
akling@apple.com [Thu, 7 Nov 2013 10:11:43 +0000 (10:11 +0000)]
More CSSPrimitiveValue constructors should return PassRef.
<https://webkit.org/b/123953>

Make some more CSSPrimitiveValue constructor helpers (that are
known to never return null) return PassRef instead of PassRefPtr.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGenerate type casting helpers for line boxes and use them.
akling@apple.com [Thu, 7 Nov 2013 10:08:04 +0000 (10:08 +0000)]
Generate type casting helpers for line boxes and use them.
<https://webkit.org/b/123976>

Semi-automatically generate the full set of toFooInlineBox()
helpers with macros instead of having them (partially) hand-coded.
Replaced static_casts with the new helpers across the codebase.

Also made the isFooInlineBox() overrides private since they should
never be called when the type is already known.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build for architectures with 4 argument registers (broken since r158820).
commit-queue@webkit.org [Thu, 7 Nov 2013 10:02:39 +0000 (10:02 +0000)]
Fix build for architectures with 4 argument registers (broken since r158820).
https://bugs.webkit.org/show_bug.cgi?id=123969

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-07
Reviewed by Andreas Kling.

* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify Attr by removing m_specified member variable and setter
rniwa@webkit.org [Thu, 7 Nov 2013 09:32:57 +0000 (09:32 +0000)]
Simplify Attr by removing m_specified member variable and setter
https://bugs.webkit.org/show_bug.cgi?id=123965

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/597f44ec928e08820574728889adabc6d8ecd746

m_specified is always true in WebKit so simply return true in Attr::specified().

* dom/Attr.cpp:
(WebCore::Attr::Attr):
* dom/Attr.h:
* dom/Document.cpp:
(WebCore::Document::adoptNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange git_commit_from_svn_revision() to work in a pure git checkout
commit-queue@webkit.org [Thu, 7 Nov 2013 09:21:08 +0000 (09:21 +0000)]
Change git_commit_from_svn_revision() to work in a pure git checkout
https://bugs.webkit.org/show_bug.cgi?id=111668

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-07
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.git_commit_from_svn_revision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
commit-queue@webkit.org [Thu, 7 Nov 2013 08:05:06 +0000 (08:05 +0000)]
[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=123919

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/PageClientImpl.cpp: Remove takeFocus().
* UIProcess/API/gtk/PageClientImpl.h: Remove takeFocus() and mark methods as OVERRIDE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVersioning.
lforschler@apple.com [Thu, 7 Nov 2013 06:41:05 +0000 (06:41 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158826 268f45cc-cd09-0410-ab3c-d52691b4dbfc