WebKit-https.git
8 years ago[chromium] Convert uses of GetDC to HWndDC.
levin@chromium.org [Tue, 24 Jan 2012 00:22:38 +0000 (00:22 +0000)]
[chromium] Convert uses of GetDC to HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76290

Reviewed by Dmitry Titov.

* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::createFontIndirectAndGetWinName):
(WebCore::fontContainsCharacter):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::FontMap::getAscent):
(WebCore::FontMap::getSpaceGlyph):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::systemFontSize):
(WebCore::pointsToPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebsite: Reword WEBKITOUTPUTDIR documentation on Building WebKit page
commit-queue@webkit.org [Tue, 24 Jan 2012 00:13:19 +0000 (00:13 +0000)]
website: Reword WEBKITOUTPUTDIR documentation on Building WebKit page
https://bugs.webkit.org/show_bug.cgi?id=76544

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-01-23
Reviewed by Darin Adler.

WEBKITOUTPUTDIR is not only for Windows.

* building/build.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style whitespace/operators triggers on overloaded division operator
eae@chromium.org [Tue, 24 Jan 2012 00:01:23 +0000 (00:01 +0000)]
check-webkit-style whitespace/operators triggers on overloaded division operator
https://bugs.webkit.org/show_bug.cgi?id=76650

Reviewed by Darin Adler.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_operator_methods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReduce throttling on video-buffering-repaints-controls test to prevent timeout.
commit-queue@webkit.org [Tue, 24 Jan 2012 00:00:55 +0000 (00:00 +0000)]
Reduce throttling on video-buffering-repaints-controls test to prevent timeout.
https://bugs.webkit.org/show_bug.cgi?id=76113

Also reduces flakiness by checking for a repaint between progress and
suspend events versus just between progress events.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23
Reviewed by Adam Barth.

* http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* http/tests/media/video-buffering-repaints-controls.html:
* platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png:
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-perf-tests should report server-side errors
rniwa@webkit.org [Mon, 23 Jan 2012 23:49:00 +0000 (23:49 +0000)]
run-perf-tests should report server-side errors
https://bugs.webkit.org/show_bug.cgi?id=76802

Reviewed by Tony Chang.

Report errors whenever server's response doesn't match "OK".

* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_single_text_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._upload_json):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=75799
commit-queue@webkit.org [Mon, 23 Jan 2012 23:46:15 +0000 (23:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75799
Calling intersectsNode on a detached range should throw.

Source/WebCore:

INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.

Test: fast/dom/Range/range-intersectsNode-exception.html

* dom/Range.cpp:
(WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached.

LayoutTests:

Added test case to verify the exception thrown while calling intersectsNode on a detached range.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.

* fast/dom/Range/range-intersectsNode-exception-expected.txt: Added.
* fast/dom/Range/range-intersectsNode-exception.html: Added.
* fast/dom/Range/range-intersectsNode-expected.txt:
* fast/dom/Range/resources/intersectsNode.js:  Modified the test case to catch the exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert DataTransferItem/DataTransferItemList back into an interface class
dcheng@chromium.org [Mon, 23 Jan 2012 23:35:44 +0000 (23:35 +0000)]
Convert DataTransferItem/DataTransferItemList back into an interface class
https://bugs.webkit.org/show_bug.cgi?id=76856

When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared
classes since Chromium/Qt happened to implement it the same way. Now that I want to do some
refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't
share the same data anymore so it doesn't make sense to keep that code in a common location.

Reviewed by David Levin.

Covered by existing tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DataTransferItem.cpp:
* dom/DataTransferItem.h:
* dom/DataTransferItemList.cpp: Removed.
* dom/DataTransferItemList.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::mayUpdateItems):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::clipboardChromium):
* platform/chromium/DataTransferItemChromium.h:
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
* platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
* platform/chromium/DataTransferItemListChromium.h:
* platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):
* platform/qt/DataTransferItemListQt.h:
* platform/qt/DataTransferItemQt.cpp:
(WebCore::DataTransferItemQt::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsString):
(WebCore::DataTransferItemQt::getAsFile):
* platform/qt/DataTransferItemQt.h:
(WebCore::DataTransferItemQt::kind):
(WebCore::DataTransferItemQt::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogetComputedStyle margin percentage test for CSS calc
mikelawther@chromium.org [Mon, 23 Jan 2012 23:32:40 +0000 (23:32 +0000)]
getComputedStyle margin percentage test for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=76130

Reviewed by Darin Adler.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
* css3/calc/getComputedStyle-margin-percentage.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=76855
barraclough@apple.com [Mon, 23 Jan 2012 23:30:57 +0000 (23:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Geoff Garen.

Step 2: generalize RedBlackTree. The profiler is going to want tio use
a RedBlackTree, allow this class to work with subclasses of
RedBlackTree::Node, Node should not need to know the names of the m_key
and m_value fields (the subclass can provide a key() accessor), and
RedBlackTree does not need to know anything about ValueType.

* JavaScriptCore.exp:
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):
* wtf/MetaAllocator.h:
(WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
(WTF::MetaAllocator::FreeSpaceNode::key):
* wtf/MetaAllocatorHandle.h:
(WTF::MetaAllocatorHandle::key):
* wtf/RedBlackTree.h:
(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642.
kling@webkit.org [Mon, 23 Jan 2012 23:01:20 +0000 (23:01 +0000)]
Unreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642.

* css/CSSMutableStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-perf-tests ignore Skipped list on chromium
rniwa@webkit.org [Mon, 23 Jan 2012 22:42:09 +0000 (22:42 +0000)]
run-perf-tests ignore Skipped list on chromium
https://bugs.webkit.org/show_bug.cgi?id=76764

Reviewed by Dirk Pranke.

Move skipped_perf_tests from WebKit port to Base port so that Chromium port
can also find skipped list. Chromium port only uses test_expectations.txt for
layout tests but performacne tests don't use test_expectations.txt so Chromium port
also needs to use Skipped list.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._tests_from_skipped_file_contents):
(Port):
(Port._expectations_from_skipped_files):
(Port.skipped_perf_tests):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_skipped_perf_tests):
(PortTest.test_skipped_perf_tests.add_text_file):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_tests_for_unsupported_features):
(WebKitPort._skipped_file_search_paths):
(WebKitPort.skipped_layout_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate uniteIfNonZero to use isZero.
commit-queue@webkit.org [Mon, 23 Jan 2012 22:37:54 +0000 (22:37 +0000)]
Update uniteIfNonZero to use isZero.
https://bugs.webkit.org/show_bug.cgi?id=76637

Patch by Philip Rogers <pdr@google.com> on 2012-01-23
Reviewed by Darin Adler.

No new tests. (I found no existing codepath that would be affected by
this change but I think this change is still valuable in preventing
future bugs.)

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):

The following change is a minor followup to
https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
related to the rest of this patch.
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEliminate CSSElementStyleDeclaration
antti@apple.com [Mon, 23 Jan 2012 22:26:21 +0000 (22:26 +0000)]
Eliminate CSSElementStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=76848

Reviewed by Andreas Kling.

CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.

Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also
shrinks all inline style declarations by one pointer.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
(WebCore::root):
* css/CSSAllInOne.cpp:
* css/CSSElementStyleDeclaration.cpp: Removed.
* css/CSSElementStyleDeclaration.h: Removed.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
(WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):

    Merge the CSSElementStyleDeclaration::styleSheet() logic here.

* css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):

    CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed.
    This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()).

* dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
* html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r105640.
senorblanco@chromium.org [Mon, 23 Jan 2012 22:07:16 +0000 (22:07 +0000)]
Unreviewed, rolling out r105640.
http://trac.webkit.org/changeset/105640
https://bugs.webkit.org/show_bug.cgi?id=76849

Broke the chromium build.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorolling chromium DEPS to r118713
senorblanco@chromium.org [Mon, 23 Jan 2012 21:41:51 +0000 (21:41 +0000)]
rolling chromium DEPS to r118713
https://bugs.webkit.org/show_bug.cgi?id=76849

Patch by Justin Novosad <junov@chromium.org> on 2012-01-23
Reviewed by Stephen White.

This is to pick up a change to skia build configuration

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build after r105635.
aestes@apple.com [Mon, 23 Jan 2012 21:39:55 +0000 (21:39 +0000)]
Fix the build after r105635.

Source/JavaScriptCore:

* JavaScriptCore.exp:

Tools:

* TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove StackBounds from JSGlobalData
mhahnenberg@apple.com [Mon, 23 Jan 2012 21:36:18 +0000 (21:36 +0000)]
Remove StackBounds from JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=76310

Reviewed by Sam Weinig.

Removed StackBounds and the stack() function from JSGlobalData since it no
longer accessed any members of JSGlobalData.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThread):
* parser/Parser.cpp:
(JSC::::Parser):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse OVERRIDE for PopupMenuClient's implementations
benjamin@webkit.org [Mon, 23 Jan 2012 21:35:24 +0000 (21:35 +0000)]
Use OVERRIDE for PopupMenuClient's implementations
https://bugs.webkit.org/show_bug.cgi?id=76774

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-23
Reviewed by Darin Adler.

* rendering/RenderMenuList.h: Also sort the methods to the same
order as PopupMenuClient.
* rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement a JIT-code aware sampling profiler for JSC
barraclough@apple.com [Mon, 23 Jan 2012 21:08:34 +0000 (21:08 +0000)]
Implement a JIT-code aware sampling profiler for JSC
https://bugs.webkit.org/show_bug.cgi?id=76855

Rubber stanmped by Geoff Garen.

Mechanical change - pass CodeBlock through to the executable allocator,
such that we will be able to map ranges of JIT code back to their owner.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBasic enhancements to StringBuilder
wangxianzhu@chromium.org [Mon, 23 Jan 2012 20:42:05 +0000 (20:42 +0000)]
Basic enhancements to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67081

Source/JavaScriptCore:

This change contains the following enhancements to StringBuilder,
for convenience, performance, testability, etc.:
- Change toStringPreserveCapacity() to const
- new public methods: capacity(), swap(), toAtomicString(), canShrink()
  and append(const StringBuilder&)
- == and != opearators to compare StringBuilders and a StringBuilder/String

Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp

Reviewed by Darin Adler.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/AtomicString.cpp:
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
(WTF::SubstringTranslator::translate):
(WTF::AtomicString::add):
(WTF::AtomicString::addSlowCase):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::add):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::canShrink):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::toAtomicString):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::capacity):
(WTF::StringBuilder::is8Bit):
(WTF::StringBuilder::swap):
(WTF::equal):
(WTF::operator==):
(WTF::operator!=):
* wtf/text/StringImpl.h:

Source/WebCore:

These changes are because we explicitly disallowed StringBuilder's
copy constructor and assignment operator, and the change of return
type of StringBuilder::toString().

Reviewed by Darin Adler.

No new tests. All layout tests and unit tests should run as before.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
* svg/SVGPathStringBuilder.h:
(WebCore::SVGPathStringBuilder::cleanup):

Source/WebKit/chromium:

This change is because we explicitly disallowed StringBuilder's
copy constructor and assignment operator.

Reviewed by Darin Adler.

No new tests. All layout tests and unit tests should run as before.

* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):

Tools:

Reviewed by Darin Adler.

* TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add WebSolidColorLayer interface to draw non-textured color layers from...
wjmaclean@chromium.org [Mon, 23 Jan 2012 20:00:57 +0000 (20:00 +0000)]
[chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura.
https://bugs.webkit.org/show_bug.cgi?id=75732

Reviewed by James Robinson.

Source/WebCore:

Add WebSolidColorLayer to paint solid-color layers without a backing texture.

Test: unit test for CCSolidColorLayerImpl.

* WebCore.gypi:
* platform/graphics/chromium/SolidColorLayerChromium.cpp: Added.
(WebCore::SolidColorLayerChromium::createCCLayerImpl):
(WebCore::SolidColorLayerChromium::create):
(WebCore::SolidColorLayerChromium::SolidColorLayerChromium):
(WebCore::SolidColorLayerChromium::~SolidColorLayerChromium):
* platform/graphics/chromium/SolidColorLayerChromium.h: Added.
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Added.
(WebCore::CCSolidColorLayerImpl::CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::~CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::quadTransform):
(WebCore::CCSolidColorLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Added.
(WebCore::CCSolidColorLayerImpl::create):
(WebCore::CCSolidColorLayerImpl::layerTypeAsString):

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* public/platform/WebSolidColorLayer.h: Added.
* src/WebSolidColorLayer.cpp: Added.
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
* src/WebSolidColorLayerImpl.cpp: Added.
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::~WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h: Added.
* tests/CCLayerTestCommon.cpp: Added.
(CCLayerTestCommon::completelyContains):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):
* tests/CCLayerTestCommon.h: Added.
* tests/CCSolidColorLayerImplTest.cpp: Added.
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate the baselines for a number of tests that use gradients. The new
abarth@webkit.org [Mon, 23 Jan 2012 19:39:15 +0000 (19:39 +0000)]
Update the baselines for a number of tests that use gradients.  The new
results are just slightly different than the old results.

* fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* fast/gradients/border-image-gradient-expected.txt: Added.
* fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added.
* platform/chromium-linux-x86/fast/gradients: Removed.
* platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
* platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed.
* platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
* platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
* platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
* platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
* platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
* platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
* platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed.
* platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
* platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed.
* platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed.
* platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed.
* platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
* platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed.
* platform/chromium-win-vista/fast/gradients: Removed.
* platform/chromium-win-xp/svg/as-background-image: Removed.
* platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
* platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
* platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
* platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
* platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
* platform/chromium-win/fast/gradients/generated-gradients-expected.png:
* platform/chromium-win/fast/gradients/simple-gradients-expected.png:
* platform/chromium-win/fast/reflections/reflection-masks-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-win/svg/filters/big-sized-filter-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
* platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed.
* platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
* platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed.
* platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
* platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed.
* platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix Qt build.
antti@apple.com [Mon, 23 Jan 2012 17:20:02 +0000 (17:20 +0000)]
Attempt to fix Qt build.

Not reviewed.

* css/CSSElementStyleDeclaration.cpp:
* css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement.
kling@webkit.org [Mon, 23 Jan 2012 17:00:38 +0000 (17:00 +0000)]
Move m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement.
<http://webkit.org/b/76833>

Reviewed by Antti Koivisto.

Move HTMLAnchorElement::m_rootEditableElementForSelectionOnMouseDown to a rare
data-style hashmap, effectively shrinking HTMLAnchorElement by one CPU word.

The pointer is only used during interactive event handling, so it shouldn't have
any noticeable effects on web performance.

This reduces memory consumption by 256 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::~HTMLAnchorElement):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
(WebCore::rootEditableElementMap):
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
(WebCore::HTMLAnchorElement::setRootEditableElementForSelectionOnMouseDown):
* html/HTMLAnchorElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEliminate CSSElementStyleDeclaration subclasses
antti@apple.com [Mon, 23 Jan 2012 16:49:10 +0000 (16:49 +0000)]
Eliminate CSSElementStyleDeclaration subclasses
https://bugs.webkit.org/show_bug.cgi?id=76827

Reviewed by Andreas Kling.

CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no real purpose.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSElementStyleDeclaration.cpp:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSElementStyleDeclaration::styleSheet):
* css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createInline):
(WebCore::toCSSElementStyleDeclaration):
* css/CSSInlineStyleDeclaration.h: Removed.
* css/CSSMutableStyleDeclaration.cpp:
* dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
* html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek.
philn@webkit.org [Mon, 23 Jan 2012 16:45:45 +0000 (16:45 +0000)]
Unreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek.

* platform/gtk/Skipped: Unskip tests 5 tests using ArrayBuffer
which is no longer tied to 3D_CANVAS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: annotate inspector's js so that it compiled.
pfeldman@chromium.org [Mon, 23 Jan 2012 16:37:16 +0000 (16:37 +0000)]
Not reviewed: annotate inspector's js so that it compiled.

* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, mark another test as flaky crash.
philn@webkit.org [Mon, 23 Jan 2012 16:32:56 +0000 (16:32 +0000)]
Unreviewed, mark another test as flaky crash.

* platform/gtk/test_expectations.txt:
editing/execCommand/19455.html is flaky, sometimes hitting an ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] fix WebAudio build after r105431
philn@webkit.org [Mon, 23 Jan 2012 16:24:21 +0000 (16:24 +0000)]
[GStreamer] fix WebAudio build after r105431
https://bugs.webkit.org/show_bug.cgi?id=76819

Reviewed by Martin Robinson.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel): Use mutableData()
when copying.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop): Drop constness when setting the buffer
data pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add touch events to the event listeners list.
pfeldman@chromium.org [Mon, 23 Jan 2012 16:20:40 +0000 (16:20 +0000)]
Web Inspector: add touch events to the event listeners list.
https://bugs.webkit.org/show_bug.cgi?id=76830

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg
philn@webkit.org [Mon, 23 Jan 2012 15:52:06 +0000 (15:52 +0000)]
Unreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg
flaky tests and added baselines for 15 tests.

* platform/gtk/css3/images/cross-fade-background-size-expected.txt: Added.
* platform/gtk/fast/backgrounds/mask-box-image-expected.txt: Added.
* platform/gtk/fast/borders/scaled-border-image-expected.txt: Added.
* platform/gtk/fast/css/text-overflow-input-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-floating-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-positioned-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* platform/gtk/svg/custom/relative-sized-image-expected.txt: Added.
* platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
* platform/gtk/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
* platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Added.
* platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Added.
* platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Added.
* platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Added.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: inspector close button is missing in the dock-to-right mode.
pfeldman@chromium.org [Mon, 23 Jan 2012 15:47:26 +0000 (15:47 +0000)]
Web Inspector: inspector close button is missing in the dock-to-right mode.
https://bugs.webkit.org/show_bug.cgi?id=76829

Reviewed by Timothy Hatcher.

* inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.get _setCompactMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r105613.
ossy@webkit.org [Mon, 23 Jan 2012 15:24:56 +0000 (15:24 +0000)]
[Qt] Unreviewed gardening after r105613.

* platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Updated.
* platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: IndexedDBModel should keep track of requests sent to the backend.
vsevik@chromium.org [Mon, 23 Jan 2012 15:17:04 +0000 (15:17 +0000)]
Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
https://bugs.webkit.org/show_bug.cgi?id=76705

Reviewed by Pavel Feldman.

* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
* inspector/InspectorIndexedDBAgent.h:
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype._requestId):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabasesForFrameRequest):
(WebInspector.IndexedDBDispatcher):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Inspecting an element inside an iframe no longer works
pfeldman@chromium.org [Mon, 23 Jan 2012 15:10:01 +0000 (15:10 +0000)]
Web Inspector: Inspecting an element inside an iframe no longer works
https://bugs.webkit.org/show_bug.cgi?id=76808

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: http/tests/inspector/inspect-element.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::innerParentNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._setChildrenPayload):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):

LayoutTests:

* http/tests/inspector/inspect-element-expected.txt: Added.
* http/tests/inspector/inspect-element.html: Added.
* http/tests/inspector/resources/inspect-element-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: response.bodySize in HAR is invalid (negative) for cached resources
caseq@chromium.org [Mon, 23 Jan 2012 14:52:50 +0000 (14:52 +0000)]
Web Inspector: response.bodySize in HAR is invalid (negative) for cached resources
https://bugs.webkit.org/show_bug.cgi?id=76823

Reviewed by Yury Semikhatsky.

- fix response.bodySize for cached resources;
Also some drive-by fixes:
- pretty-print HAR when exported
- proper annotation for JSON.stringify()
- de-obfuscate a piece of code in TimelinePanel

* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.get responseBodySize):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 14:45:23 +0000 (14:45 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkAction interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceAction.cpp: Added.
(core):
(webkitAccessibleActionInterfaceInit):
(webkitAccessibleActionDoAction):
(webkitAccessibleActionGetNActions):
(webkitAccessibleActionGetDescription):
(webkitAccessibleActionGetKeybinding):
(webkitAccessibleActionGetName):
* accessibility/gtk/WebKitAccessibleInterfaceAction.h: Added.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkAction interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceAction.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] run-gtk-tests randomly fails while running the xprop comand
mario@webkit.org [Mon, 23 Jan 2012 14:36:01 +0000 (14:36 +0000)]
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817

Reviewed by Gustavo Noronha Silva.

No need to use xprop to remove the AT_SPI_BUS property since
run-gtk-tests will always run new instances of Xvfb.

* Scripts/run-gtk-tests:
(TestRunner): Unskip TestWebKitAccessibility.
(TestRunner.run): Uncomment lines for launching the accessibility
bus and registry daemon, and remove lines for running xprop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Don't warn about override and final being C++11 extensions
vestbo@webkit.org [Mon, 23 Jan 2012 14:32:41 +0000 (14:32 +0000)]
[Qt] Don't warn about override and final being C++11 extensions

Clang will emit a warning when these extensions are used without passing
--std=c++11, but we use feature checking to decide if we have the right
extensions, so we can safely ignore these warnings. The XCode and Windows
project files have the same workaround.

The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
we only have one extra compiler for Objective-C, which is also used for
Objective-C++ sources, so we have to pass the flag, even if it doesn't
make sense for Objective-C.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT.
antonm@chromium.org [Mon, 23 Jan 2012 14:12:43 +0000 (14:12 +0000)]
Unreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline after r105613 (SVG animation repaint issue...).
antonm@chromium.org [Mon, 23 Jan 2012 14:03:45 +0000 (14:03 +0000)]
Unreviewed rebaseline after r105613 (SVG animation repaint issue...).

* platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG animation repaint issue with image and dynamic clipPath
zimmermann@webkit.org [Mon, 23 Jan 2012 12:48:12 +0000 (12:48 +0000)]
SVG animation repaint issue with image and dynamic clipPath
https://bugs.webkit.org/show_bug.cgi?id=76559

Reviewed by Zoltan Herczeg.

Source/WebCore:

Based on patch by Kelly Norton <knorton@google.com>. I extended the patch
to correctly handle relative length resolution as well.

RenderSVGImage doesn't react on setNeedsBoundariesUpdate() calls
and thus fails to update its boundaries in some cases.

The logic is also inconsistent, compared to the other renderers.
Fix that properly, by reusing the method used in RenderSVGViewportContainer.
Call calculateImageViewport() immediately, after initializing the LayoutRepainter.
Previously we resolved the image viewport in RenderSVGImage::updateFromElement. This is
wrong, as it queries the frameRect() of the RenderSVGRoot in a state, where the renderer
still needs layout, leading to wrong results.

I turned Kellys manual testcase into a predictable test, see svg/repaint/image-with-clip-path.svg
Relative sized image handling is tested in svg/custom/relative-sized-image.xhtml now.

Tests: svg/custom/relative-sized-image.xhtml
       svg/repaint/image-with-clip-path.svg

* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGImage.h:
(WebCore::RenderSVGImage::setNeedsBoundariesUpdate):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):

LayoutTests:

Update results after fixing RenderSVGImage repainting.

* platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* platform/mac/svg/custom/relative-sized-image-expected.png: Added.
* platform/mac/svg/custom/relative-sized-image-expected.txt: Added.
* platform/mac/svg/repaint/image-with-clip-path-expected.png: Added.
* svg/custom/relative-sized-image.xhtml: Added.
* svg/repaint/image-with-clip-path-expected.txt: Added.
* svg/repaint/image-with-clip-path.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<feImage> has problems referencing local elements
zimmermann@webkit.org [Mon, 23 Jan 2012 12:42:42 +0000 (12:42 +0000)]
<feImage> has problems referencing local elements
https://bugs.webkit.org/show_bug.cgi?id=76800

Reviewed by Zoltan Herczeg.

Source/WebCore:

<feImage> referencing local elements are currently rendered into an ImageBuffer
by SVGFEImageElement, using the local coordinates of the referenced renderer.

This approach is buggy and should be avoided, by moving the rendering fully
into SVGFEImage, which takes care of respecting the correct transformations.

This fixes <feImage> + local references, which currently breaks two tests in trunk.
Covered by existing tests.

* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::FEImage):
(WebCore::FEImage::createWithImage):
(WebCore::FEImage::createWithIRIReference):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
(WebCore::FEImage::platformApplySoftware):
(WebCore::FEImage::externalRepresentation):
* svg/graphics/filters/SVGFEImage.h:
(WebCore::FEImage::~FEImage):
* svg/graphics/filters/SVGFilter.h:
(WebCore::SVGFilter::absoluteTransform):

LayoutTests:

Update svg/filters/feImage-reference-* results, which are fixed now.

* platform/chromium/test_expectations.txt : Updated.
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Update for marginal change.
* svg/filters/feImage-reference-invalidation-expected.png:
* svg/filters/feImage-reference-svg-primitive-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-01-23 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 23 Jan 2012 12:39:31 +0000 (12:39 +0000)]
2012-01-23  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix Mac build, by exporting a new symbol.

        * WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 11:55:01 +0000 (11:55 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Move common function returnString() from the wrapper and
hyperlink implementations to a new utility file.

* accessibility/gtk/WebKitAccessibleUtil.cpp: Added.
(returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
WebKitAccessibleHyperlink.cpp
* accessibility/gtk/WebKitAccessibleUtil.h: Added.

* accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local
implementation of returnString.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit fails IETC composition event types
ossy@webkit.org [Mon, 23 Jan 2012 11:51:20 +0000 (11:51 +0000)]
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690

Unreviewed gardening after r105605.

* fast/events/ime-composition-events-001-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 11:46:04 +0000 (11:46 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Fix typo in class struct (parent class field had the wrong type),
fix coding style issues and update date in headers.

* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
* accessibility/gtk/WebKitAccessibleHyperlink.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 11:43:28 +0000 (11:43 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Source/WebCore:

Rename WebKitAccessible's public functions to follow WebKit's
coding style and update callers.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleNew): Renamed from webkit_accessible_new.
(webkitAccessibleGetAccessibilityObject): Likewise.
(webkitAccessibleDetach):Likewise.
(webkitAccessibleGetFocusedElement): Likewise.
* accessibility/gtk/WebKitAccessibleWrapperAtk.h:

Update calls to WebKitAccessible's public functions.

* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::detachWrapper): Update call.
(WebCore::AXObjectCache::attachWrapper): Ditto.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(core): Update call.

Source/WebKit/gtk:

Update callers to WebKitAccessible's public functions.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
(modifyAccessibilityValue):
(DumpRenderTreeSupportGtk::accessibilityHelpText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 23 Jan 2012 11:17:26 +0000 (11:17 +0000)]
Unreviewed. Fix make distcheck.

* GNUmakefile.list.am: Add missing files, remove deleted files and
fix indentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit fails IETC composition event types
bashi@chromium.org [Mon, 23 Jan 2012 10:41:29 +0000 (10:41 +0000)]
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 10:21:03 +0000 (10:21 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Source/WebCore:

Rename the file for the ATK AccessibilityObject wrapper to be more
coherent with the rest of the files in the same directory.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp.
(fallbackObject):
(returnString):
(core):
(webkit_accessible_get_name):
(webkit_accessible_get_description):
(setAtkRelationSetFromCoreObject):
(isRootObject):
(atkParentOfRootObject):
(webkit_accessible_get_parent):
(getNChildrenForTable):
(webkit_accessible_get_n_children):
(getChildForTable):
(webkit_accessible_ref_child):
(getIndexInParentForCellInRow):
(webkit_accessible_get_index_in_parent):
(addAttributeToSet):
(webkit_accessible_get_attributes):
(atkRole):
(webkit_accessible_get_role):
(selectionBelongsToObject):
(isTextWithCaret):
(setAtkStateSetFromCoreObject):
(webkit_accessible_ref_state_set):
(webkit_accessible_ref_relation_set):
(webkit_accessible_init):
(webkit_accessible_finalize):
(webkit_accessible_class_init):
(webkit_accessible_get_type):
(webkit_accessible_action_do_action):
(webkit_accessible_action_get_n_actions):
(webkit_accessible_action_get_description):
(webkit_accessible_action_get_keybinding):
(webkit_accessible_action_get_name):
(atk_action_interface_init):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkit_accessible_selection_add_selection):
(webkit_accessible_selection_clear_selection):
(webkit_accessible_selection_ref_selection):
(webkit_accessible_selection_get_selection_count):
(webkit_accessible_selection_is_child_selected):
(webkit_accessible_selection_remove_selection):
(webkit_accessible_selection_select_all_selection):
(atk_selection_interface_init):
(utf8Substr):
(convertUniCharToUTF8):
(textForRenderer):
(textForObject):
(webkit_accessible_text_get_text):
(getGailTextUtilForAtk):
(getPangoLayoutForAtk):
(webkit_accessible_text_get_text_after_offset):
(webkit_accessible_text_get_text_at_offset):
(webkit_accessible_text_get_text_before_offset):
(webkit_accessible_text_get_character_at_offset):
(webkit_accessible_text_get_caret_offset):
(baselinePositionForRenderObject):
(getAttributeSetForAccessibilityObject):
(compareAttribute):
(attributeSetDifference):
(accessibilityObjectLength):
(getAccessibilityObjectForOffset):
(getRunAttributesFromAccesibilityObject):
(webkit_accessible_text_get_run_attributes):
(webkit_accessible_text_get_default_attributes):
(textExtents):
(webkit_accessible_text_get_character_extents):
(webkit_accessible_text_get_range_extents):
(webkit_accessible_text_get_character_count):
(webkit_accessible_text_get_offset_at_point):
(getSelectionOffsetsForObject):
(webkit_accessible_text_get_n_selections):
(webkit_accessible_text_get_selection):
(webkit_accessible_text_add_selection):
(webkit_accessible_text_set_selection):
(webkit_accessible_text_remove_selection):
(webkit_accessible_text_set_caret_offset):
(atk_text_interface_init):
(webkit_accessible_editable_text_set_run_attributes):
(webkit_accessible_editable_text_set_text_contents):
(webkit_accessible_editable_text_insert_text):
(webkit_accessible_editable_text_copy_text):
(webkit_accessible_editable_text_cut_text):
(webkit_accessible_editable_text_delete_text):
(webkit_accessible_editable_text_paste_text):
(atk_editable_text_interface_init):
(contentsToAtk):
(atkToContents):
(webkit_accessible_component_ref_accessible_at_point):
(webkit_accessible_component_get_extents):
(webkit_accessible_component_grab_focus):
(atk_component_interface_init):
(webkit_accessible_image_get_image_position):
(webkit_accessible_image_get_image_description):
(webkit_accessible_image_get_image_size):
(atk_image_interface_init):
(cell):
(cellIndex):
(cellAtIndex):
(webkit_accessible_table_ref_at):
(webkit_accessible_table_get_index_at):
(webkit_accessible_table_get_column_at_index):
(webkit_accessible_table_get_row_at_index):
(webkit_accessible_table_get_n_columns):
(webkit_accessible_table_get_n_rows):
(webkit_accessible_table_get_column_extent_at):
(webkit_accessible_table_get_row_extent_at):
(webkit_accessible_table_get_column_header):
(webkit_accessible_table_get_row_header):
(webkit_accessible_table_get_caption):
(webkit_accessible_table_get_column_description):
(webkit_accessible_table_get_row_description):
(atk_table_interface_init):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):
(atkHypertextInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):
(atkHyperlinkImplInterfaceInit):
(documentAttributeValue):
(webkit_accessible_document_get_attribute_value):
(webkit_accessible_document_get_attributes):
(webkit_accessible_document_get_locale):
(atk_document_interface_init):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
(atkValueInterfaceInit):
(GetAtkInterfaceTypeFromWAIType):
(getInterfaceMaskFromObject):
(getUniqueAccessibilityTypeName):
(getAccessibilityTypeFromObject):
(webkit_accessible_new):
(webkit_accessible_get_accessibility_object):
(webkit_accessible_detach):
(webkit_accessible_get_focused_element):
(objectFocusedAndCaretOffsetUnignored):
* accessibility/gtk/WebKitAccessibleWrapperAtk.h: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.h.

Update the include for the AccessibilityObject wrapper header.

* accessibility/gtk/AXObjectCacheAtk.cpp: Update include.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp: Ditto.
* accessibility/gtk/WebKitAccessibleHyperlink.h: Ditto.
* editing/gtk/FrameSelectionGtk.cpp:

Update filename for the ATK wrapper in build files.

* GNUmakefile.list.am: Updated.
* WebCore.gypi: Updated.

Source/WebKit/gtk:

Update the include for the AccessibilityObject wrapper header.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Update include.
* webkit/webkitwebframe.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Change how build-webkit decides when to do full incremental builds
vestbo@webkit.org [Mon, 23 Jan 2012 10:14:48 +0000 (10:14 +0000)]
[Qt] Change how build-webkit decides when to do full incremental builds

Instead of relying on update-webkit (which isn't run on the bots) to
decide when to do a full incremental build (make qmake), we let the
build-webkit script itself check the current SVN revision against the
previous build (by storing it in .webkit.config).

If the two differ we assume a full incremental build is needed, since
the new revisions might have introduced problematic things like new
Q_OBJECT macros. If not, we assume the developer is doing changes
locally, and revert to doing a plain 'make'.

In addition, when the build fails in the latter case, we inform the
developer of possible pitfalls and how to manually run 'make qmake'.

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed follow-up to r105596, added missing test resources.
caseq@chromium.org [Mon, 23 Jan 2012 10:09:47 +0000 (10:09 +0000)]
Unreviewed follow-up to r105596, added missing test resources.

* http/tests/inspector/resources/har-pages-iframe.html: Added.
* http/tests/inspector/resources/har-pages-navigation-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] run-gtk-tests randomly fails while running the xprop comand
mario@webkit.org [Mon, 23 Jan 2012 10:05:29 +0000 (10:05 +0000)]
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817

Reviewed by Philippe Normand.

Temporarily comment the lines related to launching the ATSPI bus
and registry daemon, which are making the bots to fail randomly.

* Scripts/run-gtk-tests:
(TestRunner): Skip TestWebKitAccessibility, as it won't run
properly if the ATSPI infrastructure is not properly initialized.
(TestRunner.run): Comment lines related to initialization of ATSPI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: PageAgent.open() dosen't belong to the protocol.
pfeldman@chromium.org [Mon, 23 Jan 2012 10:04:10 +0000 (10:04 +0000)]
Web Inspector: PageAgent.open() dosen't belong to the protocol.
https://bugs.webkit.org/show_bug.cgi?id=74790

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::openInNewTab):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._openInNewTab):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.ondblclick):
* inspector/front-end/inspector.js:
(WebInspector.openResource):

Source/WebKit/chromium:

* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::openInNewTab):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::openInNewTab):
(WebKit::InspectorFrontendClientImpl::saveAs):
* src/InspectorFrontendClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r101742.
philn@webkit.org [Mon, 23 Jan 2012 09:59:08 +0000 (09:59 +0000)]
Unreviewed, GTK rebaseline after r101742.

* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandabl...
loislo@chromium.org [Mon, 23 Jan 2012 09:23:48 +0000 (09:23 +0000)]
Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandable tree (to get rid of cycles)
https://bugs.webkit.org/show_bug.cgi?id=76813

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening, marked 2 tests as flaky on Debug and
philn@webkit.org [Mon, 23 Jan 2012 09:13:23 +0000 (09:13 +0000)]
Unreviewed, GTK gardening, marked 2 tests as flaky on Debug and
unskipped another needing new baselines.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: HAR pageref attributes are wrong and inconsistent with pages array
caseq@chromium.org [Mon, 23 Jan 2012 09:02:56 +0000 (09:02 +0000)]
Web Inspector: HAR pageref attributes are wrong and inconsistent with pages array
https://bugs.webkit.org/show_bug.cgi?id=76398

Reviewed by Pavel Feldman.

Source/WebCore:

- introduce a notion of LoadPage;
- move page load times to LoadPage;
- associate network resources with LoadPage;
- export pages for all available resoruces to HAR, not just the last page;
- use page ids, not document URLs in HAR entries to refer to pages;
- use page URL as a title field of a HAR page;

* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertPage):
(WebInspector.HARLog.prototype._pageEventTime):
* inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):
(WebInspector.Page):
(WebInspector.Page.prototype.get id):
(WebInspector.Page.prototype.get url):
(WebInspector.Page.prototype.get contentLoadTime):
(WebInspector.Page.prototype.set contentLoadTime):
(WebInspector.Page.prototype.get loadTime):
(WebInspector.Page.prototype.set loadTime):
(WebInspector.Page.prototype.get startTime):
(WebInspector.Page.prototype._bindResource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get page):
(WebInspector.Resource.prototype.set page):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get page):
(WebInspector.PageDispatcher.prototype.domContentEventFired):
(WebInspector.PageDispatcher.prototype.loadEventFired):

LayoutTests:

* http/tests/inspector/resource-har-headers-expected.txt:
* http/tests/inspector/resource-parameters-expected.txt:
* platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening, marked a test as flaky and unskipped
philn@webkit.org [Mon, 23 Jan 2012 08:58:25 +0000 (08:58 +0000)]
Unreviewed, GTK gardening, marked a test as flaky and unskipped
several needing new baselines.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows python test build fix.
rniwa@webkit.org [Mon, 23 Jan 2012 02:13:40 +0000 (02:13 +0000)]
Windows python test build fix.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sun, 22 Jan 2012 19:51:37 +0000 (19:51 +0000)]
2012-01-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix typo, which makes the style bot warn on every patch.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
mario@webkit.org [Sun, 22 Jan 2012 19:29:04 +0000 (19:29 +0000)]
[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069

Reviewed by Martin Robinson.

Source/WebCore:

Fix bug introduced with patch for Bug 72830.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isDescendantOfObject): New function,
to check if an accessibility object is a descendant of other object.
(WebCore::AccessibilityObject::isAncestorOfObject): New function,
to check if an accessibility object is an ancestor of other object.
* accessibility/AccessibilityObject.h:

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_caret_offset): Make sure to pass the
right reference object to objectFocusedAndCaretOffsetUnignored.
(objectFocusedAndCaretOffsetUnignored): Use positionBeforeNode
instead of firstPositionInNode for calculating the begining of the
range used to calculate the offsets. Ensure that the reference
object is never a descendant of the actual object being returned.

* editing/gtk/FrameSelectionGtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.

Source/WebKit/gtk:

Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.

* tests/testatk.c:
(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Unreviewed, unskipping passing test.
sergio@webkit.org [Sun, 22 Jan 2012 12:50:52 +0000 (12:50 +0000)]
[GTK] Unreviewed, unskipping passing test.

* platform/gtk/Skipped: unskipped
http/tests/security/mixedContent/empty-url-plugin-in-frame.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Unreviewed, unskipping test passing after r79655.
sergio@webkit.org [Sun, 22 Jan 2012 11:52:22 +0000 (11:52 +0000)]
[GTK] Unreviewed, unskipping test passing after r79655.

* platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] DumpRenderTree converts "file:///" to a path differently
sergio@webkit.org [Sun, 22 Jan 2012 10:12:03 +0000 (10:12 +0000)]
[GTK] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76631

Reviewed by Martin Robinson.

Tools:

DumpRenderTree should print "/" as the last path component if the
path is a lone slash instead of empty output.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewConsoleMessage):

LayoutTests:

Unskipped a couple of tests after fix.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix for non-DFG platforms that error out on warn-unused-parameter.
fpizlo@apple.com [Sun, 22 Jan 2012 09:11:49 +0000 (09:11 +0000)]
Build fix for non-DFG platforms that error out on warn-unused-parameter.

* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
* bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix for non-DFG platforms.
fpizlo@apple.com [Sun, 22 Jan 2012 08:47:47 +0000 (08:47 +0000)]
Build fix for non-DFG platforms.

* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
* bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][PATCH] Enable MathML support by default
commit-queue@webkit.org [Sun, 22 Jan 2012 03:45:14 +0000 (03:45 +0000)]
[GTK][PATCH] Enable MathML support by default
https://bugs.webkit.org/show_bug.cgi?id=76790

Patch by Priit Laes <plaes@plaes.org> on 2012-01-21
Reviewed by Martin Robinson.

* configure.ac: Enable MathML by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Incremental texture updates are not atomic.
commit-queue@webkit.org [Sun, 22 Jan 2012 03:30:41 +0000 (03:30 +0000)]
[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672

Patch by David Reveman <reveman@chromium.org> on 2012-01-21
Reviewed by Adam Barth.

Source/WebCore:

Use a new set of textures for each commit when incremental
texture updates are enabled.

This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommit.runMultiThread

* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):
* platform/graphics/chromium/ManagedTexture.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):
* tests/CompositorFakeWebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd baselines for test after http://trac.webkit.org/changeset/105575.
abarth@webkit.org [Sun, 22 Jan 2012 01:43:06 +0000 (01:43 +0000)]
Add baselines for test after trac.webkit.org/changeset/105575.
This baseline looks very similar to the existing non-Chromium baseline.

* platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Added.
* platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not have code that directly decodes the states of old JIT inline
fpizlo@apple.com [Sun, 22 Jan 2012 01:36:23 +0000 (01:36 +0000)]
DFG should not have code that directly decodes the states of old JIT inline
cache data structures
https://bugs.webkit.org/show_bug.cgi?id=76768

Reviewed by Sam Weinig.

Introduced new classes (like GetByIdStatus) that encapsulate the set of things
that the DFG would like to know about property accesses and calls. Whereas it
previously got this information by directly decoding the data structures used
by the old JIT for inline caching, it now uses these classes, which do the work
for it. This should make it somewhat more straight forward to introduce new
ways of profiling the same information.

Also hoisted StructureSet into bytecode/ from dfg/, because it's now used by
code in bytecode/.

Making this work right involved carefully ensuring that the heuristics for
choosing how to handle property accesses was at least as good as what we had
before, since I completely restructured that code. Currently the performance
looks neutral. Since I rewrote the code I did change some things that I never
liked before, like previously if a put_bu_id had executed exactly once then
we'd compile it as if it had taken slow-path. Executing once is special because
then the inline cache is not baked in, so there is no information about how the
DFG should optimize the code. Now this is rationalized: if the put_by_id does
not offer enough information to be optimized (i.e. had executed 0 or 1 times)
then we turn it into a forced OSR exit (i.e. a patch point). However, get_by_id
still has the old behavior; I left it that way because I didn't want to make
too many changes at once.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CallLinkStatus.cpp: Added.
(JSC::CallLinkStatus::computeFor):
* bytecode/CallLinkStatus.h: Added.
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(JSC::CallLinkStatus::couldTakeSlowPath):
(JSC::CallLinkStatus::callTarget):
* bytecode/GetByIdStatus.cpp: Added.
(JSC::GetByIdStatus::computeFor):
* bytecode/GetByIdStatus.h: Added.
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::state):
(JSC::GetByIdStatus::isSet):
(JSC::GetByIdStatus::operator!):
(JSC::GetByIdStatus::isSimpleDirect):
(JSC::GetByIdStatus::takesSlowPath):
(JSC::GetByIdStatus::makesCalls):
(JSC::GetByIdStatus::structureSet):
(JSC::GetByIdStatus::offset):
* bytecode/MethodCallLinkStatus.cpp: Added.
(JSC::MethodCallLinkStatus::computeFor):
* bytecode/MethodCallLinkStatus.h: Added.
(JSC::MethodCallLinkStatus::MethodCallLinkStatus):
(JSC::MethodCallLinkStatus::isSet):
(JSC::MethodCallLinkStatus::operator!):
(JSC::MethodCallLinkStatus::needsPrototypeCheck):
(JSC::MethodCallLinkStatus::structure):
(JSC::MethodCallLinkStatus::prototypeStructure):
(JSC::MethodCallLinkStatus::function):
(JSC::MethodCallLinkStatus::prototype):
* bytecode/PutByIdStatus.cpp: Added.
(JSC::PutByIdStatus::computeFor):
* bytecode/PutByIdStatus.h: Added.
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::state):
(JSC::PutByIdStatus::isSet):
(JSC::PutByIdStatus::operator!):
(JSC::PutByIdStatus::isSimpleReplace):
(JSC::PutByIdStatus::isSimpleTransition):
(JSC::PutByIdStatus::takesSlowPath):
(JSC::PutByIdStatus::oldStructure):
(JSC::PutByIdStatus::newStructure):
(JSC::PutByIdStatus::structureChain):
(JSC::PutByIdStatus::offset):
* bytecode/StructureSet.h: Added.
(JSC::StructureSet::StructureSet):
(JSC::StructureSet::clear):
(JSC::StructureSet::add):
(JSC::StructureSet::addAll):
(JSC::StructureSet::remove):
(JSC::StructureSet::contains):
(JSC::StructureSet::isSubsetOf):
(JSC::StructureSet::isSupersetOf):
(JSC::StructureSet::size):
(JSC::StructureSet::at):
(JSC::StructureSet::operator[]):
(JSC::StructureSet::last):
(JSC::StructureSet::predictionFromStructures):
(JSC::StructureSet::operator==):
(JSC::StructureSet::dump):
* dfg/DFGAbstractValue.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGStructureSet.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd .url attribute alongside .URL in EventSource and WebSocket to comply with the...
commit-queue@webkit.org [Sun, 22 Jan 2012 01:09:18 +0000 (01:09 +0000)]
Add .url attribute alongside .URL in EventSource and WebSocket to comply with the specs but not break existing usage.
https://bugs.webkit.org/show_bug.cgi?id=40899

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-21
Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/eventsource/eventsource-url-attribute.html
       http/tests/websocket/tests/hixie76/url-attribute.html
       http/tests/websocket/tests/hybi/url-attribute.html

* page/EventSource.idl:
* websockets/WebSocket.idl:

LayoutTests:

* fast/eventsource/eventsource-url-attribute-expected.txt: Added.
* fast/eventsource/eventsource-url-attribute.html: Added.
* http/tests/websocket/tests/hixie76/url-attribute-expected.txt: Added.
* http/tests/websocket/tests/hixie76/url-attribute.html: Added.
* http/tests/websocket/tests/hybi/url-attribute-expected.txt: Added.
* http/tests/websocket/tests/hybi/url-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJIT compilation should not require ExecState
fpizlo@apple.com [Sun, 22 Jan 2012 00:48:18 +0000 (00:48 +0000)]
JIT compilation should not require ExecState
https://bugs.webkit.org/show_bug.cgi?id=76729
<rdar://problem/10731545>

Reviewed by Gavin Barraclough.

Changed the relevant JIT driver functions to take JSGlobalData& instead of
ExecState*, since really they just needed the global data.

* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r105564.
commit-queue@webkit.org [Sat, 21 Jan 2012 23:56:14 +0000 (23:56 +0000)]
Unreviewed, rolling out r105564.
http://trac.webkit.org/changeset/105564
https://bugs.webkit.org/show_bug.cgi?id=76792

Does not compile on Chromium Mac (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-21

Source/WebCore:

* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ManagedTexture.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
* tests/CompositorFakeWebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed weekend gardening. Skip the new failing tests to paint the bots green.
ossy@webkit.org [Sat, 21 Jan 2012 17:19:11 +0000 (17:19 +0000)]
[Qt] Unreviewed weekend gardening. Skip the new failing tests to paint the bots green.

* platform/qt-wk2/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement hardware accelerated Brightness and contrast filters
cmarrin@apple.com [Sat, 21 Jan 2012 15:40:03 +0000 (15:40 +0000)]
Implement hardware accelerated Brightness and contrast filters
https://bugs.webkit.org/show_bug.cgi?id=75521
https://bugs.webkit.org/show_bug.cgi?id=76719

Reviewed by Simon Fraser.

Source/WebCore:

Implemented hardware accelerated brightness and contrast filters. This also fixes
the bug where grayscale filter was accidentally never getting hardware accelerated.
It also complies with proposed spec changes for the brightness filter to be additive
rather than multiplicative, according to https://bugs.webkit.org/show_bug.cgi?id=76719.
Had to make both fixes in the same patch because I had to change the allowed brightness
values for the hardware version, so I had to change the software version as well.

Tests: css3/filters/effect-brightness-hw.html
       css3/filters/effect-contrast-hw.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseBuiltinFilterArguments):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):

LayoutTests:

New tests for hardware accelerated brightness and contrast filters. Also
added brightness and contrast values to effect-combined-hw test. And changed
brightness values in effect-brightness.html to reflect new spec.
Also fixed parsing and computed style tests to reflect new brightness spec.

* css3/filters/effect-brightness-expected.png:
* css3/filters/effect-brightness-hw-expected.png: Added.
* css3/filters/effect-brightness-hw-expected.txt: Added.
* css3/filters/effect-brightness-hw.html: Added.
* css3/filters/effect-brightness.html:
* css3/filters/effect-combined-expected.png:
* css3/filters/effect-combined-hw-expected.png:
* css3/filters/effect-combined-hw-expected.txt:
* css3/filters/effect-combined-hw.html:
* css3/filters/effect-combined.html:
* css3/filters/effect-contrast-hw-expected.png: Added.
* css3/filters/effect-contrast-hw-expected.txt: Added.
* css3/filters/effect-contrast-hw.html: Added.
* css3/filters/filter-property-computed-style-expected.txt:
* css3/filters/filter-property-parsing-expected.txt:
* css3/filters/filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/filter-property-computed-style.js:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 21 Jan 2012 12:28:20 +0000 (12:28 +0000)]
2012-01-21  Nikolas Zimmermann  <nzimmermann@rim.com>

        <feImage> ignores preserveAspectRatio="none"
        https://bugs.webkit.org/show_bug.cgi?id=76780

        Reviewed by Antti Koivisto.

        Add new testcase covering preserveAspectRatio="none" + <feImage>, which is now fixed.

        * platform/chromium/test_expectations.txt: Add new test, that needs a rebaseline.
        * platform/mac/svg/filters/feImage-preserveAspectratio-expected.png: Added.
        * platform/mac/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
        * svg/filters/feImage-preserveAspectratio.svg: Added.

2012-01-21  Nikolas Zimmermann  <nzimmermann@rim.com>

        <feImage> ignores preserveAspectRatio="none"
        https://bugs.webkit.org/show_bug.cgi?id=76780

        Reviewed by Antti Koivisto.

        preserveAspectRatio="none" was ignored in SVGFEImage. It always called transformRect() w/o checking
        whether it was supposed to transform the rect or not - move code from RenderSVGImage right into
        transformRect(), to do nothing if preserveAspectRatio="none" was given.

        Test: svg/filters/feImage-preserveAspectratio.svg

        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::transformRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohistory.replaceState should update the HistoryItem to use a GET method if previously...
jochen@chromium.org [Sat, 21 Jan 2012 10:18:36 +0000 (10:18 +0000)]
history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST)
https://bugs.webkit.org/show_bug.cgi?id=76721

Reviewed by Mihai Parparita.

Source/WebCore:

Tests: http/tests/history/replacestate-post-to-get-2.html
       http/tests/history/replacestate-post-to-get.html

* loader/HistoryController.cpp:
(WebCore::HistoryController::replaceState):

LayoutTests:

* http/tests/history/replacestate-post-to-get-2-expected.txt: Added.
* http/tests/history/replacestate-post-to-get-2.html: Added.
* http/tests/history/replacestate-post-to-get-expected.txt: Added.
* http/tests/history/replacestate-post-to-get.html: Added.
* http/tests/history/resources/replacestate-current.php: Added.
* http/tests/history/resources/replacestate-forward-back.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNull dereference in SVGDocumentExtensions::removePendingResource when updating <use...
commit-queue@webkit.org [Sat, 21 Jan 2012 10:00:36 +0000 (10:00 +0000)]
Null dereference in SVGDocumentExtensions::removePendingResource when updating <use>'s href
https://bugs.webkit.org/show_bug.cgi?id=69284

Patch by Florin Malita <fmalita@google.com> on 2012-01-21
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/use-crash-pending-resource.svg

The crash is caused by assumptions in SVGUseElement that xlink:href is the only
pending resource. This patch adds support for dealing with multiple pending resources.

* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::hasPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForElement):
* svg/SVGDocumentExtensions.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
Renamed SVGDocumentExtensions::hasPendingResources -> Renamed SVGDocumentExtensions::hasPendingResource.
Renamed SVGDocumentExtensions::isElementInPendingResources -> SVGDocumentExtensions::isElementPendingResources.
Added support for querying and removing pending resources for a specific element.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::buildPendingResource):
Refactored to support multiple pending resources.

LayoutTests:

* svg/custom/use-crash-pending-resource-expected.txt: Added.
* svg/custom/use-crash-pending-resource.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles...
commit-queue@webkit.org [Sat, 21 Jan 2012 08:51:39 +0000 (08:51 +0000)]
REGRESSION (Safari 5.0.5 - ToT): crash in SVG test dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/animate-elem-39-t.html
https://bugs.webkit.org/show_bug.cgi?id=64671

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-21
Reviewed by Nikolas Zimmermann.

Source/WebCore:

No new tests. This change is to fix crashes in existing tests.

* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::beginListChanged): If the new begin time is
later than the current end time, and the event time is also after then
end time (but we have not yet updated to that time) and the animation
is active, we need to make the animation inactive explicitly.

LayoutTests:

* platform/chromium/test_expectations.txt: Marking all svg/W3C-SVG-1.1/animate-elem* tests
as flakey pending this change being committed and new results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake WebKit2 remember the height of the Web Inspector when it is docked.
timothy@apple.com [Sat, 21 Jan 2012 08:42:55 +0000 (08:42 +0000)]
Make WebKit2 remember the height of the Web Inspector when it is docked.

https://webkit.org/b/76769

Reviewed by Dan Bernstein.

* Shared/WebPreferencesStore.h: Added InspectorAttachedHeight.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call WebPreferencesStore::setInspectorAttachedHeight.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Set the height of the inspector's WKView to inspectorAttachedHeight.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Remove unneeded setNeedsDisplay: calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPopupMenuClient::multiple() should be const
commit-queue@webkit.org [Sat, 21 Jan 2012 08:17:29 +0000 (08:17 +0000)]
PopupMenuClient::multiple() should be const
https://bugs.webkit.org/show_bug.cgi?id=76771

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-21
Reviewed by Kent Tamura.

* platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::multiple):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
* rendering/RenderMenuList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSwitch indexeddb to use supplemental IDL for DOMWindow
commit-queue@webkit.org [Sat, 21 Jan 2012 06:06:50 +0000 (06:06 +0000)]
Switch indexeddb to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76723

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-01-20
Reviewed by Adam Barth.

No new tests required, all existing tests pass.

* Modules/indexeddb: Added.
* Modules/indexeddb/DOMWindowIndexedDatabase.cpp: Added. webkitIndexedDB() method previously in DOMWindow.cpp
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::~DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
* Modules/indexeddb/DOMWindowIndexedDatabase.h: Added.
* Modules/indexeddb/DOMWindowIndexedDatabase.idl: Added. attributes previously in DOMWindow.idl
* WebCore.gyp/WebCore.gyp: add Modules/indexeddb/ directory
* WebCore.gypi: add Modules/indexeddb/*
* page/DOMWindow.cpp: remove webkitIndexedDB() method, add accessor methods for m_idbFactory
(WebCore::DOMWindow::getIDBFactory):
(WebCore::DOMWindow::setIDBFactory):
* page/DOMWindow.h:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow isContextThread to be called while in ~ScriptExecutionContext.
levin@chromium.org [Sat, 21 Jan 2012 04:11:08 +0000 (04:11 +0000)]
Allow isContextThread to be called while in ~ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=76756

Reviewed by Adam Barth.

It is possible for objects to get torn down or get called from ~ScriptExecutionContext
and in turn call isContextThread. The resulting behavior is undefined. This change defines
the behavior. I don't know of any places that do this but I have a test that is rarely
failing due to isContextThread being false. This is my best guess as to why, and I
don't see a reason to try to avoid calling isContextThread at this point.

No new functionality exposed so no new tests.

* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isContextThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less...
levin@chromium.org [Sat, 21 Jan 2012 03:32:29 +0000 (03:32 +0000)]
The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
https://bugs.webkit.org/show_bug.cgi?id=76752

Reviewed by Eric Seidel.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_for_leaky_patterns):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(LeakyPatternTest.test_create_dc):
(LeakyPatternTest.test_create_compatible_dc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Write unit tests for compositor-thread zooming
commit-queue@webkit.org [Sat, 21 Jan 2012 03:19:11 +0000 (03:19 +0000)]
[chromium] Write unit tests for compositor-thread zooming
https://bugs.webkit.org/show_bug.cgi?id=71529

Patch by Alexandre Elias <aelias@google.com> on 2012-01-20
Reviewed by James Robinson.

Add unit tests for pinch zoom and page scale animation.  Includes
small cleanups in CCLayerTreeHostImpl for testability.

Source/WebCore:

* platform/graphics/chromium/cc/CCInputHandler.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] [WK2] Division by zero error in QtViewportInteractionEngine::setItemRectVisible
ostapenko.viatcheslav@nokia.com [Sat, 21 Jan 2012 03:03:59 +0000 (03:03 +0000)]
[Qt] [WK2] Division by zero error in QtViewportInteractionEngine::setItemRectVisible
https://bugs.webkit.org/show_bug.cgi?id=76674

Reviewed by Kenneth Rohde Christiansen.

Make sure that itemRect is not empty.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::setItemRectVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Incremental texture updates are not atomic.
commit-queue@webkit.org [Sat, 21 Jan 2012 02:49:08 +0000 (02:49 +0000)]
[Chromium] Incremental texture updates are not atomic.
https://bugs.webkit.org/show_bug.cgi?id=72672

Patch by David Reveman <reveman@chromium.org> on 2012-01-20
Reviewed by James Robinson.

Source/WebCore:

Use a new set of textures for each commit when incremental
texture updates are enabled.

This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommit.runMultiThread

* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::steal):
* platform/graphics/chromium/ManagedTexture.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::partialTextureUpdateCapability):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::partialTextureUpdateCapability):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Add CCLayerTreeHostTestAtomicCommit test that verifies atomicity
of commits.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockContentLayerDelegate::drawsContent):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::notifySyncRequired):
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(WTF::CCLayerTreeHostTestAtomicCommit::afterTest):
(WTF::TEST_F):
* tests/CompositorFakeWebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-zippering incorrectly snaps to target gain
crogers@google.com [Sat, 21 Jan 2012 02:34:07 +0000 (02:34 +0000)]
De-zippering incorrectly snaps to target gain
https://bugs.webkit.org/show_bug.cgi?id=76741

Reviewed by Kenneth Russell.

* platform/audio/AudioBus.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Partially filled pixels do not occlude pixels below them.
commit-queue@webkit.org [Sat, 21 Jan 2012 02:21:02 +0000 (02:21 +0000)]
[chromium] Partially filled pixels do not occlude pixels below them.
https://bugs.webkit.org/show_bug.cgi?id=76658

Patch by Dana Jansens <danakj@chromium.org> on 2012-01-20
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/culling/tile-occlusion-boundaries.html

* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::enclosedIntRect):
(WebCore::CCQuadCuller::cullOccludedQuads):

LayoutTests:

* compositing/culling/tile-occlusion-boundaries-expected.png: Added.
* compositing/culling/tile-occlusion-boundaries-expected.txt: Added.
* compositing/culling/tile-occlusion-boundaries.html: Added.
* compositing/resources/green.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanged my status in commiters.py
shawnsingh@chromium.org [Sat, 21 Jan 2012 02:06:04 +0000 (02:06 +0000)]
Changed my status in commiters.py

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSmall cleanup of {get,put}CurrentFrame for WebMediaPlayerClientImpl/CCVideoLayerImpl.
commit-queue@webkit.org [Sat, 21 Jan 2012 01:34:07 +0000 (01:34 +0000)]
Small cleanup of {get,put}CurrentFrame for  WebMediaPlayerClientImpl/CCVideoLayerImpl.
https://bugs.webkit.org/show_bug.cgi?id=76332

Patch by Ami Fischman <fischman@chromium.org> on 2012-01-20
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):

Source/WebKit/chromium:

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDrag/drop of a file into a WebView on Windows needs to allow access to that file
sfalken@apple.com [Sat, 21 Jan 2012 01:16:49 +0000 (01:16 +0000)]
Drag/drop of a file into a WebView on Windows needs to allow access to that file
https://bugs.webkit.org/show_bug.cgi?id=76753
<rdar://problem/10731719>

Reviewed by Alexey Proskuryakov.

The Windows drag/drop code path was missing the code to open a file read exception.

Added code to match the Mac version, while allowing directories and multiple files to
also be dragged (matching our previous behavior).

* UIProcess/win/WebView.cpp:
(WebKit::maybeCreateSandboxExtensionFromDragData): Added.
(WebKit::WebView::Drop): Add a universal read exception if we're dragging a file into a WebView to open it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a Chromium-specific baselines for
abarth@webkit.org [Sat, 21 Jan 2012 01:11:27 +0000 (01:11 +0000)]
Add a Chromium-specific baselines for
fast/dom/Window/open-invalid-url.html.  Although this expected result
says "FAIL", the behavior seems to be reasonable.

* platform/chromium/fast/dom/Window/open-invalid-url-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764 Frequent...
beidson@apple.com [Sat, 21 Jan 2012 00:45:19 +0000 (00:45 +0000)]
<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764 Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache

Reviewed by Sam Weinig.

No way to reproduce without special malloc debugging and that doesn't even reproduce on all platforms.  So still no test.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame): Protect m_frame for the duration of this method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake OwnPtr<HDC> work for the Chromium Windows port.
levin@chromium.org [Sat, 21 Jan 2012 00:36:54 +0000 (00:36 +0000)]
Make OwnPtr<HDC> work for the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76738

Reviewed by Jian Li.

* JavaScriptCore.gyp/JavaScriptCore.gyp: Added OwnPtrWin.cpp to the
Chromium Windows build.
* wtf/OwnPtrCommon.h: Changed from platform WIN to OS WIN for
OwnPtr<HDC> and similar constructs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago WebCore should not send invalid URLs to client createWindow methods.
ap@apple.com [Sat, 21 Jan 2012 00:09:34 +0000 (00:09 +0000)]
    WebCore should not send invalid URLs to client createWindow methods.
        https://bugs.webkit.org/show_bug.cgi?id=39017

        Unreviewed test fix.

        * page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): Let empty URLs through.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll Chromium DEPS from 118291 to 118493.
rniwa@webkit.org [Sat, 21 Jan 2012 00:05:23 +0000 (00:05 +0000)]
Roll Chromium DEPS from 118291 to 118493.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake WebCore RunLoop work for WebKit1
weinig@apple.com [Sat, 21 Jan 2012 00:03:13 +0000 (00:03 +0000)]
Make WebCore RunLoop work for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76739

Reviewed by Anders Carlsson.

Source/WebCore:

* platform/RunLoop.cpp:
Specialize RunLoop initialization for Mac, where it can happen on any thread.

* platform/RunLoop.h:
Add RunLoop constructor that takes a CFRunLoopRef on the mac for initializing
the main thread.

* platform/mac/RunLoopMac.mm:
(WebCore::RunLoop::initializeMainRunLoop):
Add new implementation that can work from any thread (and multiple threads at the
same time if necessary).

(WebCore::RunLoop::current):
Treat the main thread specially, not storing it in thread specific data.

(WebCore::RunLoop::main):
Copy main accessor since it needs access to the file static.

(WebCore::RunLoop::RunLoop):
Add constructor which takes a CFRunLoopRef.

Source/WebKit/mac:

* Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter initialize]):
* History/WebBackForwardList.mm:
(+[WebBackForwardList initialize]):
* History/WebHistoryItem.mm:
(+[WebHistoryItem initialize]):
* Misc/WebElementDictionary.mm:
(+[WebElementDictionary initialize]):
* Misc/WebIconDatabase.mm:
(+[WebIconDatabase initialize]):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(+[WebHostedNetscapePluginView initialize]):
* Plugins/WebBaseNetscapePluginView.mm:
* Plugins/WebBasePluginPackage.mm:
* Plugins/WebNetscapePluginView.mm:
(+[WebNetscapePluginView initialize]):
* WebCoreSupport/WebEditorClient.mm:
(+[WebUndoStep initialize]):
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]):
* WebView/WebDataSource.mm:
(+[WebDataSourcePrivate initialize]):
* WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):
* WebView/WebResource.mm:
(+[WebResourcePrivate initialize]):
* WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]):
* WebView/WebView.mm:
(+[WebView initialize]):
* WebView/WebViewData.mm:
(+[WebViewPrivate initialize]):
Initialized the main run loop in addition to other initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105552 268f45cc-cd09-0410-ab3c-d52691b4dbfc