WebKit-https.git
14 years ago Reviewed by Eric.
thatcher [Mon, 3 Jul 2006 08:03:57 +0000 (08:03 +0000)]
    Reviewed by Eric.

        Bug 9628: [Drosera] Split Views acting oddly
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9628

        Only update the last X or Y coordinate if the new
        size was not constrained. Also adds the resize cursor to
        the body during the drag incase there is a constrained
        over drag off of the resizer element.

        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and landed by ggaren.
ggaren [Sun, 2 Jul 2006 23:36:57 +0000 (23:36 +0000)]
    Reviewed and landed by ggaren.

        * platform/gdk/TransferJobManager.cpp
        Fixed broken dowload logic
        * platform/gdk/ScrollViewGdk.cpp
        Add comment that scrollbarSize is a temporary variable
        * Projects/gdk/webcore-gdk.bkl
        Defined NDEBUG build executable is miscompiled otherwise
        * WebCoreSources.bkl
        added icon/SiteIcon.cpp editing/IndentOutdentCommand.cpp
        html/HTMLViewSourceDocument.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
ggaren [Sun, 2 Jul 2006 18:17:08 +0000 (18:17 +0000)]
    Reviewed by Adele.

        - Fixed <rdar://problem/4611197> REGRESSION: Liveconnect with Java test
        fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html

        * JavaScriptCore.exp: Export symbols used by liveconnect

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sun, 2 Jul 2006 13:05:27 +0000 (13:05 +0000)]
WebKitTools:

        Reviewed by Alexy Proskuryakov.  Patch by Mark Rowe.

        Bug 9692: Warning about Safari extensions on every launch is obnoxious
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9692

        * WebKitLauncher/WebKitNightlyEnabler.m:
        (myApplicationWillTerminate): Note that we are exiting cleanly.
        (cleanUpAfterOurselves): Install bundle load tracking only if we failed
         to exit cleanly on our last invocation.  This doesn't play nicely with
         multiple concurrent instances of WebKit.app so it can be disabled via
         defaults write com.apple.Safari WKNEShouldMonitorShutdowns -bool NO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sun, 2 Jul 2006 12:23:36 +0000 (12:23 +0000)]
WebKitTools:

        Reviewed by Alexy Proskuryakov.  Patch by Mark Rowe.

        Bug 9654: Refresh Loop when accessing feed URLs
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9654

        * WebKitLauncher/Info.plist: Don't claim to handle feed:// URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sun, 2 Jul 2006 12:02:38 +0000 (12:02 +0000)]
WebKitTools:

        Reviewed by Timothy Hatcher.  Patch by Mark Rowe.

        Bug 9689: Nightly builds should warn a user about potential problems when using
        "Safari extensions"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9689

        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
        * WebKitLauncher/WebKitNightlyEnabler.m:
        (myBundleDidLoad): Keep track of if any bundles that are loaded.
        (myApplicationWillFinishLaunching):  Notify user if any bundles are loaded.
        (cleanUpAfterOurselves): Register for NSBundleDidLoadNotification and
        NSApplicationWillFinishLaunchingNotification notifications so that we can
        track bundle loads and notify the user at launch completion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 2 Jul 2006 11:59:06 +0000 (11:59 +0000)]
WebCore:

        Reviewed by Timothy Hatcher.  Build fix for Linux.  Patch by Shawn Stricker.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9684
          [GDK] multiple little fixes and a few new things for Templinkstubs

        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::setDrawable): Changed SCROLLBAR_SIZE to scrollbarSize.
        * platform/gdk/TemporaryLinkStubs.cpp:
        (Image::drawTiled): Added missing parameter to argument list.
        * platform/gdk/TransferJobManager.cpp:
        (WebCore::writeCallback): Added missing parenthesis to static_cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 2 Jul 2006 11:39:43 +0000 (11:39 +0000)]
WebCore:

        Reviewed by Darin.  Patch by Mitz.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9674
          REGRESSION (r15075): Blank or incomplete pages on digg.com

        Replaced the requestingScript state bit added in the fix for bug 9317
        with a m_requestingScript bool that is set before and restored
        after calling ref() on a CachedScript.

        Test: fast/tokenizer/nested-cached-scripts.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::HTMLTokenizer):
        (WebCore::HTMLTokenizer::begin):
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::notifyFinished):
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::State::):

LayoutTests:

        Reviewed by Darin.  Patch by Mitz.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9674
          REGRESSION (r15075): Blank or incomplete pages on digg.com

        * fast/tokenizer/nested-cached-scripts-expected.txt: Added.
        * fast/tokenizer/nested-cached-scripts.html: Added.
        * fast/tokenizer/resources/nested-1.js: Added.
        * fast/tokenizer/resources/nested-2.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ggaren [Sun, 2 Jul 2006 04:06:07 +0000 (04:06 +0000)]
    Reviewed by Maciej.

        - Phase 2 in the JS API.

        - Added support for specifying static tables of values -- this should
        obviate the need for using complicated callbacks for most lookups.

        -  API objects are now created with classes (JSClassRef) -- in order to support
        static values, and in order to prevent API objects from storing their
        data inline, and thus falling into the oversized (read: slow and prone to
        giving Maciej the frowny face) heap.

        - Added two specialized JSObject subclasses -- JSCallbackFunction and JSCallbackConstructor --
        to allow JSFunctionMake and JSConstructorMake to continue to work with
        the new class model. Another solution to this problem would be to create
        a custom class object for each function and constructor you make. This
        solution is more code but also more efficient.

        - Substantially beefed up the minidom example to demonstrate and test a
        lot of these techniques. Its output is still pretty haphazard, though.

        - Gave the <kjs/ preface to some includes -- I'm told this matters to
        building on some versions of Linux.

        - Implemented JSValueIsInstanceOf and JSValueIsObjectOfClass

        - Removed GetDescription callback. Something in the class datastructure
        should take care of this.

        * API/JSBase.h:
        * API/JSCallbackConstructor.cpp: Added.
        (KJS::):
        (KJS::JSCallbackConstructor::JSCallbackConstructor):
        (KJS::JSCallbackConstructor::implementsConstruct):
        (KJS::JSCallbackConstructor::construct):
        (KJS::JSCallbackConstructor::setPrivate):
        (KJS::JSCallbackConstructor::getPrivate):
        * API/JSCallbackConstructor.h: Added.
        (KJS::JSCallbackConstructor::classInfo):
        * API/JSCallbackFunction.cpp: Added.
        (KJS::):
        (KJS::JSCallbackFunction::JSCallbackFunction):
        (KJS::JSCallbackFunction::implementsCall):
        (KJS::JSCallbackFunction::callAsFunction):
        (KJS::JSCallbackFunction::setPrivate):
        (KJS::JSCallbackFunction::getPrivate):
        * API/JSCallbackFunction.h: Added.
        (KJS::JSCallbackFunction::classInfo):
        * API/JSCallbackObject.cpp:
        (KJS::):
        (KJS::JSCallbackObject::JSCallbackObject):
        (KJS::JSCallbackObject::init):
        (KJS::JSCallbackObject::~JSCallbackObject):
        (KJS::JSCallbackObject::className):
        (KJS::JSCallbackObject::getOwnPropertySlot):
        (KJS::JSCallbackObject::put):
        (KJS::JSCallbackObject::deleteProperty):
        (KJS::JSCallbackObject::implementsConstruct):
        (KJS::JSCallbackObject::construct):
        (KJS::JSCallbackObject::implementsCall):
        (KJS::JSCallbackObject::callAsFunction):
        (KJS::JSCallbackObject::getPropertyList):
        (KJS::JSCallbackObject::toBoolean):
        (KJS::JSCallbackObject::toNumber):
        (KJS::JSCallbackObject::toString):
        (KJS::JSCallbackObject::inherits):
        (KJS::JSCallbackObject::staticValueGetter):
        (KJS::JSCallbackObject::staticFunctionGetter):
        (KJS::JSCallbackObject::callbackGetter):
        * API/JSCallbackObject.h:
        * API/JSCharBufferRef.cpp:
        * API/JSClassRef.cpp: Added.
        (JSClassCreate):
        (JSClassRetain):
        (JSClassRelease):
        * API/JSClassRef.h: Added.
        (StaticValueEntry::StaticValueEntry):
        (StaticFunctionEntry::StaticFunctionEntry):
        (__JSClass::__JSClass):
        * API/JSContextRef.cpp:
        (JSContextCreate):
        (JSEvaluate):
        * API/JSContextRef.h:
        * API/JSNode.c: Added.
        (JSNodePrototype_appendChild):
        (JSNodePrototype_removeChild):
        (JSNodePrototype_replaceChild):
        (JSNodePrototype_class):
        (JSNode_getNodeType):
        (JSNode_getChildNodes):
        (JSNode_getFirstChild):
        (JSNode_finalize):
        (JSNode_class):
        (JSNode_prototype):
        (JSNode_new):
        (JSNode_construct):
        * API/JSNode.h: Added.
        * API/JSNodeList.c: Added.
        (JSNodeListPrototype_item):
        (JSNodeListPrototype_class):
        (JSNodeList_length):
        (JSNodeList_getProperty):
        (JSNodeList_finalize):
        (JSNodeList_class):
        (JSNodeList_prototype):
        (JSNodeList_new):
        * API/JSNodeList.h: Added.
        * API/JSObjectRef.cpp:
        (JSObjectMake):
        (JSFunctionMake):
        (JSConstructorMake):
        (__JSPropertyEnumerator::__JSPropertyEnumerator):
        (JSObjectCreatePropertyEnumerator):
        (JSPropertyEnumeratorGetNext):
        (JSPropertyEnumeratorRetain):
        (JSPropertyEnumeratorRelease):
        * API/JSObjectRef.h:
        (__JSObjectCallbacks::):
        * API/JSValueRef.cpp:
        (JSValueIsObjectOfClass):
        (JSValueIsInstanceOf):
        * API/JSValueRef.h:
        * API/Node.c: Added.
        (Node_new):
        (Node_appendChild):
        (Node_removeChild):
        (Node_replaceChild):
        (Node_ref):
        (Node_deref):
        * API/Node.h: Added.
        * API/NodeList.c: Added.
        (NodeList_new):
        (NodeList_length):
        (NodeList_item):
        (NodeList_ref):
        (NodeList_deref):
        * API/NodeList.h: Added.
        * API/minidom.c:
        (main):
        (print):
        (createStringWithContentsOfFile):
        * API/minidom.js:
        * API/testapi.c:
        (assertEqualsAsCharacters):
        (MyObject_getProperty):
        (MyObject_class):
        (myConstructor_callAsConstructor):
        (main):
        * API/testapi.js:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 2 Jul 2006 03:20:02 +0000 (03:20 +0000)]
WebCore:

        Reviewed by NOBODY (build fix).

        * platform/gdk/TransferJobManager.cpp:
        (WebCore::writeCallback): Changed 'static_cat' to 'static_cast'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit:
ddkilzer [Sun, 2 Jul 2006 02:50:01 +0000 (02:50 +0000)]
WebKit:

        Reviewed by NOBODY (fixed Tim's build fix).

        * WebView/WebView.m: Added back missing '/' at the beginning of the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by NOBODY (build fix)
tomernic [Sun, 2 Jul 2006 01:31:12 +0000 (01:31 +0000)]
    Reviewed by NOBODY (build fix)

        * WebView/WebView.m:
        (-[WebView _isMIMETypeRegisteredAsPlugin:]):
        Changed nil to NO (typo).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix for case-sensitive filesystems.
thatcher [Sat, 1 Jul 2006 19:08:09 +0000 (19:08 +0000)]
Build fix for case-sensitive filesystems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and tweaked by Darin.
darin [Sat, 1 Jul 2006 05:02:23 +0000 (05:02 +0000)]
    Reviewed and tweaked by Darin.

        - Compile fixes for wx port / gcc 4.0.2

        * kjs/array_object.cpp:
        Added missing headers.

        * kjs/ExecState.h:
        gcc needs class prototypes before defining those classes as friend classes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and worked over a lot by Darin.
darin [Sat, 1 Jul 2006 04:39:50 +0000 (04:39 +0000)]
    Reviewed and worked over a lot by Darin.

        - check in first set of GDK-specific sources

        * platform/gdk/BrowserExtensionGdk.h: Added.
        * platform/gdk/CookieJarGdk.cpp: Added.
        * platform/gdk/CursorGdk.cpp: Added.
        * platform/gdk/FontCacheGdk.cpp: Added.
        * platform/gdk/FontDataGdk.cpp: Added.
        * platform/gdk/FontGdk.cpp: Added.
        * platform/gdk/FontPlatformData.h: Added.
        * platform/gdk/FontPlatformDataGdk.cpp: Added.
        * platform/gdk/FrameGdk.cpp: Added.
        * platform/gdk/FrameGdk.h: Added.
        * platform/gdk/GlyphMapGdk.cpp: Added.
        * platform/gdk/KeyEventGdk.cpp: Added.
        * platform/gdk/KeyboardCodes.h: Added.
        * platform/gdk/MouseEventGdk.cpp: Added.
        * platform/gdk/PageGdk.cpp: Added.
        * platform/gdk/RenderThemeGdk.cpp: Added.
        * platform/gdk/RenderThemeGdk.h: Added.
        * platform/gdk/ScreenGdk.cpp: Added.
        * platform/gdk/ScrollViewGdk.cpp: Added.
        * platform/gdk/SharedTimerLinux.cpp: Added.
        * platform/gdk/SystemTimeLinux.cpp: Added.
        * platform/gdk/TemporaryLinkStubs.cpp: Added.
        * platform/gdk/TransferJobCurl.cpp: Added.
        * platform/gdk/TransferJobManager.cpp: Added.
        * platform/gdk/TransferJobManager.h: Added.
        * platform/gdk/WheelEventGdk.cpp: Added.
        * platform/gdk/WidgetGdk.cpp: Added.
        * platform/gdk/gdk-encodings.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Sat, 1 Jul 2006 04:24:46 +0000 (04:24 +0000)]
    Reviewed by Darin.

        * WebCoreSources.bkl: Updated for recent file changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and enhanced by Darin.
darin [Sat, 1 Jul 2006 04:23:22 +0000 (04:23 +0000)]
    Reviewed and enhanced by Darin.

        Compilation fixes for Linux/Gdk.

        * WebCore/platform/FontData.h: Added forward declaration of a class.
        * WebCore/platform/cairo/GraphicsContextCairo.cpp: Fixed case on include.
        * WebCore/bindings/js/kjs_html.cpp: Added <math.h> include.

        * WebCore/css/maketokenizer: Fixed incorrect check for Linux that was
        already true even on Mac OS X. Added some additional includes and
        defines to the Linux extra generated code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sat, 1 Jul 2006 02:51:32 +0000 (02:51 +0000)]
WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7204
          float inserted in fixed height block via DOM not repainted

        Test: fast/repaint/float-move-during-layout.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::repaintOverhangingFloats): Renamed repaintFloatingDescendants()
        to this and limited it to repainting overhanging floats. Added a boolean parameter that forces
        all descendant overhanging floats (that don't have their own layer) to paint.
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::repaintDuringLayoutIfMoved): Changed to paint all descendant
        floats.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintOverhangingFloats):
        * rendering/RenderObject.h:

LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7204
          float inserted in fixed height block via DOM not repainted

        * fast/repaint/float-move-during-layout-expected.checksum: Added.
        * fast/repaint/float-move-during-layout-expected.png: Added.
        * fast/repaint/float-move-during-layout-expected.txt: Added.
        * fast/repaint/float-move-during-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanges by Mike Emmel.
darin [Sat, 1 Jul 2006 01:33:37 +0000 (01:33 +0000)]
Changes by Mike Emmel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Sat, 1 Jul 2006 01:32:57 +0000 (01:32 +0000)]
    Reviewed by Darin.

        - first check-in of a Gdk shell for testing WebKit

        * GdkLauncher: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Sat, 1 Jul 2006 01:31:08 +0000 (01:31 +0000)]
    Reviewed by Darin.

        Compilation fixes for Linux/Gdk.

        * JavaScriptCore/kjs/interpreter.cpp: added include of signal.h
        * JavaScriptCore/kjs/ExecState.h: added missing class declaration
        * JavaScriptCore/kjs/ExecState.cpp: case wrong on include of context.h
        * JavaScriptCore/JavaScriptCoreSources.bkl: added Context.cpp and ExecState.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
lweintraub [Fri, 30 Jun 2006 23:47:09 +0000 (23:47 +0000)]
LayoutTests:

        Reviewed by justin

        * editing/execCommand/format-block-with-trailing-br-expected.checksum: Added.
        * editing/execCommand/format-block-with-trailing-br-expected.png: Added.
        * editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
        * editing/execCommand/format-block-with-trailing-br.html: Added.

WebCore:

        Reviewed by justin

        * editing/VisiblePosition.cpp: Removed is[Not]EqualIgnoringAffinity and made operator== use the logic that ignores affinity.
        * editing/VisiblePosition.h: Ditto.
        (WebCore::operator==):
        * editing/visible_units.cpp:
        (WebCore::isStartOfParagraph): Changed to compare VisiblePositions using ==.
        (WebCore::isEndOfParagraph): Ditto.
        (WebCore::isStartOfBlock): Ditto.
        (WebCore::isEndOfBlock): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning
thatcher [Fri, 30 Jun 2006 23:35:16 +0000 (23:35 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixed the test case that I just checked in.
justing [Fri, 30 Jun 2006 22:32:52 +0000 (22:32 +0000)]
Fixed the test case that I just checked in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Fri, 30 Jun 2006 22:17:51 +0000 (22:17 +0000)]
LayoutTests:

        Reviewed by levi

        * editing/pasteboard/pasting-object-expected.checksum: Added.
        * editing/pasteboard/pasting-object-expected.png: Added.
        * editing/pasteboard/pasting-object-expected.txt: Added.
        * editing/pasteboard/pasting-object.html: Added.

WebCore:

        Reviewed by levi

        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing): Don't insert children into
        object tags while editing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Fri, 30 Jun 2006 19:43:03 +0000 (19:43 +0000)]
LayoutTests:

        Reviewed by harrison

        Added:
        * editing/selection/skip-non-editable-1-expected.txt: Added.
        * editing/selection/skip-non-editable-1.html: Added.
        * editing/selection/skip-non-editable-2-expected.txt: Added.
        * editing/selection/skip-non-editable-2.html: Added.

        Equivalent render tree:
        * editing/execCommand/format-block-with-braces-expected.txt:

        Fixes:
        * editing/selection/iframe-expected.checksum:
        * editing/selection/iframe-expected.png:
        * editing/selection/iframe-expected.txt:
        * editing/selection/inline-table-expected.checksum:
        * editing/selection/inline-table-expected.png:
        * editing/selection/inline-table-expected.txt:
        * editing/selection/move-between-blocks-no-001-expected.checksum:
        * editing/selection/move-between-blocks-no-001-expected.png:
        * editing/selection/move-between-blocks-no-001-expected.txt:
        * editing/selection/select-box-expected.checksum:
        * editing/selection/select-box-expected.png:
        * editing/selection/select-box-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4598309
        Caret gets stuck when it hits non editable content within an editable body
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9510>
        Caret will jump out of an editable region

        * dom/Position.cpp:
        (WebCore::Position::upstream): Don't move into a new editable region so that
        candidates that that straddle an editable/non-editable boundary will
        correspond to different VisiblePositions.
        (WebCore::Position::downstream): Ditto.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyMovingRightForward): Use VisiblePosition::next(true)
        (WebCore::SelectionController::modifyMovingLeftBackward): Use VisiblePosition::previous(true)
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next): Added code to jump to the next editable region as long
        as it has the same highest editable root.
        (WebCore::VisiblePosition::previous): Ditto.
        * editing/VisiblePosition.h:
        * editing/htmlediting.cpp:
        (WebCore::highestEditableRoot): Added, returns the highest editable root of a node if that
        node is in editable content, otherwise 0.
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Fri, 30 Jun 2006 19:09:54 +0000 (19:09 +0000)]
WebCore:

        Reviewed by Darin.

        - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9358
          REGRESSION: Assertion failure in HTMLInputElement::setValueFromRenderer
          (value == constrainValue(value)) when deleting all text

        Test: editing/deleting/delete-all-text-in-text-field-assertion.html

        Bug 9661 filed to fix the follow-up issue:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9661
        textContent returns "\n" for a <br> even if it is collapsed

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValueFromRenderer): Work around "\n" value
        when all characters are deleted from a text field.

LayoutTests:

        Reviewed by Darin.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9358
          REGRESSION: Assertion failure in HTMLInputElement::setValueFromRenderer
          (value == constrainValue(value)) when deleting all text

        * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Added.
        * editing/deleting/delete-all-text-in-text-field-assertion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Fri, 30 Jun 2006 18:56:59 +0000 (18:56 +0000)]
    Reviewed by Darin.

        Only enable shouldCloseWithWindow when ObjC GC is enabled.
        This maintains backwards compatibility with applications
        that expect a WebView to be usable after the window closes.

        * WebView/WebView.m:
        (-[WebViewPrivate init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick
harrison [Fri, 30 Jun 2006 17:53:21 +0000 (17:53 +0000)]
    Reviewed by Tim Omernick

        <rdar://problem/4609481> Crash calling -[WebScriptObject valueForKey:] when JS disabled

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::executionContextForDOM):
        Early return if JS is not enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
thatcher [Fri, 30 Jun 2006 17:35:00 +0000 (17:35 +0000)]
    Reviewed by Anders.

        Call _close in dealloc to ensure we cleanup for backwards
        compatibility. This will safeguard and cleanup even if the
        application doesn't use the new close API yet, like Mail.

        * WebView/WebView.m:
        (-[WebView dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
thatcher [Fri, 30 Jun 2006 14:05:51 +0000 (14:05 +0000)]
    Reviewed by Tim H.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9664
          REGRESSION (r15106): Crash in fast/events/mouseover-mouseout2.html

        * page/FrameView.cpp:
        (WebCore::FrameView::handleMouseMoveEvent): Added a check that oldSubframe is
        still a subframe of the view's frame before passing the event to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
thatcher [Fri, 30 Jun 2006 07:29:33 +0000 (07:29 +0000)]
WebCore:

        Reviewed by Darin.

        <rdar://problem/3694163> -[KWQPageState finalize] is incorrect; design change needed
        <rdar://problem/3694165> -[WebCoreFrameBridge finalize] is incorrect; design change needed

        Added close methods that need to be called before these
        objects can be released. This ensures proper tear-down under GC.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge dealloc]):
        (-[WebCoreFrameBridge finalize]):
        (-[WebCoreFrameBridge close]):
        * bridge/mac/WebCorePageBridge.h:
        * bridge/mac/WebCorePageBridge.mm:
        (-[WebCorePageBridge setMainFrame:]):
        (-[WebCorePageBridge dealloc]):
        (-[WebCorePageBridge finalize]):
        (-[WebCorePageBridge close]):
        (-[WebCorePageBridge mainFrame]):
        (-[WebCorePageBridge setGroupName:]):
        (-[WebCorePageBridge groupName]):
        * kwq/KWQPageState.h:
        * kwq/KWQPageState.mm:
        (-[KWQPageState dealloc]):
        (-[KWQPageState finalize]):
        (-[KWQPageState close]):

WebKit:

        Reviewed by Darin.

        <rdar://problem/4484405> WebKit leaks, improper tear-down
        <rdar://problem/3694059> -[WebBackForwardList finalize] is incorrect; design change needed
        <rdar://problem/3694103> -[WebFrame finalize] is incorrect; design change needed
        <rdar://problem/3694104> -[WebHTMLView finalize] is incorrect; design change needed

        Adds a close method to WebView, this needs to be called when the
        WebView is no longer needed. To make this easier for the common cases
        there is now an "auto close" on WebView that listens to the view's
        parent window. If the parent window closes and the WebView has no
        hostWindow then the WebView is automatically closed if autoClose is YES.
        To manage WebView closing yourself call setAutoClose: and pass NO.

        When a WebView closes it will tear-down and not be usable anymore.
        Close will will called on various other internal objects as a part
        of this, to ensure proper tear-down in GC without relying on finalize.

        * History/WebBackForwardList.m:
        (-[WebBackForwardList dealloc]):
        (-[WebBackForwardList finalize]):
        (-[WebBackForwardList _close]):
        * History/WebHistoryItem.m:
        (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
        (+[WebHistoryItem _releaseAllPendingPageCaches]):
        * History/WebHistoryItemPrivate.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge close]):
        (-[WebFrameBridge saveDocumentToPageCache:]):
        (-[WebFrameBridge canGoBackOrForward:]):
        * WebView/WebFrame.m:
        (-[WebFrame _detachFromParent]):
        (-[WebFrame dealloc]):
        (-[WebFrame finalize]):
        * WebView/WebFrameView.m:
        (-[WebFrameView _setWebFrame:]):
        (-[WebFrameView finalize]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView close]):
        (-[NSArray dealloc]):
        (-[NSArray finalize]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:
        * WebView/WebScriptDebugDelegate.m:
        (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
        (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):
        (-[WebScriptCallFrame enteredFrame:sourceId:line:]):
        (-[WebScriptCallFrame hitStatement:sourceId:line:]):
        (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
        * WebView/WebScriptDebugDelegatePrivate.h:
        * WebView/WebView.m:
        (-[WebViewPrivate init]):
        (-[WebView _close]):
        (-[WebView dealloc]):
        (-[WebView finalize]):
        (-[WebView viewWillMoveToWindow:]):
        (-[WebView _windowWillClose:]):
        (-[WebView setPreferencesIdentifier:]):
        (-[WebView mainFrame]):
        (-[WebView setHostWindow:]):
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
        (-[WebView close]):
        (-[WebView setAutoClose:]):
        (-[WebView autoClose]):
        (-[WebView _frameViewAtWindowPoint:]):
        * WebView/WebViewPrivate.h:

WebKitTools:

        Reviewed by Darin.

        Need to call window close so WebView tears-down completly.

        * DumpRenderTree/DumpRenderTree.m:
        (main): call [window close]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Fri, 30 Jun 2006 06:36:22 +0000 (06:36 +0000)]
WebCore:

        Reviewed by Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4874
        Table with absolute bottom positioning is positioned incorrectly

        Note: patch originally from Mitz, spruced up by Weinig.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout):

LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4874
        Table with absolute bottom positioning is positioned incorrectly

        Note: test case originally from Mitz.

        * fast/table/absolute-table-at-bottom-expected.checksum: Added.
        * fast/table/absolute-table-at-bottom-expected.png: Added.
        * fast/table/absolute-table-at-bottom-expected.txt: Added.
        * fast/table/absolute-table-at-bottom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by mjs and timo.
kdecker [Fri, 30 Jun 2006 05:56:59 +0000 (05:56 +0000)]
    Reviewed by mjs and timo.

        Fixed: <rdar://problem/4609119> handleAuthenticationFromResource was removed; needed by the Dashboard

        * WebView/WebViewPrivate.h: Added handleAuthenticationFromResource back into the header. Needed by the
        Dashboard, but was removed in r.14028 on 2006-04-23.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Fri, 30 Jun 2006 05:35:21 +0000 (05:35 +0000)]
WebCore:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9505
          moveParagraphContentsToNewBlockIfNecessary creates a new block outside the current position

        * editing/CompositeEditCommand.cpp:
        Added sanity checking to prevent modifying nodes outside of
        where we should be
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

LayoutTests:

        Reviewed by Justin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9505
         moveParagraphContentsToNewBlockIfNecessary creates a new block outside the current position

        * editing/pasteboard/paste-table-002.html: Added.
        * editing/pasteboard/paste-table-002-expected.checksum: Added.
        * editing/pasteboard/paste-table-002-expected.png: Added.
        * editing/pasteboard/paste-table-002-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Levi.
beidson [Fri, 30 Jun 2006 04:45:43 +0000 (04:45 +0000)]
    Reviewed by Levi.

        In addition to a few small details, logging changes, and style cleanups, this is a stop-gap hack
        for a problem in SQLite's blob handling.  Querying for a blob in a void* form is reproducibly
        returning a corrupt buffer.  The temporary solution is to query for the blob as "quoted text" and
        manually convert the return string into a character buffer.

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::recreateDatabase):
        (WebCore::IconDatabase::createPrivateTables):

        (WebCore::hexToUnsignedChar): These two functions are the text-to-character-data converters for the time being
        (WebCore::hexStringToVector):

        (WebCore::IconDatabase::imageDataForIconID):
        (WebCore::IconDatabase::imageDataForIconURL):
        (WebCore::IconDatabase::imageDataForPageURL):
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::IconDatabase::hasIconForIconURL):
        * icon/IconDatabase.h:  changes the icon data accessors to return a Vector<unsigned char> instead of void*

        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::columnCount):
        (WebCore::SQLStatement::getColumnBlob):
        * icon/SiteIcon.cpp:
        (SiteIcon::getImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Fri, 30 Jun 2006 04:39:24 +0000 (04:39 +0000)]
WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9652
          Assertion failure when changing an RTL table cell to display:none

        Test: fast/table/rtl-cell-display-none-assert.html

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::layoutRows): Corrected the index used as
        the last index in the columnPos vector.

LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9652
          Assertion failure when changing an RTL table cell to display:none

        * fast/table/rtl-cell-display-none-assert-expected.checksum: Added.
        * fast/table/rtl-cell-display-none-assert-expected.png: Added.
        * fast/table/rtl-cell-display-none-assert-expected.txt: Added.
        * fast/table/rtl-cell-display-none-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker.
tomernic [Fri, 30 Jun 2006 04:31:30 +0000 (04:31 +0000)]
    Reviewed by Kevin Decker.

        <rdar://problem/4608487> REGRESSION: reproducible crash in +[WebCoreFrameBridge supportedImageMIMETypes]

        * Plugins/WebPluginDatabase.m:
        (+[WebPluginDatabase setAdditionalWebPlugInPaths:]):
        One might be tempted to add additionalWebPlugInPaths to the global WebPluginDatabase here.
        For backward compatibility with earlier versions of the +setAdditionalWebPlugInPaths: SPI,
        we need to save a copy of the additional paths and not cause a refresh of the plugin DB
        at this time.
        (-[WebPluginDatabase _plugInPaths]):
        Include additionalWebPlugInPaths if this is the global DB.
        (-[WebPluginDatabase refresh]):
        Call -_plugInPaths to get the modified array of paths.  This is similar to what the old code
        (before we had per-WebView plugin search paths).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Fri, 30 Jun 2006 04:24:40 +0000 (04:24 +0000)]
WebKitTools:

        Reviewed by Darin.

        Bug 9615: Buildbot configuration should be in SVN repository
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9615

        Import BuildBot configuration files as used by build.webkit.org.
        auth.py has been stubbed out so that slave passwords are not disclosed.

        * BuildSlaveSupport/build.webkit.org-config/Makefile: Added.
        * BuildSlaveSupport/build.webkit.org-config/buildbot.css: Added.
        * BuildSlaveSupport/build.webkit.org-config/buildbot.tac: Added.
        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/__init__.py: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Added.
        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Fri, 30 Jun 2006 04:20:18 +0000 (04:20 +0000)]
WebKitTools:

        Reviewed by Darin.

        Bug 9614: Nightly builds should notify user if a newer build is available
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9614

        * BuildSlaveSupport/build-launcher-app: Write revision number to WebKit.app's VERSION file.
        * BuildSlaveSupport/build-launcher-dmg: Pass revision number to server-side nightly maintenance
        script so it can keep track of the latest revision.
        * Scripts/run-webkit-tests: Pass build-dumprendertree's exit status through correctly.
        * WebKitLauncher/VERSION: Added.  Placeholder for SVN revision number
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
        * WebKitLauncher/start.html: Retrieve revision number from VERSION file, and pass it through to
        the nightly start page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
darin [Fri, 30 Jun 2006 02:56:14 +0000 (02:56 +0000)]
    Reviewed by Anders.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9622
          showModalDialog returnValue ignored, function result is always "undefined"

        * manual-tests/modal-dialog.html: Added.
        * manual-tests/show-modal-dialog-test.html: Added.

        * page/Frame.cpp: (WebCore::Frame::clear): Call KJSProxy::clear with the
        clearWindowProperties parameter instead of not calling it at all when
        clearWindowProperties is false.

        * bindings/js/kjs_proxy.h: Add boolean clearWindowProperties parameter.
        * bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clear): Pass clearWindowProperties
        variable through to Window::clear instead of not calling it at all.

        * bindings/js/kjs_window.h: Add boolean clearWindowProperties parameter.
        * bindings/js/kjs_window.cpp: (KJS::Window::clear): If clearWindowProperties
        is false, do only the returnValue work, not the rest of the work.

        * manual-tests/modal-dialog.html: Added.
        * manual-tests/show-modal-dialog-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
mjs [Thu, 29 Jun 2006 23:32:47 +0000 (23:32 +0000)]
    Reviewed by Geoff.

        - add headerdoc comments to some of the new JS API headers

        * API/JSBase.h:
        * API/JSValueRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
bdakin [Thu, 29 Jun 2006 23:18:23 +0000 (23:18 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/4450615> Add composite mode to background
        styles

        -webkit-background-composite will set a composite mode on a
        background image.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in: Add -webkit-background-composite
        * css/CSSValueKeywords.in: Add all possible values (clear, copy,
        source-over, source-in, source-out, source-atop, destination-over,
        destination-in, destination-out, destination-atop, xor, plus-
        darker, highlight, and plus-lighter)
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBackgroundProperty):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::mapBackgroundComposite):
        * css/cssstyleselector.h:
        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawTiledImage):
        * platform/GraphicsContext.h: drawTiledImage() now takes a
        composite operator.
        * platform/Image.h: drawTiled() now takes a composite operator.
        * platform/cairo/ImageCairo.cpp:
        (WebCore::Image::drawTiled): Set the composite operator.
        * platform/mac/ImageMac.mm:
        (WebCore::Image::drawTiled): Set the composite operator.
        * platform/win/TemporaryLinkStubs.cpp:
        (Image::drawTiled):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackgroundExtended): Send the composite
        operator in the render style over to the graphics context.
        * rendering/render_style.cpp:
        (WebCore::BackgroundLayer::BackgroundLayer):
        (WebCore::BackgroundLayer::operator=):
        (WebCore::BackgroundLayer::operator==):
        (WebCore::BackgroundLayer::fillUnsetProperties):
        (WebCore::BackgroundLayer::cullEmptyLayers):
        * rendering/render_style.h:
        (WebCore::BackgroundLayer::backgroundComposite):
        (WebCore::BackgroundLayer::isBackgroundCompositeSet):
        (WebCore::BackgroundLayer::setBackgroundComposite):
        (WebCore::BackgroundLayer::clearBackgroundComposite):
        (WebCore::RenderStyle::backgroundComposite):
        (WebCore::RenderStyle::initialBackgroundComposite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Thu, 29 Jun 2006 19:28:20 +0000 (19:28 +0000)]
    Reviewed by John Sullivan.

        WebHistoryItem now supports getting and setting arbitrary properties via _transientPropertyForKey: and
        -_setTransientProperty:forKey:.
        For now, these properties do not persist with the rest of the history data.  They are intended to hold transient
        per-history-item state, which is something that was until now difficult for a WebKit client app to do.

        * History/WebHistoryItemPrivate.h:
        * History/WebHistoryItem.m:
        (-[WebHistoryItemPrivate dealloc]):
        (-[WebHistoryItem _transientPropertyForKey:]):
        (-[WebHistoryItem _setTransientProperty:forKey:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Harrison.
thatcher [Thu, 29 Jun 2006 18:18:42 +0000 (18:18 +0000)]
    Reviewed by Harrison.

        Smart insert and delete, continuous spell checking and autoscroll
        can now be used for any WebView, not just editable ones. All of
        these make sense for documents that might contain content editable
        areas or our new text fields. Autoscroll is usefull for dragging
        for file input controls also.

        Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
        WebHTMLView's _interceptEditingKeyEvent now uses WebView's
        tabKeyCyclesThroughElements state to determine whether or not
        to process tab key events. The idea here is that tabKeyCyclesThroughElements
        will be YES when this WebView is being used in a browser, and we
        desire the behavior where tab moves to the next element in tab order.
        If tabKeyCyclesThroughElements is NO, it is likely that the WebView
        is being embedded as the whole view, as in Mail, and tabs should input
        tabs as expected in a text editor. Using Option-Tab always cycles
        through elements.

        * WebView/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
        * WebView/WebHTMLView.m:
        (-[NSArray _interceptEditingKeyEvent:]):
        * WebView/WebView.m:
        (-[WebViewPrivate init]):
        (-[WebView _autoscrollForDraggingInfo:timeDelta:]):
        (-[WebView _shouldAutoscrollForDraggingInfo:]):
        (-[WebView validateUserInterfaceItem:]):
        (-[WebView toggleSmartInsertDelete:]):
        (-[WebView toggleContinuousSpellChecking:]):
        (-[WebView setTabKeyCyclesThroughElements:]):
        (-[WebView tabKeyCyclesThroughElements]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Thu, 29 Jun 2006 15:28:48 +0000 (15:28 +0000)]
WebCore:

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9649
        The no-svg build broke after r15091

        * bindings/objc/DOMInternal.h: Added #if XPATH_SUPPORT/#endif.
        * bindings/objc/DOMInternal.mm: Ditto.
        (raiseDOMException):
        * bindings/objc/DOMXPath.h: Ditto.
        * bindings/objc/DOMXPath.mm: Ditto.
        * bindings/objc/DOMXPathInternal.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Thu, 29 Jun 2006 07:54:49 +0000 (07:54 +0000)]
WebCore:

2006-06-29  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim O.

        <rdar://problem/4599760> Objective-C XPath support

        * WebCore.xcodeproj/project.pbxproj:
        Add files.

        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMInternal.mm:
        (raiseDOMException):
        Handle XPath exceptions

        * bindings/objc/DOMXPath.h: Added.
        (-[DOMXPathNSResolver lookupNamespaceURI:]):
        * bindings/objc/DOMXPath.mm: Added.
        (-[DOMNativeXPathNSResolver dealloc]):
        (-[DOMNativeXPathNSResolver finalize]):
        (-[DOMNativeXPathNSResolver _xpathNSResolver]):
        (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:]):
        (+[DOMNativeXPathNSResolver _xpathNSResolverWith:]):
        (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
        (-[DOMXPathResult dealloc]):
        (-[DOMXPathResult finalize]):
        (-[DOMXPathResult resultType]):
        (-[DOMXPathResult numberValue]):
        (-[DOMXPathResult stringValue]):
        (-[DOMXPathResult booleanValue]):
        (-[DOMXPathResult singleNodeValue]):
        (-[DOMXPathResult invalidIteratorState]):
        (-[DOMXPathResult snapshotLength]):
        (-[DOMXPathResult iterateNext]):
        (-[DOMXPathResult snapshotItem:]):
        (-[DOMXPathResult _xpathResult]):
        (-[DOMXPathResult _initWithXPathResult:]):
        (+[DOMXPathResult _xpathResultWith:]):
        (-[DOMXPathExpression evaluate:::]):
        (-[DOMXPathExpression _xpathExpression]):
        (-[DOMXPathExpression _initWithXPathExpression:]):
        (+[DOMXPathExpression _xpathExpressionWith:]):
        (-[DOMDocument createExpression::]):
        (-[DOMDocument createNSResolver:]):
        (-[DOMDocument evaluate:::::]):
        * bindings/objc/DOMXPathInternal.h: Added.
        Add Objective-C XPath API.

WebKit:

2006-06-29  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim O.

        * WebKit.xcodeproj/project.pbxproj:
        Add DOMXPath.h header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
hyatt [Thu, 29 Jun 2006 00:32:55 +0000 (00:32 +0000)]
WebCore:

        Add support for custom highlighting to paint at the root line box level
        (and to inflate the box it uses so that it can go outside the bounds of
        the line if necessary).

        Reviewed by harrison

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::customHighlightLineRect):
        (WebCore::FrameMac::paintCustomHighlight):
        * bridge/mac/WebCoreFrameBridge.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintCustomHighlight):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paintCustomHighlight):
        (WebCore::RootInlineBox::paint):
        * rendering/RootInlineBox.h:

WebKit:

        Fix custom highlighting so that you can paint the entire line (and go
        outside the bounds of the line).

        Reviewed by harrison

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge customHighlightRect:forLine:]):
        (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
mjs [Thu, 29 Jun 2006 00:20:12 +0000 (00:20 +0000)]
    Reviewed by Anders.

        - fix Frame leak on layout tests

        * WebCoreSupport/WebPageBridge.m:
        (-[WebPageBridge outerView]): Return WebFrameView for main frame instead
        of WebView to avoid reference cycle between WebView and Page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
lweintraub [Wed, 28 Jun 2006 23:44:03 +0000 (23:44 +0000)]
LayoutTests:

        Reviewed by justin

        <rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
        <rdar://problem/4590763> FormatBlock for paragraph style doesn't work

        * editing/execCommand/format-block-with-braces-expected.checksum: Added.
        * editing/execCommand/format-block-with-braces-expected.png: Added.
        * editing/execCommand/format-block-with-braces-expected.txt: Added.
        * editing/execCommand/format-block-with-braces.html: Added.
        * editing/execCommand/indent-list-item-expected.checksum: Added.
        * editing/execCommand/indent-list-item-expected.png: Added.
        * editing/execCommand/indent-list-item-expected.txt: Added.
        * editing/execCommand/indent-list-item.html: Added.
        * editing/execCommand/indent-selection-expected.checksum: Added.
        * editing/execCommand/indent-selection-expected.png: Added.
        * editing/execCommand/indent-selection-expected.txt: Added.
        * editing/execCommand/indent-selection.html: Added.
        * editing/execCommand/outdent-selection-expected.checksum: Added.
        * editing/execCommand/outdent-selection-expected.png: Added.
        * editing/execCommand/outdent-selection-expected.txt: Added.
        * editing/execCommand/outdent-selection.html: Added.

WebCore:

        Reviewed by justin

        <rdar://problem/4592005> FormatBlock inserts in the wrong place, disregarding editable content
        <rdar://problem/4590763> FormatBlock for paragraph style doesn't work

        * dom/Node.cpp:
        (WebCore::Node::rootEditableElement): Return inline nodes
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::doApply): Keep from inserting before editable content
        * editing/JSEditor.cpp: Support html braces (<>) around tag names

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by levi
justing [Wed, 28 Jun 2006 23:18:01 +0000 (23:18 +0000)]
    Reviewed by levi

        svg/custom/text-hit-test.svg was failing

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::positionForCoordinates): Don't skip child
        renderers that have a height of 0 when looking for the closest child
        renderer, they may contain content that overflows.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForCoordinates): Fixed typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make the view source document properly handle <script>. We don't syntax
hyatt [Wed, 28 Jun 2006 20:43:18 +0000 (20:43 +0000)]
    Make the view source document properly handle <script>.  We don't syntax
        highlight the JS yet, but it shows up properly now.

        Reviewed by john

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
thatcher [Wed, 28 Jun 2006 20:32:45 +0000 (20:32 +0000)]
JavaScriptCore:

        Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Prefer the Stabs debugging symbols format until DWARF bugs are fixed.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by levi
justing [Wed, 28 Jun 2006 20:18:11 +0000 (20:18 +0000)]
    Reviewed by levi

        Fixed EditActions for InsertHorizontalRule and RemoveFormat.

        * editing/JSEditor.cpp:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::editingAction):
        * editing/ReplaceSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadded google spreadsheets and yahoo mail beta, moved google calendar and yahoo previe...
aliceli1 [Wed, 28 Jun 2006 20:09:50 +0000 (20:09 +0000)]
added google spreadsheets and yahoo mail beta, moved google calendar and yahoo preview to alumni list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild Fix
lweintraub [Wed, 28 Jun 2006 18:58:19 +0000 (18:58 +0000)]
Build Fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build Fix. Reviewed by NOBODY
lweintraub [Wed, 28 Jun 2006 18:36:46 +0000 (18:36 +0000)]
     Build Fix. Reviewed by NOBODY

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
lweintraub [Wed, 28 Jun 2006 18:17:58 +0000 (18:17 +0000)]
LayoutTests:

        Reviewed by justin

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
        Bug 7568: Implement Indent/Outdent

        * editing/execCommand/indent-list-item-expected.checksum: Added.
        * editing/execCommand/indent-list-item-expected.png: Added.
        * editing/execCommand/indent-list-item-expected.txt: Added.
        * editing/execCommand/indent-list-item.html: Added.
        * editing/execCommand/indent-selection-expected.checksum: Added.
        * editing/execCommand/indent-selection-expected.png: Added.
        * editing/execCommand/indent-selection-expected.txt: Added.
        * editing/execCommand/indent-selection.html: Added.
        * editing/execCommand/outdent-selection.html: Added.

WebCore:

        Reviewed by justin

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
        Bug 7568: Implement Indent/Outdent

        * WebCore.vcproj/WebCore/WebCore.vcproj: Added IndentOutdentCommand.h/cpp
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * editing/IndentOutdentCommand.cpp: Added.
        (WebCore::IndentOutdentCommand::IndentOutdentCommand):
        (WebCore::enclosingListOrBlockquote):
        (WebCore::IndentOutdentCommand::splitTreeToNode): Splits the DOM tree from a
        descendent node to an ending ancestor, duplicating nodes when necessary. Returns
        the last node split. Used to insert blockquotes at the topmost level.
        (WebCore::IndentOutdentCommand::indentRegion):
        (WebCore::IndentOutdentCommand::outdentParagraph):
        (WebCore::IndentOutdentCommand::outdentRegion):
        (WebCore::IndentOutdentCommand::doApply):
        * editing/IndentOutdentCommand.h: Added.
        (WebCore::IndentOutdentCommand::):
        * editing/JSEditor.cpp: Added the execCommands Indent and Outdent
        * editing/htmlediting.cpp:
        (WebCore::enclosingNodeWithTag): Finds the enclosing node with any specified tag.
        (WebCore::enclosingListChild): Added checks for nill and editable boundaries.
        (WebCore::outermostEnclosingListChild): Returns the highest ancestor list child.
        (WebCore::highestAncestor): Added.
        (WebCore::createElement): Changed the passed in string to a const reference.
        * editing/htmlediting.h:

WebKit:

        Reviewed by justin

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
        Bug 7568: Implement Indent/Outdent
        Added undo action strings and enum values

        * English.lproj/Localizable.strings:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge nameForUndoAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 28 Jun 2006 15:42:13 +0000 (15:42 +0000)]
LayoutTests:

        Reviewed by Darin and Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9561
          REGRESSION: Content property on :before of button causes hang on click or hover

        * fast/forms/button-generated-content-expected.checksum: Added.
        * fast/forms/button-generated-content-expected.png: Added.
        * fast/forms/button-generated-content-expected.txt: Added.
        * fast/forms/button-generated-content.html: Added.

WebCore:

        Reviewed by Darin and Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9561
          REGRESSION: Content property on :before of button causes hang on click or hover

        Test: fast/forms/button-generated-content.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::setStyle):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::updatePseudoChild): Added. Calls updatePseudoChildForObject()
        on the button itself or on its inner div, if it has one.
        * rendering/RenderButton.h:
        (WebCore::RenderButton::createsAnonymousWrapper): Added. Returns true.
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::pseudoChild): Added. Returns the child containing
        generated content of the requested type if there is one, or otherwise the
        child before/after which such generated content should come.
        (WebCore::RenderContainer::updatePseudoChild): Removed the child parameter and moved the guts
        of this method into updatePseudoChildForObject, which this method calls unless the object
        is an anonymous wrapper.
        (WebCore::RenderContainer::updatePseudoChildForObject): Added. Does the what
        updatePseudoChildForObject did previously, but fetches the pseudo style from
        the styledObject parameter.
        * rendering/RenderContainer.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::setStyle):
        (WebCore::RenderInline::addChildToFlow):
        (WebCore::RenderInline::splitInlines):
        (WebCore::RenderInline::splitFlow):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::createsAnonymousWrapper): Added. This method replaces
        allowsReusingAnonymousChild and returns the opposite of what that method used to
        return. Returns true if the object creates an anonymous child to contain all its
        other children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Wed, 28 Jun 2006 14:39:50 +0000 (14:39 +0000)]
    Reviewed by Darin.

        Improved test to check offsetX/Y after dispatching instead of before.

        * fast/dom/window-xy-properties.html:
        * fast/dom/window-xy-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson [Wed, 28 Jun 2006 07:18:28 +0000 (07:18 +0000)]
WebCore:

        Reviewed by Maciej

        Hookup the new semi-functional SQLite icon database.
        For now, it is living side-by-side with the old DB so one can compare the
        two for debugging purposes.  Also, it is disabled (in WebKit) by default unless you
        compile with ICONDEBUG #defined.

        * WebCore.xcodeproj/project.pbxproj:  Added file SiteIcon.cpp

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
        (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
        (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
        (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::isValidDatabase):
        (WebCore::IconDatabase::recreateDatabase):
        (WebCore::IconDatabase::createPrivateTables):
        (WebCore::IconDatabase::deletePrivateTables):
        (WebCore::IconDatabase::imageDataForIconID):
        (WebCore::IconDatabase::imageDataForIconURL):
        (WebCore::IconDatabase::imageDataForPageURL):
        (WebCore::IconDatabase::setPrivateBrowsingEnabled):
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::IconDatabase::iconURLForURL):
        (WebCore::IconDatabase::setIconDataForIconURL):
        (WebCore::IconDatabase::establishIconIDForEscapedIconURL):
        (WebCore::IconDatabase::setHaveNoIconForIconURL):
        (WebCore::IconDatabase::setIconURLForPageURL):
        (WebCore::IconDatabase::hasIconForIconURL):
        * icon/IconDatabase.h:
        (WebCore::SiteIcon::getIconURL):
        (WebCore::IconDatabase::getPrivateBrowsingEnabled):

        * icon/SiteIcon.cpp: Added.
        (SiteIcon::SiteIcon):
        (SiteIcon::~SiteIcon):
        (SiteIcon::getImage):
        (SiteIcon::resetExpiration):
        (SiteIcon::getExpiration):

WebKit:

        Reviewed by Maciej

        Hookup the new semi-functional SQLite icon database.
        For now, it is living side-by-side with the old DB so one can compare the
        two for debugging purposes.  Also, it is disabled (in WebKit) by default unless you
        compile with ICONDEBUG #defined.
        Note:  To repeat that, if you want to try the new DB, #define ICONDEBUG (WebKitPrefix.h is a good place to do it)

        * Misc/WebIconDatabase.m:
        (-[NSMutableDictionary iconForURL:withSize:cache:]):
        (-[NSMutableDictionary iconURLForURL:]):
        (-[NSMutableDictionary retainIconForURL:]):
        (-[NSMutableDictionary releaseIconForURL:]):
        (-[WebIconDatabase _setHaveNoIconForIconURL:]):
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _hasIconForIconURL:]):
        (-[WebIconDatabase _resetCachedWebPreferences:]):
        * Misc/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 28 Jun 2006 03:52:29 +0000 (03:52 +0000)]
LayoutTests:

        Reviewed by Darin.

        Updated test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9605

        * fast/dom/window-xy-properties.html:
        * fast/dom/window-xy-properties-expected.txt:

WebCore:

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9605
        REGRESSION: pageX and pageY are both 0 for events created with initMouseEvent

        Calculate pageX/pageY and clientX/clientY values when using initMouseEvent.

        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::initMouseEvent):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::initCoordinates):
        * dom/MouseRelatedEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 28 Jun 2006 03:32:56 +0000 (03:32 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9317
          REGRESSION: crash in HTML tokenizer at Japanese Apple support page

        * fast/tokenizer/write-unclosed-script-expected.txt: Added.
        * fast/tokenizer/write-unclosed-script.html: Added.

WebCore:

        Reviewed by Maciej and Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9317
          REGRESSION: crash in HTML tokenizer at Japanese Apple support page

        Test: fast/tokenizer/write-unclosed-script.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler): Changed to reset the inScript flag
        and scriptCodeSize before possible script execution, but not afterwards.
        This way, if script execution write()s a <script> tag without closing it,
        the tokenizer is left in inScript state. Added code to set the requestingScript
        flag around the request for the cached script, to let notifiyFinished() know
        that it's being called under scriptHandler().
        (WebCore::HTMLTokenizer::scriptExecution): Removed code that saved and restored
        the inScript flag. This function is always entered now with inScript being false.
        (WebCore::HTMLTokenizer::notifyFinished): Changed to use the new requestingScript
        state flag instead of the inScript flag, which is always false now when entering
        this function.
        * html/HTMLTokenizer.h:
        Added the requestingScript state bit, used to tell notifyFinished() that it
        is being called under scriptHandler() (which happens when the script is already
        in cache).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixed some typos.
justing [Wed, 28 Jun 2006 02:26:52 +0000 (02:26 +0000)]
Fixed some typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 28 Jun 2006 02:23:56 +0000 (02:23 +0000)]
LayoutTests:

        Reviewed by levi

        * editing/execCommand/remove-formatting-expected.checksum: Added.
        * editing/execCommand/remove-formatting-expected.png: Added.
        * editing/execCommand/remove-formatting-expected.txt: Added.
        * editing/execCommand/remove-formatting.html: Added.

WebCore:

        Reviewed by levi

        * editing/JSEditor.cpp: Added RemoveFormat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@15072 268f45cc-cd09-0410...
kdecker [Wed, 28 Jun 2006 02:17:43 +0000 (02:17 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim O.
thatcher [Wed, 28 Jun 2006 00:18:15 +0000 (00:18 +0000)]
    Reviewed by Tim O.

        <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore, WebKit and WebBrowser

        Switch to the new ObjC 2 API, ifdefed the old code around OBJC_API_VERSION so it still works on Tiger.
        Removed the use of the old stringWithCString, switched to the new Tiger version that accepts an encoding.
        Lots of code style cleanup.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/objc/objc_class.h:
        * bindings/objc/objc_class.mm:
        (KJS::Bindings::ObjcClass::~ObjcClass):
        (KJS::Bindings::_createClassesByIsAIfNecessary):
        (KJS::Bindings::ObjcClass::classForIsA):
        (KJS::Bindings::ObjcClass::name):
        (KJS::Bindings::ObjcClass::methodsNamed):
        (KJS::Bindings::ObjcClass::fieldNamed):
        (KJS::Bindings::ObjcClass::fallbackObject):
        * bindings/objc/objc_header.h:
        * bindings/objc/objc_instance.h:
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::ObjcInstance):
        (ObjcInstance::~ObjcInstance):
        (ObjcInstance::operator=):
        (ObjcInstance::begin):
        (ObjcInstance::end):
        (ObjcInstance::getClass):
        (ObjcInstance::invokeMethod):
        (ObjcInstance::invokeDefaultMethod):
        (ObjcInstance::setValueOfField):
        (ObjcInstance::supportsSetValueOfUndefinedField):
        (ObjcInstance::setValueOfUndefinedField):
        (ObjcInstance::getValueOfField):
        (ObjcInstance::getValueOfUndefinedField):
        (ObjcInstance::defaultValue):
        (ObjcInstance::stringValue):
        (ObjcInstance::numberValue):
        (ObjcInstance::booleanValue):
        (ObjcInstance::valueOf):
        * bindings/objc/objc_runtime.h:
        * bindings/objc/objc_runtime.mm:
        (ObjcMethod::ObjcMethod):
        (ObjcMethod::name):
        (ObjcMethod::getMethodSignature):
        (ObjcMethod::setJavaScriptName):
        (ObjcField::name):
        (ObjcField::type):
        (ObjcField::valueFromInstance):
        (convertValueToObjcObject):
        (ObjcField::setValueToInstance):
        (ObjcArray::operator=):
        (ObjcArray::setValueAt):
        (ObjcArray::valueAt):
        (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
        (ObjcFallbackObjectImp::callAsFunction):
        (ObjcFallbackObjectImp::defaultValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-28 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 27 Jun 2006 23:59:31 +0000 (23:59 +0000)]
2006-06-28  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8636
        REGRESSION: JavaScript access to Java applet causes hang (_webViewURL not implemented)

        * bindings/jni/jni_objc.mm:
        (KJS::Bindings::dispatchJNICall):
        Just pass nil as the calling URL. This will cause the Java plugin to use the URL of the page
        containing the applet (which is what we used to do).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-28 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 27 Jun 2006 23:58:52 +0000 (23:58 +0000)]
2006-06-28  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        Move FIXME comment here.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getComputedStyle):
        Don't do a null check on the renderer here. Everything's handled by
        CSSComputedStyleDeclaration anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by darin
justing [Tue, 27 Jun 2006 22:56:22 +0000 (22:56 +0000)]
    Reviewed by darin

        * rendering/RenderContainer.cpp: Fixed #include formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 27 Jun 2006 22:26:22 +0000 (22:26 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work

        Added:
        * editing/selection/click-before-and-after-table-expected.txt: Added.
        * editing/selection/click-before-and-after-table.html: Added.
        Updated to reflect fix:
        * editing/selection/move-by-line-001-expected.checksum:
        * editing/selection/move-by-line-001-expected.png:

WebCore:

        Reviewed by levi

        <rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForCoordinates): In the fall through case,
        where we can't find a child block that contains (x, y), pass to RenderFlow
        instead of the last visible child block.
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::positionForCoordinates): Don't pass to the closest
        child renderer if this is a table and (x, y) is outside the table.  Return
        a VisiblePosition before or after the table.
        Fixed the code that finds the closest child renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Preserve entity text in view source mode. This patch doesn't highlight the
hyatt [Tue, 27 Jun 2006 22:04:02 +0000 (22:04 +0000)]
    Preserve entity text in view source mode.  This patch doesn't highlight the
        the entities yet, but it at least prevents their resolution and removal.

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseEntity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 27 Jun 2006 21:30:58 +0000 (21:30 +0000)]
WebCore:

2006-06-27  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
        REGRESSION: getComputedStyle should do a relayout

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getComputedStyle):
        Do a relayout.

LayoutTests:

2006-06-27  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
        REGRESSION: getComputedStyle should do a relayout

        * fast/css/getComputedStyle-relayout-expected.txt: Added.
        * fast/css/getComputedStyle-relayout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdding symbols for debug builds.
thatcher [Tue, 27 Jun 2006 21:13:00 +0000 (21:13 +0000)]
Adding symbols for debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Tue, 27 Jun 2006 20:53:05 +0000 (20:53 +0000)]
    Reviewed by Darin.

        <rdar://problem/4406785> Add an export file to TOT JavaScriptCore like the Safari-2-0-branch

        * JavaScriptCore.exp: Added.
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele
mjs [Tue, 27 Jun 2006 20:36:20 +0000 (20:36 +0000)]
    Reviewed by Adele

        - fixed <rdar://problem/4550473> Reproducible hang on www.digg.com

        * dom/NodeList.cpp:
        (WebCore::NodeList::recursiveItem): Make NodeList caching also
        work for backwards iteration - if the requested index is before
        the last cached, but closer to it than to the start of the list,
        then search backwards from there.
        (WebCore::NodeList::itemForwardsFromCurrent): Split this out as a
        helper method.
        (WebCore::NodeList::itemBackwardsFromCurrent): New helper, similar
        to the above.
        * dom/NodeList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Levi
beidson [Tue, 27 Jun 2006 19:07:34 +0000 (19:07 +0000)]
    Reviewed by Levi

        Some SQLDatabase cleanup (style stuff) and enhancements

        * icon/SQLDatabase.cpp:
        (SQLDatabase::open):
        (SQLDatabase::executeCommand):
        (SQLDatabase::returnsAtLeastOneResult):  Accessor to see if this query returns results
        (SQLDatabase::lastInsertRowID):  Accessor for the rowid of the last insert
        * icon/SQLDatabase.h:
        (WebCore::SQLStatement::prepareAndStep):
        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::bindInt64):
        -All of the following used to require the user to manually prepare and step a statement
        before asking for the result.  Now it will prepare and step itself so you can use a temporary
        object to get a quick result
        (WebCore::SQLStatement::getColumnName):
        (WebCore::SQLStatement::getColumnName16):
        (WebCore::SQLStatement::getColumnText):
        (WebCore::SQLStatement::getColumnText16):
        (WebCore::SQLStatement::getColumnDouble):
        (WebCore::SQLStatement::getColumnInt):
        (WebCore::SQLStatement::getColumnInt64):
        (WebCore::SQLStatement::getColumnBlobAsVector):
        (WebCore::SQLStatement::getColumnBlob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-27 Ada Chan <adachan@apple.com>
adachan [Tue, 27 Jun 2006 18:15:31 +0000 (18:15 +0000)]
2006-06-27  Ada Chan <adachan@apple.com>

        Reviewed by sfalken.

        Fixed build.

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
bdakin [Tue, 27 Jun 2006 17:56:09 +0000 (17:56 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/4602635> Media queries must be extended to
        address CSS pixel scaling factor

        * css/MediaFeatureNames.h: Add -webkit-device-pixel-ratio, -webkit-
        min-device-pixel-ratio, and -webkit-max-device-pixel-ratio to the
        list of feature names.
        * css/MediaQueryEvaluator.cpp:
        (WebCore::cmpvalue): Added a version of cmpvalue that compares
        floats.
        (WebCore::device_pixel_ratioMediaFeatureEval):
        (WebCore::min_device_pixel_ratioMediaFeatureEval):
        (WebCore::max_device_pixel_ratioMediaFeatureEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Tue, 27 Jun 2006 17:44:50 +0000 (17:44 +0000)]
    Reviewed by Geoff.

        - finish with http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
          REGRESSION: some callers are still using clientX/Y to get pageX/Y

        * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
        Change to use pageX/Y, but this really doesn't matter since framesets
        can't be scrolled -- it's the frames that are scrolled. So this change
        has no user-visible effect, but it's still better this way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Tue, 27 Jun 2006 17:22:38 +0000 (17:22 +0000)]
LayoutTests:

        Tests for fix for 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
        REGRESSION: some callers are still using clientX/Y to get pageX/Y

        * fast/events/anchor-image-scrolled-x-y-expected.txt: Added.
        * fast/events/anchor-image-scrolled-x-y.html: Added.
        * fast/events/input-image-scrolled-x-y-expected.txt: Added.
        * fast/events/input-image-scrolled-x-y.html: Added.

WebCore:

        Reviewed by Geoff.

        - fix 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
          REGRESSION: some callers are still using clientX/Y to get pageX/Y

        Test: fast/events/anchor-image-scrolled-x-y.html
        Test: fast/events/input-image-scrolled-x-y.html

        * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use pageX/Y.
        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Tue, 27 Jun 2006 07:35:01 +0000 (07:35 +0000)]
    Reviewed by Maciej

        Added functionality to WebCore::Image to get multiple representations/sizes into TIFF data

        * platform/mac/ImageMac.mm:
        (WebCore::Image::getTIFFRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for 9538, support syntax highlighted HTML source. Lots of loose
hyatt [Mon, 26 Jun 2006 23:53:02 +0000 (23:53 +0000)]
    Fix for 9538, support syntax highlighted HTML source.  Lots of loose
        ends still (script/style/comments/doctype/entities/accurate whitespace).

        Reviewed by darin

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge setInViewSourceMode:]):
        (-[WebCoreFrameBridge inViewSourceMode]):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::matchUARules):
        * css/cssstyleselector.h:
        * css/view-source.css: Added.
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        * dom/xml_tokenizer.h:
        (WebCore::Tokenizer::Tokenizer):
        (WebCore::Tokenizer::~Tokenizer):
        (WebCore::Tokenizer::inViewSourceMode):
        (WebCore::Tokenizer::setInViewSourceMode):
        * html/HTMLAttributeNames.in:
        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::init):
        (WebCore::HTMLFrameElement::parseMappedAttribute):
        (WebCore::HTMLFrameElement::attach):
        * html/HTMLFrameElement.h:
        (WebCore::HTMLFrameElement::viewSourceMode):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::HTMLTokenizer):
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::scriptExecution):
        (WebCore::HTMLTokenizer::parseTag):
        (WebCore::HTMLTokenizer::continueProcessing):
        (WebCore::HTMLTokenizer::write):
        (WebCore::HTMLTokenizer::timerFired):
        (WebCore::HTMLTokenizer::end):
        (WebCore::HTMLTokenizer::processToken):
        (WebCore::HTMLTokenizer::notifyFinished):
        * html/HTMLTokenizer.h:
        * html/HTMLViewSourceDocument.cpp: Added.
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addViewSourceAttribute):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        * html/HTMLViewSourceDocument.h: Added.
        * page/Frame.cpp:
        (WebCore::Frame::begin):
        (WebCore::Frame::inViewSourceMode):
        (WebCore::Frame::setInViewSourceMode):
        * page/Frame.h:
        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for 9538, support syntax highlighting for HTML source.
hyatt [Mon, 26 Jun 2006 23:48:37 +0000 (23:48 +0000)]
    Fix for 9538, support syntax highlighting for HTML source.

        Reviewed by darin

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebView.m:
        (-[WebView _setInViewSourceMode:]):
        (-[WebView _inViewSourceMode]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-26 Anders Carlsson <acarlsson@apple.com>
andersca [Mon, 26 Jun 2006 21:26:43 +0000 (21:26 +0000)]
2006-06-26  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
        REGRESSION: Crash when closing tabs on newegg.com

        * page/Frame.cpp:
        (WebCore::Frame::pageDestroyed):
        * page/Frame.h:
        Add new method which is invoked when the frame's page has been destroyed.
        Currently this function disassociates the JS Window object with the frame,
        stopping any running JS timers.

        * page/Page.cpp:
        (WebCore::Page::~Page):
        Call pageDestroyed on all frames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and reworked by Darin.
darin [Mon, 26 Jun 2006 16:38:55 +0000 (16:38 +0000)]
    Reviewed and reworked by Darin.

        Code cleanup, calculate clientX/clientY in one central place.

        * dom/EventTargetNode.h:
        * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
        Renamed parameters to pageX/Y since they aren't clientX/Y values.
        Removed code to compute clientX/Y (was a bit confused in naming before),
        because that's now done inside MouseEvent.

        * dom/MouseEvent.h:
        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::MouseEvent): Removed clientX/Y parameters.
        (WebCore::MouseEvent::initMouseEvent): Added comments about problems I noticed.
        (WebCore::MouseEvent::which): Fixed comment that confusingly mentioned KHTML,
        when it was talking about the DOM standard.

        * dom/MouseRelatedEvent.h:
        * dom/MouseRelatedEvent.cpp:
        (WebCore::contentsX): Added helper function.
        (WebCore::contentsY): Ditto.
        (WebCore::MouseRelatedEvent::MouseRelatedEvent): Removed clientX/Y parameter,
        and added code to compute clientX/Y based on pageX/Y.
        (WebCore::MouseRelatedEvent::receivedTarget): Fixed comments.

        * dom/WheelEvent.h:
        * dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Removed clientX/Y
        parameter.

        * page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): Removed the code
        to compute coordinates, and renamed the confusingly named clientPos (which was
        a page-relative position) to contentsPos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Mon, 26 Jun 2006 15:26:50 +0000 (15:26 +0000)]
LayoutTests:

        Reviewed by Darin.

        * LayoutTests/fast/events/objc-event-api-expected.txt: Updated to
        reflect flipped coordinates dumped by the layout tests.

WebKitTools:

        Reviewed by Darin.

        Bug 9579: LayoutTests/fast/events/objc-event-api.html failing due to screenY output
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9579

        Report screenY values as (height of zero screen - screenY)

        * DumpRenderTree/EventSendingController.m: (-[EventSendingController handleEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
thatcher [Mon, 26 Jun 2006 05:09:12 +0000 (05:09 +0000)]
    Reviewed by Geoff.

        Bug 9591: [Drosera] breakpoints should be dragable and deletable by dragging off the gutter
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9591

        Makes breakpoints dragable. If dragged off the gutter they are deleted.

        * Drosera/debugger.js:
        * Drosera/viewer.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Mon, 26 Jun 2006 04:51:30 +0000 (04:51 +0000)]
LayoutTests:

        Reviewed by Darin.

        Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9185

        * fast/forms/input-appearance-height-expected.png: Added.
        * fast/forms/input-appearance-height-expected.txt: Added.
        * fast/forms/input-appearance-height.html: Added.
        Tests the height attribute on all input types

        * fast/forms/input-type-change-expected.checksum: Added.
        * fast/forms/input-type-change-expected.png: Added.
        * fast/forms/input-type-change-expected.txt: Added.
        * fast/forms/input-type-change.html: Added.
        Tests changing an input type=TEXT to type=IMAGE with
        a height and width specified on the element.

        * fast/forms/input-type-change2-expected.checksum: Added.
        * fast/forms/input-type-change2-expected.png: Added.
        * fast/forms/input-type-change2-expected.txt: Added.
        * fast/forms/input-type-change2.html: Added.
        Tests changing an input type=IMAGE to type=TEXT with
        a height and width specified on the element.

WebCore:

        Reviewed and tweaked by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9185
        REGRESSION: UserID field appears with an incorrect height
        on americanexpresslogin page
        - Height and Width attribute only applies to IMAGE and HIDDEN
        types.

        * dom/NamedMappedAttrMap.h:
        (WebCore::NamedMappedAttrMap::getAttributeItem):
        Added to static_cast method.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        Update the style decl if input type has changed.
        (WebCore::HTMLInputElement::mapToEntry):
        Only Cache height and width if it is an IMAGE or HIDDEN
        (WebCore::HTMLInputElement::parseMappedAttribute):
        Check type before adding height and width style.
        (WebCore::HTMLInputElement::attach):
        Remove code for discarding width.

        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::respectHeightAndWidthAttrs):
        New method added to report if this input type uses height & width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
ggaren [Mon, 26 Jun 2006 03:12:18 +0000 (03:12 +0000)]
    Reviewed by Adele.

        - Added JSConstructorMake to match JSFunctionMake, along with test code.

        [ I checked in the ChangeLog before without the actual files. ]

        * API/JSObjectRef.cpp:
        (JSConstructorMake):
        * API/JSObjectRef.h:
        * API/testapi.c:
        (myConstructor_callAsConstructor):
        (main):
        * API/testapi.js:
        * ChangeLog:
        * JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi
        target -- this was an oversight in my earlier check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Mon, 26 Jun 2006 02:17:48 +0000 (02:17 +0000)]
    Reviewed by Darin.

        Bug 9568: assertion failure in Safari after quitting Drosera
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9568

        Call switchToServerNamed:nil and not removeLister to make sure
        the server object is set to nil to prevent further removeListener calls.

        * Drosera/DebuggerDocument.m:
        (-[DebuggerDocument applicationTerminating:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Mon, 26 Jun 2006 00:28:58 +0000 (00:28 +0000)]
LayoutTests:

        Reviewed by Darin.

        * fast/forms/textarea-hard-linewrap-empty.html: Submit form without setTimeout().
        * fast/forms/textarea-hard-linewrap.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 25 Jun 2006 23:55:53 +0000 (23:55 +0000)]
WebCore:

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9537
          REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()

        Test: fast/forms/textarea-hard-linewrap-empty.html

        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::textWithHardLineBreaks): Added null check for
        m_div->firstChild()->renderer().

LayoutTests:

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9537
          REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()

        * fast/forms/textarea-hard-linewrap-empty-expected.txt: Added.
        * fast/forms/textarea-hard-linewrap-empty.html: Added.
        * fast/forms/textarea-hard-linewrap.html: Reduced timeout from 200ms to 0ms and
        renamed function from foo() to submitForm().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sun, 25 Jun 2006 23:28:14 +0000 (23:28 +0000)]
WebKitTools:

        Reviewed by Darin.

        * Scripts/svn-apply: Speed up isDirectoryEmptyForRemoval() by returning as soon as we find
        that the directory is not empty instead of reading in every single file and directory first,
        then checking the count.  Avoid warning in removeDirectoriesIfNeeded() if $svnOutput is not
        defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 25 Jun 2006 23:17:09 +0000 (23:17 +0000)]
WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9388
          REGRESSION: outlines don't get erased when removed in some cases

        Test: fast/repaint/outline-shrinking.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): Always repaint with the old style if the outline is
        becoming narrower, even if we are going to relayout.

LayoutTests:

        Reviewed by Darin.

        - repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9388
          REGRESSION: outlines don't get erased when removed in some cases

        * fast/repaint/outline-shrinking-expected.checksum: Added.
        * fast/repaint/outline-shrinking-expected.png: Added.
        * fast/repaint/outline-shrinking-expected.txt: Added.
        * fast/repaint/outline-shrinking.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix for for GCC 5406
thatcher [Sun, 25 Jun 2006 20:56:34 +0000 (20:56 +0000)]
Build fix for for GCC 5406

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRolls out a build fix I made on Friday, this was correctly fixed by adding a long...
thatcher [Sun, 25 Jun 2006 20:37:47 +0000 (20:37 +0000)]
Rolls out a build fix I made on Friday, this was correctly fixed by adding a long version of operator[] to Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Sun, 25 Jun 2006 20:37:37 +0000 (20:37 +0000)]
WebCore:

        Reviewed by Darin.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
        event.clientX and event.clientY should be relative to the viewport, not the canvas

        Make sure clientX and clientY take into account the scroll offsets
        of the view.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):
        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::MouseEvent):
        * dom/MouseEvent.h:
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
        (WebCore::MouseRelatedEvent::initCoordinates):
        * dom/MouseRelatedEvent.h:
        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::dispatchDragEvent):

LayoutTests:

        Reviewed by Darin.

        Test cases for
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
        event.clientX and event.clientY should be relative to the viewport, not the canvas

        * fast/dom/window-xy-properties-expected.txt: Added.
        * fast/dom/window-xy-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLeak fix
thatcher [Sun, 25 Jun 2006 20:32:37 +0000 (20:32 +0000)]
Leak fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/svn-apply: Tweak comments.
darin [Sun, 25 Jun 2006 20:01:03 +0000 (20:01 +0000)]
    * Scripts/svn-apply: Tweak comments.
        * Scripts/svn-create-patch: Ditto.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15030 268f45cc-cd09-0410-ab3c-d52691b4dbfc