WebKit-https.git
7 years agoIntegrate IETC CSS : grid layout tests
tomz@codeaurora.org [Fri, 13 Apr 2012 19:39:33 +0000 (19:39 +0000)]
Integrate IETC CSS : grid layout tests
https://bugs.webkit.org/show_bug.cgi?id=83830

Patch by Dave Tharp < dtharp@codeaurora.org> on 2012-04-13
Reviewed by Adam Barth

* ietestcenter/css3/grid/display-grid-001.htm: Added.
* ietestcenter/css3/grid/display-grid-002.htm: Added.
* ietestcenter/css3/grid/grid-column-001.htm: Added.
* ietestcenter/css3/grid/grid-column-002.htm: Added.
* ietestcenter/css3/grid/grid-column-003.htm: Added.
* ietestcenter/css3/grid/grid-columns-001.htm: Added.
* ietestcenter/css3/grid/grid-items-001.htm: Added.
* ietestcenter/css3/grid/grid-items-002.htm: Added.
* ietestcenter/css3/grid/grid-items-003.htm: Added.
* ietestcenter/css3/grid/grid-items-004.htm: Added.
* ietestcenter/css3/grid/grid-items-005.htm: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Now that the chromium port is using a different dom_storage backend
michaeln@google.com [Fri, 13 Apr 2012 19:33:55 +0000 (19:33 +0000)]
[chromium] Now that the chromium port is using a different dom_storage backend
library in its main browser process, there are a handful of files that should no
longer be included in the build, and a few files than should be deleted
outright, and the webkit api should be modified to reflect the new (and smaller)
contract between the embedder and webkit/webcore.
https://bugs.webkit.org/show_bug.cgi?id=83807

Reviewed by Adam Barth.

Source/WebCore:

No new tests, existing tests apply.

* WebCore.gyp/WebCore.gyp: Exclude several files from the WebCore/storage directory.
* storage/StorageEventDispatcher.h: Delete a stale comment.

Source/WebKit/chromium:

* WebKit.gyp: Delete a few files.
* public/WebStorageNamespace.h:  Remove some unused data members and methods, and annotate close() as deprecated.
* public/platform/WebKitPlatformSupport.h: Annotate a method as deprecated.
* src/StorageAreaProxy.cpp: Remove the include of a deleted file.
* src/StorageEventDispatcherChromium.cpp: Removed.
* src/StorageEventDispatcherImpl.cpp: Added a FIXME comment for upcoming work.
* src/StorageNamespaceProxy.cpp: Modified to no longer call out to the embedder thru the deprecated close() method.
* src/StorageNamespaceProxy.h: Moved some blank lines around.
* src/WebStorageAreaImpl.cpp: Removed.
* src/WebStorageAreaImpl.h: Removed.
* src/WebStorageEventDispatcherImpl.cpp: Cleaned up some cruft.
* src/WebStorageNamespaceImpl.cpp: Removed.
* src/WebStorageNamespaceImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaselining after r114150.
zandobersek@gmail.com [Fri, 13 Apr 2012 19:32:52 +0000 (19:32 +0000)]
Unreviewed, rebaselining after r114150.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
rniwa@webkit.org [Fri, 13 Apr 2012 19:26:16 +0000 (19:26 +0000)]
webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
and also rebaseline the test results since we ignore the first run now.

* Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.run):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPageLoadingPerfTest.test_run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't rely on fixed offsets to patch get_by_id/put_by_id
barraclough@apple.com [Fri, 13 Apr 2012 19:24:14 +0000 (19:24 +0000)]
Don't rely on fixed offsets to patch get_by_id/put_by_id
https://bugs.webkit.org/show_bug.cgi?id=83924

Reviewed by Oliver Hunt.

Store offsets in the structure stub info, as we do for the DFG JIT.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::differenceBetween):
    - this method can be static (now used from PropertyStubCompilationInfo::copyToStubInfo, will be removed soon!)
* bytecode/StructureStubInfo.h:
    - added new fields for baseline JIT offsets.
* jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
    - moved out from JIT::privateCompile.
(JSC::JIT::privateCompile):
    - moved out code to PropertyStubCompilationInfo::copyToStubInfo.
* jit/JIT.h:
(PropertyStubCompilationInfo):
    - added helper functions to initializae PropertyStubCompilationInfo, state to store more offset info.
    - removed many offsets.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
    - changed code generation to use new interface to store info on PropertyStubCompilationInfo.
    - changed repatch functions to read offsets from the structure stub info.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
    - changed code generation to use new interface to store info on PropertyStubCompilationInfo.
    - changed repatch functions to read offsets from the structure stub info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore rebaselining.
andersca@apple.com [Fri, 13 Apr 2012 19:19:00 +0000 (19:19 +0000)]
More rebaselining.

* platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix some compiler warnings (miscellaneous)
rwlbuis@webkit.org [Fri, 13 Apr 2012 19:02:53 +0000 (19:02 +0000)]
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

Fix signed/unsigned comparison warning.

* parser/Lexer.cpp:
(JSC::::record16):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInclude the error if we fail to initialize the web process sandbox
andersca@apple.com [Fri, 13 Apr 2012 18:49:39 +0000 (18:49 +0000)]
Include the error if we fail to initialize the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=83927

Reviewed by Alexey Proskuryakov.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114140.
scheib@chromium.org [Fri, 13 Apr 2012 18:26:46 +0000 (18:26 +0000)]
Unreviewed, rolling out r114140.
http://trac.webkit.org/changeset/114140
https://bugs.webkit.org/show_bug.cgi?id=83921

Fails fast/css/image-set-parsing.html test it attempts to
introduce. (Requested by scheib on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

* WebCore.gypi:

Source/WebKit/chromium:

* features.gypi:

LayoutTests:

* platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/10912680> Pixel access canvas APIs do not operate at backing store...
mitz@apple.com [Fri, 13 Apr 2012 18:20:25 +0000 (18:20 +0000)]
<rdar://problem/10912680> Pixel access canvas APIs do not operate at backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83836

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/2d.imageDataHD.html

Added getImageDataHD and putImageDataHD functions to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The functions
are prefixed with “webkit” for now.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData): Added this cover function that calls
through to getImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD): Added. Calls through to
getImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::getImageData): Added a CoordinateSystem parameter to this
now-private function. It is passed through to ImageBuffer::getUnmultipliedImageData().
(WebCore::CanvasRenderingContext2D::putImageData): Added this cover function that calls
through to putImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD): Added. Calls through to
putImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::putImageData): Added a CoordinateSystem parameter to this
function. It is passed through to ImageBuffer::putByteArray, and used to compute the rect to
invalidate after the drawing operation.
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl: Added webkitPutImageDataHD() and
webkitGetImageDataHD().
* platform/graphics/ImageBuffer.h: Added a CoordinateSystem enum with the values
LogicalCoordinateSystem and BackingStoreCoordinateSystem. Added a CoordinateSystem parameter,
which defaults to LogicalCoordinateSystem, to getUnmultipliedImageData,
getPremultipliedImageData, and putByteArray.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData): Now uses the CoordinateSystem parameter to
decide whether to ask ImageBufferDaya::getData() to apply the resolution scale or not.
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Now uses the CoordinateSystem parameter to decide
whether to maintain the resolution scale while drawing or not.
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

LayoutTests:

* fast/canvas/2d.imageDataHD-expected.txt: Added.
* fast/canvas/2d.imageDataHD.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable SVG page loading performance tests
rniwa@webkit.org [Fri, 13 Apr 2012 18:16:26 +0000 (18:16 +0000)]
Enable SVG page loading performance tests
https://bugs.webkit.org/show_bug.cgi?id=83861

Reviewed by Adam Barth.

PerformanceTests:

Unskip PageLoad directory and skip tests that load too fast (less than 100ms) and are unstable,
and the ones that take too long to load (more than 20s).

* Skipped:

Tools:

Add support for page loading tests. These are tests without any test running harnesses, and we use
DriverOutput's test_timeout to measure the loading time.

Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.run):
(PerfTest):
(PerfTest.run_failed):
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest): Added.
(PageLoadingPerfTest.__init__):
(PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
* Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
(MockPrinter):
(MockPrinter.__init__):
(MockPrinter.write):
(MainTest):
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest):
(TestPageLoadingPerfTest.assertWritten):
(TestPageLoadingPerfTest.MockDriver):
(TestPageLoadingPerfTest.MockDriver.__init__):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_page_load_svg):
(test_collect_tests_with_page_load_svg.add_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline a test.
andersca@apple.com [Fri, 13 Apr 2012 18:15:43 +0000 (18:15 +0000)]
Rebaseline a test.

* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Support CCHeadsUpDisplay in threaded compositing mode
shawnsingh@chromium.org [Fri, 13 Apr 2012 18:06:50 +0000 (18:06 +0000)]
[chromium] Support CCHeadsUpDisplay in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=67499

Reviewed by James Robinson.

No new tests because this code is debugging code itself.

The last item that was needed to make the CCHeadsUpDisplay work in
threaded compositing mode was to remove the font rendering code
used on the impl-side thread. To solve this, this patch adds a
CCFontAtlas that is initialized on the main thread (where the font
rendering takes place). Then, when the HUD draws text on the impl
thread, it uses the font atlas directly.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCFontAtlas.cpp: Added.
(WebCore):
(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::wrapPositionIfNeeded):
(WebCore::CCFontAtlas::generateAtlasForFont):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):
* platform/graphics/chromium/cc/CCFontAtlas.h: Added.
(WebCore):
(CCFontAtlas):
(WebCore::CCFontAtlas::create):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(WebCore::CCLayerTreeHost::headsUpDisplayFontAtlas):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed - remove duplicate entries for two failing sputnik tests
zandobersek@gmail.com [Fri, 13 Apr 2012 18:06:15 +0000 (18:06 +0000)]
Unreviewed - remove duplicate entries for two failing sputnik tests
from the test_expectations.txt file.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] LayoutTest failures/flaky for svg/as-background-image
scheib@chromium.org [Fri, 13 Apr 2012 17:47:00 +0000 (17:47 +0000)]
[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Previous clean up in r114137 dropped a WIN IMAGE failure suppression.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600 Need...
beidson@apple.com [Fri, 13 Apr 2012 17:46:05 +0000 (17:46 +0000)]
<rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600 Need WebKit2 API to notify whether history loads are in the page cache

Source/WebKit2:

- Add a new WKBundlePageLoaderClient callback allowing the bundle to be notified
  of back/forward navigations (and deny them if it chooses)
- Add a new API to WKBundleBackForwardListItem to probe if the item is in the page cache.

Reviewed by Darin Adler.

Add the new WKBundleBackForwardListItem API:
* WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
(WKBundleBackForwardListItemIsInPageCache):
* WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
* WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
(WebKit::InjectedBundleBackForwardListItem::isInPageCache):

Update the UI page loader client to allow for a user data object to be passed from the bundle:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Update a comment typo.
(WebKit::WebLoaderClient::willGoToBackForwardListItem): Update for the user data field.
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willGoToBackForwardListItem):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

Add the new callback to the bundle loader client:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):

Call the bundle client before doing anything else, possibly canceling the navigation:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):

* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage) Adopt new bundle client interface.

Tools:

Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.

Reviewed by Darin Adler.

* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
(ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::shouldGoToBackForwardListItemCallback):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate baselines to make this test run again.
abarth@webkit.org [Fri, 13 Apr 2012 17:40:42 +0000 (17:40 +0000)]
Update baselines to make this test run again.

* platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Replaced.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium: Should enable -webkit-image-set
commit-queue@webkit.org [Fri, 13 Apr 2012 17:20:24 +0000 (17:20 +0000)]
Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859

Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/image-set-parsing.html

* WebCore.gypi:

Source/WebKit/chromium:

* features.gypi:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark test as even flakier: it can timeout.
antonm@chromium.org [Fri, 13 Apr 2012 16:16:10 +0000 (16:16 +0000)]
Mark test as even flakier: it can timeout.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Fri, 13 Apr 2012 16:05:03 +0000 (16:05 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Flag fast/regions
again. Only parts of it were passing, sigh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] LayoutTest failures/flaky for svg/as-background-image
schenney@chromium.org [Fri, 13 Apr 2012 15:49:11 +0000 (15:49 +0000)]
[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Consolidating common-cause flaky tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: do not attempt to load content from resource until request finished...
pfeldman@chromium.org [Fri, 13 Apr 2012 15:41:38 +0000 (15:41 +0000)]
Web Inspector: do not attempt to load content from resource until request finished loading.
https://bugs.webkit.org/show_bug.cgi?id=83896

Reviewed by Yury Semikhatsky.

Source/WebCore:

When we stop in the inline script on reload, we should only show concatenated script content.
When we resume, we should replace UI source code with the actual HTML content. We should not attempt to
fetch resource content until request finished loading. I regressed it in the Request extraction
and now am bringing it back.

* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Fri, 13 Apr 2012 15:40:20 +0000 (15:40 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Unskip fast/regions and
svg/hixie/perf that seem to pass fine on GTK bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: follow up to r114116 - fixing QT test
pfeldman@chromium.org [Fri, 13 Apr 2012 14:33:22 +0000 (14:33 +0000)]
Web Inspector: follow up to r114116 - fixing QT test
https://bugs.webkit.org/show_bug.cgi?id=83892

Reviewed by Yury Semikhatsky.

Source/WebCore:

Requesting content for the scripts exclusively via the page agent now.

* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.requestContent):

LayoutTests:

* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGroup EFL bots into a category on the buildbot master
commit-queue@webkit.org [Fri, 13 Apr 2012 14:30:16 +0000 (14:30 +0000)]
Group EFL bots into a category on the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=82712

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-13
Reviewed by Adam Roben.

Creating a new category definition on the buildbot frontend.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig): Determine category for EFL bots
* BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInsertHTML fails to insert h6 if the insertion point is before some text.
yi.4.shen@nokia.com [Fri, 13 Apr 2012 14:28:45 +0000 (14:28 +0000)]
InsertHTML fails to insert h6 if the insertion point is before some text.
https://bugs.webkit.org/show_bug.cgi?id=82689

Reviewed by Ryosuke Niwa.

Added the missing h6 tag for the isHeaderElement.

Source/WebCore:

No new tests: updated existing test (editing/execCommand/4128080-1.html)

* editing/ReplaceSelectionCommand.cpp:
(WebCore::isHeaderElement):

LayoutTests:

* editing/execCommand/4128080-1-expected.txt:
* editing/execCommand/4128080-1.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-04-13 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 13 Apr 2012 14:25:42 +0000 (14:25 +0000)]
2012-04-13  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Build fix after r114126.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
commit-queue@webkit.org [Fri, 13 Apr 2012 14:23:08 +0000 (14:23 +0000)]
[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-13
Reviewed by Noam Rosenthal.

This fixes API tests broken by r113715.

* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Fri, 13 Apr 2012 14:18:54 +0000 (14:18 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Marking some css2.1 tests flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark test as flaky.
antonm@chromium.org [Fri, 13 Apr 2012 14:16:55 +0000 (14:16 +0000)]
Mark test as flaky.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: exception in heap profiler when expanding a class in summary view
yurys@chromium.org [Fri, 13 Apr 2012 13:50:43 +0000 (13:50 +0000)]
Web Inspector: exception in heap profiler when expanding a class in summary view
https://bugs.webkit.org/show_bug.cgi?id=83883

Moved all DOM-specific inspector utilities into DOMExtension.js

Merged BinarySearch.js and PartialQuickSort.js into utilities.js, HeapSnapshotWorker.js now
imports utilities.js which contains all required routines.

Reviewed by Pavel Feldman.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/BinarySearch.js: Removed.
* inspector/front-end/DOMExtension.js: Copied from Source/WebCore/inspector/front-end/utilities.js.
(Node.prototype.rangeOfWord):
(Node.prototype.traverseNextTextNode):
(Node.prototype.rangeBoundaryForOffset):
(Element.prototype.removeStyleClass):
(Element.prototype.removeMatchingStyleClasses):
(Element.prototype.addStyleClass):
(Element.prototype.hasStyleClass):
(Element.prototype.positionAt):
(Element.prototype.pruneEmptyTextNodes):
(Element.prototype.isScrolledToBottom):
(Node.prototype.enclosingNodeOrSelfWithNodeNameInArray):
(Node.prototype.enclosingNodeOrSelfWithNodeName):
(Node.prototype.enclosingNodeOrSelfWithClass):
(Node.prototype.enclosingNodeWithClass):
(Element.prototype.query):
(Element.prototype.removeChildren):
(Element.prototype.isInsertionCaretInside):
(Element.prototype.createChild):
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):
(Element.prototype.boxInWindow):
(Element.prototype.setTextAndTitle):
(Event.prototype.consume):
(Text.prototype.select):
(Element.prototype.selectionLeftOffset):
(Node.prototype.isAncestor):
(Node.prototype.isDescendant):
(Node.prototype.isSelfOrAncestor):
(Node.prototype.isSelfOrDescendant):
(Node.prototype.traverseNextNode):
(Node.prototype.traversePreviousNode):
(HTMLTextAreaElement.prototype.moveCursorToEnd):
(isEnterKey):
(consumeEvent):
(highlightSearchResult):
(highlightSearchResults):
(highlightRangesWithStyleClass):
(applyDomChanges):
(revertDomChanges):
* inspector/front-end/HeapSnapshot.js: Fixed a couple of js compiler warnings
by describing structure of heap snapshot header in the protocol.
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
* inspector/front-end/HeapSnapshotWorker.js:
* inspector/front-end/PartialQuickSort.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/utilities.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark test as flaky.
antonm@chromium.org [Fri, 13 Apr 2012 13:45:15 +0000 (13:45 +0000)]
Mark test as flaky.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r113714.
commit-queue@webkit.org [Fri, 13 Apr 2012 13:26:44 +0000 (13:26 +0000)]
Unreviewed, rolling out r113714.
http://trac.webkit.org/changeset/113714
https://bugs.webkit.org/show_bug.cgi?id=83887

It is behaving strange on the bots and needs more
investigation. (Requested by jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebKit2:

* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):

Tools:

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114103.
commit-queue@webkit.org [Fri, 13 Apr 2012 13:16:58 +0000 (13:16 +0000)]
Unreviewed, rolling out r114103.
http://trac.webkit.org/changeset/114103
https://bugs.webkit.org/show_bug.cgi?id=83884

New breakpoint UI looks bad / needs polish. (Requested by
pfeldman_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

* inspector/front-end/Images/breakpointConditionalCounterBorder.png:
* inspector/front-end/Images/breakpointCounterBorder.png:
* inspector/front-end/Images/programCounterBorder.png:
* inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy...
commit-queue@webkit.org [Fri, 13 Apr 2012 13:14:08 +0000 (13:14 +0000)]
[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy sports).
https://bugs.webkit.org/show_bug.cgi?id=83760

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-13
Reviewed by George Staikos.

.:

* ManualTests/blackberry/http-cookie-database-set.php: Added.
* ManualTests/blackberry/http-cookie-database-update.php: Added.

Source/WebCore:

When we update cookies' database, protocol shouldn't be checked since it is not a cookie's key.
ESPN.com's https cookies should replace old http cookies if they have the same keys(name, path, domain).

We must restart the browser to test, so have to write a manual test case.

Test: ManualTests/blackberry/http-cookie-database-set.php

* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::invokeOpen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark test as flaky.
antonm@chromium.org [Fri, 13 Apr 2012 13:06:19 +0000 (13:06 +0000)]
Mark test as flaky.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-tools-completion: Support bugzilla email completion for webkit-patch upload...
jocelyn.turcotte@nokia.com [Fri, 13 Apr 2012 13:01:51 +0000 (13:01 +0000)]
webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
https://bugs.webkit.org/show_bug.cgi?id=83690

Reviewed by Tor Arne Vestbø.

Typing part of an email and pressing <TAB> will bash-complete it using the list in
Tools/Scripts/webkitpy/common/config/committers.py

* Scripts/webkit-tools-completion.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening: rebaseline 2 tests and add 5 tests to skiplist.
ossy@webkit.org [Fri, 13 Apr 2012 12:57:53 +0000 (12:57 +0000)]
[Qt] Gardening: rebaseline 2 tests and add 5 tests to skiplist.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-04-13
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rende...
jocelyn.turcotte@nokia.com [Fri, 13 Apr 2012 12:56:08 +0000 (12:56 +0000)]
[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rendering.
https://bugs.webkit.org/show_bug.cgi?id=83770

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Revert the previous way of dealing with things. The problem is that different layers
would end up rounding in different directions, and would cause jittering between
layers or with the QQuickWebPage's background.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):

Source/WebKit2:

- Do the alignment on the highest level as possible: the QQuickFlickable content item
  position. It already supports this with setPixelAligned which rounds the content item's position.
- Also move the setClip(true) to the common constructor as this constructor is currently only used by WTR.
- Remove setFlags(QQuickItem::ItemClipsChildrenToShape) as it is redundant with setClip(true).

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: introduce ParsedURL type, clean up url and displayName mess in Resourc...
pfeldman@chromium.org [Fri, 13 Apr 2012 12:25:25 +0000 (12:25 +0000)]
Web Inspector: introduce ParsedURL type, clean up url and displayName mess in Resource and NetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=83871

Reviewed by Yury Semikhatsky.

Source/WebCore:

There is a number of random properties created on Resource and NetworkRequest that represent various url
fragments. Display name is being based on them and sometimes requires fake Resource instance to be created.
This change (officially) introduces WebInspector.ParsedURL as a type that encapsulates this complexity.

This change also moves documentURL property into the Resource and NetworkRequest constructors and brushes up
factory methods used to create the objects.

* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.get displayDomain):
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.FrameEvaluationContext.prototype.get displayName):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.get documentURL):
(WebInspector.NetworkRequest.prototype.get parsedURL):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
* inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshUrlFragment):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get parsedURL):
(WebInspector.Resource.prototype.get frameId):
(WebInspector.Resource.prototype.get loaderId):
(WebInspector.Resource.prototype.get displayName):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeFrame.prototype._addRequest):
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):
(WebInspector.displayDomain):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
* inspector/front-end/utilities.js:

LayoutTests:

* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: extracting NetworkRequest from Resource (step 3)
pfeldman@chromium.org [Fri, 13 Apr 2012 12:15:05 +0000 (12:15 +0000)]
Web Inspector: extracting NetworkRequest from Resource (step 3)
https://bugs.webkit.org/show_bug.cgi?id=83802

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change extracts NetworkRequest from the Resource. It is now clear that these two
should have super class that would be responsible for parsing URL and would define the
requestContent signature. Corresponding patch will follow.

* inspector/front-end/NetworkManager.js:
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.get requestId):
(WebInspector.NetworkRequest.prototype.set requestId):
(WebInspector.NetworkRequest.prototype.get url):
(WebInspector.NetworkRequest.prototype.get frameId):
(WebInspector.NetworkRequest.prototype.get loaderId):
(WebInspector.NetworkRequest.prototype.get startTime):
(WebInspector.NetworkRequest.prototype.set startTime):
(WebInspector.NetworkRequest.prototype.get responseReceivedTime):
(WebInspector.NetworkRequest.prototype.set responseReceivedTime):
(WebInspector.NetworkRequest.prototype.get endTime):
(WebInspector.NetworkRequest.prototype.set endTime):
(WebInspector.NetworkRequest.prototype.get duration):
(WebInspector.NetworkRequest.prototype.get latency):
(WebInspector.NetworkRequest.prototype.get receiveDuration):
(WebInspector.NetworkRequest.prototype.get resourceSize):
(WebInspector.NetworkRequest.prototype.set resourceSize):
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.increaseTransferSize):
(WebInspector.NetworkRequest.prototype.get finished):
(WebInspector.NetworkRequest.prototype.set finished):
(WebInspector.NetworkRequest.prototype.get failed):
(WebInspector.NetworkRequest.prototype.set failed):
(WebInspector.NetworkRequest.prototype.get canceled):
(WebInspector.NetworkRequest.prototype.set canceled):
(WebInspector.NetworkRequest.prototype.get cached):
(WebInspector.NetworkRequest.prototype.set cached):
(WebInspector.NetworkRequest.prototype.get timing):
(WebInspector.NetworkRequest.prototype.set timing):
(WebInspector.NetworkRequest.prototype.get mimeType):
(WebInspector.NetworkRequest.prototype.set mimeType):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
(WebInspector.NetworkRequest.prototype.get displayDomain):
(WebInspector.NetworkRequest.prototype.get type):
(WebInspector.NetworkRequest.prototype.set type):
(WebInspector.NetworkRequest.prototype.get redirectSource):
(WebInspector.NetworkRequest.prototype.set redirectSource):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.set requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.set requestHeadersText):
(WebInspector.NetworkRequest.prototype.get requestHeadersSize):
(WebInspector.NetworkRequest.prototype.requestHeaderValue):
(WebInspector.NetworkRequest.prototype.get requestCookies):
(WebInspector.NetworkRequest.prototype.get requestFormData):
(WebInspector.NetworkRequest.prototype.set requestFormData):
(WebInspector.NetworkRequest.prototype.get requestHttpVersion):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.set responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype.set responseHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersSize):
(WebInspector.NetworkRequest.prototype.responseHeaderValue):
(WebInspector.NetworkRequest.prototype.get responseCookies):
(WebInspector.NetworkRequest.prototype.get queryParameters):
(WebInspector.NetworkRequest.prototype.get formParameters):
(WebInspector.NetworkRequest.prototype.get responseHttpVersion):
(WebInspector.NetworkRequest.prototype._parseParameters):
(WebInspector.NetworkRequest.prototype._headerValue):
(WebInspector.NetworkRequest.prototype.get content):
(WebInspector.NetworkRequest.prototype.get contentEncoded):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.isHttpFamily):
(WebInspector.NetworkRequest.prototype.requestContentType):
(WebInspector.NetworkRequest.prototype.isPingRequest):
(WebInspector.NetworkRequest.prototype.hasErrorStatusCode):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._contentURL):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
(WebInspector.NetworkRequest.prototype.setResource):
(WebInspector.NetworkRequest.prototype.resource):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._resourceAdded):
(WebInspector.RawSourceCode.prototype.forceUpdateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get type):
(WebInspector.Resource.prototype.get mimeType):
(WebInspector.Resource.prototype.set mimeType):
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

* http/tests/inspector/network/network-request-revision-content.html:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/set-breakpoint.html:
* inspector/debugger/source-frame.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agouse getClipDeviceBounds, rather than (deprecated) getTotalClip
reed@google.com [Fri, 13 Apr 2012 12:12:30 +0000 (12:12 +0000)]
use getClipDeviceBounds, rather than (deprecated) getTotalClip
https://bugs.webkit.org/show_bug.cgi?id=83808

Reviewed by Stephen White.

Equivalent functionality, existing tests apply.

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDraw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark test as flaky.
antonm@chromium.org [Fri, 13 Apr 2012 12:02:05 +0000 (12:02 +0000)]
Mark test as flaky.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add API for color chooser
commit-queue@webkit.org [Fri, 13 Apr 2012 11:44:22 +0000 (11:44 +0000)]
[EFL] Add API for color chooser
https://bugs.webkit.org/show_bug.cgi?id=83692

.:

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

* PlatformEfl.cmake:
* platform/efl/ColorChooserEfl.cpp: Added.
(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):
* platform/efl/ColorChooserEfl.h: Added.
(WebCore):
(ColorChooserEfl):

Source/WebKit/efl:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
(WebCore::ChromeClientEfl::createColorChooser):
(WebCore::ChromeClientEfl::removeColorChooser):
(WebCore::ChromeClientEfl::updateColorChooser):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* ewk/ewk_private.h:
(WebCore):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):
* ewk/ewk_view.h:

Tools:

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Fri, 13 Apr 2012 11:25:31 +0000 (11:25 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLinux rebaselines.
antonm@chromium.org [Fri, 13 Apr 2012 11:19:54 +0000 (11:19 +0000)]
Linux rebaselines.

Unreviewed.

* platform/chromium-linux/platform/chromium/compositing/filters: Added.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build fix with QT_NO_BEARERMANAGEMENT
vestbo@webkit.org [Fri, 13 Apr 2012 11:16:34 +0000 (11:16 +0000)]
[Qt] Build fix with QT_NO_BEARERMANAGEMENT

Reviewed by Jocelyn Turcotte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnabling/disabling delegates scrolling when page has no composited content asserts...
commit-queue@webkit.org [Fri, 13 Apr 2012 11:11:59 +0000 (11:11 +0000)]
Enabling/disabling delegates scrolling when page has no composited content asserts on WK1.
https://bugs.webkit.org/show_bug.cgi?id=83860

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

WK2 has compositing mode on all the time, while Wk1 turns it on only when
the page has composited content. This patch ensures that, when delegates scrolling behavior
is changed, backing stores are cleared only when there's an actual composition,
similarly to what CachedFrame does.

Test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html

* page/FrameView.cpp:
(WebCore::FrameView::delegatesScrollingDidChange):

LayoutTests:

* fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt: Added.
* fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add WebKit API to access <datalist> options
keishi@webkit.org [Fri, 13 Apr 2012 11:09:29 +0000 (11:09 +0000)]
[chromium] Add WebKit API to access <datalist> options
https://bugs.webkit.org/show_bug.cgi?id=83762

Introduce WebInputElement::dataListOptions so we can implement a UI for datalist.

Reviewed by Kent Tamura.

* public/WebInputElement.h:
(WebKit):
(WebInputElement):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::dataListOptions): Added. Returns a WebNodeCollection containing WebOptionElements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK baselines for tests now being runned since the
philn@webkit.org [Fri, 13 Apr 2012 10:39:29 +0000 (10:39 +0000)]
Unreviewed, GTK baselines for tests now being runned since the
migration to test_expectations.

* platform/gtk/css3/font-feature-settings-rendering-expected.txt: Added.
* platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: Added.
* platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/gtk/fast/dom/gc-10-expected.txt: Added.
* platform/gtk/fast/forms/date/date-appearance-expected.txt: Added.
* platform/gtk/fast/images/exif-orientation-css-expected.txt: Added.
* platform/gtk/fast/images/exif-orientation-expected.txt: Added.
* platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Added.
* platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Added.
* platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Added.
* platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Added.
* platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Added.
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-character-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-first-word-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-locale-expected.txt: Added.
* platform/gtk/fast/text/hyphens-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-126-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-127-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-65-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-82-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-84-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-87-expected.txt: Added.
* platform/gtk/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Added.
* platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Added.
* platform/gtk/test_expectations.txt: Mark a media/track test flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build on OS X
vestbo@webkit.org [Fri, 13 Apr 2012 10:37:51 +0000 (10:37 +0000)]
[Qt] Fix build on OS X

We were manually including the directories needed from WTF, instead of
using the WEBKIT qmake variable to add dependencies, which also adds
other tricks from WTF.pri, such as the right include paths for ICU.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew suppression.
antonm@chromium.org [Fri, 13 Apr 2012 10:23:18 +0000 (10:23 +0000)]
New suppression.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Fri, 13 Apr 2012 10:11:10 +0000 (10:11 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Skip two media tests trigger flakiness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Line number is not displayed while debugging javascript
commit-queue@webkit.org [Fri, 13 Apr 2012 10:10:41 +0000 (10:10 +0000)]
Web Inspector: Line number is not displayed while debugging javascript
https://bugs.webkit.org/show_bug.cgi?id=83786

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.

Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view

No additional test cases required for the above fix.

* inspector/front-end/Images/breakpointConditionalCounterBorder.png:
* inspector/front-end/Images/breakpointCounterBorder.png:
* inspector/front-end/Images/programCounterBorder.png:
* inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNow test sometimes crashes in Debug on XP too.
antonm@chromium.org [Fri, 13 Apr 2012 09:37:09 +0000 (09:37 +0000)]
Now test sometimes crashes in Debug on XP too.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a runtime flag for <input type=date>
tkent@chromium.org [Fri, 13 Apr 2012 09:15:27 +0000 (09:15 +0000)]
Add a runtime flag for <input type=date>
https://bugs.webkit.org/show_bug.cgi?id=83853

Reviewed by Adam Barth.

Source/WebCore:

* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled): Added.
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
Don't register type=date if !RuntimeEnabledFeatures::inputTypeDateEnabled()

Source/WebKit/chromium:

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Add enableInputTypeDate() and isInputTypeDateEnabled().
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableInputTypeDate): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateEnabled): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Fri, 13 Apr 2012 09:12:58 +0000 (09:12 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Skip failing new
encrypted-media test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines.
antonm@chromium.org [Fri, 13 Apr 2012 08:58:52 +0000 (08:58 +0000)]
Rebaselines.

Unreviewed.

* platform/chromium-mac/fast/ruby/nested-ruby-expected.txt: Added.
* platform/chromium-mac/fast/text/international/002-expected.png: Added.
* platform/chromium-mac/fast/text/international/002-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSDocument::setLocation does too much bare-handed lifting
abarth@webkit.org [Fri, 13 Apr 2012 08:57:33 +0000 (08:57 +0000)]
JSDocument::setLocation does too much bare-handed lifting
https://bugs.webkit.org/show_bug.cgi?id=83850

Reviewed by Sam Weinig.

As part of auditing all the ways of kicking off a navigation, I
happened to read JSDocument::setLocation, which uses very old patterns.
This patch updates it to do things the "modern" way.  There shouldn't
be any behavior change.

* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines.
antonm@chromium.org [Fri, 13 Apr 2012 08:55:30 +0000 (08:55 +0000)]
Rebaselines.

Unreviewed.

* platform/chromium-win/platform/chromium/compositing/filters: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline.
philn@webkit.org [Fri, 13 Apr 2012 08:44:30 +0000 (08:44 +0000)]
Unreviewed, GTK rebaseline.

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBackground width (or height) is wrong if width (or height) * zoom < 1.
shinyak@chromium.org [Fri, 13 Apr 2012 08:39:58 +0000 (08:39 +0000)]
Background width (or height) is wrong if width (or height) * zoom < 1.
https://bugs.webkit.org/show_bug.cgi?id=83350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.

Since CachedImage has already similar code, we moved it to IntSize and shared it.

Tests: fast/css/zoom-background-repeat-x-expected.html
       fast/css/zoom-background-repeat-x.html
       fast/css/zoom-background-repeat-y-expected.html
       fast/css/zoom-background-repeat-y.html

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
* platform/graphics/IntSize.h:
(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

LayoutTests:

* fast/css/zoom-background-repeat-x-expected.html: Added.
* fast/css/zoom-background-repeat-x.html: Added.
* fast/css/zoom-background-repeat-y-expected.html: Added.
* fast/css/zoom-background-repeat-y.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 13 Apr 2012 07:56:20 +0000 (07:56 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrepare submitForm for seamless navigation
abarth@webkit.org [Fri, 13 Apr 2012 07:53:46 +0000 (07:53 +0000)]
Prepare submitForm for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83838

Reviewed by Ryosuke Niwa.

Previously, FrameLoader::submitForm called FrameTree::find and
Document::canNavigate separately.  This patch refactors this function
to call findFrameForNavigation, which does both checks.

This doesn't change any behavior today, but it prepares us to implement
seamless navigation.  Once the seamless branch lands, this change will
be tested by seamless-form-* in https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless

For context, see:
https://github.com/eseidel/webkit/commit/3f27340577ac91b2cc0a834dd2c6fdfcac296c32

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShould clear an invalid string in a date field on blur
tkent@chromium.org [Fri, 13 Apr 2012 07:35:40 +0000 (07:35 +0000)]
Should clear an invalid string in a date field on blur
https://bugs.webkit.org/show_bug.cgi?id=83863

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/forms/date/input-date-commit-valid-only.html

* html/DateInputType.cpp:
(WebCore::DateInputType::handleBlurEvent):
Reset the visible value. The code is same as NumberInputType::handleBlurEvent().

LayoutTests:

* fast/forms/date/input-date-commit-valid-only-expected.txt: Added.
* fast/forms/date/input-date-commit-valid-only.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] <input type=date> tests should pass.
tkent@chromium.org [Fri, 13 Apr 2012 07:30:57 +0000 (07:30 +0000)]
[Chromium] <input type=date> tests should pass.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalendar Picker: remove unnecessary code from calendarPicker.{css,js}
tkent@chromium.org [Fri, 13 Apr 2012 06:33:14 +0000 (06:33 +0000)]
Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
https://bugs.webkit.org/show_bug.cgi?id=83685

Reviewed by Kentaro Hara.

Remove the followings from input files:
 - multi line comments /*...*/ (.js and .css)
 - single line comment //... (.js)
 - repeating whitespace (.js and .css)
 - leading and trailing whitespace (.js and .css)
 - empty lines (.js and .css)

This doesn't work for arbitrary JavaScript or CSS inputs, but
works well for expected input files like
css/make-css-file-arrays.pl

* make-file-arrays.py:
(strip_whitespace_and_comments):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark test as also crashing.
antonm@chromium.org [Fri, 13 Apr 2012 06:19:01 +0000 (06:19 +0000)]
Mark test as also crashing.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium: Fix scrollbar tickmark drawing on Mountain Lion
commit-queue@webkit.org [Fri, 13 Apr 2012 06:14:59 +0000 (06:14 +0000)]
Chromium: Fix scrollbar tickmark drawing on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=83844

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-04-12
Reviewed by James Robinson.

On Mountain Lion overlay scrollbars have a new expanded mode. In expanded mode the scrolllbar is slightly wider which causes the tickmarks to look incorrect. Fix was to explicitly enter expanded mode to get the correct look.
Screenshots:
broken: http://i.imgur.com/PDKYH.png
fixed: http://i.imgur.com/utp0Y.png

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint): Called setExpanded if API is available.
* platform/mac/NSScrollerImpDetails.h: Exposed the isExpanded: API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines.
antonm@chromium.org [Fri, 13 Apr 2012 06:11:56 +0000 (06:11 +0000)]
Rebaselines.

Unreviewed.

* platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines.
antonm@chromium.org [Fri, 13 Apr 2012 06:08:21 +0000 (06:08 +0000)]
Rebaselines.

Unreviewed.

* platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLocalizedDateICU should ignore timezones
tkent@chromium.org [Fri, 13 Apr 2012 06:07:40 +0000 (06:07 +0000)]
LocalizedDateICU should ignore timezones
https://bugs.webkit.org/show_bug.cgi?id=83859

Reviewed by Hajime Morita.

udat_parse() and udat_format() shift the input date by the offset of the
default timezone. We don't need this behavior for type=date. So we
specify "GMT" to udat_open().

No new tests. This behavior depends on the timezone setting of the local machine.

* platform/text/LocalizedDateICU.cpp:
(WebCore::createShortDateFormatter):
Added. Common factory functio for UDateFormat. Use "GMT" instead of the
default timezone.
(WebCore::parseLocalizedDate): Use createShortDateFormatter().
(WebCore::formatLocalizedDate): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable WebKit2 by default in configure
carlosgc@webkit.org [Fri, 13 Apr 2012 06:00:09 +0000 (06:00 +0000)]
[GTK] Enable WebKit2 by default in configure
https://bugs.webkit.org/show_bug.cgi?id=83753

Reviewed by Martin Robinson.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines.
antonm@chromium.org [Fri, 13 Apr 2012 05:37:01 +0000 (05:37 +0000)]
Rebaselines.

Unreviewed.

* fast/media/mq-min-pixel-ratio-expected.txt: Added.
* fast/reflections/reflection-masks-expected.txt: Added.
* fast/reflections/reflection-masks-opacity-expected.txt: Added.
* fast/reflections/reflection-masks-outset-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
* platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
* platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
* platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
* platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
* platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
* platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
* platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
* platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
* platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-contrast-expected.png:
* platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
* platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-invert-expected.png:
* platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-saturate-expected.png:
* platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
* platform/chromium-mac/css3/filters/regions-expanding-expected.png:
* platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
* platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
* platform/chromium-mac/platform/chromium/virtual/threaded: Added.
* platform/chromium-mac/platform/chromium/virtual/threaded/compositing: Added.
* platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility: Added.
* platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-mac/svg/custom/createImageElement-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/createImageElement2-expected.png:
* platform/chromium-mac/svg/custom/focus-ring-expected.png:
* platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/js-update-image-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
* platform/efl/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/efl/fast/reflections/reflection-masks-expected.txt: Removed.
* platform/efl/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
* platform/efl/fast/reflections/reflection-masks-outset-expected.png: Removed.
* platform/efl/fast/reflections/reflection-masks-outset-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.txt: Removed.
* platform/gtk/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Removed.
* platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Removed.
* platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/mac/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/qt/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrepare window.location for seamless navigation
abarth@webkit.org [Fri, 13 Apr 2012 05:31:20 +0000 (05:31 +0000)]
Prepare window.location for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83843

Reviewed by Eric Seidel.

This patch refactors window.location to flow through
FrameLoader::findFrameForNavigation, which is where we're going to
implement the seamless navigation redirect.  This patch shouldn't cause
any observable changes in behavior today, but it will make all the
seamless-window-location* tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
pass once we merge the seamlesss branch.  See
https://github.com/eseidel/webkit/commit/a6e708fa6c643b156397e9a287b40a0868c7959c
for context.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
* page/Location.cpp:
(WebCore::Location::setHref):
(WebCore::Location::setProtocol):
(WebCore::Location::setHost):
(WebCore::Location::setHostname):
(WebCore::Location::setPort):
(WebCore::Location::setPathname):
(WebCore::Location::setSearch):
(WebCore::Location::setHash):
(WebCore::Location::assign):
(WebCore::Location::replace):
(WebCore::Location::setLocation):
(WebCore):
* page/Location.h:
(Location):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Background filters for composited layers
danakj@chromium.org [Fri, 13 Apr 2012 05:28:44 +0000 (05:28 +0000)]
[chromium] Background filters for composited layers
https://bugs.webkit.org/show_bug.cgi?id=80046

Reviewed by Adrienne Walker.

Source/WebCore:

Adds background filters to LayerChromium/CCLayerImpl. These filters are
applied to any pixels in the contents behind the layer and seen through
it.

This is done by adding a backgroundTexture() to the render surface, which
holds the read-back contents of the target framebuffer, background filter
applied, in the surface's own coordinate space. Then this is drawn back
into the frame buffer before the contents of the surface itself is drawn.

Tests: platform/chromium/compositing/filters/background-filter-blur-off-axis.html
       platform/chromium/compositing/filters/background-filter-blur-outsets.html
       platform/chromium/compositing/filters/background-filter-blur.html

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBackgroundFilters):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::backgroundFilters):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderSurface):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::useManagedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setBackgroundFilters):
(WebCore::RenderSurfaceChromium::backgroundFilters):
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setBackgroundFilters):
(WebCore):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::backgroundFilters):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareBackgroundTexture):
(WebCore):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::computeDeviceTransform):
(WebCore::CCRenderSurface::computeDeviceBoundingBox):
(WebCore::CCRenderSurface::computeReadbackDeviceBoundingBox):
(WebCore::CCRenderSurface::readbackDeviceContentRect):
(WebCore::copyTextureToFramebuffer):
(WebCore::CCRenderSurface::copyDeviceToBackgroundTexture):
(WebCore::getSkBitmapTextureId):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::applyFilters):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
(WebCore::CCRenderSurface::setBackgroundFilters):
(WebCore::CCRenderSurface::backgroundFilters):
(WebCore::CCRenderSurface::backgroundTexture):
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::setBackgroundBlurOnNode):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/chromium:

* tests/CCLayerImplTest.cpp:
(WebCore::TEST):

LayoutTests:

* platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium/compositing/filters/background-filter-blur-expected.txt: Added.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Added.
* platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Added.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
* platform/chromium/compositing/filters/background-filter-blur-outsets.html: Added.
* platform/chromium/compositing/filters/background-filter-blur.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove V8DOMWindowShell::setLocation
abarth@webkit.org [Fri, 13 Apr 2012 04:39:58 +0000 (04:39 +0000)]
Remove V8DOMWindowShell::setLocation
https://bugs.webkit.org/show_bug.cgi?id=83833

Reviewed by Eric Seidel.

V8DOMWindowShell::setLocation is only used by document.location.  It's
more direct for document.location to call Location::setHref directly.
This integrates correctly with the navigation rules for
<iframe seamless>.

(See https://github.com/eseidel/webkit/compare/master...seamless for
more context about the connection with seamless.)

Reviewed on GitHub:
https://github.com/abarth/webkit/commit/48601729d53a6ac39df5a43b22218c91330c3f61

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrepare functions in LengthFunctions.h for LayoutUnits
leviw@chromium.org [Fri, 13 Apr 2012 04:19:42 +0000 (04:19 +0000)]
Prepare functions in LengthFunctions.h for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83726

Reviewed by Eric Seidel.

Preparing the functions that live in LengthFunctions for sub-pixel layout, which entails
using and returning LayoutUnits instead of integers. There are a number of rendering
classes that are laid out using integers -- see https://trac.webkit.org/wiki/LayoutUnit
for details -- so this also adds integer-specific versions of the length functions for
explicit use in those classes.

No new tests. No change in behavior.

* css/LengthFunctions.h:
(WebCore): Using LayoutUnits for sub-pixel precision and adding integer-specific versions
of minimumValueForLength and valueForLength that truncate.
* css/LengthFunctions.cpp:
(WebCore):
* dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Document sizes are integral.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layOutAxis): The frame tree continues to be integral.
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::timerFired): RenderMarquee scrolling uses integral values.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Table layout is integral.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114075.
commit-queue@webkit.org [Fri, 13 Apr 2012 03:51:43 +0000 (03:51 +0000)]
Unreviewed, rolling out r114075.
http://trac.webkit.org/changeset/114075
https://bugs.webkit.org/show_bug.cgi?id=83857

Breaks compile (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12

Source/Platform:

* Platform.gypi:

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/VideoFrameChromium.cpp: Renamed from Source/Platform/chromium/src/WebVideoFrame.cpp.
(WebCore):
(WebCore::VideoFrameChromium::~VideoFrameChromium):
* platform/graphics/chromium/VideoFrameChromium.h: Copied from Source/Platform/chromium/public/WebVideoFrame.h.
(WebCore):
(VideoFrameChromium):
* platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebVideoFrame.h:
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
* src/AssertMatchingEnums.cpp:
* src/VideoFrameChromiumImpl.cpp: Added.
(WebKit):
(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):
(WebKit::VideoFrameChromiumImpl::requiredTextureSize):
(WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
(WebKit::VideoFrameChromiumImpl::textureId):
(WebKit::VideoFrameChromiumImpl::textureTarget):
* src/VideoFrameChromiumImpl.h: Renamed from Source/Platform/chromium/public/WebVideoFrame.h.
(WebKit):
(VideoFrameChromiumImpl):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse _self to represnet self-navigation, like in the HTML5 spec
abarth@webkit.org [Fri, 13 Apr 2012 03:47:20 +0000 (03:47 +0000)]
Use _self to represnet self-navigation, like in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=83834

Reviewed by Eric Seidel.

This patch aligns the internal state representation of the FrameLoader
more closely with the HTML5 spec.  Both the null string and "_self"
represent self-navigation, but the HTML5 spec distinguishes them when
navigating seamless iframes.  In that case, "_self" is explicit
self-navigation, whereas a null string will get redirected to the
"master" frame (the closest enclosing non-seamless frame).

This patch shouldn't have any observable behavior changes, but it will
be useful when we merge in the seamless branch from GitHub.
(See https://github.com/eseidel/webkit/commit/df0e71fcacdb0e7e45fe669afe1314cec5b76523
which contains this change.)

Once the seamless branch lands, this change will be tested by a number
of tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
including seamless-hyperlink.html.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtract PerfTest class from PerfTestRunner
rniwa@webkit.org [Fri, 13 Apr 2012 03:11:20 +0000 (03:11 +0000)]
Extract PerfTest class from PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83847

Reviewed by Hajime Morita.

Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
that was previously represented by a tuple.

Also moved the logic to determine whether a given test is chromium style or not from run() to
_collect_tests(). And moved the output parsing algorithms for parser style and chromium style
tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
add new types of tests more easily.

* Scripts/webkitpy/performance_tests/perftest.py: Added.
(PerfTest):
(PerfTest.__init__):
(PerfTest.test_name):
(PerfTest.dirname):
(PerfTest.path_or_url):
(PerfTest._should_ignore_line_in_parser_test_result):
(PerfTest.parse_output):
(ChromiumStylePerfTest):
(ChromiumStylePerfTest.__init__):
(ChromiumStylePerfTest.parse_output):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(run_test):
(_tests_for_runner):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(_collect_tests_and_sort_test_name):
(test_collect_tests):
(test_collect_tests_with_skipped_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium...
jamesr@google.com [Fri, 13 Apr 2012 02:52:59 +0000 (02:52 +0000)]
[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851

Reviewed by Adam Barth.

Source/Platform:

Move WebVideoFrame API into Platform.

* Platform.gypi:
* chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
* chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.
(WebKit):

Source/WebCore:

Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).

Covered by existing media/ and compositing/ layout tests.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebKit):

Source/WebKit/chromium:

Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.

* WebKit.gyp:
* public/WebVideoFrame.h:
* src/AssertMatchingEnums.cpp:
* src/VideoFrameChromiumImpl.cpp: Removed.
* src/VideoFrameChromiumImpl.h: Removed.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r113900): Text tests started failing
ap@apple.com [Fri, 13 Apr 2012 02:51:18 +0000 (02:51 +0000)]
REGRESSION (r113900): Text tests started failing
https://bugs.webkit.org/show_bug.cgi?id=83724

Reviewed by Dan Bernstein.

Source/WebCore:

* Resources/DefaultFonts.plist.in: Use serif fonts for standard family again,
and updated the list with better fonts for Japanese.

LayoutTests:

* platform/mac/Skipped: unskip the tests.

* platform/mac/fast/ruby/nested-ruby-expected.png:
* platform/mac/fast/ruby/nested-ruby-expected.txt:
* platform/mac/fast/text/international/002-expected.png:
* platform/mac/fast/text/international/002-expected.txt:
Updated for minor rendering differences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove replaceUsingStringSearch() for case of a single character searchValue
benjamin@webkit.org [Fri, 13 Apr 2012 02:30:03 +0000 (02:30 +0000)]
Improve replaceUsingStringSearch() for case of a single character searchValue
https://bugs.webkit.org/show_bug.cgi?id=83738

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.

This patch improves replaceUsingStringSearch() with the following:
-Add a special case for single character search, taking advantage of the faster WTF::find().
-Inline replaceUsingStringSearch().
-Use StringImpl::create() instead of UString::substringSharingImpl() since we know we are in the bounds
 by definition.

This gives less than 1% improvement for the multicharacter replace.
The single character search show about 9% improvement.

* runtime/StringPrototype.cpp:
(JSC::replaceUsingStringSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInline StringImpl::find(UChar, ...)
benjamin@webkit.org [Fri, 13 Apr 2012 02:25:32 +0000 (02:25 +0000)]
Inline StringImpl::find(UChar, ...)
https://bugs.webkit.org/show_bug.cgi?id=83737

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.

The implementation of StringImpl::find() is a simple branch before invoking one of
two inline functions. The overhead of having a function for StringImpl::find() is significant.

It is better to let the compiler decide if that should be inlined or not.

* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::find):
(WTF):
(WTF::reverseFind):
(WTF::StringImpl::find):
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Fri, 13 Apr 2012 02:12:40 +0000 (02:12 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPreprocessing text files with modern clang treats double slashes in comments
ap@apple.com [Fri, 13 Apr 2012 01:54:08 +0000 (01:54 +0000)]
Preprocessing text files with modern clang treats double slashes in comments
https://bugs.webkit.org/show_bug.cgi?id=83827

Reviewed by Mark Rowe.

Source/WebCore:

* DerivedSources.make: Pass appropriate flags to both llvm and gcc.

Source/WebKit2:

* DerivedSources.make: Pass appropriate flags to both llvm and gcc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Encrypted Media Extensions events and errors to HTMLMediaElement
commit-queue@webkit.org [Fri, 13 Apr 2012 01:32:36 +0000 (01:32 +0000)]
Add Encrypted Media Extensions events and errors to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82974

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-12
Reviewed by Adam Barth.

The new events and errors are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#events.

Source/WebCore:

Tests: fast/events/constructors/media-key-event-constructor.html
       media/encrypted-media/encrypted-media-constants.html
       media/encrypted-media/encrypted-media-events.html

* WebCore.gypi:
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
* bindings/v8/Dictionary.h:
(WebCore):
(Dictionary):
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* html/HTMLAttributeNames.in:
* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerKeyAdded):
(WebCore::HTMLMediaElement::mediaPlayerKeyError):
(WebCore::HTMLMediaElement::mediaPlayerKeyMessage):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMediaElement.idl:
* html/MediaError.h:
* html/MediaError.idl:
* html/MediaKeyError.h: Added.
(WebCore):
(MediaKeyError):
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::code):
(WebCore::MediaKeyError::MediaKeyError):
* html/MediaKeyError.idl: Added.
* html/MediaKeyEvent.cpp: Added.
(WebCore):
(WebCore::MediaKeyEventInit::MediaKeyEventInit):
(WebCore::MediaKeyEvent::MediaKeyEvent):
(WebCore::MediaKeyEvent::~MediaKeyEvent):
(WebCore::MediaKeyEvent::interfaceName):
* html/MediaKeyEvent.h: Added.
(WebCore):
(MediaKeyEventInit):
(MediaKeyEvent):
(WebCore::MediaKeyEvent::create):
(WebCore::MediaKeyEvent::keySystem):
(WebCore::MediaKeyEvent::sessionId):
(WebCore::MediaKeyEvent::initData):
(WebCore::MediaKeyEvent::message):
(WebCore::MediaKeyEvent::defaultURL):
(WebCore::MediaKeyEvent::errorCode):
(WebCore::MediaKeyEvent::systemCode):
* html/MediaKeyEvent.idl: Added.
* page/DOMWindow.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore):
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::keyError):
(WebCore::MediaPlayer::keyMessage):
(WebCore::MediaPlayer::keyNeeded):
* platform/graphics/MediaPlayer.h:
(MediaPlayerClient):
(WebCore::MediaPlayerClient::mediaPlayerKeyAdded):
(WebCore::MediaPlayerClient::mediaPlayerKeyError):
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage):
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
(MediaPlayer):

Source/WebKit/chromium:

* public/WebMediaPlayerClient.h:
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::keyAdded):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::keyError):
(WebKit::WebMediaPlayerClientImpl::keyMessage):
(WebKit::WebMediaPlayerClientImpl::keyNeeded):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

LayoutTests:

* fast/events/constructors/media-key-event-constructor-expected.txt: Added.
* fast/events/constructors/media-key-event-constructor.html: Added.
* fast/js/resources/js-test-pre.js:
(shouldBeZero):
(shouldBeEmptyString):
* media/encrypted-media/encrypted-media-constants-expected.txt: Added.
* media/encrypted-media/encrypted-media-constants.html: Added.
* media/encrypted-media/encrypted-media-events-expected.txt: Added.
* media/encrypted-media/encrypted-media-events.html: Added.
* media/video-test.js:
(testExpected):
(testArraysEqual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReset the user preferred language overrides in Internals::reset
andersca@apple.com [Fri, 13 Apr 2012 01:26:17 +0000 (01:26 +0000)]
Reset the user preferred language overrides in Internals::reset
https://bugs.webkit.org/show_bug.cgi?id=83845

Reviewed by Ryosuke Niwa.

We don't want setting the language override in one test to affect subsequent tests,
so make sure to reset it in Internals::reset.

* testing/Internals.cpp:
(WebCore::Internals::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake layout tests not access apache on localhost:80
commit-queue@webkit.org [Fri, 13 Apr 2012 01:11:16 +0000 (01:11 +0000)]
Make layout tests not access apache on localhost:80
https://bugs.webkit.org/show_bug.cgi?id=82197

Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-12
Reviewed by Ryosuke Niwa.

It pollutes the logs of people running a local webserver, and has the
potential for changing the results of tests run locally.

* fast/dom/onerror-img.html:
* fast/js/custom-constructors-expected.txt:
* fast/js/script-tests/custom-constructors.js:
* fast/notifications/notifications-double-show.html:
* fast/notifications/notifications-with-permission.html:
* fast/notifications/notifications-without-permission.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into...
caseq@chromium.org [Fri, 13 Apr 2012 01:08:21 +0000 (01:08 +0000)]
[chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
https://bugs.webkit.org/show_bug.cgi?id=83837

Reviewed by James Robinson.

- merge CCSingleThreadProxy::commitIfNeeded() and CCSingleThreadProxy::doComposite() into commitAndComposite()

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback): call site updated.
(WebCore::CCSingleThreadProxy::compositeImmediately): ditto.
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove FrameLoader:m_isLoadingMainResource, since it is always
japhet@chromium.org [Fri, 13 Apr 2012 01:07:27 +0000 (01:07 +0000)]
Remove FrameLoader:m_isLoadingMainResource, since it is always
false at the only point it is checked.
https://bugs.webkit.org/show_bug.cgi?id=83819

Reviewed by Adam Barth.

No new tests, no functionality change intended.

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end): Merge with endIfNotLoadingMainResource(), always end, assert that we're still attached.
* loader/DocumentWriter.h:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h: Remove isLoadingMainResource(), didEndDocument(), and m_isLoadingMainResource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoXMLSerializer().serializeToString() doesn't generate the XML declaration markup like...
rwlbuis@webkit.org [Fri, 13 Apr 2012 00:58:30 +0000 (00:58 +0000)]
XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox
https://bugs.webkit.org/show_bug.cgi?id=83432

Reviewed by Ryosuke Niwa.

Source/WebCore:

Serialize the xml declaration exactly as parsed, if present in the document.

Test: fast/dom/dom-parse-serialize-xmldecl.html

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setXMLStandalone): update xmlStandalone to either yes or no.
* dom/Document.h:
(WebCore::Document::xmlStandalone):
(WebCore::Document::xmlStandaloneStatus): xmlStandalone can be unspecified, yes or no.
(WebCore::Document::hasXMLDeclaration):  test if xml declaration is present.
(WebCore::Document::setHasXMLDeclaration):
(Document):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendXMLDeclaration): write xml declaration if present.
(WebCore):
(WebCore::MarkupAccumulator::appendStartMarkup):
* editing/MarkupAccumulator.h:
(MarkupAccumulator):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.

LayoutTests:

Verify that xml declaration gets serialized if present. The updated test results are improvements.

* fast/dom/dom-parse-serialize-display-expected.txt:
* fast/dom/dom-parse-serialize-expected.txt:
* fast/dom/dom-parse-serialize-xmldecl-expected.txt: Added.
* fast/dom/dom-parse-serialize-xmldecl.html: Added.
* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* fast/xsl/xslt-processor-expected.txt:
* http/tests/xmlhttprequest/xml-encoding-expected.txt:
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowindow.open should prepare for seamless navigation by using findFrameForNavigation
abarth@webkit.org [Fri, 13 Apr 2012 00:42:37 +0000 (00:42 +0000)]
window.open should prepare for seamless navigation by using findFrameForNavigation
https://bugs.webkit.org/show_bug.cgi?id=83835

Reviewed by Ryosuke Niwa.

Before this patch, window.open called FrameTree::find and
Document::canNavigate separately.  This patch refactors the code to
call FrameLoader::findFrameForNavigation, which does both.  This
refactoring prepares window.open to understand seamless navigation,
which will happen in findFrameForNavigation.

This patch should have no behavior change today, but once we merge the
seamless branch, this change will be tested by
https://github.com/eseidel/webkit/blob/seamless/LayoutTests/fast/frames/seamless/seamless-window-open.html

See https://github.com/eseidel/webkit/commit/a0d8b7defbb63047912aefbc8e22bca4f0638c37 for context.

* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
(WebCore::createWindow):
* loader/FrameLoader.h:
(FrameLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert layout test resource PNGs to sRGB. Some tests, such as
commit-queue@webkit.org [Fri, 13 Apr 2012 00:26:23 +0000 (00:26 +0000)]
Convert layout test resource PNGs to sRGB. Some tests, such as
compositing/color-matching/image-color-matching.html, expect that
images with an RGB profile will not be altered when displayed. However,
some of the resources have RGB profiles that are different from sRGB
and actually should change when displayed with color profile support.

https://bugs.webkit.org/show_bug.cgi?id=83799

Patch by Tony Payne <tpayne@chromium.org> on 2012-04-12
Reviewed by Adam Barth.

* compositing/resources/thiswayup.png:
* css3/filters/resources/reference.png:
* fast/media/resources/apple_logo_half_size.png:
* fast/reflections/resources/kate.png:
* svg/as-border-image/resources/large-tiles.png:
* svg/custom/resources/green-checker.png:
* svg/custom/resources/red-checker.png:
* svg/wicd/resources/test-svg-child-object-rightsizing.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and Executa...
msaboff@apple.com [Fri, 13 Apr 2012 00:09:40 +0000 (00:09 +0000)]
StructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and ExecutableMemoryHandle objects
https://bugs.webkit.org/show_bug.cgi?id=83823

Reviewed by Gavin Barraclough.

Put the clearing of the accessType to after the call to deref() so that
deref() can use the accessType to delete referenced objects as needed.

* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Marking fast/regions/region-overflow-break.html as image failure on Mac.
scheib@chromium.org [Fri, 13 Apr 2012 00:03:22 +0000 (00:03 +0000)]
[Chromium] Marking fast/regions/region-overflow-break.html as image failure on Mac.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters...
aestes@apple.com [Thu, 12 Apr 2012 23:58:44 +0000 (23:58 +0000)]
REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important'
https://bugs.webkit.org/show_bug.cgi?id=83832

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Shipping versions of iAd Producer rely on the pre-r102262 behavior of
respecting '!important' when specified in a CSSStyleDeclaration
property setter. Restore this quirky behavior for versions of the app
that expect it.

* WebCore.exp.in: Export
Settings::setShouldRespectPriorityInCSSAttributeSetters().
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate): If
setShouldRespectPriorityInCSSAttributeSetters() is true, restore the
pre-r102262 behavior wherein we attempt to parse '!important' out of
the property value.
* page/Settings.cpp:
(WebCore::Settings::setShouldRespectPriorityInCSSAttributeSetters):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
* page/Settings.h:

Source/WebKit/mac:

* Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first
version of WebKit.framework to ignore '!important' in
CSSStyleDeclaration property setters.
* WebView/WebView.mm:
(shouldRespectPriorityInCSSAttributeSetters):
(-[WebView _commonInitializationWithFrameName:groupName:]): Enable a
quirk to restore pre-r102262 behavior if the application is iAd Producer
and was linked against a version of WebKit.framework that had the old behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered elements
achicu@adobe.com [Thu, 12 Apr 2012 23:55:25 +0000 (23:55 +0000)]
REGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered elements
https://bugs.webkit.org/show_bug.cgi?id=83815

Reviewed by Simon Fraser.

Source/WebCore:

The filtered area used to be the dirty rect intersected by the bounding box of the
layer. During a previous change that behavior was lost, so adding it back now.

Also, removing the memory buffers used to compute filters after the filter is computed.
They are deleted next time the filter is applied anyway, so there's no need to keep the
memory for them.

Test: css3/filters/offscreen-filters-memory-usage.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::prepare):
(WebCore):
(WebCore::FilterEffectRenderer::clearIntermediateResults):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
* rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):

LayoutTests:

Adding a test that creates a lot of layers outside the viewport. The memory should not grow
and the browser should not crash.

* css3/filters/offscreen-filters-memory-usage-expected.txt: Added.
* css3/filters/offscreen-filters-memory-usage.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Build fix after Windows export definition file change.
bfulgham@webkit.org [Thu, 12 Apr 2012 23:10:02 +0000 (23:10 +0000)]
[WinCairo] Build fix after Windows export definition file change.

* win/WebKit2CFLite.def: This file needs to be kept in sync with
WebKit2.def (aside from the WebKitInterface exports.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114045 268f45cc-cd09-0410-ab3c-d52691b4dbfc