WebKit-https.git
8 years agoWeb Inspector: add CSS model classes to the compilation.
pfeldman@chromium.org [Wed, 5 Oct 2011 10:12:56 +0000 (10:12 +0000)]
Web Inspector: add CSS model classes to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69376

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-05
Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/CSSCompletions.js:
* inspector/front-end/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype.canSetContent):
* inspector/front-end/ResourceTreeModel.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._containsInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
* inspector/front-end/externs.js:
(Array.prototype.keySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowatchlist: Add more rules for chromium public api and sort the file.
levin@chromium.org [Wed, 5 Oct 2011 09:28:55 +0000 (09:28 +0000)]
watchlist: Add more rules for chromium public api and sort the file.
https://bugs.webkit.org/show_bug.cgi?id=69323

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline fast/repaint/japanese-rl-selection-repaint-in-regions.html
hans@chromium.org [Wed, 5 Oct 2011 09:26:58 +0000 (09:26 +0000)]
Rebaseline fast/repaint/japanese-rl-selection-repaint-in-regions.html
for chromium-cg-mac after r96675. (By Garden-o-Matic.)

* platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInput styles are unexpectedly shared regardless of required status difference.
tkent@chromium.org [Wed, 5 Oct 2011 09:25:32 +0000 (09:25 +0000)]
Input styles are unexpectedly shared regardless of required status difference.
https://bugs.webkit.org/show_bug.cgi?id=69402

Reviewed by Daniel Bates.

Source/WebCore:

Tests: fast/css/pseudo-required-shared.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().

LayoutTests:

* fast/css/pseudo-required-shared-expected.html: Added.
* fast/css/pseudo-required-shared.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowatchlist: Don't add the same message to a bug more than once.
levin@chromium.org [Wed, 5 Oct 2011 09:21:54 +0000 (09:21 +0000)]
watchlist: Don't add the same message to a bug more than once.
https://bugs.webkit.org/show_bug.cgi?id=69303

Reviewed by Adam Barth.

* Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
if a message is in the comments already.
* Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
Pick a bug supplied by the mock. Change the test due to different output
from the mock watch list tool.
* Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
another email so it will be filtered out, fix bugs to have the cc and comment fields,
and fix fetch_bug to handle bug_id's which are text (because that took me way too long
to debug).
* Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
and/or cc's that are already in the bug.
* Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
and remove a comment that is filtered out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed build fix after r96643.
kbalazs@webkit.org [Wed, 5 Oct 2011 09:09:33 +0000 (09:09 +0000)]
[Qt][WK2] Unreviewed build fix after r96643.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, update expected file after r96509.
rgabor@webkit.org [Wed, 5 Oct 2011 09:03:01 +0000 (09:03 +0000)]
[Qt] Unreviewed gardening, update expected file after r96509.

* platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Web Inspector: save inspector state into single string instead of string map
yurys@chromium.org [Wed, 5 Oct 2011 08:21:59 +0000 (08:21 +0000)]
[Chromium] Web Inspector: save inspector state into single string instead of string map
https://bugs.webkit.org/show_bug.cgi?id=69335

Now that Chromium side is updated, remove unused methods from the DevToolsAgent API.

Reviewed by Pavel Feldman.

* public/WebDevToolsAgent.h:
* public/WebDevToolsAgentClient.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
* src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
rgabor@webkit.org [Wed, 5 Oct 2011 08:09:16 +0000 (08:09 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-mac/Skipped: Skip new failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Use WKRetainPtr for WK types in WebKit2 GTK+
carlosgc@webkit.org [Wed, 5 Oct 2011 08:03:01 +0000 (08:03 +0000)]
[GTK] Use WKRetainPtr for WK types in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=69404

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextFinalize):
(createDefaultWebContext):
(webkitWebContextGetWKContext):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_uri):
(webkit_web_view_load_alternate_html):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Node::willBlur()
tkent@chromium.org [Wed, 5 Oct 2011 06:07:51 +0000 (06:07 +0000)]
Remove Node::willBlur()
https://bugs.webkit.org/show_bug.cgi?id=69395

Reviewed by Ryosuke Niwa.

Revert the WebCore part of r87371 because
FrameSelection::textWillBeReplaced() doesn't set focus anymore.
No new tests. Covered by fast/forms/input-number-blur-twice.html.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode): Revert r87371.
* dom/Node.cpp: ditto.
* dom/Node.h: ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::handleBlurEvent): ditto.
* html/HTMLInputElement.h: ditto.
* html/InputType.cpp:
(WebCore::InputType::handleBlurEvent): ditto.
* html/InputType.h: ditto.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::handleBlurEvent): ditto.
* html/NumberInputType.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce feature flags for incomplete input types
tkent@chromium.org [Wed, 5 Oct 2011 06:06:43 +0000 (06:06 +0000)]
Introduce feature flags for incomplete input types
https://bugs.webkit.org/show_bug.cgi?id=68971

Reviewed by Hajime Morita.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
 Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
* html/DateInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATE)
* html/DateInputType.h: ditto.
* html/DateTimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIME)
* html/DateTimeInputType.h: ditto.
* html/DateTimeLocalInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIMELOCAL)
* html/DateTimeLocalInputType.h: ditto.
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
 Recognizes type attribute value only if it is enabled by ENABLE(INPUT_TYPE_*).
* html/MonthInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_MONTH)
* html/MonthInputType.h: ditto.
* html/TimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_TIME)
* html/TimeInputType.h: ditto.
* html/WeekInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_WEEK)
* html/WeekInputType.h: ditto.

Source/WebKit/chromium:

* features.gypi: Add disabled ENABLE_INPUT_TYPE_* flags.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.

Tools:

* Scripts/build-webkit:
Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
They are disabled by default.

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
Add ENABLE_INPUT_TYPE_* flags. They are disabled by default.
* win/tools/vsprops/FeatureDefinesCairo.vsprops: ditto.

LayoutTests:

Skip fast/forms/{date,datetime,datetimelocal,month,time,week}.

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
ggaren@apple.com [Wed, 5 Oct 2011 05:02:57 +0000 (05:02 +0000)]
Build fix.

* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use an explicit cast when shortening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Only set when the custom encoding is different from existing value
gyuyoung.kim@samsung.com [Wed, 5 Oct 2011 04:56:08 +0000 (04:56 +0000)]
[EFL] Only set when the custom encoding is different from existing value
https://bugs.webkit.org/show_bug.cgi?id=69061

Reviewed by Hajime Morita.

Only set the custom encoding value if it is different from the current value, to avoid
reloading the page.

* ewk/ewk_view.cpp:
(ewk_view_setting_encoding_custom_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=69398
hyatt@apple.com [Wed, 5 Oct 2011 04:45:48 +0000 (04:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69398

Source/WebCore:

[CSS3 Regions] Support the region-overflow property properly.

(1) Change -webkit-break to break, since the -webkit-region-overflow property already has the
-webkit- extension.

(2) Fix clipping so that it works when overflow is set or when region break is set.

(3) Refactor all the pagination spots to check if a next page is available using the new hasNextPage
function. This prevents us from paginating if we hit the last region and further breaks are no longer
allowed.

Reviewed by Dan Bernstein.

Added new tests in fast/regions.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator RegionOverflow):
* css/CSSValueKeywords.in:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::hasNextPage):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):

LayoutTests:

[CSS3 Regions] Support the region-overflow property properly.

Reviewed by Dan Bernstein.

* fast/regions/region-overflow-auto-overflow-hidden.html: Added.
* fast/regions/region-overflow-auto-overflow-visible.html: Added.
* fast/regions/region-overflow-break.html: Added.
* fast/regions/script-tests/webkit-region-overflow-parsing.js:
* fast/regions/webkit-region-overflow-parsing-expected.txt:
* platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
* platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/mac/fast/regions/region-overflow-break-expected.png: Added.
* platform/mac/fast/regions/region-overflow-break-expected.txt: Added.
* platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png:
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd static ClassInfo structs to classes that override JSCell::getCallData
mhahnenberg@apple.com [Wed, 5 Oct 2011 02:47:42 +0000 (02:47 +0000)]
Add static ClassInfo structs to classes that override JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=69311

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct.  This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing).  These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
Also added new createStructure methods to those classes that didn't have
them so that the new ClassInfo structs would be used when creating the Structures
in these classes.

* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::createStructure):

getCallData was not marked as static in StrictModeTypeErrorFunction.
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::createStructure):
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::createStructure):
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:

Source/WebCore:

No new tests.

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct.  This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing).  These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.
Also added new createStructure methods to those classes that didn't have
them so that the new ClassInfo structs would be used when creating the Structures
in these classes.

* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSome JSValue cleanup
ggaren@apple.com [Wed, 5 Oct 2011 02:38:49 +0000 (02:38 +0000)]
Some JSValue cleanup
https://bugs.webkit.org/show_bug.cgi?id=69320

../JavaScriptCore:

Reviewed by Darin Adler.

No measurable performance change.

Removed some JSValue::get* functions. get* used to be an optimization
when every value operation was a virtual function call: get* would combine
two virtual calls into one. Now, with non-virtual, inlined functions, get*
isn't faster, and may be slightly slower.

Merged getBoolean(bool&) and getBoolean() into asBoolean().

Merged uncheckedGetNumber(), getJSNumber() and getNumber() into
asNumber().

* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::asNumber):
(JSC::JSValue::asBoolean): As promised!

* runtime/NumberPrototype.cpp:
(JSC::toThisNumber):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf): Removed a bunch of uses of getJSNumber()
by switching to toThisNumber().

* API/JSCallbackObjectFunctions.h:
(JSC::::toNumber):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
* dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/DateInstance.h:
(JSC::DateInstance::internalNumber):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
* runtime/JSArray.cpp:
(JSC::compareNumbersForQSort): Replaced getNumber() => isNumber() / asNumber().
getBoolean() => isBoolean() / asBoolean(), uncheckedGetNumber() => asNumber().

* runtime/JSCell.cpp:
* runtime/JSCell.h: Nixed getJSNumber().

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
* runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):
* runtime/NumberObject.cpp:
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/Operations.h:
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd): Replaced getNumber() => isNumber() / asNumber().
getBoolean() => isBoolean() / asBoolean(), uncheckedGetNumber() => asNumber().

../WebCore:

Reviewed by Darin Adler.

* bindings/js/JSDOMBinding.cpp:
(WebCore::valueToDate):
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
* bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertValueToJValue): Updated for JSC changes.

../WebKit/mac:

Reviewed by Darin Adler.

* WebView/WebView.mm:
(aeDescFromJSValue): Updated for JSC changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix FrameView::scrollElementToRect to take already scrolled amount into consideration.
commit-queue@webkit.org [Wed, 5 Oct 2011 01:32:19 +0000 (01:32 +0000)]
Fix FrameView::scrollElementToRect to take already scrolled amount into consideration.
https://bugs.webkit.org/show_bug.cgi?id=69220

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-10-04
Reviewed by Simon Fraser.

Source/WebCore:

* page/FrameView.cpp:
(WebCore::FrameView::scrollElementToRect):

LayoutTests:

* fast/dom/scroll-element-to-rect.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIgnore the warning about using 'override'.
andersca@apple.com [Wed, 5 Oct 2011 01:14:40 +0000 (01:14 +0000)]
Ignore the warning about using 'override'.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStub out WorkerScriptController::disableEval for v8 to fix the build.
weinig@apple.com [Wed, 5 Oct 2011 01:12:34 +0000 (01:12 +0000)]
Stub out WorkerScriptController::disableEval for v8 to fix the build.

* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::disableEval):
* bindings/v8/WorkerScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOVERRIDE seems to not be working for Windows. Remove it for now.
weinig@apple.com [Wed, 5 Oct 2011 01:10:28 +0000 (01:10 +0000)]
OVERRIDE seems to not be working for Windows. Remove it for now.

* dom/Document.h:
* workers/WorkerContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWean ContentSecurityPolicy from the Document
weinig@apple.com [Wed, 5 Oct 2011 00:52:50 +0000 (00:52 +0000)]
Wean ContentSecurityPolicy from the Document
https://bugs.webkit.org/show_bug.cgi?id=69387

Reviewed by Adam Barth.

* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::disableEval):
* bindings/js/WorkerScriptController.h:
* dom/Document.cpp:
(WebCore::Document::disableEval):
* dom/Document.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::disableEval):
* workers/WorkerContext.h:
* dom/ScriptExecutionContext.h:
Add pure virtual disableEval to ScriptExecutionContext, so that ContentSecurityPolicy
can call it for both Documents and WorkerContexts.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
Call the new ScriptExecutionContext::disableEval() function.

(WebCore::ContentSecurityPolicy::reportViolation):
Use ScriptExecutionContext::addMessage() instead of going directly to the DOMWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic doesn't launch it's UI on Lion
abarth@webkit.org [Wed, 5 Oct 2011 00:52:18 +0000 (00:52 +0000)]
garden-o-matic doesn't launch it's UI on Lion
https://bugs.webkit.org/show_bug.cgi?id=69349

Reviewed by Darin Adler.

It turns out that Lion is a bit more picky about file URLs.  This patch
switches us from using a path to using an actual file URL, silencing
the warning and making the tool actually launch on Lion.

* Scripts/webkitpy/tool/servers/gardeningserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test expectations after http://trac.webkit.org/changeset/96449
commit-queue@webkit.org [Wed, 5 Oct 2011 00:12:46 +0000 (00:12 +0000)]
Update test expectations after trac.webkit.org/changeset/96449
https://bugs.webkit.org/show_bug.cgi?id=69316

Patch by David Barr <davidbarr@chromium.org> on 2011-10-04
Reviewed by Ojan Vafai.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Perl undefined variable warning when using run-safari after
dbates@webkit.org [Tue, 4 Oct 2011 23:53:27 +0000 (23:53 +0000)]
Fix Perl undefined variable warning when using run-safari after
<http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)

Rubber-stamped by Alexey Proskuryakov.

* Scripts/webkitdirs.pm:
(runMacWebKitApp): Check that the optional function argument $useOpenCommand
is defined before using it in a comparison operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove code into ScrollElasticityController::beginScrollGesture()
andersca@apple.com [Tue, 4 Oct 2011 23:48:39 +0000 (23:48 +0000)]
Move code into ScrollElasticityController::beginScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=69383

Reviewed by John Sullivan.

* platform/mac/ScrollAnimatorMac.h:
Add new ScrollElasticityControllerClient member functions.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMinimumPosition):
(WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMaximumPosition):
(WebCore::ScrollAnimatorMac::stretchAmount):
(WebCore::ScrollAnimatorMac::startSnapRubberbandTimer):
(WebCore::ScrollAnimatorMac::stopSnapRubberbandTimer):
Implement the new ScrollElasticityControllerClient member functions.

(WebCore::ScrollAnimatorMac::beginScrollGesture):
Move code into ScrollElasticityController::beginScrollGesture and call it directly.

* platform/mac/ScrollElasticityController.h:
Add new ScrollElasticityControllerClient member functions.

* platform/mac/ScrollElasticityController.mm:
(WebCore::reboundDeltaForElasticDelta):
(WebCore::ScrollElasticityController::beginScrollGesture):
Set up the scroll gesture state.

(WebCore::ScrollElasticityController::stopSnapRubberbandTimer):
New helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd GAMEPAD feature flag
commit-queue@webkit.org [Tue, 4 Oct 2011 23:34:56 +0000 (23:34 +0000)]
Add GAMEPAD feature flag
https://bugs.webkit.org/show_bug.cgi?id=66859

Patch by Scott Graham <scottmg@chromium.org> on 2011-10-04
Reviewed by Darin Fisher.

.:

* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, as no new functionality yet.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* features.pri:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJITCodeGenerator should no longer have code that tries too hard
fpizlo@apple.com [Tue, 4 Oct 2011 23:02:25 +0000 (23:02 +0000)]
JITCodeGenerator should no longer have code that tries too hard
to be both speculative and non-speculative
https://bugs.webkit.org/show_bug.cgi?id=69321

Reviewed by Gavin Barraclough.

Removed m_isSpeculative and speculationCheck() from JITCodeGenerator.
This required moving emitBranch() to SpeculativeJIT, since it was
the main user of that field and method. Other than trvial clean-ups
in emitBranch(), the code is unchanged (and still has some disparity
between 64 and 32_64, and still lacks some obvious optimizations).

* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Moved files towards GTK removal
tony@chromium.org [Tue, 4 Oct 2011 23:01:00 +0000 (23:01 +0000)]
[Chromium] Moved files towards GTK removal
https://bugs.webkit.org/show_bug.cgi?id=69229

Patch by Fady Samuel <fsamuel@chromium.org> on 2011-10-04
Reviewed by Tony Chang.

Source/WebCore:

* WebCore.gypi:
* platform/chromium/PlatformThemeChromiumLinux.cpp: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.cpp.
(WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
(WebCore::clamp):
(WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
(WebCore::PlatformThemeChromiumLinux::outlineColor):
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):
* platform/chromium/PlatformThemeChromiumLinux.h: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.h.
(WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
(WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
(WebCore::PlatformThemeChromiumLinux::trackColor):
(WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):

Source/WebKit/chromium:

* WebKit.gyp:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setScrollbarColors):
* src/linux/WebFontInfo.cpp: Renamed from Source/WebKit/chromium/src/gtk/WebFontInfo.cpp.
(WebKit::WebFontInfo::familyForChars):
(WebKit::WebFontInfo::renderStyleForStrike):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline for bug 65583 (path based border radius drawing on skia) part 7
commit-queue@webkit.org [Tue, 4 Oct 2011 22:57:08 +0000 (22:57 +0000)]
Rebaseline for bug 65583 (path based border radius drawing on skia) part 7
https://bugs.webkit.org/show_bug.cgi?id=69135

Patch by Ben Wells <benwells@chromium.org> on 2011-10-04
Reviewed by James Robinson.

* platform/chromium-linux/fast/: 26 changes.
* platform/chromium-linux/svg/custom/no-inherited-dashed-stroke-expected.png:
* platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
* platform/chromium-win/fast/: 27 changes.
* platform/chromium-win/svg/custom/no-inherited-dashed-stroke-expected.png:
* platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate html5-full-render.html to load the HTML5 spec incrementally, closer to how...
eric@webkit.org [Tue, 4 Oct 2011 22:56:41 +0000 (22:56 +0000)]
Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
https://bugs.webkit.org/show_bug.cgi?id=69374

Unreviewed.

Per https://bugs.webkit.org/show_bug.cgi?id=69374#c7
updating the chunksize to be a bit smaller now that the total
size of the html5 spec is smaller than when I wrote the test.

This should increase the prevalence of style resolution in the
sample time, which more closely matches instrument samples
taken when loading the full page in Safari.

* Parser/html5-full-render.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix position check for double tap gesture detection. A double tap
commit-queue@webkit.org [Tue, 4 Oct 2011 22:48:18 +0000 (22:48 +0000)]
Fix position check for double tap gesture detection. A double tap
should not be detected if the two taps are far from each other.
https://bugs.webkit.org/show_bug.cgi?id=69270

Patch by Varun Jain <varunjain@chromium.org> on 2011-10-04
Reviewed by Darin Fisher.

Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp

* platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::GestureRecognizerChromium::isSecondClickInsideManhattanSquare):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::click):
* platform/chromium/GestureRecognizerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotoURLRef() in WKSharedAPICast.h should return null for a null string
adachan@apple.com [Tue, 4 Oct 2011 22:45:29 +0000 (22:45 +0000)]
toURLRef() in WKSharedAPICast.h should return null for a null string
https://bugs.webkit.org/show_bug.cgi?id=69380

Reviewed by Jon Honeycutt.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toURLRef): Add the missing "return" for the null string case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Extract scheduling logic from CCThreadProxy to its own class
commit-queue@webkit.org [Tue, 4 Oct 2011 22:38:27 +0000 (22:38 +0000)]
[chromium] Extract scheduling logic from CCThreadProxy to its own class
https://bugs.webkit.org/show_bug.cgi?id=69049

Patch by James Robinson <jamesr@chromium.org> on 2011-10-04
Reviewed by Kenneth Russell.

Source/WebCore:

This partially extracts the commit/draw scheduling from CCThreadProxy to a separate isolated class. This makes
the commit/draw logic easier to test, understand and extend.

There is one subtle behavior change here to the way that the function formerly known as
CCLayerTreeHost::setNeedsCommitAndRedraw works. Previously, this would trigger a begin frame message, if one
wasn't pending, and then trigger a redraw if one wasn't pending. This was subtly wrong - the intent of that call
is that a redraw should happen after the commit. It isn't useful to draw before the commit occurs. This patch
changes the name of the function to setNeedsCommitThenRedraw and only requests a redraw after a commit occurs.

Covered by new CCSchedulerTest unit tests, CCLayerTreeHostTest unit tests, and compositing/ layout tests.

* WebCore.gypi:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCScheduler.cpp: Added.
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::requestCommit):
(WebCore::CCScheduler::requestCommitThenRedraw):
(WebCore::CCScheduler::requestRedraw):
(WebCore::CCScheduler::didCommit):
(WebCore::CCScheduler::didDraw):
* platform/graphics/chromium/cc/CCScheduler.h: Added.
(WebCore::CCSchedulerClient::~CCSchedulerClient):
(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):
(WebCore::CCScheduler::redrawAfterCommit):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxySchedulerClient::create):
(WebCore::CCThreadProxySchedulerClient::~CCThreadProxySchedulerClient):
(WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
(WebCore::CCThreadProxySchedulerClient::scheduleDrawAndPresent):
(WebCore::CCThreadProxySchedulerClient::CCThreadProxySchedulerClient):
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCThreadProxy::setNeedsCommitThenRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::initializeImplOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Adds some unit tests for the new CCScheduler class. Since the class is very simple today, the tests are
similarly quite simple.

* WebKit.gypi:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::postSetNeedsCommitThenRedrawToMainThread):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommitThenRedraw):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
* tests/CCSchedulerTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agooccasional crash in Chromium in dispatching keyEvent
commit-queue@webkit.org [Tue, 4 Oct 2011 22:30:49 +0000 (22:30 +0000)]
occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941

Patch by Scott Graham <scottmg@chromium.org> on 2011-10-04
Reviewed by Tony Chang.

Source/WebKit/chromium:

Guard Frame while handling keyEvent, as it can lose last reference due
to actions of handler.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::keyEvent):

LayoutTests:

* fast/events/keyevent-iframe-removed-crash-expected.txt: Added.
* fast/events/keyevent-iframe-removed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago https://bugs.webkit.org/show_bug.cgi?id=67774
ap@apple.com [Tue, 4 Oct 2011 22:28:54 +0000 (22:28 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=67774
        PDF in a frameset is not displayed, always downloads

        Reviewed by Darin Adler.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Plugins/PDF: Added.
        Added BuiltInPDFView class. It implements ScrollableArea and Plugin, working with iframes,
        objects and embeds. The implementation targets Mac port only, fixing a WebKit2 regression.

        * UIProcess/WebContext.cpp: (WebKit::WebContext::getPlugins): Tell WebCore that there is a
        plug-in for PDF, so that it instantiates it in a regular fashion.

        * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::canShowMIMEType): We can now show
        PDF not only in main frame.

        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Added. This is largely an implementation of
        ScrollableArea now, which can render the first page of a PDF. Further improvements to come.

        * WebProcess/Plugins/PDF/BuiltInPDFView.h: Added.

        * WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::updateControlTints): Give Plugin a chance
        to invalidate its tintable controls - it's necessary for PDF because scrollbars are tintable.

        * WebProcess/Plugins/Plugin.h: (WebKit::Plugin::controller): Added a const version, since
        some ScrollableArea methods are const.

        * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Call updateControlTints
        at updatingControlTints phase.

        * WebProcess/Plugins/PluginView.h: PDF plug-in needs to tinker with embedding FrameView to
        use Scrollbar class, so it needs to cast its PluginController up to PluginView. It's unfortunate
        that PluginView has so much NPAPI specific code, but that's how it is now.

        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): If there is no real plug-in
        installed for PDF, instantiate built-in one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoScrollElasticityController should keep track of the rubberband timer state
andersca@apple.com [Tue, 4 Oct 2011 22:14:49 +0000 (22:14 +0000)]
ScrollElasticityController should keep track of the rubberband timer state
https://bugs.webkit.org/show_bug.cgi?id=69381

Reviewed by Sam Weinig.

Add a m_snapRubberbandTimerIsActive member variable to ScrollElasticityController
and use it instead of checking whether the m_snapRubberbandTimer is active.

Eventually, ScrollElasticityControllerClient will have two member functions for starting
and stopping the timer, and the ScrollElasticityController will call them at the appropriate times.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
It's OK to stop the timer unconditionally.

(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::ScrollElasticityController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove all rubber-banding related member variables to ScrollElasticityController
andersca@apple.com [Tue, 4 Oct 2011 21:58:18 +0000 (21:58 +0000)]
Move all rubber-banding related member variables to ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=69379

Reviewed by Dan Bernstein.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::ScrollElasticityController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate XP results for the font shaping patch.
abarth@webkit.org [Tue, 4 Oct 2011 21:50:04 +0000 (21:50 +0000)]
Update XP results for the font shaping patch.

* platform/chromium-win-xp/fast/text/international/bidi-neutral-run-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate baselines after http://trac.webkit.org/changeset/96620. These
abarth@webkit.org [Tue, 4 Oct 2011 21:37:49 +0000 (21:37 +0000)]
Update baselines after trac.webkit.org/changeset/96620.  These
changes match the changes Dave made to other platforms.

* platform/chromium-cg-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-cg-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Leopard build bustage.
hyatt@apple.com [Tue, 4 Oct 2011 21:34:45 +0000 (21:34 +0000)]
Fix Leopard build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate html5-full-render.html to load the HTML5 spec incrementally, closer to how...
eric@webkit.org [Tue, 4 Oct 2011 21:27:03 +0000 (21:27 +0000)]
Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would
https://bugs.webkit.org/show_bug.cgi?id=69374

Reviewed by James Robinson.

This should finally be able to provide us with a repeatable metric
for how fast we're currently able to load the HTML5 spec.
There are a variety of interesting functions which show up in this
sample, including of course style resolution.

* Parser/html5-full-render.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fixes for everyone.
andersca@apple.com [Tue, 4 Oct 2011 21:25:27 +0000 (21:25 +0000)]
Build fixes for everyone.

* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
Fix Chromium build.

* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Fix GTK+ build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from...
jonlee@apple.com [Tue, 4 Oct 2011 21:23:29 +0000 (21:23 +0000)]
REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
https://bugs.webkit.org/show_bug.cgi?id=68412
<rdar://problem/9988252>

Reviewed by Darin Adler.

Source/WebKit2:

In WK1 setInitialFocus() is called on FocusController with the key event that
caused the web view to become first responder. In WK2 no event is sent. So if
the key stroke that caused the change in first responder status contains the
option modifier key, FocusController did not know that it had to switch behavior.

Because there are multiple ways that the WKView can becomeFirstResponder, I changed
the signature to setInitialFocus to express whether the key event parameter is an
actual key event.

* UIProcess/API/C/win/WKView.cpp:
(WKViewSetInitialFocus):
* UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]): Take the NSApp currentEvent and pass it along if
the event is a keyboard event, otherwise pass an empty event.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setInitialFocus): Change in function signature to confirm that
the event that caused the initial focus was a keyboard event, and provide the keyboard
event itself.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setInitialFocus):
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setInitialFocus): If we know that the cause of this was a keyboard
event, we pass that event to the FocusController. Otherwise we fall back to the original
behavior, which is to pass no event at all.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

In order to create a test for the bug, I had to update DRT and WKTR to create some
widget that allows first responder status to move away from the main web view.

Three methods were added to layoutTestController: addChromeInputField,
removeChromeInputField, and focusWebView. addChromeInputField adds a text field
that is a sibling to the web view, and sets up the key event loop between the two.
removeChromeInputField removes that field. focusWebView moves first responder
status to the web view.

The test makes the call via layoutTestController and passes a callback that it
assumes will be executed once the task is completed. In DRT the callback is called
synchronously. In WKTR this is handled with message passing between the two
processes.

* DumpRenderTree/LayoutTestController.cpp:
(addChromeInputFieldCallback):
(removeChromeInputFieldCallback):
(focusWebViewCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
make sure to remove the chrome input field.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::addChromeInputField):
(LayoutTestController::removeChromeInputField):
(LayoutTestController::focusWebView):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postAddChromeInputField):
(WTR::InjectedBundle::postRemoveChromeInputField):
(WTR::InjectedBundle::postFocusWebView):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
through JS.
(WTR::cacheLayoutTestControllerCallback):
(WTR::callLayoutTestControllerCallback):
(WTR::LayoutTestController::addChromeInputField):
(WTR::LayoutTestController::removeChromeInputField):
(WTR::LayoutTestController::focusWebView):
(WTR::LayoutTestController::callAddChromeInputFieldCallback):
(WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
(WTR::LayoutTestController::callFocusWebViewCallback):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):

* DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
with the patch-- just cleaning up style.
(LayoutTestController::addDisallowedURL):
(originsArrayToJS):
(LayoutTestController::queueLoad):
(LayoutTestController::setMockDeviceOrientation):
(LayoutTestController::setIconDatabaseEnabled):
(LayoutTestController::setEditingBehavior):

LayoutTests:

The option-key navigation is only relevant to the Mac platform.

* platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
* platform/mac/fast/forms/focus-option-control-on-page.html: Added.
* platform/mac/fast/forms/script-tests/focus-option-control-on-page.js: Added.
(startTest):
(runKeyPresses):
(notifyDone):
(log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a ScrollElasticityController class and move some members over from ScrollAnimatorMac
andersca@apple.com [Tue, 4 Oct 2011 21:18:53 +0000 (21:18 +0000)]
Add a ScrollElasticityController class and move some members over from ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=69373

Reviewed by David Hyatt.

ScrollElasticityController is a new class that will handle the rubber-banding when handling scroll events.

* WebCore.xcodeproj/project.pbxproj:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h: Added.
(WebCore::ScrollElasticityControllerClient::~ScrollElasticityControllerClient):
* platform/mac/ScrollElasticityController.mm: Added.
(WebCore::ScrollElasticityController::ScrollElasticityController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=69372
hyatt@apple.com [Tue, 4 Oct 2011 21:16:56 +0000 (21:16 +0000)]
Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=69372

[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.

Add support for reverse iteration to ListHashSet to support being able to walk them
backwards easily.

Reviewed by Anders Carlsson.

* wtf/ListHashSet.h:
(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTF::::rbegin):
(WTF::::rend):
(WTF::::makeReverseIterator):
(WTF::::makeConstReverseIterator):
(WTF::::makeConstIterator):

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69372

[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.

Reviewed by Anders Carlsson.

No new tests, since plenty of results changed.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):
(WebCore::RenderRegion::isFirstRegion):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::layout):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setRegionRect):
(WebCore::RenderRegion::regionRect):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=69372

[CSS3 Regions] Make sure overflow:visible lets content spill out of regions.

Reviewed by Anders Carlsson.

* platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png:
* platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png:
* platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.png:
* platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
* platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid unnecessary ASSERT in AudioDSPKernelProcessor::setNumberOfChannels()
crogers@google.com [Tue, 4 Oct 2011 21:10:48 +0000 (21:10 +0000)]
Avoid unnecessary ASSERT in AudioDSPKernelProcessor::setNumberOfChannels()
https://bugs.webkit.org/show_bug.cgi?id=69361

Reviewed by James Robinson.

No new tests.  This changes no JavaScript API.

* platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::setNumberOfChannels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofix gtk breakage caused by changeset 96595
gavinp@chromium.org [Tue, 4 Oct 2011 20:56:39 +0000 (20:56 +0000)]
fix gtk breakage caused by changeset 96595
https://bugs.webkit.org/show_bug.cgi?id=69371

ews did not catch build breakage in the gtk WebKitPluginProcess target; this patch removes
the pretty printer on gtk, which should fix the build on that platform.

Reviewed by NOBODY, this is a build fix.

* wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate our copy of the HTML5 spec used for performance testing to match the latest...
eric@webkit.org [Tue, 4 Oct 2011 20:53:09 +0000 (20:53 +0000)]
Update our copy of the HTML5 spec used for performance testing to match the latest version
https://bugs.webkit.org/show_bug.cgi?id=69364

Unreviewed.  The patch is too large to post, so landing this unreviewed. :(

The copy of the html5 spec we were using for testing was over a year old
and didn't have any of the subresources with it (we were only using it
as an HTML parsing benchmark).  I'm about to use it for testing
the full load/render time of the benchmark, so I've updated to the latest
version of the spec (now 8mb instead of 5mb) and inlined two of the
CSS files.  (Inlining the CSS was necessary to make my testing consistent
as there seems to be a race with some timer fired after CSS load.)

Increasing from 5mb to 8mb showed a similar 30% slowdown in our parser
benchmarks as expected.

* Parser/resources/html5.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse const PlatformWheelEvent references where possible
andersca@apple.com [Tue, 4 Oct 2011 20:44:05 +0000 (20:44 +0000)]
Use const PlatformWheelEvent references where possible
https://bugs.webkit.org/show_bug.cgi?id=69367

Reviewed by Sam Weinig.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/ScrollAnimator.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
* platform/ScrollableArea.h:
* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::isScrollingLeftAndShouldNotRubberBand):
(WebCore::isScrollingRightAndShouldNotRubberBand):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink HTMLTableCellElement.
commit-queue@webkit.org [Tue, 4 Oct 2011 20:39:45 +0000 (20:39 +0000)]
Shrink HTMLTableCellElement.
https://bugs.webkit.org/show_bug.cgi?id=69347

Patch by Andreas Kling <kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.

Don't cache the rowspan and colspan attributes on the element.
This shrinks HTMLTableCellElement by one CPU word, reducing memory
consumption by 80 kB (on 64-bit) when loading the full HTML5 spec.

* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement):
(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):
(WebCore::HTMLTableCellElement::parseMappedAttribute):
* html/HTMLTableCellElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r96630.
commit-queue@webkit.org [Tue, 4 Oct 2011 20:37:58 +0000 (20:37 +0000)]
Unreviewed, rolling out r96630.
http://trac.webkit.org/changeset/96630
https://bugs.webkit.org/show_bug.cgi?id=69368

Caused assertion failures in validateCell (Requested by
mhahnenberg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-04

Source/JavaScriptCore:

* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:

Source/WebCore:

* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update Qt specific expected results.
ossy@webkit.org [Tue, 4 Oct 2011 20:24:35 +0000 (20:24 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected results.

* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable sub pixel text (Skia on Mac)
caryclark@google.com [Tue, 4 Oct 2011 20:20:13 +0000 (20:20 +0000)]
Enable sub pixel text (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69354
http://code.google.com/p/chromium/issues/detail?id=98165

Reviewed by Eric Seidel.

No new tests. Layout test pixel results have been
disabled and will be rebaselined once all Skia on Mac
changes are in.

* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
Enable sub pixel text. This is set by default to enabled
by CoreGraphics, but by default disabled on Skia.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd loopsPerRun option to Parser performance test runner
eric@webkit.org [Tue, 4 Oct 2011 20:16:51 +0000 (20:16 +0000)]
Add loopsPerRun option to Parser performance test runner
https://bugs.webkit.org/show_bug.cgi?id=69363

Reviewed by Antti Koivisto.

Add loopsPerRun option and abstract out runLoop function (to make the UI more responsive).
No change in behavior in any of the tests.

* Parser/resources/runner.js:
(runLoop):
(run):
(start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove PlatformWheelEvent::m_isAccepted
andersca@apple.com [Tue, 4 Oct 2011 20:11:04 +0000 (20:11 +0000)]
Remove PlatformWheelEvent::m_isAccepted
https://bugs.webkit.org/show_bug.cgi?id=69357

Reviewed by Darin Adler.

../WebCore:

Remove PlatformWheelEvent::m_isAccepted and all the getters/setters.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
* platform/efl/PlatformWheelEventEfl.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

../WebKit/chromium:

* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
m_isAccepted has been removed.

* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::onMouseWheel):
Just return the value of handleWheelEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.
cdn@chromium.org [Tue, 4 Oct 2011 19:47:32 +0000 (19:47 +0000)]
Source/WebCore: Hold refptr to identified previous sibling within findPlaceForCounter.
https://bugs.webkit.org/show_bug.cgi?id=68563

Reviewed by Adam Barth.

Test: fast/css/counters/counter-after-style-crash.html

* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):

LayoutTests: Add test for crash when performing rich text mutations with counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=68563

Reviewed by Adam Barth.

* fast/css/counters/counter-after-style-crash-expected.txt: Added.
* fast/css/counters/counter-after-style-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB add() should fail if key is NaN
commit-queue@webkit.org [Tue, 4 Oct 2011 19:35:23 +0000 (19:35 +0000)]
IndexedDB add() should fail if key is NaN
https://bugs.webkit.org/show_bug.cgi?id=62286

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-04
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/invalid-keys.html

Implement special case - numbers are valid keys, except for NaN.

* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):

LayoutTests:

Tests for NaN and other invalid IndexedDB keys.

* storage/indexeddb/invalid-keys-expected.txt: Added.
* storage/indexeddb/invalid-keys.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd static ClassInfo structs to classes that override JSCell::getCallData
mhahnenberg@apple.com [Tue, 4 Oct 2011 19:22:00 +0000 (19:22 +0000)]
Add static ClassInfo structs to classes that override JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=69311

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct.  This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing).  These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.

* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:

getCallData was not marked as static is StrictModeTypeErrorFunction.
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:

Source/WebCore:

No new tests.

Added ClassInfo structs to each class that defined its own getCallData
function but did not already have its own ClassInfo struct.  This is a
necessary addition for when we switch over to looking up getCallData from
the MethodTable in ClassInfo rather than doing the virtual call (which we
are removing).  These new ClassInfo structs are public because we often
use these structs in other areas of the code to uniquely identify JSC classes and
to enforce runtime invariants based on those class identities using ASSERTs.

* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLeopard build fix after r96613.
rniwa@webkit.org [Tue, 4 Oct 2011 19:17:25 +0000 (19:17 +0000)]
Leopard build fix after r96613.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r94274): setting input.value erroneously triggers focus event
rniwa@webkit.org [Tue, 4 Oct 2011 19:02:44 +0000 (19:02 +0000)]
REGRESSION(r94274): setting input.value erroneously triggers focus event
https://bugs.webkit.org/show_bug.cgi?id=69315

Reviewed by Kent Tamura.

Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
when called by nodeWillBeRemoved and textWillBeReplaced.

Added a manual test. Unfortunately, the test always passes in DRT.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/FrameSelection.h:
* manual-tests/mutate-unfocused-text-with-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplicitly add toString and valueOf to prototype when convertToType callback is provided
mhahnenberg@apple.com [Tue, 4 Oct 2011 19:02:03 +0000 (19:02 +0000)]
Implicitly add toString and valueOf to prototype when convertToType callback is provided
https://bugs.webkit.org/show_bug.cgi?id=69156

Reviewed by Geoffrey Garen.

Added callbacks for toString and valueOf which are implicitly added to a client object's
prototype if they provide a convertToType callback when declaring their class through
the JSC API.

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
* API/JSCallbackFunction.h:
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/tests/testapi.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTML canvas strokes with dash and dashOffset
commit-queue@webkit.org [Tue, 4 Oct 2011 18:58:47 +0000 (18:58 +0000)]
HTML canvas strokes with dash and dashOffset
https://bugs.webkit.org/show_bug.cgi?id=63933

Patch by Young Han Lee <joybro201@gmail.com> on 2011-10-04
Reviewed by Simon Fraser.

Add webkitLineDash and webkitLineDashOffset attributes to CanvasRenderingContext2D for JSC.
These attributes can be used to determine the dash-style of stroke in HTML Canvas.

As this kind of attributes are not specified in the HTML Canvas specification yet,
the 'webkit' prefix is added to its names.

Mozilla already implemented these attributes, mozDash and mozDashOffset [1], and this patch
is created by referring to the implementation. This patch is basically using the specified
behavior of stroke-dasharray and stroke-dashoffset in the SVG specification [2], except
that doesn't support units or percentages, just floating point numbers.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=662038
[2] http://www.w3.org/TR/SVG/painting.html#StrokeProperties

Source/WebCore:

Tests: fast/canvas/canvas-webkitLineDash-invalid.html
       fast/canvas/canvas-webkitLineDash.html

* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::webkitLineDash):
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::webkitLineDash):
(WebCore::CanvasRenderingContext2D::setWebkitLineDash):
(WebCore::CanvasRenderingContext2D::webkitLineDashOffset):
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

* fast/canvas/canvas-webkitLineDash-expected.txt: Added.
* fast/canvas/canvas-webkitLineDash-invalid-expected.txt: Added.
* fast/canvas/canvas-webkitLineDash-invalid.html: Added.
* fast/canvas/canvas-webkitLineDash.html: Added.
* fast/canvas/script-tests/canvas-webkitLineDash-invalid.js: Added.
(trySettingLineDash):
(trySettingLineDashOffset):
* fast/canvas/script-tests/canvas-webkitLineDash.js: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdditional unreviewed Lion SVG pixel test rebaselining.
timothy_horton@apple.com [Tue, 4 Oct 2011 18:56:26 +0000 (18:56 +0000)]
Additional unreviewed Lion SVG pixel test rebaselining.

* platform/mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
* platform/mac-snowleopard/svg/carto.net: Added.
* platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/mac/svg/carto.net/selectionlist-expected.png:
* platform/mac/svg/custom/external-paintserver-reference-expected.png: Added.
* platform/mac/svg/custom/linking-base-external-reference-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow canvas backing store to be lazily allocated
mdelaney@apple.com [Tue, 4 Oct 2011 18:41:41 +0000 (18:41 +0000)]
Allow canvas backing store to be lazily allocated
https://bugs.webkit.org/show_bug.cgi?id=67054

Reviewed by Darin Adler.

No new tests; doesn't affect behavior.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer): Removed the setting of lineWidth
that caused the eager creation of ImageBuffer to use its GraphicsContext.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Added in default
line width setting along with other default context settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove font-fixup code in WebKitTestRunner to a better place
simon.fraser@apple.com [Tue, 4 Oct 2011 18:39:33 +0000 (18:39 +0000)]
Move font-fixup code in WebKitTestRunner to a better place
https://bugs.webkit.org/show_bug.cgi?id=69356

Reviewed by Sam Weinig.

Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
already contains font-related code.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
(WTR::drt_NSFontManager_availableFontFamilies):
(WTR::drt_NSFontManager_availableFonts):
(WTR::swizzleNSFontManagerMethods):
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPartial unreviewed rebaselines for Lion SVG pixel tests.
timothy_horton@apple.com [Tue, 4 Oct 2011 18:35:29 +0000 (18:35 +0000)]
Partial unreviewed rebaselines for Lion SVG pixel tests.

* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
* platform/mac-snowleopard/svg/css: Added.
* platform/mac-snowleopard/svg/css/composite-shadow-example-expected.png: Added.
* platform/mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png: Added.
* platform/mac-snowleopard/svg/css/stars-with-shadow-expected.png: Added.
* platform/mac-snowleopard/svg/custom: Added.
* platform/mac-snowleopard/svg/custom/altglyph-expected.png: Added.
* platform/mac-snowleopard/svg/custom/dynamic-svg-document-creation-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
* platform/mac-snowleopard/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
* platform/mac-snowleopard/svg/custom/invisible-text-after-scrolling-expected.png: Added.
* platform/mac-snowleopard/svg/custom/junk-data-expected.png: Added.
* platform/mac-snowleopard/svg/custom/missing-xlink-expected.png: Added.
* platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
* platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
* platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
* platform/mac-snowleopard/svg/dom: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-appendItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-initialize-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-removeItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
* platform/mac-snowleopard/svg/hixie: Added.
* platform/mac-snowleopard/svg/hixie/error: Added.
* platform/mac-snowleopard/svg/hixie/error/012-expected.png: Added.
* platform/mac-snowleopard/svg/in-html: Added.
* platform/mac-snowleopard/svg/in-html/circle-expected.png: Added.
* platform/mac-snowleopard/svg/overflow: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
* platform/mac-snowleopard/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
* platform/mac-snowleopard/svg/text/kerning-expected.png: Added.
* platform/mac-snowleopard/svg/text/multichar-glyph-expected.png: Added.
* platform/mac-snowleopard/svg/wicd: Added.
* platform/mac-snowleopard/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/mac-snowleopard/svg/zoom: Added.
* platform/mac-snowleopard/svg/zoom/page: Added.
* platform/mac-snowleopard/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/text: Added.
* platform/mac-snowleopard/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
* platform/mac/svg/css/composite-shadow-example-expected.png:
* platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
* platform/mac/svg/css/stars-with-shadow-expected.png:
* platform/mac/svg/custom/altglyph-expected.png:
* platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
* platform/mac/svg/custom/junk-data-expected.png:
* platform/mac/svg/custom/missing-xlink-expected.png:
* platform/mac/svg/custom/object-sizing-no-width-height-expected.png:
* platform/mac/svg/custom/path-bad-data-expected.png:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/mac/svg/custom/use-font-face-crash-expected.png:
* platform/mac/svg/dom/SVGLengthList-appendItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-basics-expected.png:
* platform/mac/svg/dom/SVGLengthList-initialize-expected.png:
* platform/mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
* platform/mac/svg/dom/SVGLengthList-removeItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-replaceItem-expected.png:
* platform/mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
* platform/mac/svg/dom/SVGNumberList-basics-expected.png:
* platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png:
* platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
* platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
* platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png:
* platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
* platform/mac/svg/dom/SVGPointList-basics-expected.png:
* platform/mac/svg/dom/SVGStringList-basics-expected.png:
* platform/mac/svg/dom/SVGTransformList-basics-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
* platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
* platform/mac/svg/hixie/error/012-expected.png:
* platform/mac/svg/in-html/circle-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
* platform/mac/svg/text/kerning-expected.png:
* platform/mac/svg/text/multichar-glyph-expected.png:
* platform/mac/svg/wicd/rightsizing-grid-expected.png:
* platform/mac/svg/wicd/test-rightsizing-b-expected.png:
* platform/mac/svg/wicd/test-scalable-background-image1-expected.png:
* platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
* platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for the CSP connect-src directive
weinig@apple.com [Tue, 4 Oct 2011 18:30:32 +0000 (18:30 +0000)]
Add support for the CSP connect-src directive
https://bugs.webkit.org/show_bug.cgi?id=69353

Reviewed by Adam Barth.

Add CSP support for XMLHttpRequest, WebSockets and EventSource.

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html
       http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html
       http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html
       http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html
       http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html
       http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowConnectFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
Add connect-src directive parsing and predicate.

* page/EventSource.cpp:
(WebCore::EventSource::create):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
Test allowConnectFromSource when establishing a connection.

LayoutTests:

* http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=69317
hyatt@apple.com [Tue, 4 Oct 2011 18:17:04 +0000 (18:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69317

[CSS3 Regions] Make overflow:hidden/auto/scroll sections behave properly when split across regions. This
includes sizing and positioning independently in each region, clipping independently in each region, and
shifting to avoid floats in each region.

Reviewed by Anders Carlsson.

Source/WebCore:

Added many new tests in fast/regions.

* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
Patching a call to overflowClipRect, which now includes a region argument so that clipping can be adjusted
per-region.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Don't clear out the cached region information when the width changes. Instead make a new call to
the flow thread to check if widths changed in any region and set relayoutChildren to true if so.

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
This is a new function that has been split out from determineLogicalLeftPositionForChild so that it can
be called by region code to compute offsets independently in each region without altering the overall object's
logical left position.

(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
Patched to call computeStartPositionDeltaForChildAvoidingFloats instead of doing the work of avoiding the floats
itself.

(WebCore::RenderBlock::computeLogicalLocationForFloat):
Fix the left clamping code to clamp to the left border in the correct region rather than always just clamping
to 0.

(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Tweaked to handle the new signature of borderBoxRectInRegion.

(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
Reworked not to return 0 on failure or when done, but to just return the current height. This is a more
fitting answer for the function to return when no more floats remain.

(WebCore::RenderBlock::getClearDelta):
Big changes to this function. It was never patched to support writing modes, so the new code is all
writing-mode-aware now. Also improved the computeLogicalWidth() call to make sure margins didn't get incorrectly changed.
The code computes transient information in each region as the object tries to find a place to fit, so that the
old widths are properly retained when layout of that child later checks to see if it needs to relayout children or not.

(WebCore::RenderBlock::nodeAtPoint):
Patched to call overflowClipRect with the region being hit tested.

(WebCore::inNormalFlow):
Tweaked to not need the initialBlock variable.

(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
Tweaked to use inRenderFlowThread() now that it exists. Also removing the regionsHaveUniformLogicalWidth()
optimization, since you can't rely on that when objects size differently depending on floats. In other words,
the future of pagination is variable width objects even in printing/columns.

(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
Renamed to make it more clear what logicalPageOffset() was. It's your offset from the top of the first page.

(WebCore::RenderBlock::regionAtBlockOffset):
New helper function for accessing the region at a given offset within your block.

(WebCore::RenderBlock::logicalWidthChangedInRegions):
New helper function that computes whether or not your logical width information changed in any regions. If so,
relayoutChildren gets set to true (just as it would have when computeLogicalWidth for the overall block changes
values).

(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginLogicalLeftForChild):
(WebCore::RenderBlock::marginLogicalRightForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
Tweaked because of const to take const arguments.

* rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalLeftForChild):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::startOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Reworking these functions so versions exist that take regions and page offsets to avoid having to recalculate
where you are over and over again as you walk up a containing block chain.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::fitBelowFloats):
Changed to handle the better return value for nextFloatLogicalBottomBelow.

(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
Removing the uniform logical width optimization.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
Changed to take a region and offset from the first page so that it doesn't have to be recomputed as you recur up
the containing block chain.

(WebCore::RenderBox::clearRenderBoxRegionInfo):
Changed to just use inRenderFlowThread().

(WebCore::RenderBox::pushContentsClip):
Changed for the new region-parameterized overflow clip function.

(WebCore::RenderBox::overflowClipRect):
Now takes a region so that a specific clip rect can be returned sized to the appropriate border box in that
region.

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Objects in flow threads no longer shrink to avoid floats when computing their overall widths. The region-specific
check now does the shrinking. It checks at the point where the region slices the object, or the top of the object if
it begins in the middle of the region.

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthInRegion):
Push all the rest of the computeLogicalWidth code into computeLogicalWidthInRegion.

(WebCore::RenderBox::renderBoxRegionInfo):
Changed to take the region and the offset from the top of the first page to avoid recomputation.

* rendering/RenderBox.h:
(WebCore::RenderBox::hasRenderOverflow):
(WebCore::RenderBox::hasVisualOverflow):
New helper used by the RenderLayer code to avoid having to check visual overflow when none exists.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use the new region-specific overflow clip.

* rendering/RenderBoxRegionInfo.h:
(WebCore::RenderBoxRegionInfo::shiftLogicalLeft):
Helper used by the region code to shift a box over when floats cause it to move.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalWidth):
Remove the optimization to avoid creating box info for uniform widths.

(WebCore::RenderFlowThread::paintIntoRegion):
Make the clip rects used when painting the flow thread's layer tree temporary in each region.

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Removing the uniform logical width optimization

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
* rendering/RenderFlowThread.h:
New helper called to see if a block needs to relayout its children because its width changed in some
region.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
(WebCore::RenderLayer::repaintBlockSelectionGaps):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::clippedByAncestor):
Changing all the layer clipping code to pass regions through to all of the helper functions involved. This is
so overflowClipRect can ultimately take a region. Eventually when we get positioned objects moving independently
in each region, we'll patch the "clip" property as well, and it will be much easier because all the plumbing has
been put in place here for overflow.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingRenderFlowThread):
Optimized to not walk up the render tree if we're in layout and a currentRenderFlowThread() exists.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
Removing the optimization for uniform logical width regions. Changed remove to take so that the caller
can examine it before deleting.

(WebCore::RenderRegion::offsetFromLogicalTopOfFirstPage):
* rendering/RenderRegion.h:
Helper function that computes the region's offset from the top of the first page.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTable.h:
* rendering/RenderTableCell.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
Changed to pass the region to overflowClipRect.

* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
Modified because the layer clip functions need regions now.

* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
Changed to use inRenderFlowThread over view()->hasRenderFlowThread.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paint):
Patched to use the new overflowClipRect that is region-specific.

LayoutTests:

* fast/regions/floats-basic-in-variable-width-regions.html: Added.
* fast/regions/overflow-in-uniform-regions-dynamic.html: Added.
* fast/regions/overflow-in-uniform-regions.html: Added.
* fast/regions/overflow-in-variable-width-regions.html:
* fast/regions/overflow-moving-below-floats-in-variable-width-regions.html: Added.
* fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html: Added.
* fast/regions/overflow-rtl-in-variable-width-regions.html:
* fast/regions/overflow-size-change-in-variable-width-regions.html: Added.
* fast/regions/overflow-size-change-with-stacking-context.html: Added.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png:
* platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
* platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
* platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKPreferences should allow control of application chrome mode
jeffm@apple.com [Tue, 4 Oct 2011 18:15:42 +0000 (18:15 +0000)]
WKPreferences should allow control of application chrome mode
https://bugs.webkit.org/show_bug.cgi?id=69344

Reviewed by Dan Bernstein.

* Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetApplicationChromeModeEnabled): Added.
(WKPreferencesGetApplicationChromeModeEnabled): Added.

* UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set application chrome mode setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT: Add DumpRenderTree.cpp
commit-queue@webkit.org [Tue, 4 Oct 2011 18:15:30 +0000 (18:15 +0000)]
[EFL] DRT: Add DumpRenderTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=62034

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-04
Reviewed by Antonio Gomes.

This is the main implementation file for EFL's DumpRenderTree.

* DumpRenderTree/efl/DumpRenderTree.cpp: Added.
(dumpFramesAsText):
(dumpFrameScrollPosition):
(shouldLogFrameLoadDelegates):
(shouldDumpAsText):
(sendPixelResultsEOF):
(invalidateAnyPreviousWaitToDumpWatchdog):
(onEcoreEvasResize):
(onCloseWindow):
(useLongRunningServerMode):
(parseCommandLineOptions):
(getFinalTestURL):
(getExpectedPixelHash):
(createLayoutTestController):
(runTest):
(runTestingServerLoop):
(adjustOutputTypeByMimeType):
(dumpFrameContentsAsText):
(shouldDumpFrameScrollPosition):
(shouldDumpPixelsAndCompareWithExpected):
(shouldDumpBackForwardList):
(initEfl):
(shutdownEfl):
(displayWebView):
(dump):
(initEcoreEvas):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore work towards making PlatformWheelEvent immutable
andersca@apple.com [Tue, 4 Oct 2011 18:15:09 +0000 (18:15 +0000)]
More work towards making PlatformWheelEvent immutable
https://bugs.webkit.org/show_bug.cgi?id=69348

Reviewed by Sam Weinig.

More work on getting rid of m_isAccepted from PlatformWheelEvent. Add more asserts
that the return value of handleWheelEvent is equal to m_isAccepted.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Implement default error pages in WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 4 Oct 2011 18:14:19 +0000 (18:14 +0000)]
[GTK] Implement default error pages in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69255

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitError.cpp:
(webkit_policy_error_quark): Add quark for policy errors.
(webkit_plugin_error_quark): Add quark for plugin errors.
* UIProcess/API/gtk/WebKitError.h: Add policy and plugin errors.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientLoadFailed): Load a custom error page when
load failed and signal has not been handled.
(webkit_web_loader_client_class_init): Add default implementation
for provisional_load_failed and load_failed virtual methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInset focus ring (Skia on Mac)
caryclark@google.com [Tue, 4 Oct 2011 18:12:58 +0000 (18:12 +0000)]
Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166
http://code.google.com/p/chromium/issues/detail?id=97956

This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.

Reviewed by Adam Barth.

No new tests. This platform is not enabled.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add webkit_web_view_load_alternate_html() to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 4 Oct 2011 18:11:55 +0000 (18:11 +0000)]
[GTK] Add webkit_web_view_load_alternate_html() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69254

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_alternate_html):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/testloading.c:
(loadAlternateContentLoadFinished):
(loadAlternateContentLoadFailed):
(testLoadAlternateContent):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExtend DOM WheelEvent to differentiate between physical and logical scroll directions
jonlee@apple.com [Tue, 4 Oct 2011 18:06:44 +0000 (18:06 +0000)]
Extend DOM WheelEvent to differentiate between physical and logical scroll directions
https://bugs.webkit.org/show_bug.cgi?id=68959
<rdar://problem/10036688>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* wtf/Platform.h: Added HAVE_INVERTED_WHEEL_EVENTS for Lion and later.

Source/WebCore:

Test: fast/events/wheelevent-direction-inverted-from-device.html

* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
* dom/WheelEvent.h:
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::webkitDirectionInvertedFromDevice):
* dom/WheelEvent.idl: Added the webkitDirectionInvertedFromDevice idl attribute.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::webkitDirectionInvertedFromDevice):
* platform/efl/PlatformWheelEventEfl.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): if building on Lion or later, use
[NSEvent isDirectionInvertedFromDevice].
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
* platform/wx/MouseWheelEventWx.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.

Source/WebKit2:

* Shared/WebEvent.h:
(WebKit::WebWheelEvent::directionInvertedFromDevice):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent): get the flag from the NSEvent.
* UIProcess/WebPageProxy.cpp:
(WebKit::coalesce):

LayoutTests:

* fast/events/wheelevent-direction-inverted-from-device-expected.txt: Added.
* fast/events/wheelevent-direction-inverted-from-device.html: Added.
* platform/mac-wk2/Skipped: WKTR does not support mouse scroll events yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
commit-queue@webkit.org [Tue, 4 Oct 2011 18:04:21 +0000 (18:04 +0000)]
[EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
https://bugs.webkit.org/show_bug.cgi?id=69338

Unreviewed build fix

Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-04

Source/WebCore:

* CMakeListsEfl.txt:

Source/WebKit/efl:

* CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2][gtk] Generate gtk-doc for WebKit2-GTK.
commit-queue@webkit.org [Tue, 4 Oct 2011 18:02:41 +0000 (18:02 +0000)]
[WebKit2][gtk] Generate gtk-doc for WebKit2-GTK.
https://bugs.webkit.org/show_bug.cgi?id=69325

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-04
Reviewed by Gustavo Noronha Silva.

Documentation generation for WebKit2-GTK+ APIs
using gtk-doc.

.:

* configure.ac:

Source/WebKit2:

* GNUmakefile.am: Added doc generation files to EXTRA_DIST.
* UIProcess/API/gtk/docs/GNUmakefile.am: Makefile for doc generation.
* UIProcess/API/gtk/docs/version.xml.in: Version information.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Document template.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Document sections added.
* UIProcess/API/gtk/docs/webkit2gtk.types: Added GObjects types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResource loader should block HTTP redirects to local resources
commit-queue@webkit.org [Tue, 4 Oct 2011 18:00:32 +0000 (18:00 +0000)]
Resource loader should block HTTP redirects to local resources
https://bugs.webkit.org/show_bug.cgi?id=68706

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-03
Reviewed by Adam Barth.

Source/WebCore:

Modified MainResourceLoader to add an extra security check on
HTTP redirects. Also, moved isFeedWithNestedProtocolInHTTPFamily
to SecurityOrigin.cpp.

* loader/FrameLoader.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::FrameLoader::loadFrameRequest):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
* page/SecurityOrigin.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::SecurityOrigin::canDisplay):

LayoutTests:

Adding a test to attempt an HTTP redirect to a file: URL.

* http/tests/security/redirect-BLOCKED-to-localURL.html: Added.
* http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Added.
* http/tests/security/resources/file-redirect-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApply color profile found to decoded bitmap (Skia on Mac)
caryclark@google.com [Tue, 4 Oct 2011 17:49:46 +0000 (17:49 +0000)]
Apply color profile found to decoded bitmap (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69144
This fixes http://code.google.com/p/chromium/issues/detail?id=97830

Reviewed by Stephen White.

No new tests. This platform is not enabled.

* platform/image-decoders/ImageDecoder.h:
Add color profile slot to Skia variation.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::resolveColorSpace):
Adjust the bitmap in place to use the supplied color space.

(WebCore::createColorSpace):
Create a CGColorSpace from a color profile.

(WebCore::ImageFrame::setColorProfile):
Save the image's color profile until the image is complete.

(WebCore::ImageFrame::setStatus):
Apply the color profile, if any, to the image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRestore Linux baseline for this test. The Linux baseline got clobbered
abarth@webkit.org [Tue, 4 Oct 2011 17:47:29 +0000 (17:47 +0000)]
Restore Linux baseline for this test.  The Linux baseline got clobbered
when I updated the Windows baseline.

* platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.
leandro@webkit.org [Tue, 4 Oct 2011 17:44:49 +0000 (17:44 +0000)]
[CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.

The Perl scripts in the css/ directory expect the definitions passed via
--defines to be a string of space-separated entries, however we were passing a
list of semicolon-separated strings, thus making all feature defines actually
be ignored.

Detected after r96433, which checked for some definitions in
CSSPropertyNames.in.

No new tests, this is a build fix.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.
commit-queue@webkit.org [Tue, 4 Oct 2011 17:39:33 +0000 (17:39 +0000)]
[WebKit2][gtk] Fix warnings while generating documentation using gtk-doc.
https://bugs.webkit.org/show_bug.cgi?id=69329

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-04
Reviewed by Martin Robinson.

Added documentation for WebKitNetworkError enum and corrected few other
minor issues in WebKit2-GTK+ API documentation.

* UIProcess/API/gtk/WebKitError.h: Added documentation for WebKitNetworkError.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkit_web_loader_client_class_init): Corrected parameter name.
* UIProcess/API/gtk/WebKitWebView.cpp: Corrected annotation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 4 Oct 2011 17:22:16 +0000 (17:22 +0000)]
2011-10-04  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed; rebaselines for GTK after r96509.

        * platform/gtk/fast/forms/file-input-disabled-expected.png:
        * platform/gtk/fast/forms/file-input-disabled-expected.txt:
        * platform/gtk/fast/invalid/017-expected.txt:
        * platform/gtk/fast/invalid/018-expected.txt:
        * platform/gtk/fast/invalid/020-expected.txt:
        * platform/gtk/fast/invalid/residual-style-expected.png:
        * platform/gtk/fast/invalid/residual-style-expected.txt:
        * platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
        * platform/gtk/fast/table/inline-form-assert-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug23994-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug56405-expected.png:
        * platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug56563-expected.png:
        * platform/gtk/tables/mozilla/bugs/bug56563-expected.txt:
        * platform/gtk/tables/mozilla/bugs/bug9024-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.png:
        * platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make SourceFrame compile.
pfeldman@chromium.org [Tue, 4 Oct 2011 17:19:04 +0000 (17:19 +0000)]
Web Inspector: make SourceFrame compile.
https://bugs.webkit.org/show_bug.cgi?id=69345

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.inspectElement):
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._inspectElementRequested):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
(WebInspector.SourceFrame.prototype._onShowPopover):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrameDelegate.prototype.requestContent):
(WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.continueToLine):
(WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSource):
(WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegate.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
* inspector/front-end/externs.js:
(WebInspector.log):
* inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):
* inspector/front-end/utilities.js:
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 4 Oct 2011 16:59:53 +0000 (16:59 +0000)]
2011-10-04  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed; new baselines for GTK after r96470

        * platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
        * platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate font shaping result after http://trac.webkit.org/changeset/96582.
abarth@webkit.org [Tue, 4 Oct 2011 16:53:29 +0000 (16:53 +0000)]
Update font shaping result after trac.webkit.org/changeset/96582.
This appears to be a progression, but I'll check with the authors of
that patch to be sure.

* platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate leopard results.
abarth@webkit.org [Tue, 4 Oct 2011 16:48:48 +0000 (16:48 +0000)]
Update leopard results.

* platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug23994-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-object: Removed.
* platform/chromium-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.
* platform/chromium-mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
* platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Removed.
* platform/qt/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 4 Oct 2011 16:32:03 +0000 (16:32 +0000)]
2011-10-04  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed; new baselines for GTK after r96257, r96374 and r96404.

        * platform/gtk/fast/repaint/selection-clear-expected.png: Added.
        * platform/gtk/fast/repaint/selection-clear-expected.txt: Added.
        * platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
        * platform/gtk/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
        * platform/gtk/fast/text/line-initial-and-final-swashes-expected.png: Added.
        * platform/gtk/fast/text/line-initial-and-final-swashes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Factor out object properties popup.
mnaganov@chromium.org [Tue, 4 Oct 2011 16:17:43 +0000 (16:17 +0000)]
Web Inspector: Factor out object properties popup.
https://bugs.webkit.org/show_bug.cgi?id=69234

Also, for HTML elements, show a non-empty id value in the element name.

Reviewed by Pavel Feldman.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMinGW warning fix after r96286.
ossy@webkit.org [Tue, 4 Oct 2011 16:16:16 +0000 (16:16 +0000)]
MinGW warning fix after r96286.

Avoid redefining STDCALL, because STDCALL is also defined in mingw32/include/windef.h:

Reviewed by Tor Arne Vestbø.

* assembler/MacroAssemblerCodeRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: compile text editor.
pfeldman@chromium.org [Tue, 4 Oct 2011 16:11:59 +0000 (16:11 +0000)]
Web Inspector: compile text editor.
https://bugs.webkit.org/show_bug.cgi?id=69339

Drive-by compilation for color, database and dom storage entities.

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/compile-front-end.sh:
* inspector/front-end/Color.js:
(WebInspector.Color.prototype._individualRGBValueToFloatValue):
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.makeKey):
(WebInspector.KeyboardShortcut.makeKeyFromEvent):
(WebInspector.KeyboardShortcut.makeDescriptor):
* inspector/front-end/SourceCSSTokenizer.js:
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/SourceHTMLTokenizer.js:
* inspector/front-end/SourceHTMLTokenizer.re2js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer.prototype._charAt):
(WebInspector.SourceTokenizer.prototype.createInitialCondition):
(WebInspector.SourceTokenizer.prototype.nextToken):
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
* inspector/front-end/TextEditorModel.js:
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewerDelegate.prototype.doubleClick):
(WebInspector.TextViewerDelegate.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegate.prototype.afterTextChanged):
(WebInspector.TextViewerDelegate.prototype.commitEditing):
(WebInspector.TextViewerDelegate.prototype.cancelEditing):
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegate.prototype.suggestedFileName):
(WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
(WebInspector.TextEditorMainPanel.prototype._createLink):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
* inspector/front-end/externs.js:
(WebInspector.completeURL):
(window.getComputedStyle):
(Event.prototype.initWebKitWheelEvent):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Timeline panel shortcut for filtering short records should have shorte...
vsevik@chromium.org [Tue, 4 Oct 2011 15:49:50 +0000 (15:49 +0000)]
Web Inspector: Timeline panel shortcut for filtering short records should have shorter description.
https://bugs.webkit.org/show_bug.cgi?id=69333

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago add more stack dumping methods
gavinp@chromium.org [Tue, 4 Oct 2011 15:39:46 +0000 (15:39 +0000)]
   add more stack dumping methods
       https://bugs.webkit.org/show_bug.cgi?id=69018

       In addition to WTFReportBacktrace, this adds the cross-platform WTFGetBacktrace, which lets
       WebKit programmatically retrieve the current stack.  This is useful if you need to add more
       reporting to field crash report uploads, if you're tracking down an irreproducable bug,
       for instance.

       Reviewed by Darin Adler.

       * wtf/Assertions.cpp:
       * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink StyleRareNonInheritedData.
commit-queue@webkit.org [Tue, 4 Oct 2011 15:13:45 +0000 (15:13 +0000)]
Shrink StyleRareNonInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69331

Patch by Andreas Kling <kling@webkit.org> on 2011-10-04
Reviewed by Antti Koivisto.

Rearrange the members and move all small types into the bitfield.
This shrinks StyleRareNonInheritedData by two CPU words, reducing memory
consumption by 140 kB (on 64-bit) when loading the full HTML5 spec.

* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Remove http/tests/inspector/network/disabled-cache-crash.html.
vsevik@chromium.org [Tue, 4 Oct 2011 15:02:25 +0000 (15:02 +0000)]
Web Inspector: Remove http/tests/inspector/network/disabled-cache-crash.html.
https://bugs.webkit.org/show_bug.cgi?id=69332

Reviewed by Pavel Feldman.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* WebCore.exp.in:
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* http/tests/inspector/network/disabled-cache-crash-expected.txt: Removed.
* http/tests/inspector/network/disabled-cache-crash.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoallow failure of most Chromium-Mac-Skia tests while we clean up that port
commit-queue@webkit.org [Tue, 4 Oct 2011 14:45:39 +0000 (14:45 +0000)]
allow failure of most Chromium-Mac-Skia tests while we clean up that port
https://bugs.webkit.org/show_bug.cgi?id=69279

Patch by Elliot Poger <epoger@google.com> on 2011-10-04
Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make DataGrid compile
pfeldman@chromium.org [Tue, 4 Oct 2011 14:23:24 +0000 (14:23 +0000)]
Web Inspector: make DataGrid compile
https://bugs.webkit.org/show_bug.cgi?id=69334

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-04
Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype._startEditingConfig):
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeChildrenRecursive):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):
(WebInspector.DataGridNode.prototype._attach):
* inspector/front-end/UIUtils.js:
(WebInspector.isBeingEdited):
(WebInspector.markBeingEdited):
(WebInspector.isEditingAnyField):
(WebInspector.EditingConfig):
(WebInspector.startEditing.blurEventListener):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing):
(WebInspector.startEditing.pasteEventListener):
(WebInspector.startEditing.keyDownEventListener):
* inspector/front-end/externs.js:
(Array.prototype.remove):
(window.getComputedStyle):
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Web Inspector: save inspector state into single string instead of string map
yurys@chromium.org [Tue, 4 Oct 2011 14:12:19 +0000 (14:12 +0000)]
[Chromium] Web Inspector: save inspector state into single string instead of string map
https://bugs.webkit.org/show_bug.cgi?id=69335

Added explicit methods for saving and restoring agent runtime state.

Reviewed by Pavel Feldman.

* public/WebDevToolsAgent.h:
* public/WebDevToolsAgentClient.h:
(WebKit::WebDevToolsAgentClient::saveAgentRuntimeState):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::reattach):
(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
* src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 4 Oct 2011 14:09:06 +0000 (14:09 +0000)]
2011-10-04  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Extensions API] extension panel's toolbar icon is incorrect when inspector window is docked
        https://bugs.webkit.org/show_bug.cgi?id=69336

        Reviewed by Pavel Feldman.

        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96589 268f45cc-cd09-0410-ab3c-d52691b4dbfc