WebKit-https.git
11 years ago2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 12 Jun 2008 00:33:48 +0000 (00:33 +0000)]
2008-06-11  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 19498: REGRESSION (r34497): crash while loading GMail
        <https://bugs.webkit.org/show_bug.cgi?id=19498>

        JavaScriptCore:

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJumpIfTrueOptimized):
        (KJS::CodeGenerator::emitJumpIfTrue):
        * VM/CodeGenerator.h:
        * kjs/nodes.cpp:
        (KJS::DoWhileNode::emitCode):
        (KJS::WhileNode::emitCode):
        (KJS::ForNode::emitCode):
        (KJS::CaseBlockNode::emitCodeForBlock):

        LayoutTests:

        * fast/js/logical-or-jless-expected.txt: Added.
        * fast/js/logical-or-jless.html: Added.
        * fast/js/resources/logical-or-jless.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-11 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 11 Jun 2008 22:01:40 +0000 (22:01 +0000)]
2008-06-11  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - a little bit of cleanup and prep for some upcoming optimizations

        * JavaScriptCore.exp: Re-sorted this file (with sort command line tool).
        * VM/CodeBlock.cpp:
        (KJS::CodeBlock::dump): Fixed printf to avoid warnings -- to use %lu we
        need to make sure the type is unsigned long.
        * kjs/object.cpp:
        (KJS::Error::create): Eliminated unused error names array, and also put
        the strings into the code since there was already a switch statment.
        This also avoids having to contemplate a hypothetical access past the
        end of the array.
        * kjs/object.h: Got rid of errorNames.
        * kjs/property_slot.cpp: Deleted unused ungettableGetter.
        * kjs/property_slot.h: Ditto.
        * wtf/AlwaysInline.h: Added LIKELY alongside UNLIKELY.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Wed, 11 Jun 2008 19:55:07 +0000 (19:55 +0000)]
WebCore:

2008-06-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Add support for "*" wildcarding for Access-Control.

        Test: http/tests/xmlhttprequest/access-control-basic-allow-star.html

        * xml/AccessItem.cpp:
        (WebCore::AccessItem::AccessItem):
        (WebCore::AccessItem::parseAccessItem):
        (WebCore::AccessItem::matches):

LayoutTests:

2008-06-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Add basic test for "*" wildcarding for Access-Control.

        * http/tests/xmlhttprequest/access-control-basic-allow-star-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-star.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 11 Jun 2008 19:48:15 +0000 (19:48 +0000)]
2008-06-11  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19457: Create fused opcodes for tests and conditional jumps
        <https://bugs.webkit.org/show_bug.cgi?id=19457>

        Add a new jless instruction, and modify the code generator to emit it
        instead of the pair (less, jtrue).

        Gives a 3.6% improvement on SunSpider.

        * VM/CodeBlock.cpp:
        (KJS::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator):
        (KJS::CodeGenerator::emitOpcode):
        (KJS::CodeGenerator::retrieveLastBinaryOp):
        (KJS::CodeGenerator::rewindBinaryOp):
        (KJS::CodeGenerator::emitJump):
        (KJS::CodeGenerator::emitJumpIfTrue):
        (KJS::CodeGenerator::emitJumpIfFalse):
        (KJS::CodeGenerator::emitMove):
        (KJS::CodeGenerator::emitNot):
        (KJS::CodeGenerator::emitEqual):
        (KJS::CodeGenerator::emitNotEqual):
        (KJS::CodeGenerator::emitStrictEqual):
        (KJS::CodeGenerator::emitNotStrictEqual):
        (KJS::CodeGenerator::emitLess):
        (KJS::CodeGenerator::emitLessEq):
        (KJS::CodeGenerator::emitPreInc):
        (KJS::CodeGenerator::emitPreDec):
        (KJS::CodeGenerator::emitPostInc):
        (KJS::CodeGenerator::emitPostDec):
        (KJS::CodeGenerator::emitToJSNumber):
        (KJS::CodeGenerator::emitNegate):
        (KJS::CodeGenerator::emitAdd):
        (KJS::CodeGenerator::emitMul):
        (KJS::CodeGenerator::emitDiv):
        (KJS::CodeGenerator::emitMod):
        (KJS::CodeGenerator::emitSub):
        (KJS::CodeGenerator::emitLeftShift):
        (KJS::CodeGenerator::emitRightShift):
        (KJS::CodeGenerator::emitUnsignedRightShift):
        (KJS::CodeGenerator::emitBitAnd):
        (KJS::CodeGenerator::emitBitXOr):
        (KJS::CodeGenerator::emitBitOr):
        (KJS::CodeGenerator::emitBitNot):
        (KJS::CodeGenerator::emitInstanceOf):
        (KJS::CodeGenerator::emitTypeOf):
        (KJS::CodeGenerator::emitIn):
        (KJS::CodeGenerator::emitLoad):
        (KJS::CodeGenerator::emitNewObject):
        (KJS::CodeGenerator::emitNewArray):
        (KJS::CodeGenerator::emitResolve):
        (KJS::CodeGenerator::emitGetScopedVar):
        (KJS::CodeGenerator::emitPutScopedVar):
        (KJS::CodeGenerator::emitResolveBase):
        (KJS::CodeGenerator::emitResolveWithBase):
        (KJS::CodeGenerator::emitResolveFunction):
        (KJS::CodeGenerator::emitGetById):
        (KJS::CodeGenerator::emitPutById):
        (KJS::CodeGenerator::emitPutGetter):
        (KJS::CodeGenerator::emitPutSetter):
        (KJS::CodeGenerator::emitDeleteById):
        (KJS::CodeGenerator::emitGetByVal):
        (KJS::CodeGenerator::emitPutByVal):
        (KJS::CodeGenerator::emitDeleteByVal):
        (KJS::CodeGenerator::emitPutByIndex):
        (KJS::CodeGenerator::emitNewFunction):
        (KJS::CodeGenerator::emitNewRegExp):
        (KJS::CodeGenerator::emitNewFunctionExpression):
        (KJS::CodeGenerator::emitCall):
        (KJS::CodeGenerator::emitReturn):
        (KJS::CodeGenerator::emitEnd):
        (KJS::CodeGenerator::emitConstruct):
        (KJS::CodeGenerator::emitPushScope):
        (KJS::CodeGenerator::emitPopScope):
        (KJS::CodeGenerator::emitDebugHook):
        (KJS::CodeGenerator::emitComplexJumpScopes):
        (KJS::CodeGenerator::emitJumpScopes):
        (KJS::CodeGenerator::emitNextPropertyName):
        (KJS::CodeGenerator::emitGetPropertyNames):
        (KJS::CodeGenerator::emitCatch):
        (KJS::CodeGenerator::emitThrow):
        (KJS::CodeGenerator::emitNewError):
        (KJS::CodeGenerator::emitJumpSubroutine):
        (KJS::CodeGenerator::emitSubroutineReturn):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Opcode.cpp:
        (KJS::):
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-11 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 11 Jun 2008 19:37:44 +0000 (19:37 +0000)]
2008-06-11  Darin Adler  <darin@apple.com>

        Reviewed by Alexey.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19442
          JavaScript array implementation doesn't maintain m_numValuesInVector when sorting

        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::checkConsistency): Added. Empty inline version for when
        consistency checks are turned off.
        (KJS::ArrayInstance::ArrayInstance): Check consistency after construction.
        (KJS::ArrayInstance::~ArrayInstance): Check consistency before destruction.
        (KJS::ArrayInstance::put): Check consistency before and after.
        (KJS::ArrayInstance::deleteProperty): Ditto.
        (KJS::ArrayInstance::setLength): Ditto.
        (KJS::compareByStringPairForQSort): Use typedef for clarity.
        (KJS::ArrayInstance::sort): Check consistency before and after. Also broke the loop
        to set up sorting into two separate passes. Added FIXMEs about various exception
        safety issues. Added code to set m_numValuesInVector after sorting.
        (KJS::ArrayInstance::compactForSorting): Ditto.

        * kjs/array_instance.h: Added a definition of an enum for the types of consistency
        check and a declaration of the consistency checking function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Wed, 11 Jun 2008 18:30:22 +0000 (18:30 +0000)]
WebCore:

2008-06-11  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19455>
        Crash at RenderObject::childAt during JustifyCenter

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Added a FIXME.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): If we're removing a line
        break that consists of a single '\n' in a text node by itself, remove
        the whole text node instead of just emptying it out.
        * editing/Selection.cpp:
        (WebCore::Selection::validate): Added a FIXME about canonicalizing
        to positions that aren't candidates.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved): When the base and/or
        extent are about to be removed but the start and end aren't, change the
        base and extent to the start and end, but don't re-validate the selection,
        since doing so could move the start and end into the node that is about
        to be removed.

LayoutTests:

2008-06-11  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19455>
        Crash at RenderObject::childAt during JustifyCenter

        * editing/execCommand/19455-expected.txt: Added.
        * editing/execCommand/19455.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMark...
cfleizach@apple.com [Wed, 11 Jun 2008 18:27:44 +0000 (18:27 +0000)]
<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMarkerRangeForUnorderedTextMarkersParameterizedAttribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-11 Adriaan de Groot <groot@kde.org>
hausmann@webkit.org [Wed, 11 Jun 2008 15:19:55 +0000 (15:19 +0000)]
2008-06-11  Adriaan de Groot  <groot@kde.org>

        Reviewed by Simon.

        Fix compilation with Sun Studio 12

        It seems like the compiler instantiates a different template version. I.e.,
        instead of parseUASheet<char [nnnn]>, it's probably instantiating
        parseUASheet<char *>, which then passes 4 or 8 as the size value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 11 Jun 2008 15:10:29 +0000 (15:10 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixed a crash when a slot connect to QWebPage::unsupportedContent would show a
modal dialog with an event loop.

We have a queued connection to various signals in the QNetworkReply, for which
it can happen that after releasing the QNetworkReply and disconnecting from it
a slot connected to one of the signals may still be called due to a posted
MetaCall event due to the queued connections. This patch removes the posted
events explicitly, fixes the coding style a bit and makes sure the same happens
when abort() is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 11 Jun 2008 15:10:08 +0000 (15:10 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix left-click and middle-click mouse event are not properly accepted.

When copying or pasting text using left or middle-click, the event must be
accepted so that it will not be potentially processed further by the parent
and/or sub-classed widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 11 Jun 2008 14:56:52 +0000 (14:56 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix input element does not accept character typed in using AltGr.

EditorClient is modified to catch AltGr and Ctrl+Alt key combination.
This fixes http://trolltech.com/developer/task-tracker/index_html?id=207050&method=entry

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.
kevino@webkit.org [Wed, 11 Jun 2008 05:51:50 +0000 (05:51 +0000)]
wx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears...
kevino@webkit.org [Wed, 11 Jun 2008 05:18:49 +0000 (05:18 +0000)]
wx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears before WebCore/DerivedSources/HTMLElementFactory.h. (See note in commit for more details. This is probably not the right fix, but this will get us buildinguntil the right fix is in place.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.
kevino@webkit.org [Wed, 11 Jun 2008 05:16:17 +0000 (05:16 +0000)]
wx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - fix the text encoding in this test
mitz@apple.com [Tue, 10 Jun 2008 21:31:37 +0000 (21:31 +0000)]
    - fix the text encoding in this test

        * editing/selection/move-left-right.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by mjs.
eric@webkit.org [Tue, 10 Jun 2008 21:06:54 +0000 (21:06 +0000)]
    Reviewed by mjs.

        Fix disconnected event listener crasher
        m_disconnectedNodesWithEventListeners not updated when nodes adopted
        https://bugs.webkit.org/show_bug.cgi?id=19451

        I failed to find a way to make this crash DRT, I can crash Debug Safari consistently.

        * dom/EventTarget.cpp:
        (WebCore::EventTarget::willMoveToNewOwnerDocument):
        (WebCore::EventTarget::didMoveToNewOwnerDocument):
        * dom/EventTarget.h:
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::willMoveToNewOwnerDocument):
        (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
        * dom/EventTargetNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Tue, 10 Jun 2008 20:49:27 +0000 (20:49 +0000)]
WebCore:

2008-06-10  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        Move more parameters to the XML files.

        * dom/make_names.pl:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * svg/svgattrs.in:
        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 10 Jun 2008 16:56:15 +0000 (16:56 +0000)]
2008-06-10  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed.

        - tweak newly added markup.

        * blog/wp-content/themes/webkit/header.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-10 Joerg Bornemann <joerg.bornemann@trolltech.com>
hausmann@webkit.org [Tue, 10 Jun 2008 16:54:17 +0000 (16:54 +0000)]
2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>

        Reviewed by Simon.

        For the qmake based build make it possible to build against makespecs where
        QMAKE_CC is defined in a configuration file included from qmake.conf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-05-26 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
hausmann@webkit.org [Tue, 10 Jun 2008 16:47:27 +0000 (16:47 +0000)]
2008-05-26  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=19323

        Implemented the QWebPage::editable property.

        Small documentation fixes by Simon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin.
ap@webkit.org [Tue, 10 Jun 2008 14:54:39 +0000 (14:54 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=16503
        match limit takes at least 13% of the time on the SunSpider regexp-dna test

        Make the limit test slightly more efficient. It is not clear how much of a win it is,
        as the improvement on regexp-dna varies from 2.3% to 0.6% depending on what revision I
        apply the patch to. Today, the win on regexp-dna was minimal, but the total win was whopping
        0.5%, due to random code generation changes.

        * pcre/pcre_exec.cpp: (match): Avoid loading a constant on each iteration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 10 Jun 2008 14:22:10 +0000 (14:22 +0000)]
2008-06-10  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Adele.

        - add short title and multisize icon

        * blog/wp-content/themes/webkit/header.php:
        * images/surfin-safari.icns: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 10 Jun 2008 08:58:00 +0000 (08:58 +0000)]
2008-06-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Make sure web action in context menus have the right enablement,
        while not messing up other web actions not included in the menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoApply GTK coding style to WebKit Gtk public headers
christian@webkit.org [Tue, 10 Jun 2008 07:48:46 +0000 (07:48 +0000)]
Apply GTK coding style to WebKit Gtk public headers

https://bugs.webkit.org/show_bug.cgi?id=16676

Reviewed by Alp Toker and Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-09 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 10 Jun 2008 05:42:48 +0000 (05:42 +0000)]
2008-06-09  Alp Toker  <alp@nuanti.com>

        gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
        each of the tools since these are no longer set globally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Tue, 10 Jun 2008 04:58:09 +0000 (04:58 +0000)]
WebCore:

        Reviewed by Justin Garcia.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19443
          <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character

        Tests added to editing/selection/move-left-right.html

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): When falling
        back from visual to logical movement, restart at the original position
        rather than an intermediate position.
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.

LayoutTests:

        Reviewed by Justin Garcia.

        - update test for https://bugs.webkit.org/show_bug.cgi?id=19443
          <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character

        * editing/selection/move-left-right-expected.txt:
        * editing/selection/move-left-right.html:
        * platform/mac/editing/selection/move-left-right-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Mon, 9 Jun 2008 22:54:50 +0000 (22:54 +0000)]
2008-06-07  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Maciej.

        Windows build fix.

        * platform/graphics/win/QTMovieWin.cpp:
        (initializeSupportedTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 21:02:23 +0000 (21:02 +0000)]
2008-06-09  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Sam.

        Add an include for readline/history.h to fix the build for Darwin users
        with the GNU readline library installed. Also, clean up the style of
        the HAVE(READLINE) check.

        * kjs/testkjs.cpp:
        (runInteractive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 17:10:27 +0000 (17:10 +0000)]
2008-06-09  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 17531: Add interactive mode to testkjs
        <https://bugs.webkit.org/show_bug.cgi?id=17531>

        This is a cleaned up version of Sam's earlier patch to add an
        interactive mode to testkjs.

        Readline support is only enabled on Darwin platforms for now, but
        other ports can enable it by defining HAVE_READLINE in kjs/config.h.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/config.h:
        * kjs/testkjs.cpp:
        (Options::Options):
        (runWithScripts):
        (runInteractive):
        (printUsageStatement):
        (parseArguments):
        (kjsmain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-09 Benjamin C Meyer <ben@meyerhome.net>
hausmann@webkit.org [Mon, 9 Jun 2008 14:58:10 +0000 (14:58 +0000)]
2008-06-09  Benjamin C Meyer  <ben@meyerhome.net>

        Reviewed by Simon

       Add Shift-Space shortcut to go up one screen, the opposite of Space
       which goes down one screen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 9 Jun 2008 12:55:31 +0000 (12:55 +0000)]
2008-06-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Use the text color from QStyle when styling form elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Mon, 9 Jun 2008 10:59:57 +0000 (10:59 +0000)]
WebCore:

2008-06-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Added a parameters hash that will hold the parameters we used to give in the
        command line.

        - Added "tags" / "attrs" XML tag parsing to fill the parameters hash.

        - Moved namespace, namespaceURI, namespacePrefix and cppNamespace in the *.in
        files.

        * dom/make_names.pl:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * svg/svgattrs.in:
        * svg/svgtags.in:
        * svg/xlinkattrs.in:
        * xml/xmlattrs.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 9 Jun 2008 07:56:07 +0000 (07:56 +0000)]
2008-06-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Darin.

        Incorporated Darin's comments to bug 18965.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBackout 34464. The build bot didn't like the new tests.
abarth@webkit.org [Mon, 9 Jun 2008 07:30:57 +0000 (07:30 +0000)]
Backout 34464.  The build bot didn't like the new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 9 Jun 2008 06:26:30 +0000 (06:26 +0000)]
2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Alder.

        https://bugs.webkit.org/show_bug.cgi?id=16631

        Improve coverage of our frame navigation test cases.  This revealed a
        bug in plugin navigation (we aren't setting the opener properly), but
        that's probably better addressed in a separate patch.

        * http/tests/security/frameNavigation/navigation-ALLOWED-child-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-child.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-descendant-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-descendant.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-not-opener-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-not-opener.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-opener-child-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-opener-child.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-popup-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-popup.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-form-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-form.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-location-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-location.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-open-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-open.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-form-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-form.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-location-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-location.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-open-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-open.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin.html: Added.
        * http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Removed.
        * http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Removed.
        * http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Removed.
        * http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Removed.
        * http/tests/security/frameNavigation/resources/iframe.html: Added.
        * http/tests/security/frameNavigation/resources/lib.js: Added.
        * http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Removed.
        * http/tests/security/frameNavigation/resources/navigation-happened.html: Removed.
        * http/tests/security/frameNavigation/resources/open.html: Added.
        * http/tests/security/frameNavigation/resources/ready.html: Added.
        * http/tests/security/frameNavigation/resources/target.html: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Removed.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 9 Jun 2008 06:26:09 +0000 (06:26 +0000)]
2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=16856

        Fix tests not to rely on broken javascript URL behavior.

        * fast/events/event-listener-html-non-html-confusion.html:
        * fast/replaced/image-map-bug16782-expected.txt: Added.
        * fast/replaced/image-map-bug16782.html: Added.
        * fast/replaced/image-map.html:
        * svg/custom/prevent-default.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 05:20:32 +0000 (05:20 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 17931: Incorrect decompilation with |new|
        <https://bugs.webkit.org/show_bug.cgi?id=17931>

        This bug was fixed by SquirrelFish, but we should add a test.

        * fast/js/function-toString-parentheses-expected.txt:
        * fast/js/resources/function-toString-parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 04:47:05 +0000 (04:47 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 17932: "ASSERTION FAILED: type != Continue" with do/while and try/finally
        <https://bugs.webkit.org/show_bug.cgi?id=17932>

        This bug was fixed by SquirrelFish, but we should add a test, as well
        as tests for related issues found while developing SquirrelFish.

        * fast/js/continue-break-multiple-labels-expected.txt:
        * fast/js/continue-break-multiple-labels.html:
        * fast/js/resources/continue-break-multiple-labels.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
abarth@webkit.org [Mon, 9 Jun 2008 04:37:49 +0000 (04:37 +0000)]
WebCore:

2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Inherit document.URL from parent's document.URL, not document.baseURI.

        https://bugs.webkit.org/show_bug.cgi?id=19257

        Tests: http/tests/security/cookies/assign-document-url.html
               http/tests/security/cookies/base-about-blank.html
               http/tests/security/cookies/base-tag.html
               http/tests/security/cookies/basic.html

        * dom/Document.cpp:
        (WebCore::Document::open):

LayoutTests:

2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Alder.

        Add a number of tests for document.cookie access.

        https://bugs.webkit.org/show_bug.cgi?id=19257

        * http/tests/security/cookies: Added.
        * http/tests/security/cookies/assign-document-url-expected.txt: Added.
        * http/tests/security/cookies/assign-document-url.html: Added.
        * http/tests/security/cookies/base-about-blank-expected.txt: Added.
        * http/tests/security/cookies/base-about-blank.html: Added.
        * http/tests/security/cookies/base-tag-expected.txt: Added.
        * http/tests/security/cookies/base-tag.html: Added.
        * http/tests/security/cookies/basic-expected.txt: Added.
        * http/tests/security/cookies/basic.html: Added.
        * http/tests/security/cookies/resources: Added.
        * http/tests/security/cookies/resources/set-a-cookie.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Darin Adler.
kevino@webkit.org [Mon, 9 Jun 2008 03:39:46 +0000 (03:39 +0000)]
Reviewed by Darin Adler.

Fix font asserts in wx port. Our computeHash function should generate the same hash for two identical fonts which are different objects, which it wasn't doing before.

https://bugs.webkit.org/show_bug.cgi?id=19310

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 9 Jun 2008 02:12:21 +0000 (02:12 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

        Test: fast/multicol/content-height-zero-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutColumns): Changed to not keep creating
        overflow columns that have zero height, because they do not help with
        fitting content in.

LayoutTests:

        - test for <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

        Reviewed by Darin Adler.

        * fast/multicol/content-height-zero-crash-expected.txt: Added.
        * fast/multicol/content-height-zero-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 00:57:28 +0000 (00:57 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19346: REGRESSION: Mootools 1.2 Class inheritance broken in post-SquirrelFish merge
        <https://bugs.webkit.org/show_bug.cgi?id=19346>

        A check for whether a function's caller is eval code accidentally included
        the case where the caller's caller is native code. Add a CodeType field to
        CodeBlock and use this for the eval caller test instead.

        JavaScriptCore:

        * VM/CodeBlock.h:
        (KJS::CodeBlock::CodeBlock):
        (KJS::ProgramCodeBlock::ProgramCodeBlock):
        (KJS::EvalCodeBlock::EvalCodeBlock):
        * VM/Machine.cpp:
        (KJS::getCallerFunctionOffset):
        * kjs/nodes.cpp:
        (KJS::FunctionBodyNode::generateCode):
        (KJS::ProgramNode::generateCode):

        LayoutTests:

        * fast/js/function-dot-arguments-and-caller-expected.txt:
        * fast/js/function-dot-arguments-and-caller.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 18837: Database panel fails to display tables if any value is NULL
aroben@apple.com [Sun, 8 Jun 2008 20:57:48 +0000 (20:57 +0000)]
    Fix Bug 18837: Database panel fails to display tables if any value is NULL

        <https://bugs.webkit.org/show_bug.cgi?id=18837>

        Reviewed by Darin Adler.

        Test: manual-tests/inspector/display-sql-null.html

        * manual-tests/inspector/display-sql-null.html: Added.
        * page/inspector/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all
        objects to strings before operating on them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 19438: Transaction errors are never displayed in database query view
aroben@apple.com [Sun, 8 Jun 2008 20:57:11 +0000 (20:57 +0000)]
    Fix Bug 19438: Transaction errors are never displayed in database query view

        <https://bugs.webkit.org/show_bug.cgi?id=19438>

        Reviewed by Darin Adler.

        Test: manual-tests/inspector/display-sql-transaction-error.html

        * manual-tests/inspector/display-sql-transaction-error.html: Added.
        * page/inspector/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): Use
        _executeSqlError as the error callback for executeSql.
        (WebInspector.DatabaseQueryView.prototype._queryError): Changed to
        only take two parameters. This matches what we'll be passed if
        db.transaction fails.
        (WebInspector.DatabaseQueryView.prototype._executeSqlError): Added.
        Calls through to _queryError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Dirk Schulze <vbs85@gmx.de>
darin@apple.com [Sun, 8 Jun 2008 20:36:24 +0000 (20:36 +0000)]
2008-06-08  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18840
        [CAIRO] Clipping-support for SVG

        Support for clipping in SVG/Cairo and fixes transformation of paths.

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::transform):
        * svg/graphics/cairo/SVGResourceClipperCairo.cpp:
        (WebCore::SVGResourceClipper::applyClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Dirk Schulze <vbs85@gmx.de>
darin@apple.com [Sun, 8 Jun 2008 20:33:27 +0000 (20:33 +0000)]
2008-06-08  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18663
        Add text-stroke support to Cairo.

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 20:30:50 +0000 (20:30 +0000)]
WebCore:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=16489
        WebKit does not support ElementTraversal specification

        Tests: fast/dom/Element/element-traversal.html

        * dom/Element.cpp:
        (WebCore::Element::firstElementChild):
        (WebCore::Element::lastElementChild):
        (WebCore::Element::previousElementSibling):
        (WebCore::Element::nextElementSibling):
        (WebCore::Element::childElementCount):
        * dom/Element.h:
        * dom/Element.idl:

LayoutTests:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        test cases for https://bugs.webkit.org/show_bug.cgi?id=16489
        WebKit does not support ElementTraversal specification

        * fast/dom/Element/element-traversal-expected.txt: Added.
        * fast/dom/Element/element-traversal.html: Added.
        * fast/dom/Element/resources/element-traversal.js: Added.

        * fast/dom/domListEnumeration-expected.txt: Updated since Element now has 5
        new properties. It would be good to rewrite this test so it doesn't have to
        be updated every time we add a property to Node or Element.
        * fast/dom/resources/domListEnumeration.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 20:01:19 +0000 (20:01 +0000)]
WebCore:

2008-06-08  Bradley Meck  <genisis329@gmail.com>

        Reviewed by Darin.

        - fix https://bugs.webkit.org/show_bug.cgi?id=17051
          safari should treat "url()" as a valid CSS value

        Test: fast/css/invalid-cursor-property-crash.html

        Changed check for empty url() to be a check for null since url() is valid
        CSS even if it is empty.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseBorderImage):

LayoutTests:

2008-06-08  Bradley Meck  <genisis329@gmail.com>

        Reviewed and tweaked by Darin.

        - test for https://bugs.webkit.org/show_bug.cgi?id=17051
          safari should treat "url()" as a valid CSS value

        We should really add some more tests for this. One text-only test each for the
        four different sites that handle URLs (cursor image, list style image, fill image,
        border image) that were fixed. Currently this covers only the cursor image.

        * fast/css/invalid-cursor-property-crash.html: Updated test to expect the
        url() to be expanded into the URL of the document itself. The text of the test
        is now a bit misleading, but it still tests that it's not a crash, and now it
        also doubles as a check that url() is handled properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:41:25 +0000 (19:41 +0000)]
WebCore:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        Bug 18041: DOMNodeRemoved events are sent twice

        Test: fast/dom/Node/DOMNodeRemovedEvent.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChild):

LayoutTests:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        Test case for
        Bug 18041: DOMNodeRemoved events are sent twice

        * fast/dom/Node/DOMNodeRemovedEvent-expected.txt: Added.
        * fast/dom/Node/DOMNodeRemovedEvent.html: Added.
        * fast/dom/Node/resources/DOMNodeRemovedEvent.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:31:59 +0000 (19:31 +0000)]
WebCore:

2008-06-08  Tony Chang  <idealisms@gmail.com>

        Reviewed by Eric Seidel.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18167
          there should be no text-drag delay on any platform except for Mac

        Move the drag text delay value into the platform specific files.

        Test: editing/selection/drag-text-delay.html

        * page/EventHandler.cpp:
        * page/EventHandler.h:
        * page/gtk/EventHandlerGtk.cpp:
        * page/mac/EventHandlerMac.mm:
        * page/qt/EventHandlerQt.cpp:
        * page/win/EventHandlerWin.cpp:
        * page/wx/EventHandlerWx.cpp:

LayoutTests:

2008-06-08  Tony Chang  <idealisms@gmail.com>

        Reviewed by Eric Seidel.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18167
          there should be no text-drag delay on any platform except for Mac

        Also updated two tests which depend on the drag text delay to be greater
        than 0 by making them no longer select text before the mouse down.

        * editing/selection/drag-text-delay-expected.txt: Added.
        * editing/selection/drag-text-delay.html: Added.
        * platform/mac/editing/selection/drag-text-delay-expected.txt: Added.

        * fast/events/autoscroll.html:
        * fast/forms/input-readonly-autoscroll.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:21:35 +0000 (19:21 +0000)]
WebCore:

2008-06-08  Rob Buis  <buis@kde.org>

        Reviewed by Darin.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18512
          getPresentationAttribute returns a shared object

        Test: svg/custom/getPresentationAttribute-modify.svg

        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::getPresentationAttribute): Unshare the mapped style
        declaration if it is shared before returning the presentation attribute.

LayoutTests:

2008-06-08  Rob Buis  <buis@kde.org>

        Reviewed by Darin.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18512
          getPresentationAttribute returns a shared object

        * svg/custom/getPresentationAttribute-modify-expected.txt: Added.
        * svg/custom/getPresentationAttribute-modify.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Eric Roman <minatoar@gmail.com>
darin@apple.com [Sun, 8 Jun 2008 19:08:53 +0000 (19:08 +0000)]
2008-06-08  Eric Roman  <minatoar@gmail.com>

        Reviewed by Adam Roben.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18550
          cross-frame-access-call.html doesn't really test window.open(), since popups are blocked

        * http/tests/security/cross-frame-access-call.html: Enable popups for this layout test.
        The test checks that window.open is returns undefined (same-domain enforcement), however
        unless popups are enabled it returns undefined regardless.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 8 Jun 2008 19:04:23 +0000 (19:04 +0000)]
2008-06-08  Alp Toker  <alp@nuanti.com>

        autotools/GTK+ build system cleanup. Don't include WebKit API in the
        WebCore build as it's no longer needed since r34426.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Jonathan Haas <myrdred@gmail.com>
darin@apple.com [Sun, 8 Jun 2008 18:39:44 +0000 (18:39 +0000)]
2008-06-08  Jonathan Haas <myrdred@gmail.com>

        Reviewed by Eric Seidel.
        Tweaked by Darin while landing to make it compile.

        - fix http://bugs.webkit.org/show_bug.cgi?id=19128
          SVG fonts don't work with medial Arabic characters

        Haven't figured out a way to make an automated test for this.

        * svg/SVGGlyphElement.h: Made arabicForm unsigned so it fits into
        its 3-bit field. Did the same for orientation's 2-bit field.

        * svg/SVGFont.cpp: Did a bit of minor tweaking.
        (WebCore::isCompatibleArabicForm): Added a cast to avoid a warning
        since the type is now different.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Eric Carlson <eric.carlson@apple.com>
darin@apple.com [Sun, 8 Jun 2008 18:22:45 +0000 (18:22 +0000)]
2008-06-08  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19299
          <rdar://problem/5969392>

        Generate the media MIME type list dynamically.

        * platform/graphics/win/QTMovieWin.cpp:
        (initializeSupportedTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Christian Persch <chpe@gnome.org>
darin@apple.com [Sun, 8 Jun 2008 18:16:38 +0000 (18:16 +0000)]
2008-06-08  Christian Persch  <chpe@gnome.org>

        Reviewed by Darin.

        - https://bugs.webkit.org/show_bug.cgi?id=19309
          uninitialised variable in PluginView

        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView): Initialise the NPP's pdata member to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 8 Jun 2008 18:07:11 +0000 (18:07 +0000)]
2008-06-08  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - https://bugs.webkit.org/show_bug.cgi?id=19435
          fix warning in PluginDebug.h

        * plugins/PluginDebug.h: Don't compile the errorStrings array if LOG_DISABLED is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Roben.
mitz@apple.com [Sun, 8 Jun 2008 17:44:41 +0000 (17:44 +0000)]
    Reviewed by Adam Roben.

        - update trac URL in PrettyPatch

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 8 Jun 2008 16:10:16 +0000 (16:10 +0000)]
2008-06-08  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Mark Rowe.

        Bring back -fstrict-aliasing for JavaScriptCore which was removed in
        r31821, since aliasing issues have now been fixed.

        Use -O3, not -O2 for the JavaScriptCore build.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-08 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 8 Jun 2008 16:01:54 +0000 (16:01 +0000)]
2008-06-08  Darin Adler  <darin@apple.com>

        * Scripts/make-js-test-wrappers: Added another exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sun, 8 Jun 2008 05:56:27 +0000 (05:56 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19431
          <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out

        Covered by fast/css/remove-shorthand.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::initShorthandMap): Fixed a typo which mapped the background
        shorthand to the mask properties.

LayoutTests:

        Reviewed by Dave Hyatt.

        - updated test for https://bugs.webkit.org/show_bug.cgi?id=19431
          <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out

        * fast/css/remove-shorthand-expected.txt:
        * fast/css/remove-shorthand.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 8 Jun 2008 03:50:33 +0000 (03:50 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Dan Bernstein.

        Bug 17928: testkjs shouldn't require "-f"
        <https://bugs.webkit.org/show_bug.cgi?id=17928>

        * kjs/testkjs.cpp:
        (printUsageStatement):
        (parseArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Brent Fulgham <bfulgham@gmail.com>
jmalonzo@webkit.org [Sun, 8 Jun 2008 01:57:54 +0000 (01:57 +0000)]
2008-06-07  Brent Fulgham  <bfulgham@gmail.com>

        Cairo build fix for r34432

        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 8 Jun 2008 01:44:07 +0000 (01:44 +0000)]
2008-06-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Confirmed by Christian Dywan.

        Gtk build fix for r34432

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_history_item_add):
        (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
        (WebKit::core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 8 Jun 2008 01:12:16 +0000 (01:12 +0000)]
2008-06-07  Darin Adler  <darin@apple.com>

        - try to fix build after HistoryItem changes

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create.
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also
        believe this fixes a memory leak in the old version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 8 Jun 2008 00:20:11 +0000 (00:20 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Timothy.

        Remove the --squirrelfish option from SunSpider, as it is no longer needed.

        SunSpider:

        * sunspider:
        * tests/LIST-SQUIRRELFISH: Removed.

        WebKitTools:

        * Scripts/run-sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sat, 7 Jun 2008 22:51:37 +0000 (22:51 +0000)]
WebCore:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toHTMLCanvasStyle):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
        * bindings/js/JSNodeFilterCondition.h:
        (WebCore::JSNodeFilterCondition::create):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter):
        * bindings/js/JSSVGLazyEventListener.h:
        (WebCore::JSSVGLazyEventListener::create):
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::multiply):
        (WebCore::JSSVGMatrix::inverse):
        (WebCore::JSSVGMatrix::translate):
        (WebCore::JSSVGMatrix::scale):
        (WebCore::JSSVGMatrix::scaleNonUniform):
        (WebCore::JSSVGMatrix::rotate):
        (WebCore::JSSVGMatrix::rotateFromVector):
        (WebCore::JSSVGMatrix::flipX):
        (WebCore::JSSVGMatrix::flipY):
        (WebCore::JSSVGMatrix::skewX):
        (WebCore::JSSVGMatrix::skewY):
        * bindings/js/JSSVGPODTypeWrapper.h:
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
        (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
        (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::commonExit):
        (WebCore::commonExitReadOnly):
        (WebCore::JSSVGPointList::initialize):
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        (WebCore::JSSVGPointList::appendItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::initialize):
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        (WebCore::JSSVGTransformList::appendItem):
        * bindings/js/kjs_binding.cpp:
        (WebCore::setDOMException):
        * bindings/js/kjs_events.h:
        (WebCore::JSUnprotectedEventListener::create):
        (WebCore::JSEventListener::create):
        (WebCore::JSLazyEventListener::create):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::createHTMLEventHandler):
        (WebCore::KJSProxy::createSVGEventHandler):
        * bindings/objc/DOM.mm:
        (WebCore::ObjCNodeFilterCondition::create):
        (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition):
        (WebCore::ObjCNodeFilterCondition::acceptNode):
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForNinePieceImage):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSFontFace.h:
        (WebCore::CSSFontFace::create):
        (WebCore::CSSFontFace::CSSFontFace):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseCounterContent):
        (WebCore::CSSParser::parseShape):
        (WebCore::BorderImageParseContext::commitBorderImage):
        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
        * css/CSSSegmentedFontFace.h:
        (WebCore::CSSSegmentedFontFace::create):
        * css/Counter.h:
        (WebCore::Counter::create):
        (WebCore::Counter::Counter):
        * css/DashboardRegion.h:
        (WebCore::DashboardRegion::create):
        (WebCore::DashboardRegion::DashboardRegion):
        * css/Rect.h:
        (WebCore::Rect::create):
        (WebCore::Rect::Rect):
        * dom/ChildNodeList.h:
        (WebCore::ChildNodeList::create):
        * dom/ClassNodeList.h:
        (WebCore::ClassNodeList::create):
        * dom/Clipboard.h:
        * dom/DOMCoreException.h:
        (WebCore::DOMCoreException::create):
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::instance):
        * dom/DOMImplementation.h:
        (WebCore::DOMImplementation::DOMImplementation):
        * dom/Document.cpp:
        (WebCore::Document::addWindowEventListener):
        (WebCore::Document::removeWindowEventListener):
        (WebCore::Document::setDecoder):
        (WebCore::Document::images):
        (WebCore::Document::applets):
        (WebCore::Document::embeds):
        (WebCore::Document::plugins):
        (WebCore::Document::objects):
        (WebCore::Document::scripts):
        (WebCore::Document::links):
        (WebCore::Document::forms):
        (WebCore::Document::anchors):
        (WebCore::Document::all):
        (WebCore::Document::windowNamedItems):
        (WebCore::Document::documentNamedItems):
        * dom/Document.h:
        * dom/DynamicNodeList.h:
        * dom/EventException.h:
        (WebCore::EventException::create):
        (WebCore::EventException::EventException):
        * dom/EventListener.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::addEventListener):
        (WebCore::EventTarget::removeEventListener):
        * dom/ExceptionBase.cpp:
        (WebCore::ExceptionBase::ExceptionBase):
        * dom/ExceptionBase.h:
        * dom/NameNodeList.h:
        (WebCore::NameNodeList::create):
        * dom/Node.cpp:
        (WebCore::Node::childNodes):
        (WebCore::Node::getElementsByTagNameNS):
        (WebCore::Node::getElementsByName):
        (WebCore::Node::getElementsByClassName):
        (WebCore::Node::querySelectorAll):
        * dom/NodeFilterCondition.h:
        * dom/NodeList.h:
        * dom/RangeException.h:
        (WebCore::RangeException::create):
        (WebCore::RangeException::RangeException):
        * dom/RegisteredEventListener.h:
        (WebCore::RegisteredEventListener::create):
        * dom/SelectorNodeList.cpp:
        (WebCore::createSelectorNodeList):
        * dom/SelectorNodeList.h:
        * dom/StaticNodeList.cpp:
        (WebCore::StaticNodeList::StaticNodeList):
        * dom/StaticNodeList.h:
        (WebCore::StaticNodeList::adopt):
        * dom/TagNodeList.h:
        (WebCore::TagNodeList::create):
        * history/HistoryItem.cpp:
        (WebCore::defaultNotifyHistoryItemChanged):
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::copy):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::create):
        * html/CanvasGradient.h:
        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):
        * html/CanvasPattern.h:
        (WebCore::CanvasPattern::create):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::State::State):
        (WebCore::CanvasRenderingContext2D::setStrokeColor):
        (WebCore::CanvasRenderingContext2D::setFillColor):
        (WebCore::CanvasRenderingContext2D::createPattern):
        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::CanvasStyle):
        * html/CanvasStyle.h:
        (WebCore::CanvasStyle::create):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection):
        (WebCore::HTMLCollection::create):
        * html/HTMLCollection.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::children):
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::create):
        * html/HTMLFormCollection.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::elements):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::areas):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::load):
        (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
        (WebCore::HTMLMediaElement::willSaveToCache):
        * html/HTMLNameCollection.h:
        (WebCore::HTMLNameCollection::create):
        * html/HTMLOptionsCollection.cpp:
        (WebCore::HTMLOptionsCollection::create):
        * html/HTMLOptionsCollection.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::options):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::rows):
        (WebCore::HTMLTableElement::tBodies):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::cells):
        * html/HTMLTableRowsCollection.cpp:
        (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
        (WebCore::HTMLTableRowsCollection::create):
        * html/HTMLTableRowsCollection.h:
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::rows):
        * html/MediaError.h:
        (WebCore::MediaError::create):
        (WebCore::MediaError::MediaError):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::ensureSVGFontData):
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write):
        (WebCore::FrameLoader::createHistoryItem):
        * loader/ImageDocument.cpp:
        (WebCore::ImageEventListener::create):
        (WebCore::ImageEventListener::ImageEventListener):
        (WebCore::ImageDocument::createDocumentStructure):
        * loader/TextResourceDecoder.h:
        (WebCore::TextResourceDecoder::create):
        * page/Page.cpp:
        (WebCore::Page::userStyleSheet):
        * svg/SVGException.h:
        (WebCore::SVGException::create):
        (WebCore::SVGException::SVGException):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::ConditionEventListener::create):
        (WebCore::ConditionEventListener::ConditionEventListener):
        (WebCore::SVGSMILElement::connectConditions):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequestException.h:
        (WebCore::XMLHttpRequestException::create):
        (WebCore::XMLHttpRequestException::XMLHttpRequestException):
        * xml/XPathException.h:
        (WebCore::XPathException::create):
        (WebCore::XPathException::XPathException):
        * xml/XPathResult.cpp:
        (WebCore::InvalidatingEventListener::create):
        (WebCore::InvalidatingEventListener::InvalidatingEventListener):
        (WebCore::XPathResult::XPathResult):
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):

WebKit/mac:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem init]):
        (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
        (-[WebHistoryItem initWithURL:target:parent:title:]):
        (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
        * WebView/WebView.mm:
        (+[WebView _decodeData:]):

WebKit/win:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * WebHistoryItem.cpp:
        (WebHistoryItem::createInstance):
        (WebHistoryItem::initFromDictionaryRepresentation):
        (WebHistoryItem::initWithURLString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 7 Jun 2008 22:49:37 +0000 (22:49 +0000)]
2008-06-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix random failures of XSS tests by using window.postMessage().

        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
        * http/tests/security/resources/cross-frame-access.js:
        * http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html:
        * http/tests/security/resources/cross-frame-iframe.html:
        * platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
mitz@apple.com [Sat, 7 Jun 2008 22:37:28 +0000 (22:37 +0000)]
    Reviewed by Sam Weinig.

        - pixel test for https://bugs.webkit.org/show_bug.cgi?id=19279
          REGRESSION (r32660): Text not redrawn correctly when selection changes

        * fast/text/selection-painted-separately.html: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.checksum: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.png: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 21:56:42 +0000 (21:56 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Eric.

        Bug 17548: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
        <https://bugs.webkit.org/show_bug.cgi?id=17548>

        * kjs/testkjs.cpp:
        (functionPrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 19:32:42 +0000 (19:32 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Sam.

        Bug 17547: JavaScriptCore print() differs from Spidermonkey Behavior
        <https://bugs.webkit.org/show_bug.cgi?id=17547>

        * kjs/testkjs.cpp:
        (functionPrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Jun 2008 19:02:00 +0000 (19:02 +0000)]
2008-06-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=17911

        * http/tests/security/resources/iframe-for-synchronous-form.html: Added.
        * http/tests/security/xss-DENIED-synchronous-form-expected.txt: Added.
        * http/tests/security/xss-DENIED-synchronous-form.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove PLATFORM ifdefs from ContextMenu.cpp
christian@webkit.org [Sat, 7 Jun 2008 18:07:07 +0000 (18:07 +0000)]
Remove PLATFORM ifdefs from ContextMenu.cpp

https://bugs.webkit.org/show_bug.cgi?id=17324

Reviewed by Alp Toker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago More build fixes.
ap@webkit.org [Sat, 7 Jun 2008 10:59:39 +0000 (10:59 +0000)]
    More build fixes.

        * kjs/JSGlobalData.cpp: Fixed an included file name for case-sensitive file systems, fixed
        JSGlobalData::threadInstance() for non-multithreaded builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix - actually adding JSGlobalData.cpp to non-Mac builds!
ap@webkit.org [Sat, 7 Jun 2008 10:41:00 +0000 (10:41 +0000)]
    Build fix - actually adding JSGlobalData.cpp to non-Mac builds!

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:36:10 +0000 (10:36 +0000)]
    Reviewed by ap.

        Still more CSSParser cleanup
        - use c++ style member initializers in CSSParser()
        - change m_styleElement to m_styleSheet and make it a CSSStyleSheet
        - finally add my copyright to the files I've been cleaning

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createMediaRule):
        (WebCore::CSSParser::createStyleRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:35:41 +0000 (10:35 +0000)]
    Reviewed by ap.

        More CSSParser cleanup
        - rename CSSParser::id to m_id
        - rename CSSParser::data to m_data
        - fix a few whitespace and argument name issues

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseValue):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:35:10 +0000 (10:35 +0000)]
    Reviewed by ap.

        Rename CSSParser::strict to m_strict

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBackgroundColor):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseTransitionDuration):
        (WebCore::CSSParser::parseTransitionRepeatCount):
        (WebCore::CSSParser::parseTimingFunctionValue):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseColorFromValue):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::CSSParser::parseBorderImage):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:34:39 +0000 (10:34 +0000)]
    Reviewed by ap.

        Rename CSSParser::defaultNamespace to m_defaultNamespace

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseSheet):
        * css/CSSParser.h:
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::addNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:34:06 +0000 (10:34 +0000)]
    Reviewed by ap.

        Rename CSSParser::important to m_important

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:33:31 +0000 (10:33 +0000)]
    Reviewed by ap.

        Yet another cleanup patch for CSSParser
        Rename CSSParser::valueList to m_valueList

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::checkForOrphanedUnits):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillShorthand):
        (WebCore::CSSParser::parseTransitionShorthand):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillPosition):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseFillProperty):
        (WebCore::CSSParser::parseTransitionProperty):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseFontFamily):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::BorderImageParseContext::commitBorderImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::parseCounter):
        (WebCore::CSSParser::parseGradient):
        (WebCore::CSSParser::parseCanvas):
        (WebCore::CSSParser::parseTransform):
        (WebCore::CSSParser::parseTransformOrigin):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        (WebCore::CSSParser::parseSVGStrokeDasharray):
        (WebCore::CSSParser::parseSVGPaint):
        (WebCore::CSSParser::parseSVGColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:32:57 +0000 (10:32 +0000)]
    Reviewed by ap.

        More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
        Remove CSSParser::current and CSSParser::currentParser and use
        the magic of YYLEX_PARAM instead.

        * css/CSSParser.cpp:
        (WebCore::enterGeneratedParser):
        (WebCore::CSSParser::parseSheet):
        (WebCore::CSSParser::parseRule):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::parseMediaQuery):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Try to fix Gtk/gcc 4.3 build.
ap@webkit.org [Sat, 7 Jun 2008 10:20:31 +0000 (10:20 +0000)]
    Try to fix Gtk/gcc 4.3 build.

        * kjs/JSGlobalData.h: Include ustring.h instead of forward-declaring UString::Rep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Sat, 7 Jun 2008 09:57:10 +0000 (09:57 +0000)]
WebCore:

2008-06-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Added XML attributes' parsing.

        - Moved (most) capitalization and audio hacks in the *.in files.

        * dom/make_names.pl:
        * html/HTMLTagNames.in:
        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
mitz@apple.com [Sat, 7 Jun 2008 08:20:58 +0000 (08:20 +0000)]
2008-06-07  Pierre-Luc Beaudoin  <pierre-luc.beaudoin@collabora.co.uk>

        With the help of Jonathon Jongsma.

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19279
        REGRESSION (r32660): Text not redrawn correctly when selection changes

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        Add a condition for when ePos <= sPos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 07:58:38 +0000 (07:58 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 17663: Wrong sequencing of argument list evaluation
        <https://bugs.webkit.org/show_bug.cgi?id=17663>

        SquirrelFish fixed this bug, but we should add a test.

        LayoutTests:

        * fast/js/order-of-operations-expected.txt:
        * fast/js/resources/order-of-operations.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin.
ap@webkit.org [Sat, 7 Jun 2008 06:03:24 +0000 (06:03 +0000)]
    Reviewed by Darin.

        Combine per-thread objects into one, to make it easier to support legacy clients (for
        which they shouldn't be really per-thread).

        No change on SunSpider total.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added JSGlobalData.{h,cpp}

        * kjs/JSGlobalData.cpp: Added.
        (KJS::JSGlobalData::JSGlobalData):
        (KJS::JSGlobalData::~JSGlobalData):
        (KJS::JSGlobalData::threadInstance):
        * kjs/JSGlobalData.h: Added.
        This class encapsulates all data that should be per-thread (or shared between legacy clients).
        It will also keep a Heap pointer, but right now, Heap (Collector) methods are all static.

        * kjs/identifier.h:
        (KJS::Identifier::Identifier):
        Added a constructor explicitly taking JSGlobalData to access IdentifierTable. Actually,
        all of them should, but this will be a separate patch.

        * kjs/identifier.cpp:
        (KJS::IdentifierTable::literalTable):
        (KJS::createIdentifierTable):
        (KJS::deleteIdentifierTable):
        (KJS::Identifier::add):
        (KJS::Identifier::addSlowCase):
        Combined IdentifierTable and LiteralIdentifierTable into a single class for simplicity.

        * kjs/grammar.y: kjsyyparse now takes JSGlobalData, not just a Lexer.

        * kjs/nodes.cpp:
        (KJS::Node::Node):
        (KJS::EvalFunctionCallNode::emitCode):
        (KJS::ScopeNode::ScopeNode):
        Changed to access Lexer and Parser via JSGlobalData::threadInstance(). This is also a
        temporary measure, they will need to use JSGlobalData explicitly.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::callEval):
        * kjs/CommonIdentifiers.cpp:
        (KJS::CommonIdentifiers::CommonIdentifiers):
        * kjs/CommonIdentifiers.h:
        * kjs/DebuggerCallFrame.cpp:
        (KJS::DebuggerCallFrame::evaluate):
        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        * kjs/ExecState.h:
        (KJS::ExecState::globalData):
        (KJS::ExecState::identifierTable):
        (KJS::ExecState::propertyNames):
        (KJS::ExecState::emptyList):
        (KJS::ExecState::lexer):
        (KJS::ExecState::parser):
        (KJS::ExecState::arrayTable):
        (KJS::ExecState::dateTable):
        (KJS::ExecState::mathTable):
        (KJS::ExecState::numberTable):
        (KJS::ExecState::RegExpImpTable):
        (KJS::ExecState::RegExpObjectImpTable):
        (KJS::ExecState::stringTable):
        * kjs/InitializeThreading.cpp:
        (KJS::initializeThreadingOnce):
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (KJS::JSGlobalObject::head):
        (KJS::JSGlobalObject::globalData):
        * kjs/Parser.cpp:
        (KJS::Parser::parse):
        * kjs/Parser.h:
        * kjs/function.cpp:
        (KJS::FunctionImp::getParameterName):
        (KJS::IndexToNameMap::unMap):
        (KJS::globalFuncEval):
        * kjs/function_object.cpp:
        (KJS::FunctionObjectImp::construct):
        * kjs/interpreter.cpp:
        (KJS::Interpreter::checkSyntax):
        (KJS::Interpreter::evaluate):
        * kjs/lexer.cpp:
        (kjsyylex):
        * kjs/lexer.h:
        * kjs/testkjs.cpp:
        (prettyPrintScript):
        Updated for the above changes. Most of threadInstance uses here will need to be replaced with
        explicitly passed pointers to support legacy JSC clients.

        * JavaScriptCore.exp: Removed KJS::parser().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-06 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 04:51:02 +0000 (04:51 +0000)]
2008-06-06  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19424: Add support for logging opcode pair counts
        <https://bugs.webkit.org/show_bug.cgi?id=19424>

        JavaScriptCore:

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Opcode.cpp:
        (KJS::OpcodeStats::OpcodeStats):
        (KJS::compareOpcodeIndices):
        (KJS::compareOpcodePairIndices):
        (KJS::OpcodeStats::~OpcodeStats):
        (KJS::OpcodeStats::recordInstruction):
        (KJS::OpcodeStats::resetLastInstruction):
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Sat, 7 Jun 2008 02:11:30 +0000 (02:11 +0000)]
WebCore:

2008-06-06  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Switched *.in files to XML format.

        - Added (simple) parsing facilities in make_names.pl using the XML::Tiny Perl parser.

        - Updated the build systems to include bindings/scripts when executing make_names.pl
        (for XMLTiny dependency).

        - Cleaned-up make_names.pl a little.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * bindings/scripts/XMLTiny.pm: Added.
        * dom/make_names.pl:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * svg/svgattrs.in:
        * svg/svgtags.in:
        * svg/xlinkattrs.in:
        * xml/xmlattrs.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-06 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Fri, 6 Jun 2008 22:51:19 +0000 (22:51 +0000)]
2008-06-06  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19407
        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing

        Test: fast/css/begin-end-contain-selector-empty-value.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

2008-06-06  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=19407
        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing.

        * fast/css/begin-end-contain-selector-empty-value.html: Added.
        * platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by mitz.
eric@webkit.org [Fri, 6 Jun 2008 22:09:40 +0000 (22:09 +0000)]
    Reviewed by mitz.

        More cleanup of CSSParser.
        Rename CSSParser::numParsedProperties and maxNumParsedProperites to m_*

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::rollbackLastProperties):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by mitz.
eric@webkit.org [Fri, 6 Jun 2008 22:03:41 +0000 (22:03 +0000)]
    Reviewed by mitz.

        More cleanup of CSSParser.
        Rename CSSParser::parsedProperties to m_parsedProperties.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::rollbackLastProperties):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by mitz.
eric@webkit.org [Fri, 6 Jun 2008 21:49:16 +0000 (21:49 +0000)]
    Reviewed by mitz.

        Start the cleanup of CSSParser.
        Rename CSSParser::styleElement to CSSParser::m_styleElement

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::document):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createMediaRule):
        (WebCore::CSSParser::createStyleRule):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by adele. Landed by eseidel.
eric@webkit.org [Fri, 6 Jun 2008 21:07:06 +0000 (21:07 +0000)]
    Reviewed by adele.  Landed by eseidel.

        https://bugs.webkit.org/show_bug.cgi?id=18337

        Calls listBoxOnChange() in typeAheadFind() when the <select> tag is a listBox.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::typeAheadFind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Jun 2008 20:39:49 +0000 (20:39 +0000)]
WebCore:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break

        Serialization of font-family:-webkit-monospace when it came from a
        CSSMutableStyleDeclaration would wrap the value in single quotes but
        serialization of the same property value pair from a CSSComputedStyleDeclaration
        wouldn't, which kept code that checked for and removed non-redundant styles from
        style spans from working correctly.

        A redundant style left on a style span would not normally create a rendering
        difference, but it did in this case because an element with
        font-family:-webkit-monospace does not appear to inherit font-size.
        Added a FIXME about how we might need to keep font-size on a style span if its
        non-redundant styles include font-family:-webkit-monospace, although I couldn't
        create a test case to produce this scenario.

        * css/FontFamilyValue.cpp:
        (WebCore::isValidCSSIdentifier): Don't return false if the String starts
        with a '-'.  This function now appears identical to isCSSTokenizerIdentifier,
        so perhaps we should use a single function.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added FIXME.  Removed the
        creation of two Strings that were never used.

LayoutTests:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break

        * editing/deleting/5890684-expected.txt: Added.
        * editing/deleting/5890684.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Jun 2008 17:06:57 +0000 (17:06 +0000)]
WebCore:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <https://bugs.webkit.org/show_bug.cgi?id=19087>
        Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): applyStyle
        can destroy insertedPlaceholder if it needs to move it, but it will set an
        endingSelection() at [movedPlaceholder, 0] if it does so.  Re-fetch insertedPlaceholder
        if that happens.  The long term solution for these crashes is to make moveParagraphs
        not copy/destroy/move content, and to make VisiblePositions update themselves on DOM
        mutations.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion): Early return to avoid crashes like this
        in the future, but ASSERT to catch them in debug builds.

LayoutTests:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <https://bugs.webkit.org/show_bug.cgi?id=19087>
        Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

        * editing/execCommand/19087-expected.txt: Added.
        * editing/execCommand/19087.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-06-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 6 Jun 2008 16:48:54 +0000 (16:48 +0000)]
2008-06-06  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        profiler.
        - Change the remaining functions that do not take arguments, from using
        recursion to using iteration.

        * JavaScriptCore.exp:
        * profiler/Profile.cpp:
        (KJS::stopProfiling):
        (KJS::restoreAll):
        (KJS::Profile::stopProfiling): Use foreach instead of recursion.
        (KJS::Profile::restoreAll): Ditto.
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp: Remove recursion.
        (KJS::ProfileNode::stopProfiling):
        (KJS::ProfileNode::restore):
        * profiler/ProfileNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayoutTests:
jchaffraix@webkit.org [Fri, 6 Jun 2008 14:48:59 +0000 (14:48 +0000)]
LayoutTests:

2008-06-06  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Alexey.

        xmlhttprequest-onProgress-open-should-zero-length.html supposes that the onprogress event
        is dispatched 3 times to test that the position is reset when XMLHttpRequest.open() is
        called.
        The test was failing because CoreFoundation keeps the data if they are not big enough
        (which led to only 1 progress event dispatched).

        We now generate a big response instead of a small one.

        Warning: this test is not guaranteed to succeed as we cannot guarantee that the server
                 will send responses' sizes that are close for 2 different requests to the same
                 resource.

        * http/tests/xmlhttprequest/resources/big-response.php: Added.
        * http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Removed.

        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added a
        warning about the possible failure of the test.
        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Greater and GreaterEq nodes to emit code in the correct order.
oliver@apple.com [Fri, 6 Jun 2008 05:09:27 +0000 (05:09 +0000)]
Fix Greater and GreaterEq nodes to emit code in the correct order.

Reviewed by Alexey.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Jun 2008 04:44:08 +0000 (04:44 +0000)]
WebCore:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19403>
        ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call

        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply): If the selection was all
        formatting (like an empty list) the format-less text will be empty.
        Early return to avoid the ASSERT that fires if input(...) is called
        with an empty String.

LayoutTests:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19403>
        ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call

        * editing/execCommand/19403-expected.txt: Added.
        * editing/execCommand/19403.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34399 268f45cc-cd09-0410-ab3c-d52691b4dbfc