WebKit-https.git
10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=30196
weinig@apple.com [Thu, 8 Oct 2009 05:30:13 +0000 (05:30 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=30196
Change style guidelines for indentation in header files

Reviewed by Dan Bernstein.

* coding/coding-style.html: Don't indent in a namespace in a header file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 8 Oct 2009 04:44:24 +0000 (04:44 +0000)]
2009-10-07  Simon Fraser  <simon.fraser@apple.com>

        Re-land 49269-49271 since reverting them did not fix the tests.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 8 Oct 2009 04:09:50 +0000 (04:09 +0000)]
2009-10-07  Simon Fraser  <simon.fraser@apple.com>

        Revert 49269-49271 to see if it fixes test failures on SnowLeopard that do not
        reproduce locally.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 8 Oct 2009 03:17:08 +0000 (03:17 +0000)]
2009-10-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor PolicyChecker out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30155

        Move the policy callback to the policy object.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::callPolicyFunction):
2009-10-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor PolicyChecker out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30155

        Move the policy callback to the policy object.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2009-10-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor PolicyChecker out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30155

        Move the policy callback to the policy object.

        * WebFrame.cpp:
        (WebFrame::dispatchWillSubmitForm):
        (WebFrame::receivedPolicyDecision):
        (WebFrame::dispatchDecidePolicyForMIMEType):
        (WebFrame::dispatchDecidePolicyForNewWindowAction):
        (WebFrame::dispatchDecidePolicyForNavigationAction):
2009-10-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor PolicyChecker out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30155

        Move the policy callback to the policy object.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::dispatchWillSubmitForm):
        (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForMIMEType):
        (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction):
        (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):
2009-10-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor PolicyChecker out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30155

        Move the policy callback to the policy object.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchWillSubmitForm):
        (WebFrameLoaderClient::receivedPolicyDecison):
2009-10-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor PolicyChecker out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30155

        Move the policy callback to the policy object.

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::dispatchWillSubmitForm):
        (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForMIMEType):
        (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNewWindowAction):
        (WebCore::FrameLoaderClientHaiku::dispatchDecidePolicyForNavigationAction):
2009-10-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Factor PolicyChecker out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30155

        This patch separates PolicyChecker from FrameLoader.  Loader policy is
        in change of managing the FrameLoaderClient callbacks.  Ideally, it
        shouldn't know anything about FrameLoader, but I couldn't quite remove
        all knowledge (although we might be able to do more later).  In a
        future patch, I'll move PolicyChecker into a separate file.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::loadURL):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::loadWithDocumentLoader):
        (WebCore::PolicyChecker::handleUnimplementablePolicy):
        (WebCore::PolicyChecker::cannotShowMIMEType):
        (WebCore::PolicyChecker::PolicyChecker):
        (WebCore::PolicyChecker::checkNavigationPolicy):
        (WebCore::PolicyChecker::checkContentPolicy):
        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        (WebCore::FrameLoader::stopAllLoaders):
        (WebCore::PolicyChecker::cancelCheck):
        (WebCore::PolicyChecker::stopCheck):
        (WebCore::PolicyChecker::continueAfterContentPolicy):
        (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm):
        (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
        (WebCore::FrameLoader::loadPostRequest):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::PolicyChecker::checkNewWindowPolicy):
        (WebCore::PolicyChecker::continueAfterNewWindowPolicy):
        (WebCore::PolicyChecker::continueAfterNavigationPolicy):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        * loader/FrameLoader.h:
        (WebCore::PolicyChecker::loadType):
        (WebCore::PolicyChecker::setLoadType):
        (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy):
        (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
        (WebCore::FrameLoader::policy):
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didCancel):
        (WebCore::MainResourceLoader::willSendRequest):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        (WebCore::MainResourceLoader::didReceiveResponse):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Fix layout test missing results.
aa@chromium.org [Thu, 8 Oct 2009 02:28:59 +0000 (02:28 +0000)]
Not reviewed. Fix layout test missing results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd new Windows build prerequisite: Visual Studio 2005 Service Pack 1 ATL Security...
sfalken@apple.com [Thu, 8 Oct 2009 02:04:28 +0000 (02:04 +0000)]
Add new Windows build prerequisite: Visual Studio 2005 Service Pack 1 ATL Security Update

Reviewed by Mark Rowe.

* building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix: removed no longer exported symbol.
ggaren@apple.com [Thu, 8 Oct 2009 01:52:47 +0000 (01:52 +0000)]
Windows build fix: removed no longer exported symbol.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
ggaren@apple.com [Thu, 8 Oct 2009 01:46:07 +0000 (01:46 +0000)]
JavaScriptCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Removed the optional lock from Heap::protect, Heap::unprotect, and friends,
since WebCore no longer uses it.

* JavaScriptCore.exp:
* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
* runtime/Collector.h:

WebCore: Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-07
Reviewed by Oliver Hunt.

Changed callback objects to use a standard helper object. The helper
object ASSERTs that it is deleted on the main thread, so no lock is
required when unprotecting its members. It also centralizes some previously
duplicated code.

Callback objects that might be deleted on a secondary thread use
callOnMainThread to delete their helper objects on the main thread.

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCallbackData.cpp: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.
(WebCore::JSCallbackData::deleteData):
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCallbackData.h: Copied from bindings/js/JSCustomSQLTransactionCallback.cpp.
(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):
(WebCore::JSCallbackData::callback):
* bindings/js/JSCustomPositionCallback.cpp:
(WebCore::JSCustomPositionCallback::JSCustomPositionCallback):
(WebCore::JSCustomPositionCallback::handleEvent):
* bindings/js/JSCustomPositionCallback.h:
* bindings/js/JSCustomPositionErrorCallback.cpp:
(WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback):
(WebCore::JSCustomPositionErrorCallback::handleEvent):
* bindings/js/JSCustomPositionErrorCallback.h:
* bindings/js/JSCustomSQLStatementCallback.cpp:
(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::~JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):
* bindings/js/JSCustomSQLStatementCallback.h:
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::~JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/js/JSCustomSQLStatementErrorCallback.h:
* bindings/js/JSCustomSQLTransactionCallback.cpp:
(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionCallback.h:
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::~JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionErrorCallback.h:
* bindings/js/JSCustomVoidCallback.cpp:
(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):
* bindings/js/JSCustomVoidCallback.h:
* storage/Database.cpp:
(WebCore::Database::Database):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Jens Alfke <snej@chromium.org>
jorlow@chromium.org [Thu, 8 Oct 2009 00:41:10 +0000 (00:41 +0000)]
2009-10-07  Jens Alfke  <snej@chromium.org>

        Reviewed by Dave Levin.

        Fix StringImpl::m_buffer
        https://bugs.webkit.org/show_bug.cgi?id=30189

        Fix my previous StringImpl patch to avoid using an indefinite-length array member,
        since MSVC doesn't like it. Instead, go back to offsetting by sizeof(StringImpl).

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl):
        (WebCore::StringImpl::createUninitialized):
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::bufferIsInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate isolated worlds under v8 to support world reuse.
aa@chromium.org [Thu, 8 Oct 2009 00:07:11 +0000 (00:07 +0000)]
Update isolated worlds under v8 to support world reuse.
https://bugs.webkit.org/show_bug.cgi?id=30145

Patch by Aaron Boodman <aa@chromium.org> on 2009-10-07
Reviewed by Adam Barth.

WebCore:

* bindings/v8/ScriptController.cpp:
Replace evaluateInNewIsolatedWorld() withe evaluateInIsolatedWorld(id).
(WebCore::ScriptController::evaluateInIsolatedWorld):
* bindings/v8/ScriptController.h: Ditto.
* bindings/v8/V8Proxy.cpp: Ditto.
(WebCore::V8Proxy::~V8Proxy): Dittio.
(WebCore::V8Proxy::evaluateInIsolatedWorld): Ditto.
* bindings/v8/V8Proxy.h: Ditto.
* bindings/v8/V8IsolatedWorld.cpp:
Add support for controlling lifetime of a world, rather than relying on GC.
(WebCore::V8IsolatedWorld::contextWeakReferenceCallback): Ditto.
(WebCore::V8IsolatedWorld::V8IsolatedWorld): Ditto.
(WebCore::V8IsolatedWorld::destroy): Ditto.
* bindings/v8/V8IsolatedWorld.h: Ditto.

LayoutTests:

* http/tests/security/isolatedWorld/iframe.html: Added.
* http/tests/security/isolatedWorld/world-reuse-expected.txt: Added.
* http/tests/security/isolatedWorld/world-reuse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSend title changes to the global history delegate.
beidson@apple.com [Thu, 8 Oct 2009 00:05:14 +0000 (00:05 +0000)]
Send title changes to the global history delegate.
<rdar://problem/7285293> and https://webkit.org/b/29904

Reviewed by Darin Adler.

WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setTitle):
* WebView/WebDelegateImplementationCaching.h:
* WebView/WebHistoryDelegate.h:
* WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]):

WebKitTools:

* DumpRenderTree/mac/HistoryDelegate.mm:
(-[HistoryDelegate webView:updateHistoryTitle:forURL:]):

LayoutTests:

* http/tests/globalhistory/history-delegate-basic-title-expected.txt: Added.
* http/tests/globalhistory/history-delegate-basic-title.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWell that was wrong, undo-ing previous build fix.
bweinstein@apple.com [Wed, 7 Oct 2009 23:55:04 +0000 (23:55 +0000)]
Well that was wrong, undo-ing previous build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHopefully the rest of the Windows build fix.
bweinstein@apple.com [Wed, 7 Oct 2009 23:50:21 +0000 (23:50 +0000)]
Hopefully the rest of the Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for http://trac.webkit.org/changeset/49272 on Windows
jorlow@chromium.org [Wed, 7 Oct 2009 23:33:35 +0000 (23:33 +0000)]
Build fix for trac.webkit.org/changeset/49272 on Windows

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-07
* platform/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the setMetadataURL function foolproof by having it remove user info
darin@apple.com [Wed, 7 Oct 2009 23:20:31 +0000 (23:20 +0000)]
Make the setMetadataURL function foolproof by having it remove user info
https://bugs.webkit.org/show_bug.cgi?id=30178
rdar://problem/6544670

Patch by Darin Adler <darin@apple.com> on 2009-10-07
Reviewed by John Sullivan.

* Misc/WebNSFileManagerExtras.m:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
Call _web_URLByRemovingUserInfo on the passed in URL string after converting
it to a URL, and then convert it back to a string.

* Misc/WebNSURLExtras.h: Added _web_URLByRemovingUserInfo.
* Misc/WebNSURLExtras.mm: Removed unused WebKitURLComponents struct.
(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Renamed to be
clearer on what this does.
(-[NSURL _webkit_URLByRemovingFragment]): Changed to call new name.
(-[NSURL _webkit_URLByRemovingResourceSpecifier]): Ditto.
(-[NSURL _web_URLByRemovingComponentAndSubsequentCharacter:]): Added.
(-[NSURL _web_URLByRemovingUserInfo]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Jens Alfke <snej@chromium.org>
eric@webkit.org [Wed, 7 Oct 2009 22:41:16 +0000 (22:41 +0000)]
2009-10-07  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Adler.

        Optimization of StringImpl:
        - Remove unnecessary m_bufferIsInternal member (saves 4 bytes). Instead, check whether
          m_data points to just past the end of the object's members.
        - copy() and createWithTerminatingNullCharacter() create the string in a single malloc
          block instead of 2 (saves ~20 bytes and considerable CPU cycles, increases locality).
        - Move m_length next to m_hash to save 4 bytes of padding in 64-bit builds.

        https://bugs.webkit.org/show_bug.cgi?id=29500

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl): Re-ordered members.
        (WebCore::StringImpl::~StringImpl): Change to is-buffer-internal check.
        (WebCore::StringImpl::createUninitialized): Use new m_buffer member instead of sizeof()
            to ensure chars are copied to correct location.
        (WebCore::StringImpl::createWithTerminatingNullCharacter): Make sure copy is created
            in a single malloc block.
        (WebCore::StringImpl::threadsafeCopy): Make sure copy is created in a single malloc block.
        (WebCore::StringImpl::crossThreadString): Make sure copy is created in a single malloc block.
        (WebCore::StringImpl::sharedBuffer): Change to is-buffer-internal check.
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::startsWith): Just fixed a confusing param name.
        (WebCore::StringImpl::bufferIsInternal): Changed member var into accessor method.
        (WebCore::StringImpl::m_data): Repositioned for optimal member packing in 64-bit.
        (WebCore::StringImpl::m_buffer): Added to provide an explicit location for where internal buffer goes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Oct 2009 22:41:06 +0000 (22:41 +0000)]
2009-10-07  Simon Fraser  <simon.fraser@apple.com>

        Make Dan Bernstein happy.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Oct 2009 22:38:11 +0000 (22:38 +0000)]
2009-10-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Avoid Obj-C message dispatch when possible by storing accessed objects
        in local variables.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Oct 2009 22:29:25 +0000 (22:29 +0000)]
2009-10-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Animation stalls for a few seconds partway through
        https://bugs.webkit.org/show_bug.cgi?id=30182

        Make sure that we only call -disableScreenUpdatesUntilFlush when a window
        update is actually going to happen, otherwise screen updates are disabled
        for too long.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Wed, 7 Oct 2009 22:26:48 +0000 (22:26 +0000)]
2009-10-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=30102
        And
        <rdar://problem/5015957>

        Fixes an issue (in the Windows build) where the cursor does not change to the
        not-allowed cursor when the drag-and-drop operation is not allowed.

        The allowed effects in WebDragClient::startDrag are hard-coded to be
        DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
        allowed drop effects should be determined by the allowed operations of the
        drag source.

        We cannot test this using DRT because DRT looks at the programmatic drop
        cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
        That is, there is a discrepancy in the Windows build between the Windows API-based
        drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
        to determine the cursor, a manual test is needed.

        * WebCoreSupport/WebDragClient.cpp:
        (draggingSourceOperationMaskToDragCursors): Added method.
        (WebDragClient::startDrag):
2009-10-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=30102
        And
        <rdar://problem/5015957>

        Manual test to confirm that the not-allowed cursor is shown for an
        invalid drag-and-drop operation.

        We cannot test this using DRT because of a discrepancy between the Windows
        API-based drop effect and the WebKit drop effect. See bug #24731 for more
        details.

        * manual-tests/drag-cursor-notallowed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Oct 2009 22:22:08 +0000 (22:22 +0000)]
2009-10-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Remove some folks from committers.py who were listed on
        the WebKit Team wiki page but who weren't actually listed as commit+.
        At some point, we should coorelate this list with the committers
        mailing list.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build.
mrowe@apple.com [Wed, 7 Oct 2009 22:16:40 +0000 (22:16 +0000)]
Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Oct 2009 22:10:49 +0000 (22:10 +0000)]
2009-10-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Import a bunch of committers from the WebKit Team page on
        the wiki into committers.py.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 7 Oct 2009 21:56:41 +0000 (21:56 +0000)]
2009-10-07  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Roben.

        Windows-specific baselines for some new tests.

        * platform/win/fast/css/large-number-round-trip-expected.txt: Added.
        * platform/win/fast/css/opacity-float-expected.txt: Copied from LayoutTests/fast/css/opacity-float-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Wed, 7 Oct 2009 21:55:58 +0000 (21:55 +0000)]
2009-10-07  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <http://webkit.org/b/30104>.
        Inspector should show cookies of sub-resources on the page.

        This function implements showing cookies for all sub-resources of a page.
        When the page is loaded, it populates the Storage Panel with a list of all
        domains that were loaded as part of the full page load (iframes, ads, etc).
        When the user selects one of the domains, the inspector calls back into the
        controller, and the controller combines all of the cookies from that domain
        into a list, and sends that list is sent back to the controller to render.

        A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement.

        As a result of a previous patch, we now have detailed cookie information for
        both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie
        support on Windows.

        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/js/ScriptObject.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getCookies):
        (WebCore::InspectorBackend::deleteCookie):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::getCookies):
        (WebCore::InspectorController::buildArrayForCookies):
        (WebCore::InspectorController::buildObjectForCookie):
        (WebCore::InspectorController::deleteCookie):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addCookieDomainForDocument):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.Cookies.getCookiesAsync):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        (WebInspector.StoragePanel.prototype.reset):
        (WebInspector.StoragePanel.prototype.addCookieDomain):
        (WebInspector.StoragePanel.prototype.showCookies):
        (WebInspector.CookieSidebarTreeElement):
        (WebInspector.CookieSidebarTreeElement.prototype.onselect):
        * inspector/front-end/inspector.js:
        (WebInspector.addCookieDomain):
        * platform/Cookie.h:
        (WebCore::CookieHash::hash):
        (WebCore::CookieHash::equal):
        (WTF::):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::deleteCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Pavel Feldman <pfeldman@chromium.org>
bweinstein@apple.com [Wed, 7 Oct 2009 21:50:10 +0000 (21:50 +0000)]
2009-10-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Add ScriptObject::set(const char*, unsigned).

        https://bugs.webkit.org/show_bug.cgi?id=30104

        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/v8/ScriptObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Oct 2009 21:47:41 +0000 (21:47 +0000)]
2009-10-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Added Aaron Boodman to committers.py.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for Windows (Cairo).
bfulgham@webkit.org [Wed, 7 Oct 2009 20:51:50 +0000 (20:51 +0000)]
Unreviewed build fix for Windows (Cairo).

Provide implementation of new BitmapImage::create that was
added in @r49060.

* platform/graphics/win/ImageCairoWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Andrew Scherkus <scherkus@chromium.org>
eric@webkit.org [Wed, 7 Oct 2009 20:25:00 +0000 (20:25 +0000)]
2009-10-07  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Refactor RenderThemeChromiumMac and RenderThemeChromiumSkia to render media controls using GraphicsContext.

        Design was based on existing RenderMediaControls.cpp used by RenderThemeSafari/Win.

        https://bugs.webkit.org/show_bug.cgi?id=29987

        Covered by existing layout tests as no new functionality was introduced.

        * WebCore.gypi: Added RenderMediaControlsChromium.cpp/h.
        * css/mediaControlsChromium.css: Tweaked media slider position and border style.
        * rendering/MediaControlElements.cpp:
        (WebCore::toParentMediaElement): Taken from RenderMediaControls.
        (WebCore::MediaControlElement::rendererIsNeeded): Don't call shouldRenderMediaControlPart() if element has no appearance.
        (WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
        * rendering/RenderMediaControls.cpp: Moved parentMediaElement() to MediaControlElements.
        * rendering/RenderMediaControlsChromium.cpp: Added.
        (WebCore::platformResource): Helper to load and cache media control image resources.
        (WebCore::mediaSliderThumbImage): Implementation refactored from RenderThemeChromiumMac/Skia.
        (WebCore::mediaVolumeSliderThumbImage): Ditto.
        (WebCore::paintMediaButton): Ditto.
        (WebCore::paintMediaMuteButton): Ditto.
        (WebCore::paintMediaPlayButton): Ditto.
        (WebCore::paintMediaSlider): Ditto.
        (WebCore::paintMediaSliderThumb): Ditto.
        (WebCore::paintMediaVolumeSlider): Ditto.
        (WebCore::paintMediaVolumeSliderThumb): Ditto.
        (WebCore::paintMediaTimelineContainer): Ditto.
        (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Ditto.
        (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Same
        (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
        * rendering/RenderMediaControlsChromium.h: Added.
        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): Implementation delegated to RenderMediaControlsChromium.
        (WebCore::RenderThemeChromiumMac::shouldRenderMediaControlPart): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): Ditto.
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): Implementation delegated to RenderMediaControlsChromium.
        (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Ditto.
        (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeChromiumSkia::shouldRenderMediaControlPart): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake plugins work with beforeload.
hyatt@apple.com [Wed, 7 Oct 2009 20:03:24 +0000 (20:03 +0000)]
Make plugins work with beforeload.

Reviewed by Adam Roben.

Added fast/dom/beforeload/flash-before-load.html

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoresized thumbnails
cmarrin@apple.com [Wed, 7 Oct 2009 19:10:25 +0000 (19:10 +0000)]
resized thumbnails

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=30176
sfalken@apple.com [Wed, 7 Oct 2009 18:32:35 +0000 (18:32 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30176
<rdar://problem/7281553> Extra information in UA causes problems with gmail

Reviewed by Darin Adler.

* WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoadded thumbnail images for demos
cmarrin@apple.com [Wed, 7 Oct 2009 18:20:09 +0000 (18:20 +0000)]
added thumbnail images for demos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 7 Oct 2009 18:10:26 +0000 (18:10 +0000)]
2009-10-07  Evan Martin  <evan@chromium.org>

        Reviewed by Simon Fraser.

        Add a currently-failing test exhibiting the problem in
        https://bugs.webkit.org/show_bug.cgi?id=20674:

        When converting very large or small numbers back to strings, exponential
        notation is used, so a value like 90010000px is returned from
        getComputedStyle() as 9.001e+07px.

        9.001e+07px does not parse, so such a value cannot be round-tripped.

        This is a particular problem with tranformation matrices, which can often
        contain very large or small numbers.

        (Test written by Simon Fraser; I've just made it a committable patch.)

        * fast/css/large-number-round-trip-expected.txt: Added.
        * fast/css/large-number-round-trip.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 7 Oct 2009 17:47:53 +0000 (17:47 +0000)]
2009-10-07  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        Layout test for verifying that LC_NUMERIC setting doesn't affect
        the way CSS properties are stringified.
        https://bugs.webkit.org/show_bug.cgi?id=18994

        * fast/css/opacity-float-expected.txt: Added.
        * fast/css/opacity-float.html: Added.
2009-10-07  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        Add API to LayoutTestController for re/setting the system locale.
        https://bugs.webkit.org/show_bug.cgi?id=18994

        * DumpRenderTree/LayoutTestController.cpp:
        (setLocaleCallback):
        (LayoutTestController::staticFunctions):
        (LayoutTestController::setLocale):
        * DumpRenderTree/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Wed, 7 Oct 2009 17:25:06 +0000 (17:25 +0000)]
2009-10-07  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        [V8] Protect JS listener object from GC while clearing a property on it.
        See http://crbug.com/23780.
        https://bugs.webkit.org/show_bug.cgi?id=30137

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::~V8AbstractEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Wed, 7 Oct 2009 17:09:13 +0000 (17:09 +0000)]
2009-10-07  Zoltan Horvath  <zoltan@webkit.org>

        Rubber-stamped by Eric Seidel.

        Allow custom memory allocation control for WebCore's CachedResourceClient class
        https://bugs.webkit.org/show_bug.cgi?id=30165

        Inherits CachedResourceClient class from FastAllocBase because (its
        child class) CSSFontFaceSource has been instantiated by 'new' in WebCore/css/CSSFontFaceSource.h:46.

        * loader/CachedResourceClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Wed, 7 Oct 2009 17:04:40 +0000 (17:04 +0000)]
2009-10-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for WebCore's IdentifierRep
        https://bugs.webkit.org/show_bug.cgi?id=30159

        Inherits IdentifierRep class from FastAllocBase because it has been
        instantiated by 'new' in WebCore/bridge/IdentifierRep.cpp:61.

        * bridge/IdentifierRep.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Wed, 7 Oct 2009 17:00:44 +0000 (17:00 +0000)]
2009-10-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for JavaScriptCore's IdentifierArena
        https://bugs.webkit.org/show_bug.cgi?id=30158

        Inherits IdentifierArena class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/parser/ParserArena.cpp:36.

        * parser/ParserArena.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Wed, 7 Oct 2009 16:59:07 +0000 (16:59 +0000)]
2009-10-07  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Fetch pointers to C++ DOM window immediately from holder
        object (do not search prototype chain for proper JS wrapper).
        https://bugs.webkit.org/show_bug.cgi?id=29031

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::createNewContext):
        (WebCore::V8Proxy::installDOMWindow):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::INDEXED_PROPERTY_GETTER):
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::NAMED_ACCESS_CHECK):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExport DateInstance::info in a way that works on Windows
aroben@apple.com [Wed, 7 Oct 2009 16:49:35 +0000 (16:49 +0000)]
Export DateInstance::info in a way that works on Windows

Fixes <http://webkit.org/b/30171>
fast/dom/Window/window-postmessage-clone.html fails on Windows

Reviewed by Anders Carlsson.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed the export of DateInstance::info from here.

* runtime/DateInstance.h: Use JS_EXPORTDATA to export
DateInstance::info, which is the required way of exporting data on
Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 7 Oct 2009 16:23:43 +0000 (16:23 +0000)]
2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Jan Alonzo.

        [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
        https://bugs.webkit.org/show_bug.cgi?id=29689

        Build fix by adding -lfontconfig for DumpRenderTree.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Wed, 7 Oct 2009 15:22:51 +0000 (15:22 +0000)]
2009-10-07  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Get rid of useless loadFailed signal in QGraphicsWebView
        https://bugs.webkit.org/show_bug.cgi?id=30166

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::_q_doLoadFinished):
        * Api/qgraphicswebview.h:
        * QGVLauncher/main.cpp:
        (MainWindow::init):
        (MainWindow::loadFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typo in PluginView::load that was causing cross-origin loads to be allowed
aroben@apple.com [Wed, 7 Oct 2009 15:11:49 +0000 (15:11 +0000)]
Fix typo in PluginView::load that was causing cross-origin loads to be allowed

This typo was introduced in the build fix in r49213.

Fixes <http://webkit.org/b/30168> REGRESSION (r49213):
http/tests/plugins/local-geturl-from-remote.html is failing on Windows

Reviewed by Sam Weinig.

* plugins/PluginView.cpp:
(WebCore::PluginView::load): Removed a comma operator that was making
a condition always evaluate to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
zoltan@webkit.org [Wed, 7 Oct 2009 14:53:22 +0000 (14:53 +0000)]
2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDo not create valid QColor's for invalid WebCore::Color's.
kenneth@webkit.org [Wed, 7 Oct 2009 14:06:50 +0000 (14:06 +0000)]
Do not create valid QColor's for invalid WebCore::Color's.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-07
Reviewed by Simon Hausmann.

* platform/graphics/qt/ColorQt.cpp:
(WebCore::Color::operator QColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 7 Oct 2009 12:44:02 +0000 (12:44 +0000)]
2009-10-07  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        "delete" in EventSender is the backspace key, not the delete one.

        * DumpRenderTree/gtk/EventSender.cpp:
        (keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Girish Ramakrishnan <girish@forwardbias.in>
eric@webkit.org [Wed, 7 Oct 2009 11:46:13 +0000 (11:46 +0000)]
2009-10-07  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Simon Hausmann.

        Add a simple rotation effect to QGVLauncher

        https://bugs.webkit.org/show_bug.cgi?id=30162

        * QGVLauncher/main.cpp:
        (MainView::animatedFlip):
        (MainWindow::animatedFlip):
        (MainWindow::buildUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Wed, 7 Oct 2009 10:58:16 +0000 (10:58 +0000)]
2009-10-07  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Simon Hausmann.

        [Qt] Symbian SBSv2 .data segment adress fix
        https://bugs.webkit.org/show_bug.cgi?id=30157

        RO-section in qtwebkit.dll exceeds allocated space in SBSv2. Move RW-section
        base address to start from 0x800000 instead of the toolchain default 0x400000

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen enabling or disabling the JIT through .qmake.cache, make sure
hausmann@webkit.org [Wed, 7 Oct 2009 10:45:13 +0000 (10:45 +0000)]
When enabling or disabling the JIT through .qmake.cache, make sure
to also toggle ENABLE_YARR_JIT.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

* JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDoc: Document HTML and status as properties.
hausmann@webkit.org [Wed, 7 Oct 2009 10:44:02 +0000 (10:44 +0000)]
Doc: Document HTML and status as properties.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-10-07
Reviewed by Simon Hausmann.

* Api/qgraphicswebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix qdoc warning about disabled renderHints property
hausmann@webkit.org [Wed, 7 Oct 2009 10:42:50 +0000 (10:42 +0000)]
Fix qdoc warning about disabled renderHints property
on Symbian.

Patch by Martin Smith <msmith@trolltech.com> on 2009-10-07
Reviewed by Simon Hausmann.

* Api/qwebview.cpp:
* Api/qwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 7 Oct 2009 10:36:44 +0000 (10:36 +0000)]
2009-10-07  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        getChildrenWithRange expects as last parameter the end index, not
        the length of the range. Correct this and clarify the variable
        names to reflect how the code works.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::getChildrenWithRange):
        (AccessibilityUIElement::getChildAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 7 Oct 2009 09:32:06 +0000 (09:32 +0000)]
2009-10-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Migrate database inspection to the injected script-based schema.

        https://bugs.webkit.org/show_bug.cgi?id=29788

        * bindings/js/JSInspectorBackendCustom.cpp:
        (WebCore::JSInspectorBackend::databaseForId):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8InspectorBackendCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        (WebCore::InspectorBackend::databaseForId):
        (WebCore::InspectorBackend::selectDatabase):
        (WebCore::InspectorBackend::getDatabaseTableNames):
        (WebCore::InspectorBackend::reportDidDispatchOnInjectedScript):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::selectDatabase):
        (WebCore::InspectorController::databaseForId):
        (WebCore::InspectorController::didOpenDatabase):
        (WebCore::InspectorController::didUseDOMStorage):
        (WebCore::InspectorController::selectDOMStorage):
        (WebCore::InspectorController::getDOMStorageResourceForId):
        * inspector/InspectorController.h:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorDatabaseResource.h:
        (WebCore::InspectorDatabaseResource::database):
        (WebCore::InspectorDatabaseResource::id):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addDatabase):
        (WebCore::InspectorFrontend::selectDatabase):
        (WebCore::InspectorFrontend::didGetDatabaseTableNames):
        (WebCore::InspectorFrontend::addDOMStorage):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/Database.js:
        (WebInspector.Database):
        (WebInspector.Database.prototype.get id):
        (WebInspector.Database.prototype.set name):
        (WebInspector.Database.prototype.set version):
        (WebInspector.Database.prototype.set domain):
        (WebInspector.Database.prototype.getTableNames):
        (WebInspector.Database.prototype.executeSql):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.dispatch):
        (InjectedScript.executeSql):
        (InjectedScript.executeSql.errorCallback):
        (InjectedScript.executeSql.queryTransaction):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.selectDatabase):
        (WebInspector.StoragePanel.prototype.dataGridForResult):
        * inspector/front-end/inspector.js:
        (WebInspector.addDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Wed, 7 Oct 2009 08:23:34 +0000 (08:23 +0000)]
2009-10-07  Martin Robinson  <martin.james.robinson@gmail.com>

        [GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
        https://bugs.webkit.org/show_bug.cgi?id=30121

        Clear previous preedit or pending composition before storing new ones.
        This can happen when a WebView receives a native keydown event without
        a matching keyup event or when preventDefault() is called on DOM keydown
        events.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::setPendingComposition):
        (WebKit::setPendingPreedit):
        (WebKit::clearPendingIMData):
        (WebKit::imContextCommitted):
        (WebKit::imContextPreeditChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 7 Oct 2009 07:42:23 +0000 (07:42 +0000)]
2009-10-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: default to an attached inspector window on Windows (as on Mac).

        https://bugs.webkit.org/show_bug.cgi?id=30134

WebKit/mac:
        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController showWindow:]):
WebKit/win:
        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::showWindowWithoutNotifications):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Girish Ramakrishnan <girish@forwardbias.in>
eric@webkit.org [Wed, 7 Oct 2009 07:40:05 +0000 (07:40 +0000)]
2009-10-07  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins: Disable content propagation for QGraphicsView items

        We cannot support content propagation for items in QGraphicsView because
        the contents of the backing store might be transformed. So turn it off
        if we are not painting on QWidget.

        Note that this check will not work for a QWebView in a
        QGraphicsProxyWidget, but I guess it's fine. Alternative is to do an
        even uglier cast: static_cast painter's paintDevice() to QWidget and
        check if it is the viewport() of QGraphicsView.

        https://bugs.webkit.org/show_bug.cgi?id=30149

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 7 Oct 2009 07:38:17 +0000 (07:38 +0000)]
2009-10-07  Xan Lopez  <xlopez@igalia.com>

        Skip two new tests for which we are missing results.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTidy up postMessage testcase
oliver@apple.com [Wed, 7 Oct 2009 07:17:47 +0000 (07:17 +0000)]
Tidy up postMessage testcase

Reviewed by Gavin Barraclough.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Qt build by adding the missing files to the build.
hausmann@webkit.org [Wed, 7 Oct 2009 07:15:21 +0000 (07:15 +0000)]
Fix the Qt build by adding the missing files to the build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-07
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 7 Oct 2009 07:10:59 +0000 (07:10 +0000)]
2009-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Fix incorrect convertion of double into int while assigning it to
        a float.

        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 7 Oct 2009 07:10:03 +0000 (07:10 +0000)]
2009-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Fix rounding error issues in height calculation in 64 bits.

        Already covered by existing tests.

        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 7 Oct 2009 06:20:02 +0000 (06:20 +0000)]
2009-10-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Dual lines in css2.1 layout tests do not match:
        https://bugs.webkit.org/show_bug.cgi?id=23262

        Now we can put a counter node as the next sibling of a reset node.
        Re-layout the counter content when the count is updated.

        Tests: fast/css/counters/t1204-increment-00-c-o.html
               fast/css/counters/t1204-increment-01-c-o.html

        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::recount):
        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
2009-10-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Dual lines in css2.1 layout tests do not match:
        https://bugs.webkit.org/show_bug.cgi?id=23262

        Now we can put a counter node as the next sibling of a reset node.
        Re-layout the counter content when the count is updated.

        * fast/css/counters/t1204-increment-00-c-o.html: Added.
        * fast/css/counters/t1204-increment-01-c-o.html: Added.
        * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Added.
        * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Added.
        * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
        * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Added.
        * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Added.
        * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Priit Laes <plaes@plaes.org>
eric@webkit.org [Wed, 7 Oct 2009 05:44:47 +0000 (05:44 +0000)]
2009-10-06  Priit Laes  <plaes@plaes.org>

        Reviewed by Gavin Barraclough.

        Linking fails with "relocation R_X86_64_PC32 against symbol
        `cti_vm_throw'"
        https://bugs.webkit.org/show_bug.cgi?id=28422

        * jit/JITStubs.cpp:
        Mark cti_vm_throw symbol as PLT-indirect symbol, so it doesn't end up
        in text segment causing relocation errors on amd64 architecture.
        Introduced new define SYMBOL_STRING_RELOCATION for such symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 7 Oct 2009 05:15:04 +0000 (05:15 +0000)]
2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Try to fix the GTK+ build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 7 Oct 2009 03:56:10 +0000 (03:56 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Adam Barth.

        Removed unused member variable from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30146

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoA few small/trivial tweaks to the last build fix.
levin@chromium.org [Wed, 7 Oct 2009 03:45:52 +0000 (03:45 +0000)]
A few small/trivial tweaks to the last build fix.

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (build fix).

* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows linking fix
oliver@apple.com [Wed, 7 Oct 2009 03:16:59 +0000 (03:16 +0000)]
Windows linking fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Need to adjust MessagePort, etc. code for the post clone work done.
levin@chromium.org [Wed, 7 Oct 2009 03:07:19 +0000 (03:07 +0000)]
[Chromium] Need to adjust MessagePort, etc. code for the post clone work done.
https://bugs.webkit.org/show_bug.cgi?id=30147

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Dimitri Glazkov.

No change in functionality so no new tests.

* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/SerializedScriptValue.h: Added.
 A very simple implementation of SerializedScriptValue
 that only works for strings.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/7271202>
weinig@apple.com [Wed, 7 Oct 2009 02:48:12 +0000 (02:48 +0000)]
Fix for <rdar://problem/7271202>
Dispatch resource load delegate functions for the media element.
Since we don't get the required callbacks from the media engine,
just fake the parameters to the delegate functions as best as possible.

Reviewed by Brady Eidson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL):
* loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
oliver@apple.com [Wed, 7 Oct 2009 02:39:30 +0000 (02:39 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
oliver@apple.com [Wed, 7 Oct 2009 02:29:15 +0000 (02:29 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild and formatting fix.
oliver@apple.com [Wed, 7 Oct 2009 02:21:49 +0000 (02:21 +0000)]
Build and formatting fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIt should be possible to post (clone) built-in JS objects to Workers
oliver@apple.com [Wed, 7 Oct 2009 02:06:03 +0000 (02:06 +0000)]
It should be possible to post (clone) built-in JS objects to Workers
https://bugs.webkit.org/show_bug.cgi?id=22878

Reviewed by Gavin Barraclough.

Implement object cloning semantics for postMessage.  Currently only
a partial implementation of the spec -- cloning of File, FileList,
ImageData, and RegExp were left out as they would have significantly
increased patch size.

Cloning requires multiple tree walks so we use a templated tree
walk function, allowing us to share a single implementation for
serialization, deserialization, and eventual destruction of the
serialized object tree.

Test: fast/dom/Window/window-postmessage-clone.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Oct 2009 01:28:55 +0000 (01:28 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix for Windows.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 7 Oct 2009 01:14:23 +0000 (01:14 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move FrameLoader::canLoad to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30111

        * WebCore.base.exp:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::isSafeToLoadURL):
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadSubframe):
        (WebCore::FrameLoader::loadPlugin):
        (WebCore::FrameLoader::loadFrameRequest):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::createJavaAppletWidget):
        * loader/FrameLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canLoad):
        (WebCore::SecurityOrigin::shouldHideReferrer):
        * page/SecurityOrigin.h:
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move FrameLoader::canLoad to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30111

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * Plugins/WebPluginContainerCheck.mm:
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebView/WebFrame.mm:
        (-[WebFrame _allowsFollowingLink:]):
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move FrameLoader::canLoad to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30111

        * WebFrame.cpp:
        (WebFrame::allowsFollowingLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 7 Oct 2009 01:05:05 +0000 (01:05 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move setLocalLoadPolicy and friends to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30110

        These have more to do with security policies than with loading frames.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::setLocalLoadPolicy):
        (WebCore::SecurityOrigin::restrictAccessToLocal):
        (WebCore::SecurityOrigin::allowSubstituteDataAccessToLocal):
        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::):
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move setLocalLoadPolicy and friends to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30110

        Call the new API.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move setLocalLoadPolicy and friends to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30110

        Call the new API.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 6 Oct 2009 22:48:58 +0000 (22:48 +0000)]
2009-10-06  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Brady Eidson.

        Preparation for <http://webkit.org/b/30104>.
        Inspector should show cookies of sub-resources on the page.

        Implement getRawCookies for CFNetwork for Windows, so we can see more
        than just a key/value pair for Cookies when we are on Windows.

        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::getRawCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jeremy Orlow <jorlow@chromium.org>
eric@webkit.org [Tue, 6 Oct 2009 22:26:36 +0000 (22:26 +0000)]
2009-10-06  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Diagram needs to be linked from the home page
        https://bugs.webkit.org/show_bug.cgi?id=30142

        http://webkit.org/coding/major-objects.html was never linked from the home
        page.

        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with...
hyatt@apple.com [Tue, 6 Oct 2009 22:26:08 +0000 (22:26 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with <link> elements and
XML processing instructions.

Reviewed by Adam Roben.

Fix up ProcessingInstruction's setData call so that it actually updates a stylesheet when the
data gets changed.

Move dispatchBeforeLoadedEvent to ContainerNode so all Elements (and ProcessingInstruction) can
access it.

Added fast/dom/beforeload/link-before-load.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::dispatchBeforeLoadEvent):
* dom/ContainerNode.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::setData):
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::requestScript):
* dom/ScriptElement.h:
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::endElementNs):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::forAttributeValue):
* html/HTMLScriptElement.h:
* svg/SVGScriptElement.cpp:
* svg/SVGScriptElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with CSS stylesheets loaded from
<link> elements and XML processing instructions.

Reviewed by Adam Roben.

* fast/dom/beforeload/link-before-load-expected.txt: Added.
* fast/dom/beforeload/link-before-load.html: Added.
* fast/dom/beforeload/pi-before-load-expected.txt: Added.
* fast/dom/beforeload/pi-before-load.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTool...
mrowe@apple.com [Tue, 6 Oct 2009 21:08:23 +0000 (21:08 +0000)]
<webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH

Reviewed by Simon Fraser.

* Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
the fact we have already changed the working directory to the top of the open source tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 20:47:58 +0000 (20:47 +0000)]
2009-10-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        accessibility/media-element.html crashes (and has incorrect result)
        https://bugs.webkit.org/show_bug.cgi?id=30108

        Fix up the accessibilty label for the newly added fullscreen button,
        and update the test result accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
jparent@chromium.org [Tue, 6 Oct 2009 20:10:11 +0000 (20:10 +0000)]
Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
rather than my committer email.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-06
* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Kelly Norton <knorton@google.com>
eric@webkit.org [Tue, 6 Oct 2009 19:56:59 +0000 (19:56 +0000)]
2009-10-06  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=30028>
        Multiple calls to SetFrontendProxyObject can leave an InspectorTimelineAgent with an invalid
        InspectorFrontend.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontendProxyObject): Adds a check for an existing timeline agent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 6 Oct 2009 19:14:39 +0000 (19:14 +0000)]
2009-10-06  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30107

        Fixes an issue where the Mac build does return the correct drop effect
        with respect to the HTML 5 specification when effectAllowed == "none".

        Currently, when effectAllowed == "none" and dropEffect == "copy" or
        dropEffect == "move" the resulting drop effect is "copy" and "move",
        respectively. However, the HTML 5 specification states that regardless
        of the specified dropEffect, when effectAllowed == "none" the resulting
        drop effect should be "none".

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
2009-10-06  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30107

        Tests that drag-and-drop returns dropEffect = "none" when
        effectAllowed == "none", regardless of the user-specified
        drop effect.

        * fast/events/drag-and-drop-none-expected.txt: Added.
        * fast/events/drag-and-drop-none.html: Added.
        * platform/win/Skipped: This test does not work under
        Windows. We need the fix for bug #24731.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove textRects to the right category in DOM.mm. Include DOMPrivate.h to ensure that...
antti@apple.com [Tue, 6 Oct 2009 19:13:55 +0000 (19:13 +0000)]
Move textRects to the right category in DOM.mm. Include DOMPrivate.h to ensure that the interfaces match.

Reviewed by Dave Kilzer.

* bindings/objc/DOM.mm:
(-[DOMNode textRects]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Benjamin C Meyer <bmeyer@rim.com>
eric@webkit.org [Tue, 6 Oct 2009 19:02:44 +0000 (19:02 +0000)]
2009-10-06  Benjamin C Meyer  <bmeyer@rim.com>

        Reviewed by Ariya Hidayat.

        Match the behavior of other WebKit browser and have the first url of the drag data be the url passed in declareAndWriteDragImage and set the text of the drag data to be the title argument.

        Manual test: Drag the readability js link from http://lab.arc90.com/experiments/readability/

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Benjamin C Meyer <bmeyer@rim.com>
eric@webkit.org [Tue, 6 Oct 2009 18:55:17 +0000 (18:55 +0000)]
2009-10-06  Benjamin C Meyer  <bmeyer@rim.com>

        Reviewed by Ariya Hidayat.

        When the drag data contains an image set it on the QDrag so it will be visible to the user.

        * WebCoreSupport/DragClientQt.cpp:
        (WebCore::DragClientQt::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 6 Oct 2009 18:47:21 +0000 (18:47 +0000)]
2009-10-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement min/max attributes, ValidityState.rangeUnderflow and
        ValidityState.rangeOverflow for <input type=number> and <input type=range>
        https://bugs.webkit.org/show_bug.cgi?id=29069

        * fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-number.html: Added.
        * fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-range.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-number.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-range.html: Added.
        * fast/forms/input-minmax-expected.txt: Added.
        * fast/forms/input-minmax.html: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
        * fast/forms/script-tests/input-minmax.js: Added.
2009-10-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement min/max attributes, ValidityState.rangeUnderflow and
        ValidityState.rangeOverflow for <input type=number> and <input type=range>
        https://bugs.webkit.org/show_bug.cgi?id=29069

        HTMLInputElement::max and min are not defined for COM because they
        conflict with the standard min() and max() macros.

        Tests: fast/forms/ValidityState-rangeOverflow-number.html
               fast/forms/ValidityState-rangeOverflow-range.html
               fast/forms/ValidityState-rangeUnderflow-number.html
               fast/forms/ValidityState-rangeUnderflow-range.html
               fast/forms/input-minmax.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rangeUnderflow):
        (WebCore::HTMLInputElement::rangeOverflow):
        (WebCore::HTMLInputElement::rangeMinimum):
        (WebCore::HTMLInputElement::rangeMaximum):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * html/ValidityState.cpp:
        (WebCore::ValidityState::rangeUnderflow):
        (WebCore::ValidityState::rangeOverflow):
        * html/ValidityState.h:
        * rendering/RenderSlider.cpp:
        (WebCore::SliderRange::SliderRange):
        (WebCore::SliderRange::valueFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 6 Oct 2009 18:29:24 +0000 (18:29 +0000)]
2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Skip new tests for which we are missing expected results.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 18:27:59 +0000 (18:27 +0000)]
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().

        r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
        it after each layout test as it should do, making the DRT dump additional output
        for all of the subsequent layout tests.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 6 Oct 2009 18:20:33 +0000 (18:20 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move m_openedByDOM to Page
        https://bugs.webkit.org/show_bug.cgi?id=30109

        We only need one instance of m_openedByDOM per page, we should move it
        to a page-scoped object.  Notice that it's only ever touched for the
        main frame.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::createWindow):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::createWindow):
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::close):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::openedByDOM):
        (WebCore::Page::setOpenedByDOM):
        * page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Tue, 6 Oct 2009 17:49:39 +0000 (17:49 +0000)]
2009-10-06  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Some functions in GraphicsContext do not work
        as expected if the associated painter has no clipping.
        https://bugs.webkit.org/show_bug.cgi?id=29691

        No new tests are associated with this because DumpRenderTree
        always sets clipping on the painter, thus it would never hit
        the test case, but fast/box-shadow/basic-shadows.html is a
        good example of what happens if the clipping is not set by
        the user of QtWebKit.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        Fixed to handle the case that there is no clipping
        before the call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=30131, make beforeload fire on script elements.
hyatt@apple.com [Tue, 6 Oct 2009 17:37:48 +0000 (17:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30131, make beforeload fire on script elements.

Reviewed by Adam Roben.

WebCore:

Added tests in fast/dom/beforeload/.

* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::requestScript):
* dom/ScriptElement.h:
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::endElementNs):
* html/HTMLAttributeNames.in:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::dispatchBeforeLoadEvent):
* html/HTMLScriptElement.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptHandler):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::dispatchBeforeLoadEvent):
* svg/SVGScriptElement.h:

LayoutTests:

* fast/dom/beforeload: Added.
* fast/dom/beforeload/resources: Added.
* fast/dom/beforeload/script-before-load-dynamic-expected.txt: Added.
* fast/dom/beforeload/script-before-load-dynamic.html: Added.
* fast/dom/beforeload/script-before-load-expected.txt: Added.
* fast/dom/beforeload/script-before-load-xhtml-expected.txt: Added.
* fast/dom/beforeload/script-before-load-xhtml.xhtml: Added.
* fast/dom/beforeload/script-before-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
xan@webkit.org [Tue, 6 Oct 2009 17:24:37 +0000 (17:24 +0000)]
WebCore:

2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25526
        [Gtk] Additional support is needed for caret browsing

        Enable caret movement commands also when caret browsing setting is
        enabled.

        * editing/EditorCommand.cpp:
        (WebCore::caretBrowsingEnabled):
        (WebCore::enabledVisibleSelectionOrCaretBrowsing):
        (WebCore::enabledInEditableTextOrCaretBrowsing):
        (WebCore::CommandEntry::):
        * manual-tests/gtk/caret-browsing.html: Added.

WebKit/gtk:

2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25526
        [Gtk] Additional support is needed for caret browsing

        Remove special cases for caret browsing, they are now handled in
        cross-platform code.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 17:24:26 +0000 (17:24 +0000)]
2009-10-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk][Layout tests] Generate results for editing tests
        https://bugs.webkit.org/show_bug.cgi?id=30061

        Add results for editing tests and enable these tests in the Skipped.
        Also moves some improperly placed tests to the 'failing' section.

        * platform/gtk/Skipped:
        * platform/gtk/editing/deleting/4922367-expected.txt: Added.
        * platform/gtk/editing/deleting/5026848-1-expected.txt: Added.
        * platform/gtk/editing/deleting/5026848-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5026848-3-expected.txt: Added.
        * platform/gtk/editing/deleting/5032066-expected.txt: Added.
        * platform/gtk/editing/deleting/5091898-expected.txt: Added.
        * platform/gtk/editing/deleting/5099303-expected.txt: Added.
        * platform/gtk/editing/deleting/5115601-expected.txt: Added.
        * platform/gtk/editing/deleting/5126166-expected.txt: Added.
        * platform/gtk/editing/deleting/5156801-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5206311-1-expected.txt: Added.
        * platform/gtk/editing/deleting/5206311-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5272440-expected.txt: Added.
        * platform/gtk/editing/deleting/5369009-expected.txt: Added.
        * platform/gtk/editing/deleting/5390681-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5390681-expected.txt: Added.
        * platform/gtk/editing/deleting/5433862-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5483370-expected.txt: Added.
        * platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3608430-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3608445-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3608462-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3775172-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3800834-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-and-undo-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-contents-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-contents-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-contents-003-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-003-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-004-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-005-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-006-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-007-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-010-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-013-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-image-004-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-005-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-006-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-007-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-008-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-009-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-010-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-011-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-012-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-013-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-014-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-listitem-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-listitem-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-select-all-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-tab-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-tab-004-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-to-select-table-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
        * platform/gtk/editing/deleting/forward-delete-expected.txt: Added.
        * platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt: Added.
        * platform/gtk/editing/deleting/move-nodes-001-expected.txt: Added.
        * platform/gtk/editing/deleting/type-delete-after-quote-expected.txt: Added.
        * platform/gtk/editing/execCommand/4580583-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/4580583-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/4747450-expected.txt: Added.
        * platform/gtk/editing/execCommand/4786404-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/4786404-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/4916402-expected.txt: Added.
        * platform/gtk/editing/execCommand/4916541-expected.txt: Added.
        * platform/gtk/editing/execCommand/4920488-expected.txt: Added.
        * platform/gtk/editing/execCommand/4920742-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/4924441-expected.txt: Added.
        * platform/gtk/editing/execCommand/5049671-expected.txt: Added.
        * platform/gtk/editing/execCommand/5080333-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/5080333-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/5136770-expected.txt: Added.
        * platform/gtk/editing/execCommand/5138441-expected.txt: Added.
        * platform/gtk/editing/execCommand/5142012-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/5142012-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/5190926-expected.txt: Added.
        * platform/gtk/editing/execCommand/5481523-expected.txt: Added.
        * platform/gtk/editing/execCommand/5482023-expected.txt: Added.
        * platform/gtk/editing/execCommand/5569741-expected.txt: Added.
        * platform/gtk/editing/execCommand/5573879-expected.txt: Added.
        * platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Added.
        * platform/gtk/editing/inserting/12882-expected.txt: Added.
        * platform/gtk/editing/inserting/4840662-expected.txt: Added.
        * platform/gtk/editing/inserting/4875189-1-expected.txt: Added.
        * platform/gtk/editing/inserting/4875189-2-expected.txt: Added.
        * platform/gtk/editing/inserting/4959067-expected.txt: Added.
        * platform/gtk/editing/inserting/4960120-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5002441-expected.txt: Added.
        * platform/gtk/editing/inserting/5058163-1-expected.txt: Added.
        * platform/gtk/editing/inserting/5058163-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5156401-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5418891-expected.txt: Added.
        * platform/gtk/editing/inserting/5510537-expected.txt: Added.
        * platform/gtk/editing/inserting/5549929-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5549929-3-expected.txt: Added.
        * platform/gtk/editing/inserting/6633727-expected.txt: Added.
        * platform/gtk/editing/inserting/6703873-expected.txt: Added.
        * platform/gtk/editing/inserting/editable-inline-element-expected.txt: Added.
        * platform/gtk/editing/inserting/edited-whitespace-1-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3654864-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3775316-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3800346-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3851164-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-after-delete-001-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-bg-font-expected.txt.
        * platform/gtk/editing/inserting/insert-br-005-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-001-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-002-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-003-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-004-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-005-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-009-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-024-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Added.
        * platform/gtk/editing/inserting/redo-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-001-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-002-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-003-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-around-br-001-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-around-image-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/4076267-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/4076267-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/4076267-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5032095-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5071074-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5075944-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5089327-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5134759-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5156401-1-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5387578-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5483567-expected.txt: Added.
        * platform/gtk/editing/pasteboard/7955-expected.txt: Added.
        * platform/gtk/editing/pasteboard/cut-text-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-table-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-004-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-005-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-007-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-008-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-009-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-xml-expected.txt: Added.
        * platform/gtk/editing/pasteboard/select-element-1-expected.txt: Added.
        * platform/gtk/editing/selection/13804-expected.txt: Added.
        * platform/gtk/editing/selection/14971-expected.txt: Added.
        * platform/gtk/editing/selection/4818145-expected.txt: Added.
        * platform/gtk/editing/selection/4866671-expected.txt: Added.
        * platform/gtk/editing/selection/4889598-expected.txt: Added.
        * platform/gtk/editing/selection/4895428-2-expected.txt: Added.
        * platform/gtk/editing/selection/4960116-expected.txt: Added.
        * platform/gtk/editing/selection/4960137-expected.txt: Added.
        * platform/gtk/editing/selection/4983858-expected.txt: Added.
        * platform/gtk/editing/selection/5007143-2-expected.txt: Added.
        * platform/gtk/editing/selection/5007143-expected.txt: Added.
        * platform/gtk/editing/selection/5057506-2-expected.txt: Added.
        * platform/gtk/editing/selection/5057506-expected.txt: Added.
        * platform/gtk/editing/selection/5076323-1-expected.txt: Added.
        * platform/gtk/editing/selection/5076323-2-expected.txt: Added.
        * platform/gtk/editing/selection/5076323-3-expected.txt: Added.
        * platform/gtk/editing/selection/5081257-1-expected.txt: Added.
        * platform/gtk/editing/selection/5081257-2-expected.txt: Added.
        * platform/gtk/editing/selection/5099303-expected.txt: Added.
        * platform/gtk/editing/selection/5109817-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-1-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-2-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-3-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-4-expected.txt: Added.
        * platform/gtk/editing/selection/5232159-expected.txt: Added.
        * platform/gtk/editing/selection/5234383-1-expected.txt: Added.
        * platform/gtk/editing/selection/5234383-2-expected.txt: Added.
        * platform/gtk/editing/selection/5333725-expected.txt: Added.
        * platform/gtk/editing/selection/5354455-1-expected.txt: Added.
        * platform/gtk/editing/selection/5354455-2-expected.txt: Added.
        * platform/gtk/editing/selection/addRange-expected.txt: Added.
        * platform/gtk/editing/selection/drag-in-iframe-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-002-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-003-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-004-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-005-expected.txt: Added.
        * platform/gtk/editing/selection/fake-drag-expected.txt: Added.
        * platform/gtk/editing/selection/iframe-expected.txt: Added.
        * platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt: Added.
        * platform/gtk/editing/selection/inline-table-expected.txt: Added.
        * platform/gtk/editing/selection/mixed-editability-6-expected.txt: Added.
        * platform/gtk/editing/selection/mixed-editability-7-expected.txt: Added.
        * platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-002-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-003-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-004-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-005-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-sentence-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt: Added.
        * platform/gtk/editing/selection/move-past-trailing-space-expected.txt: Added.
        * platform/gtk/editing/selection/select-box-expected.txt: Added.
        * platform/gtk/editing/selection/selectNode-expected.txt: Added.
        * platform/gtk/editing/selection/selectNodeContents-expected.txt: Added.
        * platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt: Added.
        * platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt: Added.
        * platform/gtk/editing/spelling/spelling-expected.txt: Added.
        * platform/gtk/editing/spelling/spelling-linebreak-expected.txt: Added.
        * platform/gtk/editing/style/4916887-expected.txt: Added.
        * platform/gtk/editing/style/5017613-1-expected.txt: Added.
        * platform/gtk/editing/style/5017613-2-expected.txt: Added.
        * platform/gtk/editing/style/5046875-1-expected.txt: Added.
        * platform/gtk/editing/style/5046875-2-expected.txt: Added.
        * platform/gtk/editing/style/5084241-expected.txt: Added.
        * platform/gtk/editing/style/5228141-expected.txt: Added.
        * platform/gtk/editing/style/5279521-expected.txt: Added.
        * platform/gtk/editing/style/block-style-003-expected.txt: Added.
        * platform/gtk/editing/style/fontsize-1-expected.txt: Added.
        * platform/gtk/editing/style/highlight-expected.txt: Added.
        * platform/gtk/editing/style/relative-font-size-change-001-expected.txt: Added.
        * platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Added.
        * platform/gtk/editing/style/style-3681552-fix-002-expected.txt: Added.
        * platform/gtk/editing/style/style-3690704-fix-expected.txt: Added.
        * platform/gtk/editing/style/typing-style-001-expected.txt: Added.
        * platform/gtk/editing/style/typing-style-002-expected.txt: Added.
        * platform/gtk/editing/style/typing-style-003-expected.txt: Added.
        * platform/gtk/editing/style/unbold-in-bold-expected.txt: Added.
        * platform/gtk/editing/undo/4063751-expected.txt: Added.
        * platform/gtk/editing/undo/5378473-expected.txt: Added.
        * platform/gtk/editing/undo/redo-typing-001-expected.txt: Added.
        * platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt: Added.
        * platform/gtk/editing/undo/undo-combined-delete-expected.txt: Added.
        * platform/gtk/editing/undo/undo-delete-boundary-expected.txt: Added.
        * platform/gtk/editing/undo/undo-delete-expected.txt: Added.
        * platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt: Added.
        * platform/gtk/editing/undo/undo-forward-delete-expected.txt: Added.
        * platform/gtk/editing/undo/undo-misspellings-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Anton Muhin <antonm@chromium>
eric@webkit.org [Tue, 6 Oct 2009 17:15:22 +0000 (17:15 +0000)]
2009-10-06  Anton Muhin  <antonm@chromium>

        Reviewed by Dimitri Glazkov.

        Non standard, but popular exetension allows automagically
        turn a function into a namespace resolver.  Support that in
        Chromium as well.

        This adds new layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=30128

        * fast/xpath/xpath-namespaces-expected.txt:
        * fast/xpath/xpath-namespaces.html:
2009-10-06  Anton Muhin  <antonm@chromium>

        Reviewed by Dimitri Glazkov.

        Non standard, but popular exetension allows automagically
        turn a function into a namespace resolver.  Support that in
        Chromium as well.

        Adjust CodeGeneratorV8 to treat XPathNSResolver in a special way.
        https://bugs.webkit.org/show_bug.cgi?id=30128

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::getXPathNSResolver):
        * bindings/v8/custom/V8DocumentCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 6 Oct 2009 15:48:52 +0000 (15:48 +0000)]
2009-10-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: close inspector client view on
        InspectorController::close API call.

        In order to run batch web inspector layout tests (and not affect
        subsequent tests) we should close inspector client's view upon
        InspectorController::close API call.

        https://bugs.webkit.org/show_bug.cgi?id=30009

WebCore:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::close):
WebKit/gtk:
        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::createPage):
WebKit/mac:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::createPage):
WebKit/qt:
        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::createPage):
WebKit/win:
        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::createPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 15:34:54 +0000 (15:34 +0000)]
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
        fast/dom/assign-to-window-status.html test, which is passing as a result.

        https://bugs.webkit.org/show_bug.cgi?id=30127

        * platform/qt/Skipped:
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
        fast/dom/assign-to-window-status.html test, which is passing as a result.

        https://bugs.webkit.org/show_bug.cgi?id=30127

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::statusBarMessage):
        * DumpRenderTree/qt/DumpRenderTree.h:
        * DumpRenderTree/qt/jsobjects.h:
        (LayoutTestController::shouldDumpStatusCallbacks):
        (LayoutTestController::dumpStatusCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Tue, 6 Oct 2009 15:27:30 +0000 (15:27 +0000)]
2009-10-06  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Simon Hausmann.

        [Qt] don't enable input methods on Symbian by default.
        https://bugs.webkit.org/show_bug.cgi?id=30117

        If input methods are enabled Symbian FEP will be launched on every
        pointer event making webpage navigation impossible with QWebView.

        * Api/qwebview.cpp:
        (QWebView::QWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49188 268f45cc-cd09-0410-ab3c-d52691b4dbfc