WebKit-https.git
9 years ago2010-09-29 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 29 Sep 2010 20:56:32 +0000 (20:56 +0000)]
2010-09-29  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Simon Fraser.

        CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
        https://bugs.webkit.org/show_bug.cgi?id=46777

        It should not be possible to get to be in the LoadingFromSourceElement
        state with a null current source node. This was a possible scenario
        where the current source node was cleared but the load state was not
        cleared as well. Tried and could not create a test case for this.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logic...
hyatt@apple.com [Wed, 29 Sep 2010 20:12:41 +0000 (20:12 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights.  Rename stretchesToViewHeight.

Reviewed by Dan Bernstein.

* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewport):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights.

Reviewed by Dan Bernstein.

* platform/mac/fast/blockflow/root-lr-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: implement CSS3 Speech "speak"
cfleizach@apple.com [Wed, 29 Sep 2010 19:59:56 +0000 (19:59 +0000)]
AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827

Reviewed by Darin Adler.

WebCore:

Support the "speak" style as defined in
http://www.w3.org/TR/css3-speech/#speak

This puts all the pieces in place for a platform to support this ability, but there's no platform implementation yet.

Test: platform/mac/accessibility/css-speech-speak.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::speakProperty):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::speakProperty):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ESpeak):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::speak):
(WebCore::InheritedFlags::setSpeak):
(WebCore::InheritedFlags::initialSpeak):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(speakCallback):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::speak):

LayoutTests:

* platform/mac/accessibility/css-speech-speak-expected.txt: Added.
* platform/mac/accessibility/css-speech-speak.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>
commit-queue@webkit.org [Wed, 29 Sep 2010 19:33:16 +0000 (19:33 +0000)]
2010-09-29  João Paulo Rechi Vita  <jprvita@profusion.mobi>

        Reviewed by Antonio Gomes.

        [Curl] Fix unused and unitialized warnings.
        https://bugs.webkit.org/show_bug.cgi?id=46831

        No new tests since no new funcionality has been added.

        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::allowsAnyHTTPSCertificateHosts):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::ResourceHandleManager):
        (WebCore::handleLocalReceiveResponse):
        (WebCore::ResourceHandleManager::downloadTimerCallback):
        (WebCore::ResourceHandleManager::initializeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46824
hyatt@apple.com [Wed, 29 Sep 2010 19:32:40 +0000 (19:32 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46824

Reviewed by Sam Weinig.

Convert layoutBlockChild (but not the functions it calls) to be block-flow-aware.

fast/blockflow/root-lr.html progresses as a result of this change.

WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
* rendering/RenderBox.h:

LayoutTests:

* platform/mac/fast/blockflow/root-lr-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement LoadURL
andersca@apple.com [Wed, 29 Sep 2010 19:17:33 +0000 (19:17 +0000)]
Implement LoadURL
https://bugs.webkit.org/show_bug.cgi?id=46826

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentCoders.h:
Move String argument coder here from WebCoreArgumentCoders.h. Add
argument coder for AtomicString.

* Platform/CoreIPC/Arguments.h:
Add typedefs for Arguments7.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Add handleMessage overload that takes 7 parameters.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::loadURL):
Send the LoadURL message.

* Scripts/webkit2/messages.py:
(parse_parameter_string): Use rsplit in case the type name contains spaces.
(argument_coder_headers_for_type): Special case Vector.

* Scripts/webkit2/messages_unittest.py:
Update results.

* Shared/WebCoreArgumentCoders.h:
Add argument coder for HTTPHeaderMap.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::loadURL):
Ask the plug-in controller to load the URL.

* WebProcess/Plugins/PluginProxy.messages.in:
Add LoadURL message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 29 Sep 2010 19:12:25 +0000 (19:12 +0000)]
2010-09-29  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations fix.

        [CHROMIUM] Update test_expectations to better reflect the state of the
        build.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 29 Sep 2010 19:08:30 +0000 (19:08 +0000)]
2010-09-29  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed, adding one more missing change from the last patch.
        https://bugs.webkit.org/show_bug.cgi?id=46524

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 29 Sep 2010 19:08:23 +0000 (19:08 +0000)]
2010-09-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        Avoid touching the po files automatically during the build
        process. The maintainers still have the option of forcing an
        update with make update-po.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Sep 2010 19:07:40 +0000 (19:07 +0000)]
2010-09-29  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Record bot ID when updating queue status
        https://bugs.webkit.org/show_bug.cgi?id=46764

        Since we now have multiple bots handling patches from the commit queue,
        we need to differentiate status updates from them, so that we can group
        the queue status page in a less confusing way.

        * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
        * QueueStatusServer/model/queuestatus.py: Add bot_id property
        * QueueStatusServer/templates/updatestatus.html: Add bot_id input
        * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
        * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
        * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
        * Scripts/webkitpy/tool/main.py: Add --bot-id
        * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 29 Sep 2010 19:04:55 +0000 (19:04 +0000)]
2010-09-29  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed, adding the new files that were supposed to be added
        but I missed to include in my previous patch.
        https://bugs.webkit.org/show_bug.cgi?id=46524

        * src/WorkerAsyncFileSystemChromium.cpp: Added.
        * src/WorkerAsyncFileSystemChromium.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed reviewer names.
rniwa@webkit.org [Wed, 29 Sep 2010 18:47:41 +0000 (18:47 +0000)]
Fixed reviewer names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 29 Sep 2010 18:44:02 +0000 (18:44 +0000)]
2010-09-29  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue "formatBlock" always returns false
        https://bugs.webkit.org/show_bug.cgi?id=21305

        Implemented queryCommandValue('formatBlock'). We match the Firefox's behavior exactly
        because Firefox and Internet Explorer support the same set of elements
        (address, h1, h2, h3, h4, h5, h6, and p) and Firefox's behavior is more compatible with Opera.
        See the bug for the detailed discussion.

        WebKit's implementation returns the local name of the lowest common ancestor
        of the selection with the tag name address, h1, h2, h3, h4, h5, h6, or p.
        It returns "" when there is no such an ancestor or there is no selection.

        Test: editing/execCommand/query-format-block.html

        * editing/Editor.cpp:
        (WebCore::isElementForFormatBlockCommand):
        (WebCore::Editor::elementForFormatBlockCommand):
        * editing/Editor.h:
        * editing/EditorCommand.cpp:
        (WebCore::valueFormatBlock):
        (WebCore::createCommandMap):
2010-09-29  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue "formatBlock" always returns false
        https://bugs.webkit.org/show_bug.cgi?id=21305

        Added a test for queryCommandValue('formatBlock').

        * editing/execCommand/query-format-block-expected.txt: Added.
        * editing/execCommand/query-format-block.html: Added.
        * editing/execCommand/script-tests/query-format-block.js: Added.
        (queryFormatBlock):
        (selectFirstPosition):
        (selectMiddleOfHelloWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 29 Sep 2010 18:12:36 +0000 (18:12 +0000)]
2010-09-29  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Bridge all FileSystem operations on Workers to the MainThread
        https://bugs.webkit.org/show_bug.cgi?id=46524

        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::requestFileSystem): Changed the worker case
        code to create WebFileSystemCallbacksImpl with the current
        ScriptExecutionContext (WorkerContext).
        * src/WebFileSystemCallbacksImpl.cpp:
        (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): Added
        a new constructor that takes ScriptExecutionContext (WorkerContext)
        for workers.
        (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem): Added the
        code for workers that creates WorkerAsyncFileSystemChromium.
        * src/WebFileSystemCallbacksImpl.h:
        * src/WorkerAsyncFileSystemChromium.cpp: Added.
        * src/WorkerAsyncFileSystemChromium.h: Added.
        * src/WorkerFileSystemCallbacksBridge.cpp: Added methods for regular
        file system operations to proxy them to the main thread.
        (WebKit::WorkerFileSystemCallbacksBridge::createForOpenFileSystem):
        (WebKit::WorkerFileSystemCallbacksBridge::createForMove):
        (WebKit::WorkerFileSystemCallbacksBridge::createForCopy):
        (WebKit::WorkerFileSystemCallbacksBridge::createForRemove):
        (WebKit::WorkerFileSystemCallbacksBridge::createForReadMetadata):
        (WebKit::WorkerFileSystemCallbacksBridge::createForCreateFile):
        (WebKit::WorkerFileSystemCallbacksBridge::createForCreateDirectory):
        (WebKit::WorkerFileSystemCallbacksBridge::createForFileExists):
        (WebKit::WorkerFileSystemCallbacksBridge::createForDirectoryExists):
        (WebKit::WorkerFileSystemCallbacksBridge::createForReadDirectory):
        (WebKit::MainThreadFileSystemCallbacks::didSucceed):
        (WebKit::MainThreadFileSystemCallbacks::didReadMetadata):
        (WebKit::MainThreadFileSystemCallbacks::didReadDirectory):
        (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::moveOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::copyOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::removeOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::readMetadataOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::createFileOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::createDirectoryOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::fileExistsOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::directoryExistsOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::readDirectoryOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnWorkerThread):
        (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnWorkerThread):
        (WebKit::WorkerFileSystemCallbacksBridge::derefIfWorkerIsStopped):
        * src/WorkerFileSystemCallbacksBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Miloš Popović <gpopac@gmail.com>
commit-queue@webkit.org [Wed, 29 Sep 2010 18:08:11 +0000 (18:08 +0000)]
2010-09-29  Miloš Popović  <gpopac@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        Serbian translations update.

        * sr.po:
        * sr@latin.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Matt Perry <mpcomplete@chromium.org>
mpcomplete@chromium.org [Wed, 29 Sep 2010 18:01:13 +0000 (18:01 +0000)]
2010-09-29  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Darin Fisher.

        Remove obsolete registerExtension variants from chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=46683

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::createNewContext):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::registeredExtensionWithV8):
        (WebCore::V8Proxy::registerExtension):
        * bindings/v8/V8Proxy.h:
2010-09-29  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Darin Fisher.

        Remove obsolete registerExtension variants from chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=46683

        * public/WebScriptController.h:
        * src/WebScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 29 Sep 2010 17:58:13 +0000 (17:58 +0000)]
2010-09-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
        https://bugs.webkit.org/show_bug.cgi?id=46822

        * platform/gtk/Skipped: Unskip a test which is no longer crashing.
2010-09-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
        https://bugs.webkit.org/show_bug.cgi?id=46822

        When parentObjectUnignored returns null in objectAndOffsetUnignored consider that
        a failure case. Handle this failure appropriately at all call sites.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_text_get_caret_offset): Handle the failure of objectAndOffsetUnignored.
        (objectAndOffsetUnignored): Always check the return value of parentObjectUnignored and
        return 0 to indicate failure when that happens.
        * editing/gtk/SelectionControllerGtk.cpp:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Handle the failure
        case of objectAndOffsetUnignored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle getting the user agent in the plug-in process
andersca@apple.com [Wed, 29 Sep 2010 17:46:51 +0000 (17:46 +0000)]
Handle getting the user agent in the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=46819

Reviewed by Sam Weinig.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Add new handleMessage overload.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::create):
(WebKit::PluginControllerProxy::PluginControllerProxy):
Pass the user agent to the plug-in controller proxy.

(WebKit::PluginControllerProxy::userAgent):
Return the user agent.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPlugin):
Pass the user agent when creating the plug-in controller proxy.

* PluginProcess/WebProcessConnection.messages.in:
Add userAgent.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::userAgent):
* WebProcess/Plugins/PluginController.h:
Remove the URL parameter to userAgent.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
Pass the user agent to WebProcessConnection::CreatePlugin.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::userAgent):
Remove url parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 29 Sep 2010 17:46:19 +0000 (17:46 +0000)]
2010-09-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r68657.
        http://trac.webkit.org/changeset/68657
        https://bugs.webkit.org/show_bug.cgi?id=46820

        reason "Breaks win debug build" (Requested by podivilov on
        #webkit).

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::send):
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::V8XMLHttpRequest::sendCallback):
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::dispatchModifiedEvent):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::parserInsertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::appendChild):
        (WebCore::ContainerNode::parserAddChild):
        (WebCore::notifyChildInserted):
        (WebCore::dispatchChildRemovalEvents):
        * dom/Element.cpp:
        (WebCore::Element::setAttribute):
        (WebCore::Element::removeAttribute):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::willInsertDOMNodeImpl):
        (WebCore::InspectorController::didInsertDOMNodeImpl):
        (WebCore::InspectorController::willRemoveDOMNodeImpl):
        (WebCore::InspectorController::didRemoveDOMNodeImpl):
        (WebCore::InspectorController::willModifyDOMAttrImpl):
        (WebCore::InspectorController::didModifyDOMAttrImpl):
        (WebCore::InspectorController::characterDataModifiedImpl):
        (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::willInsertDOMNode):
        (WebCore::InspectorController::didInsertDOMNode):
        (WebCore::InspectorController::willRemoveDOMNode):
        (WebCore::InspectorController::willModifyDOMAttr):
        (WebCore::InspectorController::didModifyDOMAttr):
        (WebCore::InspectorController::characterDataModified):
        (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
        (WebCore::InspectorController::inspectorControllerForScriptExecutionContext):
        (WebCore::InspectorController::inspectorControllerForNode):
        (WebCore::InspectorController::inspectorControllerForDocument):
        * inspector/InspectorInstrumentation.cpp: Removed.
        * inspector/InspectorInstrumentation.h: Removed.
        * workers/SharedWorker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 29 Sep 2010 17:32:43 +0000 (17:32 +0000)]
2010-09-29  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Levin.

        Performance improvement for FontLinux.
        https://bugs.webkit.org/show_bug.cgi?id=46374

        Reduce new/delete operations by storing the maximum capacity of the glyph
        array and use that value in subsequent HB_ShapeItem calls. (Note that a
        call to HB_ShapeItem may reduce the value of m_item.num_glyphs below the
        capacity.)

        Also be consistent with zero'ing the glyph arrays before calling
        HB_ShapeItem.

        There is no functionality changes so no new tests are added.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::createGlyphArrays):
        (WebCore::TextRunWalker::resetGlyphArrays):
        (WebCore::TextRunWalker::shapeGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement more PluginProxy member functions
andersca@apple.com [Wed, 29 Sep 2010 17:23:01 +0000 (17:23 +0000)]
Implement more PluginProxy member functions
https://bugs.webkit.org/show_bug.cgi?id=46815

Reviewed by Sam Weinig.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::handleMouseEvent):
(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::setFocus):
(WebKit::PluginControllerProxy::windowFocusChanged):
(WebKit::PluginControllerProxy::windowFrameChanged):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
Call the appropriate Plugin member functions.

* PluginProcess/PluginControllerProxy.messages.in:
Add new messages.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
It's OK to get a message for a plug-in controller proxy that has gone away.

(WebKit::WebProcessConnection::didReceiveSyncMessage):
Forward the message to the PluginControllerProxy handler.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::setFocus):
(WebKit::PluginProxy::windowFocusChanged):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::windowVisibilityChanged):
Send messages to the plug-in process.

(WebKit::PluginProxy::controller):
Return the plug-in controller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Wed, 29 Sep 2010 17:19:51 +0000 (17:19 +0000)]
2010-09-29  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Dimitri Glazkov.

        Add method which checks if a WebAccessibilityObject is in the cache.
        https://bugs.webkit.org/show_bug.cgi?id=46605

        * public/WebAccessibilityCache.h:
        * src/WebAccessibilityCacheImpl.cpp:
        (WebKit::WebAccessibilityCacheImpl::isCached):
        * src/WebAccessibilityCacheImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 29 Sep 2010 17:19:36 +0000 (17:19 +0000)]
2010-09-29  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract Inspector Instrumentation API as a class.
        https://bugs.webkit.org/show_bug.cgi?id=46614

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::send):
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::V8XMLHttpRequest::sendCallback):
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::dispatchModifiedEvent):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::parserInsertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::appendChild):
        (WebCore::ContainerNode::parserAddChild):
        (WebCore::notifyChildInserted):
        (WebCore::dispatchChildRemovalEvents):
        * dom/Element.cpp:
        (WebCore::Element::setAttribute):
        (WebCore::Element::removeAttribute):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp: Added.
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
        (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
        * inspector/InspectorInstrumentation.h: Added.
        (WebCore::InspectorInstrumentation::frontendCreated):
        (WebCore::InspectorInstrumentation::frontendDeleted):
        (WebCore::InspectorInstrumentation::hasFrontends):
        (WebCore::InspectorInstrumentation::willInsertDOMNode):
        (WebCore::InspectorInstrumentation::didInsertDOMNode):
        (WebCore::InspectorInstrumentation::willRemoveDOMNode):
        (WebCore::InspectorInstrumentation::willModifyDOMAttr):
        (WebCore::InspectorInstrumentation::didModifyDOMAttr):
        (WebCore::InspectorInstrumentation::characterDataModified):
        (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest):
        (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext):
        (WebCore::InspectorInstrumentation::inspectorControllerForDocument):
        (WebCore::InspectorInstrumentation::inspectorControllerForPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Anantanarayanan G Iyengar <ananta@chromium.org>
commit-queue@webkit.org [Wed, 29 Sep 2010 17:15:01 +0000 (17:15 +0000)]
2010-09-29  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Honor z-index specified by a plugin
        https://bugs.webkit.org/show_bug.cgi?id=46223

        The Chromium plugin code which implements the iframe shim technique
        for overlaying a windowed plugin with content on the page should
        honor the z-index specified on the plugin widget. If the z-index
        here is greater than the enclosing iframe shim then the plugin
        should be displayed over the iframe. Updated the layout test to test
        for this case. Skipped the plugins/iframe-shims.html layout test on
        platforms which don't support it.

        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * plugins/iframe-shims.html:
2010-09-29  Anantanarayanan G Iyengar  <ananta@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Honor z-index specified by a plugin
        https://bugs.webkit.org/show_bug.cgi?id=46223

        The Chromium plugin code which implements the iframe shim technique
        for overlaying a windowed plugin with content on the page should
        honor the z-index specified on the plugin widget. If the z-index
        here is greater than the enclosing iframe shim then the plugin
        should be displayed over the iframe. Updated the layout test to test
        for this case. Skipped the plugins/iframe-shims.html layout test on
        platforms which don't support it.

        * src/WebPluginContainerImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 29 Sep 2010 17:10:52 +0000 (17:10 +0000)]
2010-09-29  Simon Fraser  <simon.fraser@apple.com>

        No review.

        References always refert to a file in .xht format, even
        for HTML tests, so fix their loading.

        * CSSTestSuiteHarness/harness/harness.js:
        (TestSuite.prototype.loadRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46786, convert layoutBlockChild (but not...
hyatt@apple.com [Wed, 29 Sep 2010 17:00:36 +0000 (17:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46786, convert layoutBlockChild (but not any functions it calls)
to be block-flow-aware.

Reviewed by Sam Weinig.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):
* rendering/RenderBlock.h:
* rendering/RenderBox.h:
(WebCore::RenderBox::scrollbarLogicalHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Wed, 29 Sep 2010 16:46:27 +0000 (16:46 +0000)]
2010-09-29  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Don't keep local reference to QGraphicsItemOverlay in QGWVPrivate
        https://bugs.webkit.org/show_bug.cgi?id=46812

        Get the QGraphicsItemOverlay* via the QWebPageClient (d->page->d->client)
        instead of keeping a local pointer to it.

        This is cleanup for a follow-up patch.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::overlay):
        (QGraphicsWebView::paint):
        (QGraphicsWebView::setPage):
        (QGraphicsWebView::updateGeometry):
        (QGraphicsWebView::setGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>
commit-queue@webkit.org [Wed, 29 Sep 2010 16:43:01 +0000 (16:43 +0000)]
2010-09-29  João Paulo Rechi Vita  <jprvita@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] General small fixes.
        https://bugs.webkit.org/show_bug.cgi?id=46813

        This commit spots a comparison between signed and unsigned integer
        expressions, a missing return and a never-called function.

        No new tests since no new funcionality has been added.

        * platform/efl/SharedBufferEfl.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):
2010-09-29  João Paulo Rechi Vita  <jprvita@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] General small fixes.
        https://bugs.webkit.org/show_bug.cgi?id=46813

        This commit spots a comparison between signed and unsigned integer
        expressions, a missing return and a never-called function.

        * WebCoreSupport/FullscreenVideoControllerEfl.cpp:
        (FullscreenVideoController::canPlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Wed, 29 Sep 2010 16:31:22 +0000 (16:31 +0000)]
2010-09-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] QScriptEngine should have an API for creating Date objects
        https://bugs.webkit.org/show_bug.cgi?id=41667

        Implement newDate(), isDate() and toDateTime() functions. Use the
        QDateTime::{to,set}MSecsSinceEpoch() functions to do the
        calculations.

        * api/qscriptengine.cpp:
        (QScriptEngine::newDate):
        * api/qscriptengine.h:
        * api/qscriptengine_p.cpp:
        (QScriptEnginePrivate::newDate):
        * api/qscriptengine_p.h:
        (QScriptEnginePrivate::isDate):

        * api/qscriptoriginalglobalobject_p.h:
        (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject): need
        to keep track of Date Constructor and Prototype.
        (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject): ditto.
        (QScriptOriginalGlobalObject::isDate): use the Date Constructor
        and Prototype to identify Date values.

        * api/qscriptvalue.cpp:
        (QScriptValue::isDate):
        (QScriptValue::toDateTime):
        * api/qscriptvalue.h:
        * api/qscriptvalue_p.h:
        (QScriptValuePrivate::isDate):
        (QScriptValuePrivate::toDateTime):
        * tests/qscriptengine/tst_qscriptengine.cpp:
        (tst_QScriptEngine::newDate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 29 Sep 2010 16:06:46 +0000 (16:06 +0000)]
2010-09-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, updated baselines of
        svg/css/getComputedStyle-basic.xhtml after the css properties
        were renamed in r68561.

        * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 29 Sep 2010 15:55:42 +0000 (15:55 +0000)]
2010-09-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed.

        Next try to fix cygwin build.

        * wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 29 Sep 2010 15:44:44 +0000 (15:44 +0000)]
2010-09-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed.

        Build fix for cygwin #2. Oops, it's OS(WINDOWS), not OS(WIN).

        * wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 29 Sep 2010 15:35:39 +0000 (15:35 +0000)]
2010-09-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed.

        Build fix for cygwin.

        * wtf/Assertions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLook for WebKit.dll (not WebKit_debug.dll) when launching the web process in Debug...
aroben@apple.com [Wed, 29 Sep 2010 15:34:08 +0000 (15:34 +0000)]
Look for WebKit.dll (not WebKit_debug.dll) when launching the web process in Debug builds

Fixes <http://webkit.org/b/46809> <rdar://problem/8491809> REGRESSION
(r67979): All tests crashing on Windows WebKit2 test bot

Reviewed by Sam Weinig.

* UIProcess/Launcher/win/ProcessLauncherWin.cpp: WebKit_debug.dll is
only used in Debug_All builds (but WebKit2WebProcess_debug.exe is used
in all non-Debug_Internal debug-style builds).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 29 Sep 2010 15:11:14 +0000 (15:11 +0000)]
2010-09-29  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        build still broken since r68521
        https://bugs.webkit.org/show_bug.cgi?id=46795

        Call make-values.pl once only. It seems calling it multiple times
        in the same build produces a wrong CSSValueKeywordsHash.h which
        has a duplicate declaration of its valueList variable. The double
        call is triggered by the double targets in the Makefile rules and
        makevalues.pl generates one of them, which screws up the build. A
        more proper fix should be done with the advices on
        http://www.cmcrossroads.com/cm-basics/12905-rules-with-multiple-outputs-in-gnu-make

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 29 Sep 2010 15:06:25 +0000 (15:06 +0000)]
2010-09-29  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [WINCE] Buildfix for Assertions.cpp after r68511.
        https://bugs.webkit.org/show_bug.cgi?id=46807

        Some, but not all WinCE environments have support for IsDebuggerPresent().
        Add HAVE(ISDEBUGGERPRESENT) to make this a build option.
        HAVE(ISDEBUGGERPRESENT) will be 1 for all OS(WIN) by default.

        * wtf/Assertions.cpp:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>
commit-queue@webkit.org [Wed, 29 Sep 2010 14:46:06 +0000 (14:46 +0000)]
2010-09-29  João Paulo Rechi Vita  <jprvita@profusion.mobi>

        Unreviewed build fix.

        Fix CMake build for ENABLE_PROGRESS_TAG.
        https://bugs.webkit.org/show_bug.cgi?id=46808

        No new tests since it's a build fix.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Reinout van Schouwen <reinouts@gnome.org>
kov@webkit.org [Wed, 29 Sep 2010 13:56:59 +0000 (13:56 +0000)]
2010-09-29  Reinout van Schouwen  <reinouts@gnome.org>

        Reviewed by Gustavo Noronha.

        [GTK] Updated Dutch translation
        https://bugs.webkit.org/show_bug.cgi?id=46050

        * nl.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 29 Sep 2010 13:46:49 +0000 (13:46 +0000)]
2010-09-29  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
        https://bugs.webkit.org/show_bug.cgi?id=46803

        No new tests. It's covered by existing tests under LayoutTests/storage

        * bindings/v8/custom/V8CustomVoidCallback.cpp:
        (WebCore::invokeCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Satish Sampath <satish@chromium.org>
satish@chromium.org [Wed, 29 Sep 2010 13:45:15 +0000 (13:45 +0000)]
2010-09-29  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
        https://bugs.webkit.org/show_bug.cgi?id=46799

        * fast/speech/input-appearance-numberandspeech.html:
        * fast/speech/input-appearance-searchandspeech.html:
        * fast/speech/input-appearance-speechbutton.html:
        * fast/speech/input-text-speechbutton.html:
        * fast/speech/speech-button-ignore-generated-events.html:
2010-09-29  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
        https://bugs.webkit.org/show_bug.cgi?id=46799

        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::webkitspeechEnabled): Rename the runtime feature flag getter.
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in: Rename the css style name.
        * css/html.css: Rename the css style name.
        (input::-webkit-input-speech-button):
        * html/HTMLAttributeNames.in: Rename the @speech attribute.
        * html/HTMLInputElement.cpp: Update code using the attribute.
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::isSpeechEnabled):
        * html/HTMLInputElement.idl: Rename the @speech attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 Peter Varga <pvarga@inf.u-szeged.hu>
commit-queue@webkit.org [Wed, 29 Sep 2010 12:45:55 +0000 (12:45 +0000)]
2010-09-29  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        JSC compile fails on 32bit platform when Regexp Tracing is enabled
        https://bugs.webkit.org/show_bug.cgi?id=46713

        Fix the cast of pointer in regexp tracing to avoid the warning.

        * runtime/RegExp.cpp:
        (JSC::RegExp::match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 29 Sep 2010 12:17:07 +0000 (12:17 +0000)]
2010-09-29  MORITA Hajime  <morrita@google.com>

        [Chromium] failed to build without ACCELERATED_COMPOSITING
        https://bugs.webkit.org/show_bug.cgi?id=46793

        Moved constant definitions from inside ACCELERATED_COMPOSITING to
        outside of the condition.

        * WebCore.gypi:
        * platform/graphics/chromium/VideoFrameChromium.cpp: Added just for defining constants.
        * platform/graphics/chromium/VideoLayerChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix the build on non-x86 platforms with gcc
hausmann@webkit.org [Wed, 29 Sep 2010 10:35:08 +0000 (10:35 +0000)]
[Qt] Fix the build on non-x86 platforms with gcc

Reviewed by Csaba Osztrogonác.

Don't disable -Werror on arm, that doesn't work when QT_ARCH is
for example armv6. Instead change the condition as the comment says,
enable -Werror on x86/gcc where we know it passes. On other platforms
gcc produces difference warnings, and when they're fixed we can add
them to the whitelist of -Werror-supported architectures.

* WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 29 Sep 2010 09:14:34 +0000 (09:14 +0000)]
2010-09-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: [Resources panel] Need more visible "at a glance".
        https://bugs.webkit.org/show_bug.cgi?id=45657

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid):
        (WebInspector.DataGrid.prototype.updateWidths):
        (WebInspector.DataGrid.prototype.sortNodes):
        (WebInspector.DataGrid.prototype._resizerDragging):
        (WebInspector.DataGrid.prototype._endResizerDragging):
        (WebInspector.DataGridNode.prototype.selectable.true.get element):
        (WebInspector.DataGridNode.prototype.createCells):
        (WebInspector.DataGridNode.prototype.refresh):
        * inspector/front-end/Images/networkIcon.png: Copied from WebCore/inspector/front-end/Images/resourcesIcon.png.
        * inspector/front-end/NetworkPanel.js: Added.
        * inspector/front-end/Settings.js:
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.toolbar-item.network .toolbar-icon):
        (.data-grid .data-container):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        (WebInspector.updateResource):
        * inspector/front-end/networkPanel.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 29 Sep 2010 07:59:52 +0000 (07:59 +0000)]
2010-09-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move pauseOnExceptionState under control of InspectorState
        It is Inspector Protocol cleanup activity.
        The actual state of this flag can be obtained as a return value of setPauseOnExceptionState command
        or as a value in InspectorState object.

        https://bugs.webkit.org/show_bug.cgi?id=46724

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getInspectorState):
        (WebCore::InspectorController::populateScriptObjects):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        (WebCore::InspectorDebuggerAgent::pauseOnExceptionsState):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
        * inspector/front-end/inspector.js:
        (WebInspector.doLoadedDone.populateInspectorState):
        (WebInspector.doLoadedDone):
        (WebInspector.reportProtocolError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-29 James Kozianski <koz@chromium.org>
commit-queue@webkit.org [Wed, 29 Sep 2010 07:09:35 +0000 (07:09 +0000)]
2010-09-29  James Kozianski  <koz@chromium.org>

        Reviewed by James Robinson.

        Update test_expectations.txt from the flakiness dashboard.
        https://bugs.webkit.org/show_bug.cgi?id=46787

        Updates some canvas/philip tests in test_expectations.txt that have
        started passing on the flakiness dashboard.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed fix after r68568. Add Qt specific expected files for passing tests.
ossy@webkit.org [Wed, 29 Sep 2010 06:55:43 +0000 (06:55 +0000)]
Unreviewed fix after r68568. Add Qt specific expected files for passing tests.

Unskip remaining canvas layout tests so that they can track progressions/regressions
https://bugs.webkit.org/show_bug.cgi?id=46439

* platform/qt/canvas: Added.
* platform/qt/canvas/philip: Added.
* platform/qt/canvas/philip/tests: Added.
* platform/qt/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt: Added.
* platform/qt/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
* platform/qt/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 29 Sep 2010 06:50:34 +0000 (06:50 +0000)]
2010-09-28  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files
        https://bugs.webkit.org/show_bug.cgi?id=46717

        Define WTF_USE_GSTREAMER if configure found the gstreamer
        development files and add the macro in the gcc command-line if needed.

        * GNUmakefile.am:
        * configure.ac:

WebCore:

        Reviewed by Martin Robinson.

        check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files
        https://bugs.webkit.org/show_bug.cgi?id=46717

        Guard the gstreamer/ files with USE(GSTREAMER), which is more
        explicit than ENABLE(VIDEO).

        * GNUmakefile.am: Define WTF_USE_GSTREAMER only if GStreamer
        support is enabled.
        * platform/graphics/gstreamer/DataSourceGStreamer.cpp:
        * platform/graphics/gstreamer/DataSourceGStreamer.h:
        * platform/graphics/gstreamer/GOwnPtrGStreamer.cpp:
        * platform/graphics/gstreamer/GOwnPtrGStreamer.h:
        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        * platform/graphics/gstreamer/GStreamerGWorld.h:
        * platform/graphics/gstreamer/ImageGStreamer.h:
        * platform/graphics/gstreamer/ImageGStreamerCG.mm:
        * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
        * platform/graphics/gstreamer/PlatformVideoWindow.h:
        * platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:
        * platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
        * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
        * platform/graphics/gstreamer/VideoSinkGStreamer.h:
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 29 Sep 2010 06:30:45 +0000 (06:30 +0000)]
2010-09-28  Kent Tamura  <tkent@chromium.org>

        Unreviewed, windows build fix for r68629.

        * WebCore.vcproj/WebCore.vcproj: Add TimeInputType.{cpp,h}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Johnny Ding <jnd@chromium.org>
commit-queue@webkit.org [Wed, 29 Sep 2010 06:27:57 +0000 (06:27 +0000)]
2010-09-28  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292
        Some windowed plugins did not handle events through EventHandler, so we
        never set right gesture state for those events.
        This change is to set right allowPopupsFromPlugin flag to current
        execution frame, so WeKit can always get right gesture state on Mac.
        From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
        process, that process passes the allowPopupsFromPlugin flag to
        WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
        NetscapePluginInstanceProxy::evaluate.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2010-09-28  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292
        Pass the right popupAllowed flag to current execution frame,
        so WebKit can get right gesture status for popups initiated
        from plugins.
        This also makes v8 binding's ScriptController::processingUserGesture
        match what jsc version.

        Test: plugins/plugin-initiate-popup-window.html

        * bindings/v8/NPV8Object.cpp:
        (_NPN_EvaluateHelper):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::processingUserGesture):
        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::setAllowPopupsFromPlugin):
        (WebCore::ScriptController::allowPopupsFromPlugin):
2010-09-28  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292.
        Add a test to initiate popup windows from plugin during plugin is
        handling mouse/keyboard event.
        Disable this test on gtk/qt/win since the test plugin in those platforms
        didn't implement NPP_HandleEvent.

        * platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * plugins/plugin-initiate-popup-window-expected.txt: Added.
        * plugins/plugin-initiate-popup-window.html: Added.
2010-09-28  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292
        Add a new parameter to the test plugin to allow specifying a script
        and a mouse/keyboard event. The specified script will be evaluated
        in the browser when the specified event is received by the plugin.

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        (pluginAllocate):
        * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New):
        (handleEventCarbon):
        (handleEventCocoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor HTMLInputElement: Introducing InputType class and classes
tkent@chromium.org [Wed, 29 Sep 2010 06:18:18 +0000 (06:18 +0000)]
Refactor HTMLInputElement: Introducing InputType class and classes
for each input element types.
https://bugs.webkit.org/show_bug.cgi?id=45872

Reviewed by Darin Adler.

No new tests because this doesn't change any behavior.

* Android.mk: Add new files.
* CMakeLists.txt: ditto.
* GNUmakefile.am: ditto.
* WebCore.gypi: ditto.
* WebCore.pro: ditto.
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* html/BaseTextInputType.cpp: Added.
(WebCore::BaseTextInputType::isTextType):
(WebCore::BaseTextInputType::patternMismatch):
* html/BaseTextInputType.h: Added.
(WebCore::BaseTextInputType::BaseTextInputType):
* html/ButtonInputType.cpp: Added.
(WebCore::ButtonInputType::create):
(WebCore::ButtonInputType::formControlType):
* html/ButtonInputType.h: Added.
(WebCore::ButtonInputType::ButtonInputType):
* html/CheckboxInputType.cpp: Added.
(WebCore::CheckboxInputType::create):
(WebCore::CheckboxInputType::formControlType):
* html/CheckboxInputType.h: Added.
(WebCore::CheckboxInputType::CheckboxInputType):
* html/ColorInputType.cpp: Added.
(WebCore::ColorInputType::create):
(WebCore::ColorInputType::formControlType):
* html/ColorInputType.h: Added.
(WebCore::ColorInputType::ColorInputType):
* html/DateInputType.cpp: Added.
(WebCore::DateInputType::create):
(WebCore::DateInputType::formControlType):
* html/DateInputType.h: Added.
(WebCore::DateInputType::DateInputType):
* html/DateTimeInputType.cpp: Added.
(WebCore::DateTimeInputType::create):
(WebCore::DateTimeInputType::formControlType):
* html/DateTimeInputType.h: Added.
(WebCore::DateTimeInputType::DateTimeInputType):
* html/DateTimeLocalInputType.cpp: Added.
(WebCore::DateTimeLocalInputType::create):
(WebCore::DateTimeLocalInputType::formControlType):
* html/DateTimeLocalInputType.h: Added.
(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
* html/EmailInputType.cpp: Added.
(WebCore::EmailInputType::create):
(WebCore::EmailInputType::formControlType):
* html/EmailInputType.h: Added.
(WebCore::EmailInputType::EmailInputType):
* html/FileInputType.cpp: Added.
(WebCore::FileInputType::create):
(WebCore::FileInputType::formControlType):
* html/FileInputType.h: Added.
(WebCore::FileInputType::FileInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement): Initialize m_inputType.
(WebCore::HTMLInputElement::patternMismatch): Delegate to InputType.
(WebCore::HTMLInputElement::updateType): Update m_inputType with new type.
(WebCore::HTMLInputElement::formControlType): Delegate to InputType.
(WebCore::HTMLInputElement::isTextField): ditto.
(WebCore::HTMLInputElement::isTextType): ditto.
* html/HTMLInputElement.h:
* html/HiddenInputType.cpp: Added.
(WebCore::HiddenInputType::create):
(WebCore::HiddenInputType::formControlType):
* html/HiddenInputType.h: Added.
(WebCore::HiddenInputType::HiddenInputType):
* html/ImageInputType.cpp: Added.
(WebCore::ImageInputType::create):
(WebCore::ImageInputType::formControlType):
* html/ImageInputType.h: Added.
(WebCore::ImageInputType::ImageInputType):
* html/InputType.cpp: Added.
(WebCore::createInputTypeFactoryMap):
(WebCore::InputType::create):
(WebCore::InputType::createText):
(WebCore::InputType::~InputType):
(WebCore::InputType::isTextField):
(WebCore::InputType::isTextType):
(WebCore::InputType::patternMismatch):
(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::isindex):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):
* html/InputType.h: Added.
(WebCore::InputType::InputType):
(WebCore::InputType::element):
* html/IsIndexInputType.cpp: Added.
(WebCore::IsIndexInputType::create):
(WebCore::IsIndexInputType::formControlType):
* html/IsIndexInputType.h: Added.
(WebCore::IsIndexInputType::IsIndexInputType):
* html/MonthInputType.cpp: Added.
(WebCore::MonthInputType::create):
(WebCore::MonthInputType::formControlType):
* html/MonthInputType.h: Added.
(WebCore::MonthInputType::MonthInputType):
* html/NumberInputType.cpp: Added.
(WebCore::NumberInputType::create):
(WebCore::NumberInputType::formControlType):
* html/NumberInputType.h: Added.
(WebCore::NumberInputType::NumberInputType):
* html/PasswordInputType.cpp: Added.
(WebCore::PasswordInputType::create):
(WebCore::PasswordInputType::formControlType):
* html/PasswordInputType.h: Added.
(WebCore::PasswordInputType::PasswordInputType):
* html/RadioInputType.cpp: Added.
(WebCore::RadioInputType::create):
(WebCore::RadioInputType::formControlType):
* html/RadioInputType.h: Added.
(WebCore::RadioInputType::RadioInputType):
* html/RangeInputType.cpp: Added.
(WebCore::RangeInputType::create):
(WebCore::RangeInputType::formControlType):
* html/RangeInputType.h: Added.
(WebCore::RangeInputType::RangeInputType):
* html/ResetInputType.cpp: Added.
(WebCore::ResetInputType::create):
(WebCore::ResetInputType::formControlType):
* html/ResetInputType.h: Added.
(WebCore::ResetInputType::ResetInputType):
* html/SearchInputType.cpp: Added.
(WebCore::SearchInputType::create):
(WebCore::SearchInputType::formControlType):
* html/SearchInputType.h: Added.
(WebCore::SearchInputType::SearchInputType):
* html/SubmitInputType.cpp: Added.
(WebCore::SubmitInputType::create):
(WebCore::SubmitInputType::formControlType):
* html/SubmitInputType.h: Added.
(WebCore::SubmitInputType::SubmitInputType):
* html/TelephoneInputType.cpp: Added.
(WebCore::TelephoneInputType::create):
(WebCore::TelephoneInputType::formControlType):
* html/TelephoneInputType.h: Added.
(WebCore::TelephoneInputType::TelephoneInputType):
* html/TextFieldInputType.cpp: Added.
(WebCore::TextFieldInputType::isTextField):
* html/TextFieldInputType.h: Added.
(WebCore::TextFieldInputType::TextFieldInputType):
* html/TextInputType.cpp: Added.
(WebCore::TextInputType::create):
(WebCore::TextInputType::formControlType):
* html/TextInputType.h: Added.
(WebCore::TextInputType::TextInputType):
* html/TimeInputType.cpp: Added.
(WebCore::TimeInputType::create):
(WebCore::TimeInputType::formControlType):
* html/TimeInputType.h: Added.
(WebCore::TimeInputType::TimeInputType):
* html/URLInputType.cpp: Added.
(WebCore::URLInputType::create):
(WebCore::URLInputType::formControlType):
* html/URLInputType.h: Added.
(WebCore::URLInputType::URLInputType):
* html/WeekInputType.cpp: Added.
(WebCore::WeekInputType::create):
(WebCore::WeekInputType::formControlType):
* html/WeekInputType.h: Added.
(WebCore::WeekInputType::WeekInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46782, rename the top and bottom margin quirk...
hyatt@apple.com [Wed, 29 Sep 2010 05:59:55 +0000 (05:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46782, rename the top and bottom margin quirk getters/setters.

Reviewed by Maciej Stachowiak.

Also do a bit of cleanup for block flow roots.  Make sure they don't try to propagate overhanging floats out
to ancestors.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::addOverhangingFloats):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* rendering/RenderObject.h:
(WebCore::RenderObject::isMarginBeforeQuirk):
(WebCore::RenderObject::isMarginAfterQuirk):
(WebCore::RenderObject::setMarginBeforeQuirk):
(WebCore::RenderObject::setMarginAfterQuirk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 29 Sep 2010 05:59:21 +0000 (05:59 +0000)]
2010-09-28  Simon Fraser  <simon.fraser@apple.com>

        Fix export by adding missing argument.

        * CSSTestSuiteHarness/harness/harness.js:
        (TestSuite.prototype.showResultsForAllTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46780
hyatt@apple.com [Wed, 29 Sep 2010 05:38:14 +0000 (05:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46780

Reviewed by Sam Weinig.

Rename the pos/neg/collapsed margin methods.  Rename all the members of the RenderBlockRareData struct.
No logical changes.  Just renames.

* editing/TextIterator.cpp:
(WebCore::shouldEmitExtraNewlineForNode):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::maxPosMarginBefore):
(WebCore::RenderBlock::maxNegMarginBefore):
(WebCore::RenderBlock::maxPosMarginAfter):
(WebCore::RenderBlock::maxNegMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::maxMarginBefore):
(WebCore::RenderBlock::maxMarginAfter):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::beforePosDefault):
(WebCore::RenderBlock::RenderBlockRareData::beforeNegDefault):
(WebCore::RenderBlock::RenderBlockRareData::afterPosDefault):
(WebCore::RenderBlock::RenderBlockRareData::afterNegDefault):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):
(WebCore::RenderBox::maxMarginBefore):
(WebCore::RenderBox::maxMarginAfter):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 29 Sep 2010 05:14:16 +0000 (05:14 +0000)]
2010-09-28  Simon Fraser  <simon.fraser@apple.com>

        No review

        Show which tests have been run by dimming them out in the test list.

        Adjust some element sizes.

        * CSSTestSuiteHarness/harness/harness.css:
        (#test-list > option.untested):
        (#test-list > option.completed):
        (#output):
        (.output-options):
        * CSSTestSuiteHarness/harness/harness.js:
        (Test):
        (TestSuite.prototype.fillTestList):
        (TestSuite.prototype.updateTestList):
        (TestSuite.prototype.setSelectedChapter):
        (TestSuite.prototype.recordResult):
        (TestSuite.prototype.markTestCompleted):
        (TestSuite.prototype.testCompletionStateChanged):
        (TestSuite.prototype.loadTestStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 29 Sep 2010 04:35:50 +0000 (04:35 +0000)]
2010-09-28 MORITA Hajime  <morrita@google.com>

        Unreviewed; update test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, add missing import.
kevino@webkit.org [Wed, 29 Sep 2010 04:10:26 +0000 (04:10 +0000)]
[wx] Build fix, add missing import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] wxMSW build fix. Don't use multiple inheritance in PopupMenuWx to avoid debug...
kevino@webkit.org [Wed, 29 Sep 2010 04:06:18 +0000 (04:06 +0000)]
[wx] wxMSW build fix. Don't use multiple inheritance in PopupMenuWx to avoid debug build
compiler error about ambiguity over which new override (wx's or FastAllocBase's) to use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 29 Sep 2010 04:00:00 +0000 (04:00 +0000)]
2010-09-28  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Implement export of various queries on the test database, sharing
        code with that which displays results inline.

        * CSSTestSuiteHarness/harness/harness.js:
        ():
        (TestSuite.prototype.exportResultsCompletion.var):
        (TestSuite.prototype.exportResultsCompletion):
        (TestSuite.prototype.showResultsForCompletedTests):
        (TestSuite.prototype.exportResultsForCompletedTests):
        (TestSuite.prototype.showResultsForAllTests):
        (TestSuite.prototype.exportResultsForAllTests):
        (TestSuite.prototype.exportResultsForTestsNotRun):
        (TestSuite.prototype.exportResultsForTestsWithStatus):
        (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 29 Sep 2010 02:43:53 +0000 (02:43 +0000)]
2010-09-28  MORITA Hajime  <morrita@google.com>

        Unreviewed; new test baselines.

        * platform/chromium-win/animations/opacity-transform-animation-expected.checksum: Added.
        * platform/chromium-win/animations/opacity-transform-animation-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Sep 2010 01:37:41 +0000 (01:37 +0000)]
2010-09-28  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        [Chromium] animations/opacity-transform-animation.html fails on Chromium
        https://bugs.webkit.org/show_bug.cgi?id=46557

        Make transition from .7 opacity to 1.0 (instead of .8 to .9). The
        mid-point (where the pixel dump is done) is the same, but the overall
        change is more obvious, so failures are more noticeable.

        Update Chromium baselines (it has a slightly different intermediate
        color; (38, 109, 0) vs. (32, 110, 0) for the Mac port, albeit one which
        agrees with the expected interpolated value better).

        * animations/opacity-transform-animation.html:
        * platform/chromium/animations/opacity-transform-animation-expected.checksum: Added.
        * platform/chromium/animations/opacity-transform-animation-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 29 Sep 2010 01:36:54 +0000 (01:36 +0000)]
2010-09-28  Xiaomei Ji  <xji@chromium.org>

        Reviewed by NOBODY (revert unsquashed git commits)

        Revert change sets 68583 to 68590, which are un-squashed git-commits: Performance improvement for FontLinux regarding issue 46374.
        https://bugs.webkit.org/show_bug.cgi?id=46374

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 29 Sep 2010 01:20:09 +0000 (01:20 +0000)]
2010-09-28  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Work around uncertainty about the order of database
        transactions when creating the database, so that we don't
        try to query the table before it has been created.

        * CSSTestSuiteHarness/harness/harness.js:
        (TestSuite):
        (TestSuite.prototype.databaseCreated):
        (TestSuite.prototype.storeTestResult):
        (TestSuite.prototype.populateDatabaseFromTestInfoData):
        (TestSuite.prototype.queryDatabaseForTestsWithStatus):
        (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
        (TestSuite.prototype.queryDatabaseForCompletedTests):
        (TestSuite.prototype.queryDatabaseForTestsNotRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 29 Sep 2010 00:45:06 +0000 (00:45 +0000)]
2010-09-28  Stephen White  <senorblanco@chromium.org>

        Unreviewed; update test expectations.

        [CHROMIUM] Update Chromium/Linux test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Marc-Antoine Ruel <maruel@chromium.org>
commit-queue@webkit.org [Wed, 29 Sep 2010 00:44:07 +0000 (00:44 +0000)]
2010-09-28  Marc-Antoine Ruel  <maruel@chromium.org>

        Reviewed by Tony Chang.

        Split webcore_html off webcore_remaining.

        webcore_remaining is still too large for certain 32 bits toolsets.
        https://bugs.webkit.org/show_bug.cgi?id=46445

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 29 Sep 2010 00:23:56 +0000 (00:23 +0000)]
2010-09-28  Stephen White  <senorblanco@chromium.org>

        Unreviewed; update test expectations.

        [CHROMIUM] Add some new test baselines and expectations.

        * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium-mac/canvas: Added.
        * platform/chromium-mac/canvas/philip: Added.
        * platform/chromium-mac/canvas/philip/tests: Added.
        * platform/chromium-mac/canvas/philip/tests/2d.drawImage.null-expected.txt: Added.
        * platform/chromium-mac/canvas/philip/tests/2d.pattern.image.null-expected.txt: Added.
        * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Wed, 29 Sep 2010 00:14:17 +0000 (00:14 +0000)]
2010-09-28  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        Delete and forward delete shouldn't start autocorrection panel timer.
        https://bugs.webkit.org/show_bug.cgi?id=46679
        <rdar://problem/8463917>

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::markMisspellingsAfterTyping): Only start correction panel timer
          when the editing command is InsertText.
        (WebCore::TypingCommand::typingAddedToOpenCommand): Add an argument to pass in command type.

        * editing/TypingCommand.h: Add an argument to typingAddedToOpenCommand().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPaint the plug-in backing store into the WebProcess backing store
andersca@apple.com [Wed, 29 Sep 2010 00:13:54 +0000 (00:13 +0000)]
Paint the plug-in backing store into the WebProcess backing store
https://bugs.webkit.org/show_bug.cgi?id=46768

Reviewed by Sam Weinig.

* DerivedSources.make:
Add PluginProxy.

* Platform/CoreIPC/MessageID.h:
Add PluginProxy message class.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Let the web process know that we've painted.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveMessage):
Pass the message on to a plug-in proxy.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Paint our backing store into the graphics context.

(WebKit::PluginProxy::controller):
Add notImplemented().

(WebKit::PluginProxy::update):
Blit the plug-in backing store into the local backing store and tell the plug-in
controller that we want to repaint.

* WebProcess/Plugins/PluginProxy.messages.in: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBegin hooking up painting in the plug-in process
andersca@apple.com [Tue, 28 Sep 2010 23:53:25 +0000 (23:53 +0000)]
Begin hooking up painting in the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=46766

Reviewed by Sam Weinig.

JavaScriptCore:

* JavaScriptCore.exp:
Add tryFastRealloc, used by WebKit2.

WebKit2:

* DerivedSources.make:
Add PluginControllerProxy.

* Platform/CoreIPC/MessageID.h:
Add a MessageClassPluginControllerProxy message class.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize the paint timer.

(WebKit::PluginControllerProxy::paint):
Create a graphics context referencing our backing store and paint into it.

(WebKit::PluginControllerProxy::invalidate):
Update the dirty rect and start the paint timer if necessary.

(WebKit::PluginControllerProxy::geometryDidChange):
If we're passed a new backing store handle, reinitialize the backing store.

* PluginProcess/PluginControllerProxy.messages.in: Added.
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
If the message has a destination ID, forward it to the plug-in controller proxy.

* Scripts/webkit2/messages.py:
Always include WebCoreArgumentCoders.h if the type is in the WebCore namespace.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Update the size of the backing store. Create a new plug-in backing store if needed and send
it over to the plug-in process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 28 Sep 2010 23:50:11 +0000 (23:50 +0000)]
2010-09-28  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dimitri Glazkov.

        No back/forward list entry added when submitting a form via an onclick handler inside a frame
        https://bugs.webkit.org/show_bug.cgi?id=44140

        Add tests for user-gesture initiated form submissions inside iframes to
        make sure that they generate back/forward list entries.

        * fast/history/form-submit-in-frame-expected.txt: Added.
        * fast/history/form-submit-in-frame-via-onclick-expected.txt: Added.
        * fast/history/form-submit-in-frame-via-onclick.html: Added.
        * fast/history/form-submit-in-frame.html: Added.
        * fast/history/resources/form-with-input-submit.html: Added.
        * fast/history/resources/form-with-onclick-submit.html: Added.
2010-09-28  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dimitri Glazkov.

        No back/forward list entry added when submitting a form via an onclick handler inside a frame
        https://bugs.webkit.org/show_bug.cgi?id=44140

        Lock the back/forward list for JavaScript form submissions inside frames
        only if they're not in response to user gestures.

        Tests: fast/history/form-submit-in-frame-via-onclick.html
               fast/history/form-submit-in-frame.html

        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::scheduleFormSubmission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 28 Sep 2010 23:42:59 +0000 (23:42 +0000)]
2010-09-28  Stephen White  <senorblanco@chromium.org>

        Unreviewed; new Chromium/Win test baselines.

        [CHROMIUM] These are tests we were passing on Chrome, but are now listed as failing due to r68568.  Adding platform-specific baselines should make us pass them again.

        * platform/chromium-win/canvas: Added.
        * platform/chromium-win/canvas/philip: Added.
        * platform/chromium-win/canvas/philip/tests: Added.
        * platform/chromium-win/canvas/philip/tests/2d.drawImage.null-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.pattern.image.null-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
        * platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 28 Sep 2010 23:34:27 +0000 (23:34 +0000)]
2010-09-28  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Keep the accelerated compositor around even after a page is
        done using it to avoid startup costs in pages that frequently switch
        the compositor on and off.
        https://bugs.webkit.org/show_bug.cgi?id=45845

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo in previous checkin.
hyatt@apple.com [Tue, 28 Sep 2010 23:19:15 +0000 (23:19 +0000)]
Fix typo in previous checkin.

Reviewed by Sam Weinig.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Tue, 28 Sep 2010 23:04:48 +0000 (23:04 +0000)]
2010-09-28  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] invalidateRootLayerRect needs to schedule compositor
        https://bugs.webkit.org/show_bug.cgi?id=46219

        Update comments on LayerChromium commit/display functions to clarify
        their limitations. Remove unused dirtying logic from
        LayerRendererChromium.

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::setNeedsCommit):
        (WebCore::LayerChromium::setNeedsDisplay):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::present):
        * platform/graphics/chromium/LayerRendererChromium.h:
2010-09-28  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] invalidateRootLayerRect needs to schedule compositor
        https://bugs.webkit.org/show_bug.cgi?id=46219

        Make sure setRootLayerNedsDisplay is called by root invalidation.
        To avoid confusion about root-layer versus non-root-layer
        behavior, move the root layer damage state to the WebView.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::scrollRootLayerRect):
        (WebKit::WebViewImpl::invalidateRootLayerRect):
        (WebKit::WebViewImpl::doComposite):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 28 Sep 2010 22:55:59 +0000 (22:55 +0000)]
2010-09-28  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        add python keyring support to webkit-patch
        https://bugs.webkit.org/show_bug.cgi?id=41269

        * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
            the python keyring module
        * Scripts/webkitpy/common/net/credentials_unittest.py:
        * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
        * Scripts/webkitpy/common/system/user_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Tue, 28 Sep 2010 22:52:23 +0000 (22:52 +0000)]
2010-09-28  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Fix perf/class-list-remove test
        https://bugs.webkit.org/show_bug.cgi?id=46745

        Make sure we precompute the className in the setup functions and that
        we reset it before calling classList.remove.

        * perf/class-list-remove.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 28 Sep 2010 22:50:58 +0000 (22:50 +0000)]
2010-09-28  Stephen White  <senorblanco@chromium.org>

        Unreviewed; new test baselines.

        [CHROMIUM] Update test baselines after r68561.

        * platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvement for FontLinux.
xji@chromium.org [Tue, 28 Sep 2010 22:43:34 +0000 (22:43 +0000)]
Performance improvement for FontLinux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvement for FontLinux.
xji@chromium.org [Tue, 28 Sep 2010 22:43:28 +0000 (22:43 +0000)]
Performance improvement for FontLinux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvement for FontLinux.
xji@chromium.org [Tue, 28 Sep 2010 22:43:22 +0000 (22:43 +0000)]
Performance improvement for FontLinux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvement for FontLinux.
xji@chromium.org [Tue, 28 Sep 2010 22:43:17 +0000 (22:43 +0000)]
Performance improvement for FontLinux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvement for FontLinux.
xji@chromium.org [Tue, 28 Sep 2010 22:43:11 +0000 (22:43 +0000)]
Performance improvement for FontLinux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvement for FontLinux.
xji@chromium.org [Tue, 28 Sep 2010 22:43:07 +0000 (22:43 +0000)]
Performance improvement for FontLinux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvement for FontLinux.
xji@chromium.org [Tue, 28 Sep 2010 22:43:02 +0000 (22:43 +0000)]
Performance improvement for FontLinux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPerformance improvment for FontLinux
xji@chromium.org [Tue, 28 Sep 2010 22:42:55 +0000 (22:42 +0000)]
Performance improvment for FontLinux

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Jenn Braithwaite <jennb@chromium.org>
commit-queue@webkit.org [Tue, 28 Sep 2010 22:27:30 +0000 (22:27 +0000)]
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        No new tests. API addition only. Will be used in separate patch.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::didTransferChildFrameToNewDocument):
        * loader/FrameLoaderClient.h:
        * page/Frame.cpp:
        (WebCore::Frame::transferChildFrameToNewDocument):
        Pass former page to didTransferChildFrameToNewDocument.
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::didTransferChildFrameToNewDocument):
        * src/FrameLoaderClientImpl.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::didTransferChildFrameToNewDocument):
        * WebCoreSupport/FrameLoaderClientHaiku.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::didTransferChildFrameToNewDocument):
        * WebCoreSupport/FrameLoaderClientQt.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
        * WebCoreSupport/WebFrameLoaderClient.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::didTransferChildFrameToNewDocument):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::didTransferChildFrameToNewDocument):
        * WebKitSupport/FrameLoaderClientWx.h:
2010-09-28  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Dmitry Titov.

        Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
        https://bugs.webkit.org/show_bug.cgi?id=46663

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::didTransferChildFrameToNewDocument):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Tue, 28 Sep 2010 22:26:00 +0000 (22:26 +0000)]
2010-09-28  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by James Robinson.

        Scaled Resized images are blurred when sent to Skia
        https://bugs.webkit.org/show_bug.cgi?id=42370

        * platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
        * platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/svg/custom/image-rescale-expected.checksum: Added.
        * platform/mac/svg/custom/image-rescale-expected.png: Added.
        * platform/mac/svg/custom/image-rescale-expected.txt: Added.
        * svg/custom/image-rescale.svg: Added.
        * svg/custom/resources/image-rescale.jpg: Added.
2010-09-28  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by James Robinson.

        Scaled Resized images are blurred when sent to Skia
        https://bugs.webkit.org/show_bug.cgi?id=42370

        This patch modifies ImageSkia.cpp to fix the calculation of resampled
        bitmap sizes so as to include the transform matrix of the canvas.

        Test: svg/custom/image-rescale.svg

        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::computeResamplingMode):
        (WebCore::drawResampledBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 28 Sep 2010 22:19:05 +0000 (22:19 +0000)]
2010-09-28  James Robinson  <jamesr@chromium.org>

        [chromium] Decrease warning level on chromium linux temporarily. This is causing failures on some bots

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Matthew Delaney <mdelaney@apple.com>
commit-queue@webkit.org [Tue, 28 Sep 2010 22:10:11 +0000 (22:10 +0000)]
2010-09-28  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Adele Peterson.

        Unskip remaining canvas layout tests so that they can track progressions/regressions
        https://bugs.webkit.org/show_bug.cgi?id=46439

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 28 Sep 2010 21:49:00 +0000 (21:49 +0000)]
2010-09-28  Stephen White  <senorblanco@chromium.org>

        Unreviewed; new test baselines.

        [CHROMIUM] New chromium baselines post-r68334.

        * platform/chromium-linux/fast/text/basic/014-expected.checksum:
        * platform/chromium-linux/fast/text/basic/014-expected.png:
        * platform/chromium-linux/fast/text/basic/014-expected.txt: Added.
        * platform/chromium-linux/fast/text/capitalize-boundaries-expected.checksum:
        * platform/chromium-linux/fast/text/capitalize-boundaries-expected.png:
        * platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
        * platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.checksum:
        * platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.png:
        * platform/chromium-linux/fast/text/softHyphen-expected.txt: Added.
        * platform/chromium-linux/fast/text/word-break-soft-hyphen-expected.txt: Added.
        * platform/chromium-mac/fast/text/basic/014-expected.checksum: Added.
        * platform/chromium-mac/fast/text/midword-break-after-breakable-char-expected.checksum: Added.
        * platform/chromium-mac/fast/text/midword-break-after-breakable-char-expected.png: Added.
        * platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
        * platform/chromium-win/fast/text/basic/014-expected.checksum:
        * platform/chromium-win/fast/text/basic/014-expected.png:
        * platform/chromium-win/fast/text/basic/014-expected.txt:
        * platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.checksum:
        * platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.png:
        * platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.txt:
        * platform/chromium-win/fast/text/softHyphen-expected.txt:
        * platform/chromium-win/fast/text/word-break-soft-hyphen-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 28 Sep 2010 21:48:54 +0000 (21:48 +0000)]
2010-09-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Increase warning level for chromium linux build
        https://bugs.webkit.org/show_bug.cgi?id=46687

        This sets the chromium_code gyp variable to 1 for the chromium
        linux WebCore build and fixes the warnings that exposes.  This
        matches the chromium mac build's compiler settings more closely
        and should cut down on the number of patches that break mac but
        compile cleaning on linux.

        * WebCore.gyp/WebCore.gyp:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::nextScriptRun):
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::getOutlinePoint):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
        * platform/graphics/gpu/Texture.cpp:
        (WebCore::copySubRect):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::setSize):
        * platform/image-decoders/gif/GIFImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for r68521 to build on VS2008/Release.
ossy@webkit.org [Tue, 28 Sep 2010 21:35:54 +0000 (21:35 +0000)]
Fix for r68521 to build on VS2008/Release.

Patch by Stephen White <senorblanco@chromium.org> on 2010-09-28
Reviewed by Csaba Osztrogonác.

* html/DocTypeStrings.gperf:
Don't emit "#include <string.h>" here, since we're inside a namespace.
* make-hash-tools.pl:
Emit #include <string.h> manually where required.
* platform/ColorData.gperf:
Don't emit "#include <string.h>" here, since we're inside a namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoASSERT when launching the plugin process
andersca@apple.com [Tue, 28 Sep 2010 21:27:11 +0000 (21:27 +0000)]
ASSERT when launching the plugin process
https://bugs.webkit.org/show_bug.cgi?id=46754
<rdar://problem/8484570>

Reviewed by Sam Weinig.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Don't assert if we fail to launch the process. Instead, set the connection identifier
and process ID to null and deallocate the port we created.

* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
Move all code from didClose here.

(WebKit::PluginProcessProxy::didClose):
Call pluginProcessCrashedOrFailedToLaunch.

(WebKit::PluginProcessProxy::didFinishLaunching):
If we failed to launch, call pluginProcessCrashedOrFailedToLaunch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRight now we have two properties named margin-top-collapse and margin-after-collapse...
hyatt@apple.com [Tue, 28 Sep 2010 21:16:50 +0000 (21:16 +0000)]
Right now we have two properties named margin-top-collapse and margin-after-collapse.  They are proprietary and only used by Safari RSS.

Reviewed by Sam Weinig.

I am adding margin-before-collapse and margin-after-collapse and just aliasing the old properties to the new ones.
This way we have some names that are directionally independent.

Note that these properties aren't like other directional properties.  They are about what to do with the before side and after side of
your block's margins when collapsing with adjacent blocks.  The meaning of before/after depend on the block-flow directionality
of the containing block.

Computed style tests all changed and the remove-shorthand.html test covers manipulation of the shorthand.

WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::layoutBlockChild):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::marginBeforeCollapse):
(WebCore::InheritedFlags::marginAfterCollapse):
(WebCore::InheritedFlags::setMarginBeforeCollapse):
(WebCore::InheritedFlags::setMarginAfterCollapse):
(WebCore::InheritedFlags::initialMarginBeforeCollapse):
(WebCore::InheritedFlags::initialMarginAfterCollapse):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

* fast/css/remove-shorthand-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, build sources that used to be built as part of other sources.
kevino@webkit.org [Tue, 28 Sep 2010 21:15:44 +0000 (21:15 +0000)]
[wx] Build fix, build sources that used to be built as part of other sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDifferentiate waitForSyncReply from waitForReply
andersca@apple.com [Tue, 28 Sep 2010 21:00:15 +0000 (21:00 +0000)]
Differentiate waitForSyncReply from waitForReply
https://bugs.webkit.org/show_bug.cgi?id=46752

Reviewed by Sam Weinig.

Since waitForSyncReply is going to need to dispatch incoming sync messages while
waiting for the correct reply, we need to add a new waitForSyncReply function that
can do this.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
Push the pending sync reply information on the m_pendingSyncReplies stack,
send the message, wait for a reply and pop the information off the stack.

(CoreIPC::Connection::waitForSyncReply):
Block while waiting for a reply to the sync message with the given ID.

(CoreIPC::Connection::processIncomingMessage):
If the incoming message is a sync reply, set the didReceiveReply flag and the replyDecoder
members in the pending sync reply and signal the client thread to wakeup.

* Platform/CoreIPC/Connection.h:
Add a stack of PendingSyncReply structs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 28 Sep 2010 20:45:44 +0000 (20:45 +0000)]
2010-09-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
        https://bugs.webkit.org/show_bug.cgi?id=46740

        Added a test adapted from platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html
        which verifies that when rendering text the GTK+ port follows FontConfig settings.

        * platform/gtk/fonts/fontconfig-aliasing-settings-expected.checksum: Added.
        * platform/gtk/fonts/fontconfig-aliasing-settings-expected.png: Added.
        * platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt: Added.
        * platform/gtk/fonts/fontconfig-aliasing-settings.html: Added.
2010-09-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
        https://bugs.webkit.org/show_bug.cgi?id=46740

        When creating a font from a FontConfig pattern, use the FontConfig pattern's
        hinting and anti-aliasing settings. This follows the Chromium Linux approach
        of having FontConfig settings take precedence over GTK+ settings, as GTK+
        settings cannot be configured per-font and per-font-size.

        Test: platform/gtk/fonts/fontconfig-aliasing-settings.html

        * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
        (WebCore::convertFontConfigSubpixelOrder): Added this helper which converts
        the FontConfig subpixel order into the cairo equivalent.
        (WebCore::convertFontConfigHintStyle): Added this helper which converts the
        FontConfig hint style into the cairo equivalent.
        (WebCore::setCairoFontOptionsFromFontConfigPattern): Added this helper which
        reads the font rendering settings from a pattern and translates them into the
        appropriate cairo_font_options_t settings.
        (WebCore::FontPlatformData::FontPlatformData): When creating a font from a
        FontConfig pattern use setCairoFontOptionsFromFontConfigPattern to get the
        appropriate rendering options for the font.
2010-09-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
        https://bugs.webkit.org/show_bug.cgi?id=46740

        * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
        fonts which can be used to fully test FontConfig rendering settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVertical scroll bar on apple.com is too short with WebKit2
weinig@apple.com [Tue, 28 Sep 2010 20:31:00 +0000 (20:31 +0000)]
Vertical scroll bar on apple.com is too short with WebKit2
<rdar://problem/8379230>
https://bugs.webkit.org/show_bug.cgi?id=46739

Reviewed by Darin Adler and Dave Hyatt.

WebCore:

Adds a function to recalculate the scrollbars to take advantage of
a changed window re-sizer rect.

* WebCore.exp.in:
* platform/ScrollView.cpp:
(WebCore::ScrollView::windowResizerRectChanged):
* platform/ScrollView.h:

WebKit2:

This gets us most of the way to having correct scroll corner behavior. We should
follow this up by moving to painting the window re-sizer in WebCore.

* UIProcess/API/mac/WKView.mm:
(-[WKView _ownsWindowGrowBox]):
(-[WKView _updateGrowBoxForWindowFrameChange]): Calculate whether we should
be taking the scroll corner into account when laying out scrollbars.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setWindowResizerSize):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setWindowResizerSize):
(WebKit::WebPage::windowResizerRect): This now returns IntRect() for
non-mac platforms (or any platform that never sends a setWindowResizerSize
message).
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=46750
hyatt@apple.com [Tue, 28 Sep 2010 20:28:10 +0000 (20:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46750

Reviewed by Sam Weinig.

Rename the MarginInfo members and functions to be block-flow independent.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::applyAfterBreak):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::MarginInfo::setAtBeforeSideOfBlock):
(WebCore::RenderBlock::MarginInfo::setAtAfterSideOfBlock):
(WebCore::RenderBlock::MarginInfo::setMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::setMarginAfterQuirk):
(WebCore::RenderBlock::MarginInfo::setDeterminedMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::atBeforeSideOfBlock):
(WebCore::RenderBlock::MarginInfo::canCollapseWithMarginBefore):
(WebCore::RenderBlock::MarginInfo::canCollapseWithMarginAfter):
(WebCore::RenderBlock::MarginInfo::canCollapseMarginBeforeWithChildren):
(WebCore::RenderBlock::MarginInfo::canCollapseMarginAfterWithChildren):
(WebCore::RenderBlock::MarginInfo::determinedMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::marginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::marginAfterQuirk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected result to include the soft hyphen character in the plain text output.
mitz@apple.com [Tue, 28 Sep 2010 20:19:43 +0000 (20:19 +0000)]
Updated expected result to include the soft hyphen character in the plain text output.

* fast/encoding/charset-xuser-defined-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68555 268f45cc-cd09-0410-ab3c-d52691b4dbfc