WebKit-https.git
13 years agoLayoutTests:
justing [Tue, 29 Aug 2006 00:35:05 +0000 (00:35 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/inserting/redo-expected.checksum: Added.
        * editing/inserting/redo-expected.png: Added.
        * editing/inserting/redo-expected.txt: Added.
        * editing/inserting/redo.html: Added.
        * editing/pasteboard/copy-paste-bidi-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4700341>
        REGRESSION: In new mail message, caret isn't placed at end of line after redoing typing

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME.
        * page/Frame.cpp:
        (WebCore::Frame::reappliedEditing): Restore the endingSelection(), not the startingSelection().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
tomernic [Tue, 29 Aug 2006 00:30:05 +0000 (00:30 +0000)]
    Reviewed by Darin Adler.

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView createPluginScriptableObject]):
        Removed a bogus typecast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
tomernic [Mon, 28 Aug 2006 23:18:36 +0000 (23:18 +0000)]
WebCore:

        Reviewed by John Sullivan.

        Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
        in Firefox

        No test cases added, since this is essentially a leak fix.

        A brief history of NPP_GetValue(), NPObjects, and reference counting.

        Earlier versions of WebKit incorrectly interpreted the NPRuntime reference counting rules.  We failed to take
        into account the fact that plug-ins are required to retain NPObjects before returning them.  This creates several
        classes of interesting plug-ins:

        1) Plug-ins tested in WebKit and other browsers.  These plug-ins may have WebKit-specific workarounds to not retain
           the returned NPObject, thus avoiding the memory leak in WebKit.

        2) Plug-ins tested only in other browsers.  These plug-ins must already retain their NPObjects, since other browsers
           implemented the NPRuntime retain/release rules correctly.  These plug-ins likely work in WebKit, but probably leak
           NPObjects since WebKit adds its own retain in addition to the plug-in's retain.

        3) Plug-ins tested only in WebKit, that fail to retain their NPObjects before returning them.
           Such plug-ins are guaranteed to crash in other browsers due to the missing expected retain.  These plug-ins
           work in older WebKits because WebKit did not expect the plug-in to retain the NPObject.  Now that our retain
           rules match other browsers, these plug-ins may crash due to the difference in retain/release behavior.  We could
           potentially detect that situation and correct it here, but I consider it a bug that the plug-in did not follow the
           documented NPRuntime reference counting rules.  Furthermore, it is extremely unlikely that someone would develop
           a Netscape plug-in and test it *only* in WebKit.  The entire purpose of creating a Netscape plugin is so that it
           works in all browsers!

        4) Plug-ins tested only in WebKit, that properly retain their NPObjects before returning them.
           These plug-ins probably work in other browsers, and leak their NPObjects in older WebKits because of WebKit's
           extra retain.  A developer of this type of plug-in is probably unaware of the NPObject leak.  A more savvy developer
           would create a plug-in that fits into category #1.

        I am changing our NPP_GetValue() behavior to match Firefox and other browsers -- the plug-in is now expected to retain the
        returned NPObject, and the browser is expected to release it when done.  This means that plug-ins in category #3 need to be
        changed so that they don't crash in Safari.  However, such plug-ins already crash in every other browser, so I do not feel that
        this needs to be handled specifically by WebKit.

        * bridge/mac/FrameMac.mm:
        Changed -pluginScriptableObject to -createPluginScriptableObject to make clearer the contract that the method must return a
        retained NPObject.  Also changed it to return an actual NPObject* instead of a void*.  There is only one caller of this method,
        and only one implementor.  Using void* here is a needless abstraction.  It's an NPObject*!  Admit it!
        (WebCore::getInstanceForView):
        Release the NPObject after creating the bindings instance.  This is the actual bug fix.

WebKit:

        Reviewed by John Sullivan.

        Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
        in Firefox

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView createPluginScriptableObject]):
        Renamed this method (see corresponding WebCore ChangeLog entry for an explanation).
        Style changes.

WebKitTools:

        Reviewed by John Sullivan.

        Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
        in Firefox

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
        (NPP_GetValue):
        WebKit's NPP_GetValue() reference counting behavior has been changed to match Firefox.  NPObject return values
        are expected to be retained by the plug-in, and released by the caller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
aliceli1 [Mon, 28 Aug 2006 20:43:36 +0000 (20:43 +0000)]
LayoutTests:

        Reviewed by Geoff.

       Added tests for <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

        * http/tests/misc/iframe-domain-test-expected.txt: Added.
        * http/tests/misc/iframe-domain-test.html: Added.

WebCore:

        Reviewed by Geoff.

        Fixed <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

        * dom/Document.cpp:
        (WebCore::Document::open):
        set the document's url to the parent's url and re-located the code that does this to occur before calling the frame's didExplicitOpen()
        * page/Frame.cpp:
        (WebCore::Frame::didExplicitOpen):
        set the frame's url to the document's url

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele and Adam
beidson [Mon, 28 Aug 2006 19:00:47 +0000 (19:00 +0000)]
    Reviewed by Adele and Adam

        Added an optimization to return early if there's no replacements to be made

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::replace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
ap [Mon, 28 Aug 2006 18:49:55 +0000 (18:49 +0000)]
2006-08-28  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by ap.

        Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
        Provide stub implementation of RenderPopupMenuQt.

        * CMakeLists.txt:
        * platform/qt/RenderPopupMenuQt.cpp: Added.
        (WebCore::RenderPopupMenuQt::RenderPopupMenuQt):
        (WebCore::RenderPopupMenuQt::~RenderPopupMenuQt):
        (WebCore::RenderPopupMenuQt::clear):
        (WebCore::RenderPopupMenuQt::populate):
        (WebCore::RenderPopupMenuQt::showPopup):
        (WebCore::RenderPopupMenuQt::hidePopup):
        (WebCore::RenderPopupMenuQt::addSeparator):
        (WebCore::RenderPopupMenuQt::addGroupLabel):
        (WebCore::RenderPopupMenuQt::addOption):
        * platform/qt/RenderPopupMenuQt.h: Added.
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::systemFont):
        (WebCore::RenderThemeQt::createPopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
ap [Mon, 28 Aug 2006 18:40:39 +0000 (18:40 +0000)]
2006-08-28  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by ap.

        Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
        Offer QString -> DeprecatedString conversion.

        * platform/DeprecatedString.h:
        * platform/qt/StringQt.cpp:
        (WebCore::DeprecatedString::DeprecatedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
ap [Mon, 28 Aug 2006 18:37:49 +0000 (18:37 +0000)]
2006-08-28  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Tim Hatcher.

        Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

WebCore:
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::systemFont):
        Remove annoying notImplemented() usage in systemFont()

WebKitTools:
        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in
        Qt's DumpRenderTree.

      * Scripts/run-webkit-tests:
        Use -expected-qt.txt etc.. output in run-webkit-test if isQt().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
darin [Mon, 28 Aug 2006 18:25:42 +0000 (18:25 +0000)]
    Reviewed by Geoff.

        * kjs/list.h: Use explicit in constructor (as appropriate).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Mon, 28 Aug 2006 18:22:49 +0000 (18:22 +0000)]
    Reviewed by Tim Hatcher.

        * Scripts/build-drosera: Fix behavior when there are multiple options.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher's rubberstamp
beidson [Mon, 28 Aug 2006 18:22:32 +0000 (18:22 +0000)]
    Reviewed by Tim Hatcher's rubberstamp

        Rolled out my last change (16070 - pruning WebFileDatabase code) as it caused a difficult-to-track down
        failure in layout tests on a release build.

        * Misc/WebFileDatabase.h:
        * Misc/WebFileDatabase.m:
        (+[WebFileDatabaseOp opWithCode:key:object:]):
        (-[WebFileDatabaseOp initWithCode:key:object:]):
        (-[WebFileDatabaseOp opcode]):
        (-[WebFileDatabaseOp key]):
        (-[WebFileDatabaseOp object]):
        (-[WebFileDatabaseOp perform:]):
        (-[WebFileDatabaseOp dealloc]):
        (SetThreadPriority):
        (-[WebFileDatabase _createLRUList:]):
        (-[WebFileDatabase _truncateToSizeLimit:]):
        (+[WebFileDatabase _syncLoop:]):
        (databaseInit):
        (-[WebFileDatabase setTimer]):
        (-[WebFileDatabase setObject:forKey:]):
        (-[WebFileDatabase removeObjectForKey:]):
        (-[WebFileDatabase removeAllObjects]):
        (-[WebFileDatabase objectForKey:]):
        (-[WebFileDatabase performSetObject:forKey:]):
        (-[WebFileDatabase performRemoveObjectForKey:]):
        (-[WebFileDatabase open]):
        (-[WebFileDatabase close]):
        (-[WebFileDatabase lazySync:]):
        (-[WebFileDatabase sync]):
        (-[WebFileDatabase sizeLimit]):
        (-[WebFileDatabase count]):
        (-[WebFileDatabase usage]):
        (-[WebFileDatabase setSizeLimit:]):
        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase _createFileDatabase]):
        (-[WebIconDatabase _loadIconDictionaries]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Mon, 28 Aug 2006 18:18:55 +0000 (18:18 +0000)]
    Reviewed by Tim Hatcher.

        * WebInspector/webInspector/inspector.js: Add "resize: none" to the list of
        default values for CSS properties so it will be omitted from most displays
        of computed style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
harrison [Mon, 28 Aug 2006 15:54:41 +0000 (15:54 +0000)]
    Reviewed by Darin.

        <rdar://problem/3942647> Support AXStyleTextMarkerRangeForTextMarker parameterized attribute

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
        Add AXStyleTextMarkerRangeForTextMarker.

        (startOfStyleRange):
        (endOfStyleRange):
        Return first/last VisiblePosition in range having the same style has the specified VisiblePosition.

        (-[WebCoreAXObject doAXStyleTextMarkerRangeForTextMarker:]):
        Return AXTextMarkerRange for startOfStyleRange/endOfStyleRange of the specified AXTextMarker.

        (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
        Call doAXStyleTextMarkerRangeForTextMarker for AXStyleTextMarkerRangeForTextMarker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
harrison [Mon, 28 Aug 2006 15:46:05 +0000 (15:46 +0000)]
    Reviewed by Darin.

        <rdar://problem/4517383> Hide all images used for spacing purpose in AX

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityIsIgnored]):
        Check for one-dimensional image
        Check whether rendered image was stretched from one-dimensional file image

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej
beidson [Mon, 28 Aug 2006 09:18:58 +0000 (09:18 +0000)]
    Reviewed by Maciej

        Major prune of unnecessary WebFileDatabase code.  In the end, what
        useful code that remains in WebFileDatabase will likely be moved directly
        into WebIconDatabase

        * Misc/WebFileDatabase.h:
        * Misc/WebFileDatabase.m:
        (-[WebFileDatabase initWithPath:]):
        (-[WebFileDatabase objectForKey:]):
        (-[WebFileDatabase open]):
        (-[WebFileDatabase close]):
        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase _createFileDatabase]):
        (-[WebIconDatabase _loadIconDictionaries]):
        * Misc/WebLRUFileList.h: Removed.
        * Misc/WebLRUFileList.m: Removed.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej
beidson [Mon, 28 Aug 2006 05:59:56 +0000 (05:59 +0000)]
    Reviewed by Maciej

        Rewrote StringImpl::replace(UChar, StringImpl*)

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::replace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Mon, 28 Aug 2006 03:33:34 +0000 (03:33 +0000)]
WebCore:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624
          WebCore needs autogenerated Obj-C DOM bindings

          First round of auto-generated Objective C DOM bindings, starting
          with the DOM Core.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMNode description]):
        (-[DOMNode KJS::Bindings::]):
        (-[DOMNode dispatchEvent:]):
        (-[DOMNamedNodeMap _initWithNamedNodeMap:]):
        (+[DOMNamedNodeMap _namedNodeMapWith:]):
        (-[DOMNodeList _initWithNodeList:]):
        (+[DOMNodeList _nodeListWith:]):
        (-[DOMImplementation _initWithDOMImplementation:]):
        (+[DOMImplementation _DOMImplementationWith:]):
        (-[DOMImplementation _DOMImplementation]):
        (+[DOMDocumentFragment _documentFragmentWith:]):
        (-[DOMDocumentFragment _fragment]):
        (-[DOMDocument createCSSStyleDeclaration]):
        (+[DOMDocument _documentWith:]):
        (-[DOMDocument _document]):
        (-[DOMDocument _ownerElement]):
        (+[DOMAttr _attrWith:]):
        (-[DOMAttr _attr]):
        (+[DOMDocumentType _documentTypeWith:WebCore::]):
        (-[DOMDocumentType WebCore::]):
        (+[DOMText _textWith:WebCore::]):
        (+[DOMComment _commentWith:WebCore::]):
        (+[DOMCDATASection _CDATASectionWith:WebCore::]):
        (+[DOMProcessingInstruction _processingInstructionWith:WebCore::]):
        (+[DOMEntityReference _entityReferenceWith:WebCore::]):
        * bindings/objc/DOMCSS.h:
        * bindings/objc/DOMCSS.mm:
        * bindings/objc/DOMCore.h:
        * bindings/objc/DOMEvents.h:
        * bindings/objc/DOMEvents.mm:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.mm:
        (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
        * bindings/objc/DOMHTMLInternal.h:
        * bindings/objc/DOMImplementationFront.h:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMNode.h: Added.
        * bindings/objc/DOMNode.mm: Added.
        (-[DOMNode dealloc]):
        (-[DOMNode finalize]):
        (-[DOMNode nodeName]):
        (-[DOMNode nodeValue]):
        (-[DOMNode setNodeValue:]):
        (-[DOMNode nodeType]):
        (-[DOMNode parentNode]):
        (-[DOMNode childNodes]):
        (-[DOMNode firstChild]):
        (-[DOMNode lastChild]):
        (-[DOMNode previousSibling]):
        (-[DOMNode nextSibling]):
        (-[DOMNode attributes]):
        (-[DOMNode ownerDocument]):
        (-[DOMNode insertBefore::]):
        (-[DOMNode replaceChild::]):
        (-[DOMNode removeChild:]):
        (-[DOMNode appendChild:]):
        (-[DOMNode hasChildNodes]):
        (-[DOMNode cloneNode:]):
        (-[DOMNode normalize]):
        (-[DOMNode isSupported::]):
        (-[DOMNode namespaceURI]):
        (-[DOMNode prefix]):
        (-[DOMNode setPrefix:]):
        (-[DOMNode localName]):
        (-[DOMNode hasAttributes]):
        (-[DOMNode isSameNode:]):
        (-[DOMNode isEqualNode:]):
        (-[DOMNode isDefaultNamespace:]):
        (-[DOMNode lookupPrefix:]):
        (-[DOMNode lookupNamespaceURI:]):
        (-[DOMNode textContent]):
        (-[DOMNode setTextContent:]):
        (-[DOMNode boundingBox]):
        (-[DOMNode lineBoxRects]):
        * bindings/objc/DOMObject.h: Added.
        * bindings/objc/DOMObject.mm: Added.
        (-[DOMObject init]):
        (-[DOMObject dealloc]):
        (-[DOMObject finalize]):
        (-[DOMObject copyWithZone:]):
        (-[DOMObject sheet]):
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/DOMRange.h:
        * bindings/objc/DOMStylesheets.h:
        * bindings/objc/DOMTraversal.h:
        * bindings/objc/DOMViews.h:
        * bindings/objc/DOMViews.mm:
        * bindings/objc/DOMXPath.h:
        * bindings/objc/DOMXPath.mm:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm: Added.
        * dom/Attr.idl:
        * dom/CDATASection.idl: Added.
        * dom/Comment.idl: Added.
        * dom/DOMImplementation.idl:
        * dom/Document.idl:
        * dom/Element.idl:
        * dom/EntityReference.idl: Added.
        * dom/NamedNodeMap.idl: Added.
        * dom/NodeList.idl: Added.
        * dom/ProcessingInstruction.idl:

WebKit:

        Reviewed by Tim H.

        - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624
          WebCore needs autogenerated Obj-C DOM bindings

          First round of auto-generated Objective C DOM bindings, starting
          with the DOM Core.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
thatcher [Mon, 28 Aug 2006 00:26:37 +0000 (00:26 +0000)]
    Reviewed by Anders.

        Drosera will be built when you type make.

        * Drosera/Makefile: Added.
        * Makefile: Added.
        * Makefile.shared: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Sun, 27 Aug 2006 23:12:17 +0000 (23:12 +0000)]
    Reviewed by Tim H.

        Fix crash in LayoutTests/css1/font_properties/font.html,
        by implementing FontData::smallCapsFontData.

        * platform/qt/FontDataQt.cpp:
        (WebCore::FontData::platformDestroy):
        (WebCore::FontData::smallCapsFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej
beidson [Sun, 27 Aug 2006 22:57:38 +0000 (22:57 +0000)]
    Reviewed by Maciej

        Plugged a leak in StringImpl::replace()

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::replace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Sun, 27 Aug 2006 22:29:23 +0000 (22:29 +0000)]
2006-08-27  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Remove most annoying notImplemented() usages and
        implement some missing ScrollViewQt functions.
        Much nicer output when invoking run-webkit-tests.

        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::saveDocumentState):
        (WebCore::FrameQt::restoreDocumentState):
        (WebCore::FrameQt::clearUndoRedoOperations):
        (WebCore::FrameQt::partClearedInBegin):
        * platform/qt/ResourceLoaderManager.cpp:
        (WebCore::headerCallback):
        (WebCore::ResourceLoaderManager::downloadTimerCallback):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::updateContents):
        (WebCore::ScrollView::suppressScrollBars):
        (WebCore::ScrollView::setStaticBackground):
        (WebCore::ScrollView::addChild):
        (WebCore::ScrollView::removeChild):
        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::historyContains):
        (WebCore::CheckCacheObjectStatus):
        (WebCore::CheckIfReloading):
        (loadResourceIntoArray):
        (WebCore::PlugInInfoStore::supportsMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot this too (doh!)
andersca [Sun, 27 Aug 2006 22:18:36 +0000 (22:18 +0000)]
Forgot this too (doh!)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDidn't mean to commit this!
andersca [Sun, 27 Aug 2006 22:07:09 +0000 (22:07 +0000)]
Didn't mean to commit this!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-27 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 27 Aug 2006 22:03:46 +0000 (22:03 +0000)]
2006-08-27  Anders Carlsson  <acarlsson@apple.com>

        Forgot to add these.

        * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::~DumpRenderTree):
        (WebCore::DumpRenderTree::open):
        (WebCore::DumpRenderTree::readStdin):
        (WebCore::DumpRenderTree::checkLoaded):
        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
        * DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Sun, 27 Aug 2006 21:53:16 +0000 (21:53 +0000)]
2006-08-27  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric, landed by Anders.

        Add DumpRenderTree support for Qt/Linux.

        * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::~DumpRenderTree):
        (WebCore::DumpRenderTree::open):
        (WebCore::DumpRenderTree::readStdin):
        (WebCore::DumpRenderTree::checkLoaded):
        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
        * DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
        (main):
        * Scripts/build-dumprendertree:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Sun, 27 Aug 2006 21:47:03 +0000 (21:47 +0000)]
2006-08-27  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Fix Qt build (add SVGMetaDataElement.cpp to build system)

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-27 Eric Seidel <eric@eseidel.com>
eseidel [Sun, 27 Aug 2006 21:40:51 +0000 (21:40 +0000)]
2006-08-27  Eric Seidel  <eric@eseidel.com>

        Reviewed by andersca.

        No logic changes.  Just cleanup.

        * ksvg2/svg/SVGAngle.cpp:
        (SVGAngle::SVGAngle):
        (SVGAngle::unitType):
        (SVGAngle::valueAsString):
        (SVGAngle::newValueSpecifiedUnits):
        (SVGAngle::convertToSpecifiedUnits):
        * ksvg2/svg/SVGAngle.h:
        * ksvg2/svg/SVGLength.cpp:
        (WebCore::SVGLength::unitType):
        (WebCore::SVGLength::newValueSpecifiedUnits):
        (WebCore::SVGLength::convertToSpecifiedUnits):
        (WebCore::SVGLength::updateValue):
        (WebCore::SVGLength::updateValueInSpecifiedUnits):
        * ksvg2/svg/SVGLength.h:
        * platform/BitmapImage.cpp: Removed.
        * platform/BitmapImage.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoGod, that ChangeLog entry was bad...
beidson [Sun, 27 Aug 2006 21:30:25 +0000 (21:30 +0000)]
God, that ChangeLog entry was bad...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders
beidson [Sun, 27 Aug 2006 21:28:40 +0000 (21:28 +0000)]
    Reviewed by Anders

        -Changed all of the commonly used queries to keep around pre-prepared statements and bind
        their arguments instead of constructing a messy.
        -Changed some code in pruneUnretainedIconsOnStartup regarding transactions

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase): Initializers
        (WebCore::IconDatabase::close): Wipe all the preprepared statements
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Better handling of transactions
        (WebCore::readySQLStatement): Make sure a preprepared statement is ready to go for a fooQuery()
        (WebCore::IconDatabase::pageURLTableIsEmptyQuery): Added a comment
        (WebCore::IconDatabase::imageDataForIconURLQuery): Use preprepared statement + binding
        (WebCore::IconDatabase::timeStampForIconURLQuery): ditto
        (WebCore::IconDatabase::iconURLForPageURLQuery): ditto
        (WebCore::IconDatabase::forgetPageURLQuery): ditto
        (WebCore::IconDatabase::setIconIDForPageURLQuery): ditto
        (WebCore::IconDatabase::getIconIDForIconURLQuery): ditto
        (WebCore::IconDatabase::addIconForIconURLQuery): ditto
        (WebCore::IconDatabase::hasIconForIconURLQuery): ditto
        * loader/icon/IconDatabase.h: Added fooQuery() and *m_fooStatements
        * loader/icon/SQLStatement.h:
        (WebCore::SQLStatement::database): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Sun, 27 Aug 2006 19:27:34 +0000 (19:27 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        Fix switch logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Sun, 27 Aug 2006 10:47:15 +0000 (10:47 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10557
        KCanvasPath should be replace by platform/Path

        Refactoring out the KCanvasPath class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-26 Eric Seidel <eric@eseidel.com>
eseidel [Sun, 27 Aug 2006 07:09:16 +0000 (07:09 +0000)]
2006-08-26  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        pointer-events attribute does not work.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10415

        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::pointerEventsHitRules): new function to contain pointer-events hit logic
        (WebCore::RenderPath::nodeAtPoint): respect pointer-events property
        * kcanvas/RenderPath.h:
        (WebCore::RenderPath::PointerEventsHitRules::PointerEventsHitRules):
        * ksvg2/css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        * ksvg2/svg/SVGPaint.cpp: Fix this to use a real enum value
        (WebCore::SVGPaint::SVGPaint):
        (WebCore::SVGPaint::paintType):
        (WebCore::SVGPaint::uri):
        (WebCore::SVGPaint::setUri):
        (WebCore::SVGPaint::setPaint):
        * ksvg2/svg/SVGPaint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Sat, 26 Aug 2006 22:45:36 +0000 (22:45 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
        SVG should have support for <metadata> element

        Add support for metadata tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
ap [Sat, 26 Aug 2006 09:51:46 +0000 (09:51 +0000)]
    Reviewed by Eric.

        Daily Qt build fixes :-)

        * platform/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawConvexPolygon):
        * platform/qt/ImageQt.cpp:
        (WebCore::Image::initPlatformData):
        (WebCore::Image::invalidatePlatformData):
        (WebCore::Image::loadPlatformResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix the ifdef in Path.h to be CG.
hyatt [Sat, 26 Aug 2006 08:11:39 +0000 (08:11 +0000)]
    Fix the ifdef in Path.h to be CG.

        * platform/Path.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Mac build bustage (lots of float/int confusion). I am not sure
hyatt [Sat, 26 Aug 2006 07:48:51 +0000 (07:48 +0000)]
    Fix Mac build bustage (lots of float/int confusion).  I am not sure
        whether rounding was desired or not... this is just a band-aid to get
        the build working again.

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintMenuListButton):
        (WebCore::RenderThemeMac::adjustMenuListButtonStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago More refactoring of image to disentangle graphics (e.g., Cairo) from
hyatt [Sat, 26 Aug 2006 06:49:35 +0000 (06:49 +0000)]
    More refactoring of image to disentangle graphics (e.g., Cairo) from
        platform (e.g., Windows).

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        Add ImageWin to project.

        * loader/Cache.cpp:
        (WebCore::Cache::init):
        * loader/icon/IconDataCache.cpp:
        (WebCore::IconDataCache::loadImageFromResource):
        Renamed loadResource to loadPlatformResource to try to make it more clear
        that this call is implemented on each OS (and not by graphics libraries).

        * platform/Image.cpp:
        (WebCore::Image::Image):
        (WebCore::Image::~Image):
        (WebCore::Image::invalidateData):
        (WebCore::Image::size):
        (WebCore::Image::setData):
        (WebCore::Image::setNativeData):
        Fix up the PDF code to not be considered platform data any more, since
        PDF rendering is not for a specific OS.

        Renamed the methods that set OS-specific data (like NSImage) to PlatformData
        instead of NativeData.

        * platform/Image.h:
        Shifted the PDF members into CG defines.  Made CGImageRef a CG define.
        Renamed methods to reflect that they are OS-specific and not
        graphics-library-specific.

        * platform/cairo/ImageCairo.cpp:
        Removed the platform data methods.  Other platforms besides Windows that
        use Cairo will need to account for this change by adding these methods
        to their OS Image***.cpp file.

        * platform/cg/ImageCG.cpp:
        (WebCore::Image::drawTiled):
        Add FIXMEs to the wkpattern stuff.

        * platform/cg/PDFDocumentImage.cpp:
        Shouldn't have #imports in .cpp.

        * platform/mac/ImageMac.mm:
        (WebCore::Image::initPlatformData):
        (WebCore::Image::invalidatePlatformData):
        (WebCore::Image::loadPlatformResource):
        (WebCore::Image::getTIFFRepresentation):
        Add the platform data initializers to the Mac Image file.   Move the
        TIFF representation there as well, since this is only used by Mac code.

        * platform/win/ImageWin.cpp: Added.
        (WebCore::Image::initPlatformData):
        (WebCore::Image::invalidatePlatformData):
        (WebCore::Image::loadPlatformResource):
        (WebCore::Image::supportsType):
        Similar work for Windows.  Add stubs for possible future HBITMAP returns
        in the platform data methods.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintResizeControl):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintResizeControl):
        loadResource -> loadPlatformResource

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Adele.
aroben [Sat, 26 Aug 2006 01:59:04 +0000 (01:59 +0000)]
    Rubber-stamped by Adele.

        Fixed build.

        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawConvexPolygon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher
beidson [Sat, 26 Aug 2006 00:37:05 +0000 (00:37 +0000)]
    Reviewed by Tim Hatcher

        Fixed up some leaks on [WebIconDatabase init]

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Sat, 26 Aug 2006 00:33:22 +0000 (00:33 +0000)]
LayoutTests:

        Updated results for addition of -webkit-text-security.

        * fast/css/computed-style-expected.txt:

WebCore:

        Patch by Francisco, Reviewed by me.

        Preparation for switch to new text field implementation of password field.

        Added -webkit-text-security property.

        Tests: updated fast/css/computed-style-expected.txt

        * css/CSSPropertyNames.in: Added -webkit-text-security.
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added cases for textSecurity.
        * css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto.
        * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
        * css/html4.css: Added style for password field to use -webkit-text-security.

        * html/HTMLInputElement.cpp: Check appearance property to decide which renderer to use.
        (WebCore::HTMLInputElement::selectionStart):
        (WebCore::HTMLInputElement::selectionEnd):
        (WebCore::HTMLInputElement::setSelectionStart):
        (WebCore::HTMLInputElement::setSelectionEnd):
        (WebCore::HTMLInputElement::select):
        (WebCore::HTMLInputElement::setSelectionRange):
        (WebCore::HTMLInputElement::createRenderer):
        * html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): Added check for password.

        * platform/StringImpl.cpp: (WebCore::StringImpl::secure): Added. Converts a string to replace
         characters with one character, like a bullet.
        * platform/StringImpl.h:

        * rendering/RenderStyle.cpp:
        (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): Initialize textSecurity.
        (WebCore::RenderStyle::diff): Added case for textSecurity.
        * rendering/RenderStyle.h:
        (WebCore::):
        (WebCore::RenderStyle::textSecurity): Added.
        (WebCore::RenderStyle::setTextSecurity): Added.
        (WebCore::RenderStyle::initialTextSecurity): Added.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setStyle): Added case for textSecurity.
        (WebCore::RenderText::setText): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Fri, 25 Aug 2006 23:44:05 +0000 (23:44 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        New tests and updated tests for styled selects.

        * fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
        * fast/borders/borderRadiusInvalidColor-expected.png: Added.
        * fast/borders/borderRadiusInvalidColor-expected.txt: Added.
        * fast/borders/borderRadiusInvalidColor.html: Added.

        * fast/forms/select-baseline-expected.checksum: Added.
        * fast/forms/select-baseline-expected.png: Added.
        * fast/forms/select-baseline-expected.txt: Added.
        * fast/forms/select-baseline.html: Added.

        * editing/pasteboard/4641033-expected.txt:
        * editing/selection/replaced-boundaries-3-expected.txt:
        * editing/selection/select-box-expected.txt:
        * fast/block/margin-collapse/103-expected.txt:
        * fast/forms/001-expected.checksum:
        * fast/forms/001-expected.png:
        * fast/forms/001-expected.txt:
        * fast/forms/003-expected.txt:
        * fast/forms/004-expected.txt:
        * fast/forms/HTMLOptionElement_label01-expected.txt:
        * fast/forms/HTMLOptionElement_label02-expected.txt:
        * fast/forms/HTMLOptionElement_label03-expected.txt:
        * fast/forms/HTMLOptionElement_label04-expected.txt:
        * fast/forms/HTMLOptionElement_label06-expected.txt:
        * fast/forms/HTMLOptionElement_label07-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/option-script-expected.txt:
        * fast/forms/option-text-clip-expected.txt:
        * fast/forms/select-change-listbox-to-popup-expected.txt:
        * fast/forms/select-selected-expected.txt:
        * fast/forms/select-style-expected.txt:
        * fast/forms/select-visual-hebrew-expected.txt:
        * fast/invalid/014-expected.txt:
        * fast/parser/document-write-option-expected.txt:
        * fast/replaced/width100percent-expected.txt:
        * http/tests/navigation/anchor-basic-expected.txt:
        * http/tests/navigation/anchor-frames-expected.txt:
        * http/tests/navigation/anchor-goback-expected.txt:
        * http/tests/navigation/anchor-subframeload-expected.txt:
        * http/tests/navigation/javascriptlink-basic-expected.txt:
        * http/tests/navigation/javascriptlink-frames-expected.txt:
        * http/tests/navigation/javascriptlink-goback-expected.txt:
        * http/tests/navigation/javascriptlink-subframeload-expected.txt:
        * http/tests/navigation/metaredirect-basic-expected.txt:
        * http/tests/navigation/metaredirect-frames-expected.txt:
        * http/tests/navigation/metaredirect-goback-expected.txt:
        * http/tests/navigation/metaredirect-subframeload-expected.txt:
        * http/tests/navigation/post-goback2-expected.txt:
        * http/tests/navigation/postredirect-goback2-expected.txt:
        * http/tests/navigation/redirect302-basic-expected.txt:
        * http/tests/navigation/redirect302-frames-expected.txt:
        * http/tests/navigation/redirect302-goback-expected.txt:
        * http/tests/navigation/redirect302-subframeload-expected.txt:
        * http/tests/navigation/relativeanchor-basic-expected.txt:
        * http/tests/navigation/relativeanchor-frames-expected.txt:
        * http/tests/navigation/relativeanchor-goback-expected.txt:
        * http/tests/navigation/slowmetaredirect-basic-expected.txt:
        * http/tests/navigation/slowtimerredirect-basic-expected.txt:
        * http/tests/navigation/success200-basic-expected.txt:
        * http/tests/navigation/success200-frames-expected.txt:
        * http/tests/navigation/success200-frames-loadsame-expected.txt:
        * http/tests/navigation/success200-goback-expected.txt:
        * http/tests/navigation/success200-loadsame-expected.txt:
        * http/tests/navigation/success200-reload-expected.txt:
        * http/tests/navigation/success200-subframeload-expected.txt:
        * http/tests/navigation/timerredirect-basic-expected.txt:
        * http/tests/navigation/timerredirect-frames-expected.txt:
        * http/tests/navigation/timerredirect-goback-expected.txt:
        * http/tests/navigation/timerredirect-subframeload-expected.txt:
        * tables/mozilla/bugs/bug1188-expected.txt:
        * tables/mozilla/bugs/bug18359-expected.txt:
        * tables/mozilla/bugs/bug2479-3-expected.txt:
        * tables/mozilla/bugs/bug2479-4-expected.txt:
        * tables/mozilla/bugs/bug29326-expected.txt:
        * tables/mozilla/bugs/bug33855-expected.txt:
        * tables/mozilla/bugs/bug4382-expected.txt:
        * tables/mozilla/bugs/bug96334-expected.txt:
        * tables/mozilla/core/margins-expected.txt:
        * tables/mozilla/dom/tableDom-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

WebCore:

        Reviewed by Hyatt.

        Enable styling for popup menus. Also fixed baseline calculation for buttons and selects.

        Tests:   fast/forms/select-baseline.html
                 fast/borders/borderRadiusInvalidColor.html
        updated: fast/forms/select-style-expected.txt and more...

        * css/html4.css: Added style rules for styled select elements.

        * platform/GraphicsContext.h: Added argument for antialiasing.
        * platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
        * platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBorderArc): Added textColor argument so this can be used when the border color is invalid.
        (WebCore::RenderObject::drawBorder): Removed invalidisInvert since its dead code
         (any callers that set this to true were already ensuring that their color was valid).
         Updated drawConvexPolygon call to use FloatPoints instead of IntPoints.
        (WebCore::RenderObject::paintBorder): Updated to remove invalidisInvert argument from drawBorder call.
        (WebCore::RenderObject::paintOutline): ditto.
        * rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutlineForLine): ditto.
        * rendering/RenderObject.h: Updated arguments for drawBorder and drawBorderArc.

        * rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): Changed isRootLineBox argument to true when setting line height.
          Added case for when there's no children to check for hasLineIfEmpty.
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Changed isRootLineBox argument to true when setting line height.
        * rendering/RenderButton.h: (WebCore::RenderButton::hasLineIfEmpty): Added so buttons always get a line height.
        * rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasLineIfEmpty): ditto.
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutHorizontalBox): Added code to check hasLineIfEmpty to give flex boxes line height.
        (WebCore::RenderFlexibleBox::layoutVerticalBox): ditto.

        * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Moved the appearance adjustment code into adjust style.
        * rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Lets the theme paint "decorations", like the arrow control and gradients
         immediately after painting the background.

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle): This now checks whether the control is styled, and adjusts the appearance property appropriately.
        For styled selects, instead of setting the appearance to none, which is what we do for other styled controls, we set the appearance
        to MenulistButtonAppearance, which indicates that we will draw the arrow controls and button appearance in the engine.
        (WebCore::RenderTheme::paintDecorations): Added. Paints MenulistButtonAppearance in a different function,
         so the arrow control will draw at the right time (after the background).
        (WebCore::RenderTheme::paint): Added case for MenulistButtonAppearance.
        (WebCore::RenderTheme::paintBorderOnly): ditto.
        (WebCore::RenderTheme::isControlContainer): Removed cases for MenuListAppearance and MenulistButtonAppearance since the baseline is no longer provided by the theme.
        (WebCore::RenderTheme::adjustMenuListButtonStyle): Added.
        * rendering/RenderTheme.h: (WebCore::RenderTheme::paintMenuListButton): Added.

        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::isControlStyled): Removed code that made selects unstyle-able.
        (WebCore::RenderThemeMac::baselinePosition): Removed cases for MenuListAppearance and MenulistButtonAppearance.
        (WebCore::RenderThemeMac::popupButtonPadding): Added top and bottom padding so empty popups have the right baseline.
        (WebCore::TopGradientInterpolate): Added.
        (WebCore::BottomGradientInterpolate): Added.
        (WebCore::MainGradientInterpolate): Added.
        (WebCore::RenderThemeMac::paintMenuListButtonGradients): Added.  Draws gradients for styled popup menu button appearance.
        (WebCore::RenderThemeMac::paintMenuListButton): Calls paintMenuListButtonGradients, and draws arrow control.
        (WebCore::RenderThemeMac::adjustMenuListButtonStyle): Added to set padding and border radius to account for the arrow control size and font size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam
beidson [Fri, 25 Aug 2006 22:57:07 +0000 (22:57 +0000)]
    Reviewed by Adam

        Changed some time()-related code to be more platform independent

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::isIconExpiredForIconURL):
        (WebCore::IconDatabase::getOrCreateIconDataCache):
        (WebCore::IconDatabase::setIconDataForIconURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
harrison [Fri, 25 Aug 2006 22:25:54 +0000 (22:25 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4416432> Radio buttons and Checkboxes in AXWebAreas don't fill in their AXTitle attribute

        * bridge/mac/WebCoreAXObject.mm:
        (labelForElement):
        New. Returns the HTMLLabelElement, if any, for the specified Element.

        (-[WebCoreAXObject title]):
        For input elements, return the innerHTML() of the labelForElement().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher
beidson [Fri, 25 Aug 2006 21:28:33 +0000 (21:28 +0000)]
    Reviewed by Tim Hatcher

        Changed some debugging-only code to be more platform independent

        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
        (WebCore::IconDatabase::syncDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed/landed by Adam.
aroben [Fri, 25 Aug 2006 18:23:47 +0000 (18:23 +0000)]
    Reviewed/landed by Adam.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10561
        Qt platform build fixes.

        * platform/qt/FrameQt.h:
        * platform/qt/ScreenQt.cpp:
        (WebCore::qwidgetForPage):
        (WebCore::screenRect):
        (WebCore::screenDepth):
        (WebCore::usableScreenRect):
        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        * platform/qt/WidgetQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed/landed by Adam.
aroben [Fri, 25 Aug 2006 16:51:15 +0000 (16:51 +0000)]
    Reviewed/landed by Adam.

        Finally fix font caching. WebKit+Qt now works
        out of the box without any further patches :-)

        * platform/qt/FontDataQt.cpp:
        (WebCore::FontData::platformDestroy):
        * platform/qt/FontPlatformData.h:
        * platform/qt/FontPlatformDataQt.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::isFixedPitch):
        (WebCore::FontPlatformData::font):
        (WebCore::FontPlatformData::fontPtr):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::operator==):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed/landed by Adam.
aroben [Fri, 25 Aug 2006 16:46:35 +0000 (16:46 +0000)]
    Reviewed/landed by Adam.

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10559
        Confirm to WebKit style guide - last fixes :-)

        * platform/ResourceLoaderClient.h:
        * platform/qt/ComboBoxQt.cpp:
        * platform/qt/FrameQt.cpp:
        (WebCore::doScroll):
        (WebCore::FrameQt::FrameQt):
        (WebCore::FrameQt::openURL):
        (WebCore::FrameQt::submitForm):
        (WebCore::FrameQt::setTitle):
        (WebCore::FrameQt::passSubframeEventToSubframe):
        (WebCore::FrameQt::registerCommandForUndo):
        (WebCore::FrameQt::registerCommandForRedo):
        (WebCore::FrameQt::keyEvent):
        (WebCore::FrameQt::setFrameGeometry):
        * platform/qt/GlyphMapQt.cpp:
        (WebCore::GlyphMap::fillPage):
        * platform/qt/GraphicsContextQt.cpp:
        (WebCore::toQtCompositionMode):
        (WebCore::toQtLineCap):
        (WebCore::toQtLineJoin):
        (WebCore::TextShadow::TextShadow):
        (WebCore::GraphicsContextPlatformPrivate::p):
        * platform/qt/ImageQt.cpp:
        (WebCore::FrameData::clear):
        (WebCore::Image::supportsType):
        * platform/qt/IntSizeQt.cpp:
        * platform/qt/LineEditQt.cpp:
        * platform/qt/ListBoxQt.cpp:
        * platform/qt/PageQt.cpp:
        (WebCore::Page::windowRect):
        * platform/qt/PathQt.cpp:
        (WebCore::Path::~Path):
        * platform/qt/ResourceLoaderCurl.cpp:
        (WebCore::ResourceLoader::assembleResponseHeaders):
        (WebCore::ResourceLoader::retrieveCharset):
        (WebCore::ResourceLoader::receivedResponse):
        * platform/qt/ResourceLoaderManager.cpp:
        (WebCore::headerCallback):
        (WebCore::ResourceLoaderManager::downloadTimerCallback):
        (WebCore::ResourceLoaderManager::add):
        * platform/qt/ScreenQt.cpp:
        (WebCore::screenRect):
        (WebCore::usableScreenRect):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::~ScrollView):
        (WebCore::ScrollView::setParentWidget):
        (WebCore::ScrollView::addChild):
        * platform/qt/SharedTimerQt.cpp:
        (WebCore::setSharedTimerFiredFunction):
        * platform/qt/SharedTimerQt.h:
        (WebCore::SharedTimerQt::SharedTimerQt):
        (WebCore::SharedTimerQt::fire):
        * platform/qt/SystemTimeQt.cpp:
        (WebCore::currentTime):
        * platform/qt/TextEditQt.cpp:
        (WebCore::PlatformTextEdit::setParentWidget):
        (WebCore::PlatformTextEdit::text):
        (WebCore::PlatformTextEdit::sizeWithColumnsAndRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Fri, 25 Aug 2006 04:04:37 +0000 (04:04 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=10444
          Navigation links overlap the Spam Karma 2 footer

        * blog/wp-content/themes/webkit/style.css: Hide the footer altogether.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Fri, 25 Aug 2006 00:41:15 +0000 (00:41 +0000)]
    Reviewed by Darin.

        * WebView/WebFrame.m:
        (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
        * WebView/WebView.m:
        (-[WebViewPrivate dealloc]): release the background color

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Justin.
harrison [Fri, 25 Aug 2006 00:32:30 +0000 (00:32 +0000)]
    Reviewed by Justin.

        Follow up for...
        <rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange

        Fix bug I introduced in r15959.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Use topDocument in case we are in a subframe (we want the start/end of the overall page).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alice
beidson [Thu, 24 Aug 2006 23:50:43 +0000 (23:50 +0000)]
    Reviewed by Alice

        Fixed my previous checkin, which was pruning the users entire icon db on startup everytime

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings
          are indexed to 1, not 0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@16028 268f45cc-cd09-0410...
ggaren [Thu, 24 Aug 2006 23:32:11 +0000 (23:32 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Thu, 24 Aug 2006 23:09:34 +0000 (23:09 +0000)]
WebCore:

        Reviewed by Hyatt.

        Allow changing the background color WebCore draws under transparent page backgrounds.
        No automated way to test. All tests pass, no performance regression.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge setBaseBackgroundColor:]):
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameView::baseBackgroundColor):
        (WebCore::FrameView::setBaseBackgroundColor):
        * page/FrameView.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):

WebKit:

        Reviewed by Hyatt.

        WebView API to allow changing the background color that draws under transparent page backgrounds.

        * WebView/WebFrame.m:
        (-[WebFrame _makeDocumentView]):
        (-[WebFrame _updateBackground]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFrameView.m:
        (-[WebFrameView drawRect:]):
        * WebView/WebView.m:
        (-[WebView setBackgroundColor:]):
        (-[WebView backgroundColor]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (-[WebView setDrawsBackground:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Thu, 24 Aug 2006 22:07:45 +0000 (22:07 +0000)]
LayoutTests:

        Reviewed by Justin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
          REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears

        * fast/forms/drag-into-textarea-expected.txt: Added.
        * fast/forms/drag-into-textarea.html: Added.

WebCore:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
          REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
        - eliminate the EditCommandPtr class from editing; use PassRefPtr and RefPtr instead
        - other editing-related cleanup

        Test: fast/forms/drag-into-textarea.html

        * bridge/mac/FrameMac.h: Changed EditCommandPtr parameters to use PassRefPtr<EditCommand> instead.
        * bridge/win/FrameWin.h: Ditto.
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::registerCommandForUndoOrRedo): Ditto.
        (WebCore::FrameMac::registerCommandForUndo): Ditto.
        (WebCore::FrameMac::registerCommandForRedo): Ditto.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        Use applyCommand instead of EditCommandPtr. Also remove now-unneeded document parameter.
        (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): Ditto.
        (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): Ditto.

        * editing/AppendNodeCommand.h: Removed document parameter from constructor. Changed new child
        parameter to be a PassRefPtr. Reversed order of child and parent parameters.
        * editing/AppendNodeCommand.cpp:
        (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
        (WebCore::AppendNodeCommand::doApply): Ditto.
        (WebCore::AppendNodeCommand::doUnapply): Ditto.

        * editing/ApplyStyleCommand.h: Removed document parameter from constructor.
        * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Ditto.

        * editing/BreakBlockquoteCommand.h: Removed unneeded include of DeprecatedPtrList.h.
        * editing/BreakBlockquoteCommand.cpp: Moved the include of DeprecatedPtrList.h here.
        (WebCore::BreakBlockquoteCommand::doApply): Changed code to construct a Selection explicitly
        since setEndingSelection is no longer overloaded for Position.

        * editing/CompositeEditCommand.h: Added isFirstCommand function. Changed m_cmds from
        a DeprecatedValueList<EditCommandPtr> to a Vector<RefPtr<EditCommand>> and renamed it
        m_commands and made both doUnapply and doReapply private.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::doUnapply): Rewrote to use m_commands.
        (WebCore::CompositeEditCommand::doReapply): Ditto.
        (WebCore::CompositeEditCommand::applyCommandToComposite): Removed code to explicitly set up
        starting and ending selection -- now done inside setParent. Rewrote to use m_commands.
        (WebCore::CompositeEditCommand::applyStyle): Changed to not use EditCommandPtr.
        (WebCore::CompositeEditCommand::applyStyledElement): Ditto.
        (WebCore::CompositeEditCommand::removeStyledElement): Ditto.
        (WebCore::CompositeEditCommand::insertParagraphSeparator): Ditto.
        (WebCore::CompositeEditCommand::insertNodeBefore): Ditto.
        (WebCore::CompositeEditCommand::appendNode): Ditto.
        (WebCore::CompositeEditCommand::removeNode): Ditto.
        (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
        (WebCore::CompositeEditCommand::splitTextNode): Ditto.
        (WebCore::CompositeEditCommand::splitElement): Ditto.
        (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto.
        (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto.
        (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto.
        (WebCore::CompositeEditCommand::joinTextNodes): Ditto.
        (WebCore::CompositeEditCommand::inputText): Ditto.
        (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto.
        (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto.
        (WebCore::CompositeEditCommand::replaceTextInNode): Ditto.
        (WebCore::CompositeEditCommand::deleteSelection): Ditto.
        (WebCore::CompositeEditCommand::removeCSSProperty): Ditto.
        (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Also fixed a bug where the code
        would not remove an empty attribute -- will not come up in practice, but wrong in theory.
        (WebCore::CompositeEditCommand::setNodeAttribute): Changed to not use EditCommandPtr.
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto.
        (WebCore::CompositeEditCommand::deleteInsignificantText): Rewrote to use a for loop.
        (WebCore::CompositeEditCommand::moveParagraphs): Changed to not use EditCommandPtr.
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Changed code to construct a
        Selection explicitly since setEndingSelection is no longer overloaded for Position.
        (WebCore::createBlockPlaceholderElement): Collapsed this code so that the
        block placeholder class string is no longer spread across multiple functions.
        Perhaps we can get rid of this altogether at some point.

        * editing/DeleteFromTextNodeCommand.h: Removed unneeded document parameter from one constructor.
        Also removed unneeded destructor.
        * editing/DeleteFromTextNodeCommand.cpp:
        (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Ditto.

        * editing/DeleteSelectionCommand.h: Removed unneeded document parameter from one constructor.
        * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Ditto.

        * editing/EditCommand.h: Removed ECommandState, isCompositeStep(), parent(), state(), setState(),
        and most overloads of setStartingSelection() and setEndingSelection(). Made document() protected
        and non-virtual. Made setStartingSelection() setEndingSelection(), and styleAtPosition() protected.
        Made doApply(), doUnapply(), and doReapply() private. Added startingRootEditableElement(),
        endingRootEditableElement(), m_startingRootEditableElement, and m_endingRootEditableElement, which
        are needed so we can determine which editable elements an editing operation affects. Changed setParent()
        and m_parent to use CompositeEditCommand instead of EditCommand. Removed EditCommandPtr. Added
        applyCommand() function that's convenient to use on a newly-created command.
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand): Removed initialization for m_state, and added it for starting
        and ending root editable elements.
        (WebCore::EditCommand::apply): Simplified check for top level by just checking m_parent. Removed
        code to assert and set m_start. Eliminated use of EditCommandPtr.
        (WebCore::EditCommand::unapply): Ditto.
        (WebCore::EditCommand::reapply): Ditto.
        (WebCore::EditCommand::setStartingSelection): Changed to set root editable element too. Also made this
        not change the starting selection of the parent unless this is the first command in the parent -- didn't
        make sense the way it was.
        (WebCore::EditCommand::setEndingSelection): Changed to set root editable element too.
        (WebCore::EditCommand::setParent): Added code to set the starting and ending selection on the child
        based on the ending selection of the parent, formerly done by callers.
        (WebCore::applyCommand): Added.

        * editing/FormatBlockCommand.h: Tweaked formatting.
        * editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Ditto.
        * editing/InsertLineBreakCommand.h: Ditto.
        * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::splitTreeToNode): Removed use of EditCommandPtr.
        (WebCore::IndentOutdentCommand::outdentParagraph): Updated for change to list type enum.
        (WebCore::IndentOutdentCommand::outdentRegion): Removed use of EditCommandPtr.

        * editing/InsertIntoTextNodeCommand.h: Removed unneeded document parameter to constructor.
        * editing/InsertIntoTextNodeCommand.cpp:
        (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Ditto.

        * editing/InsertListCommand.h: Renamed EListType to EList, and took the "Type" suffix off
        the constants.
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::InsertListCommand): Ditto.
        (WebCore::InsertListCommand::doApply): Ditto.

        * editing/InsertNodeBeforeCommand.h: Removed unneeded document parameter from constructor
        and changed the parameter of the node to insert to a PassRefPtr.
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Remvoed use of EditCommandPtr.

        * editing/InsertTextCommand.h: Changed insertTab to take const Position&.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Ditto.
        (WebCore::InsertTextCommand::insertTab): Ditto.

        * editing/JSEditor.h: Tweaked formatting and names.
        * editing/JSEditor.cpp: Ditto. Also changed places that use EditCommandPtr.

        * editing/JoinTextNodesCommand.h: Removed unneeeded document pointer
        * editing/JoinTextNodesCommand.cpp:
        (WebCore::JoinTextNodesCommand::JoinTextNodesCommand): Ditto.
        * editing/MergeIdenticalElementsCommand.h: Ditto.
        * editing/MergeIdenticalElementsCommand.cpp:
        (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Ditto.

        * editing/ModifySelectionListLevel.h: Changed EListType to be named Type and be a member of
        IncreaseSelectionListLevelCommand. Also changed m_listElement to be a RefPtr<Node>.
        * editing/ModifySelectionListLevel.cpp:
        (WebCore::getStartEndListChildren): Changed parameters to be references instead of pointers.
        (WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
        Changed to use Type instead of EListType.
        (WebCore::canIncreaseListLevel): Changed parameters to be references instead of pointers.
        (WebCore::IncreaseSelectionListLevelCommand::doApply): Updated for change to canIncreaseListLevel.
        (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): Ditto.
        (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
        Changed to not use EditCommandPtr.
        (WebCore::canDecreaseListLevel): Changed parameters to be references instead of pointers.
        (WebCore::DecreaseSelectionListLevelCommand::doApply): Updated for change to canDecreaseListLevel.
        (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel): Ditto.
        (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Changed to not use
        EditCommandPtr.

        * editing/MoveSelectionCommand.h: Removed unnecessary document parameter and changed the fragment
        parameter to be a PassRefPtr.
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::MoveSelectionCommand): Ditto.
        (WebCore::MoveSelectionCommand::doApply): Got rid of use of EditCommandPtr.

        * editing/RebalanceWhitespaceCommand.h: Removed unnecessary document parameter.
        * editing/RebalanceWhitespaceCommand.cpp:
        (WebCore::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): Ditto.
        (WebCore::RebalanceWhitespaceCommand::doApply): Got rid of use of EditCommandPtr.

        * editing/RemoveCSSPropertyCommand.h: Tweaked formatting.

        * editing/RemoveNodeAttributeCommand.h: Removed unnecessary document parameter.
        * editing/RemoveNodeAttributeCommand.cpp:
        (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): Ditto.

        * editing/RemoveNodeCommand.h: Removed unnecessary document parameter.
        * editing/RemoveNodeCommand.cpp:
        (WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto.

        * editing/RemoveNodePreservingChildrenCommand.h: Removed unnecessary document parameter.
        * editing/RemoveNodePreservingChildrenCommand.cpp:
        (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.

        * editing/ReplaceSelectionCommand.h: Change fragment parameter to a PassRefPtr.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Ditto.
        (WebCore::ReplaceSelectionCommand::doApply): Ditto.
        (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.

        * editing/Selection.h: Changed SEL_DEFAULT_AFFINITY to be a constant rather than
        a macro. Added constructors that take visible positions. Changed setBase and
        setExtent to take const Position& for better efficiency.
        * editing/Selection.cpp:
        (WebCore::Selection::Selection): Removed unnecessary double initialization of m_state
        and m_baseIsFirst in existing constructors. Added VisiblePosition-based constructors.

        * editing/SetNodeAttributeCommand.h: Removed unnneeded document parameter.
        * editing/SetNodeAttributeCommand.cpp:
        (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Ditto.

        * editing/SplitElementCommand.h: Removed unnneeded document parameter.
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::SplitElementCommand): Ditto.

        * editing/SplitTextNodeCommand.h: Removed unnneeded document parameter.
        * editing/SplitTextNodeCommand.cpp:
        (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Ditto.

        * editing/SplitTextNodeContainingElementCommand.h: Removed unnneeded document parameter.
        * editing/SplitTextNodeContainingElementCommand.cpp:
        (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): Ditto.

        * editing/TypingCommand.h: Replaced uses of EditCommandPtr with EditCommand*.
        Renamed openForMoveTyping() with isOpenForMoreTyping().
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed): Updated to remove use of EditCommandPtr.
        (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
        (WebCore::TypingCommand::insertText): Ditto.
        (WebCore::TypingCommand::insertLineBreak): Ditto.
        (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): Ditto.
        (WebCore::TypingCommand::insertParagraphSeparator): Ditto.
        (WebCore::TypingCommand::isOpenForMoreTypingCommand): Ditto.
        (WebCore::TypingCommand::closeTyping): Ditto.
        (WebCore::TypingCommand::typingAddedToOpenCommand): Ditto.
        (WebCore::TypingCommand::insertTextRunWithoutNewlines): Ditto.

        * editing/WrapContentsInDummySpanCommand.h: Removed unnneeded document parameter.
        * editing/WrapContentsInDummySpanCommand.cpp:
        (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): Ditto.

        * editing/htmlediting.h: Changed type of NON_BREAKING_SPACE to UChar instead of
        unsigned short.

        * page/Frame.h: Changed lastEditCommand() to return an EditCommand* and changed
        appliedEditing(), unappliedEditing(), reappliedEditing(), registerCommandForUndo(),
        and registerCommandForRedo() to take PassRefPtr<EditCommand>.
        * page/FramePrivate.h: Changed m_lastEditCommand to be a RefPtr<EditCommand>.
        * page/Frame.cpp:
        (WebCore::Frame::didOpenURL): Fixed for change to m_lastEditCommand.
        (WebCore::Frame::setFocusNodeIfNeeded): Call the rootEditableElement function
        from Selection to simplify the code.
        (WebCore::Frame::selectAll): Ditto.
        (WebCore::Frame::lastEditCommand): Updated for change to m_lastEditCommand.
        (WebCore::dispatchEditableContentChangedEvents): Added. This sends an event to
        both of the root editable elements involved in a change -- the start selection
        might be in a different element than the end selection.
        (WebCore::Frame::appliedEditing): Changed to call dispatchEditableContentChangedEvents,
        and to do it before setting the ending selection. Also update to use PassRefPtr instead
        of EditCommandPtr and change the order of setting m_lastEditCommand since passing it
        to registerCommandForUndo will take ownership and set it to 0.
        (WebCore::Frame::unappliedEditing): Ditto.
        (WebCore::Frame::reappliedEditing): Ditto.
        (WebCore::Frame::computeAndSetTypingStyle): Updated for removal of EditCommandPtr.
        (WebCore::Frame::applyStyle): Ditto.
        (WebCore::Frame::applyParagraphStyle): Ditto.

        * platform/gdk/FrameGdk.h: Updated for above changes.
        * platform/gdk/TemporaryLinkStubs.cpp: Updated for above changes.
        * platform/win/TemporaryLinkStubs.cpp: Updated for above changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric. Landed by rwlbuis.
rwlbuis [Thu, 24 Aug 2006 20:18:25 +0000 (20:18 +0000)]
    Reviewed by Eric. Landed by rwlbuis.

        Add QtLauncher (was testunity before), which provides a
        standalone "browser" to test the Qt platform stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alice
beidson [Thu, 24 Aug 2006 20:10:00 +0000 (20:10 +0000)]
    Reviewed by Alice

        <rdar://problem/4697973> - Unacceptable delay on startup
        <rdar://problem/4690949> - Need to correctly prune unretained pageurls and icons on startup

        This patch was started by me and finished by Mark Rowe - we now special case all retains during
        startup into one huge sql transaction.  Also we track PageURL retains instead of IconURLs so pruning works right.
        Testing with reasonable sets of bookmarks/history (3000), startup time is neglibile.  Testing with a huge set of
        bookmarks (40,000), startup has a noticable delay, but reasonable, and is inline with shipping safari which also
        has a noticeable delay.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open): adding an initialStartupTransaction and pageRetainStatement
        (WebCore::IconDatabase::close): do cleanup on the initialStartupSQL stuff
        (WebCore::IconDatabase::retainIconForPageURL): Track initial PageURL retains in the temporary table
        (WebCore::IconDatabase::releaseIconForPageURL): Ditto
        (WebCore::IconDatabase::retainIconURL): We no longer special case this on startup
        (WebCore::IconDatabase::releaseIconURL): We no longer special case this on startup
        (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Handle the big transaction correctly and quickly
        (WebCore::IconDatabase::syncDatabase): Change the timing log message
        * loader/icon/IconDatabase.h:
        * loader/icon/SQLStatement.cpp:
        (WebCore::SQLStatement::bindText16): Added this - for reusing commonly used statements by just rebinding parameters.
        * loader/icon/SQLStatement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Thu, 24 Aug 2006 19:56:53 +0000 (19:56 +0000)]
    Reviewed by Darin.

        Fix for Mail stationary. Selecting a stationary item would cause this exception.
        *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
        Uncaught exception - *** -[WebSubresourceLoader copyWithZone:]: selector not recognized

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
        Use _webkit_setObject:forUncopiedKey: when addign the resource to pendingArchivedResources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThis file was listed in a previous ChangeLog, but not actually committed, fixing.
rwlbuis [Thu, 24 Aug 2006 19:54:43 +0000 (19:54 +0000)]
This file was listed in a previous ChangeLog, but not actually committed, fixing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed/landed by Adam.
aroben [Thu, 24 Aug 2006 18:50:55 +0000 (18:50 +0000)]
    Reviewed/landed by Adam.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support

        * CMakeLists.txt:
            Remove KCanvasMatrix.cpp because it no longer exists
            Remove platform/qt/test
        * platform/FloatSize.h:
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
            Added PLATFORM(QT) hooks in the image-decoders/, as they also need
            to work for Qt, not only for Cairo.
        * platform/qt/qt-encodings.txt: Added (required for build).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixing a typo from last patch.
aroben [Thu, 24 Aug 2006 18:35:44 +0000 (18:35 +0000)]
    Fixing a typo from last patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed/landed by Adam.
aroben [Thu, 24 Aug 2006 18:32:46 +0000 (18:32 +0000)]
    Reviewed/landed by Adam.

        Final cleanup to conform to WebKit coding style!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-24 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Thu, 24 Aug 2006 17:02:38 +0000 (17:02 +0000)]
2006-08-24  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support

        * CMakeLists.txt:
        * platform/qt/FrameQt.cpp: Added.
        (WebCore::doScroll):
        (WebCore::FrameView::isFrameView):
        (WebCore::FrameQt::FrameQt):
        (WebCore::FrameQt::init):
        (WebCore::FrameQt::~FrameQt):
        (WebCore::FrameQt::openURL):
        (WebCore::FrameQt::submitForm):
        (WebCore::FrameQt::urlSelected):
        (WebCore::FrameQt::userAgent):
        (WebCore::FrameQt::runJavaScriptAlert):
        (WebCore::FrameQt::runJavaScriptConfirm):
        (WebCore::FrameQt::locationbarVisible):
        (WebCore::FrameQt::setTitle):
        (WebCore::FrameQt::createFrame):
        (WebCore::FrameQt::passWheelEventToChildWidget):
        (WebCore::FrameQt::passSubframeEventToSubframe):
        (WebCore::FrameQt::objectContentType):
        (WebCore::FrameQt::createPlugin):
        (WebCore::FrameQt::passMouseDownEventToWidget):
        (WebCore::FrameQt::menubarVisible):
        (WebCore::FrameQt::personalbarVisible):
        (WebCore::FrameQt::statusbarVisible):
        (WebCore::FrameQt::toolbarVisible):
        (WebCore::FrameQt::createEmptyDocument):
        (WebCore::FrameQt::markedTextRange):
        (WebCore::FrameQt::incomingReferrer):
        (WebCore::FrameQt::mimeTypeForFileName):
        (WebCore::FrameQt::markMisspellingsInAdjacentWords):
        (WebCore::FrameQt::markMisspellings):
        (WebCore::FrameQt::lastEventIsMouseUp):
        (WebCore::FrameQt::saveDocumentState):
        (WebCore::FrameQt::restoreDocumentState):
        (WebCore::FrameQt::openURLRequest):
        (WebCore::FrameQt::scheduleClose):
        (WebCore::FrameQt::unfocusWindow):
        (WebCore::FrameQt::focusWindow):
        (WebCore::FrameQt::overrideMediaType):
        (WebCore::FrameQt::addMessageToConsole):
        (WebCore::FrameQt::runJavaScriptPrompt):
        (WebCore::FrameQt::getEmbedInstanceForWidget):
        (WebCore::FrameQt::getObjectInstanceForWidget):
        (WebCore::FrameQt::getAppletInstanceForWidget):
        (WebCore::FrameQt::registerCommandForUndo):
        (WebCore::FrameQt::registerCommandForRedo):
        (WebCore::FrameQt::clearUndoRedoOperations):
        (WebCore::FrameQt::issueUndoCommand):
        (WebCore::FrameQt::issueRedoCommand):
        (WebCore::FrameQt::issueCutCommand):
        (WebCore::FrameQt::issueCopyCommand):
        (WebCore::FrameQt::issuePasteCommand):
        (WebCore::FrameQt::issuePasteAndMatchStyleCommand):
        (WebCore::FrameQt::issueTransposeCommand):
        (WebCore::FrameQt::respondToChangedSelection):
        (WebCore::FrameQt::respondToChangedContents):
        (WebCore::FrameQt::shouldChangeSelection):
        (WebCore::FrameQt::partClearedInBegin):
        (WebCore::FrameQt::canGoBackOrForward):
        (WebCore::FrameQt::handledOnloadEvents):
        (WebCore::FrameQt::canPaste):
        (WebCore::FrameQt::canRedo):
        (WebCore::FrameQt::canUndo):
        (WebCore::FrameQt::print):
        (WebCore::FrameQt::shouldInterruptJavaScript):
        (WebCore::FrameQt::keyEvent):
        (WebCore::FrameQt::receivedResponse):
        (WebCore::FrameQt::receivedData):
        (WebCore::FrameQt::receivedAllData):
        (WebCore::FrameQt::setFrameGeometry):
        * platform/qt/FrameQt.h: Added.
        * platform/qt/ScrollViewCanvasQt.cpp: Added.
        (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
        (WebCore::ScrollViewCanvasQt::paintEvent):
        (WebCore::ScrollViewCanvasQt::sizeHint):
        (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
        (WebCore::ScrollViewCanvasQt::mousePressEvent):
        (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
        (WebCore::ScrollViewCanvasQt::keyPressEvent):
        (WebCore::ScrollViewCanvasQt::keyReleaseEvent):
        (WebCore::ScrollViewCanvasQt::handleKeyEvent):
        * platform/qt/ScrollViewCanvasQt.h: Added.
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::setParentWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
ap [Thu, 24 Aug 2006 16:49:19 +0000 (16:49 +0000)]
    Reviewed by ap.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support

        * platform/qt/FontCacheQt.cpp: Added.
        (WebCore::FontCache::platformInit):
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::getSimilarFontPlatformData):
        (WebCore::FontCache::getLastResortFallbackFont):
        (WebCore::FontCache::createFontPlatformData):
        * platform/qt/FontDataQt.cpp: Added.
        (WebCore::FontData::platformInit):
        (WebCore::FontData::platformDestroy):
        (WebCore::FontData::smallCapsFontData):
        (WebCore::FontData::containsCharacters):
        (WebCore::FontData::determinePitch):
        (WebCore::FontData::platformWidthForGlyph):
        * platform/qt/FontPlatformData.h: Added.
        * platform/qt/FontPlatformDataQt.cpp: Added.
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::~FontPlatformData):
        (WebCore::FontPlatformData::isFixedPitch):
        (WebCore::FontPlatformData::setFont):
        (WebCore::FontPlatformData::font):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::operator==):
        * platform/qt/FontQt.cpp: Added.
        (WebCore::Font::operator QFont):
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        * platform/qt/GlyphMapQt.cpp: Added.
        (WebCore::GlyphMap::fillPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
harrison [Thu, 24 Aug 2006 16:40:04 +0000 (16:40 +0000)]
LayoutTests:

        Updated expected results for this change:

        <rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

        * editing/selection/anchor-focus1-expected.txt:
        * editing/selection/anchor-focus2-expected.txt:
        * editing/selection/anchor-focus3-expected.txt:
        * editing/selection/move-begin-end-expected.txt:
        * fast/dom/Element/onclick-case-expected.txt:
        * fast/dom/HTMLInputElement/size-as-number-expected.txt:
        * fast/dom/document-all-input-expected.txt:
        * fast/dom/option-properties-expected.txt:
        * fast/events/objc-keyboard-event-creation-expected.txt:
        * fast/events/onsubmit-bubbling-expected.txt:
        * fast/forms/access-key-expected.txt:
        * fast/forms/activate-and-disabled-elements-expected.txt:
        * fast/forms/button-in-forms-collection-expected.txt:
        * fast/forms/check-box-enter-key-expected.txt:
        * fast/forms/cursor-position-expected.txt:
        * fast/forms/display-none-in-onchange-keyboard-expected.txt:
        * fast/forms/domstring-replace-crash-expected.txt:
        * fast/forms/double-focus-expected.txt:
        * fast/forms/element-by-name-expected.txt:
        * fast/forms/empty-get-expected.txt:
        * fast/forms/focus-expected.txt:
        * fast/forms/form-get-multipart-expected.txt:
        * fast/forms/form-get-multipart2-expected.txt:
        * fast/forms/form-get-multipart3-expected.txt:
        * fast/forms/form-post-urlencoded-expected.txt:
        * fast/forms/input-appearance-elementFromPoint-expected.txt:
        * fast/forms/input-appearance-maxlength-expected.txt:
        * fast/forms/input-changing-value-expected.txt:
        * fast/forms/input-delete-expected.txt:
        * fast/forms/input-selection-hidden-expected.txt:
        * fast/forms/input-selection-restore-expected.txt:
        * fast/forms/input-text-enter-expected.txt:
        * fast/forms/input-truncate-newline-expected.txt:
        * fast/forms/legend-access-key-expected.txt:
        * fast/forms/onchange-enter-submit-expected.txt:
        * fast/forms/onselect-textarea-expected.txt:
        * fast/forms/onselect-textfield-expected.txt:
        * fast/forms/paste-into-textarea-expected.txt:
        * fast/forms/plaintext-mode-1-expected.txt:
        * fast/forms/select-remove-option-expected.txt:
        * fast/forms/select-replace-option-expected.txt:
        * fast/forms/select-reset-expected.txt:
        * fast/forms/selection-functions-expected.txt:
        * fast/forms/text-field-setvalue-crash-expected.txt:
        * fast/forms/textarea-crlf-expected.txt:
        * fast/forms/textarea-scrolled-endline-caret-expected.txt:
        * fast/forms/textarea-setvalue-submit-expected.txt:
        * fast/forms/textfield-focus-out-expected.txt:

WebCore:

        Reinstate r15966 because layout test changes are correct.

        <rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
ap [Thu, 24 Aug 2006 16:25:13 +0000 (16:25 +0000)]
    Reviewed by ap.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support (Part II)

        Adapt the KCanvas Qt device to Rob's KCanvasMatrix removal.
        Use AffineTransform everywhere instead.

        * kcanvas/device/qt/KRenderingDeviceQt.cpp:
        (WebCore::KRenderingDeviceContextQt::KRenderingDeviceContextQt):
        (WebCore::KRenderingDeviceContextQt::concatCTM):
        (WebCore::KRenderingDeviceContextQt::ctm):
        * kcanvas/device/qt/KRenderingDeviceQt.h:
        * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
        (WebCore::KRenderingPaintServerLinearGradientQt::setup):
        (WebCore::KRenderingPaintServerRadialGradientQt::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed, tweaked and landed by ap
ap [Thu, 24 Aug 2006 16:19:20 +0000 (16:19 +0000)]
    Reviewed, tweaked and landed by ap

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support (Part II)

        * CMakeLists.txt: Adjust to Anders' build fixes.
        * wtf/Platform.h: Fix define for the Qt platform (we don't use/need Cairo.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Thu, 24 Aug 2006 10:04:16 +0000 (10:04 +0000)]
    Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10524
        svg transform: comma delimiting breaks display

        Properly parse transforms which use ',' as seperators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
mjs [Thu, 24 Aug 2006 07:12:02 +0000 (07:12 +0000)]
    Reviewed by Adele.

        - fix assertion which I accidentally changed to one that sometimes fails
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10531

        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState dealloc]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
mjs [Thu, 24 Aug 2006 06:22:13 +0000 (06:22 +0000)]
    Reviewed by Brady.

        - move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation
        for WebFrameLoader just holding on to WebDocumentLoadState

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _loadRequest:archive:]):
        (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
        (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
        (-[WebFrameLoader reload]):
        * WebView/WebFrame.m:
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
        (-[WebFrame loadRequest:]):
        (-[WebFrame loadArchive:]):
        (-[WebFrame reload]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFramePrivate.h:
        * WebView/WebView.m:
        (-[WebView setCustomTextEncodingName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej
beidson [Thu, 24 Aug 2006 05:59:33 +0000 (05:59 +0000)]
    Reviewed by Maciej

        First pass at pruning unused WebIconDatabase code.  Focus on removing methods that simply
        have no place in the new DB at all.  A few renames and a few important FIXMEs result, but no
        functionality changes.

        * Loader/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
        * Misc/WebIconDatabase.h:
        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase iconForURL:withSize:cache:]):
        (-[WebIconDatabase iconURLForURL:]):
        (-[WebIconDatabase defaultIconWithSize:]):
        (-[WebIconDatabase retainIconForURL:]):
        (-[WebIconDatabase releaseIconForURL:]):
        (-[WebIconDatabase removeAllIcons]):
        (-[WebIconDatabase _setIconData:forIconURL:]):
        (-[WebIconDatabase _setHaveNoIconForIconURL:]):
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _hasEntryForIconURL:]):
        (-[WebIconDatabase _applicationWillTerminate:]):
        (-[WebIconDatabase _resetCachedWebPreferences:]):
        * Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
mjs [Thu, 24 Aug 2006 04:15:07 +0000 (04:15 +0000)]
    Reviewed by Adele.

        - started factoring most of the guts of WebDataSource into a new class

        WebDocumentLoadState is decoupled from the rest of WebKit and will
        be moved down to WebCore. I only moved one of the data fields of
        WebDataSource for now.

        * Loader/WebDocumentLoadState.h: Added.
        * Loader/WebDocumentLoadState.m: Added.
        (-[WebDocumentLoadState initWithRequest:]): New class.
        (-[WebDocumentLoadState dealloc]):
        (-[WebDocumentLoadState setFrameLoader:]):
        (-[WebDocumentLoadState setMainResourceData:]):
        (-[WebDocumentLoadState mainResourceData]):
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call,
        it would have been called already by this point.
        (-[WebFrameLoader _setProvisionalDataSource:]): ditto.
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource initWithRequest:]):
        (-[WebDataSource data]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
mjs [Thu, 24 Aug 2006 01:28:20 +0000 (01:28 +0000)]
    Reviewed by Adele.

        - refactoring of WebDataSource in preparation for moving a bunch of it to a new class

        - minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
        - reduce Private category implementation to be only the SPI methods
        - make new Internal and FileInternal categories which contain the
        remainder (depending on whether they are called from outside of
        WebDataSource)

        * WebView/WebDataSource.m:
        (-[WebDataSource _setMainDocumentError:]):
        (addTypesFromClass):
        (+[WebDataSource _representationClassForMIMEType:]):
        (-[WebDataSource _commitIfReady]):
        (-[WebDataSource _commitLoadWithData:]):
        (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
        (-[WebDataSource _addResponse:]):
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _mainDocumentError]):
        (-[WebDataSource _addSubframeArchives:]):
        (-[WebDataSource _fileWrapperForURL:]):
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
        (-[WebDataSource _finishedLoading]):
        (-[WebDataSource _setResponse:]):
        (-[WebDataSource _setRequest:]):
        (-[WebDataSource _setupForReplaceByMIMEType:]):
        (-[WebDataSource _receivedMainResourceError:complete:]):
        (-[WebDataSource _mainReceivedError:complete:]):
        (-[WebDataSource _defersCallbacks]):
        (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebDataSource _didFailLoadingWithError:forResource:]):
        (-[WebDataSource _didFinishLoadingForResource:]):
        (-[WebDataSource _didReceiveData:contentLength:forResource:]):
        (-[WebDataSource _didReceiveResponse:forResource:]):
        (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]):
        (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]):
        (-[WebDataSource _willSendRequest:forResource:redirectResponse:]):
        (-[WebDataSource _identifierForInitialRequest:]):
        (-[WebDataSource _archivedSubresourceForURL:]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _stopRecordingResponses]):
        (-[WebDataSource _loadingStartedTime]):
        (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
        (-[WebDataSource _documentFragmentWithArchive:]):
        (-[WebDataSource _documentFragmentWithImageResource:]):
        (-[WebDataSource _imageElementWithImageResource:]):
        (-[WebDataSource _title]):
        (-[WebDataSource _isStopping]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _URL]):
        (-[WebDataSource _loadFromPageCache:]):
        (-[WebDataSource _popSubframeArchiveWithName:]):
        (-[WebDataSource _setIsClientRedirect:]):
        (-[WebDataSource _setURL:]):
        (-[WebDataSource _setLastCheckedRequest:]):
        (-[WebDataSource _defersCallbacksChanged]):
        (-[WebDataSource _lastCheckedRequest]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _bridge]):
        (-[WebDataSource _webView]):
        (-[WebDataSource _triggeringAction]):
        (-[WebDataSource _setTriggeringAction:]):
        (-[WebDataSource __adoptRequest:]):
        (-[WebDataSource _isDocumentHTML]):
        (-[WebDataSource _stopLoadingWithError:]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _responses]):
        (-[WebDataSource _makeRepresentation]):
        (-[WebDataSource _isClientRedirect]):
        (-[WebDataSource _originalRequest]):
        (-[WebDataSource _URLForHistory]):
        (-[WebDataSource _addToUnarchiveState:]):
        (-[WebDataSource _setOverrideEncoding:]):
        (-[WebDataSource _setIconURL:]):
        (-[WebDataSource _setIconURL:withType:]):
        (-[WebDataSource _overrideEncoding]):
        (-[WebDataSource _setTitle:]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Mac bustage.
hyatt [Thu, 24 Aug 2006 01:01:04 +0000 (01:01 +0000)]
Fix Mac bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Thu, 24 Aug 2006 00:38:57 +0000 (00:38 +0000)]
    Reviewed by Maciej.

        - added an assert to make it slightly easier to debug the common case of
          calling document() on a node of 0

        * dom/Node.h: (WebCore::Node::document): ASSERT(this).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Platform.h to include #defines for graphics features.
hyatt [Thu, 24 Aug 2006 00:04:12 +0000 (00:04 +0000)]
    Fix Platform.h to include #defines for graphics features.

        Reviewed by darin

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Refactor Cairo and CoreGraphics to use platform ifdefs. This patch
hyatt [Thu, 24 Aug 2006 00:02:51 +0000 (00:02 +0000)]
    Refactor Cairo and CoreGraphics to use platform ifdefs.  This patch
        separates the graphics engines from their respective platforms and replaces
        #ifdef PLATFORM(MAC) and PLATFORM(WIN) with PLATFORM(CG) and PLATFORM(CAIRO).

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * platform/AffineTransform.h:
        * platform/Color.h:
        * platform/Cursor.h:
        * platform/FloatPoint.h:
        * platform/FloatRect.h:
        * platform/FloatSize.h:
        * platform/Font.h:
        * platform/FontData.h:
        * platform/GlyphBuffer.h:
        (WebCore::GlyphBuffer::glyphAt):
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        * platform/GraphicsContext.h:
        * platform/Image.h:
        * platform/ImageSource.h:
        * platform/IntPoint.h:
        * platform/IntRect.h:
        * platform/IntSize.h:
        * platform/ResourceLoader.h:
        * platform/ResourceLoaderClient.h:
        * platform/Widget.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/cairo/ImageCairo.cpp:
        * platform/cairo/ImageSourceCairo.cpp:
        * platform/cg/AffineTransformCG.cpp:
        * platform/cg/FloatPointCG.cpp: Added.
        * platform/cg/FloatRectCG.cpp: Added.
        * platform/cg/FloatSizeCG.cpp: Added.
        * platform/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::setFocusRingClip):
        (WebCore::GraphicsContext::clearFocusRingClip):
        (WebCore::GraphicsContext::platformContext):
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        * platform/cg/GraphicsContextPlatformPrivate.h: Added.
        (WebCore::GraphicsContextPlatformPrivate:::m_cgContext):
        (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
        * platform/cg/ImageCG.cpp: Added.
        (WebCore::Image::drawTiled):
        * platform/cg/ImageSourceCG.cpp: Added.
        * platform/cg/IntPointCG.cpp: Added.
        * platform/cg/IntRectCG.cpp: Added.
        * platform/cg/IntSizeCG.cpp: Added.
        * platform/cg/PDFDocumentImage.cpp: Added.
        (WebCore::PDFDocumentImage::adjustCTM):
        * platform/cg/PDFDocumentImage.h: Added.
        * platform/cg/PathCG.cpp:
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
        * platform/mac/FloatPointMac.mm:
        * platform/mac/FloatRectMac.mm:
        * platform/mac/FloatSizeMac.mm:
        * platform/mac/GraphicsContextMac.mm:
        * platform/mac/ImageMac.mm:
        * platform/mac/ImageSourceMac.cpp: Removed.
        * platform/mac/IntPointMac.mm:
        * platform/mac/IntRectMac.mm:
        * platform/mac/IntSizeMac.mm:
        * platform/mac/PDFDocumentImage.h: Removed.
        * platform/mac/PDFDocumentImage.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoI forgot to check in these expected results yesterday.
justing [Wed, 23 Aug 2006 23:46:33 +0000 (23:46 +0000)]
I forgot to check in these expected results yesterday.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove the ifdef for platform scrollbars vs. engine scrollbars until
hyatt [Wed, 23 Aug 2006 21:36:58 +0000 (21:36 +0000)]
    Remove the ifdef for platform scrollbars vs. engine scrollbars until
        engine scrollbars actually exist.

        * platform/ScrollBar.h:
        (WebCore::ScrollBar::hasPlatformScrollBars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by harrison
justing [Wed, 23 Aug 2006 21:33:18 +0000 (21:33 +0000)]
    Reviewed by harrison

        Removed the poorly named next/previousVisiblePosition
        and use next/previousCandidate and next/previousVisuallyDistinctCandidate.
        Removed the unused VisiblePosition::maxOffset()

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next):
        (WebCore::VisiblePosition::previous):
        (WebCore::VisiblePosition::canonicalPosition):
        * editing/VisiblePosition.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan
beidson [Wed, 23 Aug 2006 21:06:59 +0000 (21:06 +0000)]
    Reviewed by John Sullivan

        /me crosses fingers
        Flip the switch to the new Icon Database
        Massive code pruning is coming up

        * WebKitPrefix.h: Flipped the switch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alexey. Landed by rwlbuis.
rwlbuis [Wed, 23 Aug 2006 21:04:08 +0000 (21:04 +0000)]
    Reviewed by Alexey. Landed by rwlbuis.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support (Part II)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Beth
beidson [Wed, 23 Aug 2006 20:48:13 +0000 (20:48 +0000)]
    Reviewed by Beth
        Since I just pushed the default URL icon from WebKit to WebCore, but
        WebKit was still using its version of the default icon, this patch makes it
        use the WebCore version

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase defaultIconWithSize:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele
beidson [Wed, 23 Aug 2006 19:31:44 +0000 (19:31 +0000)]
    Reviewed by Adele

        Moved default URL icon from WebKit to WebCore

        * Resources/urlIcon.tiff: Added.
        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/IconDataCache.cpp:
        (WebCore::IconDataCache::loadImageFromResource):
        * loader/icon/IconDataCache.h:
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::defaultIcon):
        * loader/icon/IconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin, Adele.
aroben [Wed, 23 Aug 2006 18:08:45 +0000 (18:08 +0000)]
    Reviewed by Darin, Adele.

        Some popup refactoring/cleanup.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::defaultEventHandler):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::RenderMenuList):
        (WebCore::RenderMenuList::~RenderMenuList):
        (WebCore::RenderMenuList::showPopup):
        (WebCore::RenderMenuList::hidePopup):
        * rendering/RenderMenuList.h:
        (WebCore::RenderMenuList::popup):
        (WebCore::RenderMenuList::popupIsVisible):
        * rendering/RenderPopupMenu.h:
        * rendering/RenderPopupMenuMac.h:
        (WebCore::RenderPopupMenuMac::hidePopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-23 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 23 Aug 2006 17:44:10 +0000 (17:44 +0000)]
2006-08-23  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Make the bindings compile without CoreFoundation.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * bindings/c/c_instance.cpp:
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16):
        * bindings/npapi.h:
        * bindings/runtime.cpp:
        (KJS::Bindings::Instance::createBindingForLanguageInstance):
        (KJS::Bindings::Instance::createLanguageInstanceForValue):
        * bindings/runtime_root.cpp:
        * bindings/runtime_root.h:
        * kjs/interpreter.cpp:
        (KJS::Interpreter::createLanguageInstanceForValue):
        * kjs/interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders. Landed by rwlbuis.
rwlbuis [Wed, 23 Aug 2006 16:18:18 +0000 (16:18 +0000)]
    Reviewed by Anders. Landed by rwlbuis.

        Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
        WebKit should have Qt platform support

        Note: StringQt.cpp is not part of the original patch, but was
        mistakenly omitted from earlier 10467 patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej
beidson [Wed, 23 Aug 2006 07:29:45 +0000 (07:29 +0000)]
    Reviewed by Maciej

        Added escapeSQLString() - a helper to escape strings to be used in textual SQL queries

        * WebCore.xcodeproj/project.pbxproj: Reordered some files
        * loader/icon/IconDataCache.cpp: Use the new escapeSQLString()
        (WebCore::IconDataCache::writeToDatabase):
        * loader/icon/IconDatabase.cpp: Use the new escapeSQLString() throughout
        (WebCore::IconDatabase::retainIconURL):
        (WebCore::IconDatabase::releaseIconURL):
        (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
        (WebCore::IconDatabase::establishIconIDForIconURL):
        (WebCore::imageDataForIconURLQuery):
        (WebCore::timeStampForIconURLQuery):
        (WebCore::iconURLForPageURLQuery):
        (WebCore::forgetPageURLQuery):
        (WebCore::setIconIDForPageURLQuery):
        (WebCore::getIconIDForIconURLQuery):
        (WebCore::addIconForIconURLQuery):
        (WebCore::hasIconForIconURLQuery):
        * loader/icon/SQLDatabase.h:
        (WebCore::escapeSQLString): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
mjs [Wed, 23 Aug 2006 06:59:52 +0000 (06:59 +0000)]
    Reviewed by Brady.

        - remove "loading" flag from WebDataSource and code that manages it; it is redundat.

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader addPlugInStreamLoader:]):
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader removeSubresourceLoader:]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _prepareForLoadStart]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource isLoading]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
mjs [Wed, 23 Aug 2006 06:50:38 +0000 (06:50 +0000)]
    Reviewed by Brady.

        - assorted style cleanup of icon loader code:

        - wrapped all implementation files in namespace WebCore {} instead of "using namespace WebCore;" at top
        - split headers to be one per class, to match impl files
        - made files that are purely local in IconDatabase.cpp static
        - make each impl file include config.h as first header (and no config.h includes in other headers)
        - avoid multiple copies of Vector<unsigned char> for image data

        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/IconDataCache.cpp:
        * loader/icon/IconDataCache.h: Added.
        (WebCore::):
        (WebCore::IconDataCache::getTimestamp):
        (WebCore::IconDataCache::setTimestamp):
        (WebCore::IconDataCache::getIconURL):
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::imageDataForIconURL):
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::pageURLTableIsEmptyQuery):
        (WebCore::imageDataForIconURLQuery):
        (WebCore::timeStampForIconURLQuery):
        (WebCore::iconURLForPageURLQuery):
        (WebCore::forgetPageURLQuery):
        (WebCore::setIconIDForPageURLQuery):
        (WebCore::getIconIDForIconURLQuery):
        (WebCore::addIconForIconURLQuery):
        (WebCore::hasIconForIconURLQuery):
        * loader/icon/IconDatabase.h:
        * loader/icon/SQLDatabase.cpp:
        * loader/icon/SQLDatabase.h:
        * loader/icon/SQLStatement.cpp:
        (WebCore::SQLStatement::getColumnBlobAsVector):
        * loader/icon/SQLStatement.h: Added.
        (WebCore::SQLStatement::isPrepared):
        (WebCore::SQLStatement::prepareAndStep):
        (WebCore::SQLStatement::lastError):
        (WebCore::SQLStatement::lastErrorMsg):
        * loader/icon/SQLTransaction.cpp:
        * loader/icon/SQLTransaction.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by NOBODY
trey [Wed, 23 Aug 2006 06:05:06 +0000 (06:05 +0000)]
    Reviewed by NOBODY

        This test update was missing from the patch I posted, and ggarren just checked in.

        * fast/overflow/scrollRevealButton-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej
beidson [Wed, 23 Aug 2006 06:01:09 +0000 (06:01 +0000)]
    Reviewed by Maciej

        The role of the SiteIcon is now the original intention - to be a cache of data relating to an Icon
        As such, I'm renaming it to IconDataCache.
        Also, the IconDatabase has to manually set the image data on the IconDataCache and also sets the
        TimeStamp when an icon is created or the data is changed.
        IconDataCache now has a method to write itself *to* a given database, instead of read itself from one.
        IconDatabase schema changes to have the timestamp set manually instead of via a trigger.
        The overall purpose of this change is to cache the timestamp, killing off a very common SQL query.

        * WebCore.xcodeproj/project.pbxproj: Renamed a file
        * loader/icon/IconDataCache.cpp: Added.
        (IconDataCache::IconDataCache):
        (IconDataCache::getImage): Now either returns the stored image, or 0 - no attempt to grab data
        (IconDataCache::manuallySetImageData): Delete the old image and create the new one
        (IconDataCache::writeToDatabase): Write the current iconURL, data, and timestamp to the given DB
        (IconDataCache::imageDataStatus): Determine if an IconDataCache is new without data versus actually having null data
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::createDatabaseTables): Changed DB schema to version 5 (hopefully the final version)
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::IconDatabase::isIconExpiredForIconURL): Uses the timestamp in the IconDataCache object instead of always querying
        (WebCore::IconDatabase::getOrCreateIconDataCache): Added, to handle creation of new IconDataCache when appropriate
        (WebCore::IconDatabase::setIconDataForIconURL): Puts data in SiteIcon then marks it for a future write
        (WebCore::IconDatabase::syncDatabase): Now syncs SiteIconsPendingUpdate
        * loader/icon/IconDatabase.h:
        (WebCore::IconDataCache::getTimestamp):
        (WebCore::IconDataCache::setTimestamp):
        * loader/icon/SiteIcon.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
mjs [Wed, 23 Aug 2006 05:49:04 +0000 (05:49 +0000)]
LayoutTests:

        Reviewed by Eric.

        - test for <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)

        (I both added a WebKit assertion that would fail under this test, and then did a fix to make it not fire)

        * fast/loader/start-load-in-unload-expected.txt: Added.
        * fast/loader/start-load-in-unload.html: Added.

WebKit:

        Reviewed by Eric.

        <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader addSubresourceLoader:]): Add a WebKit-level assertion that should fire when this bad
        situation occurs.
        * Loader/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Prevent
        the situation from occuring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for broken tests.
mjs [Wed, 23 Aug 2006 05:37:03 +0000 (05:37 +0000)]
    Fix for broken tests.

        - made newly added CGI scripts executable

        * http/tests/navigation/resources/error404.pl:
        * http/tests/navigation/resources/frameset.pl:
        * http/tests/navigation/resources/postresult.pl:
        * http/tests/navigation/resources/redirect302.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot to check this in in the previous commit.
justing [Wed, 23 Aug 2006 02:32:35 +0000 (02:32 +0000)]
Forgot to check this in in the previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 23 Aug 2006 00:47:01 +0000 (00:47 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
        REGRESSION(r15918): drag-into-marker.html failing

        * editing/pasteboard/paste-list-001-expected.txt:
        * fast/lists/drag-into-marker.html: Added.
        * fast/lists/drag-into-marker.html-disabled: Removed.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
        REGRESSION(r15918): drag-into-marker.html failing

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Don't avoid nesting
        in a list item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin
beidson [Wed, 23 Aug 2006 00:42:04 +0000 (00:42 +0000)]
    Reviewed by Kevin

        Added a check in getTIFFRepresentation to not proceed if the frame count is zero
        This is an error condition that was handled gracefully before - in certain circumstances
        the call to CGImageDestinationCreateWithData will spam the Console if it is passed null/empty data
        or invalid data.  This small change bails out before that call if that call will definitely fail

        * platform/mac/ImageMac.mm:
        (WebCore::Image::getTIFFRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Backed out my last change (r15966) because it broke lots of layout tests.
harrison [Wed, 23 Aug 2006 00:23:50 +0000 (00:23 +0000)]
    Backed out my last change (r15966) because it broke lots of layout tests.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs [Wed, 23 Aug 2006 00:09:28 +0000 (00:09 +0000)]
WebCore:

        Reviewed by Anders.

        - added some SPI indirections to support the following in WebKit/Loader:
            - pull more WebDataSource code into WebFrameLoader
            - make WebMainResourceLoader not depend on WebKit or on SPI

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

WebKit:

        Reviewed by Anders.

        - pull more WebDataSource code into WebFrameLoader
        - make WebMainResourceLoader not depend on WebKit or on SPI

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebFrameLoader _updateIconDatabaseWithURL:]):
        (-[WebFrameLoader _notifyIconChanged:]):
        (-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
        (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
        (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
        (-[WebFrameLoader cancelContentPolicy]):
        * Loader/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]):
        * Loader/WebLoader.m:
        (-[NSURLProtocol loadWithRequest:]):
        (-[NSURLProtocol setDefersCallbacks:]):
        * Loader/WebMainResourceLoader.h:
        * Loader/WebMainResourceLoader.m:
        (-[WebMainResourceLoader initWithFrameLoader:]):
        (-[WebMainResourceLoader dealloc]):
        (-[WebMainResourceLoader cancelWithError:]):
        (-[WebMainResourceLoader continueAfterNavigationPolicy:formState:]):
        (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
        (-[WebMainResourceLoader continueAfterContentPolicy:]):
        (-[WebMainResourceLoader checkContentPolicy]):
        (-[WebMainResourceLoader didReceiveResponse:]):
        * Plugins/WebPluginContainerCheck.m:
        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):
        * WebView/WebDataSource.m:
        (-[WebDataSource _loadIcon]):
        (-[WebDataSource _cancelledError]):
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        (+[WebDataSource _representationClassForMIMEType:]):
        (-[WebDataSource _commitLoadWithData:]):
        (-[WebDataSource _isDocumentHTML]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFramePrivate.h:
        * WebView/WebPolicyDelegate.m:
        * WebView/WebPolicyDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 22 Aug 2006 22:59:18 +0000 (22:59 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4052343&4052343&4426622> Mail hung on paste text

        Bugs exposed:
        * editing/pasteboard/paste-4039777-fix-expected.checksum:
        * editing/pasteboard/paste-4039777-fix-expected.png:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/deleting/delete-3857753-fix-expected.txt:
        * editing/pasteboard/styled-element-markup-expected.checksum:
        * editing/pasteboard/styled-element-markup-expected.png:
        * editing/pasteboard/styled-element-markup-expected.txt:
        * editing/execCommand/insertHTML-expected.checksum:
        * editing/execCommand/insertHTML-expected.png:
        * editing/execCommand/insertHTML-expected.txt:
        * editing/execCommand/insertHTML.html:

        Removed some empty style spans, font tags are replaced by style spans
        in a couple of cases:
        * editing/deleting/merge-different-styles-expected.txt:
        * editing/deleting/pruning-after-merge-1-expected.txt:
        * editing/deleting/pruning-after-merge-2-expected.txt:
        * editing/inserting/insert-3786362-fix-expected.txt:
        * editing/pasteboard/block-wrappers-necessary-expected.txt:
        * editing/pasteboard/display-block-on-spans-expected.txt:
        * editing/pasteboard/merge-end-table-expected.txt:
        * editing/pasteboard/paste-4035648-fix-expected.txt:
        * editing/pasteboard/paste-line-endings-001-expected.txt:
        * editing/pasteboard/paste-line-endings-006-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/paste-pre-001-expected.txt:
        * editing/pasteboard/paste-pre-002-expected.txt:
        * editing/pasteboard/paste-table-001-expected.txt:
        * editing/pasteboard/paste-table-002-expected.txt:
        * editing/pasteboard/paste-text-001-expected.txt:
        * editing/pasteboard/paste-text-002-expected.txt:
        * editing/pasteboard/paste-text-003-expected.txt:
        * editing/pasteboard/paste-text-004-expected.txt:
        * editing/pasteboard/paste-text-005-expected.txt:
        * editing/pasteboard/paste-text-006-expected.txt:
        * editing/pasteboard/paste-text-011-expected.txt:
        * editing/pasteboard/paste-text-012-expected.txt:
        * editing/pasteboard/paste-text-013-expected.txt:
        * editing/pasteboard/paste-text-014-expected.txt:
        * editing/pasteboard/paste-text-015-expected.txt:
        * editing/pasteboard/paste-text-016-expected.txt:
        * editing/pasteboard/paste-text-017-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * editing/pasteboard/styled-element-markup.html:
        * editing/pasteboard/testcase-9507-expected.txt:
        * editing/style/smoosh-styles-001-expected.txt:
        * editing/style/smoosh-styles-002-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4052343&4052343&4426622> Mail hung on paste text

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::isInterchangeNewlineNode):
        (WebCore::isInterchangeConvertedSpaceSpan):
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Compute the redundant inheritable styles and
        remove them and remove style nodes and style spans which were only contributing redundant styles.
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-08-22 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 22 Aug 2006 21:05:47 +0000 (21:05 +0000)]
2006-08-22  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Move the npruntime code over to using HashMap and the runtime_root code over to using
        HashMap and HashCountedSet.

        * bindings/NP_jsobject.cpp:
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::identifierFromNPIdentifier):
        * bindings/c/c_utility.h:
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::invoke):
        * bindings/npruntime.cpp:
        (getStringIdentifierMap):
        (getIntIdentifierMap):
        (_NPN_GetStringIdentifier):
        (_NPN_GetIntIdentifier):
        * bindings/runtime_root.cpp:
        (getReferencesByRootMap):
        (getReferencesSet):
        (KJS::Bindings::findReferenceSet):
        (KJS::Bindings::rootForImp):
        (KJS::Bindings::rootForInterpreter):
        (KJS::Bindings::addNativeReference):
        (KJS::Bindings::removeNativeReference):
        (RootObject::removeAllNativeReferences):
        * bindings/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15972 268f45cc-cd09-0410-ab3c-d52691b4dbfc