WebKit-https.git
11 years agoRubber stamped by Steve Falkenburg.
bfulgham@webkit.org [Wed, 26 Aug 2009 01:06:11 +0000 (01:06 +0000)]
Rubber stamped by Steve Falkenburg.

debug_wincairo.vsprops was linking against wrong C runtime.

* win/tools/vsprops/debug_wincairo.vsprops: Link to correct
  C runtime (as in the standard 'debug.vsprops' file.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoStop installing IDL files in to the framework.
mrowe@apple.com [Wed, 26 Aug 2009 00:57:58 +0000 (00:57 +0000)]
Stop installing IDL files in to the framework.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Wed, 26 Aug 2009 00:51:02 +0000 (00:51 +0000)]
2009-08-25  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
        https://bugs.webkit.org/show_bug.cgi?id=27756

        Tests: fast/forms/input-list.html
               fast/forms/input-selectedoption.html

        * html/HTMLAttributeNames.in:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::list):
        (WebCore::HTMLInputElement::selectedOption):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
2009-08-25  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Support for HTMLInputElement::list and HTMLInputElement::selectedOption.
        https://bugs.webkit.org/show_bug.cgi?id=27756

        * fast/forms/input-list-expected.txt: Added.
        * fast/forms/input-list.html: Added.
        * fast/forms/input-selectedoption-expected.txt: Added.
        * fast/forms/input-selectedoption.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Tue, 25 Aug 2009 23:24:02 +0000 (23:24 +0000)]
2009-08-25  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Darin Adler.

        make-script-test-wrappers should be executable
        https://bugs.webkit.org/show_bug.cgi?id=28669

        Make make-script-test-wrappers and update-sources-list.py both be
        executable.

        * Scripts/update-sources-list.py:
        * Scripts/make-script-test-wrappers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 25 Aug 2009 23:07:19 +0000 (23:07 +0000)]
2009-08-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible (edit)
        https://bugs.webkit.org/show_bug.cgi?id=28081

        Test: accessibility/media-element.html

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
            Add AccessibilityMediaControls.cpp/.h

        * accessibility/AXObjectCache.cpp:
        * accessibility/AXObjectCache.h:
        (WebCore::AXObjectCache::getOrCreate):
            Create AccessibilityMediaControl. Update Copyright

        * accessibility/AccessibilityMediaControls.cpp:
        * accessibility/AccessibilityMediaControls.h:
            Added.

        * accessibility/AccessibilityObject.cpp:
        * accessibility/AccessibilityObject.h:
            Add isMediaTimeline. Update Copyright.

        * accessibility/AccessibilitySlider.h:
            Make constructor protected instead of private so AccessibilityMediaTimeline can
            call it.

        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
            Add NSAccessibilityValueDescriptionAttribute to range attributes.
        (-[AccessibilityObjectWrapper subrole]):
            Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.

        * dom/Node.h:
            add isMediaControlElement.

        * page/mac/WebCoreViewFactory.h:
        * platform/LocalizedStrings.h:
        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::localizedMediaControlElementString):
        (WebCore::localizedMediaControlElementHelpText):
        (WebCore::localizedMediaTimeDescription):
            New, return localized media controller strings.

        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::mediaElementLoadingStateText):
        (WebCore::mediaElementLiveBroadcastStateText):
            Move inside of "#if ENABLE(VIDEO)"
        (WebCore::localizedMediaControlElementString):
        (WebCore::localizedMediaControlElementHelpText):
        (WebCore::localizedMediaTimeDescription):

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlElement::MediaControlElement):
            Initialize m_displayType.
        (WebCore::MediaControlElement::MediaControlElement):
        (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
            Fix style.
        (WebCore::MediaControlInputElement::MediaControlInputElement):
            Set m_displayType based on pseudo style ID.
        (WebCore::MediaControlInputElement::MediaControlInputElement):
            rename local "o" to "object".
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
        (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
        (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
            Update for MediaControlInputElement constructor change.
        (WebCore::MediaControlTimeDisplayElement::formatTime):
            New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
        (WebCore::MediaControlTimeDisplayElement::setCurrentValue):
            New, set text to current time.
        * rendering/MediaControlElements.h:

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::updateControls):
            Create controls in tab order.
        (WebCore::RenderMedia::formatTime):
            Moved to MediaControlTimeDisplayElement::formatTime.
        (WebCore::RenderMedia::updateTimeDisplay):
            Call MediaControlTimeDisplayElement::setCurrentValue.
        * rendering/RenderMedia.h:

2009-08-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        Add localized strings for media controller accessiblility.

        * English.lproj/Localizable.strings:

2009-08-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory localizedMediaControlElementString:]):
        (-[WebViewFactory localizedMediaControlElementHelpText:]):
        (-[WebViewFactory localizedMediaTimeDescription:]):
            New.

2009-08-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        * WebCoreLocalizedStrings.cpp:
        (WebCore::localizedMediaControlElementString):
        (WebCore::localizedMediaControlElementHelpText):
        (WebCore::localizedMediaTimeDescription):
            New.

2009-08-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        * accessibility/media-element.html: Added.
        * platform/mac/accessibility/media-element-expected.txt: Added.
        * media/video-controls-visible-audio-only.html:
        * platform/mac-leopard/accessibility/media-element-expected.txt: Added.
        * platform/mac-leopard/media/controls-drag-timebar-expected.txt: Added.
        * platform/mac-leopard/media/controls-strict-expected.txt: Added.
        * platform/mac-leopard/media/video-controls-rendering-expected.txt: Added.
        * platform/mac-leopard/media/video-display-toggle-expected.txt: Added.
        * platform/win/media/controls-strict-expected.txt: Added.
        * platform/win/media/video-controls-rendering-expected.txt: Added.
        * platform/win/media/video-display-toggle-expected.txt: Added.
            Added.

        * platform/mac-leopard/media/audio-controls-rendering-expected.txt:
        * platform/mac-leopard/media/controls-after-reload-expected.txt:
        * platform/mac-leopard/media/controls-styling-expected.txt:
        * platform/mac-leopard/media/video-zoom-controls-expected.txt:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/controls-after-reload-expected.txt:
        * platform/mac/media/controls-styling-expected.txt:
        * platform/mac/media/video-zoom-controls-expected.txt:
        * platform/win/media/audio-controls-rendering-expected.txt:
        * platform/win/media/controls-after-reload-expected.txt:
        * platform/win/media/controls-drag-timebar-expected.txt:
        * platform/win/media/controls-styling-expected.txt:
            Update for controller element tab order change.

        * platform/gtk/Skipped:
        * platform/win/Skipped:
            Skip new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/win: Build fix for Windows.
bfulgham@webkit.org [Tue, 25 Aug 2009 23:03:04 +0000 (23:03 +0000)]
WebKit/win: Build fix for Windows.

Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
settings so they link against the proper libraries.

* WebKit.vcproj/WebKit.sln:

WebKitTools: Build fix

Revise Debug_Cairo targets to point inherit from the
debug_wincairo.vsprops property sheet so that they link
against the proper libraries in Debug build.

* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
* WinLauncher/WinLauncher.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Tue, 25 Aug 2009 22:59:55 +0000 (22:59 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_CFLite target
bfulgham@webkit.org [Tue, 25 Aug 2009 22:54:30 +0000 (22:54 +0000)]
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_CFLite target
  that inherits from the debug_wincairo property sheet and therefore
  links to the proper debug library.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_CFLite target
  that inherits from the debug_wincairo property sheet and therefore
  links to the proper debug library.

Reviewed by NOBODY (Buildfix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRolled out r44739. Causes crash on Windows.
sfalken@apple.com [Tue, 25 Aug 2009 22:43:20 +0000 (22:43 +0000)]
Rolled out r44739. Causes crash on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[V8] Fix Canvas layout test failures in Chromium build.
jianli@chromium.org [Tue, 25 Aug 2009 22:38:31 +0000 (22:38 +0000)]
[V8] Fix Canvas layout test failures in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=28720

Reviewed by David Levin.

The previous fix r47757 does not handle the V8 object conversion correctly.

* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[V8] Fix compiling errors in Chromium build caused by Canvas3D changes from r47752.
jianli@chromium.org [Tue, 25 Aug 2009 21:04:58 +0000 (21:04 +0000)]
[V8] Fix compiling errors in Chromium build caused by Canvas3D changes from r47752.
https://bugs.webkit.org/show_bug.cgi?id=28717

Reviewed by David Levin.

* bindings/v8/DOMObjectsInclude.h:
* bindings/v8/DerivedSourcesAllInOne.cpp:
* bindings/v8/V8Index.cpp:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Tue, 25 Aug 2009 20:40:16 +0000 (20:40 +0000)]
2009-08-25  Alpha Lam  <hclam@chromium.org>

        Reviewed by David Levin.

        [chromium] Implement media volume slider for chromium
        https://bugs.webkit.org/show_bug.cgi?id=28715

        Provided the implementation of the volume slider and its container for
        chromium port. With this change there will be a usable volume control
        slider for chromium theme.

        No new tests since this is covered by existing media layout tests.

        * css/mediaControlsChromium.css: CSS style for the volume slider.
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::mediaSliderThumbImage): Returns the image for slider thumb.
        (WebCore::mediaVolumeSliderThumbImage): Returns the image for volume slider thumb.
        (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): Paints the track with one vertical white line.
        (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize): Adjusts thumb sizes according to the images.
        (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): Paints slider thumb image.
        (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): Paints volume slider thumb image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed a build problem on Tiger
cmarrin@apple.com [Tue, 25 Aug 2009 19:56:36 +0000 (19:56 +0000)]
Fixed a build problem on Tiger

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Missed checking in 2 Canvas3D files
cmarrin@apple.com [Tue, 25 Aug 2009 19:45:34 +0000 (19:45 +0000)]
    Missed checking in 2 Canvas3D files
        https://bugs.webkit.org/show_bug.cgi?id=28018

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Mads Ager <ager@chromium.org>
abarth@webkit.org [Tue, 25 Aug 2009 19:31:51 +0000 (19:31 +0000)]
2009-08-25  Mads Ager  <ager@chromium.org>

        Reviewed by Adam Barth.

        [V8] Exception from JavaScript propagates to main script
        https://bugs.webkit.org/show_bug.cgi?id=26433

        Test that both compile time and runtime exceptions thrown in
        javascript URLs are isolated from the main script.

        * fast/dom/javascript-url-exception-isolation-expected.txt: Added.
        * fast/dom/javascript-url-exception-isolation.html: Added.
        * fast/dom/resources/javascript-url-exception-isolation.js: Added.
2009-08-25  Mads Ager  <ager@chromium.org>

        Reviewed by Adam Barth.

        [V8] Exception from JavaScript propagates to main script
        https://bugs.webkit.org/show_bug.cgi?id=26433

        Make sure that exceptions thrown both at compile time and at
        runtime in javascript URLs are isolated from the main script.

        Test: fast/dom/javascript-url-exception-isolation.html

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added all new Canvas3D files to the build
cmarrin@apple.com [Tue, 25 Aug 2009 18:45:56 +0000 (18:45 +0000)]
    Added all new Canvas3D files to the build
        https://bugs.webkit.org/show_bug.cgi?id=28018

        This also hooks up CanvasRenderingContext as the common base class for
        CanvasRenderingContext2D and CanvasRenderingContext3D. And it adds a bit
        of logic throughout to support the new CanvasRenderingContext3D object.
        But nothing is hooked up yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPLATFORM(CFNETWORK) should be USE(CFNETWORK).
levin@chromium.org [Tue, 25 Aug 2009 18:30:00 +0000 (18:30 +0000)]
PLATFORM(CFNETWORK) should be USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=28713

Patch by David Levin <levin@chromium.org> on 2009-08-25
Reviewed by Adam Roben.

JavaScriptCore:

* wtf/Platform.h: Added a #define to catch this issue in the
future. The define would generate an error on gcc without the
space in the expansion, but Visual C++ needs the space to cause an error.

WebKit/win:

Also, moved the #if header section after the other #includes.

* WebError.cpp:
(WebError::localizedDescription):

WebKitTools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: Revise CFLite Debug build to emit DLL's with _debug label.
bfulgham@webkit.org [Tue, 25 Aug 2009 17:14:06 +0000 (17:14 +0000)]
JavaScriptCore: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modify
  Cairo debug build to inherit from new debug_cairo property sheet.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops:
  Modify to look for debug CFLite when in debug build.

WebKit/win: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

* WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to
  inherit from new debug_wincairo property sheet, instead of
  the current debug sheet.

WebKitLibraries: Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.

Reviewed by Steve Falkenburg.

* win/tools/vsprops/debug_wincairo.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r47630): fast/repaint/background-generated.html is failing
mitz@apple.com [Tue, 25 Aug 2009 17:09:31 +0000 (17:09 +0000)]
REGRESSION (r47630): fast/repaint/background-generated.html is failing
https://bugs.webkit.org/show_bug.cgi?id=28704

Reviewed by Anders Carlsson.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize): Handle SizeNone.
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer): Initialize the size type to SizeNone.
* rendering/style/FillLayer.h:
(WebCore::FillSize::FillSize): Changed assignment to initialization and
    removed redundant assignment to size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Yusuke Sato <yusukes@chromium.org>
eric@webkit.org [Tue, 25 Aug 2009 16:28:54 +0000 (16:28 +0000)]
2009-08-25  Yusuke Sato  <yusukes@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Complex text doesn't show up with text stroking
        https://bugs.webkit.org/show_bug.cgi?id=28707

        Skip the NULL check of m_hdc if Windows GDI is not in use.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Update outdated metrics in css1/font_properties. All tests pass.
kenneth@webkit.org [Tue, 25 Aug 2009 13:14:41 +0000 (13:14 +0000)]
[Qt] Update outdated metrics in css1/font_properties. All tests pass.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.

* platform/qt/Skipped:
* platform/qt/css1/font_properties/font-expected.txt:
* platform/qt/css1/font_properties/font_family-expected.txt:
* platform/qt/css1/font_properties/font_size-expected.txt:
* platform/qt/css1/font_properties/font_style-expected.txt:
* platform/qt/css1/font_properties/font_variant-expected.txt:
* platform/qt/css1/font_properties/font_weight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Antonio Gomes <antonio.gomes@openbossa.org>
kenneth@webkit.org [Tue, 25 Aug 2009 13:12:07 +0000 (13:12 +0000)]
2009-08-25  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Ariya Hidayat.

        Bug 28708 - Make possible to better use ResourceError in FrameLoaderClientQt class.

        * Api/qwebframe.cpp:
        (QWebFrame::requestedUrl):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
        (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
        (WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad):
        (WebCore::FrameLoaderClientQt::dispatchDidFailLoad):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Update outdated font metrics and add expected files for new tests.
kenneth@webkit.org [Tue, 25 Aug 2009 13:08:29 +0000 (13:08 +0000)]
[Qt] Update outdated font metrics and add expected files for new tests.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-25
Reviewed by Ariya Hidayat.

* platform/qt/Skipped:
* platform/qt/fast/backgrounds/001-expected.txt:
* platform/qt/fast/backgrounds/animated-gif-as-background-expected.txt: Added.
* platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt: Added.
* platform/qt/fast/backgrounds/animated-svg-as-mask-expected.txt: Added.
* platform/qt/fast/backgrounds/background-clip-text-expected.txt: Added.
* platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/qt/fast/backgrounds/background-origin-root-element-expected.txt: Added.
* platform/qt/fast/backgrounds/background-position-1-expected.txt: Added.
* platform/qt/fast/backgrounds/background-position-rounding-expected.txt: Added.
* platform/qt/fast/backgrounds/mask-composite-expected.txt: Added.
* platform/qt/fast/backgrounds/opacity-on-document-element-expected.txt: Added.
* platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt: Added.
* platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
* platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
* platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
* platform/qt/fast/backgrounds/size/zero-expected.txt: Added.
* platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
* platform/qt/fast/backgrounds/svg-as-mask-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Tue, 25 Aug 2009 12:04:25 +0000 (12:04 +0000)]
2009-08-25  Alpha Lam  <hclam@chromium.org>

        Reviewed by David Levin.

        Media controls panel does not have a volume control slider
        https://bugs.webkit.org/show_bug.cgi?id=28241

        Introduced "-webkit-media-controls-volume-slider",
        "-webkit-media-controls-volume-slider-container" and the supporting
        implementation. Also added appearances of "media-volume-slider" and
        "media-volume-slider-container".

        The implementation of the controls are in WebCore::MediaControlElements.
        Logic to trigger the display of the volume controls are in WebCore::RenderMedia.

        No new tests since this change doesn't have theme implementation and the
        volume slider is disabled by default.

        * accessibility/AccessibilitySlider.cpp:
        (WebCore::AccessibilitySlider::orientation): Marks that volume slider is vertical.
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added corresponding CSS values.
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType): ditto.
        * css/CSSSelector.h:
        (WebCore::CSSSelector::): ditto.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
        * css/CSSValueKeywords.in: ditto.
        * css/mediaControls.css: Makes the volume slider disabled by default.
        * platform/ThemeTypes.h: Defines theme parts for volume slider and its container.
        (WebCore::):
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
        (WebCore::MediaControlVolumeSliderContainerElement::styleForElement):
        Adjust the CSS values for "display", "postion", "left" and "top" according to member variables.
        (WebCore::MediaControlVolumeSliderContainerElement::setVisible): Affects the "display" CSS value.
        (WebCore::MediaControlVolumeSliderContainerElement::setPosition): Affects the "left" and "top" CSS values.
        (WebCore::MediaControlVolumeSliderContainerElement::hitTest): Hit testing this element.
        (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
        (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Modifies the volume using the slider value, allows dragging.
        * rendering/MediaControlElements.h:
        (WebCore::): Added definition for MediaControlVolumeSliderElement and MediaControlVolumeSliderContainerElement.
        (WebCore::MediaControlVolumeSliderContainerElement::isVisible): Inline getter.
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::styleDidChange): Updates styles for volume container and volume slider.
        (WebCore::RenderMedia::createVolumeSliderContainer): Creates volume slider container and attach to panel.
        (WebCore::RenderMedia::createVolumeSlider): Creates volume slider and attach to volume slider container.
        (WebCore::RenderMedia::updateControls): Updates volume container and volume slider.
        (WebCore::RenderMedia::updateVolumeSliderContainer): Sets the visibility and position of volume slider container and its child.
        (WebCore::RenderMedia::forwardEvent):
        Hit testing the volume slider container and volume slider to toggle the visibility and forward events to slider.
        * rendering/RenderMedia.h:
        Added definition for RenderMedia::updateVolumeSliderContainer().
        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::paintMediaControlsPart): Not implemented.
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::createThumbStyle): Makes volume slider vertical.
        (WebCore::RenderSlider::thumbRect): ditto.
        (WebCore::RenderSlider::mouseEventIsInThumb): ditto.
        (WebCore::RenderSlider::setValueForPosition): ditto.
        (WebCore::RenderSlider::positionForOffset): ditto.
        (WebCore::RenderSlider::currentPosition): ditto.
        (WebCore::RenderSlider::trackSize): ditto.
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle): Adjust style for volume slider thumb.
        (WebCore::RenderTheme::paint): Paints volume control parts using theme.
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::paintMediaVolumeSliderContainer): Naive implementation to be overridden.
        (WebCore::RenderTheme::paintMediaVolumeSliderTrack): ditto.
        (WebCore::RenderTheme::paintMediaVolumeSliderThumb): ditto.
        * rendering/style/RenderStyleConstants.h:
        (WebCore::): Constants for volume control parts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt/Mac] Use CONFIG+=build_all only when building libraries
vestbo@webkit.org [Tue, 25 Aug 2009 11:36:12 +0000 (11:36 +0000)]
[Qt/Mac] Use CONFIG+=build_all only when building libraries

Reviewed by Ariya Hidayat.

If no configuration is specified when building WebKit we pass the
debug_and_release option to QMake which results in Makefiles for
both configurations being generated.

Previously we built both of these configurations by default, for
all targets (both the QtWebKit framework/dyldlib and the various
executables such as QtLauncher and tests). This makes sense for
the libraries, which get the _debug suffix and can be loaded on
demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
ended up building the same executable twice.

We now only build one instance of each executable, and since this
is a developer build we build the debug-version. Passing either
--debug or --release to build-webkit will override this, and
even in the default case the release version can still be built
by running 'make release' in the the build directory of each
target.

* WebCore.pro:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-25 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 25 Aug 2009 07:18:44 +0000 (07:18 +0000)]
2009-08-25  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=28690
        Build failure in webkitgtk+-1.1.3

        Do not use deprecated function to unref a pixbuf.

        * platform/gtk/CursorGtk.cpp:
        (WebCore::Cursor::Cursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Hironori Bono <hbono@chromium.org>
abarth@webkit.org [Tue, 25 Aug 2009 06:53:30 +0000 (06:53 +0000)]
2009-08-24  Hironori Bono  <hbono@chromium.org>

        Reviewed by Adam Barth.

        Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
        <https://bugs.webkit.org/show_bug.cgi?id=27827>.

        Because of the lack of mappings from GDK key-codes to WebKit key-codes,
        Chromium cannot send valid key-codes to JavaScript when a user types
        function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

        To write layout tests for this issue, added mappings from function-key
        names to platform-specific key-codes to EventSendingController objects
        so that eventSender.keyDown() can send function-key events without using
        platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
        is only for Mac. So this change adds this new test to Skipped tests for other
        platforms to prevent this change from crashing the build trees.)

        * fast/events/keydown-function-keys-expected.txt: Added.
        * fast/events/keydown-function-keys.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2009-08-24  Hironori Bono  <hbono@chromium.org>

        Reviewed by Adam Barth.

        Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
        <https://bugs.webkit.org/show_bug.cgi?id=27827>.

        Because of the lack of mappings from GDK key-codes to WebKit key-codes,
        Chromium cannot send valid key-codes to JavaScript when a user types
        function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

        To write layout tests for this issue, added mappings from function-key
        names to platform-specific key-codes to EventSendingController objects
        so that eventSender.keyDown() can send function-key events without using
        platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
        is only for Mac. So this change adds this new test to Skipped tests for other
        platforms to prevent this change from crashing the build trees.)

        Test: fast/events/keydown-function-keys.html

       * platform/chromium/KeyCodeConversionGtk.cpp: Add mappings from GDK key-codes
        to WebKit key-code for function keys.
        (WebCore::windowsKeyCodeForKeyEvent):
2009-08-24  Hironori Bono  <hbono@chromium.org>

        Reviewed by Adam Barth.

        Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
        <https://bugs.webkit.org/show_bug.cgi?id=27827>.

        Because of the lack of mappings from GDK key-codes to WebKit key-codes,
        Chromium cannot send valid key-codes to JavaScript when a user types
        function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.

        To write layout tests for this issue, added mappings from function-key
        names to platform-specific key-codes to EventSendingController objects
        so that eventSender.keyDown() can send function-key events without using
        platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
        is only for Mac. So this change adds this new test to Skipped tests for other
        platforms to prevent this change from crashing the build trees.)

        * DumpRenderTree/mac/EventSendingController.mm:
        (-[EventSendingController keyDown:withModifiers:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix: start out with a 32-bit value to avoid a shortening warning.
ggaren@apple.com [Tue, 25 Aug 2009 04:23:59 +0000 (04:23 +0000)]
Build fix: start out with a 32-bit value to avoid a shortening warning.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24
* runtime/Collector.cpp:
(JSC::Heap::sweep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSubstantially reduced VM thrash in the GC heap.
ggaren@apple.com [Tue, 25 Aug 2009 04:09:29 +0000 (04:09 +0000)]
Substantially reduced VM thrash in the GC heap.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-08-24
Reviewed by Oliver Hunt.

1.08x faster on v8 (1.60x faster on v8-splay).

1.40x faster on bench-alloc-nonretained.

1.90x faster on bench-alloc-retained.

SunSpider says no change.

* runtime/Collector.cpp:
(JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local
variables unconditionally after calling collect(), since they may be used
even if we don't "goto scan". (In the bug I saw, usedBlocks got out of
sync with heap.usedBlocks).
(JSC::Heap::sweep): Keep enough free heap space to accomodate
the number of objects we'll allocate before the next GC, plus 25%, for
good measure.
* runtime/Collector.h: Bumped the block size to 256k. This seems to give
the best cache performance, and it prevents us from initiating lots of
VM traffic to recover very small chunks of memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=28691
barraclough@apple.com [Tue, 25 Aug 2009 02:53:51 +0000 (02:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=28691
Do not retain ScopeNodes outside of parsing

Reviewed by Oliver Adler & Darin Hunt.

There is now no need for these to exist outside of parsing - their use in the runtime is replaced by Executable types.

* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* parser/Nodes.cpp:
(JSC::ScopeNodeData::ScopeNodeData):
(JSC::ProgramNode::create):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(JSC::ScopeNode::adoptData):
(JSC::FunctionBodyNode::parameterCount):
* parser/Parser.cpp:
* parser/Parser.h:
(JSC::Parser::arena):
(JSC::Parser::Parser):
(JSC::Parser::parse):
* runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
(JSC::arrayProtoFuncSort):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compile):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::copyParameters):
(JSC::FunctionExecutable::paramString):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::sourceID):
(JSC::ScriptExecutable::sourceURL):
(JSC::ScriptExecutable::lineNo):
(JSC::ScriptExecutable::lastLine):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::recordParse):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::make):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::jitCode):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=28698
antti@apple.com [Tue, 25 Aug 2009 00:50:26 +0000 (00:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=28698
Avoid unnecessary transformations for the window resizer rect.

Reviewed by Simon Fraser.

* platform/Scrollbar.cpp:
(WebCore::Scrollbar::setFrameRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
ap@apple.com [Tue, 25 Aug 2009 00:42:52 +0000 (00:42 +0000)]
    Reviewed by Anders Carlsson.

        <rdar://problem/7161900> REGRESSION: 100 MB membuster leak on windows due to 47391
        (DNS prefetching support)

        * platform/network/cf/DNSCFNet.cpp: (WebCore::prefetchDNS): Use a run loop from secondary
        thread on Windows, because there isn't one on main one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 25 Aug 2009 00:09:39 +0000 (00:09 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=28374
        Cross-scheme requests should not be blocked by appcache rules

        Test: http/tests/appcache/different-scheme.html

        * loader/appcache/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
        Resources with different schemes can never be loaded from appcache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler and Sam Weinig.
ap@apple.com [Tue, 25 Aug 2009 00:03:19 +0000 (00:03 +0000)]
    Reviewed by Darin Adler and Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=28688
        REGRESSION(r24994): Cannot create a frame with a javascript URL

        Test: http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html

        * bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
        * bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL):
        * bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
        * bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc):
        Omit the checks if there is no document in frame yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 24 Aug 2009 22:58:39 +0000 (22:58 +0000)]
2009-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skip the correct test (media/video-currentTime-set.html, not
        media/video-currentTime-set2.html).

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 24 Aug 2009 22:47:53 +0000 (22:47 +0000)]
2009-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skip 3 new tests, and reenable some of the media tests, now that
        the bot it fixed to handle the fact that it doesn't have a sound
        card.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 24 Aug 2009 21:56:40 +0000 (21:56 +0000)]
2009-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Skip again tests that we enabled, since they are
        failing on the bot. The tests do pass, but there is an environment
        configuration problem with GStreamer on the bot (possibly related
        to the fact that it has no sound card).

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* runtime/ObjectPrototype.cpp:
darin@apple.com [Mon, 24 Aug 2009 21:37:29 +0000 (21:37 +0000)]
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put): Landed revised version I had tested but forgot
to land. Leave out the branch, since we don't need one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 24 Aug 2009 21:21:03 +0000 (21:21 +0000)]
2009-08-24  Nate Chapin  <japhet@chromium.org>

        Reviewed by Eric Seidel.

        Fix crash in fast/css/rem-dynamic-scaling.html due to a freed
        RenderStyle being accessed.

        https://bugs.webkit.org/show_bug.cgi?id=28681

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): Make currentStyle a RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
adachan@apple.com [Mon, 24 Aug 2009 21:08:11 +0000 (21:08 +0000)]
    Reviewed by Mark Rowe.

        Skip loader/go-back-to-different-window-size.html for qt and gtk.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoArray index miss case creates a string every time
darin@apple.com [Mon, 24 Aug 2009 21:05:13 +0000 (21:05 +0000)]
Array index miss case creates a string every time
https://bugs.webkit.org/show_bug.cgi?id=28664

Patch by Darin Adler <darin@apple.com> on 2009-08-24
Reviewed by Geoff Garen.

SunSpider test results I saw:

    0.5% faster overall
    1% faster on crypto-aes
    20% faster on crypto-md5
    13% faster on crypto-sha1

* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype): Initialize m_hasNoPropertiesWithUInt32Names
to true.
(JSC::ObjectPrototype::put): Clearly m_hasNoPropertiesWithUInt32Names if the new
property has a name that is the string form of a UInt32.
(JSC::ObjectPrototype::getOwnPropertySlot): Don't call JSObject::getOwnPropertySlot
if m_hasNoPropertiesWithUInt32Names is true, and it is highly likely to be true.

* runtime/ObjectPrototype.h: Added declarations for the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/5743105> Long freezing during loading and selecting text
mitz@apple.com [Mon, 24 Aug 2009 20:45:26 +0000 (20:45 +0000)]
<rdar://problem/5743105> Long freezing during loading and selecting text
of a large table
https://bugs.webkit.org/show_bug.cgi?id=14918

Reviewed by Simon Fraser.

* rendering/RenderView.cpp:
(WebCore::RenderView::setSelection): Added calls to
    beginDeferredRepaints() and endDeferredRepaints() around the
    invalidation of the selection, in order to better coalesce multiple
    invalid rectangles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 24 Aug 2009 20:26:51 +0000 (20:26 +0000)]
2009-08-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Simplify findTreeElement code, get rid of potential infinite loop.

        https://bugs.webkit.org/show_bug.cgi?id=28680

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
        * inspector/front-end/treeoutline.js:
        (TreeOutline.prototype.getCachedTreeElement):
        (TreeOutline.prototype.findTreeElement):
        * inspector/front-end/utilities.js:
        (isAncestorNode):
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 24 Aug 2009 20:20:44 +0000 (20:20 +0000)]
2009-08-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Do expand local scope when hitting the break

        https://bugs.webkit.org/show_bug.cgi?id=28678

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Brady Eidson.
adachan@apple.com [Mon, 24 Aug 2009 20:16:00 +0000 (20:16 +0000)]
    Reviewed by Brady Eidson.

        Add test for https://bugs.webkit.org/show_bug.cgi?id=28659.
        Cached page should be formatted according to the current window size, not the cached frame's size.

        * loader: Added.
        * loader/go-back-to-different-window-size-expected.txt: Added.
        * loader/go-back-to-different-window-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Steve Falkenburg.
adachan@apple.com [Mon, 24 Aug 2009 19:55:23 +0000 (19:55 +0000)]
    Reviewed by Steve Falkenburg.

        Make sure we use the current FrameView's frame rect when
        going back to a cached page.

        https://bugs.webkit.org/show_bug.cgi?id=28659

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 24 Aug 2009 19:10:17 +0000 (19:10 +0000)]
2009-08-24  Eric Seidel  <eric@webkit.org>

        No review, just updating results.

        Support placeholder on textarea
        https://bugs.webkit.org/show_bug.cgi?id=21248

        Update expected test results form windows bot.

        * platform/win/fast/forms/basic-textareas-expected.txt:
        * platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
        * platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
        * platform/win/fast/forms/textarea-placeholder-set-value-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Mon, 24 Aug 2009 18:35:22 +0000 (18:35 +0000)]
2009-08-24  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Darin Adler.

        Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
        https://bugs.webkit.org/show_bug.cgi?id=28673

        * svg/dom/resources/text-rotate-live.js: Added.
        (getRotate):
        (getAndSetRotate):
        * svg/dom/text-rotate-live-expected.txt: Added.
        * svg/dom/text-rotate-live.html: Added.
2009-08-24  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Darin Adler.

        Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList
        https://bugs.webkit.org/show_bug.cgi?id=28673

        Test: svg/dom/text-rotate-live.html

        * svg/SVGNumberList.cpp:
        (WebCore::SVGNumberList::parse): Clear the list before adding the parsed
        numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 24 Aug 2009 18:07:31 +0000 (18:07 +0000)]
2009-08-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by NOBODY (build fix)

        Turn off ENABLE_3D_CANVAS in the xconfig files.

        * Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 24 Aug 2009 16:40:34 +0000 (16:40 +0000)]
2009-08-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Only expand local scope when hitting the break

        https://bugs.webkit.org/show_bug.cgi?id=28678

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 24 Aug 2009 16:26:47 +0000 (16:26 +0000)]
WebCore:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674

Reviewed by Simon Fraser.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillSize): Added an allowComma parameter,
    which is set to false when this method consumes a comma. Moved
    handling of 'contain' and 'cover' from parseFillProperty into this
    method.
(WebCore::CSSParser::parseFillProperty): Set allowComma to true before
    processing the next value, and pass allowComma to parseFillSize.
* css/CSSParser.h:

LayoutTests:
background-size fails to parse if a single length/percentage/auto is followed by a comma
https://bugs.webkit.org/show_bug.cgi?id=28674

Reviewed by Simon Fraser.

* fast/backgrounds/size/parsing-background-size-values-expected.txt:
* fast/backgrounds/size/resources/parsing-background-size-values.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 24 Aug 2009 16:02:47 +0000 (16:02 +0000)]
2009-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Fix a typo in my distcheck build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 24 Aug 2009 15:41:58 +0000 (15:41 +0000)]
2009-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        News about the 1.1.13 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 24 Aug 2009 15:28:24 +0000 (15:28 +0000)]
2009-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Bump package and so versions for 1.1.13 release.

        * configure.ac:

WebKit/gtk

2009-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Add new symbols, and an index of new symbols for the 1.1.13
        release.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-17 Martin Robinson <martin.james.robinson@gmail.com>
kov@webkit.org [Mon, 24 Aug 2009 14:55:07 +0000 (14:55 +0000)]
2009-08-17  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] Support for cursors that are images
        https://bugs.webkit.org/show_bug.cgi?id=28346

        Added support for cursors which are images for CursorGtk. Added
        a manual test for this.

        * manual-tests/gtk/cursor-image.html: Added.
        * manual-tests/gtk/resources/redcursor.cur: Added.
        * platform/gtk/CursorGtk.cpp:
        (WebCore::Cursor::Cursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Add missing files from former commit 47709.
kenneth@webkit.org [Mon, 24 Aug 2009 14:48:01 +0000 (14:48 +0000)]
Unreviewed. Add missing files from former commit 47709.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-24
* platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kov@webkit.org [Mon, 24 Aug 2009 14:30:38 +0000 (14:30 +0000)]
WebCore:

2009-08-24  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] Integrate GStreamer video with the graphics backend
        https://bugs.webkit.org/show_bug.cgi?id=16356

        Improves GStreamer backend implementation of MediaPlayerPrivate class.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateErrorCallback): Send proper MediaPlayer
        error for different GStreamer errors to MediaPlayerPrivate.
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Move static
        initialization boolean to a better place.
        (WebCore::MediaPlayerPrivate::play):
        (WebCore::MediaPlayerPrivate::pause):
        (WebCore::MediaPlayerPrivate::duration): Return if error occured, do not
        consider the source as stream if duration query failed.
        (WebCore::MediaPlayerPrivate::currentTime): Return if error occured, use
        an early return.
        (WebCore::MediaPlayerPrivate::seek): Return if error occured.
        (WebCore::MediaPlayerPrivate::setEndTime): Remove implementation since this
        function doesn't seem to be used anywhere in WebCore.
        (WebCore::MediaPlayerPrivate::paused):
        (WebCore::MediaPlayerPrivate::seeking):
        (WebCore::MediaPlayerPrivate::setRate): Seek to current time when rate is set.
        (WebCore::MediaPlayerPrivate::maxTimeBuffered): Return if error occured.
        (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto.
        (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
        (WebCore::MediaPlayerPrivate::bytesLoaded):
        (WebCore::MediaPlayerPrivate::totalBytesKnown):
        (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
        (WebCore::MediaPlayerPrivate::updateStates): Return if error occured, update
        after seek ended with a successful change
        (WebCore::MediaPlayerPrivate::didEnd): Do not pause the playbin when end is reached.
        (WebCore::MediaPlayerPrivate::loadingFailed): Update network state with the given error.
        (WebCore::mimeTypeCache): Gather supported mime types from GStreamer.
        (WebCore::MediaPlayerPrivate::getSupportedTypes):
        (WebCore::MediaPlayerPrivate::supportsType):
        (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
        (WebCore::MediaPlayerPrivate::supportsFullscreen): First step towards fullscreen
        support.
        (WebCore::MediaPlayerPrivate::createGSTPlayBin): Use playbin2 instead of playbin,
        do not set playbin's audio sink.
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_idle_func): Use C++ casts, decrease reference count of async
        queue at the end of the idle function.
        (webkit_video_sink_render): Increase reference count of async queue.
        (webkit_video_sink_stop): Remove any idle functions with the sink as data.

LayoutTests:

2009-08-24  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] Integrate GStreamer video with the graphics backend
        https://bugs.webkit.org/show_bug.cgi?id=16356

        Enable media tests that now pass.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add results with updated font metrics for passing tests added in
kenneth@webkit.org [Mon, 24 Aug 2009 14:26:05 +0000 (14:26 +0000)]
[Qt] Add results with updated font metrics for passing tests added in
r28637 and remove them from Skipped.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-08-24
Reviewed by Ariya Hidayat.

* platform/qt/Skipped:
* platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Added.
* platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remaining new files for Canvas3D
cmarrin@apple.com [Mon, 24 Aug 2009 13:38:37 +0000 (13:38 +0000)]
    Remaining new files for Canvas3D
        https://bugs.webkit.org/show_bug.cgi?id=28018

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>
ariya@webkit.org [Mon, 24 Aug 2009 11:58:45 +0000 (11:58 +0000)]
2009-08-24  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        [Qt] Add results for new tests added in r47590 and r47702.

        * platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
        * platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
        * platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
        * platform/qt/fast/repaint/inline-block-resize-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Mon, 24 Aug 2009 11:05:49 +0000 (11:05 +0000)]
2009-08-24  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Skip new test added in r47630

        * platform/qt/Skipped: Skip fast/backgrounds/size/parsing-inherit.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
ariya@webkit.org [Mon, 24 Aug 2009 10:18:27 +0000 (10:18 +0000)]
2009-08-24  Renata Hodovan  <hodovan.renata@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        [Qt] Update the outdated metrics for doctype tests. All tests pass.

        * platform/qt/Skipped:
        * platform/qt/fast/doctypes/001-expected.txt:
        * platform/qt/fast/doctypes/002-expected.txt:
        * platform/qt/fast/doctypes/004-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Andras Becsi <becsi.andras@stud.u-szeged.hu>
ariya@webkit.org [Mon, 24 Aug 2009 10:09:52 +0000 (10:09 +0000)]
2009-08-24  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        [Qt] Add results for new tests added in r47678.

        * platform/qt/fast/block/margin-collapse/block-inside-inline: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
        * platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 24 Aug 2009 10:09:42 +0000 (10:09 +0000)]
2009-08-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Migrate call frames interaction to the InjectedScript-based schema.

        https://bugs.webkit.org/show_bug.cgi?id=28408

        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        (WebInspector.ConsoleTextMessage):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.get domWindow):
        (InspectorController.openInInspectedWindow):
        (InspectorController.getCallFrames):
        (InspectorController.evaluateInCallFrame):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.reset):
        (WebInspector.ElementsPanel.prototype.generateStylesheet):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.evaluate):
        (InjectedScript._evaluateOn):
        (InjectedScript.openInInspectedWindow):
        (InjectedScript.getCallFrames):
        (InjectedScript.evaluateInCallFrame):
        (InjectedScript._callFrameForId):
        (InjectedScript._objectForId):
        (InjectedScript.CallFrameProxy):
        (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection.prototype._update):
        * inspector/front-end/ObjectProxy.js:
        (WebInspector.ObjectPropertyProxy):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane):
        (WebInspector.ScopeChainSidebarPane.prototype.update):
        (WebInspector.ScopeVariableTreeElement.prototype.onattach):
        (WebInspector.ScopeVariableTreeElement.prototype.onexpand):
        (WebInspector.ScopeVariableTreeElement.prototype.oncollapse):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
        (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame):
        (WebInspector.ScriptsPanel.prototype.debuggerPaused.callback):
        (WebInspector.ScriptsPanel.prototype.debuggerPaused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-24 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Mon, 24 Aug 2009 08:28:51 +0000 (08:28 +0000)]
2009-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        - Add tests for the placeholder attribute and DOM property of the textarea element.
        - Correct the results for input-text-maxlength.html
        https://bugs.webkit.org/show_bug.cgi?id=21248

        * fast/forms/resources/textarea-placeholder-dom-property.js: Added.
        * fast/forms/textarea-placeholder-dom-property-expected.txt: Added.
        * fast/forms/textarea-placeholder-dom-property.html: Added.
        * fast/forms/textarea-placeholder-pseudo-style.html: Added.
        * fast/forms/textarea-placeholder-set-attribute.html: Added.
        * fast/forms/textarea-placeholder-set-value.html: Added.
        * platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
        * platform/mac/fast/forms/input-text-maxlength-expected.txt:
        * platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
        * platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt: Added.
        * platform/mac/fast/forms/textarea-placeholder-set-value-expected.txt: Added.
        * platform/qt/fast/forms/input-text-maxlength-expected.txt:
        * platform/win/fast/forms/input-text-maxlength-expected.txt:
2009-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Add support for the placeholder attribute and DOM property of the textarea element.
        https://bugs.webkit.org/show_bug.cgi?id=21248

        A DOM node for an INPUT element doesn't have a flag for placeholder
        visibility anymore.  This patch also fixes a bug that a renderer
        doesn't reflect a corresponding DOM value change.

        Tests: fast/forms/textarea-placeholder-dom-property.html
               fast/forms/textarea-placeholder-pseudo-style.html
               fast/forms/textarea-placeholder-set-attribute.html
               fast/forms/textarea-placeholder-set-value.html

        * css/html.css: Add the default style for placeholder of textarea.
        * dom/InputElement.cpp: Cleanup for m_placeholderShouldBeVisible removal
        (WebCore::InputElement::dispatchFocusEvent):
        (WebCore::InputElement::dispatchBlurEvent):
        (WebCore::InputElement::placeholderShouldBeVisible):
        (WebCore::InputElement::updatePlaceholderVisibility):
        (WebCore::InputElement::setValueFromRenderer):
        (WebCore::InputElementData::InputElementData):
        * dom/InputElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::dispatchFocusEvent):
        (WebCore::HTMLInputElement::dispatchBlurEvent):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::placeholderShouldBeVisible):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::updatePlaceholderVisibility):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):
        (WebCore::HTMLTextAreaElement::setValue):
        (WebCore::HTMLTextAreaElement::placeholderShouldBeVisible):
        (WebCore::HTMLTextAreaElement::updatePlaceholderVisibility):
        (WebCore::HTMLTextAreaElement::dispatchFocusEvent):
        (WebCore::HTMLTextAreaElement::dispatchBlurEvent):
        * html/HTMLTextAreaElement.h:
        * html/HTMLTextAreaElement.idl:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::RenderTextControl):
        (WebCore::RenderTextControl::styleDidChange):
        (WebCore::RenderTextControl::setInnerTextStyle):
        (WebCore::RenderTextControl::updatePlaceholderVisibility):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        (WebCore::RenderTextControlMultiLine::updateFromElement):
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        (WebCore::RenderTextControlMultiLine::textBaseStyle):
        * rendering/RenderTextControlMultiLine.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
        (WebCore::RenderTextControlSingleLine::textBaseStyle):
        (WebCore::RenderTextControlSingleLine::updateFromElement):
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
        * rendering/RenderTextControlSingleLine.h:
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::dispatchFocusEvent):
        (WebCore::WMLInputElement::dispatchBlurEvent):
        (WebCore::WMLInputElement::setValue):
        (WebCore::WMLInputElement::placeholderShouldBeVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
zoltan@webkit.org [Mon, 24 Aug 2009 07:14:51 +0000 (07:14 +0000)]
Unreviewed.

Change my mail address on the list of committers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 24 Aug 2009 07:02:12 +0000 (07:02 +0000)]
2009-08-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Fix regression in editing tests by changing expected file to the
        Mac one, since we now default to Mac in the EditingBehavior
        setting.

        * platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 24 Aug 2009 07:01:58 +0000 (07:01 +0000)]
2009-08-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Fix a couple of typos.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 24 Aug 2009 06:00:03 +0000 (06:00 +0000)]
2009-08-23  Dirk Schulze  <krit@webkit.org>

        Reviewed by Mark Rowe.

        Code clean-up and build fix for filters enabled builds. Moved SVGNames.h
        into #if ENABLE(SVG) for Document.cpp and added SVGNames.h to the other
        files. They are needed there after r47688.

        * dom/Document.cpp:
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeNodeElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kov@webkit.org [Mon, 24 Aug 2009 03:44:00 +0000 (03:44 +0000)]
WebCore:

2009-08-23  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed, build fix for make distcheck on GTK+.

        * GNUmakefile.am: Added files needed for the build.
        * bindings/js/JSDOMWindowCustom.cpp: Protect SharedWorker include
        with #if clause.
        * bindings/js/JSEventTarget.cpp: Dito.
        * dom/Document.cpp: Dito.
        * loader/FrameLoader.cpp: Dito.

JavaScriptCore:

2009-08-23  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed build fix for make distcheck.

        * GNUmakefile.am: Added files required for the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Joseph Pecoraro <joepeck@webkit.org>
eric@webkit.org [Sun, 23 Aug 2009 21:42:09 +0000 (21:42 +0000)]
2009-08-23  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Inspector: Throws an Error on "null"
        https://bugs.webkit.org/show_bug.cgi?id=28665

        * inspector/front-end/InjectedScript.js:
        (InjectedScript.evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 23 Aug 2009 19:49:44 +0000 (19:49 +0000)]
2009-08-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often

        https://bugs.webkit.org/show_bug.cgi?id=28666

        * inspector/front-end/InjectedScript.js:
        (InjectedScript.getProperties):
        (InjectedScript.createProxyObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 23 Aug 2009 19:24:35 +0000 (19:24 +0000)]
2009-08-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update editing-behavior property here too.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_settings_notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 23 Aug 2009 17:04:22 +0000 (17:04 +0000)]
2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubberstamped by Gustavo Noronha.

        Fix regressions introduced by http://trac.webkit.org/changeset/47690.

        Update the setting whenever the property gets set.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_settings_notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 23 Aug 2009 10:08:06 +0000 (10:08 +0000)]
2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] API for disabling local file access to web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28663

        Enable this setting for DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 23 Aug 2009 09:05:08 +0000 (09:05 +0000)]
2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Not reviewed. Skip new tests from
        http://trac.webkit.org/changeset/47678 and the appcache HTTP
        authentication tests (https://bugs.webkit.org/show_bug.cgi?id=28668)

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 23 Aug 2009 08:45:57 +0000 (08:45 +0000)]
2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] API for disabling local file access to web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28663

        Add a setting to enable or disable file access to web URLs. It's
        disabled by default for security reasons.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-22 Martin Robinson <martin.james.robinson@gmail.com>
xan@webkit.org [Sun, 23 Aug 2009 07:18:17 +0000 (07:18 +0000)]
2009-08-22  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly
        https://bugs.webkit.org/show_bug.cgi?id=28345

        When doing the conversion between cairo_surface_t* and GdkPixbuf*
        account for the differences in the respective formats' in-memory
        image format.

        * platform/graphics/gtk/ImageGtk.cpp:
        (WebCore::getCairoSurfacePixel):
        (WebCore::getGdkPixbufPixel):
        (WebCore::BitmapImage::getGdkPixbuf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake DOM classes start with a reference count of 1, like all other RefCounted
darin@apple.com [Sun, 23 Aug 2009 06:55:57 +0000 (06:55 +0000)]
Make DOM classes start with a reference count of 1, like all other RefCounted

Patch by Darin Adler <darin@apple.com> on 2009-08-22
Reviewed by Oliver Hunt.

Next step: Element, HTMLElement, HTMLAnchorElement, HTMLAppletElement,
HTMLAreaElement, HTMLEmbedElement, HTMLFrameElement, HTMLIFrameElement,
HTMLObjectElement, HTMLPlugInElement, HTMLPlugInImageElement.

* DerivedSources.make: Fix error seen every time we build by escaping the $
in the build rule, since you have to use $$ for that in make.

* WebCore.base.exp: Updated.

* bindings/objc/DOM.mm:
Added now-needed include of SVGNames.h.

* dom/Document.cpp: Added now-needed include of SVGNames.h.
(WebCore::Document::createElement): Use create instead of new.

* dom/Element.cpp:
(WebCore::Element::Element): Added ConstructionType argument so the caller
can determine whether this starts with a reference count of either 0 or 1.
Later we will remove this again once they are all 1.
(WebCore::Element::create): Added.

* dom/Element.h: Added create and made constructor protected.

* dom/StyledElement.cpp:
(WebCore::StyledElement::StyledElement): Added ConstructionType argument.
* dom/StyledElement.h: Made many functions protected or private, including
the constructor.

* dom/make_names.pl: Use create to create the base elements HTMLElement,
SVGElement, and WMLElement.

* editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply): Use create instead of new.
* editing/UnlinkCommand.cpp:
(WebCore::UnlinkCommand::doApply): Ditto.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::create): Added.
* html/HTMLAnchorElement.h: Made constructor protected and added create.
Also made m_rootEditableElementForSelectionOnMouseDown a RefPtr.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::create): Added.
* html/HTMLAppletElement.h: Made constructor private and added create.

* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::create): Added.
* html/HTMLAreaElement.h: Made constructor private and added create.

* html/HTMLElement.cpp:
(WebCore::HTMLElement::create): Added.
* html/HTMLElement.h: Made constructor protected and added create.
Made other functions protected and private. Also added inline
definition of constructor.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::create): Added.
* html/HTMLEmbedElement.h: Made constructor private and added create.
Made other functions private.

* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::create): Added.
(WebCore::HTMLFrameElement::parseMappedAttribute):
* html/HTMLFrameElement.h: Made constructor private and added create.
Made other functions private.

* html/HTMLFrameElementBase.h: Made functions protected and private.

* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Pass
CreateElement so reference count starts at 1.

* html/HTMLFrameOwnerElement.h: Made functions protected and private.

* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::create): Added.
* html/HTMLIFrameElement.h: Made constructor private and added create.
Made other functions private.

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::create): Added.
(WebCore::HTMLObjectElement::containsJavaApplet): Changed while loop
into a for loop and tweaked formatting.

* html/HTMLObjectElement.h: Made constructor private and added create.
Made other functions private.

* html/HTMLPlugInElement.h: Made constructor protected.
Made other functions protected and private.

* html/HTMLPlugInImageElement.h: Made constructor and another function
protected.

* html/HTMLTagNames.in: Removed createWithNew from all classes that
now have create functions. Moved conditional noscript to a separate
paragraph.

* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use create.
(WebCore::HTMLViewSourceDocument::addLink): Ditto.
* page/DragController.cpp:
(WebCore::documentFragmentFromDragData): Ditto.

* svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::SVGElement::create): Added.
* svg/SVGElement.h: Added create, made constructor protected, and
made other functions protected and private. Removed unneeded
SVGNames.h include.

* svg/SVGExternalResourcesRequired.h: Added now-needed SVGNames.h
include.

* svg/SVGStopElement.h: Added now-needed SVGNames.h include.
Made functions private.

* wml/WMLElement.cpp:
(WebCore::WMLElement::WMLElement): Pass CreateElementZeroRefCount
so reference count still starts at 0. Will change this class later.
(WebCore::WMLElement::create): Added.
* wml/WMLElement.h: Added create and made constructor protected.

* wml/WMLTagNames.in: Removed createWithNew from WMLElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 23 Aug 2009 06:36:34 +0000 (06:36 +0000)]
2009-08-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=28154
        clicking below end of text in a textarea moves cursor to wrong position

        Expose the EditingBehavior setting and set it by default to Mac,
        since that what matches the GTK+ default behavior.

        * webkit/webkitprivate.cpp:
        (WebKit::core):
        * webkit/webkitprivate.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebsettings.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC
mjs@apple.com [Sun, 23 Aug 2009 05:04:45 +0000 (05:04 +0000)]
REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC
https://bugs.webkit.org/show_bug.cgi?id=28655

Reviewed by Mark Rowe.

* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction): Initialize properly with a VPtrHackExecutable.
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/mac: Revert 47684. We're going to do this later once clients have had a
abarth@webkit.org [Sun, 23 Aug 2009 04:43:32 +0000 (04:43 +0000)]
WebKit/mac: Revert 47684.  We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
* Misc/WebKitVersionChecks.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

WebKit/qt: Revert 47684.  We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
* Api/qwebsettings.cpp:
(QWebSettings::QWebSettings):

WebKit/win: Revert 47684.  We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):

WebKitTools: Revert 47684.  We're going to do this later once clients have had a
chance to opt into the setting they like.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-22
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 23 Aug 2009 04:24:09 +0000 (04:24 +0000)]
2009-08-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't let local files access web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28480

        * Misc/WebKitVersionChecks.m:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
2009-08-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't let local files access web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28480

        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):
2009-08-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't let local files access web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28480

        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
2009-08-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't let local files access web URLs
        https://bugs.webkit.org/show_bug.cgi?id=28480

        A bunch of our LayoutTests rely on our old behavior, so we explicitly
        grant local files universal access during testing.  Mainly, these tests
        involve making XMLHttpRequests for data URLs.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for <rdar://problem/7161656> Crash in RenderObject::destroy when using custom...
adele@apple.com [Sun, 23 Aug 2009 00:43:48 +0000 (00:43 +0000)]
Fix for <rdar://problem/7161656> Crash in RenderObject::destroy when using custom scrollbars

Reviewed by Anders Carlsson.

Custom scrollbars normally get detached when a document gets detached.  In this case, a crash was happening when the document had gone into the page cache
and then was getting destroyed without proper scrollbar teardown.  This change makes custom scrollbars get detached when the document enters the cache.

I couldn't figure out a way to reliably cause this to happen in DRT, since the reproducible case relies on the cache being purged at a particular time.

* history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Detach custom scrollbars when the CachedFrame is created.
  They'll get reattached when the document comes out of the page cache.
* page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added some asserts to catch this problem earlier in debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Make sure self-collapsing blocks that clear floats are still able to collaps...
hyatt@apple.com [Sat, 22 Aug 2009 23:26:24 +0000 (23:26 +0000)]
WebCore: Make sure self-collapsing blocks that clear floats are still able to collapse their bottom margins with
the bottom of their parent blocks.  The old code prevented all collapsing, but all CSS2.1 states is that:
"An element that has had clearance applied to it never collapses its top margin with its parent block's bottom margin."

Reviewed by Dan Bernstein.

The implication is that the bottom margin can still collapse, and the block-inside-inline form of
fast/block/margin-collapse/025.html (added as fast/block/margin-collapse/block-inside-inline/025.html) depends
on it to get comparable results.

Added block-inside-inline tests (a whole slew of them) in fast/block/margin-collapse/block-inside-inline/

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::handleBottomOfBlock):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::canCollapseBottomWithChildren):

LayoutTests: Add a bunch of tests for the block-inside-inline cases of margin-collapsing.  The same test
suite but converted to wrap all the blocks inside inlines to make sure they still collapse
the same way.

Reviewed by Dan Bernstein.

* fast/block/margin-collapse/block-inside-inline: Added.
* fast/block/margin-collapse/block-inside-inline/001.html: Added.
* fast/block/margin-collapse/block-inside-inline/002.html: Added.
* fast/block/margin-collapse/block-inside-inline/003.html: Added.
* fast/block/margin-collapse/block-inside-inline/004.html: Added.
* fast/block/margin-collapse/block-inside-inline/005.html: Added.
* fast/block/margin-collapse/block-inside-inline/006.html: Added.
* fast/block/margin-collapse/block-inside-inline/010.html: Added.
* fast/block/margin-collapse/block-inside-inline/011.html: Added.
* fast/block/margin-collapse/block-inside-inline/012.html: Added.
* fast/block/margin-collapse/block-inside-inline/015.html: Added.
* fast/block/margin-collapse/block-inside-inline/016.html: Added.
* fast/block/margin-collapse/block-inside-inline/017.html: Added.
* fast/block/margin-collapse/block-inside-inline/018.html: Added.
* fast/block/margin-collapse/block-inside-inline/019.html: Added.
* fast/block/margin-collapse/block-inside-inline/020.html: Added.
* fast/block/margin-collapse/block-inside-inline/021.html: Added.
* fast/block/margin-collapse/block-inside-inline/022.html: Added.
* fast/block/margin-collapse/block-inside-inline/025.html: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.checksum: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.png: Added.
* platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBring signed updates to the Mac nightly builds.
mrowe@apple.com [Sat, 22 Aug 2009 22:56:59 +0000 (22:56 +0000)]
Bring signed updates to the Mac nightly builds.

Rubber-stamped by Anders Carlsson.

* WebKitLauncher/Info.plist:
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
* WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(initializeSparkle):
* WebKitLauncher/nightly.webkit.org.public.pem: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNeed to implement ARIA role="listitem" and role="list"
cfleizach@apple.com [Sat, 22 Aug 2009 17:54:37 +0000 (17:54 +0000)]
Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Fixing LayoutTest bustage.

The SnowLeopard results are the latest, so they need to move to platform/mac
The Tiger/Leopard results will default to the SnowLeopard results, so we need to move
the current test from platform/mac to platform/mac-leopard

* platform/mac-leopard/accessibility/aria-roles-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-roles-expected.txt.
* platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Removed.
* platform/mac/accessibility/aria-roles-expected.txt: Replaced with LayoutTests/platform/mac-snowleopard/accessibility/aria-roles-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Need to implement ARIA role="listitem" and role="list"
cfleizach@apple.com [Sat, 22 Aug 2009 17:03:24 +0000 (17:03 +0000)]
WebCore: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Reviewed by Darin Adler.

Test: platform/mac-snowleopard/accessibility/aria-list-and-listitem.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isUnorderedList):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):

LayoutTests: Need to implement ARIA role="listitem" and role="list"
https://bugs.webkit.org/show_bug.cgi?id=28606

Reviewed by Darin Adler.

Also added a SnowLeopard specific result for aria-roles-expected.

* platform/mac-snowleopard/accessibility: Added.
* platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt: Added.
* platform/mac-snowleopard/accessibility/aria-list-and-listitem.html: Added.
* platform/mac-snowleopard/accessibility/aria-roles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up fill image geometry calculation
mitz@apple.com [Sat, 22 Aug 2009 16:32:53 +0000 (16:32 +0000)]
Clean up fill image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=28652

Reviewed by Darin Adler.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize): Renamed
    calculateBackgroundSize() to this. Replaced separate scaledWidth and
    scaledHeight parameters with a single scaledSize parameter. Renamed
    parameters and local variables.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Changed
    to use CSS3 Backgrounds and Borders terminology in comments and
    local variable names. Renamed, clarified and consolidated some local
    variables.
* rendering/RenderBoxModelObject.h: Made calculateFillTileSize() private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Backing out http://trac.webkit.org/changeset/47669
cmarrin@apple.com [Sat, 22 Aug 2009 16:16:00 +0000 (16:16 +0000)]
    Backing out trac.webkit.org/changeset/47669

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 22 Aug 2009 16:10:49 +0000 (16:10 +0000)]
2009-08-22  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        Backing out http://trac.webkit.org/changeset/47671 in preparation of
        rolling out http://trac.webkit.org/changeset/47669.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-08-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 22 Aug 2009 15:13:03 +0000 (15:13 +0000)]
2009-08-22  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Anders Carlsson.

        Build fix, add CanvasRenderingContext to build systems.
        https://bugs.webkit.org/show_bug.cgi?id=28018

        * DerivedSources.make: Added CanvasRenderinContext.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago New files implementing GL buffer wrappers, and support to make them platform...
cmarrin@apple.com [Sat, 22 Aug 2009 13:11:26 +0000 (13:11 +0000)]
    New files implementing GL buffer wrappers, and support to make them platform independent
        https://bugs.webkit.org/show_bug.cgi?id=28018

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agostash CanvasRenderingContext2D
cmarrin@apple.com [Sat, 22 Aug 2009 12:56:36 +0000 (12:56 +0000)]
stash CanvasRenderingContext2D

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix storage leak from syntax tree arena allocation patch.
darin@apple.com [Sat, 22 Aug 2009 09:02:43 +0000 (09:02 +0000)]
Fix storage leak from syntax tree arena allocation patch.

Patch by Darin Adler <darin@apple.com> on 2009-08-22
* parser/Nodes.h: CommaNode needs to inherit from ParserArenaDeletable
because it has a vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build.
darin@apple.com [Sat, 22 Aug 2009 06:54:19 +0000 (06:54 +0000)]
Fix Qt build.

Patch by Darin Adler <darin@apple.com> on 2009-08-21
* parser/Nodes.cpp:
(JSC::ScopeNodeData::ScopeNodeData): Made non-inline again.
This is used outside Nodes.cpp so can't be inline unless
it is in the header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebCore.vcproj/build-generated-files.sh:
darin@apple.com [Sat, 22 Aug 2009 06:53:16 +0000 (06:53 +0000)]
* WebCore.vcproj/build-generated-files.sh:
* make-generated-sources.sh:
Removed obsolete code to set up CREATE_HASH_TABLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTwo loose ends from the last commit.
darin@apple.com [Sat, 22 Aug 2009 06:52:13 +0000 (06:52 +0000)]
Two loose ends from the last commit.

Patch by Darin Adler <darin@apple.com> on 2009-08-21
* JavaScriptCore.xcodeproj/project.pbxproj: Made ParserArena.h
and create_hash_table project-internal instead of "private".
* runtime/Executable.h: Removed accidentally-added constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSyntax tree nodes should use arena allocation
darin@apple.com [Sat, 22 Aug 2009 06:40:53 +0000 (06:40 +0000)]
Syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674

Patch by Darin Adler <darin@apple.com> on 2009-08-21
Reviewed by Gavin Barraclough.

Use an actual arena now. 0.6% speedup on SunSpider.

New and improved with 100% less leaking of the universe.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed all exports involving the class FunctionBodyNode, which no
longer needs to be used outside JavaScriptCore.

* JavaScriptCore.xcodeproj/project.pbxproj: Made Nodes.h and
Executable.h project-internal instead of "private".

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack
contains const Identifier* now.

* parser/Grammar.y: Made identifiers from the lexer be const
Identifier* and updated since VarStack contains const Identifier* now.

* parser/Lexer.cpp:
(JSC::Lexer::setCode): Pass in ParserArena, used for identifiers.
(JSC::Lexer::makeIdentifier): Changed return type to const Identifier*
and changed to call ParserArena.
(JSC::Lexer::clear): Removed the code to manage m_identifiers and
added code to set m_arena to 0.
* parser/Lexer.h: Updated for changes above.

* parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable
on the arena.
(JSC::ParserArenaDeletable::operator new): Changed to call the
allocateDeletable function on the arena instead of deleteWithArena.
(JSC::PropertyNode::PropertyNode): Added new constructor that makes
numeric identifiers. Some day we might want to optimize this for
integers so it doesn't create a string for each one.
(JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier
since it's now a const Identifier& so it can't be left uninitialized.
(JSC::BreakNode::BreakNode): Ditto.
(JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements*
to keep track of the statements rather than a separate statement vector.
(JSC::BlockNode::BlockNode): Ditto.
(JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.

* parser/Nodes.cpp: Moved the comment explaining emitBytecode in here.
It seemed strangely out of place in the header.
(JSC::ThrowableExpressionData::emitThrowError): Added an overload for
UString as well as Identifier.
(JSC::SourceElements::singleStatement): Added.
(JSC::SourceElements::lastStatement): Added.
(JSC::RegExpNode::emitBytecode): Changed the throwError code to use
the substitution mechanism instead of doing a string append.
(JSC::SourceElements::emitBytecode): Added. Replaces the old
statementListEmitCode function, since we now keep the SourceElements
objects around.
(JSC::BlockNode::lastStatement): Added.
(JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of
statementListEmitCode.
(JSC::CaseClauseNode::emitBytecode): Added.
(JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode
instead of statementListEmitCode.
(JSC::ScopeNodeData::ScopeNodeData): Changed to store the
SourceElements* instead of using releaseContentsIntoVector.
(JSC::ScopeNode::emitStatementsBytecode): Added.
(JSC::ScopeNode::singleStatement): Added.
(JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead
of statementListEmitCode.
(JSC::EvalNode::emitBytecode): Ditto.
(JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode
insetad of statementListEmitCode and check for the return node using
the new functions.

* parser/Nodes.h: Changed VarStack to store const Identifier* instead
of Identifier and rely on the arena to control lifetime. Added a new
ParserArenaFreeable class. Made ParserArenaDeletable inherit from
FastAllocBase instead of having its own operator new. Base the Node
class on ParserArenaFreeable. Changed the various Node classes
to use const Identifier& instead of Identifier to avoid the need to
call their destructors and allow them to function as "freeable" in the
arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions.
Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode,
CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable
as a base class since they do not descend from Node. Eliminated the
StatementVector type and instead have various classes use SourceElements*
instead of StatementVector. This prevents those classes from having to
use ParserArenaDeletable to make sure the vector destructor is called.

* parser/Parser.cpp:
(JSC::Parser::parse): Pass the arena to the lexer.

* parser/Parser.h: Added an include of ParserArena.h, which is no longer
included by Nodes.h.
(JSC::Parser::parseFunctionFromGlobalCode): Changed to use the
singleStatement function, since there is no longer any children function.
Removed some unneeded use of RefPtr.

* parser/ParserArena.cpp:
(JSC::ParserArena::ParserArena): Added. Initializes the new members,
m_freeableMemory, m_freeablePoolEnd, and m_identifiers.
(JSC::ParserArena::freeablePool): Added. Computes the pool pointer,
since we store only the current pointer and the end of pool pointer.
(JSC::ParserArena::deallocateObjects): Added. Contains the common
memory-deallocation logic used by both the destructor and the
reset function.
(JSC::ParserArena::~ParserArena): Changed to call deallocateObjects.
(JSC::ParserArena::reset): Ditto. Also added code to zero out the
new structures, and switched to use clear() instead of shrink(0) since
we don't really reuse arenas.
(JSC::ParserArena::makeNumericIdentifier): Added.
(JSC::ParserArena::allocateFreeablePool): Added. Used when the pool
is empty.
(JSC::ParserArena::isEmpty): Added. No longer inline, which is fine
since this is used only for assertions at the moment.
(JSC::ParserArena::derefWithArena): Make non-inline.

* parser/ParserArena.h: Added an actual arena of "freeable" objects,
ones that don't need destructors to be called. Also added a separate
IdentifierArena object, a segmented vector of identifiers that used
to be in the Lexer.

* runtime/Executable.h: Moved the definition of the
FunctionExecutable::make function here. It can't go in JSFunction.h
since that header has to be used outside JavaScriptCore and so can't
include this, which includes Nodes.h. The function could be moved
elswhere if we don't want to include JSFunction.h in this header, but
for now this seems to be the best place.

* runtime/JSFunction.h: Removed the include of Executable.h and
definition of the FunctionExecutable::make function.

* wtf/FastMalloc.cpp: Fixed an incorrect comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7162322> Custom style sheet ignored if UAC is enabled
adele@apple.com [Sat, 22 Aug 2009 05:24:10 +0000 (05:24 +0000)]
<rdar://problem/7162322> Custom style sheet ignored if UAC is enabled

Reviewed by Mark Rowe.

* platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
No need to open the file with write access.  Only read access is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47663 268f45cc-cd09-0410-ab3c-d52691b4dbfc