WebKit-https.git
5 years ago[iOS] Build fix
bfulgham@apple.com [Thu, 2 Jul 2015 00:05:40 +0000 (00:05 +0000)]
[iOS] Build fix

Patch by Eric Carlson <eric.carlson@apple.com> on 2015-07-01
Reviewed by Brent Fulgham.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVVideoLayer enterPIPModeRedirectingVideoToLayer:]): Renamed from enterOptimizedFullScreenModeRedirectingVideoToLayer.
(-[WebAVVideoLayer leavePIPMode]): Renamed from leaveOptimizedFullScreenMode.
(-[WebAVVideoLayer enterOptimizedFullScreenModeRedirectingVideoToLayer:]): Deleted.
(-[WebAVVideoLayer leaveOptimizedFullScreenMode]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Support bold and thin italicized system fonts
mmaxfield@apple.com [Thu, 2 Jul 2015 00:02:15 +0000 (00:02 +0000)]
[iOS] Support bold and thin italicized system fonts
https://bugs.webkit.org/show_bug.cgi?id=146463
<rdar://problem/20948885>

Reviewed by Darin Adler.

Source/WebCore:

Add the italicized attribute to font descriptors.

Test: fast/text/weighted-italicized-system-font.html

* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::createCTFontWithFamilyNameAndWeight):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::fontWithFamilySpecialCase):
(WebCore::fontWithFamily):
* platform/spi/cocoa/CoreTextSPI.h:

LayoutTests:

* fast/text/weighted-italicized-system-font-expected.html: Added.
* fast/text/weighted-italicized-system-font.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove code to recompute rounded window corners
andersca@apple.com [Thu, 2 Jul 2015 00:00:12 +0000 (00:00 +0000)]
Remove code to recompute rounded window corners
https://bugs.webkit.org/show_bug.cgi?id=146534

Reviewed by Simon Fraser.

This code is no longer needed since we're always layer-backed now.

* UIProcess/API/mac/WKView.mm:
(-[WKView displayIfNeeded]): Deleted.
(-[WKView _cacheWindowBottomCornerRect]): Deleted.
* UIProcess/API/mac/WKViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobmalloc: realloc of an XLarge range can unmap adjacent VM ranges
ggaren@apple.com [Wed, 1 Jul 2015 23:36:53 +0000 (23:36 +0000)]
bmalloc: realloc of an XLarge range can unmap adjacent VM ranges
https://bugs.webkit.org/show_bug.cgi?id=146535

Reviewed by Anders Carlsson.

This bug causes a crash when running fast/css/large-list-of-rules-crash.html
with the fix applied for https://bugs.webkit.org/show_bug.cgi?id=146519.

* bmalloc/Allocator.cpp:
(bmalloc::Allocator::reallocate): Start at object + newSize since starting
at object + oldSize means deleting the adjacent VM range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r185889
mmirman@apple.com [Wed, 1 Jul 2015 23:28:51 +0000 (23:28 +0000)]
Unreviewed, rolling out r185889
https://bugs.webkit.org/show_bug.cgi?id=146528
rdar://problem/21573959

Patch breaks chromeexperiments.com

Reverted changeset:

Source/JavaScriptCore:

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* inspector/InjectedScriptSource.js:
(.):
* runtime/JSBoundSlotBaseFunction.cpp: Removed.
* runtime/JSBoundSlotBaseFunction.h: Removed.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Deleted.
(JSC::JSGlobalObject::visitChildren): Deleted.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::boundSlotBaseFunctionStructure): Deleted.
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::getBoundSlotBaseFunctionForGetterSetter): Deleted.
* runtime/VM.cpp:
(JSC::VM::VM): Deleted.
* runtime/VM.h:

LayoutTests:

* inspector-protocol/runtime/getProperties-expected.txt:
* js/dom/native-bindings-descriptors-expected.txt: Removed.
* js/dom/native-bindings-descriptors.html: Removed.
* js/dom/script-tests/native-bindings-descriptors.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix ANGLE Windows build after r186169.
achristensen@apple.com [Wed, 1 Jul 2015 23:26:07 +0000 (23:26 +0000)]
Fix ANGLE Windows build after r186169.
https://bugs.webkit.org/show_bug.cgi?id=146532

Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

* ANGLE.vcxproj/libEGL.vcxproj:
* ANGLE.vcxproj/libEGL.vcxproj.filters:
* ANGLE.vcxproj/libGLESv2.vcxproj:
* ANGLE.vcxproj/libGLESv2.vcxproj.filters:
* ANGLE.vcxproj/libGLESv2Common.props:
* ANGLE.vcxproj/translator_common.vcxproj:
* ANGLE.vcxproj/translator_common.vcxproj.filters:
* ANGLE.vcxproj/translator_glsl.vcxproj:
* ANGLE.vcxproj/translator_glsl.vcxproj.filters:
* ANGLE.vcxproj/translator_hlsl.vcxproj:
* ANGLE.vcxproj/translator_hlsl.vcxproj.filters:
Update Windows build to build new files.

Source/WebCore:

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
Don't compile OpenGLShims.cpp or Extensions3DOpenGL.cpp on Windows
because Windows uses OpenGLES through ANGLE, not OpenGL.
* platform/graphics/ANGLEWebKitBridge.h:
Use OpenGLESShims.h on Windows instead of OpenGLShims.h.
* platform/graphics/OpenGLESShims.h:
Added needed definitions from OpenGL to compile successfully.
* platform/graphics/win/GL/glext.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb page doesn't update its loading state when web process becomes suspended if there...
commit-queue@webkit.org [Wed, 1 Jul 2015 23:17:58 +0000 (23:17 +0000)]
Web page doesn't update its loading state when web process becomes suspended if there are pending network requests (XHR).
https://bugs.webkit.org/show_bug.cgi?id=146439

When web page is loading, we hold a background activity token in NavigationState and we release the token when the page done
loading. A web page can start loading subresources (like XHR) after the page is loaded, and WebPageProxy will update its
_networkRequestsInProgress state which will notify the client there is network actvity on-going. Since we don't hold
the background activity token after page is loaded, the WebContent process could become suspended without notifying the client
and the client will lose track of the loading state.

The first thought was to hold another background activity when _networkRequestsInProgress flag is set in NavigationState.
However, this could result in side-effect that a WebContent process can stay active for too long if there is a long lasting
XHR resquest.

This patch fix this by notifying the client that network activity is stopped when WebContent process is going to be suspended.
We also cache the networkRequestsInProgress state for suspended process, so that when it becomes foreground, we can tell
the client the correct state of network activity.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-07-01
Reviewed by Dan Bernstein.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_hasNetworkRequestsOnSuspended.
(WebKit::WebPageProxy::processWillBecomeSuspended): If there is pending requests on suspend, cache the network activity state
    and notify the client.
(WebKit::WebPageProxy::processWillBecomeForground): Restore the network activity state when the process becomes foreground.
(WebKit::WebPageProxy::resetState):
* UIProcess/WebPageProxy.h: Add a data member m_hasNetworkRequestsOnSuspended to cache the network activity state on process
    suspend.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didSetAssertionState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTurn off mediastreamaudiosourcenode.html test
commit-queue@webkit.org [Wed, 1 Jul 2015 23:09:48 +0000 (23:09 +0000)]
Turn off mediastreamaudiosourcenode.html test
https://bugs.webkit.org/show_bug.cgi?id=146527
<rdar://problem/21641223>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Simon Fraser.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDisable the experimental WebGL2 implementation
dino@apple.com [Wed, 1 Jul 2015 22:38:37 +0000 (22:38 +0000)]
Disable the experimental WebGL2 implementation
https://bugs.webkit.org/show_bug.cgi?id=146526
<rdar://problem/21641235>

Reviewed by Myles Maxfield.

Source/JavaScriptCore:

Add (and disable) an ENABLE_WEBGL2 flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add (and disable) an ENABLE_WEBGL2 flag. Also protect
anything that is specific to WebGL2.

Covered by running the WebGL 1.0.2 conformance suite
and our LayoutTests.

* Configurations/FeatureDefines.xcconfig:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/js/JSWebGL2RenderingContextCustom.cpp:
* bindings/js/JSWebGLRenderingContextBaseCustom.cpp:
(WebCore::toJS):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::is3dType):
* html/canvas/WebGL2RenderingContext.cpp:
* html/canvas/WebGL2RenderingContext.h:
* html/canvas/WebGL2RenderingContext.idl:
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::drawBuffersIfNecessary):
* html/canvas/WebGLGetInfo.cpp:
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):
* html/canvas/WebGLVertexArrayObject.cpp:
* html/canvas/WebGLVertexArrayObject.h:
* html/canvas/WebGLVertexArrayObject.idl:

Source/WebKit/mac:

Add (and disable) an ENABLE_WEBGL2 flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add (and disable) an ENABLE_WEBGL2 flag.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Add (and disable) an ENABLE_WEBGL2 flag.

* wtf/FeatureDefines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix missing space.
simon.fraser@apple.com [Wed, 1 Jul 2015 22:22:58 +0000 (22:22 +0000)]
Fix missing space.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoNever try to pass URLs to LaunchServices when they're the same domain as the current...
beidson@apple.com [Wed, 1 Jul 2015 21:54:59 +0000 (21:54 +0000)]
Never try to pass URLs to LaunchServices when they're the same domain as the current URL.
<rdar://problem/20731429> and https://bugs.webkit.org/show_bug.cgi?id=146521

Reviewed by Alex Christensen.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryAppLink): Compare the proposed URL to the current URL to see if they’re in the same domain.
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRegression(183998): Disqus comments take a very long time to load
cdumez@apple.com [Wed, 1 Jul 2015 21:52:07 +0000 (21:52 +0000)]
Regression(183998): Disqus comments take a very long time to load
https://bugs.webkit.org/show_bug.cgi?id=146522
<rdar://problem/21590601>

Reviewed by Simon Fraser.

Source/WebCore:

Stop throttling requestAnimationFrame() in iframes that are not visible
due to them being zero-sized or display:none. Those are usually utility
iframes and throttling them is risky.

Se still throttle requestAnimationFrame() in iframes that would be
visible in theory but are currently not noticeable because they are
outside the viewport.

Test:
- fast/animation/request-animation-frame-throttle-subframe.html
- fast/animation/request-animation-frame-throttle-subframe-display-none.html
- fast/animation/request-animation-frame-throttle-subframe-zero-size.html

* page/FrameView.cpp:
(WebCore::FrameView::updateScriptedAnimationsAndTimersThrottlingState):

LayoutTests:

* fast/animation/request-animation-frame-throttle-subframe-display-none-expected.txt:
* fast/animation/request-animation-frame-throttle-subframe-display-none.html:
Update layout test as we changed behavior here. We no longer throttle display:none
iframes.

* fast/animation/request-animation-frame-throttle-subframe-zero-size-expected.txt: Added.
* fast/animation/request-animation-frame-throttle-subframe-zero-size.html: Added.
Add layout test to check that we don't throttle RaF in iframes that are zero-sized.

* fast/animation/resources/requestAnimationFrame-frame-2.html:
* fast/animation/resources/requestAnimationFrame-frame.html:
Update use of requestAnimationFrame() to be more representative of real world usage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKWebView snapshots have the wrong scale after rotation
timothy_horton@apple.com [Wed, 1 Jul 2015 21:34:58 +0000 (21:34 +0000)]
WKWebView snapshots have the wrong scale after rotation
https://bugs.webkit.org/show_bug.cgi?id=146476
<rdar://problem/18345247>

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
"Coordinate" -> "Coordinates".

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
Defer any snapshotting that happens during a resize until after
the resize completes. This will ensure that (in the case of an IOSurface
snapshot) the tiles are up to date, and (in the case of a software snapshot)
that our understanding of the scale and scroll offset of the WKContentView
are up to date, so that we can correctly convert from view to content coordinates
in the UI process.

(-[WKWebView _endAnimatedResize]):
Perform the deferred snapshotting after the resize completes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the iOS build.
simon.fraser@apple.com [Wed, 1 Jul 2015 21:21:45 +0000 (21:21 +0000)]
Fix the iOS build.

* WebCoreSupport/WebUserMediaClient.mm:
(-[WebUserMediaPolicyListener denyOnlyThisRequest]): Remove ASSERT_NOT_REACHED,
because it caused the compiler to warn about noreturn.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMark compositing/masks/compositing-clip-path-origin.html as being image-flakey.
simon.fraser@apple.com [Wed, 1 Jul 2015 20:53:39 +0000 (20:53 +0000)]
Mark compositing/masks/compositing-clip-path-origin.html as being image-flakey.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r179168): Characters overlap after resizing the font on the copy-pasted...
rniwa@webkit.org [Wed, 1 Jul 2015 20:31:25 +0000 (20:31 +0000)]
REGRESSION (r179168): Characters overlap after resizing the font on the copy-pasted Japanese text
https://bugs.webkit.org/show_bug.cgi?id=146492

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by WebKit serializing the used line-height size (e.g. 18px) in the copied content
instead of string "normal" and removeStyleFromRulesAndContext failing to strip it down when text with
a font that influences the line height got pasted. This is because the used value of line-height
property of the context and the pasted content doesn't match when the context doesn't use the same font.

Fixed the bug by not considering line-height as a list of editing properties we try to preserve. This is
fine because we don't provide editing operations to directly manipulate line-height.

Test: editing/pasteboard/cjk-line-height.html

* editing/EditingStyle.cpp:
(WebCore::editingProperties): Removed CSSPropertyLineHeight.

LayoutTests:

Added a regression test. Also reverted the bad rebaseline in r179168:
http://trac.webkit.org/changeset/179168/trunk/LayoutTests/editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt

* editing/pasteboard/cjk-line-height-expected.txt: Added.
* editing/pasteboard/cjk-line-height.html: Added.
* editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r184296): View keeps scrolling upward
bfulgham@apple.com [Wed, 1 Jul 2015 19:29:33 +0000 (19:29 +0000)]
REGRESSION (r184296): View keeps scrolling upward
https://bugs.webkit.org/show_bug.cgi?id=146497
<rdar://problem/21524942>

Reviewed by Darin Adler.

Avoid improperly triggering the ScrollController wheel event handling
logic when the wheel event deltaX/deltaY are zero. On certain sites,
this caused a programmatic JavaScript scroll to be triggered unexpectedly,
scrolling the page back to some initial state.

This bug was introduced while trying to make sure scrollbars were notified
when the wheel event had come to an end. Revise that change so that we still
follow the right code path for non-stretchable regions. However, make sure
that for zero-delta wheel events we make sure to properly handle the wheel
event phase.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::shouldForwardWheelEventsToParent): New helper function
to reduce the complexity of the logic in handleWheelEvent.
(WebCore::ScrollAnimatorMac::handleWheelEvent): When wheel events should be forwarded
to the parent scroll view, if the event was handled or has no change in position
trigger the 'handleWheelEventPhase' logic so that scrollbars are hidden, etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThis is a quick follow-on to http://trac.webkit.org/changeset/186132
bdakin@apple.com [Wed, 1 Jul 2015 19:11:47 +0000 (19:11 +0000)]
This is a quick follow-on to trac.webkit.org/changeset/186132

Rubber-stamped by Darin Adler.

Make this a one-liner.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoHide the inline controls when going into PiP
dino@apple.com [Wed, 1 Jul 2015 19:08:22 +0000 (19:08 +0000)]
Hide the inline controls when going into PiP
https://bugs.webkit.org/show_bug.cgi?id=146487
<rdar://problem/19881159>

Reviewed by Eric Carlson.

When the presentation mode is PiP, toggle a class
on the container element so that we can completely
hide the control toolbar. The placard should still
remain visible.

* Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-controls-panel-container.picture-in-picture): Add
a rule that hides the toolbar when PiP is active.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.handlePresentationModeChange): Toggle a
class. Also fix a bug I noticed where exiting from PiP was
not auto-hiding the controls until the user tapped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/JavaScriptCore:
commit-queue@webkit.org [Wed, 1 Jul 2015 18:44:27 +0000 (18:44 +0000)]
Source/JavaScriptCore:
Enable MEDIA_STREAM flag
https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

* Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag

Source/WebCore:
Enable MEDIA_STREAM flag
https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

* Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag
* Modules/mediastream/MediaStreamTrack.h:
* WebCore.xcodeproj/project.pbxproj: Changed project headers to
private headers
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/mac/AVAudioCaptureSource.mm:
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::refreshCaptureDeviceList): Deleted.
* platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::startProducingData):
(WebCore::AVMediaCaptureSource::stopProducingData):

Source/WebKit/mac:
Enable MEDIA_STREAM flag
https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

* Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag
* WebCoreSupport/WebUserMediaClient.h: Changed signatures
* WebCoreSupport/WebUserMediaClient.mm: Changed signatures
(WebUserMediaClient::requestPermission):
(WebUserMediaClient::cancelRequest):
(-[WebUserMediaPolicyListener denyOnlyThisRequest]):
(-[WebUserMediaPolicyListener shouldClearCache]):

Source/WebKit2:
Enable MEDIA_STREAM flag
https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

* Configurations/FeatureDefines.xcconfig: Add MEDIA_STREAM flag
* WebKit2.xcodeproj/project.pbxproj: Changed some project to private
declarations of headers
* WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userMediaPermissionRequestManager):

Tools:
Enabled MEDIA_STREAM flag
https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

* TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

LayoutTests:
Enable MEDIA_STREAM flag
https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

*
platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
Added attributes to tests
*
platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
Ditto
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r185016): Intermittent crash in WebCore::TextTrackList::remove
bfulgham@apple.com [Wed, 1 Jul 2015 17:35:56 +0000 (17:35 +0000)]
REGRESSION (r185016): Intermittent crash in WebCore::TextTrackList::remove
https://bugs.webkit.org/show_bug.cgi?id=146493
<rdar://problem/21511122>

Reviewed by Eric Carlson.

The m_textTracks member is frequently null checked during other operations, but
was not checked during track removal. This needs to be corrected.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removeTextTrack): Check that m_textTracks is
not null before using it during track removal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPNG mask images are loaded with Accept:image/svg+xml
antti@apple.com [Wed, 1 Jul 2015 17:22:27 +0000 (17:22 +0000)]
PNG mask images are loaded with Accept:image/svg+xml
https://bugs.webkit.org/show_bug.cgi?id=146509
Source/WebCore:

rdar://problem/21584740

Reviewed by Simon Fraser.

For some strange reason MaskImageOperation code loads all mask images, including non-SVG ones
using CachedSVGDocument. Resulting bad accept header may cause server to reject the request.

This is far from ideal but as a quick fix we can override the accept header for mask images to
allow any image type.

Test: http/tests/misc/mask-image-accept.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::acceptOverride):
(WebCore::CachedResourceRequest::setAcceptOverride):
* loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::load):
* loader/cache/CachedSVGDocumentReference.h:
(WebCore::CachedSVGDocumentReference::loadRequested):
(WebCore::CachedSVGDocumentReference::setAcceptsAnyImageType):
(WebCore::CachedSVGDocumentReference::document):
* platform/graphics/MaskImageOperation.cpp:
(WebCore::MaskImageOperation::ensureCachedSVGDocumentReference):

LayoutTests:

Reviewed by Simon Fraser.

* http/tests/misc/mask-image-accept-expected.html: Added.
* http/tests/misc/mask-image-accept.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (185319): Reproducible crash in WebHistoryItem launching FluidApp.
beidson@apple.com [Wed, 1 Jul 2015 17:13:04 +0000 (17:13 +0000)]
REGRESSION (185319): Reproducible crash in WebHistoryItem launching FluidApp.
<rdar://problem/21598293> and https://bugs.webkit.org/show_bug.cgi?id=146494

Reviewed by Darin Adler.

* History/WebHistoryItem.mm:
(-[WebHistoryItem initFromDictionaryRepresentation:]): Don’t reference members of a Vector
  that don’t exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCheck shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL...
beidson@apple.com [Wed, 1 Jul 2015 16:53:20 +0000 (16:53 +0000)]
Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices.
<rdar://problem/20577859> and https://bugs.webkit.org/show_bug.cgi?id=146513

Reviewed by Darin Adler.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryAppLink): The expected value of isProcessingUserGesture is lost over redirects.
  shouldOpenExternalURLs actually fits this role perfectly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[MSE] Failures on W3C media-source tests regarding MIME types
jer.noble@apple.com [Wed, 1 Jul 2015 15:54:41 +0000 (15:54 +0000)]
[MSE] Failures on W3C media-source tests regarding MIME types
https://bugs.webkit.org/show_bug.cgi?id=146499

Reviewed by Eric Carlson.

Source/WebCore:

Tests: http/tests/media/media-source/SourceBuffer-abort-readyState.html
       http/tests/media/media-source/SourceBuffer-abort-removed.html
       http/tests/media/media-source/SourceBuffer-abort-updating.html
       http/tests/media/media-source/SourceBuffer-abort.html

Multiple failures in the W3C media-source test suite due to two failures in isTypeSupported MIME type handling:
- MIME types without codec strings were being rejected.
- MIME types with codec strings which are rejected by the system are being reported as supported.

For the first, stop rejecting MIME types with non-existent codec strings. For MIME types which do have non-empty
codec strings, treat a "Maybe" response as unsupported.

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported):

LayoutTests:

Import four new tests from the w3c test suite <https://github.com/w3c/web-platform-tests.git>.

* http/tests/media/media-source/SourceBuffer-abort-readyState.html: Added.
* http/tests/media/media-source/SourceBuffer-abort-removed.html: Added.
* http/tests/media/media-source/SourceBuffer-abort-updating.html: Added.
* http/tests/media/media-source/SourceBuffer-abort.html: Added.
* http/tests/media/white.mp4: Added.
* http/tests/media/white.webm: Added.
* platform/mac/TestExpectations:
* platform/mac/http/tests/media/media-source/SourceBuffer-abort-expected.txt: Added.
* platform/mac/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt: Added.
* platform/mac/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt: Added.
* platform/mac/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt: Added.
* platform/mac/http/tests/media/media-source/mediasource-is-type-supported-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] [Wayland] Build broken with ENABLE_WAYLAND_TARGET=ON
mcatanzaro@igalia.com [Wed, 1 Jul 2015 15:44:39 +0000 (15:44 +0000)]
[GTK] [Wayland] Build broken with ENABLE_WAYLAND_TARGET=ON
https://bugs.webkit.org/show_bug.cgi?id=146512

Unreviewed, fix build with ENABLE_WAYLAND_TARGET=ON after r185949.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since...
mrobinson@webkit.org [Wed, 1 Jul 2015 14:51:28 +0000 (14:51 +0000)]
[GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
https://bugs.webkit.org/show_bug.cgi?id=144828

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Instead of setting spell checking languages unconditionally when building int
developer mode, add some C API that allows setting them in WebKitTestRunner.

* PlatformGTK.cmake: Add the new C API file to the source list.
* UIProcess/API/C/gtk/WKTextCheckerGtk.cpp:
(WKTextCheckerSetSpellCheckingLanguages): Added this function which allows settings
the spell checking languages from the C API.
* UIProcess/API/C/gtk/WKTextCheckerGtk.h: Added.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::enchantTextChecker): Remove the hack which sets the spell checking languages automatically
for development builds.

Tools:

* WebKitTestRunner/gtk/main.cpp:
(main): Use the new WKTextChecker API to set the spell checking languages
when the process is starting up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Numerous CGColor leaks in swipe gestures
commit-queue@webkit.org [Wed, 1 Jul 2015 08:55:02 +0000 (08:55 +0000)]
[Mac] Numerous CGColor leaks in swipe gestures
https://bugs.webkit.org/show_bug.cgi?id=146501

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-01
Reviewed by Tim Horton.

* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::beginSwipeGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
commit-queue@webkit.org [Wed, 1 Jul 2015 08:51:40 +0000 (08:51 +0000)]
[Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=146503

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-01
Reviewed by Tim Horton.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Simplify adoption into a new RetainPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed build fix after r186169.
achristensen@apple.com [Wed, 1 Jul 2015 06:26:23 +0000 (06:26 +0000)]
[Win] Unreviewed build fix after r186169.

Source/WebKit:

* WebKit.vcxproj/WebKit.sln:
Temporarily don't build ANGLE projects on Windows.

Source/WTF:

* wtf/FeatureDefines.h:
Temporarily disable WebGL on WinCairo. It was already temporarily disabled on AppleWin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVersioning.
bshafiei@apple.com [Wed, 1 Jul 2015 06:23:51 +0000 (06:23 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate ANGLE to b11e2483742db884bd0af41f78f528240577356b.
achristensen@apple.com [Wed, 1 Jul 2015 06:17:20 +0000 (06:17 +0000)]
Update ANGLE to b11e2483742db884bd0af41f78f528240577356b.
https://bugs.webkit.org/show_bug.cgi?id=145010

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

Huge list of source changes omitted.
ROLL DEPS!

Source/WebCore:

* CMakeLists.txt:
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::appendSymbol):
(WebCore::getStructInfo):
(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::getValidationResultValue): Deleted.
* platform/graphics/ANGLEWebKitBridge.h:
(WebCore::ANGLEShaderSymbol::isSampler):
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo):
* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::checkVaryingsPacking):
(WebCore::GraphicsContext3D::precisionsMatch):
Update WebCore to reflect changes in ANGLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Unreviewed gardening.
gyuyoung.kim@webkit.org [Wed, 1 Jul 2015 06:08:23 +0000 (06:08 +0000)]
[EFL] Unreviewed gardening.

Some tests are flaky or timeout after bumping Ubuntu version from 14.04 to 15.04.
Mark the tests to flaky or timeout.

* platform/efl/TestExpectations:
* platform/efl/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, skip this test for now. We can unskip it when this feature is enabled.
fpizlo@apple.com [Wed, 1 Jul 2015 05:59:51 +0000 (05:59 +0000)]
Unreviewed, skip this test for now. We can unskip it when this feature is enabled.

* js/script-tests/intl.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFrame flattening: Hit-testing an iframe could end up destroying the associated inline...
zalan@apple.com [Wed, 1 Jul 2015 04:30:52 +0000 (04:30 +0000)]
Frame flattening: Hit-testing an iframe could end up destroying the associated inline tree context.
https://bugs.webkit.org/show_bug.cgi?id=146447
rdar://problem/20613501

Reviewed by Simon Fraser.

This patch ensures that the render tree associated with the document on which
the hit-test is initiated does not get laid out, unless it was directly mutated prior to the hittest.

Hit-test requirements:
1. A clean the render tree before hit-testing gets propagated to the renderers.
Document::updateLayout() ensures it by calling both updateStyleIfNeeded() and layout() not only on the current tree, but also
on the ancestors if needed.

2. No render tree mutation while hit-testing the renderers.

When an iframe is being hit-tested, this hit-test could bubble down to the child frame's render view.
In order to ensure #1, we call Document::updateLayout() on the current (subframe) document.
If updateStyleIfNeeded() mutates the render tree, we mark it dirty for layout(). However frame flattening also
marks the parent renderer (RenderIFrame) dirty.
While calling layout() to clean the current render tree, we end up laying out the parent tree too.
Laying out the parent tree could end up destroying the inline tree context from where the
hittest just bubbled down. (InlineFlowBox -> RenderWidget -> RenderView).

This patch protects the render tree from such unintentional inline tree mutation during hittesting.
After the initial layout we set a layout disallow flag on the frame view to defer subsequent layouts.
This patch only changes behavior when frame flattening is enabled, but in future we may always want to enable this.

Source/WebCore:

Test: fast/frames/flattening/hittest-iframe-while-style-changes-crash.html

* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded): Deleted. -> Assertion in no longer valid.
* page/FrameView.h:
* rendering/RenderView.cpp:
(WebCore::FrameFlatteningLayoutDisallower::FrameFlatteningLayoutDisallower):
(WebCore::FrameFlatteningLayoutDisallower::~FrameFlatteningLayoutDisallower):
(WebCore::RenderView::hitTest): Protect the render tree from subsequent layouts.

LayoutTests:

* fast/frames/flattening/hittest-iframe-while-style-changes-crash-expected.txt: Added.
* fast/frames/flattening/hittest-iframe-while-style-changes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix CoordinatedGraphics.
simon.fraser@apple.com [Wed, 1 Jul 2015 02:39:50 +0000 (02:39 +0000)]
Fix CoordinatedGraphics.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: add " = $0" hint after selected element in main DOMTreeOutline
commit-queue@webkit.org [Wed, 1 Jul 2015 02:07:37 +0000 (02:07 +0000)]
Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline
https://bugs.webkit.org/show_bug.cgi?id=145739

Patch by Devin Rousso <drousso@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

* UserInterface/Views/DOMTreeOutline.css: Adds a semi-opaque " = $0" to the selected element in the DOM tree.
(.dom-tree-outline li.selected > span::after):
(.dom-tree-outline:focus li.selected > span::after):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMore Gtk/EFL fixing.
simon.fraser@apple.com [Wed, 1 Jul 2015 02:03:23 +0000 (02:03 +0000)]
More Gtk/EFL fixing.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement ECMAScript Internationalization API
commit-queue@webkit.org [Wed, 1 Jul 2015 02:01:59 +0000 (02:01 +0000)]
Implement ECMAScript Internationalization API
https://bugs.webkit.org/show_bug.cgi?id=90906

Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2015-06-30
Reviewed by Benjamin Poulain.

.:

Begin implementing the Intl apis behind ENABLE_INTL flag.
Create the base Intl namespace object.

* Source/cmake/WebKitFeatures.cmake: add ENABLE_INTL flag

Source/JavaScriptCore:

* CMakeLists.txt: add IntlObject.cpp
* Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: add IntlObject
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: add IntlObject
* JavaScriptCore.xcodeproj/project.pbxproj: add IntlObject
* runtime/CommonIdentifiers.h: add "Intl" name
* runtime/IntlObject.cpp: Added.
(JSC::IntlObject::IntlObject):
(JSC::IntlObject::create):
(JSC::IntlObject::finishCreation):
(JSC::IntlObject::createStructure):
* runtime/IntlObject.h: Added.
* runtime/JSGlobalObject.cpp: Add global Intl
(JSC::JSGlobalObject::init):

Source/WebCore:

Test: js/intl.html

* Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag

Source/WTF:

* wtf/FeatureDefines.h: add ENABLE_INTL flag

Tools:

* Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.props: add ENABLE_INTL flag
* win/tools/vsprops/FeatureDefinesCairo.props: add ENABLE_INTL flag

LayoutTests:

* TestExpectations: Skip intl until enabled
* js/intl-expected.txt: Added.
* js/intl.html: Added.
* js/script-tests/intl.js: Added.
(global):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoscroll-snap-points do not work very well with mechanical scroll wheel events
commit-queue@webkit.org [Wed, 1 Jul 2015 01:51:16 +0000 (01:51 +0000)]
scroll-snap-points do not work very well with mechanical scroll wheel events
https://bugs.webkit.org/show_bug.cgi?id=142501
<rdar://problem/20093511>

Patch by Wenson Hsieh <whsieh@berkeley.edu> on 2015-06-30
Reviewed by Brent Fulgham.

Source/WebCore:

Stateless scroll events generated by scrolling with a mechanical mouse wheel now trigger scroll
snapping after a fixed delay.

Test: platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html

* platform/cocoa/ScrollController.h: Added member to track stateless scrolling.
* platform/cocoa/ScrollController.mm: Added constant for delay for stateless scroll snapping.
(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Triggers timer upon stateless scroll events.
(WebCore::ScrollController::horizontalScrollSnapTimerFired): Timer now handles stateless scrolling updates.
(WebCore::ScrollController::verticalScrollSnapTimerFired): See above.
(WebCore::ScrollController::beginScrollSnapAnimation): Handles stateless scroll snapping.

LayoutTests:

* platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix Mac and Windows builds.
simon.fraser@apple.com [Wed, 1 Jul 2015 01:46:52 +0000 (01:46 +0000)]
Fix Mac and Windows builds.

Source/WebKit/win:

* WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::flushPendingLayerChanges):
* WebView.cpp:
(WebView::flushPendingGraphicsLayerChanges):

Source/WebKit2:

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix Gtk and EFL builds.
simon.fraser@apple.com [Wed, 1 Jul 2015 01:15:53 +0000 (01:15 +0000)]
Try to fix Gtk and EFL builds.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Missing tiles inside position:fixed on scrolling
simon.fraser@apple.com [Wed, 1 Jul 2015 01:08:41 +0000 (01:08 +0000)]
[iOS] Missing tiles inside position:fixed on scrolling
https://bugs.webkit.org/show_bug.cgi?id=146485
rdar://problem/21226861

Reviewed by Tim Horton.

Layer flushing adjusts the coverage rect for tiled layers, but does so at times
when position:fixed layers are moved around by the scrolling tree. The computed
coverage rect then doesn't reflect the layer's on-screen position, causing missing
tiles.

Fix by pushing the notion of being in a "stable state" onto FrameView, and passing
that state into the layer flush. When not in a stable state, flushing doesn't change
the visible and coverage rects for layers that are viewport-constrained.

Source/WebCore:

* page/FrameView.cpp:
(WebCore::FrameView::reset):
* page/FrameView.h: Remove some velocity-related data members that were unused.
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::flushCompositingState):
(WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects): If this is a viewport-constrained
layer, and the viewport is not stable, don't touch the rects.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::CommitState::CommitState):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit2:

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRename GraphicsLayer's allowsBackingStoreDetachment to isViewportConstrained
simon.fraser@apple.com [Wed, 1 Jul 2015 01:01:13 +0000 (01:01 +0000)]
Rename GraphicsLayer's allowsBackingStoreDetachment to isViewportConstrained
https://bugs.webkit.org/show_bug.cgi?id=146483

Reviewed by Tim Horton.

What GraphicsLayer really needs to know is whether some other thread/process
is moving its platform layers around behind its back, and this is is better
expressed as "isViewportConstrained" rather than "allowsBackingStoreDetachment".

The sense of the flag is flipped, and boolean logic adjusted accordingly.

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setIsViewportConstrained):
(WebCore::GraphicsLayer::isViewportConstrained):
(WebCore::GraphicsLayer::setAllowsBackingStoreDetachment): Deleted.
(WebCore::GraphicsLayer::allowsBackingStoreDetachment): Deleted.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
* platform/graphics/ca/GraphicsLayerCA.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setIsScrollCoordinatedWithViewportConstrainedRole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Implement ewk_favicon_database_clear() API.
commit-queue@webkit.org [Wed, 1 Jul 2015 00:46:55 +0000 (00:46 +0000)]
[EFL] Implement ewk_favicon_database_clear() API.
https://bugs.webkit.org/show_bug.cgi?id=146337

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-30
Reviewed by Gyuyoung Kim.

We need to provide way to clear favicon data.

* UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::clearFaviconDatabase):
(EwkFaviconDatabase::iconDataReadyForPageURL):
(ewk_favicon_database_icon_change_callback_del):
(ewk_favicon_database_clear):
* UIProcess/API/efl/ewk_favicon_database.h:
* UIProcess/API/efl/ewk_favicon_database_private.h:
* UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Ignore viewport rect changes during zoom bouncing.
akling@apple.com [Wed, 1 Jul 2015 00:39:22 +0000 (00:39 +0000)]
[iOS] Ignore viewport rect changes during zoom bouncing.
<https://webkit.org/b/146480>

Reviewed by Benjamin Poulain.

When the user has pinch-zoomed past the maximum zoom scale and lets go of the screen,
we animate a bounce back to the maximum scale.

Suppress viewport rect updates during this bounce animation since we don't need them
anyway. This fixes an issue where we'd sometimes get a weird rect during the animation
and if could send that to the web process, causing it to generate tiles for a part of
the page that's not actually exposed.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateVisibleContentRects]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoErrors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS.
commit-queue@webkit.org [Wed, 1 Jul 2015 00:36:18 +0000 (00:36 +0000)]
Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS.
https://bugs.webkit.org/show_bug.cgi?id=146473

Patch by Keith Miller <keith_miller@apple.com> on 2015-06-30
Reviewed by Filip Pizlo.

We were not checking if errors occurred in WTF::cryptographicallyRandomValuesFromOS.
We now buffer the data until enough bits of entropy exist to fill the buffer
rather than crash. Additionally, added two crash functions so we can distinguish
between the two reasons why we crashed in traces.

* wtf/OSRandomSource.cpp:
(WTF::crashUnableToOpenFD):
(WTF::crashUnableToReadFromFD):
(WTF::cryptographicallyRandomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rebaseline editing/style/unbold-in-bold.html on WK2.
cdumez@apple.com [Wed, 1 Jul 2015 00:17:49 +0000 (00:17 +0000)]
Unreviewed, rebaseline editing/style/unbold-in-bold.html on WK2.

* platform/mac-wk2/editing/style/unbold-in-bold-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, revert bad wk2 baseline done in r186106.
cdumez@apple.com [Wed, 1 Jul 2015 00:16:38 +0000 (00:16 +0000)]
Unreviewed, revert bad wk2 baseline done in r186106.

* platform/mac-wk2/editing/style: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<rdar://problem/20655729> WebKit should heuristically exclude scrolling touch events...
enrica@apple.com [Wed, 1 Jul 2015 00:08:12 +0000 (00:08 +0000)]
<rdar://problem/20655729> WebKit should heuristically exclude scrolling touch events from the user gesture category

Reviewed by Benjamin Poulain.

* Platform/spi/ios/UIKitSPI.h:
* Shared/WebEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
(WebKit::WebTouchEvent::position):
(WebKit::WebTouchEvent::isPotentialTap):
(WebKit::WebTouchEvent::isGesture):
(WebKit::WebTouchEvent::gestureScale):
(WebKit::WebTouchEvent::gestureRotation):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
* Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
* Shared/ios/WebTouchEventIOS.cpp:
(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
Pipe isPotentialTap through.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate the JetStream documentation to reflect the recent changes
fpizlo@apple.com [Tue, 30 Jun 2015 22:58:13 +0000 (22:58 +0000)]
Update the JetStream documentation to reflect the recent changes
https://bugs.webkit.org/show_bug.cgi?id=146474

Reviewed by Geoffrey Garen.

* JetStream/create.rb: Bump the version.
* JetStream/in-depth-TEMPLATE.html: Add cdjs documentation. Remove cordic documentation. Change documentation for splay and mandreel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: ProfileNode cleanup
commit-queue@webkit.org [Tue, 30 Jun 2015 22:58:05 +0000 (22:58 +0000)]
Web Inspector: ProfileNode cleanup
https://bugs.webkit.org/show_bug.cgi?id=146472

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

* UserInterface/Models/ProfileNode.js:
(WebInspector.ProfileNode):
Use Array.prototype.every instead of reduce.
Correct the name of a function to be what callers expect!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] [EFL] Unreviewed build fix after r186118.
clopez@igalia.com [Tue, 30 Jun 2015 22:51:16 +0000 (22:51 +0000)]
[GTK] [EFL] Unreviewed build fix after r186118.

Add if PLATFORM(COCOA) back.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCABackdropFilter should set windowServerAware to false
dino@apple.com [Tue, 30 Jun 2015 22:21:39 +0000 (22:21 +0000)]
CABackdropFilter should set windowServerAware to false
https://bugs.webkit.org/show_bug.cgi?id=146469
<rdar://problem/21618614>

Reviewed by Simon Fraser.

* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::PlatformCALayerCocoa): Set windowServerAware
to false on Mac (it's not available on iOS).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: iOS 8: Profile Nodes not showing in JavaScript Timeline
commit-queue@webkit.org [Tue, 30 Jun 2015 22:20:15 +0000 (22:20 +0000)]
Web Inspector: iOS 8: Profile Nodes not showing in JavaScript Timeline
https://bugs.webkit.org/show_bug.cgi?id=146471

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Brian Burg.

* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeCallFromPayload):
For legacy backends, convert the startTime to the proper timestamp type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRolling out r175171
cdumez@apple.com [Tue, 30 Jun 2015 22:19:26 +0000 (22:19 +0000)]
Rolling out r175171
https://bugs.webkit.org/show_bug.cgi?id=146470
<rdar://problem/21349934>

Unreviewed, rolling out <http://trac.webkit.org/changeset/175171>. It
wasn't a huge win and Brady says it caused crash at
<rdar://problem/21349934>.

* platform/network/cf/ResourceRequest.h:
* platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAllow object allocation sinking through GetScope, GetExecutable and SkipScope nodes
basile_clement@apple.com [Tue, 30 Jun 2015 22:19:05 +0000 (22:19 +0000)]
Allow object allocation sinking through GetScope, GetExecutable and SkipScope nodes
https://bugs.webkit.org/show_bug.cgi?id=146431

Reviewed by Filip Pizlo.

* dfg/DFGNode.h:
(JSC::DFG::Node::isFunctionAllocation):
(JSC::DFG::Node::isPhantomFunctionAllocation):
* dfg/DFGObjectAllocationSinkingPhase.cpp:
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
* dfg/DFGPromoteHeapAccess.h:
(JSC::DFG::promoteHeapAccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, revert bad WK1 rebaseline done in r186106.
cdumez@apple.com [Tue, 30 Jun 2015 22:16:21 +0000 (22:16 +0000)]
Unreviewed, revert bad WK1 rebaseline done in r186106.

* platform/mac/editing/style/unbold-in-bold-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrash under _layoutForNodeHighlight: when inspecting espn.com
simon.fraser@apple.com [Tue, 30 Jun 2015 22:00:36 +0000 (22:00 +0000)]
Crash under _layoutForNodeHighlight: when inspecting espn.com
https://bugs.webkit.org/show_bug.cgi?id=146422

Reviewed by Joseph Pecoraro.
Source/WebKit/mac:

When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.

Fix by bailing in this case.

* WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):

Source/WebKit2:

When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.

Fix by bailing in this case.

* UIProcess/WKInspectorHighlightView.mm:
(-[WKInspectorHighlightView _layoutForNodeHighlight:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Reduce rendering frames "Other" time by instrumenting compositing
mattbaker@apple.com [Tue, 30 Jun 2015 21:45:55 +0000 (21:45 +0000)]
Web Inspector: Reduce rendering frames "Other" time by instrumenting compositing
https://bugs.webkit.org/show_bug.cgi?id=146168

Reviewed by Brian Burg.

Source/JavaScriptCore:

* inspector/protocol/Timeline.json:
New timeline record type for compositing events.

Source/WebCore:

Added Inspector instrumentation for measuring CoreAnimation compositing time. We mark the start of a composite
event when the LayerFlushScheduler triggers a scheduled layer flush. InspectorController now exports a function
for marking the end of the composite event, which should be called during the CA transaction post-commit phase
(based on platform support). Lacking platform support, the event is considered complete after CoreAnimation
runloop observers have run.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::didComposite):
* inspector/InspectorController.h:
New export for instrumentation in WebKit2.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCompositeImpl):
(WebCore::InspectorInstrumentation::didCompositeImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willComposite):
(WebCore::InspectorInstrumentation::didComposite):
Plumbing for new instrumentation.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::didComposite):
(WebCore::toProtocol):
* inspector/InspectorTimelineAgent.h:
New Composite event type and instrumentation.

* page/FrameView.cpp:
(WebCore::FrameView::flushCompositingStateIncludingSubframes):
Hook for start of compositing.

* platform/spi/cocoa/QuartzCoreSPI.h:
New header include and interface declaration.

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):
Added handling for new Composite record type. Paint records with a parent Composite record
are flagged to simplify processing after the event hierarchy is unpacked.

* UserInterface/Images/TimelineRecordComposite.svg: Added.
New composite record icon.

* UserInterface/Models/LayoutTimelineRecord.js:
(WebInspector.LayoutTimelineRecord):
(WebInspector.LayoutTimelineRecord.displayNameForEventType):
(WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Added
Composite record support.

* UserInterface/Models/RenderingFrameTimelineRecord.js:
(WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
Add compositing time when bucketing runloop tasks, ignoring Paint events that are
contained within a Composite event.

* UserInterface/Views/LayoutTimelineOverviewGraph.js:
(WebInspector.LayoutTimelineOverviewGraph.prototype._layoutTimelineRecordAdded):
Add Composite records to paint timeline row.

* UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
Small unrelated fix.

* UserInterface/Views/TimelineIcons.css:
(.composite-record .icon):
* UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar.timeline-record-type-layout.layout-timeline-record-composite > .segment):
* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
New styles and tree element icon.

Source/WebKit2:

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Added CA transaction post-commit handlers to instrument end of composite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThe bounds on InteractionInformationAtPosition should be more precise
bdakin@apple.com [Tue, 30 Jun 2015 21:40:01 +0000 (21:40 +0000)]
The bounds on InteractionInformationAtPosition should be more precise
https://bugs.webkit.org/show_bug.cgi?id=146468
-and corresponding-
rdar://problem/20739834

Reviewed by Enrica Casucci and Simon Fraser.

Source/WebCore:

Export absoluteContentQuad().
* rendering/RenderBox.h:

Source/WebKit2:

For links, get the TextQuads from the Range, and for images, look at the
absoluteContentQuad(). All other items can continue to use absoluteBoundingBox.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdded myself, Jonathan Davis, as a committer.
jond@apple.com [Tue, 30 Jun 2015 21:37:57 +0000 (21:37 +0000)]
Added myself, Jonathan Davis, as a committer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdded WebKit feature status page to navigation.
jond@apple.com [Tue, 30 Jun 2015 21:01:01 +0000 (21:01 +0000)]
Added WebKit feature status page to navigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAddressing post-review comments in r185756.
zalan@apple.com [Tue, 30 Jun 2015 20:31:10 +0000 (20:31 +0000)]
Addressing post-review comments in r185756.

* html/RubyTextElement.cpp:
(WebCore::RubyTextElement::createElementRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAddressing post-review comments in r185916
zalan@apple.com [Tue, 30 Jun 2015 20:03:28 +0000 (20:03 +0000)]
Addressing post-review comments in r185916

* platform/LayoutUnit.h:
(WebCore::roundToDevicePixel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMediaSession: Use setSessionInternal to set the default media session in HTMLMediaEle...
mrajca@apple.com [Tue, 30 Jun 2015 19:53:18 +0000 (19:53 +0000)]
MediaSession: Use setSessionInternal to set the default media session in HTMLMediaElement's constructor
https://bugs.webkit.org/show_bug.cgi?id=146465

Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDisable Spintracer when getting the list of plug-ins
andersca@apple.com [Tue, 30 Jun 2015 19:48:35 +0000 (19:48 +0000)]
Disable Spintracer when getting the list of plug-ins
https://bugs.webkit.org/show_bug.cgi?id=146467
rdar://problem/21616640

Reviewed by Tim Horton.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJava Plugin cannot launch JavaUpdater.app after renaming
andersca@apple.com [Tue, 30 Jun 2015 19:12:45 +0000 (19:12 +0000)]
Java Plugin cannot launch JavaUpdater.app after renaming
https://bugs.webkit.org/show_bug.cgi?id=146464
rdar://problem/19747153

Reviewed by Tim Horton.

Check for both "JavaUpdater.app" and "Java Updater.app".

* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isJavaUpdaterURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS ifdefs now that this is always true
andersca@apple.com [Tue, 30 Jun 2015 18:26:01 +0000 (18:26 +0000)]
Remove the WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS ifdefs now that this is always true
https://bugs.webkit.org/show_bug.cgi?id=146462

Reviewed by Dan Bernstein.

* Misc/WebDownload.h:
* WebView/WebFrameLoadDelegate.h:
* WebView/WebPolicyDelegate.h:
* WebView/WebResourceLoadDelegate.h:
* WebView/WebUIDelegate.h:
* WebView/WebView.h:
* postprocess-headers.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMedia Session: implement algorithm for updating a media element's session (6.1)
mrajca@apple.com [Tue, 30 Jun 2015 18:10:55 +0000 (18:10 +0000)]
Media Session: implement algorithm for updating a media element's session (6.1)
https://bugs.webkit.org/show_bug.cgi?id=146460

Reviewed by Darin Adler.

In addition to storing a pointer to the new media session, we now:

- pause the media element if it is 'active' in the current media session
- remove the media element from the current media session
- release the current media session if there are no more active media elements
- set the default media session if the new media session is null
- update the 'kind' attribute to match the kind of the new media session

* Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::isMediaElementActive):
(WebCore::MediaSession::hasActiveMediaElements):
* Modules/mediasession/MediaSession.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSession):
(WebCore::HTMLMediaElement::setSessionInternal):
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Avoid taking a useless / blank navigation snapshot when navigating after restor...
cdumez@apple.com [Tue, 30 Jun 2015 18:08:19 +0000 (18:08 +0000)]
[WK2] Avoid taking a useless / blank navigation snapshot when navigating after restoring sessionState
https://bugs.webkit.org/show_bug.cgi?id=146446
<rdar://problem/21584231>

Reviewed by Darin Adler.

We currently take a useless / blank navigation snapshot when navigating
after restoring the back / forward list from a sessionState object.
This is because we get a current HistoryItem from the sessionState
which we have never really navigated to. We then take a navigation
snapshot for the current HistoryItem when navigating away as we usually
do. However, in this case, the HistoryItem was imported and there is
nothing to snapshot.

Taking this snapshot is not only wasteful, it can also potentially
overwrite the snapshot that was set by the client using
WKWebView._saveBackForwardSnapshotForItem() SPI.

To address the problem, this patch suppresses navigation snapshotting
after restoring the back / forward list from a session state and until
the next load is committed.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::recordNavigationSnapshot):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::didCommitLoadForFrame):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] webViewAddMessageToConsole always gets 1 for isError
bfulgham@apple.com [Tue, 30 Jun 2015 17:32:28 +0000 (17:32 +0000)]
[Win] webViewAddMessageToConsole always gets 1 for isError
https://bugs.webkit.org/show_bug.cgi?id=146457
<rdar://problem/21606395>

Reviewed by Zalan Bujtas.

* WebCoreSupport/WebChromeClient.cpp:
(messageIsError): Added.
(WebChromeClient::addMessageToConsole): Only pass true for
isError if the message is an error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: iOS 8: Uncaught Exception expanding Object Prototype
commit-queue@webkit.org [Tue, 30 Jun 2015 17:20:20 +0000 (17:20 +0000)]
Web Inspector: iOS 8: Uncaught Exception expanding Object Prototype
https://bugs.webkit.org/show_bug.cgi?id=146427

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

* UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WebInspector.ObjectTreePropertyTreeElement.prototype._updateProperties):
* UserInterface/Views/ObjectTreeView.js:
(WebInspector.ObjectTreeView.prototype._updateProperties):
We are supposed to receive value properties for __proto__ properties
so that we can immediately start showing information about the property.
When that is not the case, which appeared to only be on legacy
backends for the top level prototype, just ignore it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Misc. Timeline cleanup
commit-queue@webkit.org [Tue, 30 Jun 2015 17:16:05 +0000 (17:16 +0000)]
Web Inspector: Misc. Timeline cleanup
https://bugs.webkit.org/show_bug.cgi?id=146430

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-30
Reviewed by Timothy Hatcher.

* UserInterface/Models/Timeline.js:
(WebInspector.Timeline.prototype.reset):
Nobody listens for this event. Just remove it.

* UserInterface/Models/TimelineRecording.js:
Avoiding doing multiple lookups.

* UserInterface/Views/TimelineDataGridNode.js:
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
* UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.updateLayout):
Eliminate some unnecessary deletes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of unused WKSI functions
andersca@apple.com [Tue, 30 Jun 2015 17:12:00 +0000 (17:12 +0000)]
Get rid of unused WKSI functions
https://bugs.webkit.org/show_bug.cgi?id=146443

Reviewed by Tim Horton.

Source/WebCore:

* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect):
Just call CGPathAddRoundedRect directly.

* platform/ios/WebCoreSystemInterfaceIOS.mm:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.

Source/WebKit2:

* UIProcess/API/Cocoa/WKWebView.mm:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):
* WebProcess/WebProcess.h:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::destroyRenderingResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix.
bfulgham@apple.com [Tue, 30 Jun 2015 16:39:48 +0000 (16:39 +0000)]
Unreviewed build fix.

* Scripts/update-webkit-dependency: Try to build even if we cannot connect
to developer.apple.com to get update libraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Compile error, WebEditorClient::didApplyStyle() should not have any parame...
peavo@outlook.com [Tue, 30 Jun 2015 11:26:04 +0000 (11:26 +0000)]
[WinCairo] Compile error, WebEditorClient::didApplyStyle() should not have any parameters.
https://bugs.webkit.org/show_bug.cgi?id=146450

Reviewed by Csaba Osztrogonác.

* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::shouldApplyStyle):
(WebEditorClient::didApplyStyle):
* WebCoreSupport/WebEditorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Streams API] Finish pulling must always be done asynchronously as it is the expected...
calvaris@igalia.com [Tue, 30 Jun 2015 09:53:40 +0000 (09:53 +0000)]
[Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec)
https://bugs.webkit.org/show_bug.cgi?id=146408

Reviewed by Darin Adler.

Source/WebCore:

Current tests cover the case already.

* Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::pull): Call finishPull() in a postTask to delay it and simulate the promise
resolution.

LayoutTests:

* streams/reference-implementation/readable-stream-expected.txt: Updated expectation to PASS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Streams API] Synced bad strategy test with reference implementation
calvaris@igalia.com [Tue, 30 Jun 2015 09:27:49 +0000 (09:27 +0000)]
[Streams API] Synced bad strategy test with reference implementation
https://bugs.webkit.org/show_bug.cgi?id=146411

Reviewed by Darin Adler.

Source/WebCore:

Current tests cover the case.

* bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::retrieveChunkSize): Check for negative size then running the JavaScript function.

LayoutTests:

* streams/reference-implementation/bad-strategies-expected.txt:
* streams/reference-implementation/bad-strategies.html: There are three tests that are merged into one and a
fourth check is added. Updated expectations accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Streams API] Remove ReadableStream.getReader() custom binding
youenn.fablet@crf.canon.fr [Tue, 30 Jun 2015 07:50:12 +0000 (07:50 +0000)]
[Streams API] Remove ReadableStream.getReader() custom binding
https://bugs.webkit.org/show_bug.cgi?id=146404

Reviewed by Darin Adler.

Covered by existing tests.

* Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::getReader): Updated to take an exception.
* Modules/streams/ReadableStream.h:
* Modules/streams/ReadableStream.idl: Updated to remove custom binding.
* bindings/js/JSReadableStreamCustom.cpp:
(WebCore::JSReadableStream::getReader): Deleted.
* bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::constructJSReadableStreamReader): Updated to pass an exception to getReader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMake] Error when gst-plugins-base is missing is too confusing
philn@webkit.org [Tue, 30 Jun 2015 07:17:52 +0000 (07:17 +0000)]
[CMake] Error when gst-plugins-base is missing is too confusing
https://bugs.webkit.org/show_bug.cgi?id=145682

Reviewed by Carlos Garcia Campos.

* Source/cmake/OptionsGTK.cmake: Error out if the required
GStreamer libraries are not found on the host.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Streams API] ReadableStreamReader.closed should use DOMPromise
youenn.fablet@crf.canon.fr [Tue, 30 Jun 2015 06:47:19 +0000 (06:47 +0000)]
[Streams API] ReadableStreamReader.closed should use DOMPromise
https://bugs.webkit.org/show_bug.cgi?id=146406

Reviewed by Darin Adler.

Added storage of ClosedPromise as Optional of ReadableStream.
Updated code accordingly.

Covered by existing tests.

* Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::clearCallbacks):
(WebCore::ReadableStream::releaseReader):
(WebCore::ReadableStream::changeStateToErrored):
(WebCore::ReadableStream::closed):
* Modules/streams/ReadableStream.h:
* Modules/streams/ReadableStreamReader.cpp:
(WebCore::ReadableStreamReader::closed):
* Modules/streams/ReadableStreamReader.h:
* bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::JSReadableStreamReader::closed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Unreviewed GTK build fix since r186088 and r186095.
gyuyoung.kim@webkit.org [Tue, 30 Jun 2015 06:02:24 +0000 (06:02 +0000)]
[GTK] Unreviewed GTK build fix since r186088 and r186095.
https://bugs.webkit.org/show_bug.cgi?id=146449

* PlatformGTK.cmake:
* UIProcess/API/gtk/PageClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WK2] WKWebViews in Facebook app start off black
simon.fraser@apple.com [Tue, 30 Jun 2015 05:33:11 +0000 (05:33 +0000)]
[iOS WK2] WKWebViews in Facebook app start off black
https://bugs.webkit.org/show_bug.cgi?id=146445
rdar://problem/21600433

Reviewed by Tim Horton.

If -isOpaque is toggled on a WKWebView, we failed to make the page tiles non-opaque
for a while. After r183775, RenderLayerCompositor::rootBackgroundTransparencyChanged() was called,
but only considered the computed document background color, and not the view transparency.

Fix by having rootBackgroundTransparencyChanged() simply use viewHasTransparentBackground(),
which checks the FrameView transparency. Now we just need to store a transparency bool rather
than the old color (we only checked its alpha anyway).

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother rebaseline after r186086.
rniwa@webkit.org [Tue, 30 Jun 2015 02:38:36 +0000 (02:38 +0000)]
Another rebaseline after r186086.
WebKit2 needs the original expected result.

* platform/mac-wk2/editing/style: Copied from LayoutTests/platform/mac/editing/style/unbold-in-bold-expected.txt.
* platform/mac/editing/style/unbold-in-bold-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRebaseline after r186086.
rniwa@webkit.org [Tue, 30 Jun 2015 02:05:44 +0000 (02:05 +0000)]
Rebaseline after r186086.

* platform/mac/editing/style/unbold-in-bold-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebKit should use 80% black background for PiP indicator
dino@apple.com [Tue, 30 Jun 2015 01:26:21 +0000 (01:26 +0000)]
WebKit should use 80% black background for PiP indicator
https://bugs.webkit.org/show_bug.cgi?id=146444
<rdar://problem/21555726>

Reviewed by Sam Weinig.

Change the black background to a slightly less black background.
This also involved making the placard artwork white, in order
to keep it visible against the new grey.

* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-wireless-playback-status):
(audio::-webkit-media-controls-wireless-playback-status.small):
(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed EFL build fix since r186088 and r186095.
gyuyoung.kim@webkit.org [Tue, 30 Jun 2015 01:09:12 +0000 (01:09 +0000)]
Unreviewed EFL build fix since r186088 and r186095.

* CMakeLists.txt: Remove ConnectionStack.cpp.
* UIProcess/CoordinatedGraphics/WebView.h: Override virtual didFailLoadForMainFrame().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Unable to select the text of an inline error message
nvasilyev@apple.com [Tue, 30 Jun 2015 00:47:29 +0000 (00:47 +0000)]
Web Inspector: Unable to select the text of an inline error message
https://bugs.webkit.org/show_bug.cgi?id=145813

Reviewed by Timothy Hatcher.

* UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror-linewidget):
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.createWidgetForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Remove harmless error for not getting named flows
commit-queue@webkit.org [Tue, 30 Jun 2015 00:40:33 +0000 (00:40 +0000)]
Web Inspector: Remove harmless error for not getting named flows
https://bugs.webkit.org/show_bug.cgi?id=146417

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-29
Reviewed by Darin Adler.

* UserInterface/Controllers/DOMTreeManager.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Network errors (404) are missing location link in console messages
commit-queue@webkit.org [Tue, 30 Jun 2015 00:37:10 +0000 (00:37 +0000)]
Web Inspector: Network errors (404) are missing location link in console messages
https://bugs.webkit.org/show_bug.cgi?id=146442

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-29
Reviewed by Darin Adler.

* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
Restore behavior of adding a location link for network messages with urls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFlag sync XHRs from the network process so they can be handled appropriately.
beidson@apple.com [Tue, 30 Jun 2015 00:32:20 +0000 (00:32 +0000)]
Flag sync XHRs from the network process so they can be handled appropriately.
<rdar://problem/21579162> and https://bugs.webkit.org/show_bug.cgi?id=146441

Reviewed by Darin Adler.

Source/WebCore:

* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::loadingSynchronousXHR): Added so clients of asynchronous
  loads can signal they should be treated like synchronous loads at the platform level.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start): Adjust SchedulingBehavior based on the client.

* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start): Adjust SchedulingBehavior based on the client.

Source/WebKit2:

* NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::loadingSynchronousXHR): Return isSynchronous().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: iOS 8: Resources Timeline Data does not show up
commit-queue@webkit.org [Tue, 30 Jun 2015 00:27:29 +0000 (00:27 +0000)]
Web Inspector: iOS 8: Resources Timeline Data does not show up
https://bugs.webkit.org/show_bug.cgi?id=146433

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-06-29
Reviewed by Timothy Hatcher.

There were a couple issues with initializing the legacy base timestamp
for attempting to dynamically compute monotonically increasing timestamps
for timeline events for legacy backends.

    * Sometimes legacy timestamps were in seconds since epochs,
      sometimes milliseconds. The frontend did not handle both.

    * On navigations, even while resetting the base timestamp for
      the first new record received, the main resource still had
      a will send request time computed from the previous page's
      time system. This patch re-uses the original timestamp for
      this main resource as the new base and all future records
      are computed relative to this.

* UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
* UserInterface/Models/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.get originalRequestWillBeSentTimestamp):
For legacy timestamp calculations, save the original request will be sent
timestamp on the Resource in case it is needed.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._loadNewRecording):
When auto-starting a new recording for a navigation / reload, use the
main resource's request will be sent timestamp as the new base.

* UserInterface/Models/TimelineRecording.js:
Address legacy timeline timestamps by handling both legacy timestamps
that may be seconds / milliseconds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions
cfleizach@apple.com [Tue, 30 Jun 2015 00:24:05 +0000 (00:24 +0000)]
AX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=146419

Reviewed by Simon Fraser.

Make sure ObjC exception resulting from calling into the platform cause problems in WebKit.

* platform/ios/PlatformSpeechSynthesizerIOS.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(-[WebSpeechSynthesisWrapper pause]):
(-[WebSpeechSynthesisWrapper resume]):
(-[WebSpeechSynthesisWrapper cancel]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didStartSpeechUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove an empty group from the Xcode project.
andersca@apple.com [Tue, 30 Jun 2015 00:15:56 +0000 (00:15 +0000)]
Remove an empty group from the Xcode project.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of ConnectionStack
andersca@apple.com [Mon, 29 Jun 2015 23:46:27 +0000 (23:46 +0000)]
Get rid of ConnectionStack
https://bugs.webkit.org/show_bug.cgi?id=146437

Reviewed by Andreas Kling.

Just use a TemporaryChange and a static variable instead.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::setGlobalException):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
* Shared/ConnectionStack.cpp: Removed.
(WebKit::ConnectionStack::singleton): Deleted.
* Shared/ConnectionStack.h: Removed.
(WebKit::ConnectionStack::current): Deleted.
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher): Deleted.
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher): Deleted.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoving an element from a media session should also remove it from the sets of activ...
mrajca@apple.com [Mon, 29 Jun 2015 23:14:45 +0000 (23:14 +0000)]
Removing an element from a media session should also remove it from the sets of active participating elements
https://bugs.webkit.org/show_bug.cgi?id=146420

Reviewed by Eric Carlson.

* Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::removeMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Activate SSE support for 32-bit builds.
commit-queue@webkit.org [Mon, 29 Jun 2015 23:08:20 +0000 (23:08 +0000)]
[Win] Activate SSE support for 32-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=144923

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-29
Reviewed by Brent Fulgham.

* win/tools/vsprops/common.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build.
timothy_horton@apple.com [Mon, 29 Jun 2015 23:01:30 +0000 (23:01 +0000)]
Fix the build.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didFailLoadForMainFrame]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didFailLoadForMainFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTemporarily disable PICTURE_SIZES
dino@apple.com [Mon, 29 Jun 2015 22:59:51 +0000 (22:59 +0000)]
Temporarily disable PICTURE_SIZES
https://bugs.webkit.org/show_bug.cgi?id=146435
<rdar://problem/21087013>

Source/JavaScriptCore:

Reviewed by Tim Horton.

Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Tim Horton.

Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Reviewed by Tim Horton.

Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.

Temporarily disable PICTURE_SIZES until Safari branches.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Tim Horton.

Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.

* wtf/FeatureDefines.h:

LayoutTests:

Reviewed by Tim Horton.

Skip HTMLImageElement.sizes tests.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186091 268f45cc-cd09-0410-ab3c-d52691b4dbfc