WebKit-https.git
5 years agoUnreviewed, rolling out r176566.
commit-queue@webkit.org [Mon, 1 Dec 2014 14:48:34 +0000 (14:48 +0000)]
Unreviewed, rolling out r176566.
https://bugs.webkit.org/show_bug.cgi?id=139124

It broke the GTK performance tests. (Requested by clopez on
#webkit).

Reverted changeset:

"[GTK] Use GMainLoopSource in WebKitTestRunner"
https://bugs.webkit.org/show_bug.cgi?id=138831
http://trac.webkit.org/changeset/176566

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Add eldbus to the library list
ljaehun.lim@samsung.com [Mon, 1 Dec 2014 07:36:45 +0000 (07:36 +0000)]
[EFL] Add eldbus to the library list
https://bugs.webkit.org/show_bug.cgi?id=139120

Reviewed by Gyuyoung Kim.

Fix undefined reference errors for eldbus APIs.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Drop support for the EFL 1.7
ryuan.choi@navercorp.com [Mon, 1 Dec 2014 03:48:30 +0000 (03:48 +0000)]
[EFL] Drop support for the EFL 1.7
https://bugs.webkit.org/show_bug.cgi?id=139114

Reviewed by Gyuyoung Kim.

.:

* Source/cmake/EFLHelpers.cmake: Removed.
* Source/cmake/FindEcore.cmake: Removed.
* Source/cmake/FindEdje.cmake: Removed.
* Source/cmake/FindEet.cmake: Removed.
* Source/cmake/FindEeze.cmake: Removed.
* Source/cmake/FindEfreet.cmake: Removed.
* Source/cmake/FindEina.cmake: Removed.
* Source/cmake/FindElementary.cmake: Removed.
* Source/cmake/FindEvas.cmake: Removed.
* Source/cmake/OptionsEfl.cmake:

Source/WTF:

* wtf/efl/EflTypedefs.h: Removed old definitions which EFL 1.7 used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix a test failure.
andersca@apple.com [Mon, 1 Dec 2014 00:20:34 +0000 (00:20 +0000)]
Fix a test failure.

* History/WebHistory.mm:
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
Call through to the visited link store.

(+[WebHistory _removeAllVisitedLinks]):
Ditto.

* WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::isLinkVisited):
Make sure to populate visited links.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSwitch over to the visited link store from the WebViewGroup
andersca@apple.com [Sun, 30 Nov 2014 22:48:30 +0000 (22:48 +0000)]
Switch over to the visited link store from the WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139112

Reviewed by Sam Weinig.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView setGroupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd WebVisitedLinkStore::removeVisitedLink and use it on iOS
andersca@apple.com [Sun, 30 Nov 2014 22:45:19 +0000 (22:45 +0000)]
Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
https://bugs.webkit.org/show_bug.cgi?id=139111

Reviewed by Sam Weinig.

* WebCoreSupport/WebVisitedLinkStore.h:
* WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::removeVisitedLink):
* WebView/WebView.mm:
(-[WebView removeVisitedLink:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix a build warning when CSS_SCROLL_SNAP is enabled
gyuyoung.kim@samsung.com [Sun, 30 Nov 2014 02:36:26 +0000 (02:36 +0000)]
Fix a build warning when CSS_SCROLL_SNAP is enabled
https://bugs.webkit.org/show_bug.cgi?id=139084

Reviewed by Andrei Bucur.

Fix a build warning. Copy constructor of StyleScrollSnapPoints should initialize its base class.

* rendering/style/StyleScrollSnapPoints.cpp:
(WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints): Call RefCounted().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '...
commit-queue@webkit.org [Sun, 30 Nov 2014 00:39:14 +0000 (00:39 +0000)]
Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139104

Patch by Sam Weinig <sam@webkit.org> on 2014-11-29
Reviewed by Anders Carlsson.

* css/CSSPropertyNames.in:
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::applyValueWebkitLocale):
(WebCore::StyleBuilderFunctions::applyValueWebkitWritingMode):
(WebCore::StyleBuilderFunctions::applyValueWebkitTextOrientation):
(WebCore::StyleBuilderFunctions::applyValueWebkitJustifySelf):
(WebCore::StyleBuilderFunctions::applyValueWebkitPerspective):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPropertyTable keys should be AtomicStringImpl.
akling@apple.com [Sun, 30 Nov 2014 00:06:58 +0000 (00:06 +0000)]
PropertyTable keys should be AtomicStringImpl.
<https://webkit.org/b/139096>

Reviewed by Sam Weinig.

Since PropertyTable keys are really always Identifiers, switch the key
type from StringImpl* to AtomicStringImpl*.

We have code in the GetByVal opcode implementations that assumes things
about this, so this change adds confidence to those algorithms.

* bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
* bytecode/ComplexGetStatus.h:
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
* bytecode/GetByIdStatus.h:
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
* bytecode/PutByIdStatus.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):
* dfg/DFGDesiredIdentifiers.h:
(JSC::DFG::DesiredIdentifiers::operator[]):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
* runtime/Identifier.h:
(JSC::Identifier::impl):
* runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::mayInterceptStoreTo):
* runtime/IntendedStructureChain.h:
* runtime/PropertyMapHashTable.h:
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):
* runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
* runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSwitch over to using WebVisitedLinkStore on Windows
andersca@apple.com [Sat, 29 Nov 2014 23:40:30 +0000 (23:40 +0000)]
Switch over to using WebVisitedLinkStore on Windows
https://bugs.webkit.org/show_bug.cgi?id=139103

Reviewed by Antti Koivisto.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
* WebHistory.cpp:
(WebHistory::setOptionalSharedHistory):
(WebHistory::removeAllItems):
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
(WebHistory::removeItemForURLString):
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::addVisitedLinksToPageGroup): Deleted.
* WebHistory.h:
* WebView.cpp:
(WebView::initWithFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother build fix.
andersca@apple.com [Sat, 29 Nov 2014 22:52:58 +0000 (22:52 +0000)]
Another build fix.

* WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother build fix.
andersca@apple.com [Sat, 29 Nov 2014 22:48:41 +0000 (22:48 +0000)]
Another build fix.

* WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::removeAllVisitedLinks): Deleted.
(WebHistory::setHistoryItemLimit): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix build.
andersca@apple.com [Sat, 29 Nov 2014 22:43:41 +0000 (22:43 +0000)]
Try to fix build.

* WebHistory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStub out more of WebVisitedLinkStore on Windows
andersca@apple.com [Sat, 29 Nov 2014 22:23:36 +0000 (22:23 +0000)]
Stub out more of WebVisitedLinkStore on Windows
https://bugs.webkit.org/show_bug.cgi?id=139098

Reviewed by Sam Weinig.

* WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::WebVisitedLinkStore):
Initialize m_visitedLinksPopulated to false.

(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and remove all visited links if needed.

(WebVisitedLinkStore::removeAllVisitedLinks):
Remove all hashes from our shared link store.

(WebVisitedLinkStore::addVisitedLink):
Compute the visited link hash and add it to the store.

(WebVisitedLinkStore::isLinkVisited):
Populate visited links and then look up the hash in our hash map.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Call out to the history delegate or populate visited links from shared history.

(WebVisitedLinkStore::addVisitedLinkHash):
Add the hash if we're tracking hashes.

(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear the map.

* WebCoreSupport/WebVisitedLinkStore.h:
Add members.

* WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
New function that adds visited links from the history to a given store.

* WebHistory.h:
Add new member.

* WebView.cpp:
(WebView::addVisitedLinks):
Add links to the visited link store as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd an EmptyVisitedLinkStore implementation
andersca@apple.com [Sat, 29 Nov 2014 22:17:07 +0000 (22:17 +0000)]
Add an EmptyVisitedLinkStore implementation
https://bugs.webkit.org/show_bug.cgi?id=139102

Reviewed by Sam Weinig.

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
* loader/EmptyClients.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPopulate visited links
andersca@apple.com [Sat, 29 Nov 2014 22:11:08 +0000 (22:11 +0000)]
Populate visited links
https://bugs.webkit.org/show_bug.cgi?id=139101

Reviewed by Sam Weinig.

* History/WebHistory.mm:
(-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
Helper function that adds all visited link to the given store.

(-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
Call the private method.

* History/WebHistoryInternal.h:
* WebCoreSupport/WebVisitedLinkStore.h:
Add new members.

* WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::addVisitedLink):
Get the characters from the URL string and hash them, then call addVisitedLinkHash.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Implement this. First try the delegate, then try the shared history.

(WebVisitedLinkStore::addVisitedLinkHash):
Factor code that adds the link to the hash table into a separate function.

* WebView/WebView.mm:
(-[WebView addVisitedLinks:]):
Add the visited links to the store.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMore work on the legacy WebKit visited link store
andersca@apple.com [Sat, 29 Nov 2014 21:49:40 +0000 (21:49 +0000)]
More work on the legacy WebKit visited link store
https://bugs.webkit.org/show_bug.cgi?id=139100

Reviewed by Sam Weinig.

* History/WebHistory.mm:
(+[WebHistory setOptionalSharedHistory:]):
Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.

* WebCoreSupport/WebVisitedLinkStore.h:
* WebCoreSupport/WebVisitedLinkStore.mm:
(visitedLinkStores):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
Keep track of live visited link stores.

(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.

(WebVisitedLinkStore::removeAllVisitedLinks):
Iterate over all live link stores and remove their links.

(WebVisitedLinkStore::isLinkVisited):
Populate visited links and check if our hash table contains the link.

(WebVisitedLinkStore::addVisitedLink):
Add the link hash to the table.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Add stub.

(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear out the hash table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrash when calling WKPageClose on the originated page from within createNewPage callback
andersca@apple.com [Sat, 29 Nov 2014 21:12:55 +0000 (21:12 +0000)]
Crash when calling WKPageClose on the originated page from within createNewPage callback
https://bugs.webkit.org/show_bug.cgi?id=139099
<rdar://problem/19052564>

Reviewed by Sam Weinig.

Source/WebKit2:

Null check the namespace ID.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):

Tools:

Add a test.

* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::createNewPage):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a stubbed out WebVisitedLinkStore class on Windows
andersca@apple.com [Sat, 29 Nov 2014 17:47:35 +0000 (17:47 +0000)]
Add a stubbed out WebVisitedLinkStore class on Windows
https://bugs.webkit.org/show_bug.cgi?id=139078

Reviewed by Sam Weinig.

Source/WebKit:

* WebKit.vcxproj/WebKit/WebKit.vcxproj:

Source/WebKit/win:

* WebCoreSupport/WebVisitedLinkStore.cpp: Added.
(WebVisitedLinkStore::shared):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):
* WebCoreSupport/WebVisitedLinkStore.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse std::unique_ptr<>|make_unique<> in ftl, bytecode of JSC
gyuyoung.kim@samsung.com [Sat, 29 Nov 2014 07:11:50 +0000 (07:11 +0000)]
Use std::unique_ptr<>|make_unique<> in ftl, bytecode of JSC
https://bugs.webkit.org/show_bug.cgi?id=139063

Reviewed by Andreas Kling.

Clean up OwnPtr and PassOwnPtr in JSC.

* bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::push):
* bytecode/StructureStubClearingWatchpoint.h:
(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):
* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLJITFinalizer.h:
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* parser/SourceProviderCacheItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the '-webkit-initial-letter', '-webkit-line-box-contain' and '-webkit-text-strok...
commit-queue@webkit.org [Sat, 29 Nov 2014 06:20:25 +0000 (06:20 +0000)]
Move the '-webkit-initial-letter', '-webkit-line-box-contain' and '-webkit-text-stroke-width' CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139053

Patch by Sam Weinig <sam@webkit.org> on 2014-11-28
Reviewed by Andreas Kling.

* css/CSSPropertyNames.in:
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertInitialLetter):
(WebCore::StyleBuilderConverter::convertTextStrokeWidth):
(WebCore::StyleBuilderConverter::convertLineBoxContain):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStale userData is handed to WKView _actionMenuItemsForHitTestResult under prepareForMenu
timothy_horton@apple.com [Fri, 28 Nov 2014 22:10:24 +0000 (22:10 +0000)]
Stale userData is handed to WKView _actionMenuItemsForHitTestResult under prepareForMenu
https://bugs.webkit.org/show_bug.cgi?id=139069
<rdar://problem/19075587>

Reviewed by Sam Weinig.

* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController wkView:willHandleMouseDown:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _clearActionMenuState]):
Previously, _userData was not being cleared in didCloseMenu, so a subsequent
action menu invocation would end up sending stale userData to _actionMenuItemsForHitTestResult.

Additionally, factor all of the cleanup code out into _clearActionMenuState,
and call it from both wkView:willHandleMouseDown: and didCloseMenu:withEvent:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDataDetectors PageOverlay callbacks are never called
timothy_horton@apple.com [Fri, 28 Nov 2014 22:09:01 +0000 (22:09 +0000)]
DataDetectors PageOverlay callbacks are never called
https://bugs.webkit.org/show_bug.cgi?id=139067
<rdar://problem/19086676>

Reviewed by Anders Carlsson.

* Shared/mac/ActionMenuHitTestResult.mm:
(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Encode/decode the PageOverlay ID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAllow clients of the WKRenderLayerRef C SPI to connect layer trees across frame bound...
simon.fraser@apple.com [Fri, 28 Nov 2014 18:39:13 +0000 (18:39 +0000)]
Allow clients of the WKRenderLayerRef C SPI to connect layer trees across frame boundaries
https://bugs.webkit.org/show_bug.cgi?id=139021

Reviewed by Dan Bernstein.

Add WKRenderLayerGetFrameContentsLayer which returns a WKRenderLayerRef for
the content document of a RenderWidget, if its has one (e.g. frames, iframes
and <object> with document contents).

* Shared/API/c/WKRenderLayer.cpp:
(WKRenderLayerGetFrameContentsLayer):
* Shared/API/c/WKRenderLayer.h:
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):
* Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::frameContentsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r176564.
commit-queue@webkit.org [Fri, 28 Nov 2014 17:05:45 +0000 (17:05 +0000)]
Unreviewed, rolling out r176564.
https://bugs.webkit.org/show_bug.cgi?id=139093

massive failures on release test bot (Requested by philn on
#webkit).

Reverted changeset:

"[GStreamer] Bump internal jhbuild versions to 1.4.4"
https://bugs.webkit.org/show_bug.cgi?id=138866
http://trac.webkit.org/changeset/176564

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use GMainLoopSource in WebKitTestRunner
carlosgc@webkit.org [Fri, 28 Nov 2014 16:39:36 +0000 (16:39 +0000)]
[GTK] Use GMainLoopSource in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=138831

Reviewed by Sergio Villar Senin.

* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMake] Build failure against GStreamer git master
philn@webkit.org [Fri, 28 Nov 2014 15:27:47 +0000 (15:27 +0000)]
[CMake] Build failure against GStreamer git master
https://bugs.webkit.org/show_bug.cgi?id=138872

Reviewed by Csaba Osztrogon.

* Source/cmake/FindGStreamer.cmake: Simplified the
FIND_GSTREAMER_COMPONENT macro. Trust pkg-config for include
headers lookup, there's no need to do this manually. Also
explicitely check the version specified in GStreamer_FIND_VERSION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Bump internal jhbuild versions to 1.4.4
philn@webkit.org [Fri, 28 Nov 2014 14:42:50 +0000 (14:42 +0000)]
[GStreamer] Bump internal jhbuild versions to 1.4.4
https://bugs.webkit.org/show_bug.cgi?id=138866

Reviewed by Carlos Garcia Campos.

* gtk/jhbuild.modules:
* gtk/patches/gst-events-arent-gstobjects.patch: Removed.
* gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
* gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
carlosgc@webkit.org [Fri, 28 Nov 2014 14:29:26 +0000 (14:29 +0000)]
[GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
https://bugs.webkit.org/show_bug.cgi?id=138834

Reviewed by Sergio Villar Senin.

It makes everyting simpler and the tests run faster too, since we
don't need to spawn the private bus and wait until the DBus name
is registered. The web extension registers a new JavaSCript class
with a status method to run the tests, similar to the DBus
method. In the UI process side, tests use webkit_web_view_run_java_script()
instead of sending a DBus message.

* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
(WebKitDOMNodeFilterTest::create):
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
(WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
(WebKitDOMNodeFilterTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::create):
(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::webPageFromArgs): Deleted.
(WebKitDOMNodeTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
(WebKitDOMXPathNSResolverTest::create):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
(WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
(WebKitDOMXPathNSResolverTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
(WebKitFrameTest::create):
(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):
(WebKitFrameTest::webPageFromArgs): Deleted.
(WebKitFrameTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(testWebKitDOMNodeTagNames):
(beforeAll):
(afterAll):
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
(runTest):
(beforeAll):
(afterAll):
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
(webkitFrameTestRun):
(beforeAll):
(afterAll):
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
(testsMap):
(WebProcessTest::add):
(WebProcessTest::create):
(runTest):
(windowObjectClearedCallback):
(webkit_web_extension_initialize):
(methodCallCallback): Deleted.
(webkit_web_extension_initialize_with_user_data): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
* TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
* TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
* TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::runWebProcessTest):
* TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuil...
ossy@webkit.org [Fri, 28 Nov 2014 13:41:46 +0000 (13:41 +0000)]
[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=139086

Reviewed by Gyuyoung Kim.

* efl/jhbuild.modules:
* efl/patches/libseccomp-pick-up-CC.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] HTTP source element lacks SCHEDULING query support
philn@webkit.org [Fri, 28 Nov 2014 11:05:11 +0000 (11:05 +0000)]
[GStreamer] HTTP source element lacks SCHEDULING query support
https://bugs.webkit.org/show_bug.cgi?id=139064

Reviewed by Carlos Garcia Campos.

No new tests, covered by http/tests/media/hls.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQueryWithParent): Make the element handle SCHEDULING
queries with the BANDWIDTH_LIMITED flag. This helps uridecodebin
to configure itself for adaptive streaming playback scenarios.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Add warning if CMake version is too old for building with ninja.
commit-queue@webkit.org [Fri, 28 Nov 2014 09:50:18 +0000 (09:50 +0000)]
[EFL] Add warning if CMake version is too old for building with ninja.
https://bugs.webkit.org/show_bug.cgi?id=139055

Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-11-28
Reviewed by Gyuyoung Kim.

CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
that version in their repositories.

* efl/install-dependencies:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] SecComp buildfix after r176452
ossy@webkit.org [Fri, 28 Nov 2014 09:10:41 +0000 (09:10 +0000)]
[WK2] SecComp buildfix after r176452
https://bugs.webkit.org/show_bug.cgi?id=139081

Reviewed by Antti Koivisto.

* Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix -Wc++11-narrowing error in SeccompFilters.cpp
ossy@webkit.org [Fri, 28 Nov 2014 09:09:44 +0000 (09:09 +0000)]
Fix -Wc++11-narrowing error in SeccompFilters.cpp
https://bugs.webkit.org/show_bug.cgi?id=139079

Reviewed by Carlos Garcia Campos.

* Shared/linux/SeccompFilters/SeccompFilters.cpp:
(WebKit::SeccompFilters::addRule):
* Shared/linux/SeccompFilters/SeccompFilters.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] SecComp buildfix after r168605 and r168999
ossy@webkit.org [Fri, 28 Nov 2014 09:04:21 +0000 (09:04 +0000)]
[WK2] SecComp buildfix after r168605 and r168999
https://bugs.webkit.org/show_bug.cgi?id=139080

Reviewed by Carlos Garcia Campos.

* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
commit-queue@webkit.org [Fri, 28 Nov 2014 09:00:54 +0000 (09:00 +0000)]
[ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
https://bugs.webkit.org/show_bug.cgi?id=139044

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-11-28
Reviewed by Chris Fleizach.

ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
The proposed solution will enable the use of this method for the object table.
Existing test shows the result.

Tools:

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::columnHeaders):

LayoutTests:

* accessibility/table-column-headers-with-captions.html: Updated for ATK platform.
* platform/efl/accessibility/table-column-headers-with-captions-expected.txt: Added.
* platform/gtk/TestExpectations: Updated for GTK.
* platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Remove E_Dbus dependency
ryuan.choi@navercorp.com [Fri, 28 Nov 2014 07:04:09 +0000 (07:04 +0000)]
[EFL] Remove E_Dbus dependency
https://bugs.webkit.org/show_bug.cgi?id=136355

Reviewed by Gyuyoung Kim.

.:

* Source/cmake/FindE_DBus.cmake: Removed.
* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
This patch replaces E_Dbus implementation to Eldbus.

* PlatformEfl.cmake:
* platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::batteryProperties):
(WebCore::batteryPropertiesChanged):
(WebCore::BatteryProviderEfl::deviceTypeCallback):
(WebCore::BatteryProviderEfl::enumerateDevices):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired): Deleted.
(WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
(WebCore::BatteryProviderEfl::setBatteryClient): Deleted.
* platform/efl/BatteryProviderEfl.h:
(WebCore::BatteryProviderEfl::connection):
(WebCore::BatteryProviderEfl::setSignalHandler):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.

Source/WebKit2:

* UIProcess/API/efl/ewk_main.cpp: Added init/shutdown for eldbus.
(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):

Tools:

* MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInIma...
antti@apple.com [Fri, 28 Nov 2014 01:40:01 +0000 (01:40 +0000)]
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
https://bugs.webkit.org/show_bug.cgi?id=139057

Reviewed by Anders Carlsson.

No test, don't know how to repro.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse std::unique_ptr instead of OwnPtr in JSC classes
gyuyoung.kim@samsung.com [Fri, 28 Nov 2014 00:51:32 +0000 (00:51 +0000)]
Use std::unique_ptr instead of OwnPtr in JSC classes
https://bugs.webkit.org/show_bug.cgi?id=139009

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

* bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
* bytecode/DFGExitProfile.h:
* bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::add):
* bytecode/LazyOperandValueProfile.h:
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::clearNewlyAllocated):
* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
* runtime/RegExp.cpp:
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:
* yarr/RegularExpression.cpp:
(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):
* yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: [ATK] Meter and Option elements do not expose their id attribute
jdiggs@igalia.com [Fri, 28 Nov 2014 00:24:43 +0000 (00:24 +0000)]
AX: [ATK] Meter and Option elements do not expose their id attribute
https://bugs.webkit.org/show_bug.cgi?id=139017

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The options in a collapsed select element lack a node, so get the id
attribute from the associated action element. In the case of a meter,
the meter element itself is not exposed; its RenderMeter is instead.
So associate the meter element's id with the exposed RenderMeter.

No new tests. Instead, updated existing expectations to reflect the fix.

* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::element):
* accessibility/AccessibilityProgressIndicator.h:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):

LayoutTests:

* accessibility/roles-exposed.html: Unskipped the meter element test.
* platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
* platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a stubbed out WebVisitedLinkStore to WebViewGroup
andersca@apple.com [Thu, 27 Nov 2014 18:00:10 +0000 (18:00 +0000)]
Add a stubbed out WebVisitedLinkStore to WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139066

Reviewed by Antti Koivisto.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* WebCoreSupport/WebViewGroup.h:
(WebViewGroup::visitedLinkStore):
* WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::WebViewGroup):
* WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
* WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a Page::setVisitedLinkStore member function
andersca@apple.com [Thu, 27 Nov 2014 17:58:41 +0000 (17:58 +0000)]
Add a Page::setVisitedLinkStore member function
https://bugs.webkit.org/show_bug.cgi?id=139065

Reviewed by Antti Koivisto.

This will be used in a subsequent commit.

* WebCore.exp.in:
* page/Page.cpp:
(WebCore::Page::setVisitedLinkStore):
* page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Unreviewed GTK gardening.
commit-queue@webkit.org [Thu, 27 Nov 2014 12:04:51 +0000 (12:04 +0000)]
[GTK] Unreviewed GTK gardening.
https://bugs.webkit.org/show_bug.cgi?id=139061

rebaseline after r176354.

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-11-27

* platform/gtk/fast/multicol/tall-image-behavior-expected.png: Added.
* platform/gtk/fast/multicol/tall-image-behavior-expected.txt: Added.
* platform/gtk/fast/multicol/tall-image-behavior-lr-expected.png: Added.
* platform/gtk/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
* platform/gtk/fast/multicol/tall-image-behavior-rl-expected.png: Added.
* platform/gtk/fast/multicol/tall-image-behavior-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Update NavigationItemProbes icon for the GTK+ port
agomez@igalia.com [Thu, 27 Nov 2014 11:39:33 +0000 (11:39 +0000)]
Web Inspector: Update NavigationItemProbes icon for the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=139074

Reviewed by Carlos Garcia Campos.

NavigationItemProbes was updated for the Mac port and we are now
having a similar ideogram in GTK+.

* UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Unreviewed EFL gardening after r176354.
commit-queue@webkit.org [Wed, 26 Nov 2014 13:39:20 +0000 (13:39 +0000)]
[EFL] Unreviewed EFL gardening after r176354.
https://bugs.webkit.org/show_bug.cgi?id=139060

rebaseline after r176354.

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-11-26

* platform/efl/fast/multicol/tall-image-behavior-expected.png: Added.
* platform/efl/fast/multicol/tall-image-behavior-expected.txt: Added.
* platform/efl/fast/multicol/tall-image-behavior-lr-expected.png: Added.
* platform/efl/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
* platform/efl/fast/multicol/tall-image-behavior-rl-expected.png: Added.
* platform/efl/fast/multicol/tall-image-behavior-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
commit-queue@webkit.org [Wed, 26 Nov 2014 08:08:17 +0000 (08:08 +0000)]
[EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
https://bugs.webkit.org/show_bug.cgi?id=139047

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-11-26
Reviewed by Carlos Garcia Campos.

* efl/jhbuild.modules:
* efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
* efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
* gtk/jhbuild-optional.modules:
* gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
* gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd parsing for :dir()
commit-queue@webkit.org [Wed, 26 Nov 2014 00:27:52 +0000 (00:27 +0000)]
Add parsing for :dir()
https://bugs.webkit.org/show_bug.cgi?id=138932

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2014-11-25
Reviewed by Benjamin Poulain.

Source/WebCore:

Add support for parsing :dir() pseudo class. The implementation of selector
matching will be in a follow-up patch.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::detectFunctionTypeToken):
* css/CSSSelector.cpp:
(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/css-set-selector-text-expected.txt:
* fast/css/css-set-selector-text.html:
* fast/selectors/invalid-functional-pseudo-class-expected.txt:
* fast/selectors/invalid-functional-pseudo-class.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove user content handling from PageGroup
andersca@apple.com [Tue, 25 Nov 2014 19:50:45 +0000 (19:50 +0000)]
Remove user content handling from PageGroup
https://bugs.webkit.org/show_bug.cgi?id=139051

Reviewed by Antti Koivisto.

Source/WebCore:

Remove m_userContentController from PageGroup and the related functions and symbol exports.

* WebCore.exp.in:
* page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addPage):
(WebCore::PageGroup::removePage):
(WebCore::PageGroup::addUserScriptToWorld): Deleted.
(WebCore::PageGroup::addUserStyleSheetToWorld): Deleted.
(WebCore::PageGroup::removeUserScriptFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetFromWorld): Deleted.
(WebCore::PageGroup::removeUserScriptsFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetsFromWorld): Deleted.
(WebCore::PageGroup::removeAllUserContent): Deleted.
* page/PageGroup.h:

Source/WebKit/mac:

Use the user content controller in the web view group.

* WebView/WebView.mm:
(-[WebView _injectOutlookQuirksScript]):

Source/WebKit2:

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
Talk to the user content controller from the passed in WebPageGroupProxy.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Create the WebPageGroupProxy before creating the page so we can get its user content controller and
pass it to the page configuration if necessary.

* WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::userContentController):
New function that lazily creates a user content controller. We don't want to create this eagerly since
it's not used with the modern API.

(WebKit::WebPageGroupProxy::addUserStyleSheet):
(WebKit::WebPageGroupProxy::addUserScript):
(WebKit::WebPageGroupProxy::removeAllUserStyleSheets):
(WebKit::WebPageGroupProxy::removeAllUserScripts):
(WebKit::WebPageGroupProxy::removeAllUserContent):
Call through to the user content controller.

* WebProcess/WebPage/WebPageGroupProxy.h:
Add an m_userContentController member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, upload two missing test files in the commit r174677.
alex@webkit.org [Tue, 25 Nov 2014 18:05:39 +0000 (18:05 +0000)]
Unreviewed, upload two missing test files in the commit r174677.

* mathml/presentation/mo-stretch-update-expected.html: Added.
* mathml/presentation/mo-stretch-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a user content controller to WebViewGroup and use it for user content
andersca@apple.com [Tue, 25 Nov 2014 16:16:15 +0000 (16:16 +0000)]
Add a user content controller to WebViewGroup and use it for user content
https://bugs.webkit.org/show_bug.cgi?id=139043

Reviewed by Antti Koivisto.

Source/WebCore:

* WebCore.exp.in:
Export symbols.

* page/Page.cpp:
(WebCore::Page::setUserContentController):
Invalidate the injected style cache when setting a new user content controller.

Source/WebKit/mac:

This is another tiny step towards getting rid of user content handling inside PageGroup.

* WebCoreSupport/WebViewGroup.h:
(WebViewGroup::userContentController):
Add a UserContentController member and getter.

* WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::get):
Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).

(WebViewGroup::WebViewGroup):
Create a user content controller.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
set its user content controller in the PageConfiguration.

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Ditto.

(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
(+[WebView _removeAllUserContentFromGroup:]):
Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.

(-[WebView setGroupName:]):
Set the user content controller to the new WebViewGroup's user content controller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] gstmpegts is not initialized
philn@webkit.org [Tue, 25 Nov 2014 14:49:30 +0000 (14:49 +0000)]
[GStreamer] gstmpegts is not initialized
https://bugs.webkit.org/show_bug.cgi?id=139039

Reviewed by Carlos Garcia Campos.

* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer): Initialize the gstmpegts library.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
berto@igalia.com [Tue, 25 Nov 2014 14:29:09 +0000 (14:29 +0000)]
[GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
version of libraries when running the temporary executable
https://bugs.webkit.org/show_bug.cgi?id=138833

Patch by Ting-Wei Lan <lantw44@gmail.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.

This patch modifies LD_LIBRARY_PATH to make sure the dynamic linker
find the correct version of libraries when running the temporary
executable to generate the .gir file.

* PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
commit-queue@webkit.org [Tue, 25 Nov 2014 13:48:04 +0000 (13:48 +0000)]
[GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
https://bugs.webkit.org/show_bug.cgi?id=138090

Patch by Tanay C <tanay.c@samsung.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.

* MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
(browserWindowZoomIn): Added.
(browserWindowZoomOut): Added.
(scrollEventCallback): Added.
(zoomInCallback): Modified.
(zoomOutCallback): Modified.
(browserWindowConstructed): Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] REGRESSION(r176514): It made performance tests fail
ossy@webkit.org [Tue, 25 Nov 2014 09:59:38 +0000 (09:59 +0000)]
[EFL] REGRESSION(r176514): It made performance tests fail
https://bugs.webkit.org/show_bug.cgi?id=139037

Reviewed by Gyuyoung Kim.

Source/WebKit2:

* WebProcess/efl/WebProcessMainEfl.cpp: Don't try to load/shutdown eail if eailLibraryPath() is empty.

Tools:

* Scripts/webkitpy/port/efl.py:
(EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
* efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix unused variable warning in Biquad.cpp
evab.u-szeged@partner.samsung.com [Tue, 25 Nov 2014 07:41:27 +0000 (07:41 +0000)]
Fix unused variable warning in Biquad.cpp
https://bugs.webkit.org/show_bug.cgi?id=139031

Reviewed by Andreas Kling.

No new tests needed.

* platform/audio/Biquad.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove Qt cruft related to tap higlighting
evab.u-szeged@partner.samsung.com [Tue, 25 Nov 2014 07:39:07 +0000 (07:39 +0000)]
Remove Qt cruft related to tap higlighting
https://bugs.webkit.org/show_bug.cgi?id=139030

Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

* CMakeLists.txt:
* page/GestureTapHighlighter.cpp: Removed.
* page/GestureTapHighlighter.h: Removed.

Source/WebKit2:

* CMakeLists.txt:
* WebProcess/WebPage/TapHighlightController.cpp: Removed.
* WebProcess/WebPage/TapHighlightController.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the parsing and re-serialization of :lang pseudo class selector when it has multi...
commit-queue@webkit.org [Tue, 25 Nov 2014 05:26:27 +0000 (05:26 +0000)]
Fix the parsing and re-serialization of :lang pseudo class selector when it has multiple arguments with same value
https://bugs.webkit.org/show_bug.cgi?id=139013

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-11-24
Reviewed by Benjamin Poulain.

Source/WebCore:

Fix the parsing and re-serialization of :lang pseudo class selector when
it has multiple arguments with same value e.g. :lang(en, en, en). Previously,
given :lang(en, en, en) selector, it was parsed and reserialized
as :lang(enenen) instead of :lang(en, en, en)

Related test on parsing and re-serialization of css selectors is updated.

* css/CSSSelector.cpp:
(WebCore::appendArgumentList):

LayoutTests:

Updated tests to verify the parsing and serialization of :lang pseudo class
selector when it has multiple arguments with same value.

* fast/css/css-selector-text-expected.txt: Updated to cover fix.
* fast/css/css-selector-text.html: Updated to cover fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix r176527. Iterate through the text renderers.
zalan@apple.com [Tue, 25 Nov 2014 03:47:57 +0000 (03:47 +0000)]
Fix r176527. Iterate through the text renderers.
https://bugs.webkit.org/show_bug.cgi?id=139007

Reviewed by Antti Koivisto.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up OwnPtr and PassOwnPtr in JSC - bytecode, jit, inspector, and interpreter
gyuyoung.kim@samsung.com [Tue, 25 Nov 2014 02:40:06 +0000 (02:40 +0000)]
Clean up OwnPtr and PassOwnPtr in JSC - bytecode, jit, inspector, and interpreter
https://bugs.webkit.org/show_bug.cgi?id=139022

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

* bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
* bytecode/DFGExitProfile.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):
* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::JITFinalizer):
* dfg/DFGJITFinalizer.h:
* heap/IncrementalSweeper.h:
* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
* inspector/agents/InspectorDebuggerAgent.h:
* inspector/agents/JSGlobalObjectRuntimeAgent.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::enableSampler):
* interpreter/Interpreter.h:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::ExecutableAllocator):
* jit/ExecutableAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL build fix since r176530.
gyuyoung.kim@samsung.com [Tue, 25 Nov 2014 01:37:39 +0000 (01:37 +0000)]
Unreviewed, EFL build fix since r176530.

* UIProcess/CoordinatedGraphics/WebView.cpp: Replace pointer with reference.
(WebKit::WebView::processDidExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSimple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
zalan@apple.com [Tue, 25 Nov 2014 01:00:57 +0000 (01:00 +0000)]
Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
https://bugs.webkit.org/show_bug.cgi?id=139035

Reviewed by Antti Koivisto.

Move new line logic to FlowContents class.
This is in preparation to support <br>.

No change in functionality.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
* rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isNewline):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Remove some bad stuff from WebPageProxy
benjamin@webkit.org [Tue, 25 Nov 2014 00:26:35 +0000 (00:26 +0000)]
[WK2] Remove some bad stuff from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=138896

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-24
Reviewed by Sam Weinig.

The state loadStateAtProcessExit does not seem to be used anywhere.

The state urlAtProcessExit only exists to forward the url from
WebPageProxy::resetStateAfterProcessExited() to the coordinated graphics code
WebView::processDidExit().

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::processDidExit):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::urlAtProcessExit): Deleted.
(WebKit::WebPageProxy::loadStateAtProcessExit): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove :placeholder-shown out of experimental
benjamin@webkit.org [Tue, 25 Nov 2014 00:20:35 +0000 (00:20 +0000)]
Move :placeholder-shown out of experimental
https://bugs.webkit.org/show_bug.cgi?id=138998

Reviewed by Andreas Kling.

The pseudo class :placeholder-shown is used by the inspector, disabling it breaks
the sidebar.

The implementation has been stable for a while, we can move it to stable.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAvoid String concatenation with line break iterator
antti@apple.com [Tue, 25 Nov 2014 00:15:46 +0000 (00:15 +0000)]
Avoid String concatenation with line break iterator
https://bugs.webkit.org/show_bug.cgi?id=139034

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/text/simple-lines-multiple-renderers-break.html

* rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments):

    Include String too so it doesn't need to be fetched from the renderer.

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):

    Make this iterative instead of recursive.
    Uset setPriorContext to provide previous characters instead of concatenating
    the string from all the previous segments.

(WebCore::SimpleLineLayout::findNextNonWhitespace):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):

    Search using segments instead of the concatenated string.

(WebCore::SimpleLineLayout::FlowContents::textWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow): Deleted.
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Deleted.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition): Deleted.
* rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::characterAt):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition):
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):

LayoutTests:

Test that there is no implicit break point between Text nodes.

* fast/text/simple-lines-multiple-renderers-break-expected.html: Added.
* fast/text/simple-lines-multiple-renderers-break.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSimpleLineLayout::canUseFor() should iterate through RenderTexts to check if their...
zalan@apple.com [Tue, 25 Nov 2014 00:10:17 +0000 (00:10 +0000)]
SimpleLineLayout::canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
https://bugs.webkit.org/show_bug.cgi?id=139007

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html
       fast/text/simple-line-layout-multiple-renderers-with-float.html

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

LayoutTests:

* fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html: Added.
* fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html: Added.
* fast/text/simple-line-layout-multiple-renderers-with-float-expected.html: Added.
* fast/text/simple-line-layout-multiple-renderers-with-float.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] update-webkitgtk-libs fails to build fontconfig
commit-queue@webkit.org [Tue, 25 Nov 2014 00:05:27 +0000 (00:05 +0000)]
[GTK] update-webkitgtk-libs fails to build fontconfig
https://bugs.webkit.org/show_bug.cgi?id=139032

Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2014-11-24
Reviewed by Martin Robinson.

On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
fontconfig will try to generate documentation and fail.

* gtk/install-dependencies:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSimple line layout: fast/text/simple-lines-multiple-renderers test has the wrong...
zalan@apple.com [Mon, 24 Nov 2014 23:56:37 +0000 (23:56 +0000)]
Simple line layout: fast/text/simple-lines-multiple-renderers test has the wrong content.
https://bugs.webkit.org/show_bug.cgi?id=139036

Swap simple-lines-multiple-renderers.html and simple-lines-multiple-renderers-expected.html

* fast/text/simple-lines-multiple-renderers-expected.html:
* fast/text/simple-lines-multiple-renderers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the '-webkit-box-reflext' CSS property to the new StyleBuilder
weinig@apple.com [Mon, 24 Nov 2014 22:12:53 +0000 (22:12 +0000)]
Move the '-webkit-box-reflext' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139008

Reviewed by Anders Carlsson.

* css/CSSPropertyNames.in:
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertReflection):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStub out user content WebView member functions on Windows
andersca@apple.com [Mon, 24 Nov 2014 22:09:06 +0000 (22:09 +0000)]
Stub out user content WebView member functions on Windows
https://bugs.webkit.org/show_bug.cgi?id=139033

Reviewed by Sam Weinig.

These functions aren't used by any clients and hinder getting rid of PageGroup.
If it turns out they're still needed we can copy the user content controller code from Mac Legacy WebKit.

* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
(toStringVector): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] REGRESSION(176066): It made all performance tests fail
ryuan.choi@navercorp.com [Mon, 24 Nov 2014 20:48:49 +0000 (20:48 +0000)]
[EFL] REGRESSION(176066): It made all performance tests fail
https://bugs.webkit.org/show_bug.cgi?id=138865

Reviewed by Csaba Osztrogon√°c.

Since r176066, there are crash because evas_gl_surface is destroyed with
invalid evas_gl instance after evas_gl is destroyed.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::~EwkView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused Style struct from SimpleLineLayout.cpp
antti@apple.com [Mon, 24 Nov 2014 18:07:13 +0000 (18:07 +0000)]
Remove unused Style struct from SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=139027

Reviewed by Sam Weinig.

It was moved to FlowContents.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::Style::Style): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Curl] Compile error in ResourceHandleManager.cpp.
commit-queue@webkit.org [Mon, 24 Nov 2014 17:02:25 +0000 (17:02 +0000)]
[Curl] Compile error in ResourceHandleManager.cpp.
https://bugs.webkit.org/show_bug.cgi?id=139026

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-24
Reviewed by Brent Fulgham.

The parameter types of the constructor of the Timer class has changed.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::ResourceHandleManager):
(WebCore::ResourceHandleManager::downloadTimerCallback):
* platform/network/curl/ResourceHandleManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebkit2 doesnt build on powerpc 32 bits
berto@igalia.com [Mon, 24 Nov 2014 14:49:39 +0000 (14:49 +0000)]
Webkit2 doesnt build on powerpc 32 bits
https://bugs.webkit.org/show_bug.cgi?id=130837

Reviewed by Carlos Garcia Campos.

Check if libatomic is needed in order to use std::atomic, and add
it to the list of WebKit2 libraries.

* PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago.:
carlosgc@webkit.org [Mon, 24 Nov 2014 12:45:13 +0000 (12:45 +0000)]
.:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.2 release.

* gtk/NEWS: Add release notes for 2.7.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Fix GTK+ make distcheck.
carlosgc@webkit.org [Mon, 24 Nov 2014 12:12:08 +0000 (12:12 +0000)]
Unreviewed. Fix GTK+ make distcheck.

* gtk/manifest.txt: Remove deleted files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
jdiggs@igalia.com [Mon, 24 Nov 2014 12:05:33 +0000 (12:05 +0000)]
AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
https://bugs.webkit.org/show_bug.cgi?id=139016

Reviewed by Chris Fleizach.

Source/WebCore:

There was one test that could not be unskipped without making a change
for that one to pass: mapping DocumentRegionRole to ATK_ROLE_PANEL. The
rest of the "fix" is just unskipping tests for ATK and updating the test
expectations.

No new tests needed.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

LayoutTests:

* accessibility/roles-exposed.html: Unskipped a bunch of tests.
* platform/efl/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.
* platform/gtk/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Utilize Eail library to support accessibility in EFL
k.czech@samsung.com [Mon, 24 Nov 2014 11:30:55 +0000 (11:30 +0000)]
[EFL] Utilize Eail library to support accessibility in EFL
https://bugs.webkit.org/show_bug.cgi?id=137742

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Initialize EAIL module so that all the listeners and atk-bridge started properly.
Dynamic loading of EAIL help us to avoid elementary dependencies in WebKit.

* WebProcess/efl/WebProcessMainEfl.cpp:
(eailLibraryPath): reads path provided by ACCESSIBILITY_EAIL_LIBRARY_PATH variable.
(eail):

Tools:

Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.

* efl/jhbuild-optional.modules: Added.
* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_...
carlosgc@webkit.org [Mon, 24 Nov 2014 11:18:55 +0000 (11:18 +0000)]
[GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
https://bugs.webkit.org/show_bug.cgi?id=139023

Reviewed by Sergio Villar Senin.

Source/WebKit2:

The WebKitWebContext is a construct only property, so it's always
set to the default value when not provided, during the
construction. When a related-view is used to create a new web view
we should ensure that the same web context is used for the new web
view, instead of the default. We should also ignore any web
context given as construct parameter if a related view is alos provided.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Do not set the context to the default
one when not given during construction.
(webkitWebViewSetProperty): Only use the default web context when
not provided as construct parameter and there isn't a related view.

Tools:

Rename WebKitWebView/default-context as WebKitWebView/web-context
and check we are always using the right context for new web views.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewWebContext):
(beforeAll):
(testWebViewDefaultContext): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Add API to override the default local storage directory
carlosgc@webkit.org [Mon, 24 Nov 2014 07:24:01 +0000 (07:24 +0000)]
[GTK] Add API to override the default local storage directory
https://bugs.webkit.org/show_bug.cgi?id=138828

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add WebKitWebContext:local-storage-directory construct-only
property. If not provided the default will be used.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):

Tools:

Add test to check that the local storage directory is created at
the path given on construction.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextConfiguration):
(beforeAll):
* TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
(Test::Test):
(Test::~Test): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPage previews should have titles
conrad_shultz@apple.com [Mon, 24 Nov 2014 05:21:13 +0000 (05:21 +0000)]
Page previews should have titles
https://bugs.webkit.org/show_bug.cgi?id=139020

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKViewPrivate.h:
Declare -_titleForPreviewOfURL:.

* UIProcess/API/mac/WKView.mm:
(-[WKView _titleForPreviewOfURL:]):
Stub implementation.

* UIProcess/mac/WKActionMenuController.mm:
(+[WKPagePreviewViewController previewPadding]):
Account for the title height.
(-[WKPagePreviewViewController loadView]):
Set correct autoresize masks on some views; create and configure a title view that is
horizontally and vertically centered.
(-[WKActionMenuController pagePreviewViewController:titleForPreviewOfURL:]):
WKPagePreviewViewControllerDelegate method; wrap -[WKView _titleForPreviewOfURL:].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse segment vector for FlowContents
antti@apple.com [Sun, 23 Nov 2014 18:46:18 +0000 (18:46 +0000)]
Use segment vector for FlowContents
https://bugs.webkit.org/show_bug.cgi?id=139015

Reviewed by Zalan Bujtas.

And FlowContents::Segment struct and use it.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):

    Use segments.
    If there is only one segment there is nothing to do. Bail out.

* rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments):

    Move initialization to a function so m_segments can be const.
    Don't add empty end segment, handle the end case in code.

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::textWidth):

    Simplify and use segments.

(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow):

    Replace hand-rolled binary search with std::lower_bounds.

(WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
(WebCore::SimpleLineLayout::FlowContents::renderer): Deleted.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): Deleted.
* rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::hasOneSegment):
(WebCore::SimpleLineLayout::FlowContents::length):
(WebCore::SimpleLineLayout::FlowContents::isEnd):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent): Deleted.

    Renamed.

(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):

    Inline the fast path.

* rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoExtend WKRenderObject and WKRenderLayer with some more useful data
simon.fraser@apple.com [Sun, 23 Nov 2014 18:00:52 +0000 (18:00 +0000)]
Extend WKRenderObject and WKRenderLayer with some more useful data
https://bugs.webkit.org/show_bug.cgi?id=139006

Reviewed by Sam Weinig.
Source/WebCore:

Export WebCore::RenderLayerBacking::backingStoreMemoryEstimate() const.

* WebCore.exp.in:

Source/WebKit2:

Implement WKRenderLayerGetBackingStoreMemoryEstimate,
WKRenderObjectCopyTextSnippet and WKRenderObjectGetTextLength for improved
RenderLayer and RenderTree display in clients of the C SPI.

* Shared/API/c/WKRenderLayer.cpp:
(WKRenderLayerGetBackingStoreMemoryEstimate):
* Shared/API/c/WKRenderLayer.h:
* Shared/API/c/WKRenderObject.cpp:
(WKRenderObjectCopyTextSnippet):
(WKRenderObjectGetTextLength):
* Shared/API/c/WKRenderObject.h:
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):
* Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::backingStoreMemoryEstimate):
* Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):
* Shared/WebRenderObject.h:
(WebKit::WebRenderObject::textSnippet):
(WebKit::WebRenderObject::textLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up OwnPtr and PassOwnPtr in some of JS classes
gyuyoung.kim@samsung.com [Sun, 23 Nov 2014 04:37:15 +0000 (04:37 +0000)]
Clean up OwnPtr and PassOwnPtr in some of JS classes
https://bugs.webkit.org/show_bug.cgi?id=138724

Reviewed by Filip Pizlo.

As a step to use std::unique_ptr<> and std::make_unique<>, this patch replaces
OwnPtr with std::unique_ptr<>. Besides create() factory function is removed as well.

* builtins/BuiltinExecutables.h:
(JSC::BuiltinExecutables::create): Deleted.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::createRareDataIfNecessary):
* bytecode/StructureStubInfo.h:
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::hasRareData):
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):
* runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
* runtime/CodeCache.h:
(JSC::CodeCache::create): Deleted.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::clearRareData):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createRareDataIfNeeded):
* runtime/RegExpConstructor.h:
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::singleCharacterStringRep):
* runtime/SmallStrings.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake locale part of the SimpleLineLayout::FlowContent::Style
antti@apple.com [Sat, 22 Nov 2014 19:37:08 +0000 (19:37 +0000)]
Make locale part of the SimpleLineLayout::FlowContent::Style
https://bugs.webkit.org/show_bug.cgi?id=139004

Reviewed by Zalan Bujtas.

That's the only part of style not extracted out of RenderStyle in the constructor.

* rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::Style::Style):
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
* rendering/SimpleLineLayoutFlowContents.h:

    Also remove RenderBlockFlow member since it is now unused.

(WebCore::SimpleLineLayout::FlowContents::Style::Style): Deleted.

    Move to cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agor176455: ASSERT(!m_vector.isEmpty()) in IntendedStructureChain.cpp(143)
msaboff@apple.com [Sat, 22 Nov 2014 19:07:26 +0000 (19:07 +0000)]
r176455: ASSERT(!m_vector.isEmpty()) in IntendedStructureChain.cpp(143)
https://bugs.webkit.org/show_bug.cgi?id=139000

Reviewed by Darin Adler.

Check that the chainCount is non-zero before using a StructureChain.

* bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: [ATK] Accessible names missing for imagemap images and links
jdiggs@igalia.com [Sat, 22 Nov 2014 18:18:11 +0000 (18:18 +0000)]
AX: [ATK] Accessible names missing for imagemap images and links
https://bugs.webkit.org/show_bug.cgi?id=127288

Source/WebCore:

Reviewed by Chris Fleizach.

Return the alt text, if present, for the accessible name for image maps
and image map links for ATK. Also expose the accessible element with
ATK_ROLE_IMAGE_MAP instead of ATK_ROLE_IMAGE.

Test: accessibility/image-with-alt-and-map.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isImageMap):
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(atkRole):

LayoutTests:

New and updated tests to reflect the expected role, accessible hierarchy,
and exposure of the alternative text for each platform.

Reviewed by Chris Fleizach.

* accessibility/image-with-alt-and-map.html: Added.
* accessibility/roles-exposed.html: Added some more elements to the test.
* platform/efl/accessibility/image-map1-expected.txt: Added.
* platform/efl/accessibility/image-map2-expected.txt: Updated to reflect fix.
* platform/efl/accessibility/image-with-alt-and-map-expected.txt: Added.
* platform/efl/accessibility/roles-exposed-expected.txt: Updated for added elements.
* platform/gtk/accessibility/image-map1-expected.txt: Added.
* platform/gtk/accessibility/image-map2-expected.txt: Updated to reflect fix.
* platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Added.
* platform/gtk/accessibility/roles-exposed-expected.txt: Updated for added elements.
* platform/mac/accessibility/image-with-alt-and-map-expected.txt: Added.
* platform/mac/accessibility/roles-exposed-expected.txt: Updated for added elements.
* platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for added elements.
* platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for added elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused Document::ignoreAutofocus().
akling@apple.com [Sat, 22 Nov 2014 10:11:13 +0000 (10:11 +0000)]
Remove unused Document::ignoreAutofocus().
<https://webkit.org/b/139002>

Reviewed by Antti Koivisto.

No one ever actually changes this flag, so let's remove it.

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::ignoreAutofocus): Deleted.
(WebCore::Document::setIgnoreAutofocus): Deleted.
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r176459 to fix GTK build.
ossy@webkit.org [Sat, 22 Nov 2014 09:44:21 +0000 (09:44 +0000)]
URTBF after r176459 to fix GTK build.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::requestAnimationTimerFired):
* platform/ScrollAnimatorNone.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoConvert PassRefPtr return types to RefPtr.
akling@apple.com [Sat, 22 Nov 2014 09:12:01 +0000 (09:12 +0000)]
Convert PassRefPtr return types to RefPtr.
<https://webkit.org/b/138995>

Reviewed by Anders Carlsson.

Convert an assortment of DOM and HTML related functions
to return RefPtr instead of PassRefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed iOS build fix; move new symbols out of Mac-only exports.
jer.noble@apple.com [Sat, 22 Nov 2014 07:50:44 +0000 (07:50 +0000)]
Unreviewed iOS build fix; move new symbols out of Mac-only exports.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove a file that r176499 presumably did not mean to add.
timothy_horton@apple.com [Sat, 22 Nov 2014 06:38:47 +0000 (06:38 +0000)]
Remove a file that r176499 presumably did not mean to add.

* WebCore.exp.in.orig: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSupport multiple signatures of diagnostic logging.
jer.noble@apple.com [Sat, 22 Nov 2014 05:27:16 +0000 (05:27 +0000)]
Support multiple signatures of diagnostic logging.
https://bugs.webkit.org/show_bug.cgi?id=138690

Reviewed by Anders Carlsson.

Source/WebCore:

Pull logDiagnosticMessage() out of ChromeClient and make a new client interface,
DiagnosticLoggingClient, which supports multiple kinds of diagnostic logging,
namely: simple logging without a parameter, logging with a success parameter, and
logging with a generic string value parameter.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Use DiagnosticLoggingClient.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
* loader/SubframeLoader.cpp:
(WebCore::logPluginRequest): Ditto.
* page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage): Deleted.
* page/DiagnosticLoggingClient.h:
(WebCore::DiagnosticLoggingClient::logDiagnosticMessage): Added.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithResult): Added.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithValue): Added.
(WebCore::DiagnosticLoggingClient::~DiagnosticLoggingClient): Empty destructor.

Rename Page::PageClient to PageConfiguration, and pass that configuration from
Page into MainFrame upon construction.

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage): Use PageConfiguration instead of PageClients.
* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients): Ditto.
* loader/EmptyClients.h:
* page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame): Pass loaderClientForMainFrame through to the
    Frame constructor.
(WebCore::MainFrame::create): Takes a PageConfiguration.
* page/MainFrame.h:
(WebCore::MainFrame::diagnosticLoggingClient): Simple accessor.
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients): Deleted.
(WebCore::Page::PageClients::~PageClients): Deleted.
* page/Page.h:
* page/PageConfiguration.cpp: Added.
(WebCore::PageConfiguration::PageConfiguration): Renamed from PageClients().
(WebCore::PageConfiguration::~PageConfiguration): Renamed from ~PageClients().
* page/PageConfiguration.h: Added.
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged): Use PageConfiguration instead of PageClients.

Add new files and symbols to the project.

* CMakeLists.txt:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Page::PageClients has been renamed PageConfiguration.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit/win:

Page::PageClients has been renamed PageConfiguration.

* WebView.cpp:
(WebView::initWithFrame):

Source/WebKit2:

Extend the existing WKBundlePageDiagnosticLoggingClient interface by deprecating
the original logDiagnosticMessage client method in V1 and adding three new,
explicit client methods.

* CMakeLists.txt:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageDeprecated):
    Renamed from logDiagnosticMessage().
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Pass to the client.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage): Deleted.
* WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp: Added.
(WebKit::WebDiagnosticLoggingClient::WebDiagnosticLoggingClient): Simple constructor.
(WebKit::WebDiagnosticLoggingClient::~WebDiagnosticLoggingClient): Simple destructor.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage): Pass to the injected bundle.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.
* WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h: Added.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize the new client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Fixed syntax errors.
rniwa@webkit.org [Sat, 22 Nov 2014 04:25:19 +0000 (04:25 +0000)]
Unreviewed. Fixed syntax errors.

* init-database.sql:
* public/api/commits.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThe dashboard on new perf monitor should be configurable
rniwa@webkit.org [Sat, 22 Nov 2014 03:42:26 +0000 (03:42 +0000)]
The dashboard on new perf monitor should be configurable
https://bugs.webkit.org/show_bug.cgi?id=138994

Reviewed by Benjamin Poulain.

For now, make it configurable via config.json. We should eventually make it configurable via
an administrative page but this will do for now.

* config.json: Added the empty dashboard configuration.

* public/include/manifest.php: Include the dashboard configuration in the manifest file.

* public/v2/app.js:
(App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
(App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
Also obtain the default configuration from App.Manifest.
(App.IndexController._normalizeTable): Moved to App.Dashboard.

* public/v2/manifest.js:
(App.Repository.urlForRevision): Fixed the position of the open curly bracket.
(App.Repository.urlForRevisionRange): Ditto.
(App.Dashboard): Added.
(App.Dashboard.table): Extracted from App.IndexController.gridChanged.
(App.Dashboard.rows): Ditto.
(App.Dashboard.headerColumns): Ditto.
(App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
(App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
Since there is exactly one dashboard object per app, it's okay to hard code an id here.
(App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThrottled DOMTimers can prevent their document from being garbage collected
cdumez@apple.com [Sat, 22 Nov 2014 03:29:58 +0000 (03:29 +0000)]
Throttled DOMTimers can prevent their document from being garbage collected
https://bugs.webkit.org/show_bug.cgi?id=138915

Reviewed by Andreas Kling.

Source/WebCore:

Throttled DOMTimers whose interval depend on viewport changes would
keep a Vector of elements outside viewport causing them to be throttled
so that we could check later on (upon scroll or layout) if those
elements are still outside viewport. The issue is that these elements
could potentially be removed from the document (and destroyed) after
the timer has fired. To handle this, DOMTimer was ref'ing the
elements. Unfortunately, this was causing us to leak the document
as the elements in the Vector would keep the document alive.

To handle this issue, this patch updates the DOMTimer Vector to use
weak pointers. The WeakPtrFactory is stored in ElementRareData to
avoid wasting memory for all kinds of Elements (it is a fair assumption
that the number of elements whose style is animated via timers is low).

Test: fast/dom/throttled-timer-running-on-document-destruction.html

* dom/Element.cpp:
(WebCore::Element::createWeakPtr):
* dom/Element.h:
* dom/ElementRareData.cpp:
* dom/ElementRareData.h:
(WebCore::ElementRareData::weakPtrFactory):
* page/DOMTimer.cpp:
(WebCore::DOMTimerFireState::elementsChangedOutsideViewport):
(WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):
* page/DOMTimer.h:

LayoutTests:

Improve fast/dom/throttled-timer-running-on-document-destruction.html
layout test to cover the case where the throttled timer is changing the
style of an element on the *same* document when the document is
destroyed.

* fast/dom/resources/frame-with-throttled-timer-animating-element-other-document.html: Renamed from LayoutTests/fast/dom/resources/frame-with-throttled-timer.html.
* fast/dom/resources/frame-with-throttled-timer-animating-element-same-document.html: Added.
* fast/dom/throttled-timer-running-on-document-destruction.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL build fix since r176459.
gyuyoung.kim@samsung.com [Sat, 22 Nov 2014 03:27:53 +0000 (03:27 +0000)]
Unreviewed, EFL build fix since r176459.

r176459 removed Timer parameter in timer callbacks only for Mac port.
So this patch applies it to remaining classes for EFL port.

Source/WebCore:

No new tests, fix build break.

* Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::RTCDTMFSender):
* Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::RTCDataChannel):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
* Modules/vibration/Vibration.cpp:
(WebCore::Vibration::Vibration):
(WebCore::Vibration::timerFired):
* Modules/vibration/Vibration.h:
* bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
* platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::timerFired):
* platform/efl/BatteryProviderEfl.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
* platform/graphics/texmap/coordinated/CompositingCoordinator.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::CoordinatedImageBacking):
(WebCore::CoordinatedImageBacking::clearContentsTimerFired):
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
* platform/mock/DeviceMotionClientMock.cpp:
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::timerFired):
* platform/mock/DeviceMotionClientMock.h:
* platform/mock/TimerEventBasedMock.h:
(WebCore::TimerEvent::TimerEvent):
(WebCore::TimerEvent::timerFired):

Source/WebKit2:

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
* UIProcess/API/efl/EwkView.h:
* UIProcess/efl/TextCheckerClientEfl.cpp:
(TextCheckerClientEfl::TextCheckerClientEfl):
(TextCheckerClientEfl::languagesUpdateTimerFired):
(TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):
* UIProcess/efl/TextCheckerClientEfl.h:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStart using the new :not() and :matches() in the Web Inspector
benjamin@webkit.org [Sat, 22 Nov 2014 02:06:47 +0000 (02:06 +0000)]
Start using the new :not() and :matches() in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=138978

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-21
Reviewed by Joseph Pecoraro.

Source/WebCore:

There are only minor pending issues on :not() and :matches(). The feedback
has only been positive so far. It is time to move them out the experimental
flag.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::detectFunctionTypeToken):
* css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificityInternal):
(WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
(WebCore::appendSelectorList):
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::determineLinkMatchType):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):

Source/WebInspectorUI:

Start simpifying some definitions by using modern CSS.

* UserInterface/Views/CSSStyleDeclarationSection.css:
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
(.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
(.style-declaration-section.selector-locked > .header > .selector): Deleted.
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.
* UserInterface/Views/ControlToolbarItem.css:
(.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
(.toolbar.icon-only .item.control): Deleted.
* UserInterface/Views/DOMStorageContentView.css:
* UserInterface/Views/DashboardContainerView.css:
(.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
(.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
(.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
(.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
(.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.
* UserInterface/Views/DataGrid.css:
(.data-grid :matches(th, td):not(:last-child)):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(.data-grid :matches(th, td) > div):
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid tr:matches(.selected, :hover) .go-to-arrow):
(.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
(.data-grid :-webkit-any(th, td) > div): Deleted.
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
(.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.
* UserInterface/Views/DebuggerDashboardView.css:
(.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
(.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.
* UserInterface/Views/DefaultDashboardView.css:
(body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
(body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
(.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
(body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
(body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
(.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
(.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
* UserInterface/Views/DetailsSection.css:
(.details-section > .header > :matches(.node-link, .go-to-arrow)):
(.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
(body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
(.details-section > .content > .group > .row:matches(.empty, .text)):
(body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
(.details-section > .header > .go-to-arrow): Deleted.
(.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
(body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
(.details-section > .content > .group > .row.text): Deleted.
(body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.
* UserInterface/Views/FindBanner.css:
(:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
(.supports-find-banner.no-find-banner-transition): Deleted.
* UserInterface/Views/FlexibleSpaceNavigationItem.css:
(:matches(.navigation-bar, .toolbar) .item.flexible-space):
(.toolbar .item.flexible-space): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThere should be a way to associate bugs with analysis tasks
rniwa@webkit.org [Sat, 22 Nov 2014 02:06:00 +0000 (02:06 +0000)]
There should be a way to associate bugs with analysis tasks
https://bugs.webkit.org/show_bug.cgi?id=138977

Reviewed by Benjamin Poulain.

Updated associate-bug.php to match the new database schema.

* public/include/json-header.php:
(require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
already camel-cased in require_existence_of. This makes the function usable elsewhere.

* public/privileged-api/associate-bug.php:
(main): Changed the API to take run, bugTracker, and number to match the new database schema.
Also verify that those values are integers using require_format.

* public/v2/analysis.js:
(App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
(App.Bug.label): Added.
(App.BugAdapter): Added.
(App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
(App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.

* public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
containing the bug information.

* public/v2/app.js:
(App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
(App.AnalysisTaskRoute):
(App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
(App.AnalysisTaskController._fetchedManifest): Added.
(App.AnalysisTaskController.actions.associateBug): Added.

* public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.

* public/v2/data.js:
(Measurement.prototype.associateBug): Deleted.

* public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
Added a table show the bug information. Also hide the chart until chartData is available.

* public/v2/manifest.js:
(App.Model): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, iOS build fix after r176462.
cdumez@apple.com [Sat, 22 Nov 2014 01:43:07 +0000 (01:43 +0000)]
Unreviewed, iOS build fix after r176462.

Source/WebCore:

Export a few extra symbols.

* WebCore.exp.in:

Source/WebKit2:

Fix include path to TextIndicator.h to include WebCore/
as it was moved.

* UIProcess/ios/PageClientImplIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoProperties in CSSPropertyNames.in should use the new StyleBuilder by default
cdumez@apple.com [Sat, 22 Nov 2014 01:26:46 +0000 (01:26 +0000)]
Properties in CSSPropertyNames.in should use the new StyleBuilder by default
https://bugs.webkit.org/show_bug.cgi?id=138983

Reviewed by Andreas Kling.

This patch makes using the new StyleBuilder the default and drops the
[NewStyleBuilder] option as a result. A new [LegacyStyleBuilder] option
is introduced for CSS properties that are not generated in the new
StyleBuilder yet.

* css/CSSPropertyNames.in:
* css/SVGCSSPropertyNames.in:
* css/makeprop.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176491 268f45cc-cd09-0410-ab3c-d52691b4dbfc