WebKit-https.git
11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 07:42:33 +0000 (07:42 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Remove use of os.system to fix reviewers with unicode chars in their names
        https://bugs.webkit.org/show_bug.cgi?id=26713

        Also change to latin1 encoding of ø to make python happy.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 07:06:50 +0000 (07:06 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Add Adam Roben and Tor Arne Vestbø to the reviewers list.

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jeremy Orlow <jorlow@chromium.org>
darin@chromium.org [Thu, 25 Jun 2009 06:16:34 +0000 (06:16 +0000)]
2009-06-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26698

        Combined LocalStorageArea and SessionStorageArea into StorageArea since
        (after my other refactorings) there are no longer substantial
        differences between the two.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        * storage/LocalStorageArea.cpp: Removed.
        * storage/LocalStorageArea.h: Removed.
        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):
        * storage/SessionStorage.h:
        * storage/SessionStorageArea.cpp: Removed.
        * storage/SessionStorageArea.h: Removed.
        * storage/StorageArea.cpp:
        (WebCore::StorageArea::createLocalStorage):
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::createSessionStorage):
        (WebCore::StorageArea::copy):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::clear):
        (WebCore::StorageArea::scheduleFinalSync):
        (WebCore::StorageArea::blockUntilImportComplete):
        (WebCore::StorageArea::dispatchStorageEvent):
        * storage/StorageArea.h:
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::scheduleFinalSync):
        (WebCore::StorageAreaSync::syncTimerFired):
        (WebCore::StorageAreaSync::performImport):
        * storage/StorageAreaSync.h:
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 25 Jun 2009 05:01:47 +0000 (05:01 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - fix <rdar://problem/7001817> REGRESSION (r41902): Base position track
          at UCSC Genome Browser doesn't work because image map prevents img
          from hit-testing

        Test: fast/replaced/image-map-2.html

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::nodeAtPoint): Do not reset 'inside' to false if
        the image map failed the hit test.

LayoutTests:

        Reviewed by Simon Fraser.

        - test for <rdar://problem/7001817> REGRESSION (r41902): Base position
          track at UCSC Genome Browser doesn't work because image map prevents
          img from hit-testing

        * fast/replaced/image-map-2-expected.txt: Added.
        * fast/replaced/image-map-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 25 Jun 2009 03:07:02 +0000 (03:07 +0000)]
2009-06-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Make the opcode sampler work once again.

        * jit/JIT.h:
        (JSC::JIT::compileGetByIdProto):
        (JSC::JIT::compileGetByIdSelfList):
        (JSC::JIT::compileGetByIdProtoList):
        (JSC::JIT::compileGetByIdChainList):
        (JSC::JIT::compileGetByIdChain):
        (JSC::JIT::compilePutByIdTransition):
        (JSC::JIT::compileCTIMachineTrampolines):
        (JSC::JIT::compilePatchGetArrayLength):
        * jit/JITStubCall.h:
        (JSC::JITStubCall::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Jun 2009 02:38:07 +0000 (02:38 +0000)]
2009-06-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26366

        Refactor V8DOMMap to support isolated worlds.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInNewWorld):
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap):
        (WebCore::DOMDataStore::allStores):
        (WebCore::DOMDataStore::allStoresMutex):
        (WebCore::DOMDataStore::domData):
        (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
        (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
        (WebCore::StaticDOMDataStore::StaticDOMDataStore):
        (WebCore::):
        (WebCore::MainThreadDOMData::MainThreadDOMData):
        (WebCore::MainThreadDOMData::getStore):
        (WebCore::ChildThreadDOMData::ChildThreadDOMData):
        (WebCore::ChildThreadDOMData::getStore):
        (WebCore::DOMDataStore::DOMDataStore):
        (WebCore::DOMDataStore::~DOMDataStore):
        (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
        (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
        (WebCore::::forget):
        (WebCore::getDOMNodeMap):
        (WebCore::getDOMObjectMap):
        (WebCore::getActiveDOMObjectMap):
        (WebCore::getDOMSVGElementInstanceMap):
        (WebCore::getDOMSVGObjectWithContextMap):
        (WebCore::DOMData::getCurrent):
        (WebCore::DOMData::handleWeakObject):
        (WebCore::DOMData::ensureDeref):
        (WebCore::weakDOMObjectCallback):
        (WebCore::weakActiveDOMObjectCallback):
        (WebCore::weakNodeCallback):
        (WebCore::weakSVGElementInstanceCallback):
        (WebCore::weakSVGObjectWithContextCallback):
        (WebCore::DOMData::derefObject):
        (WebCore::DOMData::derefDelayedObjects):
        (WebCore::DOMData::derefDelayedObjectsInCurrentThread):
        (WebCore::DOMData::removeObjectsFromWrapperMap):
        (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
        (WebCore::visitDOMNodesInCurrentThread):
        (WebCore::visitDOMObjectsInCurrentThread):
        (WebCore::visitActiveDOMObjectsInCurrentThread):
        (WebCore::visitDOMSVGElementInstancesInCurrentThread):
        (WebCore::visitSVGObjectsInCurrentThread):
        * bindings/v8/V8DOMMap.h:
        (WebCore::DOMDataStoreHandle::getStore):
        * bindings/v8/V8IsolatedWorld.cpp: Added.
        (WebCore::getIsolatedWorldKey):
        (WebCore::contextWeakReferenceCallback):
        (WebCore::V8IsolatedWorld::evaluate):
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
        (WebCore::V8IsolatedWorld::getEntered):
        * bindings/v8/V8IsolatedWorld.h: Added.
        (WebCore::V8IsolatedWorld::getDOMDataStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 25 Jun 2009 01:52:46 +0000 (01:52 +0000)]
2009-06-24  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Bug 26604: Search doesn't work in Web Inspector Profiler
        https://bugs.webkit.org/show_bug.cgi?id=26604

        Seems like search was damaged in revision 42808.

        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.prototype.refresh):
        Here and in other functions: nodes we're searching in are profile data grid
        nodes, so there is no more need for '_dataGridNode' references.
        (WebInspector.ProfileView.prototype.searchCanceled):
        (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
        Fixed accidental semicolon that caused 'matchesQuery' always return true.
        (WebInspector.ProfileView.prototype.performSearch):
        To perform search correctly in the case of bottom up tree, we need to populate
        the tree, because there's no 1-to-1 correspondence between profile nodes and
        data grid nodes in this case.
        (WebInspector.ProfileView.prototype._jumpToSearchResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Thu, 25 Jun 2009 01:32:26 +0000 (01:32 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid
        unnecessary WTF:: usings.
        Remove existing unnecessary WTF:: usings.

        * interpreter/Interpreter.h:
        * profiler/CallIdentifier.h:
        * runtime/ScopeChain.h:
        * wtf/FastAllocBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 25 Jun 2009 01:07:08 +0000 (01:07 +0000)]
2009-06-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6450239&6574516>

        Fix flashing issues caused by compositing layers rendering content before
        a deferred layout has happened. Because the -viewWillDraw machinery doesn't
        work for composited layers, we need to use scheduleViewUpdate() to queue
        up a layout via the run loop observer in WebKit, whenever we know we
        are going to be painting soon.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::setContentsNeedDisplay):
        (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
levin@chromium.org [Thu, 25 Jun 2009 00:45:37 +0000 (00:45 +0000)]
JavaScriptCore:

2009-06-24  David Levin  <levin@chromium.org>

        Fix all builds.

        * bytecode/CodeBlock.h:
        * bytecompiler/BytecodeGenerator.h:
        * interpreter/Register.h:

WebCore:

2009-06-24  David Levin  <levin@chromium.org>

        Fix all builds.

        * ForwardingHeaders/wtf/FastAllocBase.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jeremy Orlow <jorlow@chromium.org>
darin@chromium.org [Wed, 24 Jun 2009 23:56:01 +0000 (23:56 +0000)]
2009-06-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26658

        Split the syncing portions of LocalStorageArea into StorageAreaSync.
        This name will make more sense in the next patch (in this set) when
        LocalStorageArea and SessionStorageArea are merged to become simply
        StorageArea.  (Thus the synching portion of StorageArea is in
        StorageAreaSync.)

        This looks like a big patch, but really all it's doing is splitting
        code and patching split-related things up.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::create):
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::scheduleFinalSync):
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::areaCleared):
        (WebCore::LocalStorageArea::blockUntilImportComplete):
        * storage/LocalStorageArea.h:
        * storage/LocalStorageTask.cpp:
        (WebCore::LocalStorageTask::LocalStorageTask):
        * storage/LocalStorageTask.h:
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        * storage/LocalStorageThread.h:
        * storage/SessionStorageArea.cpp:
        (WebCore::SessionStorageArea::blockUntilImportComplete):
        * storage/SessionStorageArea.h:
        * storage/StorageArea.h:
        * storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
        * storage/StorageAreaSync.h: Copied from WebCore/storage/LocalStorageArea.h.
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::scheduleImport):
        (WebCore::StorageSyncManager::scheduleSync):
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:55:57 +0000 (23:55 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=26677

        Inherits CodeBlock class from FastAllocBase because it
        has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.

        * bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:55:11 +0000 (23:55 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=26676

        Inherits BytecodeGenerator class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.

        * bytecompiler/BytecodeGenerator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:54:25 +0000 (23:54 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=26675

        Inherits Register class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.

        * interpreter/Register.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:53:36 +0000 (23:53 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26674

        Inherits HashMap class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.

        * wtf/HashMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 24 Jun 2009 23:32:15 +0000 (23:32 +0000)]
2009-06-24  Adam Treat  <adam.treat@torchmobile.com>

        Fix Qt build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix for fallout from
cfleizach@apple.com [Wed, 24 Jun 2009 23:00:47 +0000 (23:00 +0000)]
Windows build fix for fallout from

Bug 26668: AX: need a way to retrieve the language for an element

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 24 Jun 2009 22:47:45 +0000 (22:47 +0000)]
2009-06-24  David Levin  <levin@chromium.org>

        Reviewed by David Hyatt.

        Bug 26696: Member functions in DataGridColumnList should return pointers instead of PassRefPtr.
        https://bugs.webkit.org/show_bug.cgi?id=26696

        * html/DataGridColumnList.cpp:
        (WebCore::DataGridColumnList::itemWithName):
        (WebCore::DataGridColumnList::add):
        * html/DataGridColumnList.h:
        (WebCore::DataGridColumnList::item):
        (WebCore::DataGridColumnList::primaryColumn):
        (WebCore::DataGridColumnList::sortColumn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 24 Jun 2009 22:19:16 +0000 (22:19 +0000)]
2009-06-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave "Messy" Hyatt.

        Little bit of style cleanup.

        * html/DataGridColumn.cpp:
        * html/DataGridColumn.h:
        * html/DataGridColumn.idl:
        * html/DataGridColumnList.cpp:
        * html/DataGridColumnList.h:
        * html/DataGridColumnList.idl:
        * html/HTMLDataGridCellElement.cpp:
        * html/HTMLDataGridCellElement.h:
        * html/HTMLDataGridCellElement.idl:
        * html/HTMLDataGridColElement.cpp:
        * html/HTMLDataGridColElement.h:
        * html/HTMLDataGridColElement.idl:
        * html/HTMLDataGridElement.h:
        * html/HTMLDataGridElement.idl:
        * html/HTMLDataGridRowElement.cpp:
        * html/HTMLDataGridRowElement.h:
        * html/HTMLDataGridRowElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 26668: AX: need a way to retrieve the language for an element
cfleizach@apple.com [Wed, 24 Jun 2009 22:14:58 +0000 (22:14 +0000)]
Bug 26668: AX: need a way to retrieve the language for an element
https://bugs.webkit.org/show_bug.cgi?id=26668

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 24 Jun 2009 22:04:40 +0000 (22:04 +0000)]
2009-06-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6893811> Instead of downloading files linked from Google Earth, file contents displayed in browser window as text.

        * platform/network/mac/WebCoreURLResponse.mm:
        (createBinaryExtensionsSet): Add '.kmz' to the list of known-to-be-binary extensions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanne...
oliver@apple.com [Wed, 24 Jun 2009 22:01:34 +0000 (22:01 +0000)]
<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'

Reviewed by Darin Adler.

The problem was caused by the page returned with a function using a
var declaration list containing around ~3000 variables.  The solution
to this is to flatten the comma expression representation and make
codegen comma expressions and initializer lists iterative rather than
recursive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRephrased change log
mitz@apple.com [Wed, 24 Jun 2009 21:12:17 +0000 (21:12 +0000)]
Rephrased change log

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Nicolas Weber <thakis@chromium.org>
eric@webkit.org [Wed, 24 Jun 2009 21:10:18 +0000 (21:10 +0000)]
2009-06-24  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26685
        Accomodate for backwards-incompatible skia api changes.

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::clearRect):
        (WebCore::GraphicsContext::setCompositeOperation):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::paintSkBitmap):
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::setupPaintCommon):
        (PlatformContextSkia::setXfermodeMode):
        (PlatformContextSkia::applyClipFromImage):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/skia/SkiaUtils.cpp:
        (WebCore::):
        (WebCore::WebCoreCompositeToSkiaComposite):
        * platform/graphics/skia/SkiaUtils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Wed, 24 Jun 2009 21:05:05 +0000 (21:05 +0000)]
    Reviewed by Anders Carlsson.

        Fix the most recently seen kind of crash seen in
        <rdar://problem/5983224>

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Null-check the
        Frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 24 Jun 2009 20:51:44 +0000 (20:51 +0000)]
2009-06-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Add files that were added in r45093 and r45096

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 24 Jun 2009 20:33:51 +0000 (20:33 +0000)]
2009-06-24  Brady Eidson  <beidson@apple.com>

        Fix 64-bit SnowLeopard build.

        * html/DataGridColumnList.cpp:
        (WebCore::DataGridColumnList::remove):
        (WebCore::DataGridColumnList::move):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Mac build.
hyatt@apple.com [Wed, 24 Jun 2009 20:06:51 +0000 (20:06 +0000)]
Fix Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Niko.
rwlbuis@webkit.org [Wed, 24 Jun 2009 19:44:45 +0000 (19:44 +0000)]
    Reviewed by Niko.

        https://bugs.webkit.org/show_bug.cgi?id=26392
        Bug 26392: In html, modification of xlink:href of an newly inserted svg image does not work.
        https://bugs.webkit.org/show_bug.cgi?id=26328
        Bug 26328: changing href attribute of svg images dows not work when changing display attribute as well

        React to href updates even when there is no renderer, i.e. display=none.

        Tests: svg/custom/js-update-image-and-display.svg
               svg/custom/js-update-image-and-display2.svg
               svg/custom/js-update-image-and-display3.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Windows test results for a couple of search field tests
mitz@apple.com [Wed, 24 Jun 2009 19:41:46 +0000 (19:41 +0000)]
Add Windows test results for a couple of search field tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Wed, 24 Jun 2009 19:22:12 +0000 (19:22 +0000)]
WebCore:

2009-06-24  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26687

        Add basic back-end column support to datagrid.

        Added fast/dom/HTMLDataGridElement/ column tests.

        * DerivedSources.cpp:
        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/DataGridColumn.cpp: Added.
        (WebCore::DataGridColumn::setPrimary):
        * html/DataGridColumn.h: Added.
        (WebCore::DataGridColumn::create):
        (WebCore::DataGridColumn::id):
        (WebCore::DataGridColumn::setId):
        (WebCore::DataGridColumn::label):
        (WebCore::DataGridColumn::setLabel):
        (WebCore::DataGridColumn::type):
        (WebCore::DataGridColumn::setType):
        (WebCore::DataGridColumn::sortable):
        (WebCore::DataGridColumn::setSortable):
        (WebCore::DataGridColumn::sortDirection):
        (WebCore::DataGridColumn::setSortDirection):
        (WebCore::DataGridColumn::primary):
        (WebCore::DataGridColumn::detachFromColumnList):
        (WebCore::DataGridColumn::DataGridColumn):
        * html/DataGridColumn.idl: Added.
        * html/DataGridColumnList.cpp: Added.
        (WebCore::DataGridColumnList::~DataGridColumnList):
        (WebCore::DataGridColumnList::itemWithName):
        (WebCore::DataGridColumnList::add):
        (WebCore::DataGridColumnList::remove):
        (WebCore::DataGridColumnList::move):
        (WebCore::DataGridColumnList::clear):
        (WebCore::DataGridColumnList::primaryColumnChanged):
        * html/DataGridColumnList.h: Added.
        (WebCore::DataGridColumnList::create):
        (WebCore::DataGridColumnList::length):
        (WebCore::DataGridColumnList::item):
        (WebCore::DataGridColumnList::primaryColumn):
        (WebCore::DataGridColumnList::sortColumn):
        * html/DataGridColumnList.idl: Added.
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::sortable):
        (WebCore::HTMLDataGridColElement::setSortable):
        (WebCore::HTMLDataGridColElement::sortDirection):
        (WebCore::HTMLDataGridColElement::setSortDirection):
        * html/HTMLDataGridColElement.h:
        * html/HTMLDataGridColElement.idl:
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::HTMLDataGridElement):
        * html/HTMLDataGridElement.h:
        (WebCore::HTMLDataGridElement::columns):
        * html/HTMLDataGridElement.idl:
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::paintObject):
        (WebCore::RenderDataGrid::paintColumnHeaders):
        (WebCore::RenderDataGrid::rebuildColumns):
        * rendering/RenderDataGrid.h:
        (WebCore::RenderDataGrid::gridElement):

LayoutTests:

2009-06-24  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        Add test for https://bugs.webkit.org/show_bug.cgi?id=26687.

        * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Added.
        * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jessie Berlin <jberlin@apple.com>
jberlin@apple.com [Wed, 24 Jun 2009 17:29:05 +0000 (17:29 +0000)]
2009-06-24  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Adam Roben.

        Partially fixes: https://bugs.webkit.org/show_bug.cgi?id=24735
        (<rdar://problem/5015942>)
        Where on windows it was not possible to set an element as the drag
        image using setDragImage on the dataTransfer object.

        Does not "fix" the case of dragging a link where the default link image
        is still used, even when the -webkit-user-drag is set to "element". This
        is the same behavior as is found on OS X.

        Added a manual test because it is not possible to check that what is
        contained in the image snapshot is indeed the requested element.

        * dom/Clipboard.h:
        (WebCore::Clipboard::dragImageElement):
        Made getting the raw pointer from the RefPtr a const operation.
        * manual-tests/drag-with-div-or-image-as-data-image.html: Added.
        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::createDragImage):
        Get an image of the rendered element and its subtree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 24 Jun 2009 16:48:52 +0000 (16:48 +0000)]
2009-06-24  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26683
        Fix Chromium build bustage: Add custom binding for HTMLDataGridElement.dataSource

        This change just adds a stub implementation for now to help fix the build.

        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)
ddkilzer@apple.com [Wed, 24 Jun 2009 15:53:51 +0000 (15:53 +0000)]
    Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)

        Reviewed by Adam Roben.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::deliverNotification): Removed
        ExceptionCode parameter from togglePlayState().
        (WebCore::HTMLMediaElement::initialURL): Don't convert a KURL
        object to a String when assigning to a KURL variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Treat.
zimmermann@webkit.org [Wed, 24 Jun 2009 15:00:34 +0000 (15:00 +0000)]
Reviewed by Adam Treat.

Save memory by not storing attribute values in member variables, if not absolutely needed.
Also fixes bugs where we're substituting variables too early (noticeable with the upcoming <select> element).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Wed, 24 Jun 2009 14:35:25 +0000 (14:35 +0000)]
Reviewed by Adam Roben.
Forgot to initialize m_task member variable. Results in crashes sometimes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Forgot to include within last patch.
zimmermann@webkit.org [Wed, 24 Jun 2009 14:34:50 +0000 (14:34 +0000)]
Not reviewed. Forgot to include within last patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Nikolas Zimmermann.
zimmermann@webkit.org [Wed, 24 Jun 2009 14:30:45 +0000 (14:30 +0000)]
Reviewed by Nikolas Zimmermann.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26474
Adding WML <card> title attribute handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>
zecke@webkit.org [Wed, 24 Jun 2009 14:02:16 +0000 (14:02 +0000)]
2009-06-24  Jiahua Huang  <jhuangjiahua@gmail.com>

        Reviewed by Holger Freyther.

        [Gtk] Add Undo/Redo support to WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=26573

        Implement EditorClient::undo and other interested funcs.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::registerCommandForUndo):
        (WebKit::EditorClient::registerCommandForRedo):
        (WebKit::EditorClient::clearUndoRedoOperations):
        (WebKit::EditorClient::canUndo):
        (WebKit::EditorClient::canRedo):
        (WebKit::EditorClient::undo):
        (WebKit::EditorClient::redo):
        (WebKit::EditorClient::EditorClient):
        * WebCoreSupport/EditorClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 24 Jun 2009 10:00:56 +0000 (10:00 +0000)]
2009-06-24  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix the build without ENABLE_VIDEO.

        * html/CanvasRenderingContext2D.cpp: Add #if ENABLE guards.
        * html/CanvasRenderingContext2D.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTemporarily disable failing test
oliver@apple.com [Wed, 24 Jun 2009 09:26:45 +0000 (09:26 +0000)]
Temporarily disable failing test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 24 Jun 2009 08:56:20 +0000 (08:56 +0000)]
2009-06-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        Add new drag tests to the Skipped lists for non-mac platforms.

        Skipped tests:
        fast/events/drag-to-navigate.html
        fast/events/prevent-drag-to-navigate.html

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 08:15:16 +0000 (08:15 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=26645

        Inherits ScopeChainNode class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/ScopeChain.h:95.

        * wtf/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Siddhartha Chattopadhyay <sidchat@google.com>
eric@webkit.org [Wed, 24 Jun 2009 08:12:12 +0000 (08:12 +0000)]
2009-06-24  Siddhartha Chattopadhyay  <sidchat@google.com>

        Reviewed by Eric Seidel.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
        the smartReplace set TRUE initially, which was wrong since the purpose of this call is
        to just replace the selection, and place the caret at the end of the selection it replaced.

        * editing/Editor.cpp:
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        * manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jeff Johnson <opendarwin@lapcatsoftware.com>
eric@webkit.org [Wed, 24 Jun 2009 08:00:10 +0000 (08:00 +0000)]
2009-06-24  Jeff Johnson  <opendarwin@lapcatsoftware.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26638 WebKitErrors.m: _initWithPluginErrorCode: does not set localizedDescription

        Add localized descriptions for plugin errors.
        The localized strings already existed but were unused; now NSLocalizedDescriptionKey is added to the NSError userInfo.

        * Misc/WebKitErrors.m:
        (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 07:54:58 +0000 (07:54 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26648

        Inherits Deque class from FastAllocBase because it has been
        instantiated by 'new' with DEFINE_STATIC_LOCAL macro in
        JavaScriptCore/wtf/MainThread.cpp:62.

        * wtf/Deque.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 07:53:10 +0000 (07:53 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26644

        Inherits RefPtr class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/StructureChain.cpp:41.

        * wtf/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempting to make test more reliable.
oliver@apple.com [Wed, 24 Jun 2009 07:52:19 +0000 (07:52 +0000)]
Attempting to make test more reliable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Kevin Watters <kevinwatters@gmail.com>
eric@webkit.org [Wed, 24 Jun 2009 07:47:24 +0000 (07:47 +0000)]
2009-06-24  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Kevin Ollivier.

        Don't use an unsigned int for intervalInMS because we sometimes initialize
        it with a negative value.

        * platform/wx/SharedTimerWx.cpp:
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 07:45:11 +0000 (07:45 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Inherits HashSet class from FastAllocBase, because it has been
        instantiated by 'new' in JavaScriptCore/runtime/Collector.h:116.

        * wtf/HashSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 07:40:13 +0000 (07:40 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Inherits Vector class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:633.

        * wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 24 Jun 2009 07:34:05 +0000 (07:34 +0000)]
2009-06-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        Spell Maciej's name right and add Brady Eidson.

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Norbert Leser <norbert.leser@nokia.com>
eric@webkit.org [Wed, 24 Jun 2009 07:26:58 +0000 (07:26 +0000)]
2009-06-24  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Maciej Stachoviak.

        The BytecodeGenerator objects were instantiated on stack, which takes up ~38kB per instance
        (each instance includes copy of JSC::CodeBlock with large SymbolTable, etc.).
        Specifically, since there is nested invocation (e.g., GlobalCode --> FunctionCode),
        the stack overflows immediately on Symbian hardware (max. 80 kB).
        Proposed change allocates generator objects on heap.
        Performance impact (if any) should be negligible and change is proposed as general fix,
        rather than ifdef'd for SYMBIAN.

        * parser/Nodes.cpp:
        (JSC::ProgramNode::generateBytecode):
        (JSC::EvalNode::generateBytecode):
        (JSC::EvalNode::bytecodeForExceptionInfoReparse):
        (JSC::FunctionBodyNode::generateBytecode):
        (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 24 Jun 2009 07:20:49 +0000 (07:20 +0000)]
2009-06-24  Eric Seidel  <eric@webkit.org>

        No review, build fix only.

        The previous checkin had an improper merge.  This fixes the build.

        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 24 Jun 2009 07:07:46 +0000 (07:07 +0000)]
2009-06-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=25922
        Fix dropEffect = "none" to work as expected.

        * fast/events/drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
        * fast/events/drag-to-navigate.html: Added.
        * fast/events/prevent-drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
        * fast/events/prevent-drag-to-navigate.html: Added.
        * fast/events/resources/file-for-drag-to-navigate.html: Added.
        * fast/events/resources/file-for-prevent-drag-to-navigate.html: Added.

2009-06-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=25922
        JS setting dropEffect = "none" causes tryDHTMLDrag
        to return DragOperationNone.  Which is also the value
        tryDHTMLDrag previously used to indicate JS did not
        want to handle the drag.

        Make it possible for the DragController::try* methods
        to return a bool to indicate if javascript accepted
        or rejected the drag event, separate from the DragOperation.

        Tests:
        - fast/events/drag-to-navigate.html
        - fast/events/prevent-drag-to-navigate.html

        * page/DragController.cpp:
        (WebCore::DragController::dragEnteredOrUpdated):
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::defaultOperationForDrag):
        (WebCore::DragController::tryDHTMLDrag):
        * page/DragController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd expected results for test i landed earlier
oliver@apple.com [Wed, 24 Jun 2009 06:40:44 +0000 (06:40 +0000)]
Add expected results for test i landed earlier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 24 Jun 2009 06:26:04 +0000 (06:26 +0000)]
2009-06-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Dave Levin.

        Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
        https://bugs.webkit.org/show_bug.cgi?id=26669

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6164797> Add Canvas API to allow drawing of <video> frames
oliver@apple.com [Wed, 24 Jun 2009 06:19:31 +0000 (06:19 +0000)]
<rdar://problem/6164797> Add Canvas API to allow drawing of <video> frames
<https://bugs.webkit.org/show_bug.cgi?id=25920>

Reviewed by Sam Weinig and Dave Hyatt.

Add support for drawing the contents of the video element to the canvas
in accordance with the current HTML5 draft.

Test: media/video-canvas.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases...
oliver@apple.com [Wed, 24 Jun 2009 02:47:48 +0000 (02:47 +0000)]
<rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
<https://bugs.webkit.org/show_bug.cgi?id=26593>

Reviewed by Gavin Barraclough.

Add tests to ensure we correctly invalidate caching that depends on structure chains
that include dictionaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Adam Langley <agl@google.com>
agl@chromium.org [Wed, 24 Jun 2009 02:41:23 +0000 (02:41 +0000)]
2009-06-23  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Chromium: Fix crash with inherited font-size in <option>

        https://bugs.webkit.org/show_bug.cgi?id=26656
        http://code.google.com/p/chromium/issues/detail?id=14853

        In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed
        the <select> handing for Chromium to fix a rendering bug. However,
        although the font-size is correctly ignored, getRowHeight wasn't
        updated and so was calculating the height of the rows in an
        inconsistent manner. This can lead to a crash.

        * manual-tests/optgroup-empty-and-nested.html: adding test case for crash
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::getRowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Takeshi Yoshino <tyoshino@google.com>
eric@webkit.org [Wed, 24 Jun 2009 01:50:20 +0000 (01:50 +0000)]
2009-06-23  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Mark Rowe.

        Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
        https://bugs.webkit.org/show_bug.cgi?id=26537

        Let determineBaseProductDir subroutine remove
        ~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
        respecting global settings such as a custom build products directory
        (<rdar://problem/5585899>).

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 24 Jun 2009 01:49:48 +0000 (01:49 +0000)]
2009-06-23  Brady Eidson  <beidson@apple.com>

        Patch by Antti Koivisto.
        Reviewed by Brady Eidson.

        <rdar://problem/6988010> Failed resources not reloaded when built against Tiger SDK

        A latent bug that cache revalidation uncovered.  When a CachedResource failed to load,
        it should always be revalidated upon reload.

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::canUseCacheValidator):
        (WebCore::CachedResource::mustRevalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 24 Jun 2009 01:33:14 +0000 (01:33 +0000)]
2009-06-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mark Rowe.

        Resets the results for a test that was missed in
        http://trac.webkit.org/changeset/45016.

        * editing/execCommand/5142012-3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 24 Jun 2009 01:31:28 +0000 (01:31 +0000)]
2009-06-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Dave Levin.

        Make SCM.run_command smarter, and make all previous
        os.system and subprocess.popen use SCM.run_command instead.
        https://bugs.webkit.org/show_bug.cgi?id=26666

        This makes it easier to handle errors in a standard way throughout all the code.
        Since this new code raises by default when the exit_code != 0,
        we should prevent future problems of bugzilla-tool continuing after
        a git or svn command failed.

        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 24 Jun 2009 00:44:37 +0000 (00:44 +0000)]
2009-06-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load

        Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in
        iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
        calling back to a dealloc'ed object.

        * WebView/WebView.mm:
        (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization.
        (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto.
        (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6
        (-[WebView dealloc]): Release the delegate if the quirk is in effect.
        (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Wed, 24 Jun 2009 00:40:56 +0000 (00:40 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/6634228> Crash in [NSScroller mouseDown:] beneath
          EventHandler::passMouseDownEventToWidget()

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passMouseDownEventToWidget): Surround the
        -mouseDown: call with calls to Widget::beforeMouseDown() and
        Widget::afterMouseDown(), which prevent the widget's view hierarchy from
        being removed from its parent view while the scroller is tracking the
        mouse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Wed, 24 Jun 2009 00:39:02 +0000 (00:39 +0000)]
WebCore:

2009-06-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=26516
        Add initial implementation of DataGridDataSource

        - Initial implementation only supports the initialize callback function.

        Test: fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html

        * WebCore.xcodeproj/project.pbxproj:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSDataGridDataSource.cpp: Added.
        (WebCore::JSDataGridDataSource::JSDataGridDataSource):
        (WebCore::JSDataGridDataSource::~JSDataGridDataSource):
        (WebCore::JSDataGridDataSource::initialize):
        * bindings/js/JSDataGridDataSource.h: Added.
        (WebCore::JSDataGridDataSource::create):
        (WebCore::JSDataGridDataSource::isJSDataGridDataSource):
        (WebCore::JSDataGridDataSource::jsDataSource):
        (WebCore::asJSDataGridDataSource):
        * bindings/js/JSHTMLDataGridElementCustom.cpp: Added.
        (WebCore::JSHTMLDataGridElement::listener):
        (WebCore::JSHTMLDataGridElement::setListener):
        * html/DataGridDataSource.h: Added.
        (WebCore::DataGridDataSource::~DataGridDataSource):
        (WebCore::DataGridDataSource::isJSDataGridDataSource):
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::HTMLDataGridElement):
        (WebCore::HTMLDataGridElement::setDataSource):
        (WebCore::HTMLDataGridElement::initializationTimerFired):
        * html/HTMLDataGridElement.h:
        (WebCore::HTMLDataGridElement::dataSource):
        * html/HTMLDataGridElement.idl:

LayoutTests:

2009-06-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=26516
        Add initial implementation of DataGridDataSource

        * fast/dom/HTMLDataGridElement: Added.
        * fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Added.
        * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jparent@chromium.org [Tue, 23 Jun 2009 23:56:03 +0000 (23:56 +0000)]
WebCore:

2009-06-23  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Justin Garcia.

        Undo the changeset 21212 to fix the regression bug 14062.
        The changeset 21212 attempted to fix rdar://problem/5002441.
        The changeset 21212 modified InsertTextCommand::input so as to convert
        all spaces in text to non-breaking spaces for rdar://problem/5002441.
        However, the bug was originally caused by rebalanceWhitespaceAt
        and this workaround introduced a regression bug 14062.
        Because rebalanceWhitespaceAt appears to behave correctly now,
        the workaround introduced in 21212 is no longer needed.

        Test: editing/inserting/space-after-removeformat.html

        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):

LayoutTests:

2009-06-23  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Justin Garcia.

        Undo the changeset 21212 to fix the regression bug 14062.
        The changeset 21212 attempted to fix rdar://problem/5002441.
        The changeset 21212 modified InsertTextCommand::input so as to convert
        all spaces in text to non-breaking spaces for rdar://problem/5002441.
        However, the bug was originally caused by rebalanceWhitespaceAt
        and this workaround introduced a regression bug 14062.
        Because rebalanceWhitespaceAt appears to behave correctly now,
        the workaround introduced in 21212 is no longer needed.

        The following test cases are affected by this change.
        This patch removes unappropriate non-breaking spaces (&nbsp;) and
        inserts normal spaces instead.

        * editing/deleting/2610675-1-expected.txt: Replaced.
        * editing/deleting/2610675-2-expected.txt: Replaced.
        * editing/deleting/2610675-3-expected.txt: Replaced.
        * editing/inserting/insert-before-link-1-expected.txt: Replaced.
        * editing/inserting/space-after-removeformat-expected.txt: Added.
        * editing/inserting/space-after-removeformat.html: Added.
        * platform/mac/editing/execCommand/5482023-expected.checksum: Replaced.
        * platform/mac/editing/execCommand/5482023-expected.png: Replaced.
        * platform/mac/editing/execCommand/5482023-expected.txt: Replaced.
        * platform/mac/editing/input/text-input-controller-expected.txt: Replaced.
        * platform/mac/editing/inserting/editable-html-element-expected.checksum: Replaced.
        * platform/mac/editing/inserting/editable-html-element-expected.png: Replaced.
        * platform/mac/editing/inserting/editable-html-element-expected.txt: Replaced.
        * platform/mac/editing/pasteboard/4989774-expected.checksum: Replaced.
        * platform/mac/editing/pasteboard/4989774-expected.png: Replaced.
        * platform/mac/editing/pasteboard/4989774-expected.txt: Replaced.
        * platform/mac/editing/selection/4983858-expected.checksum: Replaced.
        * platform/mac/editing/selection/4983858-expected.png: Replaced.
        * platform/mac/editing/selection/4983858-expected.txt: Replaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Tue, 23 Jun 2009 23:42:49 +0000 (23:42 +0000)]
WebCore:

2009-06-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
        elements width can't be changed with javascript

        This patch both fixes setting the width attribute directly in
        JavaScript, and setting the width on the style attribute.

        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::parseMappedAttribute): If we have a
        new width, call setNeedsLayoutAndPrefWidthsRecalc()

        Call calcPrefWidths() on the table cols.
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):

        Call layoutIfNeeded on the table cols.
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout):

        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::clippedOverflowRectForRepaint): Use new
        table() convenience function.
        (WebCore::RenderTableCol::calcPrefWidths): Just call
        setPrefWidthsDirty(false) on ourself and our children.
        (WebCore::RenderTableCol::table):
        * rendering/RenderTableCol.h:

LayoutTests:

2009-06-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
        elements width can't be changed with javascript

        * fast/dom/HTMLTableColElement: Added.
        * fast/dom/HTMLTableColElement/resize-table-using-col-width.html: Added.
        * platform/mac/fast/dom/HTMLTableColElement: Added.
        * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
        * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
        * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ojan@chromium.org [Tue, 23 Jun 2009 23:35:24 +0000 (23:35 +0000)]
WebCore:

2009-06-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Dan Bernstein.

        Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
        keyword values. When diff is called on a CSSStyleDeclaration, we check
        the keywordSize to see if font-size matches a keyword value.

        This ensures that when we diff a CSSMutableStyleDeclaration returned from
        copyInheritableProperties on a CSSComputedStyleDeclaration that we
        correctly identify matching font-sizes.

        https://bugs.webkit.org/show_bug.cgi?id=26279

        Test: editing/inserting/font-size-clears-from-typing-style.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
        * css/CSSComputedStyleDeclaration.h:
        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::cssPropertyMatches):
        (WebCore::CSSStyleDeclaration::diff):
        * css/CSSStyleDeclaration.h:

LayoutTests:

2009-06-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Dan Bernstein.

        This test hits an edge case where typingStyle would never get cleared.
        In addition to making every text insertion go into its own text node,
        this caused large performance problems.

        https://bugs.webkit.org/show_bug.cgi?id=26279

        * editing/execCommand/5770834-1-expected.txt:
            These results match how they were before r43243. It's not clear to me
            why changes to font-size are affecting text-align styling though.
        * editing/inserting/font-size-clears-from-typing-style-expected.txt: Added.
        * editing/inserting/font-size-clears-from-typing-style.html: Added.
        * editing/inserting/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
        * editing/inserting/resources/font-size-clears-from-typing-style.js: Added.
        * platform/mac/editing/execCommand/remove-formatting-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Joe Mason <joe.mason@torchmobile.com>
treat@webkit.org [Tue, 23 Jun 2009 23:10:55 +0000 (23:10 +0000)]
2009-06-23  Joe Mason  <joe.mason@torchmobile.com>

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=26664
        * Scripts/prepare-ChangeLog: Added --git-index mode to list only the
        changes which are already staged in the index.  Useful to create an
        entry for what you're about to commit while ignoring unstaged changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Tue, 23 Jun 2009 23:06:36 +0000 (23:06 +0000)]
2009-06-23  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=26654
        Add the proper export define for the JavaScriptCore API when building for WINCE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 23 Jun 2009 22:38:57 +0000 (22:38 +0000)]
2009-06-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        - Fix <rdar://problem/6965672>

        Defer calls to WKPCInvalidateRect, so we don't try to invalidate while waiting for a reply, since
        that is too early.

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        (WebKit::NetscapePluginHostProxy::isProcessingRequests):
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        (WebKit::NetscapePluginHostProxy::processRequests):
        (WKPCInvalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Tue, 23 Jun 2009 22:25:06 +0000 (22:25 +0000)]
WebCore:

2009-06-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
        add a blank line to pasted Facebook content (under
        CompositeEditCommand::positionAvoidingSpecialElementBoundary)

        - Just added null checks and I will create a new bug to prevent the
        bad behavior.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):

LayoutTests:

2009-06-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
        add a blank line to pasted Facebook content (under
        CompositeEditCommand::positionAvoidingSpecialElementBoundary)

        * editing/inserting/return-with-object-element-expected.txt: Added.
        * editing/inserting/return-with-object-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 23 Jun 2009 21:48:15 +0000 (21:48 +0000)]
2009-06-23  Simon Fraser  <simon.fraser@apple.com>

        Build fix.

        Wrap shouldDoSoftwarePaint() in #if USE(ACCELERATED_COMPOSITING) to avoid warning when
        ACCELERATED_COMPOSITING is not defined.

        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 23 Jun 2009 21:25:11 +0000 (21:25 +0000)]
2009-06-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24863

        Fix reflection painting on elements with compositing layers.

        Test: compositing/reflections/reflection-on-composited.html

        * rendering/RenderLayer.h:
        Add a new PaintLayerPaintingReflection flag which is set while painting inside
        reflections.
        (WebCore::RenderLayer::setPaintingInsideReflection):
        Add a setter so that RenderLayerBacking can call it.

        * rendering/RenderLayer.cpp:
        (WebCore::shouldDoSoftwarePaint):
        Utility to clarify the logic of when a composited layer should do a software paint.

        (WebCore::RenderLayer::paintLayer):
        Use shouldDoSoftwarePaint() to determine when to software-paint a reflected layer.
        Remove transform-related tests from the reflection-painting if test because they appear
        to be unnecessary.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):
        Add the code to paint reflections to the composited layer painting method.

        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        Set the PaintLayerPaintingReflection flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
antti@apple.com [Tue, 23 Jun 2009 20:01:56 +0000 (20:01 +0000)]
WebCore:

2009-06-23  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26643
        Memory cache should respect Cache-Control: no-store

        Make resources with Cache-Control: no-store uncacheable in the memory cache.
        They get evicted immediately when all clients are gone and are always
        reloaded from the server.

        Conforms to RFC2616 14.9.2 and seems also match Firefox behavior.

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::removeClient):
        (WebCore::CachedResource::canUseCacheValidator):
        (WebCore::CachedResource::mustRevalidate):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::ResourceResponseBase):
        (WebCore::ResourceResponseBase::parseCacheControlDirectives):
        (WebCore::ResourceResponseBase::cacheControlContainsNoStore):
        * platform/network/ResourceResponseBase.h:

LayoutTests:

2009-06-23  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26643
        Memory cache should respect Cache-Control: no-store

        Update the test to cover no-store.

        * http/tests/cache/subresource-expiration-expected.txt:
        * http/tests/cache/subresource-expiration.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
beidson@apple.com [Tue, 23 Jun 2009 19:48:30 +0000 (19:48 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 23 Jun 2009 19:46:00 +0000 (19:46 +0000)]
2009-06-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        First part of https://bugs.webkit.org/show_bug.cgi?id=26652

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paint):
        (WebCore::RenderLayer::paintLayer):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        Replace the 3 boolean params to RenderLayer::paintLayer() with a bit mask for readability.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerBacking.h:
        Remove the unused 'haveTransparency' param to paintIntoLayer().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Tue, 23 Jun 2009 19:12:32 +0000 (19:12 +0000)]
WebCore:

2009-06-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
        after manually quoting blank line then hitting return

        If the insertion point is both the begining and ending visible position
        then we need to insert at the end instead of the begining, which is what
        would normally happen if the insertion point was as the begining.

        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):

LayoutTests:

2009-06-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
        after manually quoting blank line then hitting return

        * editing/inserting/insert-br-quoted-007-expected.txt: Added.
        * editing/inserting/insert-br-quoted-007.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 23 Jun 2009 19:05:30 +0000 (19:05 +0000)]
2009-06-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig, and looked over by Eric Carlson.

        <rdar://problem/6980466> Media elements should provide option for changing pitch correction

        Introduce a new boolean property to HTMLMediaElement called webkitPreservesPitch for script to control this.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Currently the platforms that have a flexible pitch preservation
          property (Quicktime on Mac and Win) have had it on by default, so continue that default for now.
        (WebCore::HTMLMediaElement::loadResource):
        (WebCore::HTMLMediaElement::webkitPreservesPitch):
        (WebCore::HTMLMediaElement::setWebkitPreservesPitch):
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::NullMediaPlayerPrivate::setPreservesPitch):
        (WebCore::MediaPlayer::MediaPlayer):
        (WebCore::MediaPlayer::preservesPitch):
        (WebCore::MediaPlayer::setPreservesPitch):
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::setPreservesPitch):

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::createQTMovie): Rework to allow recreation of the movie with almost the
          exact same attributes as before, with pitch preservation being the difference.
        (WebCore::MediaPlayerPrivate::setPreservesPitch): Recreate the QTMovie if the flag actually changes.
        (WebCore::MediaPlayerPrivate::updateStates): Restore current time and rate if this is a recreated movie.
        (WebCore::MediaPlayerPrivate::timeChanged): Clear the time-to-be-restored, as this callback means it
          has been effectively overwritten.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::setPreservesPitch):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWinPrivate::QTMovieWinPrivate):
        (QTMovieWinPrivate::~QTMovieWinPrivate):
        (QTMovieWinPrivate::task): Restore current time and rate if this is a re-created movie.
        (QTMovieWin::play): Clear the time-to-be-restored, as this effectively overwrites it.
        (QTMovieWin::pause): Ditto.
        (QTMovieWin::setRate): Ditto.
        (QTMovieWin::setCurrentTime): Ditto.
        (QTMovieWin::setPreservesPitch): Recreate the Movie if the flag actually changes.
        (QTMovieWin::load): Rework to allow recreation of the Movie with similar state as the movie before it,
          but changing the pitch preservation flag.
        * platform/graphics/win/QTMovieWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 23 Jun 2009 19:04:30 +0000 (19:04 +0000)]
2009-06-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6998286> Crash after leaving page with <video>

        Don't try to post events after going into the page cache.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::documentWillBecomeInactive): Cancel pending events and stop
        event timers so we won't try to post events after going into the cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Jeremy Orlow <jorlow@chromium.org>
darin@chromium.org [Tue, 23 Jun 2009 18:52:01 +0000 (18:52 +0000)]
2009-06-23  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Brady Eidson.

        Simplify the interaction between LocalStorageArea/SessionStorageArea
        and StorageArea by creating a "blockUntilImportComplete()" function
        rather than bouncing back and forth between the child and parent
        classes in a somewhat unintuitive manner.

        This patch also paves the way for LocalStorageArea and
        SessionStorageArea being merged into one.  It's part of several in a
        set which are separating syncing (to disk) code from the rest of the
        implementation so that local storage and session storage's code can be
        unified.

        https://bugs.webkit.org/show_bug.cgi?id=25376

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::blockUntilImportComplete):
        * storage/LocalStorageArea.h:
        * storage/StorageArea.cpp:
        (WebCore::StorageArea::length):
        (WebCore::StorageArea::key):
        (WebCore::StorageArea::getItem):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::clear):
        (WebCore::StorageArea::contains):
        * storage/StorageArea.h:
        (WebCore::StorageArea::blockUntilImportComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 23 Jun 2009 18:36:40 +0000 (18:36 +0000)]
2009-06-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6997929> Assertion at WebCore::RenderLayer::updateClipRects with hardware acceleration

        The updatingControlTints() painting pass goes through compositing layer boundaries,
        so we need to ensure we don't cache clip rects computed with the wrong root by
        setting temporaryClipRects to true.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
        Remove a printf that I left in by mistake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
andersca@apple.com [Tue, 23 Jun 2009 18:03:12 +0000 (18:03 +0000)]
WebCore:

2009-06-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        WebCore side of <rdar://problem/6946094>.

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::setExternalDataObject):
        * platform/win/ClipboardWin.h:

WebKit/win:

2009-06-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        WebKit side of <rdar://problem/6946094>.

        * Interfaces/IWebUIDelegate.idl:
        Add a newPasteboard out parameter to willPerformDragSourceAction.

        * WebCoreSupport/WebDragClient.cpp:
        (WebDragClient::willPerformDragSourceAction):
        Implement this. If the client returns a new pasteboard, use it for the drag.

        * WebCoreSupport/WebInspectorDelegate.h:
        (WebInspectorDelegate::willPerformDragSourceAction):
        Add the new parameter.

WebKitTools:

2009-06-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Update for WebKit changes.

        * DumpRenderTree/win/UIDelegate.h:
        (UIDelegate::willPerformDragSourceAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 23 Jun 2009 17:29:32 +0000 (17:29 +0000)]
2009-06-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26650

        Add setFormContentType and setFormData since it is awkward for Chromium
        to use setFormInfoFromRequest to set the underlying members.  Also, add
        a clearChildren method that Chromium needs.  These methods are used as
        part of the Chromium code that serializes a HistoryItem for storing in
        the browser's session history.

        * history/HistoryItem.cpp:
        * history/HistoryItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Joe Mason <joe.mason@torchmobile.com>
treat@webkit.org [Tue, 23 Jun 2009 15:45:12 +0000 (15:45 +0000)]
2009-06-23  Joe Mason  <joe.mason@torchmobile.com>

        Reviewed by Adam Treat.

        Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>

        https://bugs.webkit.org/show_bug.cgi?id=26611
        Implement currentThreadStackBase on WINCE by adding a global,
        g_stackBase, which must be set to the address of a local variable
        by the caller before calling any WebKit function that invokes JSC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 23 Jun 2009 15:44:53 +0000 (15:44 +0000)]
2009-06-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by NOBODY, layout tests fix.

        'timeupdate' events are, by definition, timing dependent so it isn't
        a good idea to log them in layout test results.

        * media/event-attributes-expected.txt:
        * media/event-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 23 Jun 2009 14:49:19 +0000 (14:49 +0000)]
2009-06-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6978938> Need HTML 5 event attributes for media elements

        Test: media/event-attributes.html

        * html/HTMLAttributeNames.in: Add media event attribute names.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::parseMappedAttribute): Handle media event attributes.

2009-06-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6978938> Need HTML 5 event attributes for media elements

        * media/event-attributes-expected.txt: Added.
        * media/event-attributes.html: Added.
        * media/progress-event-total.html: Cleanup, use event handler attributes.
        * media/progress-event.html: Ditto.

        * media/video-size-intrinsic-scale.html: Remove duplicate 'waitForEvent("ratechange")'
        * media/video-source-add-src.html: Ditto.
        * media/video-source-error.html: Ditto.
        * media/video-timeupdate-during-playback.html: Ditto.

        * platform/gtk/Skipped: Skip new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Thiago Macieira <thiago.macieira@nokia.com>
hausmann@webkit.org [Tue, 23 Jun 2009 13:03:59 +0000 (13:03 +0000)]
2009-06-23  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon Hausmann.

        Fix Qt build with Phonon.

        The #include <phonon> header no longer exists. And the <Phonon> or
        <Phonon/Phonon> headers have never existed (neither for us nor for the
        Phonon sources). You have to select each and every header that you do
        want now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 23 Jun 2009 12:43:47 +0000 (12:43 +0000)]
2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Remove duplicated code in Qt & GTK logging initialization

        We now share the getChannelFromName() function in Logging.cpp

        * platform/gtk/LoggingGtk.cpp:
        * platform/qt/LoggingQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 23 Jun 2009 12:43:32 +0000 (12:43 +0000)]
2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Rename the plugin logging channel to plural form 'Plugins'

        This matches both the other logging channel names, as well as the
        WebKit logging channel used by Safari/Mac for plugins.

        * platform/Logging.cpp:
        * platform/Logging.h:
        * platform/gtk/LoggingGtk.cpp:
        * platform/mac/LoggingMac.mm:
        * platform/qt/LoggingQt.cpp:
        * platform/win/LoggingWin.cpp:
        * plugins/PluginDebug.h:
        * plugins/gtk/PluginPackageGtk.cpp:
        * plugins/mac/PluginPackageMac.cpp:
        * plugins/mac/PluginViewMac.cpp:
        * plugins/qt/PluginPackageQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 23 Jun 2009 10:17:50 +0000 (10:17 +0000)]
2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Fix NPAPI mouse translation issues on Mac

        The WindowRef we pass to the plugin refers to the the top level window,
        so the x and y positions have to be relative to this position, but we
        have to manually compensate for title bar decorations and other parents
        of the QWebView since contentsToWindow() only traverses to the QWebView.

        Previously we did this compensation when passing on mouse coordinates to
        the plugin, which caused various issues with translations such as not
        being able to close the Flash settings dialog, or the hand cursor not
        appearing over links.

        We now do the compensation as part of the call to NPP_SetWindow, and
        then pass mouse coordinates in global context without any compensation,
        similar to how both Safari and Mozilla does it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 23 Jun 2009 10:11:47 +0000 (10:11 +0000)]
2009-06-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Resolve absolute path to library install_name manually

        Since our target.path is set to the Qt directory (to be able
        to do 'make install') the 'absolute_library_soname' option
        to QMake did not do the right thing.

        We now compute the absolute path manually using DESTDIR.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 23 Jun 2009 09:17:42 +0000 (09:17 +0000)]
2009-06-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26589

        More tests for the XSSAuditor.  (I converted the server side to Perl
        after Sam reviewed the patch because the PHP scripts didn't agree with
        the Tiger and Windows buildbots.)

        * http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
        * http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
        * http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
        * http/tests/security/xssAuditor/link-onclick.html: Added.
        * http/tests/security/xssAuditor/property-escape-expected.txt: Added.
        * http/tests/security/xssAuditor/property-escape.html: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
        * http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-property.pl: Added.
        * http/tests/security/xssAuditor/resources/redir.php: Added.
        * http/tests/security/xssAuditor/resources/xss.js: Added.
        * http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
        * http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
        * http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-post.html: Added.
        * http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-redirect.html: Added.
        * http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source.html: Added.
        * http/tests/security/xssAuditor/script-tag.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix stupid performance problem in the LiteralParser
oliver@apple.com [Tue, 23 Jun 2009 09:14:40 +0000 (09:14 +0000)]
Fix stupid performance problem in the LiteralParser

Reviewed by Alexey Proskuryakov.

The LiteralParser was making a new UString in order to use
toDouble, however UString's toDouble allows a much wider range
of numberic strings than the LiteralParser accepts, and requires
an additional heap allocation or two for the construciton of the
UString.  To rectify this we just call WTF::dtoa directly using
a stack allocated buffer to hold the validated numeric literal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert 44981. The buildbots hate me.
abarth@webkit.org [Tue, 23 Jun 2009 09:11:26 +0000 (09:11 +0000)]
Revert 44981.  The buildbots hate me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 23 Jun 2009 09:01:36 +0000 (09:01 +0000)]
2009-06-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        * Scripts/modules/scm.py: Fix commit_with_message to return the commit output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 23 Jun 2009 08:51:39 +0000 (08:51 +0000)]
2009-06-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26589

        More tests for the XSSAuditor.  (I converted the server side to Perl
        after Sam reviewed the patch because the PHP scripts didn't agree with
        the Tiger and Windows buildbots.)

        * http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
        * http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
        * http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
        * http/tests/security/xssAuditor/link-onclick.html: Added.
        * http/tests/security/xssAuditor/property-escape-expected.txt: Added.
        * http/tests/security/xssAuditor/property-escape.html: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
        * http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
        * http/tests/security/xssAuditor/resources/echo-property.pl: Added.
        * http/tests/security/xssAuditor/resources/redir.php: Added.
        * http/tests/security/xssAuditor/resources/xss.js: Added.
        * http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
        * http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
        * http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-post.html: Added.
        * http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-redirect.html: Added.
        * http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source.html: Added.
        * http/tests/security/xssAuditor/script-tag.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 23 Jun 2009 08:46:03 +0000 (08:46 +0000)]
2009-06-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        * Scripts/modules/scm.py: Fix error seen when commiting r44979.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44980 268f45cc-cd09-0410-ab3c-d52691b4dbfc