WebKit-https.git
12 years ago2007-08-02 Mark Rowe <mrowe@apple.com>
bdash [Thu, 2 Aug 2007 09:33:22 +0000 (09:33 +0000)]
2007-08-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5352887> "Out of memory" error during repeated JS string concatenation leaks hundreds of MBs of RAM

        A call to fastRealloc was failing which lead to UString::expandCapacity leaking the buffer it was trying to reallocate.
        It also resulted in the underlying UString::rep having both a null baseString and buf field, which meant that attempting
        to access the contents of the string after the failed memory reallocation would crash.

        A third issue is that expandedSize size was calculating the new length in a way that led to an integer overflow occurring.
        Attempting to allocate a string more than 190,000,000 characters long would fail a the integer overflow would lead to a
        memory allocation of around 3.6GB being attempted rather than the expected 390MB.  Sizes that would lead to an overflow
        are now  returned as zero and callers are updated to treat this as though the memory allocation has failed.

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction): Check whether the append failed and raise an "Out of memory" exception if it did.
        * kjs/ustring.cpp:
        (KJS::allocChars): Wrapper around fastMalloc that takes a length in characters.  It will return 0 when asked to allocate a zero-length buffer.
        (KJS::reallocChars): Wrapper around fastRealloc that takes a length in characters.  It will return 0 when asked to allocate a zero-length buffer.
        (KJS::UString::expandedSize): Split the size calculation in two and guard against overflow during each step.
        (KJS::UString::expandCapacity): Don't leak r->buf if reallocation fails.  Instead free the memory and use the null representation.
        (KJS::UString::expandPreCapacity): If fastMalloc fails then use the null representation rather than crashing in memcpy.
        (KJS::UString::UString): If calls to expandCapacity, expandPreCapacity or fastMalloc fail then use the null representation rather than crashing in memcpy.
        (KJS::UString::append): Ditto.
        (KJS::UString::operator=): Ditto.
        * kjs/ustring.h: Change return type of expandedSize from int to size_t.

2007-08-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5352887> "Out of memory" error during repeated JS string concatenation leaks hundreds of MBs of RAM

        Update test to check that accessing the string after the "Out of memory" exception was raised does not crash.

        * fast/js/resources/string-concatenate-outofmemory.js:
        * fast/js/string-concatenate-outofmemory-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoforgot to add info about the bug being fixed
aliceli1 [Thu, 2 Aug 2007 07:24:13 +0000 (07:24 +0000)]
forgot to add info about the bug being fixed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
aliceli1 [Thu, 2 Aug 2007 07:13:31 +0000 (07:13 +0000)]
WebCore:

        Reviewed by Kevin McCullough.

        fixed <rdar://problem/5310312> REGRESSION: javascript is mis-escaped at http://labs.zarate.org/passwd causing bookmarklet to break

        * WebCore.exp:
        expose some calls for WebKit to call.
        * manual-tests/JavaScript-bookmarklets.html: Added.

WebKit:

        Reviewed by Kevin McCullough.

        * Misc/WebNSURLExtras.mm:
        (+[NSURL _web_URLWithUserTypedString:relativeToURL:]):
        (-[NSURL _web_userVisibleString]):
        (-[NSURL _web_URLWithLowercasedScheme]):
        (-[NSURL _web_dataForURLComponentType:]):
        These 4 changes are just casting changes.

        (-[NSString _webkit_stringByReplacingValidPercentEscapes]):
        This change replaces the call to an NSURL method with a webcore one that doesn't abort the escaping effort once an illegal character is encountered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Don't delete the stderr file right after creating it
aroben [Thu, 2 Aug 2007 07:01:42 +0000 (07:01 +0000)]
    Don't delete the stderr file right after creating it

        Reviewed by NOBODY.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago When DRT crashes, record stderr and restart DRT
aroben [Thu, 2 Aug 2007 06:24:50 +0000 (06:24 +0000)]
    When DRT crashes, record stderr and restart DRT

        This prevents a DRT crash from causing the next few hundred tests to
        "fail" because DRT is no longer running.

        I also changed the terminology that run-webkit-tests uses in its
        output a bit, so that crashing tests are referred to as "crashes"
        instead of "failures".

        Reviewed by Mark.

        * Scripts/run-webkit-tests: Detect a crash and record it as a tool
        failure.
        (sub openDumpTool): Use open3 so that we can access stderr.
        (sub dumpToolCrashed): Added.
        (sub printFailureMessageForTest): Added.
        (sub htmlForExpectedAndActualResults): Added.
        (sub deleteExpectedAndActualResults): Added.
        (sub recordActualResultsAndDiff): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd an interface to manage global history for clients
treat [Thu, 2 Aug 2007 04:21:28 +0000 (04:21 +0000)]
Add an interface to manage global history for clients

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDo not call update or repaint from inside a paint event.
treat [Thu, 2 Aug 2007 02:24:33 +0000 (02:24 +0000)]
Do not call update or repaint from inside a paint event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix build.
andersca [Thu, 2 Aug 2007 01:43:19 +0000 (01:43 +0000)]
    Fix build.

        * Misc/WebNSURLExtras.mm:
        (+[NSURL _web_URLWithUserTypedString:relativeToURL:]):
        (-[NSURL _web_userVisibleString]):
        (-[NSURL _web_URLWithLowercasedScheme]):
        (-[NSURL _web_dataForURLComponentType:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by .
aliceli1 [Thu, 2 Aug 2007 01:18:37 +0000 (01:18 +0000)]
    Reviewed by .

        Making WebNSURLExtras objc++

        * Misc/WebNSURLExtras.m: Removed.
        * Misc/WebNSURLExtras.mm: Copied from WebKit/Misc/WebNSURLExtras.m.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson and Kevin Decker.
darin [Thu, 2 Aug 2007 01:15:23 +0000 (01:15 +0000)]
    Reviewed by Anders Carlsson and Kevin Decker.

        - fix <rdar://problem/5377432> Removal of MakeDataExecutable from 64-bit breaks WebKit build

        The trick was to ifdef out more of the code that's only needed to support CFM, which exists
        only for 32-bit PowerPC.

        * Plugins/WebNetscapePluginPackage.h: Define a SUPPORT_CFM symbol in this internal header when
        we support CFM. We support it only on 32-bit PowerPC. Only define the isBundle, isCFM, and
        connID fields when SUPPORT_CFM is on. Also use ResFileRefNum instead of SInt16.
        * Plugins/WebNetscapePluginPackage.m: Only compile the function pointer and transition vector
        functions when SUPPORT_CFM is on.
        (-[WebNetscapePluginPackage openResourceFile]): Put the non-bundle case inside a SUPPORT_CFM
        ifdef, since all non-CFM plug-ins are bundles.
        (-[WebNetscapePluginPackage closeResourceFile:]): Ditto.
        (-[WebNetscapePluginPackage _initWithPath:]): Use SUPPORT_CFM to compile out the code for
        non-bundle and bundle-based CFM plug-ins, and code that sets isBundle and isCFM.
        (-[WebNetscapePluginPackage executableType]): Put the CFM case inside SUPPORT_CFM.
        (-[WebNetscapePluginPackage load]): Put the non-bundle and CFM cases inside SUPPORT_CFM.
        There was a bit of dead code here.
        (-[WebNetscapePluginPackage _unloadWithShutdown:]): Put the non-bundle case inside
        SUPPORT_CFM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Justin.
thatcher [Thu, 2 Aug 2007 00:35:29 +0000 (00:35 +0000)]
    Reviewed by Justin.

        <rdar://problem/5376156> Mail crash in DeleteButtonController::hide() when dropping selected image on DIV's border

        Add the container element back so the selection can not touch the deletion UI nodes. The container
        has style to prevent user selection, user drag and user modification.

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::show): Make the container node, and append the button and outline elements.
        (WebCore::DeleteButtonController::hide): Remove the container elements and null out the other nodes.
        * editing/DeleteButtonController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Kevin McCullough.
darin [Thu, 2 Aug 2007 00:30:08 +0000 (00:30 +0000)]
    Reviewed by Kevin McCullough.

        - fix <rdar://problem/5375186> pointers to pieces of class definition passed to JSClassCreate should all be const

        * API/JSObjectRef.h: Added const.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::OpaqueJSClass): Added const.
        (OpaqueJSClass::create): Added const.
        * API/JSObjectRef.cpp:
        (JSClassCreate): Added const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build mod: Fix sln to match configs in vcproj.
sfalken [Wed, 1 Aug 2007 21:14:01 +0000 (21:14 +0000)]
    Build mod: Fix sln to match configs in vcproj.

        Reviewed by Adam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago fast/encoding/char-encoding.html no longer needs to be in the Leopard skiplist
oliver [Wed, 1 Aug 2007 04:30:42 +0000 (04:30 +0000)]
    fast/encoding/char-encoding.html no longer needs to be in the Leopard skiplist

        * mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Justin.
harrison [Wed, 1 Aug 2007 00:40:23 +0000 (00:40 +0000)]
    Reviewed by Justin.

        <rdar://problem/5362659> CrashTracer: [USER] 11 crashes in Mail at WebCore::InsertLineBreakCommand::doApply()

        The problem was that deleting with the X control leaves the selection inside the fragment that was deleted.

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::deleteTarget):
        Because the deletion UI only appears when the selection is entirely
        within the target, we unconditionally update the selection to be
        a caret where the target had been.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
adele [Wed, 1 Aug 2007 00:36:49 +0000 (00:36 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Updated tests for <rdar://problem/5339395> REGRESSION:http://sudokucraving.com does not render grid correctly

        * fast/forms/input-appearance-minWidth.html: Removed. This test is covered by fast/replaced/width100percent-textfield.html.
        * fast/forms/input-appearance-minWidth-expected.checksum: Removed.
        * fast/forms/input-appearance-minWidth-expected.png: Removed.
        * fast/forms/input-appearance-minWidth-expected.txt: Removed.

        * fast/forms/input-table-expected.checksum:
        * fast/forms/input-table-expected.png:
        * fast/forms/input-table-expected.txt:
        * fast/replaced/width100percent-menulist-expected.checksum:
        * fast/replaced/width100percent-menulist-expected.png:
        * fast/replaced/width100percent-menulist-expected.txt:
        * fast/replaced/width100percent-searchfield-expected.checksum: Added.
        * fast/replaced/width100percent-searchfield-expected.png: Added.
        * fast/replaced/width100percent-searchfield-expected.txt: Added.
        * fast/replaced/width100percent-searchfield.html: Added.
        * fast/replaced/width100percent-textarea-expected.checksum:
        * fast/replaced/width100percent-textarea-expected.png:
        * fast/replaced/width100percent-textarea-expected.txt:
        * fast/replaced/width100percent-textfield-expected.checksum:
        * fast/replaced/width100percent-textfield-expected.png:
        * fast/replaced/width100percent-textfield-expected.txt:

WebCore:

        Reviewed by Hyatt.

         Fix for <rdar://problem/5339395> REGRESSION:http://sudokucraving.com does not render grid correctly

        * rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip): Clip for search fields.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::controlClipRect): Added a control clip so the search field's cancel button and magnifier glass
         never draw outside the control's bounds.
        (WebCore::RenderTextControl::calcPrefWidths): Only include the inner box's padding when calculating the min/max width without using calcContentBoxWidth.
         Our old behavior was causing that inner padding to get counted twice.  Also, no need to add in the border
         for an inner box that can't be controlled from outside this class.
        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcPrefWidths): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
andersca [Wed, 1 Aug 2007 00:20:04 +0000 (00:20 +0000)]
    Reviewed by Geoff.

        Speculative fix for <rdar://problem/5359695>
        REGRESSION (Tiger Beta): Multiple crashes in WebCore::Widget::getView() const + 6

        * page/EventHandler.cpp:
        (WebCore::EventHandler::updateDragAndDrop):
        Null check the frame view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
thatcher [Tue, 31 Jul 2007 21:17:51 +0000 (21:17 +0000)]
WebCore:

        Reviewed by Oliver and Beth.

        <rdar://problem/5211271> ADOBE Leopard 9A410: At the first Launching InDesign after deactivate, EULA page gets blanked.

        Rename needsAcrobatFrameReloadingQuirk to needsAdobeFrameReloadingQuirk, since this now applies to more Adobe applications.

        * WebCore.exp:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setNeedsAdobeFrameReloadingQuirk):
        * page/Settings.h:
        (WebCore::Settings::needsAcrobatFrameReloadingQuirk):

WebKit:

        Reviewed by Oliver and Beth.

        <rdar://problem/5211271> ADOBE Leopard 9A410: At the first Launching InDesign after deactivate, EULA page gets blanked.

        Check for more Adobe applications that need the frame reload quirk. Also cache the answer
        so the version check dosen't happen more than once.

        * WebView/WebView.mm:
        (-[WebView _needsAdobeFrameReloadingQuirk]):
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
beidson [Tue, 31 Jul 2007 20:29:02 +0000 (20:29 +0000)]
LayoutTests:

        Reviewed by Brady

        Test for http://bugs.webkit.org/show_bug.cgi?id=14757
        HTMLTokenizer::processingData implementation is incorrect

        * http/tests/loading/slow-parsing-subframe-expected.txt: Added.
        * http/tests/loading/slow-parsing-subframe.html: Added.

WebCore:

        Reviewed by Brady and Darin, tweaked by Brady, landed by Brady

        Fix for http://bugs.webkit.org/show_bug.cgi?id=14757 and <rdar://problem/5364692>
        HTMLTokenizer::processingData implementation is incorrect

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::processingData): Made it also return true if the HTMLTokenizer was inside the write() call.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::checkLoadCompleteTimerFired):
        (WebCore::FrameLoader::scheduleCheckLoadComplete):
        (WebCore::FrameLoader::stopForUserCancel): Changed a call to checkLoadComplete to be asynchronous, since
        stopForUserCancel can be called while parsing.
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver.
adele [Tue, 31 Jul 2007 19:54:51 +0000 (19:54 +0000)]
    Reviewed by Oliver.

        Fix for <rdar://problem/5308020> REGRESSION: Command-N with Dvorak-Qwerty keyboard layout stopped working inside web page text fields

        * WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]):
        The input method may have modified the character we get, so don't use charactersIgnoringModifiers to interpret the character we get.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
andersca [Tue, 31 Jul 2007 19:08:04 +0000 (19:08 +0000)]
    Reviewed by Geoff.

        <rdar://problem/5371582>
        REGRESSION: PLT .5% slower due to r24451 (copying HTMLCollection objects)

        Make the hash maps store CollectionInfo pointers to reduce amount of copying when
        inserting/rehashing etc.

        * dom/Document.cpp:
        (WebCore::Document::~Document):
        (WebCore::Document::nameCollectionInfo):
        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Beth.
adele [Tue, 31 Jul 2007 18:38:05 +0000 (18:38 +0000)]
    Reviewed by Beth.

        Updated this test to force display to happen earlier. This works around a bug in DRT that draws the scrollbars in a different way from Safari.

        * fast/replaced/width100percent-textarea-expected.checksum:
        * fast/replaced/width100percent-textarea-expected.png:
        * fast/replaced/width100percent-textarea.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
adele [Tue, 31 Jul 2007 18:27:21 +0000 (18:27 +0000)]
    Reviewed by Sam.

        Breaking up fast/replaced/width100percent.html into separate tests for the different elements.

        * fast/replaced/width100percent-button-expected.checksum: Added.
        * fast/replaced/width100percent-button-expected.png: Added.
        * fast/replaced/width100percent-button-expected.txt: Added.
        * fast/replaced/width100percent-button.html: Added.
        * fast/replaced/width100percent-checkbox-expected.checksum: Added.
        * fast/replaced/width100percent-checkbox-expected.png: Added.
        * fast/replaced/width100percent-checkbox-expected.txt: Added.
        * fast/replaced/width100percent-checkbox.html: Added.
        * fast/replaced/width100percent-image-expected.checksum: Added.
        * fast/replaced/width100percent-image-expected.png: Added.
        * fast/replaced/width100percent-image-expected.txt: Added.
        * fast/replaced/width100percent-image.html: Added.
        * fast/replaced/width100percent-menulist-expected.checksum: Added.
        * fast/replaced/width100percent-menulist-expected.png: Added.
        * fast/replaced/width100percent-menulist-expected.txt: Added.
        * fast/replaced/width100percent-menulist.html: Added.
        * fast/replaced/width100percent-radio-expected.checksum: Added.
        * fast/replaced/width100percent-radio-expected.png: Added.
        * fast/replaced/width100percent-radio-expected.txt: Added.
        * fast/replaced/width100percent-radio.html: Added.
        * fast/replaced/width100percent-textarea-expected.checksum: Added.
        * fast/replaced/width100percent-textarea-expected.png: Added.
        * fast/replaced/width100percent-textarea-expected.txt: Added.
        * fast/replaced/width100percent-textarea.html: Added.
        * fast/replaced/width100percent-textfield-expected.checksum: Added.
        * fast/replaced/width100percent-textfield-expected.png: Added.
        * fast/replaced/width100percent-textfield-expected.txt: Added.
        * fast/replaced/width100percent-textfield.html: Added.

        * fast/replaced/width100percent.html: Removed.
        * fast/replaced/width100percent-expected.checksum: Removed.
        * fast/replaced/width100percent-expected.png: Removed.
        * fast/replaced/width100percent-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
weinig [Tue, 31 Jul 2007 17:58:46 +0000 (17:58 +0000)]
LayoutTests:

        Reviewed by Mitz.

        Updated tests for http://bugs.webkit.org/show_bug.cgi?id=14825
        Non-integer hsl() colours are ignored

        * fast/css/hsl-color-expected.checksum:
        * fast/css/hsl-color-expected.png:
        * fast/css/hsl-color-expected.txt:
        * fast/css/hsl-color.html: Add non-integer hue tests
        * fast/css/hsla-color-expected.checksum:
        * fast/css/hsla-color-expected.png:
        * fast/css/hsla-color-expected.txt:
        * fast/css/hsla-color.html: Add non-integer hue tests

WebCore:

        Reviewed by Mitz.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=14825
        Non-integer hsl() colours are ignored

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseHSLParameters): Parse hue as a Number,
        not an Integer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Tue, 31 Jul 2007 03:54:56 +0000 (03:54 +0000)]
LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5369009>
        Crash due to infinite recursion in moveParagraphs deleting line from a Mail message

        * editing/deleting/5369009-expected.checksum: Added.
        * editing/deleting/5369009-expected.png: Added.
        * editing/deleting/5369009-expected.txt: Added.
        * editing/deleting/5369009.html: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/5369009> Crash due to infinite recursion in moveParagraphs on delete

        After the delete, we moved content into the previous block, and a style
        rule turned a style span in the moved content into a block, throwing
        moveParagraphs into infinite recursion, as it continually tried and failed
        to get the style span into the same paragraph as the content just before it.

        Added a method to ReplaceSelectionCommand to keep inserted style spans
        from turning into blocks because of style rules.  Will add code to prevent
        other kinds of content from changing appearance because of style rules,
        post-Leopard (5371536). Also added a bool to ReplaceSelectionCommand's
        constructor to guard against infinite recursion.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/JSEditor.cpp:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::negateStyleRulesThatEffectAppearance):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build.
treat [Tue, 31 Jul 2007 03:44:13 +0000 (03:44 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin
sullivan [Tue, 31 Jul 2007 03:18:27 +0000 (03:18 +0000)]
    Reviewed by Darin

        - fixed <rdar://problem/5216176> Need WebKit SPI to allow clients using embedded WebViews to avoid
          clipping ends of some printed pages

        This provides Mail, and other clients that print views that embed WebViews, a way to ensure that
        the HTML is laid out for printing before pagination occurs.

        * WebView/WebHTMLViewPrivate.h:
        new SPI method -_layoutForPrinting

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
        new method, just like existing _web_setPrintingModeRecursive except passes YES for adjustViewSize
        (-[WebHTMLView _layoutForPrinting]):
        new SPI method, sets printing mode temporarily to adjust the view size for printing
        (-[NSView _web_setPrintingModeRecursiveAndAdjustViewSize]):
        new helper method to do the recursion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady.
andersca [Tue, 31 Jul 2007 00:48:25 +0000 (00:48 +0000)]
    Reviewed by Brady.

        <rdar://problem/5371515>
        BitmapImage::getTIFFRepresentation() bug results in favicons not working at many sites

        Don't bail out if a single frame is invalid.

        * platform/graphics/mac/ImageMac.mm:
        (WebCore::BitmapImage::getTIFFRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix a bug number on an old check-in.
darin [Tue, 31 Jul 2007 00:29:59 +0000 (00:29 +0000)]
Fix a bug number on an old check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
adele [Tue, 31 Jul 2007 00:09:31 +0000 (00:09 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5367919> A crash occurs at WebCore::Frame::isFrameSet() when attempting to print a iframe before it loads at http://www.monster.com/

        * WebView/WebHTMLView.mm: (-[WebHTMLView knowsPageRange:]): Nil check for frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
adele [Mon, 30 Jul 2007 23:56:19 +0000 (23:56 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5274937> Safari 3 breaks Missing Sync's WebKit code by crashing

        * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Nil check for the FrameLoader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca [Mon, 30 Jul 2007 23:24:37 +0000 (23:24 +0000)]
WebCore:

        Reviewed by Darin.

        <rdar://problem/5370710>
        REGRESSION: After switching from Bookmark view, the Find Banner won't appear while displaying a PDF file

        Add a hasHTMLView to FrameLoaderClient. This is only useful for clients who can show different views for different
        MIME types and URL schemes.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::transitionToCommitted):
        Call delegate methods here if the current view is not a HTML view.

        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::hasHTMLView):

WebKit:

        Reviewed by Darin.

        <rdar://problem/5370710>
        REGRESSION: After switching from Bookmark view, the Find Banner won't appear while displaying a PDF file

        Implement hasHTMLView.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::hasHTMLView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHatcher!
darin [Mon, 30 Jul 2007 23:05:37 +0000 (23:05 +0000)]
Hatcher!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Tim Matcher.
darin [Mon, 30 Jul 2007 23:05:04 +0000 (23:05 +0000)]
    Reviewed by Tim Matcher.

        * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
        characters. This turned out not to be needed for the test case that motivated me to
        do it, but it's nice to have this for the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed a typo in my last checkin.
justing [Mon, 30 Jul 2007 22:29:35 +0000 (22:29 +0000)]
Fixed a typo in my last checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
weinig [Mon, 30 Jul 2007 18:29:29 +0000 (18:29 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Update tests for <rdar://problem/5363896>
        REGRESSION: Setting document.domain does not override port-based cross-frame security checks -- breaks SAP NetWeaver

        - Also changes frame access test to use shared resource iframes.

        * http/tests/security/cross-frame-access-port-expected.txt:
        * http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
        * http/tests/security/cross-frame-access-port-explicit-domain.html:
        * http/tests/security/cross-frame-access-port.html:
        * http/tests/security/cross-frame-access-protocol-expected.txt:
        * http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
        * http/tests/security/cross-frame-access-protocol-explicit-domain.html:
        * http/tests/security/cross-frame-access-protocol.html:
        * http/tests/security/resources/cross-frame-iframe-for-port-explicit-domain-test.html: Removed.
        * http/tests/security/resources/cross-frame-iframe-for-port-test.html: Removed.
        * http/tests/security/resources/cross-frame-iframe-for-protocol-explicit-domain-test.html: Removed.
        * http/tests/security/resources/cross-frame-iframe-for-protocol-test.html: Removed.
        * http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html: Added.
        * http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

        Reviewed by Maciej.

        Fix for <rdar://problem/5363896>
        REGRESSION: Setting document.domain does not override port-based cross-frame security checks -- breaks SAP NetWeaver

        Updates the results for:
            http/tests/security/cross-frame-access-port-explicit-domain.html
            http/tests/security/cross-frame-access-protocol-explicit-domain.html

        * bindings/js/kjs_window.cpp:
        (KJS::createWindow): Use the new setDomainInternal method.
        (KJS::Window::isSafeScript): Don't set check the port or protocol
        if both documents have explicitly set document.domain in the DOM
        and the those domains are equal.
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::setDomain): Remove force parameter and change
        all calls that relied on it use the new setDomainInternal method
        which does the same thing.
        (WebCore::Document::setDomainInternal):
        * dom/Document.h: Add new m_domainWasSetInDOM variable and accessor.
        (WebCore::Document::domainWasSetInDOM):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCallImplicitClose): Use the new setDomainInternal method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justing [Mon, 30 Jul 2007 18:25:19 +0000 (18:25 +0000)]
WebCore:

        Reviewed by Tristan.

        <rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete

        Added an editor client method for asking whether or not it is
        OK to merge content after a delete.

        * bridge/EditorClient.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Ask if the
        merge is allowed.
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::shouldMoveRangeAfterDelete): Added a method stub.
        * platform/gdk/EditorClientGdk.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::shouldMoveRangeAfterDelete): Ditto.

WebKit:

        Reviewed by Tristan.

        <rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete

        Mail needs to be asked if it is OK to do the content movement that happens
        after a deleting in a situation like this one:
        <div contenteditable="plaintext-only">foo</div><div>^bar</div>
        so that they can prevent the move or so that they can save content that
        will be stripped by the move. This could have been done with shouldInsertNode
        and a new WebViewInsertAction for "moves", but WebKit clients like Mail and
        DashCode think that a shouldInsert* means that the user pasted something and
        perform actions only appropriate for pastes.  This change is less risky because
        it won't require those clients to change their code.

        * DefaultDelegates/WebDefaultEditingDelegate.m:
        (-[WebDefaultEditingDelegate webView:shouldMoveRangeAfterDelete:replacingRange:]):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::shouldMoveRangeAfterDelete):
        * WebView/WebEditingDelegatePrivate.h:

win:

        Reviewed by Tristan.

        <rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete

        * WebEditorClient.cpp:
        (WebEditorClient::shouldMoveRangeAfterDelete): Method stub.
        * WebEditorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
andersca [Mon, 30 Jul 2007 18:15:32 +0000 (18:15 +0000)]
LayoutTests:

        Reviewed by Anders.

        <rdar://problem/5352526>
        http://bugs.webkit.org/show_bug.cgi?id=14704
        REGRESSION: sync XMLHttpRequest.send() raises an exception for failed authentication

        * http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
        * http/tests/xmlhttprequest/failed-auth.html: Added.
        This test has other cases from bug 13075 commented out, as they still fail.

        * http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html: Added.
        This test already passed, but I think it's useful to cover this case, too.

WebCore:

        Reviewed by Anders.

        <rdar://problem/5352526>
        http://bugs.webkit.org/show_bug.cgi?id=14704
        REGRESSION: sync XMLHttpRequest.send() raises an exception for failed authentication

        Test: http/tests/xmlhttprequest/failed-auth.html

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously): Make the fake response better match the real one
        in case of failed authentication. Unfortunately, NSURLConnection doesn't give us the real response.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send): If the response has an HTTP code in it, then the error wasn't
        a network one, and an exception shouldn't be raised.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdating layout test results with new expected results.
tristan [Mon, 30 Jul 2007 17:48:51 +0000 (17:48 +0000)]
Updating layout test results with new expected results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
andersca [Mon, 30 Jul 2007 17:28:03 +0000 (17:28 +0000)]
    Reviewed by Darin.

        <rdar://problem/4942372> REGRESSION: Anchor links in Mail don't work anymore

        Make it possible for KURL to handle addig fragments to non-hierarchical URLs
        such as mailto: and cid:.

        * platform/KURL.cpp:
        (WebCore::KURL::init):
        If the base URL is not hierarchical but the relative URL is a fragment, then
        allow parsing it.

        (WebCore::KURL::parse):
        If the URL is not hierarchical, set the fragment start and end positions correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOn Windows make sure the dll also ends up in $$OUTPUT_DIR/bin, so that QtLauncher...
hausmann [Mon, 30 Jul 2007 16:10:42 +0000 (16:10 +0000)]
On Windows make sure the dll also ends up in $$OUTPUT_DIR/bin, so that QtLauncher can find it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLink QtLauncher into $$OUTPUT_DIR/bin
hausmann [Mon, 30 Jul 2007 16:10:29 +0000 (16:10 +0000)]
Link QtLauncher into $$OUTPUT_DIR/bin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved the __BUILDING_QT ifdef in JSStringRef.h and changed UChar for the Qt build...
hausmann [Mon, 30 Jul 2007 15:30:37 +0000 (15:30 +0000)]
Removed the __BUILDING_QT ifdef in JSStringRef.h and changed UChar for the Qt build to use wchar_t on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't link against libxml/libxslt unless we really need it.
hausmann [Mon, 30 Jul 2007 15:30:21 +0000 (15:30 +0000)]
Don't link against libxml/libxslt unless we really need it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
tristan [Mon, 30 Jul 2007 06:33:54 +0000 (06:33 +0000)]
    Reviewed by Oliver Hunt.

        <rdar://problem/5369282> REGRESSION: DOMHTMLInput throwing exception due to missing _isEdited method

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement _isEdited]):
        (-[DOMHTMLTextAreaElement _isEdited]):
        * bindings/objc/DOMPrivate.h:
        Renamed _isUserEdited to _isEdited.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-30 Diego Escalante Urrelo <diegoe@gnome.org>
alp [Mon, 30 Jul 2007 04:46:14 +0000 (04:46 +0000)]
2007-07-30  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=14806
        Implement can_go_backward and can_go_forward in webkitgtkpage.cpp

        * gtk/Api/webkitgtkpage.cpp: Implement webkit_gtk_page_can_go_backward() and
        webkit_gtk_page_can_go_forward() functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-30 Diego Escalante Urrelo <diegoe@gnome.org>
alp [Mon, 30 Jul 2007 04:07:14 +0000 (04:07 +0000)]
2007-07-30  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=14810
        Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp

        This is the proper fix for #14810.

        * gtk/Api/webkitgtkframe.cpp:
        * gtk/Api/webkitgtkpage.cpp: Fix the marshaller type of the "load_finished" signal and
        correct the class_offset parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-29 Diego Escalante Urrelo <diegoe@gnome.org>
alp [Mon, 30 Jul 2007 03:12:21 +0000 (03:12 +0000)]
2007-07-29  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=14810
        Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp

        * gtk/Api/webkitgtkpage.cpp: Use a correct n_params value and the corresponding types for
        them in the "load_finished" signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPaint and scrolling performance fixes and improvements.
treat [Mon, 30 Jul 2007 02:40:26 +0000 (02:40 +0000)]
Paint and scrolling performance fixes and improvements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele [Sun, 29 Jul 2007 23:25:17 +0000 (23:25 +0000)]
WebCore:

        Reviewed by John.

        WebCore part of fix for <rdar://problem/5102522> REGRESSION: Can't tab to webview that doesn't have editable content (affects Safari, preview pane in Mail)

        * WebCore.exp:
        * page/FocusController.cpp:
        (WebCore::FocusController::setInitialFocus): Added.
        (WebCore::FocusController::advanceFocus): Don't give the focus back to the chrome if this is the initial focus.
        * page/FocusController.h:

WebKit:

        Reviewed by John.

        WebKit part of fix for <rdar://problem/5102522> REGRESSION: Can't tab to webview that doesn't have editable content

        * WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Call new setInitialFocus method instead of advanceFocus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-29 Brian Mastenbrook <brian@mastenbrook.net>
zecke [Sun, 29 Jul 2007 21:51:41 +0000 (21:51 +0000)]
2007-07-29  Brian Mastenbrook  <brian@mastenbrook.net>

        Build fix for WebKit/Gtk to compile on Fedora 7 as described in
        http://bugs.webkit.org/show_bug.cgi?id=14557

        * WebKit.pri: cairo-ft is used by the WebKit/Gtk port

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRespect the margins when creating frames.
treat [Sun, 29 Jul 2007 15:18:26 +0000 (15:18 +0000)]
Respect the margins when creating frames.
Set the scroll mode to always off like we did before the rendered
frames patch and the other ports do now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore::Widget::setParent should be virtual.
treat [Sun, 29 Jul 2007 14:42:01 +0000 (14:42 +0000)]
WebCore::Widget::setParent should be virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWe actually pass the mac versions expected results here.
treat [Sun, 29 Jul 2007 14:22:47 +0000 (14:22 +0000)]
We actually pass the mac versions expected results here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
weinig [Sun, 29 Jul 2007 02:34:12 +0000 (02:34 +0000)]
    Reviewed by Mark Rowe.

        - Rename test for clarity and consistency.
        - Move resource from ssl/resources to security/resources as it is
          only being used by the security tests.

        * http/tests/security/cross-frame-access-port-domain-expected.txt: Removed.
        * http/tests/security/cross-frame-access-port-domain.html: Removed.
        * http/tests/security/cross-frame-access-port-explicit-domain-expected.txt: Copied from http/tests/security/cross-frame-access-port-domain-expected.txt.
        * http/tests/security/cross-frame-access-port-explicit-domain.html: Copied from http/tests/security/cross-frame-access-port-domain.html.
        * http/tests/security/cross-frame-access-protocol-expected.txt:
        * http/tests/security/cross-frame-access-protocol.html:
        * http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html: Removed.
        * http/tests/security/resources/cross-frame-iframe-for-port-explicit-domain-test.html: Copied from http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html.
        * http/tests/security/resources/cross-frame-iframe-for-protocol-test.html: Copied from http/tests/ssl/resources/cross-frame-access-protocol-iframe.html.
        * http/tests/ssl/resources: Removed.
        * http/tests/ssl/resources/cross-frame-access-protocol-iframe.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
weinig [Sun, 29 Jul 2007 02:15:18 +0000 (02:15 +0000)]
    Reviewed by Oliver Hunt.

        - Factor access testing code used in protocol and port tests to cross-frame-access.js.
        - Add cross-frame-iframe-for-protocol-explicit-domain-test.html which is parallel test to
          cross-frame-iframe-for-port-domain-test.html but for different protocols.

        * http/tests/security/cross-frame-access-port-domain-expected.txt:
        * http/tests/security/cross-frame-access-port-domain.html:
        * http/tests/security/cross-frame-access-port.html:
        * http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt: Added.
        * http/tests/security/cross-frame-access-protocol-explicit-domain.html: Added.
        * http/tests/security/cross-frame-access-protocol.html:
        * http/tests/security/resources/cross-frame-access.js:
        * http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-port-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-protocol-explicit-domain-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix up reviewer name typo in ChangeLog
alp [Sun, 29 Jul 2007 02:02:38 +0000 (02:02 +0000)]
Fix up reviewer name typo in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-29 Alp Toker <alp.toker@collabora.co.uk>
alp [Sun, 29 Jul 2007 01:30:13 +0000 (01:30 +0000)]
2007-07-29  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Brian Dash.

        http://bugs.webkit.org/show_bug.cgi?id=14711 (revisited)
        RenderThemeGdk's buttons are state-agnostic (pressed, hovered)

        Generalize shadow state into a function.
        use a GtkHBox to work around a theme bug (thanks to Nigel Tao).

        * platform/gdk/RenderThemeGdk.cpp:
        (WebCore::RenderThemeGdk::determineShadow):
        (WebCore::RenderThemeGdk::paintCheckbox):
        (WebCore::RenderThemeGdk::paintRadio):
        (WebCore::RenderThemeGdk::paintButton):
        (WebCore::RenderThemeGdk::gtkWindowContainer):
        * platform/gdk/RenderThemeGdk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-28 Mark Rowe <mrowe@apple.com>
bdash [Sun, 29 Jul 2007 01:18:13 +0000 (01:18 +0000)]
2007-07-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin and John.

        <rdar://problem/5229705> Thai characters render differently between leopard and tiger

        Add Leopard-specific test results for tests containing Thai characters.

        * mac/leopard/Skipped:
        * mac/leopard/fast/text: Added.
        * mac/leopard/fast/text/atsui-multiple-renderers-expected.txt: Added.
        * mac/leopard/fast/text/international: Added.
        * mac/leopard/fast/text/international/thai-line-breaks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-29 Mark Rowe <mrowe@apple.com>
bdash [Sun, 29 Jul 2007 01:15:49 +0000 (01:15 +0000)]
2007-07-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5228270> SVG test failures due to different metrics for scaled text blocks

        Add Leopard-specific results for three SVG tests.

        * mac/leopard/Skipped:
        * mac/leopard/svg: Added.
        * mac/leopard/svg/hixie: Added.
        * mac/leopard/svg/hixie/text: Added.
        * mac/leopard/svg/hixie/text/003-expected.txt: Added.
        * mac/leopard/svg/hixie/text/003a-expected.txt: Added.
        * mac/leopard/svg/hixie/viewbox: Added.
        * mac/leopard/svg/hixie/viewbox/preserveAspectRatio: Added.
        * mac/leopard/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
adele [Sat, 28 Jul 2007 00:54:49 +0000 (00:54 +0000)]
    Reviewed by Darin.

        Temporary fix for Windows to prevent crashing on all frame pages.  Darin
        is working on a more permanent fix.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix crash when using QtWebKit canvas support.
treat [Fri, 27 Jul 2007 23:57:19 +0000 (23:57 +0000)]
Fix crash when using QtWebKit canvas support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
ddkilzer [Fri, 27 Jul 2007 23:37:04 +0000 (23:37 +0000)]
WebKitTools:

        Reviewed by Geoff and Darin.

        Use a subroutine for validating the --skipped switch.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
weinig [Fri, 27 Jul 2007 21:49:37 +0000 (21:49 +0000)]
    Reviewed by Geoff Garen.

        - Test that cross frame access to a window on a different port is denied.
        - Adds test for out behavior of the above if document.domain is explicitly
          set to the same domain for both frames. We currently fail this test and
          a radar has been filed.
        - Clean up cross-frame-access-protocol.html to work in FireFox as well.

        * http/conf/apache2-httpd.conf: Listen on port 8080 now as well
        * http/conf/cygwin-httpd.conf: Listen on port 8080 now as well
        * http/conf/httpd.conf: Listen on port 8080 now as well
        * http/tests/security/cross-frame-access-port-domain-expected.txt: Added.
        * http/tests/security/cross-frame-access-port-domain.html: Added.
        * http/tests/security/cross-frame-access-port-expected.txt: Added.
        * http/tests/security/cross-frame-access-port.html: Added.
        * http/tests/security/cross-frame-access-protocol.html:
        * http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-port-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - fix build
darin [Fri, 27 Jul 2007 20:40:05 +0000 (20:40 +0000)]
    - fix build

        * WebKitPrefix.h: Removed the USING_WEBCORE_XXX definitions.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView delete:]): Fixed this to use WebCore again; I accidentally revived a dead
        code path that didn't work in the last patch!
        (-[WebHTMLView deleteToMark:]): Ditto.
        (-[WebHTMLView copy:]): Removed the unused side of the ifdef.
        (-[WebHTMLView cut:]): Ditto.
        (-[WebHTMLView paste:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
darin [Fri, 27 Jul 2007 20:27:21 +0000 (20:27 +0000)]
    Reviewed by Sam.

        * Scripts/run-webkit-tests: Remove exception for leaks bug that has been fixed on Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
weinig [Fri, 27 Jul 2007 20:00:51 +0000 (20:00 +0000)]
    Reviewed by Adam Roben.

        Don't display the expected and resulting values for screenTop and screenY
        as they depend on the physical screen size.

        * http/tests/security/cross-frame-access-put-expected.txt:
        * http/tests/security/resources/cross-frame-iframe-for-put-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Tim Hatcher and Oliver Hunt.
darin [Fri, 27 Jul 2007 19:13:31 +0000 (19:13 +0000)]
    Reviewed by Tim Hatcher and Oliver Hunt.

        - fix <rdar://problem/5355815> webView:doCommandBySelector: isn't getting called for copy:

        Added code so that webView:doCommandBySelector: is called for every command.

        * WebView/WebHTMLView.mm: Made 44 of the commands use the WEBCORE_COMMAND macro instead
        of being handwritten. For all the others, added invocation of COMMAND_PROLOGUE macro at
        the start of the command.
        (-[WebHTMLView callDelegateDoCommandBySelectorIfNeeded:]): Added.
        (-[WebHTMLView callWebCoreCommand:]): Added.
        (-[WebHTMLView delete:]): Removed unused code path -- easy to bring back some day, but
        we don't need it compiled in.
        (-[WebHTMLView deleteBackwardByDecomposingPreviousCharacter:]): Changed so this doesn't
        call deleteBackward: any more so we don't call the delegate two times.
        (-[WebHTMLView deleteToMark:]): Changed so this doesn't call delete: any more so we don't
        call the delegate two times.
        (-[WebHTMLView selectToMark:]): Changed so this doesn't call setMark: any more so we don't
        call the delegate two times.
        (-[WebHTMLView doCommandBySelector:]): Added code to set the private variable
        selectorForDoCommandBySelector. This allows callDelegateDoCommandBySelectorIfNeeded to
        detect that we've already called the delegate and avoids calling it twice.

        * WebView/WebHTMLViewInternal.h: Added the selectorForDoCommandBySelector field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * rendering/RenderLayer.cpp: Rolled out accidentally-checked-in code.
darin [Fri, 27 Jul 2007 19:09:20 +0000 (19:09 +0000)]
    * rendering/RenderLayer.cpp: Rolled out accidentally-checked-in code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
darin [Fri, 27 Jul 2007 19:07:30 +0000 (19:07 +0000)]
LayoutTests:

        Reviewed by John Sullivan.

        - fix <rdar://problem/5261393> In Mail the plain text alternatives to messages with attachments show weird little OBJ thingies

        * fast/text/zero-width-characters-expected.txt: Added.
        * fast/text/zero-width-characters.html: Added.

WebCore:

        Reviewed by John Sullivan.

        - fix <rdar://problem/5261393> In Mail the plain text alternatives to messages with attachments show weird little OBJ thingies

        The "weird little thingies" are U+FFFC characters. It's good to render them as zero-width, the way we do
        with control characters -- helps Mail and doesn't hurt web browsing.

        Test: fast/text/zero-width-characters.html

        * platform/CharacterNames.h: Add names for leftToRightMark, rightToLeftMark, and objectReplacementCharacter.
        * platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Give objectReplacementCharacter
        zero width in the same way we do it for the various other characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
andersca [Fri, 27 Jul 2007 18:33:27 +0000 (18:33 +0000)]
    Reviewed by Adam.

        Add FIXME comment.

        * Interfaces/DOMHTML.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-27 Ada Chan <adachan@apple.com>
adachan [Fri, 27 Jul 2007 17:27:48 +0000 (17:27 +0000)]
2007-07-27  Ada Chan  <adachan@apple.com>

        Reviewed by Adam.

        Added methods to track user edited text fields now that
        <rdar://problem/5359921> has been fixed.

        * DOMHTMLClasses.cpp:
        (DOMHTMLInputElement::QueryInterface):
        (DOMHTMLInputElement::isUserEdited):
        (DOMHTMLTextAreaElement::QueryInterface):
        (DOMHTMLTextAreaElement::isUserEdited):
        * DOMHTMLClasses.h:
        * Interfaces/DOMPrivate.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnable XSLT support for the gtk port.
lars [Fri, 27 Jul 2007 13:58:49 +0000 (13:58 +0000)]
Enable XSLT support for the gtk port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPremature end after finishing parsing is a fatal error.
lars [Fri, 27 Jul 2007 13:58:36 +0000 (13:58 +0000)]
Premature end after finishing parsing is a fatal error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoadd xlst related tests to Skipped list.
lars [Fri, 27 Jul 2007 13:58:22 +0000 (13:58 +0000)]
add xlst related tests to Skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimplify conversions that go from a QStringRef to a WebCore::String to not use a...
lars [Fri, 27 Jul 2007 13:58:12 +0000 (13:58 +0000)]
Simplify conversions that go from a QStringRef to a WebCore::String to not use a temporary QString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix entity handling in the main document content (attributes still broken)
lars [Fri, 27 Jul 2007 13:57:54 +0000 (13:57 +0000)]
Fix entity handling in the main document content (attributes still broken)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrectly convert a null QString into a null WebCore::String. Add a String(const...
lars [Fri, 27 Jul 2007 13:57:33 +0000 (13:57 +0000)]
Correctly convert a null QString into a null WebCore::String. Add a String(const QStringRef&) constructor so that we can avoid converting QStringRef via QString to WebCore::String.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoParse version and encoding of the xml document.
lars [Fri, 27 Jul 2007 13:57:07 +0000 (13:57 +0000)]
Parse version and encoding of the xml document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrectly or semi-correctly parse the public and system id.
lars [Fri, 27 Jul 2007 13:56:52 +0000 (13:56 +0000)]
Correctly or semi-correctly parse the public and system id.

Patch from Lars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix uri parsing for attributes.
lars [Fri, 27 Jul 2007 13:56:37 +0000 (13:56 +0000)]
Fix uri parsing for attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing qualified name parsing - from Lars.
lars [Fri, 27 Jul 2007 13:56:19 +0000 (13:56 +0000)]
Fixing qualified name parsing - from Lars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoParse dtd's
lars [Fri, 27 Jul 2007 13:56:05 +0000 (13:56 +0000)]
Parse dtd's

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement error handling.
lars [Fri, 27 Jul 2007 13:55:49 +0000 (13:55 +0000)]
Implement error handling.

Add our copyrights

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMaking the stylesheets work (plus everything else basically)
lars [Fri, 27 Jul 2007 13:55:35 +0000 (13:55 +0000)]
Making the stylesheets work (plus everything else basically)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove the libxml dependency when not compiling with XSLT.
lars [Fri, 27 Jul 2007 13:55:21 +0000 (13:55 +0000)]
Remove the libxml dependency when not compiling with XSLT.

Just ifdefing, displaying xml doesn't work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitQt:
zecke [Fri, 27 Jul 2007 12:26:58 +0000 (12:26 +0000)]
WebKitQt:

2007-07-27  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark.

        Don't create an app bundle on OSX to keep WebKitTools/Scripts/run-launcher working.

        * QtLauncher/QtLauncher.pro:

WebKitTools:
2007-07-27  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark.

        Correct the path of GdkLauncher and make checkFrameworks work on OSX
        when building the Qt or Gtk+ port.

        * GdkLauncher/GdkLauncher.pro: Don't create an app bundle on OSX
        * Scripts/run-launcher:
        * Scripts/webkitdirs.pm: Don't add WebKit if we build the Qt or Gtk+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWork around bug in the moc when used as preprocessor for generating the bindings...
hausmann [Fri, 27 Jul 2007 12:26:22 +0000 (12:26 +0000)]
Work around bug in the moc when used as preprocessor for generating the bindings. -DFOO=1 is needed instead of -DFOO to make the <hash>if FOO conditional match.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-07-27 Patrick Hanna <phanna@email.unc.edu>
bdash [Fri, 27 Jul 2007 11:59:09 +0000 (11:59 +0000)]
2007-07-27  Patrick Hanna  <phanna@email.unc.edu>

        Reviewed by Darin Adler.

        Change PluginBase::refresh to be static and update PluginsFunc::callAsFunction accordingly. Now we no longer
        allocate an instance of a JSObject subclass on the stack which could lead to a crash during garbage collection.

        * bindings/js/kjs_navigator.cpp:
        (KJS::PluginsFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAlways define JSChar to be unsigned short for the Qt builds, to ensure compatibility...
hausmann [Fri, 27 Jul 2007 08:34:37 +0000 (08:34 +0000)]
Always define JSChar to be unsigned short for the Qt builds, to ensure compatibility with UChar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix snprintf hack for the Qt/Windows build with mingw-gcc. MingW has snprintf, so...
hausmann [Fri, 27 Jul 2007 08:34:27 +0000 (08:34 +0000)]
Fix snprintf hack for the Qt/Windows build with mingw-gcc. MingW has snprintf, so we don't need this helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the DocTypeStrings.cpp generation work with MingW. Cleaned it up to be a regular...
hausmann [Fri, 27 Jul 2007 08:34:13 +0000 (08:34 +0000)]
Make the DocTypeStrings.cpp generation work with MingW. Cleaned it up to be a regular extra compiler at the same time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation with Qt on Windows with MingW: Implemented currentThreadStackBase...
hausmann [Fri, 27 Jul 2007 08:34:00 +0000 (08:34 +0000)]
Fix compilation with Qt on Windows with MingW: Implemented currentThreadStackBase() for this platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation with Qt on Windows with MingW: The MingW headers do not provide a...
hausmann [Fri, 27 Jul 2007 08:33:49 +0000 (08:33 +0000)]
Fix compilation with Qt on Windows with MingW: The MingW headers do not provide a prototype for a reentrant version of localtime. But since we don't use multiple threads for the Qt build we can use the plain localtime() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMingW build fixes: Do the "OBJECTS_TRAILING_SLASH" trick not only for win32-msvc...
hausmann [Fri, 27 Jul 2007 08:33:39 +0000 (08:33 +0000)]
MingW build fixes: Do the "OBJECTS_TRAILING_SLASH" trick not only for win32-msvc but for all win32 mkspecs. Added LIB/INCLUDE hack from Qt to make us pick up 3rdparty libraries such as libxml from these environment variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build-webkit for the Qt build on Windows with msvc/nmake by trying to detect...
hausmann [Fri, 27 Jul 2007 08:33:27 +0000 (08:33 +0000)]
Fix build-webkit for the Qt build on Windows with msvc/nmake by trying to detect the Qt mkspec and using "nmake" instead of "make" as build command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse $(MOVE) instead of mv to eliminated the shell dependency and replaced the long...
hausmann [Fri, 27 Jul 2007 08:33:17 +0000 (08:33 +0000)]
Use $(MOVE) instead of mv to eliminated the shell dependency and replaced the long shell line to call bison and modify the css grammar file with a few lines of portable perl code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplemented currentTime() in the interpreter by using QDateTime, so that we don't...
hausmann [Fri, 27 Jul 2007 08:33:05 +0000 (08:33 +0000)]
Implemented currentTime() in the interpreter by using QDateTime, so that we don't need timeGetTime() on Windows and therefore also don't need to link against Winmm.dll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoExclude DumpRenderTree from the Qt build on Windows for now.
hausmann [Fri, 27 Jul 2007 08:32:54 +0000 (08:32 +0000)]
Exclude DumpRenderTree from the Qt build on Windows for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFor detecting the SVG support for the Qt build don't do the nm hack. Just always...
hausmann [Fri, 27 Jul 2007 08:32:45 +0000 (08:32 +0000)]
For detecting the SVG support for the Qt build don't do the nm hack. Just always claim SVG support is enabled because that's what it is. The nm hack doesn't work on Windows anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24708 268f45cc-cd09-0410-ab3c-d52691b4dbfc