WebKit-https.git
6 years agoRemove leftover files for ENABLE_PAGE_POPUP and ENABLE_CALENDAR_PICKER
tkent@chromium.org [Wed, 29 May 2013 22:16:40 +0000 (22:16 +0000)]
Remove leftover files for ENABLE_PAGE_POPUP and ENABLE_CALENDAR_PICKER
https://bugs.webkit.org/show_bug.cgi?id=116999

Reviewed by Anders Carlsson.

.:

* ManualTests/forms/calendar-picker-crash-by-type-change.html: Removed.
* ManualTests/forms/calendar-picker.html: Removed.
* ManualTests/forms/color-suggestion-picker.html: Removed.
* ManualTests/forms/date-suggestion-picker.html: Removed.

Source/WebCore:

* Resources/pagepopups/colorSuggestionPicker.css: Removed.
* Resources/pagepopups/colorSuggestionPicker.js: Removed.
* Resources/pagepopups/pickerCommon.css: Removed.
* Resources/pagepopups/pickerCommon.js: Removed.
* Resources/pagepopups/suggestionPicker.css: Removed.
* Resources/pagepopups/suggestionPicker.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix; remove unintentional semicolon.
jer.noble@apple.com [Wed, 29 May 2013 21:59:58 +0000 (21:59 +0000)]
Unreviewed build fix; remove unintentional semicolon.

* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge PODArea::Chunk into PODFreeListArena::FreeListChunk
andersca@apple.com [Wed, 29 May 2013 21:53:13 +0000 (21:53 +0000)]
Merge PODArea::Chunk into PODFreeListArena::FreeListChunk
https://bugs.webkit.org/show_bug.cgi?id=117000

Reviewed by Oliver Hunt.

* platform/PODArena.h:
(WebCore::PODArena::roundUp):
* platform/PODFreeListArena.h:
(PODFreeListArena):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):
(FreeListChunk):
(WebCore::PODFreeListArena::FreeListChunk::~FreeListChunk):
(WebCore::PODFreeListArena::FreeListChunk::allocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove some PODArena members to PODFreeListArena
andersca@apple.com [Wed, 29 May 2013 21:28:57 +0000 (21:28 +0000)]
Move some PODArena members to PODFreeListArena
https://bugs.webkit.org/show_bug.cgi?id=116993

Reviewed by Sam Weinig.

This is more work towards merging the two classes.

* platform/PODArena.h:
(PODArena):
* platform/PODFreeListArena.h:
(PODFreeListArena):
(WebCore::PODFreeListArena::PODFreeListArena):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Be consistent with allocation/deallocation behavior
bfulgham@apple.com [Wed, 29 May 2013 21:28:28 +0000 (21:28 +0000)]
[Windows] Be consistent with allocation/deallocation behavior
https://bugs.webkit.org/show_bug.cgi?id=116998

Reviewed by Anders Carlsson.

* WebPreferences.cpp:
(WebPreferences::setStringValue): Switch from using _wcsdup and
CFStringCreateWithCharactersNoCopy to just use the standard
CFStringCreateWithCharacters call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Scrubbing long movie files results in timeline snapping back to 0 during scrub.
jer.noble@apple.com [Wed, 29 May 2013 21:20:47 +0000 (21:20 +0000)]
[Mac] Scrubbing long movie files results in timeline snapping back to 0 during scrub.
https://bugs.webkit.org/show_bug.cgi?id=116986

Reviewed by Eric Carlson.

Source/WebCore:

Keep a count of the number of in-flight seek requests, and only issue a timeupdate
(which triggers a "seeked" event) when the final seek completes.

Test: media/video-seek-multiple.html

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):

LayoutTests:

* media/video-seek-multiple-expected.txt: Added.
* media/video-seek-multiple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomedia/video-pause-immediately.html test failing on some platforms.
jer.noble@apple.com [Wed, 29 May 2013 20:55:33 +0000 (20:55 +0000)]
media/video-pause-immediately.html test failing on some platforms.
https://bugs.webkit.org/show_bug.cgi?id=116985

video-pause-immediately.html will fail on some platforms if the <video> element issues a
timeupdate event at currentTime=0. Fix the test by only removing the timeupdate listener
inside the currentTime>0 conditional.

Reviewed by Eric Carlson.

* media/video-pause-immediately.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused code from PODArena
andersca@apple.com [Wed, 29 May 2013 20:43:33 +0000 (20:43 +0000)]
Remove unused code from PODArena
https://bugs.webkit.org/show_bug.cgi?id=116990

Reviewed by Sam Weinig.

PODArena is only used as a base class of PODFreeListArena so remove unused member functions and make all
members protected to make it impossible to use it without subclassing.

PODArena is a risky class to use since it doesn't return memory to the system unless the arena object is destroyed.
This was the reason why PODFreeListArea was added. An upcoming patch will merge PODArena with PODFreeListArena and
this is a small step towards that goal.

* platform/PODArena.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove custom binding for Clipboard setDragImage function
darin@apple.com [Wed, 29 May 2013 19:48:29 +0000 (19:48 +0000)]
Remove custom binding for Clipboard setDragImage function
https://bugs.webkit.org/show_bug.cgi?id=116422

Reviewed by Sam Weinig.

* bindings/js/JSClipboardCustom.cpp: Removed setDragImage binding.

* dom/Clipboard.cpp:
(WebCore::Clipboard::canSetDragImage): Added a condition that this is a drag
and drop clipboard. That used to be checked in the setDragImage binding.
(WebCore::Clipboard::setDragImage): Added a version that takes an Element
and calls through to the existing functions (in the legacy code path), or handles
both the Element and HTMLImageElement not-in-document cases (in the new code path).

* dom/Clipboard.h: Updated for changes above.

* dom/Clipboard.idl: Removed [Custom] from setDragImage.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag): Call the new setDragImage instead of the
old setDragImageElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReturn earlier if there's no session storage namespace
andersca@apple.com [Wed, 29 May 2013 19:43:30 +0000 (19:43 +0000)]
Return earlier if there's no session storage namespace
https://bugs.webkit.org/show_bug.cgi?id=116984
<rdar://problem/13976781>

Reviewed by Tim Horton.

If we can't find a session storage namespace, return before creating an entry in the m_storageAreasByConnection
hash map since then we'll crash trying to remove it later.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup AudioSourceNode.idl from WebKit build.
commit-queue@webkit.org [Wed, 29 May 2013 19:41:09 +0000 (19:41 +0000)]
Cleanup AudioSourceNode.idl from WebKit build.
https://bugs.webkit.org/show_bug.cgi?id=116905.

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-05-29
Reviewed by Darin Adler.

AudioSourceNode.idl is not part of WebAudio Specifications anymore.
AudioNode is inherited directly in all the audio source nodes.

Source/WebCore:

No new tests. Current test cases will cover all the scenarios.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/webaudio/AudioBufferSourceNode.h:
* Modules/webaudio/AudioBufferSourceNode.idl:
* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
* Modules/webaudio/AudioScheduledSourceNode.h:
* Modules/webaudio/AudioSourceNode.h: Removed.
* Modules/webaudio/AudioSourceNode.idl: Removed.
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
* Modules/webaudio/MediaElementAudioSourceNode.h:
(MediaElementAudioSourceNode):
* Modules/webaudio/MediaElementAudioSourceNode.idl:
* Modules/webaudio/MediaStreamAudioDestinationNode.idl:
* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
* Modules/webaudio/MediaStreamAudioSourceNode.h:
(MediaStreamAudioSourceNode):
* Modules/webaudio/MediaStreamAudioSourceNode.idl:
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/OscillatorNode.idl:
* Target.pri:
* WebCore.xcodeproj/project.pbxproj:

Tools:

* Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Add more cellular technologies into the NetworkInfo enum
commit-queue@webkit.org [Wed, 29 May 2013 19:32:06 +0000 (19:32 +0000)]
[BlackBerry] Add more cellular technologies into the NetworkInfo enum
https://bugs.webkit.org/show_bug.cgi?id=116982

PR 340189
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-05-29
Reviewed by Rob Buis.

Provide more specific bandwidth speeds on different network
services our devices provide.

* WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
(WebCore):
(WebCore::NetworkInfoClientBlackBerry::bandwidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize RenderText::offsetNext for 8 bit strings
abarth@webkit.org [Wed, 29 May 2013 19:26:16 +0000 (19:26 +0000)]
Optimize RenderText::offsetNext for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=116877

Reviewed by Darin Adler.

Source/WebCore:

Previously, this function was always upconverting strings to 16 bits in
order to create a cursorMovementIterator. This patch adds a fast path
for ASCII and Latin-1 strings, which don't need this complicated cursor
movement logic.

I ran into this code because nextOffset showed up as a memory pig on a
memory profile of Mobile Gmail.

Test: editing/selection/move-by-character-brute-force.html

* rendering/RenderText.cpp:
(WebCore::RenderText::previousOffset):
(WebCore::RenderText::nextOffset):

LayoutTests:

Test that caret movement works correctly for many code points.

* editing/selection/move-by-character-brute-force-expected.txt: Added.
* editing/selection/move-by-character-brute-force.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix more CMake GTK+ build issues after r150336
mrobinson@webkit.org [Wed, 29 May 2013 19:24:05 +0000 (19:24 +0000)]
Fix more CMake GTK+ build issues after r150336

.:

* Source/cmake/OptionsGTK.cmake: Actually set the new output name variable
and be sure to set WTF_USE_EGL when EGL is enabled.

Source/WebKit2:

* CMakeLists.txt: We need to allow for setting the WebProcess output name, since
WebKitGTK+ expects it to be called WebKitWebProcess.
* PlatformGTK.cmake: No longer set WebProcess_EXECUTABLE_NAME as it's been replaced
by WebKit2_WebProcess_OUTPUT_NAME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Andrew Lo to contributors.json
anlo@rim.com [Wed, 29 May 2013 19:23:58 +0000 (19:23 +0000)]
Add Andrew Lo to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=116981

Reviewed by Rob Buis.

Adding Andrew Lo to contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Correct copy command (form versus forms)
bfulgham@apple.com [Wed, 29 May 2013 18:57:48 +0000 (18:57 +0000)]
[Windows] Correct copy command (form versus forms)

* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.vcxproj/copyForwardingHeaders.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdding myself as a committer.
cavalcantii@gmail.com [Wed, 29 May 2013 18:57:02 +0000 (18:57 +0000)]
Adding myself as a committer.

Signed-off-by: Adenilson Cavalcanti <cavalcantii@gmail.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Fix style issues in BasicShapes
commit-queue@webkit.org [Wed, 29 May 2013 18:49:43 +0000 (18:49 +0000)]
[CSS Shapes] Fix style issues in BasicShapes
https://bugs.webkit.org/show_bug.cgi?id=116734

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-05-29
Reviewed by Alexandru Chiculita.

Fix indentation in BasicShapes.cpp, and change enums to respect the
style rules CamelCase instead of HAVING_UNDERSCORES.

No new tests, only style changes.

* css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
* css/CSSBasicShapes.cpp:
(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::equals):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInsetRectangle::equals):
* css/CSSBasicShapes.h:
(WebCore::CSSBasicShapeRectangle::type):
(WebCore::CSSBasicShapeInsetRectangle::type):
(WebCore::CSSBasicShapeCircle::type):
(WebCore::CSSBasicShapeEllipse::type):
(WebCore::CSSBasicShapePolygon::type):
* rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor):
* rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor):
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeRectangle::path):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapeInsetRectangle::path):
* rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::type):
(WebCore::BasicShapeCircle::type):
(WebCore::BasicShapeEllipse::type):
(WebCore::BasicShapePolygon::type):
(WebCore::BasicShapeInsetRectangle::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Handle Host-Only cookies
commit-queue@webkit.org [Wed, 29 May 2013 18:46:40 +0000 (18:46 +0000)]
[BlackBerry] Handle Host-Only cookies
https://bugs.webkit.org/show_bug.cgi?id=116969

PR 338809
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-05-29
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.

Adding support for host-only cookies (cookies with no
specified domains). These cookies should only be returned
when the host matches the cookie domain exactly.

Tested using Opera and Browser cookie test suite. Tested
that host cookies are being stored in it's own map using
Web Inspector.

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::findOrCreateCookieMap):
* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):
* platform/blackberry/ParsedCookie.h:
(WebCore::ParsedCookie::isHostOnly):
(ParsedCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] about:memory should use malloc_stats instead of mallinfo
yoli@rim.com [Wed, 29 May 2013 18:43:55 +0000 (18:43 +0000)]
[BlackBerry] about:memory should use malloc_stats instead of mallinfo
https://bugs.webkit.org/show_bug.cgi?id=96420

Reviewed by Rob Buis.

PR 206297
Use mallopt to get malloc_stats.

* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Notify client of selection deletion
commit-queue@webkit.org [Wed, 29 May 2013 18:39:28 +0000 (18:39 +0000)]
[BlackBerry] Notify client of selection deletion
https://bugs.webkit.org/show_bug.cgi?id=116843

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-29
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR342106
Our change guard was preventing caret change notification to be sent to IMF.
This put us out of state when a selection was deleted because it is not a simple
single character deletion. Ensure that selection deletions always send a caret
update.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::deleteSelection):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData
commit-queue@webkit.org [Wed, 29 May 2013 18:37:46 +0000 (18:37 +0000)]
[BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData
https://bugs.webkit.org/show_bug.cgi?id=116954

Patch by Rob Buis <rbuis@rim.com> on 2013-05-29
Reviewed by Carlos Garcia Campos.

PR 206152
Internally reviewed by Konrad Piascik

* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):
(BlackBerry::WebKit::memoryLivePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the size of DataVector in HTMLToken
rniwa@webkit.org [Wed, 29 May 2013 18:37:10 +0000 (18:37 +0000)]
Remove the size of DataVector in HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=116931

Reviewed by Sam Weinig.

Merge https://chromium.googlesource.com/chromium/blink/+/7977721e62c471bfa17b84d82cd5d8243a4eb9a9.

Shink HTMLToken by 1.5 kB

HTMLToken has an inline vector for buffering characters during tokenization. We
originally picked the inline capacity of this buffer somewhat arbitrarily. This
CL tunes the number based on a somewhat non-scientific browse of a number of
popular web sites.

I (abarth) instrumented content_shell to log the length of each complete DataVector. I
then browsed around a variety of web sites to collect data. The 99% percentile
of DataVector lengths was just shy of 250 characters. I rounded that up to 256
because powers of two are pretty. That means we'll malloc an external buffer
less than 1% of the time, which seems fine.

* html/parser/HTMLToken.h:
(HTMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening, managing media layout tests failures on GTK WK2.
zandobersek@gmail.com [Wed, 29 May 2013 18:28:40 +0000 (18:28 +0000)]
Unreviewed GTK gardening, managing media layout tests failures on GTK WK2.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Build correction after r150837
bfulgham@apple.com [Wed, 29 May 2013 18:15:00 +0000 (18:15 +0000)]
[Windows] Build correction after r150837

New 'forms' sub-folder of html needs to be included in
copy operations.

* WebCore.vcproj/copyForwardingHeaders.cmd: copy html/forms.
* WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Use correct
'obj32' folder for build output.
* WebCore.vcxproj/copyForwardingHeaders.cmd: copy html/forms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Radio Button UX updates.
commit-queue@webkit.org [Wed, 29 May 2013 17:47:26 +0000 (17:47 +0000)]
[BlackBerry] Radio Button UX updates.
https://bugs.webkit.org/show_bug.cgi?id=116881

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-29
Reviewed by Rob Buis.

BlackBerry PR 342322.
Internally Reviewed by Jeff Rogers.
Change images.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintRadio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Datetime string is not centred in form controls.
commit-queue@webkit.org [Wed, 29 May 2013 17:41:20 +0000 (17:41 +0000)]
[BlackBerry] Datetime string is not centred in form controls.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-29
Reviewed by Rob Buis.

BlackBerry PR 343512
Internally Reviewed by Jeff Rogers.

Adjust margin for inner text node of datetime form controls.

* css/themeBlackBerry.css:
(input::-webkit-date-and-time-value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Build correction after r150876
bfulgham@apple.com [Wed, 29 May 2013 17:23:44 +0000 (17:23 +0000)]
[Windows] Build correction after r150876

A clean build will now fail because the BaseMultipleFieldsDateAndTimeInputType sources have
been removed, but are still referenced in the project file.

* WebCore.vcxproj/WebCore.vcxproj: Remove reference to BaseMultipleFieldsDateAndTimeInputType
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening, managing accessibility layout tests failures on GTK WK2.
zandobersek@gmail.com [Wed, 29 May 2013 17:22:59 +0000 (17:22 +0000)]
Unreviewed GTK gardening, managing accessibility layout tests failures on GTK WK2.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport the 'onended' EventListener property for AudioBufferSourceNode and Oscillator...
jer.noble@apple.com [Wed, 29 May 2013 17:11:53 +0000 (17:11 +0000)]
Support the 'onended' EventListener property for AudioBufferSourceNode and OscillatorNode.
https://bugs.webkit.org/show_bug.cgi?id=116798

Reviewed by Eric Carlson.

Source/WebCore:

Tests: webaudio/audiobuffersource-ended.html
       webaudio/oscillator-ended.html

* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::setOnended): Set m_hasEndedListener.
(WebCore::AudioScheduledSourceNode::finish): Call notifyEndedDispatch on the main thread.
(WebCore::AudioScheduledSourceNode::notifyEndedDispatch): Call notifyEnded().
(WebCore::AudioScheduledSourceNode::notifyEnded): Call the onended event listener.
* Modules/webaudio/AudioScheduledSourceNode.h:
(WebCore::AudioScheduledSourceNode::onended): Added boilerplate.
* Modules/webaudio/AudioBufferSourceNode.idl: Added the onerror attribute.
* Modules/webaudio/OscillatorNode.idl: Ditto.

LayoutTests:

* webaudio/audiobuffersource-ended-expected.txt: Added.
* webaudio/audiobuffersource-ended.html: Added.
* webaudio/oscillator-ended-expected.txt: Added.
* webaudio/oscillator-ended.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Support parsing inset-rectangle shapes
commit-queue@webkit.org [Wed, 29 May 2013 16:54:39 +0000 (16:54 +0000)]
[CSS Shapes] Support parsing inset-rectangle shapes
https://bugs.webkit.org/show_bug.cgi?id=116638

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-05-29
Reviewed by Dean Jackson.

Source/WebCore:

Add parsing for inset-rectangle. It's very similar to parsing for
rectangle.

No new tests, updated existing tests to cover this.

* css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Add support for inset rectangles.
(WebCore::basicShapeForValue): Add support for inset rectangles.
* css/CSSBasicShapes.cpp:
(WebCore::buildInsetRectangleString): Create an inset-rectangle css
    string.
(WebCore::CSSBasicShapeInsetRectangle::cssText): Convert inset
    rectangle shape to a CSS string.
(WebCore::CSSBasicShapeInsetRectangle::equals): Compare two inset
    rectangles.
(WebCore::CSSBasicShapeInsetRectangle::serializeResolvingVariables):
    Create an inset rectangle string, with CSS variables resolved.
(WebCore::CSSBasicShapeInsetRectangle::hasVariableReference):
    Determine if this inset rectangle has any CSS Variable references.
* css/CSSBasicShapes.h:
(CSSBasicShapeInsetRectangle): Add inset rectangle class. This is a
    direct representation of the CSS property. All the methods below
    are just simple getters and setters, along with a construtor and a
    factory method.
(WebCore::CSSBasicShapeInsetRectangle::create):
(WebCore::CSSBasicShapeInsetRectangle::top):
(WebCore::CSSBasicShapeInsetRectangle::right):
(WebCore::CSSBasicShapeInsetRectangle::bottom):
(WebCore::CSSBasicShapeInsetRectangle::left):
(WebCore::CSSBasicShapeInsetRectangle::radiusX):
(WebCore::CSSBasicShapeInsetRectangle::radiusY):
(WebCore::CSSBasicShapeInsetRectangle::setTop):
(WebCore::CSSBasicShapeInsetRectangle::setRight):
(WebCore::CSSBasicShapeInsetRectangle::setBottom):
(WebCore::CSSBasicShapeInsetRectangle::setLeft):
(WebCore::CSSBasicShapeInsetRectangle::setRadiusX):
(WebCore::CSSBasicShapeInsetRectangle::setRadiusY):
(WebCore::CSSBasicShapeInsetRectangle::type):
(WebCore::CSSBasicShapeInsetRectangle::CSSBasicShapeInsetRectangle):
(WebCore):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseBasicShapeInsetRectangle): Parse the
    inset-rectangle CSS property and create a
    CSSBasicShapeInsetRectangle.
(WebCore::CSSParser::parseBasicShape): Add a call to parse
    inset-rectangle.
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Disable
    inset-rectangles, since only the parsing has been implemented so
    far.
* rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Disable
    inset-rectangles, since only the parsing has been implemented so
    far.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeInsetRectangle::path): Calculate the Path for an
    inset-rectangle.
(WebCore::BasicShapeInsetRectangle::blend): Blend two inset rectangles
    together at a point depending on the "progress" and return the
    blended rectangle.
* rendering/style/BasicShapes.h:
(BasicShapeInsetRectangle): Add higher level inset rectangle class.
    This is used outside of the CSS representation. The methods below
    are just simple getters and setters, along with a constructor and
    a factory method.
(WebCore::BasicShapeInsetRectangle::create):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):
(WebCore::BasicShapeInsetRectangle::type):
(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle):

LayoutTests:

Updated to test for inset-rectangle cases.

* fast/exclusions/parsing/parsing-shape-inside-expected.txt:
* fast/exclusions/parsing/parsing-shape-lengths-expected.txt:
* fast/exclusions/parsing/script-tests/parsing-shape-lengths.js:
* fast/exclusions/parsing/script-tests/parsing-test-utils.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove computed style extraction out of CSSComputedStyleDeclaration.
akling@apple.com [Wed, 29 May 2013 16:30:49 +0000 (16:30 +0000)]
Move computed style extraction out of CSSComputedStyleDeclaration.
<http://webkit.org/b/116965>

Reviewed by Antti Koivisto.

Make it possible to get computed CSSValues from a Node without creating a CSSOM
style declaration object.

The bulk of the logic moves to a new class; ComputedStyleExtractor, which can be created
on the stack, and takes the same setup variables as CSSComputedStyleDeclaration.

This is prep to enable futuristic optimizations in editing and elsewhere.

* css/CSSComputedStyleDeclaration.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

    Create a ComputedStyleExtractor to do the work!

(WebCore::ComputedStyleExtractor::currentColorOrValidColor):
(WebCore::ComputedStyleExtractor::valueForFilter):
(WebCore::ComputedStyleExtractor::ComputedStyleExtractor):
(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::ComputedStyleExtractor::styledNode):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForShorthandProperties):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForSidesShorthand):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForGridShorthand):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor):
(WebCore::ComputedStyleExtractor::svgPropertyValue):

    Moved all of these from CSSComputedStyleDeclaration to the new class.

* rendering/style/RenderStyle.h:
* svg/SVGPaint.h:

    Have these two befriend ComputedStyleExtractor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother attempt to fix windows build.
antti@apple.com [Wed, 29 May 2013 16:22:49 +0000 (16:22 +0000)]
Another attempt to fix windows build.

Not reviewed.

* css/CSSFontSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix window build.
antti@apple.com [Wed, 29 May 2013 16:09:45 +0000 (16:09 +0000)]
Try to fix window build.

Not reviewed.

* platform/graphics/FontCache.h:
(WebCore::FontDescriptionFontDataCacheKey::computeHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the firing of m_paintRelatedMilestonesTimer
simon.fraser@apple.com [Wed, 29 May 2013 16:04:12 +0000 (16:04 +0000)]
Fix the firing of m_paintRelatedMilestonesTimer
https://bugs.webkit.org/show_bug.cgi?id=116919

Reviewed by Tim Horton.

r150671 intended to change things so that paint-related milestones
only fire when painting has actually happened, so that WebKit clients
are notified when we actually have bits to present.

However, it made an incorrect assumption that painting would happen
inside of flushCompositingState(). This is not the case; flushCompositingState()
will just dirty CALayers, and later on Core Animation will ask us to paint them.

This incorrect assumption meant that we would never start the
m_paintRelatedMilestonesTimer, so never fire the milestones.

Fix by starting the m_paintRelatedMilestonesTimer via the RenderLayerBacking
paintContents call back. At this time we know we're painting, so we can both
set the FrameView's last paint time, and start up the timer. We also only
want to start the timer if there are pending milestones.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didPaintBacking):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoShare FontGlyphs
antti@apple.com [Wed, 29 May 2013 15:49:40 +0000 (15:49 +0000)]
Share FontGlyphs
https://bugs.webkit.org/show_bug.cgi?id=116863

Reviewed by Anreas Kling.

Style system generates many Font objects that are identical or similar enough to have identical FontGlyphs.
We can figure out that the FontGlyphs are going to be the same and share them. This reduces memory usage.
It also improves performance as the glyph cache and the width cache hang from FontGlyphs and their hit rate
increases.

On PLT3 this takes the number of live FontGlyphs at the end from 40k+ to <1k. Width cache hit rate improves
from ~42% to ~55%.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):

    Add unique id we can use in cache key.

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

    Bump the version number on invalidation so we don't reuse cache entries after web font is loaded.

(WebCore::CSSFontSelector::resolvesFamilyFor):

    Test if FontSelector is needed for resolving a particular FontDescription.

* css/CSSFontSelector.h:
* page/Settings.cpp:
(WebCore::setGenericFontFamilyMap):

    Invalidate the cache if standard font settings change.

* platform/graphics/Font.cpp:
(FontGlyphsCacheKey):
(FontGlyphsCacheEntry):
(WebCore::operator==):
(WebCore::fontGlyphsCache):
(WebCore::invalidateFontGlyphsCache):
(WebCore::makeFontSelectorFlags):
(WebCore::makeFontGlyphsCacheKey):

    The cache key consists of

    - all families.
    - shared key with the lower level FontData cache (FontCache), guaranteeing FontDatas would be identical.
    - font selector specific keys.

    These guarantee the FontData will be identical.

(WebCore::computeFontGlyphsCacheHash):
(WebCore::pruneUnreferencedFromFontGlyphsCache):

    Don't accumulate unused entries.

(WebCore::retrieveOrAddCachedFontGlyphs):
(WebCore::Font::update):
* platform/graphics/Font.h:
* platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::operator==):
(FontPlatformDataCacheKey):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionFontDataCacheKey::FontDescriptionFontDataCacheKey):
(WebCore::FontDescriptionFontDataCacheKey::makeFlagKey):
(WebCore::FontDescriptionFontDataCacheKey::operator==):
(WebCore::FontDescriptionFontDataCacheKey::operator!=):
(WebCore::FontDescriptionFontDataCacheKey::computeHash):

    Separate part of the key for sharing.

(FontDescriptionFontDataCacheKey):
* platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::releaseFontData):
* platform/graphics/FontFallbackList.h:
(WebCore::FontGlyphs::create):
(WebCore::FontGlyphs::~FontGlyphs):

    Remove invalidate(). If FontGlyphs needs invalidation it is reconstructed.

* platform/graphics/FontSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Use lazily-backed backingstore tiles
commit-queue@webkit.org [Wed, 29 May 2013 15:37:00 +0000 (15:37 +0000)]
[BlackBerry] Use lazily-backed backingstore tiles
https://bugs.webkit.org/show_bug.cgi?id=116879
Internal PR 344523

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-05-29
Reviewed by Carlos Garcia Campos.
Informally reviewed by Arvid Nilsson and Mike Lattanzio.

As a consequence, also don't use fixed-size
shared pixmap buffers for these tiles anymore.

* WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
* WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::initialize):
* WebKitSupport/SurfacePool.h:
(SurfacePool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Add all plugins.qmltypes files and update qmldir files
hausmann@webkit.org [Wed, 29 May 2013 15:24:24 +0000 (15:24 +0000)]
[Qt] Add all plugins.qmltypes files and update qmldir files

Patch by Liang Qi <liang.qi@digia.com> on 2013-05-29
Reviewed by Simon Hausmann.

These are required for code completion in Qt Creator.

* declarative/plugins.qmltypes: Added.
* declarative/qmldir:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused file PlatformGestureEvent.cpp
thakis@chromium.org [Wed, 29 May 2013 15:23:37 +0000 (15:23 +0000)]
Remove unused file PlatformGestureEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=116894

Reviewed by Darin Adler.

This was added in https://bugs.webkit.org/show_bug.cgi?id=49345 but
not removed in https://bugs.webkit.org/show_bug.cgi?id=77492 which
removed most of that code again.

* platform/PlatformGestureRecognizer.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do...
marcelo.lira@openbossa.org [Wed, 29 May 2013 14:34:19 +0000 (14:34 +0000)]
[WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
https://bugs.webkit.org/show_bug.cgi?id=116683

Reviewed by Noam Rosenthal.

Source/WebKit2:

WKViewUserViewportToContents now converts WebView coordinates to
page contents coordinates, taking into account factors as content
scale and scroll, and also device scale.

The function WKViewUserViewportToScene was added to convert WebView
coordinates to the coordinates of the canvas/scene where the view
is drawn, and EwkView was fixed to use it, instead of
WKViewUserViewportToContents.

* UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewUserViewportToScene):
* UIProcess/API/C/CoordinatedGraphics/WKView.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::createGLSurface):
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::userViewportToContents):
(WebKit):
(WebKit::WebView::userViewportToScene):
(WebKit::WebView::transformToScene):
* UIProcess/CoordinatedGraphics/WebView.h:
(WebView):

Tools:

A coordinates conversion test for WKViewUserViewportToContents was
added to WebKit2 API tests.

* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Unreviewed gardening. Unskipping passing test.
zarvai@inf.u-szeged.hu [Wed, 29 May 2013 14:21:20 +0000 (14:21 +0000)]
[Qt][WK2] Unreviewed gardening. Unskipping passing test.
https://bugs.webkit.org/show_bug.cgi?id=70907
https://bugs.webkit.org/show_bug.cgi?id=93231
https://bugs.webkit.org/show_bug.cgi?id=89645
https://bugs.webkit.org/show_bug.cgi?id=109291
https://bugs.webkit.org/show_bug.cgi?id=92543
https://bugs.webkit.org/show_bug.cgi?id=82895
https://bugs.webkit.org/show_bug.cgi?id=87395
https://bugs.webkit.org/show_bug.cgi?id=87631
https://bugs.webkit.org/show_bug.cgi?id=89473
https://bugs.webkit.org/show_bug.cgi?id=92490

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-29

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Update my info.
commit-queue@webkit.org [Wed, 29 May 2013 14:18:26 +0000 (14:18 +0000)]
Unreviewed. Update my info.

Patch by Yong Li <yong.li.webkit@outlook.com> on 2013-05-29

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[texmap][GStreamer][GTK] Composited Video support
commit-queue@webkit.org [Wed, 29 May 2013 13:24:51 +0000 (13:24 +0000)]
[texmap][GStreamer][GTK] Composited Video support
https://bugs.webkit.org/show_bug.cgi?id=86410

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-05-29
Reviewed by Noam Rosenthal.

Enable the video accelerated compositing using the WebKit's
TextureMapper.

This patch does not use hardware accelerated video decoding. It
provides a generic path for system memory buffers.

This new functionality is only available when the coordinated graphics
system is not used.

No new tests, already covered by existing tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): update the
texture content with the new received video buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): choose to
use the accelerated compositing or the normal code path
(WebCore::MediaPlayerPrivateGStreamerBase::paint): if accelerated
compositing is used this method is halted.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper): get
a texture from the pool and draws it if it is already available.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer): returns itself
(WebCore::MediaPlayerPrivateGStreamerBase::supportsAcceleratedRendering):
returns true

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 29 May 2013 13:19:34 +0000 (13:19 +0000)]
Unreviewed GTK gardening.
Adding flaky failure expectations for two perf/ layout tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 29 May 2013 12:53:56 +0000 (12:53 +0000)]
Unreviewed GTK gardening.

* platform/gtk-wk1/TestExpectations: Remove an unnecessary expectation.
* platform/gtk/TestExpectations: Add timeout expectations for tests that are currently timing out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Add myself as committer in contributors.json.
dongseong.hwang@intel.com [Wed, 29 May 2013 12:43:28 +0000 (12:43 +0000)]
Unreviewed. Add myself as committer in contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Update NEWS and Versions.m4 for 2.1.1 release.
carlosgc@webkit.org [Wed, 29 May 2013 12:19:36 +0000 (12:19 +0000)]
Unreviewed. Update NEWS and Versions.m4 for 2.1.1 release.

.:

* Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 2.1.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Wed, 29 May 2013 12:15:53 +0000 (12:15 +0000)]
Unreviewed. Fix make distcheck.

.:

* GNUmakefile.am: Add WebKitFeatures.h and WebKitFeatures.txt to
DISTCLEANFILES.

Source/WebKit2:

* GNUmakefile.am: Add WebCoreLayerGtk2.a to DISTCLEANFILES.

Tools:

* TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
DISTCLEANFILES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed: update my email address in contributors.json.
commit-queue@webkit.org [Wed, 29 May 2013 11:51:32 +0000 (11:51 +0000)]
Unreviewed: update my email address in contributors.json.

Patch by Mary Wu <mawu@blackberry.com> on 2013-05-29

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Missing files from build after r150853
commit-queue@webkit.org [Wed, 29 May 2013 11:01:20 +0000 (11:01 +0000)]
[Qt] Missing files from build after r150853
https://bugs.webkit.org/show_bug.cgi?id=116932

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogonác.

* Target.pri: Added missing include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the...
commit-queue@webkit.org [Wed, 29 May 2013 10:57:07 +0000 (10:57 +0000)]
[CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the scroll thumbs with the mouse
https://bugs.webkit.org/show_bug.cgi?id=113703

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-05-29
Reviewed by Darin Adler.

Source/WebCore:

The point inside a box that's inside a region has its coordinates relative to the region, not the FlowThread
that is its container in the RenderObject tree.

Previously, the coordinates were computed relatively to the FlowThread which doesn't really have a location in
the page.

Tests: fast/regions/drag-scrollbars-of-content.html
       fast/regions/hover-in-second-region.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

LayoutTests:

* fast/regions/drag-scrollbars-of-content-expected.html: Added.
* fast/regions/drag-scrollbars-of-content.html: Added.
* fast/regions/hover-in-second-region-expected.html: Added.
* fast/regions/hover-in-second-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix dumb typo in r150879.
akling@apple.com [Wed, 29 May 2013 10:20:40 +0000 (10:20 +0000)]
Fix dumb typo in r150879.

* editing/htmlediting.cpp:
(WebCore::nextLeafNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove leaf Node traversal helpers to htmlediting.cpp
akling@apple.com [Wed, 29 May 2013 08:57:42 +0000 (08:57 +0000)]
Move leaf Node traversal helpers to htmlediting.cpp
<http://webkit.org/b/116940>

Reviewed by Antti Koivisto.

Move Node::previousLeafNode() and Node::nextLeafNode() to htmlediting.cpp along with their helpers.
Fixes an 8-year old FIXME. \o/

* dom/Node.h:
* dom/Node.cpp:
* dom/Position.cpp:
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
* editing/VisibleUnits.cpp:
(WebCore::previousLeafWithSameEditability):
(WebCore::nextLeafWithSameEditability):
* editing/htmlediting.h:
* editing/htmlediting.cpp:
(WebCore::previousNodeConsideringAtomicNodes):
(WebCore::nextNodeConsideringAtomicNodes):
(WebCore::previousLeafNode):
(WebCore::nextLeafNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Missing files from build after r150853
commit-queue@webkit.org [Wed, 29 May 2013 08:56:07 +0000 (08:56 +0000)]
[Qt] Missing files from build after r150853
https://bugs.webkit.org/show_bug.cgi?id=116932

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogonác.

* Target.pri: Added the CFURLExtras.{cpp,h} files to the projectfile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPresentationAttributeCacheCleaner::m_hitCount is never initialized
rniwa@webkit.org [Wed, 29 May 2013 08:53:34 +0000 (08:53 +0000)]
PresentationAttributeCacheCleaner::m_hitCount is never initialized
https://bugs.webkit.org/show_bug.cgi?id=116946

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/70be7ddc41141ef6dec7795d37842c27dab2e194.

* dom/StyledElement.cpp:
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
tkent@chromium.org [Wed, 29 May 2013 08:47:46 +0000 (08:47 +0000)]
Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
https://bugs.webkit.org/show_bug.cgi?id=116796

Reviewed by Ryosuke Niwa.

Source/WebCore:

This feature was used only by Chromium port.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/html.css:
(input::-webkit-date-and-time-value):
* dom/Element.cpp:
* dom/Element.h:
* html/BaseChooserOnlyDateAndTimeInputType.cpp:
* html/BaseChooserOnlyDateAndTimeInputType.h:
* html/BaseMultipleFieldsDateAndTimeInputType.cpp: Removed.
* html/BaseMultipleFieldsDateAndTimeInputType.h: Removed.
* html/DateInputType.cpp:
* html/DateInputType.h:
(DateInputType):
* html/DateTimeFieldsState.cpp: Removed.
* html/DateTimeFieldsState.h: Removed.
* html/DateTimeInputType.cpp:
* html/DateTimeInputType.h:
(DateTimeInputType):
* html/DateTimeLocalInputType.cpp:
* html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
* html/InputType.h:
(InputType):
* html/MonthInputType.cpp:
* html/MonthInputType.h:
(MonthInputType):
* html/TimeInputType.cpp:
* html/TimeInputType.h:
(TimeInputType):
* html/WeekInputType.cpp:
* html/WeekInputType.h:
(WeekInputType):
* html/shadow/ClearButtonElement.cpp: Removed.
* html/shadow/ClearButtonElement.h: Removed.
* html/shadow/DateTimeEditElement.cpp: Removed.
* html/shadow/DateTimeEditElement.h: Removed.
* html/shadow/DateTimeFieldElement.cpp: Removed.
* html/shadow/DateTimeFieldElement.h: Removed.
* html/shadow/DateTimeFieldElements.cpp: Removed.
* html/shadow/DateTimeFieldElements.h: Removed.
* html/shadow/DateTimeNumericFieldElement.cpp: Removed.
* html/shadow/DateTimeNumericFieldElement.h: Removed.
* html/shadow/DateTimeSymbolicFieldElement.cpp: Removed.
* html/shadow/DateTimeSymbolicFieldElement.h: Removed.
* html/shadow/PickerIndicatorElement.cpp: Removed.
* html/shadow/PickerIndicatorElement.h: Removed.
* page/ChromeClient.h:
(ChromeClient):
* platform/LocalizedStrings.h:
(WebCore):
* platform/text/PlatformLocale.cpp:
* platform/text/PlatformLocale.h:
(Locale):
* rendering/RenderDetailsMarker.cpp:
* rendering/RenderDetailsMarker.h:
* rendering/RenderObject.h:
(RenderObject):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

* wtf/FeatureDefines.h:

LayoutTests:

* fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-focus.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/date-multiple-fields/date-multiple-fields-wheel-event.html: Removed.
* fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput.html: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event.html: Removed.
* fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/month-multiple-fields/month-multiple-fields-wheel-event.html: Removed.
* fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-change-type.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus-style-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-focus.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-static-relayout-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-step-attribute-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-step-attribute.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html: Removed.
* fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-wheel-event-expected.txt: Removed.
* fast/forms/week-multiple-fields/week-multiple-fields-wheel-event.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove SnowLeopard expected results.
rniwa@webkit.org [Wed, 29 May 2013 08:36:19 +0000 (08:36 +0000)]
Remove SnowLeopard expected results.

Rubber-stamped by Andreas Kling.

* platform/mac-snowleopard: Removed.
* platform/mac-snowleopard/animations: Removed.
* platform/mac-snowleopard/canvas: Removed.
* platform/mac-snowleopard/canvas/philip: Removed.
* platform/mac-snowleopard/canvas/philip/tests: Removed.
* platform/mac-snowleopard/compositing: Removed.
* platform/mac-snowleopard/compositing/color-matching: Removed.
* platform/mac-snowleopard/compositing/framesets: Removed.
* platform/mac-snowleopard/compositing/geometry: Removed.
* platform/mac-snowleopard/compositing/iframes: Removed.
* platform/mac-snowleopard/compositing/images: Removed.
* platform/mac-snowleopard/compositing/layer-creation: Removed.
* platform/mac-snowleopard/compositing/masks: Removed.
* platform/mac-snowleopard/compositing/overflow: Removed.
* platform/mac-snowleopard/compositing/reflections: Removed.
* platform/mac-snowleopard/compositing/repaint: Removed.
* platform/mac-snowleopard/compositing/scaling: Removed.
* platform/mac-snowleopard/compositing/shadows: Removed.
* platform/mac-snowleopard/compositing/tiling: Removed.
* platform/mac-snowleopard/compositing/transitions: Removed.
* platform/mac-snowleopard/compositing/video: Removed.
* platform/mac-snowleopard/compositing/visibility: Removed.
* platform/mac-snowleopard/compositing/webgl: Removed.
* platform/mac-snowleopard/css1: Removed.
* platform/mac-snowleopard/css1/box_properties: Removed.
* platform/mac-snowleopard/css1/cascade: Removed.
* platform/mac-snowleopard/css1/classification: Removed.
* platform/mac-snowleopard/css1/color_and_background: Removed.
* platform/mac-snowleopard/css1/font_properties: Removed.
* platform/mac-snowleopard/css1/formatting_model: Removed.
* platform/mac-snowleopard/css1/pseudo: Removed.
* platform/mac-snowleopard/css1/text_properties: Removed.
* platform/mac-snowleopard/css1/units: Removed.
* platform/mac-snowleopard/css2.1: Removed.
* platform/mac-snowleopard/css2.1/20110323: Removed.
* platform/mac-snowleopard/css3: Removed.
* platform/mac-snowleopard/css3/filters: Removed.
* platform/mac-snowleopard/css3/flexbox: Removed.
* platform/mac-snowleopard/css3/images: Removed.
* platform/mac-snowleopard/css3/selectors3: Removed.
* platform/mac-snowleopard/css3/selectors3/html: Removed.
* platform/mac-snowleopard/css3/selectors3/xhtml: Removed.
* platform/mac-snowleopard/css3/selectors3/xml: Removed.
* platform/mac-snowleopard/editing: Removed.
* platform/mac-snowleopard/editing/input: Removed.
* platform/mac-snowleopard/editing/inserting: Removed.
* platform/mac-snowleopard/editing/pasteboard: Removed.
* platform/mac-snowleopard/editing/selection: Removed.
* platform/mac-snowleopard/editing/unsupported-content: Removed.
* platform/mac-snowleopard/fast: Removed.
* platform/mac-snowleopard/fast/backgrounds: Removed.
* platform/mac-snowleopard/fast/backgrounds/repeat: Removed.
* platform/mac-snowleopard/fast/backgrounds/size: Removed.
* platform/mac-snowleopard/fast/block: Removed.
* platform/mac-snowleopard/fast/block/basic: Removed.
* platform/mac-snowleopard/fast/block/float: Removed.
* platform/mac-snowleopard/fast/block/margin-collapse: Removed.
* platform/mac-snowleopard/fast/block/positioning: Removed.
* platform/mac-snowleopard/fast/borders: Removed.
* platform/mac-snowleopard/fast/canvas: Removed.
* platform/mac-snowleopard/fast/css: Removed.
* platform/mac-snowleopard/fast/dom: Removed.
* platform/mac-snowleopard/fast/encoding: Removed.
* platform/mac-snowleopard/fast/forms: Removed.
* platform/mac-snowleopard/fast/forms/file: Removed.
* platform/mac-snowleopard/fast/forms/range: Removed.
* platform/mac-snowleopard/fast/gradients: Removed.
* platform/mac-snowleopard/fast/images: Removed.
* platform/mac-snowleopard/fast/inline: Removed.
* platform/mac-snowleopard/fast/layers: Removed.
* platform/mac-snowleopard/fast/lists: Removed.
* platform/mac-snowleopard/fast/multicol: Removed.
* platform/mac-snowleopard/fast/multicol/span: Removed.
* platform/mac-snowleopard/fast/multicol/vertical-lr: Removed.
* platform/mac-snowleopard/fast/multicol/vertical-rl: Removed.
* platform/mac-snowleopard/fast/overflow: Removed.
* platform/mac-snowleopard/fast/parser: Removed.
* platform/mac-snowleopard/fast/preloader: Removed.
* platform/mac-snowleopard/fast/reflections: Removed.
* platform/mac-snowleopard/fast/repaint: Removed.
* platform/mac-snowleopard/fast/replaced: Removed.
* platform/mac-snowleopard/fast/ruby: Removed.
* platform/mac-snowleopard/fast/selectors: Removed.
* platform/mac-snowleopard/fast/table: Removed.
* platform/mac-snowleopard/fast/text: Removed.
* platform/mac-snowleopard/fast/text/international: Removed.
* platform/mac-snowleopard/fast/text/whitespace: Removed.
* platform/mac-snowleopard/fast/writing-mode: Removed.
* platform/mac-snowleopard/fast/xsl: Removed.
* platform/mac-snowleopard/fonts: Removed.
* platform/mac-snowleopard/fullscreen: Removed.
* platform/mac-snowleopard/http: Removed.
* platform/mac-snowleopard/http/tests: Removed.
* platform/mac-snowleopard/http/tests/inspector: Removed.
* platform/mac-snowleopard/http/tests/security: Removed.
* platform/mac-snowleopard/http/tests/security/contentSecurityPolicy: Removed.
* platform/mac-snowleopard/http/tests/xmlhttprequest: Removed.
* platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps: Removed.
* platform/mac-snowleopard/mathml: Removed.
* platform/mac-snowleopard/media: Removed.
* platform/mac-snowleopard/platform: Removed.
* platform/mac-snowleopard/platform/mac: Removed.
* platform/mac-snowleopard/platform/mac/compositing: Removed.
* platform/mac-snowleopard/platform/mac/compositing/canvas: Removed.
* platform/mac-snowleopard/platform/mac/editing: Removed.
* platform/mac-snowleopard/platform/mac/editing/selection: Removed.
* platform/mac-snowleopard/platform/mac/fast: Removed.
* platform/mac-snowleopard/platform/mac/fast/loader: Removed.
* platform/mac-snowleopard/platform/mac/fast/text: Removed.
* platform/mac-snowleopard/platform/mac/fast/text/international: Removed.
* platform/mac-snowleopard/platform/mac/scrollbars: Removed.
* platform/mac-snowleopard/plugins: Removed.
* platform/mac-snowleopard/printing: Removed.
* platform/mac-snowleopard/scrollbars: Removed.
* platform/mac-snowleopard/sputnik: Removed.
* platform/mac-snowleopard/sputnik/Unicode: Removed.
* platform/mac-snowleopard/svg: Removed.
* platform/mac-snowleopard/svg/W3C-I18N: Removed.
* platform/mac-snowleopard/svg/W3C-SVG-1.1: Removed.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE: Removed.
* platform/mac-snowleopard/svg/as-background-image: Removed.
* platform/mac-snowleopard/svg/as-border-image: Removed.
* platform/mac-snowleopard/svg/as-image: Removed.
* platform/mac-snowleopard/svg/as-object: Removed.
* platform/mac-snowleopard/svg/batik: Removed.
* platform/mac-snowleopard/svg/batik/paints: Removed.
* platform/mac-snowleopard/svg/carto.net: Removed.
* platform/mac-snowleopard/svg/clip-path: Removed.
* platform/mac-snowleopard/svg/css: Removed.
* platform/mac-snowleopard/svg/custom: Removed.
* platform/mac-snowleopard/svg/dom: Removed.
* platform/mac-snowleopard/svg/dynamic-updates: Removed.
* platform/mac-snowleopard/svg/filters: Removed.
* platform/mac-snowleopard/svg/foreignObject: Removed.
* platform/mac-snowleopard/svg/hixie: Removed.
* platform/mac-snowleopard/svg/hixie/data-types: Removed.
* platform/mac-snowleopard/svg/hixie/error: Removed.
* platform/mac-snowleopard/svg/hixie/intrinsic: Removed.
* platform/mac-snowleopard/svg/hixie/mixed: Removed.
* platform/mac-snowleopard/svg/hixie/perf: Removed.
* platform/mac-snowleopard/svg/hixie/processing-model: Removed.
* platform/mac-snowleopard/svg/hixie/rendering-model: Removed.
* platform/mac-snowleopard/svg/hixie/text: Removed.
* platform/mac-snowleopard/svg/hixie/viewbox: Removed.
* platform/mac-snowleopard/svg/hixie/viewbox/preserveAspectRatio: Removed.
* platform/mac-snowleopard/svg/in-html: Removed.
* platform/mac-snowleopard/svg/overflow: Removed.
* platform/mac-snowleopard/svg/repaint: Removed.
* platform/mac-snowleopard/svg/text: Removed.
* platform/mac-snowleopard/svg/transforms: Removed.
* platform/mac-snowleopard/svg/webarchive: Removed.
* platform/mac-snowleopard/svg/wicd: Removed.
* platform/mac-snowleopard/svg/zoom: Removed.
* platform/mac-snowleopard/svg/zoom/page: Removed.
* platform/mac-snowleopard/tables: Removed.
* platform/mac-snowleopard/tables/mozilla: Removed.
* platform/mac-snowleopard/tables/mozilla/bugs: Removed.
* platform/mac-snowleopard/tables/mozilla/collapsing_borders: Removed.
* platform/mac-snowleopard/tables/mozilla/core: Removed.
* platform/mac-snowleopard/tables/mozilla/marvin: Removed.
* platform/mac-snowleopard/tables/mozilla/other: Removed.
* platform/mac-snowleopard/transforms: Removed.
* platform/mac-snowleopard/transforms/2d: Removed.
* platform/mac-snowleopard/transforms/3d: Removed.
* platform/mac-snowleopard/transforms/3d/general: Removed.
* platform/mac-snowleopard/transforms/3d/point-mapping: Removed.
* platform/mac-snowleopard/webarchive: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoadding myself to committers list
kalyan.kondapally@intel.com [Wed, 29 May 2013 08:23:10 +0000 (08:23 +0000)]
adding myself to committers list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove setFullScreenRendererSize and setFullScreenRendererBackgroundColor
rniwa@webkit.org [Wed, 29 May 2013 07:49:00 +0000 (07:49 +0000)]
Remove setFullScreenRendererSize and setFullScreenRendererBackgroundColor
https://bugs.webkit.org/show_bug.cgi?id=116914

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/508eb21a07f69ed38b9be9ff92fe75dcb907861f

* dom/Document.cpp:
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake WidgetHierarchyUpdatesSuspensionScope use swap instead of copy
rniwa@webkit.org [Wed, 29 May 2013 07:46:08 +0000 (07:46 +0000)]
Make WidgetHierarchyUpdatesSuspensionScope use swap instead of copy
https://bugs.webkit.org/show_bug.cgi?id=116927

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/1d577e1fd5c5716a06e4007e04fc3d9d0a88f5e4

This is equivalent behavior code that is unambiguously better performance. swap is O(1) time and memory,
copying a hash table is at least linear with the number of elements.

* rendering/RenderWidget.cpp:
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Document::nodeAbsIndex() and Document::nodeWithAbsIndex().
akling@apple.com [Wed, 29 May 2013 07:43:43 +0000 (07:43 +0000)]
Remove Document::nodeAbsIndex() and Document::nodeWithAbsIndex().

Rubber-stamped by Antti "Lucky" Koivisto.

* dom/Document.h:
* dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Clean up WebKit2 GNUmakefile.am
commit-queue@webkit.org [Wed, 29 May 2013 07:39:46 +0000 (07:39 +0000)]
[GTK] Clean up WebKit2 GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=116907

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-29
Reviewed by Martin Robinson.

Removed WebNotificationManagerProxy.messages.in after r150785.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFocusController should operate on Elements internally.
akling@apple.com [Wed, 29 May 2013 07:36:29 +0000 (07:36 +0000)]
FocusController should operate on Elements internally.
<http://webkit.org/b/116781>

Reviewed by Antti Koivisto.

Switch from Node* to Element* as much as possible inside FocusController.
Mostly mechanical, gets rid of some unnecessary isElementNode() checks and casts.

* page/FocusController.h:
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedElement):
(WebCore::isNonFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::shouldVisit):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementRecursively):
(WebCore::FocusController::findFocusableElement):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):
(WebCore::FocusController::setActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Mouse over an element does not trigger :hover state for parent when...
commit-queue@webkit.org [Wed, 29 May 2013 07:18:05 +0000 (07:18 +0000)]
[CSS Regions] Mouse over an element does not trigger :hover state for parent when the element is flowed in a region
https://bugs.webkit.org/show_bug.cgi?id=111749

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-29
Reviewed by Antti Koivisto.

Source/WebCore:

When searching for the hover ancestor and encountering a named flow thread,
the search will continue with the DOM ancestor of the top-most element
in the named flow thread.

Tests: fast/regions/hover-in-region-grandparent.html
       fast/regions/hover-in-region-parent-skip.html
       fast/regions/hover-in-region-parent-skip-inlines-anonymous.html
       fast/regions/hover-on-child-in-region.html
       fast/regions/hover-on-child-in-region-in-region.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::hoverAncestor):
* rendering/RenderObject.h:

LayoutTests:

* fast/regions/hover-in-region-grandparent-expected.txt: Added.
* fast/regions/hover-in-region-grandparent.html: Added.
* fast/regions/hover-in-region-parent-skip-expected.txt: Added.
* fast/regions/hover-in-region-parent-skip.html: Added.
* fast/regions/hover-in-region-parent-skip-inlines-anonymous-expected.txt: Added.
* fast/regions/hover-in-region-parent-skip-inlines-anonymous.html: Added.
* fast/regions/hover-on-child-in-region-expected.txt: Added.
* fast/regions/hover-on-child-in-region.html: Added.
* fast/regions/hover-on-child-in-region-in-region-expected.txt: Added.
* fast/regions/hover-on-child-in-region-in-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in WebCore::SubresourceLoader::releaseResources when connection fails
japhet@chromium.org [Wed, 29 May 2013 05:29:54 +0000 (05:29 +0000)]
Crash in WebCore::SubresourceLoader::releaseResources when connection fails
https://bugs.webkit.org/show_bug.cgi?id=87743

Don't do anything complicated in SubresourceLoader::releaseResources(),
just clear variables. With this patch, releaseResources() will still
assert in debug builds if it is called twice, but it will safely execute
in release.

Reviewed by Darin Adler.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::cleanupForError): Pull shared cleanup code out of didFail()
    and cancel() into a helper.
(WebCore::ResourceLoader::cancel): Merge a couple variables into an enum, check for
    reentrancy from within didCancel().
* loader/ResourceLoader.h: Replace m_calledWillCancel and m_cancelled with an enum.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading): Don't call ResourceLoader::didFinishLoading(),
    put finish() in the middle of the process.
(WebCore::SubresourceLoader::didFail): Don't call ResourceLoader::didFail(), put finish()
    in the middle of the process.
(WebCore::SubresourceLoader::didCancel):
(WebCore::SubresourceLoader::notifyDone): Do the non-trivial work previous done in releaseResources(),
    most importantly calling loadDone().
(WebCore::SubresourceLoader::releaseResources): Only do simple variable clearing here.
* loader/SubresourceLoader.h:
(SubresourceLoader):
* loader/cache/CachedResource.cpp: Split stopLoading() into cancelLoad() (which notifies clients)
    and clearLoader() (which just nulls m_loader).
* loader/cache/CachedResource.h:
* loader/chromium/ResourceLoaderChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed: Adding myself to committers list.
a.bah@samsung.com [Wed, 29 May 2013 05:29:54 +0000 (05:29 +0000)]
Unreviewed: Adding myself to committers list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Build fix after r150837
ryuan.choi@samsung.com [Wed, 29 May 2013 05:21:26 +0000 (05:21 +0000)]
[GTK] Build fix after r150837
https://bugs.webkit.org/show_bug.cgi?id=116904

Unreviewed build fix.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-28

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r150169): Images from file: URLs display after a delay even though they...
aestes@apple.com [Wed, 29 May 2013 04:56:08 +0000 (04:56 +0000)]
REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=116906
<rdar://problem/13991927>

Reviewed by Andreas Kling.

Writing a test for this is blocked on https://webkit.org/b/116199.

Some WebKit clients use JavaScript to preload images from disk so that
subsequent loads will display immediately from the memory cache. By not
caching non-HTTP sub-resources in memory, we break this common pattern.
This change restricts r150169 to only apply to cached main resources.
Sub-resources will again be cached indefinitely as they were prior to
r150169.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime): If this is a non-HTTP
main resource from a scheme that should not be cached indefinitely,
return 0 for the freshness lifetime. For other non-HTTP cached
resources, return an indefinite freshness lifetime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnimations do not restart after exiting page cache
dino@apple.com [Wed, 29 May 2013 03:14:10 +0000 (03:14 +0000)]
Animations do not restart after exiting page cache
https://bugs.webkit.org/show_bug.cgi?id=116900

Reviewed by Tim Horton.

Source/WebCore:

Animations are suspended as they enter the page cache, but
were not getting correctly resumed when exiting. The cause
was an error in r149576 which was checking a global flag for suspension
on the AnimationController and thus not trying to resume anything.

Test: animations/resume-after-page-cache.html

* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):

LayoutTests:

New test to make sure an animation will resume if it
enters and leaves the page cache.

* animations/resources/page-cache-helper.html: Added.
* animations/resume-after-page-cache-expected.txt: Added.
* animations/resume-after-page-cache.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDrag to move DOM nodes does not work
commit-queue@webkit.org [Wed, 29 May 2013 02:23:41 +0000 (02:23 +0000)]
Drag to move DOM nodes does not work
https://bugs.webkit.org/show_bug.cgi?id=116865

Do not block drag events on the WebKit 1 Web Inspector WebView.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-28
Reviewed by Timothy Hatcher.

* WebCoreSupport/WebInspectorClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Silence last crash to get bots green.
bfulgham@apple.com [Wed, 29 May 2013 00:19:51 +0000 (00:19 +0000)]
[Windows] Silence last crash to get bots green.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport multiple HRTFDatabases for different sample-rates
crogers@google.com [Tue, 28 May 2013 23:42:45 +0000 (23:42 +0000)]
Support multiple HRTFDatabases for different sample-rates
https://bugs.webkit.org/show_bug.cgi?id=116183

Reviewed by Kenneth Russell.

Adapted from Blink:
https://codereview.chromium.org/14636011/

This removes the limitation which required OfflineAudioContexts to be created at native sample-rate

* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::hrtfDatabaseLoader):
(AudioContext):
* Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::create):
* Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore):
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
* platform/audio/HRTFDatabaseLoader.h:
(HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::loaderMap):
* platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
(WebCore::HRTFPanner::pan):
* platform/audio/HRTFPanner.h:
(HRTFPanner):
* platform/audio/Panner.cpp:
(WebCore::Panner::create):
* platform/audio/Panner.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Windows build fix.
ap@apple.com [Tue, 28 May 2013 23:35:24 +0000 (23:35 +0000)]
    Windows build fix.

        * platform/cf/KURLCFNet.cpp:
        (WebCore::KURL::createCFURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Many css2.1 tests fail on Apple's Windows port.
bfulgham@apple.com [Tue, 28 May 2013 23:27:23 +0000 (23:27 +0000)]
[Windows] Many css2.1 tests fail on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=75707

Reviewed by Darin Adler.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Export the WebCore::directoryName method for use by DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Freeze when loading a particular page on washingtonpost.com with NetworkProce...
ap@apple.com [Tue, 28 May 2013 23:26:48 +0000 (23:26 +0000)]
    Freeze when loading a particular page on washingtonpost.com with NetworkProcess enabled
        https://bugs.webkit.org/show_bug.cgi?id=116887
        <rdar://problem/12965959>

        Reviewed by Darin Adler.

        * Shared/cf/ArgumentCodersCF.cpp:
        (CoreIPC::encode):
        (CoreIPC::decode):
        Fix for the bug: use good shared WebCore code to manipulate CFURLs. Also, added
        a FIXME about empty URLs.

        * Shared/API/c/cf/WKURLCF.cpp: (WKURLCreateWithCFURL): Fixed to not use
        CFURLGetString, as that could prevent loading certain resources, like ones with
        curly braces in resource specifiers. We want KURL normalization, not CFURL one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Many css2.1 tests fail on Apple's Windows port.
bfulgham@apple.com [Tue, 28 May 2013 23:26:47 +0000 (23:26 +0000)]
[Windows] Many css2.1 tests fail on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=75707

Reviewed by Darin Adler.

* WebKit.vcproj/WebKitExports.def.in: Export the
WebCore::directoryName method for DRT use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Many CSS2.1 tests fail under NRWT.
bfulgham@apple.com [Tue, 28 May 2013 23:18:04 +0000 (23:18 +0000)]
[Windows] Many CSS2.1 tests fail under NRWT.
https://bugs.webkit.org/show_bug.cgi?id=75707

Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-28
Reviewed by Darin Adler.

* DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback): Added
(addFontFallbackIfPresent): Added
(removeFontFallbackIfPresent): Added
(runTest): Set up/remove font fallbacks when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] NRWT reports failure for 'mac' test cases.
bfulgham@apple.com [Tue, 28 May 2013 22:59:03 +0000 (22:59 +0000)]
[Windows] NRWT reports failure for 'mac' test cases.
https://bugs.webkit.org/show_bug.cgi?id=116698

Reviewed by Ryosuke Niwa.

The Windows port falls back to the Mac port for many test results,
and so adds the mac and mac-wk2 to its set of fallbacks.
Unfortunately, NRWT thinks that this means that tests in these
folders should be executed, resulting in many failures on
Windows.

This change overloads the '_tests_for_other_platforms' method
to return a subset of the result fallback list so that we do
not attempt to execute Mac tests on Windows.

* Scripts/webkitpy/port/base.py:
(Port.test_search_path): Added. Defaults to just calling the
baseline_search_path method, which is how most ports behave.
(Port._test_for_other_platforms): Modified to call the new
test_search_path method.

* Scripts/webkitpy/port/win.py:
(WinPort.test_search_path): Added custom overload. Strips
out mac-specific test paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] More attempts to make the bot green.
bfulgham@apple.com [Tue, 28 May 2013 22:57:21 +0000 (22:57 +0000)]
[Windows] More attempts to make the bot green.

* platform/win/TestExpectations: Exclude another two flaky tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
timothy_horton@apple.com [Tue, 28 May 2013 22:40:05 +0000 (22:40 +0000)]
fast/js/date-DST-time-cusps.html fails after trac.webkit.org/changeset/150833
https://bugs.webkit.org/show_bug.cgi?id=116895

Unreviewed, add failing test expectation.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Put correct byteCompile symbol in file. Previous version
bfulgham@apple.com [Tue, 28 May 2013 22:22:27 +0000 (22:22 +0000)]
[Windows] Put correct byteCompile symbol in file. Previous version
had an extra 'i' appended to the end.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build fix. Remove ?byteCompile symbol that
bfulgham@apple.com [Tue, 28 May 2013 22:07:02 +0000 (22:07 +0000)]
[Windows] Unreviewed build fix.  Remove ?byteCompile symbol that
is no longer accessible during link.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRendering suppression extension tokens shouldn't be 0, should handle overflow
timothy_horton@apple.com [Tue, 28 May 2013 21:52:21 +0000 (21:52 +0000)]
Rendering suppression extension tokens shouldn't be 0, should handle overflow
https://bugs.webkit.org/show_bug.cgi?id=116886
<rdar://problem/14004474>

Reviewed by Darin Adler.

Don't use invalid HashSet values as tokens, and ensure that
we're not already using a token before returning it.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::extendIncrementalRenderingSuppression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCreate a html/forms subdirectory and move FileIconLoader there
andersca@apple.com [Tue, 28 May 2013 21:50:46 +0000 (21:50 +0000)]
Create a html/forms subdirectory and move FileIconLoader there
https://bugs.webkit.org/show_bug.cgi?id=116880

Reviewed by Jessie Berlin.

A lot (if not the majority) of files in html/ are forms related, so it makes sense to begin splitting
them out into a separate subdirectory, html/forms.

Begin my moving FileIconLoader from platform to html/forms. It is related to HTML forms (it's only used by
the file upload element), and is not really a platform abstraction so it doesn't belong in platform.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/forms/FileIconLoader.cpp: Renamed from Source/WebCore/platform/FileIconLoader.cpp.
* html/forms/FileIconLoader.h: Renamed from Source/WebCore/platform/FileIconLoader.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: WKView is unable to set AXFocused to YES and does not handle keyboard events...
cfleizach@apple.com [Tue, 28 May 2013 21:47:35 +0000 (21:47 +0000)]
AX: WKView is unable to set AXFocused to YES and does not handle keyboard events as expected
https://bugs.webkit.org/show_bug.cgi?id=116756

Reviewed by Tim Horton.

If AXFocused is set to true, but the WebView is not the first responder, then the call will
not do anything. This change asks the Chrome to make the WebView the first responder before
trying to set focus within the page.

Was not able to make a test, it requires on interplay between areas outside the web view.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoString(new Date(2010,10,1)) is wrong in KRAT, YAKT
barraclough@apple.com [Tue, 28 May 2013 21:45:52 +0000 (21:45 +0000)]
String(new Date(2010,10,1)) is wrong in KRAT, YAKT
https://bugs.webkit.org/show_bug.cgi?id=106750

Reviewed by Darin Adler.

* runtime/JSDateMath.cpp:
(JSC::msToGregorianDateTime):
    - Additional review comment fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build fix after r150833
bfulgham@apple.com [Tue, 28 May 2013 21:45:06 +0000 (21:45 +0000)]
[Windows] Unreviewed build fix after r150833

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
A CR/LF combination was lost in the file, combining two symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoString(new Date(2010,10,1)) is wrong in KRAT, YAKT
barraclough@apple.com [Tue, 28 May 2013 21:33:51 +0000 (21:33 +0000)]
String(new Date(2010,10,1)) is wrong in KRAT, YAKT
https://bugs.webkit.org/show_bug.cgi?id=106750

Reviewed by Darin Adler.

First part of a fix, simplfy date handling code, instead of operating separately
on the UTC-standard and standard-DST offsets, just generate a combined UTC-local
offset (this is what we actually need, and what the OS gives us).

../JavaScriptCore:

* runtime/JSDateMath.cpp:
(JSC::getLocalTimeOffset):
    - removed getUTCOffset, converted getDSTOffset -> getLocalTimeOffset
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
    - call getLocalTimeOffset instead of getUTCOffset/getDSTOffset
* runtime/VM.cpp:
(JSC::VM::resetDateCache):
    - removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache
* runtime/VM.h:
(JSC::LocalTimeOffsetCache::LocalTimeOffsetCache):
(JSC::LocalTimeOffsetCache::reset):
(LocalTimeOffsetCache):
    - removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache

../WTF:

* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
(WTF::calculateDSTOffset):
    - made static, now not called from outside of this file.
(WTF::calculateLocalTimeOffset):
    - This combines the 2038 related adjustment from calculateDSTOffset with the
      maxUnixTime adjustment from calculateDSTOffsetSimple. Then, if HAVE(TM_GMTOFF)
      just call getLocalTime, if not use calculateUTCOffset/calculateDSTOffset.
(WTF::parseDateFromNullTerminatedCharacters):
    - call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
* wtf/DateMath.h:
(WTF::LocalTimeOffset::LocalTimeOffset):
(LocalTimeOffset):
(WTF::LocalTimeOffset::operator==):
    - new struct type, a tuple of UTC-local offset & isDST flag.
    - replaced calculateUTCOffset/calculateDSTOffset with calculateLocalTimeOffset
* wtf/GregorianDateTime.cpp:
(WTF::GregorianDateTime::setToCurrentLocalTime):
    - call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agor150199 is very wrong
mhahnenberg@apple.com [Tue, 28 May 2013 21:18:44 +0000 (21:18 +0000)]
r150199 is very wrong
https://bugs.webkit.org/show_bug.cgi?id=116876

JSValue needs to protect its internal JSValueRef.

Reviewed by Darin Adler.

* API/JSValue.mm:
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
* API/tests/testapi.mm: Added a simple test to make sure that we protect the
underlying JavaScript value across garbage collections.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Silence a few failures to get bot green.
bfulgham@apple.com [Tue, 28 May 2013 21:04:14 +0000 (21:04 +0000)]
[Windows] Silence a few failures to get bot green.
https://bugs.webkit.org/show_bug.cgi?id=116564

* platform/win/TestExpectations: Disable some tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::reposition...
jer.noble@apple.com [Tue, 28 May 2013 20:17:47 +0000 (20:17 +0000)]
Crash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::repositionGenericCue + 154
https://bugs.webkit.org/show_bug.cgi?id=116882

Reviewed by Eric Carlson.

Remove an inappropriate assert. No cues coming through repositionGenericCue will be WebVTT ones.

* rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::repositionGenericCue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix line endings in test added in r150602
robert@webkit.org [Tue, 28 May 2013 18:55:36 +0000 (18:55 +0000)]
Fix line endings in test added in r150602

Unreviewed.

* fast/css/text-overflow-ellipsis-behind-floats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] GraphicsContext: add missing definitions.
commit-queue@webkit.org [Tue, 28 May 2013 18:46:05 +0000 (18:46 +0000)]
[BlackBerry] GraphicsContext: add missing definitions.
https://bugs.webkit.org/show_bug.cgi?id=115515

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-28
Reviewed by Rob Buis.

* platform/graphics/GraphicsContext.h:
(Graphics):
Add definition for PlatformGraphicsContext.
* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
Include RoundedRect.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
anilsson@rim.com [Tue, 28 May 2013 18:40:51 +0000 (18:40 +0000)]
[BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
https://bugs.webkit.org/show_bug.cgi?id=116604

Reviewed by Carlos Garcia Campos.

Source/WebCore:

PR 273550, 99638

Remove the "get" prefix from getters in the WebKit- and compositing-
thread layer classes, as well as LayerRendererSurface. Clarify which
geometry-related getters return normalized device coordinates by adding
a comment.

Also remove dead code related to LayerData::m_holePunchClipRect, which
was part of an eventually disabled fix for video clipping in iframes,
PR 99638. Since we now use AC layers for iframes, the bug is no longer
reproducible, and the dead code will never need to be enabled again.

No change in behavior, no new tests.

* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::LayerCompositingThread::transformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::sublayers): Removed "get" prefix
(LayerCompositingThread):
(WebCore::LayerCompositingThread::boundingBox): Renamed from "getDrawRect"
(WebCore::LayerCompositingThread::transformedBounds): Removed "get" prefix
(WebCore::LayerCompositingThread::transformedHolePunchRect): Removed "get" prefix
* platform/graphics/blackberry/LayerData.h:
(LayerData): Removed unused data member "m_holePunchClipRect"
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::prepareFrameRecursive):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::collect3DPreservingLayers):
(WebCore::LayerRenderer::compositeLayersRecursive):
* platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::boundingBox):
* platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::boundingBox): Renamed from "drawRect" because that sounds like a verb, and this is a getter
* platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::sublayers): Removed "get" prefix
* platform/graphics/blackberry/VideoLayerWebKitThread.cpp:
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::boundsChanged):

Source/WebKit/blackberry:

Adapt to the removal of "get" prefix from getters in the WebKit- and
compositing-thread layer classes.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMade AudioNode an EventTarget
jer.noble@apple.com [Tue, 28 May 2013 17:54:20 +0000 (17:54 +0000)]
Made AudioNode an EventTarget
https://bugs.webkit.org/show_bug.cgi?id=116871

Source/WebCore:

Merge: https://chromium.googlesource.com/chromium/blink/+/ef37484162ddb95d677dcfdcdd778ec60590928b

Reviewed by Darin Adler.

Tests: webaudio/audionode-expected.txt:
       webaudio/audionode.html:

Add the requisite boilerplate to allow AudioNode to become an EventTarget. Remove
all that same boilerplate from ScriptProcessorNode now that it's base class
is an EventTarget.

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::interfaceName): Added boilerplate.
(WebCore::AudioNode::scriptExecutionContext): Return the AudioContext's context.
(WebCore::AudioNode::processIfNecessary): Whitespace.
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/AudioNode.idl: Make AudioNode an EventTarget.
* Modules/webaudio/ScriptProcessorNode.cpp: Remove EventTarget boilerplate.
* Modules/webaudio/ScriptProcessorNode.h: Ditto.
* Modules/webaudio/ScriptProcessorNode.idl: Ditto.
* dom/EventTarget.h: Mark AudioNode as an EventTarget.
* dom/EventTargetFactory.in: Ditto.

LayoutTests:

Reviewed by Darin Adler.

* webaudio/audionode-expected.txt:
* webaudio/audionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] backface-visibility: hidden doesn't work properly with masks and filters
anilsson@rim.com [Tue, 28 May 2013 17:28:35 +0000 (17:28 +0000)]
[BlackBerry] backface-visibility: hidden doesn't work properly with masks and filters
https://bugs.webkit.org/show_bug.cgi?id=116616

Reviewed by Carlos Garcia Campos.

The BlackBerry::Platform::Graphics::GraphicsContext generates geometry
with a different winding order than the accelerated compositing backend
of the BlackBerry port. So, when we switched from Skia to this new
rendering engine, we switched from glFrontFace(GL_CCW) to
glFrontFace(GL_CW), and all was well when drawing display lists.
However, we forgot to update the winding order of geometry generated
within the accelerated compositing backend, which is used for masks and
filters, so they were getting erroneously culled out when
backface-visibility: hidden was applied to them. Fixed by switching the
winding order of all geometry generated up here, which has the added
benefit of enabling us to use TransformationMatrix::mapQuad instead of
transforming point-by-point.

To further complicate matters, a right-side up transform is used when
drawing layers into surfaces, reversing the winding order and requiring
us to switch back to glFrontFace(GL_CCW) temporarily, when drawing
layers to surfaces, or the layers will get culled out inside the
surface.

Also fix spelling error, "drawed" should be "drawn".

No new tests, this is only detectable by pixel tests, which the
BlackBerry port currently doesn't support.

PR 341945.

* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::getTransformedRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WebCore::LayerCompositingThread::origin):
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
(WebCore):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
* platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds):
* platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::origin):
(LayerRendererSurface):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Connection issues in repeated WebProcess crash/reloads.
lauro.neto@openbossa.org [Tue, 28 May 2013 17:12:07 +0000 (17:12 +0000)]
[GTK] Connection issues in repeated WebProcess crash/reloads.
https://bugs.webkit.org/show_bug.cgi?id=115880

Reviewed by Anders Carlsson.

When stressing the WebProcess creation/destruction, WebKitGTK can
often run into socket issues like bad file descriptor errors or
polling a socket indefinitely.

Currently WebKitGTK has three places where a socket can be
closed.

- childFinishedFunction (in ProcessLauncherGtk.cpp)
- Connection::platformInvalidate (in ConnectionUnix.cpp)
- WorkQueue EventSource destruction (in WorkQueueGtk.cpp)

To avoid these race conditions, socket closing will be handled
by the event source callback in WorkQueueGtk.cpp.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate): Do not close the socket
when the connection is invalidated, the socket event source is
unregistered in this method and the socket is closed when the
GSocket associated to the event source is destroyed.
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Do not monitor child
process to close the connection on termination. This was needed in
the past when we used DGRAM sockets, we currently use always
connection oriented sockets, so that when the other end closes
the connection we are notified and the connection is invalidated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix GTK+ CMake build
mrobinson@webkit.org [Tue, 28 May 2013 16:03:25 +0000 (16:03 +0000)]
Fix GTK+ CMake build

Source/WebKit2:

* PlatformGTK.cmake: After r150336, the name of the WebKit2
library target is simply "WebKit2."

Tools:

* MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
library target is simply "WebKit2."

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove Node::dispatchChangeEvent() to HTMLFormControlElement.
akling@apple.com [Tue, 28 May 2013 14:41:11 +0000 (14:41 +0000)]
Move Node::dispatchChangeEvent() to HTMLFormControlElement.
<http://webkit.org/b/116866>

Reviewed by Anders Carlsson.

...and devirtualize it, since it had no overrides.

* dom/Node.h:
* dom/Node.cpp:
* html/HTMLFormControlElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
* html/FileInputType.cpp:
(WebCore::FileInputType::setFiles):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefactoring CSS grammar
sergio@webkit.org [Tue, 28 May 2013 14:37:34 +0000 (14:37 +0000)]
Refactoring CSS grammar
https://bugs.webkit.org/show_bug.cgi?id=116679

Reviewed by Andreas Kling.

From Blink r149948 by <serya@chromium.org>

Added "closing_parenthesis:" and "error_recovery:" to avoid code
duplication in a couple of error recovery rules. Some other rules
were also refactored which allows to reduce the the number of
shift/reduce conflicts by 2.

No new tests required as this is just a refactoring, no new
functionality added.

* css/CSSGrammar.y.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150804 268f45cc-cd09-0410-ab3c-d52691b4dbfc