WebKit-https.git
7 years agoMoar
gavinp@chromium.org [Fri, 11 Nov 2011 16:25:38 +0000 (16:25 +0000)]
Moar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofirst shot yo
gavinp@chromium.org [Fri, 11 Nov 2011 16:25:26 +0000 (16:25 +0000)]
first shot yo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed evening gardening. Add platform specific expected results for new...
ossy@webkit.org [Fri, 11 Nov 2011 16:22:17 +0000 (16:22 +0000)]
[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother baseline for contain-and-cover-zoomed that I didn't catch earlier.
tonyg@chromium.org [Fri, 11 Nov 2011 16:14:59 +0000 (16:14 +0000)]
Another baseline for contain-and-cover-zoomed that I didn't catch earlier.

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r99964.
hausmann@webkit.org [Fri, 11 Nov 2011 15:52:10 +0000 (15:52 +0000)]
Unreviewed, rolling out r99964.
http://trac.webkit.org/changeset/99964
https://bugs.webkit.org/show_bug.cgi?id=72124

Broke too many Qt tests (Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

* Target.pri:
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::usesMenuList):
* platform/qt/QtMobileWebStyle.cpp: Added.
(QtMobileWebStyle::QtMobileWebStyle):
(drawRectangularControlBackground):
(QtMobileWebStyle::drawChecker):
(QtMobileWebStyle::findChecker):
(QtMobileWebStyle::drawRadio):
(QtMobileWebStyle::findRadio):
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawMultipleComboButton):
(QtMobileWebStyle::drawSimpleComboButton):
(QtMobileWebStyle::getButtonImageSize):
(QtMobileWebStyle::findComboButton):
(QtMobileWebStyle::drawComplexControl):
* platform/qt/QtMobileWebStyle.h: Added.
* platform/qt/QtStyleOptionWebComboBox.h:
(WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox):
(WebCore::QtStyleOptionWebComboBox::checkMultiple):
* platform/qt/RenderThemeQStyle.cpp: Removed.
* platform/qt/RenderThemeQStyle.h: Removed.
* platform/qt/RenderThemeQt.cpp:
(WebCore::initStyleOption):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
(WebCore::RenderThemeQt::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::~RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::popupInternalPaddingBottom):
(WebCore::RenderThemeQt::fallbackStyle):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::RenderThemeQt::findFrameLineWidth):
(WebCore::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::setButtonPadding):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::setPopupPadding):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMenuListButton):
(WebCore::RenderThemeQt::animationDurationForProgressBar):
(WebCore::RenderThemeQt::paintProgressBar):
(WebCore::RenderThemeQt::paintSliderTrack):
(WebCore::RenderThemeQt::paintSliderThumb):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintInnerSpinButton):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
* platform/qt/RenderThemeQt.h:
(WebCore::StylePainter::isValid):
(WebCore::StylePainter::drawPrimitive):
(WebCore::StylePainter::drawControl):
(WebCore::StylePainter::drawComplexControl):
* platform/qt/RenderThemeQtMobile.cpp: Removed.
* platform/qt/RenderThemeQtMobile.h: Removed.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
* tests/tests.pri:

Tools:

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/webcore.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: fix Snow Leopard build.
pfeldman@chromium.org [Fri, 11 Nov 2011 15:42:16 +0000 (15:42 +0000)]
Not reviewed: fix Snow Leopard build.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove dead MeeGoTouch code.
hausmann@webkit.org [Fri, 11 Nov 2011 15:35:45 +0000 (15:35 +0000)]
[Qt] Remove dead MeeGoTouch code.

Reviewed by Tor Arne Vestbø.

* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make search in DOM panel scale.
pfeldman@chromium.org [Fri, 11 Nov 2011 15:22:36 +0000 (15:22 +0000)]
Web Inspector: make search in DOM panel scale.
https://bugs.webkit.org/show_bug.cgi?id=72118

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::discardSearchResults):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.performSearch.callback):
(WebInspector.DOMAgent.prototype.performSearch):
(WebInspector.DOMAgent.prototype.searchResult.mycallback):
(WebInspector.DOMAgent.prototype.searchResult):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch.resultCountCallback):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult.):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):

LayoutTests:

* inspector/elements/elements-panel-search-expected.txt:
* inspector/elements/elements-panel-search.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_b...
hausmann@webkit.org [Fri, 11 Nov 2011 15:16:19 +0000 (15:16 +0000)]
[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

* Target.pri:
* platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic
now lives within RenderThemeQtMobile.
* platform/qt/QtMobileWebStyle.h: Removed. Ditto.
* platform/qt/RenderThemeQStyle.cpp: Added.
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* platform/qt/RenderThemeQStyle.h: Added.
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
* platform/qt/RenderThemeQt.h:
(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):
* platform/qt/RenderThemeQtMobile.cpp: Added.
(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
* platform/qt/RenderThemeQtMobile.h: Added.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
* tests/tests.pri:

Tools:

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
based on availability of QtWidgets.
* qmake/mkspecs/features/webcore.prf: cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Option to configure indentation of pretty-printed Javascript
apavlov@chromium.org [Fri, 11 Nov 2011 15:14:39 +0000 (15:14 +0000)]
Web Inspector: Option to configure indentation of pretty-printed Javascript
https://bugs.webkit.org/show_bug.cgi?id=72119

Reviewed by Pavel Feldman.

Source/WebCore:

Drive-by fix for field names and added indent caching, as suggested by Pavel Podivilov.

* inspector/front-end/JavaScriptFormatter.js:
(FormattedContentBuilder):
(FormattedContentBuilder.prototype.increaseNestingLevel):
(FormattedContentBuilder.prototype.decreaseNestingLevel):
(FormattedContentBuilder.prototype._addIndent):
* inspector/front-end/ScriptFormatter.js:
* inspector/front-end/ScriptFormatterWorker.js:
(onmessage):
(formatScript):
(HTMLScriptFormatter):
(HTMLScriptFormatter.prototype.scriptEnded):

LayoutTests:

* inspector/debugger/script-formatter-expected.txt:
* inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium build fix after r99958.
andreas.kling@nokia.com [Fri, 11 Nov 2011 15:08:38 +0000 (15:08 +0000)]
Unreviewed Chromium build fix after r99958.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationCustomCall):o

    Remove hack that forced HTMLOptionsCollection to have a custom
    callAsFunctionCallback().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build fix of the private QML module with --no-webkit2.
alexis.menard@openbossa.org [Fri, 11 Nov 2011 14:55:12 +0000 (14:55 +0000)]
[Qt] Build fix of the private QML module with --no-webkit2.
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Tor Arne Vestbø.

* Source/QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
loislo@chromium.org [Fri, 11 Nov 2011 14:50:56 +0000 (14:50 +0000)]
Web Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
https://bugs.webkit.org/show_bug.cgi?id=72096

JSON.parse doesn't garantee the order of keys.
We have to explicitly order the results according to Inspector.json spec.

Patch by Mike Lewis <mikelikespie@gmail.com> on 2011-11-11
Reviewed by Pavel Feldman.

* inspector/CodeGeneratorInspector.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip a svg test and GTK rebaseline after r99941.
philn@webkit.org [Fri, 11 Nov 2011 14:50:47 +0000 (14:50 +0000)]
Unreviewed, skip a svg test and GTK rebaseline after r99941.

* platform/gtk/Skipped:
* platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ability to call HTMLCollections in V8 bindings as well.
andreas.kling@nokia.com [Fri, 11 Nov 2011 14:37:58 +0000 (14:37 +0000)]
Remove ability to call HTMLCollections in V8 bindings as well.
<http://webkit.org/b/72045>

Reviewed by Anders Carlsson.

Source/WebCore:

Follow the JSC bindings and remove the ability to call HTMLCollections
in the V8 bindings (excluding HTMLAllCollection.)

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderCustomCall):
(GenerateImplementationCustomCall):
* dom/NodeList.idl:
* html/HTMLCollection.idl:

    Remove the V8CustomCall attribute as it's no longer needed.

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:

LayoutTests:

Add a test verifying that calling collections other than document.all
will now throw.

* fast/dom/collection-calling-expected.txt: Added.
* fast/dom/collection-calling.html: Added.
* fast/dom/script-tests/collection-calling.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Interactive color box for gradients in CSS property values
apavlov@chromium.org [Fri, 11 Nov 2011 14:22:42 +0000 (14:22 +0000)]
Web Inspector: Interactive color box for gradients in CSS property values
https://bugs.webkit.org/show_bug.cgi?id=72112

Reviewed by Yury Semikhatsky.

Add "background-image" to the list of color-aware properties (may contain gradient definition).

* inspector/front-end/CSSKeywordCompletions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add missing include to PlatformWebViewQt
vestbo@webkit.org [Fri, 11 Nov 2011 13:47:13 +0000 (13:47 +0000)]
[Qt] Add missing include to PlatformWebViewQt

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Nov 2011 13:40:00 +0000 (13:40 +0000)]
2011-11-11  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Correct test_expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate chromium baselines after r99941.
tonyg@chromium.org [Fri, 11 Nov 2011 13:34:55 +0000 (13:34 +0000)]
Update chromium baselines after r99941.

That patch changed the number of zooms performed, so it seems to make sense that the
baseline would show a different sized image.

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [chromium] list dedicated workers in case inspector opened post-worker...
yurys@chromium.org [Fri, 11 Nov 2011 13:20:27 +0000 (13:20 +0000)]
Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerContext):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
* inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
* http/tests/inspector-enabled/dedicated-workers-list.html: Added.
* http/tests/inspector-enabled/resources/dedicated-worker.js: Added.
(doWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add a way to have experimental features in WebKit2
alexis.menard@openbossa.org [Fri, 11 Nov 2011 13:19:06 +0000 (13:19 +0000)]
[Qt] Add a way to have experimental features in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Kenneth Rohde Christiansen.

.:

Add the new private QML module in the build.

* Source/QtWebKit.pro:

Source/WebKit/qt:

This patch is adding a new module for accessing private
method and property from the view. It requires an import
QtWebKit.private in QML to be used.

* declarative/private/plugin.cpp: Added.
(WebKitQmlPluginPrivate::registerTypes):
* declarative/private/private.pro: Added.
* declarative/private/qmldir: Added.

Source/WebKit2:

Add new QML extensions for our public view. This extension
returns the private object of the view so that the user could
use unstable/unreleased APIs. This requires our private class
to be exported and QObject subclass.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebviewprivateextension.cpp: Added.
(QQuickWebViewPrivateExtension::QQuickWebViewPrivateExtension):
(QQuickWebViewPrivateExtension::viewPrivate):
* UIProcess/API/qt/qquickwebviewprivateextension_p.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r99950.
yurys@chromium.org [Fri, 11 Nov 2011 13:12:50 +0000 (13:12 +0000)]
Unreviewed, rolling out r99950.
http://trac.webkit.org/changeset/99950
https://bugs.webkit.org/show_bug.cgi?id=72117

"Landed wrong patch by mistake" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/JavaScriptCore:

* JavaScriptCore.exp:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:

Source/WebCore:

* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:

LayoutTests:

* inspector/debugger/function-location-expected.txt: Removed.
* inspector/debugger/function-location.html: Removed.
* platform/chromium/inspector/debugger/function-location-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: function remote objetct should provide access to function position...
yurys@chromium.org [Fri, 11 Nov 2011 13:05:33 +0000 (13:05 +0000)]
Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionLocation):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getFunctionLocation):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
* inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

* inspector/debugger/function-location-expected.txt: Added.
* inspector/debugger/function-location.html: Added.
* platform/chromium/inspector/debugger/function-location-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix incremental builds on Windows after buildsystem refactor
vestbo@webkit.org [Fri, 11 Nov 2011 12:47:33 +0000 (12:47 +0000)]
[Qt] Fix incremental builds on Windows after buildsystem refactor

The qmake rules to ensure that we run make on the derived sources
before running qmake on the target were inside a unix-scope, which
resulted in flakey builds on Windows.

We now generate a rule on all platforms that ensures that "make qmake"
will always run make on the derived sources. In addition, on platforms
that have GNU make (where "make incremental" does not run "make qmake",
but only "make"), we add a similar rule that ensures that any time the
target makefile is regenerated we first run qmake and make on the derived
sources. This rule relies on GNU make's order-only-prerequisites to
not trigger a qmake-run of the target every time we run make.

https://bugs.webkit.org/show_bug.cgi?id=71778

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.
pfeldman@chromium.org [Fri, 11 Nov 2011 12:46:17 +0000 (12:46 +0000)]
Not reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.

* inspector/InspectorDOMAgent.cpp:
(WebCore::MatchJob::MatchJob):
(WebCore::InspectorDOMAgent::onMatchJobsTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Metrics] Editor is committed when scrolling a content box dimension...
apavlov@chromium.org [Fri, 11 Nov 2011 12:44:24 +0000 (12:44 +0000)]
Web Inspector: [Metrics] Editor is committed when scrolling a content box dimension up/down for the first time
https://bugs.webkit.org/show_bug.cgi?id=72108

Reviewed by Pavel Feldman.

* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Remove QWebNavigationController
hausmann@webkit.org [Fri, 11 Nov 2011 12:40:05 +0000 (12:40 +0000)]
[Qt][WK2] Remove QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72113

Reviewed by Andreas Kling.

Source/WebKit/qt:

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.

Source/WebKit2:

Fold the functions and properties of QWebNavigationController into
QQuickWebView.

* Target.pri:
* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebpage.h:
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::canStop):
(QQuickWebView::canReload):
(QQuickWebView::title):
* UIProcess/API/qt/qquickwebview.h:
* UIProcess/API/qt/qwebnavigationcontroller.cpp: Removed.
* UIProcess/API/qt/qwebnavigationcontroller.h: Removed.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):

Tools:

Adapt to the move of the QWebNavigationController functions/properties to
QQuickWebView.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build system tweak
hausmann@webkit.org [Fri, 11 Nov 2011 12:33:19 +0000 (12:33 +0000)]
[Qt] Build system tweak

Reviewed by Tor Arne Vestbø.

Be a good qmake citizen, return true from our linkStaticLibrary
"test" function.

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium expectations for new test in r99937.
tonyg@chromium.org [Fri, 11 Nov 2011 12:33:15 +0000 (12:33 +0000)]
Chromium expectations for new test in r99937.

* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
* platform/chromium-win/svg/zoom/page/zoom-svg-as-object-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
hclam@chromium.org [Fri, 11 Nov 2011 12:17:24 +0000 (12:17 +0000)]
[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=72081

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

LayerChromium and CCLayerTreeHosts hold RefPtr<>s to each other, so if
you do not clear out the layerTreeHost pointer on the LayerChromium
the layer tree is leaked. The real code does this in WebViewImpl but
this test was not.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] scrolling is broken with compositor thread
hclam@chromium.org [Fri, 11 Nov 2011 12:16:04 +0000 (12:16 +0000)]
[chromium] scrolling is broken with compositor thread
https://bugs.webkit.org/show_bug.cgi?id=72059

Reviewed by James Robinson.

No new test. Existing test CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls checks scroll deltas are applied
on the right layer.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::scrollLayer):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
Instead of calling on the root layer which doesn't have scroll delta applied. Change this to scrollLayer()
which actually has scroll delta.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 11 Nov 2011 11:49:10 +0000 (11:49 +0000)]
2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        [Qt] 4 new tests fail introduced in r98852
        https://bugs.webkit.org/show_bug.cgi?id=71253

        Reviewed by Zoltan Herczeg.

        Fix a non-Mac only problem with contain-and-cover-zoomed.html. It zooms out four times, which is ignored on Mac, but respected elsewhere.
        This is the same fix I applied to the svg/zoom/page tests, I forgot this one.

        * fast/backgrounds/size/contain-and-cover-zoomed.html: Don't zoom out more than three times, it's otherwise ignored on Mac/DRT!
        * fast/backgrounds/size/resources/SquirrelFish.svg: Fix typo in XML version, now this shows up in Qt again. Credits to Zoltan Arvai for spotting this.
        * platform/qt/Skipped: Unskip last regression from bug 7153.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r99826.
tonyg@chromium.org [Fri, 11 Nov 2011 11:47:13 +0000 (11:47 +0000)]
Unreviewed, rolling out r99826.
http://trac.webkit.org/changeset/99826
https://bugs.webkit.org/show_bug.cgi?id=72109

"Likely causing test flakiness" (Requested by tonyg-cr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
* tests/data/page_with_image.mht: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add support for QT += webkit-private
hausmann@webkit.org [Fri, 11 Nov 2011 11:37:29 +0000 (11:37 +0000)]
[Qt] Add support for QT += webkit-private

Reviewed by Tor Arne Vestbø.

* qmake/qt_webkit.pri: Declare private headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixing media/video-frame-accurate-seek.html expectation after r99887.
tonyg@chromium.org [Fri, 11 Nov 2011 11:02:22 +0000 (11:02 +0000)]
Fixing media/video-frame-accurate-seek.html expectation after r99887.

* platform/chromium-cg-mac-leopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-frame-accurate-seek-expected.png.
* platform/chromium-gpu-mac/media/video-frame-accurate-seek-expected.png: Removed.
* platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png.
* platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Removed.
* platform/chromium/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 11 Nov 2011 09:52:29 +0000 (09:52 +0000)]
2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Zooming in SVGs in <object> is flakey
        https://bugs.webkit.org/show_bug.cgi?id=71673

        Reviewed by Zoltan Herczeg.

        Add another minimal testcase using <object> embedding SVGs + zooming.

        * platform/qt/Skipped: Unskip zoom-img-preserveAspectRatio-support-1.html.
        * platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
        * svg/zoom/page/resources/zoom-svg-as-object.svg: Added.
        * svg/zoom/page/zoom-svg-as-object.html: Added.

2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Zooming in SVGs in <object> is flakey
        https://bugs.webkit.org/show_bug.cgi?id=71673

        Reviewed by Zoltan Herczeg.

        It turns out zooming in SVGs in <object> wasn't flakey in Safari at all, only in DRT/Mac. In Safari it failed 100% reproducable.
        Scrollbars would always appear when zooming in a HTML document, containing an embedded SVG by <object>/<embed>/<iframe>, even
        though the content would visually fit perfectly, also it zoomed properly. Reloading would make the scrollbars disappear again.

        If scrollbars should be created for a FrameView or not, is determined by ScrollView::updateScrollbars(), by comparing the
        visible size of the scroll view against the contents size. The contents size is propagated to the ScrollView, by
        FrameView::adjustViewSize(), which is called during FrameView::layout(). The size thats propagated is RenderView::documentRect().
        RenderView::documentRect() returns a writing-mode aware layoutOverflowRect(), computed by RenderBox::layoutOverflowRectForPropagation.

        If overflow is "visible", layoutOverflowRect() will return a union of the borderBoxRect() and the layoutOverflowRect(), which
        may exceed the visible size of the RenderView. For standalone SVG documents, the default value for the outermost <svg> renderer is
        "visible". When embedding SVGs through <object>s into a host document, the same code path is taken, and RenderView::documentRect()
        of the embedded SVG document will always return a union of the borderBoxREct() and the layoutOverflowRect().

        If that happens while zooming in a HTML document containing a SVG by <object>, scrollbars are created.
        By ensuring that overflow is treated as hidden, which is what Opera does (and makes sense!) this can't happen.

        The fix is to treat embedded SVGs as they would carry overflow="hidden" on the outermost <svg> renderer. That also makes
        sense as the embedded SVG cant paint outside an external "frame rect" thats given by the FrameView, effectively rendering
        as overflow "hidden" already.

        The fix is realized, by altering the overflow x/y values that are used in FrameView::applyOverflowToViewport(). Previously
        we never called that method for SVG, which was fine. Now we always call applyOverflowToViewport(), but only do something
        if the FrameView of the SVG is embedded in another document. If so, we force overflow to hidden.

        That fixes all zooming+<object> related flakiness seen on the chromium bots, most noticeable, without other side effects.
        All svg/overflow tests, still work as expected.

        Test: svg/zoom/page/zoom-svg-as-object.html

        * page/Frame.cpp:
        (WebCore::Frame::setPageAndTextZoomFactors): Remove unnecessary setNeedsLayout() call in SVG builds.
        * page/FrameView.cpp:
        (WebCore::FrameView::applyOverflowToViewport): Always enforce overflow=hidden, when embedding SVGs through object/embed/iframe.
                                                       Otherwise scrollbars will appear, even though the contents would fit without them.
        (WebCore::FrameView::calculateScrollbarModesForLayout): Always call applyOverflowToViewport, even for RenderSVGRoot. It only has
                                                                an effect though, when the FrameView of the SVG is embedded through <object>/etc.
        (WebCore::FrameView::layout): Remove unnecessary setChildNeedsLayout() call.
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Fix this function, its meaning was reversed before!
        (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix logical error, by negating the result of isEmbeddedThroughFrameContainingSVGDocument.
        (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
        * rendering/svg/RenderSVGRoot.h: Expose isEmbeddedThroughFrameContainingSVGDocument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 11 Nov 2011 09:44:39 +0000 (09:44 +0000)]
2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Unbreak my 32bit SL build.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateOrRemoveFilterEffect): Use narrowPrecisionToFloat() to convert float -> double.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, build fix attempt after r99907. Since that revision
philn@webkit.org [Fri, 11 Nov 2011 09:03:42 +0000 (09:03 +0000)]
Unreviewed, build fix attempt after r99907. Since that revision
GTK layout tests were not running at all...

* Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHRTF Database consolidation
philn@webkit.org [Fri, 11 Nov 2011 08:40:02 +0000 (08:40 +0000)]
HRTF Database consolidation
https://bugs.webkit.org/show_bug.cgi?id=69703

Reviewed by Kenneth Russell.

Access to the consolidated parts of the HRTF database by segmented
chunks. A concatenated Composite HRTF database is provided in
Composite.wav. Additionnally a new build step that concatenates
the platform/audio/resources/ files into one (sox can be used for
this) can be configured for specific ports.

* platform/audio/HRTFDatabase.h:
* platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
* platform/audio/resources/Composite.wav: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: provide an id to the root inspector element for third party UA styling.
pfeldman@chromium.org [Fri, 11 Nov 2011 08:37:35 +0000 (08:37 +0000)]
Web Inspector: provide an id to the root inspector element for third party UA styling.
https://bugs.webkit.org/show_bug.cgi?id=72094

Reviewed by Yury Semikhatsky.

* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for !ENABLE(JIT) after r99898.
paroga@webkit.org [Fri, 11 Nov 2011 08:11:15 +0000 (08:11 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r99898.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, add Linux baselines I forgot to commit in the last rebaseline.
yutak@chromium.org [Fri, 11 Nov 2011 07:39:41 +0000 (07:39 +0000)]
[Chromium] Unreviewed, add Linux baselines I forgot to commit in the last rebaseline.

* platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitCSSShaderValue.h is not a member of the WebCore target
aestes@apple.com [Fri, 11 Nov 2011 07:23:31 +0000 (07:23 +0000)]
WebKitCSSShaderValue.h is not a member of the WebCore target
https://bugs.webkit.org/show_bug.cgi?id=72093

Reviewed by Dan Bernstein.

* WebCore.xcodeproj/project.pbxproj: Make WebKitCSSShaderValue.h a
member of the WebCore target, and make it a project header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisabling assertions breaks the debug build
mitz@apple.com [Fri, 11 Nov 2011 07:08:46 +0000 (07:08 +0000)]
Disabling assertions breaks the debug build
https://bugs.webkit.org/show_bug.cgi?id=72091

Reviewed by Geoff Garen.

Source/JavaScriptCore:

* dfg/DFGNode.h: Made hasIdentifier() available when assertions are
disabled. It is used in Graph::dump().
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Update m_isCheckingForDefaultMarkViolation
only if assertions are enabled.
* wtf/Deque.h:
(WTF::::checkIndexValidity): Changed ASSERT to ASSERT_UNUSED.
* wtf/ThreadRestrictionVerifier.h:
(WTF::ThreadRestrictionVerifier::setShared): Guarded the definition of
a local variable that is only used in an assertion.

Source/WebCore:

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::didDecodeProperties): Guarded the definition of local variables that are
only used in an assertion correctly.
* platform/graphics/gpu/TilingData.h: Changed ASSERT to ASSERT_UNUSED.
(WebCore::TilingData::assertTile):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed): Guarded the definition of a local variable that is
only used in an assertion correctly.
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyResource): Changed ASSERT to ASSERT_UNUSED.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource): Changed ASSERT to ASSERT_UNUSED.
(WebCore::RenderSVGResourceFilter::postApplyResource): Changed ASSERT to ASSERT_UNUSED.
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource): Changed ASSERT to ASSERT_UNUSED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 7...
yutak@chromium.org [Fri, 11 Nov 2011 06:53:19 +0000 (06:53 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 7, the final)

* platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-cg-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
* platform/chromium-cg-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
* platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
* platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
* platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
* platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSString forgets to clear m_fibers when resolving ropes
fpizlo@apple.com [Fri, 11 Nov 2011 06:39:54 +0000 (06:39 +0000)]
JSString forgets to clear m_fibers when resolving ropes
https://bugs.webkit.org/show_bug.cgi?id=72089

Reviewed by Geoff Garen.

* runtime/JSString.cpp:
(JSC::JSString::resolveRopeSlowCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed morning gardening after r99862.
ossy@webkit.org [Fri, 11 Nov 2011 06:28:49 +0000 (06:28 +0000)]
[Qt] Unreviewed morning gardening after r99862.

* platform/qt/svg/foreignObject/background-render-phase-expected.png: Added.
* platform/qt/svg/foreignObject/background-render-phase-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
dcheng@chromium.org [Fri, 11 Nov 2011 04:13:25 +0000 (04:13 +0000)]
[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
https://bugs.webkit.org/show_bug.cgi?id=71414

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no new functionality enabled yet.

* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/WebClipboard.h:
(WebKit::WebClipboard::writeDataObject):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardWriteDataObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAtomically update the system clipboard for copy/cut events
dcheng@chromium.org [Fri, 11 Nov 2011 04:12:14 +0000 (04:12 +0000)]
Atomically update the system clipboard for copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=40515

Reviewed by David Levin.

This change consolidates the system pasteboard mutation logic into dispatchCPPEvent() rather
than having it scattered throughout tryDHTMLCopy/tryDHTMLCut and the various Clipboard*
classes. This allows us to ensure that the system pasteboard remains in a consistent state
even if there's an exception thrown during event handling, and it also lays the ground work
for allowing pages to prevent copy/cut without causing the system pasteboard to be cleared.

No new tests, since any layout test would be flaky since it would depend on and affect
global system state.

* editing/Editor.cpp:
(WebCore::Editor::tryDHTMLCopy): Move Pasteboard::clear() call to dispatchCPPEvent().
(WebCore::Editor::tryDHTMLCut): Ditto.
(WebCore::Editor::dispatchCPPEvent):
Only persist Clipboard mutations to the system pasteboard if the event was dispatched
successfully and default processing was prevented.
* editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard):
When creating a Clipboard for copy/cut, back it with a unique instance of NSPasteboard to
buffer pasteboard mutations.
* platform/Pasteboard.h:
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardGtk.
(WebCore::ClipboardGtk::setData):
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::clipboard):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeClipboard):
Implement logic to flush data from temporary NSPasteboard to system pasteboard.
* platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardQt.
(WebCore::ClipboardGtk::setData):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/wince/PasteboardWinCE.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::writeClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaselines after r99902.
ojan@chromium.org [Fri, 11 Nov 2011 02:15:44 +0000 (02:15 +0000)]
Chromium rebaselines after r99902.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r99916.
hayato@chromium.org [Fri, 11 Nov 2011 02:10:20 +0000 (02:10 +0000)]
Unreviewed, rolling out r99916.
http://trac.webkit.org/changeset/99916
https://bugs.webkit.org/show_bug.cgi?id=72077

fast/harness/result.html seems platform dependent (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

* platform/chromium/fast/harness/results-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] only run media GPU layout tests on platforms supporting accelerated compos...
scherkus@chromium.org [Fri, 11 Nov 2011 01:45:57 +0000 (01:45 +0000)]
[Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=72001

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableSection's recalcCell logic is doing too much work
jchaffraix@webkit.org [Fri, 11 Nov 2011 01:41:26 +0000 (01:41 +0000)]
RenderTableSection's recalcCell logic is doing too much work
https://bugs.webkit.org/show_bug.cgi?id=71986

Reviewed by Darin Adler.

No change in behavior expected so no test.

r98738 and r98980 missed the point that Vector::clear() does not touch
the internal buffer. Thus calling clear() would keep the memory and properly
reset the size().

Due to how the code worked, after r98980 the code would end up resetting some
of RowStruct field twice: once when growing and the other one when calling
fillRowsWithDefaultStartingAtPosition.

This change make the code use Vector::clear and simplified the recalcCells
logic knowing that growing the Vector will properly initialize most of the
RowStruct fields (with RowStruct constructor).

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::addCell):
Updated after ensureRows signature change.

(WebCore::RenderTableSection::ensureRows):
Removed the overflow check as it was making some assumption as to how the
Vector worked. If we want to implement a limit, we may do it differently.
Also inlined the part of fillRowsWithDefaultStartingAtPosition that grows
the columns to match our current representation. The rest of the function's
initialization is handled by the constructor already.

(WebCore::RenderTableSection::recalcCells):
Use clear() as it keeps the buffer and just resets the size. Also shrinkToFit
at the end as we may have lost some rows.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::CellStruct::CellStruct):
Fixed the style of the constructor.

(WebCore::RenderTableSection::RowStruct::RowStruct):
Added an explicit constructor (which is equivalent to the default one)
but underlines what we expect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT when outdenting styled line break.
enrica@apple.com [Fri, 11 Nov 2011 01:26:32 +0000 (01:26 +0000)]
ASSERT when outdenting styled line break.
https://bugs.webkit.org/show_bug.cgi?id=72069
<rdar://problem/10429739>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When outdenting a line break that has some inline style, we don't consider
the enclosing elements that provide the style.
This causes the splitting to occur in the wrong position,
triggering the assert.

Test: editing/execCommand/outdent-break-with-style.html

* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph): The fix consists
in choosing the highest inline ancestor as splitting point.
* editing/htmlediting.cpp:
(WebCore::isInline): Added.
* editing/htmlediting.h: Added isInline.

LayoutTests:

* editing/execCommand/outdent-break-with-style-expected.txt: Added.
* editing/execCommand/outdent-break-with-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG byte array support sometimes clamps values incorrectly
fpizlo@apple.com [Fri, 11 Nov 2011 01:07:44 +0000 (01:07 +0000)]
DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

LayoutTests:

Reviewed by Oliver Hunt.

Added a test for byte arrays, and fixed a small bug in dfg-min-max.js.

* fast/js/dfg-byte-array-put-expected.txt: Added.
* fast/js/dfg-byte-array-put.html: Added.
* fast/js/script-tests/dfg-byte-array-put.js: Added.
(doPut):
(doGet):
* fast/js/script-tests/dfg-min-max.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, revert a misplaced expected text in r99819.
hayato@chromium.org [Fri, 11 Nov 2011 00:50:58 +0000 (00:50 +0000)]
Unreviewed, revert a misplaced expected text in r99819.
A results-expected is platform independent. r99828 fixed this.

* platform/chromium/fast/harness/results-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnce more for the QT build.
bdakin@apple.com [Fri, 11 Nov 2011 00:36:48 +0000 (00:36 +0000)]
Once more for the QT build.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setFindIndicator):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore attempted build fix.
bdakin@apple.com [Fri, 11 Nov 2011 00:33:23 +0000 (00:33 +0000)]
More attempted build fix.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/gtk/PageClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix 32-bit build.
andersca@apple.com [Fri, 11 Nov 2011 00:32:33 +0000 (00:32 +0000)]
Fix 32-bit build.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(-[WKContentLayer drawInContext:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative build fix.
bdakin@apple.com [Fri, 11 Nov 2011 00:28:42 +0000 (00:28 +0000)]
Speculative build fix.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator):
* UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=66584
bdakin@apple.com [Fri, 11 Nov 2011 00:06:02 +0000 (00:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66584
WebKit2's find bouncy looks blurry after dragging window onto >1.0 scale factor
display
-and corresponding-
<rdar://problem/9987559>

Reviewed by Anders Carlsson.

The setFindIndicator message and various functions of the same name must all take
an additional parameter indicating whether or not setting the find indicator
should result in a bounce animation. This is because when the device scale factor
changes, if there is currently a find indicator, it must be re-set to a higher or
lower resolution version, but we don't want the bounce animation to happen again.
* UIProcess/API/mac/FindIndicatorWindow.h:
* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/mac/WKView.mm:
(-[WKView _setFindIndicator:fadeOut:animate:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

New function FindController::isShowingOverlay() is used to determine if
FindController::deviceScaleFactorDidChange() needs to be called.
* WebProcess/WebPage/FindController.h:
(WebKit::FindController::isShowingOverlay):

FindController::deviceScaleFactorDidChange() calls updateFindIndicator to re-
generate the bitmap at the appropriate scale factor, but tells it not to animate
this time.
(WebKit::FindController::deviceScaleFactorDidChange):

updateFindIndicator() takes a new parameter indicating whether or not the
FindIndicator should animate. It defaults to true since the deviceScaleFactor
changing is the only case currently where we do not want it to animate.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):

Calls into FindController::deviceScaleFactorDidChange() when the scale factor has
changed and the find overlay is showing.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoValueProfile/PredictedType contains dead code, and doesn't recognize functions
fpizlo@apple.com [Thu, 10 Nov 2011 23:59:31 +0000 (23:59 +0000)]
ValueProfile/PredictedType contains dead code, and doesn't recognize functions
https://bugs.webkit.org/show_bug.cgi?id=72065

Reviewed by Gavin Barraclough and Geoff Garen.

Added PredictFunction support, and did some cleaning up along the way.
ValueProfile no longer has statistics machinery, because we never used
it. Rearranged some bits in PredictedType to more easily make room for
one more object type. Changed some debug code to use more consistent
conventions (ByteArray becomes Bytearray so that if we ever have a
"Byte" prediction we don't get confused between a prediction that is
the union of Byte and Array and a prediction that indicates precisely
a ByteArray).

* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isFunctionPrediction):
* bytecode/ValueProfile.cpp:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobencher script should support remote benchmarking
fpizlo@apple.com [Thu, 10 Nov 2011 23:47:29 +0000 (23:47 +0000)]
bencher script should support remote benchmarking
https://bugs.webkit.org/show_bug.cgi?id=71618

Rubber-stamped by Geoff Garen.

Added the following features:

- Benchmark report tells you the hostname and machine model (according to
  'sysctl hw.model') of the machine you did the run on, and svn revision number
  (according to 'svn info') of the VMs you're testing.

- The --remote option. You give this an ssh-style hostname (i.e. user@host is
  acceptable, in addition to just host, in which case your username is used)
  and it automatically packages the build directories of the VMs you're testing,
  sends them to the remote machine along with your copy of the bencher script
  and all of the options you passed.  This pretty much seamlessly allows you
  to run a set of benchmarks on any machine that is sufficiently compatible with
  yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
  must now include a tempPath setting that tells bencher where to put files
  when that machine is used as a slave in a remote benchmarking run.

- Added yet another way of specifying which benchmarks to run. This was sort of
  necessary for --remote to work as expected. Previously, you either said what
  suites to exclude (for example --exclude-sunspider) or that you only wanted
  to run one suite to the exclusion of others (--sunspider-only). But it's
  often better to just be able to specify the list of suites you want. This is
  now supported. You can say, for example, --v8 --sunspider, which means, just
  run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
  still supported.

* Scripts/bencher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLazily start DRT instances in NRWT
tony@chromium.org [Thu, 10 Nov 2011 23:31:45 +0000 (23:31 +0000)]
Lazily start DRT instances in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72038

Reviewed by Eric Seidel.

Just a refactoring, no new tests.

* Scripts/webkitpy/layout_tests/controllers/worker.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<http://webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAM...
ddkilzer@apple.com [Thu, 10 Nov 2011 23:31:31 +0000 (23:31 +0000)]
<webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR

Reviewed by Joseph Pecoraro.

* JavaScriptCore.xcodeproj/project.pbxproj: The testapi.js
script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath
for installation.  Also removed "Versions/A/" from the path
since this is unneeded due the default symlinks present in the
framework.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi...
dino@apple.com [Thu, 10 Nov 2011 23:11:15 +0000 (23:11 +0000)]
Remove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi?id=72058

Reviewed by Simon Fraser.

As suggested by Nikolas, we don't need this virtual method any more.

* rendering/FilterEffectRenderer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ARMv7 support to the DFG JIT
barraclough@apple.com [Thu, 10 Nov 2011 23:02:33 +0000 (23:02 +0000)]
Add ARMv7 support to the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72061

Reviewed by Geoff Garen.

* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
    - Add CPU(ARM) copies of these functions.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::spill):
    - Fix matching of '}' re #if blocks, makes some tools happy.
(JSC::DFG::JITCodeGenerator::setupArguments):
(JSC::DFG::JITCodeGenerator::setupArgumentsWithExecState):
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheckSetResult):
(JSC::DFG::JITCodeGenerator::appendCallSetResult):
    - Add CPU(ARM) / 4 argument register copies of these functions.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
    - Should use callOperation to plant a call to a DFG_OPERATION.
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
    - These methods need to plant a relinkable jump; we currently do so
      using beginUninterruptedSequence() / endUninterruptedSequence().
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
    - Should use callOperation to plant a call to a DFG_OPERATION.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
    - This method needs to plant a relinkable jump; we currently do so
      using beginUninterruptedSequence() / endUninterruptedSequence().
(JSC::DFG::JITCompiler::compileBody):
    - Add abstraction to retrieve the pc after a call.
* dfg/DFGOSRExitCompiler.cpp:
    - Fix a bug - CodeLocationLabel needs a data address rather than an
      executable one, but can just take a MacroAssemblerCodePtr instead!
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::compileClampDoubleToByte):
    - Add FIXME comment to come back to! - bug#72054.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
    - Add missing method (ooops, required by bug#72047)
* dfg/DFGSpeculativeJIT32_64.cpp:
    - Need to wrap fmod on ARMv7.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
luiz@webkit.org [Thu, 10 Nov 2011 23:01:27 +0000 (23:01 +0000)]
[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
https://bugs.webkit.org/show_bug.cgi?id=71530

Reviewed by Simon Hausmann.

Adding methods setGeometry and setFont so that users of platform plugin may show the
popup menus in proper position and using proper font.

* Api/qwebkitplatformplugin.h:
* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
* examples/platformplugin/WebPlugin.h:
(WebPopup::setGeometry):
(WebPopup::setFont):
* examples/platformplugin/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72060
hyatt@apple.com [Thu, 10 Nov 2011 22:59:46 +0000 (22:59 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72060

[CSS Line Grid] Add support for the line-grid-snap property to control snapping to the nearest
enclosing grid.

Reviewed by Dan Bernstein.

Added fast/line-grid/line-grid-snap-parsing.html.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineGridSnap):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::lineGridSnap):
(WebCore::InheritedFlags::setLineGridSnap):
(WebCore::InheritedFlags::initialLineGridSnap):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=72060

Add tests for line-grid-snap parsing.

Reviewed by Dan Bernstein.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/line-grid/line-grid-snap-parsing-expected.txt: Added.
* fast/line-grid/line-grid-snap-parsing.html: Added.
* fast/line-grid/script-tests/line-grid-snap-parsing.js: Added.
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChangeLog mistakenly recognizes any string between '*' and ':' as touched files
rniwa@webkit.org [Thu, 10 Nov 2011 22:52:30 +0000 (22:52 +0000)]
ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
https://bugs.webkit.org/show_bug.cgi?id=72057

Reviewed by Eric Seidel.

Make the regular expression more explicit.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCodeGeneratorV8.pm can generate Event constructors
haraken@chromium.org [Thu, 10 Nov 2011 22:43:46 +0000 (22:43 +0000)]
CodeGeneratorV8.pm can generate Event constructors
https://bugs.webkit.org/show_bug.cgi?id=72055

Reviewed by Adam Barth.

This patch makes CodeGeneratorV8.pm generate Event constructors
and replaces a custom constructor of Event with the generated one.
After this patch is landed without regression,
I will replace custom constructors of all other Events.
This patch introduces two new IDLs:

- [ConstructorTemplate=Event] IDL indicates that CodeGenerator should
generate an Event constructor.
- [InitializedByConstructor] IDL on an attribute indicates that
the attribute can be initialized by the constructor.

Tests: fast/events/constructors/event-constructors.html
       fast/events/constructors/custom-event-constructor.html
       fast/events/constructors/progress-event-constructor.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): Added a header for fillXXXXEventInit(...).
(IsConstructable): Judges if a given interface is constructable.
(IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].
(GenerateEventConstructorCallback): Generates an Event constructor. The generated code is the same as the code that had been written in V8EventConstructors.cpp.
(GenerateImplementation): Generates an Event constructor if [ConstructorTemplate=Event] is specified.
* dom/Event.idl: Added [ConstructorTemplate=Event] IDL. Added [InitializedByConstructor] IDL to attributes that can be initialized by a constructor.

* bindings/scripts/test/TestEventConstructor.idl: Added a new run-bindings-test.
* bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp: Updated a run-bindings-tests result.
(WebDOMTestEventConstructor::WebDOMTestEventConstructorPrivate::WebDOMTestEventConstructorPrivate):
(WebDOMTestEventConstructor::WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::operator=):
(WebDOMTestEventConstructor::impl):
(WebDOMTestEventConstructor::~WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::attr1):
(WebDOMTestEventConstructor::attr2):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMTestEventConstructor.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp: Ditto.
(WebKit::kit):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):
(WebKit::core):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_set_property):
(webkit_dom_test_event_constructor_get_property):
(webkit_dom_test_event_constructor_constructed):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):
(WebKit::wrapTestEventConstructor):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h: Ditto.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::getConstructData):
(WebCore::JSTestEventConstructorPrototype::self):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation):
(WebCore::JSTestEventConstructor::createPrototype):
(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::toJS):
(WebCore::toTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.
(WebCore::JSTestEventConstructor::create):
(WebCore::JSTestEventConstructor::createStructure):
(WebCore::JSTestEventConstructor::impl):
(WebCore::JSTestEventConstructorPrototype::create):
(WebCore::JSTestEventConstructorPrototype::createStructure):
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):
* bindings/scripts/test/ObjC/DOMTestEventConstructor.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestEventConstructor.mm: Ditto.
(-[DOMTestEventConstructor dealloc]):
(-[DOMTestEventConstructor finalize]):
(-[DOMTestEventConstructor attr1]):
(-[DOMTestEventConstructor attr2]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h: Ditto.
* bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.
(WebCore::TestEventConstructorInternal::V8_USE):
(WebCore::TestEventConstructorInternal::attr1AttrGetter):
(WebCore::TestEventConstructorInternal::attr2AttrGetter):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore::V8TestEventConstructor::wrapSlow):
(WebCore::V8TestEventConstructor::derefObject):
* bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.
(WebCore::V8TestEventConstructor::toNative):
(WebCore::V8TestEventConstructor::existingWrapper):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h: Ditto.
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
* bindings/scripts/test/V8/V8TestNamedConstructor.h: Ditto.
* bindings/scripts/test/V8/V8TestObj.h: Ditto.
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
* bindings/v8/custom/V8EventConstructors.cpp: Removed a custom constructor of Event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Pre-emptively mark a canvas test as failing for next Skia roll.
senorblanco@chromium.org [Thu, 10 Nov 2011 22:27:32 +0000 (22:27 +0000)]
[chromium] Pre-emptively mark a canvas test as failing for next Skia roll.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should not reparse code that was just parsed
fpizlo@apple.com [Thu, 10 Nov 2011 21:59:39 +0000 (21:59 +0000)]
DFG should not reparse code that was just parsed
https://bugs.webkit.org/show_bug.cgi?id=71977

Reviewed by Geoff Garen.

The instruction stream of a code block is now kept around until
the next GC. When doing either an optimizing compilation of an
executable, or inlining of an executable, we now try to find the
already preexisting bytecode. If we find it, we don't have to parse.
If we don't find it, we parse as before. Inlining takes the extra
step of caching code blocks, so if the same executable gets inlined
multiple times into the same caller, then we parse it at most once
even if prior to inlining that executable did not have any code
blocks with an instruction stream.

Also fixed a silly bug where the strict mode for various operations
was being determined by looking at the machine code block rather
than the inlinee.

To enable the delete-on-next-GC policy, I introduced the notion
of an ultra weak finalizer, which anyone can register during
tracing. This is thread-safe (for parallel GC) and
stop-the-world-safe (so calls to free() are postponed until the
world is resumed). This required reusing some facilities previously
created for WeakReferenceHarvester, so I created a common utility
class. I also retweaked the handling of WeakReferenceHarvesters,
since they should be executed during stop-the-world since in the
future we may want to allow them to call drain().

2% win on SunSpider. 2% win on V8, when run in my harness. Neutral
elsewhere.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::copyPostParseDataFrom):
(JSC::CodeBlock::copyPostParseDataFromAlternative):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::canProduceCopyWithBytecode):
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::handleBytecodeDiscardingOpportunity):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::BytecodeDestructionBlocker::BytecodeDestructionBlocker):
(JSC::BytecodeDestructionBlocker::~BytecodeDestructionBlocker):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::strictModeFor):
* dfg/DFGByteCodeCache.h: Added.
(JSC::DFG::CodeBlockKey::CodeBlockKey):
(JSC::DFG::CodeBlockKey::operator==):
(JSC::DFG::CodeBlockKey::hash):
(JSC::DFG::CodeBlockKey::executable):
(JSC::DFG::CodeBlockKey::kind):
(JSC::DFG::CodeBlockKey::isHashTableDeletedValue):
(JSC::DFG::CodeBlockKeyHash::hash):
(JSC::DFG::CodeBlockKeyHash::equal):
(JSC::DFG::ByteCodeCache::ByteCodeCache):
(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/Heap.cpp:
(JSC::Heap::finalizeUnconditionally):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/Heap.h:
* heap/ListableHandler.h: Added.
(JSC::ListableHandler::ListableHandler):
(JSC::ListableHandler::~ListableHandler):
(JSC::ListableHandler::List::List):
(JSC::ListableHandler::List::addNotThreadSafe):
(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::hasNext):
(JSC::ListableHandler::List::removeNext):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionally):
* heap/MarkStack.h:
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::addUnconditionalFinalizer):
* heap/SlotVisitor.h:
* heap/UnconditionalFinalizer.h: Added.
(JSC::UnconditionalFinalizer::~UnconditionalFinalizer):
* heap/WeakReferenceHarvester.h:
(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::profiledCodeBlockFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a couple tests that have started hitting asserts on the mac bots.
ojan@chromium.org [Thu, 10 Nov 2011 21:55:33 +0000 (21:55 +0000)]
Add a couple tests that have started hitting asserts on the mac bots.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo not share CSS style for MediaElement backed by a plugin
benjamin@webkit.org [Thu, 10 Nov 2011 21:44:28 +0000 (21:44 +0000)]
Do not share CSS style for MediaElement backed by a plugin
https://bugs.webkit.org/show_bug.cgi?id=72005

Reviewed by Simon Fraser.

With PLUGIN_PROXY_FOR_VIDEO, the RenderMedia elements are rendered through RenderBoxModelObject.
Like the embedded element, the proxied media element can gain a layer outside a change of style.

This patch prevents style sharing for the Audio and Video elements when PLUGIN_PROXY_FOR_VIDEO
is enabled.

This path is covered by exising tests. In particular, http/tests/misc/empty-urls.html
ASSERT() because of this.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ARMv7 register info for the DFG JIT
barraclough@apple.com [Thu, 10 Nov 2011 21:41:04 +0000 (21:41 +0000)]
Add ARMv7 register info for the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72050

Reviewed by Geoff Garen.

* dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WKViews in NSPopovers render as they would in active windows.
timothy@apple.com [Thu, 10 Nov 2011 21:34:00 +0000 (21:34 +0000)]
Make WKViews in NSPopovers render as they would in active windows.

The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
are shown or hidden since they share key with the parent window. So WKView
needs to update the active state during order on/off screen notifications.

https://webkit.org/b/68435

Reviewed by John Sullivan.

* UIProcess/API/mac/WKView.mm:
(-[WKView _windowDidOrderOffScreen:]): Call viewStateDidChange with WebPageProxy::ViewWindowIsActive.
(-[WKView _windowDidOrderOnScreen:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove/copy/merge SVG filter rendering code to generic rendering
dino@apple.com [Thu, 10 Nov 2011 21:31:50 +0000 (21:31 +0000)]
Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Implement an extremely simple version of the filter
chain. Only a single hue-rotate filter is supported
at the moment. The change in this commit was to insert a new
step in RenderLayer's painting to capture the content to an
offscreen ImageBuffer, apply a filter operation on that buffer,
and then draw the result in place of the original element. The full
implementation will need something like the SVGFilterBuilder
but this is a good prototype of effects on HTML content.
It's an open question at the moment as to when the filter
effect should apply: after masking, after overflow, after outline,
etc. Currently the filter applies at the end of the paintLayer code.
This will likely change.

Added a FilterEffectRenderer class that is the root of the filter
tree. At the moment it holds the offscreen context and
the existing paint context.

Other than rendering, the rest of this patch adds tests
to make sure any element with a filter style will become
a RenderLayer. In order to avoid a lot of duplicated code
around the more complex logic tests, RenderStyle::hasFilter
is available outside ENABLE(CSS_FILTERS), but returns false
in those situations.

Tests: css3/filters/add-filter-rendering.html
       css3/filters/remove-filter-rendering.html
       css3/filters/simple-filter-rendering.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/FilterEffectRenderer.cpp: Added.
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::~FilterEffectRenderer):
* rendering/FilterEffectRenderer.h: Added.
(WebCore::FilterEffectRenderer::create):
(WebCore::FilterEffectRenderer::setSourceImageRect):
(WebCore::FilterEffectRenderer::sourceImageRect):
(WebCore::FilterEffectRenderer::setFilterRegion):
(WebCore::FilterEffectRenderer::filterRegion):
(WebCore::FilterEffectRenderer::effectBoundingBoxMode):
(WebCore::FilterEffectRenderer::setEffect):
(WebCore::FilterEffectRenderer::effect):
(WebCore::FilterEffectRenderer::setSourceGraphic):
(WebCore::FilterEffectRenderer::sourceGraphic):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::styleChanged):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::updateFilterBackingStore):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasFilter):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasFilter):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::requiresLayer):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasFilter):

Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Three new tests that exercise the (simple) filter
implementation.

* css3/filters/add-filter-rendering-expected.png: Added.
* css3/filters/add-filter-rendering-expected.txt: Added.
* css3/filters/add-filter-rendering.html: Added.
* css3/filters/remove-filter-rendering-expected.png: Added.
* css3/filters/remove-filter-rendering-expected.txt: Added.
* css3/filters/remove-filter-rendering.html: Added.
* css3/filters/simple-filter-rendering-expected.png: Added.
* css3/filters/simple-filter-rendering-expected.txt: Added.
* css3/filters/simple-filter-rendering.html: Added.
+

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago#ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
barraclough@apple.com [Thu, 10 Nov 2011 21:08:13 +0000 (21:08 +0000)]
#ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
https://bugs.webkit.org/show_bug.cgi?id=72047

Reviewed by Geoff Garen.

We currently don't attempt to abstract divide through the macro assembler,
due to these instructions commonly having specific requirements. This means
there is architecture specific code in the JIT - #ifdef it, and provide a
common implementation.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a simple content layer to TiledCoreAnimationDrawingArea
andersca@apple.com [Thu, 10 Nov 2011 21:06:39 +0000 (21:06 +0000)]
Add a simple content layer to TiledCoreAnimationDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=72044

Reviewed by Darin Adler.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add a content layer member variable.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(-[WKContentLayer _initWithWebPage:WebKit::]):
Add initializer.

(-[WKContentLayer drawInContext:]):
Lay out and draw the web page.

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add the content layer as a sublayer of the root layer.

(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Tell the content layer to paint.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the content layer as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe WKView layer hosting subview needs to be flipped
andersca@apple.com [Thu, 10 Nov 2011 21:06:34 +0000 (21:06 +0000)]
The WKView layer hosting subview needs to be flipped
https://bugs.webkit.org/show_bug.cgi?id=72042

Reviewed by Darin Adler.

In order to match the Core Animation layer hierarchy, the layer hosting WKView
subview needs to be flipped.

* UIProcess/API/mac/WKView.mm:
(-[WKFlippedView isFlipped]):
Add a NSView subview whose sole purpose is to be flipped.

(-[WKView _enterAcceleratedCompositingMode:]):
Create a WKFlippedView instead of a regular NSView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ENABLE_VALUE_PROFILER support for ARMv7
barraclough@apple.com [Thu, 10 Nov 2011 20:38:23 +0000 (20:38 +0000)]
Add ENABLE_VALUE_PROFILER support for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=72043

Reviewed by Geoff Garen.

This requires us to make a bucketCounterRegister available; to do so we'll need to spill more registers on entry to JIT code.

* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_mod):
    - cleanup location of UNUSED_PARAM
* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
    - Update JITStackFrame structure & asm code to spill more registers.
* jit/JSInterfaceJIT.h:
    - Assign a bucketCounterRegister.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix sampling counters on ARMv7, move add64 functionality to macro assembler
barraclough@apple.com [Thu, 10 Nov 2011 20:24:06 +0000 (20:24 +0000)]
Fix sampling counters on ARMv7, move add64 functionality to macro assembler
https://bugs.webkit.org/show_bug.cgi?id=72040

Reviewed by Geoff Garen.

The ability to add an integer to a uint64_t in memory is poorly copied in
multiple places & ifdef'ed on architecture, addWithCarry32 is also a badly
designed interface since add32 is not required to set flags (we have no
concept of flags in the macro assembler interface).

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add64):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add64):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add64):
* dfg/DFGAssemblyHelpers.cpp:
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitCount):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-10 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 20:04:06 +0000 (20:04 +0000)]
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        Update expectations for media/video-frame-accurate-seek.html.

        It's passing consistently.

        * platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-frame-accurate-seek-expected.png.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: --webkit-visual-word crash when create legacy position for shadowRoot
xji@chromium.org [Thu, 10 Nov 2011 19:51:58 +0000 (19:51 +0000)]
Source/WebCore: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

Inside textarea, the shadowed text node's previous leaf node could be the
shadowRoot node, which cause assert exception in creating legacy position based
on such node. Exit previousRootInlineBox() when reach shadowRoot node.

It does not cause problem when looking for text node's next leaf node. Adding
the same checking in nextRootInlineBox just to be safe.

Test: editing/selection/move-by-word-visually-crash-test-textarea.html

* editing/visible_units.cpp:
(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):

LayoutTests: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

* editing/selection/move-by-word-visually-crash-test-textarea-expected.txt: Added.
* editing/selection/move-by-word-visually-crash-test-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd line for very flaky test storage/indexeddb/factory-deletedatabase-interactions...
ojan@chromium.org [Thu, 10 Nov 2011 19:27:47 +0000 (19:27 +0000)]
Add line for very flaky test storage/indexeddb/factory-deletedatabase-interactions.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParse drop-shadow() filter syntax https://bugs.webkit.org/show_bug.cgi?id=69108
dino@apple.com [Thu, 10 Nov 2011 19:26:24 +0000 (19:26 +0000)]
Parse drop-shadow() filter syntax https://bugs.webkit.org/show_bug.cgi?id=69108

Reviewed by Simon Fraser.

Source/WebCore:

Support parsing of the shadow syntax inside drop-shadow
and returning the correct computed style for a filter that
has such a function.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
    Move this from a static function (computedFilter) to a method on
    CSSComputedStyleDeclaration, which allows us to call the
    existing method for shadow styles.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSComputedStyleDeclaration.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):
    Previously parseShadow expected to be called with the entire
    value of a property, not just to look at a restricted subset.
    Change parseShadow to take a CSSParserValueList as parameter,
    allowing it to be used to parse the arguments to the drop-shadow
    function. Also, return the CSSValueList rather than injecting
    it directly into the property value.
(WebCore::filterInfoForName):
(WebCore::CSSParser::parseFilter):
    Support for the drop-shadow() function.
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
    Updated to use the new arguments for parseShadow.

LayoutTests:

Extend existing tests to exercise parsing of valid
and invalid drop-shadow filters, as well as the computed
style.

* css3/filters/filter-property-computed-style-expected.txt:
* css3/filters/filter-property-parsing-expected.txt:
* css3/filters/filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/filter-property-computed-style.js:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 19:22:14 +0000 (19:22 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline Gtk/Win results after r99854.

        * platform/gtk/svg/batik/text/textEffect-expected.txt:
        * platform/gtk/svg/batik/text/textEffect3-expected.txt:
        * platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/gtk/svg/custom/text-filter-expected.txt:
        * platform/gtk/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
        * platform/gtk/svg/filters/filter-on-tspan-expected.txt:
        * platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-10 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 19:09:06 +0000 (19:09 +0000)]
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        Rebaseline fast/layers/video-layer.html due to r98596.

        * platform/chromium-cg-mac-snowleopard/fast/layers/video-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.png.
        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png: Added.
        * platform/chromium-mac/fast/layers/video-layer-expected.png: Removed.
        * platform/chromium-mac/fast/layers/video-layer-expected.txt: Removed.
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines after http://trac.webkit.org/changeset/99854.
ojan@chromium.org [Thu, 10 Nov 2011 18:47:41 +0000 (18:47 +0000)]
Rebaselines after trac.webkit.org/changeset/99854.
The new results were all updated in r99854, but there are sizing differences
on the chromium bots.

* platform/chromium-cg-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/filters/filter-on-tspan-expected.png.
* platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
* platform/chromium-mac-snowleopard/svg/custom/text-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/text-filter-expected.png.
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png.
* platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filter-on-tspan-expected.png.
* platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
* platform/chromium-win/svg/custom/text-filter-expected.txt:
* platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
* platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt:
* platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
adamk@chromium.org [Thu, 10 Nov 2011 18:39:39 +0000 (18:39 +0000)]
[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
https://bugs.webkit.org/show_bug.cgi?id=71939

Reviewed by Ojan Vafai.

These benchmarks time both the DOM mutations themselves and the time taken
to call the MutationCallback. This measurement is achieved by
executing the code entirely within the MutationCallback itself.

* Mutation/append-child-deep.html: Added. Covers appendChild in a 200-node-deep tree with subtree observation.
* Mutation/append-child.html: Added. Covers appendChild in a flat tree.
* Mutation/inner-html.html: Added. Covers innerHTML adding and removing many nodes at a time.
* Mutation/remove-child-deep.html: Added. Covers removeChild in a 200-node-deep tree with subtree observation.
* Mutation/remove-child.html: Added. Covers removeChild in a flat tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: ApplicationCache UI is confusing and incorrect.
vsevik@chromium.org [Thu, 10 Nov 2011 18:36:12 +0000 (18:36 +0000)]
Web Inspector: ApplicationCache UI is confusing and incorrect.
https://bugs.webkit.org/show_bug.cgi?id=64581

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed resources panel application cache UI.
Manifest urls are now shown under application cache tree element.
Under each manifest url tree element frames using relevant application
cache are listed. Application cache detailed views could be opened for each
frame.

Test: http/tests/inspector/resource-tree/appcache-iframe-manifests.html

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::setFrontend):
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::networkStateChanged):
(WebCore::InspectorApplicationCacheAgent::enable):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
(WebCore::InspectorApplicationCacheAgent::getManifestForFrame):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
* inspector/InspectorPageAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
* inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
(WebInspector.ApplicationCacheModel.prototype._mainFrameNavigated):
(WebInspector.ApplicationCacheModel.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheModel.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheModel.prototype._frameManifestUpdated):
(WebInspector.ApplicationCacheModel.prototype._frameManifestRemoved):
(WebInspector.ApplicationCacheModel.prototype.frameManifestURL):
(WebInspector.ApplicationCacheModel.prototype.frameManifestStatus):
(WebInspector.ApplicationCacheModel.prototype._statusUpdated):
(WebInspector.ApplicationCacheModel.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.frameForId):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype.addDocumentURL):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._populateApplicationCacheTree):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestAdded):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestRemoved):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestStatusChanged):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get frameId):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):

LayoutTests:

* http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
* http/tests/inspector/resource-tree/appcache-iframe-manifests.html: Added.
* http/tests/inspector/resource-tree/resources/manifest.php: Added.
* http/tests/inspector/resource-tree/resources/page-with-manifest.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium expectations for r99854.
tonyg@chromium.org [Thu, 10 Nov 2011 18:26:13 +0000 (18:26 +0000)]
Chromium expectations for r99854.

* platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
* platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-11-10 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 18:23:15 +0000 (18:23 +0000)]
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        Few more rebaselines for media/video-frame-accurate-seek-expected.html.

        * platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
        * platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixup expectations for bots that finished cycling after r99760 was committed.
ojan@chromium.org [Thu, 10 Nov 2011 18:16:54 +0000 (18:16 +0000)]
Fixup expectations for bots that finished cycling after r99760 was committed.

* platform/chromium/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
* platform/chromium/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
* platform/chromium/fast/repaint/scroll-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png.
* platform/chromium/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
* platform/chromium/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
* platform/chromium/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
* platform/chromium/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium expectations for r99862.
tonyg@chromium.org [Thu, 10 Nov 2011 18:11:53 +0000 (18:11 +0000)]
Chromium expectations for r99862.

* platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Added.
* platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShrink CSSMutableStyleDeclaration.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:46:27 +0000 (17:46 +0000)]
Shrink CSSMutableStyleDeclaration.
<http://webkit.org/b/72032>

Reviewed by Antti Koivisto.

Move m_strictParsing and m_iteratorCount (debug only) up into
CSSStyleDeclaration, effectively shaving one CPU word (4/8 bytes)
off of every CSSMutableStyleDeclaration.

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSMutableStyleDeclaration.h:
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
* css/CSSStyleDeclaration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] X11 plugins need to be reworked for Qt5
kbalazs@webkit.org [Thu, 10 Nov 2011 17:32:31 +0000 (17:32 +0000)]
[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

.:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

* Source/api.pri: Link to xlib if necessary.

Source/WebCore:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

No new tests. Existing plugin test are sufficient.

* Target.pri:
* bridge/npruntime_internal.h: Added yet another undef
to fix build with Qt5 + X11 headers.
* plugins/qt/QtX11ImageConversion.cpp: Added.
(WebCore::qimageFromXImage):
* plugins/qt/QtX11ImageConversion.h: Added.
Added a helper function to create a QImage from an XImage.
Put it in a new file into WebCore to avoid copyright issues - as
the code has been taken directly from Qt - and to be able to resuse
it for the WK1 plugin support in the future.

Source/WebKit2:

* Target.pri:
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::pluginsDirectories):
Kill the last dependency from the WebKit1 plugin system.
This is necessary because currently we don't build the WebKit1
plugin code. The function is equivalent with the XP_UNIX part of
PluginDatabase::defaultPluginDirectories.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::initializeXEvent):
Rework plugin initialization and drawing model.

Tools:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

* qmake/mkspecs/features/features.prf: Enable X11
plugins if Qt is built with the xcb-xlib backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/dom/htmlcollection-detectability.html has strange failure output.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:25:58 +0000 (17:25 +0000)]
fast/dom/htmlcollection-detectability.html has strange failure output.
<http://webkit.org/b/71946>

Reviewed by Darin Adler.

When a collection should be detectable, but isn't, the test would
say "Failed: document.foo is detectable." It should say that it's
undetectable.

* fast/dom/htmlcollection-detectability.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
vsevik@chromium.org [Thu, 10 Nov 2011 17:12:08 +0000 (17:12 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99870 268f45cc-cd09-0410-ab3c-d52691b4dbfc