WebKit-https.git
8 years agoMoar Chromium Lion rebaselines.
ojan@chromium.org [Fri, 9 Mar 2012 01:53:41 +0000 (01:53 +0000)]
Moar Chromium Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] more comprehensive tests for gesture scrolling
commit-queue@webkit.org [Fri, 9 Mar 2012 01:27:31 +0000 (01:27 +0000)]
[chromium] more comprehensive tests for gesture scrolling
https://bugs.webkit.org/show_bug.cgi?id=80201

Prior to landing some changes to EventHandler::handleGestureEvent, add
some tests to ensure that the behaviour of handleGestureEvent and
handleWheelEvent don't regress.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-08
Reviewed by Dimitri Glazkov.

* fast/events/touch/gesture/resources/gesture-helpers.js: Added: utility functions.
(recordWheel):
(recordScroll):
(exitIfNecessary):
(checkTestDependencies):
(checkScrollOffset):
* fast/events/touch/gesture/resources/scroll-inside-iframe.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-div.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-iframe.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-page.html: Added.
* fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-scroll-shy-target.html: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac build fix for micro data API.
rniwa@webkit.org [Fri, 9 Mar 2012 01:22:49 +0000 (01:22 +0000)]
Mac build fix for micro data API.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::removeCachedMicroDataItemList):
* html/HTMLElement.idl:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Fri, 9 Mar 2012 01:13:47 +0000 (01:13 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Fri, 9 Mar 2012 01:11:53 +0000 (01:11 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Fri, 9 Mar 2012 01:07:25 +0000 (01:07 +0000)]
[chromium] Unreviewed gardening.

Mark a bunch of tests as failing on Leopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoString.prototype.match and replace do not clear global regexp lastIndex per ES5.1...
barraclough@apple.com [Fri, 9 Mar 2012 00:49:31 +0000 (00:49 +0000)]
String.prototype.match and replace do not clear global regexp lastIndex per ES5.1 15.5.4.10
https://bugs.webkit.org/show_bug.cgi?id=26890

Reviewed by Oliver Hunt.

Per 15.10.6.2 step 9.a.1 called via the action of the last iteration of 15.5.4.10 8.f.i.

Source/JavaScriptCore:

* runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):
    - added calls to setLastIndex.

LayoutTests:

* fast/js/script-tests/string-match.js: Added.
* fast/js/string-match-expected.txt: Added.
* fast/js/string-match.html: Added.
    - Added test case for match.
* fast/js/script-tests/string-replace-2.js:
* fast/js/string-replace-2-expected.txt:
    - Added tests for update correct lastIndex handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport [Custom] for static functions
jonlee@apple.com [Fri, 9 Mar 2012 00:46:38 +0000 (00:46 +0000)]
Support [Custom] for static functions
https://bugs.webkit.org/show_bug.cgi?id=80573

Reviewed by Kentaro Hara.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): If the function is static, add static qualifier to cpp function.
(GenerateImplementation): Reorganize the function to split out based on the static
attribute, instead of checking for it at every line we output.
    If the function is static and not custom, the listed code should be the code in
the rest of the function that did not have the static check. If it is custom, then
we check the number of arguments, and then call the static impl function directly.
    If the function is not static, all of the "unless ($function->isStatic)" checks
are removed since it is not necessary.

* bindings/scripts/test/TestObj.idl: Added new test case.

* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjConstructorFunctionClassMethod2):
* bindings/scripts/test/JS/JSTestObj.h:
(JSTestObj):
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj classMethod2]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCollapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
commit-queue@webkit.org [Fri, 9 Mar 2012 00:41:22 +0000 (00:41 +0000)]
Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
https://bugs.webkit.org/show_bug.cgi?id=80592

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

In anticipation of moving FILE_SYSTEM-related code to Modules/, we
are collapsing combination BLOB/FILE_SYSTEM ifdefs to just
BLOB. In other words, it is assumed from now on that you can not
have FILE_SYSTEM support without BLOB support.

No new tests, all existing tests pass.

* CMakeLists.txt:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
(WebCore::ScriptExecutionContext::fileThread):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* fileapi/AsyncFileStream.cpp:
* fileapi/AsyncFileStream.h:
* fileapi/FileError.h:
* fileapi/FileException.cpp:
* fileapi/FileException.h:
* fileapi/FileThread.cpp:
* fileapi/FileThread.h:
* fileapi/OperationNotAllowedException.cpp:
* fileapi/OperationNotAllowedException.h:
* platform/FileStream.cpp:
* platform/FileStream.h:
* platform/FileStreamClient.h:
* platform/SchemeRegistry.cpp:
(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::CORSEnabledSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Always use the current focused node when processing focus changes
commit-queue@webkit.org [Fri, 9 Mar 2012 00:31:40 +0000 (00:31 +0000)]
[BlackBerry] Always use the current focused node when processing focus changes
https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-08
Reviewed by Antonio Gomes.

Guard against toRange or fromRange being null when called
as part of a clear event.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
ojan@chromium.org [Fri, 9 Mar 2012 00:19:40 +0000 (00:19 +0000)]
NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
https://bugs.webkit.org/show_bug.cgi?id=80648

Patch by Andy Estes <aestes@apple.com> on 2012-03-08
Reviewed by Simon Fraser.

* fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
* fast/events/input-element-display-none-in-dragleave-crash.html: Added.
* platform/wk2/Skipped: WebKitTestRunner doesn't support
EventSender.beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Snow Leopard build fix.
jer.noble@apple.com [Fri, 9 Mar 2012 00:13:54 +0000 (00:13 +0000)]
Unreviewed Snow Leopard build fix.

On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:].

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[NSWindow convertRectToScreen:]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[NSWindow convertRectToScreen:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse an explicit attribute to signal that a context prefers to use a discrete GPU
jamesr@google.com [Thu, 8 Mar 2012 23:52:56 +0000 (23:52 +0000)]
Use an explicit attribute to signal that a context prefers to use a discrete GPU
https://bugs.webkit.org/show_bug.cgi?id=80639

Reviewed by Stephen White.

Source/Platform:

Adds preferDiscreteGPU attribute to WebGraphicsContext3D::Attributes. Also remove the forUseOnAnotherThread
attribute, this has been dead code for a while now.

* chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):

Source/WebCore:

On platforms that support both integrated and discrete GPUs and can dynamically switch between the two, we
sometimes have a specific preference for a given context. Specifically, contexts used for WebGL and canvas 2d
acceleration should use the discrete GPU if available, but compositor contexts can run fine on an integrated
GPU. Instead of attempting to infer the intent from examining other context attributes, this adds an explicit
attribute to control this behavior.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3D::create):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
aestes@apple.com [Thu, 8 Mar 2012 23:47:36 +0000 (23:47 +0000)]
NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
https://bugs.webkit.org/show_bug.cgi?id=80648

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/input-element-display-none-in-dragleave-crash.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer().

LayoutTests:

* fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
* fast/events/input-element-display-none-in-dragleave-crash.html: Added.
* platform/wk2/Skipped: WebKitTestRunner doesn't support
EventSender.beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoYet another unreviewed build fix.
jer.noble@apple.com [Thu, 8 Mar 2012 23:46:30 +0000 (23:46 +0000)]
Yet another unreviewed build fix.

Remove an unneeded and Lion-defined window constant from WebCoreFullScreenWindow.

* platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSwitch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and addFocu...
leviw@chromium.org [Thu, 8 Mar 2012 23:41:47 +0000 (23:41 +0000)]
Switch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and addFocusRingRects back to integers
https://bugs.webkit.org/show_bug.cgi?id=80545

Reviewed by Simon Fraser.

Converting the above functions, all of which return rects that represent on-screen rects, to IntRects from
LayoutRects.

addFocusRingsRects generates a vector of rects that is handed off directly to the GraphicsContext to be
drawn. Snapping the rects before adding them to the vector saves an extra pass through the vector.

absoluteRects and culledInlineAbsoluteRects are only used by addFocusRingRects, hasNonEmptyBoundingBox (only
to check if they're empty), and absoluteBoundingBoxRect, which is exposed from WebCore and thus should be an
IntRect anyways.

No new tests. No change in behavior.

* dom/Node.cpp:
(WebCore::Node::hasNonEmptyBoundingBox):
* dom/Range.cpp:
(WebCore::Range::boundingBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
* rendering/RenderListBox.h:
(RenderListBox):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
* rendering/RenderObject.h:
(WebCore::RenderObject::absoluteRects):
(RenderObject):
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::addFocusRingRects):
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
* rendering/RenderText.h:
(RenderText):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
* rendering/RenderTextControl.h:
(RenderTextControl):
* rendering/RenderView.cpp:
(WebCore::RenderView::absoluteRects):
* rendering/RenderView.h:
(RenderView):
* rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::absoluteRects):
* rendering/svg/RenderSVGBlock.h:
(RenderSVGBlock):
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects):
* rendering/svg/RenderSVGContainer.h:
(RenderSVGContainer):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects):
* rendering/svg/RenderSVGImage.h:
(RenderSVGImage):
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::absoluteRects):
* rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::addFocusRingRects):
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFurther unreviewed build fix.
jer.noble@apple.com [Thu, 8 Mar 2012 23:38:11 +0000 (23:38 +0000)]
Further unreviewed build fix.

Add in the WebCore namespace, so that IntRect is pulled in.

* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
* UIProcess/win/WebFullScreenManagerProxyWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Use EventNames instead of strings
arv@chromium.org [Thu, 8 Mar 2012 23:35:15 +0000 (23:35 +0000)]
[V8] Use EventNames instead of strings
https://bugs.webkit.org/show_bug.cgi?id=80649

Reviewed by Ojan Vafai.

No new tests. Covered by existing tests.

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNo-op filter changes color output because of colorspace issues
timothy_horton@apple.com [Thu, 8 Mar 2012 23:32:01 +0000 (23:32 +0000)]
No-op filter changes color output because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=72411
<rdar://problem/10588374>

Reviewed by Dean Jackson.

Redefine "linear RGB" color space on Mac to mean linearized sRGB, instead of linear
Generic RGB. This makes existing CG color matching equivalent to what other ports do via
ImageBuffer::transformColorSpace (which only adjusts gamma, as we will now). Previously,
we were also causing actual (non-gamma) color adjustments which were not reversible.

No new tests, covered by all existing SVG and CSS filter tests.

* Resources/linearSRGB.icc: Added.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::linearRGBColorSpaceRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
jer.noble@apple.com [Thu, 8 Mar 2012 23:28:02 +0000 (23:28 +0000)]
Unreviewed build fix.

Add stub implementations of beganEnterFullScreen and beganExitFullScreen
to platform-specific WebFullScreenManagerProxy implementations.

* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):
* UIProcess/win/WebFullScreenManagerProxyWin.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=80463
bdakin@apple.com [Thu, 8 Mar 2012 23:24:14 +0000 (23:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80463
RenderImage is using the wrong origin when calling addRelevantRepaintedObject
-and corresponding-
<rdar://problem/10970221>

Reviewed by Dan Bernstein.

Source/WebCore:

Use the exact same rect that we paint with instead of the
visualOverflowRect() which does not always have a correct x and y.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):

Tools:

New test!
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
* TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for ENABLE(LEGACY_NOTIFICATIONS)
jonlee@apple.com [Thu, 8 Mar 2012 23:20:00 +0000 (23:20 +0000)]
Add support for ENABLE(LEGACY_NOTIFICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=80497

Reviewed by Adam Barth.

Source/JavaScriptCore:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:

Source/WebKit/mac:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Prep for b80472: Update API for Web Notifications
* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFull Screen Refactor Part 4: Animate into Full Screen mode using new animation classe...
jer.noble@apple.com [Thu, 8 Mar 2012 23:15:05 +0000 (23:15 +0000)]
Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition.
https://bugs.webkit.org/show_bug.cgi?id=78930

Reviewed by Anders Carlsson.

Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController
in WebKit2.  As such, the following functions are copies of their equivalents in WKFullScreenWindowController:
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController init]):
(-[WebFullScreenController dealloc]):
(-[WebFullScreenController windowDidLoad]):
(-[WebFullScreenController cancelOperation:]):
(-[WebFullScreenController applicationDidResignActive:]):
(-[WebFullScreenController applicationDidChangeScreenParameters:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController close]):
(-[WebFullScreenController animationDidEnd:]):
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):
(-[WebFullScreenController _swapView:with:]):
(createBackgroundFullscreenWindow):
(windowFrameFromApparentFrames):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

The following is a copy of the equivalent function in WebFullScreenManager:
* WebView/WebFullScreenController.mm:
(screenRectOfContents):

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.)
* WebView/WebFullScreenController.h:
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController setElement:]): No need to add event listeners to the media element.
(-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous.
(-[WebFullScreenController exitFullScreen]): Ditto.
* WebView/WebView.mm:
(-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen.
(-[WebView _exitFullScreenForElement:WebCore::]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFull Screen Refactor Part 3: Animate into Full Screen mode using new animation classes.
jer.noble@apple.com [Thu, 8 Mar 2012 23:15:00 +0000 (23:15 +0000)]
Full Screen Refactor Part 3: Animate into Full Screen mode using new animation classes.
https://bugs.webkit.org/show_bug.cgi?id=78928

Reviewed by Anders Carlsson.

Source/WebCore:

Move WKFullScreenWindow from WebKit2 into WebCore to be shared by WebKit2 and WebKit.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/WebCoreFullScreenWindow.h:
* platform/mac/WebCoreFullScreenWindow.mm:

Add symbols for the following classes and functions to the export list:
    WebCoreFullScreenWindow
    WebWindowScaleAnimation
    WebWindowFadeAnimation
    ScrollView::contentsToScreen()
    RenderObject::localToContainerQuad()
    Document::setAnimatingFullScreen()
* WebCore.exp.in:

Source/WebKit2:

Boilerplate changes to WebKit2 IPC messages and supporting functions.
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen): Added boilerplate.
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/WebFullScreenManagerProxy.messages.in:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen): Added boilerplate.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen): Added boilerplate.
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::screenRectOfContents): Added.  Calculates the screen rect of an element's contents.
(WebKit::WebFullScreenManager::enterFullScreenForElement): Use screenRectOfContents()
(WebKit::WebFullScreenManager::willEnterFullScreen): Ditto. Do not set the background color. Call new BeganEnterFullScreen
    XPC message.
(WebKit::WebFullScreenManager::didEnterFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::willExitFullScreen): Use screenRectOfContents. Do not set the background color. Call new
    BeganExitFullScreen XPC message.
(WebKit::WebFullScreenManager::didExitFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::setAnimatingFullScreen): Added boilerplate.
* WebProcess/FullScreen/WebFullScreenManager.h:
* WebProcess/FullScreen/WebFullScreenManager.messages.in:

* UIProcess/mac/WKFullScreenWindowController.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController cancelOperation:]): Renamed from _requestExitWithAnimation:.
(-[WKFullScreenWindowController applicationDidResignActive:]): Call cancelOperation: instead
    of _requestExitWithAnimation.
(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): Set the frame of
    both the full screen window and the background window.
(-[WKFullScreenWindowController enterFullScreen:]): Save a rendered image of the current
    page to use in the placeholder.
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from
    beganEnterFullScreenAnimation.
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): No need to swap
    placeholder views here, as they were already swapped in beganEnter...:.
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from
    beganExitFullScreenAnimation.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Swap web view back into place.
(-[WKFullScreenWindowController close]):
(-[WKFullScreenWindowController animationDidEnd:]): Added.
(createBackgroundFullscreenWindow): Added.
(windowFrameFromApparentFrames): Added.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Added.
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFull Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
jer.noble@apple.com [Thu, 8 Mar 2012 23:14:53 +0000 (23:14 +0000)]
Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
https://bugs.webkit.org/show_bug.cgi?id=78926

Reviewed by John Sullivan.

The following functions (and also their Proxy versions) were removed completely:
WebFullScreenManager::enterAcceleratedCompositingMode(const LayerTreeContext&)
WebFullScreenManager::exitAcceleratedCompositingMode()
WebFullScreenManager::beganEnterFullScreenAnimation()
WebFullScreenManager::finishedEnterFullScreenAnimation(bool)
WebFullScreenManager::beganExitFullScreenAnimation()
WebFullScreenManager::finishedExitFullScreenAnimation(bool)
WebFullScreenManager::getFullScreenRect(WebCore::IntRect&)

* UIProcess/WebFullScreenManagerProxy.cpp:
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit::WebFullScreenManagerProxy::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beginExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::disposeOfLayerClient):
(WebFullScreenManagerProxy):
* UIProcess/WebFullScreenManagerProxy.messages.in:
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
* UIProcess/win/WebFullScreenManagerProxyWin.cpp:
(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManager::~WebFullScreenManager):
* WebProcess/FullScreen/WebFullScreenManager.h:
(WebFullScreenManager):
* WebProcess/FullScreen/WebFullScreenManager.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exitFullScreenForElement):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

Additionally, the platform-specific WebFullScreenManager subclasses were removed, as no
platform-specific implementations remained after the above functions were removed:
* GNUmakefile.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Removed.
* WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Removed.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Removed.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Removed.
* WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Removed.
* WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Removed.
* WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Removed.
* WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFull Screen Refactor Part 1: Remove special-case rendering code for Full Screen anima...
jer.noble@apple.com [Thu, 8 Mar 2012 23:14:46 +0000 (23:14 +0000)]
Full Screen Refactor Part 1: Remove special-case rendering code for Full Screen animation.
https://bugs.webkit.org/show_bug.cgi?id=78925

Reviewed by John Sullivan.

No new tests; no net change in functionality so covered by existing tests.

The following functions had special case code for rendering full-screen elements removed:
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::setAnimatingFullScreen):
* page/FrameView.cpp:
(WebCore):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::syncCompositingStateForThisFrame):
* rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsTransformed):
(WebCore::RenderLayerBacking::updateCompositedBounds):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't enable VIDEO_TRACK on all OS X platforms
mlilek@apple.com [Thu, 8 Mar 2012 23:08:56 +0000 (23:08 +0000)]
Don't enable VIDEO_TRACK on all OS X platforms
https://bugs.webkit.org/show_bug.cgi?id=80635

Reviewed by Eric Carlson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMoar Chromium Lion rebaselines.
ojan@chromium.org [Thu, 8 Mar 2012 23:05:21 +0000 (23:05 +0000)]
Moar Chromium Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoperf-o-matic should incrementally update JSON responses
rniwa@webkit.org [Thu, 8 Mar 2012 22:58:54 +0000 (22:58 +0000)]
perf-o-matic should incrementally update JSON responses
https://bugs.webkit.org/show_bug.cgi?id=79898

Reviewed by Eric Seidel.

Now that Runs object store test_runs and averages separately,
we can update JSON data incrementally without degrading values.

Also fixed the order of arguments passed to DashboardImage.needs_update
in schedule_runs_update. This bug had caused all chart images to be
updated on every new report.

* Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
* Websites/webkit-perf.appspot.com/models.py:
(Runs.update_or_insert):
(Runs.update_incrementally):
(Runs):
(Runs.get_by_objects):
* Websites/webkit-perf.appspot.com/models_unittest.py:
(RunsTest._create_results):
(RunsTest.test_generate_runs):
(RunsTest.test_update_or_insert):
(RunsTest.test_update_incrementally):
(RunsTest.test_to_json_with_results):
* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoimplement flexbox wrap-reverse
tony@chromium.org [Thu, 8 Mar 2012 22:55:53 +0000 (22:55 +0000)]
implement flexbox wrap-reverse
https://bugs.webkit.org/show_bug.cgi?id=80552

Reviewed by Ojan Vafai.

Source/WebCore:

No new tests, but additional coverage in:
    css3/flexbox/multiline-align.html
    css3/flexbox/multiline-pack.html
    css3/flexbox/multiline.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::WrapReverseContext::WrapReverseContext): Helper struct to hold information needed for reversing
the order of lines.
(RenderFlexibleBox::WrapReverseContext):
(WebCore::RenderFlexibleBox::WrapReverseContext::addCrossAxisOffset):
(WebCore::RenderFlexibleBox::WrapReverseContext::addNumberOfChildrenOnLine):
(WebCore::RenderFlexibleBox::WrapReverseContext::lineCrossAxisDelta): Computes the number of pixels to move a line.
(WebCore):
(WebCore::RenderFlexibleBox::layoutFlexItems): Call flipForWrapReverse if needed. This happens
before flipForRightToLeftColumn because otherwise the crossAxisOffsets will be wrong.
(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::alignChildren): Flip alignment in wrap-reverse because the cross directions are flipped.
(WebCore::RenderFlexibleBox::flipForWrapReverse): Flip each line.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/multiline-align-expected.txt:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-expected.txt:
* css3/flexbox/multiline-pack-expected.txt:
* css3/flexbox/multiline-pack.html:
* css3/flexbox/multiline.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. That day is not today.
oliver@apple.com [Thu, 8 Mar 2012 22:53:01 +0000 (22:53 +0000)]
Build fix.  That day is not today.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove InDocumentFlag manipulation methods from Node interface
adamk@chromium.org [Thu, 8 Mar 2012 22:47:44 +0000 (22:47 +0000)]
Remove InDocumentFlag manipulation methods from Node interface
https://bugs.webkit.org/show_bug.cgi?id=80612

Reviewed by Ryosuke Niwa.

This is a first step towards tightening up Node::inDocument() to match
the actual in-document-tree state (see r108152 for the sort of bug
resulting from those not matching).

No new tests, refactoring only.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument:
the call to Node::removedFromDocument three lines above will clear the flag.
* dom/Document.cpp:
(WebCore::Document::Document): Call ContainerNode constructor with InDocumentFlag always set
instead of calling setInDocument.
* dom/Node.cpp:
(WebCore::Node::insertedIntoDocument): Inline setInDocument (now the only caller).
(WebCore::Node::removedFromDocument): Inline clearInDocument (now the only caller).
* dom/Node.h: Remove setInDocument & clearInDocument, add new CreateDocument ConstructionType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. One of these days I'll manage to commit something that works everywhere.
oliver@apple.com [Thu, 8 Mar 2012 22:29:09 +0000 (22:29 +0000)]
Build fix. One of these days I'll manage to commit something that works everywhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Try to fix the Snow Leopard build
vestbo@webkit.org [Thu, 8 Mar 2012 22:09:53 +0000 (22:09 +0000)]
[Qt] Try to fix the Snow Leopard build

If the build is running under sh, echo -n does not empty the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate MIPS patchOffsetGetByIdSlowCaseCall
commit-queue@webkit.org [Thu, 8 Mar 2012 22:03:09 +0000 (22:03 +0000)]
Update MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=80302

Patch by Chao-ying Fu <fu@mips.com> on 2012-03-08
Reviewed by Oliver Hunt.

* jit/JIT.h:
(JIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProspective build fix for Qt minimal after r110191
vestbo@webkit.org [Thu, 8 Mar 2012 22:00:19 +0000 (22:00 +0000)]
Prospective build fix for Qt minimal after r110191

https://bugs.webkit.org/show_bug.cgi?id=80338

* testing/Internals.cpp:
(WebCore):
* testing/Internals.h:
(Internals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Chromium Lion rebaselines as well as some fixes for
ojan@chromium.org [Thu, 8 Mar 2012 22:00:00 +0000 (22:00 +0000)]
More Chromium Lion rebaselines as well as some fixes for
Chromium Leopard/SnowLeopard from previous Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMissing some places where we should be blinding 64bit values (and blinding something...
oliver@apple.com [Thu, 8 Mar 2012 21:58:32 +0000 (21:58 +0000)]
Missing some places where we should be blinding 64bit values (and blinding something we shouldn't)
https://bugs.webkit.org/show_bug.cgi?id=80633

Reviewed by Gavin Barraclough.

Add 64-bit trap for shouldBlindForSpecificArch, so that we always blind
if there isn't a machine specific implementation (otherwise the 64bit value
got truncated and 32bit checks were used -- leaving 32bits untested).
Also add a bit of logic to ensure that we don't try to blind a few common
constants that go through the ImmPtr paths -- encoded numeric JSValues and
unencoded doubles with common "safe" values.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlindDouble):
(MacroAssembler):
(JSC::MacroAssembler::shouldBlind):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Prospective Windows build fix
vestbo@webkit.org [Thu, 8 Mar 2012 21:49:16 +0000 (21:49 +0000)]
[Qt] Prospective Windows build fix

Don't assume that windows-builds will always run inside a cmd.exe shell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Creating a selector for class names with trailing spaces results with...
commit-queue@webkit.org [Thu, 8 Mar 2012 21:40:32 +0000 (21:40 +0000)]
Web Inspector: Creating a selector for class names with trailing spaces results with two dots instead of one
https://bugs.webkit.org/show_bug.cgi?id=80529

Trim the className before replacing the whitespaces with dot "."

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-03-08
Reviewed by Pavel Feldman.

No new tests.

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout test for window.devicePixelRatio
commit-queue@webkit.org [Thu, 8 Mar 2012 21:23:38 +0000 (21:23 +0000)]
Layout test for window.devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=80292

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-08
Reviewed by Rob Buis.

* fast/viewport/viewport-133-expected.txt: Added.
* fast/viewport/viewport-133.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10981173> Dashboard regions should not be in device space
mitz@apple.com [Thu, 8 Mar 2012 21:20:30 +0000 (21:20 +0000)]
<rdar://problem/10981173> Dashboard regions should not be in device space

Reviewed by John Sullivan.

Source/WebCore:

Test: TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm

* rendering/RenderInline.cpp:
(WebCore::RenderInline::addDashboardRegions): Stop applying the device scale factor to
Dashboard regions.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addDashboardRegions): Ditto.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
(-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch works oddly on local Git branches
dpranke@chromium.org [Thu, 8 Mar 2012 21:03:10 +0000 (21:03 +0000)]
webkit-patch works oddly on local Git branches
https://bugs.webkit.org/show_bug.cgi?id=76958

Reviewed by Ojan Vafai.

This change makes the '-g' flag to webkit-patch behave a
little more consistently with git. The 'HEAD..' syntax
is changed to 'HEAD....' (four dots), so as to not
collide with the underlying git syntax. We also generalize
the syntax to support any refname, so 'foo....' means
diff against foo and include working copy changes.

This change also adds the 'UPSTREAM' shortcut to identify
whatever the current upstream/tracking branch is; this is
useful if you have multiple local branches stacked up.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git._branch_from_ref):
(Git):
(Git._current_branch):
(Git._upstream_branch):
(Git.merge_base):
(Git._commit_on_branch):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitSVNTest._second_local_commit):
(GitSVNTest._two_local_commits):
(GitSVNTest.test_commit_with_message_git_commit_range):
(GitSVNTest.test_upstream_branch):
(GitSVNTest.test_create_patch_working_copy_only):
(GitSVNTest.test_changed_files_local_plus_working_copy):
(GitSVNTest.test_changed_files_working_copy_only):
(GitSVNTest.test_changed_files_upstream):
* Scripts/webkitpy/tool/steps/options.py:
(Options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/11012572> Ensure that the staged frameworks path is in the search...
mrowe@apple.com [Thu, 8 Mar 2012 20:43:24 +0000 (20:43 +0000)]
<rdar://problem/11012572> Ensure that the staged frameworks path is in the search path for JavaScriptCore

Reviewed by Dan Bernstein.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Cannot insert right curly bracket on some keyboards
commit-queue@webkit.org [Thu, 8 Mar 2012 20:34:26 +0000 (20:34 +0000)]
Web Inspector: Cannot insert right curly bracket on some keyboards
https://bugs.webkit.org/show_bug.cgi?id=80474

Make sure other modifiers are not pressed

Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-03-08
Reviewed by Pavel Feldman

* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a method to window.internals to enable testing of inspector highlight rects
commit-queue@webkit.org [Thu, 8 Mar 2012 20:32:56 +0000 (20:32 +0000)]
Add a method to window.internals to enable testing of inspector highlight rects
https://bugs.webkit.org/show_bug.cgi?id=80338

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-08
Reviewed by Pavel Feldman.

.:

* Source/autotools/symbols.filter: Export symbols for GTK.

Source/WebCore:

Add window.internals.inspectorHighlightRects, a method which makes it possible to test the
positions and sizes of inspector highlight rects.

Test: inspector/elements/highlight-node.html

* WebCore.exp.in: Export symbols.
* testing/Internals.cpp:
(WebCore::Internals::inspectorHighlightRects): Call InspectorController::getHighlight and
return the highlight's quads as a ClientRectList.
(WebCore):
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:

    Add inspectorHighlightRects to the window.internals interface.

Source/WebKit2:

* win/WebKit2.def: Export symbols for win.
* win/WebKit2CFLite.def: Same as above.

LayoutTests:

* inspector/elements/highlight-node-expected.txt: Added.
* inspector/elements/highlight-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=80370
antti@apple.com [Thu, 8 Mar 2012 20:17:24 +0000 (20:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80370
Enable matched declaration caching for elements with a style attribute

Reviewed by Andreas Kling

* Api/qwebelement.cpp:
(QWebElement::styleProperty):
(QWebElement::setStyleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Chromium Lion rebaselines.
ojan@chromium.org [Thu, 8 Mar 2012 20:16:27 +0000 (20:16 +0000)]
More Chromium Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=80370
antti@apple.com [Thu, 8 Mar 2012 20:15:16 +0000 (20:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80370
Enable matched declaration caching for elements with a style attribute

Reviewed by Andreas Kling

Make the property set for style attribute immutable as long as there is no CSSOM
wrapper for it. If the style attribute changes we create a new property set instead
of recycling the old one. This way the property sets can be made cacheable as long
as there is no CSSOM wrapper that would allow uncontrolled modifications. Constructing
the wrapper disables caching.

Made StyledElement::inlineStyle() and StyledElement::ensureInlineStyle() return a const
StylePropertySet so making accidental modifications difficult. Also dropped *Decl from
the names.

Fixed two unrelated bugs that this exposed.

* css/CSSStyleSelector.cpp:

    Don't allow caching of document element style if writingModeSetOnDocumentElement() bit is set.
    Tested by fast/multicol/vertical-rl/break-properties.html.

(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/StylePropertySet.h:
(StylePropertySet):
(WebCore::StylePropertySet::hasCSSOMWrapper):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):

    Invalidate the matched properties cache if the document has rem units and the root font changes.
    Tested by fast/css/rem-dynamic-scaling.html.

* dom/ElementAttributeData.cpp:
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
(WebCore::ElementAttributeData::destroyInlineStyle):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::inlineStyle):
(ElementAttributeData):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::~StyledElement):
(WebCore):
(WebCore::StyledElement::style):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyle):
(WebCore::StyledElement::ensureInlineStyle):
(StyledElement):
(WebCore::StyledElement::destroyInlineStyle):
* editing/ApplyStyleCommand.cpp:
(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/EditingStyle.cpp:
(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(HTMLTextDecorationEquivalent):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
(WebCore::EditingStyle::mergeStyle):
* editing/EditingStyle.h:
(EditingStyle):
* editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::styleFromMatchedRulesAndInlineDecl):
* html/HTMLElement.cpp:
(WebCore::StyledElement::copyNonAttributeProperties):
* html/canvas/CanvasStyle.cpp:
(WebCore::currentColor):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::retrieveResourcesForProperties):
* page/PageSerializer.h:
(PageSerializer):
* rendering/RenderTreeAsText.cpp:
(WebCore::isEmptyOrUnstyledAppleStyleSpan):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 8 Mar 2012 20:06:33 +0000 (20:06 +0000)]
[chromium] Unreviewed gardening.

Fallout from r110179.

* platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Block file-to-file access by default
commit-queue@webkit.org [Thu, 8 Mar 2012 19:59:13 +0000 (19:59 +0000)]
[BlackBerry] Block file-to-file access by default
https://bugs.webkit.org/show_bug.cgi?id=80605

Patch by Yong Li <yoli@rim.com> on 2012-03-08
Reviewed by Rob Buis.

Turn off allowFileAccessFromFileURLs() by default.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHave ScrollAnimatorNone use requestAnimationFrame
commit-queue@webkit.org [Thu, 8 Mar 2012 19:37:34 +0000 (19:37 +0000)]
Have ScrollAnimatorNone use requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=78938

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-08
Reviewed by James Robinson.

Source/WebCore:

No new tests. Passes Chromium webkit_unit_tests.

* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::serviceScrollAnimations):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore):
(WebCore::ScrollAnimatorNone::serviceScrollAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::startNextTimer):
(WebCore::ScrollAnimatorNone::animationTimerActive):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):
* platform/ScrollAnimatorNone.h:
(ScrollAnimatorNone):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::serviceScrollAnimations):
(WebCore):
* platform/ScrollableArea.h:
(WebCore):
(ScrollableArea):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::hostWindow):
(RenderLayer):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::hostWindow):
(RenderListBox):

Source/WebKit/chromium:

* src/ScrollbarGroup.h:
(WebCore):
(WebKit::ScrollbarGroup::hostWindow):
(ScrollbarGroup):
* tests/ScrollAnimatorNoneTest.cpp:
(MockScrollableArea::hostWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r109964): Assertion failure (!isUndefined()) in Length::getIntValue(...
mitz@apple.com [Thu, 8 Mar 2012 19:18:44 +0000 (19:18 +0000)]
REGRESSION (r109964): Assertion failure (!isUndefined()) in Length::getIntValue() when a Dashboard region is specified without offsets
https://bugs.webkit.org/show_bug.cgi?id=80614

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/css/dashboard-regions-undefined-length-assertion.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList): Reverted to setting zero lengths,
rather than Undefined ones, in the RenderStyle when offsets are not given.

LayoutTests:

* fast/css/dashboard-regions-undefined-length-assertion-expected.txt: Added.
* fast/css/dashboard-regions-undefined-length-assertion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 8 Mar 2012 19:18:17 +0000 (19:18 +0000)]
[chromium] Unreviewed gardening.

Rebaseline all TEXT results affected by r110072.

* fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
* fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
* fast/block/float/in-margin-expected.txt: Added.
* fast/clip/017-expected.txt: Added.
* fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
* fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
* fast/dynamic/subtree-table-cell-height-expected.txt: Added.
* platform/chromium-linux-x86/compositing/overflow: Removed.
* platform/chromium-linux-x86/fast/layers: Added.
* platform/chromium-linux-x86/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-linux-x86/fast/layers/self-painting-outline-expected.txt: Added.
* platform/chromium-linux-x86/fast/overflow: Removed.
* platform/chromium-linux-x86/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/chromium-linux-x86/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-linux-x86/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/chromium-linux-x86/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-linux-x86/fast/replaced: Removed.
* platform/chromium-linux-x86/fast/text: Added.
* platform/chromium-linux-x86/fast/text/selection-painted-separately-expected.txt: Added.
* platform/chromium-linux-x86/tables/mozilla/bugs: Removed.
* platform/chromium-linux/editing/selection/3690703-2-expected.txt:
* platform/chromium-linux/editing/selection/3690703-expected.txt:
* platform/chromium-linux/editing/selection/3690719-expected.txt:
* platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
* platform/chromium-linux/fast/css/input-search-padding-expected.txt:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/input-baseline-expected.txt:
* platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
* platform/chromium-linux/fast/forms/input-value-expected.txt:
* platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-linux/fast/invalid/residual-style-expected.txt:
* platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-linux/fast/layers/self-painting-outline-expected.txt: Added.
* platform/chromium-linux/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/chromium-linux/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-linux/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/chromium-linux/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
* platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-linux/fast/text/selection-painted-separately-expected.txt: Added.
* platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
* platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
* platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
* platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac-leopard/fast/layers/self-painting-outline-expected.txt: Added.
* platform/chromium-mac-leopard/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/selection-painted-separately-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/3690703-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/3690719-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/4975120-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/float/032-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/float/033-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-font-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/lineboxcontain/font-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/lineboxcontain/glyphs-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-table-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-width-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/html/details-open2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/html/details-open4-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/invalid: Added.
* platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/layers/self-painting-outline-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/multicol/layers-split-across-columns-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/overflow/004-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/overflow/line-clamp-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/overflow/overflow-focus-ring-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/layer-outline-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/layer-outline-horizontal-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/lines-with-layout-delta-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/003-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/029-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/overflowHidden-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/selection-painted-separately-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/selection-rect-rounding-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.txt: Added.
* platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug154780-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Added.
* platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.txt: Added.
* platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt: Added.
* platform/chromium-mac/fast/block/float/033-expected.txt: Removed.
* platform/chromium-mac/fast/clip/008-expected.txt: Added.
* platform/chromium-mac/fast/clip/011-expected.txt: Added.
* platform/chromium-mac/fast/clip/012-expected.txt: Added.
* platform/chromium-mac/fast/css/input-search-padding-expected.txt: Added.
* platform/chromium-mac/fast/css/invalidation-errors-2-expected.txt: Added.
* platform/chromium-mac/fast/css/invalidation-errors-expected.txt: Added.
* platform/chromium-mac/fast/css/line-height-expected.txt: Added.
* platform/chromium-mac/fast/css/nested-layers-with-hover-expected.txt: Added.
* platform/chromium-mac/fast/dom/isindex-001-expected.txt: Added.
* platform/chromium-mac/fast/dom/isindex-002-expected.txt: Added.
* platform/chromium-mac/fast/events/context-no-deselect-expected.txt: Added.
* platform/chromium-mac/fast/forms/basic-inputs-expected.txt: Added.
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Added.
* platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
* platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Added.
* platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* platform/chromium-win-vista/compositing/overflow: Removed.
* platform/chromium-win-vista/fast/layers: Added.
* platform/chromium-win-vista/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-win-vista/fast/layers/self-painting-outline-expected.txt: Added.
* platform/chromium-win-vista/fast/multicol: Removed.
* platform/chromium-win-vista/fast/repaint: Added.
* platform/chromium-win-vista/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/chromium-win-vista/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-win-vista/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/chromium-win-vista/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt: Added.
* platform/chromium-win-vista/http/tests/navigation: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs: Added.
* platform/chromium-win-xp/compositing/overflow: Removed.
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win-xp/fast/layers: Added.
* platform/chromium-win-xp/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-win-xp/fast/layers/self-painting-outline-expected.txt: Added.
* platform/chromium-win-xp/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/chromium-win-xp/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-win-xp/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/chromium-win-xp/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-win-xp/fast/replaced: Removed.
* platform/chromium-win-xp/fast/text/selection-painted-separately-expected.txt: Added.
* platform/chromium-win/compositing/overflow/ancestor-overflow-expected.txt:
* platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
* platform/chromium-win/editing/pasteboard/4806874-expected.txt:
* platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
* platform/chromium-win/editing/selection/3690703-2-expected.txt:
* platform/chromium-win/editing/selection/3690703-expected.txt:
* platform/chromium-win/editing/selection/3690719-expected.txt:
* platform/chromium-win/editing/selection/4895428-3-expected.txt:
* platform/chromium-win/editing/selection/4975120-expected.txt:
* platform/chromium-win/editing/selection/drag-select-1-expected.txt:
* platform/chromium-win/editing/selection/expanding-selections-expected.txt:
* platform/chromium-win/editing/selection/leave-requested-block-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt:
* platform/chromium-win/fast/block/float/032-expected.txt:
* platform/chromium-win/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
* platform/chromium-win/fast/css/input-search-padding-expected.txt:
* platform/chromium-win/fast/css/invalidation-errors-2-expected.txt:
* platform/chromium-win/fast/css/invalidation-errors-expected.txt:
* platform/chromium-win/fast/css/line-height-expected.txt:
* platform/chromium-win/fast/css/nested-layers-with-hover-expected.txt:
* platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/chromium-win/fast/css/text-overflow-input-expected.txt:
* platform/chromium-win/fast/dom/isindex-001-expected.txt:
* platform/chromium-win/fast/dom/isindex-002-expected.txt:
* platform/chromium-win/fast/events/autoscroll-expected.txt:
* platform/chromium-win/fast/events/context-no-deselect-expected.txt:
* platform/chromium-win/fast/forms/basic-inputs-expected.txt:
* platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-win/fast/forms/encoding-test-expected.txt:
* platform/chromium-win/fast/forms/fieldset-align-expected.txt:
* platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
* platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-win/fast/forms/input-align-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
* platform/chromium-win/fast/forms/input-baseline-expected.txt:
* platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
* platform/chromium-win/fast/forms/input-spaces-expected.txt:
* platform/chromium-win/fast/forms/input-table-expected.txt:
* platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
* platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
* platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/chromium-win/fast/forms/input-value-expected.txt:
* platform/chromium-win/fast/forms/input-width-expected.txt:
* platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
* platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/chromium-win/fast/forms/search-rtl-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
* platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
* platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
* platform/chromium-win/fast/forms/text-style-color-expected.txt:
* platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
* platform/chromium-win/fast/html/details-no-summary4-expected.txt:
* platform/chromium-win/fast/html/details-open-javascript-expected.txt:
* platform/chromium-win/fast/html/details-open2-expected.txt:
* platform/chromium-win/fast/html/details-open4-expected.txt:
* platform/chromium-win/fast/invalid/residual-style-expected.txt:
* platform/chromium-win/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-win/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/chromium-win/fast/layers/self-painting-outline-expected.txt: Added.
* platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
* platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt:
* platform/chromium-win/fast/overflow/004-expected.txt:
* platform/chromium-win/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/chromium-win/fast/overflow/line-clamp-expected.txt:
* platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
* platform/chromium-win/fast/repaint/inline-relative-positioned-expected.txt:
* platform/chromium-win/fast/repaint/layer-outline-expected.txt:
* platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/chromium-win/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/chromium-win/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/chromium-win/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/chromium-win/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/chromium-win/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-win/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/chromium-win/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
* platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
* platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
* platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
* platform/chromium-win/fast/table/003-expected.txt:
* platform/chromium-win/fast/table/029-expected.txt:
* platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/chromium-win/fast/table/overflowHidden-expected.txt:
* platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
* platform/chromium-win/fast/table/text-field-baseline-expected.txt:
* platform/chromium-win/fast/text/selection-painted-separately-expected.txt: Added.
* platform/chromium-win/fast/text/selection-rect-rounding-expected.txt:
* platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/chromium-win/svg/hixie/mixed/003-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/45621-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug154780-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
* platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
* platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
* platform/chromium/fast/block/float/033-expected.txt: Added.
* platform/chromium/fast/block/float/avoidance-rtl-expected.txt: Added.
* platform/chromium/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/chromium/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
* platform/chromium/fast/block/float/in-margin-expected.txt: Added.
* platform/chromium/fast/clip: Added.
* platform/chromium/fast/clip/017-expected.txt: Added.
* platform/chromium/fast/dynamic: Added.
* platform/chromium/fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
* platform/chromium/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
* platform/chromium/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
* platform/chromium/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium/fast/speech: Removed.
* platform/chromium/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitGtk+ fails to build on win32 against GTK3
commit-queue@webkit.org [Thu, 8 Mar 2012 19:15:08 +0000 (19:15 +0000)]
WebKitGtk+ fails to build on win32 against GTK3
https://bugs.webkit.org/show_bug.cgi?id=63919

Patch by Mikkel Kruse Johnsen <mikkel@linet.dk> on 2012-03-08
Reviewed by Gustavo Noronha Silva.

* plugins/gtk/PluginViewGtk.cpp: Don't use gtk_socket_new with GTK3 on Win32
(WebCore::PluginView::platformStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix line endings for copy-files.cmd.
sfalken@apple.com [Thu, 8 Mar 2012 19:13:49 +0000 (19:13 +0000)]
Fix line endings for copy-files.cmd.

If a cmd file doesn't have Windows line endings, it doesn't work properly.
In this case, the label :clean wasn't found, breaking the clean build.

Reviewed by Jessie Berlin.

* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry]New feature: support about:cookie for internal build.
commit-queue@webkit.org [Thu, 8 Mar 2012 19:01:43 +0000 (19:01 +0000)]
[BlackBerry]New feature: support about:cookie for internal build.
https://bugs.webkit.org/show_bug.cgi?id=80367

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-08
Reviewed by Antonio Gomes.

No new tests.

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore):
* platform/blackberry/CookieManager.h:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleAbout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Always use the current focused node when processing focus changes
commit-queue@webkit.org [Thu, 8 Mar 2012 18:21:57 +0000 (18:21 +0000)]
[BlackBerry] Always use the current focused node when processing focus changes
https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-08
Reviewed by Antonio Gomes.

Update InputHandler focused node handling to strictly use
the currently focused node.  This prevents a handling loop
when JS is modifying the focus and we get a late notification
of a past change from ChromeClientBlackBerry with the previously
unfocused node.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::focusedNodeChanged):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
(WebCore::EditorClientBlackBerry::setInputMethodState):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
* WebKitSupport/InputHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Windows build fixing.
jberlin@webkit.org [Thu, 8 Mar 2012 18:09:07 +0000 (18:09 +0000)]
More Windows build fixing.

* gtest/msvc/gtest-md.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMade extract-localizable-strings ignore NSLocalizedFileSizeDescription
sullivan@apple.com [Thu, 8 Mar 2012 17:48:31 +0000 (17:48 +0000)]
Made extract-localizable-strings ignore NSLocalizedFileSizeDescription

Reviewed by Eric Carlson.

* Scripts/extract-localizable-strings:
Added NSLocalizedFileSizeDescription to allowed list of tokens that start
with NSLocalized. Also improved an error message to include the troublesome token.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake elements with attributes smaller by eliminating the m_element back pointer in...
caio.oliveira@openbossa.org [Thu, 8 Mar 2012 17:42:28 +0000 (17:42 +0000)]
Make elements with attributes smaller by eliminating the m_element back pointer in NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=75069

Reviewed by Ryosuke Niwa.

Source/WebCore:

NamedNodeMap is an exposed DOM representation of an element's attribute storage. As part of
its implementation it keeps a pointer to its associated Element plus all the attribute
storage.

This commit separate the two things: NamedNodeMap is now a wrapper to Element, containing
only the pointer, and the attribute storage is now owned by Element directly. Since usage
of NamedNodeMap is not very common, it can be stored in ElementRareData. As a result, most
elements with attributes now don't need to allocate memory for that extra pointer in
NamedNodeMap.

One consequence of this implementation is that now we explicitly don't support
DocumentType.notations and DocumentType.entities. They weren't supported before, a
NamedNodeMap was never created for those attributes -- and some NamedNodeMap functions
wouldn't work correctly without an associated Element.

NamedNodeMap itself was cleaned up, as well as unnecessary references to it removed in the
code and comments.

No new tests and should not change results for existing tests.

* dom/Attribute.h:
(WebCore):
* dom/DocumentType.h:
(DocumentType): Point out that we don't support does attributes yet.
* dom/Element.cpp:
(WebCore::Element::~Element): Detaching the NamedNodeMap is no longer necessary because it
will be destroyed. We still detach the potential Attrs inside our Attributes by using
clearAttributes().
(WebCore::Element::attributes): Looks in ElementRareData now. Note we ensure the creation
of the attribute storage.
(WebCore):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasAttributes):
(WebCore::Element::createAttributeData):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::hasNamedNodeMap): Helper function for Node::dumpStatistics().
* dom/Element.h:
(Element):
(WebCore::Element::attributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::create):
(ElementAttributeData):
* dom/ElementRareData.h:
(ElementRareData):
* dom/NamedNodeMap.cpp: Rewriting now that m_attributeData is not a member, using m_element
methods when possible.
(WebCore::NamedNodeMap::ref):
(WebCore::NamedNodeMap::deref):
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item):
(WebCore::NamedNodeMap::length):
* dom/NamedNodeMap.h:
(WebCore):
(WebCore::NamedNodeMap::create):
(NamedNodeMap):
(WebCore::NamedNodeMap::NamedNodeMap): Instead of asserting m_element in every function, we
now assert only in the constructor.
* dom/Node.cpp:
(WebCore::Node::dumpStatistics): Add a counter for elements with rare data, this allows us
compare more clearly the impact of moving NamedNodeMap there.
(WebCore::Node::isEqualNode): Remove use of mapsEquivalent(). It was dead code, because
both entities and notations were always NULL.
(WebCore::Node::compareDocumentPosition):
* inspector/DOMPatchSupport.h:
(WebCore):
* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):

Source/WebKit/chromium:

* src/WebElement.cpp: Include NamedNodeMap.h since Element.h doesn't include it anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream WebGL related files from platform/graphics
commit-queue@webkit.org [Thu, 8 Mar 2012 16:53:41 +0000 (16:53 +0000)]
[BlackBerry] Upstream WebGL related files from platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=79876

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

* platform/graphics/blackberry/DrawingBufferBlackBerry.cpp: Added.
(WebCore):
(DrawingBufferInternal):
(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::platformLayer):
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp: Added.
(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::isGLES2NPOTStrict):
(WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::setContextLostCallback):
* platform/graphics/blackberry/WebGLLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::WebGLLayerWebKitThread::WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::setNeedsDisplay):
(WebCore::WebGLLayerWebKitThread::updateTextureContentsIfNeeded):
* platform/graphics/blackberry/WebGLLayerWebKitThread.h: Added.
(WebCore):
(WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::create):
(WebCore::WebGLLayerWebKitThread::setWebGLContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] LayerRender should turn off stencil/scissor after drawing layers
commit-queue@webkit.org [Thu, 8 Mar 2012 16:42:55 +0000 (16:42 +0000)]
[BlackBerry] LayerRender should turn off stencil/scissor after drawing layers
https://bugs.webkit.org/show_bug.cgi?id=80598

Patch by Yong Li <yoli@rim.com> on 2012-03-08
Reviewed by Rob Buis.

Turn off stencil/scissor after using them to avoid affecting later GL operation
accidentally.

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt WK2] Remove duplicate code related to dialog handling in QQuickWebView
commit-queue@webkit.org [Thu, 8 Mar 2012 16:05:04 +0000 (16:05 +0000)]
[Qt WK2] Remove duplicate code related to dialog handling in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=80557

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-08
Reviewed by Simon Hausmann.

Move common code related to running QtDialogRunner into a separate function

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::handleAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebViewPrivate::execDialogRunner):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix flaky test by decreasing granularity of cues (cues cover longer time
commit-queue@webkit.org [Thu, 8 Mar 2012 15:50:55 +0000 (15:50 +0000)]
Fix flaky test by decreasing granularity of cues (cues cover longer time
intervals). The flakiness seems to appear because the video is paused
synchronously, while missed events events are dispatched asynchronously.

It can happen that multiple cues are actually missed cues, hence more exit
events are dispatched together, but the video was paused before the actual
dispatch.

https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-08
Reviewed by Eric Carlson.

* media/track/captions-webvtt/simple-captions.vtt:
* media/track/track-cues-pause-on-exit-expected.txt:
* media/track/track-cues-pause-on-exit.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Rebaseline after r110072.
ossy@webkit.org [Thu, 8 Mar 2012 15:28:28 +0000 (15:28 +0000)]
[Qt] Rebaseline after r110072.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-08
Reviewed by Csaba Osztrogonác.

* platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/qt/fast/clip/008-expected.png:
* platform/qt/fast/clip/008-expected.txt:
* platform/qt/fast/clip/011-expected.png:
* platform/qt/fast/clip/011-expected.txt:
* platform/qt/fast/clip/012-expected.png:
* platform/qt/fast/clip/012-expected.txt:
* platform/qt/fast/forms/input-text-double-click-expected.txt:
* platform/qt/fast/forms/textfield-overflow-expected.txt:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Windows build fix.
hausmann@webkit.org [Thu, 8 Mar 2012 15:08:29 +0000 (15:08 +0000)]
[Qt] Windows build fix.

Reviewed by Tor Arne Vestbø.

* DerivedSources.pri: Replace commandline that is too long for Windows with
separate lines to be executed in the Makefile for the IDL preprocessing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 8 Mar 2012 14:09:47 +0000 (14:09 +0000)]
[chromium] Unreviewed gardening.

Mark compositing/reflections/nested-reflection-opacity.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: The function had to return a hash but it returned just address.
loislo@chromium.org [Thu, 8 Mar 2012 14:06:09 +0000 (14:06 +0000)]
Web Inspector: The function had to return a hash but it returned just address.
https://bugs.webkit.org/show_bug.cgi?id=80591

Reviewed by Yury Semikhatsky.

* bindings/v8/RetainedDOMInfo.cpp:
(WebCore::RetainedDOMInfo::GetHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed single line fix. The function had to return a hash but it returned just...
loislo@chromium.org [Thu, 8 Mar 2012 13:24:28 +0000 (13:24 +0000)]
Unreviewed single line fix. The function had to return a hash but it returned just address.

* bindings/v8/V8GCController.cpp:
(WebCore::UnspecifiedGroup::GetHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 8 Mar 2012 12:41:19 +0000 (12:41 +0000)]
[chromium] Unreviewed gardening.

Mark some tests failing on Leopard after the Lion rebaselines.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<shadow> should be rendered correctly.
shinyak@chromium.org [Thu, 8 Mar 2012 11:25:33 +0000 (11:25 +0000)]
<shadow> should be rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=78596

Reviewed by Hajime Morita.

Source/WebCore:

This patch supports <shadow> element rendering.

When attaching <shadow> element, if it is in the oldest shadow tree, it runs a part of
distribution algorithm. If it is in non-oldest shadow tree, it runs tree a part of
tree composition algorithm to assign a older shadow root. In this patch, InsertionPonit
try to treat the distributed host children and the assigned shadow children similarly.

NodeRenderingContext supports rendering <shadow> element. Since the assigned shadow children
are treated like distributed host children, that change is to consider non-youngest shadow
tree basically also.

Tests: fast/dom/shadow/shadow-element-rendering-multiple.html
       fast/dom/shadow/shadow-element-rendering-single.html

* dom/NodeRenderingContext.cpp:
(WebCore):
(WebCore::NodeRenderingContext::NodeRenderingContext):
  Does not ignore non-youngest shadow tree.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::ShadowRoot::assignedTo):
(WebCore):
(WebCore::ShadowRoot::setAssignedTo):
(WebCore::ShadowRoot::isUsedForRendering):
  Returns true if ShadowRoot is youngest or assigned to some InsertionPoint.
(WebCore::toShadowRoot):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::insertionPointFor):
  Returns InsertionPoint to which node is distributed.
* dom/ShadowTree.h:
(ShadowTree):
* html/shadow/HTMLContentElement.h:
(WebCore::HTMLContentElement::doesSelectFromHostChildren):
(HTMLContentElement):
* html/shadow/HTMLShadowElement.cpp:
(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::select):
(WebCore::HTMLShadowElement::doesSelectFromHostChildren):
(WebCore):
* html/shadow/HTMLShadowElement.h:
(HTMLShadowElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::assignedFrom):
(WebCore):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::clearAssignment):
* html/shadow/InsertionPoint.h:
(InsertionPoint):

LayoutTests:

Contains tests both in case <shadow> appears in the oldest shadow root and
non-olderst shadow tree.

* fast/dom/shadow/shadow-element-rendering-multiple-expected.txt: Added.
* fast/dom/shadow/shadow-element-rendering-multiple.html: Added.
* fast/dom/shadow/shadow-element-rendering-single-expected.txt: Added.
* fast/dom/shadow/shadow-element-rendering-single.html: Added.
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeech JavaScript API: SpeechRecognitionAlternative, Result and ResultList
hans@chromium.org [Thu, 8 Mar 2012 11:22:25 +0000 (11:22 +0000)]
Speech JavaScript API: SpeechRecognitionAlternative, Result and ResultList
https://bugs.webkit.org/show_bug.cgi?id=80424

Reviewed by Adam Barth.

Implement the SpeechRecognitionAlternative,
SpeechRecognitionResult and SpeechRecognitionResultList.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

No new tests because these interfaces don't have constructors.
They will be tested as more of the API gets implemented.

* Modules/speech/SpeechRecognitionAlternative.cpp: Added.
(WebCore):
(WebCore::SpeechRecognitionAlternative::create):
(WebCore::SpeechRecognitionAlternative::SpeechRecognitionAlternative):
* Modules/speech/SpeechRecognitionAlternative.h: Added.
(WebCore):
(SpeechRecognitionAlternative):
(WebCore::SpeechRecognitionAlternative::transcript):
(WebCore::SpeechRecognitionAlternative::confidence):
* Modules/speech/SpeechRecognitionAlternative.idl: Added.
* Modules/speech/SpeechRecognitionResult.cpp: Added.
(WebCore):
(WebCore::SpeechRecognitionResult::create):
(WebCore::SpeechRecognitionResult::item):
(WebCore::SpeechRecognitionResult::SpeechRecognitionResult):
* Modules/speech/SpeechRecognitionResult.h: Added.
(WebCore):
(SpeechRecognitionResult):
(WebCore::SpeechRecognitionResult::length):
(WebCore::SpeechRecognitionResult::final):
* Modules/speech/SpeechRecognitionResult.idl: Added.
* Modules/speech/SpeechRecognitionResultList.cpp: Added.
(WebCore):
(WebCore::SpeechRecognitionResultList::create):
(WebCore::SpeechRecognitionResultList::item):
(WebCore::SpeechRecognitionResultList::SpeechRecognitionResultList):
* Modules/speech/SpeechRecognitionResultList.h: Added.
(WebCore):
(SpeechRecognitionResultList):
(WebCore::SpeechRecognitionResultList::length):
* Modules/speech/SpeechRecognitionResultList.idl: Added.
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG CFA incorrectly handles ValueToInt32
fpizlo@apple.com [Thu, 8 Mar 2012 10:01:32 +0000 (10:01 +0000)]
DFG CFA incorrectly handles ValueToInt32
https://bugs.webkit.org/show_bug.cgi?id=80568

Reviewed by Gavin Barraclough.

Changed it match exactly the decision pattern used in
DFG::SpeculativeJIT::compileValueToInt32

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] [WK2] Webkit fails to link when compiled with force_static_libs_as_shared
ostapenko.viatcheslav@nokia.com [Thu, 8 Mar 2012 09:57:25 +0000 (09:57 +0000)]
[Qt] [WK2] Webkit fails to link when compiled with force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=80524

Reviewed by Simon Hausmann.

Move IdentifierTable methods defintion to WTFThreadData.cpp to fix linking
of WTF library.

* runtime/Identifier.cpp:
* wtf/WTFThreadData.cpp:
(JSC):
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110115.
commit-queue@webkit.org [Thu, 8 Mar 2012 09:51:05 +0000 (09:51 +0000)]
Unreviewed, rolling out r110115.
http://trac.webkit.org/changeset/110115
https://bugs.webkit.org/show_bug.cgi?id=80581

broke test-webkitpy (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-08

* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}
commit-queue@webkit.org [Thu, 8 Mar 2012 09:45:58 +0000 (09:45 +0000)]
[BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79867

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp: Added.
(WebCore):
(WebCore::setLayerBorderColor):
(WebCore::clearBorderColor):
(WebCore::setLayerBackgroundColor):
(WebCore::clearLayerBackgroundColor):
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::~GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setName):
(WebCore::GraphicsLayerBlackBerry::setChildren):
(WebCore::GraphicsLayerBlackBerry::addChild):
(WebCore::GraphicsLayerBlackBerry::addChildAtIndex):
(WebCore::GraphicsLayerBlackBerry::addChildBelow):
(WebCore::GraphicsLayerBlackBerry::addChildAbove):
(WebCore::GraphicsLayerBlackBerry::replaceChild):
(WebCore::GraphicsLayerBlackBerry::removeFromParent):
(WebCore::GraphicsLayerBlackBerry::setPosition):
(WebCore::GraphicsLayerBlackBerry::setAnchorPoint):
(WebCore::GraphicsLayerBlackBerry::setSize):
(WebCore::GraphicsLayerBlackBerry::setTransform):
(WebCore::GraphicsLayerBlackBerry::setChildrenTransform):
(WebCore::GraphicsLayerBlackBerry::setPreserves3D):
(WebCore::GraphicsLayerBlackBerry::setMasksToBounds):
(WebCore::GraphicsLayerBlackBerry::setDrawsContent):
(WebCore::GraphicsLayerBlackBerry::setContentsVisible):
(WebCore::GraphicsLayerBlackBerry::setMaskLayer):
(WebCore::GraphicsLayerBlackBerry::setReplicatedByLayer):
(WebCore::GraphicsLayerBlackBerry::setFixedPosition):
(WebCore::GraphicsLayerBlackBerry::setHasFixedContainer):
(WebCore::GraphicsLayerBlackBerry::setHasFixedAncestorInDOMTree):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setContentsOpaque):
(WebCore::GraphicsLayerBlackBerry::setBackfaceVisibility):
(WebCore::GraphicsLayerBlackBerry::setOpacity):
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
(WebCore::GraphicsLayerBlackBerry::setContentsRect):
(WebCore::removeAnimationByIdAndProperty):
(WebCore::removeAnimationByName):
(WebCore::GraphicsLayerBlackBerry::addAnimation):
(WebCore::GraphicsLayerBlackBerry::pauseAnimation):
(WebCore::GraphicsLayerBlackBerry::removeAnimation):
(WebCore::GraphicsLayerBlackBerry::suspendAnimations):
(WebCore::GraphicsLayerBlackBerry::resumeAnimations):
(WebCore::GraphicsLayerBlackBerry::setContentsToImage):
(WebCore::GraphicsLayerBlackBerry::updateContentsImage):
(WebCore::GraphicsLayerBlackBerry::setContentsToCanvas):
(WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
(WebCore::GraphicsLayerBlackBerry::hostLayerForSublayers):
(WebCore::GraphicsLayerBlackBerry::layerForSuperlayer):
(WebCore::GraphicsLayerBlackBerry::platformLayer):
(WebCore::GraphicsLayerBlackBerry::setDebugBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setDebugBorder):
(WebCore::GraphicsLayerBlackBerry::updateSublayerList):
(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):
(WebCore::GraphicsLayerBlackBerry::updateLayerSize):
(WebCore::GraphicsLayerBlackBerry::updateAnchorPoint):
(WebCore::GraphicsLayerBlackBerry::updateTransform):
(WebCore::GraphicsLayerBlackBerry::updateChildrenTransform):
(WebCore::GraphicsLayerBlackBerry::updateMasksToBounds):
(WebCore::GraphicsLayerBlackBerry::updateContentsOpaque):
(WebCore::GraphicsLayerBlackBerry::updateBackfaceVisibility):
(WebCore::GraphicsLayerBlackBerry::updateLayerPreserves3D):
(WebCore::GraphicsLayerBlackBerry::updateLayerIsDrawable):
(WebCore::GraphicsLayerBlackBerry::updateFixedPosition):
(WebCore::GraphicsLayerBlackBerry::updateHasFixedContainer):
(WebCore::GraphicsLayerBlackBerry::updateHasFixedAncestorInDOMTree):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::updateAnimations):
(WebCore::GraphicsLayerBlackBerry::updateContentsVideo):
(WebCore::GraphicsLayerBlackBerry::updateContentsRect):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
(WebCore::GraphicsLayerBlackBerry::updateOpacityOnLayer):
(WebCore::GraphicsLayerBlackBerry::contentsVisible):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h: Added.
(WebCore):
(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::notifySyncRequired):
(WebCore::GraphicsLayerBlackBerry::notifyAnimationStarted):
(WebCore::GraphicsLayerBlackBerry::primaryLayer):
(WebCore::GraphicsLayerBlackBerry::contentsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Re-organize test files of label element
commit-queue@webkit.org [Thu, 8 Mar 2012 09:31:25 +0000 (09:31 +0000)]
[Forms] Re-organize test files of label element
https://bugs.webkit.org/show_bug.cgi?id=80575

There are 988 files under LayoutTests/fast/forms. It is hard to find
a file from UI. To improve discoverability of file, it is better to
organize files based on element as some test files did.

This patch moves test files of "label" element to fast/forms/label and
adjusts path of JavaScript files.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-08
Reviewed by Kentaro Hara.

* fast/forms/label/labels-add-htmlFor-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-add-htmlFor-label-expected.txt.
* fast/forms/label/labels-add-htmlFor-label.html: Renamed from LayoutTests/fast/forms/labels-add-htmlFor-label.html.
* fast/forms/label/labels-add-parent-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-add-parent-label-expected.txt.
* fast/forms/label/labels-add-parent-label.html: Renamed from LayoutTests/fast/forms/labels-add-parent-label.html.
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-change-htmlFor-attribute-expected.txt.
* fast/forms/label/labels-change-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-change-htmlFor-attribute.html.
* fast/forms/label/labels-custom-property-expected.txt: Renamed from LayoutTests/fast/forms/labels-custom-property-expected.txt.
* fast/forms/label/labels-custom-property.html: Renamed from LayoutTests/fast/forms/labels-custom-property.html.
* fast/forms/label/labels-item-index-expected.txt: Renamed from LayoutTests/fast/forms/labels-item-index-expected.txt.
* fast/forms/label/labels-item-index.html: Renamed from LayoutTests/fast/forms/labels-item-index.html.
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-attribute-expected.txt.
* fast/forms/label/labels-remove-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-attribute.html.
* fast/forms/label/labels-remove-htmlFor-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-label-expected.txt.
* fast/forms/label/labels-remove-htmlFor-label.html: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-label.html.
* fast/forms/label/labels-remove-parent-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-parent-label-expected.txt.
* fast/forms/label/labels-remove-parent-label.html: Renamed from LayoutTests/fast/forms/labels-remove-parent-label.html.
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-set-htmlFor-attribute-expected.txt.
* fast/forms/label/labels-set-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-set-htmlFor-attribute.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG instruction count threshold should be lifted to 10000
fpizlo@apple.com [Thu, 8 Mar 2012 09:06:43 +0000 (09:06 +0000)]
DFG instruction count threshold should be lifted to 10000
https://bugs.webkit.org/show_bug.cgi?id=80579

Reviewed by Gavin Barraclough.

* runtime/Options.cpp:
(JSC::Options::initializeOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncorrect tracking of abstract values of variables forced double
fpizlo@apple.com [Thu, 8 Mar 2012 09:02:48 +0000 (09:02 +0000)]
Incorrect tracking of abstract values of variables forced double
https://bugs.webkit.org/show_bug.cgi?id=80566
<rdar://problem/11001442>

Reviewed by Gavin Barraclough.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::mergeStateAtTail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Added myself to watchlist.
haraken@chromium.org [Thu, 8 Mar 2012 08:35:22 +0000 (08:35 +0000)]
Unreviewed. Added myself to watchlist.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: Remove Node::isContentElement and Node::isShadowElement.
shinyak@chromium.org [Thu, 8 Mar 2012 08:22:06 +0000 (08:22 +0000)]
Refactoring: Remove Node::isContentElement and Node::isShadowElement.
https://bugs.webkit.org/show_bug.cgi?id=80501

Reviewed by Hajime Morita.

Removes Node::isContentElement and Node::isShadowElement. These methods are replaced
by hasTagName. However the tag name of HTMLContentElement was not consistent,
this patch make them consistent.

No new tests. Should be covered by existing tests.

* dom/Node.h:
* html/HTMLElement.h:
(WebCore::HTMLElement::isInsertionPoint):
(HTMLElement):
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
  It uses HTMLNames::divTag as tagname. It should use HTMLNames::webkitShadowTagName.
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* html/shadow/InsertionPoint.h:
(InsertionPoint):
(WebCore::InsertionPoint::isInsertionPoint):
(WebCore::isInsertionPoint):
* testing/Internals.cpp:
(WebCore::Internals::isValidContentSelect):
* testing/Internals.h:
(Internals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoContainerNode::insertedIntoDocument and removedFromDocument use weak iteration patterns
abarth@webkit.org [Thu, 8 Mar 2012 07:34:44 +0000 (07:34 +0000)]
ContainerNode::insertedIntoDocument and removedFromDocument use weak iteration patterns
https://bugs.webkit.org/show_bug.cgi?id=80569

Reviewed by Ryosuke Niwa.

This patch moves ContainerNode::insertedIntoDocument and
removedFromDocument to using a better iteration pattern in which we
collect all the nodes we're planning to iterate into a vector and then
iterate over them.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertedIntoDocument):
(WebCore::ContainerNode::removedFromDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compo...
fischman@chromium.org [Thu, 8 Mar 2012 06:55:36 +0000 (06:55 +0000)]
[Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
https://bugs.webkit.org/show_bug.cgi?id=80565

Reviewed by James Robinson.

This gets triggered by the video HW decode+render path when threaded compositor is enabled
(https://chromiumcodereview.appspot.com/9639005/)

No new tests.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS3 calc: mixed absolute/percentages work for width, height, margin and padding
mikelawther@chromium.org [Thu, 8 Mar 2012 06:48:35 +0000 (06:48 +0000)]
CSS3 calc: mixed absolute/percentages work for width, height, margin and padding
https://bugs.webkit.org/show_bug.cgi?id=79621

Reviewed by Andreas Kling.

Source/WebCore:

ApplyPropertyLength in CSSStyleApplyPropery now handles mixed absolute/percentage
length expressions. All property handlers using this template now work with
mixed expressions.

This patch adds a new expression evaluator in CalculationValue.cpp. This is because
Length.[cpp|h] (in platform) cannot refer to CSSCalculationValue.[cpp|h] (in css)
due to layering restrictions.

Lengths can be copied, and so the expressions are stored in a hashmap, and only their
ids are copied along with Length. The expressions are RefCounted, and will get
cleaned up when the last referring Length is destructed.

* WebCore.exp.in:
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(CSSCalcBinaryOperation):
* css/CSSCalculationValue.h:
(WebCore):
(CSSCalcExpressionNode):
(CSSCalcValue):
(WebCore::CSSCalcValue::toCalcValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
* platform/CalculationValue.cpp:
(WebCore::CalcExpressionBinaryOperation::evaluate):
(WebCore):
(WebCore::CalculationValue::create):
(WebCore::CalculationValue::evaluate):
* platform/CalculationValue.h:
(CalcExpressionNode):
(WebCore::CalcExpressionNode::~CalcExpressionNode):
(WebCore):
(CalculationValue):
(WebCore::CalculationValue::CalculationValue):
(CalcExpressionNumber):
(WebCore::CalcExpressionNumber::CalcExpressionNumber):
(WebCore::CalcExpressionNumber::evaluate):
(CalcExpressionLength):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::evaluate):
(CalcExpressionBinaryOperation):
(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
* platform/Length.cpp:
(WebCore):
(WebCore::Length::~Length):
(CalculationValueHandleMap):
(WebCore::CalculationValueHandleMap::CalculationValueHandleMap):
(WebCore::CalculationValueHandleMap::insert):
(WebCore::CalculationValueHandleMap::remove):
(WebCore::CalculationValueHandleMap::get):
(WebCore::calcHandles):
(WebCore::Length::Length):
(WebCore::Length::calculationValue):
(WebCore::Length::calculatedValue):
(WebCore::Length::calculatedMinValue):
(WebCore::Length::calculatedFloatValue):
(WebCore::Length::incrementCalculatedRef):
(WebCore::Length::decrementCalculatedRef):
(WebCore::Length::nonNanCalculatedValue):
* platform/Length.h:
(Length):
(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::operator*=):
(WebCore::Length::value):
(WebCore::Length::setValue):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::isZero):
(WebCore::Length::isPositive):
(WebCore::Length::isNegative):
(WebCore::Length::isPercent):
(WebCore::Length::isSpecified):
(WebCore::Length::isCalculated):
(WebCore::Length::initFromLength):
(WebCore::Length::calculationHandle):

LayoutTests:

* css3/calc/margin-expected.txt:
* css3/calc/padding-expected.txt:
* css3/calc/simple-calcs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix the MIPS/SH4 build after r109834
commit-queue@webkit.org [Thu, 8 Mar 2012 06:15:01 +0000 (06:15 +0000)]
[Qt] Fix the MIPS/SH4 build after r109834
https://bugs.webkit.org/show_bug.cgi?id=80492

Patch by Chao-yng Fu <fu@mips.com> on 2012-03-07
Reviewed by Oliver Hunt.

Implement three-argument branch(Add,Sub)32.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchSub32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDo not refer to resutlsButtonElement and cancelButtonElement to compute paddings...
tkent@chromium.org [Thu, 8 Mar 2012 05:31:25 +0000 (05:31 +0000)]
Do not refer to resutlsButtonElement and cancelButtonElement to compute paddings of search popups
https://bugs.webkit.org/show_bug.cgi?id=80564

Reviewed by Hajime Morita.

We'd like to reduce dependency of resultsButtonElement and
cancelButtonElement from RenderTextControlSingleLine.

No behavior change.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
Use the left position of innerBlockElement, instead of the width of resultsButtonElement.
They are equivalent.
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
Use <the container width - right position of innerBlockElement>,
instead of the width of the cancelButtonElement. They are
equivalent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agouse DEFINE_STATIC_LOCAL on Lengths to avoid exit time destructors
mikelawther@chromium.org [Thu, 8 Mar 2012 04:49:11 +0000 (04:49 +0000)]
use DEFINE_STATIC_LOCAL on Lengths to avoid exit time destructors
https://bugs.webkit.org/show_bug.cgi?id=80561

Reviewed by Eric Seidel.

This is in preparation for http://wkb.ug/79621 where a destructor is added to Length.

No new tests as this is not a behaviour change.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. update chromium test expectations.
ukai@chromium.org [Thu, 8 Mar 2012 04:37:30 +0000 (04:37 +0000)]
Unreviewed. update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTurn Runs class into a proper model to implement incremental JSON update
rniwa@webkit.org [Thu, 8 Mar 2012 04:27:19 +0000 (04:27 +0000)]
Turn Runs class into a proper model to implement incremental JSON update
https://bugs.webkit.org/show_bug.cgi?id=80364

Reviewed by Hajime Morita.

Move Runs from json_generators.py to models.py and turn it into a proper Model.

Now most JSON responses are held by Runs objects instead of PersistentCache.
Added some tests around update_or_insert and json_by_ids to test PersistentCache-like
behavior but there should be no user-visible behavioral differences.

* Websites/webkit-perf.appspot.com/controller.py:
(RunsUpdateHandler.post):
(CachedRunsHandler.get):
(RunsChartHandler.post):
* Websites/webkit-perf.appspot.com/json_generators.py:
(ManifestJSONGenerator.value):
* Websites/webkit-perf.appspot.com/json_generators_unittest.py:
(ManifestJSONGeneratorTest.test_value_two_tests):
* Websites/webkit-perf.appspot.com/models.py:
(Test):
(Runs):
(Runs._generate_runs):
(Runs._entry_from_build_and_result):
(Runs._key_name):
(Runs.update_or_insert):
(Runs.json_by_ids):
(Runs.to_json):
(Runs.chart_params):
* Websites/webkit-perf.appspot.com/models_unittest.py:
(RunsTest):
(RunsTest.setUp):
(RunsTest._create_results):
(RunsTest.test_generate_runs):
(RunsTest.test_update_or_insert):
(RunsTest.test_json_by_ids):
(RunsTest.test_to_json_without_results):
(RunsTest.test_to_json_with_results):
(RunsTest._assert_entry):
(RunsTest.test_run_from_build_and_result):
(RunsTest.test_run_from_build_and_result.create_build):
(RunsTest.test_chart_params_with_value):
(RunsTest.test_chart_params_with_value.split_as_int):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. update chromium test expecation.
ukai@chromium.org [Thu, 8 Mar 2012 04:21:56 +0000 (04:21 +0000)]
Unreviewed. update chromium test expecation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoContainerNode::willRemove uses a weak iteration pattern
abarth@webkit.org [Thu, 8 Mar 2012 04:08:41 +0000 (04:08 +0000)]
ContainerNode::willRemove uses a weak iteration pattern
https://bugs.webkit.org/show_bug.cgi?id=80530

Reviewed by Ryosuke Niwa.

This patch moves ContainerNode::willRemove to using a better iteration
pattern in which we collect all the nodes we're planning to iterate
into a vector and then iterate over them.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::willRemove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110127.
commit-queue@webkit.org [Thu, 8 Mar 2012 04:04:40 +0000 (04:04 +0000)]
Unreviewed, rolling out r110127.
http://trac.webkit.org/changeset/110127
https://bugs.webkit.org/show_bug.cgi?id=80562

compile failed on AppleWin (Requested by ukai on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-07

* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
* heap/Heap.h:
(JSC):
(Heap):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::finalize):
* runtime/Executable.h:
(FunctionExecutable):
(JSC::FunctionExecutable::create):
* runtime/JSGlobalData.cpp:
(WTF):
(Recompiler):
(WTF::Recompiler::operator()):
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
haraken@chromium.org [Thu, 8 Mar 2012 04:02:26 +0000 (04:02 +0000)]
[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
Element.dataset and Node.attributes
https://bugs.webkit.org/show_bug.cgi?id=80376

Reviewed by Adam Barth.

This patch improves the performance of HTMLElement.classList, Element.dataset
and Node.attributes by 6.4 times, 7.1 times and 10.9 times, respectively.

Previously, a 'hiddenReferenceName' string was allocated on v8::Handle and
created every time the DOM attribute is accessed, in spite of the fact that
the 'hiddenReferenceName' string is static.

This patch moves the 'hiddenReferenceName' string to v8::Persistent and makes it static.
Also, this patch removes 'if (!elementValue.IsEmpty() && elementValue->IsObject())',
since if 'element' exists, it is guaranteed that 'elementValue' is not empty
and is an Object.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=130283

AppleWebKit/JavaScriptCore:
div.classList : 382ms
div.classList.foo = 123 : 335ms
div.dataset : 403ms
div.dataset.foo = 123 : 5250ms
div.attributes : 183ms

Chromium/V8 (without this patch):
div.classList : 9140ms
div.classList.foo = 123 : 9086ms
div.dataset : 9930ms
div.dataset.foo = 123 : 49698ms
div.attributes : 13489ms

Chromium/V8 (with this patch):
div.classList : 1435ms
div.classList.foo = 123 : 1470ms
div.dataset : 1400ms
div.dataset.foo = 123 : 30396ms
div.attributes : 1242ms

No tests. No change in behavior.

* bindings/v8/custom/V8DOMStringMapCustom.cpp: Modified as described above.
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp: Ditto.
(WebCore::toV8):

* bindings/v8/V8HiddenPropertyName.cpp: Defined a hidden property name string statically
to optimize the macro.
(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):
* bindings/v8/V8HiddenPropertyName.h: Modified to switch two prefixes "WebCore::HiddenProperty::"
and "WebCore::HiddenReference::", depending on whether a given name represents a hidden property
or a hidden reference.
(WebCore):
(V8HiddenPropertyName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix
michaeln@google.com [Thu, 8 Mar 2012 03:33:17 +0000 (03:33 +0000)]
Unreviewed build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd RenderBoxModelObject::marginWidth() and marginHeight()
tkent@chromium.org [Thu, 8 Mar 2012 03:31:25 +0000 (03:31 +0000)]
Add RenderBoxModelObject::marginWidth() and marginHeight()
https://bugs.webkit.org/show_bug.cgi?id=80556

Reviewed by Kentaro Hara.

They make some code shorter.

No behavior change.

* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::marginHeight): Added.
(WebCore::RenderBoxModelObject::marginWidth): Added.
* inspector/DOMNodeHighlighter.cpp: Use marginHeight() and/or marginWidth().
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatWithRect::FloatWithRect): ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkFloatsInCleanLine): ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage): ditto.
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): ditto.
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): ditto.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild): ditto.
(WebCore::RenderFlexibleBox::computeNextFlexLine): ditto.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteRects): ditto.
(WebCore::RenderInline::culledInlineAbsoluteQuads): ditto.
(WebCore::RenderInline::culledInlineBoundingBox): ditto.
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::trackPieceRectWithMargins): ditto.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight): ditto.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::computeControlHeight): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe end atom of the marked block considered to filter invalid cells
commit-queue@webkit.org [Thu, 8 Mar 2012 03:15:00 +0000 (03:15 +0000)]
The end atom of the marked block considered to filter invalid cells
https://bugs.webkit.org/show_bug.cgi?id=79191

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-07
Reviewed by Geoffrey Garen.

Register file could have stale pointers beyond the end atom of marked block.
Those pointers can weasel out of filtering in-middle-of-cell pointer.

* heap/MarkedBlock.h:
(JSC::MarkedBlock::isLiveCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean Windows build fails after r110033
jberlin@webkit.org [Thu, 8 Mar 2012 03:10:08 +0000 (03:10 +0000)]
Clean Windows build fails after r110033
https://bugs.webkit.org/show_bug.cgi?id=80553

Rubber-stamped by Jon Honeycutt and Eric Seidel.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
Place the implementation files next to their header files in the wtf/text subdirectory.
Use echo -F to tell xcopy that these are files (since there is apparently no flag).
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
Update the path to those implementation files.
* JavaScriptCore.vcproj/testRegExp/testRegExp.vcproj:
Ditto.

Source/ThirdParty:

* gtest/msvc/gtest-md.vcproj:
Add the new JavaScriptCore include directory to the include path.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj:
Update the expected location of the copied JSC WTF string implementation files.

Tools:

Add the new JavaScriptCore include directory to some more vsprops files.

* DumpRenderTree/win/ImageDiffCommon.vsprops:
* WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
* WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEliminate redundant Phis in DFG
yuqiang.xian@intel.com [Thu, 8 Mar 2012 03:08:36 +0000 (03:08 +0000)]
Eliminate redundant Phis in DFG
https://bugs.webkit.org/show_bug.cgi?id=80415

Reviewed by Filip Pizlo.

Although this may not have any advantage at current stage, this is towards
minimal SSA to make more high level optimizations (like bug 76770) easier.
We have the choices either to build minimal SSA from scratch or to
keep current simple Phi insertion mechanism and remove the redundancy
in another phase. Currently we choose the latter because the change
could be smaller.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGRedundantPhiEliminationPhase.cpp: Added.
(DFG):
(RedundantPhiEliminationPhase):
(JSC::DFG::RedundantPhiEliminationPhase::RedundantPhiEliminationPhase):
(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::RedundantPhiEliminationPhase::getRedundantReplacement):
(JSC::DFG::RedundantPhiEliminationPhase::replacePhiChild):
(JSC::DFG::RedundantPhiEliminationPhase::fixupPhis):
(JSC::DFG::RedundantPhiEliminationPhase::updateBlockVariableInformation):
(JSC::DFG::performRedundantPhiElimination):
* dfg/DFGRedundantPhiEliminationPhase.h: Added.
(DFG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Don't be so CRASH() happy in the bindings layer.
michaeln@google.com [Thu, 8 Mar 2012 03:07:44 +0000 (03:07 +0000)]
[Chromium] Don't be so CRASH() happy in the bindings layer.
https://bugs.webkit.org/show_bug.cgi?id=75111
- change the v8 bindings generated code to check for the 'worker is terminating'
  condition prior to committing a suicidal CRASH()
- fixup custom v8 bindings accordingly
- simplify bindings/generic/ActiveDOMCallback, there is no need for it to support
  destruction on a different thread

Reviewed by David Levin.

No new tests, existing tests apply.

* bindings/generic/ActiveDOMCallback.cpp: Simplified in general.
(WebCore):
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
(WebCore::ActiveDOMCallback::~ActiveDOMCallback):
(WebCore::ActiveDOMCallback::canInvokeCallback):
(WebCore::ActiveDOMCallback::isScriptControllerTerminating): New method to avoid CRASH()ing in exceptional conditions in v8 bindings.
* bindings/generic/ActiveDOMCallback.h: Derive from ContextDestructionObserver.
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::scheduleExecutionTermination): Use a mutex to provide a memory barrier.
(WebCore::WorkerScriptController::isExecutionTerminating): New supporting method to avoid CRASH()ing in exceptional conditions.
* bindings/js/WorkerScriptController.h:
(WorkerScriptController):
* bindings/scripts/CodeGeneratorV8.pm: Generates v8 bindding code that uses isScriptControllerTerminating to avoid CRASH()ing.
(GenerateCallbackImplementation):
* bindings/scripts/test/V8/V8TestCallback.cpp: Fixup expected outputs of the modified CodeGeneratorV8.pm script.
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController): Initialize a new data member.
(WebCore::WorkerScriptController::scheduleExecutionTermination): Use a mutex to provide a memory barrier.
(WebCore::WorkerScriptController::isExecutionTerminating): New supporting method to avoid CRASH()ing in exceptional conditions.
* bindings/v8/WorkerScriptController.h: Add a pair of new data members, bool + mutex.
(WorkerScriptController):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext): Initilaize data members.
(WebCore::ScriptExecutionContext::stopActiveDOMObjects): Set m_activeDOMObjectsAreStopped.
* dom/ScriptExecutionContext.h: Add m_activeDOMObjectsAreStopped data member.
(WebCore::ScriptExecutionContext::activeDOMObjectsAreStopped): Simple getter.
(ScriptExecutionContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110131 268f45cc-cd09-0410-ab3c-d52691b4dbfc