WebKit-https.git
10 years ago2010-05-28 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Sat, 29 May 2010 03:33:43 +0000 (03:33 +0000)]
2010-05-28  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Dmitry Titov.

        We don't test the async DB success callback in an isolated world.
        https://bugs.webkit.org/show_bug.cgi?id=39849

        This pretty much a copy of transaction-error-callback-isolated-world.html.
        * storage/transaction-success-callback-isolated-world-expected.txt: Added.
        * storage/transaction-success-callback-isolated-world.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Sat, 29 May 2010 03:21:44 +0000 (03:21 +0000)]
2010-05-28  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Prevent chromium composited layers from rendering on top of the scrollbars.
        https://bugs.webkit.org/show_bug.cgi?id=39851

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 29 May 2010 03:06:42 +0000 (03:06 +0000)]
2010-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
        https://bugs.webkit.org/show_bug.cgi?id=39546

        One sublty is that we want to wait for the user to finish editing the
        ChangeLog before moving on to the next step.  That means we want to pass
        -W to open.  However, if the user is using Xcode to edit the ChangeLog,
        we don't want them to have to exit the Xcode application.  For this reason,
        we create a new instance of the application with -n.

        Overall, xed seems like a better solution, so we recommend that too.

        * Scripts/webkitpy/common/system/user.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/editchangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Chao-ying Fu <fu@mips.com>
eric@webkit.org [Sat, 29 May 2010 02:54:21 +0000 (02:54 +0000)]
2010-05-28  Chao-ying Fu  <fu@mips.com>

        Reviewed by Eric Seidel.

        Fix MIPS JIT DoubleGreaterThanOrEqual Operands
        https://bugs.webkit.org/show_bug.cgi?id=39504

        Swapped two operands of left and right for DoubleGreaterThanOrEqual.
        This patch fixed two layout tests as follows.
        fast/js/comparison-operators-greater.html
        fast/js/comparison-operators-less.html

        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::branchDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a using declaration for AdoptWK to match the one just added for WKRetainPtr.
sullivan@apple.com [Sat, 29 May 2010 00:40:24 +0000 (00:40 +0000)]
Add a using declaration for AdoptWK to match the one just added for WKRetainPtr.

Rubber-stamped by Dan Bernstein.

* UIProcess/API/cpp/WKRetainPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 29 May 2010 00:14:11 +0000 (00:14 +0000)]
2010-05-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
        threads are wedged. Also, the script will print the results of the
        tests completed when the interrupt occurs.

        https://bugs.webkit.org/show_bug.cgi?id=33238

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIgnore more Python messiness.
darin@apple.com [Fri, 28 May 2010 23:52:15 +0000 (23:52 +0000)]
Ignore more Python messiness.

* Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
* Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
* Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
* Scripts/webkitpy/test: Added property svn:ignore.
* Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a using declaration for WKRetainPtr matching what we do for our
weinig@apple.com [Fri, 28 May 2010 23:02:00 +0000 (23:02 +0000)]
Add a using declaration for WKRetainPtr matching what we do for our
other smart pointers and fix the destructor.

Reviewed by Anders Carlsson.

* UIProcess/API/cpp/WKRetainPtr.h:
(WebKit::WKRetainPtr::~WKRetainPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove jit compilation from linking thunks into cti_vm_lazyLink methods.
barraclough@apple.com [Fri, 28 May 2010 22:51:27 +0000 (22:51 +0000)]
Move jit compilation from linking thunks into cti_vm_lazyLink methods.

Reviewed by Geoff Garen.

* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Aaron Boodman <aa@chromium.org>
aa@chromium.org [Fri, 28 May 2010 22:42:57 +0000 (22:42 +0000)]
2010-05-28  Aaron Boodman  <aa@chromium.org>

        Reviewed by Darin Fisher.

        Added isXHTMLDocument() to WebCore::Document.

        https://bugs.webkit.org/show_bug.cgi?id=39887

        * dom/Document.h: Add isXHTMLDocument().
        (WebCore::Document::isXHTMLDocument): Ditto.
2010-05-28  Aaron Boodman  <aa@chromium.org>

        Reviewed by Darin Fisher.

        Add isXHTMLDocument() to WebDocument.

        https://bugs.webkit.org/show_bug.cgi?id=39887

        * public/WebDocument.h: Add isXHTMLDocument().
        * src/WebDocument.cpp: ditto.
        (WebKit::WebDocument::isXHTMLDocument): dittorama.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 39898 - Move arity check into callee.
barraclough@apple.com [Fri, 28 May 2010 21:18:35 +0000 (21:18 +0000)]
Bug 39898 - Move arity check into callee.

Reviewed by Sam Weinig.

We can reduce the size of the virtual call trampolines by moving the arity check
into the callee functions.  As a following step we will be able to remove the
check for native function / codeblocks by performing translation in a lazy stub.

* interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::setReturnPC):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::linkCall):
(JSC::JIT::linkConstruct):
* jit/JIT.h:
(JSC::JIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::generateJITCodeForCall):
(JSC::FunctionExecutable::generateJITCodeForConstruct):
(JSC::FunctionExecutable::reparseExceptionInfo):
* runtime/Executable.h:
(JSC::NativeExecutable::NativeExecutable):
(JSC::FunctionExecutable::generatedJITCodeForCallWithArityCheck):
(JSC::FunctionExecutable::generatedJITCodeForConstructWithArityCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39857
pkasting@chromium.org [Fri, 28 May 2010 21:15:19 +0000 (21:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39857
Make GIFs loop the correct number of times.  Previously, everyone looped
one time too few for non-infinitely-looping GIFs.

Reviewed by Darin Adler.

Modified a Qt manual test to be correct and moved it to the general
manual test directory.

* manual-tests/animated-gif-looping.html: Copied from WebCore/manual-tests/qt/qt-gif-test.html.
* manual-tests/qt/qt-10loop-anim.gif: Removed.
* manual-tests/qt/qt-anim.gif: Removed.
* manual-tests/qt/qt-gif-test.html: Removed.
* manual-tests/qt/qt-noanim.gif: Removed.
* manual-tests/resources/animated-10x.gif: Copied from WebCore/manual-tests/qt/qt-10loop-anim.gif and modified.
* manual-tests/resources/animated-infinite.gif: Copied from WebCore/manual-tests/qt/qt-anim.gif.
* manual-tests/resources/non-animated.gif: Copied from WebCore/manual-tests/qt/qt-noanim.gif.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::internalAdvanceAnimation): For a loop count of n, show a total of n + 1 animation cycles.
* platform/graphics/ImageSource.h:
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::repetitionCount):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::repetitionCount): Remove translation code now that WebCore matches Qt's internal handling of the loop count.  Qt itself may still have a bug here.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::repetitionCount):
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read): Translate loop count 0 to "loop infinitely" (by restoring one piece of the Mozilla code we'd removed).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoopenFile(...) in FIleSystemPOSIX does not call fileSystemRepresentation
benm@google.com [Fri, 28 May 2010 20:07:39 +0000 (20:07 +0000)]
openFile(...) in FIleSystemPOSIX does not call fileSystemRepresentation
https://bugs.webkit.org/show_bug.cgi?id=39882

Reviewed by Darin Adler.

No new tests. Existing tests in fast/files should suffice.

* platform/posix/FileSystemPOSIX.cpp:
(WebCore::openFile): pass the path parameter through fileSystemRepresentation before using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding myself as a reviewer.
cfleizach@apple.com [Fri, 28 May 2010 19:17:03 +0000 (19:17 +0000)]
Adding myself as a reviewer.

Reviewed by Beth Dakin.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. No review.
cfleizach@apple.com [Fri, 28 May 2010 18:45:43 +0000 (18:45 +0000)]
Build fix. No review.

AX: need to catch NSAccessibilityExceptions in DRT
https://bugs.webkit.org/show_bug.cgi?id=39881

It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::selectedTextRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Chang Shu <Chang.Shu@nokia.com>
chang.shu@nokia.com [Fri, 28 May 2010 18:43:49 +0000 (18:43 +0000)]
2010-05-28  Chang Shu  <Chang.Shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable Philip's canvas tests on Qt and skip
        the failed ones.

        https://bugs.webkit.org/show_bug.cgi?id=20553

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 May 2010 18:21:03 +0000 (18:21 +0000)]
2010-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Named entities in attributes aren't parsed correctly by HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=39873

        I misplaced this if statement when writing this code originally.  Now
        that we have test coverage for this paragraph in the spec, we can see
        and fix the bug.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::consumeEntity):
2010-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Named entities in attributes aren't parsed correctly by HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=39873

        Add a test suite for parsing entities in attributes and update expected results.

        * html5lib/resources/entities02.dat: Added.
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 28 May 2010 18:17:06 +0000 (18:17 +0000)]
2010-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle edge cases in HTML5 entity parsing
        https://bugs.webkit.org/show_bug.cgi?id=39823

        The HTML5 specification tells us to handle HTML entities in a somewhat
        complicated way.  This patch attempts to correctly handle numeric
        entities.  Some of this code is duplicated from HTMLTokenizer.

        * html/HTML5Lexer.cpp:
        (WebCore::HTMLNames::):
        (WebCore::HTMLNames::adjustEntity):
        (WebCore::HTMLNames::legalEntityFor):
        (WebCore::HTML5Lexer::consumeEntity):
        (WebCore::HTML5Lexer::processEntity):
        (WebCore::HTML5Lexer::nextToken):
        (WebCore::HTML5Lexer::emitCodePoint):
        * html/HTML5Lexer.h:
2010-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle edge cases in HTML5 entity parsing
        https://bugs.webkit.org/show_bug.cgi?id=39823

        Tests a bunch of the edge cases of entity handling in the HTML5
        specification.

        * html5lib/resources/entities01.dat:
        * html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: stop prepping value conversion in accessibilityAttributeValueForParameter
cfleizach@apple.com [Fri, 28 May 2010 18:11:00 +0000 (18:11 +0000)]
AX: stop prepping value conversion in accessibilityAttributeValueForParameter
https://bugs.webkit.org/show_bug.cgi?id=39880

Reviewed by Beth Dakin.

Cleaning up a FIXME so that all values are not converted before they're needed in accessibilityAttributeValue:forParameter:

* accessibility/mac/AccessibilityObjectWrapper.mm:
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRIM Bug #293 and https://bugs.webkit.org/show_bug.cgi?id=39859
treat@webkit.org [Fri, 28 May 2010 17:55:51 +0000 (17:55 +0000)]
RIM Bug #293 and https://bugs.webkit.org/show_bug.cgi?id=39859

Patch by Adam Treat <atreat@rim.com> on 2010-05-28
Reviewed by Daniel Bates.

Layout is not dependent upon ScrollView::frameRect when useFixedLayout
is true.  No reason to set the needs layout flag in this case.

* platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: need to catch NSAccessibilityExceptions in DRT
cfleizach@apple.com [Fri, 28 May 2010 17:44:57 +0000 (17:44 +0000)]
AX: need to catch NSAccessibilityExceptions in DRT
https://bugs.webkit.org/show_bug.cgi?id=39881

Reviewed by Darin Adler.

WebKitTools:

Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but
because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.

So DRT should wrap exception handlers around its AX related calls.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(attributesOfElement):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isActionSupported):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::press):
(AccessibilityUIElement::url):
(AccessibilityUIElement::hasPopup):

LayoutTests:

* platform/mac/accessibility/unsupported-attribute-does-not-crash-expected.txt: Added.
* platform/mac/accessibility/unsupported-attribute-does-not-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 28 May 2010 17:31:58 +0000 (17:31 +0000)]
2010-05-28  Mikhail Naganov  <mnaganov@chromium.org>

        Unreviewed. Revert 60353 -- immature.

        https://bugs.webkit.org/show_bug.cgi?id=39646

        * bindings/js/JSConsoleCustom.cpp:
        * bindings/v8/custom/V8ConsoleCustom.cpp:
        * page/Console.cpp:
        * page/Console.h:
        * page/Console.idl:
        * fast/dom/Window/window-properties-expected.txt:
        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Fri, 28 May 2010 16:17:04 +0000 (16:17 +0000)]
2010-05-28  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Allow client to override default database quota. We increase the
        default database quota to 1MB (it was incorrectly set to 1KB, which is
        too low) and add methods to allow client to iteratively database quota
        when it becomes greater than the allowed value.
        https://bugs.webkit.org/show_bug.cgi?id=39867

        * efl/WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::exceededDatabaseQuota): reimplement method
        to allow client to increase database quota iteratively.
        * efl/ewk/ewk_private.h:
        * efl/ewk/ewk_settings.cpp:
        * efl/ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Fri, 28 May 2010 16:03:28 +0000 (16:03 +0000)]
2010-05-28  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add default path to web database and methods to set it.
        If a default path is not set, it will default to "/", in which a
        normal user usually does not have write permission.

        * efl/EWebLauncher/main.c: overwrite default directory with another
        one.
        (main):
        * efl/ewk/ewk_main.cpp:
        (ewk_init): add default path
        * efl/ewk/ewk_settings.cpp: add methods to set and get database path
        (ewk_settings_web_database_path_set):
        (ewk_settings_web_database_path_get):
        * efl/ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Fri, 28 May 2010 15:40:00 +0000 (15:40 +0000)]
2010-05-28  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Fix wrongly set clipper. Now the scrollbars from main
        frame are shown even on a zoom level lower than 1.0.

        * efl/ewk/ewk_view_single.c:
        (_ewk_view_single_smart_add):
        (_ewk_view_single_smart_backing_store_add):
        (ewk_view_single_smart_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 28 May 2010 15:38:58 +0000 (15:38 +0000)]
2010-05-27  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Make more HTML DOM members private, especially constructors, batch 2
        https://bugs.webkit.org/show_bug.cgi?id=39706

        Refactoring so no new tests.

        Worked my way up from the bottom of HTMLTagNames.in.

        * html/HTMLTagNames.in: Removed createWithNew from keygen, listing,
        map, marquee, menu, meta, ol, optgroup, option, p, param, pre,
        script, select, source, style, table, tbody, td, textarea, tfoot,
        th, thead, title, tr, ul, video, xmp, and noscript.

        * editing/htmlediting.cpp:
        (WebCore::createOrderedListElement): Use create function instead of new.
        (WebCore::createUnorderedListElement): Ditto.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Ditto.
        (WebCore::HTMLParser::mapCreateErrorCheck): Ditto.
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createContainingTable): Ditto.
        (WebCore::HTMLViewSourceDocument::addLine): Ditto.

        * html/HTMLKeygenElement.cpp:
        (WebCore::HTMLKeygenElement::HTMLKeygenElement): Use create function
        instead of new.
        (WebCore::HTMLKeygenElement::create): Added.
        * html/HTMLKeygenElement.h: Made constructor and virtual function
        overrides private, added create function.

        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::HTMLMapElement):
        (WebCore::HTMLMapElement::create):
        * html/HTMLMapElement.h:
        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
        (WebCore::HTMLMarqueeElement::create):
        * html/HTMLMarqueeElement.h:
        * html/HTMLMenuElement.cpp:
        (WebCore::HTMLMenuElement::HTMLMenuElement):
        (WebCore::HTMLMenuElement::create):
        * html/HTMLMenuElement.h:
        * html/HTMLMetaElement.cpp:
        (WebCore::HTMLMetaElement::HTMLMetaElement):
        (WebCore::HTMLMetaElement::create):
        * html/HTMLMetaElement.h:
        * html/HTMLNoScriptElement.cpp:
        (WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
        (WebCore::HTMLNoScriptElement::create):
        (WebCore::HTMLNoScriptElement::childShouldCreateRenderer):
        * html/HTMLNoScriptElement.h:
        * html/HTMLOListElement.cpp:
        (WebCore::HTMLOListElement::HTMLOListElement):
        (WebCore::HTMLOListElement::create):
        * html/HTMLOListElement.h:
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
        (WebCore::HTMLOptGroupElement::create):
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::HTMLOptionElement):
        (WebCore::HTMLOptionElement::create):
        * html/HTMLOptionElement.h:
        * html/HTMLParagraphElement.cpp:
        (WebCore::HTMLParagraphElement::HTMLParagraphElement):
        (WebCore::HTMLParagraphElement::create):
        * html/HTMLParagraphElement.h:
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::HTMLParamElement):
        (WebCore::HTMLParamElement::create):
        * html/HTMLParamElement.h:
        * html/HTMLPreElement.cpp:
        (WebCore::HTMLPreElement::HTMLPreElement):
        (WebCore::HTMLPreElement::create):
        * html/HTMLPreElement.h:
        * html/HTMLQuoteElement.cpp:
        (WebCore::HTMLQuoteElement::HTMLQuoteElement):
        (WebCore::HTMLQuoteElement::create):
        * html/HTMLQuoteElement.h:
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::HTMLScriptElement):
        (WebCore::HTMLScriptElement::create):
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::create):
        * html/HTMLSelectElement.h:
        * html/HTMLSourceElement.cpp:
        (WebCore::HTMLSourceElement::HTMLSourceElement):
        (WebCore::HTMLSourceElement::create):
        * html/HTMLSourceElement.h:
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::HTMLStyleElement):
        (WebCore::HTMLStyleElement::create):
        * html/HTMLStyleElement.h:
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::HTMLTableRowElement):
        (WebCore::HTMLTableRowElement::create):
        (WebCore::HTMLTableRowElement::insertCell):
        * html/HTMLTableRowElement.h:
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::HTMLTableSectionElement):
        (WebCore::HTMLTableSectionElement::create):
        (WebCore::HTMLTableSectionElement::insertRow):
        * html/HTMLTableSectionElement.h:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::create):
        * html/HTMLTextAreaElement.h:
        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::HTMLTitleElement):
        (WebCore::HTMLTitleElement::create):
        * html/HTMLTitleElement.h:
        * html/HTMLUListElement.cpp:
        (WebCore::HTMLUListElement::HTMLUListElement):
        (WebCore::HTMLUListElement::create):
        * html/HTMLUListElement.h:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::HTMLVideoElement):
        (WebCore::HTMLVideoElement::create):
        * html/HTMLVideoElement.h:
        Made constructors and virtual function overrides private, added
        create function.

        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::HTMLTableCellElement): Updated
        names of data members. Renamed _row to m_row, _col to m_col,
        rSpan to m_rowSpan, cSpan to m_colSpan, and removed unused
        rowHeight and m_solid.
        (WebCore::HTMLTableCellElement::create): Added.
        (WebCore::HTMLTableCellElement::parseMappedAttribute): Updated names.
        * html/HTMLTableCellElement.h: Ditto.

        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::create): Added.
        (WebCore::HTMLTableElement::createTHead): Used create instead of new.
        (WebCore::HTMLTableElement::createTFoot): Ditto.
        (WebCore::HTMLTableElement::insertRow): Ditto.
        * html/HTMLTableElement.h:

        * html/HTMLTablePartElement.h: Made members protected instead of
        public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Fri, 28 May 2010 15:23:25 +0000 (15:23 +0000)]
2010-05-28  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] REGRESSION(r59837): Incorrect clipping of TransparencyLayers
        https://bugs.webkit.org/show_bug.cgi?id=39784

        Move coordinate transformation from TransparencyLayer to clipToImageBuffer()

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::TransparencyLayer::TransparencyLayer):
        (WebCore::GraphicsContext::clipToImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Fri, 28 May 2010 15:11:35 +0000 (15:11 +0000)]
2010-05-28  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EF] Implement methods for supporting PopupMenu
        https://bugs.webkit.org/show_bug.cgi?id=39629

        * platform/PopupMenu.h: add needed attribute
        * platform/efl/PopupMenuEfl.cpp: implement methods to show/hide popup
        menu
        (WebCore::PopupMenu::PopupMenu): initialize new attribute
        (WebCore::PopupMenu::show): ditto.
        (WebCore::PopupMenu::hide): ditto.
2010-05-28  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add support for Popup menus
        https://bugs.webkit.org/show_bug.cgi?id=39629

        * efl/WebCoreSupport/ChromeClientEfl.cpp: implement methods to create
        and destroy popup menu.
        (WebCore::ChromeClientEfl::createSelectPopup): ditto.
        (WebCore::ChromeClientEfl::destroySelectPopup): ditto.
        * efl/WebCoreSupport/ChromeClientEfl.h: ditto.
        * efl/ewk/ewk_private.h: add function to call browser when a popup is
        created/deleted

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Fri, 28 May 2010 14:56:15 +0000 (14:56 +0000)]
2010-05-28  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Reorder class initializers to remove compiler warnings.
        https://bugs.webkit.org/show_bug.cgi?id=39596

        * platform/efl/PlatformKeyboardEventEfl.cpp: ditto.
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): ditto.
        * platform/efl/PlatformMouseEventEfl.cpp: ditto.
        (WebCore::PlatformMouseEvent::PlatformMouseEvent): ditto.
        * platform/efl/PlatformWheelEventEfl.cpp: ditto
        (WebCore::PlatformWheelEvent::PlatformWheelEvent): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 28 May 2010 14:30:41 +0000 (14:30 +0000)]
2010-05-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Add IndexedDB's IDBIndex
        https://bugs.webkit.org/show_bug.cgi?id=39850

        Flesh out IDBIndex as much as possible until Andrei finishes
        his patch to get around passing Frame*'s all around.  I also
        cleaned up a bunch of existing files as I noticed style
        violations (while basing my new files off of the old).

        Not hooked up enough to test.  Will add tests soon.

        * Android.derived.jscbindings.mk
        * Android.derived.v8bindings.mk
        * Android.mk
        * CMakeLists.txt
        * DerivedSources.cpp
        * DerivedSources.make
        * GNUmakefile.am
        * WebCore.pri
        * WebCore.pro
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj
        * WebCore.xcodeproj/project.pbxproj
        * bindings/js/JSIDBAnyCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8IDBAnyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBAny.cpp:
        (WebCore::IDBAny::idbIndexRequest):
        (WebCore::IDBAny::set):
        * storage/IDBAny.h:
        (WebCore::IDBAny::):
        * storage/IDBCallbacks.h:
        * storage/IDBDatabase.h:
        * storage/IDBDatabaseError.h:
        (WebCore::IDBDatabaseError::):
        * storage/IDBDatabaseError.idl:
        * storage/IDBDatabaseException.h:
        * storage/IDBDatabaseException.idl:
        * storage/IDBDatabaseImpl.cpp:
        * storage/IDBDatabaseImpl.h:
        * storage/IDBDatabaseRequest.cpp:
        * storage/IDBDatabaseRequest.h:
        * storage/IDBDatabaseRequest.idl:
        * storage/IDBIndex.h: Added.
        (WebCore::IDBIndex::~IDBIndex):
        * storage/IDBIndexImpl.cpp: Added.
        (WebCore::IDBIndexImpl::IDBIndexImpl):
        (WebCore::IDBIndexImpl::~IDBIndexImpl):
        * storage/IDBIndexImpl.h: Added.
        (WebCore::IDBIndexImpl::create):
        (WebCore::IDBIndexImpl::name):
        (WebCore::IDBIndexImpl::keyPath):
        (WebCore::IDBIndexImpl::unique):
        * storage/IDBIndexRequest.cpp: Added.
        (WebCore::IDBIndexRequest::IDBIndexRequest):
        (WebCore::IDBIndexRequest::~IDBIndexRequest):
        * storage/IDBIndexRequest.h: Added.
        (WebCore::IDBIndexRequest::create):
        (WebCore::IDBIndexRequest::name):
        (WebCore::IDBIndexRequest::keyPath):
        (WebCore::IDBIndexRequest::unique):
        * storage/IDBIndexRequest.idl: Added.
        * storage/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::IDBObjectStore):
        (WebCore::IDBObjectStore::~IDBObjectStore):
        (WebCore::IDBObjectStore::indexNames):
        (WebCore::IDBObjectStore::createIndex):
        (WebCore::IDBObjectStore::index):
        (WebCore::IDBObjectStore::removeIndex):
        * storage/IDBObjectStore.h:
        * storage/IDBObjectStoreRequest.cpp:
        (WebCore::IDBObjectStoreRequest::IDBObjectStoreRequest):
        (WebCore::IDBObjectStoreRequest::name):
        (WebCore::IDBObjectStoreRequest::keyPath):
        (WebCore::IDBObjectStoreRequest::indexNames):
        (WebCore::IDBObjectStoreRequest::createIndex):
        (WebCore::IDBObjectStoreRequest::index):
        (WebCore::IDBObjectStoreRequest::removeIndex):
        * storage/IDBObjectStoreRequest.h:
        * storage/IDBObjectStoreRequest.idl:
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::onSuccess):
        * storage/IDBRequest.h:
        * storage/IndexedDatabaseRequest.idl:
2010-05-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Add IndexedDB's IDBIndex
        https://bugs.webkit.org/show_bug.cgi?id=39850

        Add WebKit layer for IDBIndex.

        * WebKit.gyp:
        * public/WebCommon.h:
        * public/WebIDBCallbacks.h:
        (WebKit::WebIDBCallbacks::onError):
        (WebKit::WebIDBCallbacks::onSuccess):
        * public/WebIDBDatabase.h:
        * public/WebIDBIndex.h: Added.
        (WebKit::WebIDBIndex::~WebIDBIndex):
        (WebKit::WebIDBIndex::name):
        (WebKit::WebIDBIndex::keyPath):
        (WebKit::WebIDBIndex::unique):
        * src/IDBCallbacksProxy.cpp:
        (WebCore::IDBCallbacksProxy::onSuccess):
        * src/IDBCallbacksProxy.h:
        * src/IDBDatabaseProxy.cpp:
        * src/IDBDatabaseProxy.h:
        * src/IDBIndexProxy.cpp: Added.
        (WebCore::IDBIndexProxy::create):
        (WebCore::IDBIndexProxy::IDBIndexProxy):
        (WebCore::IDBIndexProxy::~IDBIndexProxy):
        (WebCore::IDBIndexProxy::name):
        (WebCore::IDBIndexProxy::keyPath):
        (WebCore::IDBIndexProxy::unique):
        * src/IDBIndexProxy.h: Added.
        * src/WebIDBCallbacksImpl.cpp:
        (WebCore::WebIDBCallbacksImpl::onSuccess):
        * src/WebIDBCallbacksImpl.h:
        * src/WebIDBDatabaseImpl.cpp:
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBIndexImpl.cpp: Added.
        (WebKit::WebIDBIndexImpl::WebIDBIndexImpl):
        (WebKit::WebIDBIndexImpl::~WebIDBIndexImpl):
        (WebKit::WebIDBIndexImpl::name):
        (WebKit::WebIDBIndexImpl::keyPath):
        (WebKit::WebIDBIndexImpl::unique):
        * src/WebIDBIndexImpl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 28 May 2010 14:10:03 +0000 (14:10 +0000)]
2010-05-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: check that ClientMessageLoopAdapter is not 0 before
        accessing its fileds from inspectedViewClosed method. It may be 0
        if inspector frontend has not been open.
        https://bugs.webkit.org/show_bug.cgi?id=39876

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Shu Chang <chang.shu@nokia.com>
chang.shu@nokia.com [Fri, 28 May 2010 14:08:09 +0000 (14:08 +0000)]
2010-05-28  Shu Chang  <chang.shu@nokia.com>

        Unreviewed.

        Remove two junk files not supposed to be in.

        * canvas/philip/tests/.reportgen.html.swp: Removed.
        * canvas/philip/tests/.reportgen.js.swp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 28 May 2010 14:07:31 +0000 (14:07 +0000)]
2010-05-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: hide node highlight when inspected page closes.
        https://bugs.webkit.org/show_bug.cgi?id=39872

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 28 May 2010 14:01:21 +0000 (14:01 +0000)]
2010-05-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add Console API for retrieving memory stats

        Add 'console.memory' property which returns an object. Currently
        it has two fields: totalHeapSize and usedHeapSize. Later, it can be
        extended for reporting total browser's memory consumption.

        https://bugs.webkit.org/show_bug.cgi?id=39840

        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::memory):
        * bindings/v8/custom/V8ConsoleCustom.cpp:
        (WebCore::V8Console::memoryAccessorGetter):
        * page/Console.cpp:
        (WebCore::Console::memory):
        * page/Console.h:
        * page/Console.idl:
        * fast/dom/Window/window-properties-expected.txt:
        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a missing #if ENABLE(), some null checking.
antti.j.koivisto@nokia.com [Fri, 28 May 2010 13:57:17 +0000 (13:57 +0000)]
Add a missing #if ENABLE(), some null checking.

Reviewed by Kenneth Rohde Christiansen.

* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 28 May 2010 13:37:10 +0000 (13:37 +0000)]
2010-05-28  Xan Lopez  <xlopez@igalia.com>

        Add new file to the build system.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39874
antti.j.koivisto@nokia.com [Fri, 28 May 2010 13:28:07 +0000 (13:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39874
[Qt] Make tiled backing store more configurable

Reviewed by Kenneth Rohde Christiansen.

Make tile size, tile creation delay and tiling area dynamically configurable.

WebCore:

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setTileSize):
(WebCore::TiledBackingStore::setTileCreationDelay):
(WebCore::TiledBackingStore::setKeepAndCoverAreaMultipliers):
(WebCore::TiledBackingStore::createTiles):
* platform/graphics/TiledBackingStore.h:
(WebCore::TiledBackingStore::tileSize):
(WebCore::TiledBackingStore::tileCreationDelay):
(WebCore::TiledBackingStore::getKeepAndCoverAreaMultipliers):

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r60348.
yael.aharon@nokia.com [Fri, 28 May 2010 13:12:45 +0000 (13:12 +0000)]
Unreviewed build fix after r60348.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setNotificationsReceiver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Fri, 28 May 2010 12:59:52 +0000 (12:59 +0000)]
2010-05-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Pass all web notification layout tests
        https://bugs.webkit.org/show_bug.cgi?id=39146

        * platform/qt/Skipped:
2010-05-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Pass all web notification layout tests
        https://bugs.webkit.org/show_bug.cgi?id=39146

        Add support for multiple simultaneous notifications.
        Add a private callback mechanism to the client for security checks.
        Notifications are disabled if the client does not set the callbacks.
        Support replaceId and cancel.
        Send close and display events when needed.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setNotificationsReceiver):
        (DumpRenderTreeSupportQt::allowNotificationForOrigin):
        (DumpRenderTreeSupportQt::setCheckPermissionFunction):
        (DumpRenderTreeSupportQt::setRequestPermissionFunction):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (NotificationIconWrapper::NotificationIconWrapper):
        (NotificationIconWrapper::~NotificationIconWrapper):
        (NotificationPresenterClientQt::NotificationPresenterClientQt):
        (NotificationPresenterClientQt::show):
        (NotificationPresenterClientQt::cancel):
        (NotificationPresenterClientQt::notificationObjectDestroyed):
        (NotificationPresenterClientQt::requestPermission):
        (NotificationPresenterClientQt::checkPermission):
        (NotificationPresenterClientQt::allowNotificationForOrigin):
        (NotificationPresenterClientQt::clearNotificationsList):
        (NotificationPresenterClientQt::sendEvent):
        * WebCoreSupport/NotificationPresenterClientQt.h:
        (WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt):
        (WebCore::NotificationPresenterClientQt::setReceiver):
2010-05-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Pass all web notification layout tests
        https://bugs.webkit.org/show_bug.cgi?id=39146

        Mimic Chromium's test_shell security model in Qt's DRT.
        It makes a list of origins which were granted permission to display
        notifications, and only those origins can display notifications.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::checkPermissionCallback):
        (WebCore::requestPermissionCallback):
        (WebCore::WebPage::WebPage):
        (WebCore::DumpRenderTree::checkPermission):
        (WebCore::DumpRenderTree::requestPermission):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::grantDesktopNotificationPermission):
        (LayoutTestController::checkDesktopNotificationPermission):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 28 May 2010 10:11:13 +0000 (10:11 +0000)]
2010-05-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        document.write does not work correctly in the HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=39828

        Add two tests for document.write behavior and update
        our expected results to remove two parse errors now that
        document.write is functioning correctly.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
2010-05-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        document.write does not work correctly in the HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=39828

        Added a new HTML5ScriptRunnerHost interface which
        HTML5Tokenizer implements.  This allows HTML5ScriptController
        to delegate the actual ScriptController::executeScript back to
        HTML5Tokenizer.  HTML5Tokenizer saves off the current m_source
        before calling ScriptController::executeScript to allow safe
        reentrancy through document.write().

        * WebCore.xcodeproj/project.pbxproj:
         - Added HTML5ScriptRunnerHost.h
        * html/HTML5ScriptRunner.cpp:
        (WebCore::HTML5ScriptRunner::HTML5ScriptRunner):
        (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner):
         - Unregister m_parsingBlockingScript if stopped before
           load completion.  This was probably causing some of the
           crashes on page navigation we saw during LayoutTest runs.
        (WebCore::documentURLForScriptExecution):
         - Unify our documentURL handling so all callsites get it right.
        (WebCore::HTML5ScriptRunner::sourceFromPendingScript):
         - Use documentURLForScriptExecution
        (WebCore::HTML5ScriptRunner::executePendingScript):
         - Call stopWatchingForLoad instead of removeClient()
         - Call executeScript instead of ScriptController directly.
        (WebCore::HTML5ScriptRunner::executeScript):
         - Wraps calls to HTML5ScriptRunnerHost::executeScript
        (WebCore::HTML5ScriptRunner::watchForLoad):
         - Wraps calls to HTML5ScriptRunnerHost::watchForLoad
        (WebCore::HTML5ScriptRunner::stopWatchingForLoad):
         - Wraps calls to HTML5ScriptRunnerHost::stopWatchingForLoad
        (WebCore::HTML5ScriptRunner::requestScript):
         - Only watch for load if the CachedScript isn't already loaded.
           This gets rid of rentrancy due to addClient calls, and as a result
           also stops us from hitting ASSERT(m_scriptNestingLevel)
           in executePendingScript.
        (WebCore::HTML5ScriptRunner::runScript):
         - Use the new fancy documentURLForScriptExecution and executeScript.
        * html/HTML5ScriptRunner.h:
        (WebCore::HTML5ScriptRunner::PendingScript::PendingScript):
         - Add a watchingForLoad bool so we know if we ever called watchForLoad
           with this CachedScript*.
        * html/HTML5ScriptRunnerHost.h: Added.
        (WebCore::HTML5ScriptRunnerHost::~HTML5ScriptRunnerHost):
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::HTML5Tokenizer):
         - Store an m_document pointer since we need to access
           m_document->frame()->script() for script execution.
        (WebCore::HTML5Tokenizer::pumpLexer):
         - Always pause or unpause the TreeBuilder after script execution.
           Previously nested script execution would leave the TreeBuilder
           paused even though the top-level loop wanted to resume parsing.
           Now whenever m_scriptRunner->execute returns "continue parsing"
           parsing will actually continue.  This fixed cases where we would
           ignore the rest of the document after document.write() of a script tag.
        (WebCore::HTML5Tokenizer::write):
         - Explain how document.write() reentrancy is safe in the new world.
        (WebCore::HTML5Tokenizer::watchForLoad):
         - HTML5ScriptRunnerHost implementation.  We assert that this call will
           never cause script execution since that's our current design.
        (WebCore::HTML5Tokenizer::stopWatchingForLoad):
         - HTML5ScriptRunnerHost implementation.
        (WebCore::HTML5Tokenizer::executeScript):
         - HTML5ScriptRunnerHost implementation. Save off the current source
           before executing scripts in case document.write is called during
           script execution.
        * html/HTML5Tokenizer.h:
         - Implement HTML5ScriptRunnerHost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-25 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 28 May 2010 09:01:56 +0000 (09:01 +0000)]
2010-05-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Update the style guide re: static member variables and structs
        https://bugs.webkit.org/show_bug.cgi?id=39663

        Per Darin Adler's proposal on webkit-dev.

        All static member variables should be prefixed with s_.
        m_ should not be used for public data members in structs.
        Only structs should have public data members.

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-28 Nathan Lawrence <nlawrence@apple.com>
eric@webkit.org [Fri, 28 May 2010 07:58:34 +0000 (07:58 +0000)]
2010-05-28  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=39460

        Because not just <img> and <image> elements can preload images, we
        dont want to restrict the element associated with the loader.

        No new tests. Should share the same tests as the last patch.

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 28 May 2010 07:00:29 +0000 (07:00 +0000)]
2010-05-27  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        Cursor movement and text selection does not work well if a block is followed by an inline.
        https://bugs.webkit.org/show_bug.cgi?id=32123

        RenderInline::setSelectionState() missed selection state
        propagation for ancestors.  This fix pulled
        RenderBlock::setSelectionState() up to RenderBoxModelObject, to
        share it with RenderInline.

        * editing/selection/range-between-block-and-inline.html: Added.
        * platform/mac/editing/selection/range-between-block-and-inline-expected.checksum: Added.
        * platform/mac/editing/selection/range-between-block-and-inline-expected.png: Added.
        * platform/mac/editing/selection/range-between-block-and-inline-expected.txt: Added.
2010-05-27  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        Cursor movement and text selection does not work well if a block is followed by an inline.
        https://bugs.webkit.org/show_bug.cgi?id=32123

        RenderInline::setSelectionState() missed selection state
        propagation for ancestors.  This fix pulled
        RenderBlock::setSelectionState() up to RenderBoxModelObject, to
        share it with RenderInline.

        Test: editing/selection/range-between-block-and-inline.html: Added.

        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::setSelectionState):
        * rendering/RenderBoxModelObject.h:
        Moved setSelectionState() from RenderBlock to RenderBoxModelObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 28 May 2010 05:09:00 +0000 (05:09 +0000)]
2010-05-27  MORITA Hajime  <morrita@google.com>

        Not reviewed. Fixed typo

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 28 May 2010 04:21:55 +0000 (04:21 +0000)]
2010-05-27  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Make more HTML DOM members private, especially constructors
        https://bugs.webkit.org/show_bug.cgi?id=39697

        Refactoring, so no new tests needed.

        Working my way through HTMLTagNames.in from top to bottom, skipping any
        that are non-trivial for some reason.

        * html/HTMLTagNames.in: Removed createWithNew from audio, base, basefont,
        blockquote, body, br, button, canvas, caption, col, colgroup, datagrid,
        datalist, dcell, dcol, drow, del, dir, dl, and fieldset.

        * mathml/mathtags.in: Removed createWithNew from msub, and msup.

        * dom/Document.cpp:
        (WebCore::Document::implicitClose): Use create function instead of new.
        (WebCore::Document::getCSSCanvasElement): Ditto.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::createIndentBlockquoteElement): Ditto.
        * editing/htmlediting.cpp:
        (WebCore::createBreakElement): Ditto.
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::createCaption): Ditto.
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createContainingTable): Ditto.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setInnerTextValue): Ditto.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Use create function instead of new.
        Required reordering the code slightly, but the new order works fine.

        * html/HTMLAudioElement.cpp:
        (WebCore::HTMLAudioElement::create):
        * html/HTMLAudioElement.h:
        * html/HTMLBRElement.cpp:
        (WebCore::HTMLBRElement::create):
        * html/HTMLBRElement.h:
        * html/HTMLBaseElement.cpp:
        (WebCore::HTMLBaseElement::create):
        * html/HTMLBaseElement.h:
        * html/HTMLBaseFontElement.cpp:
        (WebCore::HTMLBaseFontElement::create):
        * html/HTMLBaseFontElement.h:
        * html/HTMLBlockquoteElement.cpp:
        (WebCore::HTMLBlockquoteElement::create):
        * html/HTMLBlockquoteElement.h:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::create):
        * html/HTMLBodyElement.h:
        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::create):
        * html/HTMLButtonElement.h:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::create):
        * html/HTMLCanvasElement.h:
        * html/HTMLDListElement.cpp:
        (WebCore::HTMLDListElement::create):
        * html/HTMLDListElement.h:
        * html/HTMLDataGridCellElement.cpp:
        (WebCore::HTMLDataGridCellElement::create):
        * html/HTMLDataGridCellElement.h:
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::create):
        * html/HTMLDataGridColElement.h:
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::create):
        * html/HTMLDataGridElement.h:
        * html/HTMLDataGridRowElement.cpp:
        (WebCore::HTMLDataGridRowElement::create):
        * html/HTMLDataGridRowElement.h:
        * html/HTMLDataListElement.cpp:
        (WebCore::HTMLDataListElement::create):
        * html/HTMLDataListElement.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setInnerText):
        * html/HTMLFieldSetElement.cpp:
        (WebCore::HTMLFieldSetElement::create):
        * html/HTMLFieldSetElement.h:
        * html/HTMLModElement.cpp:
        (WebCore::HTMLModElement::HTMLModElement):
        (WebCore::HTMLModElement::create):
        * html/HTMLModElement.h:
        * html/HTMLTableCaptionElement.cpp:
        (WebCore::HTMLTableCaptionElement::create):
        * html/HTMLTableCaptionElement.h:
        Made constructors and virtual function overrides private, added create functions.
        Made constructors inline in cases where they were called in only one place.

        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::HTMLTableColElement): Changed data member name
        from _span to m_span.
        (WebCore::HTMLTableColElement::create): Added.
        (WebCore::HTMLTableColElement::parseMappedAttribute): Updated to use m_span.
        * html/HTMLTableColElement.h:
        Made constructor and virtual function overrides private, added create function.
        Renamed _span to m_span.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 28 May 2010 03:21:29 +0000 (03:21 +0000)]
2010-05-27  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Darin Adler.

        wx port: build fix for Linux
        https://bugs.webkit.org/show_bug.cgi?id=39860

        Use uint16_t instead of uint16.

        * plugins/PluginPackageNone.cpp:
        (WebCore::PluginPackage::NPVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 28 May 2010 02:35:32 +0000 (02:35 +0000)]
2010-05-27  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Tamura Kent.

        [Chromium] Update chromium test expectations for parseFloat & toNumber tests
        https://bugs.webkit.org/show_bug.cgi?id=39861

        Update expectation files.

        * platform/chromium/fast/js/ToNumber-expected.txt:
        * platform/chromium/fast/js/parseFloat-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Nathan Lawrence <nlawrence@apple.com>
eric@webkit.org [Fri, 28 May 2010 00:44:59 +0000 (00:44 +0000)]
2010-05-27  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=39460

        Fixes the issue where images prefetched by JavaScript do not report
        their memory usage to the GC.

        There is a new test manual-tests/image-prefetch-stress.html that loads
        a new 4MB image every half a second.

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        * manual-tests/image-prefetch-stress.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Thu, 27 May 2010 23:43:54 +0000 (23:43 +0000)]
2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Darin Adler.

        UTF-16 code points compare() for String objects
        https://bugs.webkit.org/show_bug.cgi?id=39701

        Moving compare() implementation from UString to StringImpl for it to be shared
        with String. Adding overloaded free functions codePointCompare() in StringImpl
        and WTFString. Renaming function compare in UString to codePointCompare to be
        consistent.

        * runtime/JSArray.cpp:
        (JSC::compareByStringPairForQSort):
        * runtime/UString.cpp:
        * runtime/UString.h:
        (JSC::codePointCompare):
        * wtf/text/StringImpl.cpp:
        (WebCore::codePointCompare):
        * wtf/text/StringImpl.h:
        * wtf/text/WTFString.cpp:
        (WebCore::codePointCompare):
        * wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange z-component to 1.
bdakin@apple.com [Thu, 27 May 2010 23:40:42 +0000 (23:40 +0000)]
Change z-component to 1.

Reviewed by Simon Fraser.

* WebView/WebHTMLView.mm:
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Thu, 27 May 2010 23:21:51 +0000 (23:21 +0000)]
2010-05-27  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Adam Barth.

        Add v8 bindings for async DB API in workers
        https://bugs.webkit.org/show_bug.cgi?id=39145

        No new tests.  This should share layout tests with JSC.

        Tweak the callback generation to switch lots of Frame* to ScriptExecutionContext*, and use the context passed in to handleEvent where possible.
        * bindings/scripts/CodeGeneratorV8.pm:

        As with CodeGeneratorV8; these are pretty much all tiny tweaks.
        We do have to use a slightly different patch for callback invocation in invokeCallback, as V8Proxy::retrieve() doesn't work in the worker context.
        * bindings/v8/custom/V8CustomPositionCallback.cpp:
        (WebCore::V8CustomPositionCallback::handleEvent):
        * bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
        (WebCore::V8CustomPositionErrorCallback::handleEvent):
        * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
        (WebCore::V8SQLStatementErrorCallback::handleEvent):
        * bindings/v8/custom/V8CustomVoidCallback.cpp:
        (WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
        (WebCore::V8CustomVoidCallback::handleEvent):
        (WebCore::invokeCallback):
        * bindings/v8/custom/V8CustomVoidCallback.h:
        (WebCore::V8CustomVoidCallback::create):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::openDatabaseCallback):
        * bindings/v8/custom/V8DatabaseCustom.cpp:
        (WebCore::V8Database::changeVersionCallback):
        (WebCore::createTransaction):
        * bindings/v8/custom/V8DatabaseSyncCustom.cpp:
        (WebCore::V8DatabaseSync::changeVersionCallback):
        (WebCore::createTransaction):
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::V8NotificationCenter::requestPermissionCallback):
        * bindings/v8/custom/V8SQLTransactionCustom.cpp:
        (WebCore::V8SQLTransaction::executeSqlCallback):

        Add openDatabaseCallback.
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::V8WorkerContext::openDatabaseCallback):
        Remove an obsolete parameter.
        (WebCore::V8WorkerContext::openDatabaseSyncCallback):
2010-05-27  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Adam Barth.

        Add v8 bindings for async DB API in workers
        https://bugs.webkit.org/show_bug.cgi?id=39145

        * src/DatabaseObserver.cpp:
        We should check that we're on the context thread now, not the main
        thread.
        (WebCore::DatabaseObserver::databaseOpened):
        (WebCore::DatabaseObserver::databaseModified):
        (WebCore::DatabaseObserver::databaseClosed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-26 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 27 May 2010 23:09:48 +0000 (23:09 +0000)]
2010-05-26  Darin Adler  <darin@apple.com>

        Reviewed by Kent Tamura.

        Null characters handled incorrectly in ToNumber conversion
        https://bugs.webkit.org/show_bug.cgi?id=38088

        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::parseInt): Changed code to use UTF8String().data() instead of
        ascii() to fix the thread safety issue. Code path is covered by existing
        tests in run-javascriptcore-tests.
        (JSC::parseFloat): Moved comment to UString::toDouble since the issue
        affects all clients, not just parseFloat. Specifically, this also affects
        standard JavaScript numeric conversion, ToNumber.

        * runtime/UString.cpp:
        (JSC::UString::toDouble): Added a comment about incorrect space skipping.
        Changed trailing junk check to use the length of the CString instead of
        checking for a null character. Also got rid of a little unneeded logic
        in the case where we tolerate trailing junk.
2010-05-26  Darin Adler  <darin@apple.com>

        Reviewed by Kent Tamura.

        Null characters handled incorrectly in ToNumber conversion
        https://bugs.webkit.org/show_bug.cgi?id=38088

        * fast/js/ToNumber-expected.txt: Updated for new tests and to
        expect PASS for two null character tests.
        * fast/js/ToNumber.js: Added more test cases.
        * fast/js/parseFloat-expected.txt: Updated for new test case.
        * fast/js/script-tests/parseFloat.js: Added a test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Thu, 27 May 2010 22:52:53 +0000 (22:52 +0000)]
2010-05-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] Query parameters are not displayed in the resources headers section.

        https://bugs.webkit.org/show_bug.cgi?id=39848

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        (WebInspector.ResourceView.prototype._refreshRequestPayload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Nico Weber <thakis@chromium.org>
eric@webkit.org [Thu, 27 May 2010 22:41:53 +0000 (22:41 +0000)]
2010-05-27  Nico Weber  <thakis@chromium.org>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=39092

        Add Yank support to chromium mac. Do this by moving WebKit Mac's
        implementation of Editor::yankFromKillRing() into its own class and
        then using that.

        * editing/Editor.cpp:
          Use new KillRing class.
        * editing/Editor.h:
        (WebCore::Editor::killRing):
          Use new KillRing class.
        * editing/EditorCommand.cpp:
        (WebCore::executeYankAndSelect):
          Use new KillRing class.
        * platform/KillRing.h:
          Add new KillRing class, which acts as null object.
        (WebCore::KillRing::~KillRing):
        * platform/mac/KillRingMac.h:
          Add new KillRingMac class, which writes to the mac's kill ring.
        * platform/mac/KillRingMac.mm:
          Add new KillRingMac class, which writes to the mac's kill ring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Ben Murdoch <benm@google.com>
eric@webkit.org [Thu, 27 May 2010 22:26:17 +0000 (22:26 +0000)]
2010-05-27  Ben Murdoch  <benm@google.com>

        Reviewed by Jian Li.

        Build break in FileStream.cpp
        https://bugs.webkit.org/show_bug.cgi?id=39841

        When ENABLE_BLOB_SLICE is not defined, an undefined variable is used
        in FileStream.cpp:114. Fix by using the correct variable.

        Build fix so no new tests.

        * html/FileStream.cpp:
        (WebCore::FileStream::openForRead): Replace undefined variable with a defined one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Thu, 27 May 2010 21:57:15 +0000 (21:57 +0000)]
2010-05-27  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Default popup window size should not depend on zoom level
        https://bugs.webkit.org/show_bug.cgi?id=39835

        V8DOMWindow::openCallback should not set width and height of new
        window unless specified in the function's arguments.

        There is already code to reset the new window's origin coordinates,
        but the same thing should be done to its dimensions as well. Otherwise,
        a new popup with unspecified size will have its size depending on the
        parent's zoom level, which is not desirable.

        This is the same as what is done in
        bindings/js/JSDOMWindowCustom.cpp:826.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::openCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Nathan Lawrence <nlawrence@apple.com>
eric@webkit.org [Thu, 27 May 2010 21:45:10 +0000 (21:45 +0000)]
2010-05-27  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        Search for the new allocation one word at a time.  Improves
        performance on SunSpider by approximately 1%.
        http://bugs.webkit.org/show_bug.cgi?id=39758

        * runtime/Collector.cpp:
        (JSC::Heap::allocate):
        * runtime/Collector.h:
        (JSC::CollectorBitmap::advanceToNextPossibleFreeCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 27 May 2010 20:26:08 +0000 (20:26 +0000)]
2010-05-27  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        qt_instance.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39744

        Fix webkit coding style issues in qt_instance.cpp

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getQtInstance):
        (JSC::Bindings::QtInstance::removeCachedMethod):
        (JSC::Bindings::QtInstance::markAggregate):
        (JSC::Bindings::QtInstance::getPropertyNames):
        (JSC::Bindings::QtInstance::stringValue):
        (JSC::Bindings::QtField::name):
        (JSC::Bindings::QtField::valueFromInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
jparent@chromium.org [Thu, 27 May 2010 20:14:39 +0000 (20:14 +0000)]
Unreviewed.

Update Chromium expectations for runner.html after r60278.

* platform/chromium-mac/html5lib/runner-expected.txt:
* platform/chromium-win/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 27 May 2010 20:14:21 +0000 (20:14 +0000)]
2010-05-27  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        qt_instance.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39743

        Fix webkit coding style issues in qt_instance.h

        * bridge/qt/qt_instance.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 27 May 2010 20:01:37 +0000 (20:01 +0000)]
2010-05-27  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        qt_class.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39742

        Fix webkit coding style issues in qt_class.h

        * bridge/qt/qt_class.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 27 May 2010 19:22:59 +0000 (19:22 +0000)]
2010-05-27  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8016158> Crash in CVPixelBufferCreateResolvedAttributesDictionary with RLE
        compressed movie.

        Configure the visual context to generate Direct3D compatible pixel buffers when we are able to
        use a CAImageQueue so there will be less conversion required before display. This change also
        works around the issue that causes the RLE compressed movie to crash.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Pass enum to QTMovieVisualContext
        constructor instead of CFDictionary.
        * platform/graphics/win/QTMovieVisualContext.cpp:
        (SetNumberValue):
        (getPixelBufferCreationOptions): New, create options dictionary appropriate for the visual
        context type.
        (pixelBufferCreationOptions): New, return options dictionary appropriate for the visual
        context type.
        (QTMovieVisualContextPriv::QTMovieVisualContextPriv): Get the options dictionary from
        getPixelBufferCreationOptions insteaad of taking it as a parameter.
        (QTMovieVisualContext::QTMovieVisualContext): Take enum instead of CFDictionary for
        visual context configuration type.
        * platform/graphics/win/QTMovieVisualContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 27 May 2010 19:07:49 +0000 (19:07 +0000)]
2010-05-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        [Qt] REGRESSION(r60258): It broke 10 tests.
        https://bugs.webkit.org/show_bug.cgi?id=39819

        * plugins/qt/PluginDataQt.cpp:
        (WebCore::PluginData::initPlugins):
        Append the MimeClassInfo object after it's been initialized.
2010-05-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        [Qt] REGRESSION(r60258): It broke 10 tests.
        https://bugs.webkit.org/show_bug.cgi?id=39819

        Remove tests from the skipped list.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fixes for Windows after recent changes.
kevino@webkit.org [Thu, 27 May 2010 19:02:53 +0000 (19:02 +0000)]
[wx] Build fixes for Windows after recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago https://bugs.webkit.org/show_bug.cgi?id=39852
ap@apple.com [Thu, 27 May 2010 18:37:09 +0000 (18:37 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=39852
        [Qt] fast/encoding/yentest.html fails

        * platform/Qt/Skipped: Disabling the new tests for backslash transcoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 27 May 2010 18:34:29 +0000 (18:34 +0000)]
2010-05-27  Gustavo Noronha Silva  <gns@gnome.org>

        Update documentation control files, and fix Since tags for 1.3.1.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:
        * webkit/webkitwebbackforwardlist.cpp:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 27 May 2010 18:19:58 +0000 (18:19 +0000)]
2010-05-27  Gustavo Noronha Silva  <gns@gnome.org>

        Final make distcheck fix - clean up generated GDOM files on distclean.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Shinichiro Hamaji.
ap@apple.com [Thu, 27 May 2010 17:27:59 +0000 (17:27 +0000)]
    Reviewed by Shinichiro Hamaji.

        https://bugs.webkit.org/show_bug.cgi?id=39606
        Land tests for <rdar://problem/3277733>: \ in JavaScript mishandled when encoding is Japanese

        * fast/encoding/resources/yentestexternal.js: Added.
        * fast/encoding/resources/yentestexternal2.js: Added.
        * fast/encoding/yentest-expected.txt: Added.
        * fast/encoding/yentest.html: Added.
        * fast/encoding/yentest2-expected.txt: Added.
        * fast/encoding/yentest2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 39324 - AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute...
cfleizach@apple.com [Thu, 27 May 2010 17:26:00 +0000 (17:26 +0000)]
Bug 39324 - AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameter$
https://bugs.webkit.org/show_bug.cgi?id=39324

No review, build fixage.

Rolling out change from r60307 until a better fix is ready.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 May 2010 17:12:09 +0000 (17:12 +0000)]
2010-05-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: check that ScriptDebugListener was not removed
        while messages were dispatched in the nested loop.
        https://bugs.webkit.org/show_bug.cgi?id=39838

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::handleV8DebugEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 May 2010 16:26:16 +0000 (16:26 +0000)]
2010-05-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: undefined script URL value should be converted to an emtpy
        WebCore::String instead of "undefined" string. Otherwise it's shown
        in the Scripts panel with "undefined:<line no>" URL.
        https://bugs.webkit.org/show_bug.cgi?id=39845

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter...
cfleizach@apple.com [Thu, 27 May 2010 16:20:36 +0000 (16:20 +0000)]
AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle.
https://bugs.webkit.org/show_bug.cgi?id=39324

Reviewed by Darin Adler.

Make sure that accessibilityAttributeValue:forParameter: will default to its super's implementation. This is how AppKit expects objects to behave.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 27 May 2010 16:18:39 +0000 (16:18 +0000)]
2010-05-27  Xan Lopez  <xlopez@igalia.com>

        More GTK+ distcheck fixes.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 27 May 2010 16:16:30 +0000 (16:16 +0000)]
2010-05-27  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Bump for 1.3.1 release.

        * configure.ac:

WebKit/gtk:

2010-05-27  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for 1.3.1 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 27 May 2010 15:55:53 +0000 (15:55 +0000)]
2010-05-27  Gustavo Noronha Silva  <gns@gnome.org>

        More build fixage for make dist.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 May 2010 15:48:49 +0000 (15:48 +0000)]
2010-05-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Resume script execution if user tries to navigate to another URL
        https://bugs.webkit.org/show_bug.cgi?id=39842

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::):
        (WebKit::WebDevToolsAgentImpl::didNavigate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 May 2010 15:16:10 +0000 (15:16 +0000)]
2010-05-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: notify ScriptDebugListener when execution is resumed
        https://bugs.webkit.org/show_bug.cgi?id=39838

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::handleV8DebugEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Thu, 27 May 2010 15:05:34 +0000 (15:05 +0000)]
2010-05-27  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Ojan Vafai.

        Mark some SVG tests as flaky on Windows
        https://bugs.webkit.org/show_bug.cgi?id=39790

        The following SVG tests have been failing intermittently on the
        chromium console for the past 2+ days.
         - svg/clip-path/clip-path-childs-clipped.svg
         - svg/clip-path/clip-path-evenodd-nonzero.svg
         - svg/clip-path/clip-path-text-and-shape.svg
         - svg/text/text-text-04-t.svg
         - svg/text/text-text-05-t.svg

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 27 May 2010 14:36:23 +0000 (14:36 +0000)]
2010-05-27  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        qt_pixmapruntime.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39745

        Fix webkit coding style issues in qt_pixmapruntime.cpp

        * bridge/qt/qt_pixmapruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-26 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 27 May 2010 13:42:32 +0000 (13:42 +0000)]
2010-05-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IndexedDB layout tests
        https://bugs.webkit.org/show_bug.cgi?id=39748

        Split basics.js into a common library plus 2 other tests.  This
        will make it easier to ensure good test coverage as we go forward
        without too much cut and paste coding.  For the most part, each
        IndexedDB idl file should have its own test in the future (at a
        minimum).

        Also switching the 'description' portion of the test expectation
        to reflect the build fix from last night (which breaks the feature).

        * storage/indexeddb/basics-expected.txt: Removed.
        * storage/indexeddb/basics.html: Removed.
        * storage/indexeddb/idb-database-request-expected.txt: Added.
        * storage/indexeddb/idb-database-request.html: Added.
        * storage/indexeddb/indexed-database-request-expected.txt: Added.
        * storage/indexeddb/indexed-database-request.html: Added.
        * storage/indexeddb/resources/shared.js: Added.
        (init):
        (done):
        (verifyEventCommon):
        (verifyErrorEvent):
        (verifySuccessEvent):
        (verifyResult):
        (unexpectedErrorCallback):
        * storage/indexeddb/script-tests/TEMPLATE.html:
        * storage/indexeddb/script-tests/basics.js: Removed.
        * storage/indexeddb/script-tests/idb-database-request.js: Added.
        (openSuccess):
        (test):
        * storage/indexeddb/script-tests/indexed-database-request.js: Added.
        (openCallback):
        (test):
2010-05-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IndexedDB layout tests
        https://bugs.webkit.org/show_bug.cgi?id=39748

        Remove an assert that always fires.

        Tests: storage/indexeddb/idb-database-request.html
               storage/indexeddb/indexed-database-request.html

        * storage/IDBDatabaseImpl.cpp:
        (WebCore::IDBDatabaseImpl::objectStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 27 May 2010 13:35:33 +0000 (13:35 +0000)]
2010-05-27  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        Build fix for introspection support - make sure DOM headers are
        included by the GI scanner.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 27 May 2010 13:12:26 +0000 (13:12 +0000)]
2010-05-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Get CSS rule offsets lazily.

        https://bugs.webkit.org/show_bug.cgi?id=39832

        * inspector/InspectorCSSStore.cpp:
        (WebCore::InspectorCSSStore::getStartEndOffsets):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Thu, 27 May 2010 13:02:21 +0000 (13:02 +0000)]
2010-05-27  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        qt_class.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39741

        Fix webkit coding style issues in qt_class.cpp

        * bridge/qt/qt_class.cpp:
        (JSC::Bindings::QtClass::fieldNamed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Thu, 27 May 2010 12:48:47 +0000 (12:48 +0000)]
2010-05-27  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Brady Eidson.

        New Layout test for the history.pushState function.

        The test checks if history.length property is correct after
        a few pushState calls.

        history.pushState doesn't work for the first page in a window.
        https://bugs.webkit.org/show_bug.cgi?id=39418

        * fast/loader/stateobjects/pushstate-without-history-expected.txt: Added.
        * fast/loader/stateobjects/pushstate-without-history.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 27 May 2010 12:36:47 +0000 (12:36 +0000)]
2010-05-27  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Darin Adler.

        RVCT does not have strnstr.
        https://bugs.webkit.org/show_bug.cgi?id=39719

        Add COMPILER(RVCT) guard to strnstr in StringExtras.h as RVCT does not provide strnstr.

        * wtf/StringExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 May 2010 12:14:53 +0000 (12:14 +0000)]
2010-05-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style complains about use of NULL in GTK function calls that require sentinels
        https://bugs.webkit.org/show_bug.cgi?id=39372

        Don't warn about NULL in g_*() calls. Zero can't be used instead
        for calls like g_build_filename and g_object_get/set.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 27 May 2010 12:12:43 +0000 (12:12 +0000)]
2010-05-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        Remove bit-rotten INSTRUMENT_LAYOUT_SCHEDULING code from HTMLTokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39714

        This came from a discussion on #webkit with Hyatt about this code
        being old and no longer used to either of our knowledge.

        No functional changes, thus no tests.

        I also removed a bogus FIXME I had added in an earlier patch
        before I understood what the HTMLTokenizer was trying to do.

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::scriptExecution):
        (WebCore::HTMLTokenizer::continueProcessing):
        (WebCore::HTMLTokenizer::willWriteHTML):
        (WebCore::HTMLTokenizer::didWriteHTML):
        (WebCore::HTMLTokenizer::timerFired):
        (WebCore::HTMLTokenizer::executeExternalScriptsIfReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 27 May 2010 12:01:01 +0000 (12:01 +0000)]
2010-05-27  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Add callbacks to ScriptController to allow notifications on named items additions and removals
        https://bugs.webkit.org/show_bug.cgi?id=39679

        * bindings/js/ScriptController.h: Callbacks with empty implementation added.
        (WebCore::ScriptController::namedItemAdded):
        (WebCore::ScriptController::namedItemRemoved):
        * bindings/v8/ScriptController.cpp: Empty implementation of callbacks.
        (WebCore::ScriptController::namedItemAdded):
        (WebCore::ScriptController::namedItemRemoved):
        * bindings/v8/ScriptController.h: Callbacks added.
        * html/HTMLDocument.cpp: Hooking in callbacks.
        (WebCore::HTMLDocument::addItemToMap):
        (WebCore::HTMLDocument::removeItemFromMap):
        * html/HTMLDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 27 May 2010 11:43:30 +0000 (11:43 +0000)]
2010-05-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Implement lazy clearing of renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=36248

        * fast/canvas/webgl/renderbuffer-initialization-expected.txt: Added.
        * fast/canvas/webgl/renderbuffer-initialization.html: Added.
2010-05-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Implement lazy clearing of renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=36248

        Test: fast/canvas/webgl/renderbuffer-initialization.html

        * html/canvas/WebGLFramebuffer.cpp:
        (WebCore::WebGLFramebuffer::WebGLFramebuffer): Init added members.
        (WebCore::WebGLFramebuffer::setAttachment): Set attachment object.
        (WebCore::WebGLFramebuffer::onBind): Perform buffer clearing if needed.
        (WebCore::WebGLFramebuffer::onAttachedObjectChange): Ditto.
        (WebCore::WebGLFramebuffer::isUninitialized): Check whether an attached object is uninitialized renderbuffer.
        (WebCore::WebGLFramebuffer::setInitialized): After initialize a renderbuffer, set the flag.
        (WebCore::WebGLFramebuffer::initializeRenderbuffers): Clear un-initialized renderbuffers if framebuffer is complete.
        * html/canvas/WebGLFramebuffer.h:
        (WebCore::WebGLFramebuffer::isDepthAttached): Changed to check object.
        (WebCore::WebGLFramebuffer::isStencilAttached): Ditto.
        (WebCore::WebGLFramebuffer::isDepthStencilAttached): Ditto.
        * html/canvas/WebGLRenderbuffer.cpp:
        (WebCore::WebGLRenderbuffer::WebGLRenderbuffer): Init added members.
        * html/canvas/WebGLRenderbuffer.h:
        (WebCore::WebGLRenderbuffer::isInitialized): As the function name.
        (WebCore::WebGLRenderbuffer::setInitialized): Ditto.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::bindFramebuffer): Call onBind().
        (WebCore::WebGLRenderingContext::copyTexImage2D): Call onAttachedObjectChange().
        (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto.
        (WebCore::WebGLRenderingContext::deleteTexture): Ditto.
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Call setAttachment.
        (WebCore::WebGLRenderingContext::framebufferTexture2D): Call onAttachedObjectChange().
        (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
        (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::reshape): Initialize internal buffers.
2010-05-27  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Implement lazy clearing of renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=36248

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Clear WebGL internal buffers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Kristian Monsen <kristianm@google.com>
eric@webkit.org [Thu, 27 May 2010 10:51:16 +0000 (10:51 +0000)]
2010-05-27  Kristian Monsen  <kristianm@google.com>

        Reviewed by Darin Adler.

        Compile fix for Android, added include for Refcounted.h, this did not get
        included through Threading.h in Android.
        https://bugs.webkit.org/show_bug.cgi?id=39678

        Build fix only, no new tests.

        * storage/SQLTransactionSyncCallback.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Joone Hur <joone@kldp.org>
eric@webkit.org [Thu, 27 May 2010 10:39:32 +0000 (10:39 +0000)]
2010-05-27  Joone Hur  <joone@kldp.org>

        Reviewed by Xan Lopez.

        Add GtkVersioning.h in ScrollbackGtk.cpp for maintaining compatibility with the previous GTK+

        https://bugs.webkit.org/show_bug.cgi?id=39567

        * platform/gtk/ScrollbarGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Thu, 27 May 2010 10:28:00 +0000 (10:28 +0000)]
2010-05-27  Hans Wennborg  <hans@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Increase limit on number of (i)frames from 200 to 1000.
        https://bugs.webkit.org/show_bug.cgi?id=39427

        Add layout tests that test the possibility of generating 1000 iframes.

        * compositing/iframes/lots-of-iframes-expected.txt: Added.
        * compositing/iframes/lots-of-iframes.html: Added.
        * compositing/iframes/lots-of-objects-expected.txt: Added.
        * compositing/iframes/lots-of-objects.html: Added.
2010-05-27  Hans Wennborg  <hans@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Increase limit on number of (i)frames from 200 to 1000.
        https://bugs.webkit.org/show_bug.cgi?id=39427

        The limit on number of iframes was introduced in r3707 back in 2003.
        An example of a page that is broken because of this is:
        http://vimcolorschemetest.googlecode.com/svn/html/index-c.html
        Neither Firefox nor IE has such a limit.

        It seems that WebKit can handle a significantly higher number of frames, and
        the original reasons for imposing the limit are believed to be gone.

        Tests: compositing/iframes/lots-of-iframes.html
               compositing/iframes/lots-of-objects.html

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):
        * page/FrameTree.cpp:
        (WebCore::FrameTree::uniqueChildName):
        * page/Page.h:
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::isURLAllowed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 27 May 2010 09:51:56 +0000 (09:51 +0000)]
2010-05-27  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Xan Lopez.

        [GTK] writeToFile fails when length is large
        https://bugs.webkit.org/show_bug.cgi?id=39666

        writeToFile forgot to increment data pointer.

        * platform/gtk/FileSystemGtk.cpp:
        (WebCore::writeToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Thu, 27 May 2010 09:37:26 +0000 (09:37 +0000)]
2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Platform plugin example
        https://bugs.webkit.org/show_bug.cgi?id=39489

        Adding a Qt platform plugin example to repository.

        * examples/platformplugin/README: Added.
        * examples/platformplugin/WebPlugin.cpp: Added.
        (Popup::populateList):
        (Popup::onItemSelected):
        (WebPopup::WebPopup):
        (WebPopup::~WebPopup):
        (WebPopup::createSingleSelectionPopup):
        (WebPopup::createMultipleSelectionPopup):
        (WebPopup::createPopup):
        (WebPopup::show):
        (WebPopup::hide):
        (WebPopup::popupClosed):
        (WebPopup::itemClicked):
        (SingleSelectionPopup::SingleSelectionPopup):
        (MultipleItemListDelegate::MultipleItemListDelegate):
        (MultipleItemListDelegate::paint):
        (MultipleSelectionPopup::MultipleSelectionPopup):
        (WebPlugin::supportsExtension):
        * examples/platformplugin/WebPlugin.h: Added.
        (Popup::Popup):
        (WebPlugin::createSelectInputMethod):
        * examples/platformplugin/platformplugin.pro: Added.
        * examples/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
        (QWebSelectData::~QWebSelectData):
        (QWebSelectData::):
        (QWebSelectMethod::~QWebSelectMethod):
        (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
        (QWebKitPlatformPlugin::):
2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Platform plugin example
        https://bugs.webkit.org/show_bug.cgi?id=39489

        Exempting directory WebKit/qt/examples/ from style guide.

        * Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Dragging onto the desktop causes a critical GLib warning
mrobinson@webkit.org [Thu, 27 May 2010 09:30:25 +0000 (09:30 +0000)]
[GTK] Dragging onto the desktop causes a critical GLib warning
https://bugs.webkit.org/show_bug.cgi?id=39718

Reviewed by Xan Lopez.

Only increment the window reference count if it is not null during drag-end
signal processing.

* webkit/webkitwebview.cpp:
(webkit_web_view_drag_end): Guard against null window values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-26 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 27 May 2010 09:21:24 +0000 (09:21 +0000)]
2010-05-26  Philippe Normand  <pnormand@igalia.com>

        Reviewed by David Levin.

        [style] Allow usage of NULL in gst_*_many()
        https://bugs.webkit.org/show_bug.cgi?id=39740

        Don't warn if NULL is used by gst_*_many() functions. Zero can't
        be used for the reason explained in Bug 32858.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39783, clean up the moveChild functions on...
hyatt@apple.com [Thu, 27 May 2010 08:30:32 +0000 (08:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39783, clean up the moveChild functions on RenderBlock.

Reviewed by Sam Weinig.

Eliminate the need to pass the toChildrenList to the moveChild functions by tightening up the type of the
|to| argument to be a RenderBlock.

Add a moveChildrenTo function that can move a range of children, and patch places that were doing this
by hand.

Make the append forms of the functions just use the insert forms with a beforeChild of 0.

Patch insertChildNode in RenderObjectChildList so that it passes the fullInsert parameter through in the
case where it does an append.

Add an assert to RenderLayer that catches bad structure built when the fullInsert/Remove parameters are
messed up when using append/insertChildNode.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks):
(WebCore::RenderBlock::createAndAppendRootInlineBox):
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveChildrenTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):
(WebCore::RenderBlock::moveChildrenTo):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::addChild):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Add failing tests to the Skipped list temporarily.
ossy@webkit.org [Thu, 27 May 2010 08:30:00 +0000 (08:30 +0000)]
Unreviewed. Add failing tests to the Skipped list temporarily.

[Qt] REGRESSION(r60258): It broke 10 tests.
https://bugs.webkit.org/show_bug.cgi?id=39819

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 27 May 2010 08:17:46 +0000 (08:17 +0000)]
2010-05-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add <pre>/<listing> hack to HTML5Lexer to fix the last remaining HTML5 test suite regressions
        https://bugs.webkit.org/show_bug.cgi?id=39818

        * html5lib/runner-expected-html5.txt:
2010-05-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add <pre>/<listing> hack to HTML5Lexer to fix the last remaining HTML5 test suite regressions
        https://bugs.webkit.org/show_bug.cgi?id=39818

        HTML parsers are supposed to ignore the first \n after a <pre> or <listing> tag
        for authoring convenience.  Our new HTML5Lexer didn't have this hack yet
        so there were 4 HTML5 tests failing.  Fixing this fixed the last of the HTML5
        test suite regressions using the HTML5Lexer vs the old lexer.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::reset):
        (WebCore::HTML5Lexer::nextToken):
        * html/HTML5Lexer.h:
        (WebCore::HTML5Lexer::skipLeadingNewLineForListing):
        * html/HTML5TreeBuilder.cpp:
        (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing file from my last commit.
abarth@webkit.org [Thu, 27 May 2010 08:00:25 +0000 (08:00 +0000)]
Add missing file from my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60279 268f45cc-cd09-0410-ab3c-d52691b4dbfc