WebKit-https.git
9 years agounicode-bidi:-webkit-plaintext does not work on <textarea>
leviw@chromium.org [Wed, 27 Jul 2011 23:16:25 +0000 (23:16 +0000)]
unicode-bidi:-webkit-plaintext does not work on <textarea>
https://bugs.webkit.org/show_bug.cgi?id=65074

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixing unicode-bidi style propagation into text control shadow trees.

Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::adjustInnerTextStyle):

LayoutTests:

Fixing unicode-bidi propagation into text controls.

* fast/text/international/unicode-bidi-plaintext-in-textarea.html: Added.
* platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
* platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace SpecificityCalculator with TestConfiguration-driven logic.
dglazkov@chromium.org [Wed, 27 Jul 2011 23:11:01 +0000 (23:11 +0000)]
Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
    test configuration matching, removed a bunch of code.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow ports to specify their own test expectation specifier macros.
dglazkov@chromium.org [Wed, 27 Jul 2011 22:42:34 +0000 (22:42 +0000)]
Allow ports to specify their own test expectation specifier macros.
https://bugs.webkit.org/show_bug.cgi?id=65291

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
* Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
* Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
* Scripts/webkitpy/layout_tests/port/test.py: Added test macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for Symbian after r91800
mahesh.kulkarni@nokia.com [Wed, 27 Jul 2011 22:35:47 +0000 (22:35 +0000)]
Build fix for Symbian after r91800

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark another webgl flaky test.
enne@google.com [Wed, 27 Jul 2011 22:33:46 +0000 (22:33 +0000)]
[chromium] Mark another webgl flaky test.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow TestConfigurationConverter report conversion errors.
dglazkov@chromium.org [Wed, 27 Jul 2011 22:16:41 +0000 (22:16 +0000)]
Allow TestConfigurationConverter report conversion errors.
https://bugs.webkit.org/show_bug.cgi?id=65287

Also, fix a few miscellaneous testing issues.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
    was created. 'default' is not a valid build type.
* Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline absolute-child-with-percent-etc-etc-etc.
enne@google.com [Wed, 27 Jul 2011 22:10:01 +0000 (22:10 +0000)]
[chromium] Rebaseline absolute-child-with-percent-etc-etc-etc.

Unreviewed gardening.

* platform/chromium-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
* platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
* platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-27 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 27 Jul 2011 22:01:02 +0000 (22:01 +0000)]
2011-07-27  Eric Carlson  <eric.carlson@apple.com>

        Load delegate not consulted before loading some poster images
        https://bugs.webkit.org/show_bug.cgi?id=65270

        Reviewed by Darin Adler.

        Test: media/video-poster-blocked-by-willsendrequest.html

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::setDisplayMode): Don't ask media engine to set poster if
            willLoadMediaElementURL returns false.

2011-07-27  Eric Carlson  <eric.carlson@apple.com>

        Load delegate not consulted before loading some poster images
        https://bugs.webkit.org/show_bug.cgi?id=65270

        Reviewed by Darin Adler.

        * media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
        * media/video-poster-blocked-by-willsendrequest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle callback oriented JSONP
oliver@apple.com [Wed, 27 Jul 2011 21:55:40 +0000 (21:55 +0000)]
Handle callback oriented JSONP
https://bugs.webkit.org/show_bug.cgi?id=65271

Reviewed by Gavin Barraclough.

Handle the callback oriented versions of JSONP.  The Literal parser
now handles <Identifier> (. <Identifier>)* (jsonData).

* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lex):
* runtime/LiteralParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for printing with accelerated <canvas>
senorblanco@chromium.org [Wed, 27 Jul 2011 21:50:57 +0000 (21:50 +0000)]
Fix for printing with accelerated <canvas>
https://bugs.webkit.org/show_bug.cgi?id=62406

Reviewed by James Robinson.

The platform-independent side of this should be covered by existing
tests.  Printing itself in Chrome has few tests, sadly.  :(

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert http://trac.webkit.org/changeset/90415.
slewis@apple.com [Wed, 27 Jul 2011 21:44:49 +0000 (21:44 +0000)]
Revert http://trac.webkit.org/changeset/90415.
Caused a 5% sunspider regression in-browser.

Unreviewed rollout.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach all ports about their test configurations.
dglazkov@chromium.org [Wed, 27 Jul 2011 21:06:56 +0000 (21:06 +0000)]
Teach all ports about their test configurations.
https://bugs.webkit.org/show_bug.cgi?id=65278

Each Port object should return a valid set of all TestConfiguration instances,
available for this port.

Reviewed by Philippe Normand.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
    since it is different for each port.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
    all test configurations as a param.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
* Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
* Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
* Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
* Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
* Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
* Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
* Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaselines for r89627 and r91497.
rniwa@webkit.org [Wed, 27 Jul 2011 19:44:03 +0000 (19:44 +0000)]
Chromium rebaselines for r89627 and r91497.

* platform/chromium-linux/editing/selection/extend-inside-transforms-backward-expected.png: Added.
* platform/chromium-linux/editing/selection/extend-inside-transforms-forward-expected.png: Added.
* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png:
* platform/chromium-linux/fast/multicol/single-line-expected.png:
* platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/single-line-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-margin-collapsing-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
* platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/single-line-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
* platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
* platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.png: Added.
* platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
* platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.png: Added.
* platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.png:
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt:
* platform/chromium-win/fast/multicol/single-line-expected.png:
* platform/chromium-win/fast/multicol/single-line-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.txt:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoediting/selection/move-by-word-visually* tests timing out
xji@chromium.org [Wed, 27 Jul 2011 19:26:08 +0000 (19:26 +0000)]
editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Split the 2 tests into 4 tests. But need to find a way to improve
performance eventually.

* editing/selection/move-by-word-visually-multi-line-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
* editing/selection/move-by-word-visually-multi-line.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
* editing/selection/move-by-word-visually-multi-space-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
* editing/selection/move-by-word-visually-multi-space.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
* editing/selection/move-by-word-visually-others-expected.txt: Removed.
* editing/selection/move-by-word-visually-others.html: Removed.
* editing/selection/move-by-word-visually-single-space-inline-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
* editing/selection/move-by-word-visually-single-space-inline-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
* editing/selection/move-by-word-visually-single-space-one-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
* editing/selection/move-by-word-visually-single-space-one-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
* editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt: Removed.
* editing/selection/move-by-word-visually-single-space-sigle-line.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][Qt] Move from QGraphicsView to Qt Scene Graph
benjamin.poulain@nokia.com [Wed, 27 Jul 2011 19:21:45 +0000 (19:21 +0000)]
[WK2][Qt] Move from QGraphicsView to Qt Scene Graph
https://bugs.webkit.org/show_bug.cgi?id=62969

Reviewed by Andreas Kling.

Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>

Source/WebKit/qt:

Add the declarative dependency to link WebKit.

* QtWebKit.pro:

Source/WebKit2:

This patch change the base of WebKit2 from QGraphicsWidget
to scenegraph based items.

QTouchWebView becomes a QSGItem with the only role of clipping
child items.
QTouchWebPage becomes a QSGPaintedItem in order to render the content
of the flattened page. This is a temporary work around to get
something running without deep changes on the drawing area proxy.

QDesktopWebView become a QSGPaintedItem and behave as before
regarding rendering. The drawing area proxy is used to render
the full item.

The event delivery had to be adapted because the scenegraph does not
follow regular delivery of QEvents. Instead, each event type is
delivered directly to a specific virtual function.
In this patch, the events are forwarded to the classic QObject::event().

For the features that cannot be implemented on scenegraph (tooltip, menus, etc),
a temporary workaround was added: the parent canvas is used as the widget for
providing the feature. This assumes the web views alone in the canvas and
take its full size. This will have to be fixed in the scenegraph for us to
implement those features.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::isActive):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::init):
(paintCrashedPage):
(QDesktopWebView::keyPressEvent):
(QDesktopWebView::keyReleaseEvent):
(QDesktopWebView::inputMethodEvent):
(QDesktopWebView::focusInEvent):
(QDesktopWebView::focusOutEvent):
(QDesktopWebView::mousePressEvent):
(QDesktopWebView::mouseMoveEvent):
(QDesktopWebView::mouseReleaseEvent):
(QDesktopWebView::mouseDoubleClickEvent):
(QDesktopWebView::wheelEvent):
(QDesktopWebView::touchEvent):
(QDesktopWebView::hoverEnterEvent):
(QDesktopWebView::hoverMoveEvent):
(QDesktopWebView::hoverLeaveEvent):
(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragExitEvent):
(QDesktopWebView::dragDropEvent):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::paint):
(QTouchWebPage::event):
(QTouchWebPage::keyPressEvent):
(QTouchWebPage::keyReleaseEvent):
(QTouchWebPage::inputMethodEvent):
(QTouchWebPage::focusInEvent):
(QTouchWebPage::focusOutEvent):
(QTouchWebPage::touchEvent):
(QTouchWebPage::geometryChanged):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::scroll):
(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/testwindow.h:
(TestWindow::TestWindow):
(TestWindow::resizeEvent):
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::panGestureRequestScroll):
(WebKit::TouchViewInterface::pinchGestureRequestUpdate):
(WebKit::TouchViewInterface::drawingAreaSize):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::isActive):
* UIProcess/qt/ViewInterface.cpp: Removed.
* UIProcess/qt/ViewInterface.h:
* WebKit2.pro:

Tools:

With the scene graph, the interface to have a window on screen is
QSGCanvas. QGraphicsView is not used, and openGL is an enforced
dependency.

Both the BrowserView and the WebKitTest runner are changed from
QGraphicsView to QSGCanvas.

* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::view):
* MiniBrowser/qt/BrowserView.h:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/main.cpp:
(main):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/qt/WebKitTestRunner.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWrong image height in absolutely positioned div in relatively positioned parent with...
rniwa@webkit.org [Wed, 27 Jul 2011 18:54:54 +0000 (18:54 +0000)]
Wrong image height in absolutely positioned div in relatively positioned parent with bottom padding
https://bugs.webkit.org/show_bug.cgi?id=64046

Reviewed by David Hyatt.

Add pixel test results.

* platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac pixel rebaselines after r91497.
rniwa@webkit.org [Wed, 27 Jul 2011 18:39:36 +0000 (18:39 +0000)]
Mac pixel rebaselines after r91497.

* platform/mac/fast/multicol/float-multicol-expected.png:
* platform/mac/fast/multicol/scrolling-overflow-expected.png:
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/mac/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
mihaip@chromium.org [Wed, 27 Jul 2011 18:34:07 +0000 (18:34 +0000)]
[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
https://bugs.webkit.org/show_bug.cgi?id=65158

Reviewed by David Hyatt.

Source/WebCore:

Add per-Document instance user stylesheets (as opposed to the page
group user styles and the global page stylesheet).

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore::Document::addUserSheet):
* dom/Document.h:

Source/WebKit/chromium:

Add WebDocument::insertUserStyleSheet which inserts a user stylesheet,
instead of forcing extensions to use insertStyleText which manipulates
the DOM of the page and results in compatibility issues (see
http://crbug.com/82220).

* public/WebDocument.h:
* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark data-view-test.html as flaky in non-debug configs too.
enne@google.com [Wed, 27 Jul 2011 18:32:45 +0000 (18:32 +0000)]
[chromium] Mark data-view-test.html as flaky in non-debug configs too.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Disable cache option should only clear memory cache, not disable it.
vsevik@chromium.org [Wed, 27 Jul 2011 18:30:18 +0000 (18:30 +0000)]
Web Inspector: Disable cache option should only clear memory cache, not disable it.
https://bugs.webkit.org/show_bug.cgi?id=65184

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/InspectorClient.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:

LayoutTests:

* http/tests/inspector/network/network-disable-cache-memory-expected.txt:
* http/tests/inspector/network/network-disable-cache-memory.html:
* http/tests/inspector/network/resources/random-script.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.
ossy@webkit.org [Wed, 27 Jul 2011 17:45:41 +0000 (17:45 +0000)]
[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

* platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
* platform/qt-wk2/Skipped: Skip failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add baselines for struct-dom-11-f.svg.
enne@google.com [Wed, 27 Jul 2011 17:43:06 +0000 (17:43 +0000)]
[chromium] Add baselines for struct-dom-11-f.svg.

Unreviewed gardening.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtWebkit never finishes loading sites when they are loaded after an initial...
caio.oliveira@openbossa.org [Wed, 27 Jul 2011 17:40:57 +0000 (17:40 +0000)]
[Qt] QtWebkit never finishes loading sites when they are loaded after an initial QUrl fails to load.
https://bugs.webkit.org/show_bug.cgi?id=61328

Reviewed by Andreas Kling.

Change the hooks in FrameLoaderClient we use for emitting signals. Instead of
emitting signals in the progress notification functions, we use the
dispatchDid{Start,Finish,Fail}* functions. The main reason behind this change is
that loading code is prepared to handle load() when inside those functions.

The crash was being caused by setUrl() (and load()) being called when
loadFinished(false) was emitted. The problem here is that when
postProgressFinishedNotification the FrameLoader wasn't ready for taking a load()
call again, because it was still the ProvisionalLoadState but with the
provisionalDocumentLoader already removed.

To emulate the same behavior that QtWebKit had when using
postProgressFinishedNotification, we now keep track of the frame originating the
load, and emit the signals when this frame's client is called.

The patch keeps the existing semantics for QWebPage signals, but we now emit the
QWebFrame signals everytime, not only when they are the originating frame for
loading.

* Api/qwebframe.cpp:
(clearCoreFrame): Document our assumption that activeDocumentLoader will exist.

* WebCoreSupport/FrameLoaderClientQt.h: Remove m_loadError, add a boolean to keep
track whether the frame is originating the load. Remove the signals from
FrameLoaderClientQt since we will emit QWebFrame and QWebPage signals directly.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Initialize m_isOriginatingLoad.

(WebCore::FrameLoaderClientQt::setFrame): Do not connect QWebFrame and QWebPage
signals to our signals for load/finished, signal emission will be done manually.

(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): Emit
loadStarted() signal and make the first notification of estimation change, that
Qt API tests expect to exist and notify 10%.

(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): Remove reference to
m_loadError and emit loadFinished() signal.

(WebCore::FrameLoaderClientQt::postProgressStartedNotification): Remove signal
emission and mark the originating load as true, since only the originating frame
gets this call in its client.

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification): Remove signal
emission.

(WebCore::FrameLoaderClientQt::callErrorPageExtension): Return whether the call
was successful or not. This wasn't necessary before because a successful call for
error page would lead to a load(), that cleared the m_loadError.
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): Remove reference
to m_loadError and emit finished signal indicating error if ErrorPage extension
doesn't handle it.
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad): Ditto.

(WebCore::FrameLoaderClientQt::emitLoadStarted): Emit the loadStarted() signal
for the QWebFrame, and if the originating load also do for the QWebPage.

(WebCore::FrameLoaderClientQt::emitLoadFinished): Same as before but for
loadFinished(). Take care to reset the originating load flag before the signals
are emitted, since they might want to set it back again.

* tests/qwebframe/tst_qwebframe.cpp:
(URLSetter::URLSetter): Object that sets the url using either load() or setUrl()
when a certain signal is emitted in the frame.

(URLSetter::execute):
(tst_QWebFrame::loadInSignalHandlers_data):
(tst_QWebFrame::loadInSignalHandlers): New test inspired by the bug test case. This test
crashes without this patch applied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Mark more tests as being flaky.
enne@google.com [Wed, 27 Jul 2011 17:20:34 +0000 (17:20 +0000)]
[Chromium] Mark more tests as being flaky.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
ossy@webkit.org [Wed, 27 Jul 2011 17:09:29 +0000 (17:09 +0000)]
[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
https://bugs.webkit.org/show_bug.cgi?id=65266

[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

* platform/qt-4.8/fast/css/font-face-opentype-expected.png: Added.
* platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Added.
* platform/qt-4.8/fast/css/font-family-pictograph-expected.png: Added.
* platform/qt-4.8/fast/css/font-family-pictograph-expected.txt: Added.
* platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
* platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
* platform/qt-4.8/svg/custom/tref-own-content-removal-expected.png: Added.
* platform/qt-4.8/svg/custom/tref-own-content-removal-expected.txt: Added.
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Remove window.XSLTProcessor entries.
* platform/qt/Skipped: Skip a failing test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg.
* platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added after r91850.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added after r91850.
* platform/qt/svg/custom/tref-own-content-removal-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 27 Jul 2011 16:20:46 +0000 (16:20 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-wk2/Skipped: Skip failing tests after migration to Qt5.
* platform/qt/test_expectations.txt: Mark fast/js/array-sort-modifying-tostring.html as TIMEOUT PASS flakey test in debug mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Unreviewed gardening.
ossy@webkit.org [Wed, 27 Jul 2011 16:06:18 +0000 (16:06 +0000)]
[WK2] Unreviewed gardening.

* platform/qt-wk2/Skipped: Skip new failing tests.
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Update after r91300.
* platform/wk2/Skipped: Skip tests because of missing layoutTestController implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-27 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 27 Jul 2011 15:58:40 +0000 (15:58 +0000)]
2011-07-27  Rob Buis  <rbuis@rim.com>

        Implement getIntersectionList(), getEnclosureList(), checkIntersection() and checkEnclosure() in SVGSVGElement
        https://bugs.webkit.org/show_bug.cgi?id=11274

        Reviewed by Nikolas Zimmermann.

        Implement checkIntersection/checkEnclosure and use it to implement getIntersectionList and getEnclosureList as well.
        The referenceElement is used to provide a DOM subtree to find matches in. Also we do not allow elements that specify
        pointer-events=none in the list.

        Tests: svg/W3C-SVG-1.1-SE/struct-dom-11-f.svg
               svg/custom/intersection-list-clipping.svg
               svg/custom/intersection-list-nested-svg.svg

        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::getElementCTM):
        (WebCore::intersectsAllowingEmpty):
        (WebCore::isGraphicsElement):
        (WebCore::RenderSVGModelObject::checkIntersection):
        (WebCore::RenderSVGModelObject::checkEnclosure):
        * rendering/svg/RenderSVGModelObject.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::checkIntersection):
        (WebCore::SVGSVGElement::checkEnclosure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTighten up some chromium test expectations to green up the bots.
senorblanco@chromium.org [Wed, 27 Jul 2011 15:56:28 +0000 (15:56 +0000)]
Tighten up some chromium test expectations to green up the bots.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline one Chromium GPU test on Linux after
senorblanco@chromium.org [Wed, 27 Jul 2011 15:45:52 +0000 (15:45 +0000)]
Rebaseline one Chromium GPU test on Linux after
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

* platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPass on the suggested name for download file to the client.
commit-queue@webkit.org [Wed, 27 Jul 2011 15:36:31 +0000 (15:36 +0000)]
Pass on the suggested name for download file to the client.
https://bugs.webkit.org/show_bug.cgi?id=65181

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::startDownload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew chromium-linux baselines after skia change
senorblanco@chromium.org [Wed, 27 Jul 2011 15:25:36 +0000 (15:25 +0000)]
New chromium-linux baselines after skia change
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

* platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/fast/transforms/transform-on-inline-expected.png:
* platform/chromium-linux/fast/transforms/transform-table-row-expected.png:
* platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
* platform/chromium-linux/fonts/cursive-expected.txt: Added.
* platform/chromium-linux/fonts/fantasy-expected.txt:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
* platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPath2-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPath3-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-linux/svg/custom/focus-ring-expected.png:
* platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
* platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
* platform/chromium-linux/svg/custom/text-linking-expected.png:
* platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
* platform/chromium-linux/svg/custom/text-rotation-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
* platform/chromium-linux/svg/custom/use-on-non-svg-namespaced-element-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
* platform/chromium-linux/svg/text/text-path-01-b-expected.png:
* platform/chromium-linux/svg/text/text-path-middle-align-expected.png:
* platform/chromium-linux/svg/text/text-text-07-t-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/chromium-linux/transforms/2d/compound-transforms-vs-containers-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build in Qt 5 of QDeclarativeWebView
caio.oliveira@openbossa.org [Wed, 27 Jul 2011 15:20:43 +0000 (15:20 +0000)]
[Qt] Fix build in Qt 5 of QDeclarativeWebView
https://bugs.webkit.org/show_bug.cgi?id=65258

Reviewed by Andreas Kling.

In Qt 5, the QGraphicsView-based classes for QtQuick are in the
qtquick1 module, including QDeclarativeItem and QDeclarativeView.

.:

* Source/WebKit.pro:

Source/WebKit/qt:

* declarative/qdeclarativewebview_p.h:
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
* tests/tests.pri:
* tests/tests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][V8] Fix the build.
abecsi@webkit.org [Wed, 27 Jul 2011 14:37:26 +0000 (14:37 +0000)]
[Qt][V8] Fix the build.

Unreviewed build fix.

No new tests needed.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Add missing CString.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed build fix for mac.
alexis.menard@openbossa.org [Wed, 27 Jul 2011 14:20:07 +0000 (14:20 +0000)]
[Qt] Unreviewed build fix for mac.

QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
of the options passed to build-webkit, therefore DerivedSources should now generate the
includes when it's mac.

* DerivedSources.pro:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared...
ossy@webkit.org [Wed, 27 Jul 2011 14:12:12 +0000 (14:12 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

* platform/qt/Skipped: Skip a new failing test: svg/custom/image-with-transform-clip-filter.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative win build fix after r91835
tonyg@chromium.org [Wed, 27 Jul 2011 13:56:16 +0000 (13:56 +0000)]
Speculative win build fix after r91835
https://bugs.webkit.org/show_bug.cgi?id=65255

Unreviewed build fix.

* src/WebFontImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Clean WKPageLoaderClient
commit-queue@webkit.org [Wed, 27 Jul 2011 13:55:06 +0000 (13:55 +0000)]
[Qt][WK2] Clean WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=65246

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-27
Reviewed by Andreas Kling.

Remove the empty functions from Qt's WKPageLoaderClient.

* UIProcess/qt/ClientImpl.cpp:
(qt_wk_didSameDocumentNavigationForFrame): Move the function to
have all the implementations in the same order as the definitions.
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInspector should support cd(window) in the command line
yurys@chromium.org [Wed, 27 Jul 2011 13:37:03 +0000 (13:37 +0000)]
Inspector should support cd(window) in the command line
https://bugs.webkit.org/show_bug.cgi?id=19872

Source/WebCore:

Added dropdown list with all iframes to allow selecting current evaluation context for console expressions.

Reviewed by Pavel Feldman.

Test: http/tests/inspector/console-cd.html

* WebCore.gypi:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
* inspector/WorkerInspectorController.cpp:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._contextUpdated):
(WebInspector.ConsoleView.prototype.get _currentEvaluationContextId):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/ContextManager.js: Added.
(WebInspector.ContextManager):
(WebInspector.ContextManager.prototype._frameAdded):
(WebInspector.ContextManager.prototype._frameNavigated):
(WebInspector.ContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext):
(WebInspector.FrameEvaluationContext.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get id):
(WebInspector.FrameEvaluationContext.prototype.get url):
(WebInspector.FrameEvaluationContext.prototype.get displayName):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

Added a test for console evaluation in an iframe.

Reviewed by Pavel Feldman.

* http/tests/inspector/console-cd-expected.txt: Added.
* http/tests/inspector/console-cd.html: Added.
* http/tests/inspector/resources/console-cd-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt (and possibly Gtk) WebKit2 build after addition of -webkit-pictograph
caio.oliveira@openbossa.org [Wed, 27 Jul 2011 13:34:41 +0000 (13:34 +0000)]
Fix Qt (and possibly Gtk) WebKit2 build after addition of -webkit-pictograph
https://bugs.webkit.org/show_bug.cgi?id=65253

Reviewed by Andreas Kling.

The -webkit-pictograph generic family was added by bug 65197.

* Shared/WebPreferencesStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
commit-queue@webkit.org [Wed, 27 Jul 2011 13:07:42 +0000 (13:07 +0000)]
Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripWhiteSpace):
  Added an interface to take IsWhiteSpaceFunctionPtr.
(WTF::StringImpl::simplifyWhiteSpace): ditto.
* wtf/text/StringImpl.h:
* wtf/text/WTFString.cpp:
(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.
* wtf/text/WTFString.h:

Source/WebCore: Uses isHTMLSpace to normalize white spaces.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

Test: fast/forms/option-strip-unicode-spaces.html

* dom/OptionElement.cpp:
(WebCore::OptionElement::normalizeText):
  Uses isHTMLSpace to trim and replace white spaces.

LayoutTests: Added a test to normalize option.text.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

* fast/forms/option-strip-unicode-spaces-expected.txt: Added.
* fast/forms/option-strip-unicode-spaces.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Qt specific expected result for a new test introduced in r91777.
ossy@webkit.org [Wed, 27 Jul 2011 13:01:00 +0000 (13:01 +0000)]
Add Qt specific expected result for a new test introduced in r91777.

* platform/qt/fast/css/font-family-pictograph-expected.png: Added.
* platform/qt/fast/css/font-family-pictograph-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove include of skia/ext/platform_canvas.h
zecke@webkit.org [Wed, 27 Jul 2011 12:38:37 +0000 (12:38 +0000)]
[chromium] Remove include of skia/ext/platform_canvas.h
https://bugs.webkit.org/show_bug.cgi?id=60852

Reviewed by Hajime Morita.

In https://bugs.webkit.org/show_bug.cgi?id=57563 the usage of the
skia::PlatformCanvas was eliminated in favor of directly using
SkCanvas directly. The include of platform_canvas.h was not removed
leaving the dependency on Chromium in the header files. Remove
that dependency now.

* platform/graphics/skia/PlatformContextSkia.h: Remove platform_canvas.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, forgotten GTK pixel test results for
philn@webkit.org [Wed, 27 Jul 2011 11:22:58 +0000 (11:22 +0000)]
    Unreviewed, forgotten GTK pixel test results for
        fast/forms/input-file-re-render.html after r91833.

        * platform/gtk/fast/forms/input-file-re-render-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK pixel tests rebaseline after r91759.
philn@webkit.org [Wed, 27 Jul 2011 10:51:30 +0000 (10:51 +0000)]
    Unreviewed, GTK pixel tests rebaseline after r91759.

        * platform/gtk/fast/forms/box-shadow-override-expected.png:
        * platform/gtk/fast/forms/file-input-direction-expected.png:
        * platform/gtk/fast/forms/file-input-disabled-expected.png:
        * platform/gtk/fast/forms/form-element-geometry-expected.png:
        * platform/gtk/fast/forms/input-appearance-height-expected.png:
        * platform/gtk/fast/forms/input-value-expected.png:
        * platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Simplify the PageUIClient
benjamin.poulain@nokia.com [Wed, 27 Jul 2011 10:24:08 +0000 (10:24 +0000)]
[Qt][WK2] Simplify the PageUIClient
https://bugs.webkit.org/show_bug.cgi?id=65198

Reviewed by Andreas Kling.

The only function of WKPageLoaderClient with a complete implementation
is qt_wk_setStatusText(). The other functions were what is left from
before the refactoring of QWKPage.

This patch removes the unused functions to simplify the client. Since the dependency
on QtWebPageProxy is removed from that client, it now calls the ViewInterface directly.

* UIProcess/qt/ClientImpl.cpp:
(toViewInterface):
(qt_wk_setStatusText):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r91792.
commit-queue@webkit.org [Wed, 27 Jul 2011 10:03:00 +0000 (10:03 +0000)]
Unreviewed, rolling out r91792.
http://trac.webkit.org/changeset/91792
https://bugs.webkit.org/show_bug.cgi?id=65242

It broke NRWT on Qt and GTK (Requested by Ossy_night on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-27

* Scripts/webkitpy/layout_tests/models/test_configuration.py:
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTra...
mnaganov@chromium.org [Wed, 27 Jul 2011 10:01:51 +0000 (10:01 +0000)]
Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
https://bugs.webkit.org/show_bug.cgi?id=65213

Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoediting/selection/move-by-word-visually* tests timing out
tonyg@chromium.org [Wed, 27 Jul 2011 09:49:49 +0000 (09:49 +0000)]
editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Unreviewed build fix.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoKnob of a disabled or readonly range control should not be draggable.
commit-queue@webkit.org [Wed, 27 Jul 2011 09:15:21 +0000 (09:15 +0000)]
Knob of a disabled or readonly range control should not be draggable.
https://bugs.webkit.org/show_bug.cgi?id=54820

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

Source/WebCore:

Made disabled or readonly range control undraggable.

Test: fast/forms/range-drag.html

* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
  Added check that the element is readonly or disabled.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler): ditto.

LayoutTests:

Added tests to confirm disabled or readonly range control is undraggable.

* fast/forms/range-drag-expected.txt: Added.
* fast/forms/range-drag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: CloseEvent attribute is not available on WebWorkers in JSC
yutak@chromium.org [Wed, 27 Jul 2011 08:56:58 +0000 (08:56 +0000)]
WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
https://bugs.webkit.org/show_bug.cgi?id=65232

Reviewed by Kent Tamura.

Source/WebCore:

Add [NoStaticTables] attribute to CloseEvent interface definition. This attribute
makes the code generator obtain the attributes table used for building ClassInfo
through JSGlobalData, instead of directly using a statically-allocated table.

Generally speaking, NoStaticTables needs to be specified in interfaces which
may be accessed from workers.

Tests: http/tests/websocket/tests/hybi/workers/shared-worker-simple.html (updated)
       http/tests/websocket/tests/hybi/workers/worker-simple.html (updated)

* websockets/CloseEvent.idl: Fixed the formatting, too.

LayoutTests:

* http/tests/websocket/tests/hybi/workers/resources/worker-simple.js:
(runTests): Check the value of closeEvent.wasClean.
* http/tests/websocket/tests/hybi/workers/shared-worker-simple-expected.txt:
* http/tests/websocket/tests/hybi/workers/worker-simple-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT speculation failure code performs incorrect conversions in
commit-queue@webkit.org [Wed, 27 Jul 2011 07:12:38 +0000 (07:12 +0000)]
DFG JIT speculation failure code performs incorrect conversions in
the case where two registers need to be swapped.
https://bugs.webkit.org/show_bug.cgi?id=65233

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-27
Reviewed by Gavin Barraclough.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::GeneralizedRegister::swapWith):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoreduce and reduceRight bind callback's this to null rather than undefined
commit-queue@webkit.org [Wed, 27 Jul 2011 06:02:54 +0000 (06:02 +0000)]
reduce and reduceRight bind callback's this to null rather than undefined
https://bugs.webkit.org/show_bug.cgi?id=62264

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Fixed Array.prototype.reduce and Array.prototype.reduceRight so that they behave correctly
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

LayoutTests:

Added additional tests to test Array.prototype.reduce and Array.prototype.reduceRight
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

* fast/js/array-reduce-expected.txt:
* fast/js/array-reduceRight-expected.txt:
* fast/js/script-tests/array-reduce.js:
* fast/js/script-tests/array-reduceRight.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] REGRESSION(90963): Content layers are not redrawn after losing the composi...
commit-queue@webkit.org [Wed, 27 Jul 2011 03:48:27 +0000 (03:48 +0000)]
[chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
https://bugs.webkit.org/show_bug.cgi?id=65224

Patch by James Robinson <jamesr@chromium.org> on 2011-07-26
Reviewed by Kenneth Russell.

There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
page and kill the GPU process.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::cleanupResources):
* platform/graphics/chromium/ContentLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r91805.
commit-queue@webkit.org [Wed, 27 Jul 2011 03:42:22 +0000 (03:42 +0000)]
Unreviewed, rolling out r91805.
http://trac.webkit.org/changeset/91805
https://bugs.webkit.org/show_bug.cgi?id=65226

Breaks @ symbols and changes other font rendering on Windows
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):
* platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r91812.
enne@google.com [Wed, 27 Jul 2011 03:18:22 +0000 (03:18 +0000)]
Unreviewed, rolling out r91812.
http://trac.webkit.org/changeset/91812
https://bugs.webkit.org/show_bug.cgi?id=65210

Breaks OSX GPU tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix ChangeLog.
abarth@webkit.org [Wed, 27 Jul 2011 03:05:42 +0000 (03:05 +0000)]
Fix ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoenne tells me that she already rebaselined this test. The 10.5 bot is
abarth@webkit.org [Wed, 27 Jul 2011 03:01:10 +0000 (03:01 +0000)]
enne tells me that she already rebaselined this test.  The 10.5 bot is
just behind because dglazkov broke NRWT on Python 2.5.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch to an older idiom that works on Python 2.5.
abarth@webkit.org [Wed, 27 Jul 2011 02:59:50 +0000 (02:59 +0000)]
Switch to an older idiom that works on Python 2.5.

* Scripts/webkitpy/layout_tests/models/test_configuration.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC command-line tool does not come with any facility for
commit-queue@webkit.org [Wed, 27 Jul 2011 02:56:25 +0000 (02:56 +0000)]
JSC command-line tool does not come with any facility for
measuring time precisely.
https://bugs.webkit.org/show_bug.cgi?id=65223

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

Exposed WTF::currentTime() as currentTimePrecise().

* jsc.cpp:
(GlobalObject::GlobalObject):
(functionPreciseTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r91809.
commit-queue@webkit.org [Wed, 27 Jul 2011 02:48:04 +0000 (02:48 +0000)]
Unreviewed, rolling out r91809.
http://trac.webkit.org/changeset/91809
https://bugs.webkit.org/show_bug.cgi?id=65225

Does not build on Chromium Windows (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
* dom/WheelEvent.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::resetGestureRecognizer):
* page/EventHandler.h:
* page/FrameView.cpp:
(WebCore::FrameView::reset):
* platform/PlatformGestureEvent.h:
* platform/PlatformGestureRecognizer.h:
* platform/chromium/FramelessScrollView.h:
* platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
(WebCore::InnerGestureRecognizer::processTouchEventForGesture):
(WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
* platform/chromium/GestureRecognizerChromium.h:
(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::processTouchEventForGesture):
* platform/chromium/PopupMenuChromium.cpp:
* platform/chromium/PopupMenuChromium.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleGestureEvent):

Source/WebKit/chromium:

* features.gypi:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix pointer operator coding style in ewk_view.
gyuyoung.kim@samsung.com [Wed, 27 Jul 2011 02:45:32 +0000 (02:45 +0000)]
[EFL] Fix pointer operator coding style in ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=65163

Move '*' operator to variable according to efl coding style. In addition,
add a space between * and variable in type casting.

Reviewed by Kent Tamura.

* ewk/ewk_view.cpp:
(_ewk_view_smart_changed):
(_ewk_view_repaints_resize):
(_ewk_view_repaint_add):
(_ewk_view_repaints_flush):
(_ewk_view_scrolls_resize):
(_ewk_view_scroll_add):
(_ewk_view_scrolls_flush):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_core_frame_new):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_calculate):
(_ewk_view_smart_contents_resize):
(_ewk_view_smart_zoom_set):
(_ewk_view_smart_flush):
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_zoom_animated_mark_stop):
(_ewk_view_zoom_animated_finish):
(_ewk_view_zoom_animated_current):
(_ewk_view_zoom_animator_cb):
(_ewk_view_zoom_animation_start):
(_ewk_view_viewport_attributes_compute):
(ewk_view_base_smart_set):
(ewk_view_fixed_layout_size_set):
(ewk_view_fixed_layout_size_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_frame_main_get):
(ewk_view_frame_focused_get):
(ewk_view_uri_set):
(ewk_view_uri_get):
(ewk_view_title_get):
(ewk_view_editable_get):
(ewk_view_bg_color_set):
(ewk_view_bg_color_get):
(ewk_view_text_search):
(ewk_view_text_matches_mark):
(ewk_view_text_matches_unmark_all):
(ewk_view_text_matches_highlight_set):
(ewk_view_text_matches_highlight_get):
(ewk_view_editable_set):
(ewk_view_selection_get):
(_ewk_view_editor_command):
(ewk_view_execute_editor_command):
(ewk_view_context_menu_forward_event):
(ewk_view_load_progress_get):
(ewk_view_stop):
(ewk_view_reload):
(ewk_view_reload_full):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_navigate):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_navigate_possible):
(ewk_view_history_enable_get):
(ewk_view_history_enable_set):
(ewk_view_history_get):
(ewk_view_zoom_get):
(ewk_view_zoom_set):
(ewk_view_zoom_weak_smooth_scale_get):
(ewk_view_zoom_weak_smooth_scale_set):
(ewk_view_zoom_weak_set):
(ewk_view_zoom_animated_mark_start):
(ewk_view_zoom_animated_mark_end):
(ewk_view_zoom_animated_mark_current):
(ewk_view_zoom_animated_mark_stop):
(ewk_view_zoom_animated_set):
(ewk_view_zoom_text_only_get):
(ewk_view_zoom_text_only_set):
(ewk_view_pre_render_region):
(ewk_view_pre_render_relative_radius):
(ewk_view_pre_render_cancel):
(ewk_view_setting_user_agent_get):
(ewk_view_setting_user_agent_set):
(ewk_view_setting_user_stylesheet_get):
(ewk_view_setting_user_stylesheet_set):
(ewk_view_setting_auto_load_images_get):
(ewk_view_setting_auto_load_images_set):
(ewk_view_setting_auto_shrink_images_get):
(ewk_view_setting_auto_shrink_images_set):
(ewk_view_setting_enable_auto_resize_window_get):
(ewk_view_setting_enable_auto_resize_window_set):
(ewk_view_setting_enable_scripts_get):
(ewk_view_setting_enable_scripts_set):
(ewk_view_setting_enable_plugins_get):
(ewk_view_setting_enable_plugins_set):
(ewk_view_setting_enable_frame_flattening_get):
(ewk_view_setting_enable_frame_flattening_set):
(ewk_view_setting_scripts_window_open_get):
(ewk_view_setting_scripts_window_open_set):
(ewk_view_setting_resizable_textareas_get):
(ewk_view_setting_resizable_textareas_set):
(ewk_view_setting_private_browsing_get):
(ewk_view_setting_private_browsing_set):
(ewk_view_setting_offline_app_cache_get):
(ewk_view_setting_offline_app_cache_set):
(ewk_view_setting_caret_browsing_get):
(ewk_view_setting_caret_browsing_set):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_setting_encoding_default_get):
(ewk_view_setting_encoding_default_set):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_encoding_detector_get):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_enable_developer_extras_set):
(ewk_view_setting_font_minimum_size_get):
(ewk_view_setting_font_minimum_size_set):
(ewk_view_setting_font_minimum_logical_size_get):
(ewk_view_setting_font_minimum_logical_size_set):
(ewk_view_setting_font_default_size_get):
(ewk_view_setting_font_default_size_set):
(ewk_view_setting_font_monospace_size_get):
(ewk_view_setting_font_monospace_size_set):
(ewk_view_setting_font_standard_get):
(ewk_view_setting_font_standard_set):
(ewk_view_setting_font_cursive_get):
(ewk_view_setting_font_cursive_set):
(ewk_view_setting_font_fantasy_get):
(ewk_view_setting_font_fantasy_set):
(ewk_view_setting_font_monospace_get):
(ewk_view_setting_font_monospace_set):
(ewk_view_setting_font_serif_get):
(ewk_view_setting_font_serif_set):
(ewk_view_setting_font_sans_serif_get):
(ewk_view_setting_font_sans_serif_set):
(ewk_view_setting_spatial_navigation_get):
(ewk_view_setting_spatial_navigation_set):
(ewk_view_setting_local_storage_get):
(ewk_view_setting_local_storage_set):
(ewk_view_setting_page_cache_get):
(ewk_view_setting_page_cache_set):
(ewk_view_setting_local_storage_database_path_get):
(ewk_view_setting_local_storage_database_path_set):
(ewk_view_smart_data_get):
(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):
(ewk_view_repaint_add):
(ewk_view_layout_if_needed_recursive):
(ewk_view_scrolls_process):
(ewk_view_paint_context_new):
(ewk_view_paint_context_free):
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
(ewk_view_paint_context_scale):
(ewk_view_paint_context_translate):
(ewk_view_paint):
(ewk_view_paint_contents):
(ewk_view_ready):
(ewk_view_input_method_state_set):
(ewk_view_title_set):
(ewk_view_uri_changed):
(ewk_view_load_started):
(ewk_view_frame_main_load_started):
(ewk_view_load_provisional):
(ewk_view_load_show):
(ewk_view_frame_main_cleared):
(ewk_view_frame_main_icon_received):
(ewk_view_load_finished):
(ewk_view_load_error):
(ewk_view_load_progress_changed):
(ewk_view_restore_state):
(ewk_view_window_create):
(ewk_view_window_close):
(ewk_view_mouse_link_hover_in):
(ewk_view_mouse_link_hover_out):
(ewk_view_toolbars_visible_set):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_set):
(ewk_view_statusbar_visible_get):
(ewk_view_statusbar_text_set):
(ewk_view_scrollbars_visible_set):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_set):
(ewk_view_menubar_visible_get):
(ewk_view_tooltip_text_set):
(ewk_view_add_console_message):
(ewk_view_run_javascript_alert):
(ewk_view_run_javascript_confirm):
(ewk_view_run_javascript_prompt):
(ewk_view_should_interrupt_javascript):
(ewk_view_exceeded_database_quota):
(ewk_view_run_open_panel):
(ewk_view_repaint):
(ewk_view_scroll):
(ewk_view_core_page_get):
(ewk_view_frame_create):
(ewk_view_plugin_create):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(ewk_view_popup_selected_set):
(ewk_view_download_request):
(ewk_view_viewport_attributes_set):
(ewk_view_viewport_attributes_get):
(ewk_view_zoom_range_set):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_set):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_need_touch_events_set):
(ewk_view_need_touch_events_get):
(ewk_view_mode_set):
(ewk_view_mode_get):
(ewk_view_editor_client_selection_changed):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8][Chromium] Run workers in a separate v8::Isolate
dslomov@google.com [Wed, 27 Jul 2011 02:41:13 +0000 (02:41 +0000)]
[V8][Chromium] Run workers in a separate v8::Isolate
https://bugs.webkit.org/show_bug.cgi?id=65004
This patch allocates a new v8::Isolate for every worker and enters it on worker thread.

Reviewed by David Levin.

Covered by existing chromium tests.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
* bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
(WebCore::StaticDOMDataStore::~StaticDOMDataStore):
* bindings/v8/StaticDOMDataStore.h:
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::registerDOMDataStore):
(WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):
* bindings/v8/V8DOMMap.cpp:
(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
* bindings/v8/WorkerScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThis test appears to fail on Leopard only.
abarth@webkit.org [Wed, 27 Jul 2011 02:37:03 +0000 (02:37 +0000)]
This test appears to fail on Leopard only.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Avoid clearing the framebuffer when compositing in release builds
jamesr@google.com [Wed, 27 Jul 2011 02:28:07 +0000 (02:28 +0000)]
[chromium] Avoid clearing the framebuffer when compositing in release builds
https://bugs.webkit.org/show_bug.cgi?id=65210

Reviewed by Kenneth Russell.

We clear the default framebuffer to blue when compositing so it's
easier to spot regions we miss. This is useful for debugging, but eats
bandwidth unnecessarily in release builds.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew XML tokenizer
jpfau@apple.com [Wed, 27 Jul 2011 02:25:44 +0000 (02:25 +0000)]
New XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=64566

Reviewed by Adam Barth.

Add tokenizer for XML and tests in NewXMLDocumentParser for printing results of tokenization.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):
* xml/parser/NewXMLDocumentParser.h:
* xml/parser/XMLToken.h:
* xml/parser/XMLTokenizer.cpp: Added.
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::::shouldSkipNullCharacters):
(WebCore::XMLTokenizer::nextToken):
(WebCore::XMLTokenizer::bufferCharacter):
(WebCore::XMLTokenizer::parseError):
* xml/parser/XMLTokenizer.h: Added.
(WebCore::XMLTokenizer::create):
(WebCore::XMLTokenizer::gotError):
(WebCore::XMLTokenizer::shouldSkipNullCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd an exception to coding style check for EFL port.
gyuyoung.kim@samsung.com [Wed, 27 Jul 2011 02:02:38 +0000 (02:02 +0000)]
Add an exception to coding style check for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=65162

Add an exception of whitespace/declaration for EFL port. Because,
'*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

* Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Layering violations in gesture recognizer
commit-queue@webkit.org [Wed, 27 Jul 2011 01:52:19 +0000 (01:52 +0000)]
[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.
* page/EventHandler.h:
* page/FrameView.cpp:
(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.
* platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.
* platform/PlatformGestureRecognizer.h:
* platform/chromium/FramelessScrollView.h:
Added support for displatching gesture and touch events.
* platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):
* platform/chromium/GestureRecognizerChromium.h:
* platform/chromium/PopupMenuChromium.cpp:
Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
* platform/chromium/PopupMenuChromium.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

* features.gypi:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.
* src/WebPopupMenuImpl.cpp:
Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestore Composited Layers Faster from PageCache
joepeck@webkit.org [Wed, 27 Jul 2011 01:38:30 +0000 (01:38 +0000)]
Restore Composited Layers Faster from PageCache
https://bugs.webkit.org/show_bug.cgi?id=65216

Reviewed by Simon Fraser.

Restore the layer tree hierarchy a little sooner, when
restoring from the page cache. This more closely matches
original restore behavior.

Existing test showed no change.

* page/FrameView.cpp:
(WebCore::FrameView::restoreBackingStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG speculative JIT never emits inline double comparisons, even when it
commit-queue@webkit.org [Wed, 27 Jul 2011 01:27:43 +0000 (01:27 +0000)]
DFG speculative JIT never emits inline double comparisons, even when it
would be obvious more efficient to do so.
https://bugs.webkit.org/show_bug.cgi?id=65212

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This handles the obvious case of inlining double comparisons: it only addresses
the speculative JIT, and only for fused compare/branch sequences.  But it does
handle the case where both operands are double (and there is no slow path),
or where one operand is double and the other is unknown type (in which case it
attempts to unbox the double, otherwise taking slow path).  This is an 0.8%
speed-up on SunSpider.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add option to turn on disk caching in QtTestBrowser
commit-queue@webkit.org [Wed, 27 Jul 2011 01:12:50 +0000 (01:12 +0000)]
[Qt] Add option to turn on disk caching in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=65007

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2011-07-26
Reviewed by Noam Rosenthal.

Add menu item and command line option to turn on disk caching in
QtTestBrowser. Simple QNetworkDiskCache added to the page's
QNetworkAccssManager.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[skia] never draw with GDI, so that all text can be gpu-accelerated
commit-queue@webkit.org [Wed, 27 Jul 2011 01:10:04 +0000 (01:10 +0000)]
[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Patch by Mike Reed <reed@google.com> on 2011-07-26
Reviewed by Kenneth Russell.

No new tests. existing tests apply to the new drawing path

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=64969
commit-queue@webkit.org [Wed, 27 Jul 2011 00:55:33 +0000 (00:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64969
DFG JIT generates inefficient code for speculation failures.

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This implements a speculation failure strategy where (1) values spilled on
non-speculative but not spilled on speculative are spilled, (2) values that
are in registers on both paths are rearranged without ever touching memory,
and (3) values spilled on speculative but not spilled on non-speculative are
filled.

The register shuffling is the most interesting part of this patch.  It
constructs a permutation graph for registers.  Each node represents a
register, and each directed edge corresponds to the register's value having
to be moved to a different register as part of the shuffling.  This is a
directed graph where each node may only have 0 or 1 incoming edges, and
0 or 1 outgoing edges.  The algorithm then first finds maximal non-cyclic
subgraphs where all nodes in the subgraph are reachable from a start node.
Such subgraphs always resemble linked lists, and correspond to simply
moving the value in the second-to-last register into the last register, and
then moving the value in the third-to-last register into the second-to-last
register, and so on.  Once these subgraphs are taken care of, the remaining
subgraphs are cycles, and are handled using either (a) conversion or no-op
if the cycle involves one node, (b) swap if it involves two nodes, or (c)
a cyclic shuffle involving a scratch register if there are three or more
nodes.

* dfg/DFGGenerationInfo.h:
(JSC::DFG::needDataFormatConversion):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::GeneralizedRegister::GeneralizedRegister):
(JSC::DFG::GeneralizedRegister::createGPR):
(JSC::DFG::GeneralizedRegister::createFPR):
(JSC::DFG::GeneralizedRegister::dump):
(JSC::DFG::GeneralizedRegister::findInSpeculationCheck):
(JSC::DFG::GeneralizedRegister::findInEntryLocation):
(JSC::DFG::GeneralizedRegister::previousDataFormat):
(JSC::DFG::GeneralizedRegister::nextDataFormat):
(JSC::DFG::GeneralizedRegister::convert):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::ShuffledRegister):
(JSC::DFG::ShuffledRegister::isEndOfNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::ShuffledRegister::lookup):
(JSC::DFG::lookupForRegister):
(JSC::DFG::NodeToRegisterMap::Tuple::Tuple):
(JSC::DFG::NodeToRegisterMap::NodeToRegisterMap):
(JSC::DFG::NodeToRegisterMap::set):
(JSC::DFG::NodeToRegisterMap::end):
(JSC::DFG::NodeToRegisterMap::find):
(JSC::DFG::NodeToRegisterMap::clear):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::linkSpeculationChecks):
* dfg/DFGJITCompiler.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculationCheck::SpeculationCheck):
* dfg/DFGSpeculativeJIT.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFloat32Array(ArrayBuffer, index, length) constructor working incorrectly.
kbr@google.com [Wed, 27 Jul 2011 00:53:33 +0000 (00:53 +0000)]
Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=57042

Reviewed by James Robinson.

Source/WebCore:

* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferViewWithArrayBufferArgument):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):

LayoutTests:

* fast/canvas/webgl/array-unit-tests-expected.txt:
* fast/canvas/webgl/array-unit-tests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoV8 custom bindings for AudioNode must do proper object checking and throw exception...
crogers@google.com [Wed, 27 Jul 2011 00:25:06 +0000 (00:25 +0000)]
V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
https://bugs.webkit.org/show_bug.cgi?id=65222

Reviewed by James Robinson.

No new tests - this fixes upcoming audionode.html layout test

* bindings/v8/custom/V8AudioNodeCustom.cpp:
(WebCore::V8AudioNode::connectCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAudioContext is not correctly accounting for hardware resources
crogers@google.com [Wed, 27 Jul 2011 00:15:37 +0000 (00:15 +0000)]
AudioContext is not correctly accounting for hardware resources
https://bugs.webkit.org/show_bug.cgi?id=65217

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

* webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::lazyInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle CSS Properties that can be either auto or a primitive value in CSSStyleApplyPr...
macpherson@chromium.org [Wed, 27 Jul 2011 00:14:34 +0000 (00:14 +0000)]
Handle CSS Properties that can be either auto or a primitive value in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=65164

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

* css/CSSPrimitiveValueMappings.h:
Add casts to/from various numeric types.
(WebCore::CSSPrimitiveValue::operator short):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator float):
* css/CSSStyleApplyProperty.cpp:
Add class to handle properties that set an "auto" boolean on RenderStyle.
(WebCore::ApplyPropertyAuto::ApplyPropertyAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
Remove existing implementations.
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd protection space authentication callback code to CFNetwork loader on Mac
psolanki@apple.com [Tue, 26 Jul 2011 23:43:15 +0000 (23:43 +0000)]
Add protection space authentication callback code to CFNetwork loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=65190
<rdar://problem/9842424>

Reviewed by Oliver Hunt.

Port over protection space authentication callback code from ResourceHandleMac.mm to
ResourceHandleCFNet.cpp.

* platform/network/ResourceHandle.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::canRespondToProtectionSpace):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Add logging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Check in expectations for font-family-pictograph.
enne@google.com [Tue, 26 Jul 2011 23:30:52 +0000 (23:30 +0000)]
[chromium] Check in expectations for font-family-pictograph.
https://bugs.webkit.org/show_bug.cgi?id=65197

Unreviewed gardening.

* platform/chromium-linux/fast/css/font-family-pictograph-expected.png: Added.
* platform/chromium-linux/fast/css/font-family-pictograph-expected.txt: Added.
* platform/chromium-mac/fast/css/font-family-pictograph-expected.png: Added.
* platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Added.
* platform/chromium-win/fast/css/font-family-pictograph-expected.png: Added.
* platform/chromium-win/fast/css/font-family-pictograph-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for download='filename' attribute in anchors.
abarth@webkit.org [Tue, 26 Jul 2011 23:25:49 +0000 (23:25 +0000)]
Add support for download='filename' attribute in anchors.
https://bugs.webkit.org/show_bug.cgi?id=64580

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

The download attribute allows the author of the hyperlink to cause the
browser to download the linked URL.  The author can also supply a
suggested file name in the attribute value.  This feature is a recent
addition to HTML to better support offline applications that use blob
URLs.  Traditionally, web sites use the HTTP Content-Disposition header
to trigger downloads, but that option isn't available when working
offline.

There is some question about whether we should initiate a download when
we receive a DOM-created click event.  This patch does initiate the
download, but we might revise that decision in the future as part of a
larger change in how WebKit treats the interaction between default
event handlers and DOM-created events.

Tests: fast/dom/HTMLAnchorElement/anchor-download.html
       fast/dom/HTMLAnchorElement/anchor-nodownload.html
       fast/dom/HTMLAnchorElement/anchor-download-unset.html
       fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::handleClick):
* html/HTMLAnchorElement.h:
* html/HTMLAnchorElement.idl:
* html/HTMLAttributeNames.in:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::startDownload):
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

* features.gypi:
* public/WebFrameClient.h:
(WebKit::WebFrameClient::loadURLExternally):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientImpl::startDownload):
* src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::startDownload):
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::startDownload):
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::startDownload):
* WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::startDownload):
* WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::startDownload):
* WebFrame.h:

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::startDownload):
* WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::startDownload):
* WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::startDownload):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::loadURLExternally):
* DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

* fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
* fast/dom/HTMLAnchorElement/anchor-download.html: Added.
* fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
* fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
* fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
* fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
* fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
* fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark webaudio/test-basic as crashing on Windows.
enne@google.com [Tue, 26 Jul 2011 23:18:32 +0000 (23:18 +0000)]
[chromium] Mark webaudio/test-basic as crashing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=65219.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuffer overflow creating error messages for JSON.parse
oliver@apple.com [Tue, 26 Jul 2011 22:47:32 +0000 (22:47 +0000)]
Buffer overflow creating error messages for JSON.parse
https://bugs.webkit.org/show_bug.cgi?id=65211

Reviewed by Darin Adler.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Update testcase to reflect actual expected output.

* fast/js/JSON-parse-expected.txt:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Parse string length to the UString constructor.

* runtime/LiteralParser.cpp:
(JSC::LiteralParser::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber-stamped by Anders Carlsson.
mitz@apple.com [Tue, 26 Jul 2011 22:23:16 +0000 (22:23 +0000)]
Rubber-stamped by Anders Carlsson.

Update DumpRenderTree and API tests for the pictograph font family preference.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoApply r40940 to WebKit2 to work around a Silverlight crash.
commit-queue@webkit.org [Tue, 26 Jul 2011 22:08:28 +0000 (22:08 +0000)]
Apply r40940 to WebKit2 to work around a Silverlight crash.
https://bugs.webkit.org/show_bug.cgi?id=65205
<rdar://problem/9058370>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-26
Reviewed by Anders Carlsson.

* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
* Shared/Plugins/PluginQuirks.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::userAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace SpecificityCalculator with TestConfiguration-driven logic.
dglazkov@chromium.org [Tue, 26 Jul 2011 22:07:23 +0000 (22:07 +0000)]
Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
* Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
    test configuration matching, removed a bunch of code.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
    was created. 'default' is not a valid build type.
* Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncrease the information density in garden-o-matic
abarth@webkit.org [Tue, 26 Jul 2011 22:04:52 +0000 (22:04 +0000)]
Increase the information density in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65141

Reviewed by Dimitri Glazkov.

This patch changes lets us show each revision on a single line,
allowing use to show an entire day's worth of commits at once.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor automatically generated JS DOM bindings to replace operator new with static...
commit-queue@webkit.org [Tue, 26 Jul 2011 21:56:13 +0000 (21:56 +0000)]
Refactor automatically generated JS DOM bindings to replace operator new with static create methods
https://bugs.webkit.org/show_bug.cgi?id=64732

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Replacing the public constructors in the automatically generated JS DOM bindings with static
create methods.  JSByteArray is used by several of these bindings in WebCore.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::create):
* runtime/JSByteArray.h:

Source/WebCore:

No new tests.

Replacing the public constructors in the automatically generated JS DOM bindings in CodeGeneratorJS.pm
with static create methods.  This is part of a larger refactoring effort to use static create methods
in the headers of the generated files (so as to be inline-able) in favor of public constructors throughout JSC.

* bindings/js/JSAudioConstructor.h:
(WebCore::JSAudioConstructor::create):
* bindings/js/JSDOMBinding.h:
(WebCore::createWrapper):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::create):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSOptionConstructor.h:
(WebCore::JSOptionConstructor::create):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForTypeInImpl):
(AddIncludesForTypeInHeader):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterface::createPrototype):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListener::createPrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObj::createPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterface::createPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
* bridge/jni/jsc/JavaArrayJSC.cpp:
(JavaArray::convertJObjectToArray):
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::newRuntimeObject):
* bridge/objc/objc_utility.mm:
(JSC::Bindings::convertObjcValueToValue):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
* bridge/runtime_array.h:
(JSC::RuntimeArray::create):
* bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCancel the load when an associated URL loader goes out of scope.
brettw@chromium.org [Tue, 26 Jul 2011 21:52:50 +0000 (21:52 +0000)]
Cancel the load when an associated URL loader goes out of scope.
Previously, the load would continue even when the WebURLLoader object
was deleted, and the data would just get queued up.

https://bugs.webkit.org/show_bug.cgi?id=65204

Reviewed by Darin Fisher.

* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago--webkit-visual-word does not work in multi-line
xji@chromium.org [Tue, 26 Jul 2011 21:51:17 +0000 (21:51 +0000)]
--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace Position(node, offset, PositionIsOffsetInAnchor) with
createPositionAvoidingIgnoredNode(node, offset) which takes care of creating position
before/after <br/> etc. editingIgnoresContent node.

When iterate InlineBox, replace prevLeafChild and nextLeafChild (which only returns
InlineBox within the same line) with leftInlineBox and rightInlineBox (which returns
InlineBox across multiple lines).

* editing/htmlediting.cpp:
(WebCore::createPositionAvoidingIgnoredNode):
* editing/htmlediting.h:
* editing/visible_units.cpp:
(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Replace Position() with
createPositionAvoidingIgnoredNode().
(WebCore::leftmostPositionInRTLBoxInLTRBlock): Ditto.
(WebCore::rightmostPositionInLTRBoxInRTLBlock): Ditto.
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): Ditto.
(WebCore::blockWithPreviousLineBox): Added.
(WebCore::previousRootInlineBox): Added.
(WebCore::blockWithNextLineBox): Added.
(WebCore::nextRootInlineBox): Added.
(WebCore::leftInlineBox): Added.
(WebCore::rightInlineBox): Added.
(WebCore::leftWordBoundary): Replace prevLeafChild/nextLeafChild with leftInlineBox()
and rightInlineBox().
(WebCore::rightWordBoundary): Ditto.
(WebCore::leftWordPositionAcrossBoundary): Ditto.
(WebCore::rightWordPositionAcrossBoundary): Ditto.

LayoutTests:

Add test for multiple-line.

* editing/selection/move-by-word-visually-null-box.html:
* editing/selection/move-by-word-visually-others-expected.txt:
* editing/selection/move-by-word-visually-others.html: Add tests for multi-line. Shorten
test id.
* editing/selection/move-by-word-visually-single-space-sigle-line.html: Shorten test id.
* editing/selection/resources/move-by-word-visually.js:
(moveByWordForEveryPosition):
(setWidth):
(runMoveLeftRight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix for Qt/Linux.
alexis.menard@openbossa.org [Tue, 26 Jul 2011 21:49:03 +0000 (21:49 +0000)]
Unreviewed build fix for Qt/Linux.

On platforms with no glib and gstreamer we should not build javascriptcore
with the Glib support. This is related to http://trac.webkit.org/changeset/91752.

* wtf/wtf.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTestConfigurationConverter should not barf on invalid specifiers.
dglazkov@chromium.org [Tue, 26 Jul 2011 21:44:28 +0000 (21:44 +0000)]
TestConfigurationConverter should not barf on invalid specifiers.
https://bugs.webkit.org/show_bug.cgi?id=65194

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
    made it return empty set whenever an invalid specifier is encountered.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce a way to convert between specifier lists and TestConfiguration sets.
dglazkov@chromium.org [Tue, 26 Jul 2011 21:42:29 +0000 (21:42 +0000)]
Introduce a way to convert between specifier lists and TestConfiguration sets.
https://bugs.webkit.org/show_bug.cgi?id=65094

Add TestConfigurationConverter, a facility to convert:
1) a set of specifiers into a set of TestConfiguration instances;
2) a set of TestConfiguration instances into a list of sets of specifiers.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
commit-queue@webkit.org [Tue, 26 Jul 2011 21:17:14 +0000 (21:17 +0000)]
CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
https://bugs.webkit.org/show_bug.cgi?id=65171

Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-26
Reviewed by Adam Roben.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=60778
hyatt@apple.com [Tue, 26 Jul 2011 20:39:25 +0000 (20:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60778

Use after free because of line box culling optimization regression.

In the case of a child with no line box being removed (typically
a <br> in quirks mode), if there is no previous sibling with a line
box, then we have a potential problem with the culling optimization.

The culled inline may still have other leaf line box children, but
they may follow the removed <br>. In this case we can't rely on
them, since we need a line box that comes before the <br>.

The fix is to simply recur up to the parent if we are a culled inline
and could not find a previous line box.

Reviewed by Dan Bernstein.

Added editing/execCommand/crash-line-break-after-outdent.html

Source/WebCore:

* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

LayoutTests:

* editing/execCommand/crash-line-break-after-outdent-expected.txt: Added.
* editing/execCommand/crash-line-break-after-outdent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd first basic layout test for the web audio API
crogers@google.com [Tue, 26 Jul 2011 20:36:25 +0000 (20:36 +0000)]
Add first basic layout test for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=57977

Reviewed by Tony Chang.

* webaudio: Added.
* webaudio/resources: Added.
* webaudio/resources/audio-testing.js: Added.
(writeString):
(writeInt16):
(writeInt32):
(writeAudioBuffer):
(createWaveFileData):
(createAudioData):
(finishAudioTest):
* webaudio/test-basic-expected.wav: Added.
* webaudio/test-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid outputting #EOF twice for web audio tests in chromium DRT
crogers@google.com [Tue, 26 Jul 2011 20:28:15 +0000 (20:28 +0000)]
Avoid outputting #EOF twice for web audio tests in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=65201

Reviewed by Dirk Pranke.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix change log typos
mitz@apple.com [Tue, 26 Jul 2011 20:27:55 +0000 (20:27 +0000)]
Fix change log typos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: <rdar://problem/9842889> Add a generic pictograph font family Add...
mitz@apple.com [Tue, 26 Jul 2011 20:23:50 +0000 (20:23 +0000)]
Source/WebCore: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

Test: fast/css/font-family-pictograph.html

* WebCore.exp.in: Export Settings::setPictographFontFamily().
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::identifierForFamily): Added -webkit-pictograph.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::fontDataForGenericFamily): Ditto.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Ditto.
* css/CSSValueKeywords.in:
* inspector/front-end/CSSKeywordCompletions.js: Ditto.
* inspector/front-end/SourceCSSTokenizer.js: Ditto.
(WebInspector.SourceCSSTokenizer):
* inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
* page/Settings.cpp:
(WebCore::Settings::pictographFontFamily): Added this getter.
(WebCore::Settings::setPictographFontFamily): Added this setter.
* page/Settings.h:
* platform/graphics/FontDescription.h: Added PictographFamily to the GenericFamilyType enum.

Source/WebKit/mac: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

* WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set the default pictograph font family to
"Apple Color Emoji".
(-[WebPreferences pictographFontFamily]): Added this getter.
(-[WebPreferences setPictographFontFamily:]): Added this setter.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Pass the preference through to WebCore.

Source/WebKit/win: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

* Interfaces/IWebPreferences.idl: Added pictographFontFamily() and
setPictographFontFamily().
* WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize the pictograph font
preference to "Times New Roman".
(WebPreferences::pictographFontFamily): Added this getter.
(WebPreferences::setPictographFontFamily): Added this setter.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Pass the preference value through to
WebCore.

Source/WebKit2: <rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPictographFontFamily): Added.
(WKPreferencesCopyPictographFontFamily): Added.
* UIProcess/API/C/WKPreferences.h:

LayoutTests: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

* fast/css/font-family-pictograph.html: Added.
* platform/mac/fast/css/font-family-pictograph-expected.png: Added.
* platform/mac/fast/css/font-family-pictograph-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] getClientRects now fails similarly on Mac after r91763.
enne@google.com [Tue, 26 Jul 2011 19:48:37 +0000 (19:48 +0000)]
[chromium] getClientRects now fails similarly on Mac after r91763.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove (i.e., speed up) .gyp(i) files for Chromium
commit-queue@webkit.org [Tue, 26 Jul 2011 19:37:01 +0000 (19:37 +0000)]
Improve (i.e., speed up) .gyp(i) files for Chromium
https://bugs.webkit.org/show_bug.cgi?id=65032

Patch by Viet-Trung Luu <viettrungluu@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

This re-applies r91595 with the source exclusion fixed.

Test by building (in all supported configurations).

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91774 268f45cc-cd09-0410-ab3c-d52691b4dbfc