2009-03-17  Darin Adler  <darin@apple.com>

        Reviewed by David Hyatt.

        Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
        https://bugs.webkit.org/show_bug.cgi?id=24517

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since
        determining whether to display the delete button involves style and updateRendering
        also updates style (should probably be named updateStyle, in fact). Not needed to fix
        this bug, but would have prevented the crash that led to this bug in the first place.

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have
        delete button controllers.
        * editing/Editor.cpp:
        (WebCore::Editor::rangeForPoint): Ditto.

        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup
        doesn't depend on renderers at all when the convertBlocksToInlines boolean is false.
        This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the
        createMarkup function that's called by innerHTML.
        (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member
        function. Added a feature where the accumulator will skip a node. Moved arguments
        that don't change during recursion into an object. This function still is a bit
        inefficient, since it creates a new HashMap at every level as it recurses, but for now
        I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly
        for consistency and clarity.
        (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets.
        Instead of calling disable/enable on the delete button controller's container element,
        pass it in to the markup accumulator as a node to skip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Simon Fraser.

        Fix the usage of the $architecture variable for non-Apple-Mac
        ports.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24651
        Skia does not always render text fill/stroke pattern/gradient/color correctly

        Changes Skia's font rendering to only render gradient/pattern if current
        color space indicates the gradient/pattern should be used.
        This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::strokeColorSpace):
        (WebCore::GraphicsContext::fillColorSpace):
        * platform/graphics/GraphicsContext.h:
        (WebCore::):
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::paintSkiaText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2009-03-17  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
        <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

        Test: editing/inserting/6633727.html

        This changes does a few things:
        1) Renames pos to insertionPosition.
        2) Eliminates "startNode".  It doesn't work well to consider the node separately from the insertionPosition.
           The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
        3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
           representation of the insertionPosition, so all ancestor nodes are correctly included.

        * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

2009-03-17  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=24655
        <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

        * editing/inserting/6633727.html: Added.
        * platform/mac/editing/inserting/6633727-expected.checksum: Added.
        * platform/mac/editing/inserting/6633727-expected.png: Added.
        * platform/mac/editing/inserting/6633727-expected.txt: Added.

        Updated results.  The behavior for these tests doesn't change, but the render tree is slightly different.

        * platform/mac/editing/inserting/insert-div-021-expected.txt:
        * platform/mac/editing/style/block-styles-007-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the build.

* Plugins/Hosted/HostedNetscapePluginStream.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Kevin Ollivier.

https://bugs.webkit.org/show_bug.cgi?id=24115
Introduce platform independent stubs for plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version string)

        <https://bugs.webkit.org/show_bug.cgi?id=24645>

        Reviewed by Mark Rowe.

        * Scripts/bisect-builds:
        (makeNightlyList): Added checks for Safari 4 Public Beta on
        Tiger and Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixed ChangeLog date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Use -[NSURLResponse(WebCoreURLResponse) _webcore_MIMEType] consistently

        Reviewed by Darin Adler.

        WebKit r30323 added -_webcore_MIMEType to fix issues with
        incorrect MIME types in NS[HTTP]URLResponse objects.  However,
        uses of -[NSURLResponse MIMEType] still persist in WebKit that
        should be switched to use -_webcore_MIMEType.  Note that
        -[WebDataSource _responseMIMEType] calls back into WebCore to
        get the MIME type from the ResourceResponse object, which has
        already retrieved it via -_webcore_MIMEType.

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::didReceiveResponse): Use
        -_webcore_MIMEType.
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::didReceiveResponse): Ditto.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView pluginView:receivedData:]): Ditto.
        * Plugins/WebPluginController.mm:
        (-[WebPluginController pluginView:receivedResponse:]): Ditto.
        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation _isDisplayingWebArchive]): Use
        -[WebDataSource _responseMIMEType] instead.
        * WebView/WebPDFRepresentation.m:
        (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Ditto.
        * WebView/WebPDFView.mm:
        (-[WebPDFView menuForEvent:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24632

        Fix repaint issues when composited layers come and go (only applies
        when ACCELERATED_COMPOSITING is turned on).

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::mustOverlayCompositedLayers):
        (WebCore::RenderLayer::setMustOverlayCompositedLayers):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::RenderLayerBacking):
        * rendering/RenderLayerBacking.h:

        Move what used to be the 'forceCompositingLayer' flag from RenderLayerBacking
        to RenderLayer, because we don't want the side-effects of creating RenderLayerBacking
        when setting this flag.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateLayerCompositingState):
        When a RenderLayer flips into or out of compositing mode, compute a repaint
        rect relative to the containerForRepaint, and repaint it.

        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
        Call layer->setMustOverlayCompositedLayers() rather than setForcedCompositingLayer().

        (WebCore::RenderLayerCompositor::needsToBeComposited):
        (WebCore::RenderLayerCompositor::requiresCompositingLayer):
        (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
        (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
        * rendering/RenderLayerCompositor.h:

        Rename requiresCompositingLayerForTransform() to requiresCompositingForTransform()
        and make it a class static method to match requiresCompositingForAnimation(). Both
        now take RenderObjects, rathern than RenderLayers.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::hasTransformRelatedProperty):
        Minor tidyup using convenience methods added in an earlier commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Darin Adler  <darin@apple.com>

        Earlier version reviewed by Adele Peterson.

        Bug 24304: REGRESSION (r39864): Hitting the space bar to select an <input type=radio>
        or push an <input type=button> or <button> causes the page to scroll down.

        Would be best to add a regression test for Windows eventually; tested that this has
        no effect on the Mac OS X platform.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler): Added FIXMEs and tweaked formatting.
        Use the code that calls the base class's defaultEventHandler early only in the cases
        where it's needed: keydown and keypress events in text fields. In other cases, do the
        more typical thing and call the default handler only at the end of the function.
        This function already had code to make sure the keypress event for space never gets
        through, but it was running too late since the scrolling code was moved into the
        base class default event handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24396

        * config.h:
        Add WTF_USE_ACCELERATED_COMPOSITING, defined to 0 for now, and add some
        comments to make the #ifdefs more readable.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::computedTransform):
        Add a comment to mention that we don't flatten the matrix.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::transform_3dMediaFeatureEval):
        Have the 'transform-3d' media query evaluate to 'true' if 3d-rendering
        is supported.

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::animateTransform):
        No need for the #ifdef here. If we don't support 3d, we will have already flattened
        the matrix.

        * platform/graphics/transforms/TransformationMatrix.cpp:
        (WebCore::TransformationMatrix::makeAffine):
        * platform/graphics/transforms/TransformationMatrix.h:
        New method to convert the matrix to an affine matrix by throwing a way the non-affine
        parts.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::currentTransform):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateLayerTransform):
        If 3d rendering is not supported, convert the matrix to an affine matrix
        which can be rendered, and used for hit testing.

        * rendering/RenderLayerCompositor.cpp:
        Change the name of the exported symbol that webkitdirs.pm uses to know if
        3d rendering is supported. There is no other 3d-rendering-specific symbol we can sniff.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::transformFromContainer):
        Only take perspective into account if 3d rendering is supported.

        * rendering/RenderObject.h:
        (WebCore::makeMatrixRenderable):
        Utility method that flattens a matrix if 3d rendering is not supported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

wx build fix. Fix typo after mouse wheel changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Update failing layout test after float painting fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Darin Adler  <darin@apple.com>

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::isEqual): Fix build, remove stray parenthesis.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Mark Rowe.

        Enable HTML5 media elements support by default in the GTK+ port.

        * configure.ac:

WebKitTools:

2009-03-17  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Mark Rowe.

        Enable HTML5 media elements support by default also for the GTK+
        port.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Darin Adler  <darin@apple.com>

        Fix crash seen right away when running run-webkit-tests.

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::isEqual): Restore assertion to its behavior pre-refactoring.
        Also tweaked formatting a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        HTMLSelectElement::add() doesn't look at exception code returned from insertBefore(), so
        it doesn't need to zero it out before calling.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): Removed "ec = 0" line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Adam Roben.

        - WebCore part of adding a mechanism for controlling the caching of
          responses through WebFrameLoaderClient

        Mac already has such a mechanism, and this adds one for CFNetwork ports.

        * WebCore.vcproj/WebCore.vcproj: Added EmptyClients.h
        and ResourceLoaderCFNet.cpp.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::shouldCacheResponse): Added an
        implementation that always returns true.

        * loader/FrameLoaderClient.h: Declared shouldCacheResponse().

        * loader/ResourceLoader.h: Ditto.

        * loader/cf/ResourceLoaderCFNet.cpp: Added.
        (WebCore::ResourceLoader::shouldCacheResponse): Added. Calls through to
        FrameLoaderClient::shouldCacheResponse().

        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::shouldCacheResponse): Added an
        implementation that always returns true.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willCacheResponse): Added a call to
        ResourceHandleClient::shouldCacheResponse(). If the client returns
        false, return 0, which will prevent CFNetwork from caching the response.

WebKit/win:

        Reviewed by Adam Roben.

        - WebKit part of adding a mechanism for controlling the caching of
          responses through WebFrameLoaderClient

        * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added the
        IWebResourceLoadDelegatePrivate3 interface, containing the new
        delegate method shouldCacheResponse().

        * Interfaces/IWebURLRequest.idl: Added the isEqual() method.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::shouldCacheResponse): Implemented this new
        FrameLoaderDelegate method by calling through to the resource load
        delegate, if it implements shouldCacheResponse(), and returning true
        otherwise.

        * WebCoreSupport/WebFrameLoaderClient.h:

        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::isEqual): Added.
        (WebMutableURLRequest::setValue): Implemented.

        * WebMutableURLRequest.h: Declared isEqual().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=13287
        Cannot change SELECT to a dynamically created option

        Tests: fast/forms/add-and-remove-option.html
               fast/forms/add-remove-option-modification-event.html
               fast/forms/add-selected-option.html
               fast/forms/select-cache-desynchronization.html

        * dom/ContainerNode.cpp:
        (WebCore::dispatchChildInsertionEvents): Increment DOM tree version. This will happen when
        dispatching DOMSubtreeModified again, but the version should be incremented for event
        listeners to have an up to date view of the DOM.
        (WebCore::dispatchChildRemovalEvents): Ditto.

        * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoTree):
        Make sure that the select element knows about its new selected option.

        * html/HTMLOptionElement.h: Use insertedIntoTree() instead of insertedIntoDocument(),
        because DOM also needs to be updated for forms that are not in document yet. Similar
        problems exist for node removing, but removedFromTree() is called at a wrong time, so
        those problems cannot be fixed without deeper refactoring.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setRecalcListItems): Reset m_activeSelectionAnchorIndex - it
        doesn't make sense to keep the anchor after programmatically changing the selection, and
        keeping it was causing a failure in fast/forms/listbox-selection.html.

        * html/HTMLSelectElement.h: Removed overrides for ContainerNode methods that only called
        base class versions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    <rdar://problem/6690324> Accessing FTP sites reads unallocated memory, can result in garbled entries or crashes

        Reviewed by Darin Adler.

        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Assign CString to a local while we hold pointers into it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix ChangeLog comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2009-03-16  David Hyatt  <hyatt@apple.com>

        <rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/

        Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
        layers that don't paint themselves.  This is done by adding a new boolean parameter to enclosingLayer
        so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
        themselves.

        Reviewed by Darin Adler.

        Added fast/block/float/overlapping-floats-with-overflow-hidden.html

        * WebCore.base.exp:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addOverhangingFloats):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::enclosingSelfPaintingLayer):
        * rendering/RenderObject.h:

LayoutTests:

2009-03-16  David Hyatt  <hyatt@apple.com>

        <rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/

        Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
        layers that don't paint themselves.  This is done by adding a new enclosingSelfPaintingLayer method
        so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
        themselves.

        Reviewed by Darin Adler.

        * fast/block/float/overlapping-floats-with-overflow-hidden.html: Added.
        * platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.checksum: Added.
        * platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png: Added.
        * platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24592
        [GTK] Crash in FcPatternHash

        Style fixes.

        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
        (WebCore::FontPlatformData::operator=):
        * platform/graphics/gtk/FontPlatformDataPango.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24592
        [GTK] Crash in FcPatternHash

        Sanitize memory management in pango fonts.

        Release memory allocated by FontPlatformDataPango in its own
        destructor instead of doing it from other classes, and add copy
        constructor and '=' operator to be able to track referenced
        objects properly.

        * platform/graphics/gtk/FontPlatformDataPango.cpp:
        (WebCore::FontPlatformData::~FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2009-03-17  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
        seen with inspector, which uses adoptNode
        https://bugs.webkit.org/show_bug.cgi?id=24624
        rdar://problem/6422850

        Test: fast/dom/HTMLImageElement/image-load-cross-document.html

        * dom/Document.cpp:
        (WebCore::Document::Document): Removed m_imageLoadEventTimer.
        (WebCore::Document::detach): Removed m_imageLoadEventDispatchSoonList and
        m_imageLoadEventDispatchingList.
        (WebCore::Document::implicitClose): Called ImageLoader::dispatchPendingLoadEvents
        instead of dispatchImageLoadEventsNow.

        * dom/Document.h: Removed ImageLoader, dispatchImageLoadEventSoon,
        dispatchImageLoadEventsNow, removeImage, m_imageLoadEventDispatchSoonList,
        m_imageLoadEventDispatchingList, m_imageLoadEventTimer, and imageLoadEventTimerFired.

        * loader/ImageLoader.cpp:
        (WebCore::loadEventSender): Added. Returns the single global ImageLoadEventSender
        object used privately as the target of the load event timer.
        (WebCore::ImageLoader::~ImageLoader): Call ImageLoadEventSender::cancelLoadEvent
        rather than Document::removeImage.
        (WebCore::ImageLoader::setImage): Use m_element directly, not element().
        (WebCore::ImageLoader::updateFromElement): Ditto. Also name the local variable
        document instead of doc.
        (WebCore::ImageLoader::notifyFinished): Call ImageLoadEventSender::dispatchLoadEventSoon
        rather than Document::dispatchImageLoadEventSoon.
        (WebCore::ImageLoader::dispatchPendingLoadEvent): Added. Handles the common logic
        about when load events can be dispatched so that dispatchLoadEvent only has to
        have the specific part for each derived class. This includes a check that the
        document is attached, which used to be handled by having documents empty out the
        image load event vectors in the detach function.
        (WebCore::ImageLoader::dispatchPendingLoadEvents): Added. Calls the appropriate
        function on the ImageLoadEventSender, which avoids the need to have that class be
        public in the ImageLoader header.
        (WebCore::ImageLoadEventSender::ImageLoadEventSender): Added. Has the code that
        was previously in the Document constructor.
        (WebCore::ImageLoadEventSender::dispatchLoadEventSoon): Added. Has the code that
        was previously in Document::dispatchImageLoadEventSoon.
        (WebCore::ImageLoadEventSender::cancelLoadEvent): Added. Has the code that was
        previously in Document::removeImage.
        (WebCore::ImageLoadEventSender::dispatchPendingLoadEvents): Added. Has the code
        that was previously in Document::dispatchImageLoadEventsNow.
        (WebCore::ImageLoadEventSender::timerFired): Added. Calls dispatchPendingLoadEvents.

        * loader/ImageLoader.h: Improved comments. Made the virtual functions private
        or protected rather than public. Added static dispatchPendingLoadEvents function
        for use by Document and private dispatchPendingLoadEvent function for use by
        ImageLoadEventSender. Made setLoadingImage private and eliminated
        setHaveFiredLoadEvent since that can all be done inside the class without any
        member functions.

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::dispatchLoadEvent): Removed logic to check whether a
        load event already fired and whether image() is 0. These are now both base class
        responsibilities.
        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::dispatchLoadEvent): Ditto.
        * wml/WMLImageLoader.cpp:
        (WebCore::WMLImageLoader::dispatchLoadEvent): Ditto.

LayoutTests:

2009-03-17  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
        seen with inspector, which uses adoptNode
        https://bugs.webkit.org/show_bug.cgi?id=24624
        rdar://problem/6422850

        This test has one significant disadvantage. When it fails, the crash typically
        occurs during a subsequent test, not this one. It would be great if someone figured
        out at some point how to improve that.

        * fast/dom/HTMLImageElement/image-load-cross-document-expected.txt: Added.
        * fast/dom/HTMLImageElement/image-load-cross-document.html: Added.
        * fast/dom/HTMLImageElement/resources/image-load-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24623
        Refactor ConsoleMessage to use ScriptFuncitonCall and eliminate JSC
        dependencies.

        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument): Added uint and ScriptString-taking methods.
        * bindings/js/ScriptFunctionCall.h:
        * bindings/js/ScriptObjectQuarantine.cpp:
        (WebCore::quarantineValue): Added generic ScriptValue quarantine helper.
        * bindings/js/ScriptObjectQuarantine.h:
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::isEqual): Added.
        * bindings/js/ScriptValue.h:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToConsole): Added.
        (WebCore::ConsoleMessage::isEqual): Changed to use ScriptValue::isEqual.
        * inspector/ConsoleMessage.h:
        (WebCore::ConsoleMessage::incrementCount): Added.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addConsoleMessage): Changed to use ConsoleMessage::addToConsole.
        (WebCore::InspectorController::populateScriptObjects): Ditto.
        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Mark Rowe.

Move BUILDING_ON_* defines into Platform.h to make them available to other ports.
Also tweak the defines so that they work with the default values set by
AvailabilityMacros.h.

https://bugs.webkit.org/show_bug.cgi?id=24630

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Mike Hommey <glandium@debian.org>

        Reviewed by Holger Freyther.

        Do not export cti* symbols.
        See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=519924.

        * autotools/symbols.filter:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24592
        [GTK] Crash in FcPatternHash

        Sanitize memory management in gtk fonts.

        Release memory allocated by FontPlatformDataGtk in its own
        destructor instead of doing it from other classes, and add copy
        constructor and '=' operator to be able to track referenced
        objects properly.

        * platform/graphics/gtk/FontPlatformData.h:
        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-17  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Build fix for Qt < 4.5.

        As reported by Yael Aharon  <yael.aharon@nokia.com>

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix coverage builds

Reviewed by Alexey Proskuryakov

Make coverage testing more reliable by ensuring --coverage does not
clobber configuration settings, and by removing the unnecessary
dependency on matplotlib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=24614
        Access control checks are different in cached and uncached cases

        Test: http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html

        * loader/CrossOriginAccessControl.cpp:
        (WebCore::isOnAccessControlSimpleRequestMethodWhitelist): Factored out simple method
        check for use in both cached and uncached cases. In cached case, an old definition that
        omitted HEAD was still used.
        (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Check that content type has an
        allowed value. This is needed in all call sites. Also changed to compare MIME type, not
        content type.
        (WebCore::isSimpleCrossOriginAccessRequest): Use the above methods.

        * loader/CrossOriginAccessControl.h: Expose isOnAccessControlSimpleRequestMethodWhitelist.

        * loader/CrossOriginPreflightResultCache.cpp:
        (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
        (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
        Use the new checks for simple method and header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24638
        [GTK] HTML5 media tags do not work

        Remove the blacklisting of the media/ directory, now that we have
        a working MediaPlayer; skip only the tests that are still failing
        because MediaPlayerPrivateGStreamer is not completely implemented.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24638
        [GTK] HTML5 media tags do not work

        Add a repaint-requested signal to the video sink, and use it to
        call MediaPlayerPrivate::repaint, so that the video actually
        plays.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateRepaintCallback):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_idle_func):
        (webkit_video_sink_render):
        (webkit_video_sink_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24638
        [GTK] HTML5 media tags do not work

        Work-around the fact that gst_element_query_duration returns true even
        though it is unable to figure out the duration when in stream (push)
        mode.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::duration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Skip media tests that are currently failing.

Rubber-stamped by Adele Peterson.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/6642742> Top Sites malfunction when switching text zoom mode

        * page/Frame.cpp:
        (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is
        currently showing a non-HTML view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Skip a test that is currently crashing.

Rubber-stamped by Beth Dakin.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Update test results for six accessibility tests.

Rubber-stamped by Beth Dakin.

* platform/mac/accessibility/lists-expected.txt:
* platform/mac/accessibility/table-attributes-expected.txt:
* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/accessibility/table-sections-expected.txt:
* platform/mac/accessibility/table-with-aria-role-expected.txt:
* platform/mac/accessibility/table-with-rules-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Move platform-specific acessibility tests and results into platform/mac.

Rubber-stamped by Beth Dakin.

* platform/mac/accessibility/accesskey-expected.txt: Renamed from LayoutTests/accessibility/accesskey-expected.txt.
* platform/mac/accessibility/accesskey.html: Renamed from LayoutTests/accessibility/accesskey.html.
* platform/mac/accessibility/aria-describedby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-describedby-on-input-expected.txt.
* platform/mac/accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-on-input-expected.txt.
* platform/mac/accessibility/aria-range-expected.txt: Renamed from LayoutTests/accessibility/aria-range-expected.txt.
* platform/mac/accessibility/aria-range-value-expected.txt: Renamed from LayoutTests/accessibility/aria-range-value-expected.txt.
* platform/mac/accessibility/aria-range-value.html: Renamed from LayoutTests/accessibility/aria-range-value.html.
* platform/mac/accessibility/aria-range.html: Renamed from LayoutTests/accessibility/aria-range.html.
* platform/mac/accessibility/aria-roles-expected.txt: Renamed from LayoutTests/accessibility/aria-roles-expected.txt.
* platform/mac/accessibility/aria-slider-expected.txt: Renamed from LayoutTests/accessibility/aria-slider-expected.txt.
* platform/mac/accessibility/aria-slider.html: Renamed from LayoutTests/accessibility/aria-slider.html.
* platform/mac/accessibility/aria-spinbutton-expected.txt: Renamed from LayoutTests/accessibility/aria-spinbutton-expected.txt.
* platform/mac/accessibility/aria-spinbutton.html: Renamed from LayoutTests/accessibility/aria-spinbutton.html.
* platform/mac/accessibility/bounds-for-range-expected.txt: Renamed from LayoutTests/accessibility/bounds-for-range-expected.txt.
* platform/mac/accessibility/bounds-for-range.html: Renamed from LayoutTests/accessibility/bounds-for-range.html.
* platform/mac/accessibility/content-editable-expected.txt: Renamed from LayoutTests/accessibility/content-editable-expected.txt.
* platform/mac/accessibility/content-editable.html: Renamed from LayoutTests/accessibility/content-editable.html.
* platform/mac/accessibility/document-attributes-expected.txt: Renamed from LayoutTests/accessibility/document-attributes-expected.txt.
* platform/mac/accessibility/document-attributes.html: Renamed from LayoutTests/accessibility/document-attributes.html.
* platform/mac/accessibility/document-links-expected.txt: Renamed from LayoutTests/accessibility/document-links-expected.txt.
* platform/mac/accessibility/document-links.html: Renamed from LayoutTests/accessibility/document-links.html.
* platform/mac/accessibility/double-title-expected.txt: Renamed from LayoutTests/accessibility/double-title-expected.txt.
* platform/mac/accessibility/double-title.html: Renamed from LayoutTests/accessibility/double-title.html.
* platform/mac/accessibility/frame-with-title-expected.txt: Renamed from LayoutTests/accessibility/frame-with-title-expected.txt.
* platform/mac/accessibility/frame-with-title.html: Renamed from LayoutTests/accessibility/frame-with-title.html.
* platform/mac/accessibility/image-map1-expected.txt: Renamed from LayoutTests/accessibility/image-map1-expected.txt.
* platform/mac/accessibility/image-map2-expected.txt: Renamed from LayoutTests/accessibility/image-map2-expected.txt.
* platform/mac/accessibility/input-image-url-expected.txt: Renamed from LayoutTests/accessibility/input-image-url-expected.txt.
* platform/mac/accessibility/input-image-url.html: Renamed from LayoutTests/accessibility/input-image-url.html.
* platform/mac/accessibility/internal-link-anchors-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors-expected.txt.
* platform/mac/accessibility/internal-link-anchors.html: Renamed from LayoutTests/accessibility/internal-link-anchors.html.
* platform/mac/accessibility/internal-link-anchors2-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors2-expected.txt.
* platform/mac/accessibility/legend-expected.txt: Renamed from LayoutTests/accessibility/legend-expected.txt.
* platform/mac/accessibility/plugin-expected.txt: Renamed from LayoutTests/accessibility/plugin-expected.txt.
* platform/mac/accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/radio-button-group-members-expected.txt.
* platform/mac/accessibility/resources/cake.png: Copied from LayoutTests/accessibility/resources/cake.png.
* platform/mac/accessibility/resources/test.swf: Renamed from LayoutTests/accessibility/resources/test.swf.
* platform/mac/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/accessibility/table-one-cell-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        * English.lproj/Localizable.strings: Updated.
        * StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/mac:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory contextMenuItemTagParagraphDirectionMenu]): Changed string here, but only
        post-Leopard, since we want this to match the Mac OS X menu on Tiger and Leopard.
        (-[WebViewFactory contextMenuItemTagSelectionDirectionMenu]): Changed string here.

WebKit/win:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

        For now, change only the localized strings, not the terminology in the code.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here.
        (WebCore::contextMenuItemTagTextDirectionMenu): And here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24629: moving forward or backward a paragraph fails at edge of document
        https://bugs.webkit.org/show_bug.cgi?id=24629
        rdar://problem/6544413

        Test: editing/selection/move-paragraph-document-edges.html

        * editing/visible_units.cpp:
        (WebCore::previousParagraphPosition): Use the last result from
        previousLinePosition rather than going all the way back to what was originally
        passed in when we hit exception cases like null or not moving. This correctly
        inherits the behavior of previousLinePosition when we are in a paragraph at the
        edge of a document.
        (WebCore::nextParagraphPosition): Ditto.

LayoutTests:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24629: moving forward or backward a paragraph fails at edge of document
        https://bugs.webkit.org/show_bug.cgi?id=24629
        rdar://problem/6544413

        * editing/selection/move-paragraph-document-edges-expected.txt: Added.
        * editing/selection/move-paragraph-document-edges.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
        https://bugs.webkit.org/show_bug.cgi?id=24619

        * rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
        * rendering/RenderView.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Adam Roben.

        [gtk] API implementation: url and title
        http://bugs.webkit.org/show_bug.cgi?id=14807

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h: Implement "title" and "uri" properties as well
        as according functions. "uri" always reflects the current location
        including navigation inside the same page. title-changed is deprecated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Peter Kasting  <pkasting@google.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24368
        DOM scroll events should be based off the actual number of wheel
        ticks, not off the number of lines scrolled.  This matches IE.

        * dom/Node.cpp:
        (WebCore::Node::dispatchWheelEvent):
        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        * dom/WheelEvent.h:
        (WebCore::WheelEvent::create):
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::wheelTicksX):
        (WebCore::PlatformWheelEvent::wheelTicksY):
        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/qt/WheelEventQt.cpp:
        * platform/win/WheelEventWin.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/wx/MouseWheelEventWx.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Clean up a few issues in the Animation code:

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine):
        Whitespace

        (WebCore::AnimationBase::willNeedService):
        Don't round to float, use std::max

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        Fix erroneously copied line to null out m_lastResponseWaiter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Don't mig_deallocate random data in case an instance proxy method returns false.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        (WKPCInvokeDefault):
        (WKPCGetProperty):
        (WKPCEnumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler and John Sullivan.

        When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
        Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.

        Instead, just zero out the member variable in invalidate.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (pluginInvalidate):
        (pluginDeallocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2009-03-12  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=13632

        Overflow scrolling needs to account for the bottom/right padding on the object itself as well
        as for bottom/right margins on children.

        Existing tests cover this.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):

LayoutTests:

2009-03-16  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=13632

        Overflow scrolling needs to account for the bottom/right padding on the object itself as well
        as for bottom/right margins on children.

        * platform/mac/fast/body-propagation/overflow/002-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/002-expected.png:
        * platform/mac/fast/body-propagation/overflow/002-expected.txt:
        * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt:
        * platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
        * platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt:
        * platform/mac/fast/body-propagation/overflow/003-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/003-expected.png:
        * platform/mac/fast/body-propagation/overflow/003-expected.txt:
        * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt:
        * platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
        * platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt:
        * platform/mac/fast/body-propagation/overflow/004-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/004-expected.png:
        * platform/mac/fast/body-propagation/overflow/004-expected.txt:
        * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt:
        * platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
        * platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt:
        * platform/mac/fast/body-propagation/overflow/007-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/007-expected.png:
        * platform/mac/fast/body-propagation/overflow/007-expected.txt:
        * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt:
        * platform/mac/fast/forms/basic-textareas-expected.txt:
        * platform/mac/fast/forms/input-disabled-color-expected.txt:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
        * platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
        * platform/mac/fast/overflow/003-expected.checksum:
        * platform/mac/fast/overflow/003-expected.png:
        * platform/mac/fast/overflow/003-expected.txt:
        * platform/mac/fast/overflow/004-expected.checksum:
        * platform/mac/fast/overflow/004-expected.png:
        * platform/mac/fast/overflow/007-expected.checksum:
        * platform/mac/fast/overflow/007-expected.png:
        * platform/mac/fast/overflow/007-expected.txt:
        * platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
        * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
        * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
        * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt:
        * platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
        * platform/mac/fast/replaced/width100percent-textarea-expected.png:
        * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
        * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2009-03-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix for <rdar://problem/6320555>
        Add an upper limit for setting HTMLSelectElement.length.

        Test: fast/forms/select-max-length.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setOption):
        (WebCore::HTMLSelectElement::setLength):

LayoutTests:

2009-03-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Test for <rdar://problem/6320555>
        Add an upper limit for setting HTMLSelectElement.length.

        * fast/forms/select-max-length-expected.txt: Added.
        * fast/forms/select-max-length.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Sam Weinig.

        REGRESSION: undo-iframe-location-change.html is failing on the buildbots
        https://bugs.webkit.org/show_bug.cgi?id=24626

        Added a call to [[webview undoManager] removeAllActions]
        to make sure anything left on the undo stack after one test
        will not affect any later test.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6633944>
        REGRESSION (Safari 4 PB): Many crashes in Flip4Mac involving loading the plugin

        Defer loading while calling webPlugInInitialize since it can end up spinning the run loop.

        * Plugins/WebPluginController.mm:
        (-[WebPluginController addPlugin:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Add IWebFramePrivate::isDisplayingStandaloneImage

        This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
        uses.

        Reviewed by Darin Adler.

        * Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.

        * WebFrame.cpp:
        (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our
        Document is an image document.

        * WebFrame.h: Added isDisplayingStandaloneImage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6686721> Media document crash in 64-bit WebKit

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when
        rendering inline with old versions of QuickTime, so don't look for it when we are in a
        media document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Pamela Greene  <pam@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove test dependency on precise window location and size. It's not
        clear to me why these vary, but they're not what the test is checking,
        so it need not depend on them in any case.
        https://bugs.webkit.org/show_bug.cgi?id=24170

        * fast/dom/Window/window-lookup-precedence-expected.txt:
        * fast/dom/Window/window-lookup-precedence.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fix <rdar://problem/6622601>

        Make sure to update both the window frame and the plug-in frame.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView addWindowObservers]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24590
        Refactor InspectorDOMStorageResource to use ScriptFunctionCall.

        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
        * bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
        * bindings/js/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject): Added Storage helper.
        * bindings/js/ScriptObjectQuarantine.h: Ditto.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects): Changed to use bind method.
        (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method.
        (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
        * inspector/InspectorController.h: Removed add/remove methods for DOM storage.
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
        (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added.
        (WebCore::InspectorDOMStorageResource::bind): Added.
        (WebCore::InspectorDOMStorageResource::unbind): Added.
        * inspector/InspectorDOMStorageResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-16   Mike Belshe  <mike@belse.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24580
        Fix query() to match KURL behavior, this time with the code that
        compiles.

        * platform/KURLGoogle.cpp:
        (WebCore::KURL::query): Fix copy/paste mistake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=21752
        REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it

        Test: fast/dom/Window/window-early-properties-xhr.html

        For some transitions, the Window object is not replaced, but Document is. When this happened,
        window.document property was updated, but references to Document kept in cached constructors
        were not.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        (WebCore::JSAudioConstructor::document):
        (WebCore::JSAudioConstructor::mark):
        * bindings/js/JSAudioConstructor.h:
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        (WebCore::JSImageConstructor::document):
        (WebCore::JSImageConstructor::mark):
        * bindings/js/JSImageConstructor.h:
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
        (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
        (WebCore::JSMessageChannelConstructor::mark):
        * bindings/js/JSMessageChannelConstructor.h:
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        (WebCore::JSOptionConstructor::document):
        (WebCore::JSOptionConstructor::mark):
        * bindings/js/JSOptionConstructor.h:
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
        (WebCore::JSXMLHttpRequestConstructor::mark):
        * bindings/js/JSXMLHttpRequestConstructor.h:
        Changed cached constructors to keep a reference to Window, not Document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24549
        Impose a limit on Access-Control-Max-Age value

        * loader/CrossOriginPreflightResultCache.cpp:
        (WebCore::CrossOriginPreflightResultCacheItem::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by David Kilzer.

        <rdar://problem/6668875> Normalize Geolocation results

        * platform/mac/GeolocationServiceMac.mm:
        (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by David Kilzer.

        Update ::toString format as suggested by Darin Adler.

        * page/Geoposition.cpp:
        (WebCore::Geoposition::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Simon Fraser  <simon.fraser@apple.com>

        Revert r41718 because it broke DumpRenderTree on Tiger.

        * JavaScriptCorePrefix.h:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

        Reviewed by Darin Adler.

        Yet another case where we would trigger extended encoding loading needlessly.

        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::encodingForFormSubmission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Simon Fraser  <simon.fraser@apple.com>

        Build fix: no review.

        * rendering/style/ContentData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Bug 24542: Improve ContentData encapsulation

        <https://bugs.webkit.org/show_bug.cgi?id=24542>

        Reviewed by Simon Fraser.

        No tests since there is no change in behavior.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject): Used getter methods
        instead of data members on ContentData class.  Used isImage()
        convenience method.
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.

        * rendering/style/ContentData.cpp:
        (WebCore::ContentData::clear): Extracted code into
        deleteContent() method.
        (WebCore::ContentData::dataEquivalent): Added.  Extracted code
        from StyleRareNonInheritedData::contentDataEquivalent().
        (WebCore::ContentData::deleteContent): Added.  Used by setter
        methods.
        * rendering/style/ContentData.h: Made m_type, m_content and
        m_next private.
        (WebCore::ContentData::isCounter): Added.
        (WebCore::ContentData::isImage): Added.
        (WebCore::ContentData::isNone): Added.
        (WebCore::ContentData::isText): Added.
        (WebCore::ContentData::type): Added.
        (WebCore::ContentData::dataEquivalent): Added.
        (WebCore::ContentData::image): Added.
        (WebCore::ContentData::setImage): Added.
        (WebCore::ContentData::text): Added.
        (WebCore::ContentData::setText): Added.
        (WebCore::ContentData::counter): Added.
        (WebCore::ContentData::setCounter): Added.
        (WebCore::ContentData::next): Added.
        (WebCore::ContentData::setNext): Added.

        * rendering/style/CounterContent.h:
        (WebCore::operator!=): Removed.
        (WebCore::operator==): Renamed operator!=() and reversed its
        logic after extracting code from
        StyleRareNonInheritedData::contentDataEquivalent() to create
        ContentData::dataEquivalent().

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setContent): Used new getters and setters
        on ContentData class.  Changed first argument from a StringImpl*
        to a PassRefPtr<StrimgImpl>.  Used isText() convenience method.
        * rendering/style/RenderStyle.h:
        (WebCore::RenderStyle::setContent): Updated declaration.
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::contentDataEquivalent):
        Extracted most logic in while() loop into
        ContentData::dataEquivalent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Xan Lopez  <xlopez@igalia.com>

        Bump version to 1.1.3 for release and fix soversion
        calculation (oops). Thanks to Frederik Himpe for pointing this
        out.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Mark Rowe.

        * config.ini: fix my blog's feed address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Anders Carlsson.

        Fix default policy decision to be ignore, on MIME checks, if
        WebKit doesn't know how to handle the MIME type. The documentation
        is already correct, and this was an oversight when the policy
        decision code was first committed. Since 1.1.2 will be the first
        release to support download, there is no practical change in
        behavior.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=24602
        [Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

        Reintroduce the URI into the soup message after having set it in
        the KURL, on redirects, to make sure it is properly encoded. This
        fixes bad request problems when servers give bad URIs on their
        response's Location header.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
Platform.h so that they're defined for all ports building on Mac, and tweak
the definitions of those macros based on Mark Rowe's suggestions to accomodate
cases where the values may not be <= to the .0 release for that version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-15  Xan Lopez  <xlopez@igalia.com>

        Bump version and libtool version for release.

        * configure.ac:

WebKit/gtk:

2009-03-15  Xan Lopez  <xlopez@igalia.com>

        * NEWS: update for 1.1.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Committing LayoutTests/editing/selection/5354455-2.html that was supposed to be in previous check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19737
        No cursor and paste not enabled right clicking text field/area

        Test: fast/events/right-click-focus.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::handleMousePressEvent):
        Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Suggested by Mark Rowe.

        Move results for security/block-test.html to their correct locations. Results for other
        platforms will need to be generated.

        * platform/mac-leopard/security/block-test-expected.txt: Removed.
        * platform/mac-tiger/security: Added.
        * platform/mac-tiger/security/block-test-expected.txt: Copied from LayoutTests/security/block-test-expected.txt.
        * platform/mac/security: Added.
        * platform/mac/security/block-test-expected.txt: Copied from LayoutTests/platform/mac-leopard/security/block-test-expected.txt.
        * security/block-test-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=23949
        HTMLSelectElement is in inconsistent state when handling mutation events

        Test: fast/forms/mutation-event-recalc.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::appendChild):
        Call childrenChanged() before dispatching modification events, not after.

        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::insertBefore):
        (WebCore::HTMLOptGroupElement::replaceChild):
        (WebCore::HTMLOptGroupElement::removeChild):
        (WebCore::HTMLOptGroupElement::appendChild):
        (WebCore::HTMLOptGroupElement::removeChildren):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::add):
        (WebCore::HTMLSelectElement::remove):
        (WebCore::HTMLSelectElement::insertBefore):
        (WebCore::HTMLSelectElement::replaceChild):
        (WebCore::HTMLSelectElement::removeChild):
        (WebCore::HTMLSelectElement::appendChild):
        (WebCore::HTMLSelectElement::removeChildren):
        Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events
        were already dispatched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Adele Peterson.

        - fix <rdar://problem/6607773> WebKit should support the "Default"
          paragraph writing direction -- or at least validate the menu item
          appropriately

        Made WebHTMLView validate user interface items with the selector
        -makeBaseWritingDirectionNatural: by returning NO and, if the item is
        a menu item, setting its state to "off".

        Strictly speaking, since -makeBaseWritingDirectionNatural: is never
        valid for WebViews, WebHTMLView should not need to respond to it and
        validate it, however because other responders respond to all three
        -makeBaseWritingDirection*: messages and set the menu item state, having
        WebHTMLView do the same makes application developers' lives easier.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView makeBaseWritingDirectionNatural:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Add svn:executable property to recently added cgi scripts.

        * http/tests/xmlhttprequest/resources/access-control-basic-options-not-supported.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Skip two tests that are failing.

Rubber-stamped by Dan Bernstein.

* platform/mac-snowleopard/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-14  Greg Bolsinga  <bolsinga@apple.com>

        <rdar://problem/6683465>

        Geolocation has to be able to handle NULL Frames.

        Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-14  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by David Kilzer.

        Geoposition::toString was missing the Coordinates after the update.

        * page/Geoposition.cpp:
        (WebCore::Geoposition::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-14  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        [Gtk] Build fix - pass a Coordinate to Geoposition::create
        https://bugs.webkit.org/show_bug.cgi?id=24603

        Gtk build fix per r41650
        https://bugs.webkit.org/show_bug.cgi?id=24506
        Geolocation in Safari differs from the spec, no Coordinates attribute on Position

        Pass a Coordinate to Geoposition::create.

        * platform/gtk/GeolocationServiceGtk.cpp:
        (WebCore::GeolocationServiceGtk::updatePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-14  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [GTK] use of confirm dialog (yes/no) causes segfault
        https://bugs.webkit.org/show_bug.cgi?id=20940

        Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
        OBJECT,STRING,POINTER

        * webkit/webkitwebview.cpp:
        * webkitmarshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-14  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        Remove two now working tests from GTK's Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-14  Xan Lopez  <xlopez@igalia.com>

        No review, build fix.

        Split clean rules to make distcheck pass.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Update layout test results to accommodate slight changes in error messages in the latest version of libxml2.

Rubber-stamped by Oliver Hunt.

* fast/dom/getElementsByClassName/011-expected.txt:
* fast/parser/external-entities-expected.txt:
* platform/mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Copied from LayoutTests/fast/dom/getElementsByClassName/011-expected.txt.
* platform/mac-leopard/fast/invalid/missing-end-tag-expected.checksum: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.checksum.
* platform/mac-leopard/fast/invalid/missing-end-tag-expected.png: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.png.
* platform/mac-leopard/fast/invalid/missing-end-tag-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.txt.
* platform/mac-leopard/fast/parser/external-entities-expected.txt: Copied from LayoutTests/fast/parser/external-entities-expected.txt.
* platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.checksum: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum.
* platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png.
* platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt.
* platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.checksum: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum.
* platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
* platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
* platform/mac-leopard/svg/custom/junk-data-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.checksum.
* platform/mac-leopard/svg/custom/junk-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.png.
* platform/mac-leopard/svg/custom/junk-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.txt.
* platform/mac-leopard/svg/custom/missing-xlink-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.checksum.
* platform/mac-leopard/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
* platform/mac-leopard/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
* platform/mac-leopard/svg/hixie/error/012-expected.checksum: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.checksum.
* platform/mac-leopard/svg/hixie/error/012-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.png.
* platform/mac-leopard/svg/hixie/error/012-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.txt.
* platform/mac/fast/invalid/missing-end-tag-expected.checksum:
* platform/mac/fast/invalid/missing-end-tag-expected.png:
* platform/mac/fast/invalid/missing-end-tag-expected.txt:
* platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum:
* platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
* platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
* platform/mac/svg/custom/junk-data-expected.checksum:
* platform/mac/svg/custom/junk-data-expected.png:
* platform/mac/svg/custom/junk-data-expected.txt:
* platform/mac/svg/custom/missing-xlink-expected.checksum:
* platform/mac/svg/custom/missing-xlink-expected.png:
* platform/mac/svg/custom/missing-xlink-expected.txt:
* platform/mac/svg/hixie/error/012-expected.checksum:
* platform/mac/svg/hixie/error/012-expected.png:
* platform/mac/svg/hixie/error/012-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Change the layout test result search policy for Mac OS X to fit better with the idea of
newer OS versions improving on previous OS versions.

Reviewed by Dan Bernstein.

The results for the latest version of Mac OS X are placed in the "mac" directory.  The
results for older versions of Mac OS X are structured as a series of overlays.  When
running on Leopard, the results in "mac-leopard" are searched before those in "mac".
When running on Tiger, the results in "mac-tiger" are searched before those in
"mac-leopard" and "mac".

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24545
        Make cross-site XHR simple request definition match current spec draft

        Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html
               http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html

        * loader/CrossOriginAccessControl.cpp:
        (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language.
        (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those
        that could be sent via form submission.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=15172
        object fallback - empty string for first argument of setAttributeNS does not work like null

        https://bugs.webkit.org/show_bug.cgi?id=24548
        createElementNS("", name) should create an element in null namespace

        Tests: fast/dom/createElementNS-empty-namespace.html
               fast/dom/setAttributeNS-empty-namespace.html

        * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
        Convert empty namespaces to null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24591
        Add my blog to Planet WebKit

        Add my blog to the planet.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Take advantage of the ability of recent versions of Xcode to easily switch the active
architecture.

Rubber-stamped by Dan Bernstein.

* Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove rarely used Makefile targets from the Makefile.

There are many situations in which the targets don't work as expected,
and their primary use is addressed by having the build system default
to building the appropriate architecture.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.

Reviewed by Timothy Hatcher.

The scripts will automatically target 64-bit if the system and hardware support it.  This can be
overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
to make the override persistent.

* Scripts/build-webkit: Remove architecture-related code.
* Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
* Scripts/run-javascriptcore-tests: Remove architecture-related code.
* Scripts/run-safari: Ditto.
* Scripts/run-webkit-tests: Ditto.
* Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments.  The --32-bit argument will set the
architecture preference to the 32-bit architecture of the machine.  The --64-bit argument will remove any architecture
override that is in effect so that 64-bit support will be automatically detected.
* Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the
auto-detection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
switching between building in Xcode and via build-webkit.

Reviewed by David Kilzer.

build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
Derived Sources build settings.  When building in Xcode, this setting isn't present so
Xcode reruns the script build phases.  This results in a new version of TracingDtrace.h
being generated, and the files that include it being rebuilt.

* JavaScriptCore.xcodeproj/project.pbxproj:  Don't regenerate TracingDtrace.h if it is
already newer than the input file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-13  John Abd-El-Malek  <jam@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24593
        Added requestorID so we can track the request to its WebView without using frame (which was removed).

        * platform/network/chromium/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::requestorID):
        (WebCore::ResourceRequest::setRequestorID):
        (WebCore::ResourceRequest::setTargetType):
        (WebCore::ResourceRequest::policyURL):
        (WebCore::ResourceRequest::setPolicyURL):
        (WebCore::ResourceRequest::requestorPid):
        (WebCore::ResourceRequest::setRequestorPid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-13  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24561
        Add custom V8 bindings for HTMLElementCanvas, Location.

        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
        * bindings/v8/custom/V8LocationCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-13  Stephen White  <senorblanco@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24584

        Fix transparent text rendering on Chromium.  FontChromiumWin
        was calling beginTransparencyLayer()/endTransparencyLayer(), with
        a TransparencyWin inside to do GDI ClearType rendering over an
        opaque background.  TransparencyWin does its special sauce
        in the destructor, but it was being called too late to be used
        correctly in the layer.  Put the special sauce into a new function,
        composite(), and call that explicitly instead.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::~TransparencyWin):
        (WebCore::TransparencyWin::composite):
        (WebCore::TransparencyWin::init):
        * platform/graphics/chromium/TransparencyWin.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-13  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24562
        Add custom implementation for getCSSCanvasContext to V8 bindings.

        * bindings/v8/custom/V8DocumentCustom.cpp: Added new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-03-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Add tests for various types of textareas. Tests in both
        quirks and standards modes. Although only the standards
        modes tests fit in the pixel results.
        https://bugs.webkit.org/show_bug.cgi?id=24370

        * fast/forms/basic-textareas.html: Added.
        * platform/mac/fast/forms/basic-textareas-expected.checksum: Added.
        * platform/mac/fast/forms/basic-textareas-expected.png: Added.
        * platform/mac/fast/forms/basic-textareas-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41690 268f45cc-cd09-0410-ab3c-d52691b4dbfc