WebKit-https.git
9 years ago2011-06-27 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 27 Jun 2011 08:07:18 +0000 (08:07 +0000)]
2011-06-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
        https://bugs.webkit.org/show_bug.cgi?id=63427

        ~WebViewHost() navigates to about:blank, so it calls some
        callbacks and LayoutTestController functions.

        * DumpRenderTree/chromium/TestShell.h:
         Move m_printer upper and move m_webViewHost lower.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 08:04:51 +0000 (08:04 +0000)]
2011-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move server config files to webkitpy.layout_tests.servers
        https://bugs.webkit.org/show_bug.cgi?id=63436

        The config files belong with the servers.

        * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
        * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
        * Scripts/webkitpy/layout_tests/servers/http_server.py:
        * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
        * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 KwangHyuk Kim <hyuki.kim@samsung.com>
commit-queue@webkit.org [Mon, 27 Jun 2011 08:01:50 +0000 (08:01 +0000)]
2011-06-27  KwangHyuk Kim  <hyuki.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Remove dead code related with Ewk_Tiled_Backing_Store_Item's update field.
        https://bugs.webkit.org/show_bug.cgi?id=62967

        As some code do not affect any logical flow of tiled backing store except condition check,
        I would like to clean dead code related with Ewk_Tiled_Backing_Store_Item's update field
        and Ewk_Tiled_Backing_Store_Data's queue field

        * ewk/ewk_tiled_backing_store.c:
        (_ewk_tiled_backing_store_item_process_idler_cb):
        (_ewk_tiled_backing_store_item_fill):
        (_ewk_tiled_backing_store_item_add):
        (_ewk_tiled_backing_store_item_del):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] SVG animation pause API missing
ossy@webkit.org [Mon, 27 Jun 2011 07:59:48 +0000 (07:59 +0000)]
[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

* platform/mac-wk2/Skipped: Skip a new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 07:59:06 +0000 (07:59 +0000)]
2011-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move websocket_server and http_server to webkitpy.layout_package.servers
        https://bugs.webkit.org/show_bug.cgi?id=63434

        These classes do not represent ports.  They represent servers.

        * Scripts/new-run-webkit-httpd:
        * Scripts/new-run-webkit-websocketserver:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
        * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
        * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
        * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
        * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
        * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 27 Jun 2011 07:54:12 +0000 (07:54 +0000)]
2011-06-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=63428

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Add platform specific expected results after r89745.
ossy@webkit.org [Mon, 27 Jun 2011 07:46:10 +0000 (07:46 +0000)]
[Qt] Unreviewed gardening. Add platform specific expected results after r89745.

* platform/qt/Skipped: Revert accidentally committed (r89732) changes.
* platform/qt/svg/custom/linking-a-03-b-all-expected.png:
* platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 07:43:36 +0000 (07:43 +0000)]
2011-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move apache_http_server.py to webkitpy.layout_package.servers
        https://bugs.webkit.org/show_bug.cgi?id=63433

        The apache_http_server.py is a server, not a port.

        * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/servers: Added.
        * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 07:34:49 +0000 (07:34 +0000)]
2011-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
        https://bugs.webkit.org/show_bug.cgi?id=63432

        This code isn't in the dependency cone of new-run-webkit-tests. It's
        unclear what it's final home should be, but this patch moves it out of
        layout_tests to simply the package.

        * Scripts/rebaseline-chromium-webkit-tests:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
        * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 07:20:11 +0000 (07:20 +0000)]
2011-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
        https://bugs.webkit.org/show_bug.cgi?id=63429

        This package as nothing to do with the layout_tests package.

        * Scripts/update-webgl-conformance-tests:
        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
        * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
        * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 27 Jun 2011 07:11:42 +0000 (07:11 +0000)]
2011-06-27  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Add useHixie76WebSocketProtocol to WebSettings
        https://bugs.webkit.org/show_bug.cgi?id=63424

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setHixie76WebSocketProtocolEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 07:10:00 +0000 (07:10 +0000)]
2011-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move deduplicate_tests.py into webkitpy.to_be_moved
        https://bugs.webkit.org/show_bug.cgi?id=63426

        deduplicate_tests.py doesn't haven anything to do with layout tests.
        It's really a separate script.  This patch moves it to the (new)
        to_be_moved package so that it doesn't distract us when working on NRWT.

        * Scripts/deduplicate-tests:
        * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
        * Scripts/webkitpy/test/main.py:
        * Scripts/webkitpy/to_be_moved: Added.
        * Scripts/webkitpy/to_be_moved/__init__.py: Added.
        * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
        * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a separate file name for Lion's WebKitSystemInterface.
mrowe@apple.com [Mon, 27 Jun 2011 06:50:04 +0000 (06:50 +0000)]
Use a separate file name for Lion's WebKitSystemInterface.

Reviewed by Dan Bernstein.

Source/WebKit/mac:

* Configurations/DebugRelease.xcconfig:

Source/WebKit2:

* Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 06:49:16 +0000 (06:49 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove LegacyDefaultOptionalArguments from WebAudio IDL files
        https://bugs.webkit.org/show_bug.cgi?id=63416

        WebAudio isn't that widely used, so it's seems somewhat safe to remove
        legacy code generation hacks.  I'm not an expert on WebAudio, but the
        API doesn't appear to need many optional arguments.

        There are a bunch of APIs that have custom bindings that look like they
        could be autogenerated.  I've added FIXME comments where appropriate.

        * webaudio/AudioBuffer.idl:
        * webaudio/AudioContext.idl:
        * webaudio/AudioListener.idl:
        * webaudio/AudioNode.idl:
        * webaudio/AudioPannerNode.idl:
        * webaudio/AudioParam.idl:
        * webaudio/RealtimeAnalyserNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 06:40:47 +0000 (06:40 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Remove empty directory.

        * Scripts/webkitpy/layout_tests/test_types: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 27 Jun 2011 06:40:47 +0000 (06:40 +0000)]
2011-06-26  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION Scripts panel sidebar pane context menu has no "Remove breakpoint" item
        https://bugs.webkit.org/show_bug.cgi?id=63421

        Show generic sidebar menu only if no pane-specific menu has been shown.

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 06:39:01 +0000 (06:39 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Build fix for clang.  Apparently clang doesn't want us to use the std
        namespace in headers, which makes sense.

        * svg/SVGAnimatedType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 06:31:48 +0000 (06:31 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove LegacyDefaultOptionalArguments from XMLHttpRequest.idl and XMLHttpRequestUpload.idl
        https://bugs.webkit.org/show_bug.cgi?id=63418

        The XMLHttpRequest.idl interface used to implement the new behavior
        manually using the RequiresAllArguments attribute.  Now that we have
        that behavior by default, we can simply remove the
        LegacyDefaultOptionalArguments attribute.

        * xml/XMLHttpRequest.idl:
        * xml/XMLHttpRequestUpload.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9679221&9679235> Work around an issue with sandbox.h.
mrowe@apple.com [Mon, 27 Jun 2011 06:22:06 +0000 (06:22 +0000)]
<rdar://problem/9679221&9679235> Work around an issue with sandbox.h.

Rubber-stamped by Maciej Stachowiak.

* WebProcess/mac/WebProcessMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 27 Jun 2011 06:16:05 +0000 (06:16 +0000)]
2011-06-26  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGLengthList animation
        https://bugs.webkit.org/show_bug.cgi?id=63399

        Test animations of attributes with type SVGLengthList.

        * svg/animations/script-tests/svglengthlist-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglengthlist-animation-2.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglengthlist-animation-3.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svglengthlist-animation-4.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svglengthlist-animation-1-expected.txt: Added.
        * svg/animations/svglengthlist-animation-1.html: Added.
        * svg/animations/svglengthlist-animation-2-expected.txt: Added.
        * svg/animations/svglengthlist-animation-2.html: Added.
        * svg/animations/svglengthlist-animation-3-expected.txt: Added.
        * svg/animations/svglengthlist-animation-3.html: Added.
        * svg/animations/svglengthlist-animation-4-expected.txt: Added.
        * svg/animations/svglengthlist-animation-4.html: Added.
2011-06-26  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGLengthList animation
        https://bugs.webkit.org/show_bug.cgi?id=63399

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedLengthList.

        Interpolated animations of glyph positions are possible now.

        Tests: svg/animations/svglengthlist-animation-1.html
               svg/animations/svglengthlist-animation-2.html
               svg/animations/svglengthlist-animation-3.html
               svg/animations/svglengthlist-animation-4.html

        * CMakeLists.txt: Add new file to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp: Make use of AnimatedLengthList.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimatedLengthList.cpp: Added. New animator for SVGLengthList.
        (WebCore::SVGAnimatedLengthListAnimator::SVGAnimatedLengthListAnimator):
        (WebCore::SVGAnimatedLengthListAnimator::constructFromString):
        (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedLengthListAnimator::calculateDistance):
        * svg/SVGAnimatedLengthList.h:
        (WebCore::SVGAnimatedLengthListAnimator::~SVGAnimatedLengthListAnimator):
        * svg/SVGAnimatedType.cpp: Add SVGLengthList.
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createLengthList):
        (WebCore::SVGAnimatedType::lengthList):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h:
        (WebCore::SVGAnimatorFactory::create):
        * svg/SVGLength.cpp: Add new constructor with LengthType, LengthMode and value.
        (WebCore::SVGLength::SVGLength):
        * svg/SVGLength.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 04:49:46 +0000 (04:49 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        window.location should use the holder's prototype chain
        https://bugs.webkit.org/show_bug.cgi?id=63411

        * http/tests/security/location-prototype-expected.txt: Added.
        * http/tests/security/location-prototype.html: Added.
        * http/tests/security/resources/location-prototype-overwrite.html: Added.
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        window.location should use the holder's prototype chain
        https://bugs.webkit.org/show_bug.cgi?id=63411

        This patch corrects the prototype chain for Location, but we really
        should do a complete cleanup of the prototype chain generation, like we
        did for JavaScriptCore.

        Test: http/tests/security/location-prototype.html

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 04:45:43 +0000 (04:45 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add [Optional] attributes where appropriate for addEventListener and removeEventListener
        https://bugs.webkit.org/show_bug.cgi?id=63417

        This patch doesn't actually change behavior because these interfaces
        have the LegacyDefaultOptionalArguments attribute.  This patch paves
        the way to removing LegacyDefaultOptionalArguments from some of these
        interfaces as well as making the project safer for copy-and-pasting
        these methods into new IDL files that don't have the
        LegacyDefaultOptionalArguments attribute.

        * bindings/scripts/test/TestObj.idl:
        * dom/EventTarget.idl:
        * dom/MediaStream.idl:
        * dom/MessagePort.idl:
        * dom/Node.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * notifications/Notification.idl:
        * page/DOMWindow.idl:
        * page/EventSource.idl:
        * storage/IDBRequest.idl:
        * storage/IDBTransaction.idl:
        * svg/SVGElementInstance.idl:
        * websockets/WebSocket.idl:
        * workers/AbstractWorker.idl:
        * workers/WorkerContext.idl:
        * xml/XMLHttpRequest.idl:
        * xml/XMLHttpRequestUpload.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 03:43:39 +0000 (03:43 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Kent Tamura.

        m_formElementsWithFormAttribute doesn't ref the objects it holds
        https://bugs.webkit.org/show_bug.cgi?id=62956

        * fast/forms/form-associated-element-crash3-expected.txt: Added.
        * fast/forms/form-associated-element-crash3.html: Added.
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Kent Tamura.

        m_formElementsWithFormAttribute doesn't ref the objects it holds
        https://bugs.webkit.org/show_bug.cgi?id=62956

        Test: fast/forms/form-associated-element-crash3.html

        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange committers entry.w
takano.naoki@gmail.com [Mon, 27 Jun 2011 03:34:31 +0000 (03:34 +0000)]
Change committers entry.w

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Jun 2011 03:15:00 +0000 (03:15 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove WebSecurityOrigin::grantUniversalAccess
        https://bugs.webkit.org/show_bug.cgi?id=63415

        This function has no callers and is downright dangerous.

        * public/WebSecurityOrigin.h:
        * src/WebSecurityOrigin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 27 Jun 2011 01:47:50 +0000 (01:47 +0000)]
2011-06-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        FileList::filenames should be FileList::paths, because it's more accurate.
        https://bugs.webkit.org/show_bug.cgi?id=63414

        Refactoring, no change in behavior.

        * fileapi/FileList.cpp:
        (WebCore::FileList::paths): Renamed from filenames.
        * fileapi/FileList.h:
        * html/FileInputType.cpp:
        (WebCore::FileInputType::handleDOMActivateEvent): Changed to use filenames, also fixed a reach-unto-thyself whoopsie.
        (WebCore::FileInputType::requestIcon): Ditto.
        (WebCore::FileInputType::filesChosen): Ditto.
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::fileTextValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Ryuan Choi <ryuan.choi@samsung.com>
ryuan.choi@samsung.com [Mon, 27 Jun 2011 00:31:19 +0000 (00:31 +0000)]
2011-06-26  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Functions needing Ewk_View_Private_Data as parameter are not part of public API.
        https://bugs.webkit.org/show_bug.cgi?id=62688

        Move functions which use Ewk_View_Private_Data and may not be required by
        applications to ewk_private.h.

        * ewk/ewk_private.h:
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 26 Jun 2011 23:06:18 +0000 (23:06 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Baselines for new test.

        * platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
        * platform/chromium-linux/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
        * platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
        * platform/chromium-win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Sun, 26 Jun 2011 21:26:29 +0000 (21:26 +0000)]
2011-06-26  Young Han Lee  <joybro@company100.net>

        Reviewed by Dirk Schulze.

        SVGAnimation - keyTime value 1 never get animated
        https://bugs.webkit.org/show_bug.cgi?id=63230

        According to the SMIL 3.0 specification, the index of the keyTimes should be
        determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
        and t=0.5, the current index of the keyTimes have to be 1 not 0).
        http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

        * svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt: Added.
        * svg/animations/animate-number-calcMode-discrete-keyTimes.html: Added.
        * svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
2011-06-26  Young Han Lee  <joybro@company100.net>

        Reviewed by Dirk Schulze.

        SVGAnimation - keyTime value 1 never get animated
        https://bugs.webkit.org/show_bug.cgi?id=63230

        According to the SMIL 3.0 specification, the index of the keyTimes should be
        determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1)
        and t=0.5, the current index of the keyTimes have to be 1 not 0).
        http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced

        Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html

        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::calculateKeyTimesIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 26 Jun 2011 20:21:01 +0000 (20:21 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove code behind WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
        https://bugs.webkit.org/show_bug.cgi?id=63402

        These old APIs are no longer needed.

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Filip Pizlo <fpizlo@apple.com>
commit-queue@webkit.org [Sun, 26 Jun 2011 19:30:56 +0000 (19:30 +0000)]
2011-06-26  Filip Pizlo  <fpizlo@apple.com>

        Reviewed by Gavin Barraclough.

        DFG non-speculative JIT has potentially harmful speculations with respect to arithmetic operations.
        https://bugs.webkit.org/show_bug.cgi?id=63347

        * dfg/DFGNonSpeculativeJIT.cpp:
            - Changed arithmetic operations to speculate in favor of integers.
        (JSC::DFG::NonSpeculativeJIT::valueToNumber):
        (JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
        (JSC::DFG::NonSpeculativeJIT::basicArithOp):
        (JSC::DFG::NonSpeculativeJIT::compile):
        * dfg/DFGNonSpeculativeJIT.h:
        * dfg/DFGOperations.cpp:
            - Added slow-path routines for arithmetic that perform no speculation; the
              non-speculative JIT will generate calls to these in cases where its
              speculation fails.
        * dfg/DFGOperations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 26 Jun 2011 17:17:55 +0000 (17:17 +0000)]
2011-06-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Don't use a Mutex for protecting access to the connection queue clients
        https://bugs.webkit.org/show_bug.cgi?id=63403

        Make sure to only access the queue client vector from the connection work queue.
        This gets rid of a lock and ensures that adding/removing clients from callbacks works correctly.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::addQueueClient):
        (CoreIPC::Connection::removeQueueClient):
        (CoreIPC::Connection::addQueueClientOnWorkQueue):
        (CoreIPC::Connection::removeQueueClientOnWorkQueue):
        (CoreIPC::Connection::processIncomingMessage):
        * Platform/CoreIPC/Connection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 26 Jun 2011 17:04:34 +0000 (17:04 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Darn.  Need BUGWG to make the file parse.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWith word-break: break-all, words do not break correctly before a surrogate pair
mitz@apple.com [Sun, 26 Jun 2011 16:09:33 +0000 (16:09 +0000)]
With word-break: break-all, words do not break correctly before a surrogate pair
https://bugs.webkit.org/show_bug.cgi?id=63401

Reviewed by Darin Adler.

Source/WebCore:

The code to check for mid-word breaks accumulates width one character at a time. It was actually
measuring the two parts of the surrogate pair individually, so they appeared to have zero width.
Fixed by checking for surrogate pairs and measuring the pair as one unit.

Test: fast/text/midword-break-before-surrogate-pair.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

* fast/text/midword-break-before-surrogate-pair.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 26 Jun 2011 14:22:13 +0000 (14:22 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Note that this test ASSERTs on Linux Debug.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
kbalazs@webkit.org [Sun, 26 Jun 2011 13:12:04 +0000 (13:12 +0000)]
Unreviewed gardening.

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

Skip new tests that depend on pause API. Put them to the
mac list that is used by all WebKit2 platforms.
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 26 Jun 2011 11:24:25 +0000 (11:24 +0000)]
2011-06-26  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGNumberOptionalNumber animation
        https://bugs.webkit.org/show_bug.cgi?id=63397

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedNumberOptionalNumber.

        Animations of attributes with type SVGAnimatedNumberOptionalNumber can be interpolated now. This can be used for smooth
        growing shadows with feGaussianBlur, feDropShadow or other filter effects.

        Tests: svg/animations/svgnumberoptionalnumber-animation-1.html
               svg/animations/svgnumberoptionalnumber-animation-2.html
               svg/animations/svgnumberoptionalnumber-animation-3.html
               svg/animations/svgnumberoptionalnumber-animation-4.html

        * CMakeLists.txt: Added new files to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberOptionalNumber.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimatedNumberOptionalNumber.cpp: Added. New animator for SVGAnimatedNumberOptionalNumber.
        (WebCore::SVGAnimatedNumberOptionalNumberAnimator::SVGAnimatedNumberOptionalNumberAnimator):
        (WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString):
        (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateDistance):
        * svg/SVGAnimatedNumberOptionalNumber.h: Added.
        (WebCore::SVGAnimatedNumberOptionalNumberAnimator::~SVGAnimatedNumberOptionalNumberAnimator):
        * svg/SVGAnimatedType.cpp: Added new type: pair<float, float>.
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createNumberOptionalNumber):
        (WebCore::SVGAnimatedType::numberOptionalNumber):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h: Add new animator to factory.
        (WebCore::SVGAnimatorFactory::create):
2011-06-26  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGNumberOptionalNumber animation
        https://bugs.webkit.org/show_bug.cgi?id=63397

        Test animation of SVGNumberOptionalNumber values with and without optional number, as well as 'to' and 'by' animations.

        * svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svgnumberoptionalnumber-animation-1-expected.txt: Added.
        * svg/animations/svgnumberoptionalnumber-animation-1.html: Added.
        * svg/animations/svgnumberoptionalnumber-animation-2-expected.txt: Added.
        * svg/animations/svgnumberoptionalnumber-animation-2.html: Added.
        * svg/animations/svgnumberoptionalnumber-animation-3-expected.txt: Added.
        * svg/animations/svgnumberoptionalnumber-animation-3.html: Added.
        * svg/animations/svgnumberoptionalnumber-animation-4-expected.txt: Added.
        * svg/animations/svgnumberoptionalnumber-animation-4.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-26 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Sun, 26 Jun 2011 09:35:17 +0000 (09:35 +0000)]
2011-06-26  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed. Skip failing tests.

        [Qt][WK2] svgnumberlist-animation-[1,2] fails since added
        https://bugs.webkit.org/show_bug.cgi?id=63396

        * platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 26 Jun 2011 06:33:59 +0000 (06:33 +0000)]
2011-06-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
        https://bugs.webkit.org/show_bug.cgi?id=63394

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):
2011-06-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
        https://bugs.webkit.org/show_bug.cgi?id=63394

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::queueLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Sun, 26 Jun 2011 05:43:00 +0000 (05:43 +0000)]
2011-06-25  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: new chromium baselines.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
        * platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
        * platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
        * platform/chromium-linux/svg/custom/linking-uri-01-b-expected.png: Added.
        * platform/chromium-linux/svg/custom/linking-uri-01-b-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
        * platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png:
        * platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
        * platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
        * platform/chromium-mac/svg/custom/linking-uri-01-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
        * platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
        * platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt:
        * platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
        * platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.txt:
        * platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
        * platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
        * platform/chromium-win/svg/custom/linking-uri-01-b-expected.png: Added.
        * platform/chromium-win/svg/custom/linking-uri-01-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 26 Jun 2011 04:33:36 +0000 (04:33 +0000)]
2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Crash in frameless document with media element.
        https://bugs.webkit.org/show_bug.cgi?id=63393

        * fast/dom/shadow/frameless-media-element-crash.html: Added.
        * fast/dom/shadow/frameless-media-element-crash-expected.txt: Added.
2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Crash in frameless document with media element.
        https://bugs.webkit.org/show_bug.cgi?id=63393

        Since MediaControls::create can return 0 (and does for frameless documents), we must anticipate it
        in the calling code.

        Test: fast/dom/shadow/frameless-media-element-crash.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged): Changed to bail out if controls weren't successfully created.
        (WebCore::HTMLMediaElement::createMediaControls): Renamed to better reflect the purpose, changed to handle failure of creation.
        (WebCore::HTMLMediaElement::preDispatchEventHandler): Changed to bail out if controls weren't successfully created.
        * html/HTMLMediaElement.h: Adjusted def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 26 Jun 2011 04:09:40 +0000 (04:09 +0000)]
2011-06-25  Adam Barth  <abarth@webkit.org>

        Roll Chromium DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 26 Jun 2011 04:04:07 +0000 (04:04 +0000)]
2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Fix some minor style issues
        https://bugs.webkit.org/show_bug.cgi?id=63391

        * inspector/DOMNodeHighlighter.cpp:
        (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
        The explicit WebCore namespace usage can be dropped.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::mapLocalToContainer):
        Use ASSERT_UNUSED for a parameter that we want to ASSERT
        on for a debug build, but is UNUSED in a release build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction after r89426.
bfulgham@webkit.org [Sun, 26 Jun 2011 00:39:52 +0000 (00:39 +0000)]
Unreviewed build correction after r89426.

* WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
  Link with Cairo DLL for new functionality.
* WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
  code for snprintf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction after r89426.
bfulgham@webkit.org [Sun, 26 Jun 2011 00:36:57 +0000 (00:36 +0000)]
Unreviewed build correction after r89426.

* Shared/API/c/cairo/WKImageCairo.h: Declare cairo type
  as struct (in keeping with other declarations).
* win/WebKit2.vcproj: Add new WKImageCairo.cpp file to
  WinCairo build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction after r89503.
bfulgham@webkit.org [Sun, 26 Jun 2011 00:22:12 +0000 (00:22 +0000)]
Unreviewed build correction after r89503.
See http://trac.webkit.org/changeset/89503. The modifications
to the WebKit2.def need to be mirrored in WebKit2CFLite.def.

* win/WebKit2CFLite.def: Add new exported symbol for isPreloaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 25 Jun 2011 23:32:35 +0000 (23:32 +0000)]
2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed build fix.

        Use UNUSED_PARAM on the correct param!

        * rendering/RenderView.cpp:
        (WebCore::RenderView::mapLocalToContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction after r89426.
bfulgham@webkit.org [Sat, 25 Jun 2011 23:10:49 +0000 (23:10 +0000)]
Unreviewed build correction after r89426.
See http://trac.webkit.org/changeset/89426. The new WebKit2
header file (WKImageCairo.h) is needed.

* win/WebKit2Generated.make: Make sure to copy the WKImageCairo.h
header file to the WebKit2 API directory after building.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 25 Jun 2011 23:01:33 +0000 (23:01 +0000)]
2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Simon Fraser.

        Inspector highlight rect is wrong for contents of transformed iframes
        https://bugs.webkit.org/show_bug.cgi?id=53627

        Part 2: Only adjust for the FrameView's scroll position when
        the localToAbsolute mapping did not end with fixed content.
        Content that is inside of a fixed position container is already
        adjusted for the FrameView's scrollPosition when RenderView
        maps local to container.

        This patch uses a "wasFixed" out parameter to determine if
        the localToAbsolute transformation ended inside a fixed block,
        and if so does not apply the scroll position.

        * page/FrameView.cpp:
        (WebCore::FrameView::convertFromRenderer):
        Respect wasFixed as described above.

        * rendering/RenderBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        This is the only time that "fixed" ever changed. So when
        fixed changes, update the optional wasFixed out parameter.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::localToAbsolute):
        (WebCore::RenderObject::mapLocalToContainer):
        (WebCore::RenderObject::localToContainerQuad):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::localToAbsoluteQuad):
        Ignore wasFixed by default, but pipe it though where needed.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::mapLocalToContainer):
        This is the final recursive call, so wasFixed goes no
        further. We sanity check its value in debug builds.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::selectionGapRectsForRepaint):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::mapLocalToContainer):
        * rendering/RenderInline.h:
        * rendering/svg/RenderSVGForeignObject.cpp:
        (WebCore::RenderSVGForeignObject::mapLocalToContainer):
        * rendering/svg/RenderSVGForeignObject.h:
        * rendering/svg/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::mapLocalToContainer):
        * rendering/svg/RenderSVGInline.h:
        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::mapLocalToContainer):
        * rendering/svg/RenderSVGModelObject.h:
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::mapLocalToContainer):
        * rendering/svg/RenderSVGRoot.h:
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::mapLocalToContainer):
        * rendering/svg/RenderSVGText.h:
        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::mapLocalToContainer):
        * rendering/svg/SVGRenderSupport.h:
        Pipe wasFixed through where needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 25 Jun 2011 23:01:15 +0000 (23:01 +0000)]
2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Simon Fraser.

        Inspector highlight rect is wrong for contents of transformed iframes
        https://bugs.webkit.org/show_bug.cgi?id=53627

        Part 1: Provide FloatQuad versions of convertFromRenderer,
        convertToContainingView, and convertChildToSelf, so that we
        can get the fully transformed quad of a renderer all the
        way up to the root widget.

        * page/FrameView.cpp:
        (WebCore::FrameView::convertFromRenderer):
        (WebCore::FrameView::convertToContainingView):
        * page/FrameView.h:
        * platform/ScrollView.h:
        (WebCore::ScrollView::convertChildToSelf):
        * platform/Widget.h:
        * platform/Widget.cpp:
        (WebCore::Widget::convertToContainingView):
        Provide FloatQuad versions of these already existing functions.

        (WebCore::Widget::convertToRootContainingView):
        Provide a helper conversion function to recursively
        convert a given FloatQuad up to the root widget.

        * inspector/DOMNodeHighlighter.cpp:
        (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
        Use the new methods to convert the FloatQuad for the highlighted
        node to the root container, without losing transformation
        information. Add a FIXME for SVG, which is still broken.

        * WebCore.exp.in:
        Export the new Widget functions so WebKit can link properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 25 Jun 2011 22:16:57 +0000 (22:16 +0000)]
2011-06-25  Dirk Schulze  <krit@webkit.org>

        Unreviewed build fix.

        SVGAnimatedType should support SVGNumberList animation
        https://bugs.webkit.org/show_bug.cgi?id=63387

        * svg/SVGAnimatedNumberList.cpp:
        (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 25 Jun 2011 22:08:27 +0000 (22:08 +0000)]
2011-06-25  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.  Remove ifdefs around these two functions because
        we're not planning to move them.  This patch makes WebFrameImpl.h
        consistent with WebFrame.h so we can build with the new API
        configuration.

        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 25 Jun 2011 22:02:29 +0000 (22:02 +0000)]
2011-06-25  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGNumberList animation
        https://bugs.webkit.org/show_bug.cgi?id=63387

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGNumberList.

        Animations of attributes with type SVGNumberList can be interpolated now.

        Tests: svg/animations/svgnumberlist-animation-1.html
               svg/animations/svgnumberlist-animation-2.html

        * CMakeLists.txt: Added new file to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberList.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimatedNumber.cpp:
        (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedNumber): Made method static for reuse in SVGAnimatedNumberList (and SVGAnimatedNumberOptionalNumber later).
        (WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue): Use new static function.
        * svg/SVGAnimatedNumber.h:
        * svg/SVGAnimatedNumberList.cpp: Added. New animator for SVGNumberList.
        (WebCore::SVGAnimatedNumberListAnimator::SVGAnimatedNumberListAnimator):
        (WebCore::SVGAnimatedNumberListAnimator::constructFromString):
        (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedNumberListAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedNumberListAnimator::calculateDistance):
        * svg/SVGAnimatedNumberList.h:
        (WebCore::SVGAnimatedNumberListAnimator::~SVGAnimatedNumberListAnimator):
        * svg/SVGAnimatedType.cpp: Use new Animator.
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createNumberList):
        (WebCore::SVGAnimatedType::numberList):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h:
        (WebCore::SVGAnimatorFactory::create):
2011-06-25  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGNumberList animation
        https://bugs.webkit.org/show_bug.cgi?id=63387

        Test animation of attributes with type SVGNumberList.

        * svg/animations/script-tests/svgnumberlist-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svgnumberlist-animation-2.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svgnumberlist-animation-1-expected.txt: Added.
        * svg/animations/svgnumberlist-animation-1.html: Added.
        * svg/animations/svgnumberlist-animation-2-expected.txt: Added.
        * svg/animations/svgnumberlist-animation-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 21:36:56 +0000 (21:36 +0000)]
2011-06-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPath to SVGAnimatorFactory concept
        https://bugs.webkit.org/show_bug.cgi?id=63336

        Convert <animate attributeName="d"> parsing to the new SVGAnimatorFactory concept, removing
        the last special data types from SVGAnimateElement: SVGPathByteStream m_fromPath/m_toPath/m_animatedPath.
        All existing non-string primitives have been converted to the new concept.

        Doesn't change any functionality.

        * CMakeLists.txt: Added SVGAnimatedPath.*.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::SVGAnimateElement):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimatedPath.cpp: Added.
        (WebCore::SVGAnimatedPathAnimator::SVGAnimatedPathAnimator):
        (WebCore::SVGAnimatedPathAnimator::constructFromString):
        (WebCore::SVGAnimatedPathAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedPathAnimator::calculateDistance):
        * svg/SVGAnimatedPath.h: Added.
        (WebCore::SVGAnimatedPathAnimator::~SVGAnimatedPathAnimator):
        * svg/SVGAnimatedType.cpp:
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createPath):
        (WebCore::SVGAnimatedType::path):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h:
        (WebCore::SVGAnimatorFactory::create):
        * svg/SVGPathByteStream.h:
        (WebCore::SVGPathByteStream::initializeFrom):
        * svg/SVGPathParserFactory.cpp:
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList):
        (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
        (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 25 Jun 2011 21:20:22 +0000 (21:20 +0000)]
2011-06-25  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        SOFT_LINK_POINTER_OPTIONAL isn't optional.
        https://bugs.webkit.org/show_bug.cgi?id=63378

        Continuation of r89718.  SOFT_LINK_POINTER_OPTIONAL should check the value returned by dlsym before dereferencing it.

        * platform/mac/SoftLinking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Gardening.
kbalazs@webkit.org [Sat, 25 Jun 2011 19:02:07 +0000 (19:02 +0000)]
Unreviewed. Gardening.
Skip css3/flexbox tests on Qt since ENABLE(CSS3_FLEXBOX) is disabled.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 25 Jun 2011 18:53:00 +0000 (18:53 +0000)]
2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        run-bindings-tests does not work on Chromium Windows.
        https://bugs.webkit.org/show_bug.cgi?id=63382

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Sat, 25 Jun 2011 18:41:39 +0000 (18:41 +0000)]
2011-06-25  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test linking-uri-01-b.svg fails
        https://bugs.webkit.org/show_bug.cgi?id=63322

        Allow navigating to internal <view> targets. When choosing Back ensure
        the <svg> current view is initialized correctly.

        Tests: svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg
               svg/custom/linking-uri-01-b.svg

        * page/FrameView.cpp: Delegate to setupInitialView.
        (WebCore::FrameView::scrollToAnchor):
        * svg/SVGAElement.cpp: Allow navigating to internal <view> targets.
        (WebCore::SVGAElement::defaultEventHandler):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setupInitialView): Initialize current view depending on fragment identifier.
        (WebCore::SVGSVGElement::inheritViewAttributes):
        * svg/SVGSVGElement.h:
2011-06-25  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test linking-uri-01-b.svg fails
        https://bugs.webkit.org/show_bug.cgi?id=63322

        Add a test for navigating to an inner <view> anchor. The changed test results
        are improvements.

        * platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
        * platform/mac/svg/custom/linking-a-03-b-all-expected.png:
        * platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
        * platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
        * platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
        * platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
        * platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
        * platform/mac/svg/custom/linking-uri-01-b-expected.png: Added.
        * platform/mac/svg/custom/linking-uri-01-b-expected.txt: Added.
        * svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg: Added.
        * svg/custom/linking-uri-01-b.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-20 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 25 Jun 2011 17:44:20 +0000 (17:44 +0000)]
2011-06-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Duplicate entry in context menu
        https://bugs.webkit.org/show_bug.cgi?id=62139

        contextMenuController()->populate() is called from
        ContextMenuController::handleContextMenuEvent() so
        QWebPage::updatePositionDependentActions() does not need
        to call it independently.

        Related changesets:
         http://trac.webkit.org/changeset/73535
         http://trac.webkit.org/changeset/32389

        * Api/qwebpage.cpp:
        (QWebPage::updatePositionDependentActions):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::contextMenuCopy):
        (tst_QWebPage::contextMenuPopulatedOnce):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 25 Jun 2011 17:21:26 +0000 (17:21 +0000)]
2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Update expectations after r89732.
        https://bugs.webkit.org/show_bug.cgi?id=59085

        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 25 Jun 2011 17:04:40 +0000 (17:04 +0000)]
2011-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
        https://bugs.webkit.org/show_bug.cgi?id=63373

        * fast/css/unknown-pseudo-element-matching-expected.txt: Updated results.
        * fast/css/unknown-pseudo-element-matching.html: Added more tests.
2011-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
        https://bugs.webkit.org/show_bug.cgi?id=63373

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement.
        (WebCore::CSSStyleSelector::pushParent): Ditto.
        * dom/Node.cpp:
        (WebCore::Node::parentOrHostElement): Added.
        * dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Sat, 25 Jun 2011 10:20:18 +0000 (10:20 +0000)]
2011-06-25  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: chromium rebaselines.

        * platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.png: Added.
        * platform/chromium-linux/svg/custom/svg-fonts-fallback-expected.txt: Added.
        * platform/chromium-linux/svg/custom/svg-fonts-segmented-expected.png: Added.
        * platform/chromium-linux/svg/custom/svg-fonts-word-spacing-expected.png: Added.
        * platform/chromium-linux/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
        * platform/chromium-mac-leopard/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-fonts-fallback-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-fonts-fallback-expected.txt: Added.
        * platform/chromium-win/svg/custom/svg-fonts-segmented-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-fonts-segmented-expected.txt: Added.
        * platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
        * platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
        * platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 08:43:59 +0000 (08:43 +0000)]
2011-06-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        Update gtk baseline. The rebaselines should be done now.

        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * platform/gtk/svg/batik/text/textEffect-expected.txt:
        * platform/gtk/svg/batik/text/textEffect3-expected.txt:
        * platform/gtk/svg/batik/text/xmlSpace-expected.txt:
        * platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt:
        * platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/gtk/svg/text/text-altglyph-01-b-expected.txt:
        * platform/gtk/svg/text/text-text-04-t-expected.txt:
        * platform/gtk/svg/text/text-text-05-t-expected.txt:
        * platform/gtk/svg/text/text-text-06-t-expected.txt:
        * platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
        * platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 08:01:00 +0000 (08:01 +0000)]
2011-06-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        Update win baseline.

        * platform/win-wk2/Skipped: Skip newly added svg/text test just like in mac-wk2.
        * platform/win-xp/svg/custom: Added.
        * platform/win-xp/svg/custom/svg-fonts-fallback-expected.txt: Added. XP has different metrics here.
        * platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Update result from Win7 slave.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 07:44:58 +0000 (07:44 +0000)]
2011-06-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        Skip svg/text/select-text-svgfont.html on mac-wk2, just like the other svg/text tests.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 07:36:04 +0000 (07:36 +0000)]
2011-06-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Gardening.

        http/tests/inspector/network/network-iframe-load-and-delete.html fails on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=63379

        http/tests/navigation/anchor-basic.html fails on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=63380

        Skip last two tests that kept Leopard red, should turn green again now.

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 07:34:27 +0000 (07:34 +0000)]
2011-06-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Gardening.

        REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing on Leopard/SnowLeopard release
        https://bugs.webkit.org/show_bug.cgi?id=63169

        Skip failing test for mac, to turn bots green again.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 07:31:18 +0000 (07:31 +0000)]
2011-06-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        Update a stale Leopard result.

        * platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Qt and Chromium builds.
mitz@apple.com [Sat, 25 Jun 2011 07:02:19 +0000 (07:02 +0000)]
Try to fix the Qt and Chromium builds.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setEncodedAudioData):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd an option to enable legacy rounding hacks
mitz@apple.com [Sat, 25 Jun 2011 06:49:12 +0000 (06:49 +0000)]
Add an option to enable legacy rounding hacks
https://bugs.webkit.org/show_bug.cgi?id=63363

Reviewed by Anders Carlsson.

Source/WebCore:

Restored most of text rounding hacks which were removed in r78846, with a global flag to control
whether rounding hacks are allowed, which defaults to false.

Test: platform/mac/fast/text/rounding-hacks.html

* CMakeLists.txt: Added TextRun.cpp.
* GNUmakefile.list.am: Ditto.
* WebCore.exp.in: Export new TextRun function and global and updated StringTruncator functions.
* WebCore.gypi: Added TextRun.cpp.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Disable rounding hacks in the one place
they used to be disabled.
* platform/graphics/Font.cpp: Re-added the rounding character table.
* platform/graphics/Font.h:
(WebCore::Font::isRoundingHackCharacter): Re-added.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Account for final rounding width.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::adjustedSpaceWidth): Re-added.
* platform/graphics/StringTruncator.cpp:
(WebCore::stringWidth): Re-added disableRoundingHacks parameter.
(WebCore::truncateString): Ditto.
(WebCore::StringTruncator::centerTruncate): Added EnableRoundingHacksOrNot parameter.
(WebCore::StringTruncator::rightTruncate): Ditto.
(WebCore::StringTruncator::width): Ditto.
* platform/graphics/StringTruncator.h:
* platform/graphics/TextRun.cpp: Added.
(WebCore::TextRun::setAllowsRoundingHacks): Added.
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun): Added RoundingHacks parameter to the constructors, used to initialize
the m_applyRunRounding and m_applyWordRounding member variables, subject to rounding hacks being allowed.
(WebCore::TextRun::applyRunRounding): Re-added this accessor.
(WebCore::TextRun::applyWordRounding): Ditto.
(WebCore::TextRun::disableRoundingHacks): Re-added.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Re-added code to apply rounding hacks.
(WebCore::WidthIterator::advance): Ditto.
* platform/graphics/WidthIterator.h:
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ceilCGFloat): Re-added.
(WebCore::ComplexTextController::ComplexTextController): Re-added code to apply rounding hacks.
(WebCore::ComplexTextController::advance): Ditto.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Ditto.
* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::finalRoundingWidth): Re-added this accessor.
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText): Accound for final rounding width.
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformGlyphInit): Initialize m_adjustedSpaceWidth.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::fileListNameForWidth): Enabled rounding hacks in the string truncator.
* platform/mac/DragImageMac.mm:
(WebCore::widthWithFont): Disable rounding hacks when measuring.
(WebCore::drawAtPoint): Disable rounding hacks when drawing.
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink): Enable rounding hacks in the string truncator.
* platform/win/WebCoreTextRenderer.cpp:
(WebCore::WebCoreTextFloatWidth): Ditto.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject): Disable rounding hacks.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAvgCharWidth): Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::fileListNameForWidth): Enabled rounding hacks in the string truncator.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::fileListNameForWidth): Ditto.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun): Disabled rounding hacks.
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::constructTextRun): Ditto.

Source/WebKit/mac:

* Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
Disabled rounding hacks.
(-[NSString _web_widthWithFont:]): Ditto.
* WebView/WebView.mm:
(+[WebView _setAllowsRoundingHacks:]): Added this setter.
* WebView/WebViewPrivate.h:

Source/WebKit/win:

* WebKitGraphics.cpp:
(CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
(RightTruncateStringToWidth): Ditto.

Tools:

Added layoutTestController.allowRoundingHacks() and implemented it
on OS X.

* DumpRenderTree/LayoutTestController.cpp:
(allowRoundingHacksCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::allowRoundingHacks):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::allowRoundingHacks):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::allowRoundingHacks):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::allowRoundingHacks):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::allowRoundingHacks):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::allowRoundingHacks):

LayoutTests:

* platform/mac/fast/text/rounding-hacks.html: Added.
* platform/mac/platform/mac/fast/text/rounding-hacks-expected.png: Added.
* platform/mac/platform/mac/fast/text/rounding-hacks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 06:28:12 +0000 (06:28 +0000)]
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        font substitution doesn't work for HTML text using SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=17608

        Selection rects are wrong for text with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=25460

        With @font-face, SVG fonts only work as primary, non-segmented
        https://bugs.webkit.org/show_bug.cgi?id=32227

        When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
        https://bugs.webkit.org/show_bug.cgi?id=34236

        SVG @font-face breaks text-overflow: ellipsis
        https://bugs.webkit.org/show_bug.cgi?id=36840

        REGRESSION: SVG Font selection problems
        https://bugs.webkit.org/show_bug.cgi?id=41934

        Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
        That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
        There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

        Update SVG pixel test baseline. Use all results that have been checked in when I landed the patch the last time.

        * platform/chromium/test_expectations.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.png:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/xmlSpace-expected.png:
        * platform/mac/svg/batik/text/xmlSpace-expected.txt:
        * platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
        * platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
        * platform/mac/svg/custom/svg-fonts-fallback-expected.png: Added.
        * platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Added.
        * platform/mac/svg/custom/svg-fonts-segmented-expected.png: Added.
        * platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Added.
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
        * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
        * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
        * platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/mac/svg/text/text-altglyph-01-b-expected.png:
        * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
        * platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
        * platform/mac/svg/text/text-text-04-t-expected.png:
        * platform/mac/svg/text/text-text-04-t-expected.txt:
        * platform/mac/svg/text/text-text-05-t-expected.png:
        * platform/mac/svg/text/text-text-05-t-expected.txt:
        * platform/mac/svg/text/text-text-06-t-expected.png:
        * platform/mac/svg/text/text-text-06-t-expected.txt:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
        * platform/mac/svg/wicd/test-rightsizing-b-expected.png:
        * platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
        * platform/qt-mac/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
        * platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
        * platform/qt/Skipped:
        * platform/qt/fast/dom/Window/window-properties-expected.png: Added.
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Added.
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-2-expected.png: Added.
        * platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.png: Added.
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/js/global-constructors-expected.png: Added.
        * platform/qt/fast/js/global-constructors-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
        * platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
        * platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
        * platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
        * platform/qt/svg/custom/svg-features-expected.png: Added.
        * platform/qt/svg/custom/svg-features-expected.txt: Added.
        * platform/qt/svg/custom/svg-fonts-in-html-expected.png:
        * platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
        * platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
        * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
        * platform/qt/svg/wicd/test-rightsizing-b-expected.png:
        * platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
        * svg/custom/resources/ABCFont.svg:
        * svg/custom/svg-fonts-fallback.xhtml: Added.
        * svg/custom/svg-fonts-segmented.xhtml: Added.
        * svg/custom/svg-fonts-word-spacing.html: Added.
        * svg/text/select-text-svgfont-expected.txt: Added.
        * svg/text/select-text-svgfont.html: Added.
        * svg/text/text-overflow-ellipsis-svgfont.html: Added.
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        * wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        font substitution doesn't work for HTML text using SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=17608

        Selection rects are wrong for text with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=25460

        With @font-face, SVG fonts only work as primary, non-segmented
        https://bugs.webkit.org/show_bug.cgi?id=32227

        When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
        https://bugs.webkit.org/show_bug.cgi?id=34236

        SVG @font-face breaks text-overflow: ellipsis
        https://bugs.webkit.org/show_bug.cgi?id=36840

        REGRESSION: SVG Font selection problems
        https://bugs.webkit.org/show_bug.cgi?id=41934

        Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)
               svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
               svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Michael Lewis)
               svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
               svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emil Schutte)

        Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
        That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
        There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

        This makes text selection using SVG Fonts possible again.

        * features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFont support is not available and the fast path is disabled.
        * page/DOMWindow.idl: Touched file to force Qt regenerating the bindings.
        * platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well.
        (WebCore::Font::drawText):
        (WebCore::Font::drawEmphasisMarks):
        (WebCore::Font::width):
        (WebCore::Font::selectionRectForText):
        (WebCore::Font::offsetForPosition):
        (WebCore::Font::codePath):
        * platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasisMarks. Add new glyphDataAndPageForCharacter() method which returns a pair
                                    std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to properly
                                    handle font fallback glyph matching for SVG Fonts..
        (WebCore::Font::fontList): Add FontFallbackList accessor.
        * platform/graphics/FontFallbackList.h: Add getters/setters for glyphPageZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderingContext.
        (WebCore::FontFallbackList::glyphPageZero):
        (WebCore::FontFallbackList::glyphPages):
        (WebCore::FontFallbackList::setGlyphPageZero):
        (WebCore::FontFallbackList::setGlyphPages):
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter): Move implementation to glyphDataAndPageForCharacter(), and use that method from here.
        (WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer.
        (WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case.
        (WebCore::Font::drawGlyphBuffer): Ditto.
        * platform/graphics/FontMetrics.h:
        (WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPage using the glyphs defined in the SVG Font.
        * platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage has been changed.
        (WebCore::SVGGlyph::SVGGlyph):
        (WebCore::SVGGlyph::operator==):
        * platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int.
        (WebCore::SimpleFontData::SimpleFontData):
        * platform/graphics/SimpleFontData.h: Add new pure virtual methods to the AdditionalFontData interface, to be implemented in SVGFontData.
        (WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we encounter a SVG glyph.
        * platform/graphics/TextRun.h:
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::glyphDataForCharacter):
        (WebCore::WidthIterator::advance):
        * platform/graphics/WidthIterator.h: Store several new members needed for SVG Fonts support (last processed glyph name used for kerning pair lookup)
                                             and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).
        (WebCore::WidthIterator::run):
        (WebCore::WidthIterator::runWidthSoFar):
        (WebCore::WidthIterator::lastGlyphName):
        (WebCore::WidthIterator::setLastGlyphName):
        (WebCore::WidthIterator::arabicForms):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scaleEmToUnits free function from FontMetrics.h.
        * platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
        * platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Handle UTF-16 surrogate pairs correctly, fixes the previous Acid3 regression.
        * rendering/svg/SVGTextMetrics.cpp:
        (WebCore::SVGTextMetrics::SVGTextMetrics):
        (WebCore::constructTextRun):
        (WebCore::SVGTextMetrics::measureCharacterRange):
        * rendering/svg/SVGTextMetrics.h:
        * rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGFont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionForTextUsingSVGFont.
        (WebCore::firstParentRendererForNonTextNode): Don't assert node() exists, doesn't hold true for generated render objects.
        (WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFromRun.
        (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove extra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength().
        (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method.
        (WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing method, this actually creates/renders Paths.
        (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 of SVG Glyph selection code.
        * rendering/svg/SVGTextRunRenderingContext.h:
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::hasValidGlyphElement):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGFontData.cpp:
        (WebCore::SVGFontData::initializeFontData): Changed font size from int to float.
        (WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width.
        (WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph selection code.
        (WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs defined in the SVG Font.
        (WebCore::SVGFontData::fillBMPGlyphs): Moved from the previous fillSVGGlyphPage implementation.
        (WebCore::SVGFontData::fillNonBMPGlyphs): Add non-bmp glyph handling, fixing the Acid3 regression (support using SVGGlyphs for UTF-16 surrogate pairs).
        * svg/SVGFontData.h:
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligature registration for the use within GlyphPage.
        (WebCore::SVGFontElement::ensureGlyphCache):
        * svg/SVGGlyphMap.h: Switch to use SurrogatePairTextIterator, and switch glyph table from UChar to UChar32, just like GlyphPage, to handle glyphs from non-BMP correctly.
        (WebCore::SVGGlyphMap::addGlyph): Remove setting isValid, it's not needed anymore and gone.
        (WebCore::SVGGlyphMap::collectGlyphsForString):
        * svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Sat, 25 Jun 2011 02:42:38 +0000 (02:42 +0000)]
2011-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [CMAKE] Replace ";" with space in FEATURE_DEFINES macro
        https://bugs.webkit.org/show_bug.cgi?id=62211

        html.css file doesn't recognize ENABLE_XXX macro because FEATURE_DEFINES macro has ";"
        as separator. So, let the html.css to use new feature macro with space separator.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 25 Jun 2011 02:15:35 +0000 (02:15 +0000)]
2011-06-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Arm Assembler, Immediate stack offset values truncated to 8 bits for add & sub
        https://bugs.webkit.org/show_bug.cgi?id=63345

        The methods ARMThumbImmediate::getUInt9 and ARMThumbImmediate::getUInt10
        return 9 and 10 bit quantities, therefore changed their return type from
        uint8_t to uint16_t.  Also casted the places where they are used as they
        are currently shifted and used as 7 or 8 bit values.

        These methods are currently used for literals for stack offsets,
        including creating and destroying stack frames.  The prior truncation of
        the upper bits caused stack frames to be too small, thus allowing a
        JIT'ed function to access and overwrite stack space outside of the
        incorrectly sized stack frame.

        * assembler/ARMv7Assembler.h:
        (JSC::ARMThumbImmediate::getUInt9):
        (JSC::ARMThumbImmediate::getUInt10):
        (JSC::ARMv7Assembler::add):
        (JSC::ARMv7Assembler::ldr):
        (JSC::ARMv7Assembler::str):
        (JSC::ARMv7Assembler::sub):
        (JSC::ARMv7Assembler::sub_S):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Ryuan Choi <ryuan.choi@samsung.com>
ryuan.choi@samsung.com [Sat, 25 Jun 2011 01:21:24 +0000 (01:21 +0000)]
2011-06-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove ewk_frame_theme_get/set.
        https://bugs.webkit.org/show_bug.cgi?id=63370

        Remove ewk_frame_theme_get/set to avoid confusion.
        Setting theme on each frame is meaningless and ewk_view_thjeme_set can
        do same thing.

        * ewk/ewk_frame.cpp:
        * ewk/ewk_frame.h:
        * ewk/ewk_view.cpp:
        (ewk_view_theme_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 25 Jun 2011 00:45:00 +0000 (00:45 +0000)]
2011-06-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Drag-and-drop tab in same window makes web process falsely report unresponsiveness
        https://bugs.webkit.org/show_bug.cgi?id=63369
        <rdar://problem/9673120>

        If the view becomes invisible, stop the responsiveness timer, because we might not get any
        messages that will cause it to stop (such as painting notifications since we don't paint
        when we're not visible).

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::viewStateDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Gavin Peters <gavinp@chromium.org>
gavinp@chromium.org [Sat, 25 Jun 2011 00:39:33 +0000 (00:39 +0000)]
2011-06-24  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Darin Adler.

        fix possible race in LinkLoader
        https://bugs.webkit.org/show_bug.cgi?id=63360

        In chromium bug 80729
        http://code.google.com/p/chromium/issues/detail?id=80729 I am
        seeing some kind of double triggering of the timer; I am concerned
        that it is possible that a Link element errors out or succeeds,
        sets a timer, and shortly before the timer is triggered it is
        editted, launches another request.  After that, the first timer
        triggers, zeroing out m_cachedResource.  Then, the second load
        finishes, and *crash*.  If this is the case, this fix should stop
        it.

        No new tests; I haven't reproduced this.  I hope chrome's crash
        telemetry will give good feedback; this crash is occuring many times a
        day so the difference should be obvious.

        * loader/LinkLoader.cpp:
        (WebCore::LinkLoader::LinkLoader):
        (WebCore::LinkLoader::linkLoadTimerFired):
        (WebCore::LinkLoader::linkLoadingErrorTimerFired):
        (WebCore::LinkLoader::notifyFinished):
        * loader/LinkLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 25 Jun 2011 00:16:36 +0000 (00:16 +0000)]
2011-06-24  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
        https://bugs.webkit.org/show_bug.cgi?id=63332
        <rdar://problem/9661650>

        No new tests; Only affects machines with QTKit < 7.6.3 installed.

        Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is non-NULL before passing it into -[QTMovie initWithAttributes:],
        as it is only defined in QTKit >= 7.6.3.  If it is NULL, pass QTSecurityPolicyNoCrossSiteAttribute=YES instead, which has
        the same effect in earlier versions of QTKit as the NoLocalToRemote and NoRemoteToLocal keys.  To avoid ASSERTs when running
        debug builds with earlier versions of QTKit, add a SOFT_LINK_POINTER_OPTIONAL macro to SoftLinking.h and make these keys optional.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
        * platform/mac/SoftLinking.h: Add SOFT_LINK_POINTER_OPTIONAL macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build failure.
darin@apple.com [Sat, 25 Jun 2011 00:13:22 +0000 (00:13 +0000)]
Try to fix Windows build failure.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::setFileDescriptorData): Copy string into a local so we
can call charactersWithNullTermination on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 25 Jun 2011 00:11:58 +0000 (00:11 +0000)]
2011-06-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        releaseFastMallocFreeMemory doesn't adjust free counts for scavenger
        https://bugs.webkit.org/show_bug.cgi?id=63015

        Added code to adjust class TCMalloc_PageHeap variables free_committed_pages_ and
        min_free_committed_pages_since_last_scavenge_ in ReleaseFreeList().  These
        adjustments are a bug.  These need to reflect the pages that are released
        in ReleaseFreeLsit so that scavenge doesn't try to free that many pages as well.
        Made ReleaseFreeList a member of TCMalloc_PageHeap in the process.  Updated
        Check() and helper method CheckList() to check the number of actual free pages
        with free_committed_pages_.

        The symptom of the problem of the existing code is that the scavenger may
        run unneccesarily without any real work to do, i.e. pages on the free lists.
        The scanvenger would also end up freeing too many pages, that is going below
        the current 528 target free pages.

        Note that the style of the changes was kept consistent with the
        existing style.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::Check):
        (WTF::TCMalloc_PageHeap::CheckList):
        (WTF::TCMalloc_PageHeap::ReleaseFreeList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 25 Jun 2011 00:09:37 +0000 (00:09 +0000)]
2011-06-23  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Remove some unneeded functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=63295

        Removing 7 of the functions in FrameLoader.h is probably a step
        in the right direction.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::handledOnloadEvents):
        Moved the call to stopDeferringEvents in here from FrameLoader.
        * loader/DocumentLoader.h: Ditto.

        * loader/DocumentWriter.h: Fixed a typo.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::setFirstPartyForCookies): Changed this to
        use a non-recursive tree walk instead of recursion.
        (WebCore::FrameLoader::stopAllLoaders): Moved the code from
        stopLoadingSubframes inline, since it's only two lines of code.
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Moved
        the code from markLoadComplete inline, since it's only one line.
        (WebCore::FrameLoader::checkLoadComplete): Changed this to use a
        non-recursive tree walk instead of recursion, eliminating the
        recursiveCheckLoadComplete function completely.
        (WebCore::FrameLoader::handledOnloadEvents): Moved the call to
        stopDeferringEvents into DocumentLoader.

        * loader/FrameLoader.h: Removed unneeded forward declarations,
        and now-unneeded functions setupForReplaceByMIMEType,
        isStopping, isLoadingFromCachedPage, stopLoadingSubframes,
        markLoadComplete, mainReceivedError, and recursiveCheckLoadComplete.
        Also made allChildrenAreComplete private.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        Call DocumentLoader::isStopping so we can remove the function
        from FrameLoader that just calls through. Other call sites were
        using DocumentLoader::isStopping directly.
        (WebCore::MainResourceLoader::didReceiveResponse): Call
        DocumentLoader::setupForReplaceByMIMEType so we can remove the
        function from FrameLoader that just calls through. This was
        the only call site.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::init): Call the
        ResourceLoader::cancelledError function instead of calling
        directly to FrameLoader.

        * loader/ResourceLoader.h: Made response an inline function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Rubber-stamped by Maciej Stachowiak.
ap@apple.com [Sat, 25 Jun 2011 00:03:25 +0000 (00:03 +0000)]
    Rubber-stamped by Maciej Stachowiak.

        REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading

        No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
        the rollout will re-introduce the older less frequent crash).

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix
        for bug 62764.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 23:39:35 +0000 (23:39 +0000)]
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add flexbox and inline-flexbox as possible CSS display values
        https://bugs.webkit.org/show_bug.cgi?id=63361

        * css3/flexbox/display-property-expected.txt: Added.
        * css3/flexbox/display-property.html: Added.
        * css3/flexbox/script-tests/display-property.js: Added.
        (testFlex):
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add flexbox and inline-flexbox as possible CSS display values
        https://bugs.webkit.org/show_bug.cgi?id=63361

        Test: css3/flexbox/display-property.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Anna Cavender <annacc@chromium.org>
hclam@chromium.org [Fri, 24 Jun 2011 23:06:01 +0000 (23:06 +0000)]
2011-06-24  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Loading out-of-band text track files from <track>.
        https://bugs.webkit.org/show_bug.cgi?id=62881

        Uses the src attribute of <track> urls to load out-of-band text track
        files using ThreadableLoader.  Also removes TextTrackPrivateInterface
        (as well as LoadableTextTrackImpl and MutableTextTrackImpl) classes.

        No new tests because feature is hidden behind VIDEO_TRACK feature
        define, which is turned off.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * html/HTMLTrackElement.cpp:
        * html/HTMLTrackElement.h:
        * html/LoadableTextTrack.cpp:
        * html/LoadableTextTrack.h:
        * html/LoadableTextTrackImpl.cpp: Removed.
        * html/LoadableTextTrackImpl.h: Removed.
        * html/MutableTextTrack.cpp:
        * html/MutableTextTrack.h:
        * html/MutableTextTrackImpl.cpp: Removed.
        * html/MutableTextTrackImpl.h: Removed.
        * html/TextTrack.cpp:
        * html/TextTrack.h:
        * html/TextTrackPrivate.h: Removed.
        * platform/track/CueParser.cpp:
        * platform/track/CueParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Fri, 24 Jun 2011 22:32:18 +0000 (22:32 +0000)]
2011-06-24  Rob Buis  <rbuis@rim.com>

        Rubber-stamped by Nikolas Zimmermann.

        All pointer-events fail if text has visibility="hidden"
        https://bugs.webkit.org/show_bug.cgi?id=62209

        Do not use writing mode aware code for SVG Text.

        No new tests needed.

        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 22:15:29 +0000 (22:15 +0000)]
2011-06-24  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        REGRESSION (r89687): 5 compositing/rtl tests failing on Windows 7 Release (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=63343

        These tests were failing since they were introduced in r89687.  The
        layerTreeAsText dump on the iframe document was causing the outer
        layerTreeAsText dump to be affected by font metrics.  Fixed in this
        case by not putting layerTreeAsText output in an element when inside
        an iframe.

        * compositing/rtl/rtl-absolute-overflow-scrolled.html:
        * compositing/rtl/rtl-absolute-overflow.html:
        * compositing/rtl/rtl-absolute.html:
        * compositing/rtl/rtl-fixed-overflow-scrolled.html:
        * compositing/rtl/rtl-fixed-overflow.html:
        * compositing/rtl/rtl-fixed.html:
        * compositing/rtl/rtl-iframe-absolute-expected.txt:
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
        * compositing/rtl/rtl-iframe-fixed-expected.txt:
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
        * compositing/rtl/rtl-iframe-relative-expected.txt:
        * compositing/rtl/rtl-relative.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 22:07:10 +0000 (22:07 +0000)]
2011-06-24  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Darin Adler.

        Change NDEBUG to !LOG_DISABLED macro in databases for logging.
        https://bugs.webkit.org/show_bug.cgi?id=63346

        Changed NDEBUG to !LOG_DISABLED in databases code which involves logging.
        This change resolves also build break in Release build when logging enabled.

        No new tests because there is no new behavior or feature exposed.

        * loader/icon/IconDatabase.cpp: Macro fixes.
        (WebCore::IconDatabase::iconDatabaseSyncThread):
        (WebCore::IconDatabase::syncThreadMainLoop):
        (WebCore::IconDatabase::readFromDatabase):
        (WebCore::IconDatabase::writeToDatabase):
        (WebCore::IconDatabase::cleanupSyncThread):
        * storage/AbstractDatabase.h: Macro fixes.
        * storage/DatabaseTask.cpp: Macro fixes.
        * storage/DatabaseTask.h: Macro fixes.
        * storage/SQLTransaction.cpp: Macro fixes.
        * storage/SQLTransaction.h: Macro fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 22:05:16 +0000 (22:05 +0000)]
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        Pass Strings by const reference to functions
        https://bugs.webkit.org/show_bug.cgi?id=63341

        Note that since Strings hold a RefPtr to StringImpl, passing Strings
        by value isn't horrible, but it does cause ref count churn and using
        const references is more consistent with the rest of the code base.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addHTTPOriginIfNeeded): Rework the code to not
            change the value of the passed in String.
        * loader/FrameLoader.h:
        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::setFileDescriptorData):
        * platform/win/ClipboardUtilitiesWin.h:
        * storage/DatabaseTracker.h:
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
        * storage/IDBLevelDBBackingStore.h:
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
        * storage/IDBSQLiteBackingStore.h:
        * storage/chromium/DatabaseTrackerChromium.cpp:
        (WebCore::DatabaseTracker::getOpenDatabases):
        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::SVGPaint):
        * svg/SVGPaint.h:
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::updateAnimations):
        * svg/animation/SMILTimeContainer.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 24 Jun 2011 22:03:55 +0000 (22:03 +0000)]
2011-06-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Not possible for plug-ins to override the internal PDF viewer
        https://bugs.webkit.org/show_bug.cgi?id=63356
        <rdar://problem/9673382>

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
        Pass the entire resource response to shouldUseCustomRepresentationForResponse.

        * WebProcess/WebProcess.cpp:
        (WebKit::canPluginHandleResponse):
        Ask for the plug-in path for a plug-in that can handle the given resource response.
        If we fail to send the message, or if the path comes back empty, we assume that there's no plug-in
        that can handle it.

        (WebKit::WebProcess::shouldUseCustomRepresentationForResponse):
        If the response MIME type is in the m_mimeTypesWithCustomRepresentations map, check if there's
        a plug-in that can handle the given response. If that is the case, it should have precedence over
        the custom representation.

        * WebProcess/WebProcess.h:
        Rename shouldUseCustomRepresentationForMIMEType to shouldUseCustomRepresentationForResponse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 24 Jun 2011 21:45:16 +0000 (21:45 +0000)]
2011-06-24  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Match other clampTo* functions in style with clampToInteger(float)
        function.
        https://bugs.webkit.org/show_bug.cgi?id=53449

        * wtf/MathExtras.h:
        (clampToInteger):
        (clampToFloat):
        (clampToPositiveInteger):
2011-06-24  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Add clamping for CSSPrimitiveValues and SVGInlineText font size.
        https://bugs.webkit.org/show_bug.cgi?id=53449

        Test: svg/text/svg-zoom-large-value.xhtml

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add asserts to detect if the
        number created is valid.
        * css/CSSPrimitiveValue.h: add clamping checks to prevent overflows.
        (WebCore::CSSPrimitiveValue::getFloatValue):
        (WebCore::CSSPrimitiveValue::getIntValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): split into two
        static functions, one specific to CSSStyleSelector and other generic to help
        in clamping font size for other callers like svg text, etc.
        * css/CSSStyleSelector.h:
        * platform/graphics/FontDescription.h: add asserts to detect if the new font
        size is valid.
        (WebCore::FontDescription::setComputedSize):
        (WebCore::FontDescription::setSpecifiedSize):
        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): use the new helper
        from CSSStyleSelector to help in clamping new scaled font size. do not use
        "smart minimum" since svg allows really small unreadable fonts (tested by existing
        layout tests). Document's minimum font size clamp (0 in my case) and harmless epsilon
        check in CSSStyleSelector function should still hold for svg.
2011-06-24  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Tests that font size for svg text zoom is clamped and we do not
        crash on ASSERT(isfinite(s)) in FontDescription.h
        https://bugs.webkit.org/show_bug.cgi?id=53449

        * svg/text/svg-zoom-large-value-expected.txt: Added.
        * svg/text/svg-zoom-large-value.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Fri, 24 Jun 2011 21:22:54 +0000 (21:22 +0000)]
2011-06-24  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Remove unsafe static_cast inside the InlineBox hierarchy
        https://bugs.webkit.org/show_bug.cgi?id=63077

        Refactoring only, no new test.

        * rendering/InlineFlowBox.h:
        (WebCore::toInlineFlowBox):
        * rendering/InlineTextBox.h:
        (WebCore::toInlineTextBox):
        Added the proper cast methods to those 2 classes from an InlineBox.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::nextLeafChild):
        (WebCore::InlineBox::prevLeafChild):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::getFlowSpacingLogicalWidth):
        (WebCore::InlineFlowBox::addToLine):
        (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
        (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
        (WebCore::InlineFlowBox::requiresIdeographicBaseline):
        (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
        (WebCore::InlineFlowBox::flipLinesInBlockDirection):
        (WebCore::InlineFlowBox::computeOverflow):
        (WebCore::InlineFlowBox::firstLeafChild):
        (WebCore::InlineFlowBox::lastLeafChild):
        (WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
        (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForBox):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::createLineBoxes):
        (WebCore::RenderBlock::constructLine):
        (WebCore::setLogicalWidthForTextRun):
        (WebCore::computeExpansionForJustifiedText):
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):
        (WebCore::RenderText::positionLineBox):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::ascentAndDescentForBox):
        (WebCore::RootInlineBox::includeFontForBox):
        (WebCore::RootInlineBox::includeGlyphsForBox):
        Replaced the static_cast in those previous call sites with the new cast methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Fri, 24 Jun 2011 20:54:58 +0000 (20:54 +0000)]
2011-06-24  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix.

        Build fix on Linux when using the GStreamer backend.

        No new tests, just a build fix.

        * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
        (FullScreenVideoWindow::keyPressEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude the directory containing the failing tests in titles of bugs filed from TestF...
aroben@apple.com [Fri, 24 Jun 2011 20:54:23 +0000 (20:54 +0000)]
Include the directory containing the failing tests in titles of bugs filed from TestFailures when all the tests won't fit

Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
which tests are failing

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
that ends in a path separator.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
in the title, first try to include the longest common prefix of the test names, then, if
that's still too long or there's no common prefix, fall back to not including any
information about which tests are failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude links to Trac in bugs filed from TestFailures
aroben@apple.com [Fri, 24 Jun 2011 20:53:51 +0000 (20:53 +0000)]
Include links to Trac in bugs filed from TestFailures

Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
Trac for suspect revisions

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
Trac.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
include a link to Trac for it in the first sentence of the description. Otherwise include a
link to the suspect range after the list of failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Fri, 24 Jun 2011 20:46:42 +0000 (20:46 +0000)]
2011-06-24  Nat Duca  <nduca@chromium.org>

        Unreviewed, rolling out r89694.
        http://trac.webkit.org/changeset/89694
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Test shell still not ready for animate changes.

        * WebCore.gypi:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::setViewport):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
        (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
        (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Removed.
        * platform/graphics/chromium/cc/CCMainThreadTask.h:
        * platform/graphics/chromium/cc/CCThread.cpp:
        (WebCore::CCThread::runLoop):
        * platform/graphics/chromium/cc/CCThreadTask.h:
2011-06-24  Nat Duca  <nduca@chromium.org>

        Unreviewed, rolling out r89694.
        http://trac.webkit.org/changeset/89694
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Test shell still not ready for animate changes.

        * WebKit.gypi:
        * public/WebWidget.h:
        (WebKit::WebWidget::animate):
        (WebKit::WebWidget::composite):
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::animate):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):
        (WebKit::WebViewImpl::animate):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::composite):
        (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
        (WebKit::WebView::zoomLevelToZoomFactor):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::reallocateRenderer):
        (WebKit::WebViewImpl::updateLayerRendererViewport):
        (WebKit::WebViewImpl::graphicsContext3D):
        * src/WebViewImpl.h:
        * tests/CCLayerTreeHostTest.cpp: Removed.
        * tests/CCThreadTest.cpp:
        (WebCore::TEST):
2011-06-24  Nat Duca  <nduca@chromium.org>

        Unreviewed, rolling out r89694.
        http://trac.webkit.org/changeset/89694
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Test shell still not ready for animate changes.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 24 Jun 2011 20:33:08 +0000 (20:33 +0000)]
2011-06-24  Chris Rogers  <crogers@google.com>

        Unreviewed build fix.

        Fix Chromium Linux Build
        https://bugs.webkit.org/show_bug.cgi?id=63349

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typos introduced in r89696
aroben@apple.com [Fri, 24 Jun 2011 19:56:57 +0000 (19:56 +0000)]
Fix typos introduced in r89696

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
callback, since that's what it expects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Henry Song <hsong@sisa.samsung.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 19:49:28 +0000 (19:49 +0000)]
2011-06-24  Henry Song  <hsong@sisa.samsung.com>

        Reviewed by Martin Robinson.

        Correct _sharedTimer value in SharedTimerEfl.cpp
        https://bugs.webkit.org/show_bug.cgi?id=62380

        SharedTimerEfl.cpp set _sharedTimer = 0 is incorrect in
        timerEvent(), we have observed addNewTimer() can be triggered
        by either inside timerFunction() or others that are not within
        timerFunction().  We have observed the following case:
        1. add a new Timer within timerFunction()
        2. timerFunction returns, set _sharedTimer = 0
        3. addNewTimer() is triggered again within webkit, don't know
           it triggers this.
        4. because at this moment, _sharedTimer == 0, the previous
           registered timer (in step 1) did not get removed.
        5. Now in ecore_timer, there are two timers with same callbacks
        6. From now on, timerFunction() will be called twice back-to-back
           in each ecore_timer loop.
        To correct this, we should set _sharedTimer = 0 before
        timerFunction() so that when addNewTimer() triggered within,
        we have a valid timer object.

        * platform/efl/SharedTimerEfl.cpp:
        (WebCore::timerEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake TestFailures correctly remember whether old-run-webkit-tests exited early
aroben@apple.com [Fri, 24 Jun 2011 19:37:22 +0000 (19:37 +0000)]
Make TestFailures correctly remember whether old-run-webkit-tests exited early

Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
completion after reload

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
in the PeristentCache, store an object that contains both the number of failures and whether
old-run-webkit-tests exited early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd links to regression ranges in Trac to the TestFailures page
aroben@apple.com [Fri, 24 Jun 2011 19:36:44 +0000 (19:36 +0000)]
Add links to regression ranges in Trac to the TestFailures page

Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
links to regression ranges in Trac

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
(Trac): This new class represents a particular instance of Trac for a single project.
(Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
repository path between the two specified revisions
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController): Added new trac argument.
(ViewController.prototype._displayBuilder): Moved code to create the DOM for the
passed/failed builds from here...
(ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
Trac if there are multiple suspect revisions.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Fri, 24 Jun 2011 19:29:16 +0000 (19:29 +0000)]
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
        thread and compositor thread halves of a composited view. Communication
        between the two is based on the design used in FileStreamProxy.

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::setViewport):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromiumImpl::create):
        (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent):
        (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl):
        (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread):
        (WebCore::LayerRendererChromiumImplProxy::create):
        (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl):
        (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy):
        (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
        (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
        (WebCore::CCHeadsUpDisplay::currentFrameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHost::CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::init):
        (WebCore::CCLayerTreeHost::~CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::beginCommit):
        (WebCore::CCLayerTreeHost::commitComplete):
        (WebCore::CCLayerTreeHost::animateAndLayout):
        (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
        (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHost::setNeedsRedraw):
        (WebCore::CCLayerTreeHost::updateLayers):
        * platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHost::frameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostCommitter::create):
        (WebCore::CCLayerTreeHostCommitter::commit):
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added.
        (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::beginCommit):
        (WebCore::CCLayerTreeHostImpl::commitComplete):
        (WebCore::CCLayerTreeHostImpl::drawLayers):
        (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient):
        (WebCore::CCLayerTreeHostImpl::frameNumber):
        (WebCore::CCLayerTreeHostImpl::sourceFrameNumber):
        (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added.
        (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):
        (WebCore::CCLayerTreeHostImplProxy::start):
        (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy):
        (WebCore::CCLayerTreeHostImplProxy::isStarted):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw):
        (WebCore::CCLayerTreeHostImplProxy::stop):
        (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::isMainThread):
        (WebCore::CCLayerTreeHostImplProxy::isCCThread):
        (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit):
        (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added.
        (WebCore::CCLayerTreeHostImplProxy::host):
        * platform/graphics/chromium/cc/CCMainThreadTask.h:
        * platform/graphics/chromium/cc/CCThread.cpp:
        (WebCore::CCThread::runLoop):
        * platform/graphics/chromium/cc/CCThreadTask.h:
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Redirect invalidates and scheduling into compositor when in
        threaded compositing mode. Add stress tests for CCLayerTreeHost.

        * WebKit.gypi:
        * public/WebWidget.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::animate):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::animate):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::animateAndLayout):
        (WebKit::WebViewImpl::updateLayers):
        (WebKit::WebViewImpl::composite):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::createLayerTreeHostContext3D):
        (WebKit::WebViewImpl::reallocateRenderer):
        (WebKit::WebViewImpl::updateLayerRendererSettings):
        (WebKit::WebViewImpl::updateLayerRendererViewport):
        * src/WebViewImpl.h:
        * tests/CCLayerTreeHostTest.cpp: Added.
        (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
        (WTF::CCLayerTreeHostTest::animateAndLayout):
        (WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
        (WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
        (WTF::CCLayerTreeHostTest::commitOnCCThread):
        (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
        (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
        (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTest::updateLayers):
        (WTF::CCLayerTreeHostTest::onBeginTest):
        (WTF::CCLayerTreeHostTest::doEndTest):
        (WTF::CCLayerTreeHostTest::onEndTest):
        (WTF::CCLayerTreeHostTest::runTest):
        (WTF::CCLayerTreeHostTest::testTimeout):
        (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
        (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
        (WTF::MockLayerTreeHostClient::animateAndLayout):
        (WTF::MockLayerTreeHostClient::updateLayers):
        (WTF::MockLayerTreeHostCommitter::create):
        (WTF::MockLayerTreeHostCommitter::commit):
        (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
        (WTF::MockLayerTreeHostImpl::create):
        (WTF::MockLayerTreeHostImpl::beginCommit):
        (WTF::MockLayerTreeHostImpl::commitComplete):
        (WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
        (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
        (WTF::MockLayerTreeHostImplProxy::create):
        (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
        (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
        (WTF::MockLayerTreeHost::MockLayerTreeHost):
        (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
        (WTF::MockLayerTreeHost::updateLayers):
        (WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
        (WTF::MockLayerTreeHost::beginCommit):
        (WTF::MockLayerTreeHost::commitComplete):
        (WTF::CCLayerTreeHostTest::doBeginTest):
        (WTF::CCLayerTreeHostTest::endTest):
        (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1):
        (WTF::CCLayerTreeHostTestShortlived1::beginTest):
        (WTF::CCLayerTreeHostTestShortlived1::afterTest):
        (WTF::TEST_F):
        (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2):
        (WTF::CCLayerTreeHostTestShortlived2::beginTest):
        (WTF::CCLayerTreeHostTestShortlived2::afterTest):
        (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3):
        (WTF::CCLayerTreeHostTestShortlived3::beginTest):
        (WTF::CCLayerTreeHostTestShortlived3::afterTest):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
        * tests/CCThreadTest.cpp:
        (WebCore::TEST):
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89694 268f45cc-cd09-0410-ab3c-d52691b4dbfc