WebKit-https.git
11 years ago2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Mon, 19 Apr 2010 17:38:11 +0000 (17:38 +0000)]
2010-04-19  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Add and enable the build of testatkroles to test ATK non form roles.

        * GNUmakefile.am:
2010-04-19  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Add testatkroles to test ATK non form roles.

        * tests/testatkroles.c: Added.
        (finish_loading):
        (atk_roles_fixture_setup):
        (atk_roles_fixture_teardown):
        (get_child_and_test_role):
        (test_webkit_atk_get_role_document_frame):
        (test_webkit_atk_get_role_heading):
        (test_webkit_atk_get_role_image):
        (test_webkit_atk_get_role_link):
        (test_webkit_atk_get_role_list_and_item):
        (test_webkit_atk_get_role_paragraph):
        (test_webkit_atk_get_role_section):
        (test_webkit_atk_get_role_table):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFinish exposing extremal shrink factors WebHTMLView uses when shrinking pages to...
mitz@apple.com [Mon, 19 Apr 2010 17:21:27 +0000 (17:21 +0000)]
Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by Sam Weinig.

* WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 19 Apr 2010 17:11:53 +0000 (17:11 +0000)]
2010-04-19  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Chromium build fix.

        * bindings/v8/JavaScriptCallFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 19 Apr 2010 17:01:39 +0000 (17:01 +0000)]
2010-04-19  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: implement JavaScriptCallFrame that works for v8.
        Implementing this binding for v8 allows to make evaluations on
        call frames and protects access to the debugger context from
        inspected context.

        https://bugs.webkit.org/show_bug.cgi?id=37755

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeType):
        * bindings/v8/JavaScriptCallFrame.cpp: Added.
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame):
        (WebCore::JavaScriptCallFrame::caller):
        (WebCore::JavaScriptCallFrame::sourceID):
        (WebCore::JavaScriptCallFrame::line):
        (WebCore::JavaScriptCallFrame::functionName):
        (WebCore::JavaScriptCallFrame::scopeChain):
        (WebCore::JavaScriptCallFrame::scopeType):
        (WebCore::JavaScriptCallFrame::thisObject):
        (WebCore::JavaScriptCallFrame::evaluate):
        * bindings/v8/JavaScriptCallFrame.h: Added.
        (WebCore::JavaScriptCallFrame::create):
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::currentCallFrame):
        * bindings/v8/ScriptDebugServer.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
        * bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added.
        (WebCore::V8JavaScriptCallFrame::evaluateCallback):
        (WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter):
        (WebCore::V8JavaScriptCallFrame::scopeTypeCallback):
        (WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter):
        (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
        * inspector/JavaScriptCallFrame.idl:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
ossy@webkit.org [Mon, 19 Apr 2010 16:41:05 +0000 (16:41 +0000)]
[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
Additionally fix some minor pixel differences.

Rubber-stamped by Simon Hausmann.

Compared to Mac png files and Mac expected files.

* platform/qt/Skipped:
* platform/qt/fast/frames/frame-navigation-expected.checksum: Added.
* platform/qt/fast/frames/frame-navigation-expected.png: Added.
* platform/qt/fast/frames/frame-navigation-expected.txt: Updated.
* platform/qt/fast/overflow/line-clamp-expected.checksum: Added.
* platform/qt/fast/overflow/line-clamp-expected.png: Added.
* platform/qt/fast/overflow/line-clamp-expected.txt: Added.
* platform/qt/fast/reflections/opacity-reflection-transform-expected.checksum: Added.
* platform/qt/fast/reflections/opacity-reflection-transform-expected.png: Added.
* platform/qt/fast/reflections/opacity-reflection-transform-expected.txt: Added.
* platform/qt/fast/repaint/fixed-tranformed-expected.checksum: Added.
* platform/qt/fast/repaint/fixed-tranformed-expected.png: Added.
* platform/qt/fast/repaint/fixed-tranformed-expected.txt: Added.
* platform/qt/fast/repaint/repaint-during-scroll-expected.checksum: Added.
* platform/qt/fast/repaint/repaint-during-scroll-expected.png: Added.
* platform/qt/fast/repaint/repaint-during-scroll-expected.txt: Added.
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.checksum: Added.
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.png: Added.
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Updated.
* platform/qt/http/tests/misc/error404-expected.checksum: Added.
* platform/qt/http/tests/misc/error404-expected.png: Added.
* platform/qt/http/tests/misc/error404-expected.txt: Added.
* platform/qt/http/tests/misc/frame-access-during-load-expected.checksum: Added.
* platform/qt/http/tests/misc/frame-access-during-load-expected.png: Added.
* platform/qt/http/tests/misc/frame-access-during-load-expected.txt: Added.
* platform/qt/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
* platform/qt/http/tests/misc/generated-content-inside-table-expected.png: Added.
* platform/qt/http/tests/misc/generated-content-inside-table-expected.txt: Added.
* platform/qt/http/tests/misc/iframe404-expected.checksum: Added.
* platform/qt/http/tests/misc/iframe404-expected.png: Added.
* platform/qt/http/tests/misc/iframe404-expected.txt: Added.
* platform/qt/http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
* platform/qt/http/tests/misc/location-replace-crossdomain-expected.png: Added.
* platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
* platform/qt/http/tests/uri/css-href-expected.checksum: Added.
* platform/qt/http/tests/uri/css-href-expected.png: Added.
* platform/qt/http/tests/uri/css-href-expected.txt: Updated.
* platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
* platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
* platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber Stamped by Adam Roben
jberlin@webkit.org [Mon, 19 Apr 2010 15:05:25 +0000 (15:05 +0000)]
Rubber Stamped by Adam Roben

Chromium Release Build Fix.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFirst steps towards fixing bug 24021 - pseudo-element styles not accessible / retriev...
jberlin@webkit.org [Mon, 19 Apr 2010 13:28:27 +0000 (13:28 +0000)]
First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
https://bugs.webkit.org/show_bug.cgi?id=24021

Reviewed by Dave Hyatt.

WebCore:

Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.

Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html

* WebCore.base.exp:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
Parse the and store the pseudo-element specifier from the string provided by the user.
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
(WebCore::CSSComputedStyleDeclaration::length):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
Ditto.
* css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Take into consideration the pseudo-element.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
(WebCore::nameToPseudoTypeMap):
Create and return the mapping between string names and PseudoTypes.
(WebCore::CSSSelector::parsePseudoType):
Parse and the given string into a PseudoType.
(WebCore::CSSSelector::extractPseudoType):
Refactored to use parsePseudoType.
* css/CSSSelector.h:

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Refactored to use pseudoId.

* dom/Element.cpp:
(WebCore::Element::computedStyle):
If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.
* dom/Element.h:
(WebCore::Element::virtualComputedStyle):
Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.

* dom/Node.h:
(WebCore::Node::computedStyle):
Ditto.
* dom/Node.cpp:
(WebCore::Node::virtualComputedStyle):
Get the computed style for the pseudo-element if it has been specified.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
Ditto.

LayoutTests:

* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] lacks clipToImageBuffer()
ossy@webkit.org [Mon, 19 Apr 2010 11:54:04 +0000 (11:54 +0000)]
[Qt] lacks clipToImageBuffer()
https://bugs.webkit.org/show_bug.cgi?id=24289

Skip svg/clip-path tests introduced in r52511,
and move clip related tests here.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 19 Apr 2010 09:05:53 +0000 (09:05 +0000)]
2010-04-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Fix a test initialization problem
        https://bugs.webkit.org/show_bug.cgi?id=37791

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (runTest): Call resetTestController() before runFileTest(). Some
          controllers initialize their fields in reset() and not in their
          constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 19 Apr 2010 08:40:46 +0000 (08:40 +0000)]
2010-04-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
        https://bugs.webkit.org/show_bug.cgi?id=37793

        We need to use WebKitDriver instead of ChromiumDriver for Chromium
        DRT because its interface is different from test_shell.

        Chromium DRT has no UI.  So we can't use it to show test results.

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 19 Apr 2010 06:36:31 +0000 (06:36 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        Make failure-reason more forgiving
        https://bugs.webkit.org/show_bug.cgi?id=37525

        Removed search_limit, which wasn't very useful anyway.
        Added a log about the long load time loading from the builders.
        Prompt the user for what revision to start walking from (makes it easy to restart upon failure).

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/tool/commands/queries.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Mon, 19 Apr 2010 05:13:27 +0000 (05:13 +0000)]
2010-04-18  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Laszlo Gombos.

        [WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
        https://bugs.webkit.org/show_bug.cgi?id=37434

        Windows CE supports little-endian format only, so don't define
        WTF_CPU_MIDDLE_ENDIAN=1.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCreated a class for check-webkit-style that encapsulates iterating
cjerdonek@webkit.org [Mon, 19 Apr 2010 04:26:52 +0000 (04:26 +0000)]
Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=37754

This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.

* Scripts/webkitpy/common/system/logtesting.py:
  - Added a logMessages() method to the LoggingTestCase class.
    This method provides unit tests with access to the raw list
    of log messages in case the tester needs to do something more
    than simply assert the list of existing messages.

* Scripts/webkitpy/style/checker.py:
  - Added a ProcessorBase class that processors of lists of lines
    should eventually inherit from.
  - Also added a FIXME to use the ProcessorBase class and the
    TextFileReader class added below.

* Scripts/webkitpy/style/filereader.py: Added.
  - Created a TextFileReader class that encapsulates reading
    and iterating over text files.

* Scripts/webkitpy/style/filereader_unittest.py: Added.
  - Added a TextFileReaderTest class to unit-test the
    new TextFileReader class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Mon, 19 Apr 2010 04:22:45 +0000 (04:22 +0000)]
2010-04-18  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix JavaScriptCore's include path for WinCE builds

        https://bugs.webkit.org/show_bug.cgi?id=36751

        * JavaScriptCore.pri:
2010-04-18  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix JavaScriptCore's include path for WinCE builds

        https://bugs.webkit.org/show_bug.cgi?id=36751

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Michael Forney <michael@mforney.org>
eric@webkit.org [Mon, 19 Apr 2010 04:08:31 +0000 (04:08 +0000)]
2010-04-18  Michael Forney  <michael@mforney.org>

        Reviewed by Laszlo Gombos.

        https://bugs.webkit.org/show_bug.cgi?id=37762

        Fixes the sandbox option in configure.

        * configure.ac: Fix cut and paste error in the sandbox option causing
        --{enable,disable}-sandbox to be ineffective, and it to be controlled
        by the ruby flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-15 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 19 Apr 2010 03:26:56 +0000 (03:26 +0000)]
2010-04-15  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] new-run-webkit-tests should be able to use chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=37645

        Make sure that the lack of a chromium checkout doesn't cause the script to
        fail.

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
            to be relative to an upstream output dir.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 21:25:33 +0000 (21:25 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Unreviewed, fixing the Qt bot.

        Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
        https://bugs.webkit.org/show_bug.cgi?id=37632

        * Scripts/run-webkit-tests:
         - Exit non-zero of launching the harness fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 20:58:47 +0000 (20:58 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Unreviewed, fixing the Qt bot.

        Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
        https://bugs.webkit.org/show_bug.cgi?id=37632

        * Scripts/run-webkit-tests:
         - Fix the wrapper to work for users who do not
           have WebKitTools/Scripts in their path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 18 Apr 2010 20:56:49 +0000 (20:56 +0000)]
2010-04-18  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Update a label of the diagram to better match the
        description in the text of the blog post.

        * blog-files/loader-diagram.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 20:34:17 +0000 (20:34 +0000)]
2010-04-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a layer of indirection when calling run-webkit-tests to
        allow testing new-run-webkit-tests on various platforms.
        https://bugs.webkit.org/show_bug.cgi?id=37632

        This will let us test and fix bugs in new-run-webkit-tests
        without needing to restart the buildbot master between tests.

        Currently this change leaves run-webkit-tests as-is, but once
        its landed we will easily be able to turn on/off
        new-run-webkit-tests for various ports/configurations.

        I will send a note out to webkit-dev about how we will
        be using this launcher script to test on the bots.

        * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
        * Scripts/run-webkit-tests:
         - A new script which decides whether to run new- or old-
           run-webkit-tests based on the platform.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Add some dummy argument handling for arguments which
           old-run-webkit-tests supports but new-run-webkit-tests
           does not yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 17:43:50 +0000 (17:43 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
        https://bugs.webkit.org/show_bug.cgi?id=33295

        The Gtk builders have been green every time I've looked
        at them in the last 5 days or so.  It would appear webkit
        is now keeping them green and we should update the core
        builder list to match reality.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add support for LayoutTestController commands
robert@webkit.org [Sun, 18 Apr 2010 11:01:58 +0000 (11:01 +0000)]
[Qt] Add support for LayoutTestController commands

2010-04-18  Robert Hogan  <robert@webkit.org>

        Unreviewed fix to pixel differences in unskipped layout tests.

        [Qt] Add support for LayoutTestController commands

        Fix up minor pixel differences on unskipped tests from r57793.

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * platform/qt/editing/deleting/smart-delete-003-expected.txt:
        * platform/qt/editing/deleting/smart-delete-004-expected.txt:
        * platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
        * platform/qt/editing/selection/5195166-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add support for LayoutTestController commands
robert@webkit.org [Sun, 18 Apr 2010 10:36:12 +0000 (10:36 +0000)]
[Qt] Add support for LayoutTestController commands
2010-04-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add support for LayoutTestController commands:
                   setSmartInsertDeleteEnabled
                   setSelectTrailingWhitespaceEnabled
                   execCommand
                   isCommandEnabled

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * Api/qwebpage_p.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled):
        (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled):
        (DumpRenderTreeSupportQt::executeCoreCommandByName):
        (DumpRenderTreeSupportQt::isCommandEnabled):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::smartInsertDeleteEnabled):
        (WebCore::EditorClientQt::toggleSmartInsertDelete):
        (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
        * WebCoreSupport/EditorClientQt.h:

2010-04-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add support for LayoutTestController commands:
                   setSmartInsertDeleteEnabled
                   setSelectTrailingWhitespaceEnabled
                   execCommand
                   isCommandEnabled

        Unskip tests:
        editing/deleting/smart-editing-disabled.html
        editing/execCommand/19089.html
        editing/execCommand/delete-image-in-anchor.html
        editing/execCommand/enabling-and-selection-2.html
        editing/selection/doubleclick-whitespace-crash.html
        editing/selection/doubleclick-whitespace-img-crash.html
        editing/selection/doubleclick-whitespace.html
        editing/selection/select-line.html
        editing/deleting/5300379.html
        editing/deleting/smart-delete-003.html
        editing/deleting/smart-delete-004.html
        editing/selection/5195166-1.html
        editing/selection/5195166-2.html

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * platform/qt/Skipped:
        * platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
        * platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
        * platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
        * platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
        * platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.

2010-04-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add support for LayoutTestController commands:
                   setSmartInsertDeleteEnabled
                   setSelectTrailingWhitespaceEnabled
                   execCommand
                   isCommandEnabled

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setSmartInsertDeleteEnabled):
        (LayoutTestController::setSelectTrailingWhitespaceEnabled):
        (LayoutTestController::execCommand):
        (LayoutTestController::isCommandEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Sun, 18 Apr 2010 10:25:54 +0000 (10:25 +0000)]
2010-04-18  Antonio Gomes  <tonikitoo@webkit.org>

        [Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)

        It was removed by r57511.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 18 Apr 2010 06:27:01 +0000 (06:27 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Added loader diagram for upcoming blog post.

        * blog-files/loader-diagram.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Barth.
ap@apple.com [Sun, 18 Apr 2010 06:03:46 +0000 (06:03 +0000)]
    Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=37720
        <rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
        crashes on SnowLeopard Release

        Tests:
        * fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
        * fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:

        * bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event
        listeners set via document.body. The body wrapper can go away if nothing else references it.

        * html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations,
        because we need to use window object as a wrapper, not the element. Marked all window event
        listeners as such for code generator.

        * html/HTMLFrameSetElement.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Juan C. Montemayor <jmonte03@cs.tufts.edu>
joepeck@webkit.org [Sun, 18 Apr 2010 05:00:26 +0000 (05:00 +0000)]
2010-04-17  Juan C. Montemayor  <jmonte03@cs.tufts.edu>

        Reviewed by Joseph Pecoraro.

        Databases pane doesn't recognize table creation/deletion
        https://bugs.webkit.org/show_bug.cgi?id=20219

        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 00:42:05 +0000 (00:42 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove steps_references and commands_references
        https://bugs.webkit.org/show_bug.cgi?id=37758

        We tried using the mumble_references convention to manage our
        dependencies, but it doesn't seem to be providing much value for the
        steps and commands module because these modules are small pieces of the
        larger tool module.  In this patch, I've removed the references file
        for these modules.

        I've left the style_references file for the style module because that
        module seems better isolated from the rest of webkitpy and the
        style_references file appears to be providing some value.

        * Scripts/webkitpy/tool/commands/commandtest.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/commands_references.py: Removed.
        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
        * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
        * Scripts/webkitpy/tool/steps_references.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Sat, 17 Apr 2010 20:43:30 +0000 (20:43 +0000)]
2010-04-17  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Auto-generate V8 bindings for canvas.* overloads
        https://bugs.webkit.org/show_bug.cgi?id=37453

        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
        * bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 17 Apr 2010 20:10:36 +0000 (20:10 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Test file: URL canonicalization
        https://bugs.webkit.org/show_bug.cgi?id=37700

        Re-land http://trac.webkit.org/changeset/57719, hopefully not breaking
        the Windows bot this time.

        * fast/url/file-expected.txt: Added.
        * fast/url/file.html: Added.
        * fast/url/mailto.html:
        * fast/url/script-tests/file.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 17 Apr 2010 20:00:39 +0000 (20:00 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
        iteration of this patch.

        Add URL parsing tests for relative URL resolution
        https://bugs.webkit.org/show_bug.cgi?id=37644

        I've split the platform specific parts of this test into separate
        files.  On KURL-based ports these should have the same results on every
        platform.  We can decide whether to have platform-specific behavior at
        a later time.

        * fast/url/relative-expected.txt: Added.
        * fast/url/relative-unix-expected.txt: Added.
        * fast/url/relative-unix.html: Added.
        * fast/url/relative-win-expected.txt: Added.
        * fast/url/relative-win.html: Added.
        * fast/url/relative.html: Added.
        * fast/url/script-tests/relative-unix.js: Added.
        * fast/url/script-tests/relative-win.js: Added.
        * fast/url/script-tests/relative.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Sat, 17 Apr 2010 18:42:07 +0000 (18:42 +0000)]
2010-04-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

        https://bugs.webkit.org/show_bug.cgi?id=37740

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp.
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        (WebCore::JavaScriptCallFrame::caller):
        (WebCore::JavaScriptCallFrame::scopeChain):
        (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
        (WebCore::JavaScriptCallFrame::functionName):
        (WebCore::JavaScriptCallFrame::type):
        (WebCore::JavaScriptCallFrame::thisObject):
        (WebCore::JavaScriptCallFrame::evaluate):
        * bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h.
        (WebCore::JavaScriptCallFrame::create):
        (WebCore::JavaScriptCallFrame::invalidate):
        (WebCore::JavaScriptCallFrame::isValid):
        (WebCore::JavaScriptCallFrame::sourceID):
        (WebCore::JavaScriptCallFrame::line):
        (WebCore::JavaScriptCallFrame::update):
        * inspector/InjectedScriptHost.h:
        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 17 Apr 2010 16:00:23 +0000 (16:00 +0000)]
2010-04-17  Alejandro G. Castro  <alex@igalia.com>

        Rubber-stamped by Xan Lopez.

        Skipping media/audio-constructor-preload.html
        https://bugs.webkit.org/show_bug.cgi?id=37753

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 17 Apr 2010 15:49:19 +0000 (15:49 +0000)]
2010-04-17  Alejandro G. Castro  <alex@igalia.com>

        Rubber-stamped by Xan Lopez.

        Skipping inspector/timeline-paint.html
        https://bugs.webkit.org/show_bug.cgi?id=37752

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 17 Apr 2010 15:16:15 +0000 (15:16 +0000)]
2010-04-17  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        We have to initialize the timer attribute after destroying it, not
        doing it was causing crashes in some situations.

        * webkit/webkitdownload.cpp:
        (webkit_download_finalize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Sat, 17 Apr 2010 14:55:28 +0000 (14:55 +0000)]
2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding definition of GLES2Context class.
        https://bugs.webkit.org/show_bug.cgi?id=37541

        No new functionality implemented yet, no tests.

        * WebCore.gypi: Added GLES2Context.h
        * platform/chromium/GLES2Context.h: Added.
2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
        https://bugs.webkit.org/show_bug.cgi?id=37541

        * WebKit.gyp:
        * public/WebGLES2Context.h: Added.
        (WebKit::WebGLES2Context::~WebGLES2Context):
        * src/GLES2Context.cpp: Added.
        (WebCore::GLES2ContextInternal::GLES2ContextInternal):
        (WebCore::GLES2ContextInternal::~GLES2ContextInternal):
        (WebCore::GLES2ContextInternal::getWebGLES2Context):
        (WebCore::GLES2ContextInternal::initialize):
        (WebCore::GLES2Context::create):
        (WebCore::GLES2Context::~GLES2Context):
        (WebCore::GLES2Context::initialize):
        (WebCore::GLES2Context::makeCurrent):
        (WebCore::GLES2Context::destroy):
        (WebCore::GLES2Context::swapBuffers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash while handling SVG font in the wrong namespace imported with @font-face
jchaffraix@webkit.org [Sat, 17 Apr 2010 13:37:55 +0000 (13:37 +0000)]
Crash while handling SVG font in the wrong namespace imported with @font-face
https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

* loader/CachedFont.cpp:
(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

* fast/invalid/invalidSVGFont-expected.txt: Added.
* fast/invalid/invalidSVGFont.html: Added.
* fast/invalid/resources/svgFontWrongNamespace.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 17 Apr 2010 08:13:20 +0000 (08:13 +0000)]
2010-04-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        WebKit needs a Chromium Mac EWS Builder
        https://bugs.webkit.org/show_bug.cgi?id=37742

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 17 Apr 2010 08:02:44 +0000 (08:02 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Fix expected results for unit test broken by
        http://trac.webkit.org/changeset/57772

        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r57770.
ossy@webkit.org [Sat, 17 Apr 2010 06:14:13 +0000 (06:14 +0000)]
Unreviewed, rolling out r57770.
http://trac.webkit.org/changeset/57770
https://bugs.webkit.org/show_bug.cgi?id=37746

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-16
8 test cases crashed (Requested by Ossy on #webkit).

WebCore:

* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sat, 17 Apr 2010 04:40:14 +0000 (04:40 +0000)]
2010-04-16  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=36312

        Adds support for the viewport meta tag. The code is largely derived in whole
        or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
        source code <http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

        * Android.mk: Added file ViewportArguments.cpp.
        * GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * dom/Document.cpp:
        (WebCore::isSeparator): Added.
        (WebCore::Document::processArguments): Added.
        (WebCore::Document::processViewport): Added.
        * dom/Document.h:
        * dom/ViewportArguments.cpp: Added.
        (WebCore::setViewportFeature):
        (WebCore::viewportErrorMessageTemplate):
        (WebCore::viewportErrorMessageLevel):
        (WebCore::reportViewportWarning):
        * dom/ViewportArguments.h: Added.
        (WebCore::):
        (WebCore::ViewportArguments::):
        (WebCore::ViewportArguments::ViewportArguments):
        (WebCore::ViewportArguments::hasCustomArgument):
        * html/HTMLMetaElement.cpp:
        (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
        * page/ChromeClient.h:
        (WebCore::ChromeClient::didReceiveViewportArguments): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove the need for a .defs file! Define WK_EXPORT.
weinig@apple.com [Sat, 17 Apr 2010 03:23:57 +0000 (03:23 +0000)]
Remove the need for a .defs file! Define WK_EXPORT.

Reviewed by Jon "The Belly" Honeycutt.

* UIProcess/API/C/WKBase.h:
* WebProcess/win/WebProcessMain.h:
* win/WebKit2.def: Removed.
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTeach windows MiniBrowser how to work with window.open()
weinig@apple.com [Sat, 17 Apr 2010 03:06:42 +0000 (03:06 +0000)]
Teach windows MiniBrowser how to work with window.open()
and targeted links.

Reviewed by Adam Roben.

WebKit2:

Export WKPageSetPageUIClient.

* win/WebKit2.def:

WebKitTools:

* MiniBrowser/win/BrowserView.cpp:
(createNewPage): Create a new BrowserWindow and return its page.
(showPage): Show the page.
(closePage): Empty implementation.
(runJavaScriptAlert): Empty implementation.
(BrowserView::create): Register a UIClient.
* MiniBrowser/win/BrowserView.h:
(BrowserView::webView): Added.
Change create to take a BrowserWindow instead of an HWND.

* MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::wndProc): Respond to WM_NCDESTROY.
(BrowserWindow::goToURL): Added. Forwards to BrowserView.
(BrowserWindow::onCreate): Don't always go to the default
url. Let the caller do this.
(BrowserWindow::onNCDestroy): Delete the window.
* MiniBrowser/win/BrowserWindow.h:
(BrowserWindow::view): Added.
(BrowserWindow::window): Added.

* MiniBrowser/win/main.cpp:
(_tWinMain):
Go to the default URL for the initial page. Allocate the initial
window on the heap for correctness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd the Windows Debug (Test) builder to the list of core builders
aroben@apple.com [Sat, 17 Apr 2010 02:53:59 +0000 (02:53 +0000)]
Add the Windows Debug (Test) builder to the list of core builders

It's been green for a few days now, and all the known Windows
flakiness is Release-only.

Rubber-stamped by Mark Rowe.

* Scripts/webkitpy/common/net/buildbot.py:
(BuildBot.core_builder_name_regexps): Added a regular expression to
match the "Windows Debug (Test)" builder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGet rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
dumi@chromium.org [Sat, 17 Apr 2010 02:30:14 +0000 (02:30 +0000)]
Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
https://bugs.webkit.org/show_bug.cgi?id=37733

Reviewed by Eric Seidel.

* src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sat, 17 Apr 2010 02:04:50 +0000 (02:04 +0000)]
2010-04-16  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Antti Koivisto.

        [Qt] GraphicsLayer: support fill-modes
        https://bugs.webkit.org/show_bug.cgi?id=36216

        Remove LayoutTests/animations/fill-mode-transform.html from the skip list

        * platform/qt/Skipped:
2010-04-16  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Antti Koivisto.

        [Qt] GraphicsLayer: support fill-modes
        https://bugs.webkit.org/show_bug.cgi?id=36216
        Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
        enables a key-frame animation to go to the animation's starting point before the delay,
        and/or to stay at the animation's ending point after its ended, without reverting to the default
        value.
        We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
        and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::AnimationQtBase::AnimationQtBase):
        (WebCore::TransformAnimationQt::~TransformAnimationQt):
        (WebCore::TransformAnimationQt::applyFrame):
        (WebCore::GraphicsLayerQt::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* bindings/js/JSDesktopNotificationsCustom.cpp:
barraclough@apple.com [Sat, 17 Apr 2010 00:24:42 +0000 (00:24 +0000)]
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

Reviewed by NOBODY (arm build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChanging the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
dumi@chromium.org [Sat, 17 Apr 2010 00:20:51 +0000 (00:20 +0000)]
Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

* public/WebSecurityOrigin.h:
* src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: [v8] In Workers, script errors right after close() are not delivered to...
dimich@chromium.org [Sat, 17 Apr 2010 00:12:30 +0000 (00:12 +0000)]
WebCore: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Existing worker-close.html will now work in Chromium.

* bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.
* bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.

WebKit/chromium: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.

LayoutTests: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Moved the expected result into platform-independent chromium subdirectory, since
the only chromium-specific difference is the way v8 formats an error message.
Also updated the expected result to match the passing now test.

* platform/chromium-win/fast/workers/worker-close-expected.txt: Removed.
* platform/chromium/fast/workers/worker-close-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=37735
barraclough@apple.com [Sat, 17 Apr 2010 00:10:39 +0000 (00:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString

Reviewed by Sam Weinig.

Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.

* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMBinding.cpp:
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSMimeTypeArrayCustom.cpp:
(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSPluginArrayCustom.cpp:
(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):
* bindings/js/JSPluginCustom.cpp:
(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::initPopStateEvent):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
* platform/text/AtomicString.h:
(WebCore::AtomicString::AtomicString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix typo from r55729
aroben@apple.com [Fri, 16 Apr 2010 23:58:22 +0000 (23:58 +0000)]
Fix typo from r55729

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix window.open() and targeted links.
weinig@apple.com [Fri, 16 Apr 2010 23:51:54 +0000 (23:51 +0000)]
Fix window.open() and targeted links.

Reviewed by Anders Carlsson.

WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveSyncMessage): Pass in the new pageID
instead of 0.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage): Allow for the page to have already
been created, as is the case with programmatic window opening from within
WebCore (e.g. window.open() or <a target="_blank">).

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(_createNewPage): Use the correct initializer to and load the window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fixing chromium build.
ajwong@chromium.org [Fri, 16 Apr 2010 23:45:20 +0000 (23:45 +0000)]
Not reviewed. Fixing chromium build.

[chromium] Upstream test_expectations.txt changes from chromium.
Mark letter_spacing.html as consistently failing for mac.
Fixing a syntax error in the test_expectations.txt file.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fixing chromiumg build.
ajwong@chromium.org [Fri, 16 Apr 2010 23:31:24 +0000 (23:31 +0000)]
Not reviewed. Fixing chromiumg build.

[chromium] filterRes.svg is consistently failing now. Marking as such.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't optimize debug builds.
weinig@apple.com [Fri, 16 Apr 2010 23:23:01 +0000 (23:23 +0000)]
Don't optimize debug builds.

Reviewed by Mark Rowe.

* WebKit2.xcodeproj/project.pbxproj: Define GCC_OPTIMIZATION_LEVEL correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 16 Apr 2010 23:13:30 +0000 (23:13 +0000)]
2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket crash when it receives bad header.
        https://bugs.webkit.org/show_bug.cgi?id=37682

        * websocket/tests/bad-handshake-crash-expected.txt: Added.
        * websocket/tests/bad-handshake-crash.html: Added.
        * websocket/tests/bad-handshake-crash_wsh.py: Added.
        * websocket/tests/script-tests/bad-handshake-crash.js: Added.
2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket crash when it receives bad header.
        https://bugs.webkit.org/show_bug.cgi?id=37682

        If name or value is not valid UTF-8, nameStr or valueStr would be
        null string, so crashed in headers->add(nameStr, valueStr).
        Check both nameStr and valueStr are not null string.
        Otherwise handshake will fail.

        Test: websocket/tests/bad-handshake-crash.html

        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7873647> Crash when updating hover state
mitz@apple.com [Fri, 16 Apr 2010 23:10:19 +0000 (23:10 +0000)]
<rdar://problem/7873647> Crash when updating hover state

Reviewed by Simon Fraser.

WebCore:

Test: fast/dynamic/hover-style-recalc-crash.html

Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.

LayoutTests:

* fast/dynamic/hover-style-recalc-crash-expected.txt: Added.
* fast/dynamic/hover-style-recalc-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Build fix.
ajwong@chromium.org [Fri, 16 Apr 2010 23:07:32 +0000 (23:07 +0000)]
Not reviewed. Build fix.

[chromium] Compile fix. Missing include header, and missing type conversion.

* src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3DInternal::beginPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
andersca@apple.com [Fri, 16 Apr 2010 22:42:29 +0000 (22:42 +0000)]
Fix build.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
barraclough@apple.com [Fri, 16 Apr 2010 22:31:40 +0000 (22:31 +0000)]
Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 16 Apr 2010 22:29:47 +0000 (22:29 +0000)]
2010-04-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, fixing Chromium test_expectations.txt due to removed tests in r57292.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake Safari correctly allocate 5MB of DB storage to all new
dumi@chromium.org [Fri, 16 Apr 2010 22:11:10 +0000 (22:11 +0000)]
Make Safari correctly allocate 5MB of DB storage to all new
origins.
https://bugs.webkit.org/show_bug.cgi?id=36671

Reviewed by Alexey Proskuryakov.

Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.

* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::detailsForNameAndOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 16 Apr 2010 22:06:17 +0000 (22:06 +0000)]
2010-04-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, checking in Chromium baselines for media/video-seek-past-end-playing.html.

        * platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Added.
        * platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
barraclough@apple.com [Fri, 16 Apr 2010 22:05:05 +0000 (22:05 +0000)]
Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 16 Apr 2010 21:55:19 +0000 (21:55 +0000)]
2010-04-16  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI
        https://bugs.webkit.org/show_bug.cgi?id=37218

        No new tests; tests will be added when we add upper layer implementations.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/FileStream.cpp:
        (WebCore::FileStream::stop):
        * html/FileStream.h:
        * html/FileStreamClient.h:
        (WebCore::FileStreamClient::didStop):
        * html/FileStreamProxy.cpp: Added
        * html/FileStreamProxy.h: Added
        * html/FileThreadTask.h: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
barraclough@apple.com [Fri, 16 Apr 2010 21:50:05 +0000 (21:50 +0000)]
Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

JavaScriptCore:

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:

WebCore:

Remove ustring() method, and constructor passed a UString.

* WebCore.base.exp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::stringimplToUString):
(WebCore::jsStringSlowCase):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):
* bindings/js/JSDOMBinding.h:
(WebCore::jsString):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::operator UString):
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::create):
* platform/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Fri, 16 Apr 2010 21:39:36 +0000 (21:39 +0000)]
2010-04-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] WebGL is not visible when QGLWidget viewport is used
        https://bugs.webkit.org/show_bug.cgi?id=37070

        Added HostWindow parameter to the constructor of GraphicsContext3D.
        Shared OpenGL context is initialized with parent QGLWidget.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::create):
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::getOwnerGLWidget):
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
2010-04-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] WebGL is not visible when QGLWidget viewport is used
        https://bugs.webkit.org/show_bug.cgi?id=37070

        Added HostWindow parameter to the constructor of GraphicsContext3D.
        Shared OpenGL context is initialized with parent QGLWidget.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Fri, 16 Apr 2010 21:27:03 +0000 (21:27 +0000)]
2010-04-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] WebKit compilation fails with --3d-canvas
        https://bugs.webkit.org/show_bug.cgi?id=37699

        API for readPixels() has been changed.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::readPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Fri, 16 Apr 2010 21:16:54 +0000 (21:16 +0000)]
2010-04-16  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Antti Koivisto.

        [Qt]QtLauncher crash on page with CSS 3D transform
        https://bugs.webkit.org/show_bug.cgi?id=36859

        Added a neccessary null-pointer check, lack of which created the crash circumstances.

        Tested by http://css-vfx.googlecode.com/svn/trunk/snowstack/snowstack.html

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Sergey Ulanov <sergeyu@chromium.org>
scherkus@chromium.org [Fri, 16 Apr 2010 21:14:47 +0000 (21:14 +0000)]
2010-04-16  Sergey Ulanov <sergeyu@chromium.org>

        Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

        * platform/chromium-linux/media/controls-after-reload-expected.checksum:
        * platform/chromium-linux/media/controls-after-reload-expected.png:
        * platform/chromium-linux/media/controls-strict-expected.checksum:
        * platform/chromium-linux/media/controls-strict-expected.png:
        * platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
        * platform/chromium-linux/media/video-aspect-ratio-expected.png:
        * platform/chromium-linux/media/video-controls-rendering-expected.checksum:
        * platform/chromium-linux/media/video-controls-rendering-expected.png:
        * platform/chromium-linux/media/video-display-toggle-expected.checksum:
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/media/video-layer-crash-expected.checksum:
        * platform/chromium-linux/media/video-layer-crash-expected.png:
        * platform/chromium-linux/media/video-no-audio-expected.checksum:
        * platform/chromium-linux/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/video-transformed-expected.checksum:
        * platform/chromium-linux/media/video-transformed-expected.png:
        * platform/chromium-linux/media/video-volume-slider-expected.checksum:
        * platform/chromium-linux/media/video-volume-slider-expected.png:
        * platform/chromium-linux/media/video-zoom-expected.checksum:
        * platform/chromium-linux/media/video-zoom-expected.png:
        * platform/chromium-mac/media/controls-after-reload-expected.checksum:
        * platform/chromium-mac/media/controls-after-reload-expected.png:
        * platform/chromium-mac/media/controls-strict-expected.checksum:
        * platform/chromium-mac/media/controls-strict-expected.png:
        * platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
        * platform/chromium-mac/media/video-aspect-ratio-expected.png:
        * platform/chromium-mac/media/video-controls-rendering-expected.checksum:
        * platform/chromium-mac/media/video-controls-rendering-expected.png:
        * platform/chromium-mac/media/video-display-toggle-expected.checksum:
        * platform/chromium-mac/media/video-display-toggle-expected.png:
        * platform/chromium-mac/media/video-layer-crash-expected.checksum:
        * platform/chromium-mac/media/video-layer-crash-expected.png:
        * platform/chromium-mac/media/video-no-audio-expected.checksum:
        * platform/chromium-mac/media/video-no-audio-expected.png:
        * platform/chromium-mac/media/video-transformed-expected.checksum:
        * platform/chromium-mac/media/video-transformed-expected.png:
        * platform/chromium-mac/media/video-volume-slider-expected.checksum:
        * platform/chromium-mac/media/video-volume-slider-expected.png:
        * platform/chromium-mac/media/video-zoom-expected.checksum:
        * platform/chromium-mac/media/video-zoom-expected.png:
        * platform/chromium-win/media/controls-after-reload-expected.checksum:
        * platform/chromium-win/media/controls-after-reload-expected.png:
        * platform/chromium-win/media/controls-strict-expected.checksum:
        * platform/chromium-win/media/controls-strict-expected.png:
        * platform/chromium-win/media/video-aspect-ratio-expected.checksum:
        * platform/chromium-win/media/video-aspect-ratio-expected.png:
        * platform/chromium-win/media/video-controls-rendering-expected.checksum:
        * platform/chromium-win/media/video-controls-rendering-expected.png:
        * platform/chromium-win/media/video-display-toggle-expected.checksum:
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/media/video-layer-crash-expected.checksum:
        * platform/chromium-win/media/video-layer-crash-expected.png:
        * platform/chromium-win/media/video-no-audio-expected.checksum:
        * platform/chromium-win/media/video-no-audio-expected.png:
        * platform/chromium-win/media/video-transformed-expected.checksum:
        * platform/chromium-win/media/video-transformed-expected.png:
        * platform/chromium-win/media/video-volume-slider-expected.checksum:
        * platform/chromium-win/media/video-volume-slider-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix links to layout test results from build status pages
aroben@apple.com [Fri, 16 Apr 2010 21:08:33 +0000 (21:08 +0000)]
Fix links to layout test results from build status pages

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ExtractTestResults.finished): Prepend "/" on the URL of the test
results page so that it is treated as an absolute URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake sure to update the current graphics context when calling out to AppKit.
andersca@apple.com [Fri, 16 Apr 2010 20:52:03 +0000 (20:52 +0000)]
Make sure to update the current graphics context when calling out to AppKit.

Reviewed by Sam Weinig.

* platform/mac/ThemeMac.mm:
(WebCore::paintCheckbox):
(WebCore::paintRadio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebFrame.cpp:
barraclough@apple.com [Fri, 16 Apr 2010 20:34:44 +0000 (20:34 +0000)]
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix windows build.
andersca@apple.com [Fri, 16 Apr 2010 20:26:07 +0000 (20:26 +0000)]
Fix windows build.

Reviewed by Sam Weinig.

* Platform/win/RunLoopWin.cpp:
(RunLoop::run):
* UIProcess/Launcher/win/WebProcessLauncher.cpp:
(WebKit::webThreadBody):
(WebKit::launchWebProcess):
* WebProcess/win/WebProcessMain.cpp:
(WebKit::WebProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=37675
barraclough@apple.com [Fri, 16 Apr 2010 20:21:03 +0000 (20:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37675
Remove casts/constructors to/from JSC::UString type from WebCore::String

Reviewed by Sam Weinig & Oliver Hunt.

WebCore's strings should not know about JSC::UString, this should be abstracted
away in the bindings.  Add explicit conversion methods rather than relying on
overloaded cast operators / constructors being implicitly called.

This patch only changes the class String, once this has landed StringImpl, and
hopefully AtomicString too, should follow suit.

WebCore:

This patch adds:
    WebCore::identifierToString
    WebCore::ustringToString
    WebCore::stringToUString

- to JSDOMBindings.h, and updates code to call these methods.

* WebCore.base.exp:
* WebCore.order:
* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/js/JSAudioConstructor.cpp:
(WebCore::constructAudio):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):
* bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setData):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMBinding.cpp:
(WebCore::identifierToString):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::JSDOMFormData::append):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::openDatabase):
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSEventSourceConstructor.cpp:
(WebCore::constructEventSource):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::callHTMLCollection):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::documentWrite):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::showContextMenu):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSOptionConstructor.cpp:
(WebCore::constructHTMLOptionElement):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSSharedWorkerConstructor.cpp:
(WebCore::constructSharedWorker):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
(WebCore::JSStorage::putDelegate):
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):
* bindings/js/JSWebKitCSSMatrixConstructor.cpp:
(WebCore::constructWebKitCSSMatrix):
* bindings/js/JSWebSocketConstructor.cpp:
(WebCore::constructWebSocket):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::send):
* bindings/js/JSWorkerConstructor.cpp:
(WebCore::constructWorker):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::importScripts):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::overrideMimeType):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* bindings/js/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):
* bindings/js/ScriptEventListener.cpp:
(WebCore::getEventListenerHandlerBody):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptObject::set):
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
* bindings/js/ScriptString.h:
(WebCore::ScriptString::operator String):
(WebCore::ScriptString::ustring):
(WebCore::ScriptString::operator+=):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::getString):
* bindings/js/ScriptValue.h:
(WebCore::ScriptValue::toString):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedObject::set):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::putProperty):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::StringSourceProvider):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
* bridge/c/c_utility.cpp:
(JSC::Bindings::identifierFromNPIdentifier):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::createProfileHeader):
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::sourceString):
* inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::functionName):
* platform/KURL.h:
(WebCore::KURL::operator const String&):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::operator UString):
* platform/text/AtomicString.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:

WebKit/mac:

* Plugins/Hosted/NetscapePluginHostProxy.mm:
(identifierFromIdentifierRep):
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::getPropertyNames):
* WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):
* WebView/WebScriptDebugger.mm:
(toNSURL):
* WebView/WebView.mm:
(aeDescFromJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake resizing responsive on Windows.
weinig@apple.com [Fri, 16 Apr 2010 20:15:45 +0000 (20:15 +0000)]
Make resizing responsive on Windows.

Reviewed by Anders Carlsson.

- Use the same waitFor logic as do for the Mac resizing
  DrawingAreaUpdateChunk code.

* Shared/win/UpdateChunk.cpp:
(WebKit::UpdateChunk::UpdateChunk):
* Shared/win/UpdateChunk.h:
 Add a constructor that only takes an IntRect and allocates
 the shared memory mapping for you.
* UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::ensureBackingStore):
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::drawUpdateChunkIntoBackingStore):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):
* UIProcess/win/DrawingAreaProxy.h:
Perform wait in paint as we do on the mac.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::onSizeEvent):
Change to use an IntSize.

* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::setSize):
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:
Specialize setSize() drawing and factor out painting
into a helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Build fix for chromium.
ajwong@chromium.org [Fri, 16 Apr 2010 20:13:49 +0000 (20:13 +0000)]
Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-mac and chromium-win
also since this test there as well.

* platform/chromium-mac/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
* platform/chromium-mac/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
* platform/chromium-mac/fast/url/standard-url-expected.txt:
* platform/chromium-win/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
* platform/chromium-win/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
* platform/chromium-win/fast/url/standard-url-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Build fix for chromium.
ajwong@chromium.org [Fri, 16 Apr 2010 20:05:37 +0000 (20:05 +0000)]
Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-linux since this test
fully passes on this platform.

* platform/chromium-linux/fast/url/host-expected.txt: Added.
* platform/chromium-linux/fast/url/path-expected.txt: Added.
* platform/chromium-linux/fast/url/standard-url-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 Apr 2010 19:58:02 +0000 (19:58 +0000)]
2010-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Always pass a view to the AppKit drawing functions.
        https://bugs.webkit.org/show_bug.cgi?id=37724

        * platform/mac/ThemeMac.mm:
        (WebCore::paintCheckbox):
        (WebCore::paintRadio):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuList):
        (WebCore::RenderThemeMac::paintSliderThumb):
        (WebCore::RenderThemeMac::paintSearchField):
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ap@apple.com [Fri, 16 Apr 2010 19:45:26 +0000 (19:45 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=37718
        Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks

        Test: fast/events/recorded-keydown-event.html

        * dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::charCode): Check if the view (window) is
        frameless.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 Apr 2010 19:36:08 +0000 (19:36 +0000)]
2010-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Make run loops be allocated as thread specific data.
        https://bugs.webkit.org/show_bug.cgi?id=37723

        * Platform/RunLoop.cpp:
        (RunLoop::initializeMainRunLoop):
        (RunLoop::current):
        (RunLoop::main):
        * Platform/RunLoop.h:
        * Platform/mac/RunLoopMac.mm:
        (RunLoop::run):
        (RunLoop::stop):
        * UIProcess/Launcher/mac/WebProcessLauncher.mm:
        (WebKit::webThreadBody):
        (WebKit::launchWebProcess):
        * UIProcess/ResponsivenessTimer.cpp:
        (WebKit::ResponsivenessTimer::ResponsivenessTimer):
        * WebProcess/Launching/mac/WebProcessMain.mm:
        (main):
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::isSeparateProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip HTMLFrameSetElement-window-eventListener-attributes.html on SnowLeopard
aroben@apple.com [Fri, 16 Apr 2010 18:52:36 +0000 (18:52 +0000)]
Skip HTMLFrameSetElement-window-eventListener-attributes.html on SnowLeopard

It is crashing sometimes. <http://webkit.org/b/37720> tracks investigating this.

Rubber-stamped by Sam Weinig.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake it possible for clients to instantiate a WebUserContentURLPattern
aroben@apple.com [Fri, 16 Apr 2010 18:40:10 +0000 (18:40 +0000)]
Make it possible for clients to instantiate a WebUserContentURLPattern

Reviewed by Tim Hatcher.

* ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which
lists all our instantiatable classes.

* WebKitClassFactory.cpp: Added a now-required #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSKip xss-DENIED-mime-type-execute-as-html.html to see if it makes the http test stop...
aroben@apple.com [Fri, 16 Apr 2010 18:19:30 +0000 (18:19 +0000)]
SKip xss-DENIED-mime-type-execute-as-html.html to see if it makes the http test stop timing out on Windows

<http://webkit.org/b/37714> tracks this investigation.

Rubber-stamped by Sam Weinig.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 16 Apr 2010 18:19:14 +0000 (18:19 +0000)]
2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Jian Li.

        [chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
        https://bugs.webkit.org/show_bug.cgi?id=37687

        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Jian Li <jianli@chromium.org>
dglazkov@chromium.org [Fri, 16 Apr 2010 18:07:57 +0000 (18:07 +0000)]
2010-04-16  Jian Li  <jianli@chromium.org>

        Reviewed by Dmitry Titov.

        Update FormDataList to fix style violations in old code.
        https://bugs.webkit.org/show_bug.cgi?id=37689

        * html/FormDataList.h:
        (WebCore::FormDataList::appendData):
        (WebCore::FormDataList::appendBlob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate FormDataList to fix style violations in old code.
jianli@chromium.org [Fri, 16 Apr 2010 18:00:48 +0000 (18:00 +0000)]
Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689

Reviewed by Dmitry Titov.

* html/FormDataList.h:
(WebCore::FormDataList::appendData):
(WebCore::FormDataList::appendBlob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix WebKit2 build.
andersca@apple.com [Fri, 16 Apr 2010 17:59:38 +0000 (17:59 +0000)]
Fix WebKit2 build.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Fri, 16 Apr 2010 17:18:12 +0000 (17:18 +0000)]
2010-04-16  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Select popups would assert when destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=37436

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::PopupContainer):
        (WebCore::PopupContainer::showPopup):
        (WebCore::PopupContainer::notifyPopupHidden):
        * platform/chromium/PopupMenuChromium.h:
2010-04-16  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Select popups would assert when destroyed.
        Also adding unit-tests for the select popup code.
        https://bugs.webkit.org/show_bug.cgi?id=37436

        * WebKit.gyp:
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::selectPopup):
        * tests/PopupMenuTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoExpose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
mitz@apple.com [Fri, 16 Apr 2010 17:09:17 +0000 (17:09 +0000)]
Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by John Sullivan.

* WebView/WebHTMLView.mm:
Replaced two macros with constants.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
(-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
* WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and
_WebHTMLViewPrintingMaximumShrinkFactor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Fri, 16 Apr 2010 16:18:08 +0000 (16:18 +0000)]
2010-04-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57719.
        http://trac.webkit.org/changeset/57719
        https://bugs.webkit.org/show_bug.cgi?id=37708

        Broke 8 URL tests on Windows due to use of file:///tmp/ URLs,
        which don't work on Windows. (Requested by aroben on #webkit).

        * fast/url/anchor.html:
        * fast/url/file-expected.txt: Removed.
        * fast/url/file.html: Removed.
        * fast/url/ipv4.html:
        * fast/url/path-url.html:
        * fast/url/port.html:
        * fast/url/query.html:
        * fast/url/script-tests/TEMPLATE.html:
        * fast/url/script-tests/file.js: Removed.
        * fast/url/standard-url.html:
        * fast/url/trivial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 16 Apr 2010 14:11:38 +0000 (14:11 +0000)]
2010-04-16  Antonio Gomes  <tonikitoo@webkit.org>

        Unreviewed QtWebKit (with Qt 4.7) build fix.

        Bug 37683 moved code from FontQt.cpp to FontPlatformDataQt.cpp but did not
        renamed the variable used.

        * platform/graphics/qt/FontPlatformDataQt.cpp:
        (WebCore::FontPlatformData::FontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Tony Chang <tony@chromium.org>
eric@webkit.org [Fri, 16 Apr 2010 07:36:05 +0000 (07:36 +0000)]
2010-04-16  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] build DRT on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37690

        * DEPS: Need to roll deps to remove a dependency on src/chrome
        * gyp_webkit: generate makefiles for DRT.gyp on Linux
2010-04-16  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] build DRT on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37690

        * Scripts/build-dumprendertree: Add support for win and linux

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 16 Apr 2010 07:27:09 +0000 (07:27 +0000)]
2010-04-16  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Test file: URL canonicalization
        https://bugs.webkit.org/show_bug.cgi?id=37700

        * fast/url/script-tests/file.js: Added new test.
        * fast/url/file-expected.txt: Added (expected results).
        * fast/url/file.html: Added (wrapper).

        * fast/url/script-tests/TEMPLATE.html: Add an explicit dependable
        <base> URL to the template, to avoid making test expectations
        system dependent.

        Other test wrappers regenerated for the above change:

        * fast/url/anchor.html:
        * fast/url/ipv4.html:
        * fast/url/path-url.html:
        * fast/url/port.html:
        * fast/url/query.html:
        * fast/url/standard-url.html:
        * fast/url/trivial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Fri, 16 Apr 2010 07:25:21 +0000 (07:25 +0000)]
2010-04-16  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Make GraphicsLayerQt always use ItemCoordinateCache, and remove ItemUsesExtendedStyleOption.
        This aligns our implementation with the Safari implementation - layers are always uploaded
        to textures in item units, and WebCore is responsible for the heuristics.

        [Qt] GraphicsLayer: performance optimizations
        https://bugs.webkit.org/show_bug.cgi?id=35393

        No new tests. Still no FPS benchmarks available (on any platform)
        but animations are noticably better.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        (WebCore::TransformAnimationQt::updateState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Fri, 16 Apr 2010 07:14:19 +0000 (07:14 +0000)]
2010-04-16  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WebCore::Font::font() causes a QFont detach
        https://bugs.webkit.org/show_bug.cgi?id=37683

        Moved the setStyleStrategy call to FontPlatformData
        to avoid the detach.

        Thanks to Holger for spotting this.

        * platform/graphics/qt/FontPlatformDataQt.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::font):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-15 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Fri, 16 Apr 2010 07:03:19 +0000 (07:03 +0000)]
2010-04-15  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to efl/WebCoreSupport.
        http://webkit.org/b/35915

        * efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added.
        * efl/WebCoreSupport/FrameLoaderClientEfl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-15 Matt Perry <mpcomplete@chromium.org>
eric@webkit.org [Fri, 16 Apr 2010 06:20:30 +0000 (06:20 +0000)]
2010-04-15  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Adam Barth.

        Remove the check for the main frame's scheme when deciding which
        v8 extensions to add to a script context. Instead, Chromium will
        handle that check elsewhere to allow finer-grained control over
        what APIs we expose to web pages.
        https://bugs.webkit.org/show_bug.cgi?id=37681

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::createNewContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-15 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Fri, 16 Apr 2010 05:59:15 +0000 (05:59 +0000)]
2010-04-15  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        No default selection for <select multiple> menu lists.
        https://bugs.webkit.org/show_bug.cgi?id=37530

        Manual test: manual-tests/no-listbox-rendering.html

        For menu lists, if the selection is not indicated by the html file, the first <option> will be
        selected after loading the page or reseting the form. On the other hand listboxes may have no
        element selected after loading the page or reseting the form.

        When NO_LISTBOX_RENDERING is enabled listboxes becomes menu lists. Those <select multiple>
        that did not have selected elements, now being menu lists, will have the first <option>
        selected. That is the behavior difference that this patch corrects.

        When NO_LISTBOX_RENDERING is enabled usesMenuList() always returns true then usesMenuList() cannot
        be used to decide about initial selection of the elements. This patch replaces (usesMenuLists())
        by (!multiple && size <= 1) where initial selection is considered.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::recalcListItems):
        (WebCore::SelectElement::reset):
        * manual-tests/no-listbox-rendering.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-15 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 16 Apr 2010 05:36:47 +0000 (05:36 +0000)]
2010-04-15  Tony Chang  <tony@chromium.org>

        Not reviewed, trying to make the tree green.

        [qt] fast/url/hosts.html is failing, skip until someone can
        investigate.
        https://bugs.webkit.org/show_bug.cgi?id=37697

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57713 268f45cc-cd09-0410-ab3c-d52691b4dbfc