WebKit-https.git
11 years agoAdding myself to the committer list. No review needed.
abecsi@webkit.org [Fri, 29 Jan 2010 03:40:08 +0000 (03:40 +0000)]
Adding myself to the committer list. No review needed.

* Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Steve Block <steveblock@google.com>
eric@webkit.org [Fri, 29 Jan 2010 02:57:58 +0000 (02:57 +0000)]
2010-01-28  Steve Block  <steveblock@google.com>

        Reviewed by David Levin.

        Use long long rather than int64 in V8Binding.h
        https://bugs.webkit.org/show_bug.cgi?id=34270

        No new tests, build fix only.

        * bindings/v8/V8Binding.h: Modified.
        (WebCore::toInt64): Returns long long

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Avi Drissman <avi@chromium.org>
eric@webkit.org [Fri, 29 Jan 2010 02:41:24 +0000 (02:41 +0000)]
2010-01-28  Avi Drissman  <avi@chromium.org>

        Reviewed by David Levin.

        Unused variable in ThemeMac (followup to change 49103).
        https://bugs.webkit.org/show_bug.cgi?id=34274

        Covered by existing tests.

        * platform/mac/ThemeMac.mm:
        (WebCore::setupButtonCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHuge plain text pastes are slow
enrica@apple.com [Fri, 29 Jan 2010 02:10:55 +0000 (02:10 +0000)]
Huge plain text pastes are slow
<rdar://problem/5195056>
https://bugs.webkit.org/show_bug.cgi?id=34237

Reviewed by Maciej Stachowiak.

WebCore:

No new tests. It is a performance improvement.

The performance of the plain text paste is now linear.
We treat as a special case, a fragment that has been
created from plain text. Finding VisiblePositions and
applying style is greatly simplified, given the nature of
the fragment.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/markup.cpp:
(WebCore::isPlainTextMarkup):
* editing/markup.h:

WebKit/mac:

Mail is ignoring the fragment created from plain text or HTML that is
passed to the delegate function, that creates a new one.
This fix avoids creating the fragment twice.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInitialize DOM Storage's quota's current length parameter when we clone it.
jorlow@chromium.org [Fri, 29 Jan 2010 01:57:59 +0000 (01:57 +0000)]
Initialize DOM Storage's quota's current length parameter when we clone it.
https://bugs.webkit.org/show_bug.cgi?id=34294

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-28
Reviewed by Adam Barth.

* storage/StorageMap.cpp:
(WebCore::StorageMap::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Fri, 29 Jan 2010 01:49:18 +0000 (01:49 +0000)]
2010-01-28  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Support kinetic scrolling on Maemo 5

        https://bugs.webkit.org/show_bug.cgi?id=34267

        Patch by Ralf Engels <ralf.engels@nokia.com> and
        Robert Griebl <rgriebl@trolltech.com>

        * Api/qwebview.cpp:
        (QWebViewKineticScroller::QWebViewKineticScroller):
        (QWebViewKineticScroller::eventFilter):
        (QWebViewKineticScroller::currentFrame):
        (QWebViewKineticScroller::scrollingFrameAt):
        (QWebViewKineticScroller::attachToWidget):
        (QWebViewKineticScroller::removeFromWidget):
        (QWebViewKineticScroller::positionRange):
        (QWebViewKineticScroller::position):
        (QWebViewKineticScroller::viewportSize):
        (QWebViewKineticScroller::setPosition):
        (QWebView::QWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Hayato Ito <hayato@chromium.org>
eric@webkit.org [Fri, 29 Jan 2010 01:32:49 +0000 (01:32 +0000)]
2010-01-28  Hayato Ito  <hayato@chromium.org>

        Reviewed by David Levin.

        Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.

        https://bugs.webkit.org/show_bug.cgi?id=34252

        * Scripts/make-script-test-wrappers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix after r53411 on WinCairo.
bfulgham@webkit.org [Fri, 29 Jan 2010 01:28:05 +0000 (01:28 +0000)]
Unreviewed build fix after r53411 on WinCairo.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Nayan Kumar K <nayankk@gmail.com>
eric@webkit.org [Fri, 29 Jan 2010 01:15:07 +0000 (01:15 +0000)]
2010-01-28  Nayan Kumar K  <nayankk@gmail.com>

        Reviewed by Laszlo Gombos.

        Fix for compilation error in WML enabled build introduced because of the changeset 53514.

        https://bugs.webkit.org/show_bug.cgi?id=34254

        * wml/WMLDocument.cpp:
        (WebCore::WMLDocument::WMLDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Alex Milowski <alex@milowski.com>
eric@webkit.org [Fri, 29 Jan 2010 00:57:49 +0000 (00:57 +0000)]
2010-01-28  Alex Milowski  <alex@milowski.com>

        Reviewed by Eric Seidel.

        Updates from CSS change for mathml.css

        * platform/mac/mathml/presentation/sub-expected.txt:
        * platform/mac/mathml/presentation/sup-expected.txt:
        * platform/mac/mathml/presentation/tables-expected.checksum:
        * platform/mac/mathml/presentation/tables-expected.png:
        * platform/mac/mathml/presentation/tables-expected.txt:
2010-01-28  Alex Milowski  <alex@milowski.com>

        Reviewed by Eric Seidel.

        Update to CSS to remove unnecessary line-height settings

        * css/mathml.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd missing includes for HashMap/HashSet
steveblock@google.com [Fri, 29 Jan 2010 00:31:22 +0000 (00:31 +0000)]
Add missing includes for HashMap/HashSet
https://bugs.webkit.org/show_bug.cgi?id=34276

Reviewed by David Levin.

No new tests, build fix only.

* platform/KURL.cpp: Modified. Include HashMap.h
* platform/network/CredentialStorage.cpp: Modified. Include HashMap.h and HashSet.h
* platform/network/ProtectionSpaceHash.h: Modified. Include HashTraits.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd missing svn:executable property on LayoutTests/http/tests/media/resources/setCook...
kov@webkit.org [Fri, 29 Jan 2010 00:20:51 +0000 (00:20 +0000)]
Add missing svn:executable property on LayoutTests/http/tests/media/resources/setCookie.cgi

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Sebastian Dröge <sebastian.droege@collabora.co.uk>
kov@webkit.org [Thu, 28 Jan 2010 23:56:34 +0000 (23:56 +0000)]
2010-01-28 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

        Pass cookies to the GStreamer HTTP source
        https://bugs.webkit.org/show_bug.cgi?id=34003

        Test: http/tests/media/video-cookie.html

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        When using an appropiate GStreamer HTTP source element, pass
        the cookies for the media URI to it. This fixes playback of
        the YouTube HTML5 videos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed buildfix after r54022.
ossy@webkit.org [Thu, 28 Jan 2010 23:50:29 +0000 (23:50 +0000)]
[Qt] Unreviewed buildfix after r54022.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::createStructure):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Incorrect small caps vs. normal text handling
ossy@webkit.org [Thu, 28 Jan 2010 23:19:47 +0000 (23:19 +0000)]
[Qt] Incorrect small caps vs. normal text handling
https://bugs.webkit.org/show_bug.cgi?id=34286

* platform/qt/Skipped: css2.1/t1505-c524-font-var-00-b.html skipped

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix an assertion beneath SerializedScriptValue::deserialize on 32-bit builds (e.g...
aroben@apple.com [Thu, 28 Jan 2010 23:03:10 +0000 (23:03 +0000)]
Fix an assertion beneath SerializedScriptValue::deserialize on 32-bit builds (e.g., on Windows)

Passing a JSValue to toRef on 32-bit builds can perform an allocation,
so we need to make sure we hold a JSLock when that occurs.

Reviewed by Oliver Hunt.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::serialize):
(WebCore::SerializedScriptValueData::deserialize):
Moved JSLocks from here...

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
...to this higher level, from which toRef can be called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 28 Jan 2010 22:51:06 +0000 (22:51 +0000)]
2010-01-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Simplify anonymous slot implementation
        https://bugs.webkit.org/show_bug.cgi?id=34282

        A class must now specify the number of slots it needs at construction time
        rather than later on with a transition.  This makes many things simpler,
        we no longer need to need an additional transition on object creation to
        add the anonymous slots, and we remove the need for a number of transition
        type checks.

        * API/JSCallbackConstructor.h:
        (JSC::JSCallbackConstructor::createStructure):
        * API/JSCallbackFunction.h:
        (JSC::JSCallbackFunction::createStructure):
        * API/JSCallbackObject.h:
        (JSC::JSCallbackObject::createStructure):
        * JavaScriptCore.exp:
        * debugger/DebuggerActivation.h:
        (JSC::DebuggerActivation::createStructure):
        * runtime/Arguments.h:
        (JSC::Arguments::createStructure):
        * runtime/BooleanObject.h:
        (JSC::BooleanObject::createStructure):
        * runtime/DateInstance.h:
        (JSC::DateInstance::createStructure):
        * runtime/DatePrototype.h:
        (JSC::DatePrototype::createStructure):
        * runtime/FunctionPrototype.h:
        (JSC::FunctionPrototype::createStructure):
        * runtime/GetterSetter.h:
        (JSC::GetterSetter::createStructure):
        * runtime/GlobalEvalFunction.h:
        (JSC::GlobalEvalFunction::createStructure):
        * runtime/InternalFunction.h:
        (JSC::InternalFunction::createStructure):
        * runtime/JSAPIValueWrapper.h:
        (JSC::JSAPIValueWrapper::createStructure):
        * runtime/JSActivation.h:
        (JSC::JSActivation::createStructure):
        * runtime/JSArray.h:
        (JSC::JSArray::createStructure):
        * runtime/JSByteArray.cpp:
        (JSC::JSByteArray::createStructure):
        * runtime/JSCell.h:
        (JSC::JSCell::createDummyStructure):
        * runtime/JSFunction.h:
        (JSC::JSFunction::createStructure):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::createStructure):
        * runtime/JSNotAnObject.h:
        (JSC::JSNotAnObject::createStructure):
        * runtime/JSONObject.h:
        (JSC::JSONObject::createStructure):
        * runtime/JSObject.h:
        (JSC::JSObject::createStructure):
        (JSC::JSObject::putAnonymousValue):
        (JSC::JSObject::getAnonymousValue):
        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::createStructure):
        * runtime/JSStaticScopeObject.h:
        (JSC::JSStaticScopeObject::createStructure):
        * runtime/JSString.h:
        (JSC::Fiber::createStructure):
        * runtime/JSVariableObject.h:
        (JSC::JSVariableObject::createStructure):
        * runtime/JSWrapperObject.h:
        (JSC::JSWrapperObject::createStructure):
        (JSC::JSWrapperObject::JSWrapperObject):
        * runtime/MathObject.h:
        (JSC::MathObject::createStructure):
        * runtime/NumberConstructor.h:
        (JSC::NumberConstructor::createStructure):
        * runtime/NumberObject.h:
        (JSC::NumberObject::createStructure):
        * runtime/RegExpConstructor.h:
        (JSC::RegExpConstructor::createStructure):
        * runtime/RegExpObject.h:
        (JSC::RegExpObject::createStructure):
        * runtime/StringObject.h:
        (JSC::StringObject::createStructure):
        * runtime/StringObjectThatMasqueradesAsUndefined.h:
        (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
        * runtime/Structure.cpp:
        (JSC::Structure::~Structure):
        (JSC::Structure::materializePropertyMap):
        * runtime/Structure.h:
        (JSC::Structure::create):
        (JSC::Structure::anonymousSlotCount):
        * runtime/StructureTransitionTable.h:
2010-01-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Simplify anonymous slot implementation
        https://bugs.webkit.org/show_bug.cgi?id=34282

        Update JSGlue Structure usage to pass the anonymous slot count.

        * UserObjectImp.h:
        (UserObjectImp::createStructure):
2010-01-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Simplify anonymous slot implementation
        https://bugs.webkit.org/show_bug.cgi?id=34282

        Update the WebCore JS DOM bindings to correctly pass and
        propagate the anonymous slot count information.

        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObjectWithGlobalPointer::createStructure):
        (WebCore::DOMConstructorObject::createStructure):
        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::createStructure):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/objc/objc_runtime.h:
        (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
        * bridge/runtime_array.h:
        (JSC::RuntimeArray::createStructure):
        * bridge/runtime_method.h:
        (JSC::RuntimeMethod::createStructure):
        * bridge/runtime_object.h:
        (JSC::RuntimeObjectImp::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[wx] Build fix after removal of the zlib image decoder.
kevino@webkit.org [Thu, 28 Jan 2010 22:26:39 +0000 (22:26 +0000)]
[wx] Build fix after removal of the zlib image decoder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 28 Jan 2010 22:17:23 +0000 (22:17 +0000)]
2010-01-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] hebrew vowel marks incorrectly positioned
        https://bugs.webkit.org/show_bug.cgi?id=34234

        Add a layout test containing some Hebrew vowels.

        * fast/text/international/hebrew-vowels.html: Added.
2010-01-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] hebrew vowel marks incorrectly positioned
        https://bugs.webkit.org/show_bug.cgi?id=34234

        Fix glyph metrics computation such that the glyph offsets
        are correct, so we can now make use of them.

        Test: fast/text/international/hebrew-vowels.html

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::createGlyphArrays): initialize per-glyph
        offset table.
        (WebCore::TextRunWalker::setGlyphXPositions): use per-glyph
        offsets.
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::getGlyphMetrics): fix metrics computation such that
        per-glyph offsets are computed correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 28 Jan 2010 22:08:56 +0000 (22:08 +0000)]
2010-01-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Qt] Build fix if websockets support is turned off after r53947.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 28 Jan 2010 21:44:24 +0000 (21:44 +0000)]
2010-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54012.
        http://trac.webkit.org/changeset/54012
        https://bugs.webkit.org/show_bug.cgi?id=34266

        Introduced 33 crashes in V8 traversal/ tests.

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::mainWorldScriptState):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptState.cpp:
        * bindings/js/ScriptState.h:
        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::mainWorldScriptState):
        (WebCore::ScriptController::currentScriptState):
        (WebCore::ScriptController::clearWindowShell):
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptScope.cpp:
        (WebCore::ScriptScope::ScriptScope):
        (WebCore::ScriptScope::success):
        * bindings/v8/ScriptScope.h:
        * bindings/v8/ScriptState.cpp:
        (WebCore::ScriptState::ScriptState):
        (WebCore::scriptStateFromPage):
        * bindings/v8/ScriptState.h:
        (WebCore::ScriptState::ScriptState):
        (WebCore::ScriptState::frame):
        * bindings/v8/V8HiddenPropertyName.h:
        * bindings/v8/V8IsolatedContext.cpp:
        (WebCore::V8IsolatedContext::scriptState):
        * bindings/v8/V8IsolatedContext.h:
        * bindings/v8/V8Utilities.cpp:
        (WebCore::getScriptExecutionContext):
        (WebCore::reportException):
        * bindings/v8/custom/V8NodeIteratorCustom.cpp:
        (WebCore::V8NodeIterator::nextNodeCallback):
        (WebCore::V8NodeIterator::previousNodeCallback):
        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
        (WebCore::V8TreeWalker::parentNodeCallback):
        (WebCore::V8TreeWalker::firstChildCallback):
        (WebCore::V8TreeWalker::lastChildCallback):
        (WebCore::V8TreeWalker::nextNodeCallback):
        (WebCore::V8TreeWalker::previousNodeCallback):
        (WebCore::V8TreeWalker::nextSiblingCallback):
        (WebCore::V8TreeWalker::previousSiblingCallback):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::injectedScriptForNodeId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReapply 54008: Expand the NotificationPresenter::checkPermission() interface
aa@chromium.org [Thu, 28 Jan 2010 21:36:35 +0000 (21:36 +0000)]
Reapply 54008: Expand the NotificationPresenter::checkPermission() interface
to send the full URL of the requesting context, as well as a pointer to the
document if that context was a document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 28 Jan 2010 21:34:44 +0000 (21:34 +0000)]
2010-01-28  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Fix missing forward-declarations and includes in V8 bindings
        https://bugs.webkit.org/show_bug.cgi?id=34272

        No new tests, build fix only.

        * bindings/v8/ScriptController.h: Modified. Forward-declare NPObject
        * bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h
        * bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 28 Jan 2010 21:24:51 +0000 (21:24 +0000)]
2010-01-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, trivial baseline update.

        Update baseline for "Animated scaling of background-image is too slow"
        https://bugs.webkit.org/show_bug.cgi?id=33808

        * platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
        * platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 28 Jan 2010 21:05:51 +0000 (21:05 +0000)]
2010-01-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Remove ScriptState::frame which is only used for reporting exceptions
        in some cases in a way that diverges from the regular exception reporting in
        v8 bindings.

        Cache ScriptState directly on v8::Context instead of providing
        implementations specific for isolated worlds and ScriptController.

        https://bugs.webkit.org/show_bug.cgi?id=34266

        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptState.cpp:
        (WebCore::mainWorldScriptState):
        * bindings/js/ScriptState.h:
        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::clearWindowShell):
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptScope.cpp:
        (WebCore::ScriptScope::ScriptScope):
        (WebCore::ScriptScope::success):
        * bindings/v8/ScriptScope.h:
        * bindings/v8/ScriptState.cpp:
        (WebCore::ScriptState::ScriptState):
        (WebCore::ScriptState::forContext):
        (WebCore::ScriptState::current):
        (WebCore::ScriptState::empty):
        (WebCore::ScriptState::weakReferenceCallback):
        (WebCore::mainWorldScriptState):
        (WebCore::scriptStateFromPage):
        * bindings/v8/ScriptState.h:
        * bindings/v8/V8HiddenPropertyName.h:
        * bindings/v8/V8IsolatedContext.cpp:
        * bindings/v8/V8IsolatedContext.h:
        * bindings/v8/V8Utilities.cpp:
        (WebCore::getScriptExecutionContext):
        (WebCore::reportException):
        * bindings/v8/custom/V8NodeIteratorCustom.cpp:
        (WebCore::V8NodeIterator::nextNodeCallback):
        (WebCore::V8NodeIterator::previousNodeCallback):
        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
        (WebCore::V8TreeWalker::parentNodeCallback):
        (WebCore::V8TreeWalker::firstChildCallback):
        (WebCore::V8TreeWalker::lastChildCallback):
        (WebCore::V8TreeWalker::nextNodeCallback):
        (WebCore::V8TreeWalker::previousNodeCallback):
        (WebCore::V8TreeWalker::nextSiblingCallback):
        (WebCore::V8TreeWalker::previousSiblingCallback):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::injectedScriptForNodeId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agorevert
aa@chromium.org [Thu, 28 Jan 2010 20:38:02 +0000 (20:38 +0000)]
revert

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Jan 2010 20:34:36 +0000 (20:34 +0000)]
2010-01-28  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Remove XSSAuditor false positive for Google Translate
        https://bugs.webkit.org/show_bug.cgi?id=34242

        Add a test that we allow attackers to inject directly into the href
        property of the base tag.

        * http/tests/security/xssAuditor/base-href-direct-expected.txt: Added.
        * http/tests/security/xssAuditor/base-href-direct.html: Added.
        * http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added.
2010-01-28  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Remove XSSAuditor false positive for Google Translate
        https://bugs.webkit.org/show_bug.cgi?id=34242

        Google translate takes a base URL as a parameter, causing a false
        positive in the XSS filter.  This patch removes the false positive by
        allowing direct injections into the href property of the base tag.

        Test: http/tests/security/xssAuditor/base-href-direct.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canSetBaseElementURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 28 Jan 2010 20:27:38 +0000 (20:27 +0000)]
2010-01-28  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Save additional memory in SVG*Element classes, by introducing SVGElementRareData
        https://bugs.webkit.org/show_bug.cgi?id=34268

        Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement.
        This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase.

        SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from
        NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element.

        * GNUmakefile.am: Add SVGElementRareData.h to build.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated.
        (WebCore::Node::Node):
        * dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now.
        (WebCore::Node::hasRareSVGData):
        * svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying.
        (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
        * svg/SVGAnimateTransformElement.cpp: Ditto.
        (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
        * svg/SVGAnimationElement.cpp: Ditto.
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
        * svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData.
        (WebCore::SVGElement::SVGElement):
        (WebCore::SVGElement::~SVGElement):
        (WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData().
        (WebCore::SVGElement::ensureRareSVGData): Dito.
        (WebCore::SVGElement::accessDocumentSVGExtensions):
        (WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData.
        (WebCore::SVGElement::removeInstanceMapping): Ditto.
        (WebCore::SVGElement::instancesForElement): Ditto.
        (WebCore::SVGElement::setCursorElement): Ditto.
        (WebCore::SVGElement::setCursorImageValue): Ditto.
        * svg/SVGElement.h:
        * svg/SVGElementInstance.cpp: Ditto.
        (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
        * svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same.
        (WebCore::SVGElementRareData::SVGElementRareData):
        (WebCore::SVGElementRareData::rareDataMap):
        (WebCore::SVGElementRareData::rareDataFromMap):
        (WebCore::SVGElementRareData::elementInstances):
        (WebCore::SVGElementRareData::instanceUpdatesBlocked):
        (WebCore::SVGElementRareData::setInstanceUpdatesBlocked):
        (WebCore::SVGElementRareData::cursorElement):
        (WebCore::SVGElementRareData::setCursorElement):
        (WebCore::SVGElementRareData::cursorImageValue):
        (WebCore::SVGElementRareData::setCursorImageValue):
        * svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData.
        (WebCore::SVGStyledElement::SVGStyledElement):
        (WebCore::SVGStyledElement::instanceUpdatesBlocked):
        (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
        * svg/SVGStyledElement.h:
        * svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference.
        (WebCore::dumpInstanceTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Aaron Boodman <aa@chromium.org>
aa@chromium.org [Thu, 28 Jan 2010 19:24:08 +0000 (19:24 +0000)]
2010-01-28  Aaron Boodman  <aa@chromium.org>

        Reviewed by Darin Adler.

        Expand the NotificationPresenter::checkPermission() interface to send the full
        URL of the requesting context, as well as a pointer to the document if that
        context was a document.

        https://bugs.webkit.org/show_bug.cgi?id=34238

        * notifications/Notification.cpp:
        (WebCore::Notification::Notification):
        * notifications/NotificationCenter.cpp:
        (WebCore::NotificationCenter::NotificationCenter):
        (WebCore::NotificationCenter::checkPermission):
        Pass the full URL and document from the requesting context when calling
        NotificationPresenter::checkPermission().

        * notifications/NotificationPresenter.h:
        (WebCore::NotificationPresenter::):
        Expand interface.
2010-01-27  Aaron Boodman  <aa@chromium.org>

        Reviewed by Darin Adler.

        Send full URL and application id of requesting context to Chromium
        when checking notification permissions.

        https://bugs.webkit.org/show_bug.cgi?id=34238

        * public/WebDocument.h:
        * src/WebDocument.cpp:
        (WebKit::WebDocument::applicationID):
        Implement applicationID() method.

        * public/WebNotificationPresenter.h:
        * src/NotificationPresenterImpl.cpp:
        (WebKit::NotificationPresenterImpl::checkPermission):
        * src/NotificationPresenterImpl.h:
        Send applicationID and full URL through to Chromium.
2010-01-27  Aaron Boodman  <aa@chromium.org>

        Expand NotificationCenter::checkPermission() interface.
        It now passes the full URL instead of just the origin.

        https://bugs.webkit.org/show_bug.cgi?id=34238

        * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
        (WebDesktopNotificationsDelegate::checkPermission):
        * WebCoreSupport/WebDesktopNotificationsDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, trivial expectations update.
jam@chromium.org [Thu, 28 Jan 2010 18:34:02 +0000 (18:34 +0000)]
Unreviewed, trivial expectations update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 28 Jan 2010 18:07:14 +0000 (18:07 +0000)]
2010-01-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Video can overlap position:fixed element when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=32180

        When the scroll position changes, and we're using overlap to decide what gets composited,
        then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements
        overlap composited elements (e.g. video).

        Test: compositing/geometry/video-fixed-scrolling.html

        * page/FrameView.cpp:
        (WebCore::FrameView::updateCompositingLayers):
        (WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers()
        with the type of change that occurred.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check
        for hierarchy update if m_compositingConsultsOverlap is true, and do
        a geometry update. For other changes, always check for hierarchy updates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for user stylesheet bugs where they get parsed using the wrong compatibility...
hyatt@apple.com [Thu, 28 Jan 2010 17:47:30 +0000 (17:47 +0000)]
Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode.  This was a regression
caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM.

Reviewed by Darin Adler.

This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it.

In order to avoid creating the style selector before the compatibility mode has been determined, document
style is now created without having a dependence on an instantiated style selector.  The creation of the style
is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related
functions have been made static as well so that they can be used by this method.

m_styleSelector on Document is now an OwnPtr.

Added userscripts/mixed-case-stylesheet.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
(WebCore::CSSStyleSelector::fontSizeForKeyword):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::attach):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
(WebCore::Document::styleSelector):
(WebCore::Document::visuallyOrdered):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::determineParseMode):
* loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Anton Muhin <antonm@google.com>
eric@webkit.org [Thu, 28 Jan 2010 17:03:50 +0000 (17:03 +0000)]
2010-01-28  Anton Muhin  <antonm@google.com>

        Reviewed by Alexey Proskuryakov.

        Add layout tests to verify assignment to items of NodeList
        https://bugs.webkit.org/show_bug.cgi?id=34213

        * fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added.
        * fast/dom/NodeList/nodelist-item-assignment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 16:47:04 +0000 (16:47 +0000)]
2010-01-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=34245

        No functional changes.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp.
        (WebCore::DateComponents::maxWeekNumberInYear):
        (WebCore::DateComponents::parseYear):
        (WebCore::DateComponents::addDay):
        (WebCore::DateComponents::addMinute):
        (WebCore::DateComponents::parseTimeZone):
        (WebCore::DateComponents::parseMonth):
        (WebCore::DateComponents::parseDate):
        (WebCore::DateComponents::parseWeek):
        (WebCore::DateComponents::parseTime):
        (WebCore::DateComponents::parseDateTimeLocal):
        (WebCore::DateComponents::parseDateTime):
        (WebCore::DateComponents::setMillisecondsSinceMidnightInternal):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDate):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime):
        (WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal):
        (WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
        (WebCore::DateComponents::setMillisecondsSinceMidnight):
        (WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
        (WebCore::DateComponents::millisecondsSinceEpochForTime):
        (WebCore::DateComponents::millisecondsSinceEpoch):
        (WebCore::DateComponents::toStringForTime):
        (WebCore::DateComponents::toString):
        * html/DateComponents.h: Copied from WebCore/html/ISODateTime.h.
        (WebCore::DateComponents::DateComponents):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseToDouble):
        (WebCore::HTMLInputElement::valueAsDate):
        (WebCore::HTMLInputElement::setValueAsDate):
        (WebCore::HTMLInputElement::setValueAsNumber):
        (WebCore::HTMLInputElement::formStringToDateComponents):
        * html/HTMLInputElement.h:
        * html/ISODateTime.cpp: Removed.
        * html/ISODateTime.h: Removed.
        * html/ValidityState.cpp:
        (WebCore::ValidityState::typeMismatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed, roll out r54000.
ossy@webkit.org [Thu, 28 Jan 2010 16:44:00 +0000 (16:44 +0000)]
[Qt] Unreviewed, roll out r54000.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::display):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 16:28:41 +0000 (16:28 +0000)]
2010-01-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Use platform-specific monospace fonts in the Web Inspector

        Move the OS version detection code into the frontend,
        add custom CSS monospace styles for known platforms.
        https://bugs.webkit.org/show_bug.cgi?id=34040

        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::platform):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView):
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
        (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createConditionElement):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.URLRegExp.i.get platform):
        (WebInspector._detectPlatform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Thu, 28 Jan 2010 14:41:05 +0000 (14:41 +0000)]
2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement the display() method of the layout test controller
        https://bugs.webkit.org/show_bug.cgi?id=34258

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::showPage):
        (WebCore::DumpRenderTree::hidePage):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::display):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDo not set the combobox font on Maemo5 and S60; use the
kenneth@webkit.org [Thu, 28 Jan 2010 13:39:14 +0000 (13:39 +0000)]
Do not set the combobox font on Maemo5 and S60; use the
default instead.

Reviewed by Simon Hausmann.

* WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoEliminated the filename parameter from functions in
cjerdonek@webkit.org [Thu, 28 Jan 2010 13:22:16 +0000 (13:22 +0000)]
Eliminated the filename parameter from functions in
check-webkit-style's cpp.py where it is no longer used.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34249

* Scripts/webkitpy/style/processors/cpp.py:
  - Reduced number of occurrences of "filename" variable from
    approximately 200 to 120.

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Refactored unit tests as necessary to accommodate changes to cpp.py.
  - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
    where the incorrect file extension was getting passed to
    cpp_style.check_language().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix for endless print loop when printing web pages
hausmann@webkit.org [Thu, 28 Jan 2010 13:06:49 +0000 (13:06 +0000)]
[Qt] Fix for endless print loop when printing web pages

Patch by Trond Kjernåsen <trond@trolltech.com> on 2010-01-28
Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::print):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 12:34:02 +0000 (12:34 +0000)]
2010-01-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Simplify views logic in Profiler panel, and fix the problem described in the issue.
        Remove image from Welcome view.
        Preserve border on status bar-like buttons in Welcome view on window deactivation.

        https://bugs.webkit.org/show_bug.cgi?id=34201

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.show):
        (WebInspector.ProfilesPanel.prototype.reset):
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.showView):
        (WebInspector.ProfilesPanel.prototype._updateInterface):
        * inspector/front-end/WelcomeView.js:
        (WebInspector.WelcomeView):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Speed up KURL to QUrl conversion
zecke@webkit.org [Thu, 28 Jan 2010 11:54:12 +0000 (11:54 +0000)]
[Qt] Speed up KURL to QUrl conversion

https://bugs.webkit.org/show_bug.cgi?id=33873

The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Android] [Qt] Touch event page co-ordinates are incorrect when touch is received...
benm@google.com [Thu, 28 Jan 2010 11:00:35 +0000 (11:00 +0000)]
[Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=34162

Reviewed by Simon Hausmann.

WebCore:

The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.

* dom/Touch.cpp:
(WebCore::Touch::Touch): Remove dead code.
* dom/Touch.h: Remove dead code.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.
* platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
* platform/PlatformTouchPoint.h: Ditto.
* platform/android/PlatformTouchEventAndroid.cpp: Ditto.
* platform/android/PlatformTouchPointAndroid.cpp: Ditto.

LayoutTests:

Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.

* fast/events/touch/resources/touch-inside-iframe2.html:
* fast/events/touch/touch-inside-iframe-expected.txt:
* fast/events/touch/touch-inside-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 10:46:26 +0000 (10:46 +0000)]
2010-01-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Simplify isActivation method.

        https://bugs.webkit.org/show_bug.cgi?id=34161

        Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::isActivation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 28 Jan 2010 09:20:10 +0000 (09:20 +0000)]
2010-01-28  Xan Lopez  <xlopez@igalia.com>

        [GTK] Can DnD files to our filechooser widget (<input type="file">)
        https://bugs.webkit.org/show_bug.cgi?id=34246

        Skip failing test because of this missing feature.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 28 Jan 2010 09:10:29 +0000 (09:10 +0000)]
2010-01-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        Remove tests for dates later than 275760-09-13T00:00Z.
        https://bugs.webkit.org/show_bug.cgi?id=34240

        Date.UTC() of V8 doesn't support such dates though Date.UTC() of
        JavaScriptCore does.

        * fast/forms/input-valueasnumber-date-expected.txt:
        * fast/forms/input-valueasnumber-datetime-expected.txt:
        * fast/forms/input-valueasnumber-datetimelocal-expected.txt:
        * fast/forms/input-valueasnumber-month-expected.txt:
        * fast/forms/script-tests/input-valueasnumber-date.js:
        * fast/forms/script-tests/input-valueasnumber-datetime.js:
        * fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
        * fast/forms/script-tests/input-valueasnumber-month.js:
        * platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Thu, 28 Jan 2010 08:45:32 +0000 (08:45 +0000)]
2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        In check-webkit-style, eliminated the dependency of
        processors/cpp_unittest.py on checker.py.

        https://bugs.webkit.org/show_bug.cgi?id=34205

        * Scripts/webkitpy/style/checker.py:
          - Addressed FIXME by removing STYLE_CATEGORIES data.
          - Added style_categories().

        * Scripts/webkitpy/style/checker_unittest.py:
          - Minor changes.

        * Scripts/webkitpy/style/processors/cpp.py:
          - Added categories attribute to CppProcessor class (data
            was originally checker.STYLE_CATEGORIES).

        * Scripts/webkitpy/style/processors/cpp_unittest.py:
          - Addressed FIXME by eliminating "import" from checker.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 08:29:05 +0000 (08:29 +0000)]
2010-01-28  Anton Muhin  <antonm@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Improve treatment of conditions and rest of the line for if, else, switch and alikes
        https://bugs.webkit.org/show_bug.cgi?id=34173

        * Scripts/webkitpy/style/cpp_style.py:
        * Scripts/webkitpy/style/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Joe Mason <jmason@rim.com>
eric@webkit.org [Thu, 28 Jan 2010 08:12:32 +0000 (08:12 +0000)]
2010-01-28  Joe Mason  <jmason@rim.com>

        Reviewed by Adam Barth.

        Limit login retries to 5
        https://bugs.webkit.org/show_bug.cgi?id=34193

        * Scripts/webkitpy/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 28 Jan 2010 07:29:39 +0000 (07:29 +0000)]
2010-01-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        rangeOverflow/rangeUnderflow support for type=date
        https://bugs.webkit.org/show_bug.cgi?id=34209

        * fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-date.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-date.html: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added.

2010-01-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        rangeOverflow/rangeUnderflow support for type=date
        https://bugs.webkit.org/show_bug.cgi?id=34209

        Add DATE type support to rangeUnderflow(), rangeOverflow(),
        minimum(), and maximum() of HTMLInputElement.
        In order to unify parsing code for value, min, and max strings,
        introduce parseToDouble() function and it is called by
        valueAsDate() and valueAsNumber() too.

        Tests: fast/forms/ValidityState-rangeOverflow-date.html
               fast/forms/ValidityState-rangeUnderflow-date.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble().
        (WebCore::HTMLInputElement::rangeOverflow): ditto.
        (WebCore::HTMLInputElement::minimum): ditto.
        (WebCore::HTMLInputElement::maximum): ditto.
        (WebCore::HTMLInputElement::doubleValueFor): Added.
        (WebCore::HTMLInputElement::valueAsDate): Use parseToDouble().
        (WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble().
        * html/HTMLInputElement.h: Declare parseToDouble().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 28 Jan 2010 07:27:09 +0000 (07:27 +0000)]
2010-01-27  Darin Fisher  <darin@chromium.org>

        Fix chromium build bustage (take 2).

        * bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Skip test introduced in r53972 because of missing eventSender.beginDragWithFiles()
ossy@webkit.org [Thu, 28 Jan 2010 07:18:57 +0000 (07:18 +0000)]
[Qt] Skip test introduced in r53972 because of missing eventSender.beginDragWithFiles()

* platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 28 Jan 2010 06:50:36 +0000 (06:50 +0000)]
2010-01-27  Darin Fisher  <darin@chromium.org>

        Fix chromium build bustage.

        * bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 28 Jan 2010 06:36:24 +0000 (06:36 +0000)]
2010-01-27  Darin Fisher  <darin@chromium.org>

        Reviewed by Pavel Feldman.

        Expose HistoryItem::documentSequenceNumber
        https://bugs.webkit.org/show_bug.cgi?id=34243

        * public/WebHistoryItem.h:
        * src/WebHistoryItem.cpp:
        (WebKit::WebHistoryItem::documentSequenceNumber):
        (WebKit::WebHistoryItem::setDocumentSequenceNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix.
oliver@apple.com [Thu, 28 Jan 2010 05:26:54 +0000 (05:26 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 28 Jan 2010 04:47:07 +0000 (04:47 +0000)]
2010-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        MessageEvent.data should deserialize in the context of the MessageEvent's global object
        https://bugs.webkit.org/show_bug.cgi?id=34227

        Add logic to allow us to create an Object, Array, or Date instance
        so we can create them in the context of a specific global object,
        rather than just using the current lexical global object.

        * JavaScriptCore.exp:
        * runtime/DateInstance.cpp:
        (JSC::DateInstance::DateInstance):
        * runtime/DateInstance.h:
        * runtime/JSGlobalObject.h:
        (JSC::constructEmptyObject):
        (JSC::constructEmptyArray):
2010-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        MessageEvent.data should deserialize in the context of the MessageEvent's global object
        https://bugs.webkit.org/show_bug.cgi?id=34227

        Test that the object returned from postMessage.data is created in the correct context

        * fast/dom/Window/resources/window-postmessage-clone-frames-frame.html: Added.
        * fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
        * fast/dom/Window/window-postmessage-clone-frames.html: Added.
2010-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        MessageEvent.data should deserialize in the context of the MessageEvent's global object
        https://bugs.webkit.org/show_bug.cgi?id=34227

        Make ScriptValue deserialisation support the provision of a specific global
        object to use when creating new objects.  This then allows us to make
        MessageEvent.data and PopStateEvent.state deserialize in the correct
        context.

        Test: fast/dom/Window/window-postmessage-clone-frames.html

        * bindings/js/JSPopStateEventCustom.cpp:
          Remove custom implementation of state getter
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::DeserializingTreeWalker::DeserializingTreeWalker):
        (WebCore::DeserializingTreeWalker::createOutputArray):
        (WebCore::DeserializingTreeWalker::createOutputObject):
        (WebCore::DeserializingTreeWalker::convertIfTerminal):
        (WebCore::SerializedScriptValueData::deserialize):
        (WebCore::SerializedScriptValue::deserialize):
        * bindings/js/SerializedScriptValue.h:
        (WebCore::SerializedScriptValue::deserialize):
        * bindings/scripts/CodeGeneratorJS.pm:
          Update bindings generation to pass the correct global object, and to
          treat "any" as synonymous with SerializedValue.
        * dom/PopStateEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding myself to the committer list. No review necessary.
mrobinson@webkit.org [Thu, 28 Jan 2010 03:24:50 +0000 (03:24 +0000)]
Adding myself to the committer list. No review necessary.

* Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Martin Robinson <mrobinson@webkit.org>
eric@webkit.org [Thu, 28 Jan 2010 03:22:37 +0000 (03:22 +0000)]
2010-01-27  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Expose the IM context via the API
        https://bugs.webkit.org/show_bug.cgi?id=33327

        Expose the GtkIMMultiContext as a property of WebKitWebView. This will
        allow embedders to generate the input method context menu entries and
        make testing certain IM context behavior possible.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_property):
        (DNDContentsRequest::webkit_web_view_get_im_context):
        (DNDContentsRequest::webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Nicholas Young <nicholas.young@nokia.com>
eric@webkit.org [Thu, 28 Jan 2010 02:55:55 +0000 (02:55 +0000)]
2010-01-27  Nicholas Young  <nicholas.young@nokia.com>

        Reviewed by Eric Carlson.

        Make media controls fade in/out transition duration configurable on a theme level.
        https://bugs.webkit.org/show_bug.cgi?id=34196

        No new tests needed (I hope).

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::RenderMedia): Removed constant from contructor - the initial value is meaningless.
        (WebCore::RenderMedia::updateControlVisibility): Get fade in/out duration from theme.
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::mediaControlsFadeInDuration): New virtual method.
        (WebCore::RenderTheme::mediaControlsFadeOutDuration): New virtual method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 John Abd-El-Malek <jam@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 01:41:31 +0000 (01:41 +0000)]
2010-01-27  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that when a page removes an iframe that sleeps in its unload handler and
        terminates its JS execution, the outer page's JS continues running.

        https://bugs.webkit.org/show_bug.cgi?id=34226

        * fast/dom/Window/slow-unload-handler-expected.txt: Copied from LayoutTests/fast/dom/Window/slow_unload_handler-expected.txt.
        * fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html: Added.
        * fast/dom/Window/slow-unload-handler-only-frame-is-stopped-expected.txt: Added.
        * fast/dom/Window/slow-unload-handler.html: Copied from LayoutTests/fast/dom/Window/slow_unload_handler.html.
        * fast/dom/Window/slow_unload_handler-expected.txt: Removed.
        * fast/dom/Window/slow_unload_handler.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-01-27  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that when a page removes an iframe that sleeps in its unload handler and
        terminates its JS execution, the outer page's JS continues running.

        https://bugs.webkit.org/show_bug.cgi?id=34226

        Tests: fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
               fast/dom/Window/slow-unload-handler.html

        * bindings/v8/DateExtension.cpp:
        (WebCore::DateExtension::OnSleepDetected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 01:24:10 +0000 (01:24 +0000)]
2010-01-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add valueAsNumber support for type=datetime-local.
        https://bugs.webkit.org/show_bug.cgi?id=34200

        The test data is equivalent to input-valueasnumber-datetime.html.
        The expectation contains two FAIL lines because they check
        unimplemented features.

        * fast/forms/input-valueasnumber-datetimelocal-expected.txt: Added.
        * fast/forms/input-valueasnumber-datetimelocal.html: Added.
        * fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Added.
2010-01-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add valueAsNumber support for type=datetime-local.
        https://bugs.webkit.org/show_bug.cgi?id=34200

        Implement necessary methods of ISODateTime, and call them from
        HTMLInputElement.

        Test: fast/forms/input-valueasnumber-datetimelocal.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueAsNumber):
        (WebCore::HTMLInputElement::setValueAsNumber):
        * html/ISODateTime.cpp:
        (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTimeLocal):
          Implemented.  Just call setMillisecondsSinceEpochForDateTime().
        (WebCore::ISODateTime::millisecondsSinceEpochForTime):
          Accept to be called for m_type=DateTimeLocal.
        (WebCore::ISODateTime::toString): Add DateTimeLocal support.
        * html/ISODateTime.h: Declare new methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 George Wright <gwright@rim.com>
eric@webkit.org [Thu, 28 Jan 2010 01:05:43 +0000 (01:05 +0000)]
2010-01-27  George Wright  <gwright@rim.com>

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=34216

        Add missing include for wtf/Platform.h

        * DumpRenderTree/AccessibilityController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows Debug_All build fix.
sfalken@apple.com [Thu, 28 Jan 2010 00:46:16 +0000 (00:46 +0000)]
Windows Debug_All build fix.

* platform/graphics/win/WKCACFLayer.cpp:
* platform/graphics/win/WKCACFLayerRenderer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake it possible to instantiate WebSerializedJSValue using WebKitCreateInstance
aroben@apple.com [Thu, 28 Jan 2010 00:28:51 +0000 (00:28 +0000)]
Make it possible to instantiate WebSerializedJSValue using WebKitCreateInstance

Reviewed by Dave Hyatt.

* ForEachCoClass.h:
* WebKitClassFactory.cpp:
Added WebSerializedJSValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Adam Roben.
bweinstein@apple.com [Thu, 28 Jan 2010 00:23:16 +0000 (00:23 +0000)]
Rubber-stamped by Adam Roben.

Add platform specific failing Windows results for two recently
added tests. I will comment on their originating bugs saying that
failing results were landed for Windows.

<https://bugs.webkit.org/show_bug.cgi?id=29564>
<https://bugs.webkit.org/show_bug.cgi?id=32696>

* platform/win/fast/css/button-height-expected.txt: Added.
* platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 28 Jan 2010 00:16:53 +0000 (00:16 +0000)]
2010-01-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] complex text draws newlines as bells
        https://bugs.webkit.org/show_bug.cgi?id=34186

        Revert r45496 -- once we've got a glyph array, it is too late to normalize
        because we could have had multiple codepoints combine into one glyph.  The
        Uniscribe code it mentions it's duplicating uses the log cluster map to fix
        this.

        Instead, we just normalize the input text if it contains any non-ascii-space
        whitespace.

        This fixes fast/text/international/hindi-whitespace, which currently has an
        incorrect baseline containing a square box glyph.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::stringToGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 27 Jan 2010 23:41:50 +0000 (23:41 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34150
        WebKit needs a mechanism to catch stale HashMap entries

        It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
        is just its value, it is very unlikely that any observable problem is reproducible.

        This extends hash table consistency checks to check that pointers are referencing allocated
        memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
        to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).

        * wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can
        add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems
        with those yet.

        * wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by
        CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().

        * wtf/HashTable.h:
        (WTF::HashTable::internalCheckTableConsistency):
        (WTF::HashTable::internalCheckTableConsistencyExceptSize):
        (WTF::HashTable::checkTableConsistencyExceptSize):
        Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off.
        (WTF::::add): Updated for checkTableConsistency renaming.
        (WTF::::addPassingHashCode): Ditto.
        (WTF::::removeAndInvalidate): Ditto.
        (WTF::::remove): Ditto.
        (WTF::::rehash): Ditto.
        (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this
        function returns true for tables with m_table == 0.
        (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially,
        we could do the same for values.

        * wtf/HashTraits.h:
        (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden
        to add checks. Currently, the only override is for pointer hashes.

        * wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Wed, 27 Jan 2010 23:32:34 +0000 (23:32 +0000)]
2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide worker thread ability to track counters
        https://bugs.webkit.org/show_bug.cgi?id=34221

        Implement workerThreadCount() in LayoutTestController of Qt DRT

        Tests:
        fast/workers/dedicated-worker-lifecycle.html
        fast/workers/shared-worker-frame-lifecycle.html
        fast/workers/shared-worker-lifecycle.html
        fast/workers/worker-lifecycle.html

        * platform/qt/Skipped:
2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide worker thread ability to track counters
        https://bugs.webkit.org/show_bug.cgi?id=34221

        Implement workerThreadCount() in LayoutTestController of Qt DRT

        Tests:
        fast/workers/dedicated-worker-lifecycle.html
        fast/workers/shared-worker-frame-lifecycle.html
        fast/workers/shared-worker-lifecycle.html
        fast/workers/worker-lifecycle.html

        * Api/qwebpage.cpp:
        (qt_drt_workerThreadCount):
2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide worker thread ability to track counters
        https://bugs.webkit.org/show_bug.cgi?id=34221

        Implement workerThreadCount() in LayoutTestController of Qt DRT

        Tests:
        fast/workers/dedicated-worker-lifecycle.html
        fast/workers/shared-worker-frame-lifecycle.html
        fast/workers/shared-worker-lifecycle.html
        fast/workers/worker-lifecycle.html

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::workerThreadCount):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Brian Tarricone <brian@kakai.com>
eric@webkit.org [Wed, 27 Jan 2010 23:16:04 +0000 (23:16 +0000)]
2010-01-27  Brian Tarricone  <brian@kakai.com>

        Reviewed by Gustavo Noronha Silva.

        [gtk] Add support for windowless NPAPI plugins

        Much of this is a translation of how the Qt backend does this,
        modified for Gtk.

        https://bugs.webkit.org/show_bug.cgi?id=18831

        No new tests; there is already a windowless test in the tree.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::handleEvent):
        (WebCore::PluginView::PluginView):
        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::getRootWindow):
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::handleKeyboardEvent):
        (WebCore::inputEventState):
        (WebCore::PluginView::initXEvent):
        (WebCore::setXButtonEventSpecificFields):
        (WebCore::setXMotionEventSpecificFields):
        (WebCore::setXCrossingEventSpecificFields):
        (WebCore::PluginView::handleMouseEvent):
        (WebCore::PluginView::handleFocusInEvent):
        (WebCore::PluginView::handleFocusOutEvent):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::setNPWindowIfNeeded):
        (WebCore::PluginView::getValueStatic):
        (WebCore::PluginView::invalidateRect):
        (WebCore::getPluginDisplay):
        (WebCore::plug_removed_cb):
        (WebCore::getVisualAndColormap):
        (WebCore::PluginView::platformStart):
        (WebCore::PluginView::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Wed, 27 Jan 2010 22:59:25 +0000 (22:59 +0000)]
2010-01-27  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Remove trailing \ from inline function code
        https://bugs.webkit.org/show_bug.cgi?id=34223

        * assembler/ARMv7Assembler.h:
        (JSC::ARMThumbImmediate::countLeadingZerosPartial):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Wed, 27 Jan 2010 22:41:51 +0000 (22:41 +0000)]
2010-01-27  Anton Muhin  <antonm@chromium.org>

        Reviewed by David Levin.

        [v8] minor cosmetic fix in V8 bindings codegenerator
        https://bugs.webkit.org/show_bug.cgi?id=34224

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Wed, 27 Jan 2010 22:08:52 +0000 (22:08 +0000)]
Rubberstamped by Simon Hausmann.

[Qt] QtLauncher refactoring:

Make the LauncherWindow depend less on the view, so that more
code can be shared in near future.

* QtLauncher/main.cpp:
(LauncherWindow::sendTouchEvent):
(LauncherWindow::loadFinished):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setupUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 27 Jan 2010 21:36:16 +0000 (21:36 +0000)]
2010-01-27  Darin Fisher  <darin@chromium.org>

        Fix Chromium build bustage.

        * rendering/RenderBoxModelObject.cpp: Add wtf/CurrentTime.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-26 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 27 Jan 2010 21:17:55 +0000 (21:17 +0000)]
2010-01-26  Darin Fisher  <darin@chromium.org>

        Reviewed by Brady Eidson and David Levin.

        Chains of history items representing same-document navigation need to
        always remember that association

        https://bugs.webkit.org/show_bug.cgi?id=33224

        Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
        During session history traversal, if the current HistoryItem and the
        target HistoryItem have the same DocumentSequenceNumber, then it means
        that the current Document should remain.

        NOTE: To support Chromium's serialization of HistoryItems, I generate
        DocumentSequenceNumbers that are unique across application launches.
        DocumentSequenceNumbers are generated using a counter initialized with
        the time of day.

        Test: fast/loader/stateobjects/document-destroyed-navigate-back.html

        * dom/Document.cpp:
        (WebCore::Document::detach):
        * dom/Document.h:
        * history/BackForwardList.cpp:
        (WebCore::BackForwardList::pushStateItem):
        * history/BackForwardListChromium.cpp:
        (WebCore::BackForwardList::pushStateItem):
        * history/HistoryItem.cpp:
        (WebCore::generateDocumentSequenceNumber):
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::~HistoryItem):
        (WebCore::HistoryItem::setStateObject):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::setDocumentSequenceNumber):
        (WebCore::HistoryItem::documentSequenceNumber):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::navigateWithinDocument):
        (WebCore::FrameLoader::loadItem):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateBackForwardListForFragmentScroll):
        (WebCore::HistoryController::pushState):
        (WebCore::HistoryController::replaceState):
        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        * page/History.cpp:
        (WebCore::History::stateObjectAdded):
        * page/Page.cpp:
        (WebCore::Page::goToItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 27 Jan 2010 21:14:03 +0000 (21:14 +0000)]
2010-01-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Simon Fraser.

        Animated scaling of background-image is too slow
        https://bugs.webkit.org/show_bug.cgi?id=33808

        Implement a version of the RenderImage animated scaling optimisation
        for background images.  Due to the possibility of arbitrary transforms
        being applied to containing elements we explicitly check the current
        CTM of the context for scaling or rotation.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawTiledImage):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/transforms/TransformationMatrix.h:
        (WebCore::TransformationMatrix::isIdentityOrTranslation):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData):
        (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData):
        (WebCore::RenderBoxModelScaleData::size):
        (WebCore::RenderBoxModelScaleData::time):
        (WebCore::RenderBoxModelScaleData::useLowQualityScale):
        (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer):
        (WebCore::RenderBoxModelScaleData::setSize):
        (WebCore::RenderBoxModelScaleData::setTime):
        (WebCore::RenderBoxModelScaleData::setUseLowQualityScale):
        (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed):
        (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired):
        (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
        (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired):
        (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderBoxModelObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Wed, 27 Jan 2010 20:40:37 +0000 (20:40 +0000)]
Rubberstamped by Simon Hausmann.

[Qt] QtLauncher refactoring:

Move out code from the MainWindow (renamed to LauncherWindow)
that is not depending on the view, and add it to a new class
called MainWindow.

* QtLauncher/QtLauncher.pro:
* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):
(WebPage::createWindow):
(main):
* QtLauncher/mainwindow.cpp: Added.
(MainWindow::MainWindow):
(MainWindow::buildUI):
(MainWindow::page):
(MainWindow::setAddressUrl):
(MainWindow::addCompleterEntry):
(MainWindow::load):
(MainWindow::changeLocation):
(MainWindow::openFile):
* QtLauncher/mainwindow.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Wed, 27 Jan 2010 20:16:52 +0000 (20:16 +0000)]
2010-01-27  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Enable websockets support in QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=34180

        Remove websockets tests from skiplist.

        * platform/qt/Skipped:
2010-01-27  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Enable websockets support in QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=34180

        Connected between SocketStreamHandle and QTcpSocket/QSslSocket
        to enable support for websockets.
        Proxy authentication is not yet supported.
        SSL certificate errors are ignored while this is under development.

        * WebCore.pro:
        * platform/network/qt/SocketStreamHandle.h:
        * platform/network/qt/SocketStreamHandlePrivate.h: Added.
        * platform/network/qt/SocketStreamHandleQt.cpp:
        (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
        (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate):
        (WebCore::SocketStreamHandlePrivate::socketConnected):
        (WebCore::SocketStreamHandlePrivate::socketReadyRead):
        (WebCore::SocketStreamHandlePrivate::send):
        (WebCore::SocketStreamHandlePrivate::close):
        (WebCore::SocketStreamHandlePrivate::socketSentdata):
        (WebCore::SocketStreamHandlePrivate::socketClosed):
        (WebCore::SocketStreamHandlePrivate::socketError):
        (WebCore::SocketStreamHandlePrivate::socketClosedCallback):
        (WebCore::SocketStreamHandlePrivate::socketErrorCallback):
        (WebCore::SocketStreamHandlePrivate::socketSslErrors):
        (WebCore::SocketStreamHandle::SocketStreamHandle):
        (WebCore::SocketStreamHandle::~SocketStreamHandle):
        (WebCore::SocketStreamHandle::platformSend):
        (WebCore::SocketStreamHandle::platformClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Mads Ager <ager@chromium.org>
eric@webkit.org [Wed, 27 Jan 2010 20:00:13 +0000 (20:00 +0000)]
2010-01-27  Mads Ager  <ager@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Support getting integer-named properties using indexing notation on document object
        https://bugs.webkit.org/show_bug.cgi?id=34211

        * fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt: Added.
        * fast/dom/HTMLDocument/get-iframe-with-integer-name.html: Added.
2010-01-27  Mads Ager  <ager@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Support getting integer-named properties using indexing notation on document object
        https://bugs.webkit.org/show_bug.cgi?id=34211

        Add indexed property getter to HTMLDocument to support getting
        elements with integer names using indexing notation on document.

        Test: fast/dom/HTMLDocument/get-iframe-with-integer-name.html

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::V8HTMLDocument::indexedPropertyGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 27 Jan 2010 19:30:19 +0000 (19:30 +0000)]
2010-01-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Oliver Hunt.

        Instead of relying on Object.prototype.toString result use JSObject::isActivationObject
        to check if a scope node is a JSActivation. Object.prototype.toString for JSActivation
        will call JSActivation::toThisObject whose result depends on the current call stack.

        https://bugs.webkit.org/show_bug.cgi?id=34161

        Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::isActivation):
        * inspector/InjectedScriptHost.idl:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor.):
        * manual-tests/inspector/debugger-scopes-inspection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Anton Muhin <antonm@google.com>
eric@webkit.org [Wed, 27 Jan 2010 19:18:28 +0000 (19:18 +0000)]
2010-01-27 Anton Muhin <antonm@google.com>
        Review by Adam Barth.

        Implement Node map in intrusive way for better speed.
        https://bugs.webkit.org/show_bug.cgi?id=33957

        * bindings/v8/DOMData.h:
        (WebCore::DOMData::removeObjectsFromWrapperMap):
        * bindings/v8/DOMDataStore.cpp:
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::get):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::set):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::contains):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::allocateTableEntry):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::freeTableEntry):
        * bindings/v8/DOMDataStore.h:
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntry):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntries):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visitEntries):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::TableChunk::TableChunk):
        (WebCore::DOMDataStore::domNodeMap):
        * bindings/v8/StaticDOMDataStore.cpp:
        (WebCore::StaticDOMDataStore::StaticDOMDataStore):
        * bindings/v8/StaticDOMDataStore.h:
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::getDOMNodeMap):
        * bindings/v8/V8DOMMap.h:
        (WebCore::AbstractWeakReferenceMap::AbstractWeakReferenceMap):
        (WebCore::AbstractWeakReferenceMap::weakReferenceCallback):
        (WebCore::WeakReferenceMap::WeakReferenceMap):
        (WebCore::WeakReferenceMap::set):
        (WebCore::WeakReferenceMap::visit):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertDocumentToV8Object):
        (WebCore::getWrapper):
        (WebCore::V8DOMWrapper::convertNodeToV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
        * bindings/v8/V8DOMWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-26 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 27 Jan 2010 19:15:13 +0000 (19:15 +0000)]
2010-01-26  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        Add methods to support running a nested modal loop outside of WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=34199

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebView::willEnterModalLoop): Create PageGroupLoadDeferrer
        (WebKit::WebView::didExitModalLoop): Destroy PageGroupLoadDeferrer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
eric@webkit.org [Wed, 27 Jan 2010 19:01:38 +0000 (19:01 +0000)]
2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        Remove fast/events/keydown-numpad-keys.html from gtk's Skipped list.
        https://bugs.webkit.org/show_bug.cgi?id=28247

        * platform/gtk/Skipped:
2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        Add key event mappings for numpad keys for Gtk and Chromium/Gtk.
        http://bugs.webkit.org/show_bug.cgi?id=28247

        Test: fast/events/keydown-numpad-keys.html

        * platform/chromium/KeyCodeConversionGtk.cpp:
        (WebCore::windowsKeyCodeForKeyEvent):
        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::windowsKeyCodeForKeyEvent):
2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        Correctly handle the KeyLocation argument that has been introduced
        recently to test location-dependent key events in EventSender.keyDown.
        http://bugs.webkit.org/show_bug.cgi?id=28247

        Test: fast/events/keydown-numpad-keys.html

        * DumpRenderTree/gtk/EventSender.cpp:
        (keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 27 Jan 2010 18:36:54 +0000 (18:36 +0000)]
2010-01-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: migrate from SourceFrame to SourceFrame2.

        https://bugs.webkit.org/show_bug.cgi?id=34171

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        * inspector/InspectorFrontendHost.cpp:
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/InspectorBackendStub.js:
        * inspector/front-end/InspectorFrontendHostStub.js:
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._innerSelectContentTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.getResourceContent):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView):
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._sidebarResizeDrag):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.set executionLine):
        (WebInspector.SourceFrame.prototype.revealLine):
        (WebInspector.SourceFrame.prototype.addBreakpoint):
        (WebInspector.SourceFrame.prototype.removeBreakpoint):
        (WebInspector.SourceFrame.prototype.addMessage):
        (WebInspector.SourceFrame.prototype.clearMessages):
        (WebInspector.SourceFrame.prototype.sizeToFitContentHeight):
        (WebInspector.SourceFrame.prototype.setContent):
        (WebInspector.SourceFrame.prototype.findSearchMatches):
        (WebInspector.SourceFrame.prototype._collectRegexMatches):
        (WebInspector.SourceFrame.prototype.setSelection):
        (WebInspector.SourceFrame.prototype._incrementMessageRepeatCount):
        (WebInspector.SourceFrame.prototype._addExistingMessagesToSource):
        (WebInspector.SourceFrame.prototype._addMessageToSource):
        (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource):
        (WebInspector.SourceFrame.prototype._addBreakpointToSource):
        (WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
        (WebInspector.SourceFrame.prototype._contextMenu):
        (WebInspector.SourceFrame.prototype._toggleBreakpoint):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition):
        (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
        (WebInspector.SourceFrame.prototype._createConditionElement):
        (WebInspector.SourceFrame.prototype._keyDown):
        (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
        (WebInspector.SourceFrame.prototype._breakpointChanged):
        (WebInspector.SourceFrame.prototype.resize):
        (WebInspector.BreakpointLineNumberDecorator):
        (WebInspector.BreakpointLineNumberDecorator.prototype.decorate):
        (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint):
        (WebInspector.BreakpointLineNumberDecorator.prototype._paintProgramCounter):
        (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown):
        (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu):
        (WebInspector.ExecutionLineDecorator):
        (WebInspector.ExecutionLineDecorator.prototype.decorate):
        * inspector/front-end/SourceFrame2.js: Removed.
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        (WebInspector.SourceView.prototype.show):
        (WebInspector.SourceView.prototype.resize):
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
        (WebInspector.SourceView.prototype._contentLoaded):
        (WebInspector.SourceView.prototype.performSearch.findSearchMatches):
        (WebInspector.SourceView.prototype.performSearch):
        (WebInspector.SourceView.prototype._jumpToSearchResult):
        (WebInspector.SourceView.prototype._sourceFrameSetupFinished):
        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor.prototype._mouseDown):
        (WebInspector.TextEditor.prototype._copy.delayCopy):
        (WebInspector.TextEditor.prototype._copy):
        (WebInspector.TextEditor.prototype._cut):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Dominik Röttsches <dominik.roettsches@access-company.com>
eric@webkit.org [Wed, 27 Jan 2010 18:19:39 +0000 (18:19 +0000)]
2010-01-27  Dominik Röttsches  <dominik.roettsches@access-company.com>

        Reviewed by Xan Lopez.

        [Gtk] For removing ICU, implement IDN support by means of libidn
        https://bugs.webkit.org/show_bug.cgi?id=31470

        In order to avoid a new dependency,
        IDN support now based on GLib for the GLib unicode backend.

        * platform/KURL.cpp:
        (WebCore::appendEncodedHostname):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 27 Jan 2010 17:55:50 +0000 (17:55 +0000)]
2010-01-27  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding missing WebMutationEvent.cpp file to fix build bustage.
        https://bugs.webkit.org/show_bug.cgi?id=33882

        * public/WebMutationEvent.h: Remove unnecessary constructor.
        * src/WebEvent.cpp: Remove unnecessary include of WebMutationEvent.h.
        * src/WebMutationEvent.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Wed, 27 Jan 2010 17:43:15 +0000 (17:43 +0000)]
Rubberstamped by Simon Hausmann.

[Qt] QtLauncher, coding style fixes.

* QtLauncher/main.cpp:
(MainWindow::MainWindow):
(MainWindow::sendTouchEvent):
(MainWindow::eventFilter):
(MainWindow::loadURL):
(MainWindow::setupUI):
(WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Wed, 27 Jan 2010 17:02:18 +0000 (17:02 +0000)]
Rubberstamped by Simon Hausmann.

[Qt] QtLauncher refactoring, separating the webview and
adding a QGraphicsWebView based version.

* QtLauncher/QtLauncher.pro:
* QtLauncher/main.cpp:
(MainWindow::MainWindow):
* QtLauncher/webpage.h:
* QtLauncher/webview.cpp: Added.
(createContextMenu):
(WebViewGraphicsBased::mousePressEvent):
(WebViewTraditional::mousePressEvent):
(WebViewGraphicsBased::contextMenuEvent):
(WebViewTraditional::contextMenuEvent):
* QtLauncher/webview.h: Added.
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewTraditional::WebViewTraditional):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Update the .def files with exported symbols
hausmann@webkit.org [Wed, 27 Jan 2010 16:14:46 +0000 (16:14 +0000)]
[Qt] Update the .def files with exported symbols

Reviewed by Laszlo Gombos.

* symbian/eabi/QtWebKitu.def: Add two mangled missing new symbols for arm eabi.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.: [Qt] Don't build the tests in packages, only the launcher(s)
hausmann@webkit.org [Wed, 27 Jan 2010 16:06:44 +0000 (16:06 +0000)]
.: [Qt] Don't build the tests in packages, only the launcher(s)

Reviewed by Kenneth Rohde Christiansen.

* WebKit.pro:

WebCore: [Qt] For package builds use the .def files on Symbian

Reviewed by Kenneth Rohde Christiansen.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Jay Campan <jcampan@google.com>
eric@webkit.org [Wed, 27 Jan 2010 15:15:23 +0000 (15:15 +0000)]
2010-01-27  Jay Campan  <jcampan@google.com>

        Reviewed by Darin Fisher.

        Adding EventListeners to the chromium API.

        https://bugs.webkit.org/show_bug.cgi?id=33882

        * WebKit.gyp:
        * public/WebEvent.h: Added.
        * public/WebEventListener.h: Added.
        * public/WebMutationEvent.h: Added.
        * public/WebNode.h:
        * public/WebString.h:
        (WebKit::operator==):
        (WebKit::operator!=):
        * src/EventListenerWrapper.cpp: Added.
        * src/EventListenerWrapper.h: Added.
        * src/WebEvent.cpp: Added.
        * src/WebEventListener.cpp: Added.
        * src/WebEventListenerPrivate.cpp: Added.
        * src/WebEventListenerPrivate.h: Added.
        * src/WebNode.cpp:
        (WebKit::WebNode::addEventListener):
        (WebKit::WebNode::removeEventListener):
        * src/WebString.cpp:
        (WebKit::WebString::equals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Wed, 27 Jan 2010 14:58:24 +0000 (14:58 +0000)]
2010-01-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Avoid watch expressions duplication
        https://bugs.webkit.org/show_bug.cgi?id=33996

        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 27 Jan 2010 14:47:26 +0000 (14:47 +0000)]
2010-01-27  Alexander Pavlov  <apavlov@chromium.org>

        Adding myself as committer. No review necessary.

        * Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 27 Jan 2010 14:41:42 +0000 (14:41 +0000)]
2010-01-27  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adds EventSource bindings for V8
        https://bugs.webkit.org/show_bug.cgi?id=33695

        No new tests (existing layout tests for EventSource should pass).

        * Android.v8bindings.mk:
        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8EventSourceConstructor.cpp: Added.
        * bindings/v8/custom/V8EventSourceCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Wed, 27 Jan 2010 14:25:11 +0000 (14:25 +0000)]
2010-01-27  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Meta-methods can't be introspected using ES5 API
        https://bugs.webkit.org/show_bug.cgi?id=34087

        Add getOwnPropertyDescriptor() and getOwnPropertyNames() reimplementations.

        Tests are in WebKit/qt/tests/qwebframe

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
        (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
        (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
        (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
        * bridge/qt/qt_runtime.h:
2010-01-27  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Meta-methods can't be introspected using ES5 API
        https://bugs.webkit.org/show_bug.cgi?id=34087

        Test that Object.getOwnPropertyDescriptor and
        Object.getOwnPropertyNames work with meta-methods.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Simon Hausmann
kenneth@webkit.org [Wed, 27 Jan 2010 14:21:48 +0000 (14:21 +0000)]
Rubberstamped by Simon Hausmann

[Qt] QtLauncher refactoring, separating utility methods.

* QtLauncher/QtLauncher.pro:
* QtLauncher/main.cpp:
* QtLauncher/utils.cpp: Added.
(urlFromUserInput):
* QtLauncher/utils.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 27 Jan 2010 14:07:59 +0000 (14:07 +0000)]
2010-01-27  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port WTF's randomNumber
        https://bugs.webkit.org/show_bug.cgi?id=33566

        Use GETRAND to generate 4 byte random byte sequence to implement
        weakRandomNumber. Create a secure random number generator with
        AEECLSID_RANDOM to implement randomNumber.

        * wtf/RandomNumber.cpp:
        (WTF::weakRandomNumber):
        (WTF::randomNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Tony Chang <tony@chromium.org>
eric@webkit.org [Wed, 27 Jan 2010 13:51:15 +0000 (13:51 +0000)]
2010-01-27  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Fix a crash when trying to indent a block element that was contained
        in a list.  This was happening because enclosingBlock() in
        htmlediting.cpp can return the current the same Node when a block
        element (like an <hr> or a <table>) is passed in.  This causes
        the indent command to think that it is not in a list item.

        Work around this by checking to see if enclosingBlock returned the
        same Node.

        https://bugs.webkit.org/show_bug.cgi?id=32390

        * editing/execCommand/indent-block-in-list-expected.txt: Added.
        * editing/execCommand/indent-block-in-list.html: Added.
2010-01-27  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Fix a crash when trying to indent a block element that was contained
        in a list.  This was happening because enclosingBlock() in
        htmlediting.cpp can return the current the same Node when a block
        element (like an <hr> or a <table>) is passed in.  This causes
        the indent command to think that it is not in a list item.

        Work around this by checking to see if enclosingBlock returned the
        same Node.

        https://bugs.webkit.org/show_bug.cgi?id=32390

        Test: editing/execCommand/indent-block-in-list.html

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::tryIndentingAsListItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Wed, 27 Jan 2010 13:34:24 +0000 (13:34 +0000)]
2010-01-27  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port getCPUTime
        https://bugs.webkit.org/show_bug.cgi?id=33572

        Use GETUPTIMEMS which returns a continuously and
        linearly increasing millisecond timer from the time the device
        was powered on. This function is enough to implement getCPUTime.

        * runtime/TimeoutChecker.cpp:
        (JSC::getCPUTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 27 Jan 2010 13:01:03 +0000 (13:01 +0000)]
2010-01-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        webkit-patch needs an open-bugs command
        https://bugs.webkit.org/show_bug.cgi?id=30793

        * Scripts/test-webkitpy: import OpenBugsTest
        * Scripts/webkit-patch: import OpenBugs
        * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
        * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
        * Scripts/webkitpy/commands/queries_unittest.py: ditto
        * Scripts/webkitpy/commands/queues_unittest.py: ditto
        * Scripts/webkitpy/commands/upload_unittest.py: ditto
        * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add the "d" suffix to QtWebKit's dll on Windows.
jocelyn.turcotte@nokia.com [Wed, 27 Jan 2010 12:43:06 +0000 (12:43 +0000)]
[Qt] Add the "d" suffix to QtWebKit's dll on Windows.

Reviewed by Tor Arne Vestbø.

* WebKit.pri:

WebCore:

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53924 268f45cc-cd09-0410-ab3c-d52691b4dbfc