WebKit-https.git
10 years ago2010-02-17 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Wed, 17 Feb 2010 20:08:08 +0000 (20:08 +0000)]
2010-02-17  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsLayer: support perspective and 3D transforms
        https://bugs.webkit.org/show_bug.cgi?id=34960

        * WebKit.pri: added appropriate define: ENABLED_3D_RENDERING
2010-02-17  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsLayer: support perspective and 3D transforms
        https://bugs.webkit.org/show_bug.cgi?id=34960

        New tests: http://webkit.org/blog-files/3d-transforms/perspective-by-example.html

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::updateTransform):
        (WebCore::GraphicsLayerQtImpl::setBaseTransform):
        (WebCore::GraphicsLayerQtImpl::computeTransform):
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        (WebCore::TransformAnimationQt::~TransformAnimationQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
pkasting@chromium.org [Wed, 17 Feb 2010 19:51:24 +0000 (19:51 +0000)]
Unreviewed, build fix.

Fix crashes due to an omitted line in r54839.

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Alok Priyadarshi <alokp@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 19:28:06 +0000 (19:28 +0000)]
2010-02-17  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by Ariya Hidayat.

        Bug 34900: Implement accelerated compositing for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=34900

        Do not exclude files needed for accelerated compositing. In fact there is no need to exclude these files.
        These files are already guarded with WTF_USE_ACCELERATED_COMPOSITING flag.

        * WebCore.gyp/WebCore.gyp: Removed GraphicsLayer.cpp, RenderLayerBacking.cpp,
        and RenderLayerCompositor.cpp from excluded list.
2010-02-17  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by Ariya Hidayat.

        Bug 34900: Implement accelerated compositing for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=34900

        * features.gypi: Added WTF_USE_ACCELERATED_COMPOSITING flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove the obsolete chromium interface for handling DownloadURL.
jianli@chromium.org [Wed, 17 Feb 2010 19:08:09 +0000 (19:08 +0000)]
[chromium] Remove the obsolete chromium interface for handling DownloadURL.
https://bugs.webkit.org/show_bug.cgi?id=34982

Reviewed by Darin Fisher.

WebCore:

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::setData):

WebKit/chromium:

* public/WebDragData.h:
* src/WebDragData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Wed, 17 Feb 2010 19:06:22 +0000 (19:06 +0000)]
2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Ariya Hidayat.

        Make possible Qt DRT to get total number of pages to be printed

        LayoutTests:
            printing/numberOfPages.html

        [Qt] DRT: Get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34955

        * Api/qwebframe.cpp:
        (qt_drt_numberOfPages):
        (qt_drt_evaluateScriptInIsolatedWorld):
2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Ariya Hidayat.

        Make possible Qt DRT to get total number of pages to be printed

        LayoutTests:
            printing/numberOfPages.html

        [Qt] DRT: Get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34955

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::numberOfPages):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for blocks that...
mitz@apple.com [Wed, 17 Feb 2010 19:02:39 +0000 (19:02 +0000)]
<rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for blocks that span multiple columns

Reviewed by Darin Adler.

* manual-tests/match-marker-rects.html: Added.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintTextMatchMarker): Use the text renderer rather
than its ancestor block for the local-to-absolute transformation.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/gtk:
xan@webkit.org [Wed, 17 Feb 2010 18:33:02 +0000 (18:33 +0000)]
WebKit/gtk:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Rename 'enable-java' setting to 'enable-java-applet', since it
        only controls whether <applet> is supported or not instead of
        whether all Java content is supported or not.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_update_settings):
        (DNDContentsRequest::webkit_web_view_settings_notify):

WebKitTools:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update to use new property name.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Julien Chaffraix <jchaffraix@webkit.org>
eric@webkit.org [Wed, 17 Feb 2010 17:49:46 +0000 (17:49 +0000)]
2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Ariya Hidayat.

        Remove some warnings seen when building Qt
        https://bugs.webkit.org/show_bug.cgi?id=35017

        Using a machine without the needed tools to build WebKit leads to
        several errors and warnings.

        * Scripts/webkitdirs.pm: Refactored the code testing the command's
        presence into a commandExists routine. While doing so removed, stderr
        output as it usually does not give anything more than our message. Also
        added a Qt check for qmake that was missing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 15:47:27 +0000 (15:47 +0000)]
2010-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to turn windows slaves again, by skipping two websocket tests that fail reliable.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTypo in test name
kov@webkit.org [Wed, 17 Feb 2010 15:17:36 +0000 (15:17 +0000)]
Typo in test name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Tor Arne Vestbø.
ossy@webkit.org [Wed, 17 Feb 2010 15:14:38 +0000 (15:14 +0000)]
Rubber-stamped by Tor Arne Vestbø.

[Qt] Add platform specific expected files for new tests pass in fast/css.

Rendertree results compared to Mac expected files with --ignore-metrics,
pixel results compared to Mac png files.

fast/css/font-face-opentype.html introduced in r54855.
fast/css/inline-element-line-break.html introduced in r54544.
fast/css/pseudo-element-line-break.html introduced in r54544.

* platform/qt/fast/css/font-face-opentype-expected.txt: Added.
* platform/qt/fast/css/inline-element-line-break-expected.txt: Added.
* platform/qt/fast/css/pseudo-element-line-break-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 15:09:58 +0000 (15:09 +0000)]
2010-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to turn SnowLeopard slave green again. Skipping media/video-load-networkState.html - already filed a bug last year.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 15:05:37 +0000 (15:05 +0000)]
2010-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to turn Tiger slave green again. Skipping media/video-display-aspect-ratio.html - already skipped on the other mac variants & win.

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping new test that does not pass on Qt.
kov@webkit.org [Wed, 17 Feb 2010 14:48:50 +0000 (14:48 +0000)]
Skipping new test that does not pass on Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 17 Feb 2010 14:30:11 +0000 (14:30 +0000)]
2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Does not send an Accept header for subresources, causing some sites to break
        https://bugs.webkit.org/show_bug.cgi?id=33242

        Set */* as the Accept header when downloading resources
        that did not set an Accept header. This behaviour is similar to
        the one adopted by Chromium.

        Test: http/tests/misc/image-checks-for-accept.html

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a mistake I just committed to the change log.
jorlow@chromium.org [Wed, 17 Feb 2010 14:24:09 +0000 (14:24 +0000)]
Fix a mistake I just committed to the change log.

Note that the last svn commit message should have read like this:

2010-02-17  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Fixes initialization order of members for GeolocationServiceChromium.
        https://bugs.webkit.org/show_bug.cgi?id=35034

        * platform/chromium/GeolocationServiceChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2
jorlow@chromium.org [Wed, 17 Feb 2010 14:20:45 +0000 (14:20 +0000)]
2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 14:08:49 +0000 (14:08 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Gustavo Noronha.

        Disable Java by default in DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 13:46:17 +0000 (13:46 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Implement FrameLoaderClient::createJavaAppletWidget.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createJavaAppletWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
xan@webkit.org [Wed, 17 Feb 2010 13:46:05 +0000 (13:46 +0000)]
WebCore:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Resolve symlinks before trying to load plugins as modules, since
        GModule won't do it.

        Based on original work by Gustavo Noronha.

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::load):

JavaScriptCore:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Add support for GFile to GOwnPtr.

        Based on original work by Gustavo Noronha.

        * wtf/gtk/GOwnPtr.cpp:
        (WTF::GFile):
        * wtf/gtk/GOwnPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 13:41:47 +0000 (13:41 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Add a WebKitWebSetting to enable/disable the Java plugin support.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 17 Feb 2010 13:39:12 +0000 (13:39 +0000)]
2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by NOBODY (OOPS!).

        Protect the resource loader object from disappearing during
        parseDataUrl.

        Tested by testdownload API test.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::parseDataUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a number of new tests
kov@webkit.org [Wed, 17 Feb 2010 13:12:29 +0000 (13:12 +0000)]
Skip a number of new tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 12:00:15 +0000 (12:00 +0000)]
2010-02-17  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Implements GeolocationServices for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=32068

        This is part of implementing Geolocation framework for Chromium. Existing layout tests should pass.

        * WebCore.gypi:
        * page/Geolocation.h:
        * platform/GeolocationService.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 17 Feb 2010 10:49:08 +0000 (10:49 +0000)]
2010-02-17  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        Missing property warning after r54873
        https://bugs.webkit.org/show_bug.cgi?id=35023

        Add a new WebKitWebSettings setting, 'enable-file-access-from-file-uris', set to
        FALSE by default, that when enabled will assign each file:// URI
        their own security domain.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 17 Feb 2010 10:21:27 +0000 (10:21 +0000)]
2010-02-17  Steve Block  <steveblock@google.com>

        Reviewed by Ariya Hidayat.

        Adds missing platform and feature guards to V8 bindings
        https://bugs.webkit.org/show_bug.cgi?id=34987

        No new tests, build fix only.

        * bindings/v8/V8Proxy.cpp: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
        * bindings/v8/V8Proxy.h: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
        * bindings/v8/custom/V8DocumentCustom.cpp: Modified. Adds XPATH guards

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 17 Feb 2010 10:04:58 +0000 (10:04 +0000)]
2010-02-17  Steve Block  <steveblock@google.com>

        Reviewed by Ariya Hidayat.

        Include WebCore's npruntime.h for Android in V8 bindings
        https://bugs.webkit.org/show_bug.cgi?id=35002

        Currently, the V8 bindings include bindings/npruntime.h, which is a
        Chromium-specific file outside of the WebKit tree.

        No new tests, build fix only.

        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/NPV8Object.h:
        * bindings/v8/V8NPObject.h:
        * bindings/v8/V8NPUtils.h:
        * bindings/v8/npruntime_impl.h:
        * bindings/v8/npruntime_priv.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed - demo.
mjs@apple.com [Wed, 17 Feb 2010 08:38:14 +0000 (08:38 +0000)]
Not reviewed - demo.

Made some examples of using <details> for table descriptions.

* demos/hover-summary: Added.
* demos/hover-summary/details.css: Added.
* demos/hover-summary/details.js: Added.
(summaryClickListener):
():
(window.onload):
* demos/hover-summary/example1.html: Added.
* demos/hover-summary/example2.html: Added.
* demos/hover-summary/horizontal-triangle.png: Added.
* demos/hover-summary/vertical-triangle.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-15 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 17 Feb 2010 08:37:38 +0000 (08:37 +0000)]
2010-02-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should handle BUFFERING messages
        https://bugs.webkit.org/show_bug.cgi?id=30004

        * configure.ac: Bump gstreamer -core/-plugins-base requirements to
        0.10.25 which is the minimum required version for on-disk buffering.

2010-01-07  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should handle BUFFERING messages
        https://bugs.webkit.org/show_bug.cgi?id=30004

        Draw the buffering status in the media controls. The timebar is
        now 2 pixels shorter so dragging it at same absolute position than
        before produces a seek at a new position in the media, this
        explains the rebaselining of the controls-drag-timebar test.

        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-drag-timebar-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-controls-rendering-expected.txt:
        Re-baselined due to 1px left/right border added in controls timeline.

2010-01-07  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should handle BUFFERING messages
        https://bugs.webkit.org/show_bug.cgi?id=30004

        Initial support for on-disk buffering of videos. This works only
        for Quicktime and flv though.

        * css/mediaControlsGtk.css:
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintMediaSliderTrack): Draw the
        buffering status in the media controls.
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback): Defer buffering
        messages handling to processBufferingStats().
        (WebCore::bufferingTimeoutCallback): Closure called periodically
        during the on-disk buffering process.
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): New instance
        variables and create playbin2 here instead of doing it in load().
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): New instance
        variables.
        (WebCore::MediaPlayerPrivate::load): Simply set uri on playbin2
        instead of creating the pipeline and setting uri all together.
        (WebCore::MediaPlayerPrivate::processBufferingStats): Start a new
        timeout source if the player is starting on-disk buffering.
        (WebCore::MediaPlayerPrivate::queryBufferingStats): Method called
        200ms during on-disk buffering to update the maxTimeLoaded and few
        other private variables.
        (WebCore::MediaPlayerPrivate::maxTimeSeekable):
        (WebCore::MediaPlayerPrivate::maxTimeLoaded):
        (WebCore::MediaPlayerPrivate::bytesLoaded): Fixed implementations
        regarding buffering.
        (WebCore::MediaPlayerPrivate::totalBytes): Improved logging.
        (WebCore::MediaPlayerPrivate::updateStates): Start playback if it
        was internally paused at beginning of on-disk buffering and set
        ready/network states depending on the state of the on-disk
        buffering process.
        (WebCore::MediaPlayerPrivate::didEnd): Emit durationChanged.
        (WebCore::MediaPlayerPrivate::setAutobuffer): Edit playbin2 flags
        property depending on autoBuffer value.
        (WebCore::MediaPlayerPrivate::createGSTPlayBin): Don't set uri
        there, it is now done in load().
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: New methods
        and instance variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix by adding a return statement.
bweinstein@apple.com [Wed, 17 Feb 2010 08:17:22 +0000 (08:17 +0000)]
Build fix by adding a return statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 08:04:00 +0000 (08:04 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Skip tests requiring new results.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to fix the build
bweinstein@apple.com [Wed, 17 Feb 2010 07:56:24 +0000 (07:56 +0000)]
Touch WebKit.idl to fix the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome minor check-webkit-style code clean-ups. This revision
cjerdonek@webkit.org [Wed, 17 Feb 2010 07:38:43 +0000 (07:38 +0000)]
Some minor check-webkit-style code clean-ups.  This revision
contains no new functionality.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34932

* Scripts/check-webkit-style:
  - Replaced the call to webkit_argument_defaults() with a
    default parameter in the ArgumentParser constructor.

* Scripts/webkitpy/style/checker.py:
  - Removed the WEBKIT prefix from the default global variables.
  - Prefixed several of the global variables with an underscore
    to reflect that they are used internally.
  - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
  - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
    configuration from list-tuple pairs to list-list pairs.
  - Renamed style_categories() to _all_categories().
  - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
  - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
  - In the ArgumentParser class--
    - Renamed the doc_print attribute to stderr_write.
    - Other minor updates.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated the import statements and unit test classes as necessary.
  - Added assertions to test _PATH_RULES_SPECIFIER more fully.

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Updated the unit test classes as necessary.
  - Changed StyleErrorHandlerTestBase to store a list of error
    messages rather than just the last one.

* Scripts/webkitpy/style/filter.py:
  - Altered FilterConfiguration._path_rules_from_path()
    to convert the path_rules list to a tuple.

* Scripts/webkitpy/style/filter_unittest.py:
  - Updated the unit tests to reflect the change from tuples to
    lists in the _PATH_RULES_SPECIFIER configuration variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Chris Evans <cevans@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 07:32:30 +0000 (07:32 +0000)]
2010-02-16  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Add a new setting which gives the option of assigning every file:///
        to its own unique domain.

        https://bugs.webkit.org/show_bug.cgi?id=34778

        Test: Pending in forthcoming separate change due to non-trivial
        dependencies.

        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext): Place file:/// URI documents
        into their own unique domains if the new setting requires it.
        * page/Settings.h:
        * page/Settings.cpp:
        (WebCore::Settings::setAllowFileAccessFromFileURLs): Simple setter.
        * page/SecurityOrigin.h:
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::makeUnique): Add simple ability to force an
        origin to be considered unique.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 07:12:23 +0000 (07:12 +0000)]
2010-02-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: drosera/demo.js not syntax highlighted correctly.

        https://bugs.webkit.org/show_bug.cgi?id=35008

        * inspector/front-end/SourceTokenizer.js:
        (WebInspector.SourceTokenizer.Registry):
        (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 06:56:19 +0000 (06:56 +0000)]
2010-02-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: prefer smooth scrolling to instant highlight.

        https://bugs.webkit.org/show_bug.cgi?id=34978

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype._scroll):
        (WebInspector.TextChunk):
        (WebInspector.TextChunk.prototype._createRow):
        * inspector/front-end/textViewer.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a handful of other leaks seen on the buildbot.
mrowe@apple.com [Wed, 17 Feb 2010 05:57:24 +0000 (05:57 +0000)]
Fix a handful of other leaks seen on the buildbot.

Patch by Gavin Barraclough <barraclough@apple.com> on 2010-02-16
Reviewed by Mark Rowe.

* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Delegate through to the subclass version of deref to ensure that
the correct cleanup takes place.  This function previously featured some code that attempted to
skip deletion of static UStringImpl's.  Closer inspection revealed that it was in fact equivalent
to "if (false)", meaning that UStringImpl's which had their final deref performed via this function
were leaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForgot a .get() because this is an OwnPtr
bweinstein@apple.com [Wed, 17 Feb 2010 05:26:01 +0000 (05:26 +0000)]
Forgot a .get() because this is an OwnPtr

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry using m_qtVideoLayer instead of platformLayer() to fix the build
bweinstein@apple.com [Wed, 17 Feb 2010 04:55:21 +0000 (04:55 +0000)]
Try using m_qtVideoLayer instead of platformLayer() to fix the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix when Accelerated Compositing is on
bweinstein@apple.com [Wed, 17 Feb 2010 04:21:00 +0000 (04:21 +0000)]
Build fix when Accelerated Compositing is on

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a handful of leaks seen on the buildbot.
mrowe@apple.com [Wed, 17 Feb 2010 04:06:48 +0000 (04:06 +0000)]
Fix a handful of leaks seen on the buildbot.

Reviewed by Gavin Barraclough.

* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Call URopeImpl::destructNonRecursive rather than delete
to ensure that the rope's fibers are also destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Wed, 17 Feb 2010 03:54:23 +0000 (03:54 +0000)]
2010-02-16  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Nikolas Zimmermann.

        SVG not rendered as background-image from data URI
        https://bugs.webkit.org/show_bug.cgi?id=33630

        * platform/mac/svg/css/background-image-svg-expected.checksum: Added.
        * platform/mac/svg/css/background-image-svg-expected.png: Added.
        * platform/qt/svg/css/background-image-svg-expected.checksum: Added.
        * platform/qt/svg/css/background-image-svg-expected.png: Added.
        * svg/css/background-image-svg.html: Added.
        * svg/css/background-image-svg-expected.txt: Added.
2010-02-16  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Nikolas Zimmermann.

        SVG not rendered as background-image from data URI
        https://bugs.webkit.org/show_bug.cgi?id=33630

        When the background image is an SVG image, and it is smaller than the area
        it is supposed to fill, we were using renderSubTreeToImage to draw it.
        That call was not going through all the drawing phases, and so the SVG itself
        would not be drawn.

        Test: svg/css/background-image-svg.html

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::nativeImageForCurrentFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Bryan Yeung <bryeung@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 03:37:58 +0000 (03:37 +0000)]
2010-02-16  Bryan Yeung  <bryeung@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Remove the bounds on stroke width and miter for the skia platform.
        https://bugs.webkit.org/show_bug.cgi?id=34954

        Test: svg/custom/stroke-width-large.svg

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::setupPaintForStroking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 03:27:46 +0000 (03:27 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Correct typo in test name in Skipped list. Should turn SL slave green again.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a missing semicolon
bweinstein@apple.com [Wed, 17 Feb 2010 03:25:54 +0000 (03:25 +0000)]
Add a missing semicolon

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 03:21:48 +0000 (03:21 +0000)]
2010-02-16  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
        classes.  releaseRef releases the original pointer without decreasing
        the reference count, and the base class constructor increases the
        reference count, leading to a leak.

        https://bugs.webkit.org/show_bug.cgi?id=35000

        * src/WebDocument.cpp:
        (WebKit::WebDocument::WebDocument):
        * src/WebElement.cpp:
        (WebKit::WebElement::WebElement):
        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::WebFormElement):
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::WebInputElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 03:10:49 +0000 (03:10 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Attempt to fix win slave. Skip same tests failing on SL, add bug references to skipped list.

        * platform/mac-snowleopard/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Bryan Yeung <bryeung@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 03:05:44 +0000 (03:05 +0000)]
2010-02-16  Bryan Yeung  <bryeung@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Add a new layout test for large stroke widths in SVG.
        This regression tests a bug in the Skia platform where the width was
        limited to 512.

        https://bugs.webkit.org/show_bug.cgi?id=34954

        * platform/mac/svg/custom/stroke-width-large-expected.checksum: Added.
        * platform/mac/svg/custom/stroke-width-large-expected.png: Added.
        * platform/mac/svg/custom/stroke-width-large-expected.txt: Added.
        * svg/custom/stroke-width-large.svg: Added.
2010-02-16  Bryan Yeung  <bryeung@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Remove the bounds on stroke width and miter for the skia platform.
        https://bugs.webkit.org/show_bug.cgi?id=34954

        Test: svg/custom/stroke-width-large.svg

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::setupPaintForStroking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 MORITA Hajime <morrita@gmail.com>
eric@webkit.org [Wed, 17 Feb 2010 02:49:36 +0000 (02:49 +0000)]
2010-02-16  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Nikolas Zimmermann.

        REGRESSION: SVG text disappaears after double click
        https://bugs.webkit.org/show_bug.cgi?id=34880

        * platform/mac/svg/text/selection-doubleclick-expected.checksum: Added.
        * platform/mac/svg/text/selection-doubleclick-expected.png: Added.
        * platform/mac/svg/text/selection-doubleclick-expected.txt: Added.
        * platform/mac/svg/text/selection-tripleclick-expected.checksum: Added.
        * platform/mac/svg/text/selection-tripleclick-expected.png: Added.
        * platform/mac/svg/text/selection-tripleclick-expected.txt: Added.
        * svg/text/selection-doubleclick.svg: Added.
        * svg/text/selection-tripleclick.svg: Added.
2010-02-16  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Nikolas Zimmermann.

        REGRESSION: SVG text disappaears after double click
        https://bugs.webkit.org/show_bug.cgi?id=34880

        Tests: svg/text/selection-doubleclick.svg
               svg/text/selection-tripleclick.svg

        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection):
        Use InlineTextBox::selectionStartEnd() instead of
        RenderObject::selectionStartEnd() because latter may span multiple
        comparing startPos and endPos is irrelevant in some cases.
        former selectionStartEnd() is for single line and comparing
        startPos and endPos will make sense.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Ariya Hidayat <ariya.hidayat@gmail.com>
ariya@webkit.org [Wed, 17 Feb 2010 02:29:57 +0000 (02:29 +0000)]
2010-02-16  Ariya Hidayat  <ariya.hidayat@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Allow scrolling to an anchor programmatically.
        https://bugs.webkit.org/show_bug.cgi?id=29856

        * Api/qwebframe.cpp:
        (QWebFrame::scrollToAnchor): New API function.
        * Api/qwebframe.h:
        * tests/qwebframe/tst_qwebframe.cpp: New tests for scrollToAnchor().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInspector should display Array lengths in the property lists.
jberlin@webkit.org [Wed, 17 Feb 2010 02:25:47 +0000 (02:25 +0000)]
Inspector should display Array lengths in the property lists.
https://bugs.webkit.org/show_bug.cgi?id=20695

Reviewed by Timothy Hatcher.

* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
For objects of type 'array' (which includes Arrays, NodeLists, and HTMLCollections), make the length of the object available via propertyLength on the proxy object.
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
For properties that have propertyLength defined, append it to the displayed description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Yusuke Sato <yusukes@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 02:16:25 +0000 (02:16 +0000)]
2010-02-16  Yusuke Sato  <yusukes@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
        https://bugs.webkit.org/show_bug.cgi?id=34735

        * fast/css/font-face-opentype.html: Added.
        * fast/css/resources/Ahem.otf: Added. Ahem font which has CFF glyphs, converted from Ahem.ttf by FontForge (http://fontforge.sourceforge.net/).
        * platform/mac/fast/css/font-face-opentype-expected.checksum: Added.
        * platform/mac/fast/css/font-face-opentype-expected.png: Added.
        * platform/mac/fast/css/font-face-opentype-expected.txt: Added.
2010-02-16  Yusuke Sato  <yusukes@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
        https://bugs.webkit.org/show_bug.cgi?id=34735

        Use 0xFFFF as invalidGlyph when fontData is a OpenType font with CFF glyphs.

        Test: fast/css/font-face-opentype.html

        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillBMPGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Ariya Hidayat <ariya.hidayat@gmail.com>
ariya@webkit.org [Wed, 17 Feb 2010 02:11:38 +0000 (02:11 +0000)]
2010-02-16  Ariya Hidayat  <ariya.hidayat@gmail.com>

        Reviewed by Laszlo Gombos.

        Fix building with Qt < 4.6.
        https://bugs.webkit.org/show_bug.cgi?id=34885

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::updateResizesToContentsForPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange quota-tracking.html to open databases only as they're
dumi@chromium.org [Wed, 17 Feb 2010 01:51:18 +0000 (01:51 +0000)]
Change quota-tracking.html to open databases only as they're
needed. Otherwise, open databases end up using more space from
this origin than the test expects.

Reviewed by Simon Fraser.

* storage/quota-tracking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 17 Feb 2010 01:42:37 +0000 (01:42 +0000)]
2010-02-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Nikolas Zimmermann.

        Make this test more robust to slow-loading media.

        * media/video-load-networkState.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* page/MediaCanStartListener.h: Fixed license.
darin@apple.com [Wed, 17 Feb 2010 01:33:03 +0000 (01:33 +0000)]
* page/MediaCanStartListener.h: Fixed license.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 01:26:42 +0000 (01:26 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Simon Fraser.

        Skip svg/zoom/(page|text)/zoom-coords-viewattr-01-b.svg on SnowLeopard.
        svg/W3C-SVG-1.1/coords-viewattr* fail on SL and are already Skipped, seems related to entity parsing, not SVG.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 17 Feb 2010 01:23:19 +0000 (01:23 +0000)]
2010-02-16  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Generalize delayed plug-in start for background tabs for use for other media
        https://bugs.webkit.org/show_bug.cgi?id=34981

        * WebView.cpp:
        (WebView::setCanStartPlugins): Change to call setCanStartMedia.
        In a later patch we can change the of the public function in the IDL file too,
        but for now this should be enough.
2010-02-16  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Generalize delayed plug-in start for background tabs for use for other media
        https://bugs.webkit.org/show_bug.cgi?id=34981

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView viewWillMoveToWindow:]): Added comment.
        (-[WebHTMLView viewDidMoveToWindow]): Ditto.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        Call setCanStartMedia right away so that if this view is not in a window, it
        will not start any media.
        (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving
        to a window of nil.
        (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to
        a window that is non-nil.
2010-02-16  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Generalize delayed plug-in start for background tabs for use for other media
        https://bugs.webkit.org/show_bug.cgi?id=34981

        Also did some simple cleanup of HTMLMediaElement to get ready to make it
        a client of the same mechanism.

        * WebCore.base.exp: Added Page::setCanStartMedia and resorted.
        * WebCore.xcodeproj/project.pbxproj: Added MediaCanStartListener.h.

        * html/HTMLAudioElement.h: Added an implementation of isVideo since that
        is now a pure virtual function in HTMLMediaElement. Also made tagPriority
        private.

        * html/HTMLMediaElement.h: Made it clearer that HTMLMediaElement is an
        abstract base class by making its constructor protected and making the
        isVideo function a pure virtual function.

        * page/Page.cpp:
        (WebCore::Page::Page): Updated for name change from m_canStartPlugins
        to m_canStartMedia.
        (WebCore::Page::addMediaCanStartListener): Renamed and added an assertion.
        (WebCore::Page::removeUnstartedMedia): Ditto.
        (WebCore::Page::setCanStartMedia): Renamed plugin to media and moved
        the code here from PageWin.cpp. The main change from the one in PageWin.cpp
        is that this function calls mediaCanStart rather than explicitly calling a
        combination of start and dispatchDidFailToStartPlugin on a PluginView.

        * page/Page.h: Re-sorted forward class declarations. Renamed the plugin
        starting functions to media starting names and changed types from
        PluginView to MediaCanStartListener.

        * page/MediaCanStartListener.h: Added.

        * page/win/PageWin.cpp: Moved setCanStartPlugins to the platform-independent
        Page.cpp file so it can be used for more than just Windows plug-ins.

        * plugins/PluginView.cpp: Sorted includes.
        (WebCore::PluginView::startOrAddToUnstartedList): Use addMediaCanStartListener.
        (WebCore::PluginView::mediaCanStart): Added. Called when the page decides that
        media can start. Contains the code that used to be in Page::setCanStartPlugins.
        (WebCore::PluginView::removeFromUnstartedListIfNecessary): Use
        removeMediaCanStartListener.

        * plugins/PluginView.h: Adopted MediaCanStartListener.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 17 Feb 2010 00:50:31 +0000 (00:50 +0000)]
2010-02-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=34999
        Compositing layers inside overflow:scroll divs are not always updated on scrolling

        When RenderLayer::scrollToOffset() updates compositing layer positions, it needs
        to start updating at its stacking context rather than just its compositing ancestor.
        The stacking context is guaranteed to contain all descendants of the overflow
        layer, including those that are not direct descendants of the overflow layer in stacking
        (and therefore compositing) order.

        Test: compositing/overflow/scroll-ancestor-update.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable warnings preventing use of anonymous structs/onions -
barraclough@apple.com [Wed, 17 Feb 2010 00:25:43 +0000 (00:25 +0000)]
Disable warnings preventing use of anonymous structs/onions -
don't take all my fun toys away, these are useful & awesome!

Reviewed by NOBODY (Build fix).

* win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 00:09:43 +0000 (00:09 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Dirk Schulze.

        Add missing .checksum file in platform/mac/svg/zoom/page. All parts of the original patch for bug 14004 have been landed.

        * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow FloatRect::center() to return fractional coordinates. It was
mitz@apple.com [Wed, 17 Feb 2010 00:08:06 +0000 (00:08 +0000)]
Allow FloatRect::center() to return fractional coordinates. It was
mistakenly converting to integers.

Reviewed by Simon Fraser.

* platform/graphics/FloatRect.h:
(WebCore::FloatRect::center):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 00:05:33 +0000 (00:05 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by David Hyatt.

        SVG units don't stay consistently sized on zoom
        https://bugs.webkit.org/show_bug.cgi?id=14004

        * platform/mac/svg/zoom: Added.
        * platform/mac/svg/zoom/page: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
        * platform/mac/svg/zoom/text: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
        * svg/zoom: Added.
        * svg/zoom/NOTE: Added.
        * svg/zoom/page: Added.
        * svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
        * svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
        * svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
        * svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
        * svg/zoom/page/zoom-foreignObject.svg: Added.
        * svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
        * svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
        * svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
        * svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
        * svg/zoom/resources: Added.
        * svg/zoom/resources/testPageZoom.js: Added.
        * svg/zoom/resources/testTextZoom.js: Added.
        * svg/zoom/text: Added.
        * svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
        * svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
        * svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
        * svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
        * svg/zoom/text/zoom-foreignObject.svg: Added.
        * svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
        * svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
        * svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
        * svg/zoom/text/zoom-svg-float-border-padding.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=34964
barraclough@apple.com [Wed, 17 Feb 2010 00:01:58 +0000 (00:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=34964
Leaks tool reports false memory leaks due to Rope implementation.

Reviewed by Oliver Hunt.

JavaScriptCore:

A rope is a recursive data structure where each node in the rope holds a set of
pointers, each of which may reference either a string (in UStringImpl form) or
another rope node.  A low bit in each pointer is used to distinguish between
rope & string elements, in a fashion similar to the recently-removed
PtrAndFlags class (see https://bugs.webkit.org/show_bug.cgi?id=33731 ).  Again,
this causes a problem for Leaks – refactor to remove the magic pointer
mangling.

Move Rope out from JSString.h and rename to URopeImpl, to match UStringImpl.
Give UStringImpl and URopeImpl a common parent class, UStringOrRopeImpl.
Repurpose an otherwise invalid permutation to flags (static & should report
memory cost) to identify ropes.

This allows us to change the rope's fibers to interrogate the object rather
than storing a bool within the low bits of the pointer (or in some cases the
use of a common parent class removes the need to determine the type at all -
there is a common interface to ref or get the length of either ropes or strings).

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/JSString.h:
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::JSStringFinalizerStruct::JSStringFinalizerStruct):
(JSC::RopeBuilder::JSStringFinalizerStruct::):
* runtime/UString.cpp:
(JSC::UString::toStrictUInt32):
(JSC::equal):
* runtime/UString.h:
(JSC::UString::isEmpty):
(JSC::UString::size):
* runtime/UStringImpl.cpp:
(JSC::URopeImpl::derefFibersNonRecursive):
(JSC::URopeImpl::destructNonRecursive):
* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::isRope):
(JSC::UStringOrRopeImpl::length):
(JSC::UStringOrRopeImpl::ref):
(JSC::UStringOrRopeImpl::):
(JSC::UStringOrRopeImpl::operator new):
(JSC::UStringOrRopeImpl::UStringOrRopeImpl):
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::):
(JSC::URopeImpl::tryCreateUninitialized):
(JSC::URopeImpl::initializeFiber):
(JSC::URopeImpl::fiberCount):
(JSC::URopeImpl::fibers):
(JSC::URopeImpl::deref):
(JSC::URopeImpl::URopeImpl):
(JSC::URopeImpl::hasOneRef):
(JSC::UStringOrRopeImpl::deref):

WebCore:

Renamed cUStringImpl::size() to UStringImpl::size()UStringImpl::length()
(matches WebCore::StringImpl).

* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::length):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r54811) fast/canvas/drawImage-with-negative-source-destination.html...
ossy@webkit.org [Tue, 16 Feb 2010 23:55:05 +0000 (23:55 +0000)]
[Qt] REGRESSION(r54811) fast/canvas/drawImage-with-negative-source-destination.html fails
https://bugs.webkit.org/show_bug.cgi?id=35005

* platform/qt/Skipped:
 - fast/canvas/drawImage-with-negative-source-destination.html skipped until fix.
 - inspector/timeline-paint.html skipped because it is flakey.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7288853> Message about missing plugin does not specify
jhoneycutt@apple.com [Tue, 16 Feb 2010 23:49:35 +0000 (23:49 +0000)]
<rdar://problem/7288853> Message about missing plugin does not specify
the type or download link for download

Reviewed by Mark Rowe.

* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::findPlugin):
Only update the mimeType out param if we find a plug-in for the file
extension.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 16 Feb 2010 23:41:07 +0000 (23:41 +0000)]
2010-02-16  Simon Fraser  <simon.fraser@apple.com>

        Build fix for Tiger.

        Add #if USE(ACCELERATED_COMPOSITING) around the call to mediaPlayerRenderingModeChanged().

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::setUpVideoRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuildfix for r54826.
ossy@webkit.org [Tue, 16 Feb 2010 23:03:58 +0000 (23:03 +0000)]
Buildfix for r54826.

Reviewed by Eric Carlson.

HTMLMediaElement class defined by HTMLMediaElement.h in #if ENABLE(VIDEO) block,
it should be in #if ENABLE(VIDEO) block in rendering/RenderLayerBacking.cpp too.

* rendering/RenderLayerBacking.cpp: Missing #if ENABLE(VIDEO) guard added.
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out the rest of r54833 as it includes more unrelated changes.
mrowe@apple.com [Tue, 16 Feb 2010 23:02:29 +0000 (23:02 +0000)]
Roll out the rest of r54833 as it includes more unrelated changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLet's not check garbage in to common build scripts and hose the world now eh guys?
mrowe@apple.com [Tue, 16 Feb 2010 23:00:44 +0000 (23:00 +0000)]
Let's not check garbage in to common build scripts and hose the world now eh guys?

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed: Chromium build fix.
jparent@chromium.org [Tue, 16 Feb 2010 22:56:50 +0000 (22:56 +0000)]
Unreviewed: Chromium build fix.

http://trac.webkit.org/changeset/54823 introduced an unused variable.  Remove it.

* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 34974: Leak of ScheduledAction during layout tests
mrowe@apple.com [Tue, 16 Feb 2010 22:53:46 +0000 (22:53 +0000)]
Bug 34974: Leak of ScheduledAction during layout tests
<https://bugs.webkit.org/show_bug.cgi?id=34974>

Reviewed by Alexey Proskuryakov.

ScheduledAction::create was returning a raw pointer which was threaded down through to an OwnPtr in DOMTimer.
If any of the code paths in between hit an error case and returned early the raw pointer would be leaked.  We
can avoid this by passing it as a PassOwnPtr.  This will ensure that the ScheduledAction is cleaned up should
an error case be hit.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout): Store the newly-created ScheduledAction in an OwnPtr and then hand it off
as the function argument.
(WebCore::JSDOMWindow::setInterval): Ditto.
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::setTimeout): Ditto.
(WebCore::JSWorkerContext::setInterval): Ditto.
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create): Return a PassOwnPtr.
* bindings/js/ScheduledAction.h:
* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer): Update argument type.
(WebCore::DOMTimer::install): Ditto.
* page/DOMTimer.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setTimeout): Ditto.
(WebCore::DOMWindow::setInterval): Ditto.
* page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 16 Feb 2010 22:51:13 +0000 (22:51 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by David Hyatt.

        SVG units don't stay consistently sized on zoom
        https://bugs.webkit.org/show_bug.cgi?id=14004

        Large step towards making WebKit an usable SVG viewer.

        Make zooming into SVG documents work as expected, in both standalone and XHTML/SVG compound documents.
        SVG applies a global scale to the document, whereas CSS zooms all individual length units (on full-page-zoom).
        Scaling has to be avoided for all SVG specific CSS properties (already works) and for some selected CSS
        properties shared between CSS & SVG that explicitely need a different treatment in the context of SVG.
        To name a few: font-size, letter-spacing, etc. should stay invariant under zoom in SVG document fragments.

        Some new rules regarding zooming:
        - "Zoom text only" should never affect SVG documents, neither text nor content should zoom.
          This option doesn't make much sense for SVG, so it's wise to avoid side-effects and disable it.
          In compound documents the SVG would stay as-is and only text of surrounding XHTML content would zoom.

        - "Full page zoom" is the only zoom mode affecting SVG. (Panning only works in standalone documents.)

        Cover all mentioned cases above by a new set of layout tests.

        Tests: svg/zoom/page/absolute-sized-document-no-scrollbars.svg
               svg/zoom/page/absolute-sized-document-scrollbars.svg
               svg/zoom/page/relative-sized-document-scrollbars.svg
               svg/zoom/page/zoom-coords-viewattr-01-b.svg
               svg/zoom/page/zoom-foreignObject.svg
               svg/zoom/page/zoom-hixie-mixed-008.xml
               svg/zoom/page/zoom-hixie-mixed-009.xml
               svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
               svg/zoom/page/zoom-svg-float-border-padding.xml
               svg/zoom/text/absolute-sized-document-no-scrollbars.svg
               svg/zoom/text/absolute-sized-document-scrollbars.svg
               svg/zoom/text/relative-sized-document-scrollbars.svg
               svg/zoom/text/zoom-coords-viewattr-01-b.svg
               svg/zoom/text/zoom-foreignObject.svg
               svg/zoom/text/zoom-hixie-mixed-008.xml
               svg/zoom/text/zoom-hixie-mixed-009.xml
               svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
               svg/zoom/text/zoom-svg-float-border-padding.xml

        * css/CSSStyleSelector.cpp: Blacklist certain properties not to be zoomed for SVG elements.
        (WebCore::CSSStyleSelector::styleForDocument): Don't zoom font-sizes.
        (WebCore::CSSStyleSelector::applyProperty): Ditto (+ letter/word-spacing).
        (WebCore::CSSStyleSelector::setFontSize): Ditto.
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): Never apply text zoom to SVG.
        * css/CSSStyleSelector.h:
        * css/SVGCSSStyleSelector.cpp: -webkit-shadow + SVG was incorrectly respecting zoom factor.
        (WebCore::CSSStyleSelector::applySVGProperty):
        * page/Frame.cpp:
        (WebCore::Frame::shouldApplyTextZoom): Remove SVG special cases.
        (WebCore::Frame::shouldApplyPageZoom): Ditto.
        (WebCore::Frame::setZoomFactor): Don't force setZoomsTextOnly() - SVG now uses FPZ as well.
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::calcReplacedWidth): CSSPropertyWidth is explicitely not scaled by CSSStyleSelector, fix that for outermost <svg> elements.
        (WebCore::RenderSVGRoot::calcReplacedHeight): Ditto for CSSPropertyHeight.
        (WebCore::RenderSVGRoot::layout): Simplify & cleanup code, take advantage of new calcWidth/Height functionality, no need to scale anything here.
        (WebCore::RenderSVGRoot::paint): Use parentOriginToBorderBox() instead of duplicating code.
        (WebCore::RenderSVGRoot::calcViewport): Simplify code.
        (WebCore::RenderSVGRoot::localToBorderBoxTransform): Calculate viewBoxToViewTransformation() against unscaled width()/height() values.
        * rendering/RenderSVGRoot.h:
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::PercentageOfViewport): Cleanup & document function.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::currentScale): Return pageZoomFactor(), not just the zoomFactor() - as we want to ignore text-only zoom.
        (WebCore::SVGSVGElement::setCurrentScale): Pass isTextOnly=false to setZoomFactor().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 16 Feb 2010 22:46:41 +0000 (22:46 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by David Hyatt.

        SVG units don't stay consistently sized on zoom
        https://bugs.webkit.org/show_bug.cgi?id=14004

        * platform/mac/svg/zoom: Added.
        * platform/mac/svg/zoom/page: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
        * platform/mac/svg/zoom/text: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
        * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
        * platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
        * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
        * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
        * platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
        * svg/zoom: Added.
        * svg/zoom/NOTE: Added.
        * svg/zoom/page: Added.
        * svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
        * svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
        * svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
        * svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
        * svg/zoom/page/zoom-foreignObject.svg: Added.
        * svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
        * svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
        * svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
        * svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
        * svg/zoom/resources: Added.
        * svg/zoom/resources/testPageZoom.js: Added.
        * svg/zoom/resources/testTextZoom.js: Added.
        * svg/zoom/text: Added.
        * svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
        * svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
        * svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
        * svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
        * svg/zoom/text/zoom-foreignObject.svg: Added.
        * svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
        * svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
        * svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
        * svg/zoom/text/zoom-svg-float-border-padding.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 16 Feb 2010 22:44:21 +0000 (22:44 +0000)]
2010-02-16  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=34988
        WebHTMLView.mm has two -willRemoveSubview: methods

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed: Chromium build fix.
jparent@chromium.org [Tue, 16 Feb 2010 22:30:38 +0000 (22:30 +0000)]
Unreviewed: Chromium build fix.

https://bugs.webkit.org/show_bug.cgi?id=34998

Move include of JavaScriptProfile.h behind if (USE_JSC).

* inspector/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 16 Feb 2010 22:21:44 +0000 (22:21 +0000)]
2010-02-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        re-factor Skipped list parsing code into multiple functions and unit test it
        https://bugs.webkit.org/show_bug.cgi?id=34986

        * Scripts/test-webkitpy: Add new unit test.
        * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
        * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Geoffrey Garen and Kevin Decker.
ap@apple.com [Tue, 16 Feb 2010 22:16:08 +0000 (22:16 +0000)]
    Reviewed by Geoffrey Garen and Kevin Decker.

        https://bugs.webkit.org/show_bug.cgi?id=34989
        <rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content

        This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
        in the former case, and adjustCursor in the latter).

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView handleMouseEntered:]):
        (-[WebHostedNetscapePluginView handleMouseExited:]):
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView handleMouseEntered:]):
        (-[WebBaseNetscapePluginView handleMouseExited:]):
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView handleMouseEntered:]):
        (-[WebNetscapePluginView handleMouseExited:]):
        AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to
        notify plug-in views of mouse entered/exited as part of DOM event dispatch.

        * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides
        mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event
        handler. Other mouse events are passed down by EventHandler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 16 Feb 2010 22:04:37 +0000 (22:04 +0000)]
2010-02-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Carlson.

        With hardware acceleration turned off, video frames never display if poster
        image is specified
        https://bugs.webkit.org/show_bug.cgi?id=34965

        HTMLVideoElement's m_shouldDisplayPosterImage was never updated after
        the movie supplied its first video frame, so the poster would continue to show.

        Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called
        each time a new frame is available. updatePosterImage() is cheap.

        Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of
        ugly casts.

        Test: manual-tests/media-elements/video-replaces-poster.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check.
        (WebCore::HTMLMediaElement::setNetworkState): Ditto.
        (WebCore::HTMLMediaElement::setReadyState): Ditto.
        (WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage().
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual
        method on the base class.
        * html/HTMLVideoElement.h: Override updatePosterImage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 16 Feb 2010 21:55:28 +0000 (21:55 +0000)]
2010-02-16  Simon Fraser  <simon.fraser@apple.com>

        Build fix for platforms without ACCELERATED_COMPOSITING defined.

        mediaPlayerRenderingModeChanged() is only available when ACCELERATED_COMPOSITING is defined.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::setUpVideoRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 16 Feb 2010 21:46:06 +0000 (21:46 +0000)]
2010-02-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Carlson.

        Autoplaying video with poster doesn't reliably show up
        https://bugs.webkit.org/show_bug.cgi?id=34966

        A timing issue with compositing updates when replacing the poster image
        with the video could cause the video to not display.

        Fix by making video layer hook up more similar to WebGL etc, by having the
        video kick off a recalcStyle() via a SyntheticStyleChange. This requires
        vending a PlaformLayer* from the media player, up through the element.

        Test: media/video-replaces-poster.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaPlayerRenderingModeChanged): Use setNeedsStyleRecalc()
        to kick off a compositing update.

        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::platformLayer): Export the media engine's layer.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::NullMediaPlayerPrivate::platformLayer): Method to vend the media layer.
        (WebCore::MediaPlayer::platformLayer):

        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayerClient::mediaPlayerRenderingModeChanged): New client callback
        to indicate that the rendering mode changed. The element uses this to kick off a
        recalcStyle.

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::platformLayer): Method to vend the media layer.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieLayer): No longer parent the layer directly
        via setContentsToMedia().
        (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): Ditto.
        (WebCore::MediaPlayerPrivate::setUpVideoRendering): Tell the client that the
        rendering mode changed.
        (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Call setContentsToMedia()
        here.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Add platformLayer().
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer.
        (WebCore::MediaPlayerPrivate::setUpVideoRendering): Call mediaPlayerRenderingModeChanged()
        (WebCore::MediaPlayerPrivate::createLayerForMovie): Don't parent the layer ourselves any more.

        * rendering/RenderVideo.h: videoGraphicsLayer() is no longer needed.
        * rendering/RenderVideo.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 16 Feb 2010 21:06:42 +0000 (21:06 +0000)]
2010-02-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Refreshed all localization-related files, so that they are
        up-to-date with the code.

        * de.po: Updated.
        * en_GB.po: Updated.
        * es.po: Updated.
        * it.po: Updated.
        * lt.po: Updated.
        * nl.po: Updated.
        * pt_BR.po: Updated.
        * ru.po: Updated.
        * sr.po: Updated.
        * sr@latin.po: Updated.
        * sv.po: Updated.
        * vi.po: Updated.
        * webkit.pot: Updated.
        * zh_CN.po: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Gil Osher <gilosher@gmail.com>
kov@webkit.org [Tue, 16 Feb 2010 21:06:18 +0000 (21:06 +0000)]
2010-02-16  Gil Osher <gilosher@gmail.com>

        Reviewed by Gustavo Noronha.

        Localization of WebKitGTK+ in Hebrew.

        * he.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCode cleanup in ImageDecoders; no functional change.
pkasting@chromium.org [Tue, 16 Feb 2010 20:50:10 +0000 (20:50 +0000)]
Code cleanup in ImageDecoders; no functional change.
https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

* Make code mostly comply with the style guide (switch indenting, use of
  "!" vs. "== 0", don't unnecessarily wrap lines, etc.)
* Eliminate m_allDataReceived in ICO/BMP decoders since it's in the
  base ImageDecoder class
* Remove some useless or wrong comments, add others
* Wrap comments at 80 columns (most already were) for
  consistency/readability
* Avoid casts by using correct variable types
* Consistent naming of decode() function/args
* Shorter code in some places
* Make declaration and definition order match

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::forceLoadEverything):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::setSize):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::):
(WebCore::ImageDecoder::ImageDecoder):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::BMPImageDecoder):
(WebCore::BMPImageDecoder::setData):
(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::decode):
(WebCore::BMPImageDecoder::decodeHelper):
(WebCore::BMPImageDecoder::processFileHeader):
* platform/image-decoders/bmp/BMPImageDecoder.h:
(WebCore::BMPImageDecoder::readUint32):
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::BMPImageReader):
(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::isInfoHeaderValid):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):
* platform/image-decoders/bmp/BMPImageReader.h:
(WebCore::BMPImageReader::readUint32):
(WebCore::BMPImageReader::pastEndOfImage):
(WebCore::BMPImageReader::readCurrentPixel):
(WebCore::BMPImageReader::getComponent):
(WebCore::BMPImageReader::getAlpha):
(WebCore::BMPImageReader::setI):
(WebCore::BMPImageReader::setRGBA):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/gif/GIFImageDecoder.h:
(WebCore::GIFImageDecoder::):
(WebCore::GIFImageDecoder::filenameExtension):
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::do_lzw):
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::~GIFImageReader):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::ICOImageDecoder):
(WebCore::ICOImageDecoder::~ICOImageDecoder):
(WebCore::ICOImageDecoder::setData):
(WebCore::ICOImageDecoder::isSizeAvailable):
(WebCore::ICOImageDecoder::frameSizeAtIndex):
(WebCore::ICOImageDecoder::frameCount):
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::compareEntries):
(WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex):
(WebCore::ICOImageDecoder::decode):
(WebCore::ICOImageDecoder::decodeDirectory):
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectoryEntries):
(WebCore::ICOImageDecoder::readDirectoryEntry):
* platform/image-decoders/ico/ICOImageDecoder.h:
(WebCore::ICOImageDecoder::readUint16):
(WebCore::ICOImageDecoder::readUint32):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageReader::decode):
(WebCore::error_exit):
(WebCore::fill_input_buffer):
(WebCore::term_source):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::jpegComplete):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
(WebCore::JPEGImageDecoder::filenameExtension):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):
(WebCore::decodingWarning):
(WebCore::headerAvailable):
(WebCore::rowAvailable):
(WebCore::pngComplete):
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageReader::createInterlaceBuffer):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::filenameExtension):
* platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::setDecodedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 16 Feb 2010 14:44:20 +0000 (14:44 +0000)]
2010-02-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Check if the handle has a SoupMessage before trying to use
        it. This will be the case in non-HTTP(S) URLs.

        * webkit/webkitdownload.cpp:
        (webkit_download_new_with_handle):
        (webkit_download_start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed buildfix.
ossy@webkit.org [Tue, 16 Feb 2010 13:32:44 +0000 (13:32 +0000)]
[Qt] Unreviewed buildfix.

* WebCore.pro: Missing backslash added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 16 Feb 2010 13:17:49 +0000 (13:17 +0000)]
2010-02-16  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.

        https://bugs.webkit.org/show_bug.cgi?id=34848

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JavaScriptProfile.cpp: Added.
        (WebCore::profileCache):
        (WebCore::getTitleCallback):
        (WebCore::getHeadCallback):
        (WebCore::getUniqueIdCallback):
        (WebCore::focus):
        (WebCore::exclude):
        (WebCore::restoreAll):
        (WebCore::finalize):
        (WebCore::ProfileClass):
        (WebCore::toJS):
        * bindings/js/JavaScriptProfile.h: Added.
        * bindings/js/JavaScriptProfileNode.cpp: Added.
        (WebCore::profileNodeCache):
        (WebCore::getFunctionName):
        (WebCore::getURL):
        (WebCore::getLineNumber):
        (WebCore::getTotalTime):
        (WebCore::getSelfTime):
        (WebCore::getNumberOfCalls):
        (WebCore::getChildren):
        (WebCore::getVisible):
        (WebCore::getCallUID):
        (WebCore::finalize):
        (WebCore::ProfileNodeClass):
        (WebCore::toJS):
        * bindings/js/JavaScriptProfileNode.h: Added.
        * inspector/JavaScriptProfile.cpp: Removed.
        * inspector/JavaScriptProfile.h: Removed.
        * inspector/JavaScriptProfileNode.cpp: Removed.
        * inspector/JavaScriptProfileNode.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 16 Feb 2010 13:11:41 +0000 (13:11 +0000)]
2010-02-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Elements Panel: Limit the number of initially loaded element children
        https://bugs.webkit.org/show_bug.cgi?id=34421

        Test: inspector/elements-panel-limited-children.html

        WebCore:
        * English.lproj/localizedStrings.js:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype._insertChild):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
        (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
        (WebInspector.ElementsTreeElement):
        (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit):
        (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit):
        (WebInspector.ElementsTreeElement.prototype.get expandedChildCount):
        (WebInspector.ElementsTreeElement.prototype.showChild):
        (WebInspector.ElementsTreeElement.prototype.insertChildElement):
        (WebInspector.ElementsTreeElement.prototype.moveChild):
        (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
        (WebInspector.ElementsTreeElement.prototype._updateChildren):
        (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
        (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren):
        ():
        * inspector/front-end/inspector.css:

        LayoutTests:
        * inspector/elements-panel-limited-children-expected.txt: Added.
        * inspector/elements-panel-limited-children.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 16 Feb 2010 12:54:05 +0000 (12:54 +0000)]
2010-02-16  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Bump version to 1.1.22 so we can depend on it in applications.

        * configure.ac:

WebKit/gtk:

2010-02-16  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Add a new WebKitWebSettings setting, 'auto-resize-window', set to
        FALSE by default, that when enabled will apply any resizes or
        moves done by a page through various DOM methods (moveTo,
        resizeTo, moveBy, resizeBy).

        * WebCoreSupport/ChromeClientGtk.cpp:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):

WebKitTools:

2010-02-16  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Enable 'auto-resize-window' in our DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor and split up basic-touch-events test
benm@google.com [Tue, 16 Feb 2010 11:18:30 +0000 (11:18 +0000)]
Refactor and split up basic-touch-events test
https://bugs.webkit.org/show_bug.cgi?id=34476

Reviewed by Simon Hausmann.

Split the basic-touch-events test into two separate tests, one for single and another for multi touch. Also refactor the tests to run in an asynchronous manner.

* fast/events/touch/basic-multi-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same multi touch tests cases from the old basic-touch-events test.
* fast/events/touch/basic-multi-touch-events-expected.txt: Added.
* fast/events/touch/script-tests/basic-multi-touch-events.js: Added.
* fast/events/touch/basic-single-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same single touch tests cases from the old basic-touch-events test.
* fast/events/touch/script-tests/basic-single-touch-events.js: Added.
* fast/events/touch/basic-single-touch-events-expected.txt: Added.
* fast/events/touch/basic-touch-events.html: Removed.
* fast/events/touch/script-tests/basic-touch-events.js: Removed.
* fast/events/touch/basic-touch-events-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Symbian build fix.
hausmann@webkit.org [Tue, 16 Feb 2010 11:14:16 +0000 (11:14 +0000)]
Unreviewed Symbian build fix.

Updated the def file with two new exports used by QtLauncher.

* symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Ismail Donmez <ismail@namtrac.org>
eric@webkit.org [Tue, 16 Feb 2010 11:10:14 +0000 (11:10 +0000)]
2010-02-16  Ismail Donmez  <ismail@namtrac.org>

        Reviewed by Pavel Feldman.

        Fix compilation with inspector disabled.
        https://bugs.webkit.org/show_bug.cgi?id=32724

        * rendering/RenderLayerBacking.cpp:
        (WebCore::inspectorTimelineAgent):
2010-02-16  Ismail Donmez  <ismail@namtrac.org>

        Reviewed by Pavel Feldman.

        Fix compilation with inspector disabled.
        https://bugs.webkit.org/show_bug.cgi?id=32724

        * Api/qwebpage.cpp:
        (qt_drt_webinspector_executeScript):
        (qt_drt_webinspector_close):
        (qt_drt_webinspector_show):
        (qt_drt_setTimelineProfilingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix include paths for forwarding headers in standalone builds.
hausmann@webkit.org [Tue, 16 Feb 2010 10:27:03 +0000 (10:27 +0000)]
[Qt] Fix include paths for forwarding headers in standalone builds.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-02-16
Reviewed by Simon Hausman.

* Api/DerivedSources.pro: Use relative paths for package builds and added some
documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Feb 2010 10:25:29 +0000 (10:25 +0000)]
2010-02-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: turn off line wrapping in source view.

        https://bugs.webkit.org/show_bug.cgi?id=34935

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.markAndRevealRange):
        (WebInspector.TextViewer.prototype._paintLine):
        * inspector/front-end/textViewer.css:
        * inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Feb 2010 10:08:21 +0000 (10:08 +0000)]
2010-02-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: let search iterate over views in Resources
        and keep the view in Scripts.

        https://bugs.webkit.org/show_bug.cgi?id=34968

        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.jumpToNextSearchResult):
        (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
        (WebInspector.Panel.prototype.showSourceLineForURL):
        (WebInspector.Panel.prototype.searchIteratesOverViews):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.get _resources):
        (WebInspector.ResourcesPanel.prototype.searchIteratesOverViews):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.showingLastSearchResult):
        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):
        (WebInspector.focusSearchField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Tue, 16 Feb 2010 09:17:44 +0000 (09:17 +0000)]
2010-02-16  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] canvas clipping is buggy
        https://bugs.webkit.org/show_bug.cgi?id=32405

        Apparently the bug was in GraphicsContext::roundToDevicePixels, we
        didn't take unto accounts rotation, so the device pixels were rounded
        incorrectly. The new formula is a 1:1 copy from GraphicsContextCG so
        it should be rather safe

        Test: http://glimr.rubyforge.org/cake/canvas.html#Polaroids now looks right

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::roundToDevicePixels): Copy the formula from
        GraphicsContextCG

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 16 Feb 2010 08:48:31 +0000 (08:48 +0000)]
2010-02-16  Yury Semikhatsky  <yurys@chromium.org>

        Not Reviewed, build fix.

        * platform/graphics/FloatRect.h:
        (WebCore::FloatRect::center): make conversion from float to int explicit so that compiler
        doesn't complain about that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-15 Gabor Loki <loki@webkit.org>
eric@webkit.org [Tue, 16 Feb 2010 07:42:20 +0000 (07:42 +0000)]
2010-02-15  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        Fix the SP at ctiOpThrowNotCaught on Thumb2 (JSVALUE32)
        https://bugs.webkit.org/show_bug.cgi?id=34939

        * jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-15 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Tue, 16 Feb 2010 06:17:21 +0000 (06:17 +0000)]
2010-02-15  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Darin Adler.

        check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
        https://bugs.webkit.org/show_bug.cgi?id=34834

        * Scripts/webkitpy/style/processors/cpp.py:
        * Scripts/webkitpy/style/processors/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: <rdar://problem/7645609> [webView selectionRect] API is broken for multicolu...
mitz@apple.com [Tue, 16 Feb 2010 04:19:04 +0000 (04:19 +0000)]
WebCore: <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout

Reviewed by Simon Fraser.

Refine the fix for https://bugs.webkit.org/show_bug.cgi?id=34923 by using the center of
a quad’s bounding box, rather than its top left, as the reference point passed to
offsetFromContainer(). This ensures that if a sliver off the top of the selection rect is in
one column, but most of it is on another column, the single rect we return will be for the
second column.

* platform/graphics/FloatRect.h:
(WebCore::FloatRect::center): Added.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localToContainerQuad): Use the center instead of the top left.

LayoutTests: Add test case for <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout

Reviewed by Simon Fraser.

* fast/multicol/client-rects-expected.checksum:
* fast/multicol/client-rects-expected.png:
* fast/multicol/client-rects-expected.txt:
* fast/multicol/client-rects.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54807 268f45cc-cd09-0410-ab3c-d52691b4dbfc