WebKit-https.git
7 years agoUnreviewed gardening, update expected files after r134435.
ossy@webkit.org [Wed, 14 Nov 2012 06:56:27 +0000 (06:56 +0000)]
Unreviewed gardening, update expected files after r134435.

* dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
* fast/dom/DOMException/prototype-object-expected.txt:
* fast/dom/DOMException/stack-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Console: update tab/shift-tab shortcut description.
commit-queue@webkit.org [Wed, 14 Nov 2012 06:55:12 +0000 (06:55 +0000)]
Web Inspector: Console: update tab/shift-tab shortcut description.
https://bugs.webkit.org/show_bug.cgi?id=102175

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-13
Reviewed by Pavel Feldman.

For "Tab / Shift-Tab" it said "Next/previous suggestion".
Actually, shift-tab to do nothing, and tab auto-completes common prefix.

* English.lproj/localizedStrings.js: Replaced string.
* inspector/front-end/ConsoleView.js: Updated shortcut registration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Pass showDebugBorders directly to WebLayerTreeSettings, don't use the...
danakj@chromium.org [Wed, 14 Nov 2012 06:37:20 +0000 (06:37 +0000)]
[chromium] Pass showDebugBorders directly to WebLayerTreeSettings, don't use the GraphicsLayer border width setting.
https://bugs.webkit.org/show_bug.cgi?id=102130

Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

The current method of setting debug borders on GraphicsLayers requires
every GraphicsLayerClient to set the value on the layer(s) it
represents. This skips the NonCompositedContentHost as well as any
other clients other than RenderLayerBacking - including layers from the
inspector.

Instead, pass the debug border setting directly to the
WebLayerTreeSettings where the compositor can use the flag to enable
borders on all layers globally.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable calendar picker for input types datetime/datetime-local
commit-queue@webkit.org [Wed, 14 Nov 2012 06:30:04 +0000 (06:30 +0000)]
Enable calendar picker for input types datetime/datetime-local
https://bugs.webkit.org/show_bug.cgi?id=101889

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-13
Reviewed by Kent Tamura.

Source/WebCore:

This adds calendar picker to <input type=datetime> and <input type=datetime-local>.
When a user choose a date from calendar picker, year/month/day fields of the input
element are updated and hour/minute/second fields are unchanged.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-local.html
       platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html

* Resources/pagepopups/calendarPicker.js: Day.parse accepts datetime string (just drops time part).
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue):
If the given value is not valid for the element, try to parse it as a date string.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::formatDateTimeFieldsState): DateTimeFieldsState::month() returns 1-12, not 0-11.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState): Ditto.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::setOnlyYearMonthDay): Added.
(WebCore):
* html/shadow/DateTimeEditElement.h:
(DateTimeEditElement):
* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker): Return true for datetime and datetimelocal too.

LayoutTests:

Added tests for calendar picker for inpt type=datetime/datetime-local.

* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134524.
haraken@chromium.org [Wed, 14 Nov 2012 06:18:03 +0000 (06:18 +0000)]
Unreviewed, rolling out r134524.
http://trac.webkit.org/changeset/134524
https://bugs.webkit.org/show_bug.cgi?id=102177

"Chromiium build broken" (Requested by haraken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* rendering/RenderThemeChromiumFontProvider.cpp: Removed.
* rendering/RenderThemeChromiumFontProvider.h: Removed.
* rendering/RenderThemeChromiumFontProviderLinux.cpp: Removed.
* rendering/RenderThemeChromiumFontProviderWin.cpp: Removed.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::defaultGUIFont):
(WebCore::RenderThemeChromiumSkia::systemFont):
(WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::getNonClientMetrics):
(WebCore::systemFontSize):
(WebCore::pointsToPixels):
(WebCore::RenderThemeChromiumWin::systemFont):
(WebCore::RenderThemeChromiumWin::setDefaultFontSize):
* rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix compile warning [-Wsign-compare]
commit-queue@webkit.org [Wed, 14 Nov 2012 06:15:12 +0000 (06:15 +0000)]
Fix compile warning [-Wsign-compare]
https://bugs.webkit.org/show_bug.cgi?id=101458

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-13
Reviewed by Alexey Proskuryakov.

Currently, lossy check has been done by comparing file size(posix signed integral value) with conversioned(standard c++ unsigned integral value).
However, it leads -Wsign-compare compile warning.
Therefore, this patch assigns the file size to the biggest possible unsigned variable, then does the lossy check.

* platform/posix/SharedBufferPOSIX.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable datalist UI for input types week and month
keishi@webkit.org [Wed, 14 Nov 2012 06:13:52 +0000 (06:13 +0000)]
Enable datalist UI for input types week and month
https://bugs.webkit.org/show_bug.cgi?id=102041

Reviewed by Kent Tamura.

Source/WebCore:

Enabling datalist UI for input types week and month.

No new tests. Tests will be added later in Bug 102039 and Bug 102040.

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add month and week to the list.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): If the type supports calendar picker show the "Other..." option.

LayoutTests:

* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocheckbox to toggle FPS counter in the inspector's settings
commit-queue@webkit.org [Wed, 14 Nov 2012 05:52:55 +0000 (05:52 +0000)]
checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660

Patch by Eberhard Graether <egraether@google.com> on 2012-11-13
Reviewed by Pavel Feldman.

Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowFPSCounter):

Source/WebCore:

No new tests.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowFPSCounter):
(WebCore::InspectorClient::setShowFPSCounter):
(InspectorClient):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowFPSCounter):
(WebCore):
(WebCore::InspectorPageAgent::setShowFPSCounter):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showFPSCounterChanged):
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit):
(WebKit::InspectorClientImpl::setShowFPSCounter):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::loadFontAtlasIfNecessary):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCollect necessary features for SelectRuleFeatureSet
shinyak@chromium.org [Wed, 14 Nov 2012 05:51:12 +0000 (05:51 +0000)]
Collect necessary features for SelectRuleFeatureSet
https://bugs.webkit.org/show_bug.cgi?id=102160

Reviewed by Dimitri Glazkov.

Source/WebCore:

When pseudo class is changed, we might have to invalidate distribution. To determine whether we should invalidate
distribution, we would like to collect RuleFeature from select attributes.

According to ShadowDOM spec, we have to collect the following pseudo classes: checked, enabled, disabled,
indeterminate, link, target, and visited. We collect them in this patch.

Test: fast/dom/shadow/shadow-select-attribute-featureset.html

* html/shadow/SelectRuleFeatureSet.cpp:
(WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet): Uses int as bitset so that we can use bit operator.
(WebCore::SelectRuleFeatureSet::add):
(WebCore::SelectRuleFeatureSet::clear):
(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector): Collects necessary features from CSSSelector.
* html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorForChecked):
(WebCore::SelectRuleFeatureSet::hasSelectorForEnabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForDisabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForIndeterminate):
(WebCore::SelectRuleFeatureSet::hasSelectorForLink):
(WebCore::SelectRuleFeatureSet::hasSelectorForTarget):
(WebCore::SelectRuleFeatureSet::hasSelectorForVisited):
(SelectRuleFeatureSet):
(WebCore::SelectRuleFeatureSet::setSelectRuleFeature):
(WebCore::SelectRuleFeatureSet::hasSelectorFor):
* testing/Internals.cpp:
(WebCore::Internals::hasSelectorForPseudoClassInShadow):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/shadow-select-attribute-featureset-expected.txt:
* fast/dom/shadow/shadow-select-attribute-featureset.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
gyuyoung.kim@samsung.com [Wed, 14 Nov 2012 05:45:43 +0000 (05:45 +0000)]
[EFL][WK2] Add a button parameter to mouseClick, mouseDown, mouseUp functions
https://bugs.webkit.org/show_bug.cgi?id=102065

Reviewed by Laszlo Gombos.

mouseClick(), mouseDown() and mouseUp() test functions are only able to test a left button of mouse now.
However, EFL API test framwork needs to test various mouse buttons. For example, context menu test needs
to simulate a right mouse button. So, button type parameter needs to be added for it.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseClick):
(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove inline style logic from ElementAttributeData to StyledElement.
kling@webkit.org [Wed, 14 Nov 2012 05:39:17 +0000 (05:39 +0000)]
Move inline style logic from ElementAttributeData to StyledElement.
<http://webkit.org/b/102120>

Reviewed by Antti Koivisto.

Source/WebCore:

Move all the logic dealing with element inline style from ElementAttributeData to StyledElement.
No difference in behavior, just making ElementAttributeData dumber.

* css/StylePropertySet.cpp:
* css/StylePropertySet.h:
(WebCore::StylePropertySet::hasCSSOMWrapper):
(WebCore::StylePropertySet::cssStyleDeclaration):

    Added as complements to ensureCSSStyleDeclaration() for the case where we don't want
    to instantiate a CSSOM wrapper unnecessarily.

* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyle):
* dom/ElementAttributeData.cpp:
(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::inlineStyle):
(ElementAttributeData):

    Renamed m_inlineStyleDecl to m_inlineStyle. Finally.

* dom/StyledElement.cpp:
(WebCore::StyledElement::~StyledElement):

    Detach the CSSOM wrapper from the inline style if there is one.

(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::style):

    Renamed ensureInlineStyle() to ensureMutableInlineStyle() since that's what it
    actually does. Update call sites accordingly.

(WebCore::StyledElement::inlineStyleCSSOMWrapper):

    Added helper to get the CSSOM wrapper for the element's inline style if there is one.

(WebCore::StyledElement::styleAttributeChanged):

    Do the work to parse/update/replace the inline style attribute here instead of
    in an ElementAttributeData method.

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::removeAllInlineStyleProperties):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
* html/canvas/CanvasStyle.cpp:
(WebCore::currentColor):

    s/ensureInlineStyle/ensureMutableInlineStyle/

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::styleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/forms/file/input-file-write-files.html should cover correct setting value
commit-queue@webkit.org [Wed, 14 Nov 2012 05:35:11 +0000 (05:35 +0000)]
fast/forms/file/input-file-write-files.html should cover correct setting value
https://bugs.webkit.org/show_bug.cgi?id=100085

Patch by Li Yin <li.yin@intel.com> on 2012-11-13
Reviewed by Kentaro Hara.

Fix the GObject and Objective C bindings comparibility issue. Preserving existing
behavior for those may be important in idl.

No new tests, because fast/forms/file/input-file-value.html has covered it.

* html/HTMLInputElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix build warning in NetworkStateNotifierEfl.cpp
commit-queue@webkit.org [Wed, 14 Nov 2012 05:23:44 +0000 (05:23 +0000)]
[EFL] Fix build warning in NetworkStateNotifierEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=102061

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-13
Reviewed by Gyuyoung Kim.

The second argument for NLMSG_OK needs to be unsigned to avoid the -Wsign-compare warning.

* platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::readSocketCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't mark scrolling contents as dirty if RenderLayerBacking is going away
commit-queue@webkit.org [Wed, 14 Nov 2012 05:19:15 +0000 (05:19 +0000)]
Don't mark scrolling contents as dirty if RenderLayerBacking is going away
https://bugs.webkit.org/show_bug.cgi?id=101947

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-13
Reviewed by Simon Fraser.

When a scrolling contents graphics layer is created or destroyed, the
associated graphics layer is marked as needing display because some of
the painted content may have migrated between the primary graphics layer
and the scrolling layer.

This causes a problem when the RenderLayerBacking is being destroyed,
because setNeedsDisplay() needs to check from the compositor whether to
track repaints or not. If the RenderLayerBacking is being destroyed, the
value returned by compositor() is garbage and this causes a crash.

This patch fixes the problem by making RenderLayer::compositor() return a null
pointer when the renderer no longer has a view.

Covered by existing layout tests in compositing/overflow/.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::compositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined test results.
haraken@chromium.org [Wed, 14 Nov 2012 05:12:22 +0000 (05:12 +0000)]
Unreviewed. Rebaselined test results.

* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/checkerboard-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/checkerboard-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] New window size should consult the window attributes
commit-queue@webkit.org [Wed, 14 Nov 2012 05:05:42 +0000 (05:05 +0000)]
[EFL][WK2] New window size should consult the window attributes
https://bugs.webkit.org/show_bug.cgi?id=102122

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Pass the size that was specified in window.open to the embedder.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::createNewPage):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::createNewPage):

Tools:

Take into account the size that was specified in window.open
when creating a new window. This avoids ugly flashing on the screen.

* MiniBrowser/efl/main.c:
(on_key_down):
(on_new_window):
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: non-trivial test conversion batch 2
dgrogan@chromium.org [Wed, 14 Nov 2012 05:03:50 +0000 (05:03 +0000)]
IndexedDB: non-trivial test conversion batch 2
https://bugs.webkit.org/show_bug.cgi?id=101998

Reviewed by Tony Chang.

* storage/indexeddb/cursor-overloads-expected.txt:
* storage/indexeddb/cursor-overloads.html:
  Trivial conversion that I missed last time around.

* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-close-expected.txt:
* storage/indexeddb/database-closepending-flag-expected.txt:
* storage/indexeddb/delete-closed-database-object-expected.txt:
* storage/indexeddb/resources/database-basics.js:
  Removed test that shows calling setVersion inside a version change
  transaction is an error. Replaced with test showing same error for a
  generic transaction.

* storage/indexeddb/resources/database-close.js:
  Formerly used both unblocked setVersion and deleteDatabase to signal
  that a connection was closed, now just used deleteDatabase.

* storage/indexeddb/resources/database-closepending-flag.js:
  Straightforward, it just has multiple opens.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well...
danakj@chromium.org [Wed, 14 Nov 2012 05:01:04 +0000 (05:01 +0000)]
[chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well, in preparation for removing the settings from WebCompositorSupport
https://bugs.webkit.org/show_bug.cgi?id=102146

Reviewed by James Robinson.

Source/Platform:

Add accelerated animation and per-tile painting to the
WebLayerTreeView structure.

* chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

Add accelerated animation and per-tile painting to the WebSettings structure.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
(WebKit::WebSettingsImpl::perTilePaintingEnabled):
(WebKit::WebSettingsImpl::acceleratedAnimationEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

Tools:

Pass settings that go through WebCompositorSupport also through
WebLayerTreeSettings. When the compositor starts using those instead,
we can remove the callers to the WebCompositorSupport setters.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
noam.rosenthal@nokia.com [Wed, 14 Nov 2012 04:47:01 +0000 (04:47 +0000)]
Coordinated Graphics: Rename m_CoordinatedGraphicsLayerClient to m_coordinator
https://bugs.webkit.org/show_bug.cgi?id=102133

Renamed m_CoordinatedGraphicsLayerClient to m_coordinator.
Also, there is no need for calling setCoordinator every time the tree changes,
since we can call it once when the layer is created, now that LayerTreeCoordinator
is the GraphicsLayerFactory.

Reviewed by Kenneth Rohde Christiansen.

No change in functionality.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::ensureImageBackingStore):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
(WebCore::CoordinatedGraphicsLayer::setCoordinator):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: InvalidCharacterError
arv@chromium.org [Wed, 14 Nov 2012 04:42:46 +0000 (04:42 +0000)]
Update DOMException name: InvalidCharacterError
https://bugs.webkit.org/show_bug.cgi?id=102128

Reviewed by Darin Adler.

Source/WebCore:

Patch 5 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/Document/createElement-invalid-names-expected.txt:
* fast/dom/Document/createElement-invalid-names.html:
* fast/dom/Element/prefix-setter-exception-expected.txt:
* fast/dom/Window/atob-btoa-expected.txt:
* fast/dom/dataset-expected.txt:
* fast/dom/dataset-xhtml-expected.txt:
* fast/dom/script-tests/dataset-xhtml.js:
* fast/dom/script-tests/dataset.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Run multiple tasks per transaction tick
jsbell@chromium.org [Wed, 14 Nov 2012 04:33:39 +0000 (04:33 +0000)]
IndexedDB: Run multiple tasks per transaction tick
https://bugs.webkit.org/show_bug.cgi?id=97738

Reviewed by Tony Chang.

Process multiple tasks from the pending queue(s) when the timer fires. The
task may initiate new tasks that change which queue is active (e.g. indexing
operations) so the loop must re-check each tick which queue to use.

In DumpRenderTree, time to make 20k puts/20k gets dropped from 3.2s to 2.0s (-37%);
in Chromium's content_shell, the time dropped from 8.1s to 4.6s (-42%).

No new tests - just perf improvements, covered by (nearly) all existing IDB tests.

* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort): Use takeFirst() to clean up code.
(WebCore::IDBTransactionBackendImpl::taskTimerFired): Process as many tasks as are available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable frame loading instead of throwing exceptions on subtree modifications in...
commit-queue@webkit.org [Wed, 14 Nov 2012 04:25:11 +0000 (04:25 +0000)]
Disable frame loading instead of throwing exceptions on subtree modifications in ChildFrameDisconnector
https://bugs.webkit.org/show_bug.cgi?id=102012

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-13
Reviewed by Ojan Vafai.

Source/WebCore:

Previously if you modified the subtree that was being removed from a
removeChild from inside an unload handler on an <iframe> inside the
subtree you'd get an exception which is wrong. Instead we just need to
disable all frame loading there.

This works because either the subtree will be removed and the frame never
loading doesn't matter, or some section of the subtree that contains the
frame will be moved to another part of the document which will cause the
frame to load when it's inserted there.

I also added a check for <object> elements. It doesn't seem this is actually
reachable in the existing code, but I'm not entirely sure since the frame
loading and object/plugin handling is very confusing.

A better fix could be to repeatedly walk the subtree until all frames
were disconnected or some iteration limit was hit and then force all leftover
subframes to disconnect without firing unload handlers but this is such an
edge case I don't think the complexity is necessary.

Test: fast/frames/modifications-in-subtree-unload.html

* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::disconnect):
* dom/Node.cpp:
(WebCore::checkAcceptChild): Removed exception.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check canLoadFrame().
* html/HTMLFrameOwnerElement.h:
(SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::~SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::canLoadFrame):
  Returns true if frames can be loaded in the subtree.
(WebCore::SubframeLoadingDisabler::disabledSubtreeRoots):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
  Check canLoadFrame(). I think this case is impossible, but it's better
  to be safe than sorry later.

LayoutTests:

Remove console log output from the exception we no longer throw. Since we no
longer throw an exception we don't need a platform specific output file either.

Also add a test that we don't throw an exception during modifications to subtrees
during unload.

* fast/frames/modifications-in-subtree-unload-expected.html: Added.
* fast/frames/modifications-in-subtree-unload.html: Added.
* fast/frames/out-of-document-iframe-has-child-frame-expected.txt:
* platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add missing ENABLE(SVG) test in header
jsbell@chromium.org [Wed, 14 Nov 2012 04:22:39 +0000 (04:22 +0000)]
[V8] Add missing ENABLE(SVG) test in header
https://bugs.webkit.org/show_bug.cgi?id=102143

Reviewed by Kentaro Hara.

Need to wrap the #include of a header that's only conditionally generated.

Fixes build error if compiling e.g. w/ GYP_DEFINES="enable_svg=0"

* bindings/v8/custom/V8ElementCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAutomatically run small plugins
jonlee@apple.com [Wed, 14 Nov 2012 04:21:41 +0000 (04:21 +0000)]
Automatically run small plugins
https://bugs.webkit.org/show_bug.cgi?id=102148
<rdar://problem/12695560>

Reviewed by Darin Adler.

* rendering/RenderEmbeddedObject.h: Promote layout() to protected.
* rendering/RenderSnapshottedPlugIn.cpp: Add constants for threshold size for plugins that will auto-start.
(WebCore::RenderSnapshottedPlugIn::layout): After layout, obtain the width and height of the element.
If either dimension is 0, or the overall size of the plugin is smaller that the threshold size, move the
display state to Playing. Assuming we will always layout before first paint, changing the state here
should be safe.
* rendering/RenderSnapshottedPlugIn.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNotify embedder of lost contexts and allow overriding of WebGL support
kbr@google.com [Wed, 14 Nov 2012 04:13:22 +0000 (04:13 +0000)]
Notify embedder of lost contexts and allow overriding of WebGL support
https://bugs.webkit.org/show_bug.cgi?id=101826

Reviewed by Adam Barth.

Source/WebCore:

Add hooks notifying the embedder when OpenGL contexts are lost and
allowing overriding of WebGL support on a per-frame basis.

No tests yet; don't know how to test this solely within WebKit.
Currently developing tests in the Chromium port exercising the
notifications end-to-end. Once those are in place, I'm prepared to
investigate adding tests for all ports.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
  Check whether embedder vetoes creation of new WebGL contexts.
(WebCore::WebGLRenderingContext::loseContextImpl):
  Notify embedder that context was lost.
(WebCore::WebGLRenderingContext::maybeRestoreContext):
  Check whether embedder vetoes restoration of existing WebGL contexts.
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::allowWebGL):
(WebCore::FrameLoaderClient::didLoseWebGLContext):
  Hooks notifying embedder of lost contexts and asking permission to run WebGL.

Source/WebKit/chromium:

Expose new FrameLoaderClient hooks through Chromium's
WebPermissionClient and WebFrameClient. Downstream browser tests
will exercise this new functionality.

* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didLoseWebGLContext):
* public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowWebGL):
* src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::allowWebGL):
(WebKit::FrameLoaderClientImpl::didLoseWebGLContext):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Refactor theme font lookup into a factory
commit-queue@webkit.org [Wed, 14 Nov 2012 04:06:07 +0000 (04:06 +0000)]
[Chromium] Refactor theme font lookup into a factory
https://bugs.webkit.org/show_bug.cgi?id=101949

Patch by Scott Violet <sky@chromium.org> on 2012-11-13
Reviewed by Tony Chang.

This will ultimately allow us to use what is currently in RenderThemeChromiumLinux on windows.

No new tests. Refactoring only.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* rendering/RenderThemeChromiumFontProvider.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::defaultGUIFont): Moved into RenderThemeFontProvider.
* rendering/RenderThemeChromiumFontProvider.h: Added.
(WTF):
(WebCore):
(RenderThemeChromiumFontProvider): This is the font related methods.
* rendering/RenderThemeChromiumFontProviderLinux.cpp: Added.
(WebCore):
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): What was in RenderThemeChromiumSkia::setDefaultFontSize.
(WebCore::RenderThemeChromiumFontProvider::systemFont): What was in RenderThemeChromiumSkia::systemFont.
* rendering/RenderThemeChromiumFontProviderWin.cpp: Added.
(WebCore):
(WebCore::pointsToPixels): Moved from RenderThemeChromiumWin.
(WebCore::getNonClientMetrics): Moved from RenderThemeChromiumWin.
(WebCore::systemFontSize): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::systemFont): Moved from RenderThemeChromiumWin.
(WebCore::RenderThemeChromiumFontProvider::setDefaultFontSize): Moved from RenderThemeChromiumWin.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): Moved into RenderThemeFontProvider.
(WebCore::RenderThemeChromiumSkia::systemFont): Calls to RenderThemeChromiumFontProvider.
(WebCore::RenderThemeChromiumSkia::setDefaultFontSize): Calls to RenderThemeChromiumFontProvider.
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia): Moves defaultFontSize into RenderThemeChromiumFontProvider.
* rendering/RenderThemeChromiumWin.cpp: Moves font code into RenderThemeFontProviderWin.
(WebCore):
* rendering/RenderThemeChromiumWin.h: Removed overriden methods now handled by RenderThemeChromiumSkia.
(RenderThemeChromiumWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd DOMRequestState to maintain world/ScriptExecutionContext state
alecflett@chromium.org [Wed, 14 Nov 2012 03:41:51 +0000 (03:41 +0000)]
Add DOMRequestState to maintain world/ScriptExecutionContext state
https://bugs.webkit.org/show_bug.cgi?id=102102

Reviewed by Adam Barth.

Introduce DOMRequestState, and convert IndexedDB over.

No new tests, this is an abstraction layer for existing code.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* WebCore.gypi:
* bindings/v8/DOMRequestState.h: Added.
(WebCore):
(DOMRequestState):
(WebCore::DOMRequestState::DOMRequestState):
(Scope):
(WebCore::DOMRequestState::Scope::Scope):
(WebCore::DOMRequestState::scope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r134328) - ASSERT(isMainThread()) when subresources redirect in the Networ...
beidson@apple.com [Wed, 14 Nov 2012 03:38:18 +0000 (03:38 +0000)]
REGRESSION(r134328) - ASSERT(isMainThread()) when subresources redirect in the NetworkProcessPass through
https://bugs.webkit.org/show_bug.cgi?id=102167

Reviewed by Simon Fraser.

willSendRequest comes in on a background thread but we need to do HostRecord accounting on the main thread.

So we'll just dispatch the receivedRedirect call to the main thread RunLoop.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert r134474; turns out these tests were failing.
dpranke@chromium.org [Wed, 14 Nov 2012 03:19:58 +0000 (03:19 +0000)]
Revert r134474; turns out these tests were failing.

I need to figure out what's going on here ...

* platform/chromium-linux/fast/text/zero-font-size-2-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSever Chromium's dependence on WebKitSystemInterface media control drawing functions...
commit-queue@webkit.org [Wed, 14 Nov 2012 03:15:58 +0000 (03:15 +0000)]
Sever Chromium's dependence on WebKitSystemInterface media control drawing functions in RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=101634

Patch by Robert Sesek <rsesek@chromium.org> on 2012-11-13
Reviewed by Adam Barth.

This splits out the common methods between RenderThemeMac and RenderThemeChromiumMac
into RenderThemeMacShared.

No new tests, just refactoring.

* WebCore.gyp/WebCore.gyp: Remove RenderThemeMac.mm from platform/ sources list, since it's part of rendering/
* WebCore.gypi: Add RenderThemeMacShared.{h,mm}
* WebCore.xcodeproj/project.pbxproj: Add RenderThemeMacShared.{h,mm}
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft):
(WebCore::RenderThemeChromiumMac::popupInternalPaddingRight):
(WebCore::RenderThemeChromiumMac::extraDefaultStyleSheet):
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeMac::create):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
(WebCore::RenderThemeMac::documentViewFor):
(WebCore::mediaControllerTheme):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):
(WebCore::RenderThemeMac::extraMediaControlsStyleSheet):
(WebCore::RenderThemeMac::extraFullScreenStyleSheet):
* rendering/RenderThemeMacShared.h: Copied from Source/WebCore/rendering/RenderThemeMac.h.
(WebCore):
(RenderThemeMacShared):
(WebCore::RenderThemeMacShared::supportsControlTints):
(WebCore::RenderThemeMacShared::scrollbarControlSizeForPart):
(WebCore::RenderThemeMacShared::supportsSelectionForegroundColors):
(WebCore::RenderThemeMacShared::supportsClosedCaptioning):
(WebCore::RenderThemeMacShared::updateActiveState):
* rendering/RenderThemeMacShared.mm: Copied from Source/WebCore/rendering/RenderThemeMac.mm.
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(WebCore):
(WebCore::RenderThemeMacShared::RenderThemeMacShared):
(WebCore::RenderThemeMacShared::~RenderThemeMacShared):
(WebCore::RenderThemeMacShared::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeMacShared::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeMacShared::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeMacShared::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMacShared::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMacShared::platformFocusRingColor):
(WebCore::RenderThemeMacShared::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::toFontWeight):
(WebCore::RenderThemeMacShared::systemFont):
(WebCore::convertNSColorToColor):
(WebCore::menuBackgroundColor):
(WebCore::RenderThemeMacShared::platformColorsDidChange):
(WebCore::RenderThemeMacShared::systemColor):
(WebCore::RenderThemeMacShared::usesTestModeFocusRingColor):
(WebCore::RenderThemeMacShared::isControlStyled):
(WebCore::RenderThemeMacShared::adjustRepaintRect):
(WebCore::RenderThemeMacShared::inflateRect):
(WebCore::RenderThemeMacShared::convertToPaintingRect):
(WebCore::RenderThemeMacShared::updateCheckedState):
(WebCore::RenderThemeMacShared::updateEnabledState):
(WebCore::RenderThemeMacShared::updateFocusedState):
(WebCore::RenderThemeMacShared::updatePressedState):
(WebCore::RenderThemeMacShared::controlSupportsTints):
(WebCore::RenderThemeMacShared::controlSizeForFont):
(WebCore::RenderThemeMacShared::setControlSize):
(WebCore::RenderThemeMacShared::sizeForFont):
(WebCore::RenderThemeMacShared::sizeForSystemFont):
(WebCore::RenderThemeMacShared::setSizeFromFont):
(WebCore::RenderThemeMacShared::setFontFromControlSize):
(WebCore::RenderThemeMacShared::controlSizeForSystemFont):
(WebCore::RenderThemeMacShared::paintTextField):
(WebCore::RenderThemeMacShared::adjustTextFieldStyle):
(WebCore::RenderThemeMacShared::paintCapsLockIndicator):
(WebCore::RenderThemeMacShared::paintTextArea):
(WebCore::RenderThemeMacShared::adjustTextAreaStyle):
(WebCore::RenderThemeMacShared::popupButtonMargins):
(WebCore::RenderThemeMacShared::popupButtonSizes):
(WebCore::RenderThemeMacShared::popupButtonPadding):
(WebCore::RenderThemeMacShared::paintMenuList):
(WebCore::RenderThemeMacShared::meterSizeForBounds):
(WebCore::RenderThemeMacShared::paintMeter):
(WebCore::RenderThemeMacShared::supportsMeter):
(WebCore::RenderThemeMacShared::levelIndicatorStyleFor):
(WebCore::RenderThemeMacShared::levelIndicatorFor):
(WebCore::RenderThemeMacShared::progressBarSizes):
(WebCore::RenderThemeMacShared::progressBarMargins):
(WebCore::RenderThemeMacShared::minimumProgressBarHeight):
(WebCore::RenderThemeMacShared::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMacShared::animationDurationForProgressBar):
(WebCore::RenderThemeMacShared::adjustProgressBarStyle):
(WebCore::RenderThemeMacShared::paintProgressBar):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMacShared::paintMenuListButtonGradients):
(WebCore::RenderThemeMacShared::paintMenuListButton):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMacShared::adjustMenuListStyle):
(WebCore::RenderThemeMacShared::popupInternalPaddingLeft):
(WebCore::RenderThemeMacShared::popupInternalPaddingRight):
(WebCore::RenderThemeMacShared::popupInternalPaddingTop):
(WebCore::RenderThemeMacShared::popupInternalPaddingBottom):
(WebCore::RenderThemeMacShared::adjustMenuListButtonStyle):
(WebCore::RenderThemeMacShared::setPopupButtonCellState):
(WebCore::RenderThemeMacShared::menuListSizes):
(WebCore::RenderThemeMacShared::minimumMenuListSize):
(WebCore::RenderThemeMacShared::adjustSliderTrackStyle):
(WebCore::RenderThemeMacShared::paintSliderTrack):
(WebCore::RenderThemeMacShared::adjustSliderThumbStyle):
(WebCore::RenderThemeMacShared::paintSliderThumb):
(WebCore::RenderThemeMacShared::paintSearchField):
(WebCore::RenderThemeMacShared::setSearchCellState):
(WebCore::RenderThemeMacShared::searchFieldSizes):
(WebCore::RenderThemeMacShared::setSearchFieldSize):
(WebCore::RenderThemeMacShared::adjustSearchFieldStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
(WebCore::RenderThemeMacShared::cancelButtonSizes):
(WebCore::RenderThemeMacShared::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMacShared::resultsButtonSizes):
(WebCore::RenderThemeMacShared::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldDecoration):
(WebCore::RenderThemeMacShared::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMacShared::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldResultsButton):
(WebCore::RenderThemeMacShared::sliderTickSize):
(WebCore::RenderThemeMacShared::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeMacShared::adjustSliderThumbSize):
(WebCore::RenderThemeMacShared::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeMacShared::popupButton):
(WebCore::RenderThemeMacShared::search):
(WebCore::RenderThemeMacShared::searchMenuTemplate):
(WebCore::RenderThemeMacShared::sliderThumbHorizontal):
(WebCore::RenderThemeMacShared::sliderThumbVertical):
(WebCore::RenderThemeMacShared::textField):
(WebCore::RenderThemeMacShared::fileListNameForWidth):
(WebCore::RenderThemeMacShared::paintPlugInSnapshotOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate chromium-mac-lion baselines after r134516. Unreviewed.
dpranke@chromium.org [Wed, 14 Nov 2012 03:15:28 +0000 (03:15 +0000)]
Update chromium-mac-lion baselines after r134516. Unreviewed.

* platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
* platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS @charset parsing is too loose, doesn't match other browsers
commit-queue@webkit.org [Wed, 14 Nov 2012 02:55:17 +0000 (02:55 +0000)]
CSS @charset parsing is too loose, doesn't match other browsers
https://bugs.webkit.org/show_bug.cgi?id=101527

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-11-13
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Per <https://www.w3.org/Bugs/Public/show_bug.cgi?id=19882#attach_1244>,
IE and FF have changed to be strict about @charset parsing,
as the CSS 2.1 spec requires.
Since @charset use is very uncommon anyway,
we should match the new behavior and the spec for platform consistency.

Test: fast/encoding/css-charset-evil/css-charset-evil.html

* loader/TextResourceDecoder.cpp:
(WebCore::bytesEqual):
(WebCore::TextResourceDecoder::checkForCSSCharset):

LayoutTests:

Removed the old css-charset-evil.html test,
which tested for our loose parsing of @charset.
Now that we're tightening our parsing to match the spec and IE's and FF's new behavior,
I added a more comprehensive test of incorrect @charset rules,
to ensure that we correctly reject them.

* fast/encoding/css-charset-evil-expected.txt: Removed.
* fast/encoding/css-charset-evil.css: Removed.
* fast/encoding/css-charset-evil.html: Removed.
* fast/encoding/css-charset-evil/css-charset-evil-a1.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-a2.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-a3.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-a4.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b1.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b2.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b3.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b4.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b5.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b6.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b7.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-b8.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-c1.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-c2.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-c3.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-d1.css: Added.
* fast/encoding/css-charset-evil/css-charset-evil-expected.txt: Added.
* fast/encoding/css-charset-evil/css-charset-evil.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add new baselines after r134435
commit-queue@webkit.org [Wed, 14 Nov 2012 02:53:24 +0000 (02:53 +0000)]
[EFL] Add new baselines after r134435
https://bugs.webkit.org/show_bug.cgi?id=102125

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-13

* platform/efl-wk1/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
* platform/efl-wk1/fast/dom/DOMException/prototype-object-expected.txt: Added.
* platform/efl-wk1/fast/dom/DOMException/stack-trace-expected.txt: Added.
* platform/efl-wk2/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
* platform/efl-wk2/fast/dom/DOMException/prototype-object-expected.txt: Added.
* platform/efl-wk2/fast/dom/DOMException/stack-trace-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore chromium-mac-mountainlion rebaselining and bug triaging.
dpranke@chromium.org [Wed, 14 Nov 2012 02:45:56 +0000 (02:45 +0000)]
More chromium-mac-mountainlion rebaselining and bug triaging.
https://bugs.webkit.org/show_bug.cgi?id=99749

Unreviewed.

* platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/chromium-mac-lion/compositing/direct-image-compositing-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/direct-image-compositing-expected.png.
* platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png: Copied from LayoutTests/platform/chromium-mac/compositing/geometry/clipping-foreground-expected.png.
* platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/dynamic/text-combine-expected.png.
* platform/chromium-mac-lion/fast/dynamic/text-combine-expected.txt: Added.
* platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png.
* platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt.
* platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/emphasis-combined-text-expected.png.
* platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.txt: Added.
* platform/chromium-mac-lion/fast/text/emphasis-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/emphasis-expected.png.
* platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png.
* platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt.
* platform/chromium-mac-lion/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png.
* platform/chromium-mac-lion/fast/writing-mode/border-vertical-lr-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/border-vertical-lr-expected.png.
* platform/chromium-mac-lion/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-mac-lion/fast/writing-mode/box-shadow-horizontal-bt-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/box-shadow-horizontal-bt-expected.png.
* platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-lr-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png.
* platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-rl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png.
* platform/chromium-mac-lion/fast/writing-mode/broken-ideographic-font-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png.
* platform/chromium-mac-lion/fast/writing-mode/broken-ideographic-font-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.txt.
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png.
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png.
* platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png.
* platform/chromium-mac-lion/platform/chromium/fast/text/text-stroke-with-border-expected.png: Copied from LayoutTests/platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png.
* platform/chromium-mac-lion/svg/custom/foreign-object-skew-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/foreign-object-skew-expected.png.
* platform/chromium-mac-lion/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png.
* platform/chromium-mac-lion/svg/hixie/perf/007-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/hixie/perf/007-expected.png.
* platform/chromium-mac-lion/tables/mozilla/bugs/bug11026-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png.
* platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac/fast/dynamic/text-combine-expected.png:
* platform/chromium-mac/fast/dynamic/text-combine-expected.txt: Added.
* platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
* platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt:
* platform/chromium-mac/fast/text/emphasis-combined-text-expected.png:
* platform/chromium-mac/fast/text/emphasis-combined-text-expected.txt: Added.
* platform/chromium-mac/fast/text/emphasis-expected.png:
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
* platform/chromium-mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/border-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-mac/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png:
* platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/text/text-stroke-with-border-expected.png:
* platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/chromium-mac/svg/hixie/perf/007-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
* platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebSocket] send() and close() should not throw an exception for an unpaired surrogat...
bashi@chromium.org [Wed, 14 Nov 2012 01:52:35 +0000 (01:52 +0000)]
[WebSocket] send() and close() should not throw an exception for an unpaired surrogate but use the replacement character
https://bugs.webkit.org/show_bug.cgi?id=101569

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Replace unpaired surrogates with replacing character (U+FFFD) when
encoding text messages and close reasons. This change is aimed at
following the changes on the WebSocket API specification.

Test: http/tests/websocket/tests/hybi/close-reason-too-long.html

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::close):
Use String::StrictConversionReplacingUnpairedSurrogatesWithFFFD mode to encode
text message. Remove invalid utf-8 check.
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
Use String::StrictConversionReplacingUnpairedSurrogatesWithFFFD mode to encode
close reason. Remove invalid utf-8 check.

LayoutTests:

- Updated tests which try to send unpaired surrogates.
  These tests should not throw SYNTAX_ERR.
- Add a test that checks whether WebKit throws SYNTAX_ERR when a close
  reason is too long.

* http/tests/websocket/tests/hybi/close-reason-too-long-expected.txt: Added.
* http/tests/websocket/tests/hybi/close-reason-too-long.html: Ditto.
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Updated.
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Ditto.
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Ditto.
* http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse prefix form of increment / decrement operators in WTF String classes when possible
commit-queue@webkit.org [Wed, 14 Nov 2012 01:27:43 +0000 (01:27 +0000)]
Use prefix form of increment / decrement operators in WTF String classes when possible
https://bugs.webkit.org/show_bug.cgi?id=101859

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-13
Reviewed by Benjamin Poulain.

Use prefix form of increment / decrement operators whenever possible in
WTF String classes as this seems to be the convention in WebKit.

* wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::add):
* wtf/text/Base64.cpp:
(WTF::base64Encode):
(WTF::base64DecodeInternal):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::allocateBufferUpConvert):
* wtf/text/StringConcatenate.h:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upconvertCharacters):
(WTF::StringImpl::containsOnlyWhitespace):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::stripMatchedCharacters):
(WTF::StringImpl::removeCharacters):
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::reverseFindInner):
(WTF::reverseFindIgnoringCaseInner):
(WTF::StringImpl::replace):
(WTF::StringImpl::createWithTerminatingNullCharacter):
* wtf/text/StringImpl.h:
(WTF::codePointCompare):
* wtf/text/WTFString.cpp:
(WTF::String::String):
(WTF::toIntegralType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake InspectorFrontendHost.moveWindowBy work in WebKit2 for Mac.
timothy@apple.com [Wed, 14 Nov 2012 01:18:39 +0000 (01:18 +0000)]
Make InspectorFrontendHost.moveWindowBy work in WebKit2 for Mac.

https://bugs.webkit.org/show_bug.cgi?id=102154

Reviewed by Joseph Pecoraro.

* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::getWindowFrame): Added. Call setInspectorWindowFrame.
(WebKit::setWindowFrame): Added. Call inspectorWindowFrame.
(WebKit::WebInspectorProxy::setInspectorWindowFrame): Added.
(WebKit::WebInspectorProxy::inspectorWindowFrame): Added.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create and set the WKPageUIClient
with getWindowFrame and setWindowFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReduce snapshot waiting time
jonlee@apple.com [Wed, 14 Nov 2012 01:10:35 +0000 (01:10 +0000)]
Reduce snapshot waiting time
https://bugs.webkit.org/show_bug.cgi?id=102147
<rdar://problem/12695539>

Reviewed by Brian Weinstein.

* WebProcess/Plugins/PluginView.cpp: Reduce to 1 second. Improves impressions of responsiveness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake HTMLLegendElement.form behave according to specification
commit-queue@webkit.org [Wed, 14 Nov 2012 01:08:46 +0000 (01:08 +0000)]
Make HTMLLegendElement.form behave according to specification
https://bugs.webkit.org/show_bug.cgi?id=101044

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-13
Reviewed by Kent Tamura.

Source/WebCore:

According to the HTML5 specification (http://dev.w3.org/html5/spec/single-page.html#dom-legend-form),
The form IDL attribute's behavior depends on whether the legend element is in a fieldset element or
not. If the legend has a fieldset element as its parent, then the form IDL attribute must return the
same value as the form IDL attribute on that fieldset element. Otherwise, it must return null.

This patch makes WebKit behaves according to specification (and Firefox). Previously, legend.form was
not returning null if the element was not inside a fieldset. Also, legend.form did not necessarily
return the same value as the parent fieldset's form attribute.

Test: fast/forms/legend/legend-form.html

* html/HTMLLegendElement.cpp:
(WebCore):
(WebCore::HTMLLegendElement::virtualForm):
* html/HTMLLegendElement.h:
(HTMLLegendElement):

LayoutTests:

A new fast/forms/legend/legend-form.html test to check that
the legend element's form attribute behaves according to
specification.

* fast/forms/legend/legend-form-expected.txt: Added.
* fast/forms/legend/legend-form.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFactor the code to enter accelerated compositing given a layer out into a separate...
andersca@apple.com [Wed, 14 Nov 2012 01:06:41 +0000 (01:06 +0000)]
Factor the code to enter accelerated compositing given a layer out into a separate method
https://bugs.webkit.org/show_bug.cgi?id=102155

Reviewed by Andreas Kling.

* UIProcess/API/mac/WKView.mm:
(-[WKView _enterAcceleratedCompositingMode:]):
(-[WKView _enterAcceleratedCompositingModeWithRootLayer:]):
* UIProcess/API/mac/WKViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake an assertion in JSEventListener::jsFunction() more useful.
mark.lam@apple.com [Wed, 14 Nov 2012 00:59:44 +0000 (00:59 +0000)]
Make an assertion in JSEventListener::jsFunction() more useful.
https://bugs.webkit.org/show_bug.cgi?id=101985.

Reviewed by Geoffrey Garen.

The assertion was weakened in r134495. This strengthens it again.

No new tests.

* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport list of tracks in caption media controls
dino@apple.com [Wed, 14 Nov 2012 00:36:06 +0000 (00:36 +0000)]
Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669

Reviewed by Eric Carlson.

Attempt four of commit. The first two times caused build failures on Chromium. The third time
crashed the Windows test bot. It's also been rebased since r134488.

Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670

No new tests - this doesn't expose any testable surface.

* css/mediaControls.css: Added default rules that hide the new elements.
* css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.
* html/shadow/MediaControlElements.h:
(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.
* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::MediaControlsApple):
(WebCore::MediaControlsApple::create): New track container and list elements created.
(WebCore::MediaControlsApple::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlsApple::hide):
(WebCore::MediaControlsApple::makeTransparent):
(WebCore::MediaControlsApple::reset):
(WebCore::MediaControlsApple::reportedError):
(WebCore::MediaControlsApple::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):
* html/shadow/MediaControlsApple.h:
(MediaControlsApple):
* html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::initializeControls): Pass in the controls as a parameter.
* html/shadow/MediaControls.h:
(MediaControls):
* platform/Language.cpp:
(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.
* platform/Language.h:
(WebCore):
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart): New enum values into switch.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): New enum values into switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134377.
dglazkov@chromium.org [Wed, 14 Nov 2012 00:33:45 +0000 (00:33 +0000)]
Unreviewed, rolling out r134377.
http://trac.webkit.org/changeset/134377
https://bugs.webkit.org/show_bug.cgi?id=101133

Caused a mysterious Android Clang build failure, needs
investigation before landing again.

Source/WebCore:

* css/html.css:
(input::-webkit-textfield-decoration-container):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attach):

LayoutTests:

* fast/forms/number/number-content-url-crash-expected.txt: Removed.
* fast/forms/number/number-content-url-crash.html: Removed.
* fast/forms/search/search-content-url-crash-expected.txt: Removed.
* fast/forms/search/search-content-url-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134482.
commit-queue@webkit.org [Wed, 14 Nov 2012 00:16:11 +0000 (00:16 +0000)]
Unreviewed, rolling out r134482.
http://trac.webkit.org/changeset/134482
https://bugs.webkit.org/show_bug.cgi?id=102140

The patch causes fast/regions/moved-content-node-crash.html to
crash in Debug mode due to ASSERTION. (Requested by abucur on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

* rendering/InlineFlowBox.cpp:
(SameSizeAsInlineFlowBox):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(InlineFlowBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
* rendering/RootInlineBox.h:
(WebCore):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
(WebCore::RootInlineBox::isFirstAfterPageBreak):
(WebCore::RootInlineBox::setIsFirstAfterPageBreak):
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
(RootInlineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134503.
haraken@chromium.org [Wed, 14 Nov 2012 00:02:51 +0000 (00:02 +0000)]
Unreviewed, rolling out r134503.
http://trac.webkit.org/changeset/134503

Roll out a patch that was landed just to investigate svn
trouble

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Investigating svn trouble. Test commit.
haraken@chromium.org [Wed, 14 Nov 2012 00:01:00 +0000 (00:01 +0000)]
Unreviewed. Investigating svn trouble. Test commit.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines for filtering changes due to chromium r167479
jamesr@google.com [Tue, 13 Nov 2012 23:56:54 +0000 (23:56 +0000)]
Rebaselines for filtering changes due to chromium r167479

* platform/chromium-linux/compositing/checkerboard-expected.png: Added.
* platform/chromium-mac/compositing/checkerboard-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
* platform/chromium-win/compositing/checkerboard-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMissing NodeRenderStyle.h include in WebCore/html/TextFieldInputType.cpp
wangxianzhu@chromium.org [Tue, 13 Nov 2012 23:53:50 +0000 (23:53 +0000)]
Missing NodeRenderStyle.h include in WebCore/html/TextFieldInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=102108

Reviewed by Adam Barth.

No new tests. Fix clang build break.

* html/TextFieldInputType.cpp: Added #include "NodeRenderStyle.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: MathML types need to be semantically identified in AX tree
cfleizach@apple.com [Tue, 13 Nov 2012 23:29:09 +0000 (23:29 +0000)]
AX: MathML types need to be semantically identified in AX tree
https://bugs.webkit.org/show_bug.cgi?id=101263

Reviewed by Beth Dakin.

Source/WebCore:

Semantically identify various MathML elements within the AX tree. This will allow
screen readers to identify math types so that equations can be output more accurately.

Test: platform/mac/accessibility/mathml-elements.html

* accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::isMathElement):
(WebCore::AccessibilityObject::isMathFraction):
(WebCore::AccessibilityObject::isMathFenced):
(WebCore::AccessibilityObject::isMathSubscriptSuperscript):
(WebCore::AccessibilityObject::isMathRow):
(WebCore::AccessibilityObject::isMathUnderOver):
(WebCore::AccessibilityObject::isMathRoot):
(WebCore::AccessibilityObject::isMathSquareRoot):
(WebCore::AccessibilityObject::isMathText):
(WebCore::AccessibilityObject::isMathNumber):
(WebCore::AccessibilityObject::isMathOperator):
(WebCore::AccessibilityObject::isMathFenceOperator):
(WebCore::AccessibilityObject::isMathSeparatorOperator):
(WebCore::AccessibilityObject::isMathIdentifier):
(WebCore::AccessibilityObject::isMathTable):
(WebCore::AccessibilityObject::isMathTableRow):
(WebCore::AccessibilityObject::isMathTableCell):
(WebCore::AccessibilityObject::mathRadicandObject):
(WebCore::AccessibilityObject::mathRootIndexObject):
(WebCore::AccessibilityObject::mathUnderObject):
(WebCore::AccessibilityObject::mathOverObject):
(WebCore::AccessibilityObject::mathNumeratorObject):
(WebCore::AccessibilityObject::mathDenominatorObject):
(WebCore::AccessibilityObject::mathBaseObject):
(WebCore::AccessibilityObject::mathSubscriptObject):
(WebCore::AccessibilityObject::mathSuperscriptObject):
(WebCore::AccessibilityObject::mathFencedOpenString):
(WebCore::AccessibilityObject::mathFencedCloseString):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
    Handle a case where a MathML render element is created with the node of their parent (which could lead to an assert).
(WebCore::AccessibilityRenderObject::textUnderElement):
    Handle the cases for RenderMathMLOperators which use the node of their parent, which confuses the normal textUnderElement() routine.
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
    Handle ignored cases for math elements
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isMathElement):
(WebCore::AccessibilityRenderObject::isMathFraction):
(WebCore::AccessibilityRenderObject::isMathFenced):
(WebCore::AccessibilityRenderObject::isMathSubscriptSuperscript):
(WebCore::AccessibilityRenderObject::isMathRow):
(WebCore::AccessibilityRenderObject::isMathUnderOver):
(WebCore::AccessibilityRenderObject::isMathSquareRoot):
(WebCore::AccessibilityRenderObject::isMathRoot):
(WebCore::AccessibilityRenderObject::isMathOperator):
(WebCore::AccessibilityRenderObject::isMathFenceOperator):
(WebCore::AccessibilityRenderObject::isMathSeparatorOperator):
(WebCore::AccessibilityRenderObject::isMathText):
(WebCore::AccessibilityRenderObject::isMathNumber):
(WebCore::AccessibilityRenderObject::isMathIdentifier):
(WebCore::AccessibilityRenderObject::isMathTable):
(WebCore::AccessibilityRenderObject::isMathTableRow):
(WebCore::AccessibilityRenderObject::isMathTableCell):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
    Make sure anonymouse blocks are ignored within math tree; make sure non-element type objects are ignored (like <mstyle>).
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
(WebCore::AccessibilityRenderObject::mathFencedOpenString):
(WebCore::AccessibilityRenderObject::mathFencedCloseString):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
* rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::isRenderMathMLFenced):
(WebCore::RenderMathMLBlock::isRenderMathMLFraction):
(WebCore::RenderMathMLBlock::isRenderMathMLRoot):
(WebCore::RenderMathMLBlock::isRenderMathMLSquareRoot):
(WebCore::RenderMathMLBlock::isRenderMathMLSubSup):
(WebCore::RenderMathMLBlock::isRenderMathMLUnderOver):
(WebCore::RenderMathMLBlock::setIgnoreInAccessibilityTree):
(WebCore::RenderMathMLBlock::ignoreInAccessibilityTree):
    Add ability to identify anonymous render blocks as items that AX should ignore.
(RenderMathMLBlock):
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
    Identify which kind of math operator is being created on the fly (Fence or Separator)
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
* rendering/mathml/RenderMathMLFenced.h:
(WebCore::RenderMathMLFenced::isRenderMathMLFenced):
(RenderMathMLFenced):
* rendering/mathml/RenderMathMLFraction.h:
(WebCore::RenderMathMLFraction::isRenderMathMLFraction):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
     Mark anonymous render blocks as AX ignored.
* rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::setOperatorType):
(WebCore::RenderMathMLOperator::operatorType):
(RenderMathMLOperator):
* rendering/mathml/RenderMathMLRoot.h:
(WebCore::RenderMathMLRoot::isRenderMathMLRoot):
* rendering/mathml/RenderMathMLSquareRoot.h:
(WebCore::RenderMathMLSquareRoot::isRenderMathMLSquareRoot):
* rendering/mathml/RenderMathMLSubSup.h:
(WebCore::RenderMathMLSubSup::isRenderMathMLSubSup):
* rendering/mathml/RenderMathMLUnderOver.h:
(WebCore::RenderMathMLUnderOver::isRenderMathMLUnderOver):

Source/WebKit/chromium:

* public/WebAccessibilityRole.h:
* src/AssertMatchingEnums.cpp:
    Add new accessibility role.

LayoutTests:

* platform/mac/accessibility/mathml-elements-expected.txt: Added.
* platform/mac/accessibility/mathml-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSEventListener should not access m_jsFunction when its wrapper is gone.
mark.lam@apple.com [Tue, 13 Nov 2012 23:21:38 +0000 (23:21 +0000)]
JSEventListener should not access m_jsFunction when its wrapper is gone.
https://bugs.webkit.org/show_bug.cgi?id=101985.

Reviewed by Geoffrey Garen.

Added a few null checks for m_wrapper before we do anything with m_jsFunction.

No new tests.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::initializeJSFunction):
- Removed a now invalid assertion. m_wrapper is expected to have a
  valid non-zero value when jsFunction is valid. However, in the case
  of JSLazyEventListener (which extends JSEventListener), m_wrapper is
  initially 0 when m_jsFunction has not been realized yet. When
  JSLazyEventListener::initializeJSFunction() realizes m_jsFunction,
  it will set m_wrapper to an appropriate wrapper object.

  For this reason, JSEventListener::jsFunction() cannot do the null
  check on m_wrapper until after the call to initializeJSFunction.

  This, in turns, means that in the case of the non-lazy
  JSEventListener, initializeJSFunction() will also be called, and
  if the GC has collected the m_wrapper but the JSEventListener has
  not been removed yet, it is possible to see a null m_wrapper while
  m_jsFunction contains a non-zero stale value.

  Hence, this assertion of (m_wrapper || !m_jsFunction) in
  JSEventListener::initializeJSFunction() is not always true and
  should be removed.

(WebCore::JSEventListener::visitJSFunction):
(WebCore::JSEventListener::operator==):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix media/video-empty-source.html lint error.
dglazkov@chromium.org [Tue, 13 Nov 2012 23:21:35 +0000 (23:21 +0000)]
[Chromium] Fix media/video-empty-source.html lint error.

* platform/chromium/TestExpectations: Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r134490.
rniwa@webkit.org [Tue, 13 Nov 2012 23:11:03 +0000 (23:11 +0000)]
Build fix after r134490.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix FastMalloc.cpp compile error for MSVC in 64-bit.
bfulgham@webkit.org [Tue, 13 Nov 2012 22:39:32 +0000 (22:39 +0000)]
Fix FastMalloc.cpp compile error for MSVC in 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=88344

Patch by Brent Fulgham  <bfulgham@webkit.org> and Alex Christensen <alex.christensen@flexsim.com> on 2012-11-13
Reviewed by Ryosuke Niwa.

MSVC will not compile array declarations of zero size. The existing
padding math for TCMalloc_Central_FreeListPadded would evaluate
to zero on 64-bit machines, preventing the compile from finishing.

* wtf/FastMalloc.cpp:
(TCMalloc_Central_FreeListPadded_Template): Add new template (and
zero-size specialization) to provide proper behavior under 64-bit
Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] instantiateV8Object should encapulate the tricky creationContext logic
abarth@webkit.org [Tue, 13 Nov 2012 22:38:25 +0000 (22:38 +0000)]
[V8] instantiateV8Object should encapulate the tricky creationContext logic
https://bugs.webkit.org/show_bug.cgi?id=102117

Reviewed by Eric Seidel.

The logic around creationContext is tricky. Rather than putting the
logic in the code generator, we can centralize the logic in
instantiateV8Object.

This patch shouldn't have any behavior change.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
* bindings/v8/V8DOMWrapper.cpp:
(V8WrapperInstantiationScope):
(WebCore::V8WrapperInstantiationScope::V8WrapperInstantiationScope):
(WebCore::V8WrapperInstantiationScope::~V8WrapperInstantiationScope):
(WebCore::V8WrapperInstantiationScope::context):
(WebCore):
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up the inheritance tree under the MediaControls Class.
dino@apple.com [Tue, 13 Nov 2012 22:36:18 +0000 (22:36 +0000)]
Clean up the inheritance tree under the MediaControls Class.
https://bugs.webkit.org/show_bug.cgi?id=88871

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-11-13
Reviewed by Eric Carlson.

Source/WebCore:

This patch removes code duplication between the Chromium and Safari
media controls shadow DOMs.
This is achieved by pulling common functions that are identical (or
almost identical) between the different platforms into the base class.
The derived classes are renamed based on their platform:
- MediaControlRootElement                to MediaControlsApple.
- MediaControlRootElementChromium        to MediaControlsChromium.
- MediaControlRootElementChromiumAndroid to MediaControlsChromiumAndroid.
MediaControls is now no longer an abstract base class, but its "create"
function is only implemented in the port-specific header file, so it's
on purpose incomplete in the MediaControls.cpp file.

No new tests because this is refactoring work only.

* CMakeLists.txt:
  Rename MediaControlRootElement.cpp to MediaControlsApple.cpp .
* GNUmakefile.list.am:
  Rename MediaControlRootElement.[cpp,h] to MediaControlsApple.[cpp,h] .
* Target.pri:
  Rename MediaControlRootElement.cpp to MediaControlsApple.cpp .
* WebCore.gypi:
  Rename MediaControlRootElement[Chromium[Android]].[cpp,h] to MediaControls[Apple,Chromium[Android]].[cpp,h] .
* WebCore.order:
  Rename MediaControlRootElement symbols to MediaControlsApple symbols.
* WebCore.vcproj/WebCore.vcproj:
  Rename MediaControlRootElement.[cpp,h] to MediaControlsApple.[cpp,h] .
* WebCore.xcodeproj/project.pbxproj:
  Rename MediaControlRootElement.[cpp,h] to MediaControlsApple.[cpp,h] .
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::defaultEventHandler):
  Remove dependency on MediaControlRootElement.h (base class MediaControls.h is still there).
  Rename updateTimeDisplay() to updateCurrentTimeDisplay().
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::MediaControls):
  Added initialization for media elements that all platform controls share.
(WebCore):
  Removed include files that are already included in header file.
(WebCore::MediaControls::setMediaController):
  Added controller assignment for media elements that all platform controls share.
(WebCore::MediaControls::reset):
  Added resets for media elements that all platform controls share.
(WebCore::MediaControls::reportedError):
  Added error handling for media elements that all platform controls share.
(WebCore::MediaControls::loadedMetadata):
  Added default action for loadedMetadata event.
(WebCore::MediaControls::show):
(WebCore::MediaControls::hide):
(WebCore::MediaControls::makeOpaque):
(WebCore::MediaControls::makeTransparent):
(WebCore::MediaControls::shouldHideControls):
(WebCore::MediaControls::bufferingProgressed):
(WebCore::MediaControls::playbackStarted):
(WebCore::MediaControls::playbackProgressed):
(WebCore::MediaControls::playbackStopped):
(WebCore::MediaControls::updateCurrentTimeDisplay):
(WebCore::MediaControls::showVolumeSlider):
(WebCore::MediaControls::changedMute):
(WebCore::MediaControls::changedVolume):
(WebCore::MediaControls::changedClosedCaptionsVisibility):
(WebCore::MediaControls::enteredFullscreen):
(WebCore::MediaControls::exitedFullscreen):
(WebCore::MediaControls::defaultEventHandler):
(WebCore::MediaControls::hideFullscreenControlsTimerFired):
(WebCore::MediaControls::startHideFullscreenControlsTimer):
(WebCore::MediaControls::stopHideFullscreenControlsTimer):
(WebCore::MediaControls::shadowPseudoId):
(WebCore::MediaControls::containsRelatedTarget):
(WebCore::MediaControls::createTextTrackDisplay):
(WebCore::MediaControls::showTextTrackDisplay):
(WebCore::MediaControls::hideTextTrackDisplay):
(WebCore::MediaControls::updateTextTrackDisplay):
  Added default actions for all these media controls member functions.
* html/shadow/MediaControls.h:
(WebCore):
  Added include files and forward class declarations that all media controls share.
(MediaControls):
  Make all pure virtual functions that have default implementations just virtual.
(WebCore::MediaControls::updateStatusDisplay):
  Add an empty virtual updateStatusDisplay function which is used by media elements.
* html/shadow/MediaControlsApple.cpp: Renamed from Source/WebCore/html/shadow/MediaControlRootElement.cpp.
  Reduced Apple-specific media control functions by relying on default implementations in the base class.
* html/shadow/MediaControlsApple.h: Renamed from Source/WebCore/html/shadow/MediaControlRootElement.h.
  Reduced Apple-specific media control elements by relying on some elements in the base class.
* html/shadow/MediaControlsChromium.cpp: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp.
  Reduced Chromium-specific media control functions by relying on default implementations in the base class.
* html/shadow/MediaControlsChromium.h: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromium.h.
  Reduced Chromium-specific media control functions by relying on default implementations in the base class.
* html/shadow/MediaControlsChromiumAndroid.cpp: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromiumAndroid.cpp.
  Renamed class name and base class name.
* html/shadow/MediaControlsChromiumAndroid.h: Renamed from Source/WebCore/html/shadow/MediaControlRootElementChromiumAndroid.h.
  Renamed class name and base class name.
* rendering/RenderTheme.h:
(WebCore::RenderTheme::timeWithoutMouseMovementBeforeHidingControls):
  Moved timeWithoutMouseMovementBeforeHidingControls variable from all classes to a theme-specific function.

Source/WebKit/chromium:

This patch removes code duplication between the Chromium and Safari
media controls shadow DOMs.
The derived classes are renamed based on their platform:
- MediaControlRootElement                to MediaControlsApple.
- MediaControlRootElementChromium        to MediaControlsChromium.
- MediaControlRootElementChromiumAndroid to MediaControlsChromiumAndroid.

* public/WebContextMenuData.h:
  Move MediaControlRootElement to MediaControls.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  Move MediaControlRootElement to MediaControls.

LayoutTests:

* platform/chromium-mac-mountainlion/TestExpectations: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoteGraphicsLayer destructor should call GraphicsLayer::willBeDestroyed
andersca@apple.com [Tue, 13 Nov 2012 22:34:24 +0000 (22:34 +0000)]
RemoteGraphicsLayer destructor should call GraphicsLayer::willBeDestroyed
https://bugs.webkit.org/show_bug.cgi?id=102135

Reviewed by Andreas Kling.

Call GraphicsLayer::willBeDestroyed from the RemoteGraphicsLayer destructor and move
the call to RemoteLayerTreeContext::layerWillBeDestroyed to the overridden
willBeDestroyed member function.

* WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
* WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::~RemoteGraphicsLayer):
(WebKit::RemoteGraphicsLayer::willBeDestroyed):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134446.
dglazkov@chromium.org [Tue, 13 Nov 2012 22:32:00 +0000 (22:32 +0000)]
Unreviewed, rolling out r134446.
http://trac.webkit.org/changeset/134446
https://bugs.webkit.org/show_bug.cgi?id=101968

Need to try a different strategy for landing a two-sided patch
(3/3).

Source/Platform:

* chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134458.
dglazkov@chromium.org [Tue, 13 Nov 2012 22:31:22 +0000 (22:31 +0000)]
Unreviewed, rolling out r134458.
http://trac.webkit.org/changeset/134458

Need to try a different strategy for landing a two-sided patch
(2/3).

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134461.
dglazkov@chromium.org [Tue, 13 Nov 2012 22:30:43 +0000 (22:30 +0000)]
Unreviewed, rolling out r134461.
http://trac.webkit.org/changeset/134461

Need to try a different strategy for landing a two-sided patch
(1/3).

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSParser::setStyleSheet() should be inline
benjamin@webkit.org [Tue, 13 Nov 2012 22:19:57 +0000 (22:19 +0000)]
CSSParser::setStyleSheet() should be inline
https://bugs.webkit.org/show_bug.cgi?id=101829

Reviewed by Andreas Kling.

* css/CSSParser.cpp:
* css/CSSParser.h:
(WebCore::CSSParser::setStyleSheet):
CSSParser::setStyleSheet() just assign a pointer, it does not even
change a ref-count. The function should probably be in the header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data
commit-queue@webkit.org [Tue, 13 Nov 2012 22:14:05 +0000 (22:14 +0000)]
[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data
https://bugs.webkit.org/show_bug.cgi?id=101332

Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-13
Reviewed by David Hyatt.

Currently the pagination information for lines is spread between the RootInlineBox and InlineFlowBox classes, consuming memory even though
the boxes were not the result of an pagination layout. To overcome this, a new struct (LineFragmentationData) is created that wraps all the data,
including a new member, the containing Region for the line.
The containing Region is used to detect if a line changed the Region where it resides. This will be helpful especially when implementing region
styling for layout properties (e.g. the font-size property https://bugs.webkit.org/show_bug.cgi?id=95559 ).
A line can change the region when it is shifted inside the containing block or if the entire block moves. This means it's better to delegate
the task of updating the containing Region to the block.

Tests: No new tests because there is no functional change.

* rendering/InlineFlowBox.cpp:
(SameSizeAsInlineFlowBox):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(InlineFlowBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::setContainingRegion):
(WebCore):
* rendering/RootInlineBox.h:
(WebCore):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
(WebCore::RootInlineBox::isFirstAfterPageBreak):
(WebCore::RootInlineBox::setIsFirstAfterPageBreak):
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
(RootInlineBox):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::ensureLineFragmentationData):
(LineFragmentationData):
(WebCore::RootInlineBox::LineFragmentationData::LineFragmentationData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSplit NetworkRequest up into a request class and a loading class.
beidson@apple.com [Tue, 13 Nov 2012 22:05:13 +0000 (22:05 +0000)]
Split NetworkRequest up into a request class and a loading class.
https://bugs.webkit.org/show_bug.cgi?id=102049

Reviewed by Alexey Proskuryakov.

NetworkRequest unintentionally grew into a class that managed actual loading.

This patch splits it into "NetworkResourceLoadParameters" for all request-related data
and "NetworkResourceLoader" for handling the actual load itself.

Change HostRecord to manage NetworkResourceLoaders instead of NetworkRequests:
* NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::~HostRecord):
(WebKit::HostRecord::schedule):
(WebKit::HostRecord::addLoadInProgress):
(WebKit::HostRecord::remove):
(WebKit::HostRecord::hasRequests):
(WebKit::HostRecord::limitRequests):
* NetworkProcess/HostRecord.h:
(WebKit::HostRecord::loadersPending):

A new class to be a container for all the data required to start a network load:
* Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
* Shared/Network/NetworkResourceLoadParameters.h:
(WebKit::NetworkResourceLoadParameters::request):
(WebKit::NetworkResourceLoadParameters::priority):
(WebKit::NetworkResourceLoadParameters::contentSniffingPolicy):

Pass a single NetworkResourceLoadParameters around instead of multiple bits of data:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleResourceLoad):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost):
* NetworkProcess/NetworkResourceLoadScheduler.h:

The actual ResourceHandleClient that does the actual loading:
* NetworkProcess/NetworkResourceLoader.cpp: Renamed from Source/WebKit2/NetworkProcess/NetworkRequest.cpp.
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::priority):
(WebKit::NetworkResourceLoader::start):
(WebKit::requestsToStopMutex):
(WebKit::requestsToStop):
(WebKit::NetworkResourceLoader::scheduleStopOnMainThread):
(WebKit::NetworkResourceLoader::performStops):
(WebKit::NetworkResourceLoader::stop):
(WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::responseMap):
(WebKit::generateWillSendRequestID):
(WebKit::didReceiveWillSendRequestHandled):
(WebKit::NetworkResourceLoader::willSendRequest):
(WebKit::NetworkResourceLoader::didSendData):
(WebKit::NetworkResourceLoader::didReceiveCachedMetadata):
(WebKit::NetworkResourceLoader::wasBlocked):
(WebKit::NetworkResourceLoader::cannotShowURL):
(WebKit::NetworkResourceLoader::willCacheResponse):
(WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):
(WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge):
(WebKit::NetworkResourceLoader::receivedCancellation):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkResourceLoader::supportsDataArray):
(WebKit::NetworkResourceLoader::didReceiveDataArray):
(WebKit::NetworkResourceLoader::willStopBufferingData):
(WebKit::NetworkResourceLoader::createAsyncFileStream):
* NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::create):
(WebKit::NetworkResourceLoader::identifier):
(WebKit::NetworkResourceLoader::connectionToWebProcess):

* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFastMalloc.cpp needs to be reordered before padding bug can be fixed
bfulgham@webkit.org [Tue, 13 Nov 2012 21:50:12 +0000 (21:50 +0000)]
FastMalloc.cpp needs to be reordered before padding bug can be fixed
https://bugs.webkit.org/show_bug.cgi?id=89366

Note: This file violates Style rules.  This change only moves
the TCMalloc_Central_FreeList class declaration and the various
FastMallocZone methods earlier in the file.

Patch by Brent Fulgham <bfulgham@webkit.org> and Alex Christensen <alex.christensen@flexsim.com> on 2012-11-13
Reviewed by Ryosuke Niwa.

* wtf/FastMalloc.cpp:
Reordered definitions to prepare for adding specialized template
(WTF):
(TCMalloc_Central_FreeList):
(WTF::TCMalloc_Central_FreeList::length):
(WTF::TCMalloc_Central_FreeList::tc_length):
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects):
(TCMalloc_Central_FreeListPadded):
(FastMallocZone):
(WTF::FastMallocZone::goodSize):
(WTF::FastMallocZone::check):
(WTF::FastMallocZone::print):
(WTF::FastMallocZone::log):
(WTF::FastMallocZone::forceLock):
(WTF::FastMallocZone::forceUnlock):
(WTF::FastMallocZone::statistics):
(WTF::FastMallocZone::zoneValloc):
(WTF::FastMallocZone::zoneDestroy):
(WTF::KernelSupportsTLS):
(WTF::CheckIfKernelSupportsTLS):
(TCMalloc_ThreadCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStore destroyed layers in the remote layer tree transaction
andersca@apple.com [Tue, 13 Nov 2012 21:46:53 +0000 (21:46 +0000)]
Store destroyed layers in the remote layer tree transaction
https://bugs.webkit.org/show_bug.cgi?id=102127

Reviewed by Andreas Kling.

* Shared/mac/RemoteLayerTreeTransaction.h:
(RemoteLayerTreeTransaction):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::setDestroyedLayerIDs):
(WebKit):
(WebKit::RemoteLayerTreeTransaction::dump):
* WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
* WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::~RemoteGraphicsLayer):
(WebKit::RemoteGraphicsLayer::removeFromParent):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
(RemoteLayerTreeContext):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
(WebKit::RemoteLayerTreeContext::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Marked fast/workers/worker-exception-during-navigation.html as a flaky...
dglazkov@chromium.org [Tue, 13 Nov 2012 21:44:26 +0000 (21:44 +0000)]
[Chromium] Marked fast/workers/worker-exception-during-navigation.html as a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=102131

* platform/chromium/TestExpectations: Added a flaky crash expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QNX build fails due to signature change in gl2.h header (glShaderSource)
commit-queue@webkit.org [Tue, 13 Nov 2012 21:37:25 +0000 (21:37 +0000)]
[Qt] QNX build fails due to signature change in gl2.h header (glShaderSource)
https://bugs.webkit.org/show_bug.cgi?id=98038

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-11-13
Reviewed by Simon Hausmann.

Cast the function to the expected type, just like it is done on non-Qt/OpenGL2 ES platforms.

* platform/graphics/OpenGLShims.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit exposes ARIA rowheader role as AXUnknown when not contained in table/grid
cfleizach@apple.com [Tue, 13 Nov 2012 21:25:18 +0000 (21:25 +0000)]
WebKit exposes ARIA rowheader role as AXUnknown when not contained in table/grid
https://bugs.webkit.org/show_bug.cgi?id=101616

Reviewed by Beth Dakin.

Source/WebCore:

If the rowheader role is exposed because the element is not within a table, the mac platform
should map that to a generic group.

Test: platform/mac/accessibility/rowheader-outside-table-role.html

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):

LayoutTests:

* platform/mac/accessibility/rowheader-outside-table-role-expected.txt: Added.
* platform/mac/accessibility/rowheader-outside-table-role.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove a few old no-longer-failing tests and update one baseline.
dpranke@chromium.org [Tue, 13 Nov 2012 21:23:07 +0000 (21:23 +0000)]
Remove a few old no-longer-failing tests and update one baseline.

Unreviewed, gardening.

* platform/chromium-linux/fast/text/zero-font-size-2-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r130643): Assertion failure when running DRT in debug mode
roger_fong@apple.com [Tue, 13 Nov 2012 21:11:24 +0000 (21:11 +0000)]
REGRESSION(r130643): Assertion failure when running DRT in debug mode
https://bugs.webkit.org/show_bug.cgi?id=101791

Reviewed by Darin Adler.

When running DRT in debug mode, we hit an assertion failure in initializing the WebKit instance.
This failure started occuring in r130643 and this work around follows the work around in r132302.

* WebKitCOMAPI.cpp:
(CLSIDHashTraits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdjust the Web Inspector window title frame if needed to prevent it from intersecting...
timothy@apple.com [Tue, 13 Nov 2012 21:10:37 +0000 (21:10 +0000)]
Adjust the Web Inspector window title frame if needed to prevent it from intersecting the dock button.

https://bugs.webkit.org/show_bug.cgi?id=102073

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindow _customTitleFrame]): Added. Adjust the title frame.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorWindow _customTitleFrame]): Added. Adjust the title frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Tue, 13 Nov 2012 20:39:26 +0000 (20:39 +0000)]
[EFL] Unreviewed gardening.

Skip a few tests, update expectations when some colors varied
slightly from the existing expectation and add a few new ones.

* platform/efl-wk1/TestExpectations:
* platform/efl/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/efl/fast/forms/menulist-no-overflow-expected.png:
* platform/efl/fast/forms/menulist-separator-painting-expected.png:
* platform/efl/fast/forms/select-background-none-expected.png:
* platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.png:
* platform/efl/fast/forms/select-selected-expected.png:
* platform/efl/fast/forms/select-visual-hebrew-expected.png:
* platform/efl/fast/forms/selectlist-minsize-expected.png:
* platform/efl/fast/forms/stuff-on-my-optgroup-expected.png:
* platform/efl/fast/html/keygen-expected.png:
* platform/efl/fast/images/png-suite/test-expected.png:
* platform/efl/fast/replaced/image-sizing-expected.png:
* platform/efl/fast/replaced/three-selects-break-expected.png:
* platform/efl/fast/replaced/width100percent-menulist-expected.png:
* platform/efl/fast/ruby/overhang-horizontal-expected.png: Added.
* platform/efl/fast/runin/runin-generated-before-content-expected.png: Added.
* platform/efl/fast/text/updateNewFont-expected.png:
* platform/efl/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
* platform/efl/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/efl/fast/writing-mode/english-lr-text-expected.png:
* platform/efl/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
* platform/efl/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
* platform/efl/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
* platform/efl/svg/filters/feColorMatrix-offset-expected.png: Added.
* platform/efl/svg/filters/feDropShadow-subregion-expected.png: Added.
* platform/efl/svg/filters/feGaussianBlur-subregion-expected.png: Added.
* platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/efl/svg/filters/feImage-preserveAspectratio-expected.png:
* platform/efl/svg/filters/feImage-subregions-expected.png:
* platform/efl/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
* platform/efl/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
* platform/efl/svg/filters/feLighting-crash-expected.png:
* platform/efl/svg/filters/feOffset-expected.png:
* platform/efl/svg/filters/feTile-expected.png:
* platform/efl/svg/filters/filter-on-tspan-expected.png:
* platform/efl/svg/filters/filter-placement-issue-expected.png:
* platform/efl/svg/filters/filter-rounding-issues-expected.png:
* platform/efl/svg/filters/filter-source-position-expected.png: Added.
* platform/efl/svg/filters/filteredImage-expected.png: Added.
* platform/efl/svg/filters/parent-children-with-same-filter-expected.png:
* platform/efl/svg/filters/shadow-on-filter-expected.png:
* platform/efl/svg/filters/subRegion-one-effect-expected.png:
* platform/efl/svg/filters/subRegion-two-effects-expected.png:
* platform/efl/svg/foreignObject/filter-expected.png: Added.
* platform/efl/svg/text/selection-doubleclick-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix SkImageFilter DAG path to pass all css3/filters tests
senorblanco@chromium.org [Tue, 13 Nov 2012 20:39:21 +0000 (20:39 +0000)]
[Chromium] Fix SkImageFilter DAG path to pass all css3/filters tests
https://bugs.webkit.org/show_bug.cgi?id=101952

Reviewed by James Robinson.

With these changes, all of the css3/filters tests pass when the
if-test in GraphicsLayerChromium::setFilters() is forced true (for
now, it remains true only if there's a reference filter in the chain).

Covered by the css3/filters tests (when the switch is thrown in
GraphicsLayerChromium::setFilters()).

* WebCore.gypi:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
Drop to software rendering if there's a custom filter in the chain.
This is the same as the WebFilterOperations path is doing.
* platform/graphics/filters/skia/DropShadowImageFilter.cpp: Added.
* platform/graphics/filters/skia/DropShadowImageFilter.h: Added.
New implementation of drop-shadow filter; equivalent to
the path in cc/render_surface_filters.cc.
* platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
Fix the sepia and grayscale filters (value was inverted).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134442.
abarth@webkit.org [Tue, 13 Nov 2012 20:36:47 +0000 (20:36 +0000)]
Unreviewed, rolling out r134442.
http://trac.webkit.org/changeset/134442
https://bugs.webkit.org/show_bug.cgi?id=102111

Does not compile on apple-mac (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSImageValue.h:
(WebCore):
(CSSImageValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::load):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::cachedShader):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
* html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::preload):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore):
(WebCore::CachedResourceLoader::preload):
* loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
* loader/cache/CachedResourceRequest.h:
(CachedResourceRequest):
(WebCore::CachedResourceRequest::defer):
(WebCore::CachedResourceRequest::setDefer):
* loader/cache/CachedResourceRequestInitiators.cpp: Removed.
* loader/cache/CachedResourceRequestInitiators.h: Removed.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
* platform/ThreadGlobalData.h:
(ThreadGlobalData):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: file upload input text value is not exposed through accessibility
cfleizach@apple.com [Tue, 13 Nov 2012 20:30:10 +0000 (20:30 +0000)]
AX: file upload input text value is not exposed through accessibility
https://bugs.webkit.org/show_bug.cgi?id=100583

Reviewed by Beth Dakin.

Source/WebCore:

This is a hard problem to solve on the Mac because there are three pieces of information
     1) The type of button 2) The text on the button 3) The text for the value.
I think the best compromise is to label this as a file upload button type in the role description,
and then expose the file path text as the AXTitle.
This will give the more relevant information and should be clear what is happening.

Test: platform/mac/accessibility/file-upload-button-subrole.html

* English.lproj/Localizable.strings:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
* platform/LocalizedStrings.cpp:
(WebCore::AXFileUploadButtonText):
* platform/LocalizedStrings.h:

LayoutTests:

* platform/mac/accessibility/file-upload-button-subrole-expected.txt: Added.
* platform/mac/accessibility/file-upload-button-subrole.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133944.
commit-queue@webkit.org [Tue, 13 Nov 2012 20:17:55 +0000 (20:17 +0000)]
Unreviewed, rolling out r133944.
http://trac.webkit.org/changeset/133944
https://bugs.webkit.org/show_bug.cgi?id=102118

Only JS bindings support NATIVE_TYPE_ERR (Requested by arv on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

Source/WebCore:

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNamedConstructorCallback):
(TypeCanFailConversion):
* dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
* dom/Element.idl:

LayoutTests:

* fast/dom/Element/attr-param-typechecking-expected.txt:
* fast/dom/Element/script-tests/attr-param-typechecking.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
abarth@webkit.org [Tue, 13 Nov 2012 20:11:53 +0000 (20:11 +0000)]
Unreviewed.

Update run-bindings-tests results.

* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::dispatchWrapCustom):
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::toNative):
(V8Float64Array):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::toNative):
(V8TestActiveDOMObject):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::toNative):
(V8TestCustomNamedGetter):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::toNative):
(V8TestEventConstructor):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::toNative):
(V8TestEventTarget):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::toNative):
(V8TestException):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::toNative):
(V8TestInterface):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::toNative):
(V8TestMediaQueryListListener):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::toNative):
(V8TestNamedConstructor):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::V8TestNode::toNative):
(V8TestNode):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
(WebCore::toV8Fast):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::toNative):
(V8TestObj):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::wrapSlow):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::V8TestOverloadedConstructors::toNative):
(V8TestOverloadedConstructors):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::toNative):
(V8TestSerializedScriptValueInterface):
(WebCore):
(WebCore::dispatchWrap):
(WebCore::toV8Object):
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStore layer positions and sizes in the transaction
andersca@apple.com [Tue, 13 Nov 2012 20:11:32 +0000 (20:11 +0000)]
Store layer positions and sizes in the transaction
https://bugs.webkit.org/show_bug.cgi?id=102115

Reviewed by Andreas Kling.

* Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
(WebKit::dumpChangedLayers):
* WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
(RemoteGraphicsLayer):
* WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
(WebKit::RemoteGraphicsLayer::setPosition):
(WebKit::RemoteGraphicsLayer::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations for animation tests.
danakj@chromium.org [Tue, 13 Nov 2012 20:08:04 +0000 (20:08 +0000)]
Unreviewed test expectations for animation tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSFunction and its descendants should be destructible
fpizlo@apple.com [Tue, 13 Nov 2012 19:58:18 +0000 (19:58 +0000)]
JSFunction and its descendants should be destructible
https://bugs.webkit.org/show_bug.cgi?id=102062

Reviewed by Mark Hahnenberg.

This will make it easy to place an InlineWatchpointSet inside JSFunction. In the
future, we could make JSFunction non-destructible again by making a version of
WatchpointSet that is entirely GC'd, but this seems like overkill for now.

This is performance-neutral.

* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::destroy):
(JSC):
* runtime/JSBoundFunction.h:
(JSBoundFunction):
* runtime/JSFunction.cpp:
(JSC):
(JSC::JSFunction::destroy):
* runtime/JSFunction.h:
(JSFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Pacify linter and tweak expectations to avoid conflicts.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:53:22 +0000 (19:53 +0000)]
[Chromium] Pacify linter and tweak expectations to avoid conflicts.

* platform/chromium/TestExpectations: Tweaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
abarth@webkit.org [Tue, 13 Nov 2012 19:42:22 +0000 (19:42 +0000)]
Unreviewed.

Speculative build fix for Qt.

* dom/make_names.pl:
(printWrapperFactoryCppFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow painting outside overflow clip in accelerated scrolling layers
commit-queue@webkit.org [Tue, 13 Nov 2012 19:40:31 +0000 (19:40 +0000)]
Allow painting outside overflow clip in accelerated scrolling layers
https://bugs.webkit.org/show_bug.cgi?id=100524

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-13
Reviewed by Simon Fraser.

Source/WebCore:

In preparation for avoiding repaints when scrolling child layers, make it
possible to paint outside the overflow clip.

Test: compositing/overflow/updating-scrolling-content.html

* rendering/LayoutState.h:
(LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::repaintBlockSelectionGaps):

LayoutTests:

Added a test to check painting outside the overflow clip. Note that this will
not pass unless ENABLE_ACCELERATED_OVERFLOW_SCROLLING is enabled.

* compositing/overflow/updating-scrolling-content-expected.txt: Added.
* compositing/overflow/updating-scrolling-content.html: Added.
* platform/chromium/TestExpectations: Mark test as expected to fail
  by default.
* platform/mac/TestExpectations: Skip the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe layer tree transaction should include the root layer
andersca@apple.com [Tue, 13 Nov 2012 19:33:01 +0000 (19:33 +0000)]
The layer tree transaction should include the root layer
https://bugs.webkit.org/show_bug.cgi?id=102109

Reviewed by Andreas Kling.

Keep the root layer ID in the layer tree transaction and encode/decode and dump it.

* Shared/mac/RemoteLayerTreeTransaction.h:
(RemoteLayerTreeTransaction):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::setRootLayerID):
(WebKit):
(WebKit::RemoteLayerTreeTransaction::dump):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
(RemoteLayerTreeContext):
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::setRootLayer):
(WebKit::RemoteLayerTreeContext::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove the test that is now passing.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:31:19 +0000 (19:31 +0000)]
[Chromium] Remove the test that is now passing.

* platform/chromium/TestExpectations: Removed expectation of failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPort SimpleFontDataWin.cpp to WinCE
paroga@webkit.org [Tue, 13 Nov 2012 19:31:14 +0000 (19:31 +0000)]
Port SimpleFontDataWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=97889

Reviewed by Brent Fulgham.

Add #if !OS(WINCE) around some parts of the code, so it can be used by the WinCE port too in a next step.
Also cleaned up the include headers.

* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore):
(WebCore::SimpleFontData::widthForGDIGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Chromium] move spectrum.css into the standalone css files group.
pfeldman@chromium.org [Tue, 13 Nov 2012 19:29:40 +0000 (19:29 +0000)]
Web Inspector: [Chromium] move spectrum.css into the standalone css files group.

Not reviewed: moved css file in gypi.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134434.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:24:35 +0000 (19:24 +0000)]
Unreviewed, rolling out r134434.
http://trac.webkit.org/changeset/134434
https://bugs.webkit.org/show_bug.cgi?id=102072

The test that was added asserts in loader.

Source/WebCore:

* loader/FrameLoader.cpp:
(WebCore::createWindow):
* page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::adjustWindowRect):
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
(WebCore::DOMWindow::open):
(WebCore::DOMWindow::showModalDialog):
* page/DOMWindow.h:
(DOMWindow):

LayoutTests:

* fast/dom/Window/open-window-min-size-expected.txt: Removed.
* fast/dom/Window/open-window-min-size.html: Removed.
* fast/dom/Window/resources/print-close.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134449.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:21:03 +0000 (19:21 +0000)]
Unreviewed, rolling out r134449.
http://trac.webkit.org/changeset/134449
https://bugs.webkit.org/show_bug.cgi?id=102076

Re-rolling in the patch, it was innocent.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134424.
dglazkov@chromium.org [Tue, 13 Nov 2012 19:10:46 +0000 (19:10 +0000)]
Unreviewed, rolling out r134424.
http://trac.webkit.org/changeset/134424
https://bugs.webkit.org/show_bug.cgi?id=102076

Made fast/dom/Window/open-window-min-size.html crash.

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaselined platform/chromium/virtual/softwarecompositing/layer-creation...
commit-queue@webkit.org [Tue, 13 Nov 2012 19:10:44 +0000 (19:10 +0000)]
[Chromium] Rebaselined platform/chromium/virtual/softwarecompositing/layer-creation/spanOverlapsCanvas.html
https://bugs.webkit.org/show_bug.cgi?id=101997

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-13
Reviewed by James Robinson.

Since we disabled hardware accelerated canvas when in software compositing mode,
this layout test doesn't create any layers which is the correct behaviour.

* platform/chromium/TestExpectations:
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] More efficient wrapper dispatch
abarth@webkit.org [Tue, 13 Nov 2012 19:06:30 +0000 (19:06 +0000)]
[V8] More efficient wrapper dispatch
https://bugs.webkit.org/show_bug.cgi?id=102082

Patch by Dan Carney <dcarney@google.com> on 2012-11-13
Reviewed by Adam Barth.

Source/WebCore:

Dispatching a call to V8Whatever::wrap involved a chain
of calls, each of which checked its wrapper cache.
This refactor gives calls only 2 choices of functions to call:
toV8 and toV8Object instead of wrap. wrap has been renamed to
dispatchWrap and no longer contains cache checks.
Additionally, classes which require a custom toV8 function
have had all wrapping and caching calls removed, as they could
not have been accessed.

No new tests. Sufficiently covered.

* Modules/indexeddb/IDBAny.idl:
* Modules/indexeddb/IDBKey.idl:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GenerateToV8Converters):
* bindings/scripts/IDLAttributes.txt:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::dispatchWrapCustom):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::V8CSSRule::dispatchWrapCustom):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::V8CSSValue::dispatchWrapCustom):
* bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:
(WebCore::V8CanvasRenderingContext::dispatchWrapCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore):
(WebCore::V8DataView::dispatchWrapCustom):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::dispatchWrapCustom):
* bindings/v8/custom/V8ElementCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8PerformanceEntryCustom.cpp.
(WebCore):
(WebCore::V8Element::dispatchWrapCustom):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::V8Entry::dispatchWrapCustom):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::V8EntrySync::dispatchWrapCustom):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore):
(WebCore::V8Event::dispatchWrapCustom):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::dispatchWrapCustom):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::dispatchWrapCustom):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::dispatchWrapCustom):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::V8ImageData::dispatchWrapCustom):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::dispatchWrapCustom):
* bindings/v8/custom/V8PerformanceEntryCustom.cpp:
(WebCore::V8PerformanceEntry::dispatchWrapCustom):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::V8SVGDocument::dispatchWrapCustom):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::V8SVGElement::dispatchWrapCustom):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::V8SVGPathSeg::dispatchWrapCustom):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::V8StyleSheet::dispatchWrapCustom):
* dom/Element.idl:
* dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
* html/MicroDataItemValue.idl:
* inspector/ScriptProfile.idl:
* inspector/ScriptProfileNode.idl:
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

Source/WebKit/chromium:

* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove the WebCompositorSupport methods for changing settings, plumb every...
danakj@chromium.org [Tue, 13 Nov 2012 19:05:59 +0000 (19:05 +0000)]
[chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
https://bugs.webkit.org/show_bug.cgi?id=101968

Reviewed by James Robinson.

Source/Platform:

Move the outlier settings from WebCompositorSupport to WebLayerTreeView.

PerTilePainting and AcceleratedAnimations are simply moved over. The
PartialSwap and PageScalePinchZoomInCompositor settings, however, are
not used by DRT, so we remove them.

This change will temporarily break the --per-tile-painting and
--accelerated-animations command line flags for chromium DRT until
a chromium side patch hooks up the WebLayerTreeSettings again, but
we have no bots running with these flags.

PinchZoom will be unaffected by this, as DRT never turned it on, and by
passing the WebLayerTreeSetting, chromium will not use it from here yet,
either.

PartialSwap will be also unaffected, as there was no place in WebKit
that would enable it currently.

* chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

This adds perTilePainting and acceleratedAniamtions to the WebSettings
classes, so that DRT can turn these on via WebLayerTreeSettings.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
(WebKit::WebSettingsImpl::perTilePaintingEnabled):
(WebKit::WebSettingsImpl::acceleratedAnimationEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix webkitpy issues arising from a partially-installed pylint.
dpranke@chromium.org [Tue, 13 Nov 2012 18:59:54 +0000 (18:59 +0000)]
Fix webkitpy issues arising from a partially-installed pylint.
Unreviewed, build fix.

This patch ensures that we will re-install the pylint and logilab
packages if any of them are missing, not just the pylint package.

* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_pylint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert the changes from r134388 and r134426 as r134345 was rolled out.
rakuco@webkit.org [Tue, 13 Nov 2012 18:58:29 +0000 (18:58 +0000)]
Revert the changes from r134388 and r134426 as r134345 was rolled out.

* platform/efl/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/qt/fast/dynamic/insertAdjacentElement-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134367.
dglazkov@chromium.org [Tue, 13 Nov 2012 18:53:36 +0000 (18:53 +0000)]
Unreviewed, rolling out r134367.
http://trac.webkit.org/changeset/134367
https://bugs.webkit.org/show_bug.cgi?id=100738

Speculative rollout, could have cause Dromaeo setAttribute
perf regression.

PerformanceTests:

* DOM/ModifyAttribute.html: Removed.
* DOM/resources/dom-perf/modify-attribute.js: Removed.

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::checkNeedsStyleInvalidationForClassChange):
(WebCore::Element::classAttributeChanged):

LayoutTests:

* fast/dom/shadow/distribution-attribute-modified-expected.html: Removed.
* fast/dom/shadow/distribution-attribute-modified.html: Removed.
* fast/dom/shadow/distribution-className-modified-expected.html: Removed.
* fast/dom/shadow/distribution-className-modified.html: Removed.
* fast/dom/shadow/distribution-id-modified-expected.html: Removed.
* fast/dom/shadow/distribution-id-modified.html: Removed.
* fast/dom/shadow/reprojection-attribute-modified-expected.html: Removed.
* fast/dom/shadow/reprojection-attribute-modified.html: Removed.
* fast/dom/shadow/reprojection-className-modified-expected.html: Removed.
* fast/dom/shadow/reprojection-className-modified.html: Removed.
* fast/dom/shadow/reprojection-id-modified-expected.html: Removed.
* fast/dom/shadow/reprojection-id-modified.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd initiator to CachedResourceRequest.
commit-queue@webkit.org [Tue, 13 Nov 2012 18:52:28 +0000 (18:52 +0000)]
Add initiator to CachedResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=101935

Patch by Marja Hölttä <marja@chromium.org> on 2012-11-13
Reviewed by Adam Barth.

Motivation: Chromium needs to know which elements request a
resource (such as an image or a script) (bug 92761). In addition,
for exposing resource timing information (bug 84883) we need to
store the initiator, and this is the first step towards it.

No new tests: No visible change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSCrossfadeValue.cpp:
(WebCore::cachedImageForCSSValue):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSImageValue.h:
(WebCore):
(CSSImageValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::load):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::cachedShader):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
* html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::preload):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore):
(WebCore::CachedResourceLoader::preload):
* loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
(WebCore):
(WebCore::CachedResourceRequest::~CachedResourceRequest):
(WebCore::CachedResourceRequest::setInitiator):
(WebCore::CachedResourceRequest::initiatorName):
(WebCore::CachedResourceRequest::initiatorDocument):
(WebCore::CachedResourceRequest::initiatorElement):
* loader/cache/CachedResourceRequest.h:
(WebCore):
(WebCore::CachedResourceRequest::setOptions):
(WebCore::CachedResourceRequest::defer):
(WebCore::CachedResourceRequest::setDefer):
(CachedResourceRequest):
* loader/cache/CachedResourceRequestInitiators.cpp: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
(WebCore):
(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):
* loader/cache/CachedResourceRequestInitiators.h: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
(WebCore):
(CachedResourceRequestInitiators):
(WebCore::cachedResourceRequestInitiators):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore):
(WebCore::ThreadGlobalData::cachedResourceRequestInitiators):
(ThreadGlobalData):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] More unreviewed gardening.
rakuco@webkit.org [Tue, 13 Nov 2012 18:51:36 +0000 (18:51 +0000)]
[EFL] More unreviewed gardening.

Update some pixel expectations and skip one test.

* platform/efl/TestExpectations:
* platform/efl/fast/media/view-mode-media-feature-expected.png: Added property svn:mime-type.
* platform/efl/fast/overflow/overflow_hidden-expected.png: Modified property svn:mime-type.
* platform/efl/svg/text/text-rescale-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134345.
commit-queue@webkit.org [Tue, 13 Nov 2012 18:47:57 +0000 (18:47 +0000)]
Unreviewed, rolling out r134345.
http://trac.webkit.org/changeset/134345
https://bugs.webkit.org/show_bug.cgi?id=102106

Incomplete support for NATIVE_TYPE_ERR in objc and other
bindings (Requested by jsbell on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-13

Source/WebCore:

* Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::create):
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
* Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::setBinaryType):
* Modules/mediastream/RTCIceCandidate.cpp:
(WebCore::RTCIceCandidate::create):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
* Modules/mediastream/RTCSessionDescription.cpp:
(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::setType):
* bindings/js/CallbackFunction.cpp:
(WebCore::checkFunctionOnlyCallback):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::selectIndexSetter):
* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallString):
* bindings/v8/V8Callback.h:
(WebCore::createFunctionOnlyCallback):
* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* dom/DOMCoreException.idl:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacentElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD):
* page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::extend):
* svg/properties/SVGTransformListPropertyTearOff.h:
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):

LayoutTests:

* canvas/philip/tests/2d.drawImage.null.html:
* canvas/philip/tests/2d.imageData.put.null.html:
* canvas/philip/tests/2d.pattern.image.null.html:
* editing/selection/extend-expected.txt:
* fast/dom/Geolocation/argument-types-expected.txt:
* fast/dom/Geolocation/not-enough-arguments-expected.txt:
* fast/dom/Geolocation/script-tests/argument-types.js:
(test):
* fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt:
* fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt:
* fast/js/select-options-add-expected.txt:
* fast/mediastream/RTCIceCandidate-expected.txt:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/RTCSessionDescription-expected.txt:
* media/encrypted-media/encrypted-media-syntax-expected.txt:
* media/encrypted-media/encrypted-media-syntax.html:
* media/video-test.js:
* platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
* security/crypto-random-values-types-expected.txt:
* svg/dom/SVGTransformList-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: storage/indexeddb/mozilla/add-twice-failure.html is flaky following r134252
jsbell@chromium.org [Tue, 13 Nov 2012 18:45:34 +0000 (18:45 +0000)]
IndexedDB: storage/indexeddb/mozilla/add-twice-failure.html is flaky following r134252
https://bugs.webkit.org/show_bug.cgi?id=101996

Reviewed by Dimitri Glazkov.

Error being tested may cause transaction to abort, which could happen before or after
test output is captured. Prevent default behavior of the error so this doesn't happen.

* storage/indexeddb/mozilla/resources/add-twice-failure.js:
(addSecondExpectedError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding my new email address to committers.py and watchlist.
noam.rosenthal@nokia.com [Tue, 13 Nov 2012 18:26:38 +0000 (18:26 +0000)]
Unreviewed, adding my new email address to committers.py and watchlist.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134438 268f45cc-cd09-0410-ab3c-d52691b4dbfc