WebKit-https.git
5 years agoUnreviewed, EFL build fix since r169869.
gyuyoung.kim@samsung.com [Thu, 12 Jun 2014 05:03:07 +0000 (05:03 +0000)]
Unreviewed, EFL build fix since r169869.

Additionally literal-suffix is removed in EFL compile flag, because it is duplicated.

* Source/cmake/WebKitHelpers.cmake: Treat undef error as build warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font
mmaxfield@apple.com [Thu, 12 Jun 2014 02:24:25 +0000 (02:24 +0000)]
SVGGlyphToPathTranslator ASSERTs when encountering a missing glyph in an SVG font
https://bugs.webkit.org/show_bug.cgi?id=133528

Reviewed by Simon Fraser.

Source/WebCore:
Turns out this assertion is benign. We can take an early out of advance() (which
is then handled properly by Font::dashesForIntersectionsWithRect()

Test: svg/custom/skip-underline-missing-glyph.html

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect): Rather than skip partial results,
don't skip anything at all to be consistent.
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::advance): Take an early out to avoid an ASSERT.

LayoutTests:
Make sure that no ASSERT occurs in this situation. In addition, make sure that the
whole element doesn't get skip:ink gaps. This will need to be updated when we
support SVG + non-SVG mixed runs.

* svg/custom/skip-underline-missing-glyph-expected.html: Added
* svg/custom/skip-underline-missing-glyph.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for...
simon.fraser@apple.com [Thu, 12 Jun 2014 02:03:34 +0000 (02:03 +0000)]
[iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
https://bugs.webkit.org/show_bug.cgi?id=133779

Reviewed by Benjamin Poulain.

Source/WebCore:

Add a "testing" viewport configuration with initial scale of 1.

* WebCore.exp.in:
* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::testingParameters):
* page/ViewportConfiguration.h:

Source/WebKit2:

Support a custom viewport configuration for testing, on iOS.

* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _frameOrBoundsChanged]): Call setViewportConfigurationMinimumLayoutSize()
just as WKWebView does.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetUseTestingViewportConfiguration): New SPI to set a viewport config for testing.
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::setUseTestingViewportConfiguration):
(WebKit::WebPage::isUsingTestingViewportConfiguration):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::resetViewportDefaultConfiguration):

Tools:

Tell the WebPage to use the testing viewport configuration from the injected bundle.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage): Code cleanup.
* WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoKeep CFDataRefs in SharedBuffer instead of merging them
psolanki@apple.com [Thu, 12 Jun 2014 00:46:49 +0000 (00:46 +0000)]
Keep CFDataRefs in SharedBuffer instead of merging them
https://bugs.webkit.org/show_bug.cgi?id=133775

Reviewed by Alexey Proskuryakov.

Instead of merging the CFDataRefs into one buffer, save them in as CFDataRefs in
SharedBuffer. They will get merged when code calls buffer() later on.

No new tests because no functional changes.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::handleDataArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1.
commit-queue@webkit.org [Thu, 12 Jun 2014 00:32:28 +0000 (00:32 +0000)]
WebFrameNetworkContext should not have a sourceApplicationIdentifier in WK1.
https://bugs.webkit.org/show_bug.cgi?id=133772

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-11
Reviewed by Jer Noble.

Return empty string from sourceApplicationIdentifier for WK1.

* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoediting/selection/selection-in-iframe-removed-crash.html or selection-invalid-offset...
ap@apple.com [Thu, 12 Jun 2014 00:30:22 +0000 (00:30 +0000)]
editing/selection/selection-in-iframe-removed-crash.html or selection-invalid-offset.html crashes intermittently
https://bugs.webkit.org/show_bug.cgi?id=111521
<rdar://problem/15159351>

Reviewed by Brady Eidson.

Source/WebCore:
Covered by existing tests.

* loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData): Bail out if the
load was canceled from under receivedFirstData(). Since this is where we commit the
load, there are ample opportunities for scripts or clients to do anything.

LayoutTests:
* platform/mac/TestExpectations: Removed expectations for the tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unused VisibleContentRectUpdateInfo update ID
timothy_horton@apple.com [Thu, 12 Jun 2014 00:14:27 +0000 (00:14 +0000)]
Remove unused VisibleContentRectUpdateInfo update ID
https://bugs.webkit.org/show_bug.cgi?id=133777

Reviewed by Benjamin Poulain.

Remove some unused code.

* Shared/VisibleContentRectUpdateInfo.cpp:
(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):
* Shared/VisibleContentRectUpdateInfo.h:
(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::operator==):
(WebKit::VisibleContentRectUpdateInfo::updateID): Deleted.
* Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::setLastVisibleContentRectUpdateID): Deleted.
(WebKit::RemoteLayerTreeTransaction::lastVisibleContentRectUpdateID): Deleted.
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::nextVisibleContentRectUpdateID): Deleted.
(WebKit::WebPageProxy::lastVisibleContentRectUpdateID): Deleted.
* UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::willCommitLayerTree):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSubpixel rendering: RenderBox's content clipping should clip on device pixel boundary.
zalan@apple.com [Thu, 12 Jun 2014 00:14:21 +0000 (00:14 +0000)]
Subpixel rendering: RenderBox's content clipping should clip on device pixel boundary.
https://bugs.webkit.org/show_bug.cgi?id=133767
<rdar://problem/17272365>

Reviewed by Simon Fraser.

Push RenderBox's content clipping to device pixel boundaries. Integral snapping makes
content cut off prematurely.

Source/WebCore:
Test: fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):

LayoutTests:
* fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden-expected.html: Added.
* fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove XHRReplayData::addHeader
andersca@apple.com [Wed, 11 Jun 2014 23:57:39 +0000 (23:57 +0000)]
Remove XHRReplayData::addHeader
https://bugs.webkit.org/show_bug.cgi?id=133776

Reviewed by Antti Koivisto.

Just pass the HTTP header map to XHRReplayData::create directly.

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willLoadXHR):
* inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::create):
(WebCore::XHRReplayData::XHRReplayData):
(WebCore::XHRReplayData::addHeader): Deleted.
* inspector/NetworkResourcesData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the Mac build.
aestes@apple.com [Wed, 11 Jun 2014 23:12:30 +0000 (23:12 +0000)]
Fix the Mac build.

* WebCore.exp.in: Exported __ZN7WebCore19ResourceRequestBase15setHTTPReferrerERKN3WTF6StringE
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: Moved ivar declarations to @interface to account for the 32-bit legacy runtime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] Move CompletionHandlerCallChecker into a separate file
mitz@apple.com [Wed, 11 Jun 2014 23:06:43 +0000 (23:06 +0000)]
[Cocoa] Move CompletionHandlerCallChecker into a separate file
https://bugs.webkit.org/show_bug.cgi?id=133774

Reviewed by Anders Carlsson.

* Shared/Cocoa/CompletionHandlerCallChecker.h: Added.
* Shared/Cocoa/CompletionHandlerCallChecker.mm: Added.
(WebKit::CompletionHandlerCallChecker::create):
(WebKit::CompletionHandlerCallChecker::CompletionHandlerCallChecker):
(WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker):
(WebKit::CompletionHandlerCallChecker::didCallCompletionHandler):
(WebKit::CompletionHandlerCallChecker::classImplementingDelegateMethod):

* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::CompletionHandlerCallChecker::create): Deleted.
(WebKit::CompletionHandlerCallChecker::~CompletionHandlerCallChecker): Deleted.
(WebKit::CompletionHandlerCallChecker::didCallCompletionHandler): Deleted.
(WebKit::CompletionHandlerCallChecker::CompletionHandlerCallChecker): Deleted.
(WebKit::CompletionHandlerCallChecker::classImplementingDelegateMethod): Deleted.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInline caching should try to flatten uncacheable dictionaries
mhahnenberg@apple.com [Wed, 11 Jun 2014 22:55:34 +0000 (22:55 +0000)]
Inline caching should try to flatten uncacheable dictionaries
https://bugs.webkit.org/show_bug.cgi?id=133683

Reviewed by Geoffrey Garen.

There exists a body of JS code that deletes properties off of objects (especially function/constructor objects),
which puts them into an uncacheable dictionary state. This prevents all future inline caching for these objects.
If properties are deleted out of the object during its initialization, we can enable caching for that object by
attempting to flatten it when we see we're trying to do inline caching with that object. We then record that we
performed this flattening optimization in the object's Structure. If it ever re-enters the uncacheable dictionary
state then we can just give up on caching that object.

In refactoring some of the code in tryCacheGetById and tryBuildGetByIdList to reduce some duplication, I added
the InlineCacheAction enum, a new way to indicate the success or failure of an inline caching attempt. I changed
the other inline caching functions to return this enum rather than the opaque booleans that we were previously
returning.

* jit/Repatch.cpp:
(JSC::actionForCell):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::tryBuildGetByIDList):
(JSC::buildGetByIDList):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryBuildPutByIdList):
(JSC::buildPutByIdList):
(JSC::tryRepatchIn):
(JSC::repatchIn):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::flattenDictionaryStructure):
* runtime/Structure.h:
(JSC::Structure::hasBeenFlattenedBefore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake FrameView 8 bytes smaller
simon.fraser@apple.com [Wed, 11 Jun 2014 22:52:28 +0000 (22:52 +0000)]
Make FrameView 8 bytes smaller
https://bugs.webkit.org/show_bug.cgi?id=133771

Reviewed by Anders Carlsson.

m_borderX and m_borderY were historical cruft.

* page/FrameView.cpp:
(WebCore::FrameView::reset):
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Clear UIProcess visual state after WebProcess crash
mhock@apple.com [Wed, 11 Jun 2014 22:49:36 +0000 (22:49 +0000)]
[iOS] Clear UIProcess visual state after WebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=133664
<rdar://problem/16952742>

Reviewed by Benjamin Poulain.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didRelaunchProcess]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didRelaunchProcess):
* UIProcess/mac/RemoteLayerTreeHost.h:
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::~RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::clearLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement swipeWithEvent for non-fluid swipes
timothy_horton@apple.com [Wed, 11 Jun 2014 22:47:16 +0000 (22:47 +0000)]
Implement swipeWithEvent for non-fluid swipes
https://bugs.webkit.org/show_bug.cgi?id=133766
<rdar://problem/17126889>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView swipeWithEvent:]):
On non-fluid swipes, go back or forward depending on the swipe direction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWindowFeatures arguments shoud ignore invalid characters in values
ddkilzer@apple.com [Wed, 11 Jun 2014 22:41:03 +0000 (22:41 +0000)]
WindowFeatures arguments shoud ignore invalid characters in values
<http://webkit.org/b/133703>
<rdar://problem/17254118>

Reviewed by Andy Estes.

Source/WebCore:

Test: fast/dom/Window/window-property-invalid-characters-ignored.html

* page/WindowFeatures.cpp:
(WebCore::WindowFeatures::WindowFeatures): Set |length| based on
|buffer|, not |features|.  Switch to using a for loop.  Switch
to unsigned types since we are working with positive offsets
into a String.

LayoutTests:

* fast/dom/Window/resources/window-property-invalid-characters-ignored.html: Added.
* fast/dom/Window/window-property-invalid-characters-ignored-expected.txt: Added.
* fast/dom/Window/window-property-invalid-characters-ignored.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoViewport arguments should ignore invalid characters in values
ddkilzer@apple.com [Wed, 11 Jun 2014 22:40:59 +0000 (22:40 +0000)]
Viewport arguments should ignore invalid characters in values
<http://webkit.org/b/133555>
<rdar://problem/17179650>

Reviewed by Daniel Bates.

Source/WebCore:

Test: fast/viewport/viewport-warnings-7.html

* dom/Document.cpp:
(WebCore::Document::processArguments): Set |length| based on
|buffer|, not |features|.  Switch to using a for loop.  Switch
to unsigned types since we are working with positive offsets
into a String.

LayoutTests:

* fast/viewport/viewport-warnings-7-expected.txt: Added.
* fast/viewport/viewport-warnings-7.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove some HTTP header field accessors to ResourceRequestBase.cpp
andersca@apple.com [Wed, 11 Jun 2014 22:34:05 +0000 (22:34 +0000)]
Move some HTTP header field accessors to ResourceRequestBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=133773

Reviewed by Andreas Kling.

This will avoid having to include HTTPHeaderNames.h from ResourceRequestBase.h.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::httpOrigin):
(WebCore::ResourceRequestBase::setHTTPOrigin):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::httpContentType): Deleted.
(WebCore::ResourceRequestBase::setHTTPContentType): Deleted.
(WebCore::ResourceRequestBase::httpReferrer): Deleted.
(WebCore::ResourceRequestBase::setHTTPReferrer): Deleted.
(WebCore::ResourceRequestBase::httpOrigin): Deleted.
(WebCore::ResourceRequestBase::setHTTPOrigin): Deleted.
(WebCore::ResourceRequestBase::httpUserAgent): Deleted.
(WebCore::ResourceRequestBase::setHTTPUserAgent): Deleted.
(WebCore::ResourceRequestBase::httpAccept): Deleted.
(WebCore::ResourceRequestBase::setHTTPAccept): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] Xcode cannot infer that the WebKit target implicitly depends on WebCore.framework
mitz@apple.com [Wed, 11 Jun 2014 22:31:31 +0000 (22:31 +0000)]
[Cocoa] Xcode cannot infer that the WebKit target implicitly depends on WebCore.framework
https://bugs.webkit.org/show_bug.cgi?id=133765

Reviewed by Anders Carlsson.

* Configurations/WebKit.xcconfig: Move linking against WebCore from OTHER_LDFLAGS here...
* WebKit2.xcodeproj/project.pbxproj: ...to the Link Binary With Libraries build phase here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWTR cleanup: push per-test viewport configuration into TestController, where platform...
simon.fraser@apple.com [Wed, 11 Jun 2014 22:08:34 +0000 (22:08 +0000)]
WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
https://bugs.webkit.org/show_bug.cgi?id=133770

Reviewed by Anders Carlsson.

Push the per-test view configuration up to TestController, so that platforms
can modify the behavior. This also allows platform-specific changes (e.g.
for threaded scrolling) to made without #ifefs.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::updateWebViewSizeForTest):
(WTR::TestController::updateWindowScaleForTest):
(WTR::shouldUseFixedLayout):
(WTR::TestController::updateLayoutTypeForTest):
(WTR::TestController::platformConfigureViewForTest):
(WTR::TestController::configureViewForTest):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::sizeWebViewForCurrentTest): Deleted.
(WTR::changeWindowScaleIfNeeded): Deleted.
(WTR::shouldUseThreadedScrolling): Deleted.
(WTR::updateThreadedScrollingForCurrentTest): Deleted.
(WTR::shouldUseFixedLayout): Deleted.
(WTR::updateLayoutType): Deleted.
* WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::pathOrURL):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::shouldMakeViewportFlexible):
(WTR::TestController::platformConfigureViewForTest):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::shouldUseThreadedScrolling):
(WTR::TestController::platformConfigureViewForTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove some more unneeded member functions from HTTPHeaderMap
andersca@apple.com [Wed, 11 Jun 2014 22:01:03 +0000 (22:01 +0000)]
Remove some more unneeded member functions from HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=133768

Reviewed by Simon Fraser.

* loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::find): Deleted.
(WebCore::HTTPHeaderMap::keys): Deleted.
* platform/network/HTTPHeaderMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviwed Mac release build fix; mark the keyPath parameter as unused.
jer.noble@apple.com [Wed, 11 Jun 2014 21:57:55 +0000 (21:57 +0000)]
Unreviwed Mac release build fix; mark the keyPath parameter as unused.

* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Avoid deadlock with AVFoundation
bfulgham@apple.com [Wed, 11 Jun 2014 21:43:55 +0000 (21:43 +0000)]
[Win] Avoid deadlock with AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=133762
<rdar://problem/17128248>

Reviewed by Eric Carlson.

Always invoke our notifications asynchronously so that we do not
execute long-running code while holding the AVFWrapper map mutex
lock. AVFoundationCF callbacks can deadlock if we call into AVF
while holding this lock.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMake] One more URTBF after r169826.
ossy@webkit.org [Wed, 11 Jun 2014 21:42:24 +0000 (21:42 +0000)]
[CMake] One more URTBF after r169826.

* CMakeLists.txt: Generate files to the proper place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Add dependencies packages to efl install-dependencies file
gyuyoung.kim@samsung.com [Wed, 11 Jun 2014 21:38:01 +0000 (21:38 +0000)]
[EFL] Add dependencies packages to efl install-dependencies file
https://bugs.webkit.org/show_bug.cgi?id=133720

Reviewed by Csaba Osztrogonác.

After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
install doxygen and libssl-dev because efl 1.9 depends on those libraries.

* efl/install-dependencies:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMake]URTBF after r169826.
ossy@webkit.org [Wed, 11 Jun 2014 21:33:24 +0000 (21:33 +0000)]
[CMake]URTBF after r169826.

* CMakeLists.txt: Typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Moving myself to the list of reviewers.
zoltan@webkit.org [Wed, 11 Jun 2014 21:29:50 +0000 (21:29 +0000)]
Unreviewed. Moving myself to the list of reviewers.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of an unneeded HTTPHeaderMap::remove overload
andersca@apple.com [Wed, 11 Jun 2014 21:28:59 +0000 (21:28 +0000)]
Get rid of an unneeded HTTPHeaderMap::remove overload
https://bugs.webkit.org/show_bug.cgi?id=133763

Reviewed by Andreas Kling.

Change HTTPHeaderMap::remove to return whether an entry was removed or not and simplify
ResourceRequestBase::clearHTTPAuthorization.

* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::remove):
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::clearHTTPAuthorization):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] URTBF after r169823.
ossy@webkit.org [Wed, 11 Jun 2014 21:28:00 +0000 (21:28 +0000)]
[EFL] URTBF after r169823.

* bindings/ScriptValue.cpp: Missing include added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Enable fast/viewport tests
ddkilzer@apple.com [Wed, 11 Jun 2014 21:11:33 +0000 (21:11 +0000)]
[iOS] Enable fast/viewport tests
<http://webkit.org/b/133754>

Reviewed by Andy Estes.

* platform/ios-sim/Skipped:
- Stop skipping fast/viewport tests.

* platform/ios-sim/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
* platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
* platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
* platform/ios-sim/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
* platform/ios-sim/fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
* platform/ios-sim/fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
* platform/ios-sim/fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
* platform/ios-sim/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt: Added.
- iOS never supported these "legacy" viewport modes, so add
  platform-specific results with current behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove an unnecessary asObject(this) call inside JSObject::fastGetOwnPropertySlot.
rniwa@webkit.org [Wed, 11 Jun 2014 21:04:58 +0000 (21:04 +0000)]
Remove an unnecessary asObject(this) call inside JSObject::fastGetOwnPropertySlot.

Rubber-stamped by Andreas Kling.

* runtime/JSObject.h:
(JSC::JSObject::fastGetOwnPropertySlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EME][Mac] Propagate errors from AVSampleBufferDisplayLayer through to MSE
jer.noble@apple.com [Wed, 11 Jun 2014 21:02:26 +0000 (21:02 +0000)]
[EME][Mac] Propagate errors from AVSampleBufferDisplayLayer through to MSE
https://bugs.webkit.org/show_bug.cgi?id=133747

Reviewed by Eric Carlson.

Abstract out the delivery of errors in MediaKeySession into its own method, which can be triggered by
CDMSession objects through the CDMSessionClient interface:
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendMessage):
(WebCore::MediaKeySession::sendError):
* Modules/encryptedmedia/MediaKeySession.h:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError):
* Modules/mediasource/SourceBuffer.h:
* platform/graphics/SourceBufferPrivateClient.h:
* platform/graphics/CDMSession.h:

Add an Objective-C object which can listen for error KVO notifications:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
(WebCore::SourceBufferPrivateAVFObjCErrorClient::~SourceBufferPrivateAVFObjCErrorClient):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener initWithParent:WebCore::]):
(-[WebAVSampleBufferErrorListener dealloc]):
(-[WebAVSampleBufferErrorListener invalidate]):
(-[WebAVSampleBufferErrorListener beginObservingLayer:]):
(-[WebAVSampleBufferErrorListener stopObservingLayer:]):
(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVSampleBufferErrorListener layerFailedToDecode:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::registerForErrorNotifications):
(WebCore::SourceBufferPrivateAVFObjC::unregisterForErrorNotifications):
(WebCore::SourceBufferPrivateAVFObjC::layerDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):

Register for the new error notifications:
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC): Moved to source file.
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC): Register for error notifications.
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC): Unregister for error notifications.
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError): Pass through to CDMSessionClient.
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't force CharacterData to override getOwnPropertySlot.
akling@apple.com [Wed, 11 Jun 2014 20:49:42 +0000 (20:49 +0000)]
Don't force CharacterData to override getOwnPropertySlot.
<https://webkit.org/b/133717>

This was preventing us from taking the GetByVal fast path for Text nodes
since they inherit from CharacterData and having a "length" attribute
meant we gave them a custom getOwnPropertySlot, despite not actually
needing it for anything.

Reviewed by Anders Carlsson.

* bindings/scripts/CodeGeneratorJS.pm:
(AttributeShouldBeOnInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoinspector-protocol/debugger/breakpoint-action-detach.html is flaky
ap@apple.com [Wed, 11 Jun 2014 20:46:36 +0000 (20:46 +0000)]
inspector-protocol/debugger/breakpoint-action-detach.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=133761

* TestExpectations: Skipped it. Updated bug number for another inspector-protocol
test while at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[wk2] Don't dispatch view state changes immediately
timothy_horton@apple.com [Wed, 11 Jun 2014 20:43:50 +0000 (20:43 +0000)]
[wk2] Don't dispatch view state changes immediately
https://bugs.webkit.org/show_bug.cgi?id=133713

Reviewed by Simon Fraser.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::updateViewState): Deleted.
* UIProcess/WebPageProxy.h:
On PLATFORM(COCOA), wait until just before CA is going to commit the UI process layer
tree to dispatch view state changes to the Web process. This avoids sending multiple
view state change messages to the Web process within one run-loop cycle, for example
when a view is moved around in the view hierarchy but the view state otherwise remains the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a script that generates a gperf hash for HTTP header names
andersca@apple.com [Wed, 11 Jun 2014 20:42:34 +0000 (20:42 +0000)]
Add a script that generates a gperf hash for HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=133760

Reviewed by Andreas Kling.

This is the first step towards getting rid of AtomicString from HTTPHeaderMap.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/network/HTTPHeaderNames.in: Added.
* platform/network/create-http-header-name-table: Added.
(HTTPHeaderName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake it possible for waitForAndDispatchImmediately to bail if a sync message comes...
timothy_horton@apple.com [Wed, 11 Jun 2014 20:37:59 +0000 (20:37 +0000)]
Make it possible for waitForAndDispatchImmediately to bail if a sync message comes in from the other direction
https://bugs.webkit.org/show_bug.cgi?id=133708

Reviewed by Anders Carlsson.

* Platform/IPC/Connection.cpp:
(IPC::WaitForMessageState):
(IPC::Connection::Connection):
(IPC::Connection::waitForMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
* Platform/IPC/Connection.h:
(IPC::Connection::waitForAndDispatchImmediately):
Remove the waitForMessageMap, and assert that we're only ever waiting for one message at a time.
This simplifies this code a bit, and we never wait on more than one message at a time, so it was unnecessary.

Add a flag to waitForAndDispatchImmediately, InterruptWaitingIfSyncMessageArrives, which will cause
waitForAndDispatchImmediately to bail if a sync message arrives, to avoid pointlessly blocking both processes
for the entire timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTurning on DUMP_PROPERTYMAP_STATS causes a build failure
rniwa@webkit.org [Wed, 11 Jun 2014 20:21:34 +0000 (20:21 +0000)]
Turning on DUMP_PROPERTYMAP_STATS causes a build failure
https://bugs.webkit.org/show_bug.cgi?id=133673

Reviewed by Andreas Kling.

Source/JavaScriptCore:
Rewrote the property map statistics code because the old code wasn't building,
and it was also mixing numbers for lookups and insertions/removals.

New logging code records the number of calls to PropertyTable::find (finds) and
PropertyTable::get/PropertyTable::findWithString separately so that we can quantify
the number of probing during updates and lookups.

* jsc.cpp:
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::get):
(JSC::PropertyTable::findWithString):
(JSC::PropertyTable::add):
(JSC::PropertyTable::remove):
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
* runtime/Structure.cpp:
(JSC::PropertyMapStatisticsExitLogger::PropertyMapStatisticsExitLogger):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):

Source/WTF:
Added DEFINE_GLOBAL_FOR_LOGGING to allow running a destructor in logging code
that needs to be enabled in release builds (e.g. for JavaScriptCore).

* wtf/StdLibExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAlways inline JSValue::get() and Structure::get().
akling@apple.com [Wed, 11 Jun 2014 20:16:42 +0000 (20:16 +0000)]
Always inline JSValue::get() and Structure::get().
<https://webkit.org/b/133755>

Reviewed by Ryosuke Niwa.

These functions get really hot, so ask the compiler to be more
aggressive about inlining them.

~28% speed-up on Ryosuke's microbenchmark for accessing nextSibling
through GetByVal.

* runtime/JSArrayIterator.cpp:
* runtime/JSCJSValue.cpp:
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::get):
* runtime/JSPromiseDeferred.cpp:
* runtime/StructureInlines.h:
(JSC::Structure::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStructure::get should instantiate DeferGC only when materializing property map
rniwa@webkit.org [Wed, 11 Jun 2014 20:15:30 +0000 (20:15 +0000)]
Structure::get should instantiate DeferGC only when materializing property map
https://bugs.webkit.org/show_bug.cgi?id=133727

Rubber-stamped by Andreas Kling.

Make materializePropertyMapIfNecessary always inline.

This is ~12% improvement on the microbenchmark attached in the bug.

* runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRestrict database process profile
oliver@apple.com [Wed, 11 Jun 2014 20:13:37 +0000 (20:13 +0000)]
Restrict database process profile
https://bugs.webkit.org/show_bug.cgi?id=133750

Reviewed by Alexey Proskuryakov.

Make the sandbox profile much more restrictive.

* Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't snapshot offscreen plugins that would normally be considered primary plugins...
roger_fong@apple.com [Wed, 11 Jun 2014 19:59:24 +0000 (19:59 +0000)]
Don't snapshot offscreen plugins that would normally be considered primary plugins after they are moved in view.
https://bugs.webkit.org/show_bug.cgi?id=133667.
<rdar://problem/16743250>

Reviewed by Tim Horton.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
(WebKit::PluginView::pluginSnapshotTimerFired):
Set the display state to Playing if the following is true:
The plugin in question is large enough to be considered the primary snapshot and either:
a) The maximum number of snapshot retries has been reached and no good snapshot has been found.
b) The plugin is moved to be on-screen while the snapshot attempts are in progress.
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::plugInIntersectsSearchRect): Re-factor out intersection logic.
(WebKit::WebPage::plugInIsPrimarySize): Re-factor out primary plugin size logic.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Use the above two methods here.
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove more WKPreferences to WKWebViewConfiguration
andersca@apple.com [Wed, 11 Jun 2014 19:49:57 +0000 (19:49 +0000)]
Move more WKPreferences to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=133756
<rdar://problem/17271468>

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences setMinimumFontSize:]):
(-[WKPreferences suppressesIncrementalRendering]): Deleted.
(-[WKPreferences setSuppressesIncrementalRendering:]): Deleted.
(-[WKPreferences allowsInlineMediaPlayback]): Deleted.
(-[WKPreferences setAllowsInlineMediaPlayback:]): Deleted.
(-[WKPreferences mediaPlaybackRequiresUserAction]): Deleted.
(-[WKPreferences setMediaPlaybackRequiresUserAction:]): Deleted.
(-[WKPreferences mediaPlaybackAllowsAirPlay]): Deleted.
(-[WKPreferences setMediaPlaybackAllowsAirPlay:]): Deleted.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.h:
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate WKSI for <rdar://problem/17009091>.
jer.noble@apple.com [Wed, 11 Jun 2014 19:31:51 +0000 (19:31 +0000)]
Update WKSI for <rdar://problem/17009091>.

Rubber stamped by Eric Carlson.

* libWebKitSystemInterfaceMavericks.a:
* libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStructure::get should instantiate DeferGC only when materializing property map
rniwa@webkit.org [Wed, 11 Jun 2014 19:29:51 +0000 (19:29 +0000)]
Structure::get should instantiate DeferGC only when materializing property map
https://bugs.webkit.org/show_bug.cgi?id=133727

Reviewed by Geoffrey Garen.

DeferGC instances in Structure::get was added in http://trac.webkit.org/r157539 in order to avoid
collecting the property table newly created by materializePropertyMapIfNecessary since GC can happen
when GCSafeConcurrentJITLocker goes out of scope.

However, always instantiating DeferGC inside Structure::get introduced a new performance bottleneck
in JSObject::getPropertySlot because frequently incrementing and decrementing a counter in vm.m_heap
and running a release assertion inside Heap::incrementDeferralDepth() is expensive.

Work around this by instantiating DeferGC only when we're actually calling materializePropertyMap,
and immediately storing a pointer to the newly created property table in the stack before DeferGC
goes out of scope so that the property table will be marked.

This shows 13-16% improvement on the microbenchmark attached in the bug.

* runtime/JSCJSValue.cpp:
* runtime/JSObject.h:
(JSC::JSObject::fastGetOwnPropertySlot):
* runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
* runtime/StructureInlines.h:
(JSC::Structure::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSome JSValue::get() micro-optimzations.
akling@apple.com [Wed, 11 Jun 2014 18:40:13 +0000 (18:40 +0000)]
Some JSValue::get() micro-optimzations.
<https://webkit.org/b/133739>

Tighten some of the property lookup code to improve performance of the
eagerly reified prototype attributes:

- Instead of converting the property name to an integer at every step
  in the prototype chain, move that to a separate pass at the end
  since it should be a rare case.

- Cache the StructureIDTable in a local instead of fetching it from
  the Heap on every step.

- Make fillCustomGetterPropertySlot inline. It was out-of-lined based
  on the assumption that clients would mostly be cacheable GetByIds,
  and it gets pretty hot (~1%) in GetByVal.

- Pass the Structure directly to fillCustomGetterPropertySlot instead
  of refetching it from the StructureIDTable.

Reviewed by Geoff Garen.

* runtime/JSObject.cpp:
(JSC::JSObject::fillCustomGetterPropertySlot): Deleted.
* runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::fillCustomGetterPropertySlot):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::getOwnPropertySlotSlow): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoROLLOUT: r153510: Broke Table borders on Wikipedia
bfulgham@apple.com [Wed, 11 Jun 2014 18:36:07 +0000 (18:36 +0000)]
ROLLOUT: r153510: Broke Table borders on Wikipedia
https://bugs.webkit.org/show_bug.cgi?id=132802
<rdar://problem/16792562>

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect): Deleted.
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect): Deleted.
* rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebKit2 iOS: Unable to open UI menu for "open in new tab" for links on yahoo.com.
enrica@apple.com [Wed, 11 Jun 2014 18:06:14 +0000 (18:06 +0000)]
WebKit2 iOS: Unable to open UI menu for "open in new tab" for links on yahoo.com.
https://bugs.webkit.org/show_bug.cgi?id=133749
<rdar://problem/17165992>

Reviewed by Brady Eidson.

The URL returned to the UIProcess as string needs to be encoded.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove suppressesIncrementalRendering to WKWebViewConfiguration
andersca@apple.com [Wed, 11 Jun 2014 17:44:56 +0000 (17:44 +0000)]
Move suppressesIncrementalRendering to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=133707
<rdar://problem/17271468>

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKPreferences.h:
Get rid of suppressesIncrementalRendering.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Set the suppressesIncrementalRenderingKey key in webPageConfiguration.preferenceValues.

* UIProcess/API/Cocoa/WKWebViewConfiguration.h:
Add suppressesIncrementalRendering.

* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
Assign suppressesIncrementalRendering.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Copy webPageConfiguration.preferenceValues to m_configurationPreferenceValues.

(WebKit::WebPageProxy::preferencesStore):
If m_configurationPreferenceValues is empty, just return m_preferences->store(). Otherwise,
copy the store and apply the configuration preference values.

(WebKit::WebPageProxy::preferencesDidChange):
Call preferencesStore() so we'll get the configuration preference values as well.

(WebKit::WebPageProxy::creationParameters):
Ditto.

* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Curl] Empty headers in request response.
commit-queue@webkit.org [Wed, 11 Jun 2014 17:27:30 +0000 (17:27 +0000)]
[Curl] Empty headers in request response.
https://bugs.webkit.org/show_bug.cgi?id=133483

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-11
Reviewed by Brent Fulgham.

When a request is taken from the cache, its cached response headers are empty, if the cache entry was created in the same session.
It is only when the cache entry is loaded from disc, that the response headers are properly set.
We need to set the cached response headers in both cases.
There is also an issue if two jobs are loading the same url at the same time.
Both jobs will then write to the cache content file, and create invalid content.
This can be fixed by only letting the first request write to the content file.

* platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::CurlCacheEntry):
(WebCore::CurlCacheEntry::isLoading): Added method to check if cache entry is loading the content.
(WebCore::CurlCacheEntry::saveResponseHeaders): Set the cached response headers when response is saved.
(WebCore::CurlCacheEntry::invalidate): To be on the safe side, close content file when entry is invalidated.
(WebCore::CurlCacheEntry::parseResponseHeaders): Made parameter const.
* platform/network/curl/CurlCacheEntry.h: Keep track of which job is creating this cache entry.
(WebCore::CurlCacheEntry::getJob):
* platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::loadIndex): When cache entry is loaded from disc, there is no associated job.
(WebCore::CurlCacheManager::didReceiveResponse): Bail out if cache entry is already currently loading,
otherwise associate this job with the new cache entry.
(WebCore::CurlCacheManager::didFinishLoading): Changed parameter type.
(WebCore::CurlCacheManager::isCached): Don't report the url as cached if it's currently loading content.
(WebCore::CurlCacheManager::didReceiveData): Don't write to the content file if the entry is not associated with the job.
(WebCore::CurlCacheManager::didFail): Changed parameter type.
* platform/network/curl/CurlCacheManager.h: Changed parameter type.
* platform/network/curl/ResourceHandleManager.cpp: Ditto.
(WebCore::writeCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r133705): Layout Test js/dom/webidl-type-mapping.html is failing
weinig@apple.com [Wed, 11 Jun 2014 17:03:20 +0000 (17:03 +0000)]
REGRESSION (r133705): Layout Test js/dom/webidl-type-mapping.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133736

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Turns out we can't remove the HashTable yet after all, as JavaScriptCore
relies on hasSetterOrReadonlyProperties bit to make put work correctly. We
can, however, skip creating the table, and just use the value array during
reification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: iOS: VoiceOver ignores input type = date in Safari on iOS7
cfleizach@apple.com [Wed, 11 Jun 2014 16:12:56 +0000 (16:12 +0000)]
AX: iOS: VoiceOver ignores input type = date in Safari on iOS7
https://bugs.webkit.org/show_bug.cgi?id=133709

Reviewed by Mario Sanchez Prada.

The date field on iOS appears as a popup button, which is not a type we had encountered for <input> types.
This returns an appropriate role in that case.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Drop to maintain EFL 32bit release bot
gyuyoung.kim@samsung.com [Wed, 11 Jun 2014 15:37:31 +0000 (15:37 +0000)]
[EFL] Drop to maintain EFL 32bit release bot
https://bugs.webkit.org/show_bug.cgi?id=133710

Reviewed by Csaba Osztrogonác.

* BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWrap NSURLRequest in bundle API
antti@apple.com [Wed, 11 Jun 2014 15:36:58 +0000 (15:36 +0000)]
Wrap NSURLRequest in bundle API
https://bugs.webkit.org/show_bug.cgi?id=133732
<rdar://problem/17267217>

Reviewed by Andreas Kling.

Patch by Dan Bernstein.

We don't want to construct actual NSURLRequests in the web process side unless really needed as it is slow.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* Shared/Cocoa/WKNSURLRequest.h: Added.
(WebKit::wrapper):
* Shared/Cocoa/WKNSURLRequest.mm: Added.

    Add a wrapper object that initializes the underlying NSURLRequest on-demand.

(-[WKNSURLRequest _web_createTarget]):
(-[WKNSURLRequest URL]):
(-[WKNSURLRequest copyWithZone:]):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(willSendRequestForFrame):
(didInitiateLoadForResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Unreviewed GTK gardening
commit-queue@webkit.org [Wed, 11 Jun 2014 14:42:30 +0000 (14:42 +0000)]
[GTK] Unreviewed GTK gardening

Add missing GTK expectations file after test added at r169390, and removed specific
ones for tests now passing with default ones after r169403.

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-06-11

* platform/gtk/fast/dom/webtiming-document-open-expected.txt: Removed.
* platform/gtk/fast/dom/webtiming-navigate-within-document-expected.txt: Removed.
* platform/gtk/fast/multicol/pagination/nested-transforms-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<rdar://problem/17218629> [Cocoa] WKWebView’s canGoBack and canGoForward properties...
mitz@apple.com [Wed, 11 Jun 2014 14:30:34 +0000 (14:30 +0000)]
<rdar://problem/17218629> [Cocoa] WKWebView’s canGoBack and canGoForward properties are not KVO-compliant
https://bugs.webkit.org/show_bug.cgi?id=133722

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm: Added no-op overrides of new
PageLoadStateObserver member functions.

* UIProcess/API/Cocoa/WKWebView.h: Documented the canGoBack and canGoForward properties as
being KVO-compliant.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView canGoBack]): Changed to get the return value from the page load state.
(-[WKWebView canGoForward]): Ditto.

* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::willChangeCanGoBack): Override this new PageLoadStateObserver
member function by sending the appropriate KVO change message to the WKWebView.
(WebKit::NavigationState::didChangeCanGoBack): Ditto.
(WebKit::NavigationState::willChangeCanGoForward): Ditto.
(WebKit::NavigationState::didChangeCanGoForward): Ditto.

* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Check for changes to canGoBack and canGoForward
and call the observers if needed.
(WebKit::PageLoadState::canGoBack): Added. Returns the value from the committed state.
(WebKit::PageLoadState::setCanGoBack): Added. Sets the value in the uncommitted state.
(WebKit::PageLoadState::canGoForward): Added. Returns the value from the committed state.
(WebKit::PageLoadState::setCanGoForward): Added. Sets the value in the uncommitted state.
* UIProcess/PageLoadState.h:
(WebKit::PageLoadState::Data::Data): Added canGoBack and canGoForward boolean members.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList): Update the page load state with the new
state of canGoBack and canGoForward.
* UIProcess/WebPageProxy.h: Removed unused member variables m_canGoBack and m_canGoForward.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Updated expectations for accessibility/lists.html test
commit-queue@webkit.org [Wed, 11 Jun 2014 12:50:31 +0000 (12:50 +0000)]
[EFL] Updated expectations for accessibility/lists.html test
https://bugs.webkit.org/show_bug.cgi?id=132818

Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-06-11
Reviewed by Mario Sanchez Prada.

* platform/efl-wk1/accessibility/lists-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAvoid Vector copies in WebNotificationManagerProxy::providerDidCloseNotifications...
zandobersek@gmail.com [Wed, 11 Jun 2014 12:22:04 +0000 (12:22 +0000)]
Avoid Vector copies in WebNotificationManagerProxy::providerDidCloseNotifications(), FindController::findStringMatches()
https://bugs.webkit.org/show_bug.cgi?id=133676

Reviewed by Andreas Kling.

* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications): Move the newly-created
Vector object into the HashMap<>::add() call.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches): Movethe newly-create Vector object into the
Vector<>::append() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAvoid FontGlyphsCacheKey copy in FontGlyphsCacheEntry constructor
zandobersek@gmail.com [Wed, 11 Jun 2014 12:20:49 +0000 (12:20 +0000)]
Avoid FontGlyphsCacheKey copy in FontGlyphsCacheEntry constructor
https://bugs.webkit.org/show_bug.cgi?id=133674

Reviewed by Andreas Kling.

* platform/graphics/Font.cpp:
(WebCore::FontGlyphsCacheEntry::FontGlyphsCacheEntry): The FontGlyphsCacheKey
variable is already passed-in as an rvalue reference, so it should be moved
into the constructor of the corresponding member variable instead of copied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Add missing test cases for EWK2ViewTest.
commit-queue@webkit.org [Wed, 11 Jun 2014 11:56:05 +0000 (11:56 +0000)]
[EFL][WK2] Add missing test cases for EWK2ViewTest.
https://bugs.webkit.org/show_bug.cgi?id=133715

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-06-11
Reviewed by Gyuyoung Kim.

Add missing test cases for ewk_view.h APIs, ewk_view_stop(), ewk_view_html_string_load(), ewk_view_theme_get(),
ewk_view_feed_touch_event(), ewk_view_text_find_highlight_clear(), ewk_view_text_find(), ewk_view_text_matches_count(),
ewk_view_page_contents_get(), ewk_view_script_execute().

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build after after r169789 on platforms that build with -Wunused-const-variable
aestes@apple.com [Wed, 11 Jun 2014 10:46:24 +0000 (10:46 +0000)]
Fix the build after after r169789 on platforms that build with -Wunused-const-variable

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable): Don't create the value array if it'll never be used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use a different user agent string depending on the site
carlosgc@webkit.org [Wed, 11 Jun 2014 07:38:35 +0000 (07:38 +0000)]
[GTK] Use a different user agent string depending on the site
https://bugs.webkit.org/show_bug.cgi?id=132681

Reviewed by Anders Carlsson.

Source/WebCore:
We have changed the user agent string several times to try to fix
broken websites that require specific things in the UA string to
properly work. But everytime we change the UA string to fix a
website we break others. We could use different UA string
depending on the website. UserAgentGtk code has also been cleaned
up, using NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL
and avoiding unneeded conversions to UTF-8.

* platform/gtk/UserAgentGtk.cpp:
(WebCore::UserAgentQuirks::UserAgentQuirks): New helper private
class to handle user agent quirks.
(WebCore::UserAgentQuirks::add):
(WebCore::UserAgentQuirks::contains):
(WebCore::UserAgentQuirks::isEmpty):
(WebCore::platformForUAString): Bring back this method that was
removed to always pretend to be Macintosh.
(WebCore::platformVersionForUAString): Return a different platform
version depending on the actual platform.
(WebCore::versionForUAString): Return the WebKit version.
(WebCore::buildUserAgentString): Helper function to build the user
agent taking into account the UserAgentQuirks received.
(WebCore::standardUserAgentStatic): Standard user agent string
when no quirks are present.
(WebCore::standardUserAgent):
(WebCore::standardUserAgentForURL): New method that returns the
user agent string for the given URL.
* platform/gtk/UserAgentGtk.h:

Source/WebKit2:
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_class_init): Enable site specific quirks setting
by default.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::userAgent): Pass the given URL to WebPage.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::userAgent): Try to get the user agent for the
URL received falling back to the current one otherwise.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::platformUserAgent): Added.
* WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::platformUserAgent): Return null String.
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformUserAgent): Use WebCore::standardUserAgentForURL() when site specific quirks
setting is enabled.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformUserAgent): Return null String.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformUserAgent): Return null String.

Tools:
Add a unit test to check user agent quirks.

* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
(testWebKitSettings): Site specific quirks setting is now enabled
by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, EFL build fix. Treat literal-suffix error as build warning.
gyuyoung.kim@samsung.com [Wed, 11 Jun 2014 07:13:23 +0000 (07:13 +0000)]
Unreviewed, EFL build fix. Treat literal-suffix error as build warning.

* Source/cmake/WebKitHelpers.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed build fix.
achristensen@apple.com [Wed, 11 Jun 2014 07:02:23 +0000 (07:02 +0000)]
[Win] Unreviewed build fix.

Source/WebCore:
* platform/network/curl/ResourceRequest.h:
Include missing PassOwnPtr.h.

Source/WebKit:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Fixed 64-bit linker symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoActually only generate tables for History and Location.
weinig@apple.com [Wed, 11 Jun 2014 05:44:00 +0000 (05:44 +0000)]
Actually only generate tables for History and Location.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, update my list of email addresses in contributors.json.
gyuyoung.kim@samsung.com [Wed, 11 Jun 2014 04:32:07 +0000 (04:32 +0000)]
Unreviewed, update my list of email addresses in contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempt to fix the tests.
weinig@apple.com [Wed, 11 Jun 2014 04:19:00 +0000 (04:19 +0000)]
Attempt to fix the tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Keep generating HashTables for History and Location, since they use them in
their custom getOwnPropertySlot delegates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] ScrollingTreeOverflowScrollingNode does not use asynchronous touch dispatch
benjamin@webkit.org [Wed, 11 Jun 2014 03:52:25 +0000 (03:52 +0000)]
[iOS][WK2] ScrollingTreeOverflowScrollingNode does not use asynchronous touch dispatch
https://bugs.webkit.org/show_bug.cgi?id=133702

Source/WebCore:

Reviewed by Simon Fraser.

* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::scrollingTreeNodeWillStartPanGesture):

Source/WebKit2:
<rdar://problem/17259261>

Reviewed by Simon Fraser.

Notify the WKWebView and the TouchGestureRecognizer when on of the internal UIScrollView
starts scrolling in response to a gesture.

* UIProcess/PageClient.h:
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
* UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::scrollingTreeNodeWillStartPanGesture):
* UIProcess/Scrolling/RemoteScrollingTree.h:
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewWillStartPanGesture):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::scrollViewWillStartPanGesture):
* UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartPanGesture):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::scrollViewWillStartPanGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReduce the overhead of updating the animatable style on ARMv7
benjamin@webkit.org [Wed, 11 Jun 2014 03:35:43 +0000 (03:35 +0000)]
Reduce the overhead of updating the animatable style on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=133618

Reviewed by Simon Fraser.

While updating the style for animations, most of the time spent was pure calling overhead.

This patch should reduce this a bit on ARMv7:
1) Get the frame directly from the document instead of document->view->framview->frame.
2) Inline RenderObject::animation(). This is just 3 loads, setting up the registers on the call
   site is more expensive than loading the values directly.
3) Inline RenderElement::setAnimatableStyle(). It has only one call site and the call is mostly
   overhead.

* css/CSSComputedStyleDeclaration.cpp:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::setAnimatableStyle): Deleted.
* rendering/RenderElement.h:
(WebCore::RenderElement::setAnimatableStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
(WebCore::RenderObject::animation): Deleted.
* rendering/RenderObject.h:
(WebCore::RenderObject::animation):
* rendering/RenderView.h:
(WebCore::RenderObject::frame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't create a HashTable for JSObjects that use eager reification
weinig@apple.com [Wed, 11 Jun 2014 03:09:22 +0000 (03:09 +0000)]
Don't create a HashTable for JSObjects that use eager reification
https://bugs.webkit.org/show_bug.cgi?id=133705

Reviewed by Geoffrey Garen.

../JavaScriptCore:
* runtime/Lookup.h:
(JSC::reifyStaticProperties):
Add a version of reifyStaticProperties that takes an array of HashTableValues
rather than a HashTable.

../WebCore:
It is unnecessary to create the CompactHashIndex or HashTable for JSObjects
that use eager reification, since we will never look up properties directly.
Instead, we can iterate the HashTableValue array directly during reification.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Only generate the value array for prototypes that use eager reification.

(GenerateHashTableValueArray):
Extract out into a helper.

(GenerateHashTable):
Add a parameter, $justGenerateValueArray, that if true, means we only
should generate the value array.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
* bindings/scripts/test/JS/JSTestException.cpp:
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
* bindings/scripts/test/JS/JSTestNode.cpp:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
* bindings/scripts/test/JS/JSattribute.cpp:
* bindings/scripts/test/JS/JSreadonly.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAlways switch to an sRGB screen color profile when running tests
simon.fraser@apple.com [Wed, 11 Jun 2014 02:28:42 +0000 (02:28 +0000)]
Always switch to an sRGB screen color profile when running tests
https://bugs.webkit.org/show_bug.cgi?id=133712

Reviewed by Tim Horton.

Switch the screen color profile to sRGB when running tests, because even ref
tests need the screen to use the correct color profile.

* DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile):
* Scripts/webkitpy/port/mac.py:
(MacPort.start_helper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPrediction propagator should make sure everyone knows that a variable that is in...
fpizlo@apple.com [Wed, 11 Jun 2014 01:53:19 +0000 (01:53 +0000)]
Prediction propagator should make sure everyone knows that a variable that is in an argument position where other versions of that variable are not MachineInts cannot possibly be flushed as Int52
https://bugs.webkit.org/show_bug.cgi?id=133698

Reviewed by Geoffrey Garen and Mark Hahnenberg.

* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate): Use the new utility to figure out if a variable could ever represent an Int52.
* dfg/DFGVariableAccessData.cpp:
(JSC::DFG::VariableAccessData::couldRepresentInt52): Add a new utility to detect early on if a variable could possibly be Int52.
(JSC::DFG::VariableAccessData::couldRepresentInt52Impl):
(JSC::DFG::VariableAccessData::flushFormat):
* dfg/DFGVariableAccessData.h:
* tests/stress/int52-inlined-call-argument.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Bump EFL libraries to 1.9
ryuan.choi@samsung.com [Wed, 11 Jun 2014 01:38:03 +0000 (01:38 +0000)]
[EFL] Bump EFL libraries to 1.9
https://bugs.webkit.org/show_bug.cgi?id=125479

Patch by Martin Hodovan <mhodovan@partner.samsung.com> on 2014-06-10
Reviewed by Gyuyoung Kim.

Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
and László Langó <llango.u-szeged@partner.samsung.com>.

* ImageDiff/CMakeLists.txt:
* MiniBrowser/efl/CMakeLists.txt:
* efl/install-dependencies:
* efl/jhbuild.modules:
* efl/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: iOS: Return the language for attributed text marker queries
cfleizach@apple.com [Wed, 11 Jun 2014 01:04:06 +0000 (01:04 +0000)]
AX: iOS: Return the language for attributed text marker queries
https://bugs.webkit.org/show_bug.cgi?id=133682

Reviewed by Mario Sanchez Prada.

Add language to the list of objects being returned for attributed text.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AXAttributeStringSetLanguage):
(AXAttributedStringAppendText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoold-run-webkit-tests: Create CoreSimulator device on demand and find it by name
dfarler@apple.com [Wed, 11 Jun 2014 00:06:17 +0000 (00:06 +0000)]
old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
https://bugs.webkit.org/show_bug.cgi?id=133663

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(installAndLaunchDumpToolAppUsingNotification):
- Remove obsolete notification keys
- Key off of mandatory device UDID (a UUID)
- Create a device on demand via CoreSimulator if necessary
-- Grab the UDID from the created device plist.
* Scripts/webkitdirs.pm:
(iOSSimulatorDevicesPath): Added
(iOSSimulatorDevices): Added
(createiOSSimulatorDevice): Added
(deleteiOSSimulatorDevice): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/WebCore: WebCore part of [Cocoa] Handling authentication challenges should...
mitz@apple.com [Wed, 11 Jun 2014 00:01:18 +0000 (00:01 +0000)]
Source/WebCore: WebCore part of [Cocoa] Handling authentication challenges should not require multiple delegate methods
https://bugs.webkit.org/show_bug.cgi?id=133697

Reviewed by Anders Carlsson.

* platform/network/AuthenticationClient.h: Declared new virtual member functions for
requesting default handling of a challenge and rejecting a challenge.
* platform/network/ResourceHandle.h: Override new AuthenticationClient functions.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::receivedRequestToPerformDefaultHandling): Added. Calls
CFURLConnectionPerformDefaultHandlingForChallenge.
(WebCore::ResourceHandle::receivedChallengeRejection): Added. Calls
CFURLConnectionRejectChallenge.
* platform/network/cf/SocketStreamHandle.h: Override new AuthenticationClient functions.
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::receivedRequestToPerformDefaultHandling): Added empty
override.
(WebCore::SocketStreamHandle::receivedChallengeRejection): Ditto.

Source/WebKit2: WebKit2 part of [Cocoa] Handling authentication challenges should not require multiple delegate methods
https://bugs.webkit.org/show_bug.cgi?id=133697

Reviewed by Anders Carlsson.

* Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::performDefaultHandling): Added. Calls the new
AuthenticationClient function receivedRequestToPerformDefaultHandling.
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue): Added. Calls the new
AuthenticationClient function receivedChallengeRejection.
* Shared/Authentication/AuthenticationManager.h:
* Shared/Authentication/AuthenticationManager.messages.in: Added new messages
PerformDefaultHandling and RejectProtectionSpaceAndContinue.

* Shared/Downloads/DownloadAuthenticationClient.h: Override new AuthenticationClient member
functions.

* Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::receivedRequestToPerformDefaultHandling): Added empty implementation.
(WebKit::Download::receivedChallengeRejection): Ditto.

* Shared/Downloads/mac/DownloadMac.mm:
(WebKit::Download::receivedRequestToPerformDefaultHandling): Added. Forwards to the sender.
(WebKit::Download::receivedChallengeRejection): Ditto.

* UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:
(checkChallenge): Factored out a bit of code into this helper function.
(-[WKNSURLAuthenticationChallengeSender cancelAuthenticationChallenge:]): Use new helper.
(-[WKNSURLAuthenticationChallengeSender continueWithoutCredentialForAuthenticationChallenge:]):
Ditto.
(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]): Ditto.
(-[WKNSURLAuthenticationChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
Implemented this optional NSURLAuthenticationChallengeSender protocol method by forwarding
to the decision listener.
(-[WKNSURLAuthenticationChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):
Ditto.

* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method.

* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::performDefaultHandling): Added. Sends a message to
the authentication manager.
(WebKit::AuthenticationChallengeProxy::rejectProtectionSpaceAndContinue): Ditto.
* UIProcess/Authentication/AuthenticationChallengeProxy.h:

* UIProcess/Authentication/AuthenticationDecisionListener.cpp:
(WebKit::AuthenticationDecisionListener::performDefaultHandling): Added. Forwards to the
authentication challenge proxy.
(WebKit::AuthenticationDecisionListener::rejectProtectionSpaceAndContinue): Ditto.
* UIProcess/Authentication/AuthenticationDecisionListener.h:

* UIProcess/Cocoa/NavigationState.h: Added flag in m_navigationDelegateMethods struct.
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate): Initialize
webViewWillSendRequestForAuthenticationChallenge flag in the delegate methods struct.
(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): If
the delegate implements -_webView:willSendRequestForAuthenticationChallenge:, return true
here; the delegate will respond with -rejectProtectionSpaceAndContinueWithChallenge: if
it cannot authenticate.
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): If the
delegate implements -_webView:willSendRequestForAuthenticationChallenge:, send that message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r167962): Out of bounds read in JSC::StructureIDTable::get()
bfulgham@apple.com [Tue, 10 Jun 2014 23:30:43 +0000 (23:30 +0000)]
REGRESSION (r167962): Out of bounds read in JSC::StructureIDTable::get()
https://bugs.webkit.org/show_bug.cgi?id=133463
<rdar://problem/17098100>

Reviewed by Geoffrey Garen.

Revise MediaControllerHost implementation so that instead of holding its
own pointer to the JS Controller object, it uses new properties added to
the internal media controls DOM hierarchy. This allows the GC to see the
needed lifecycle of the various media control objects and avoids the
premature deallocation that caused this bug.

* Modules/mediacontrols/MediaControlsHost.h:
(WebCore::MediaControlsHost::controllerJSValue): Deleted.
(WebCore::MediaControlsHost::setControllerJSValue): Deleted.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::controllerJSValue): Added convenience function
to share logic for retrieving the controller object.
(WebCore::HTMLMediaElement::updateCaptionContainer): Revise to use new method
for accessing the controller.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Connect the media
elements JS wrapper object to the MediaControlsHost JS wrapper. Then connect
the MediaControlsHost JS wrapper to the Controller JS object.
(WebCore::HTMLMediaElement::pageScaleFactorChanged): Revise to use new method
for accessing the controller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJapanese text in Google search is rendered too low and clipped
mmaxfield@apple.com [Tue, 10 Jun 2014 23:23:46 +0000 (23:23 +0000)]
Japanese text in Google search is rendered too low and clipped
https://bugs.webkit.org/show_bug.cgi?id=133595

Reviewed by Simon Fraser.

This is a revert of r155324.

Source/WebCore:
By forcing line-height to be normal, r155324 was forcing WebKit to inspect font metrics
to determine the height of a line. This means that if a fallback font was required to
draw a line of text, and the fallback font had a higher ascent than the primary font,
the entire line of text would be pushed down. If we don't force line-height to be normal,
then we use the line-height value instead, which short circuits this mechanism, thereby
not pushing text down.

No new tests (because this is simply a revert)

* css/html.css:
(input): Deleted.

LayoutTests:
* fast/dom/HTMLInputElement/input-line-height-expected.txt: Removed.
* fast/dom/HTMLInputElement/input-line-height.html: Removed.
* fast/forms/placeholder-position-expected.txt:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.txt:
* platform/mac-mountainlion/fast/forms/placeholder-position-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r167937): Do not use effective zoom factor while resolving media query...
zalan@apple.com [Tue, 10 Jun 2014 23:13:20 +0000 (23:13 +0000)]
REGRESSION (r167937): Do not use effective zoom factor while resolving media query's min-, max-(device)width/height values.
https://bugs.webkit.org/show_bug.cgi?id=133681

Reviewed by Simon Fraser.

We lost the default multiplier(zoom) value of 1 with r167937 at template<typename T> T computeLength().
Now MediaQueryEvaluator takes the current page zoom factor into account while resolving min-, max- width values.

This patch explicitly sets the multiplier value to 1 to ensure zoom independent media query value resolving.

Source/WebCore:
Test: fast/media/media-query-with-scaled-content.html

* css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::viewportWidthFactor):
(WebCore::CSSToLengthConversionData::viewportHeightFactor):
* css/CSSToLengthConversionData.h:
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* testing/Internals.cpp:
(WebCore::Internals::setPageZoomFactor):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:
* fast/media/media-query-with-scaled-content-expected.html: Added.
* fast/media/media-query-with-scaled-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agohttps://bugs.webkit.org/show_bug.cgi?id=133694
simon.fraser@apple.com [Tue, 10 Jun 2014 22:47:02 +0000 (22:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=133694

Revert the part of r169733 that caused this test to start failing.

Source/WebCore:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):

LayoutTests:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFactor repeated CFRunLoopObserver code out
timothy_horton@apple.com [Tue, 10 Jun 2014 22:30:31 +0000 (22:30 +0000)]
Factor repeated CFRunLoopObserver code out
https://bugs.webkit.org/show_bug.cgi?id=133690

Reviewed by Simon Fraser.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/cf/RunLoopObserver.cpp: Added.
(WebCore::RunLoopObserver::create):
(WebCore::RunLoopObserver::~RunLoopObserver):
(WebCore::RunLoopObserver::runLoopObserverFired):
(WebCore::RunLoopObserver::schedule):
(WebCore::RunLoopObserver::invalidate):
* platform/cf/RunLoopObserver.h: Added.
(WebCore::RunLoopObserver::isScheduled):
(WebCore::RunLoopObserver::RunLoopObserver):
Factor CFRunLoopObserver management code out of LayerFlushScheduler and WebKit2.

* platform/graphics/ca/LayerFlushScheduler.h:
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::LayerFlushScheduler):
(WebCore::LayerFlushScheduler::~LayerFlushScheduler):
(WebCore::LayerFlushScheduler::layerFlushCallback):
(WebCore::LayerFlushScheduler::schedule):
(WebCore::LayerFlushScheduler::invalidate):
(WebCore::LayerFlushScheduler::runLoopObserverCallback): Deleted.
Make use of WebCore::RunLoopObserver.

* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::~RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::showDebugIndicator):
(WebKit::coreAnimationDidCommitLayersCallback): Deleted.
(WebKit::RemoteLayerTreeDrawingAreaProxy::scheduleCoreAnimationLayerCommitObserver): Deleted.
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers): Deleted.
Make use of WebCore::RunLoopObserver.

* WebView/WebViewData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoModernize loop code in scrolling tree code
simon.fraser@apple.com [Tue, 10 Jun 2014 22:14:46 +0000 (22:14 +0000)]
Modernize loop code in scrolling tree code
https://bugs.webkit.org/show_bug.cgi?id=133688

Reviewed by Anders Carlsson.

Use new loop syntax for walking children.

* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::cloneAndResetChildren):
(WebCore::ScrollingStateNode::removeChild):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):
(WebCore::ScrollingStateNode::dump):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::removeChild):
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse [ Pass Failure ] instead of [ Skip ] for the tests skipped in r169767.
aestes@apple.com [Tue, 10 Jun 2014 21:56:38 +0000 (21:56 +0000)]
Use [ Pass Failure ] instead of [ Skip ] for the tests skipped in r169767.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix availability declaration.
andersca@apple.com [Tue, 10 Jun 2014 21:41:04 +0000 (21:41 +0000)]
Fix availability declaration.

* UIProcess/API/Cocoa/WKError.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK][gtkdoc] remove -Wcast-align
vjaquez@igalia.com [Tue, 10 Jun 2014 21:40:03 +0000 (21:40 +0000)]
[GTK][gtkdoc] remove -Wcast-align
https://bugs.webkit.org/show_bug.cgi?id=133640

Apparently gcc warns that GParamSpec is not castable to
GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
though ARM hackers claim that those only need 4byte alignment. As long as gcc
behaves that way, this warning is not very useful, also they break the Debian
packaging.

This patch appends the compiler flag -Wno-align-cast for the gtkdoc
scanner compilation, thus the compiler ignores the previous
-Waling-cast flag.

Reviewed by Martin Robinson.

* gtk/generate-gtkdoc:
(get_generator_for_config):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (6/9/2014): Several TextTrackCue tests became very flaky
aestes@apple.com [Tue, 10 Jun 2014 21:36:53 +0000 (21:36 +0000)]
REGRESSION (6/9/2014): Several TextTrackCue tests became very flaky
https://bugs.webkit.org/show_bug.cgi?id=133686

* platform/mac/TestExpectations: Skipped the flaky tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAddress a comment about a comment.
andersca@apple.com [Tue, 10 Jun 2014 21:36:04 +0000 (21:36 +0000)]
Address a comment about a comment.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd -[WKWebView evaluateJavaScript:completionHandler:]
andersca@apple.com [Tue, 10 Jun 2014 21:25:54 +0000 (21:25 +0000)]
Add -[WKWebView evaluateJavaScript:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=133689
<rdar://problem/17152685>

Reviewed by Geoffrey Garen.

Source/WebCore:
* English.lproj/Localizable.strings:
Add new localizable strings.

Source/WebKit2:
* Shared/API/c/WKErrorRef.h:
Remove WKErrorCode typedef from here.

* UIProcess/API/C/WKPageLoaderClient.h:
Use uint32_t instead of WKErrorCode.

* UIProcess/API/Cocoa/WKError.h:
(NS_ENUM):
Add a WKErrorDomain and a WKErrorCode enum.

* UIProcess/API/Cocoa/WKError.mm:
(localizedDescriptionForErrorCode):
Helper that returns the localized description given an error code.

(createNSError):
Helper that creates an NSError with the correct localized description given an error code.

* UIProcess/API/Cocoa/WKErrorInternal.h:
Add helpers.

* UIProcess/API/Cocoa/WKWebView.h:
Add evaluateJavaScript:completionHandler: method.

* UIProcess/API/Cocoa/WKWebView.mm:
(callbackErrorCode):
Helper that returns a WKErrorCode from a WebKit::CallbackBase::Error enum.

(-[WKWebView evaluateJavaScript:completionHandler:]):
Run the JavaScript code and handle all the error cases.

(-[WKWebView _runJavaScriptInMainFrame:]):
Reimplement this using the API method.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] http/tests/navigation/new-window-redirect-history.html crashes
ap@apple.com [Tue, 10 Jun 2014 21:20:19 +0000 (21:20 +0000)]
[WK2] http/tests/navigation/new-window-redirect-history.html crashes
https://bugs.webkit.org/show_bug.cgi?id=127683

* platform/wk2/TestExpectations: Changed expectation from Crash to Skip, because
it crashes every time, and generating more crash logs only makes other tests more
flaky without providing useful information.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't call Connection::terminateSoon if the connection is null
andersca@apple.com [Tue, 10 Jun 2014 20:56:15 +0000 (20:56 +0000)]
Don't call Connection::terminateSoon if the connection is null
https://bugs.webkit.org/show_bug.cgi?id=133695
<rdar://problem/17069024>

Reviewed by Tim Horton.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::removeWebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSkip some more flaky tests.
ap@apple.com [Tue, 10 Jun 2014 20:54:42 +0000 (20:54 +0000)]
Skip some more flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=133696
<rdar://problem/17257097>

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r169733): compositing/iframes/become-composited-nested-iframes.html fails...
aestes@apple.com [Tue, 10 Jun 2014 20:47:03 +0000 (20:47 +0000)]
REGRESSION (r169733): compositing/iframes/become-composited-nested-iframes.html fails on WebKit1 bots
https://bugs.webkit.org/show_bug.cgi?id=133694

* platform/mac/TestExpectations: Marked the test as failing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agofast/dom/beforeload/remove-frame-in-beforeload-listener.html and related tests are...
ap@apple.com [Tue, 10 Jun 2014 20:41:50 +0000 (20:41 +0000)]
fast/dom/beforeload/remove-frame-in-beforeload-listener.html and related tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=133685

* platform/wk2/TestExpectations: Skipped more affected tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd process entitlements
oliver@apple.com [Tue, 10 Jun 2014 20:33:00 +0000 (20:33 +0000)]
Add process entitlements
https://bugs.webkit.org/show_bug.cgi?id=133693

Reviewed by Alexey Proskuryakov.

Add entitlements description for Database process, and
ensure that we reference the correct seatbelt profiles.

* Configurations/DatabaseService.Development.xcconfig:
* Configurations/DatabaseService.xcconfig:
* Configurations/Databases-iOS.entitlements:
* Configurations/Network-iOS.entitlements:
* Configurations/WebContent-iOS.entitlements:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAssertion failure at JSC::Structure::checkOffsetConsistency() const + 234.
mark.lam@apple.com [Tue, 10 Jun 2014 20:29:29 +0000 (20:29 +0000)]
Assertion failure at JSC::Structure::checkOffsetConsistency() const + 234.
<https://webkit.org/b/133356>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:
The root cause of this issue is that a nonPropertyTransition can transition
a pinned dictionary structure to an unpinned dictionary structure.  The new
structure will get a copy of the property table from the original structure.
However, when a GC occurs, the property table in the new structure will be
cleared because it is unpinned.  This leads to complications in subsequent
derivative structures when flattening occurs, which eventually leads to the
assertion failure in this bug.

The fix is to ensure that the new dictionary structure generated by the
nonPropertyTransition will have a copy of its predecessor's property table
and is pinned.

* runtime/Structure.cpp:
(JSC::Structure::nonPropertyTransition):

LayoutTests:
* TestExpectations:
- Undoing expectation for js/primitive-property-access-edge-cases.html now
  that the bug is fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix crashes on some plug-in tests.
ap@apple.com [Tue, 10 Jun 2014 20:00:14 +0000 (20:00 +0000)]
Fix crashes on some plug-in tests.
https://bugs.webkit.org/show_bug.cgi?id=133691
<rdar://problem/17255836>

Reviewed by Anders Carlsson.

* PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize):
Cannot use TemporaryChange here, because the object may go away before stack unwinds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoplatform/mac-wk2/plugins/destroy-during-async-npp-new.html is flaky
ap@apple.com [Tue, 10 Jun 2014 19:56:03 +0000 (19:56 +0000)]
platform/mac-wk2/plugins/destroy-during-async-npp-new.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=133692

* platform/mac-wk2/TestExpectations: Skipped the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSerialize ResourceRequests without platform request
antti@apple.com [Tue, 10 Jun 2014 19:07:47 +0000 (19:07 +0000)]
Serialize ResourceRequests without platform request
https://bugs.webkit.org/show_bug.cgi?id=133679

Reviewed by Alexey Proskuryakov.

Source/WebCore:
We create platform requests in the web process just so we can serialize them. This is unnecessary work.

* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::encodingRequiresPlatformData):
(WebCore::ResourceRequestBase::encodeWithoutPlatformData):
(WebCore::ResourceRequestBase::decodeWithoutPlatformData):

    Add encoding and decoding functions here to avoid exposing internals.

* platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::encodingRequiresPlatformData):

    Allow encoding without platform data if it hasn't been created yet and there is no request body.

Source/WebKit2:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceRequest>::decode):

    Encode ResourceRequest directly if possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: recording is overused as both noun and verb in TimelineManager
burg@cs.washington.edu [Tue, 10 Jun 2014 18:47:01 +0000 (18:47 +0000)]
Web Inspector: recording is overused as both noun and verb in TimelineManager
https://bugs.webkit.org/show_bug.cgi?id=132878

Reviewed by Joseph Pecoraro.

Rename most uses of the verb 'recording' to the verb 'capturing' for timelines.
Rename getter for the recording to activeRecording, and recordingEnabled to isCapturing().

When the timeline manager can handle multiple timeline data sets (i.e., 'recordings'),
it will be very confusing to have 'recording' as a plural noun and verb in the model.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.get activeRecording):
(WebInspector.TimelineManager.prototype.isCapturing):
(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.stopCapturing):
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype._addRecord):
(WebInspector.TimelineManager.prototype._startAutoCapturing):
(WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
(WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
(WebInspector.TimelineManager.prototype._mainResourceDidChange):
(WebInspector.TimelineManager.prototype._resourceWasAdded):
(WebInspector.TimelineManager.prototype.get recording): Deleted.
(WebInspector.TimelineManager.prototype.get recordingEnabled): Deleted.
(WebInspector.TimelineManager.prototype.startRecording): Deleted.
(WebInspector.TimelineManager.prototype.stopRecording): Deleted.
(WebInspector.TimelineManager.prototype._startAutoRecording): Deleted.
* UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard):
(WebInspector.DefaultDashboard.prototype._mainResourceDidChange):
(WebInspector.DefaultDashboard.prototype._capturingStopped):
(WebInspector.DefaultDashboard.prototype._recordingStopped): Deleted.
* UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
* UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._capturingStarted):
(WebInspector.TimelineContentView.prototype._capturingStopped):
(WebInspector.TimelineContentView.prototype._recordingStarted): Deleted.
(WebInspector.TimelineContentView.prototype._recordingStopped): Deleted.
* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.initialize):
(WebInspector.TimelineSidebarPanel.prototype._capturingStarted):
(WebInspector.TimelineSidebarPanel.prototype._capturingStopped):
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOver):
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphMousedOut):
(WebInspector.TimelineSidebarPanel.prototype._recordGlyphClicked):
(WebInspector.TimelineSidebarPanel.prototype._replayCaptureButtonClicked):
(WebInspector.TimelineSidebarPanel.prototype._recordingStarted): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._recordingStopped): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agofast/dom/beforeload/remove-frame-in-beforeload-listener.html is flaky
ap@apple.com [Tue, 10 Jun 2014 18:03:25 +0000 (18:03 +0000)]
fast/dom/beforeload/remove-frame-in-beforeload-listener.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=133685

* platform/wk2/TestExpectations: Skipped the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169752 268f45cc-cd09-0410-ab3c-d52691b4dbfc