WebKit-https.git
11 years ago2009-03-16 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 17 Mar 2009 00:10:25 +0000 (00:10 +0000)]
2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/6642742> Top Sites malfunction when switching text zoom mode

        * page/Frame.cpp:
        (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is
        currently showing a non-HTML view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip a test that is currently crashing.
mrowe@apple.com [Mon, 16 Mar 2009 23:55:09 +0000 (23:55 +0000)]
Skip a test that is currently crashing.

Rubber-stamped by Beth Dakin.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate test results for six accessibility tests.
mrowe@apple.com [Mon, 16 Mar 2009 23:55:06 +0000 (23:55 +0000)]
Update test results for six accessibility tests.

Rubber-stamped by Beth Dakin.

* platform/mac/accessibility/lists-expected.txt:
* platform/mac/accessibility/table-attributes-expected.txt:
* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/accessibility/table-sections-expected.txt:
* platform/mac/accessibility/table-with-aria-role-expected.txt:
* platform/mac/accessibility/table-with-rules-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove platform-specific acessibility tests and results into platform/mac.
mrowe@apple.com [Mon, 16 Mar 2009 23:55:00 +0000 (23:55 +0000)]
Move platform-specific acessibility tests and results into platform/mac.

Rubber-stamped by Beth Dakin.

* platform/mac/accessibility/accesskey-expected.txt: Renamed from LayoutTests/accessibility/accesskey-expected.txt.
* platform/mac/accessibility/accesskey.html: Renamed from LayoutTests/accessibility/accesskey.html.
* platform/mac/accessibility/aria-describedby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-describedby-on-input-expected.txt.
* platform/mac/accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-on-input-expected.txt.
* platform/mac/accessibility/aria-range-expected.txt: Renamed from LayoutTests/accessibility/aria-range-expected.txt.
* platform/mac/accessibility/aria-range-value-expected.txt: Renamed from LayoutTests/accessibility/aria-range-value-expected.txt.
* platform/mac/accessibility/aria-range-value.html: Renamed from LayoutTests/accessibility/aria-range-value.html.
* platform/mac/accessibility/aria-range.html: Renamed from LayoutTests/accessibility/aria-range.html.
* platform/mac/accessibility/aria-roles-expected.txt: Renamed from LayoutTests/accessibility/aria-roles-expected.txt.
* platform/mac/accessibility/aria-slider-expected.txt: Renamed from LayoutTests/accessibility/aria-slider-expected.txt.
* platform/mac/accessibility/aria-slider.html: Renamed from LayoutTests/accessibility/aria-slider.html.
* platform/mac/accessibility/aria-spinbutton-expected.txt: Renamed from LayoutTests/accessibility/aria-spinbutton-expected.txt.
* platform/mac/accessibility/aria-spinbutton.html: Renamed from LayoutTests/accessibility/aria-spinbutton.html.
* platform/mac/accessibility/bounds-for-range-expected.txt: Renamed from LayoutTests/accessibility/bounds-for-range-expected.txt.
* platform/mac/accessibility/bounds-for-range.html: Renamed from LayoutTests/accessibility/bounds-for-range.html.
* platform/mac/accessibility/content-editable-expected.txt: Renamed from LayoutTests/accessibility/content-editable-expected.txt.
* platform/mac/accessibility/content-editable.html: Renamed from LayoutTests/accessibility/content-editable.html.
* platform/mac/accessibility/document-attributes-expected.txt: Renamed from LayoutTests/accessibility/document-attributes-expected.txt.
* platform/mac/accessibility/document-attributes.html: Renamed from LayoutTests/accessibility/document-attributes.html.
* platform/mac/accessibility/document-links-expected.txt: Renamed from LayoutTests/accessibility/document-links-expected.txt.
* platform/mac/accessibility/document-links.html: Renamed from LayoutTests/accessibility/document-links.html.
* platform/mac/accessibility/double-title-expected.txt: Renamed from LayoutTests/accessibility/double-title-expected.txt.
* platform/mac/accessibility/double-title.html: Renamed from LayoutTests/accessibility/double-title.html.
* platform/mac/accessibility/frame-with-title-expected.txt: Renamed from LayoutTests/accessibility/frame-with-title-expected.txt.
* platform/mac/accessibility/frame-with-title.html: Renamed from LayoutTests/accessibility/frame-with-title.html.
* platform/mac/accessibility/image-map1-expected.txt: Renamed from LayoutTests/accessibility/image-map1-expected.txt.
* platform/mac/accessibility/image-map2-expected.txt: Renamed from LayoutTests/accessibility/image-map2-expected.txt.
* platform/mac/accessibility/input-image-url-expected.txt: Renamed from LayoutTests/accessibility/input-image-url-expected.txt.
* platform/mac/accessibility/input-image-url.html: Renamed from LayoutTests/accessibility/input-image-url.html.
* platform/mac/accessibility/internal-link-anchors-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors-expected.txt.
* platform/mac/accessibility/internal-link-anchors.html: Renamed from LayoutTests/accessibility/internal-link-anchors.html.
* platform/mac/accessibility/internal-link-anchors2-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors2-expected.txt.
* platform/mac/accessibility/legend-expected.txt: Renamed from LayoutTests/accessibility/legend-expected.txt.
* platform/mac/accessibility/plugin-expected.txt: Renamed from LayoutTests/accessibility/plugin-expected.txt.
* platform/mac/accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/radio-button-group-members-expected.txt.
* platform/mac/accessibility/resources/cake.png: Copied from LayoutTests/accessibility/resources/cake.png.
* platform/mac/accessibility/resources/test.swf: Renamed from LayoutTests/accessibility/resources/test.swf.
* platform/mac/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/accessibility/table-one-cell-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit:
darin@apple.com [Mon, 16 Mar 2009 23:30:18 +0000 (23:30 +0000)]
WebKit:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        * English.lproj/Localizable.strings: Updated.
        * StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/mac:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory contextMenuItemTagParagraphDirectionMenu]): Changed string here, but only
        post-Leopard, since we want this to match the Mac OS X menu on Tiger and Leopard.
        (-[WebViewFactory contextMenuItemTagSelectionDirectionMenu]): Changed string here.

WebKit/win:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

        For now, change only the localized strings, not the terminology in the code.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here.
        (WebCore::contextMenuItemTagTextDirectionMenu): And here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Mon, 16 Mar 2009 23:15:32 +0000 (23:15 +0000)]
WebCore:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24629: moving forward or backward a paragraph fails at edge of document
        https://bugs.webkit.org/show_bug.cgi?id=24629
        rdar://problem/6544413

        Test: editing/selection/move-paragraph-document-edges.html

        * editing/visible_units.cpp:
        (WebCore::previousParagraphPosition): Use the last result from
        previousLinePosition rather than going all the way back to what was originally
        passed in when we hit exception cases like null or not moving. This correctly
        inherits the behavior of previousLinePosition when we are in a paragraph at the
        edge of a document.
        (WebCore::nextParagraphPosition): Ditto.

LayoutTests:

2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24629: moving forward or backward a paragraph fails at edge of document
        https://bugs.webkit.org/show_bug.cgi?id=24629
        rdar://problem/6544413

        * editing/selection/move-paragraph-document-edges-expected.txt: Added.
        * editing/selection/move-paragraph-document-edges.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 16 Mar 2009 22:41:23 +0000 (22:41 +0000)]
2009-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
        https://bugs.webkit.org/show_bug.cgi?id=24619

        * rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
        * rendering/RenderView.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Mon, 16 Mar 2009 22:37:49 +0000 (22:37 +0000)]
2009-03-16  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Adam Roben.

        [gtk] API implementation: url and title
        http://bugs.webkit.org/show_bug.cgi?id=14807

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h: Implement "title" and "uri" properties as well
        as according functions. "uri" always reflects the current location
        including navigation inside the same page. title-changed is deprecated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Mon, 16 Mar 2009 22:19:56 +0000 (22:19 +0000)]
2009-03-16  Peter Kasting  <pkasting@google.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24368
        DOM scroll events should be based off the actual number of wheel
        ticks, not off the number of lines scrolled.  This matches IE.

        * dom/Node.cpp:
        (WebCore::Node::dispatchWheelEvent):
        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        * dom/WheelEvent.h:
        (WebCore::WheelEvent::create):
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::wheelTicksX):
        (WebCore::PlatformWheelEvent::wheelTicksY):
        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/qt/WheelEventQt.cpp:
        * platform/win/WheelEventWin.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/wx/MouseWheelEventWx.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 16 Mar 2009 22:07:28 +0000 (22:07 +0000)]
2009-03-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Clean up a few issues in the Animation code:

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine):
        Whitespace

        (WebCore::AnimationBase::willNeedService):
        Don't round to float, use std::max

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        Fix erroneously copied line to null out m_lastResponseWaiter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 Mar 2009 21:58:30 +0000 (21:58 +0000)]
2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Don't mig_deallocate random data in case an instance proxy method returns false.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        (WKPCInvokeDefault):
        (WKPCGetProperty):
        (WKPCEnumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 Mar 2009 21:49:59 +0000 (21:49 +0000)]
2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler and John Sullivan.

        When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
        Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.

        Instead, just zero out the member variable in invalidate.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (pluginInvalidate):
        (pluginDeallocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Mon, 16 Mar 2009 21:34:26 +0000 (21:34 +0000)]
WebCore:

2009-03-12  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=13632

        Overflow scrolling needs to account for the bottom/right padding on the object itself as well
        as for bottom/right margins on children.

        Existing tests cover this.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):

LayoutTests:

2009-03-16  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=13632

        Overflow scrolling needs to account for the bottom/right padding on the object itself as well
        as for bottom/right margins on children.

        * platform/mac/fast/body-propagation/overflow/002-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/002-expected.png:
        * platform/mac/fast/body-propagation/overflow/002-expected.txt:
        * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt:
        * platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
        * platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt:
        * platform/mac/fast/body-propagation/overflow/003-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/003-expected.png:
        * platform/mac/fast/body-propagation/overflow/003-expected.txt:
        * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt:
        * platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
        * platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt:
        * platform/mac/fast/body-propagation/overflow/004-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/004-expected.png:
        * platform/mac/fast/body-propagation/overflow/004-expected.txt:
        * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt:
        * platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
        * platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt:
        * platform/mac/fast/body-propagation/overflow/007-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/007-expected.png:
        * platform/mac/fast/body-propagation/overflow/007-expected.txt:
        * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
        * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
        * platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt:
        * platform/mac/fast/forms/basic-textareas-expected.txt:
        * platform/mac/fast/forms/input-disabled-color-expected.txt:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
        * platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
        * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
        * platform/mac/fast/overflow/003-expected.checksum:
        * platform/mac/fast/overflow/003-expected.png:
        * platform/mac/fast/overflow/003-expected.txt:
        * platform/mac/fast/overflow/004-expected.checksum:
        * platform/mac/fast/overflow/004-expected.png:
        * platform/mac/fast/overflow/007-expected.checksum:
        * platform/mac/fast/overflow/007-expected.png:
        * platform/mac/fast/overflow/007-expected.txt:
        * platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
        * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
        * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
        * platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt:
        * platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
        * platform/mac/fast/replaced/width100percent-textarea-expected.png:
        * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
        * platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Mon, 16 Mar 2009 21:19:16 +0000 (21:19 +0000)]
WebCore:

2009-03-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix for <rdar://problem/6320555>
        Add an upper limit for setting HTMLSelectElement.length.

        Test: fast/forms/select-max-length.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setOption):
        (WebCore::HTMLSelectElement::setLength):

LayoutTests:

2009-03-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Test for <rdar://problem/6320555>
        Add an upper limit for setting HTMLSelectElement.length.

        * fast/forms/select-max-length-expected.txt: Added.
        * fast/forms/select-max-length.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
eric@webkit.org [Mon, 16 Mar 2009 20:56:55 +0000 (20:56 +0000)]
    Reviewed by Sam Weinig.

        REGRESSION: undo-iframe-location-change.html is failing on the buildbots
        https://bugs.webkit.org/show_bug.cgi?id=24626

        Added a call to [[webview undoManager] removeAllActions]
        to make sure anything left on the undo stack after one test
        will not affect any later test.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 Mar 2009 20:09:02 +0000 (20:09 +0000)]
2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6633944>
        REGRESSION (Safari 4 PB): Many crashes in Flip4Mac involving loading the plugin

        Defer loading while calling webPlugInInitialize since it can end up spinning the run loop.

        * Plugins/WebPluginController.mm:
        (-[WebPluginController addPlugin:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add IWebFramePrivate::isDisplayingStandaloneImage
aroben@apple.com [Mon, 16 Mar 2009 20:03:41 +0000 (20:03 +0000)]
    Add IWebFramePrivate::isDisplayingStandaloneImage

        This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
        uses.

        Reviewed by Darin Adler.

        * Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.

        * WebFrame.cpp:
        (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our
        Document is an image document.

        * WebFrame.h: Added isDisplayingStandaloneImage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 16 Mar 2009 19:56:13 +0000 (19:56 +0000)]
2009-03-16  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6686721> Media document crash in 64-bit WebKit

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when
        rendering inline with old versions of QuickTime, so don't look for it when we are in a
        media document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Pamela Greene <pam@chromium.org>
pam@chromium.org [Mon, 16 Mar 2009 19:55:39 +0000 (19:55 +0000)]
2009-03-16  Pamela Greene  <pam@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove test dependency on precise window location and size. It's not
        clear to me why these vary, but they're not what the test is checking,
        so it need not depend on them in any case.
        https://bugs.webkit.org/show_bug.cgi?id=24170

        * fast/dom/Window/window-lookup-precedence-expected.txt:
        * fast/dom/Window/window-lookup-precedence.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 Mar 2009 18:54:33 +0000 (18:54 +0000)]
2009-03-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fix <rdar://problem/6622601>

        Make sure to update both the window frame and the plug-in frame.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView addWindowObservers]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 16 Mar 2009 16:47:10 +0000 (16:47 +0000)]
2009-03-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24590
        Refactor InspectorDOMStorageResource to use ScriptFunctionCall.

        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
        * bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
        * bindings/js/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject): Added Storage helper.
        * bindings/js/ScriptObjectQuarantine.h: Ditto.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects): Changed to use bind method.
        (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method.
        (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
        * inspector/InspectorController.h: Removed add/remove methods for DOM storage.
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
        (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added.
        (WebCore::InspectorDOMStorageResource::bind): Added.
        (WebCore::InspectorDOMStorageResource::unbind): Added.
        * inspector/InspectorDOMStorageResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-16 Mike Belshe <mike@belse.com>
dglazkov@chromium.org [Mon, 16 Mar 2009 16:13:03 +0000 (16:13 +0000)]
2009-03-16   Mike Belshe  <mike@belse.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24580
        Fix query() to match KURL behavior, this time with the code that
        compiles.

        * platform/KURLGoogle.cpp:
        (WebCore::KURL::query): Fix copy/paste mistake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 16 Mar 2009 07:39:17 +0000 (07:39 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=21752
        REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it

        Test: fast/dom/Window/window-early-properties-xhr.html

        For some transitions, the Window object is not replaced, but Document is. When this happened,
        window.document property was updated, but references to Document kept in cached constructors
        were not.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        (WebCore::JSAudioConstructor::document):
        (WebCore::JSAudioConstructor::mark):
        * bindings/js/JSAudioConstructor.h:
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        (WebCore::JSImageConstructor::document):
        (WebCore::JSImageConstructor::mark):
        * bindings/js/JSImageConstructor.h:
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
        (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
        (WebCore::JSMessageChannelConstructor::mark):
        * bindings/js/JSMessageChannelConstructor.h:
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        (WebCore::JSOptionConstructor::document):
        (WebCore::JSOptionConstructor::mark):
        * bindings/js/JSOptionConstructor.h:
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
        (WebCore::JSXMLHttpRequestConstructor::mark):
        * bindings/js/JSXMLHttpRequestConstructor.h:
        Changed cached constructors to keep a reference to Window, not Document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 16 Mar 2009 07:12:01 +0000 (07:12 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24549
        Impose a limit on Access-Control-Max-Age value

        * loader/CrossOriginPreflightResultCache.cpp:
        (WebCore::CrossOriginPreflightResultCacheItem::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 16 Mar 2009 02:04:03 +0000 (02:04 +0000)]
2009-03-15  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by David Kilzer.

        <rdar://problem/6668875> Normalize Geolocation results

        * platform/mac/GeolocationServiceMac.mm:
        (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 16 Mar 2009 01:02:51 +0000 (01:02 +0000)]
2009-03-15  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by David Kilzer.

        Update ::toString format as suggested by Darin Adler.

        * page/Geoposition.cpp:
        (WebCore::Geoposition::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 16 Mar 2009 00:31:04 +0000 (00:31 +0000)]
2009-03-15  Simon Fraser  <simon.fraser@apple.com>

        Revert r41718 because it broke DumpRenderTree on Tiger.

        * JavaScriptCorePrefix.h:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6668238> WebCore is registering text encodings needlessly...
ddkilzer@apple.com [Sun, 15 Mar 2009 23:55:42 +0000 (23:55 +0000)]
    <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

        Reviewed by Darin Adler.

        Yet another case where we would trigger extended encoding loading needlessly.

        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::encodingForFormSubmission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 15 Mar 2009 23:41:32 +0000 (23:41 +0000)]
2009-03-15  Simon Fraser  <simon.fraser@apple.com>

        Build fix: no review.

        * rendering/style/ContentData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 24542: Improve ContentData encapsulation
ddkilzer@apple.com [Sun, 15 Mar 2009 23:32:57 +0000 (23:32 +0000)]
    Bug 24542: Improve ContentData encapsulation

        <https://bugs.webkit.org/show_bug.cgi?id=24542>

        Reviewed by Simon Fraser.

        No tests since there is no change in behavior.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject): Used getter methods
        instead of data members on ContentData class.  Used isImage()
        convenience method.
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.

        * rendering/style/ContentData.cpp:
        (WebCore::ContentData::clear): Extracted code into
        deleteContent() method.
        (WebCore::ContentData::dataEquivalent): Added.  Extracted code
        from StyleRareNonInheritedData::contentDataEquivalent().
        (WebCore::ContentData::deleteContent): Added.  Used by setter
        methods.
        * rendering/style/ContentData.h: Made m_type, m_content and
        m_next private.
        (WebCore::ContentData::isCounter): Added.
        (WebCore::ContentData::isImage): Added.
        (WebCore::ContentData::isNone): Added.
        (WebCore::ContentData::isText): Added.
        (WebCore::ContentData::type): Added.
        (WebCore::ContentData::dataEquivalent): Added.
        (WebCore::ContentData::image): Added.
        (WebCore::ContentData::setImage): Added.
        (WebCore::ContentData::text): Added.
        (WebCore::ContentData::setText): Added.
        (WebCore::ContentData::counter): Added.
        (WebCore::ContentData::setCounter): Added.
        (WebCore::ContentData::next): Added.
        (WebCore::ContentData::setNext): Added.

        * rendering/style/CounterContent.h:
        (WebCore::operator!=): Removed.
        (WebCore::operator==): Renamed operator!=() and reversed its
        logic after extracting code from
        StyleRareNonInheritedData::contentDataEquivalent() to create
        ContentData::dataEquivalent().

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setContent): Used new getters and setters
        on ContentData class.  Changed first argument from a StringImpl*
        to a PassRefPtr<StrimgImpl>.  Used isText() convenience method.
        * rendering/style/RenderStyle.h:
        (WebCore::RenderStyle::setContent): Updated declaration.
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::contentDataEquivalent):
        Extracted most logic in while() loop into
        ContentData::dataEquivalent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 15 Mar 2009 22:26:38 +0000 (22:26 +0000)]
2009-03-15  Xan Lopez  <xlopez@igalia.com>

        Bump version to 1.1.3 for release and fix soversion
        calculation (oops). Thanks to Frederik Himpe for pointing this
        out.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 15 Mar 2009 20:15:23 +0000 (20:15 +0000)]
2009-03-15  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Mark Rowe.

        * config.ini: fix my blog's feed address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 15 Mar 2009 17:40:54 +0000 (17:40 +0000)]
2009-03-15  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Anders Carlsson.

        Fix default policy decision to be ignore, on MIME checks, if
        WebKit doesn't know how to handle the MIME type. The documentation
        is already correct, and this was an oversight when the policy
        decision code was first committed. Since 1.1.2 will be the first
        release to support download, there is no practical change in
        behavior.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 15 Mar 2009 17:40:33 +0000 (17:40 +0000)]
2009-03-15  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=24602
        [Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

        Reintroduce the URI into the soup message after having set it in
        the KURL, on redirects, to make sure it is properly encoded. This
        fixes bad request problems when servers give bad URIs on their
        response's Location header.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNon-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
kevino@webkit.org [Sun, 15 Mar 2009 17:23:06 +0000 (17:23 +0000)]
Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
Platform.h so that they're defined for all ports building on Mac, and tweak
the definitions of those macros based on Mark Rowe's suggestions to accomodate
cases where the values may not be <= to the .0 release for that version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 15 Mar 2009 15:30:38 +0000 (15:30 +0000)]
2009-03-15  Xan Lopez  <xlopez@igalia.com>

        Bump version and libtool version for release.

        * configure.ac:

WebKit/gtk:

2009-03-15  Xan Lopez  <xlopez@igalia.com>

        * NEWS: update for 1.1.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCommitting LayoutTests/editing/selection/5354455-2.html that was supposed to be in...
ap@webkit.org [Sun, 15 Mar 2009 11:26:42 +0000 (11:26 +0000)]
Committing LayoutTests/editing/selection/5354455-2.html that was supposed to be in previous check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Sun, 15 Mar 2009 09:22:07 +0000 (09:22 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19737
        No cursor and paste not enabled right clicking text field/area

        Test: fast/events/right-click-focus.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::handleMousePressEvent):
        Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Suggested by Mark Rowe.
ap@webkit.org [Sun, 15 Mar 2009 08:56:11 +0000 (08:56 +0000)]
    Suggested by Mark Rowe.

        Move results for security/block-test.html to their correct locations. Results for other
        platforms will need to be generated.

        * platform/mac-leopard/security/block-test-expected.txt: Removed.
        * platform/mac-tiger/security: Added.
        * platform/mac-tiger/security/block-test-expected.txt: Copied from LayoutTests/security/block-test-expected.txt.
        * platform/mac/security: Added.
        * platform/mac/security/block-test-expected.txt: Copied from LayoutTests/platform/mac-leopard/security/block-test-expected.txt.
        * security/block-test-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adele Peterson.
ap@webkit.org [Sun, 15 Mar 2009 08:42:57 +0000 (08:42 +0000)]
    Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=23949
        HTMLSelectElement is in inconsistent state when handling mutation events

        Test: fast/forms/mutation-event-recalc.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::appendChild):
        Call childrenChanged() before dispatching modification events, not after.

        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::insertBefore):
        (WebCore::HTMLOptGroupElement::replaceChild):
        (WebCore::HTMLOptGroupElement::removeChild):
        (WebCore::HTMLOptGroupElement::appendChild):
        (WebCore::HTMLOptGroupElement::removeChildren):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::add):
        (WebCore::HTMLSelectElement::remove):
        (WebCore::HTMLSelectElement::insertBefore):
        (WebCore::HTMLSelectElement::replaceChild):
        (WebCore::HTMLSelectElement::removeChild):
        (WebCore::HTMLSelectElement::appendChild):
        (WebCore::HTMLSelectElement::removeChildren):
        Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events
        were already dispatched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adele Peterson.
mitz@apple.com [Sun, 15 Mar 2009 08:23:28 +0000 (08:23 +0000)]
    Reviewed by Adele Peterson.

        - fix <rdar://problem/6607773> WebKit should support the "Default"
          paragraph writing direction -- or at least validate the menu item
          appropriately

        Made WebHTMLView validate user interface items with the selector
        -makeBaseWritingDirectionNatural: by returning NO and, if the item is
        a menu item, setting its state to "off".

        Strictly speaking, since -makeBaseWritingDirectionNatural: is never
        valid for WebViews, WebHTMLView should not need to respond to it and
        validate it, however because other responders respond to all three
        -makeBaseWritingDirection*: messages and set the menu item state, having
        WebHTMLView do the same makes application developers' lives easier.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView makeBaseWritingDirectionNatural:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add svn:executable property to recently added cgi scripts.
ap@webkit.org [Sun, 15 Mar 2009 08:16:50 +0000 (08:16 +0000)]
    Add svn:executable property to recently added cgi scripts.

        * http/tests/xmlhttprequest/resources/access-control-basic-options-not-supported.cgi:
        * http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip two tests that are failing.
mrowe@apple.com [Sun, 15 Mar 2009 03:23:08 +0000 (03:23 +0000)]
Skip two tests that are failing.

Rubber-stamped by Dan Bernstein.

* platform/mac-snowleopard/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-14 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Sun, 15 Mar 2009 02:55:27 +0000 (02:55 +0000)]
2009-03-14  Greg Bolsinga  <bolsinga@apple.com>

        <rdar://problem/6683465>

        Geolocation has to be able to handle NULL Frames.

        Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-14 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Sun, 15 Mar 2009 01:58:43 +0000 (01:58 +0000)]
2009-03-14  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by David Kilzer.

        Geoposition::toString was missing the Coordinates after the update.

        * page/Geoposition.cpp:
        (WebCore::Geoposition::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 14 Mar 2009 23:44:22 +0000 (23:44 +0000)]
2009-03-14  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        [Gtk] Build fix - pass a Coordinate to Geoposition::create
        https://bugs.webkit.org/show_bug.cgi?id=24603

        Gtk build fix per r41650
        https://bugs.webkit.org/show_bug.cgi?id=24506
        Geolocation in Safari differs from the spec, no Coordinates attribute on Position

        Pass a Coordinate to Geoposition::create.

        * platform/gtk/GeolocationServiceGtk.cpp:
        (WebCore::GeolocationServiceGtk::updatePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 14 Mar 2009 23:14:53 +0000 (23:14 +0000)]
2009-03-14  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [GTK] use of confirm dialog (yes/no) causes segfault
        https://bugs.webkit.org/show_bug.cgi?id=20940

        Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
        OBJECT,STRING,POINTER

        * webkit/webkitwebview.cpp:
        * webkitmarshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-14 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 14 Mar 2009 22:02:03 +0000 (22:02 +0000)]
2009-03-14  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        Remove two now working tests from GTK's Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-14 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 14 Mar 2009 20:22:13 +0000 (20:22 +0000)]
2009-03-14  Xan Lopez  <xlopez@igalia.com>

        No review, build fix.

        Split clean rules to make distcheck pass.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout test results to accommodate slight changes in error messages in the...
mrowe@apple.com [Sat, 14 Mar 2009 12:50:49 +0000 (12:50 +0000)]
Update layout test results to accommodate slight changes in error messages in the latest version of libxml2.

Rubber-stamped by Oliver Hunt.

* fast/dom/getElementsByClassName/011-expected.txt:
* fast/parser/external-entities-expected.txt:
* platform/mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Copied from LayoutTests/fast/dom/getElementsByClassName/011-expected.txt.
* platform/mac-leopard/fast/invalid/missing-end-tag-expected.checksum: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.checksum.
* platform/mac-leopard/fast/invalid/missing-end-tag-expected.png: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.png.
* platform/mac-leopard/fast/invalid/missing-end-tag-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.txt.
* platform/mac-leopard/fast/parser/external-entities-expected.txt: Copied from LayoutTests/fast/parser/external-entities-expected.txt.
* platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.checksum: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum.
* platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png.
* platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt.
* platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.checksum: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum.
* platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
* platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
* platform/mac-leopard/svg/custom/junk-data-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.checksum.
* platform/mac-leopard/svg/custom/junk-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.png.
* platform/mac-leopard/svg/custom/junk-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.txt.
* platform/mac-leopard/svg/custom/missing-xlink-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.checksum.
* platform/mac-leopard/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
* platform/mac-leopard/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
* platform/mac-leopard/svg/hixie/error/012-expected.checksum: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.checksum.
* platform/mac-leopard/svg/hixie/error/012-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.png.
* platform/mac-leopard/svg/hixie/error/012-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.txt.
* platform/mac/fast/invalid/missing-end-tag-expected.checksum:
* platform/mac/fast/invalid/missing-end-tag-expected.png:
* platform/mac/fast/invalid/missing-end-tag-expected.txt:
* platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum:
* platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
* platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
* platform/mac/svg/custom/junk-data-expected.checksum:
* platform/mac/svg/custom/junk-data-expected.png:
* platform/mac/svg/custom/junk-data-expected.txt:
* platform/mac/svg/custom/missing-xlink-expected.checksum:
* platform/mac/svg/custom/missing-xlink-expected.png:
* platform/mac/svg/custom/missing-xlink-expected.txt:
* platform/mac/svg/hixie/error/012-expected.checksum:
* platform/mac/svg/hixie/error/012-expected.png:
* platform/mac/svg/hixie/error/012-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChange the layout test result search policy for Mac OS X to fit better with the idea of
mrowe@apple.com [Sat, 14 Mar 2009 12:19:47 +0000 (12:19 +0000)]
Change the layout test result search policy for Mac OS X to fit better with the idea of
newer OS versions improving on previous OS versions.

Reviewed by Dan Bernstein.

The results for the latest version of Mac OS X are placed in the "mac" directory.  The
results for older versions of Mac OS X are structured as a series of overlays.  When
running on Leopard, the results in "mac-leopard" are searched before those in "mac".
When running on Tiger, the results in "mac-tiger" are searched before those in
"mac-leopard" and "mac".

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Sat, 14 Mar 2009 12:02:27 +0000 (12:02 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24545
        Make cross-site XHR simple request definition match current spec draft

        Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html
               http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html

        * loader/CrossOriginAccessControl.cpp:
        (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language.
        (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those
        that could be sent via form submission.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Sat, 14 Mar 2009 11:56:10 +0000 (11:56 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=15172
        object fallback - empty string for first argument of setAttributeNS does not work like null

        https://bugs.webkit.org/show_bug.cgi?id=24548
        createElementNS("", name) should create an element in null namespace

        Tests: fast/dom/createElementNS-empty-namespace.html
               fast/dom/setAttributeNS-empty-namespace.html

        * dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
        Convert empty namespaces to null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 14 Mar 2009 11:54:40 +0000 (11:54 +0000)]
2009-03-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24591
        Add my blog to Planet WebKit

        Add my blog to the planet.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTake advantage of the ability of recent versions of Xcode to easily switch the active
mrowe@apple.com [Sat, 14 Mar 2009 06:17:34 +0000 (06:17 +0000)]
Take advantage of the ability of recent versions of Xcode to easily switch the active
architecture.

Rubber-stamped by Dan Bernstein.

* Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove rarely used Makefile targets from the Makefile.
mrowe@apple.com [Sat, 14 Mar 2009 06:17:21 +0000 (06:17 +0000)]
Remove rarely used Makefile targets from the Makefile.

There are many situations in which the targets don't work as expected,
and their primary use is addressed by having the build system default
to building the appropriate architecture.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove the --64-bit argument from scripts in favor of them detecting when 64-bit...
mrowe@apple.com [Sat, 14 Mar 2009 06:17:16 +0000 (06:17 +0000)]
Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.

Reviewed by Timothy Hatcher.

The scripts will automatically target 64-bit if the system and hardware support it.  This can be
overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
to make the override persistent.

* Scripts/build-webkit: Remove architecture-related code.
* Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
* Scripts/run-javascriptcore-tests: Remove architecture-related code.
* Scripts/run-safari: Ditto.
* Scripts/run-webkit-tests: Ditto.
* Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments.  The --32-bit argument will set the
architecture preference to the 32-bit architecture of the machine.  The --64-bit argument will remove any architecture
override that is in effect so that 64-bit support will be automatically detected.
* Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the
auto-detection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPrevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
mrowe@apple.com [Sat, 14 Mar 2009 06:17:08 +0000 (06:17 +0000)]
Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
switching between building in Xcode and via build-webkit.

Reviewed by David Kilzer.

build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
Derived Sources build settings.  When building in Xcode, this setting isn't present so
Xcode reruns the script build phases.  This results in a new version of TracingDtrace.h
being generated, and the files that include it being rebuilt.

* JavaScriptCore.xcodeproj/project.pbxproj:  Don't regenerate TracingDtrace.h if it is
already newer than the input file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 John Abd-El-Malek <jam@google.com>
dimich@chromium.org [Sat, 14 Mar 2009 00:53:28 +0000 (00:53 +0000)]
2009-03-13  John Abd-El-Malek  <jam@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24593
        Added requestorID so we can track the request to its WebView without using frame (which was removed).

        * platform/network/chromium/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::requestorID):
        (WebCore::ResourceRequest::setRequestorID):
        (WebCore::ResourceRequest::setTargetType):
        (WebCore::ResourceRequest::policyURL):
        (WebCore::ResourceRequest::setPolicyURL):
        (WebCore::ResourceRequest::requestorPid):
        (WebCore::ResourceRequest::setRequestorPid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Mike Belshe <mike@belshe.com>
dglazkov@chromium.org [Fri, 13 Mar 2009 23:07:24 +0000 (23:07 +0000)]
2009-03-13  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24561
        Add custom V8 bindings for HTMLElementCanvas, Location.

        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
        * bindings/v8/custom/V8LocationCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Stephen White <senorblanco@chromium.org>
eric@webkit.org [Fri, 13 Mar 2009 22:47:20 +0000 (22:47 +0000)]
2009-03-13  Stephen White  <senorblanco@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24584

        Fix transparent text rendering on Chromium.  FontChromiumWin
        was calling beginTransparencyLayer()/endTransparencyLayer(), with
        a TransparencyWin inside to do GDI ClearType rendering over an
        opaque background.  TransparencyWin does its special sauce
        in the destructor, but it was being called too late to be used
        correctly in the layer.  Put the special sauce into a new function,
        composite(), and call that explicitly instead.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::~TransparencyWin):
        (WebCore::TransparencyWin::composite):
        (WebCore::TransparencyWin::init):
        * platform/graphics/chromium/TransparencyWin.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Mike Belshe <mike@belshe.com>
dglazkov@chromium.org [Fri, 13 Mar 2009 22:46:44 +0000 (22:46 +0000)]
2009-03-13  Mike Belshe  <mike@belshe.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24562
        Add custom implementation for getCSSCanvasContext to V8 bindings.

        * bindings/v8/custom/V8DocumentCustom.cpp: Added new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Ojan Vafai <ojan@chromium.org>
eric@webkit.org [Fri, 13 Mar 2009 22:43:18 +0000 (22:43 +0000)]
2009-03-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Add tests for various types of textareas. Tests in both
        quirks and standards modes. Although only the standards
        modes tests fit in the pixel results.
        https://bugs.webkit.org/show_bug.cgi?id=24370

        * fast/forms/basic-textareas.html: Added.
        * platform/mac/fast/forms/basic-textareas-expected.checksum: Added.
        * platform/mac/fast/forms/basic-textareas-expected.png: Added.
        * platform/mac/fast/forms/basic-textareas-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Mike Belshe <mike@belse.com>
dglazkov@chromium.org [Fri, 13 Mar 2009 22:42:29 +0000 (22:42 +0000)]
2009-03-13  Mike Belshe  <mike@belse.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24580
        Fix query() to match KURL behavior.

        * platform/KURLGoogle.cpp:
        (WebCore::KURL::query): remove extra logic around question mark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 13 Mar 2009 22:32:47 +0000 (22:32 +0000)]
2009-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker and Geoffrey Garen.

        <rdar://problem/6590384>
        REGRESSION (Safari 3-4): Tiger-only Crash occurs at WebView hostWindow () after reloading a set of tabs then quitting

        When we're doing fast teardown, plug-in views can be destroyed from -[WebView dealloc]'s [super dealloc] call,
        and thus calling -[WebView hostWindow] will crash since _private is nil.

        * WebView/WebView.mm:
        (-[WebView hostWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can...
cfleizach@apple.com [Fri, 13 Mar 2009 22:20:51 +0000 (22:20 +0000)]
Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
https://bugs.webkit.org/show_bug.cgi?id=24474

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Jian Li <jianli@chromium.org>
dimich@chromium.org [Fri, 13 Mar 2009 22:00:09 +0000 (22:00 +0000)]
2009-03-13  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24589
        Upstream changes to V8 event listeners (Chromium r11133) in order to
        fix worker functionality break in Chromium.

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        (WebCore::V8AbstractEventListener::handleEvent):
        * bindings/v8/V8AbstractEventListener.h:
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Norbert Leser <norbert.leser@nokia.com>
dimich@chromium.org [Fri, 13 Mar 2009 21:52:19 +0000 (21:52 +0000)]
2009-03-13  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Darin Adler.

        Resolved name conflict with globally defined tzname in Symbian.
        Replaced with different name instead of using namespace qualifier
        (appeared to be less clumsy).

        * runtime/DateMath.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 13 Mar 2009 21:31:02 +0000 (21:31 +0000)]
2009-03-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24524
        Introduce ScriptObject and ScriptFunctionCall abstractions.

        * GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * bindings/js/ScriptFunctionCall.cpp: Added.
        * bindings/js/ScriptFunctionCall.h: Added.
        * bindings/js/ScriptObject.cpp: Added.
        * bindings/js/ScriptObject.h: Added.
        * bindings/js/ScriptObjectQuarantine.cpp: Added.
        * bindings/js/ScriptObjectQuarantine.h: Added.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind.
        (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind.
        (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
        * inspector/InspectorController.h: Removed addScriptDatabaseResource and
        removeScriptDatabaseResource declarations.
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        (WebCore::InspectorDatabaseResource::bind): Added.
        (WebCore::InspectorDatabaseResource::unbind): Added.
        * inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 13 Mar 2009 21:26:19 +0000 (21:26 +0000)]
2009-03-13  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24467
        Make Skia drawRect() and stroke behavior match CG.

        This makes drawRect() ignore the stroke width (like CG does), and
        adds a warning comment about that to the appropriate header.

        It also eliminates some hacky code in Skia's stroke preparation,
        which tried to adjust odd-width strokes to fall on pixel boundaries.
        Not only did this not match CG, it wouldn't necessarily work right,
        because there could be other transforms (e.g. full-page zoom) that
        would affect the stroke before it reached the device pixel level.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::drawRect):
        (PlatformContextSkia::setupPaintForStroking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Jian Li <jianli@chromium.org>
dimich@chromium.org [Fri, 13 Mar 2009 20:45:17 +0000 (20:45 +0000)]
2009-03-13  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24583
        Need to change scope of constructor and destructor of V8ObjectEventListener from private
        to protected so that they could be used in its derived class V8WorkerContextEventListener.

        * bindings/v8/V8ObjectEventListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 13 Mar 2009 19:53:48 +0000 (19:53 +0000)]
2009-03-13  Anders Carlsson  <andersca@apple.com>

        And yet another attempt...

        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler):
        (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler):
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 13 Mar 2009 19:52:10 +0000 (19:52 +0000)]
2009-03-13  Anders Carlsson  <andersca@apple.com>

        Another attempt at fixing the build.

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 13 Mar 2009 19:39:13 +0000 (19:39 +0000)]
2009-03-13  Anders Carlsson  <andersca@apple.com>

        Try to fix the SL build.

        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 13 Mar 2009 19:13:16 +0000 (19:13 +0000)]
2009-03-13  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24579
        Many V8*Event* files are misplaced.

        This code is infrastructure for supporting the bindings and thus should
        be in the bindings/v8 directory.

        * bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
        * bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
        * bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
        * bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
        * bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
        * bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
        * bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
        * bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Fri, 13 Mar 2009 19:06:46 +0000 (19:06 +0000)]
WebCore:

2009-03-13  Adele Peterson  <adele@apple.com>

        Reviewed by Justin Garcia.

        Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

        Test: editing/pasteboard/5089327.html

        Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::handleStyleSpansBeforeInsertion):
        (WebCore::ReplaceSelectionCommand::handleStyleSpans):

LayoutTests:

2009-03-13  Adele Peterson  <adele@apple.com>

        Reviewed by Justin Garcia.

        Tests for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

        * editing/pasteboard/5089327.html: Added.
        * platform/mac/editing/pasteboard/5089327-expected.checksum: Added.
        * platform/mac/editing/pasteboard/5089327-expected.png: Added.
        * platform/mac/editing/pasteboard/5089327-expected.txt: Added.

        Updated colors for pasted content.

        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.checksum:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.checksum:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 13 Mar 2009 18:57:36 +0000 (18:57 +0000)]
2009-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Update to match new API.

        * NetscapeInputMethodPlugin/main.m:
        (NPP_New):
        (NPP_Destroy):
        (NPP_SetWindow):
        (handleDraw):
        (invalidatePlugin):
        (handleFocusChanged):
        (handleMouseMoved):
        (handleMouseDown):
        (handleTextFieldKeyDown):
        (handleTextInput):
        (NPP_HandleEvent):
        (NPP_URLNotify):
        (NPP_GetValue):
        (NPP_SetValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Fri, 13 Mar 2009 18:56:42 +0000 (18:56 +0000)]
2009-03-13  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        Update Geolocation perimission dialogs to be asynchronous.
        https://bugs.webkit.org/show_bug.cgi?id=24505

        WebGeolocation is a wrapper around WebCore::Geolocation. It mimics the
        coding style set by WebSecurityOrigin.

        WebChromeClient now calls the private UI delegate method
        -webView:frame:requestGeolocationPermission:securityOrigin:

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::requestGeolocationPermissionForFrame):
        * WebCoreSupport/WebGeolocation.mm: Added.
        (WebCore::if):
        (-[WebGeolocation shouldClearCache]):
        (-[WebGeolocation setIsAllowed:]):
        (-[WebGeolocation dealloc]):
        * WebCoreSupport/WebGeolocationInternal.h: Added.
        * WebCoreSupport/WebGeolocationPrivate.h: Added.
        * WebView/WebUIDelegatePrivate.h:

2009-03-13  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        Update Geolocation perimission dialogs to be asynchronous.
        https://bugs.webkit.org/show_bug.cgi?id=24505

        Add WebGeolocation, a wrapper around WebCore::Geolocation. It mimics the
        coding style set by WebSecurityOrigin.

        * WebKit.xcodeproj/project.pbxproj:

2009-03-13  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        Update Geolocation perimission dialogs to be asynchronous.
        https://bugs.webkit.org/show_bug.cgi?id=24505

        Geolocation now requests permission from the Chrome asynchronously.
        The Chrome is passed the Geolocation object, and the Chrome sets the permission
        on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
        of SecurityOrigins with geolocation permission. This is so that the GeolocationService
        can inform the Chrome of its request, and the Chrome is also free to implement its
        own policy.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * page/Chrome.cpp:
        (WebCore::Chrome::requestGeolocationPermissionForFrame):
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
        * page/Geolocation.cpp:
        (WebCore::Geolocation::Geolocation):
        (WebCore::Geolocation::getCurrentPosition):
        (WebCore::Geolocation::watchPosition):
        (WebCore::Geolocation::setIsAllowed):
        (WebCore::Geolocation::displayChallengeIfNecessary):
        (WebCore::Geolocation::geolocationServicePositionChanged):
        * page/Geolocation.h:
        (WebCore::Geolocation::isAllowed):
        (WebCore::Geolocation::setShouldClearCache):
        (WebCore::Geolocation::shouldClearCache):
        (WebCore::Geolocation::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
andersca@apple.com [Fri, 13 Mar 2009 18:44:19 +0000 (18:44 +0000)]
WebCore:

2009-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6610666> Revise the Cocoa event model text API

        Add a NPCocoaEventTextInput event type. Remove the text input variables.

        * bridge/npapi.h:
        (_NPCocoaEvent::):

WebKit:

2009-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6610666> Revise the Cocoa event model text API

        Remove nptextinput.h

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6610666> Revise the Cocoa event model text API

        Replace the text input API with a simpler API that uses a separate text input window.

        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
        Initialize m_keyEventHandler to 0.

        (WebNetscapePluginEventHandlerCocoa::keyDown):
        If the plug-in returns 0 from NPP_HandleEvent, pass the event to the TSM machinery.

        (WebNetscapePluginEventHandlerCocoa::focusChanged):
        Install/remove the key event handler as needed.

        (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
        Get the text and send a TextInput event.

        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        Remove the old text input API.

        (-[WebNetscapePluginView inputContext]):
        Always return nil here.

        * Plugins/npapi.mm:
        * Plugins/nptextinput.h: Removed.

WebKitTools:

2009-03-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6610666> Revise the Cocoa event model text API

        Add a case statement for NPCocoaEventTextInput.

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (handleEventCocoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders.
kdecker@apple.com [Fri, 13 Mar 2009 18:18:44 +0000 (18:18 +0000)]
    Reviewed by Anders.

        <rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed

        The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
        over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
        for x-oleobject.

        * rendering/RenderPartObject.cpp:
        (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Pamela Greene <pam@chromium.org>
pam@chromium.org [Fri, 13 Mar 2009 17:45:42 +0000 (17:45 +0000)]
2009-03-13  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Fisher.

        Add tests for window property lookup precedence in the presence of
        conflicting names in a child frame and in a named document element.

        https://bugs.webkit.org/show_bug.cgi?id=24170

        * fast/dom/Window/resources/window-properties.js: Added.
        * fast/dom/Window/window-lookup-precedence-expected.txt: Added.
        * fast/dom/Window/window-lookup-precedence.html: Added.
        * fast/js/resources/js-test-pre.js:
        (shouldEvaluateTo): Added. Compares expected values of various types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Jian Li <jianli@chromium.org>
levin@chromium.org [Fri, 13 Mar 2009 17:32:19 +0000 (17:32 +0000)]
2009-03-13  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24559
        Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.

        * bindings/v8/custom/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::getListenerFunction):
        (WebCore::V8LazyEventListener::getWrappedListenerFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Jian Li <jianli@chromium.org>
levin@chromium.org [Fri, 13 Mar 2009 17:32:12 +0000 (17:32 +0000)]
2009-03-13  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24557
        This is to support running multiple workers in a single worker process in chromium.

        * bindings/v8/custom/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::handleEvent):
        Add locker to v8 event listener of worker context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Pamela Greene <pam@chromium.org>
pam@chromium.org [Fri, 13 Mar 2009 17:09:52 +0000 (17:09 +0000)]
2009-03-13  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add test cases to ensure that DOM constructors have higher lookup
        precedence than a document element with the same name.

        https://bugs.webkit.org/show_bug.cgi?id=24520

        * fast/dom/dom-constructors-expected.txt:
        * fast/dom/dom-constructors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Pamela Greene <pam@chromium.org>
pam@chromium.org [Fri, 13 Mar 2009 16:20:43 +0000 (16:20 +0000)]
2009-03-13  Pamela Greene  <pam@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add a test to check that the JS wrapper for the document in an
        inner frame is created in the correct context when it's accessed
        from the outer frame first.

        https://bugs.webkit.org/show_bug.cgi?id=24564

        * fast/dom/resources/wrapper-context-inner.html: Added.
        * fast/dom/wrapper-context-expected.txt: Added.
        * fast/dom/wrapper-context.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@webkit.org [Fri, 13 Mar 2009 13:25:52 +0000 (13:25 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=24575
        XHR response is incorrect after a network error.

        Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html
               http/tests/xmlhttprequest/cross-site-denied-response-sync.html
               http/tests/xmlhttprequest/cross-site-denied-response.html

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request.
        (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note
        that since internalAbort() can drop GC protection, it is not safe to use the object after
        this call.
        (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and
        return early if it was. This can happen during sync requests, as the loader does not know
        that it was aborted, and just synthesizes all callbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Updating results after the fix for bug 3547.
ap@webkit.org [Fri, 13 Mar 2009 12:57:19 +0000 (12:57 +0000)]
    Updating results after the fix for bug 3547.

        * fast/loader/xmlhttprequest-missing-file-exception-expected.txt: The status text for
        a failed local file load is no longer "OK", which is good.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
ap@webkit.org [Fri, 13 Mar 2009 11:06:47 +0000 (11:06 +0000)]
2009-03-13  Adam Bergkvist <adam.bergkvist@ericsson.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=3547
        XMLHttpRequest.statusText returns always "OK"

        Covered by existing tests (which now pass on all platforms but Mac).

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up
        to each platform to correctly set the status text or set it to "OK" to retain current
        behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
ap@webkit.org [Fri, 13 Mar 2009 10:05:42 +0000 (10:05 +0000)]
2009-03-13  Adam Bergkvist <adam.bergkvist@ericsson.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24349
        [QT] HTTP status text is never set

        Set HTTP status text to the reason phrase attribute of QNetworkReply.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - Skipped file fix
mitz@apple.com [Fri, 13 Mar 2009 06:23:36 +0000 (06:23 +0000)]
    - Skipped file fix

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 13 Mar 2009 06:07:10 +0000 (06:07 +0000)]
2009-03-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6622300>: Reproducible crash on
        <http://www.editgrid.com/explore/tnc/dave/FusionChart%3A_Candlestick>

        Prevent CSSStyleSheet::checkLoaded() writing to freed memory when it gets
        deleted from under itself. The sheetLoaded() notification can allow scripts
        to run via HTMLTokenizer::executeScriptsWaitingForStylesheets(),
        which can cause the last ref to the CSSStyleSheet to be released.

        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::checkLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Let DerivedSources.make know we want database APIs.
kevino@webkit.org [Fri, 13 Mar 2009 05:28:57 +0000 (05:28 +0000)]
wx build fix. Let DerivedSources.make know we want database APIs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6548446> TCMalloc_SystemRelease should use madvise rather than re...
mrowe@apple.com [Fri, 13 Mar 2009 03:33:27 +0000 (03:33 +0000)]
<rdar://problem/6548446> TCMalloc_SystemRelease should use madvise rather than re-mmaping span of pages

* wtf/FastMalloc.cpp:
(WTF::mergeDecommittedStates): If either of the spans has been released to the system, release the other
span as well so that the flag in the merged span is accurate.
* wtf/Platform.h:
* wtf/TCSystemAlloc.cpp: Track decommitted spans when using MADV_FREE_REUSABLE / MADV_FREE_REUSE.
(TCMalloc_SystemRelease): Use madvise with MADV_FREE_REUSABLE when it is available.
(TCMalloc_SystemCommit): Use madvise with MADV_FREE_REUSE when it is available.
* wtf/TCSystemAlloc.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 13 Mar 2009 03:10:31 +0000 (03:10 +0000)]
2009-03-12  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=24498
        Fix the Qt port to use the same algorithm for drawing dashed and dotted
        borders as the other ports.  This makes the Qt port pixel-for-pixel perfect
        compared to border drawing with Apple's canonical mac port and much closer
        to konqueror and firefox behavior.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Fri, 13 Mar 2009 00:15:36 +0000 (00:15 +0000)]
    Reviewed by Anders Carlsson.

        - skip editing/selection/word-thai.html on Tiger because it has an older
          version of Unicode.

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Thu, 12 Mar 2009 23:05:52 +0000 (23:05 +0000)]
    Reviewed by Justin Garcia.

        Clean up DOMSelection to use some helper functions
        making the code smaller, and less error-prone.
        https://bugs.webkit.org/show_bug.cgi?id=19221

        I tried moving DOMSelection off of rangeCompliantEquivalent
        but failed.  VisibleSelection holds positions like (table, 1) to mean
        "after the table".

        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::visibleSelection):
        (WebCore::anchorPosition):
        (WebCore::focusPosition):
        (WebCore::basePosition):
        (WebCore::extentPosition):
        (WebCore::DOMSelection::anchorNode):
        (WebCore::DOMSelection::anchorOffset):
        (WebCore::DOMSelection::focusNode):
        (WebCore::DOMSelection::focusOffset):
        (WebCore::DOMSelection::baseNode):
        (WebCore::DOMSelection::baseOffset):
        (WebCore::DOMSelection::extentNode):
        (WebCore::DOMSelection::extentOffset):
        * page/DOMSelection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Thu, 12 Mar 2009 22:47:32 +0000 (22:47 +0000)]
2009-03-12  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24563
        Change ResourceRequest to be a struct rather then a class to match other declarations.

        * platform/network/chromium/ResourceRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Mark.
andersca@apple.com [Thu, 12 Mar 2009 22:15:21 +0000 (22:15 +0000)]
Add Mark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 12 Mar 2009 22:13:39 +0000 (22:13 +0000)]
2009-03-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mike Thole.

        Fix <rdar://problem/6624105>.

        Make sure to process incoming messages for the NSEventTrackingRunLoopMode as well.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-12 Aaron Boodman <aa@chromium.org>
levin@chromium.org [Thu, 12 Mar 2009 22:05:33 +0000 (22:05 +0000)]
2009-03-12  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        Bug 16348: @font-face does not affect the default style
        <https://bugs.webkit.org/show_bug.cgi?id=16348>

        * fast/css/font-face-default-font.html:
        Handle the default font being either 'Times' or 'Times New Roman'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41653 268f45cc-cd09-0410-ab3c-d52691b4dbfc