WebKit-https.git
10 years ago2009-10-15 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 15 Oct 2009 07:10:51 +0000 (07:10 +0000)]
2009-10-15  Joseph Pecoraro  <joepeck@webkit.org>

        Fix Windows build.

        * dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 15 Oct 2009 06:41:42 +0000 (06:41 +0000)]
2009-10-14  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Adam Barth.

        [HTML5] Add document.head
        https://bugs.webkit.org/show_bug.cgi?id=30232

        Test is fast/dom/document-head.html

        * dom/Document.idl: added readonly attribute head

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Matt Mueller <mattm@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 06:12:39 +0000 (06:12 +0000)]
2009-10-14  Matt Mueller  <mattm@chromium.org>

        Reviewed by Darin Adler.

        Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit.  See http://crbug.com/20939.
        https://bugs.webkit.org/show_bug.cgi?id=30347
        https://bugs.webkit.org/show_bug.cgi?id=22772

        Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::validUnit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 15 Oct 2009 05:15:54 +0000 (05:15 +0000)]
2009-10-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Move scrolling code from FrameLoader to FrameView
        https://bugs.webkit.org/show_bug.cgi?id=30370

        This code is about controlling the Frame's view, not about loading
        stuff into the frame.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedParsing):
        (WebCore::FrameLoader::scrollToAnchor):
        * page/FrameView.cpp:
        (WebCore::FrameView::scrollToFragment):
        (WebCore::FrameView::scrollToAnchor):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake typeinfo flags default to false
oliver@apple.com [Thu, 15 Oct 2009 03:24:17 +0000 (03:24 +0000)]
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372

Reviewed by Geoff Garen.

Part 1. Reverse the HasStandardGetOwnPropertySlot flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 15 Oct 2009 02:39:34 +0000 (02:39 +0000)]
2009-10-14  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        Document what state the build tree is expected to be in after a patch.

        * coding/contributing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 15 Oct 2009 02:14:25 +0000 (02:14 +0000)]
2009-10-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        [XSSAuditor] Add an exception for local files
        https://bugs.webkit.org/show_bug.cgi?id=30352

        Test that we allow sites to load scripts from their own domain as long
        as they don't use query strings.

        * http/tests/security/xssAuditor/script-tag-with-source-same-host-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html: Added.
        * http/tests/security/xssAuditor/script-tag-with-source-same-host.html: Added.
2009-10-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        [XSSAuditor] Add an exception for local files
        https://bugs.webkit.org/show_bug.cgi?id=30352

        Reduce XSS auditor false positives by always letting pages load scripts
        from their own host. We don't actually know of any false positives
        that this prevents, but it seems like a good idea.

        One subtly is that we don't add this exception for scripts that have a
        query string because (1) URLs with query strings are more apt to
        confuse servers and (2) it is much less common to load scripts with a
        query string.

        Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html
               http/tests/security/xssAuditor/script-tag-with-source-same-host.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unbreak the world.
kdecker@apple.com [Thu, 15 Oct 2009 00:33:32 +0000 (00:33 +0000)]
    Unbreak the world.

        * Plugins/WebBaseNetscapePluginView.mm:
        (WebHaltablePlugin::restart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson and Jon Honeycutt
kdecker@apple.com [Thu, 15 Oct 2009 00:14:08 +0000 (00:14 +0000)]
    Reviewed by Anders Carlsson and Jon Honeycutt

        <rdar://problem/7304295> snapshots of halted plug-ins are missing

        * Plugins/WebBaseNetscapePluginView.mm: Move bodies of WebHaltablePlugin virtual functions from WebHaltablePlugin class definition.
        (WebHaltablePlugin::halt): Provide a substitute image to the RenderWidget for the plug-in view.
        (WebHaltablePlugin::restart): Clear the substitute image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 14 Oct 2009 23:54:23 +0000 (23:54 +0000)]
2009-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by George Staikos.

        Kill virtual contextElement() method spread all over SVG code
        https://bugs.webkit.org/show_bug.cgi?id=30183

        Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the
        SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired
        subclasses. This is a first step to working animVal support. More patches will follow that depend on this change.

        Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann,
        and remove vim modelines on all files I touched. No change in functionality, thus no new tests.

        * svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGAltGlyphElement.h: Remove virtual contextElement() method.
        * svg/SVGAnimatedProperty.h:
        (WebCore::::synchronize):
        (WebCore::::startAnimation):
        (WebCore::::stopAnimation):
        * svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGCircleElement.h: Ditto.
        * svg/SVGClipPathElement.h: Ditto.
        * svg/SVGCursorElement.h: Ditto.
        * svg/SVGDefsElement.h: Ditto.
        * svg/SVGEllipseElement.h: Ditto.
        * svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method.
        * svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGFELightElement.h: Remove virtual contextElement() method.
        * svg/SVGFEMergeNodeElement.h: Ditto.
        * svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method.
        * svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element.
        (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto.
        * svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method.
        * svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGForeignObjectElement.h: Ditto.
        * svg/SVGGElement.h: Ditto.
        * svg/SVGGradientElement.h: Ditto.
        * svg/SVGImageElement.h: Ditto.
        * svg/SVGLineElement.h: Ditto.
        * svg/SVGMPathElement.h: Ditto. Fix license indention.
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGMaskElement.h: Ditto.
        * svg/SVGPathElement.h: Ditto.
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize().
        * svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGRectElement.h: Ditto.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGScriptElement.h: Ditto.
        * svg/SVGSwitchElement.h: Ditto.
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGTRefElement.h: Remove virtual contextElement() method.
        * svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGTextPathElement.h: Remove virtual contextElement() method.
        * svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        * svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute().
        (WebCore::SVGViewSpec::parseViewSpec): Ditto.
        * svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a failure seen on buildbot after landing the fix for
darin@apple.com [Wed, 14 Oct 2009 23:48:56 +0000 (23:48 +0000)]
Fix a failure seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994

Patch by Darin Adler <darin@apple.com> on 2009-10-14
* platform/win/fast/css/large-number-round-trip-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 14 Oct 2009 23:21:46 +0000 (23:21 +0000)]
2009-10-14  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Masking with wrong offset
        [https://bugs.webkit.org/show_bug.cgi?id=30325]

        SVGMaskElement moves the mask image graphics context to the wrong location.
        In objectBoundingBoxMode the maskDestRect gets translated. This transformation
        is not used in the later calculation. Fix by consistenly calculating the translation
        offsets from the final mask destination rect.

        Test: svg/custom/mask-with-default-value.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

2009-10-14  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Masking with wrong offset
        [https://bugs.webkit.org/show_bug.cgi?id=30325]

        SVGMaskElement moves the mask image graphics context to the wrong location.
        In objectBoundingBoxMode the maskDestRect gets translated. This transformation
        is not used in the later calculation. Fix by consistenly calculating the translation
        offsets from the final mask destination rect.

        Test: svg/custom/mask-with-default-value.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubberstamped by Jon Honeycutt.
kdecker@apple.com [Wed, 14 Oct 2009 23:14:45 +0000 (23:14 +0000)]
    Rubberstamped by Jon Honeycutt.

        Export a few more showSubstituteImage() related methods.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix failures seen on buildbot after landing the fix for
darin@apple.com [Wed, 14 Oct 2009 23:11:43 +0000 (23:11 +0000)]
Fix failures seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994

Patch by Darin Adler <darin@apple.com> on 2009-10-14
Reviewed by Mark Rowe.

Somehow I had the mac/fast/css/opacity-float-expected.txt
removed locally, and Subversion didn't check that in!

* platform/mac/fast/css/opacity-float-expected.txt: Removed.
* platform/win/fast/css/opacity-float-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable plugins/private-browsing-mode.html on Snow Leopard.
andersca@apple.com [Wed, 14 Oct 2009 23:00:04 +0000 (23:00 +0000)]
Disable plugins/private-browsing-mode.html on Snow Leopard.

Reviewed by Sam Weinig.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=30269
jparent@chromium.org [Wed, 14 Oct 2009 22:38:47 +0000 (22:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30269
Use onload to detect iframe load, rather than setTimeout.
This will give more consistent test results and hopefully faster run times.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-13
Reviewed by Darin Adler.

* editing/execCommand/paste-1.html:
* editing/execCommand/paste-2.html:
* editing/pasteboard/subframe-dragndrop-1.html:
* editing/selection/4776665.html:
* editing/selection/4975120.html:
* editing/selection/5136696.html:
* editing/selection/drag-to-contenteditable-iframe.html:
* platform/mac/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
* platform/qt/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
* platform/win/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
darin@apple.com [Wed, 14 Oct 2009 21:45:27 +0000 (21:45 +0000)]
JavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.

Patch by Darin Adler <darin@apple.com> on 2009-10-14
* wtf/MathExtras.h: Added llround and llroundf for Windows.

WebCore: Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.

Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=18994

* css/CSSPrimitiveValue.cpp:
(WebCore::appendCSSDouble):
(WebCore::formatWithUnits):
(WebCore::CSSPrimitiveValue::cssText):

LayoutTests: Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly

Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=18994

* fast/css/large-number-round-trip-expected.txt:
* fast/css/opacity-float-expected.txt:
* fast/css/opacity-float.html:
* platform/mac/fast/css/opacity-float-expected.txt: Removed.
* transforms/2d/compound-2d-transforms-expected.txt:
* transforms/2d/compound-2d-transforms.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Mark Seaborn <mseaborn@google.com>
eric@webkit.org [Wed, 14 Oct 2009 21:41:01 +0000 (21:41 +0000)]
2009-10-14  Mark Seaborn  <mseaborn@google.com>

        Reviewed by Darin Adler.

        Check error return value in Perl build script
        https://bugs.webkit.org/show_bug.cgi?id=30316

        * css/makevalues.pl: Die if gperf fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r49580 as it is completely wrong and breaks the Mac builds.
mrowe@apple.com [Wed, 14 Oct 2009 20:39:23 +0000 (20:39 +0000)]
Roll out r49580 as it is completely wrong and breaks the Mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 14 Oct 2009 20:30:35 +0000 (20:30 +0000)]
2009-10-14  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG wrong filterRegions for userSpaceOnUse and percentage values
        [https://bugs.webkit.org/show_bug.cgi?id=30330]

        Some clean-up of the SVG filter calculation code. This clean-up
        also fixes the problem with percentage and userSpaceInUse mode.

        Test: svg/filters/subRegion-in-userSpace.svg

        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::FilterEffect):
        * platform/graphics/filters/FilterEffect.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::buildFilter):
        (WebCore::SVGFilterElement::canvasResource):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::SVGResourceFilter):
        (WebCore::SVGResourceFilter::~SVGResourceFilter):
        (WebCore::SVGResourceFilter::addFilterEffect):
        (WebCore::SVGResourceFilter::prepareFilter):
        * svg/graphics/SVGResourceFilter.h:
        (WebCore::SVGResourceFilter::create):
        * svg/graphics/filters/SVGFilter.cpp:
        (WebCore::SVGFilter::SVGFilter):
        (WebCore::SVGFilter::calculateEffectSubRegion):
        (WebCore::SVGFilter::create):
        * svg/graphics/filters/SVGFilter.h:

        Reviewed by Nikolas Zimmermann.

        Check if the percentage of effect values takes user space as reference and
        not the FilterRect.

        * platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.png: Added.
        * platform/mac/svg/filters/subRegion-in-userSpace-expected.txt: Added.
        * svg/filters/subRegion-in-userSpace.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTools: Don't set the history delegate on new windows that are opened during...
beidson@apple.com [Wed, 14 Oct 2009 19:32:37 +0000 (19:32 +0000)]
WebKitTools: Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1 - Disables WebHistory
2 - Doesn't make sense in that context anyway.

Reviewed by Sam Weinig.

* DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):

LayoutTests: Un-skip a test that now passes.

Reviewed by Sam Weinig.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
kevino@webkit.org [Wed, 14 Oct 2009 19:01:34 +0000 (19:01 +0000)]
Mac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
compilation of code that requires 10.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
kevino@webkit.org [Wed, 14 Oct 2009 18:51:05 +0000 (18:51 +0000)]
wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago The last change fixed the problem, removing diagnostic printfs.
cmarrin@apple.com [Wed, 14 Oct 2009 18:41:34 +0000 (18:41 +0000)]
    The last change fixed the problem, removing diagnostic printfs.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCURL build fix for versions < 7.18.
kevino@webkit.org [Wed, 14 Oct 2009 18:31:39 +0000 (18:31 +0000)]
CURL build fix for versions < 7.18.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 14 Oct 2009 18:30:37 +0000 (18:30 +0000)]
2009-10-14  Nate Chapin  <japhet@chromium.org>

        Unreviewed, build fix.

        When I landed r49569 for Victor, I failed to svn add one of the required files.

        This should fix the redness on the Windows test bots.

        * platform/win/editing/pasteboard/paste-xml-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago One more round of changes to figure out why the webgl
cmarrin@apple.com [Wed, 14 Oct 2009 18:18:21 +0000 (18:18 +0000)]
    One more round of changes to figure out why the webgl
        tests are crashing on the build bot. Here I am trying
        to see if we can create a software renderer. I am also
        printing the found pixel formats.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnabling NPAPI plugin support on Qt Webkit for S60 platform
yael.aharon@nokia.com [Wed, 14 Oct 2009 17:42:12 +0000 (17:42 +0000)]
Enabling NPAPI plugin support on Qt Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-14
Reviewed by

Also implemented by Mahesh Kulkarni<mahesh.kulkarni@nokia.com>,
Rohini Ananth <rohini.ananth@nokia.com> and help from Norbert Lesr
<norbert.leser@nokia.com>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 17:34:55 +0000 (17:34 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: skip inspector tests that were recently added
        until harness is fixed in release mode.

        https://bugs.webkit.org/show_bug.cgi?id=30014

        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip my two new failures while I'm actively looking at them.
beidson@apple.com [Wed, 14 Oct 2009 17:29:49 +0000 (17:29 +0000)]
Skip my two new failures while I'm actively looking at them.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago More changes to figure out why the webgl tests are crashing on the build...
cmarrin@apple.com [Wed, 14 Oct 2009 17:18:14 +0000 (17:18 +0000)]
    More changes to figure out why the webgl tests are crashing on the build bot.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still...
kevino@webkit.org [Wed, 14 Oct 2009 17:11:34 +0000 (17:11 +0000)]
wx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still building stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Victor Wang <victorw@chromium.org>
japhet@chromium.org [Wed, 14 Oct 2009 17:02:13 +0000 (17:02 +0000)]
2009-10-14  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Adler.

        Add paste-xml test back for Win.
        The result difference between Mac and Win is due to the
        platform dependent implementation. The diff is expected
        with current implementation.
        See bug for more deails:

        https://bugs.webkit.org/show_bug.cgi?id=30267

        * platform/win/Skipped:
        * platform/win/editing/pasteboard/paste-xml-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 16:39:23 +0000 (16:39 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add initial layout tests for web inspector.

        https://bugs.webkit.org/show_bug.cgi?id=30014

        * inspector/console-tests-expected.txt: Added.
        * inspector/console-tests.html: Added.
        * inspector/elements-panel-structure-expected.txt: Added.
        * inspector/elements-panel-structure.html: Added.
        * inspector/evaluate-in-frontend-expected.txt: Added.
        * inspector/evaluate-in-frontend.html: Added.
        * inspector/evaluate-in-frontend.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Victor Wang <victorw@chromium.org>
japhet@chromium.org [Wed, 14 Oct 2009 16:26:38 +0000 (16:26 +0000)]
2009-10-14  Victor Wang  <victorw@chromium.org>

        Reviewed by David Hyatt.

        Round non-integer line height values.

        Change webkit to rounding non-integer line height values
        instead of truncating them. This fixes a layout test
        failure on Windows and matches the calculation in IE and Firefox.

        https://bugs.webkit.org/show_bug.cgi?id=24434

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
aroben@apple.com [Wed, 14 Oct 2009 16:23:50 +0000 (16:23 +0000)]
Windows build fix

* WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
IWebNavigationData from the build (they get #imported via WebKit.idl).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Kelly Norton <knorton@google.com>
pfeldman@chromium.org [Wed, 14 Oct 2009 16:21:06 +0000 (16:21 +0000)]
2009-10-13  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Removes the persistent setting for InspectorTimelineAgent and renames timeline related
        interfaces to be more consistent with the JavaScript profiler.

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::startTimelineProfiler):
        (WebCore::InspectorBackend::stopTimelineProfiler):
        (WebCore::InspectorBackend::timelineProfilerEnabled):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::startTimelineProfiler):
        (WebCore::InspectorController::stopTimelineProfiler):
        (WebCore::InspectorController::timelineProfilerEnabled):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::timelineProfilerWasStarted):
        (WebCore::InspectorFrontend::timelineProfilerWasStopped):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/TimelineAgent.js:
        (WebInspector.timelineProfilerWasStarted):
        (WebInspector.timelineProfilerWasStopped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit Win API should provide a delegate interface for global history.
beidson@apple.com [Wed, 14 Oct 2009 16:03:31 +0000 (16:03 +0000)]
WebKit Win API should provide a delegate interface for global history.
https://bugs.webkit.org/show_bug.cgi?id=29905

Reviewed by Sam Weinig.

WebKit/win:

-Add IWebHistoryDelegate for clients to implement.
-Add (I)WebNavigationData for the history delegate's use.
-When it exists, call the history delegate instead of using WebHistory.

* Interfaces/IWebHistoryDelegate.idl: Added.
* Interfaces/IWebHistoryPrivate.idl:
* Interfaces/IWebNavigationData.idl: Added.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:

* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebFrameLoaderClient::setTitle):

 * WebView.cpp:
(WebView::close):
(WebView::mainFrameURL):
(WebView::setHistoryDelegate):
(WebView::historyDelegate):
(WebView::addVisitedLinks):
* WebView.h:

* WebHistory.cpp:
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
* WebHistory.h:

* WebNavigationData.cpp: Added.
(WebNavigationData::QueryInterface):
(WebNavigationData::AddRef):
(WebNavigationData::Release):
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
(WebNavigationData::createInstance):
(WebNavigationData::url):
(WebNavigationData::title):
(WebNavigationData::originalRequest):
(WebNavigationData::response):
(WebNavigationData::hasSubstituteData):
(WebNavigationData::clientRedirectSource):
* WebNavigationData.h: Added.

WebKitTools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpHistoryDelegateCallbacks):
(LayoutTestController::setDumpHistoryDelegateCallbacks):

* DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogHistoryDelegates):
(runTest):
(createWebViewAndOffscreenWindow):
(main):
* DumpRenderTree/win/DumpRenderTree.vcproj:

Add the IWebHistoryDelegate to DRT Windows:
* DumpRenderTree/win/HistoryDelegate.cpp: Added.
(wstringFromBSTR):
(HistoryDelegate::HistoryDelegate):
(HistoryDelegate::~HistoryDelegate):
(HistoryDelegate::QueryInterface):
(HistoryDelegate::AddRef):
(HistoryDelegate::Release):
(HistoryDelegate::didNavigateWithNavigationData):
(HistoryDelegate::didPerformClientRedirectFromURL):
(HistoryDelegate::didPerformServerRedirectFromURL):
(HistoryDelegate::updateHistoryTitle):
(HistoryDelegate::populateVisitedLinksForWebView):
* DumpRenderTree/win/HistoryDelegate.h: Added.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeAllVisitedLinks):

LayoutTests:

* platform/win/Skipped: Enable globalhistory tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Wed, 14 Oct 2009 16:02:11 +0000 (16:02 +0000)]
2009-10-14  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement support for setPOSIXLocale on Qt.
        https://bugs.webkit.org/show_bug.cgi?id=30268

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setPOSIXLocale):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Yong Li <yong.li@torchmobile.com>
yong.li@torchmobile.com [Wed, 14 Oct 2009 15:48:41 +0000 (15:48 +0000)]
2009-10-02  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Adele Peterson.

        Fixed crash when loading invalid image data.
        Also added a test case that loads an invalid image to make sure
        we don't crash in this situation.
        https://bugs.webkit.org/show_bug.cgi?id=29980

WebCore:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::setImageSizeForAltText):

LayoutTests:
        * fast/images/image-invalid-data-expected.txt: Added.
        * fast/images/image-invalid-data.html: Added.
        * fast/images/resources/invalid.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for NULL ptr deref in canvas's toDataURL().
senorblanco@chromium.org [Wed, 14 Oct 2009 15:02:42 +0000 (15:02 +0000)]
WebCore: Fix for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254

Reviewed by Eric Seidel.

Test: fast/canvas/canvas-toDataURL-crash.html

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):

LayoutTests: New test for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254

Reviewed by Eric Seidel.

* fast/canvas/canvas-toDataURL-crash-expected.txt: Added.
* fast/canvas/canvas-toDataURL-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 14:54:18 +0000 (14:54 +0000)]
2009-10-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed, reverting r49558 since it broke profiler tests.

        https://bugs.webkit.org/show_bug.cgi?id=30328

        * bindings/js/JSInspectorBackendCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getProfileHeaders):
        (WebCore::InspectorBackend::getProfile):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getProfileHeaders):
        (WebCore::InspectorController::getProfile):
        (WebCore::InspectorController::createProfileHeader):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addProfileHeader):
        (WebCore::InspectorFrontend::didGetProfileHeaders):
        (WebCore::InspectorFrontend::didGetProfile):
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::ProfileNodeClass):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.profileCallback):
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
        (WebInspector.ProfileView.prototype._assignParentsInProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        * inspector/front-end/inspector.js:
        (WebInspector.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImageDecoderQt: Minor tweaks to the decoder
zecke@webkit.org [Wed, 14 Oct 2009 14:10:52 +0000 (14:10 +0000)]
ImageDecoderQt: Minor tweaks to the decoder

- Only cache the data when we start to use it.
- Start with a repetition count of none for normal images.
- Do not use canRead as this will trigger parsing of the full image
- Cope with a GIF failing to decode the first frame, do not
  set m_failed to true if decoding the first frame failed
- Inform the QImageReader about the format that was detected
- Always create a ImageDecoderQt when when we have more
  than four byte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 13:32:09 +0000 (13:32 +0000)]
2009-10-14  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Migrate profiles to the injected script-based schema.

        https://bugs.webkit.org/show_bug.cgi?id=30328

        * bindings/js/JSInspectorBackendCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getProfileHeaders):
        (WebCore::InspectorBackend::getProfile):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getProfileHeaders):
        (WebCore::InspectorController::getProfile):
        (WebCore::InspectorController::createProfileHeader):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addProfileHeader):
        (WebCore::InspectorFrontend::didGetProfileHeaders):
        (WebCore::InspectorFrontend::didGetProfile):
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::ProfileNodeClass):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.profileCallback):
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
        (WebInspector.ProfileView.prototype._assignParentsInProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfileHeader):
        * inspector/front-end/inspector.js:
        (WebInspector.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Yury Semikhatsky <yurys@chromium.org>
pfeldman@chromium.org [Wed, 14 Oct 2009 09:14:29 +0000 (09:14 +0000)]
2009-10-13  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Don't collect call frame properties until they're needed for completion.

        https://bugs.webkit.org/show_bug.cgi?id=30334

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties.
        (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed.
        * inspector/front-end/ScriptsPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Yongjun Zhang <yongjun.zhang@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 14 Oct 2009 05:14:04 +0000 (05:14 +0000)]
2009-10-13  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=29106
        [Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.

        Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw
        compiler aggressively resolve inheritance of class R.

        The winscw compiler bug is reported at:
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.

        The change should be reverted when the above bug is fixed in winscw compiler.

        * loader/CachedResourceHandle.h:
        (WebCore::::CachedResourceHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 14 Oct 2009 04:43:16 +0000 (04:43 +0000)]
2009-10-13  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r49554, because it broke Win and Chromium builds.
        http://trac.webkit.org/changeset/49554

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 14 Oct 2009 04:09:02 +0000 (04:09 +0000)]
2009-10-13  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Float formatting changes affect three tests:
        - large-number-round-trip now passes
        - opacity-float now passes and has more test cases
        - compound-2d-transforms output tweaked slightly

        https://bugs.webkit.org/show_bug.cgi?id=18994

        * fast/css/large-number-round-trip-expected.txt:
        * fast/css/opacity-float-expected.txt:
        * fast/css/opacity-float.html:
        * platform/mac/fast/css/opacity-float-expected.txt: Removed.
        * transforms/2d/compound-2d-transforms-expected.txt:
        * transforms/2d/compound-2d-transforms.html:
2009-10-13  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Barth.

        Stringify CSS units manually (without printf) to make the formatting
        locale-insensitive and obey CSS spec with respect to large values.

        https://bugs.webkit.org/show_bug.cgi?id=18994

        * css/CSSPrimitiveValue.cpp:
        (WebCore::appendCSSDouble):
        (WebCore::formatWithUnits):
        (WebCore::CSSPrimitiveValue::cssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Evan Martin <evan@chromium.org>
eric@webkit.org [Wed, 14 Oct 2009 03:52:04 +0000 (03:52 +0000)]
2009-10-13  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        Make grippy lines vertical on horizontal scrollbars in Linux Chrome.
        While we're rebaselining scrollbars, fix an off by one in the vertical
        scrollbar rendering too.

        https://bugs.webkit.org/show_bug.cgi?id=30319

        Tests: this is covered by every pixel test involving scrollbars.

        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Wed, 14 Oct 2009 03:37:24 +0000 (03:37 +0000)]
2009-10-13  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Holger Freyther.

        [LayoutTests][Gtk] Set a common Gtk theme as default and update the results
        https://bugs.webkit.org/show_bug.cgi?id=30223

        Update test results to reflect the usage of the default theme.

        * platform/gtk/editing/selection/iframe-expected.txt:
        * platform/gtk/editing/selection/select-box-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix issue where clientX and clientY on MouseEvents were wrong when
weinig@apple.com [Wed, 14 Oct 2009 03:16:03 +0000 (03:16 +0000)]
WebCore: Fix issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.

Reviewed by David Hyatt.

Test: fast/events/clientXY-in-zoom-and-scroll.html

* dom/MouseRelatedEvent.cpp:
(WebCore::contentsX): Take page zoom into account.
(WebCore::contentsY): Ditto.

LayoutTests: Test issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.

Reviewed by David Hyatt.

* fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
* fast/events/clientXY-in-zoom-and-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix more WebView bustage.
hyatt@apple.com [Wed, 14 Oct 2009 02:42:58 +0000 (02:42 +0000)]
Fix more WebView bustage.

* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build bustage on Windows.
hyatt@apple.com [Wed, 14 Oct 2009 02:22:24 +0000 (02:22 +0000)]
Fix build bustage on Windows.

* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, adding myself to reviewers list.
slewis@apple.com [Wed, 14 Oct 2009 01:54:47 +0000 (01:54 +0000)]
Unreviewed, adding myself to reviewers list.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix null assignment so root tests work again.
slewis@apple.com [Wed, 14 Oct 2009 01:52:00 +0000 (01:52 +0000)]
Fix null assignment so root tests work again.

Reviewed by Mark Rowe.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix DumpRenderTree to account for API changes in the user script stuff.
hyatt@apple.com [Wed, 14 Oct 2009 01:38:04 +0000 (01:38 +0000)]
Fix DumpRenderTree to account for API changes in the user script stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Change the order of arguments on some of the user stylesheet/script function...
hyatt@apple.com [Wed, 14 Oct 2009 01:37:13 +0000 (01:37 +0000)]
WebCore: Change the order of arguments on some of the user stylesheet/script functions.  Split the removal functions
out into separate ones for scripts and stylesheets.

Reviewed by Adam Roben.

* WebCore.base.exp:
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
* page/PageGroup.h:
(WebCore::PageGroup::userScripts):
(WebCore::PageGroup::userStyleSheets):

WebKit/mac: Change the order of arguments on some methods.  Split removal for user stylesheets and script into
separate functions based off the type of object being removed.

Reviewed by Adam Roben.

* WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:worldID:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:worldID:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:worldID:url:]):
(+[WebView _removeUserStyleSheetFromGroup:worldID:url:]):
(+[WebView _removeUserScriptsFromGroup:worldID:]):
(+[WebView _removeUserStyleSheetsFromGroup:worldID:]):
* WebView/WebViewPrivate.h:

WebKit/win: Split removal functions for user scripts and stylehseets based on type.

Reviewed by Adam Roben..

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChrome's "Skia" theme paints select controls backwards in RTL.
dimich@chromium.org [Wed, 14 Oct 2009 01:16:01 +0000 (01:16 +0000)]
Chrome's "Skia" theme paints select controls backwards in RTL.

Patch by Evan Martin <evan@chromium.org> on 2009-10-13
Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=30320

Test: fast/text/international/bidi-menulist.html
(The test is about something else, but it includes RTL selects.)

* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=30318
dimich@chromium.org [Wed, 14 Oct 2009 01:15:53 +0000 (01:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30318
ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.
It's a followup to r48884. It removed the need to pass the ScritpExecutionContext
into EventListener constructor but did not remove the code pulling ScriptExecutionContext.

Reviewed by Alexey Proskuryakov.

WebCore:

Tests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.

* fast/events/add-event-without-document-expected.txt: Added.
* fast/events/add-event-without-document.html: Added.

All changes in files below are the same - remove the code that calls
EventTarget::scriptExecutionContext and checks it for NULL.

* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

LayoutTests:

Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.

* fast/events/add-event-without-document-expected.txt: Added.
* fast/events/add-event-without-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Jon Honeycutt.
bweinstein@apple.com [Wed, 14 Oct 2009 00:41:57 +0000 (00:41 +0000)]
Rubber-stamped by Jon Honeycutt.

Add trailing newline to the Windows Skipped List.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd bug number to previous ChangeLog entry.
bweinstein@apple.com [Wed, 14 Oct 2009 00:36:05 +0000 (00:36 +0000)]
Add bug number to previous ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Anders Carlsson.
bweinstein@apple.com [Wed, 14 Oct 2009 00:34:42 +0000 (00:34 +0000)]
Rubber-stamped by Anders Carlsson.

Add plugins/private-browsing-mode.html to the Windows Skipped
list because the feature is not implemented on Windows.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 13 Oct 2009 23:58:45 +0000 (23:58 +0000)]
2009-10-13  Simon Fraser  <simon.fraser@apple.com>

        Temporary debugging changes to figure out why the webgl tests are crashing on the build bot.

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable SHARED_WORKERS for Chromium
atwilson@chromium.org [Tue, 13 Oct 2009 23:39:42 +0000 (23:39 +0000)]
Enable SHARED_WORKERS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=30289

Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by David Levin.

WebCore:

Cleaned up bitrot in SharedWorker V8 bindings.

* WebCore.gypi:
Removed default implementation of SharedWorkerRepository so Chromium can provide its own.
* bindings/v8/DerivedSourcesAllInOne.cpp:
Added V8SharedWorkerContext.cpp.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getTemplate):
Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT.
* bindings/v8/V8Index.cpp:
Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers.
* bindings/v8/V8Index.h:
Added definition for SHAREDWORKERCONTEXT wrapper.
* bindings/v8/WorkerContextExecutionProxy.cpp:
Added includes for SharedWorker.h and SharedWorkerContext.h.
* bindings/v8/custom/V8CustomBinding.h:
Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index.
Also added field indexes for SharedWorkers.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
Added runtime enabler for the SharedWorker constructor.
* bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Cleaned up bitrot (various APIs have changed since this file was written).
* page/DOMWindow.idl:
Added EnabledAtRuntime flag to window.SharedWorker.

WebKit:

* chromium/features.gypi:
Turned on ENABLE_SHARED_WORKERS by default. This doesn't actually turn on
SharedWorkers yet, as Chromium overrides this flag in its feature_overrides.gypi.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@apple.com [Tue, 13 Oct 2009 23:36:15 +0000 (23:36 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=30345
        HTTP tests for credential handling fail on Tiger

        We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so
        let it do its work without intervention. Once again, we pass explicitly passed credentials
        in URL, fixing regressions from Safari 3.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Roland Steiner <rolandsteiner@google.com>
eric@webkit.org [Tue, 13 Oct 2009 23:19:28 +0000 (23:19 +0000)]
2009-10-13  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by Adam Barth.

        Bug 28964 -  [Chromium] ChromiumDataObject should have getter/setter interface

        Reworked and added to the getter/setter interface in ChromiumDataObject:
        - added contains...() methods to just query the state
        - added containsValid...URL() methods for URL data members
        - removed takeFileNames() as this was too type-dependent
        - changed return type of fileNames() to Vector<String>
        - added interface methods to allow appending to and iteration over file names

        No new tests (no functional behavior changed).

        * platform/chromium/ChromiumDataObject.h:
        (WebCore::ChromiumDataObject::containsMainURL):
        (WebCore::ChromiumDataObject::containsValidMainURL):
        (WebCore::ChromiumDataObject::containsMainURLTitle):
        (WebCore::ChromiumDataObject::containsTextPlain):
        (WebCore::ChromiumDataObject::containsTextHTML):
        (WebCore::ChromiumDataObject::containsHTMLBaseURL):
        (WebCore::ChromiumDataObject::containsValidHTMLBaseURL):
        (WebCore::ChromiumDataObject::containsContent):
        (WebCore::ChromiumDataObject::containsContentFileExtension):
        (WebCore::ChromiumDataObject::containsContentFileName):
        (WebCore::ChromiumDataObject::setContentFileName):
        (WebCore::ChromiumDataObject::containsFileNames):
        (WebCore::ChromiumDataObject::fileNames):
        (WebCore::ChromiumDataObject::clearFileNames):
        (WebCore::ChromiumDataObject::countFileNames):
        (WebCore::ChromiumDataObject::fileNameAt):
        (WebCore::ChromiumDataObject::setFileNames):
        (WebCore::ChromiumDataObject::appendToFileNames):
        (WebCore::ChromiumDataObject::popFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 13 Oct 2009 22:53:34 +0000 (22:53 +0000)]
2009-10-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Visibility:visible inside a compositing layer doesn't make the element visible
        https://bugs.webkit.org/show_bug.cgi?id=30339

        When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer()
        only consulted hasVisibleContent(), which does not take into a account child layers which
        may be visible. We also have to consult hasVisibleDescendant() as well.

        Test: compositing/compositing-visible-descendant.html

        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::hasVisibleDescendant):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
eric@webkit.org [Tue, 13 Oct 2009 22:51:12 +0000 (22:51 +0000)]
2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
        out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
        This is done in preparation of implementing missing features in DRT.
        No functionality changes made yet.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/EventSenderQt.cpp: Added.
        (EventSender::EventSender):
        (EventSender::mouseDown):
        (EventSender::mouseUp):
        (EventSender::mouseMoveTo):
        (EventSender::leapForward):
        (EventSender::keyDown):
        (EventSender::contextClick):
        (EventSender::scheduleAsynchronousClick):
        (EventSender::frameUnderMouse):
        * DumpRenderTree/qt/EventSenderQt.h: Added.
        (EventSender::clearKillRing):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::reset):
        (LayoutTestController::processWork):
        (LayoutTestController::maybeDump):
        (LayoutTestController::waitUntilDone):
        (LayoutTestController::notifyDone):
        (LayoutTestController::windowCount):
        (LayoutTestController::clearBackForwardList):
        (LayoutTestController::dumpEditingCallbacks):
        (LayoutTestController::dumpResourceLoadCallbacks):
        (LayoutTestController::queueBackNavigation):
        (LayoutTestController::queueForwardNavigation):
        (LayoutTestController::queueLoad):
        (LayoutTestController::queueReload):
        (LayoutTestController::queueScript):
        (LayoutTestController::provisionalLoad):
        (LayoutTestController::timerEvent):
        (LayoutTestController::encodeHostName):
        (LayoutTestController::decodeHostName):
        (LayoutTestController::setJavaScriptProfilingEnabled):
        (LayoutTestController::setFixedContentsSize):
        (LayoutTestController::setPrivateBrowsingEnabled):
        (LayoutTestController::setPopupBlockingEnabled):
        (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
        (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
        (LayoutTestController::numberOfActiveAnimations):
        (LayoutTestController::disableImageLoading):
        (LayoutTestController::dispatchPendingLoadRequests):
        (LayoutTestController::setDatabaseQuota):
        (LayoutTestController::clearAllDatabases):
        (LayoutTestController::whiteListAccessFromOrigin):
        (LayoutTestController::waitForPolicyDelegate):
        (LayoutTestController::overridePreference):
        * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
        (LayoutTestController::isLoading):
        (LayoutTestController::setLoading):
        (LayoutTestController::shouldDumpAsText):
        (LayoutTestController::shouldDumpBackForwardList):
        (LayoutTestController::shouldDumpChildrenAsText):
        (LayoutTestController::shouldDumpDatabaseCallbacks):
        (LayoutTestController::shouldDumpStatusCallbacks):
        (LayoutTestController::shouldWaitUntilDone):
        (LayoutTestController::canOpenWindows):
        (LayoutTestController::shouldDumpTitleChanges):
        (LayoutTestController::waitForPolicy):
        (LayoutTestController::dumpAsText):
        (LayoutTestController::dumpChildFramesAsText):
        (LayoutTestController::dumpDatabaseCallbacks):
        (LayoutTestController::dumpStatusCallbacks):
        (LayoutTestController::setCanOpenWindows):
        (LayoutTestController::dumpBackForwardList):
        (LayoutTestController::setCloseRemainingWindowsWhenComplete):
        (LayoutTestController::display):
        (LayoutTestController::dumpTitleChanges):
        (LayoutTestController::dumpSelectionRect):
        * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
        (TextInputController::TextInputController):
        (TextInputController::doCommand):
        * DumpRenderTree/qt/TextInputControllerQt.h: Added.
        * DumpRenderTree/qt/WorkQueue.cpp:
        * DumpRenderTree/qt/WorkQueue.h:
        * DumpRenderTree/qt/WorkQueueItem.h:
        * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
        (findFrameNamed):
        (LoadItem::invoke):
        (ReloadItem::invoke):
        (ScriptItem::invoke):
        (BackForwardItem::invoke):
        * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 13 Oct 2009 22:17:32 +0000 (22:17 +0000)]
2009-10-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        https://bugs.webkit.org/show_bug.cgi?id=30278

        Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        from the make system into common code.

        Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API
        support is not enabled.

        Remove notImplemented() from PluginPackageNone.cpp and
        PluginDataNone.cpp make them just empty functions.

        * GNUmakefile.am:
        * WebCore.pro:
        * plugins/PluginDataNone.cpp:
        (WebCore::PluginData::initPlugins):
        (WebCore::PluginData::refresh):
        * plugins/PluginPackageNone.cpp:
        (WebCore::PluginPackage::determineQuirks):
        (WebCore::PluginPackage::fetchInfo):
        (WebCore::PluginPackage::load):

2009-10-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        https://bugs.webkit.org/show_bug.cgi?id=30278

        Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
        from the make system into common code.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, adding myself to the list of reviewers.
dimich@chromium.org [Tue, 13 Oct 2009 22:02:54 +0000 (22:02 +0000)]
Not reviewed, adding myself to the list of reviewers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Tue, 13 Oct 2009 22:02:38 +0000 (22:02 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=30150
        <rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types

        Test: editing/pasteboard/crash-accessing-clipboardData-types.html

        * platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String
        class doesn't have operator bool, it's operator NSString* that is invoked instead, and it
        converts null strings to non-null @"".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
andersca@apple.com [Tue, 13 Oct 2009 21:59:54 +0000 (21:59 +0000)]
<rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API

Reviewed by Sam Weinig.

WebKit/mac:

Listen for WebPreferences notifications and update the _isPrivateBrowsingEnabled ivar
when the value changes. Also call -[WebBaseNetscapePluginView privateBrowsingModeDidChange] when the
value changes. In process this just calls NPP_SetValue, and OOP it sends a MIG message to the plug-in host.

* Plugins/Hosted/NetscapePluginHostManager.h:
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::privateBrowsingModeDidChange):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView privateBrowsingModeDidChange]):
* Plugins/Hosted/WebKitPluginHost.defs:
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView privateBrowsingModeDidChange]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView preferencesHaveChanged:]):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView getVariable:value:]):

WebKitTools:

Make the private browsing mode testable by the test plug-in.

* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginGetProperty):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_SetValue):

LayoutTests:

Add test.

* platform/mac-snowleopard/Skipped:
Remove now passing tests that was fixed by https://bugs.webkit.org/show_bug.cgi?id=30295.

* plugins/private-browsing-mode-expected.txt: Added.
* plugins/private-browsing-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowindow attributes (like localStorage) that are disabled at runtime are still visible
atwilson@chromium.org [Tue, 13 Oct 2009 21:44:38 +0000 (21:44 +0000)]
window attributes (like localStorage) that are disabled at runtime are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240

Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by Dimitri Glazkov.

Adding codegen/bindings to support runtime disabling of attributes.

No new tests (only supported by chrome currently)

* bindings/scripts/CodeGeneratorV8.pm:
Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct.
Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance.
* bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes):
Refactored attribute setting code into a common inline routine.
* bindings/v8/V8Proxy.h:
(WebCore::configureAttribute):
Inline function which configures a single attribute given a BatchedAttribute struct.
* bindings/v8/custom/V8CustomBinding.h:
Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
Added code to enable window.Audio only if MediaPlayer.isAvailable() == true
* page/DOMWindow.idl:
Added [EnabledAtRuntime] extended attribute to the Audio attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 13 Oct 2009 21:24:39 +0000 (21:24 +0000)]
2009-10-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        ARM compiler does not understand reinterpret_cast<void*>
        https://bugs.webkit.org/show_bug.cgi?id=29034

        Change reinterpret_cast<void*> to regular C style (void*) cast
        for the ARM RVCT compiler.

        * assembler/MacroAssemblerCodeRef.h:
        (JSC::FunctionPtr::FunctionPtr):
        * jit/JITOpcodes.cpp: Cast to FunctionPtr first
           instead of directly casting to reinterpret_cast
        * jit/JITStubCall.h: Ditto + change the type of m_stub
          from void* to FunctionPtr.
        (JSC::JITStubCall::JITStubCall):
        (JSC::JITStubCall::call):
        * jit/JITStubs.cpp: Ditto.
        (JSC::DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
eric@webkit.org [Tue, 13 Oct 2009 20:53:12 +0000 (20:53 +0000)]
2009-10-13  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27457
        Test case for static email validation on type=email input elements as
        per HTML5 specs:
        http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state

        * fast/forms/ValidityState-typeMismatch-email-expected.txt: Added.
        * fast/forms/ValidityState-typeMismatch-email.html: Added.
        * fast/forms/resources/ValidityState-typeMismatch-email.js: Added.
        ():
2009-10-13  Michelangelo De Simone  <micdesim@gmail.com>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27457
        Added support for static validation on type=email input elements as per
        HTML5 specs:
        http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state

        Test: fast/forms/ValidityState-typeMismatch-email.html

        * html/ValidityState.cpp:
        (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch
        performs validation on type=email input elements now.
        (WebCore::ValidityState::isValidEmailAddress): simple validation method
        * html/ValidityState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Dmitry Titov <dimich@chromium.org>
eric@webkit.org [Tue, 13 Oct 2009 20:27:04 +0000 (20:27 +0000)]
2009-10-13  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Adam Barth.

        Event listeners installed on a window object returned from window.open() don't work
        https://bugs.webkit.org/show_bug.cgi?id=28716

        * http/tests/security/resources/has-window-events.html: Added.
        * http/tests/security/window-events-clear-domain-expected.txt: Added.
        * http/tests/security/window-events-clear-domain.html: Added.
        * http/tests/security/window-events-clear-port-expected.txt: Added.
        * http/tests/security/window-events-clear-port.html: Added.
        * http/tests/security/window-events-pass-expected.txt: Added.
        * http/tests/security/window-events-pass.html: Added.
2009-10-13  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Adam Barth.

        Event listeners installed on a window object returned from window.open() don't work
        https://bugs.webkit.org/show_bug.cgi?id=28716

        Tests: http/tests/security/window-events-clear-domain.html
               http/tests/security/window-events-clear-port.html
               http/tests/security/window-events-pass.html

        * dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all
        window event handlers when implicitOpen is called. It is called in 2 cases - on
        committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers).

        (WebCore::Document::open): in addition to calling implicitOpen it also removes window
        event handlers, to preserve the behavior of document.open().

        (WebCore::Document::implicitOpen): includes the part of removed Document::clear() that
        does not remove window event handlers.

        * dom/Document.h: Removed clear().

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers
        if we transition from temporary empty document to a loaded one.

        (WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading.
        (WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a leak in the inspector by calling didRemoveNode with
bweinstein@apple.com [Tue, 13 Oct 2009 20:03:23 +0000 (20:03 +0000)]
Fix a leak in the inspector by calling didRemoveNode with
an error code when it fails, instead of returning from the
Backend.

Reviewed by Pavel Feldman.

* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
* inspector/front-end/ElementsTreeOutline.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
bweinstein@apple.com [Tue, 13 Oct 2009 19:01:02 +0000 (19:01 +0000)]
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
Web Inspector: Should be able to delete nodes from the Elements Tree.

Reviewed by Timothy Hatcher.

When the delete key is pressed and a element is selected in the tree,
the element should be deleted from the Elements Tree and the DOM.

* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didRemoveNode):
* inspector/InspectorFrontend.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateModifiedNodes):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix REGRESSION(49479): Mouseover on resources graph doesn't show timings.
bweinstein@apple.com [Tue, 13 Oct 2009 17:08:18 +0000 (17:08 +0000)]
Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings.

Reviewed by Timothy Hatcher.

Set pointer-events: none on the new overlay so mouseover events are passed
to the resources graph so we can show timings.

* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 17:04:39 +0000 (17:04 +0000)]
2009-10-13  Pavel Feldman  <pfeldman@chromium.org>

        No review, just adding self to the list of reviewers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Girish Ramakrishnan <girish@forwardbias.in>
eric@webkit.org [Tue, 13 Oct 2009 14:27:11 +0000 (14:27 +0000)]
2009-10-13  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Simon Hausmann.

        [Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.

        This is a bug for two reasons:
        1. Everytime we use winId(), we end up creating a native widget. This causes an
        unnecessary copy of contents from the backing store to the native widget.
        2. Neither windowed nor windowless plugins require the winId of the QWebView or
        QGraphicsView.

        Introduce ownerWidget() which returns a QWidget * without creating a native widget
        (as opposed to QWidget::find(winId)).

       https://bugs.webkit.org/show_bug.cgi?id=30170

        * platform/qt/PlatformScreenQt.cpp:
        (WebCore::screenDepthPerComponent):
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::show):
        * platform/qt/QWebPageClient.h:
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::setSharedXEventFields):
        (WebCore::PluginView::initXEvent):
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::platformStart):
2009-10-13  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Simon Hausmann.

        [Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.

        This is a bug for two reasons:
        1. Everytime we use winId(), we end up creating a native widget. This causes an
        unnecessary copy of contents from the backing store to the native widget.
        2. Neither windowed nor windowless plugins require the winId of the QWebView or
        QGraphicsView.

        Introduce ownerWidget() which returns a QWidget * without creating a native widget
        (as opposed to QWidget::find(winId)).

        https://bugs.webkit.org/show_bug.cgi?id=30170

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::ownerWidget):
        * Api/qwebview.cpp:
        (QWebViewPrivate::ownerWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix for typo in filename
kov@webkit.org [Tue, 13 Oct 2009 13:26:21 +0000 (13:26 +0000)]
Unreviewed fix for typo in filename

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 12:14:11 +0000 (12:14 +0000)]
2009-10-13  Pavel Feldman  <pfeldman@chromium.org>

        Layout test fix, reverting previous change.

        Reverting r49499 as it caused several layout test failures.

        * inspector/console-tests-expected.txt: Removed.
        * inspector/console-tests.html: Removed.
        * inspector/elements-panel-structure-expected.txt: Removed.
        * inspector/elements-panel-structure.html: Removed.
        * inspector/evaluate-in-frontend-expected.txt: Removed.
        * inspector/evaluate-in-frontend.html: Removed.
        * inspector/evaluate-in-frontend.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 11:53:48 +0000 (11:53 +0000)]
2009-10-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add initial layout tests for web inspector.

        https://bugs.webkit.org/show_bug.cgi?id=30014

        * inspector/console-tests-expected.txt: Added.
        * inspector/console-tests.html: Added.
        * inspector/elements-panel-structure-expected.txt: Added.
        * inspector/elements-panel-structure.html: Added.
        * inspector/evaluate-in-frontend-expected.txt: Added.
        * inspector/evaluate-in-frontend.html: Added.
        * inspector/evaluate-in-frontend.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
tonikitoo@webkit.org [Tue, 13 Oct 2009 11:35:36 +0000 (11:35 +0000)]
[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
https://bugs.webkit.org/show_bug.cgi?id=30296

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.

* tests/qwebpage/tst_qwebpage.cpp:
(ErrorPage::ErrorPage):
(ErrorPage::supportsExtension):
(ErrorPage::extension):
(tst_QWebPage::errorPageExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] better handle possible edge cases on qwebframe::requestedUrl use
tonikitoo@webkit.org [Tue, 13 Oct 2009 10:57:13 +0000 (10:57 +0000)]
[Qt] better handle possible edge cases on qwebframe::requestedUrl use
https://bugs.webkit.org/show_bug.cgi?id=30216

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.

QWebFrame::requestedUrl can be called at any time during the load
process, including:

* An error handling (whereas an alternate error page for unsuccessful
  load is being set);
* A ssl error exception call;
* Navigation notifications (titleChanged, urlChanged, progresses,
  addHistoryEntry, etc);
* Among others.

This patch makes requestedUrl calls to fallback to FrameLoaderClient
m_loadError's failingURL when an error has occurred, unless it is
null/empty.

Also, m_loadError is now being reset at each the main frame starts a
load, in order to avoid previous load errors footprints.

* Api/qwebframe.cpp:
(QWebFrame::requestedUrl):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:28:45 +0000 (08:28 +0000)]
2009-10-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Adam Roben.

        Web Inspector: Use proper web view in inspector layout
        tests for windows.

        https://bugs.webkit.org/show_bug.cgi?id=30298

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Alexander Pavlov <apavlov@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:26:34 +0000 (08:26 +0000)]
2009-10-12  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.
        Alter profile link format to enable multiple profile types
        https://bugs.webkit.org/show_bug.cgi?id=30253

        The new profile URL includes the profile type along with the
        profile title and uid.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfileFinishedMessageToConsole):
        (WebCore::InspectorController::addStartProfilingMessageToConsole):
        * inspector/front-end/inspector.js:
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector.linkifyStringAsFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Alexander Pavlov <apavlov@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:19:52 +0000 (08:19 +0000)]
2009-10-12  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Fix same-named profiles grouping in the Profiles panel.

        The tree node re-parenting while adding a new group node was broken.

        https://bugs.webkit.org/show_bug.cgi?id=30299

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.addProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 13 Oct 2009 08:16:53 +0000 (08:16 +0000)]
2009-10-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Enforce async interaction between inspector controller and frontend.

        https://bugs.webkit.org/show_bug.cgi?id=30300

        * inspector/front-end/inspector.js:
        (WebInspector.dispatch.delayDispatch):
        (WebInspector.dispatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 13 Oct 2009 06:11:19 +0000 (06:11 +0000)]
2009-10-12  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Missing default value for the default text encoding.
        https://bugs.webkit.org/show_bug.cgi?id=30311

        QtWebKit has provided a default, hardcoded value for default charset but since
        the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
        value has had no effect.

        Added a regression test and unskipped fast/dom/Document/document-charset.html,
        which is passing now.

        * platform/qt/Skipped:
2009-10-12  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Missing default value for the default text encoding.
        https://bugs.webkit.org/show_bug.cgi?id=30311

        QtWebKit has provided a default, hardcoded value for default charset but since
        the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
        value has had no effect.

        Added a regression test and unskipped fast/dom/Document/document-charset.html,
        which is passing now.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::defaultTextEncoding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange <a name> to id="" to fix styling problems
cam@webkit.org [Tue, 13 Oct 2009 05:38:56 +0000 (05:38 +0000)]
Change <a name> to id="" to fix styling problems
https://bugs.webkit.org/show_bug.cgi?id=30283

Reviewed by Eric Seidel.

This prevents the headings from being styled like links.

* coding/contributing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Xiaomei Ji <xji@chromium.org>
eric@webkit.org [Tue, 13 Oct 2009 04:59:36 +0000 (04:59 +0000)]
2009-10-12  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Sam Weinig.

        Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
        scrolled page.
        https://bugs.webkit.org/show_bug.cgi?id=30034

        * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
        * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
        * fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
        * fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-12  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Sam Weinig.

        Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
        scrolled page.
        https://bugs.webkit.org/show_bug.cgi?id=30034

        * dom/Document.cpp:
        (WebCore::Document::elementFromPoint): calculate the correct point
        relative to document when the page is zoomed and scrolled.
        (WebCore::Document::caretRangeFromPoint): calculate the correct point
        relative to document when the page is zoomed and scrolled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 13 Oct 2009 04:22:11 +0000 (04:22 +0000)]
2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed.  Fix 4 layout test failures by webkit r49488

        WebKit r49488 enables window.WebSocket back.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
ukai@chromium.org [Tue, 13 Oct 2009 01:44:18 +0000 (01:44 +0000)]
WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

Test: fast/websockets/websocket-event-target.html

* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* websockets/WebSocket.idl:

WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests: Add a test to verify WebSocket's EventTarget methods.
https://bugs.webkit.org/show_bug.cgi?id=29841

Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).

* fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
* fast/websockets/script-tests/websocket-event-target.js: Added.
(openListener):
(messageListener):
(closeListener):
* fast/websockets/websocket-event-target-expected.txt: Added.
* fast/websockets/websocket-event-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=29078
weinig@apple.com [Tue, 13 Oct 2009 00:47:41 +0000 (00:47 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=29078
<rdar://problem/7288221>

Reviewed by Darin Adler.

WebCore:

Add a mechanism to blacklist certain codecs.  Initially, just blacklist UTF-7 as HTML5 encourages.

* platform/text/TextEncodingRegistry.cpp:
(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

LayoutTests:

Test the lack of UTF-7 support. Remove old UTF-7 tests.

* fast/encoding/char-decoding-expected.txt:
* fast/encoding/char-decoding.html:
* http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
* http/tests/misc/submit-get-in-utf7.html: Removed.
* http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
* http/tests/misc/submit-post-in-utf7.html: Removed.
* http/tests/misc/url-in-utf7-expected.txt: Removed.
* http/tests/misc/url-in-utf7.html: Removed.
* http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
* http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
* http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
* http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for the beforeload event to frames. Complete support of the beforeload...
hyatt@apple.com [Tue, 13 Oct 2009 00:37:02 +0000 (00:37 +0000)]
Add support for the beforeload event to frames.  Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed).  Add support
for the Objective-C wrapper class as well.

Reviewed by Darin Adler.

Added fast/dom/beforeload/frame-before-load.html

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/objc/DOMEvents.mm:
(kitClass):
* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::isBeforeLoadEvent):
* dom/Event.cpp:
(WebCore::Event::isBeforeLoadEvent):
* dom/Event.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 13 Oct 2009 00:27:10 +0000 (00:27 +0000)]
2009-10-12  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium Port - Windows
        https://bugs.webkit.org/show_bug.cgi?id=29969

        * chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.
2009-10-12  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium Port - Windows
        https://bugs.webkit.org/show_bug.cgi?id=29969

        * Scripts/pdevenv: removed msvc's /useenv for chromium builds
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix <rdar://problem/7094146> Reproducible crash at
mitz@apple.com [Mon, 12 Oct 2009 23:49:46 +0000 (23:49 +0000)]
WebCore: Fix <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

Test: fast/dynamic/position-absolute-to-fixed-crash.html

The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.

LayoutTests: Test for <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()

Reviewed by Simon Fraser.

* fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
* fast/dynamic/position-absolute-to-fixed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Mon, 12 Oct 2009 23:20:33 +0000 (23:20 +0000)]
2009-10-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        Add a palette() method that is needed by our RenderTheme.

        * platform/qt/QWebPageClient.h:
2009-10-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        Implement the new palette() methods on the page clients

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::palette):
        * Api/qwebview.cpp:
        (QWebViewPrivate::palette):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49483 268f45cc-cd09-0410-ab3c-d52691b4dbfc