WebKit-https.git
8 years agoRemove this horribly outdated file. It was showing up in
dino@apple.com [Sat, 29 Oct 2011 00:10:11 +0000 (00:10 +0000)]
Remove this horribly outdated file. It was showing up in
Google searches and shouldn't be used as official
documentation.

Rubber-stamped by Simon Fraser.

* specs/MediaQueriesExtensions.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit.py gdb visualizer is broken after change to StringImpl
commit-queue@webkit.org [Sat, 29 Oct 2011 00:03:46 +0000 (00:03 +0000)]
webkit.py gdb visualizer is broken after change to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=71154

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

r98624 changed StringImpl m_data to m_data32. This changes updates
webkit.py to match.

* gdb/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFactor ContextDestructionObserver out of ActiveDOMObject
abarth@webkit.org [Fri, 28 Oct 2011 23:57:21 +0000 (23:57 +0000)]
Factor ContextDestructionObserver out of ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=71153

Reviewed by Sam Weinig.

This patch paves the way to make more objects observe the destruction
of ScriptExecutioContext without needing to add ifdefs to
ScriptExecutionContext.h/cpp.  (As an example, see DOMURL.)

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* dom/ActiveDOMObject.h:
(WebCore::ContextDestructionObserver::scriptExecutionContext):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
(WebCore::didCreateDestructionObserver):
(WebCore::willDestroyDestructionObserver):
* dom/ScriptExecutionContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names
joepeck@webkit.org [Fri, 28 Oct 2011 23:51:12 +0000 (23:51 +0000)]
<webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names

Reviewed by Dan Bernstein.

* Scripts/check-for-inappropriate-objc-class-names:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for sending scroll-update events from EventSender.
commit-queue@webkit.org [Fri, 28 Oct 2011 23:44:30 +0000 (23:44 +0000)]
Add support for sending scroll-update events from EventSender.
https://bugs.webkit.org/show_bug.cgi?id=66272

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-10-28
Reviewed by Adam Barth.

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::reset):
(EventSender::gestureScrollUpdate):
(EventSender::gestureEvent):
* DumpRenderTree/chromium/EventSender.h:

LayoutTests:

* fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
* fast/events/touch/gesture/gesture-scroll.html: Added.
* platform/chromium/fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
jeffm@apple.com [Fri, 28 Oct 2011 23:35:08 +0000 (23:35 +0000)]
More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=71156

Don't include PDF and PostScript types in the set of MIME types with custom representations
when initializing the web process if WebKitOmitPDFSupport is set.

I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
shown inline when this preference was set, but to be complete we should exclude the MIME
types here as well.

Reviewed by Alexey Proskuryakov.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
eric@webkit.org [Fri, 28 Oct 2011 23:31:41 +0000 (23:31 +0000)]
new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOne more unreviewed build fix due to r98775.
timothy_horton@apple.com [Fri, 28 Oct 2011 23:31:11 +0000 (23:31 +0000)]
One more unreviewed build fix due to r98775.

No new tests.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Track wheel event handler registration and pass to input filter
jamesr@google.com [Fri, 28 Oct 2011 23:30:07 +0000 (23:30 +0000)]
[chromium] Track wheel event handler registration and pass to input filter
https://bugs.webkit.org/show_bug.cgi?id=71078

Reviewed by Kenneth Russell.

Source/WebCore:

This propagates mouse wheel registration notifications to the compositor input filter. If there are any handlers
registered, which includes JS handlers and scrollable areas other than the main view, the input filter will pass
mouse wheel events to the widget. Otherwise when threaded compositing is enabled the input filter translates
wheel events into root layer scrolling.

Only changes behavior with an off-by-default flag enabled, so no tests.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setHaveWheelEventHandlers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers):
* platform/graphics/chromium/cc/CCScrollController.h:

Source/WebKit/chromium:

Pushes mouse wheel event handler notifications to CCLayerTreeHost when compositing.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix due to r98775.
timothy_horton@apple.com [Fri, 28 Oct 2011 23:27:32 +0000 (23:27 +0000)]
Unreviewed build fix due to r98775.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIf visibility changes while an accelerated animation is running, element jumps around
simon.fraser@apple.com [Fri, 28 Oct 2011 23:18:08 +0000 (23:18 +0000)]
If visibility changes while an accelerated animation is running, element jumps around
https://bugs.webkit.org/show_bug.cgi?id=29984

Source/WebCore:

Reviewed by Chris Marrin.

Compositing now affects whether RenderLayers for visibility:hidden elements
are included in z-order lists. So we have to dirty those lists when we enter
compopsiting mode.

Test: compositing/visibility/animation-visibility.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitespace.
(WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal(), which doesn't have
to ping the compositor.
(WebCore::RenderLayer::dirtyZOrderListsInternal):
(WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursively dirty z-order
lists.
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode): When going into compositing mode,
dirty all z-order lists.

LayoutTests:

Reviewed by Chris Marrin.

Add testcase for visibility changing in the middle of an accelerated animation.

* animations/resources/animation-test-helpers.js: Add some constants for readability.
(checkExpectedValue): Add support for testing 'visibility'.
* compositing/visibility/animation-visibility-expected.png: Added.
* compositing/visibility/animation-visibility-expected.txt: Added.
* compositing/visibility/animation-visibility.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement CSS3 Images cross-fade() image function
timothy_horton@apple.com [Fri, 28 Oct 2011 23:08:51 +0000 (23:08 +0000)]
Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Parse -webkit-cross-fade according to the CSS3 Images Values specification.

Also, adjust other CSS parsing functions to support nested functions, by using a specific CSS value list
instead of the global one. This allows - for example - cross-fade to pass each of its arguments back into
parseFillImage and to successfully parse image functions in this fashion.

Test: fast/css/getComputedStyle/computed-style-cross-fade.html

* WebCore.xcodeproj/project.pbxproj:
* css/CSSCrossfadeValue.cpp: Added.
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::cssText):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):
* css/CSSCrossfadeValue.h: Added.
(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isFixedSize):
(WebCore::CSSCrossfadeValue::setFromImage):
(WebCore::CSSCrossfadeValue::setToImage):
(WebCore::CSSCrossfadeValue::setPercentage):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCanvas):
* css/CSSParser.h:

Add tests to ensure that -webkit-cross-fade is parsed correctly.

* fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-cross-fade.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempted build fix after r98765.
mitz@apple.com [Fri, 28 Oct 2011 23:06:00 +0000 (23:06 +0000)]
Attempted build fix after r98765.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS grammar doesn't support functions with no parameters
cmarrin@apple.com [Fri, 28 Oct 2011 22:55:37 +0000 (22:55 +0000)]
CSS grammar doesn't support functions with no parameters
https://bugs.webkit.org/show_bug.cgi?id=69110

Reviewed by Dean Jackson.

Source/WebCore:

Add rule to grammar to accept functions with 0 args and return
this case with a CSSParserValueList with 0 values. Also fixed
filter creation function to properly handle filters with 0
arguments.

* css/CSSGrammar.y:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):

LayoutTests:

Updated tests to include tests for allowing 0 argument functions and for
disallowing functions with trailing commas (to pickup a couple of theses
cases not in the current tests). Also fixed one typo.

* css3/filters/filter-property-computed-style-expected.txt:
* css3/filters/filter-property-parsing-expected.txt:
* css3/filters/filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/filter-property-computed-style.js:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:
(testFilterRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r98757.
johnnyg@google.com [Fri, 28 Oct 2011 22:34:42 +0000 (22:34 +0000)]
Unreviewed, rolling out r98757.
http://trac.webkit.org/changeset/98757
https://bugs.webkit.org/show_bug.cgi?id=71150

crashes webkit_unit_tests on chromium windows (Requested by
johnny_g on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRubber-stamped by Eric Seidel.
abarth@webkit.org [Fri, 28 Oct 2011 22:21:49 +0000 (22:21 +0000)]
Rubber-stamped by Eric Seidel.

Fix namespace indent in ScriptExecutionContext.h.

* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isDocument):
(WebCore::ScriptExecutionContext::isWorkerContext):
(WebCore::ScriptExecutionContext::setHasOpenDatabases):
(WebCore::ScriptExecutionContext::hasOpenDatabases):
(WebCore::ScriptExecutionContext::url):
(WebCore::ScriptExecutionContext::completeURL):
(WebCore::ScriptExecutionContext::securityOrigin):
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
(WebCore::ScriptExecutionContext::activeDOMObjects):
(WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::messagePorts):
(WebCore::ScriptExecutionContext::domUrls):
(WebCore::ScriptExecutionContext::ref):
(WebCore::ScriptExecutionContext::deref):
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: WebCore part of:
sullivan@apple.com [Fri, 28 Oct 2011 22:07:16 +0000 (22:07 +0000)]
Source/WebCore: WebCore part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
Bail out if backspace navigation is not enabled.

* page/Settings.cpp:
(WebCore::Settings::Settings):
Initialize m_backspaceKeyNavigationEnabled to true to match current behavior.

* page/Settings.h:
Declared m_backspaceKeyNavigationEnabled.
(WebCore::Settings::setBackspaceKeyNavigationEnabled):
New function, simple setter.
(WebCore::Settings::backspaceKeyNavigationEnabled):
New function, simple getter.

Source/WebKit/mac: WebKit part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* WebView/WebFrameView.mm:
(-[WebFrameView keyDown:]):
Honor the new preference.

* WebView/WebPreferenceKeysPrivate.h:
Added #define for WebKitBackspaceKeyNavigationEnabledKey

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Initialize new pref to YES, to match current behavior.
(-[WebPreferences setBackspaceKeyNavigationEnabled:]):
New method, standard prefs setter.
(-[WebPreferences backspaceKeyNavigationEnabled]):
New method, standard prefs getter.

* WebView/WebPreferencesPrivate.h:
Declared new methods.

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* Shared/WebPreferencesStore.h:
Declared backspaceKeyNavigationEnabled property using macro. This initializes
it to true, to match current behavior.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBackspaceKeyNavigationEnabled):
New function, pass value to impl.
(WKPreferencesGetBackspaceKeyNavigationEnabled):
New function, returns result from impl.

* UIProcess/API/C/WKPreferences.h:
Declared API functions for new preference.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Updates WebCore settings from WebKit2 prefs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
johnnyg@google.com [Fri, 28 Oct 2011 21:55:59 +0000 (21:55 +0000)]
Unreviewed gardening.

* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/dom: Removed.
* platform/chromium-cg-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium-cg-mac/svg/hixie/perf: Removed.
* platform/chromium-cg-mac/svg/hixie/perf/001-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/visibility: Added.
* platform/chromium-gpu-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-gpu-win/compositing/visibility: Added.
* platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
* platform/chromium-linux/svg/hixie/perf/001-expected.png:
* platform/chromium-mac-snowleopard/fast/dom: Removed.
* platform/chromium-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium-mac/svg/hixie/perf/001-expected.png: Removed.
* platform/chromium-mac/svg/hixie/perf/001-expected.txt: Removed.
* platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Removed.
* platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOverridden clippedOverflowRectForRepaint() still uses IntRects
eae@chromium.org [Fri, 28 Oct 2011 21:55:11 +0000 (21:55 +0000)]
Overridden clippedOverflowRectForRepaint() still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71046

Reviewed by Simon Fraser.

Change all virtual clippedOverflowRectForRepaint functions to use the
same signature.

No new tests.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
* rendering/RenderText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused parsers for 'exception' and 'alias' IDL keywords
adamk@chromium.org [Fri, 28 Oct 2011 21:46:17 +0000 (21:46 +0000)]
Remove unused parsers for 'exception' and 'alias' IDL keywords
https://bugs.webkit.org/show_bug.cgi?id=71140

Reviewed by Adam Barth.

* bindings/scripts/IDLParser.pm:
(ParseInterface):
(DetermineParseMode):
(ProcessSection):
* bindings/scripts/IDLStructure.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10288006> Emoji characters are too close to each other in small font...
mitz@apple.com [Fri, 28 Oct 2011 21:41:43 +0000 (21:41 +0000)]
<rdar://problem/10288006> Emoji characters are too close to each other in small font size

Reviewed by Sam Weinig.

Source/WebCore:

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color bitmap font, use
-[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances().

LayoutTests:

* platform/mac/fast/css/font-family-pictograph-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused default constructor
abarth@webkit.org [Fri, 28 Oct 2011 21:30:44 +0000 (21:30 +0000)]
Remove unused default constructor
https://bugs.webkit.org/show_bug.cgi?id=71136

Reviewed by Eric Seidel.

No one is calling this constructor anymore now that we've fixed the
callers.

* dom/make_exception_code_description.pl:
(generateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when splitting inline flows with generated floats
commit-queue@webkit.org [Fri, 28 Oct 2011 21:28:39 +0000 (21:28 +0000)]
Crash when splitting inline flows with generated floats
https://bugs.webkit.org/show_bug.cgi?id=70458

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-28
Reviewed by David Hyatt.

Source/WebCore:

When lineBoxes on a RenderBlock are being deleted, we now check the floating object list to
ensure references to them are being cleared.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox when deleting them

LayoutTests:

Added test for crash condition when splitting inline flows on an object with generated floats.

* fast/css-generated-content/inline-splitting-with-after-float-crash.html: Added
* fast/css-generated-content/inline-splitting-with-after-float-crash-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Leopard-only code from GraphicsLayerCA
simon.fraser@apple.com [Fri, 28 Oct 2011 21:26:57 +0000 (21:26 +0000)]
Remove Leopard-only code from GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=71141

Reviewed by Chris Marrin.

Remove !HAVE_MODERN_QUARTZCORE code, which was only
used on Leopard. updateContentsTransform() became a no-op,
so could be removed.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::defaultContentsOrientation):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):
* platform/graphics/ca/GraphicsLayerCA.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport using a different front-end for the Web Inspector in WebKit2.
timothy@apple.com [Fri, 28 Oct 2011 20:51:52 +0000 (20:51 +0000)]
Support using a different front-end for the Web Inspector in WebKit2.

rdar://problem/10318665
https://webkit.org/b/71089

Reviewed by Sam Weinig.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Added webInspectorBasePath and webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetOverrideWebInspectorBaseDirectory): Added. Calls through to WebContext.
(WKContextSetOverrideWebInspectorPagePath): Ditto.
(WKContextSetOverrideWebInspectorLocalizedStringsPath): Ditto.
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess): Set webInspectorBasePath and webInspectorLocalizedStringsPath.
* UIProcess/WebContext.h:
(WebKit::WebContext::overrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::setOverrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::overrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorLocalizedStringsPath): Added.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectorPageURL): Use WebContext::overrideWebInspectorPagePath if set.
(WebKit::WebInspectorProxy::inspectorBaseURL): Use WebContext::overrideWebInspectorBaseDirectory if set.
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::globalInspectorLocalizedStringsURL): Added. Static storage for the setting.
(WebKit::WebInspector::setLocalizedStringsPath): Added. Set globalInspectorLocalizedStringsURL.
(WebKit::WebInspector::localizedStringsURL): Return globalInspectorLocalizedStringsURL.
* WebProcess/com.apple.WebProcess.sb: Added read-only subpath for WEBKIT_WEB_INSPECTOR_DIR.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::appendReadonlySandboxDirectory): Check path for empty to prevent an exception when
calling through to fileSystemRepresentation.
(WebKit::initializeSandbox): Added WEBKIT_WEB_INSPECTOR_DIR parameter.
(WebKit::WebProcess::platformInitializeWebProcess): Call WebInspector::setLocalizedStringsPath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNRWT crashes when parsing leaks output due to UTF-8 decoding error
eric@webkit.org [Fri, 28 Oct 2011 20:46:29 +0000 (20:46 +0000)]
NRWT crashes when parsing leaks output due to UTF-8 decoding error
https://bugs.webkit.org/show_bug.cgi?id=71112

Reviewed by Adam Barth.

Use read_binary_file instead of read_text_file and add a test
case with some non-utf8 data to make sure we don't break this in the future.

* Scripts/webkitpy/layout_tests/port/leakdetector.py:
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Implicitly skip render surfaces that won't be drawn
enne@google.com [Fri, 28 Oct 2011 20:44:58 +0000 (20:44 +0000)]
[chromium] Implicitly skip render surfaces that won't be drawn
https://bugs.webkit.org/show_bug.cgi?id=71038

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up BuiltInPDFView a little
ap@apple.com [Fri, 28 Oct 2011 20:27:44 +0000 (20:27 +0000)]
Clean up BuiltInPDFView a little
https://bugs.webkit.org/show_bug.cgi?id=71133

Reviewed by Daniel Bates.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::createScrollbar):
Removed an incorrect FIXME. Custom scrollbars specified in a document don't apply
to subframes, and thus shouldn't apply to PDFs.

* WebProcess/Plugins/PDF/BuiltInPDFView.h: (WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):
Moved to a correct location. This is not a Plugin method, but a ScrollView one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAutogenerate Exception-downcast code in bindings
abarth@webkit.org [Fri, 28 Oct 2011 20:20:50 +0000 (20:20 +0000)]
Autogenerate Exception-downcast code in bindings
https://bugs.webkit.org/show_bug.cgi?id=71108

Reviewed by Eric Seidel.

This patch uses the same generated code style as we're using for Events
to generate the downcasts for the Exception types in the bindings.
This cause me to refactor more code from make_event_factory.pl into
InFilesCompiler.pm.

After this patch, some of these files and scripts are misnamed.  I'll
rename them in a followup patch.

* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/objc/ExceptionHandlers.mm:
(WebCore::raiseDOMException):
* bindings/scripts/InFilesCompiler.pm:
(initializeFromCommandLine):
(compile):
(interfaceForItem):
(toMacroStyle):
(generateInterfacesHeader):
(generateHeadersHeader):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* dom/ExceptionCodeDescription.in:
* dom/make_event_factory.pl:
(generateCode):
(generateImplementation):
* dom/make_exception_code_description.pl:
(defaultItemFactory):
(generateCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowatchlist should not CC the bug reporter
levin@chromium.org [Fri, 28 Oct 2011 19:58:04 +0000 (19:58 +0000)]
watchlist should not CC the bug reporter
https://bugs.webkit.org/show_bug.cgi?id=71079

Reviewed by Adam Barth.

Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.

* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
* Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
* Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix builds which have ACCELERATED_COMPOSITING disabled.
simon.fraser@apple.com [Fri, 28 Oct 2011 19:42:43 +0000 (19:42 +0000)]
Fix builds which have ACCELERATED_COMPOSITING disabled.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateZOrderLists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
johnnyg@google.com [Fri, 28 Oct 2011 19:36:50 +0000 (19:36 +0000)]
Unreviewed gardening.

* platform/chromium-cg-mac-leopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/svg/hixie: Added.
* platform/chromium-cg-mac-snowleopard/svg/hixie/perf: Added.
* platform/chromium-cg-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-cg-mac/svg/hixie/perf/002-expected.png: Removed.
* platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
* platform/chromium-linux/svg/hixie/perf/002-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png:
* platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png:
* platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
* platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-mac/svg/batik/text/textOnPath-expected.png: Removed.
* platform/chromium-mac/svg/hixie/perf/002-expected.png: Removed.
* platform/chromium-mac/svg/hixie/perf/002-expected.txt: Removed.
* platform/chromium-win-vista/svg/batik/text: Removed.
* platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Added.
* platform/chromium-win/svg/batik/text/textOnPath-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/chromium/fast/js/array-prototype-properties-expected.txt: Replaced.
* platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Removed.
* platform/chromium/fast/js/kde/RegExp-expected.txt: Removed.
* platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove LegacyDefaultOptionalArguments flag from inspector IDLs
arv@chromium.org [Fri, 28 Oct 2011 19:29:00 +0000 (19:29 +0000)]
Remove LegacyDefaultOptionalArguments flag from inspector IDLs
https://bugs.webkit.org/show_bug.cgi?id=65748

Reviewed by Adam Barth.

Covered by existing tests.

* inspector/InjectedScriptHost.idl:
* inspector/InspectorFrontendHost.idl:
* inspector/JavaScriptCallFrame.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Database metadata changes should be tied to transaction
commit-queue@webkit.org [Fri, 28 Oct 2011 19:22:27 +0000 (19:22 +0000)]
IndexedDB: Database metadata changes should be tied to transaction
https://bugs.webkit.org/show_bug.cgi?id=70974

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

Source/WebCore:

Database metadata (that is, the version string) was rolled back
on abort by an abort task. If the abort task didn't run e.g.
due to a crash, the metadata would not be reverted. All of the
other store/index/data changes were written into the transaction
itself, so the metadata now is too. Refactored the metadata
get/create/update methods for clarity as well.

Note that the new tests don't actually verify that the code handles
this case; that will need to be done with persistence tests
that span multiple runs of the browser and induce crashes.
The new tests do verify that these changes don't cause regressions
not caught by other tests.

Tests: storage/indexeddb/open-during-transaction.html
       storage/indexeddb/version-change-abort.html

* storage/IDBBackingStore.h:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
* storage/IDBLevelDBBackingStore.h:

LayoutTests:

* storage/indexeddb/open-during-transaction-expected.txt: Added.
* storage/indexeddb/open-during-transaction.html: Added.
* storage/indexeddb/version-change-abort-expected.txt: Added.
* storage/indexeddb/version-change-abort.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse enum instead of bool to represent -webkit-column-span property.
macpherson@chromium.org [Fri, 28 Oct 2011 19:15:26 +0000 (19:15 +0000)]
Use enum instead of bool to represent -webkit-column-span property.
https://bugs.webkit.org/show_bug.cgi?id=70867

Reviewed by Darin Adler.

Covered by existing tests.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createAnonymousColumnSpanBlock):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::columnSpan):
(WebCore::InheritedFlags::setColumnSpan):
(WebCore::InheritedFlags::initialColumnSpan):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleMultiColData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstan...
mhahnenberg@apple.com [Fri, 28 Oct 2011 19:08:24 +0000 (19:08 +0000)]
De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject
https://bugs.webkit.org/show_bug.cgi?id=70968

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* API/JSCallbackObject.cpp: Added two specializations for createStructure that use different JSTypes in their
TypeInfo.  Had to also create a specialization for JSNonFinalObject, even JSGlobalObject was the only that
needed it because Windows wouldn't build without it.
(JSC::::createStructure):
* API/JSCallbackObject.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ErrorInstance.h: Removed virtual function and changed JSType provided to TypeInfo in createStructure.
(JSC::ErrorInstance::createStructure):
* runtime/ErrorPrototype.h: Ditto
(JSC::ErrorPrototype::createStructure):
* runtime/JSActivation.h: Ditto
(JSC::JSActivation::createStructure):
* runtime/JSGlobalObject.h: Ditto
(JSC::JSGlobalObject::createStructure):
* runtime/JSObject.h: De-virtualized functions.  They now check the JSType of the object for the corresponding type.
(JSC::JSObject::isGlobalObject):
(JSC::JSObject::isVariableObject):
(JSC::JSObject::isActivationObject):
(JSC::JSObject::isErrorInstance):
* runtime/JSType.h: Added new types for GlobalObject, VariableObject, ActivationObject, and ErrorInstance.
* runtime/JSVariableObject.cpp: Removed virtual function.
* runtime/JSVariableObject.h: Changed JSType provided to TypeInfo in createStructure.
(JSC::JSVariableObject::createStructure):

Source/WebCore:

No new tests.

* bindings/js/JSDOMGlobalObject.h: Changed JSType provided to TypeInfo in createStructure since this
class inherits from JSGlobalObject.
(WebCore::JSDOMGlobalObject::createStructure):
* bindings/js/JSDOMWindowBase.h: Ditto
(WebCore::JSDOMWindowBase::createStructure):
* bindings/js/JSWorkerContextBase.h: Ditto
(WebCore::JSWorkerContextBase::createStructure):
* bindings/scripts/CodeGeneratorJS.pm: Added extra check to make sure subclasses of JSGlobalObject,
namely JSDOMWindow and JSWorkerContext, get their special JSType in their createStructure function.
(GenerateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded some missing results for compositing visibilty tests.
simon.fraser@apple.com [Fri, 28 Oct 2011 18:57:35 +0000 (18:57 +0000)]
Added some missing results for compositing visibilty tests.

* platform/mac/compositing/visibility/visibility-composited-expected.txt: Added.
* platform/mac/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
* platform/mac/compositing/visibility/visibility-image-layers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r98736.
commit-queue@webkit.org [Fri, 28 Oct 2011 18:43:36 +0000 (18:43 +0000)]
Unreviewed, rolling out r98736.
http://trac.webkit.org/changeset/98736
https://bugs.webkit.org/show_bug.cgi?id=71125

This patch broke perf/array-binary-search.html test (Requested
by annacc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::addTrack):
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
* html/HTMLTrackElement.h:
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

* media/track/track-load-error-readyState-expected.txt: Removed.
* media/track/track-load-error-readyState.html: Removed.
* media/track/track-load-from-element-readyState-expected.txt: Removed.
* media/track/track-load-from-element-readyState.html: Removed.
* media/track/track-load-from-src-readyState-expected.txt: Removed.
* media/track/track-load-from-src-readyState.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTesting allowed identifier chars which are greater than 126
zherczeg@webkit.org [Fri, 28 Oct 2011 18:40:14 +0000 (18:40 +0000)]
Testing allowed identifier chars which are greater than 126
https://bugs.webkit.org/show_bug.cgi?id=71097

Reviewed by Darin Adler.

* fast/css/parsing-css-nonascii-expected.txt: Added.
* fast/css/parsing-css-nonascii.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderTableSection::recalcCells should not free its grid
jchaffraix@webkit.org [Fri, 28 Oct 2011 18:04:14 +0000 (18:04 +0000)]
RenderTableSection::recalcCells should not free its grid
https://bugs.webkit.org/show_bug.cgi?id=71056

Reviewed by Darin Adler.

Refactoring only, no change in behavior.

r98614 had the bad side effect of clearing the row vector (m_grid) on
the RenderTableSection when doing a recalcCells. This change removes the
unneeded free and inline the |row| field into the RowStruct as it made
no sense to have it as a pointer.

* rendering/RenderTableSection.cpp:
(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Mechanical changes now that |row| is a member of RowStruct.

(WebCore::RenderTableSection::~RenderTableSection): Clear our row vector.

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::recalcCells):
Those 2 functions were refactored to use fillRowsWithDefaultStartingAtPosition.

(WebCore::RenderTableSection::fillRowsWithDefaultStartingAtPosition):
Factored the code to fill the RowStruct structure with default values.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
More mechanical change after the |row| field change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnskip tables/mozilla_expected_failures/bugs/bug14007-2.html
rniwa@webkit.org [Fri, 28 Oct 2011 18:00:36 +0000 (18:00 +0000)]
Unskip tables/mozilla_expected_failures/bugs/bug14007-2.html
since the test was rebaselined in r98691.

Also enable platform/mac/editing/deleting/backward-delete.html on Chromium Mac
and skip it again on Chromium Windows and Linux.

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement load notification and events for <track>.
annacc@chromium.org [Fri, 28 Oct 2011 17:54:32 +0000 (17:54 +0000)]
Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html
       media/track/track-load-from-element-readyState.html
       media/track/track-load-from-src-readyState.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::loadNextTextTrack):
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):
* html/HTMLTrackElement.h:
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

* media/track/track-load-error-readyState-expected.txt: Added.
* media/track/track-load-error-readyState.html: Added.
* media/track/track-load-from-element-readyState-expected.txt: Added.
* media/track/track-load-from-element-readyState.html: Added.
* media/track/track-load-from-src-readyState-expected.txt: Added.
* media/track/track-load-from-src-readyState.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden...
simon.fraser@apple.com [Fri, 28 Oct 2011 17:46:38 +0000 (17:46 +0000)]
Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html
       compositing/visibility/visibility-composited.html
       compositing/visibility/visibility-image-layers-dynamic.html
       compositing/visibility/visibility-image-layers.html

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.
* platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,
added ContentsVisibilityChanged flag.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.
* rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

* compositing/visibility/visibility-composited-expected.png: Added.
* compositing/visibility/visibility-composited-transforms-expected.png: Added.
* compositing/visibility/visibility-composited-transforms.html: Added.
* compositing/visibility/visibility-composited.html: Added.
* compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* compositing/visibility/visibility-image-layers-dynamic.html: Added.
* compositing/visibility/visibility-image-layers-expected.png: Added.
* compositing/visibility/visibility-image-layers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJS Test Harness: Remove js-test-post-function.js
arv@chromium.org [Fri, 28 Oct 2011 17:35:50 +0000 (17:35 +0000)]
JS Test Harness: Remove js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=70959

Reviewed by Ojan Vafai.

This moves isSuccessfullyParsed to js-test-pre.js and removes js-test-post-function.js and all references to it.

* fast/js/resources/js-test-post-function.js: Removed.
* fast/js/resources/js-test-pre.js:
(isSuccessfullyParsed): Moved here from js-test-post-function.js

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoempty-urls.html needs to stop being flaky.
japhet@chromium.org [Fri, 28 Oct 2011 16:58:33 +0000 (16:58 +0000)]
empty-urls.html needs to stop being flaky.
Because it was in http/tests/loading, it output
frame load callbacks, and it was unpredictable whether
the callback for onload or for the load completing would
be called first. Ergo, move the test to http/tests/misc,
and remove the logic which failed to enforce a frame load
callback ordering.
https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

* http/tests/loading/empty-urls-expected.txt: Removed.
* http/tests/loading/empty-urls.html: Removed.
* http/tests/misc/empty-urls-expected.txt: Copied from LayoutTests/http/tests/loading/empty-urls-expected.txt.
* http/tests/misc/empty-urls.html: Copied from LayoutTests/http/tests/loading/empty-urls.html.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Build fixes for glib 2.31 (current master)
philn@webkit.org [Fri, 28 Oct 2011 16:47:14 +0000 (16:47 +0000)]
[GTK] Build fixes for glib 2.31 (current master)
https://bugs.webkit.org/show_bug.cgi?id=70679

Reviewed by Martin Robinson.

g_cond_new and g_mutex_new have been replaced by _init
functions. Same for _free, replaced by _clear.

* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_init):
(webkit_video_sink_dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename a number of methods mentioning JavaScript to just Script instead
jochen@chromium.org [Fri, 28 Oct 2011 16:29:26 +0000 (16:29 +0000)]
Rename a number of methods mentioning JavaScript to just Script instead
https://bugs.webkit.org/show_bug.cgi?id=71105

Reviewed by Adam Barth.

Source/WebCore:

* WebCore.exp.in:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowScript):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setScriptEnabled):
* page/Settings.h:
(WebCore::Settings::isScriptEnabled):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowScript):
* src/FrameLoaderClientImpl.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::collectGarbage):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setJavaScriptEnabled):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_enable_scripts_set):

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld):
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit/wince:

* WebView.cpp:
(WebView::WebView):

Source/WebKit/wx:

* WebSettings.cpp:
(wxWebSettings::SetJavaScriptEnabled):
(wxWebSettings::IsJavaScriptEnabled):
* WebView.cpp:
(wxWebView::Create):

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
jchaffraix@webkit.org [Fri, 28 Oct 2011 16:22:18 +0000 (16:22 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
Remove fast/replaced/table-percent-height.html that has been passing for at least
a week. Also tighten some tests that have not been passing (but occasionally timing
out) on the flakyness dashboard for some time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatti...
vsevik@chromium.org [Fri, 28 Oct 2011 14:57:53 +0000 (14:57 +0000)]
Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd watchlist for QtWebKit2 API and for WK2's Qt specific files.
zoltan@webkit.org [Fri, 28 Oct 2011 14:52:19 +0000 (14:52 +0000)]
Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
https://bugs.webkit.org/show_bug.cgi?id=71116

Reviewed by David Levin.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Fri, 28 Oct 2011 14:42:56 +0000 (14:42 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed gardening.
ossy@webkit.org [Fri, 28 Oct 2011 13:59:58 +0000 (13:59 +0000)]
[Qt][WK2] Unreviewed gardening.

REGRESSION: 5 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=71117

* platform/qt-wk2/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReset line numbers for scripts generated with document.write.
pfeldman@chromium.org [Fri, 28 Oct 2011 13:27:32 +0000 (13:27 +0000)]
Reset line numbers for scripts generated with document.write.
https://bugs.webkit.org/show_bug.cgi?id=71099

Reviewed by Yury Semikhatsky.

Source/JavaScriptCore:

* wtf/text/TextPosition.h:
(WTF::OrdinalNumber::OrdinalNumber):

Source/WebCore:

Test: http/tests/inspector-enabled/document-write.html

* dom/Document.h:
(WebCore::Document::isInDocumentWrite):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):

LayoutTests:

* http/tests/inspector-enabled/document-write-expected.txt: Added.
* http/tests/inspector-enabled/document-write.html: Added.
* platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 28 Oct 2011 13:10:36 +0000 (13:10 +0000)]
2011-10-28  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Unsupress css3/font-feature-settings-rendering.html as it should
        pass on Linux after r98716.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
ossy@webkit.org [Fri, 28 Oct 2011 13:06:52 +0000 (13:06 +0000)]
[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
https://bugs.webkit.org/show_bug.cgi?id=70494

One more buildfix. (unreviewed)

* UIProcess/API/qt/qtouchwebpage.cpp:
(computeEffectiveOpacity):
(QTouchWebPage::itemChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
ossy@webkit.org [Fri, 28 Oct 2011 13:06:34 +0000 (13:06 +0000)]
[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
https://bugs.webkit.org/show_bug.cgi?id=70494

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-10-28
Reviewed by Kenneth Christiansen.

Use QQuick* instead of QSG* as well as QStandardPaths
instead of QDesktopLocation.

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):

Source/WebKit2:

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::event):
(QDesktopWebViewPrivate::engine):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):
(QTouchWebView::touchEvent):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/tests/testwindow.h:
(TestWindow::TestWindow):
(TestWindow::resizeEvent):
* UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::createPopupMenuProxy):
* UIProcess/qt/QtSGUpdateQueue.cpp:
(WebKit::QtSGUpdateQueue::QtSGUpdateQueue):
* UIProcess/qt/QtSGUpdateQueue.h:
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::engine):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDataLocation):
* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
* UIProcess/qt/WebPopupMenuProxyQtDesktop.h:
(WebKit::WebPopupMenuProxyQtDesktop::create):

Tools:

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::setDiskCache):
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac build fix after r98711
aroben@apple.com [Fri, 28 Oct 2011 12:37:55 +0000 (12:37 +0000)]
Mac build fix after r98711

* WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h private so WebKit can
find it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
jocelyn.turcotte@nokia.com [Fri, 28 Oct 2011 12:28:31 +0000 (12:28 +0000)]
[Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=71106

Reviewed by Simon Hausmann.

Holding Ctrl allows multiple touch points to be held on the screen using
mouse buttons. It would previously only prevent TouchReleased to be sent
and would require another MouseButtonRelease to be sent without holding Ctrl.

This patch makes sure that all held touch points are released when Ctrl
is released if MouseButtonRelease was received.
It also removes the touch QEvent::Type logic since it's currently handled
by QtGui by observing the modified touch points.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
* MiniBrowser/qt/MiniBrowserApplication.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] MiniBrowser needs a -window-size option
kenneth@webkit.org [Fri, 28 Oct 2011 12:20:13 +0000 (12:20 +0000)]
[Qt] MiniBrowser needs a -window-size option
https://bugs.webkit.org/show_bug.cgi?id=70999

Reviewed by Simon Hausmann.

Add an -window-size option useful for testing the viewport handling.
Also clean up the option handling.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
(WindowOptions::setRequestedWindowSize):
(WindowOptions::requestedWindowSize):
* MiniBrowser/qt/utils.cpp:
(takeOptionValue):
* MiniBrowser/qt/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Make the kinetic engine use the same curve and constants as on the N9
kenneth@webkit.org [Fri, 28 Oct 2011 12:18:03 +0000 (12:18 +0000)]
[Qt] Make the kinetic engine use the same curve and constants as on the N9
https://bugs.webkit.org/show_bug.cgi?id=71102

Reviewed by Simon Hausmann.

Now that we are using the QScroller for kinetic scrolling and page
interaction, we need to make sure it uses the same curve (exponential)
and the same values as the MeeGo Touch physics engine used on the N9.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] css3/font-feature-settings-rendering.html has incorrect image result after...
antti@apple.com [Fri, 28 Oct 2011 11:47:47 +0000 (11:47 +0000)]
[Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542
https://bugs.webkit.org/show_bug.cgi?id=71019

Source/WebCore:

Reviewed by Andreas Kling.

These properties need to be marked inherited too.

Note that the new test case doesn't fail even without the patch. If I understand correctly
the image test in the title is pretty much the only way to see this. However the
new test improves code coverage and protects against future regressions.

Test: fast/css/inherited-properties-rare-text.html

* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):

LayoutTests:

Reviewed by Andreas Kling.

* fast/css/inherited-properties-rare-text-expected.txt: Added.
* fast/css/inherited-properties-rare-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove getExceptionCodeDescription()
abarth@webkit.org [Fri, 28 Oct 2011 09:52:28 +0000 (09:52 +0000)]
Remove getExceptionCodeDescription()
https://bugs.webkit.org/show_bug.cgi?id=71103

Reviewed by Eric Seidel.

Source/WebCore:

This function serves no purpose.

* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/objc/ExceptionHandlers.mm:
(WebCore::raiseDOMException):
* bindings/scripts/CodeGeneratorGObject.pm:
():
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* dom/ExceptionCode.cpp:
* dom/ExceptionCode.h:

Source/WebKit/chromium:

Migrate to new API.

* src/StorageInfoChromium.cpp:
* src/WebStorageQuotaCallbacksImpl.cpp:
(WebKit::WebStorageQuotaCallbacksImpl::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CSS background-image applied inline shows a warning, but still works.
apavlov@chromium.org [Fri, 28 Oct 2011 09:43:30 +0000 (09:43 +0000)]
Web Inspector: CSS background-image applied inline shows a warning, but still works.
https://bugs.webkit.org/show_bug.cgi?id=70325

Reviewed by Antti Koivisto.

Source/WebCore:

This change eliminates the "non-parsed property" warning displayed next to any
"background-image" property of an element's inline style.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseDeclaration):
* css/CSSParser.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

* inspector/styles/styles-new-API-expected.txt:
* inspector/styles/styles-new-API.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fixenate Qt.
abarth@webkit.org [Fri, 28 Oct 2011 09:36:43 +0000 (09:36 +0000)]
Attempt to fixenate Qt.

* CodeGenerators.pri:
* dom/make_event_factory.pl:
(toMacroStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Clean-up unused functions in WebIDBFactory
hans@chromium.org [Fri, 28 Oct 2011 09:27:05 +0000 (09:27 +0000)]
IndexedDB: Clean-up unused functions in WebIDBFactory
https://bugs.webkit.org/show_bug.cgi?id=71011

Reviewed by Tony Chang.

This is a clean-up after r97453. Since Chromium was updated,
these functions are no longer used.

* public/WebIDBFactory.h:
(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExceptionCode.cpp shouldn't need to know about every feature that throws exceptions
abarth@webkit.org [Fri, 28 Oct 2011 09:11:50 +0000 (09:11 +0000)]
ExceptionCode.cpp shouldn't need to know about every feature that throws exceptions
https://bugs.webkit.org/show_bug.cgi?id=70890

Reviewed by Eric Seidel.

.:

Add a code generation step.

* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Generate the feature-specific parts of ExceptionCode.cpp from a ".in"
file.  This is an incremental step towards inlining
getExceptionCodeDescription into its callers and replacing the switch
statements at those locations with autogenerated code.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* dom/DOMCoreException.cpp:
(WebCore::DOMCoreException::initializeDescription):
* dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
* dom/ExceptionCode.h:
* dom/ExceptionCodeDescription.in: Added.
* dom/make_exception_code_description.pl: Added.
(defaultItemFactory):
(generateCode):
(generateHeader):
(generateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CallStackSidebarPane should remove discarded Placards from RawSourceCo...
yurys@chromium.org [Fri, 28 Oct 2011 09:09:29 +0000 (09:09 +0000)]
Web Inspector: CallStackSidebarPane should remove discarded Placards from RawSourceCode listeners list
https://bugs.webkit.org/show_bug.cgi?id=70996

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/callstack-placards-discarded.html

* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
* inspector/front-end/Placard.js:
(WebInspector.Placard.prototype.toggleSelected):
(WebInspector.Placard.prototype.discard):

LayoutTests:

* inspector/debugger/callstack-placards-discarded-expected.txt: Added.
* inspector/debugger/callstack-placards-discarded.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 28 Oct 2011 08:48:16 +0000 (08:48 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd allowScriptFromSource callback to FrameLoaderClient
jochen@chromium.org [Fri, 28 Oct 2011 08:16:59 +0000 (08:16 +0000)]
Add allowScriptFromSource callback to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=71013

Reviewed by Darin Fisher.

Source/WebCore:

Test: platform/chromium/permissionclient/script-permissions.html

* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowScriptFromSource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

Source/WebKit/chromium:

* public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowScriptFromSource):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowScriptFromSource):
* src/FrameLoaderClientImpl.h:

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setScriptsAllowed):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowScriptFromSource):
(WebPermissions::setScriptsAllowed):
(WebPermissions::reset):
* DumpRenderTree/chromium/WebPermissions.h:

LayoutTests:

* platform/chromium/permissionclient/resources/script.js: Added.
* platform/chromium/permissionclient/script-permissions-expected.txt: Added.
* platform/chromium/permissionclient/script-permissions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API
carlosgc@webkit.org [Fri, 28 Oct 2011 08:12:53 +0000 (08:12 +0000)]
[GTK] Add webkit_web_view_get_uri() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=70814

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(didStartProvisionalLoadForFrame): Update WebView URI to make sure
it's updated to provisional URL.
(didReceiveServerRedirectForProvisionalLoadForFrame): Update
WebView URI if there's a server redirection.
(didCommitLoadForFrame): Update WebView URI to make sure it
contains the final one.
(didSameDocumentNavigationForFrame): Update WebView URI when a
navigation action within the same document is performed.
(webkitWebLoaderClientAttachLoaderClientToPage): Add
implementation for didSameDocumentNavigationForFrame callback.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add URI property.
(webkitWebViewUpdateURI): Check whether current active URI has
changed to updated it and emit ::notify signal if it changes.
(webkit_web_view_load_uri): Call webkitWebViewUpdateURI() to make
sure the active URI is updated when load operation is started.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_go_back): Ditto.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_get_uri): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h: Add
webkitWebViewUpdateURI().
* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(provisionalLoadStartedCallback): Check provisional URL is the
requested URI.
(provisionalLoadReceivedServerRedirectCallback): Check provisional
URL after server redirection is the expected redirected URI.
(provisionalLoadFailedCallback): Check active URI.
(loadCommittedCallback): Ditto.
(loadFinishedCallback): Ditto.
(loadFailedCallback): Ditto
(LoadTrackingTest::LoadTrackingTest): Check active URI is NULL
before any loading operation has started.
* UIProcess/API/gtk/tests/LoadTrackingTest.h:
(LoadTrackingTest::setRedirectURI): Set the redirect URI to check
it after a server redirection.
* UIProcess/API/gtk/tests/TestBackForwardList.cpp:
(testBackForwardListNavigation): Use WebViewTest methods for
navigation actions instead of using WebKitWebView API directly.
(testBackForwardListLimitAndCache): Ditto.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testLoadingStatus): Ditto.
(testLoadingError): Ditto.
(testLoadAlternateContent): Ditto.
(testLoadCancelled): Ditto.
(testWebViewReload): Ditto.
(testLoadProgress): Ditto.
(testWebViewActiveURI): Add a test to check that notify signal is
emitted when active URI changes and it's correctly updated when
loader client signals are emitted.
(beforeAll): Add active-uri test.
* UIProcess/API/gtk/tests/WebViewTest.cpp: Add custom load methods
wrapping the WebKitWebView ones, to initialize the active URI to
the requested one, so that it can be checked by the loader client
test.
(WebViewTest::loadURI):
(WebViewTest::loadAlternateHTML):
(WebViewTest::goBack):
(WebViewTest::goForward):
(WebViewTest::goToBackForwardListItem):
* UIProcess/API/gtk/tests/WebViewTest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Synchronize tiling with accelerated compositing
hausmann@webkit.org [Fri, 28 Oct 2011 07:59:18 +0000 (07:59 +0000)]
[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2011-10-21
Reviewed by Simon Hausmann.

Make QTouchWebView always render with accelerated compositing.
At first, the web content would only render after the rest of the scene has rendered. In a
future patch we'll enable rendering the web content via an FBO, which would cover all other
cases as well.

Right now this only works for QTouchWebView, and thus accelerated compositing is disabled
for desktop web-views. This required adding some settings enablers in Q
WebPreferencesPrivate. Those are not exposed to the public API, as they are an implementation
detail.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::initSceneGraphConnections):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::setPage):
(computeEffectiveOpacity):
(QTouchWebPagePrivate::paintToCurrentGLContext):
(QTouchWebPagePrivate::_q_onAfterSceneRender):
(QTouchWebPagePrivate::_q_onSceneGraphInitialized):
(QTouchWebPage::itemChange):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::get):
* UIProcess/API/qt/qwebpreferences_p.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::renderNextFrame):
* UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::QtDesktopWebPageProxy):
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::setViewNeedsDisplay):
* UIProcess/qt/QtTouchWebPageProxy.cpp:
(QtTouchWebPageProxy::QtTouchWebPageProxy):
(QtTouchWebPageProxy::createDrawingAreaProxy):
(QtTouchWebPageProxy::renderToCurrentGLContext):
(QtTouchWebPageProxy::setVisibleContentRectAndScale):
(QtTouchWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtTouchWebPageProxy::renderNextFrame):
* UIProcess/qt/QtTouchWebPageProxy.h:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize):
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update Chromium test expectation.
yutak@chromium.org [Fri, 28 Oct 2011 07:39:59 +0000 (07:39 +0000)]
Unreviewed, update Chromium test expectation.

* platform/chromium/test_expectations.txt:
Mark http/tests/websocket/tests/hybi/reserved-bits.html as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor make_event_factory.pl to use InFilesCompiler.pm
abarth@webkit.org [Fri, 28 Oct 2011 07:20:58 +0000 (07:20 +0000)]
Refactor make_event_factory.pl to use InFilesCompiler.pm
https://bugs.webkit.org/show_bug.cgi?id=71094

Reviewed by Eric Seidel.

This refactoring helps share code with
make_exception_code_descriptions.pl, which is coming in a future patch.
I have a dream of refactoring make_names.pl to use this module as well.

* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/scripts/action_makenames.py:
* bindings/scripts/InFilesCompiler.pm: Added.
(itemHandler):
(parameterHandler):
(new):
(compile):
(license):
* dom/make_event_factory.pl:
(defaultItemFactory):
(interfaceForEvent):
(generateCode):
(printFactoryFile):
(printMacroFile):
(printHeadersFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded myself as a committer.
achicu@adobe.com [Fri, 28 Oct 2011 07:18:36 +0000 (07:18 +0000)]
Added myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove WinCairo from the set of core builders. WinCairo rarely builds
abarth@webkit.org [Fri, 28 Oct 2011 07:01:23 +0000 (07:01 +0000)]
Remove WinCairo from the set of core builders.  WinCairo rarely builds
and is never green.

Rubber-stamped by Eric Seidel.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Implement frame rate control portions of CCScheduler
nduca@chromium.org [Fri, 28 Oct 2011 06:50:19 +0000 (06:50 +0000)]
[chromium] Implement frame rate control portions of CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=70713

Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Added.
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::postTickTask):
(WebCore::CCDelayBasedTimeSource::onTick):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Added.
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::~CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setClient):
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
* platform/graphics/chromium/cc/CCFrameRateController.cpp: Added.
(WebCore::CCFrameRateControllerTimeSourceAdapter::create):
(WebCore::CCFrameRateControllerTimeSourceAdapter::~CCFrameRateControllerTimeSourceAdapter):
(WebCore::CCFrameRateControllerTimeSourceAdapter::onTimerTick):
(WebCore::CCFrameRateControllerTimeSourceAdapter::CCFrameRateControllerTimeSourceAdapter):
(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::~CCFrameRateController):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):
(WebCore::CCFrameRateController::didAbortAllPendingFrames):
* platform/graphics/chromium/cc/CCFrameRateController.h: Added.
(WebCore::CCFrameRateControllerClient::~CCFrameRateControllerClient):
(WebCore::CCFrameRateController::setClient):
(WebCore::CCFrameRateController::setActive):
* platform/graphics/chromium/cc/CCTimeSource.h: Added.
(WebCore::CCTimeSourceClient::~CCTimeSourceClient):
(WebCore::CCTimeSource::~CCTimeSource):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCDelayBasedTimeSourceTest.cpp: Added.
(WebKitTests::TEST):
* tests/CCFrameRateControllerTest.cpp: Added.
(WebKitTests::FakeCCFrameRateControllerClient::FakeCCFrameRateControllerClient):
(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::frameBegun):
(WebKitTests::FakeCCFrameRateControllerClient::beginFrame):
(WebKitTests::TEST):
* tests/CCLayerTreeHostTest.cpp:
* tests/CCSchedulerTestCommon.h: Added.
(WebKitTests::FakeCCTimeSourceClient::FakeCCTimeSourceClient):
(WebKitTests::FakeCCTimeSourceClient::reset):
(WebKitTests::FakeCCTimeSourceClient::tickCalled):
(WebKitTests::FakeCCTimeSourceClient::onTimerTick):
(WebKitTests::FakeCCThread::FakeCCThread):
(WebKitTests::FakeCCThread::reset):
(WebKitTests::FakeCCThread::hasPendingTask):
(WebKitTests::FakeCCThread::runPendingTask):
(WebKitTests::FakeCCThread::pendingDelay):
(WebKitTests::FakeCCThread::postTask):
(WebKitTests::FakeCCThread::postDelayedTask):
(WebKitTests::FakeCCThread::threadID):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Create .xz tarballs during distcheck
commit-queue@webkit.org [Fri, 28 Oct 2011 06:44:54 +0000 (06:44 +0000)]
[GTK] Create .xz tarballs during distcheck
https://bugs.webkit.org/show_bug.cgi?id=71001

Patch by Priit Laes <plaes@plaes.org> on 2011-10-27
Reviewed by Martin Robinson.

* configure.ac: Switched tarballs to use .xz compression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unskip platform/mac/editing/deleting/backward-delete.html on Chromium because...
rniwa@webkit.org [Fri, 28 Oct 2011 06:26:07 +0000 (06:26 +0000)]
   Unskip platform/mac/editing/deleting/backward-delete.html on Chromium because it passes on my Mac.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGroup editing test expectations for Chromium in one place.
rniwa@webkit.org [Fri, 28 Oct 2011 06:18:02 +0000 (06:18 +0000)]
Group editing test expectations for Chromium in one place.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Mac rebaselines.
rniwa@webkit.org [Fri, 28 Oct 2011 06:06:57 +0000 (06:06 +0000)]
Chromium Mac rebaselines.

* platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png:
* platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png:
* platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png:
* platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png:
* platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png:
* platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png:
* platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png:
* platform/chromium-cg-mac-leopard/editing/pasteboard/4944770-1-expected.png:
* platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png:
* platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png:
* platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-cg-mac-leopard/fast/dom/blur-contenteditable-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/deleting/table-cells-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/execCommand/find-after-replace-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/inserting/4278698-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/3976872-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/selection/select-all-iframe-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/undo: Added.
* platform/chromium-cg-mac-snowleopard/editing/undo/4063751-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/unsupported-content: Added.
* platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDeprecate [V8ConstructorSetsActiveDOMWrapper] IDL
haraken@chromium.org [Fri, 28 Oct 2011 05:52:58 +0000 (05:52 +0000)]
Deprecate [V8ConstructorSetsActiveDOMWrapper] IDL
https://bugs.webkit.org/show_bug.cgi?id=71088

Reviewed by Adam Barth.

I introduced [V8ConstructorSetsActiveDOMWrapper] IDL in bug 66536,
but I found that it has the same meaning as [ActiveDOMObject] IDL.
This patch removes [V8ConstructorSetsActiveDOMWrapper] IDL.

No change in behavior.

Tests: fast/dom/global-constructors.html
       fast/eventsource/eventsource-constructor.html
       fast/eventsource/eventsource-attribute-listeners.html
       fast/files/blob-slice-test.html
       fast/files/file-reader-abort.html
       ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor
       ui_tests:WorkerTest.FLAKY_SharedWorkerFastName
       ui_tests:WorkerTest.FLAKY_WorkerConstructor
       ui_tests:WorkerTest.FLAKY_WorkerEventListener

* bindings/scripts/CodeGeneratorV8.pm: Replaced "V8ConstructorSetsActiveDOMWrapper" with "ActiveDOMObject".
(GenerateConstructorCallback):
* bindings/scripts/test/TestInterface.idl: Ditto.
* bindings/scripts/test/JS/JSTestInterface.cpp: Updated a test result.
(WebCore::isObservable):
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto.
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::V8TestInterface::toActiveDOMObject):
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.h: Ditto.
(WebCore::V8TestInterface::existingWrapper):
* fileapi/FileReader.idl: Removed [V8ConstructorSetsActiveDOMWrapper] IDL.
* mediastream/PeerConnection.idl: Ditto.
* page/EventSource.idl: Ditto.
* workers/SharedWorker.idl: Ditto.
* workers/Worker.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRace condition in SocketStreamHandleCFNet when PAC script is used
yutak@chromium.org [Fri, 28 Oct 2011 05:39:15 +0000 (05:39 +0000)]
Race condition in SocketStreamHandleCFNet when PAC script is used
https://bugs.webkit.org/show_bug.cgi?id=70894

Reviewed by Alexey Proskuryakov.

Pass callback functions that call ref() or deref() as retain/release member
of CFStreamClientContext.

No new tests, as it is not possible to write a test with PAC script enabled.

* platform/network/cf/SocketStreamHandle.h:
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::scheduleStreams):
(WebCore::SocketStreamHandle::retainSocketStreamHandle):
(WebCore::SocketStreamHandle::releaseSocketStreamHandle):
(WebCore::SocketStreamHandle::pacExecutionCallbackMainThread):
This callback may be called after platformClose() is already called. We should
not create new streams in this case.
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::readStreamCallback):
This manual ref/deref can be safely removed as m_readStream holds the reference.
(WebCore::SocketStreamHandle::writeStreamCallback):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSocket: Connecting to localhost:8880 takes one second on Windows
yutak@chromium.org [Fri, 28 Oct 2011 05:39:13 +0000 (05:39 +0000)]
WebSocket: Connecting to localhost:8880 takes one second on Windows
https://bugs.webkit.org/show_bug.cgi?id=64788

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
from timing out on Windows, because this test tries to open a lot of
connections to localhost and each attempt takes one second to fall back from
IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReland patch ensure font load before calling Skia during printing
commit-queue@webkit.org [Fri, 28 Oct 2011 05:37:32 +0000 (05:37 +0000)]
Reland patch ensure font load before calling Skia during printing
https://bugs.webkit.org/show_bug.cgi?id=70390

Patch by Arthur Hsu <arthurhsu@chromium.org> on 2011-10-27
Reviewed by James Robinson.

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest Failure in fast/dom/prototype-inheritance-2.html after r98495
msaboff@apple.com [Fri, 28 Oct 2011 05:22:35 +0000 (05:22 +0000)]
Test Failure in fast/dom/prototype-inheritance-2.html after r98495
https://bugs.webkit.org/show_bug.cgi?id=71058

Rebaselined these results due to hash order changes in r98495.

Reviewed by Darin Adler.

* fast/dom/prototype-inheritance-2-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix the Qt build.
abarth@webkit.org [Fri, 28 Oct 2011 05:11:31 +0000 (05:11 +0000)]
Attempt to fix the Qt build.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove erroneous expected results after r98685.
rniwa@webkit.org [Fri, 28 Oct 2011 05:10:10 +0000 (05:10 +0000)]
Remove erroneous expected results after r98685.

* platform/chromium-linux/editing/selection/click-before-and-after-table-expected.png: Removed.
* platform/chromium-win/editing/selection/click-before-and-after-table-expected.png: Removed.
* platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt: Removed.
* platform/qt/editing/selection/click-before-and-after-table-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobinding test rebaseline after r98679.
rniwa@webkit.org [Fri, 28 Oct 2011 04:58:21 +0000 (04:58 +0000)]
binding test rebaseline after r98679.

* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDis-integrate run-bindings-tests with webkitpy
abarth@webkit.org [Fri, 28 Oct 2011 04:55:21 +0000 (04:55 +0000)]
Dis-integrate run-bindings-tests with webkitpy
https://bugs.webkit.org/show_bug.cgi?id=71092

Reviewed by Ryosuke Niwa.

These tests aren't really adding any value.

* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove type-specific exception descriptions into the implementation files for each...
abarth@webkit.org [Fri, 28 Oct 2011 04:44:36 +0000 (04:44 +0000)]
Move type-specific exception descriptions into the implementation files for each type
https://bugs.webkit.org/show_bug.cgi?id=71081

Reviewed by Eric Seidel.

There's no reason to centralize this information.  It belongs with each
exception type.  This patch is in preparation for autogenerating the central file.

* WebCore.xcodeproj/project.pbxproj:
* dom/DOMCoreException.cpp: Added.
(WebCore::DOMCoreException::initializeDescription):
* dom/DOMCoreException.h:
* dom/EventException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.
(WebCore::EventException::initializeDescription):
* dom/EventException.h:
* dom/ExceptionBase.h:
(WebCore::ExceptionBase::code):
(WebCore::ExceptionBase::name):
(WebCore::ExceptionBase::message):
(WebCore::ExceptionBase::description):
* dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
* dom/RangeException.cpp: Copied from Source/WebCore/xml/XPathException.h.
(WebCore::RangeException::initializeDescription):
* dom/RangeException.h:
* fileapi/FileException.cpp: Added.
(WebCore::FileException::initializeDescription):
* fileapi/FileException.h:
* fileapi/OperationNotAllowedException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.
(WebCore::OperationNotAllowedException::initializeDescription):
* fileapi/OperationNotAllowedException.h:
* storage/IDBDatabaseException.cpp: Added.
(WebCore::IDBDatabaseException::initializeDescription):
* storage/IDBDatabaseException.h:
* storage/SQLException.cpp: Added.
(WebCore::SQLException::initializeDescription):
* storage/SQLException.h:
* svg/SVGException.cpp: Copied from Source/WebCore/dom/EventException.h.
(WebCore::SVGException::initializeDescription):
* svg/SVGException.h:
* xml/XMLHttpRequestException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestException.h.
(WebCore::XMLHttpRequestException::initializeDescription):
* xml/XMLHttpRequestException.h:
* xml/XPathException.cpp: Copied from Source/WebCore/xml/XPathException.h.
(WebCore::XPathException::initializeDescription):
* xml/XPathException.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix click-before-and-after-table.html for Chromium
rniwa@webkit.org [Fri, 28 Oct 2011 04:24:35 +0000 (04:24 +0000)]
Fix click-before-and-after-table.html for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70869

Reviewed by Tony Chang.

Fixed the test by wrapping tests in a function to avoid shadowing "top" variable.

* editing/selection/click-before-and-after-table.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the GTK+ build after r98664.
mrobinson@webkit.org [Fri, 28 Oct 2011 03:50:15 +0000 (03:50 +0000)]
Fix the GTK+ build after r98664.

* WebProcess/Plugins/Plugin.h: Add an IntSize forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate chromium test expectations.
johnnyg@google.com [Fri, 28 Oct 2011 03:50:06 +0000 (03:50 +0000)]
Update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r98639): NRWT crashes when parsing leaks output
eric@webkit.org [Fri, 28 Oct 2011 03:47:02 +0000 (03:47 +0000)]
REGRESSION (r98639): NRWT crashes when parsing leaks output
https://bugs.webkit.org/show_bug.cgi?id=71087

Unreviewed.  Sadly we have no good way to test logging.

* Scripts/webkitpy/layout_tests/port/leakdetector.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCMake: Add support to optionally install the built JavaScript shell
dbates@webkit.org [Fri, 28 Oct 2011 02:54:17 +0000 (02:54 +0000)]
CMake: Add support to optionally install the built JavaScript shell
https://bugs.webkit.org/show_bug.cgi?id=71062

Reviewed by Antonio Gomes.

.:

Adds a CMake option, called SHOULD_INSTALL_JS_SHELL, that when
defined will generate an installation rule to install the built
JavaScript shell into /bin (with respect to the prefix path).

By default, we don't define this option and hence don't generate
an installation rule for the JavaScript shell.

* Source/CMakeLists.txt:

Source/JavaScriptCore:

Generate an installation rule for installing the JavaScript shell in
/bin (with respect to the prefix path) when SHOULD_INSTALL_JS_SHELL
is defined.

* shell/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Fix variable renaming issue inside ewk_view.cpp
commit-queue@webkit.org [Fri, 28 Oct 2011 02:47:48 +0000 (02:47 +0000)]
[EFL] Fix variable renaming issue inside ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=71020

Unreviewed build fix.

Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2011-10-27

* ewk/ewk_view.cpp:
(ewk_view_js_object_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
haraken@chromium.org [Fri, 28 Oct 2011 02:43:12 +0000 (02:43 +0000)]
Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70215

Reviewed by Adam Barth.

Source/JavaScriptCore:

Added a method that judges if a given JSValue is empty.

Tests: transforms/svg-vs-css.xhtml
       transforms/cssmatrix-2d-interface.xhtml
       transforms/cssmatrix-3d-interface.xhtml

* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::isEmpty):

Source/WebCore:

This patch implements [Optional=CallWithNullValue] IDL for JSC.
While a parameter specified as [Optional=CallWithDefaultValue] is
handled as a string "undefined", a parameter specified as
[Optional=CallWithNullValue] is handled as a null string.
(Note: not a string "null", but a null string).

c.f. [Optional=CallWithNullValue] is implemented in V8 in bug 67458.

Tests: fast/dom/global-constructors.html
       transforms/svg-vs-css.xhtml
       transforms/cssmatrix-2d-interface.xhtml
       transforms/cssmatrix-3d-interface.xhtml

* GNUmakefile.list.am: Removed JSWebKitCSSMatrixCustom.cpp.
* UseJSC.cmake: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.
* bindings/js/JSDOMBinding.h: MAYBE_MISSING_PARAMETER(exec, index, policy) returns the index-th parameter, if the parameter exists. It returns an undefined value, if the index-th parameter is missing and the policy is MissingIsUndefined. It returns an empty value, otherwise (i.e. if the index-th parameter is missing and the policy is MissingIsEmpty).
* bindings/js/JSWebKitCSSMatrixCustom.cpp: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck): Supported [Optional=CallWithNullValue].
(GenerateConstructorDefinition): Supported [Optional=CallWithNullValue].
* css/WebKitCSSMatrix.idl: Removed [JSCustomConstructor].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd more test expectations and chromium results.
johnnyg@google.com [Fri, 28 Oct 2011 02:30:16 +0000 (02:30 +0000)]
Add more test expectations and chromium results.

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/css/getComputedStyle: Removed.
* platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Remove most of the documentation errors from WebKit1
mrobinson@webkit.org [Fri, 28 Oct 2011 01:40:49 +0000 (01:40 +0000)]
[GTK] Remove most of the documentation errors from WebKit1
https://bugs.webkit.org/show_bug.cgi?id=70670

Reviewed by Gustavo Noronha Silva.

Fix most of the documentation errors for WebKit and make many
missing symbols show up in the documentation.

* webkit/webkitglobals.h: Doc fixes.
* webkit/webkitspellchecker.h: Ditto.
* webkit/webkitspellcheckerenchant.cpp: Ditto.
* webkit/webkitwebbackforwardlist.h: Ditto.
* webkit/webkitwebdatasource.cpp: Ditto.
* webkit/webkitwebframe.cpp: Ditto.
* webkit/webkitwebinspector.cpp: Ditto.
* webkit/webkitwebinspector.h: Ditto.
* webkit/webkitwebplugin.h: Ditto.
* webkit/webkitwebplugindatabase.cpp: Ditto.
* webkit/webkitwebplugindatabase.h: Ditto.
* webkit/webkitwebsettings.h: Ditto.
* webkit/webkitwebview.cpp: Ditto.
(webkit_web_view_class_init): Ditto.
* webkit/webkitwebview.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderTableCell m_row and m_column should not be signed values
jchaffraix@webkit.org [Fri, 28 Oct 2011 01:28:58 +0000 (01:28 +0000)]
RenderTableCell m_row and m_column should not be signed values
https://bugs.webkit.org/show_bug.cgi?id=70369

Reviewed by Darin Adler.

No new tests, refactoring only.

The gist of the change is to update row / column handling in the table's
rendering code to use unsigned values. Not all the code is switched over
to unsigned but this is a good start.

Using unsigned makes a lot more sense that allowing some negative indexes
to creep in the algorithms. Also it enables us to "free" the unused signed
bit on the 2 RenderTableCell fields that can be used to pack 2 bits in a
follow-up patch.

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cellForColumnAndRow):
Removed 2 casts to int as the left side now computes to an unsigned too.
Added some ASSERT to make sure we don't get negative values (colSpan / rowSpan
are always >= 1 by definition but better to be safe).

* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObjectForSection):
* accessibility/AccessibilityTableColumn.h:
Switched m_columnIndex to unsigned to remove any signed / unsigned comparisons.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::cellAbove):
(WebCore::RenderTable::cellBelow):
(WebCore::RenderTable::cellBefore):
(WebCore::RenderTable::cellAfter):
Mostly mechanical changes to avoid signed / unsigned comparisons or casts.

* rendering/RenderTable.h:
(WebCore::RenderTable::numEffCols):
(WebCore::RenderTable::colToEffCol):
Updated a couple of functions to use an unsigned.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::col):
(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::row):
(WebCore::RenderTableCell::setRow):
Updated after switching the fields to unsigned. Also added 2 constants
to cover the not-initialized-yet value for row and column indexes.
Note: we don't enforce that you can't reach those indexes but neither
did the previous code!

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::clearGrid):
(WebCore::RenderTableSection::numColumns):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Lots of mechanical: signed -> unsigned changes. However we had
to change the logic a bit as it assumed that m_cRow started at
-1 and increased from there. The new meaning of m_cRow is the
number of rows seen and m_cRow - 1 is where to insert your new
cells.

(WebCore::RenderTableSection::addCell):
Checked the callers and all increase m_cRow before calling the function.
Added an ASSERT to catch up wrong usage in the future.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::numRows): Switched to unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98676 268f45cc-cd09-0410-ab3c-d52691b4dbfc