WebKit-https.git
10 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 22:58:04 +0000 (22:58 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] r60803 broke media/controls-drag-timebar.html
        https://bugs.webkit.org/show_bug.cgi?id=40269

        * platform/gtk/Skipped: Unskip test which is now passing.
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] r60803 broke media/controls-drag-timebar.html
        https://bugs.webkit.org/show_bug.cgi?id=40269

        Only queue events while the mouse button is down, if drag mode is enabled. Some
        tests may disable drag mode, to prevent the queuing of events in this situation.

        * DumpRenderTree/gtk/EventSender.cpp:
        (sendOrQueueEvent): Only queue events here if dragMode is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove some CVS directories that snuck into Subversion
aroben@apple.com [Wed, 16 Jun 2010 22:47:47 +0000 (22:47 +0000)]
Remove some CVS directories that snuck into Subversion

These were added back when the Mozilla tables tests were imported.

Rubber-stamped by Dan Berstein.

* tables/mozilla/images/CVS: Removed.
* tables/mozilla_expected_failures/images/CVS: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDelete tables/mozilla/images/adforce_imgis_com.html and its associated results
aroben@apple.com [Wed, 16 Jun 2010 22:38:23 +0000 (22:38 +0000)]
Delete tables/mozilla/images/adforce_imgis_com.html and its associated results

This file is a GIF that somehow obtained a .html extension. It isn't
referenced by any other test. (It was failing on Windows because the
HTML5 parser turns null bytes into U+FFFD, whose rendering is
font-dependent.)

Fixes <http://webkit.org/b/40741> REGRESSION (r61234):
tables/mozilla/images/adforce_imgis_com.html fails on Windows.

Reviewed by Dave Hyatt.

* platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* platform/mac/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/mac/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* platform/qt/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* tables/mozilla/images/adforce_imgis_com.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 22:26:35 +0000 (22:26 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=40600

        * platform/gtk/Skipped: This change exposed some failures which were previously not reported. Skip them.
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=40600

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Reset the click count after a drag starts.
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup): Reset the click count after a load is committed.
        * webkit/webkitprivate.h: Move static click counting variables to be per-view.
        * webkit/webkitwebview.cpp:
        (getEventTime): Added.
        (webkit_web_view_button_press_event): If the event time is zero, use the current time.
        (webkit_web_view_finalize): Clean up click counting member.
        (webkit_web_view_init): Initialize click counting member.
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=40600

        * DumpRenderTree/gtk/EventSender.cpp:
        (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 22:13:12 +0000 (22:13 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add a hidden land-cowboy command to webkit-patch to help land quick
        build fixes.

        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 21:57:34 +0000 (21:57 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 parser crash when setTimeout document.write after slow script
        https://bugs.webkit.org/show_bug.cgi?id=40726

        According to the HTML5 spec, we're supposed to open() a new document if
        we receive a document.write() after we've received EOF for the network.
        The old parser just dumped those bytes onto the end of the network
        stream.  After this patch, our behavior matches Minefield.

        Test: http/tests/misc/write-while-waiting.html

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::write):
        * dom/DocumentParser.h:
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::finishWasCalled):
        * dom/XMLDocumentParser.h:
        * html/HTML5DocumentParser.cpp:
        (WebCore::HTML5DocumentParser::finishWasCalled):
        * html/HTML5DocumentParser.h:
        (WebCore::HTML5DocumentParser::InputStream::isClosed):
        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::finishWasCalled):
        * html/HTMLDocumentParser.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finishWasCalled):
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::finishWasCalled):
        * loader/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::finishWasCalled):
        * loader/SinkDocument.cpp:
        (WebCore::SinkDocumentParser::finishWasCalled):
        * loader/TextDocument.cpp:
        (WebCore::TextDocumentParser::finishWasCalled):
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 parser crash when setTimeout document.write after slow script
        https://bugs.webkit.org/show_bug.cgi?id=40726

        Adds a test for what happens when we receive a document.write() while
        we're waiting for an external script to load (and after receiving EOF
        from the network).

        * http/tests/misc/write-while-waiting-expected.txt: Added.
        * http/tests/misc/write-while-waiting.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 21:56:28 +0000 (21:56 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Enable HTML5 Parser in Safari on Mac
        https://bugs.webkit.org/show_bug.cgi?id=40739

        The HTML5 parser is probably off on all webkit ports.
        We should either flip the meaning of the default so that
        "false" means HTML5 on all ports, or we'll have to write
        more code like this for all the other ports.

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Wed, 16 Jun 2010 21:51:22 +0000 (21:51 +0000)]
Unreviewed, expectations update.

Updated platform/chromium-* expectations for the tests after HTML5 parser switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Wed, 16 Jun 2010 21:38:03 +0000 (21:38 +0000)]
Unreviewed, expectations update.

* platform/chromium/test_expectations.txt: Removed already passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert fast/dom/stripNullFromTextNodes.html to dumpAsText
aroben@apple.com [Wed, 16 Jun 2010 21:22:08 +0000 (21:22 +0000)]
Convert fast/dom/stripNullFromTextNodes.html to dumpAsText

There's nothing in this test that requires a render tree dump. We have
other tests that test rendering of U+FFFD characters (which was what
was causing the test to fail, since Windows uses a different font for
that character than Mac does).

Fixes <http://webkit.org/b/40738> REGRESSION: (r61234):
fast/dom/stripNullFromTextNodes.html fails on Windows

Reviewed by Dan Bernstein.

* fast/dom/stripNullFromTextNodes-expected.txt: Added.

* fast/dom/stripNullFromTextNodes.html: Added a call to
layoutTestController.dumpAsText().

* platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
* platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
* platform/mac/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/mac/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/mac/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
* platform/qt/fast/dom/stripNullFromTextNodes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 21:18:09 +0000 (21:18 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] ClipboardGtk::setURL does not match the behavior of other platforms
        https://bugs.webkit.org/show_bug.cgi?id=40640

        Instead of writing URL labels to the text portion of the clipboard or
        drag-and-drop data, write the URL itself. Also escape the label text
        of URLs. Abstracts logic into DataObjectGtk, so ClipboardGtk and
        PasteboardGtk can share it.

        Tests for this issue will be activated when dropping support has been
        added to the GTK+ EventSender.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::writeURL): Use DataObjectGtk::setURL.
        * platform/gtk/DataObjectGtk.cpp:
        (WebCore::DataObjectGtk::setURL):
        Added. Write URL to the text portion and remember to escape the
        label when creating the markup portion.
        * platform/gtk/DataObjectGtk.h: Add declaration of new method.
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeURL): Use DataObjectGtk::setURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 21:15:20 +0000 (21:15 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
        https://bugs.webkit.org/show_bug.cgi?id=40729

        This was a copy/paste error.  Yay for ASSERTs.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::nextToken):
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
        https://bugs.webkit.org/show_bug.cgi?id=40729

        Add more test coverage of DOCTYPE parsing states.  Turns out you use a
        different state if there's no whitespace between the public and system
        identifiers.

        * html5lib/resources/doctype01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert console messages to UTF-8 before printing them
aroben@apple.com [Wed, 16 Jun 2010 20:54:19 +0000 (20:54 +0000)]
Convert console messages to UTF-8 before printing them

Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
http/tests/security/xssAuditor/embed-tag-null-char.html and
http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
Windows. (I can't test the fix because Apache is crashing on my
computer.)

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/win/DumpRenderTree.cpp:
(toUTF8): Extracted the code into an overload that takes a wide string
and a length, then added an overload that takes a wstring.

* DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
overload.

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
UTF-8 instead of letting printf convert to the current code page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Wed, 16 Jun 2010 20:28:58 +0000 (20:28 +0000)]
2010-06-16  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Kent Tamura.

        Added plumbing to Chromium WebKit API to allow setting/getting the name
        of top level frames.

        https://bugs.webkit.org/show_bug.cgi?id=40430
        * public/WebFrame.h:
        Added setName() API.
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        Now takes a "name" parameter.
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):
        Passes a name parameter.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::setName):
        Allows setting the frame name by calling through to the WebCore API.
        * src/WebFrameImpl.h:
2010-06-16  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Plumbing for top-level frame names
        https://bugs.webkit.org/show_bug.cgi?id=40430

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createView):
        Migrate to new createView() API.
        * DumpRenderTree/chromium/WebViewHost.h:
        Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Stuart Morgan <stuartmorgan@chromium.org>
eric@webkit.org [Wed, 16 Jun 2010 20:08:10 +0000 (20:08 +0000)]
2010-06-16  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Anders Carlsson.

        Bring npapi.h more in line with upstream npapi-headers version:
        - Remove obsolete XP_MAC sections.
        - Remove Metrowerks defines.
        - Add OS/2 defines.
        - Add Maemo defines.
        - Add new version of the custom Carbon event definitions.
        - Sync platform define style/details

        https://bugs.webkit.org/show_bug.cgi?id=38666

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Wed, 16 Jun 2010 19:27:55 +0000 (19:27 +0000)]
2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>

    [Qt] Scroll wheel event support to graphics based DRT
    https://bugs.webkit.org/show_bug.cgi?id=40577

    Reviewed by Kenneth Rohde Christiansen.

    * DumpRenderTree/qt/EventSenderQt.cpp:
    (EventSender::continuousMouseScrollBy):
    (EventSender::createGraphicsSceneWheelEvent):
    * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 16 Jun 2010 19:16:17 +0000 (19:16 +0000)]
2010-06-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix clipping via CSS clip: with composited descendants
        https://bugs.webkit.org/show_bug.cgi?id=40579

        Consult the 'clip' style, as well as overflow, when creating clipping
        compositing layers.

        Tests: compositing/geometry/clip.html
               compositing/overflow/clip-descendents.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::clipBox): Utility function that returns the union of the clip and overflow
        boxes.
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use clipBox() to
        get the correct clipping rectangle.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer): Look for
        clip as well as overflow.
        (WebCore::RenderLayerCompositor::clipsCompositingDescendants): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 16 Jun 2010 19:11:46 +0000 (19:11 +0000)]
2010-06-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: Undocked inspector toolbar is white
        https://bugs.webkit.org/show_bug.cgi?id=40644

        Make the html element 100% height so that we don't erase the background to white, after r61215.

        * inspector/front-end/inspector.css:
        (html):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove a stray newline from the Windows version of TestNetscapePlugin
aroben@apple.com [Wed, 16 Jun 2010 19:10:18 +0000 (19:10 +0000)]
Remove a stray newline from the Windows version of TestNetscapePlugin

Reviewed by Alexey Proskuryakov.

Fixes <http://webkit.org/b/40728>
plugins/geturlnotify-during-document-teardown.html fails on Windows

* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy): Removed extra newline that the Mac version doesn't
have.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Wed, 16 Jun 2010 19:02:17 +0000 (19:02 +0000)]
Fix build.

* NetscapeCoreAnimationMoviePlugin/main.m:
(NPP_New):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUser scripts injected on start are not run on image documents.
bweinstein@apple.com [Wed, 16 Jun 2010 19:00:49 +0000 (19:00 +0000)]
User scripts injected on start are not run on image documents.
https://bugs.webkit.org/show_bug.cgi?id=40722
<rdar://8087394>

Reviewed by Darin Adler.

User scripts that are injected on start are run from FrameLoader::dispatchDocumentElementAvailable,
but this is never called from ImageDocument, so call it when we create a document element for
our image document.

* loader/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure): Call FrameLoader::dispatchDocumentElementAvailable
    after creating our document element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRespect LayoutTestController::isPrinting on Windows
aroben@apple.com [Wed, 16 Jun 2010 18:56:50 +0000 (18:56 +0000)]
Respect LayoutTestController::isPrinting on Windows

This gets some printing tests closer to passing (like
printing/page-rule-in-media-query.html).

Fixes <http://webkit.org/b/40727>.

Reviewed by Dan Bernstein.

WebKit/win:

Add a "forPrinting" boolean parameter to
IWebFramePrivate::renderTreeAsExternalRepresentation

* Interfaces/IWebFramePrivate.idl: Renamed the current
renderTreeAsExternalRepresentation to unused1, and added a new version
that takes a boolean "forPrinting" parameter.

* Interfaces/WebKit.idl: Touched to force a build.

* WebFrame.cpp:
(WebFrame::renderTreeAsExternalRepresentation): Added a boolean
"forPrinting" parameter, and used it to tell externalRepresentation
what kind of behavior to use.

* WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and
added the new one.

WebKitTools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump): Pass LayoutTestController::isPrinting to
IWebFramePrivate::renderTreeAsExternalRepresentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNow fixing the path to WebGLLayer.*
cmarrin@apple.com [Wed, 16 Jun 2010 18:51:13 +0000 (18:51 +0000)]
Now fixing the path to WebGLLayer.*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdditional minor fix to path of GraphicsContext3D.mac
cmarrin@apple.com [Wed, 16 Jun 2010 18:47:30 +0000 (18:47 +0000)]
Additional minor fix to path of GraphicsContext3D.mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing path to GraphicsContext3D.mac (hopefully)
cmarrin@apple.com [Wed, 16 Jun 2010 18:46:09 +0000 (18:46 +0000)]
Fixing path to GraphicsContext3D.mac (hopefully)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 18:32:54 +0000 (18:32 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Disabling a test which fails on Tiger for platform-specific decoding reasons.

        fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
        https://bugs.webkit.org/show_bug.cgi?id=40725

        * platform/mac-tiger/Skipped:
         - Skipping the test until someone with Tiger access can look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* WebCore.xcodeproj/project.pbxproj: Make paths relative to the project root.
beidson@apple.com [Wed, 16 Jun 2010 18:17:44 +0000 (18:17 +0000)]
* WebCore.xcodeproj/project.pbxproj: Make paths relative to the project root.

Reviewed by NOBODY (Build fix for Mac)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 18:05:18 +0000 (18:05 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Add Tiger-specific expectations because U+FFFD is a different length on
        Tiger.  :(

        * platform/mac-tiger/fast/dom: Added.
        * platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Added.
        * platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Added.
        * platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 16 Jun 2010 17:33:15 +0000 (17:33 +0000)]
2010-06-16  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=40643

        Second of three steps - rename Canvas3DLayer to WebGLLayer

        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/mac/Canvas3DLayer.h: Removed.
        * platform/graphics/mac/Canvas3DLayer.mm: Removed.
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):
        * platform/graphics/mac/WebGLLayer.h: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.h.
        * platform/graphics/mac/WebGLLayer.mm: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 16 Jun 2010 17:05:17 +0000 (17:05 +0000)]
2010-06-16  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=40643

        Rename GraphicsContext3DMac.cpp so it can interact with CALayer

        * platform/graphics/mac/GraphicsContext3DMac.cpp: Removed.
        * platform/graphics/mac/GraphicsContext3DMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp.
        * WebCore.xcodeproj/project.pbxproj

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand new expected Windows results for two failing tests
aroben@apple.com [Wed, 16 Jun 2010 16:12:16 +0000 (16:12 +0000)]
Land new expected Windows results for two failing tests

These test results should have been updated in r61136, but weren't.

Reviewed by Anders Carlsson.

Fixes <http://webkit.org/b/40713> REGRESSION (r61136):
fast/dom/prototype-inheritance-2.html and
fast/js/global-constructors.html are failing on Windows.

* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:
Updated with the actual results from the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 16:04:39 +0000 (16:04 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        Add baselines for tests that should be passing consistently now.

        * platform/gtk/Skipped: Unskip tests. They should pass consistently.
        * platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
        * platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Wed, 16 Jun 2010 15:53:18 +0000 (15:53 +0000)]
2010-06-16  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Rebaseline tests following r61240
        https://bugs.webkit.org/show_bug.cgi?id=40711

        Following r61240 (new HTML5 lexer), we need to rebaseline a few tests.

        * platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
        * platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
        * platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
        * platform/chromium-mac/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
        * platform/chromium-mac/fast/tokenizer/script_extra_close-expected.txt:
        * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
        * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
        * platform/chromium-win/fast/doctypes/003-expected.checksum:
        * platform/chromium-win/fast/doctypes/003-expected.png:
        * platform/chromium-win/fast/doctypes/003-expected.txt:
        * platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum:
        * platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png:
        * platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt:
        * platform/chromium-win/fast/invalid/016-expected.checksum:
        * platform/chromium-win/fast/invalid/016-expected.png:
        * platform/chromium-win/fast/invalid/016-expected.txt:
        * platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
        * platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.png:
        * platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.txt: Removed.
        * platform/chromium-win/fast/parser/comment-in-style-expected.checksum:
        * platform/chromium-win/fast/parser/comment-in-style-expected.png:
        * platform/chromium-win/fast/parser/comment-in-style-expected.txt:
        * platform/chromium-win/fast/parser/parseCommentsInTitles-expected.checksum:
        * platform/chromium-win/fast/parser/parseCommentsInTitles-expected.png:
        * platform/chromium-win/fast/parser/parseCommentsInTitles-expected.txt:
        * platform/chromium-win/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
        * platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.checksum:
        * platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.png:
        * platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.txt:
        * platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.checksum:
        * platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.png:
        * platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.txt:
        * platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.checksum:
        * platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.png:
        * platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.txt:
        * platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum:
        * platform/chromium-win/fast/text/international/hindi-whitespace-expected.png:
        * platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.checksum:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.png:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.txt: Removed.
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.checksum:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.png:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.txt: Removed.
        * platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt:
        * platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum:
        * platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png:
        * platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 15:45:20 +0000 (15:45 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        Unskip passing test.

        * platform/gtk/Skipped: Unskip this test which appears to be passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 15:32:41 +0000 (15:32 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Skip this test because I keep screwing up the expectations for this
        test.  I'll get it cleared up by the end of the day.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand new expected Windows results for tests that use <video controls>
aroben@apple.com [Wed, 16 Jun 2010 15:15:00 +0000 (15:15 +0000)]
Land new expected Windows results for tests that use <video controls>

The current expected results expect a fullscreen button to be included
in the controls. But the fullscreen button is only included when
accelerated compositing is enabled, and the bots build without
accelerated compositing enabled.

Rubber-stamped by Dan Bernstein.

Fixes <http://webkit.org/b/40710> Tests that use <video controls> are
failing on Windows.

* platform/win/media/controls-after-reload-expected.txt:
* platform/win/media/controls-drag-timebar-expected.txt:
* platform/win/media/controls-strict-expected.txt:
* platform/win/media/controls-styling-expected.txt:
* platform/win/media/video-controls-rendering-expected.txt:
* platform/win/media/video-display-toggle-expected.txt:
* platform/win/media/video-no-audio-expected.txt:
Updated with the actual results from the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 16 Jun 2010 15:10:16 +0000 (15:10 +0000)]
2010-06-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add new files, needed in SVG Text rewrite
        https://bugs.webkit.org/show_bug.cgi?id=40676

        Land SVGTextChunkLayoutInfo.cpp and SVGTextQuery.(cpp|h), both with an "#if 0" on top, as they will be needed
        in a later patch, completing the SVG Text rewrite, that will enable them.

        Doesn't affect any code for now, it should just reduce the review amount.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/SVGTextChunkLayoutInfo.cpp: Added.
        (WebCore::cummulatedWidthOrHeightOfTextChunk):
        (WebCore::cummulatedWidthOfTextChunk):
        (WebCore::cummulatedHeightOfTextChunk):
        (WebCore::calculateTextAnchorShiftForTextChunk):
        (WebCore::applyTextAnchorToTextChunk):
        (WebCore::calculateTextLengthCorrectionForTextChunk):
        (WebCore::applyTextLengthCorrectionToTextChunk):
        (WebCore::SVGTextChunkLayoutInfo::startTextChunk):
        (WebCore::SVGTextChunkLayoutInfo::closeTextChunk):
        (WebCore::SVGTextChunkLayoutInfo::buildTextChunks):
        (WebCore::SVGTextChunkLayoutInfo::recursiveBuildTextChunks):
        (WebCore::SVGTextChunkLayoutInfo::layoutTextChunks):
        * rendering/SVGTextChunkLayoutInfo.h: Add missing include, otherwhise compiling SVGTextChunkLayoutInfo.cpp will fail.
        * rendering/SVGTextQuery.cpp: Added.
        (WebCore::SVGTextQuery::Data::Data):
        (WebCore::flowBoxForRenderer):
        (WebCore::mapLengthThroughChunkTransformation):
        (WebCore::SVGTextQuery::SVGTextQuery):
        (WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
        (WebCore::SVGTextQuery::executeQuery):
        (WebCore::SVGTextQuery::mapStartAndLengthIntoChunkPartCoordinates):
        (WebCore::SVGTextQuery::measureCharacterRange):
        (WebCore::NumberOfCharactersData::NumberOfCharactersData):
        (WebCore::SVGTextQuery::numberOfCharactersCallback):
        (WebCore::SVGTextQuery::numberOfCharacters):
        (WebCore::TextLengthData::TextLengthData):
        (WebCore::SVGTextQuery::textLengthCallback):
        (WebCore::SVGTextQuery::textLength):
        (WebCore::SubStringLengthData::SubStringLengthData):
        (WebCore::SVGTextQuery::subStringLengthCallback):
        (WebCore::SVGTextQuery::subStringLength):
        (WebCore::StartPositionOfCharacterData::StartPositionOfCharacterData):
        (WebCore::SVGTextQuery::startPositionOfCharacterCallback):
        (WebCore::SVGTextQuery::startPositionOfCharacter):
        (WebCore::EndPositionOfCharacterData::EndPositionOfCharacterData):
        (WebCore::SVGTextQuery::endPositionOfCharacterCallback):
        (WebCore::SVGTextQuery::endPositionOfCharacter):
        (WebCore::RotationOfCharacterData::RotationOfCharacterData):
        (WebCore::SVGTextQuery::rotationOfCharacterCallback):
        (WebCore::SVGTextQuery::rotationOfCharacter):
        (WebCore::ExtentOfCharacterData::ExtentOfCharacterData):
        (WebCore::SVGTextQuery::extentOfCharacterCallback):
        (WebCore::SVGTextQuery::extentOfCharacter):
        (WebCore::CharacterNumberAtPositionData::CharacterNumberAtPositionData):
        (WebCore::SVGTextQuery::characterNumberAtPositionCallback):
        (WebCore::SVGTextQuery::characterNumberAtPosition):
        * rendering/SVGTextQuery.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix tiled backing store painting when calling QGraphicsWebView::setPage() after...
hausmann@webkit.org [Wed, 16 Jun 2010 15:09:22 +0000 (15:09 +0000)]
[Qt] Fix tiled backing store painting when calling QGraphicsWebView::setPage() after setResizesToContents(true)

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-16
Reviewed by Simon Hausmann.

When calling setPage() after setResizesToContents, the value of the property wasn't propagated
to the page client. Therefore the visible rect for the tiled backing store was incorrect.

Simply move the variable assignment into updateResizesToContentsForPage(), which is always called.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::updateResizesToContentsForPage):
(QGraphicsWebView::setResizesToContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 16 Jun 2010 13:51:21 +0000 (13:51 +0000)]
2010-06-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Provide floating-point support for text selection framework
        https://bugs.webkit.org/show_bug.cgi?id=40665

        This is the first chunk of the SVG Text rewrite patches.
        offsetForPosition() / selectionRectForText() should accept float/FloatPoint arguments instead
        of int/IntPoint. offsetForPosition() already worked with floats internally in Qt and Mac.
        selectionRectForText() was already returning a FloatRect, but the passed in origin was an integer.
        Fixing these problems in order to support sub-pixel positioning in the upcoming SVG Text rewrite patch.

        Add a glyphScale parameter to TextRun, that will be used to support text selection
        in lengthAdjust/textLength scenarios in SVG text, soon.

        Doesn't affect any testcases so far. HTML is not affected in any way,
        as it only ever passes integers to these functions.

        * platform/graphics/Font.cpp:
        (WebCore::Font::selectionRectForText):
        (WebCore::Font::offsetForPosition):
        * platform/graphics/Font.h:
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::offsetForPositionForSimpleText):
        * platform/graphics/TextRun.h:
        (WebCore::TextRun::TextRun):
        (WebCore::TextRun::glyphScale):
        (WebCore::TextRun::setGlyphScale):
        (WebCore::TextRun::applyGlyphScaling):
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::advance):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/efl/FontEfl.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/haiku/FontHaiku.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/mac/ComplexTextController.cpp:
        (WebCore::ComplexTextController::offsetForPosition):
        * platform/graphics/mac/ComplexTextController.h:
        * platform/graphics/mac/FontComplexTextMac.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::offsetForPositionForSimpleText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/win/FontWin.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/wince/FontWince.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/wx/FontWx.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * svg/SVGFont.cpp:
        (WebCore::Font::selectionRectForTextUsingSVGFont):
        (WebCore::Font::offsetForPositionForTextUsingSVGFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 16 Jun 2010 12:42:29 +0000 (12:42 +0000)]
2010-06-16  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Introduce single element caches for WebCore::String to v8::String conversions
        https://bugs.webkit.org/show_bug.cgi?id=40435
        Measurements show that for some web apps (GMail, Wave) and some scenarios
        (intensive reading and/or keeping a tab open for a long time),
        hit rate lies in 30--50% interval.
        Inlining fast case gives another minor performance win.

        * bindings/v8/V8Binding.cpp:
        (WebCore::getStringCache):
        (WebCore::v8ExternalStringSlow):
        * bindings/v8/V8Binding.h:
        (WebCore::v8ExternalString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwap WebGL and SiteSpecificQuirks attributes in the QWebSettings
hausmann@webkit.org [Wed, 16 Jun 2010 11:47:01 +0000 (11:47 +0000)]
Swap WebGL and SiteSpecificQuirks attributes in the QWebSettings
enum, to allow for binary compatibility with qtwebkit-2.0, where
WebGL is not in the settings but SiteSpecificQuirks will be.

Rubber-stamped by Tor Arne Vestbø.

* Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Wed, 16 Jun 2010 11:46:51 +0000 (11:46 +0000)]
2010-05-20  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        Spatial Navigation: using offset{Left,Top} is not enough to get the proper inner frames position
        https://bugs.webkit.org/show_bug.cgi?id=39439

        As pointed out by Darin Adler in https://bugs.webkit.org/show_bug.cgi?id=18662#c20,
        "It's not correct to use the offsetLeft and offsetTop of the frame owner element's renderer because
        that's just the distance from the offsetParent, not the absolute position".

        Patch fixes that behavior by now considering the offsetTop and offsetLeft the offsetParent recursively,
        starting from the HtmlFrameOwnerElement. Previously, only calling offsetTop and offsetLeft works
        because all tests were done in html samples where the {i}frame element was a directly a child of the body,
        e.g. <html>...<body><iframe src=xxx>....<body></html>.

        WebCore:
        Test: fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html

        * page/SpatialNavigation.cpp:
        (WebCore::renderRectRelativeToRootDocument):

        LayoutTests:
        * fast/events/spatial-navigation/snav-iframe-recursive-offset-parent-expected.txt: Added.
        * fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Tiger build
mitz@apple.com [Wed, 16 Jun 2010 09:26:13 +0000 (09:26 +0000)]
Try to fix the Tiger build

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 09:23:38 +0000 (09:23 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Disabling a test which fails on Gtk for unexplained
        reasons which are specific to the Gtk port.

        Gtk pumps the HTML5Lexer an extra time, causing inspector/timeline-script-tag-1.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=40664

        * platform/qt/Skipped:
         - Skip the test until a Gtk person can take a look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Tiger build
mitz@apple.com [Wed, 16 Jun 2010 09:15:27 +0000 (09:15 +0000)]
Try to fix the Tiger build

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 09:12:04 +0000 (09:12 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Disabling a test which due to a Qt decoding bug
        is now failing with the HTML5 lexer.

        fast/encoding/japanese-encoding-mix.html fails on Qt after enabling HTML5 Lexer
        https://bugs.webkit.org/show_bug.cgi?id=40661

        Qt's decoders don't seem to be passing the "--" of the "-->" to the
        HTML5DocumentParser correctly, thus the comment is never closed
        and the rest of the document gets eaten.

        * platform/qt/Skipped:
         - Skip the test until a Qt person can take a look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 08:59:21 +0000 (08:59 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Add two XSS Auditor tests to the Skipped list.  These tests actually
        pass in the sense that the attack is blocked.  However, the U+FFFD in
        the console output is getting mangled.  We could check in Qt-specific
        expected results, but that doesn't quite seem right.  There's something
        wrong with the Qt UT8 decoder, which I suspect is related to (or the
        same as) https://bugs.webkit.org/show_bug.cgi?id=35263

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Store matchBegin directly in the array of output instead of the stack.
abecsi@webkit.org [Wed, 16 Jun 2010 08:50:38 +0000 (08:50 +0000)]
Store matchBegin directly in the array of output instead of the stack.
    https://bugs.webkit.org/show_bug.cgi?id=38988

    Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-06-16
    Reviewed by Geoffrey Garen.

    * yarr/RegexJIT.cpp:
    (JSC::Yarr::RegexGenerator::generateDisjunction):
    (JSC::Yarr::RegexGenerator::generate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 08:48:15 +0000 (08:48 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Add platform-specific results for Snow Leopard.  Maciej thinks there is
        something going on here related to BIDI and additional FFFD
        replacements.  This test is already on our list of things to
        investigate more closely.

        * platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Added.
        * platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Added.
        * platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 08:25:11 +0000 (08:25 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed, just updating qt platform result to match new expectations.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Windows and Chromium will still need updates, but I don't have easy
        access to those results.

        * platform/qt/fast/text/stripNullFromText-expected.txt:
         - \0 now gets converted to 0xfffd per HTML5.
        * platform/qt/fast/text/international/hindi-whitespace-expected.txt:
          - Expected CR handling change after http://trac.webkit.org/changeset/61234.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: <rdar://problem/8077119> REGRESSION (r60247): Google Reader contains the...
mitz@apple.com [Wed, 16 Jun 2010 08:20:18 +0000 (08:20 +0000)]
WebCore: <rdar://problem/8077119> REGRESSION (r60247): Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

Test: platform/mac/fast/text/x-height.html

The result of platformBoundsForGlyph() is in flipped coordinates, whereas the result of
-[NSFont boundingRectForGlyph:] was not. r60247 failed to account for this.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): Measure the height of the x glyph above the baseline
correctly.
(WebCore::SimpleFontData::platformBoundsForGlyph): Return a rect in flipped coordinates on Tiger
as well.

LayoutTests: <rdar://problem/8077119> REGRESSION: Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

* platform/mac/fast/text/x-height-expected.checksum: Added.
* platform/mac/fast/text/x-height-expected.png: Added.
* platform/mac/fast/text/x-height-expected.txt: Added.
* platform/mac/fast/text/x-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 08:06:14 +0000 (08:06 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Update platform-specific expected results for Qt.

        * platform/qt/fast/text/international/hindi-whitespace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 07:59:23 +0000 (07:59 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't crash when a document ends with an entity
        https://bugs.webkit.org/show_bug.cgi?id=40658

        When we SWITCH_TO a state, we're expecting our caller to have advanced
        the source.  Rather than have all the callers check for empty, we do
        that ourselves.

        * html/HTML5Lexer.cpp:
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't crash when a document ends with an entity
        https://bugs.webkit.org/show_bug.cgi?id=40658

        Add a test for an entity being the only contents of a file.

        * html5lib/resources/webkit01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 07:51:08 +0000 (07:51 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed, just updating platform results to match new expectations.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Update platform-specific results for broken CSS test whose results
        changed as part of http://trac.webkit.org/changeset/61234.

        * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.txt:
        * platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
        * platform/qt/css1/box_properties/float_elements_in_series-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 07:30:05 +0000 (07:30 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        I seem to have screwed up generating the updated expectation file.
        This file is from the bots.

        * platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 07:04:52 +0000 (07:04 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Revert unintentional change to expected results.  I have a different
        diff on my machine because I have some errant cookies.

        * inspector/audits-panel-functional-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 06:51:25 +0000 (06:51 +0000)]
2010-06-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Change some tests not to rely upon <script/>.  We already cover that
        case in parsing tests.

        * fast/lists/ol-nested-items-dynamic-insert.html:
        * fast/lists/ol-nested-items-dynamic-remove.html:
        * fast/lists/ol-nested-items.html:
        * fast/lists/ol-nested-list-dynamic-insert.html:
        * fast/lists/ol-nested-list-dynamic-remove.html:
        * fast/lists/ol-nested-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 06:27:37 +0000 (06:27 +0000)]
2010-06-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        * page/Settings.cpp:
        (WebCore::Settings::Settings):
2010-06-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        This patch updates the expected results for tests that conflict with
        the HTML5 specification.  In a later patch, I'll update the tests
        themselves to fix pass/fail messages.

        * fast/doctypes/005-case-preserving-expected.txt:
            - HTML5 specifies case normalization for DOCTYPEs.
        * fast/js/missing-title-end-tag-js-expected.txt:
            - HTML5 requires us to swallow the entire document when <title> is
              unterminated.
        * fast/parser/comment-in-iframe-expected.txt:
        * fast/parser/comment-in-script-tricky-expected.txt:
        * fast/parser/comment-in-title-expected.txt:
        * fast/parser/comments-expected.txt:
            - Differences due to HTML5 comment parsing.
        * fast/parser/eightdigithexentity-expected.txt:
            - HTML5 specifies a different behavior for &#x00FFFFFF;
        * fast/parser/entity-end-iframe-tag-expected.txt:
            - HTML5 specifies a different behavior for &lt;/iframe>
        * fast/parser/entity-surrogate-pairs-expected.txt:
            - HTML5 doesn't allow entities to create surrogate pairs.
        * fast/parser/html-whitespace-expected.txt:
            - HTML5 has a different handling of CR in this case.
        * fast/parser/script-tag-with-trailing-slash-expected.txt:
            - HTML5 does not allow self-closing <script/> tags.
        * fast/parser/tag-with-exclamation-point-expected.txt:
            - HTML5 treats bogus DOCTYPEs as comments.
        * fast/parser/xml-directive-in-dom-expected.txt:
            - HTML5 attaches <?xml?> processing directives to the DOM as
              comments.
        * fast/xpath/xpath-functional-test-expected.txt:
            - I don't fully understand this test, but our new behavior matches
              the Firefox nightly builds (which have an HTML5 parser).
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
            - Massive progressions on HTML5 conformance.
        * http/tests/loading/gmail-assert-on-load-expected.txt:
            - I don't fully understand this behavior change.  It might
              represent a bug.  We're still investigating.
        * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
            - Update expected results for change in NULL char handling.
        * http/tests/security/xssAuditor/img-onerror-tricky-expected.txt:
            - This exploit no longer works in the HTML5 parser, so it's not
              blocked.
        * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
            - This a real regression.  We need to update the XSSAuditor to use
              the HTML5 parser's HTML entity decoder.  I'll do that in a
              followup patch because there doesn't appear to be an easy way to
              key the choice off of the WebCore::Setting.
        * http/tests/security/xssAuditor/malformed-HTML-expected.txt:
            - Slightly different handling of malformed HTML.  The exploit is still blocked.
        * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
            - Update expected result due to different NULL character handling.
        * inspector/audits-panel-functional-expected.txt:
        * inspector/timeline-script-tag-1-expected.txt:
            - Slightly different semantics around document.write.
        * inspector/elements-panel-structure-expected.txt:
            - HTML5 specifies case normalization for DOCTYPEs.
        * platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
            - HTML5 specifies different handling of "<foo<bar"
        * platform/mac/fast/doctypes/003-expected.txt:
            - HTML5 specifies case normalization for DOCTYPEs.
        * platform/mac/fast/dom/stripNullFromTextNodes-expected.txt:
            - HTML5 specifies different handling of NULL characters.
        * platform/mac/fast/invalid/016-expected.txt:
            - HTML5 specifies different handling of "<foo<bar"
        * platform/mac/fast/parser/broken-comments-vs-parsing-mode-expected.txt:
            - HTML5 specifies different handling of HTML comments.
        * platform/mac/fast/parser/comment-in-style-expected.txt:
            - HTML5 specifies different handling of HTML comments.
        * platform/mac/fast/parser/parseCommentsInTitles-expected.txt:
            - HTML5 specifies different handling of HTML comments.
        * platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
        * platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
        * platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
        * platform/mac/fast/text/international/hindi-whitespace-expected.txt:
            - HTML5 specifies different handling CR.  I don't fully understand
              the consequences of this change, but our new behavior matches the
              Firefox nightly.
        * platform/mac/fast/text/stripNullFromText-expected.txt:
            - HTML5 specifies different handling of NULL characters.
        * platform/mac/fast/tokenizer/missing-title-end-tag-1-expected.txt:
        * platform/mac/fast/tokenizer/missing-title-end-tag-2-expected.txt:
            - HTML5 requires us to swallow the entire document when <title> is
              unterminated.
        * platform/mac/fast/tokenizer/script_extra_close-expected.txt:
            - We're coalescing text nodes slightly different in the new parser.
              We're going to get this up to spec when we work on the
              TreeConstructor (which is where the spec handles text node
              coalescing).
        * platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt:
            - Different handling of crazy unicode characters (replaced with
              FFFD).  Still investigating whether this is a real bug.
        * webarchive/archive-empty-frame-dom-expected.webarchive:
            - HTML5 specifies case normalization for DOCTYPEs.
2010-06-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (initializeGlobalsFromCommandLineOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't leak WebGeolocationPositionInternal and GeolocationPosition instances for every...
mrowe@apple.com [Wed, 16 Jun 2010 04:50:29 +0000 (04:50 +0000)]
Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.

Reviewed by Sam Weinig.

* WebView/WebGeolocationPosition.mm:
(-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Dmitry Titov <dimich@chromium.org>
yuzo@google.com [Wed, 16 Jun 2010 03:23:12 +0000 (03:23 +0000)]
2010-06-15  Dmitry Titov  <dimich@chromium.org>

        Not reviewed, updating Chromium test expectations.

        * platform/chromium/test_expectations.txt:
2010-06-15  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by David Harrison.

        sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
        Explicitly initialize it to null, just to be safe.

        * platform/sql/SQLiteStatement.cpp:
        (WebCore::SQLiteStatement::prepare):
2010-06-10  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Implement render style selection for pages to support CSS3 Paged Media.
        https://bugs.webkit.org/show_bug.cgi?id=35961

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (-[WebFrame pageProperty:propertyName:]):
2010-06-10  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Implement render style selection for pages to support CSS3 Paged Media.
        https://bugs.webkit.org/show_bug.cgi?id=35961

        * DumpRenderTree/LayoutTestController.cpp:
        (parsePagePropertyParameters):
        (pagePropertyCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pageProperty):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::pageProperty):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::pageProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
mrowe@apple.com [Wed, 16 Jun 2010 02:27:22 +0000 (02:27 +0000)]
sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
Explicitly initialize it to null, just to be safe.

Rubber-stamped by David Harrison.

* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8091103> URLs not added to history when initial load happens via...
mrowe@apple.com [Wed, 16 Jun 2010 02:23:45 +0000 (02:23 +0000)]
<rdar://problem/8091103> URLs not added to history when initial load happens via back/forward navigation

Reviewed by Brady Eidson.

Back/forward navigation currently does not create or update items in the global history. This is usually
desirable, except for in the event where the back/forward list was created programmatically and attached
to the WebView and the initial load in that WebView is being performed as a result of a back/forward
navigation. In that situation it is preferable to ensure that global history item is created or updated.

No test case is added because DumpRenderTree is not able to test the scenario where the initial
load in a WebView occurs via a back/forward navigation.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): If we're committing the first load in this frame as a
back/forward navigation then we should update the history as if it were a standard load, with the
exception of updating the back/forward list.
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForStandardLoad): Add a parameter to allow callers to skip updating
the back/forward list.
* loader/HistoryController.h:
(WebCore::HistoryController::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, updating Chromium test expectations.
dimich@chromium.org [Wed, 16 Jun 2010 01:07:50 +0000 (01:07 +0000)]
Not reviewed, updating Chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/8010805>
weinig@apple.com [Wed, 16 Jun 2010 00:45:55 +0000 (00:45 +0000)]
Fix for <rdar://problem/8010805>
Assertion failure ("mainThreadPthread") in isMainThread() mousing over cnn.com in Mini Browser

Reviewed by Anders Carlsson.

Don't use WebCore::String::operator NSString*() from the UIProcess, since it uses
StringImpl::createCFString() which expects to be called from WebCore's main thread.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::nsStringFromWebCoreString):
(WebKit::PageClientImpl::toolTipChanged):
* UIProcess/API/mac/WKView.mm:
(-[WKView view:stringForToolTip:point:userData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, updating Chromium test expectations.
dimich@chromium.org [Wed, 16 Jun 2010 00:19:57 +0000 (00:19 +0000)]
Not reviewed, updating Chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Jun 2010 23:42:33 +0000 (23:42 +0000)]
2010-06-15  Simon Fraser  <simon.fraser@apple.com>

        Fix crashing tests; need to check for null documentElement().

        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 15 Jun 2010 23:36:07 +0000 (23:36 +0000)]
2010-06-15  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Fix compilation errors in BlobBuilder with FILE_WRITER enabled
        https://bugs.webkit.org/show_bug.cgi?id=40606

        No functionality change so no new tests.

        * html/BlobBuilder.cpp:
        * html/BlobBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 15 Jun 2010 23:35:55 +0000 (23:35 +0000)]
2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Fix compilation with older GTK+.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::pageRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove type attribute from File.idl to Blob.idl per latest File API spec.
jianli@chromium.org [Tue, 15 Jun 2010 23:29:19 +0000 (23:29 +0000)]
Move type attribute from File.idl to Blob.idl per latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=40642

Reviewed by David Levin.

* html/Blob.idl:
* html/File.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=40630
weinig@apple.com [Tue, 15 Jun 2010 23:17:21 +0000 (23:17 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
WebKit2: Add mechanism to inject code into the WebProcess on startup

Reviewed by Anders Carlsson.

Add initial InjectedBundle support.

WebKit2:

* Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Add new LoadInjectedBundle message kind.

* UIProcess/API/C/WKContext.cpp:
(toWK):
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
* UIProcess/API/C/WKContext.h:
Rename WKContextCreateWithProcessModel to WKContextCreate and add
WKContextCreateWithInjectedBundlePath for creating a context with
a bundle.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* UIProcess/WebContext.h:
(WebKit::WebContext::create):
(WebKit::WebContext::processModel):
(WebKit::WebContext::bundlePath):
* UIProcess/WebPageNamespace.cpp:
(WebKit::WebPageNamespace::ensureWebProcess):
(WebKit::WebPageNamespace::reviveIfNecessary):
* UIProcess/WebProcessManager.cpp:
(WebKit::WebProcessManager::getWebProcess):
* UIProcess/WebProcessManager.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
* UIProcess/WebProcessProxy.h:
Thread the bundle path through process creation.

* WebProcess/InjectedBundle: Added.
* WebProcess/InjectedBundle/API: Added.
* WebProcess/InjectedBundle/API/c: Added.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp: Added.
(WKBundleSetClient):
* WebProcess/InjectedBundle/API/c/WKBundle.h: Added.
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added.
(WebKit::):
(toWK):
(toRef):
* WebProcess/InjectedBundle/API/c/WKBundleBase.h: Added.
* WebProcess/InjectedBundle/API/c/WKBundleInitialize.h: Added.
* WebProcess/InjectedBundle/InjectedBundle.cpp: Added.
(WebKit::InjectedBundle::InjectedBundle):
(WebKit::InjectedBundle::~InjectedBundle):
(WebKit::InjectedBundle::initializeClient):
(WebKit::InjectedBundle::didCreatePage):
* WebProcess/InjectedBundle/InjectedBundle.h: Added.
(WebKit::InjectedBundle::create):
Add bundle boilerplate.

* WebProcess/InjectedBundle/mac: Added.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Added.
(WebKit::InjectedBundle::load):
Load the InjectedBundle using CFBundle.

* WebProcess/InjectedBundle/win: Added.
* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: Added.
(WebKit::pathGetFileName):
(WebKit::directoryName):
(WebKit::InjectedBundle::load):
Load the InjectedBundle using HMODULE.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Add initial bundle callback for page creation. More to come.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::injectedBundle):
Load the InjectedBundle on LoadInjectedBundle message.

* WebKit2.xcodeproj/project.pbxproj:
* mac/WebKit2.exp:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add the new files.

WebKitTools:

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/WebBundle-Info.plist: Added.
Add test InjectedBundle to the project.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
Get the path to the WebBundle from the the main bundle and pass it to the new
WKContextCreateWithInjectedBundlePath function.

* MiniBrowser/mac/BrowserWindowController.m:
(_didChangeProgress):
Fix the build.  This has been broken for a while.

* MiniBrowser/mac/WebBundle: Added.
* MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
(_didCreatePage):
(WKBundleInitialize):
Add really basic InjectedBundle.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding myself to the reviewers list.
dumi@chromium.org [Tue, 15 Jun 2010 22:47:17 +0000 (22:47 +0000)]
Adding myself to the reviewers list.
https://bugs.webkit.org/show_bug.cgi?id=40693

Reviewed by Darin Adler.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 15 Jun 2010 22:44:08 +0000 (22:44 +0000)]
2010-06-15  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, updating Chromium test expectations for media layout tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
darin@apple.com [Tue, 15 Jun 2010 22:33:13 +0000 (22:33 +0000)]
Fix build.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::shouldClose): Call loader()->shouldClose().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, updating Chromium test expectations.
dimich@chromium.org [Tue, 15 Jun 2010 22:30:34 +0000 (22:30 +0000)]
Unreviewed, updating Chromium test expectations.

Mark following tests SLOW so they won't fail on TIMEOUT in Debug:
fast/frames/lots-of-iframes.html
fast/frames/lots-of-objects.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 15 Jun 2010 22:20:34 +0000 (22:20 +0000)]
2010-06-15  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions out of Frame class that were marked "move to Chrome"
        https://bugs.webkit.org/show_bug.cgi?id=39636

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::dispatchBeforeUnloadEvent): Call shouldClose
        on FrameLoader instead of going through Frame.
2010-06-15  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions out of Frame class that were marked "move to Chrome"
        https://bugs.webkit.org/show_bug.cgi?id=39636

        * WebView.cpp:
        (WebView::shouldClose): Call shouldClose on FrameLoader instead of
        going through Frame.
2010-06-15  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions out of Frame class that were marked "move to Chrome"
        https://bugs.webkit.org/show_bug.cgi?id=39636

        * WebFrame.cpp:
        (wxWebFrame::ShouldClose): Call shouldClose on FrameLoader instead
        of going through Frame.
2010-06-15  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions out of Frame class that were marked "move to Chrome"
        https://bugs.webkit.org/show_bug.cgi?id=39636

        * WebView/WebView.mm:
        (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of
        going through Frame.
2010-06-15  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions out of Frame class that were marked "move to Chrome"
        https://bugs.webkit.org/show_bug.cgi?id=39636

        Refactoring that does not require new tests.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didOpenURL): Call setStatus and setDefaultStatus
        on DOMWindow rather than going through Frame.
        (WebCore::FrameLoader::open): Ditto.
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call
        shouldClose on this object instead of going through Frame.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Call
        shouldClose on FrameLoader instead of going through Frame.
        (WebCore::DOMWindow::focus): Moved the code from Frame::focusWindow
        in here.
        (WebCore::DOMWindow::blur): Moved the code from Frame::unfocusWindow
        in here.
        (WebCore::DOMWindow::close): Moved the code from Frame::scheduleClose
        in here.
        (WebCore::DOMWindow::setStatus): Moved the code from
        Frame::setJSStatusBarText in here.
        (WebCore::DOMWindow::setDefaultStatus): Moved the code from
        Frame::setJSDefaultStatusBarText in here.

        * page/DOMWindow.h: Added m_status and m_defaultStatus members to
        store the status messages being set by the DOM.

        * page/Frame.cpp: Removed all the functions that were marked
        "to be moved into Chrome".
        * page/Frame.h: Ditto.
2010-06-15  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions out of Frame class that were marked "move to Chrome"
        https://bugs.webkit.org/show_bug.cgi?id=39636

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::tryClose): Call shouldClose on FrameLoader instead of
        going through Frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 15 Jun 2010 22:04:18 +0000 (22:04 +0000)]
2010-06-15  Darin Fisher  <darin@chromium.org>

        Fix whitespace error in expected results.

        Looks like Chromium's TestShell and DRT do not agree in how whitespace
        is generated in some cases.

        * fast/history/history-back-within-subframe-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Jun 2010 22:00:26 +0000 (22:00 +0000)]
2010-06-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Garbage shown outside HTML if HTML is absolutely positioned
        https://bugs.webkit.org/show_bug.cgi?id=36163

        Add a check that the root renderer (the document element's renderer) covers
        the entire viewport before deciding that we don't need the RenderView
        to paint its background. Fixes lack of painting with positioned, floated, and
        display: table html elements.

        Test: fast/repaint/positioned-document-element.html

        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Jun 2010 22:00:02 +0000 (22:00 +0000)]
2010-06-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Safari 5 does not clear background with transformed html element
        https://bugs.webkit.org/show_bug.cgi?id=40498

        When the document element is composited, ensure that the FrameView
        paints the background, because the composited layer may be transparent,
        or might get moved via animation.

        Test: compositing/repaint/composited-document-element.html

        * rendering/RenderView.cpp:
        (WebCore::isComposited):
        (WebCore::rendererObscuresBackground):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove getPluginInfoFromBundleAndMIMEDictionary:
andersca@apple.com [Tue, 15 Jun 2010 21:48:48 +0000 (21:48 +0000)]
Remove getPluginInfoFromBundleAndMIMEDictionary:

Reviewed by Dan Bernstein.

* Plugins/WebBasePluginPackage.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.
andersca@apple.com [Tue, 15 Jun 2010 21:40:25 +0000 (21:40 +0000)]
Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.

Reviewed by Dan Bernstein.

* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 15 Jun 2010 20:57:58 +0000 (20:57 +0000)]
2010-06-15  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Switch to using GIO methods instead of realpath in GtkLauncher to determine
        the file URI. This should remove warnings about realpath being undefined
        when compiling with '-ansi'.

        * GtkLauncher/main.c:
        (filenameToURL): Use GIO instead of realpath to determine file URI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 15 Jun 2010 20:41:23 +0000 (20:41 +0000)]
2010-06-15  Darin Fisher  <darin@chromium.org>

        Adding missing test results.

        * fast/history/history-back-within-subframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 15 Jun 2010 19:49:50 +0000 (19:49 +0000)]
2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        Remove GSEAL from the debug config since the bots have a GTK+
        version too old, duh.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 15 Jun 2010 19:32:38 +0000 (19:32 +0000)]
2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Try to fix GTK+ build.

        * platform/gtk/GtkVersioning.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 15 Jun 2010 19:31:53 +0000 (19:31 +0000)]
2010-06-15  Darin Fisher  <darin@chromium.org>

        Reviewed by Brady Eidson.

        Introduce HistoryItem::itemSequenceNumber and use it to identify
        HistoryItems that are clones of one another.

        Changes HistoryController::recursiveGoToItem to use itemSequenceNumber
        equality instead of isTargetItem as the pre-requisite for not calling
        FrameLoader::loadItem.

        Changes FrameLoader::loadItem to require equivalent
        documentSequenceNumber before initiating a same document navigation.
        This alone would appear to fix the bug, but it does not go far enough
        since without the itemSequenceNumber equality check, we'd re-load more
        often than we should.

        Moves documentSequenceNumber assignment into createItemTree as cleanup
        and to ensure that it gets called properly whenever we create a cloned
        HistoryItem.  (createItemTree's mission is to create clones up until
        or including the target frame depending on the value of the doClip
        parameter.)

        Removes the now unused HistoryController::urlsMatchItem.

        https://bugs.webkit.org/show_bug.cgi?id=40451

        Test: fast/history/history-back-within-subframe.html
              http/tests/navigation/history-back-across-form-submission-to-fragment.html

        * history/HistoryItem.cpp:
        (WebCore::generateSequenceNumber):
        (WebCore::HistoryItem::HistoryItem):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::setItemSequenceNumber):
        (WebCore::HistoryItem::itemSequenceNumber):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::updateBackForwardListForFragmentScroll):
        (WebCore::HistoryController::createItemTree):
        (WebCore::HistoryController::recursiveGoToItem):
        (WebCore::HistoryController::pushState):
        * loader/HistoryController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 15 Jun 2010 19:14:38 +0000 (19:14 +0000)]
2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Does not compile with -DGSEAL_ENABLE
        https://bugs.webkit.org/show_bug.cgi?id=37851

        Add GSEAL_ENABLE flag when doing debug builds.

        * GNUmakefile.am:

WebCore:

2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Does not compile with -DGSEAL_ENABLE
        https://bugs.webkit.org/show_bug.cgi?id=37851

        Fix compilation with GSEAL_ENABLE.

        * platform/gtk/GtkVersioning.h:
        * platform/gtk/PlatformScreenGtk.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::show):
        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::detachAdjustment):
        (ScrollbarGtk::updateThumbPosition):
        (ScrollbarGtk::updateThumbProportion):
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::paint):
        (WebCore::PluginView::initXEvent):
        (WebCore::PluginView::platformGetValue):
        (WebCore::PluginView::platformStart):
        * plugins/gtk/gtk2xtbin.c:
        (gtk_xtbin_realize):
        (gtk_xtbin_new):
        (gtk_xtbin_set_position):
        (gtk_xtbin_unrealize):

WebKit/gtk:

2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Does not compile with -DGSEAL_ENABLE
        https://bugs.webkit.org/show_bug.cgi?id=37851

        Fix compilation with GSEAL_ENABLE.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::pageRect):
        (WebKit::ChromeClient::contentsSizeChanged):
        * tests/testdomnode.c:
        (test_dom_node_insertion):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_realize):
        (webkit_web_view_script_dialog):
        (webkit_web_view_drag_end):
        (webkit_web_view_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Increase limit on number of (i)frames from 200 to 1000.
ap@apple.com [Tue, 15 Jun 2010 18:59:31 +0000 (18:59 +0000)]
    Increase limit on number of (i)frames from 200 to 1000.
        https://bugs.webkit.org/show_bug.cgi?id=39427

        Move the right test this time, move remove-iframe-crash back. Oops.

        * compositing/iframes/lots-of-iframes-expected.txt: Removed.
        * compositing/iframes/lots-of-iframes.html: Removed.
        * compositing/iframes/remove-iframe-crash-expected.txt: Copied from fast/frames/remove-iframe-crash-expected.txt.
        * compositing/iframes/remove-iframe-crash.html: Copied from fast/frames/remove-iframe-crash.html.
        * fast/frames/lots-of-iframes-expected.txt: Copied from compositing/iframes/lots-of-iframes-expected.txt.
        * fast/frames/lots-of-iframes.html: Copied from compositing/iframes/lots-of-iframes.html.
        * fast/frames/remove-iframe-crash-expected.txt: Removed.
        * fast/frames/remove-iframe-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Jun 2010 18:54:13 +0000 (18:54 +0000)]
2010-06-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps

        The run loop observer used to commit compositing layer changes does not do
        updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
        update is pending (added in r58623).

        However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
        This caused us to never sync compositing layers.

        So detect if the current window is wrapping a carbon window, and in that case consult the root
        HIView to detect if display is pending.

        * WebView/WebView.mm:
        (layerSyncRunLoopObserverCallBack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake JavaScriptCore build with clang++.
andersca@apple.com [Tue, 15 Jun 2010 18:52:31 +0000 (18:52 +0000)]
Make JavaScriptCore build with clang++.

Reviewed by Sam Weinig.

* jit/JITInlineMethods.h:
(JSC::JIT::emitPutVirtualRegister):
Explicitly cast to an int.

* yarr/RegexCompiler.cpp:
(JSC::Yarr::compileRegex):
Return 0 instead of false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 15 Jun 2010 18:48:36 +0000 (18:48 +0000)]
2010-06-15  Kenneth Russell  <kbr@google.com>

        Unreviewed, test fix.

        Fix test breakage from 40175
        https://bugs.webkit.org/show_bug.cgi?id=40631

        * fast/canvas/webgl/texture-npot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 15 Jun 2010 18:40:20 +0000 (18:40 +0000)]
2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        Fix the build when WebSockets are disabled.

        * bindings/js/JSWorkerContextCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Jun 2010 18:37:50 +0000 (18:37 +0000)]
2010-06-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        YouTube thumbnail borders vanish during transition
        https://bugs.webkit.org/show_bug.cgi?id=40551

        Turn off the direct image optimization if the image has a clip style, so that is is
        correctly rendered with the clip.

        Test: compositing/images/clip-on-directly-composited-image.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::isDirectlyCompositedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Not reviewed, just moving tests.
ap@apple.com [Tue, 15 Jun 2010 18:31:29 +0000 (18:31 +0000)]
    Not reviewed, just moving tests.

        Increase limit on number of (i)frames from 200 to 1000.
        https://bugs.webkit.org/show_bug.cgi?id=39427

        Move the new tests out of compositing directory.

        * compositing/iframes/lots-of-objects-expected.txt: Removed.
        * compositing/iframes/lots-of-objects.html: Removed.
        * compositing/iframes/remove-iframe-crash-expected.txt: Removed.
        * compositing/iframes/remove-iframe-crash.html: Removed.
        * fast/frames/lots-of-objects-expected.txt: Copied from LayoutTests/compositing/iframes/lots-of-objects-expected.txt.
        * fast/frames/lots-of-objects.html: Copied from LayoutTests/compositing/iframes/lots-of-objects.html.
        * fast/frames/remove-iframe-crash-expected.txt: Copied from LayoutTests/compositing/iframes/remove-iframe-crash-expected.txt.
        * fast/frames/remove-iframe-crash.html: Copied from LayoutTests/compositing/iframes/remove-iframe-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-15 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 15 Jun 2010 17:50:42 +0000 (17:50 +0000)]
2010-06-15  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
        https://bugs.webkit.org/show_bug.cgi?id=40623

        * bindings/v8/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::functionName): return empty string for anonymous functions instead of [anonymous].
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::handleV8DebugEvent): autocontinue on syntax errors since there is no stack trace and
        not much to inspect.
2010-06-15  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
        https://bugs.webkit.org/show_bug.cgi?id=40623

        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent.prototype.formatCallFrame_): return empty function name for anonymous functions.
        * src/js/DebuggerScript.js:
        * src/js/Tests.js:
        (.TestSuite.prototype.testProfilerTab.findVisibleView):
        (.TestSuite.prototype.testProfilerTab):
        (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):
        (.TestSuite.prototype.testSetBreakpoint.this):
        (.TestSuite.prototype.testSetBreakpoint):
        (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit):
        (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage):
        (.TestSuite.prototype.testExpandScope.examineScopes):
        (.TestSuite.prototype.testExpandScope):
        (.TestSuite.prototype.testDebugIntrinsicProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Rename NotificatioIconWrapper to NotificationWrapper
yael.aharon@nokia.com [Tue, 15 Jun 2010 17:25:23 +0000 (17:25 +0000)]
[Qt] Rename NotificatioIconWrapper to NotificationWrapper
https://bugs.webkit.org/show_bug.cgi?id=40571

Reviewed by Kenneth Rohde Christiansen.

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):
* WebCoreSupport/NotificationPresenterClientQt.h:
(WebCore::NotificationWrapper::~NotificationWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove some unnecessary steps for setting up the debugger on Windows
aroben@apple.com [Tue, 15 Jun 2010 16:55:06 +0000 (16:55 +0000)]
Remove some unnecessary steps for setting up the debugger on Windows

Apparently update-webkit does this for you now.

WebKitSite:

Rubber-stamped by Steve Falkenburg.

* building/debug.html: Removed the first two Windows steps, which are
now unnecessary, and updated the third to reflect reality.

WebKitTools:

Remove the redundant set-apple-windows-environment-variables script

Apparently update-webkit does this for you these days.

Rubber-stamped by Steve Falkenburg.

* Scripts/set-apple-windows-environment-variables: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebCore's and JavaScriptCore's DerivedSources available for debugging in product...
aroben@apple.com [Tue, 15 Jun 2010 16:40:40 +0000 (16:40 +0000)]
Make WebCore's and JavaScriptCore's DerivedSources available for debugging in production builds

Fixes <http://webkit.org/b/40626> <rdar://problem/8094205>.

Reviewed by Sam Weinig.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.make: Copy the contents of
JavaScriptCore's DerivedSources directory to
AppleInternal/Sources/JavaScriptCore.

WebCore:

* WebCore.vcproj/WebCore.make: Copy the contents of WebCore's
DerivedSources directory to AppleInternal/Sources/WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprove instructions for debugging on Windows
aroben@apple.com [Tue, 15 Jun 2010 16:40:20 +0000 (16:40 +0000)]
Improve instructions for debugging on Windows

Fixes <http://webkit.org/b/40585>.

Reviewed by Steve Falkenburg.

* building/debug.html: Improved the Windows instructions. We now
instruct users to set things up so that hitting F5 from WebKit.sln
will launch Safari with the WEBKITNIGHTLY environment variable
pointing to the location of the built WebKit.dll.

* building/console_vs2005.jpg: Removed.
* building/debug_vs2005.jpg: Removed.

* building/launch-debugger-vs2005.png: Added.
* building/set-as-startup-project-vs2005.png: Added.
* building/set-debugging-properties-vs2005.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a script to set the WebKitOutputDir and WebKitLibrariesDir environment variables
aroben@apple.com [Tue, 15 Jun 2010 16:39:58 +0000 (16:39 +0000)]
Add a script to set the WebKitOutputDir and WebKitLibrariesDir environment variables

Fixes <http://webkit.org/b/40595>.

Reviewed by Steve Falkenburg.

* Scripts/set-apple-windows-environment-variables: Added.
(to_windows_path): Passes the passed-in path through cygpath to
generate a Windows-style path.
(main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
variables to their defaults, if they aren't already set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeed up run-safari/debug-safari on Windows
aroben@apple.com [Tue, 15 Jun 2010 16:39:41 +0000 (16:39 +0000)]
Speed up run-safari/debug-safari on Windows

Fixes <http://webkit.org/b/40586>.

Reviewed by Steve Falkenburg.

* Scripts/webkitdirs.pm:
(runSafari): When debugging, set up the environment to run Safari
using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
actually launch the debugger. When not debugging, just run WebKit.exe
and it will do the rest for us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61192 268f45cc-cd09-0410-ab3c-d52691b4dbfc