WebKit-https.git
7 years ago.: == Rolled over to ChangeLog-2012-05-22 ==
simon.fraser@apple.com [Tue, 22 May 2012 20:37:14 +0000 (20:37 +0000)]
.: == Rolled over to ChangeLog-2012-05-22 ==

Source/JavaScriptCore: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebCore: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebKit/chromium: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebKit/gtk: == Rolled over to ChangeLog-2012-05-22 ==

Source/WebKit2: == Rolled over to ChangeLog-2012-05-22 ==

Tools: == Rolled over to ChangeLog-2012-05-22 ==

LayoutTests: == Rolled over to ChangeLog-2012-05-22 ==

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] platform/chromium/.../visibility-simple-*-layer.html fails intermittently...
jsbell@chromium.org [Tue, 22 May 2012 20:30:03 +0000 (20:30 +0000)]
[Chromium] platform/chromium/.../visibility-simple-*-layer.html fails intermittently on Windows bots.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Fix iframe printing.
commit-queue@webkit.org [Tue, 22 May 2012 20:26:16 +0000 (20:26 +0000)]
Source/WebCore: Fix iframe printing.
https://bugs.webkit.org/show_bug.cgi?id=85118

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-05-22
Reviewed by Darin Adler, Eric Seidel.

Patch fixed two issues by disabling special handling of subframes for printing.
1. Regression. Division by zero when forceLayoutForPagination called for subframes
and page sizes set to zero.
2. Old issue. RendererView adjusted layout of subframes for printing and set invalid
dimensions. Sometimes it caused missing iframe when printed.

Test: printing/iframe-print.html

* page/Frame.cpp:
(WebCore::Frame::setPrinting): Calls forceLayoutForPagination for root frames only.
(WebCore::Frame::resizePageRectsKeepingRatio): Added ASSERTs to catch division by zero.
* rendering/RenderView.cpp: Replaced printing() with shouldUsePrintingLayout() for most calls.
(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):
(WebCore::RenderView::layout):
(WebCore::RenderView::shouldUsePrintingLayout): Returns true only if printing enabled and it's a root frame.
(WebCore::RenderView::viewRect):
(WebCore::RenderView::viewHeight):
(WebCore::RenderView::viewWidth):
* rendering/RenderView.h:

LayoutTests: LayoutTest for iframe printing.
https://bugs.webkit.org/show_bug.cgi?id=85118

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-05-22
Reviewed by Darin Adler, Eric Seidel.

* printing/iframe-print-expected.txt: Added.
* printing/iframe-print.html: Added.
* printing/resources/iframe-subframe-vertical-rl.html: Added.
* printing/resources/iframe-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] getPlatformThreadRegisters() should fetch target thread's registers
commit-queue@webkit.org [Tue, 22 May 2012 20:23:44 +0000 (20:23 +0000)]
[BlackBerry] getPlatformThreadRegisters() should fetch target thread's registers
https://bugs.webkit.org/show_bug.cgi?id=87148

Patch by Yong Li <yoli@rim.com> on 2012-05-22
Reviewed by George Staikos.

Our previous implementation of getPlatformThreadRegisters() read registers in current
thread's context but it is supposed to read the target thread's registers.

* heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 22 May 2012 20:20:34 +0000 (20:20 +0000)]
2012-05-22  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * wtf/RAMSize.cpp:
        (WTF::computeRAMSize): sysctl expects a uint64_t, so use that and then
        cast back to size_t. Since it's coneivable that a 32bit process would
        run on a system with more than 4GB RAM, I added a paranoid check for
        that condition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix tests being flaky when multiple draws occur in between commits
commit-queue@webkit.org [Tue, 22 May 2012 20:17:20 +0000 (20:17 +0000)]
[Chromium] Fix tests being flaky when multiple draws occur in between commits
https://bugs.webkit.org/show_bug.cgi?id=83935

Tests that are verifying events in a commit/draw lock-step pattern, should use
sourceFrameNumber() not frameNumber() on the impl side.
Otherwise they will fail if the same frame is drawn more than once in
between commits (which is perfectly legal and could happen for example
because we draw without a new commit because we are still in BEGIN_FRAME
or updating resources).

Patch by Daniel Sievers <sievers@chromium.org> on 2012-05-22
Reviewed by Adrienne Walker.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestFractionalScroll::drawLayersOnCCThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
jberlin@webkit.org [Tue, 22 May 2012 20:03:33 +0000 (20:03 +0000)]
Build fix.

* wtf/RAMSize.cpp:
(WTF::computeRAMSize):
If you say you are going to return a size_t, actually return a size_t.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should support reflective arguments access
fpizlo@apple.com [Tue, 22 May 2012 20:02:25 +0000 (20:02 +0000)]
DFG should support reflective arguments access
https://bugs.webkit.org/show_bug.cgi?id=85721

Reviewed by Oliver Hunt.

Merged r116345 from dfgopt.

This adds support for op_create_arguments to the DFG. No other arguments-related
opcodes are added by this change, though it does add a lot of the scaffolding
necessary for the other ops.

This also adds GetByVal/PutByVal optimizations for Arguments.

Finally, this rationalizes slowPathCall with no return. Previously, that would
work via callOperation() overloads that took InvalidGPRReg as the return GPR.
But that creates awful ambiguity, since we had template functions that were
polymorphic over all parameters except the second, which was a GPRReg, and a
bunch of non-template overloads that also potentially had GPRReg as the second
argument. I finally started to hit this ambiguity and was getting absolutely
bizarre compiler errors, that made me feel like I was programming in SML. So,
I changed the no-argument overloads to take NoResultTag instead, which made
everything sensible again by eliminating the overload ambiguity.

This is a ~7% speed-up on V8/earley and neutral elsewhere.

* bytecode/PredictedType.h:
(JSC::isArgumentsPrediction):
(JSC):
(JSC::isActionableMutableArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
* dfg/DFGCommon.h:
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::unmodifiedArgumentsRegister):
(Node):
(JSC::DFG::Node::shouldSpeculateArguments):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(DFG):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Arguments.h:
(ArgumentsData):
(Arguments):
(JSC::Arguments::offsetOfData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] canvas/philip/tests/2d.path.stroke.overlap.html fails with Qt-4.6.2 or higher
rafael.lobo@openbossa.org [Tue, 22 May 2012 19:23:18 +0000 (19:23 +0000)]
[Qt] canvas/philip/tests/2d.path.stroke.overlap.html fails with Qt-4.6.2 or higher
https://bugs.webkit.org/show_bug.cgi?id=40362

Reviewed by Noam Rosenthal.

Source/WebCore:

Before drawing the stroke from a certain path, it should make the union of the stroke areas.
The previous implementation didn't consider that so the intersection was painted twice.
By using QPainterPathStroker, we create a QPainterPath on top of the platform path, and
then we fill it with the expected brush. This way we avoid repainting areas.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::fillPathStroke):
(WebCore):
(WebCore::GraphicsContext::strokePath):

LayoutTests:

* platform/qt/Skipped: Unskip test after fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGC allocation trigger should be tuned to system RAM
ggaren@apple.com [Tue, 22 May 2012 19:17:57 +0000 (19:17 +0000)]
GC allocation trigger should be tuned to system RAM
https://bugs.webkit.org/show_bug.cgi?id=87039

Reviewed by Darin Adler.

../JavaScriptCore:

This helps avoid OOM crashes on small platforms, and helps avoid "too much GC"
performance issues on big platforms.

* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect):
* heap/Heap.h:
(Heap): GC balances between a fixed minimum and a proportional multiplier,
which are limited based on system RAM.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
* runtime/JSGlobalData.h:
(JSGlobalData): Renamed HeapSize to HeapType because the exact size is
influenced by the heap type, but not determined by it.

../WTF:

Added a helper function for measuring system RAM.

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/AmountOfRAM.cpp: Added.
(WTF):
(WTF::computeAmountOfRAM):
(WTF::amountOfRAM):
* wtf/AmountOfRAM.h: Added.
(WTF):
* wtf/CMakeLists.txt:
* wtf/StdLibExtras.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable private names by default in WebCore
barraclough@apple.com [Tue, 22 May 2012 19:10:43 +0000 (19:10 +0000)]
Disable private names by default in WebCore
https://bugs.webkit.org/show_bug.cgi?id=87088

Reviewed by Geoff Garen.

r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
These are probably not yet ready to be web-facing, so disabling by default in WebCore.
Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.

Source/JavaScriptCore:

* jsc.cpp:
(GlobalObject):
(GlobalObject::javaScriptExperimentsEnabled):
    - Implemented new trap to opt-in to private names support.
* runtime/JSGlobalObject.cpp:
(JSC):
(JSC::JSGlobalObject::reset):
    - Only add the Name property to the global object if experiments are enabled.
* runtime/JSGlobalObject.h:
(GlobalObjectMethodTable):
    - Added new trap to enabled experiments.
(JSGlobalObject):
(JSC::JSGlobalObject::finishCreation):
    - Set the global object's m_experimentsEnabled state on construction.
(JSC::JSGlobalObject::javaScriptExperimentsEnabled):
    - Defaults to off.

Source/WebCore:

* WebCore.exp.in:
    - Added export.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore):
(WebCore::JSDOMWindowBase::javaScriptExperimentsEnabled):
    - Override default from JSC, enable based on corresponding Setting.
* bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
    - Added declaration for javaScriptExperimentsEnabled.
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setJavaScriptExperimentsEnabled):
(WebCore):
* page/Settings.h:
(Settings):
(WebCore::Settings::javaScriptExperimentsEnabled):
    - Added Setting, reflecting WebPreference.

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setJavaScriptExperimentsEnabled:]):
(-[WebPreferences javaScriptExperimentsEnabled]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
    - Added JavaScriptExperimentsEnabled to WebPreferences.

Source/WebKit2:

* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetJavaScriptExperimentsEnabled):
(WKPreferencesGetJavaScriptExperimentsEnabled):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
    - Added JavaScriptExperimentsEnabled to WebPreferences.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
    - Enable private name support in DRT.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
    - Enable private name support in WKTR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots
eae@chromium.org [Tue, 22 May 2012 19:00:35 +0000 (19:00 +0000)]
REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=87145

Reviewed by Levi Weintraub.

Fix zoom-in-length-round-trip to support subpixel support turned on or off.

* fast/css/zoom-in-length-round-trip.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago!HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Andro...
abarth@webkit.org [Tue, 22 May 2012 18:50:44 +0000 (18:50 +0000)]
!HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Android build
https://bugs.webkit.org/show_bug.cgi?id=87141

Reviewed by Eric Seidel.

In the Chromium Android build there is still one remaining dependency
on object files in the accessibility directory:
AccessibilityObject::actionVerb. I missed this function in my previous
patch, but this patch changes it to be an inline stub.

* accessibility/AccessibilityObject.cpp:
(WebCore):
* accessibility/AccessibilityObject.h:
(WebCore):
(WebCore::actionVerb):
(WebCore::AccessibilityObject::lineForPosition):
(WebCore::AccessibilityObject::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Support Array-type key paths
jsbell@chromium.org [Tue, 22 May 2012 18:46:07 +0000 (18:46 +0000)]
IndexedDB: Support Array-type key paths
https://bugs.webkit.org/show_bug.cgi?id=84207

Reviewed by Tony Chang.

Source/WebCore:

Implement IDB spec behavior that key paths can be arrays of strings; when
evaluated, these yield arrays of keys, providing compound key support. Also
changes exception types to match the spec.

Test: storage/indexeddb/keypath-arrays.html
Test: storage/indexeddb/keypath-basics.html

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore): Look for both string and array in option dict,
throw exceptions for forbidden combinations of key generator and key paths.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex): Handle special cases (accepted and forbidden).
(WebCore):
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
(WebCore::IDBObjectStore::createIndex): Overloads to satisfy IDL overloads and optional dicts.
* Modules/indexeddb/IDBObjectStore.idl: Add DOMString array overload.
* bindings/v8/IDBBindingUtilities.cpp: Implement spec logic for evaluating array key paths.
(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore):

LayoutTests:

* storage/indexeddb/keypath-arrays-expected.txt: Added.
* storage/indexeddb/keypath-arrays.html: Added.
* storage/indexeddb/keypath-basics-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
* storage/indexeddb/mozilla/resources/create-objectstore-basics.js:
(cleanDatabase):
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/resources/keypath-arrays.js: Added.
(test.request.onsuccess):
(test):
(openSuccess.request.onsuccess):
(openSuccess):
(testKeyPaths.checkStore.request.onsuccess):
(testKeyPaths.checkStore):
(testKeyPaths.checkIndex.request.onsuccess):
(testKeyPaths.checkIndex):
(testKeyPaths):
* storage/indexeddb/resources/keypath-basics.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] REGRESSION(r116135): Keys that confirm composition trigger a default action
mrobinson@webkit.org [Tue, 22 May 2012 18:37:22 +0000 (18:37 +0000)]
[GTK] REGRESSION(r116135): Keys that confirm composition trigger a default action
https://bugs.webkit.org/show_bug.cgi?id=86925

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. Creating tests for GTK+ input methods is quite difficult, as they
can differ from machine to machine. It's also hard to simulate composition
sequences.

* platform/gtk/CompositionResults.h: Instead of holding composition results, just
keep a flag describing whether or not this event had results.
(CompositionResults):

Source/WebKit/gtk:

Instead of sending composition results with a keydown event, simply send whether
or not the event had results. Activate the results after processing the event. This
allows for input methods to modify the DOM after the keydown event and to still
prevent the default action during handleInputMethodKeydown.

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection): This patch removes the m_updatingComposition
so we no longer have to check it here.
(WebKit::EditorClient::keyboardEventHadCompositionResults): Added.
(WebKit::EditorClient::handleInputMethodKeydown): Now prevent the default action when
the keyboard event had composition results.
(WebKit::EditorClient::EditorClient):
* WebCoreSupport/EditorClientGtk.h: Remove the m_updatingComposition member, as it's no
longer used.
* WebCoreSupport/WebViewInputMethodFilter.cpp:
(WebKit::WebViewInputMethodFilter::sendKeyEventWithCompositionResults): Now send the
composition results after the key event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a small syntax error in the GTK+ API test runner.
mrobinson@webkit.org [Tue, 22 May 2012 18:34:22 +0000 (18:34 +0000)]
Fix a small syntax error in the GTK+ API test runner.

Reviewed by Gustavo Noronha Silva.

* gtk/run-api-tests:
(TestRunner._setup_testing_environment): When reporting the error use
the correct Python format string syntax.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()
commit-queue@webkit.org [Tue, 22 May 2012 18:18:25 +0000 (18:18 +0000)]
[GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()
https://bugs.webkit.org/show_bug.cgi?id=86962

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-22
Reviewed by Gustavo Noronha Silva.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setCacheModel): Sets WEBKIT_CACHE_MODEL_WEB_BROWSER if argument is 2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Key modifier bit flags have enum type.
commit-queue@webkit.org [Tue, 22 May 2012 18:11:52 +0000 (18:11 +0000)]
[EFL][DRT] Key modifier bit flags have enum type.
https://bugs.webkit.org/show_bug.cgi?id=86838

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-22
Reviewed by Antonio Gomes.

Refactoring. Key modifier flags are unsigned int.
Key modifier bit flags used have enum type. It caused problems as a key can have several modifiers
at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift)
would have been out of EvasKeyModifier enum.

* DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(MouseEventInfo::MouseEventInfo):
(MouseEventInfo):
(setEvasModifiers):
(modifiersFromJSValue):
(mouseDownCallback):
(mouseUpCallback):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion failure (toRenderBox() called on a RenderInline) beneath RenderBlock::block...
inferno@chromium.org [Tue, 22 May 2012 18:11:35 +0000 (18:11 +0000)]
Assertion failure (toRenderBox() called on a RenderInline) beneath RenderBlock::blockBeforeWithinSelectionRoot()
https://bugs.webkit.org/show_bug.cgi?id=86500

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/block/line-layout/selection-highlight-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Demoted the object local variable to
RenderObject, changed use of parentBox() to parent(), and added toRenderBlock() in two places.

LayoutTests:

* fast/block/line-layout/selection-highlight-crash-expected.txt: Added.
* fast/block/line-layout/selection-highlight-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] jquery/attributes.html SLOW -> TIMEOUT
jsbell@chromium.org [Tue, 22 May 2012 17:58:54 +0000 (17:58 +0000)]
[Chromium] jquery/attributes.html SLOW -> TIMEOUT

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=87145
beidson@apple.com [Tue, 22 May 2012 17:53:37 +0000 (17:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87145
REGRESSION (r117815) fast/css/zoom-in-length-round-trip.html fails on Mac bots

* platform/mac/Skipped: Skipping until Levi Weintraub can explore the regression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERTs in RenderInline::layout()
rwlbuis@webkit.org [Tue, 22 May 2012 17:51:24 +0000 (17:51 +0000)]
ASSERTs in RenderInline::layout()
https://bugs.webkit.org/show_bug.cgi?id=63365

Patch by Rob Buis <rbuis@rim.com> on 2012-05-22
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Do not allow creation of renderers for text content children in elements by default.
Subclasses like SVGTextElement override this behavior.
This also fixes the <a><textPath</a> case because the <a> parent decides to allow <textPath> or not:
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environment

Test: svg/custom/disallowed-text-content-rendering.svg

* svg/SVGElement.cpp:
(WebCore::SVGElement::childShouldCreateRenderer):
* svg/SVGElement.h:
(SVGElement):

LayoutTests:

Test text content element children inside elements.

* svg/custom/disallowed-text-content-rendering-expected.txt: Added.
* svg/custom/disallowed-text-content-rendering.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property
commit-queue@webkit.org [Tue, 22 May 2012 17:45:13 +0000 (17:45 +0000)]
Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property
https://bugs.webkit.org/show_bug.cgi?id=86694

Source/WebCore:

As KeyboardEvent for left/right location key, e.g. left-control,
right-control, provides DOM_KEY_LOCATION_STANDARD as keyLocation property,
modified KeyCodeConversion to make PlatformKeyboardEvent
provide virtual keycodes with location information, e.g. VK_LCONTROL or
VK_RCONTROL, and modified KeyboardEvent to generate location information
from the virtual keycodes, e.g. genrating DOM_KEY_LOCATION_LEFT for
VK_LCONTROL. KeyboardEvent also removes location information from
the virtual keycodes, e.g. genrating VK_CONTROL for VK_LCONTROL.
The location property is defined in the W3C DOM3 specification:
http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-22
Reviewed by Alexey Proskuryakov.

Test: fast/events/keydown-leftright-keys.html

* dom/KeyboardEvent.cpp:
(WebCore::windowsVirtualKeyCodeWithoutLocation):
Added a function which removes location information from a given
keycode. For example, when VK_LCONTROL is given, returns VK_CONTROL.
(WebCore::keyLocationCode):
Added a function which provides location information from a given
keycode. For example, when VK_LCONTROL is given,
returns DOM_KEY_LOCATION_LEFT.
(WebCore::KeyboardEvent::KeyboardEvent):
Initialized m_keyLocation by using the above keyLocationCode.
(WebCore::KeyboardEvent::keyCode):
Modified to use the above two functions to initialize keycode property
and keylocation property.
* platform/chromium/KeyCodeConversionAndroid.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
* platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
* platform/cocoa/KeyEventCocoa.mm:
(WebCore::windowsKeyCodeForKeyCode):
Modified these keycode conversions to return keycodes with location
information, e.g. modified keycode conversions returns VK_LCONTROL
for left control.

Tools:

Modify keyDown to create left- and right- control, shift, and alt
keyevent for a test to check that keyLocation property can have
DOM_KEY_LOCATION_LEFT for left-control, shift, and alt, and
DOM_KEY_LOCATION_RIGHT for right-control, shift, and alt.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-22
Reviewed by Alexey Proskuryakov.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::keyDown):
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]):

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-22
Reviewed by Alexey Proskuryakov.

* fast/events/keydown-leftright-keys-expected.txt: Added.
* fast/events/keydown-leftright-keys.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL's DRT needs to print information about received Web Intents
commit-queue@webkit.org [Tue, 22 May 2012 17:42:57 +0000 (17:42 +0000)]
[EFL] EFL's DRT needs to print information about received Web Intents
https://bugs.webkit.org/show_bug.cgi?id=86864

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-22
Reviewed by Adam Barth.

.:

Enable Web Intents by default on EFL port.

* Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

* ewk/ewk_intent.cpp:
(ewk_intent_suggestions_get): Add function to retrieve suggested
service URLs for an intent.
(ewk_intent_extra_names_get): Add function to retrieve names of
extra metadata for an intent.
(ewk_intent_new): Correctly initialize Ewk_Intent members to avoid
crashes.
(ewk_intent_free): Unref shared strings.
* ewk/ewk_intent.h:

Tools:

Catch "intent,new" signal in EFL's DumpRenderTree and dump information
about the intent. This output is expected by several webintents test
cases.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameIntentNew):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Unskip a few Web Intents tests that are passing now that the
functionality is enabled by default on EFL port.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: provide content-related actions on the sources panel.
pfeldman@chromium.org [Tue, 22 May 2012 17:41:47 +0000 (17:41 +0000)]
Web Inspector: provide content-related actions on the sources panel.
https://bugs.webkit.org/show_bug.cgi?id=87144

Reviewed by Vsevolod Vlasov.

Now that the authoring focus moved to the Source panel, context menu actions should follow:
- refactored context menu actions to be provider-based
- edited call sites to add applicable actions.

* English.lproj/localizedStrings.js:
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu.prototype.appendApplicableItems):
* inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype.unregisterHandler):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems.doSave):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems.save):
(WebInspector.HandlerRegistry.prototype.appendApplicableItems):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype.searchCanceled):
(WebInspector.NetworkPanel.prototype.appendApplicableItems.reveal):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._contextMenu):
* inspector/front-end/UIUtils.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector._doLoadedDoneWithCapabilities.get if):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of flaky media tests
commit-queue@webkit.org [Tue, 22 May 2012 17:37:27 +0000 (17:37 +0000)]
[EFL] Gardening of flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=87138

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-22

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove old staging enum value WebURLRequest::TargetType::TargetIsPrerender
gavinp@chromium.org [Tue, 22 May 2012 17:33:28 +0000 (17:33 +0000)]
[Chromium] Remove old staging enum value WebURLRequest::TargetType::TargetIsPrerender
https://bugs.webkit.org/show_bug.cgi?id=85021

Reviewed by Adam Barth.

* chromium/public/WebURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGive FileInputType a setFiles() method, let Drag-n-Drop call it.
thakis@chromium.org [Tue, 22 May 2012 17:32:59 +0000 (17:32 +0000)]
Give FileInputType a setFiles() method, let Drag-n-Drop call it.
https://bugs.webkit.org/show_bug.cgi?id=87139

Reviewed by Ojan Vafai.

filesChosen(), the FileChooserClient callback, used to modify
m_fileList directly. Instead, convert the FileChooserClient
data to a FileList and pass that to a factored-out setFiles()
method. This is in preparation to making the files property
writable.

Pure refactoring, no functionality change.

* html/FileInputType.cpp:
(WebCore::FileInputType::toFileList):
(WebCore::FileInputType::setFiles):
(WebCore::FileInputType::filesChosen):
(WebCore):
* html/FileInputType.h:
(FileInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntent::create() throws is service is "url://a url"
commit-queue@webkit.org [Tue, 22 May 2012 17:25:12 +0000 (17:25 +0000)]
Intent::create() throws is service is "url://a url"
https://bugs.webkit.org/show_bug.cgi?id=86873

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-22
Reviewed by Adam Barth.

Remove checks in webintents/web-intents-obj-constructor.html which are
valid for Google URL but fail with KURL.

* webintents/web-intents-obj-constructor-expected.txt:
* webintents/web-intents-obj-constructor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTruncating multiplication on integers should not OSR exit every time
fpizlo@apple.com [Tue, 22 May 2012 17:18:21 +0000 (17:18 +0000)]
Truncating multiplication on integers should not OSR exit every time
https://bugs.webkit.org/show_bug.cgi?id=85752

Reviewed by Gavin Barraclough.

Merge r116264 from dfgopt.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::mulShouldSpeculateInteger):
(Graph):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMul):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: JavaScriptSourceFrame should be based on JavaScriptSource not UISource...
vsevik@chromium.org [Tue, 22 May 2012 17:13:33 +0000 (17:13 +0000)]
Web Inspector: JavaScriptSourceFrame should be based on JavaScriptSource not UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=87135

Reviewed by Pavel Feldman.

Source/WebCore:

Renamed _uiSourceCode to _javaScriptSource in JavaScriptSourceFrame.
Removed unused uiSourceCode getter from JavaScriptSourceFrame.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/script-formatter-breakpoints.html:
* inspector/debugger/script-formatter-console.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoadd OVERRIDE annotations to classes derived from CCAnimationCurve
commit-queue@webkit.org [Tue, 22 May 2012 17:04:23 +0000 (17:04 +0000)]
add OVERRIDE annotations to classes derived from CCAnimationCurve
https://bugs.webkit.org/show_bug.cgi?id=87073

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-22
Reviewed by James Robinson.

No new tests required.

* platform/graphics/chromium/cc/CCAnimationCurve.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoadd OVERRIDE annotations to CCThreadTask
commit-queue@webkit.org [Tue, 22 May 2012 16:58:58 +0000 (16:58 +0000)]
add OVERRIDE annotations to CCThreadTask
https://bugs.webkit.org/show_bug.cgi?id=87074

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-22
Reviewed by James Robinson.

No new tests required.

* platform/graphics/chromium/cc/CCThreadTask.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move asserts in CCLayerTreeHostTest::dispatch*
commit-queue@webkit.org [Tue, 22 May 2012 16:47:38 +0000 (16:47 +0000)]
[chromium] Move asserts in CCLayerTreeHostTest::dispatch*
https://bugs.webkit.org/show_bug.cgi?id=87134

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-22
Reviewed by Adrienne Walker.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimateAndCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::dispatchSetVisible):
(WTF::CCLayerTreeHostTest::dispatchSetInvisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCentralize and clean-up table column iteration
jchaffraix@webkit.org [Tue, 22 May 2012 16:43:48 +0000 (16:43 +0000)]
Centralize and clean-up table column iteration
https://bugs.webkit.org/show_bug.cgi?id=87051

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/table/caption-between-column-and-column-group.html
       fast/table/caption-between-column-group-and-column.html
       fast/table/caption-between-columns.html

The existing code had duplications between different classes and some
of the iterating functions could use a better place. That's what this
change solves, along with several renamings.

* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColumnGroupWithColumnChildren):
Renamed isTableColGroup to this to better reflect what it checks.
Also added a new function: nextColumn.

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
Updated after isTableColGroup renaming.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::firstColumn):
Added this new function to get the first column (or column group).

(WebCore::RenderTable::colElement):
Cleaned up this function: switched the loop to a 'for' now that the
helper functions make it easy. Cleaned up the ordering and the naming.

* rendering/RenderTable.h:
Added firstColumn.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColLogicalWidth):
Updated to use nextColumn().

* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::nextColumn):
Added this new helper function to centralize the code to iterate over columns.

LayoutTests:

Those tests just validate and enforce what we were already doing that were
not covered by any existing tests.

* fast/table/caption-between-column-and-column-group-expected.html: Added.
* fast/table/caption-between-column-and-column-group.html: Added.
* fast/table/caption-between-column-group-and-column-expected.html: Added.
* fast/table/caption-between-column-group-and-column.html: Added.
* fast/table/caption-between-columns-expected.html: Added.
* fast/table/caption-between-columns.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make color of spelling check marker cross-platform.
commit-queue@webkit.org [Tue, 22 May 2012 16:41:12 +0000 (16:41 +0000)]
[chromium] Make color of spelling check marker cross-platform.
https://bugs.webkit.org/show_bug.cgi?id=87095

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-22
Reviewed by Adam Barth.

Pixel layout is RGBA on Android, while it is BGRA on other platforms.

No new tests. To run tests on Android.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add support to enable/disable DOM paste
commit-queue@webkit.org [Tue, 22 May 2012 16:41:08 +0000 (16:41 +0000)]
[EFL] Add support to enable/disable DOM paste
https://bugs.webkit.org/show_bug.cgi?id=85040

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-22
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add support to enable/disable DOM paste setting so that document.execCommand()
allows paste command when this setting is enabled. Also, update documentation
for scripts_can_access_clipboard setting in ewk_view.

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_access_clipboard_set):
* ewk/ewk_view.h:

Tools:

Enable JavascriptCanAccessClipboard setting on each test startup so
that test cases which rely on clipboard can be unskipped.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Unskip a few clipboard related tests which are now passing.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
commit-queue@webkit.org [Tue, 22 May 2012 16:32:24 +0000 (16:32 +0000)]
[BlackBerry] Remove unused/unimplemented methods from InspectorClientBlackberry
https://bugs.webkit.org/show_bug.cgi?id=87125

Patch by Konrad Piascik <kpaiscik@rim.com> on 2012-05-22
Reviewed by Rob Buis.

Removed unimplemented methods that are no longer part of InspectorClient and added
a new stub for InspectorStateClient::updateInspectorStateCookie

* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
(WebCore):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Skip asserting test in win debug following subpixel layout changes.
jsbell@chromium.org [Tue, 22 May 2012 16:22:37 +0000 (16:22 +0000)]
[Chromium] Skip asserting test in win debug following subpixel layout changes.
https://bugs.webkit.org/show_bug.cgi?id=87137

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
zandobersek@gmail.com [Tue, 22 May 2012 16:17:13 +0000 (16:17 +0000)]
[Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=86284

Unreviewed, removing test expectations for tests that should pass now
that the web view is repainted before dumping pixel results.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=87136
beidson@apple.com [Tue, 22 May 2012 16:10:10 +0000 (16:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87136
REGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests failing on Mac bots.

* platform/mac/Skipped: Skipping tests until Kenneth Russel can take a look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Expand damage from the background-blurred layer to ensure readback is...
danakj@chromium.org [Tue, 22 May 2012 16:10:09 +0000 (16:10 +0000)]
[chromium] Expand damage from the background-blurred layer to ensure readback is only including pixels below that layer
https://bugs.webkit.org/show_bug.cgi?id=86884

Reviewed by Adrienne Walker.

Source/WebCore:

Consider layers in back-to-front order A, B, and C, where layer B has
a blur background filter applied, and C exactly covers A. When B does
its readback to perform its blur, it should include the pixels of A
not C. With partial swap, if B is damaged, that damaged area will read
pixels from outside of the damage rect. Those pixels should use the
contents of A, not C, so we must expand the damage to ensure we redraw
all pixels that are going to be included in the blur for the current
frame.

Also, when a layer below B has damage outside the contentBounds of B
but within its blur radius, then that damage will be blurred inside B,
so expand all damage within B's blurred contentBounds.

Unit test: CCDamageTrackerTest.verifyDamageForBackgroundBlurredChild

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::expandRectWithFilters):
(WebCore::expandDamageRectInsideRectWithFilters):
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

Source/WebKit/chromium:

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] Add region styling support for color property
mihnea@adobe.com [Tue, 22 May 2012 16:07:07 +0000 (16:07 +0000)]
[CSSRegions] Add region styling support for color property
https://bugs.webkit.org/show_bug.cgi?id=85633

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/region-style-color.html

This patch extends the region styling support. In addition to background-color, it adds
the possibility of styling color in regions.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore):
(WebCore::RenderFlowThread::checkRegionsWithStyling):
* rendering/RenderFlowThread.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
(WebCore::RenderRegion::setObjectStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
* rendering/RenderRegion.h:
(RenderRegion):
(ObjectRegionStyleInfo):

LayoutTests:

Added region-style-color.html and its associated ref test for testing the color in region style rules.
Modified region-style-image-background-color/region-style-inline-background-color since background color
can be styled for inline/replaced elements.

* fast/regions/region-style-color-expected.html: Added.
* fast/regions/region-style-color.html: Added.
* fast/regions/region-style-image-background-color.html:
* fast/regions/region-style-inline-background-color-expected.html:
* fast/regions/region-style-inline-background-color.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove GenerateSetDOMException() from CodeGeneratorV8.pm
haraken@chromium.org [Tue, 22 May 2012 15:57:04 +0000 (15:57 +0000)]
[V8] Remove GenerateSetDOMException() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=87114

Reviewed by Nate Chapin.

GenerateSetDOMException() is used by only one place. This patch removes it.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Fire error when there are problems opening a DB
dgrogan@chromium.org [Tue, 22 May 2012 15:55:15 +0000 (15:55 +0000)]
IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

* WebKit.gypi:
* tests/IDBAbortOnCorruptTest.cpp: Added.
(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):
* tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.
(WebCore):
(IDBFakeBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-22 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 22 May 2012 15:41:19 +0000 (15:41 +0000)]
2012-05-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Follow-up patch after r117975, as the strict approach fires assertions.
        CSS generated content can violate the ASSERT(child->isSVGInline() || child->isSVGInlineText()) logic.

        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::subtreeChildWasAdded):
        (WebCore::RenderSVGText::subtreeChildWillBeRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium AX: Crash when menulist adds selected option via document.write
dmazzoni@google.com [Tue, 22 May 2012 15:24:33 +0000 (15:24 +0000)]
Chromium AX: Crash when menulist adds selected option via document.write
https://bugs.webkit.org/show_bug.cgi?id=87028

Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/chromium/accessibility/add-to-menu-list-crashes.html

* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::addChild):

LayoutTests:

* platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt: Added.
* platform/chromium/accessibility/add-to-menu-list-crashes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap
zimmermann@webkit.org [Tue, 22 May 2012 15:21:49 +0000 (15:21 +0000)]
Crash in WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap
https://bugs.webkit.org/show_bug.cgi?id=86781

Reviewed by Rob Buis.

Source/WebCore:

Always invalidate the text positioning element cache if the <text> render subtree mutates.
Currently only RenderSVGInlineText renderers are tracked correctly, RenderSVGInline
renderers like RenderSVGTSpan didn't cause text positioning element cache mutations
so far. Fix that.

Test: svg/custom/bug86781.html

* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::removeChild):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::removeChild):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):

LayoutTests:

* svg/custom/bug86781-expected.txt: Added.
* svg/custom/bug86781.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make "Go to source" shortcut accessible from all panels.
pfeldman@chromium.org [Tue, 22 May 2012 15:04:49 +0000 (15:04 +0000)]
Web Inspector: make "Go to source" shortcut accessible from all panels.
https://bugs.webkit.org/show_bug.cgi?id=87132

Reviewed by Vsevolod Vlasov.

* English.lproj/localizedStrings.js:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype.handleShortcut):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
(WebInspector.OpenResourceDialog.prototype.itemsCount):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype.selectItem):
(WebInspector.OpenResourceDialog.show):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.appendApplicableItems):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.handleShortcut):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: HeapSnapshot: speedUp buildAggregates.
loislo@chromium.org [Tue, 22 May 2012 14:48:38 +0000 (14:48 +0000)]
Web Inspector: HeapSnapshot: speedUp buildAggregates.
https://bugs.webkit.org/show_bug.cgi?id=87131

Engine can't inline getters and use fast-case if the function has for(i in object) loops.

Reviewed by Yury Semikhatsky.

No logic changes.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.classIndex):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-22 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 22 May 2012 14:44:56 +0000 (14:44 +0000)]
2012-05-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Re-add expected results for three tests that were missing.

        * platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::RenderSVGContainer::paint
zimmermann@webkit.org [Tue, 22 May 2012 14:42:10 +0000 (14:42 +0000)]
Crash in WebCore::RenderSVGContainer::paint
https://bugs.webkit.org/show_bug.cgi?id=86392

Reviewed by Rob Buis.

Source/WebCore:

Modernize the <marker> code, switch to the same design pattern used for handling zero-length subpaths.
Decouple the generation of the marker start/mid/end positions from the actual usage of these information.
Only generate those marker positions if the underlying Path changes, and never else.

When figuring out the bounds for a shape, access to current set of RenderSVGResourceMarker start/mid/end resources
and ask the marker resources for their bounds using the previously figured out marker positions on the Path.
Drawing markers is handled in the same way.

Remove SVGMarkerLayoutInfo alltogether which stored raw pointers to the RenderSVGResourceMarkers.
We assumed that those objects would stay alive from layout() to paint(), but that assumption is wrong.

Tests: svg/custom/bug86392.html
       svg/custom/marker-zero-length-linecaps-expected.svg
       svg/custom/marker-zero-length-linecaps.svg

* CMakeLists.txt: Remove SVGMarkerLayoutInfo.*.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.order: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* rendering/svg/RenderSVGAllInOne.cpp: Ditto.
* rendering/svg/RenderSVGShape.cpp: Handle markers just like the existing zero leng subpath code, which is superior.
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
(WebCore::RenderSVGShape::paint):
(WebCore::markerForType):
(WebCore::RenderSVGShape::markerRect):
(WebCore::RenderSVGShape::inflateWithStrokeAndMarkerBounds):
(WebCore::RenderSVGShape::drawMarkers):
(WebCore::RenderSVGShape::processMarkerPositions):
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):
* rendering/svg/SVGMarkerData.h:
(WebCore::MarkerPosition::MarkerPosition):
(MarkerPosition):
(WebCore::SVGMarkerData::SVGMarkerData):
(WebCore::SVGMarkerData::updateFromPathElement):
(WebCore::SVGMarkerData::pathIsDone):
(SVGMarkerData):
(WebCore::SVGMarkerData::currentAngle):
* rendering/svg/SVGMarkerLayoutInfo.cpp: Removed.
* rendering/svg/SVGMarkerLayoutInfo.h: Removed.
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::resourcesCacheFromRenderObject):
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject):
* rendering/svg/SVGResourcesCache.h:
(SVGResourcesCache):

LayoutTests:

* svg/custom/bug86392-expected.txt: Added.
* svg/custom/bug86392.html: Added.
* svg/custom/marker-zero-length-linecaps-expected.svg: Added.
* svg/custom/marker-zero-length-linecaps.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Implement the ContextMenuItem SubMenu type
apavlov@chromium.org [Tue, 22 May 2012 14:32:27 +0000 (14:32 +0000)]
[Chromium] Implement the ContextMenuItem SubMenu type
https://bugs.webkit.org/show_bug.cgi?id=86625

Reviewed by Pavel Feldman.

Source/WebCore:

This change is the WebKit part of a two-sided patch that adds subMenuItems to ContextMenuItem
and introduces code needed to handle it properly.

* platform/ContextMenuItem.h:
(PlatformMenuItemDescription): Add a Vector for subMenuItems.
* platform/PlatformMenuDescription.h:
(WebCore): Introduce a meaningful typedef for PlatformMenuDescription in Chromium.
* platform/chromium/ContextMenuChromium.cpp:
(WebCore::ContextMenu::itemWithAction): Search submenus when looking up a requested action id.
(WebCore::ContextMenu::platformDescription): Return a real PlatformMenuDescription rather than 0.
* platform/chromium/ContextMenuItemChromium.cpp:
(WebCore::ContextMenuItem::ContextMenuItem): Set submenu if one has been passed in.
(WebCore::ContextMenuItem::platformSubMenu): Return real subMenuItems instead of an empty PlatformMenuDescription.
(WebCore::ContextMenuItem::setSubMenu): Implemented.
(WebCore):

Source/WebKit/chromium:

* public/WebMenuItemInfo.h:
(WebMenuItemInfo): Add the SubMenu type and a vector of subMenuItems.
* src/ContextMenuClientImpl.cpp:
(WebKit::populateSubMenuItems): A recursive implementation that populates submenu items as well as other item types.
(WebKit):
(WebKit::ContextMenuClientImpl::populateCustomMenuItems): Consider submenus when populating WebMenuItemInfos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: use canvas to render timeline category strips in overview pane
caseq@chromium.org [Tue, 22 May 2012 14:06:47 +0000 (14:06 +0000)]
Web Inspector: use canvas to render timeline category strips in overview pane
https://bugs.webkit.org/show_bug.cgi?id=87109

Reviewed by Pavel Feldman.

- use canvas, not DOM to represent timeline category strips in the default overview mode

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview): propagate to TimelineCategoryStrips;
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged): force update of category strips;
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.setShowShortEvents):
(WebInspector.TimelineCategoryStrips):
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord): process one record;
(WebInspector.TimelineCategoryStrips.prototype.update): re-draw everything;
(WebInspector.TimelineCategoryStrips.prototype.setShowShortEvents):
(WebInspector.TimelineCategoryStrips.prototype._renderBar): render single bar;
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.createFillStyle): utility methods to create gradients for category bars;
(WebInspector.TimelinePresentationModel.createFillStyleForCategory):
(WebInspector.TimelineCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Clean up internal viewport animation API
kenneth@webkit.org [Tue, 22 May 2012 14:04:23 +0000 (14:04 +0000)]
[Qt] Clean up internal viewport animation API
https://bugs.webkit.org/show_bug.cgi?id=87130

Reviewed by Simon Hausmann.

const'ify classes which should be const.

There is now only one method which can animate, animateItemRectVisible
which is used for also animating the contents back into valid bounds.
The valid bounds are computed using a separate method. It is now more
clear when an animation is used or not and asserts are added for
ensuring no concurrent animations as well as proper update deferring.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::itemRectFromCSS):
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::nearestValidBounds):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing tests and new passes
commit-queue@webkit.org [Tue, 22 May 2012 14:02:09 +0000 (14:02 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=87122

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-22

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [regression] dynamically created script tab is bound to the document...
pfeldman@chromium.org [Tue, 22 May 2012 13:55:10 +0000 (13:55 +0000)]
Web Inspector: [regression] dynamically created script tab is bound to the document resource.
https://bugs.webkit.org/show_bug.cgi?id=87119

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/debugger/dynamic-script-tag.html

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger.didSetBreakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._setInDebugger):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.rawLocationToUILocation):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):
(WebInspector.Script.Location.prototype.update):

LayoutTests:

* inspector/debugger/dynamic-script-tag-expected.txt: Added.
* inspector/debugger/dynamic-script-tag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: JavaScript breakpoints disappear when Ctrl+S is pressed for the script...
vsevik@chromium.org [Tue, 22 May 2012 13:50:35 +0000 (13:50 +0000)]
Web Inspector: JavaScript breakpoints disappear when Ctrl+S is pressed for the script without changes.
https://bugs.webkit.org/show_bug.cgi?id=87121

Reviewed by Pavel Feldman.

JavaScriptSourceFrame and StylesSourceFrame should not commit working copy unless UISourceCode is dirty.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSourceFrame.prototype.commitEditing):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.commitWorkingCopy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
alexis.menard@openbossa.org [Tue, 22 May 2012 13:47:11 +0000 (13:47 +0000)]
[Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
https://bugs.webkit.org/show_bug.cgi?id=87044

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-05-22
Reviewed by Alexis Menard.

Use sendOrQueueEvent instead of m_testController->mainWebView()->sendEvent

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Gardening of fast/spatial-navigation tests.
commit-queue@webkit.org [Tue, 22 May 2012 13:28:52 +0000 (13:28 +0000)]
[EFL][DRT] Gardening of fast/spatial-navigation tests.
https://bugs.webkit.org/show_bug.cgi?id=87112

Unreviewed gardening. Unskipped some fast/spatial-navigation tests after r117218.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-22

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: HeapSnapshot: speed-up calculateRetainedSize functon.
loislo@chromium.org [Tue, 22 May 2012 13:25:54 +0000 (13:25 +0000)]
Web Inspector: HeapSnapshot: speed-up calculateRetainedSize functon.
https://bugs.webkit.org/show_bug.cgi?id=87124

I found that in all dominators related functions we use nodeOrdinals.
At the moment we divide nodeIndex to nodeFieldCount and this operation too expensive for these simple algorithms.

Reviewed by Yury Semikhatsky.

Covered by existing tests.

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):

LayoutTests:

* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: annotate InjectedScriptSource.js for closure compiler
yurys@chromium.org [Tue, 22 May 2012 13:07:14 +0000 (13:07 +0000)]
Web Inspector: annotate InjectedScriptSource.js for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=87120

Reviewed by Pavel Feldman.

Annotated InjectedScriptSource.js for closure compiler. Replaced call of undefined
_isPrimitiveValue function with isPrimitiveValue.

* inspector/InjectedScriptExterns.js: Added. External APIs used in InjectedScriptSource.js
(console.log):
(InjectedScriptHost.prototype.storageId):
(InjectedScriptHost.prototype.functionDetails):
(InjectedScriptHost.prototype.isHTMLAllCollection):
(InjectedScriptHost.prototype.internalConstructorName):
(InjectedScriptHost.prototype.copyText):
(InjectedScriptHost.prototype.clearConsoleMessages):
(InjectedScriptHost.prototype.inspectedObject):
(InjectedScriptHost.prototype.databaseId):
(InjectedScriptHost.prototype.inspect):
(InjectedScriptHost.prototype.type):
(InjectedScriptHost.prototype.getEventListeners):
(JavaScriptCallFrame.prototype.scopeType):
* inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Speed up CCLayerTreeHostTestTickAnimationWhileBackgrounded
commit-queue@webkit.org [Tue, 22 May 2012 13:03:33 +0000 (13:03 +0000)]
[chromium] Speed up CCLayerTreeHostTestTickAnimationWhileBackgrounded
https://bugs.webkit.org/show_bug.cgi?id=86871

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-22
Reviewed by James Robinson.

Source/WebCore:

With this patch, the background animation timer is lazily created,
allowing for different time intervals to be used. In particular, a
very short interval for unit tests.

Unit tests: CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThread
            CCLayerTreeHostTestTickAnimationWhileBackgrounded.runMultiThread

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setBackgroundTickingEnabled):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::animateLayers):
(WebCore::CCLayerTreeHostImpl::lowFrequencyAnimationInterval):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setVisible):

Source/WebKit/chromium:

Use a shorter time interval for background animation ticking so that
unit tests can run faster.

* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostImpl::lowFrequencyAnimationInterval):
(MockLayerTreeHostImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Test expectations need updating
commit-queue@webkit.org [Tue, 22 May 2012 12:35:18 +0000 (12:35 +0000)]
[EFL] Test expectations need updating
https://bugs.webkit.org/show_bug.cgi?id=87115

Unreviewed EFL gardening. Update expectations for 2 test cases which
are failing after r117932.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-22

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Styles] Odd synthetic shorthands may appear in the style
apavlov@chromium.org [Tue, 22 May 2012 12:22:10 +0000 (12:22 +0000)]
Web Inspector: [Styles] Odd synthetic shorthands may appear in the style
https://bugs.webkit.org/show_bug.cgi?id=87081

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):

LayoutTests:

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/elements/resources/elements-panel-styles.css:
(.foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix crashes when a mouse points a <svg> element in shadow DOM subtree.
hayato@chromium.org [Tue, 22 May 2012 12:14:41 +0000 (12:14 +0000)]
Fix crashes when a mouse points a <svg> element in shadow DOM subtree.
https://bugs.webkit.org/show_bug.cgi?id=86795

Reviewed by Nikolas Zimmermann.

Source/WebCore:

<svg> elements in shadow dom subtree are still not supported.
This fixes only crashes.

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

* dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingSVGTargetRules):
* page/EventHandler.cpp:
(WebCore::instanceAssociatedWithShadowTreeElement):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDOM Attr objects pointing to "style" attribute should force reification when read.
kling@webkit.org [Tue, 22 May 2012 12:06:24 +0000 (12:06 +0000)]
DOM Attr objects pointing to "style" attribute should force reification when read.
<http://webkit.org/b/87076>

Reviewed by Antti Koivisto.

Source/WebCore:

Make sure that the "style" attribute is reserialized as needed when it gets retrieved
through an Attr object. This fixes a bug where updating an element's inline style
through the CSSOM API, and then retrieving the style attribute through an Attr node
that was previously created by element.getAttributeNode() would return the old style
attribute value.

Test: fast/dom/attr-style-too-lazy.html

* dom/Attr.cpp:
(WebCore::Attr::value):

LayoutTests:

* fast/dom/attr-style-too-lazy-expected.txt: Added.
* fast/dom/attr-style-too-lazy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Structure test_expectations.txt into meaningful sections
commit-queue@webkit.org [Tue, 22 May 2012 11:59:09 +0000 (11:59 +0000)]
[EFL][DRT] Structure test_expectations.txt into meaningful sections
https://bugs.webkit.org/show_bug.cgi?id=86628

Unreviewed, EFL gardening.

Organizing test_expectations.txt into categories.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-22

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a layout test for attribute selector invalidation triggering recursive style...
kling@webkit.org [Tue, 22 May 2012 11:57:20 +0000 (11:57 +0000)]
Add a layout test for attribute selector invalidation triggering recursive style recalc.
<http://webkit.org/b/21346>

Reviewed by Antti Koivisto.

Bug 21346 was already fixed somewhere in the semirecent past, so here's the provided
test case as form of a layout test to make sure we don't regress this again.

* fast/css/attribute-selector-recursive-update-on-setAttribute-expected.txt: Added.
* fast/css/attribute-selector-recursive-update-on-setAttribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: HeapProfiler: upstream retainedSize calculation.
loislo@chromium.org [Tue, 22 May 2012 11:54:50 +0000 (11:54 +0000)]
Web Inspector: HeapProfiler: upstream retainedSize calculation.
https://bugs.webkit.org/show_bug.cgi?id=87107

This patch upstreams V8::HeapSnapshotGenerator::CalculateRetainedSizes function to front-end.
After that we will be able to drop retainedSize field from the snapshot serialized data.
See meta-bug https://bugs.webkit.org/show_bug.cgi?id=87089

Reviewed by Yury Semikhatsky.

PerformanceTests:

* inspector/heap-snapshot.html: add counter for the _calculateRetainedSize method.

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get retainedSize):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):

LayoutTests:

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Mini clean ups in the interaction engine
kenneth@webkit.org [Tue, 22 May 2012 11:54:17 +0000 (11:54 +0000)]
[Qt] Mini clean ups in the interaction engine
https://bugs.webkit.org/show_bug.cgi?id=87013

Reviewed by Simon Hausmann.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
    Assert that we are suspended.
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
    Never zoom to any area if suspended which indicates other
    animation or user interaction.
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
    If immediate is set, ignore suspension.
(WebKit::QtViewportInteractionEngine::itemSizeChanged):
    Improve the comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Tap-to-zoom overshoot animation
commit-queue@webkit.org [Tue, 22 May 2012 11:44:54 +0000 (11:44 +0000)]
[Qt] Tap-to-zoom overshoot animation
https://bugs.webkit.org/show_bug.cgi?id=87108

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-22
Reviewed by Kenneth Rohde Christiansen.

Defines a simple animation curve that combines a large
ease-out (overshoot) with a small ease-in (correction).
Uses that curve for zooming animation.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::physicalOvershoot):
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNRWT results.html page should show a count of the number of tests in each category
kkristof@inf.u-szeged.hu [Tue, 22 May 2012 11:43:54 +0000 (11:43 +0000)]
NRWT results.html page should show a count of the number of tests in each category
https://bugs.webkit.org/show_bug.cgi?id=64215

Reviewed by Ojan Vafai.

* fast/harness/resources/results-test.js:
* fast/harness/results-expected.txt:
* fast/harness/results.html:
* platform/chromium-win/fast/harness/results-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remaining duplicated test in Skipped and test_expectations.txt after r117932
commit-queue@webkit.org [Tue, 22 May 2012 11:39:08 +0000 (11:39 +0000)]
[EFL] Remaining duplicated test in Skipped and test_expectations.txt after r117932
https://bugs.webkit.org/show_bug.cgi?id=87103

Unreviewed EFL gardening. Remove from Skipped file a test that is
already in test_expectations.txt to make the style script happy.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-22

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add missing test baselines
commit-queue@webkit.org [Tue, 22 May 2012 11:24:48 +0000 (11:24 +0000)]
[EFL] Add missing test baselines
https://bugs.webkit.org/show_bug.cgi?id=87110

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-22

* platform/efl/css1/font_properties/font-expected.txt: Added.
* platform/efl/css1/text_properties/line_height-expected.txt: Added.
* platform/efl/css3/selectors3/html/css3-modsel-32-expected.txt: Added.
* platform/efl/http/tests/misc/acid2-expected.png:
* platform/efl/http/tests/misc/acid2-expected.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
zandobersek@gmail.com [Tue, 22 May 2012 11:21:52 +0000 (11:21 +0000)]
[Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=86284

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add an additional method to the ChromeClient through which it is
possible to bypass the painting timer and force an immediate repaint of
the current dirty regions.

Add a new method to DumpRenderTreeSupportGtk class that calls that
method, making it possible to force an instant paint from
DumpRenderTree.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::paint): Only delay the painting if the paint is
not forced.
(WebKit::ChromeClient::forcePaint):
(WebKit):
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFrameChildren): Refactor getFrameChildren
to use the kit() function on the core child frames rather than using
the FrameLoaderClient of that frame, which is what the kit() function does in the first
place. This makes it possible to remove the inclusion of the FrameLoaderClientGtk.h
header which causes symbol name conflicts when included along with ChromeClientGtk.h
that originate in the Xlib headers included through the former header.
(DumpRenderTreeSupportGtk::forceWebViewPaint):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Paint the current dirty regions of the web view once more before
dumping pixel results.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange RenderBlock to user RenderBox/RenderInline writing mode logic
eae@chromium.org [Tue, 22 May 2012 11:16:16 +0000 (11:16 +0000)]
Change RenderBlock to user RenderBox/RenderInline writing mode logic
https://bugs.webkit.org/show_bug.cgi?id=87040

Reviewed by Eric Seidel.

Remove unnecessary writing mode logic in RenderBlock and use the
implementation in RenderBox and RenderInline instead.

No new tests, no change in functionality.

* rendering/RenderBlock.cpp:
(WebCore):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::marginStart):
(WebCore::RenderInline::marginEnd):
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):
* rendering/RenderInline.h:
(RenderInline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 22 May 2012 10:56:58 +0000 (10:56 +0000)]
Unreviewed GTK gardening.

Add a failing test expectation for a CSS test modified in r117815
(subpixel layout changes) and a GTK-specific baseline for a test
introduced in r117803.

* platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt: Added.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebSocket] WebSocket object should fire a simple event named error when it is requir...
commit-queue@webkit.org [Tue, 22 May 2012 10:52:12 +0000 (10:52 +0000)]
[WebSocket] WebSocket object should fire a simple event named error when it is required to fail the websocket connection.
https://bugs.webkit.org/show_bug.cgi?id=86958

Source/WebCore:

Patch by Li Yin <li.yin@intel.com> on 2012-05-22
Reviewed by Kent Tamura.

Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
If the user agent was required to fail the websocket connection or the
WebSocket connection is closed with prejudice, fire a simple event
named error at the WebSocket object.

Tests: http/tests/websocket/tests/hybi/close.html

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveMessageError):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):

LayoutTests:

Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
If the user agent was required to fail the websocket connection or the
WebSocket connection is closed with prejudice, fire a simple event
named error at the WebSocket object.

Patch by Li Yin <li.yin@intel.com> on 2012-05-22
Reviewed by Kent Tamura.

* http/tests/websocket/tests/hybi/close-expected.txt:
* http/tests/websocket/tests/hybi/close.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make the resizing code more straight forward
kenneth@webkit.org [Tue, 22 May 2012 10:49:20 +0000 (10:49 +0000)]
[Qt] Make the resizing code more straight forward
https://bugs.webkit.org/show_bug.cgi?id=87015

Reviewed by Simon Hausmann.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewFlickablePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add UI tests for fit-to-view
kenneth@webkit.org [Tue, 22 May 2012 10:45:24 +0000 (10:45 +0000)]
[Qt] Add UI tests for fit-to-view
https://bugs.webkit.org/show_bug.cgi?id=86857

Reviewed by Simon Hausmann.

Make sure to always emit contentsScaleCommitted when the
contents size changes, so that it can be used for testing.

Also add a method to do single taps.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
* UIProcess/API/qt/qwebkittest.cpp:
(touchPoint):
(QWebKitTest::touchTap):
(QWebKitTest::touchDoubleTap):
* UIProcess/API/qt/qwebkittest_p.h:
* UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove an entry for css3/filters/custom/filter-repaint-custom-rotated...
tkent@chromium.org [Tue, 22 May 2012 10:15:16 +0000 (10:15 +0000)]
[Chromium] Remove an entry for css3/filters/custom/filter-repaint-custom-rotated.html
https://bugs.webkit.org/show_bug.cgi?id=85868

The failure was fixed by ENABLE_SUBPIXEL_LAYOUT.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: allow showing selected object in another heap profiler view
yurys@chromium.org [Tue, 22 May 2012 09:53:45 +0000 (09:53 +0000)]
Web Inspector: allow showing selected object in another heap profiler view
https://bugs.webkit.org/show_bug.cgi?id=87098

Reviewed by Vsevolod Vlasov.

Added 2 context menu actions: 1) to jump from a node in the heap snapshot summary
view to the same node in the dominators view; 2) to jump from a node in the dominators
view to the same node in the summary view.

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid): "sorting complete" event is only dispatched on
when the data grid is populated. If we switch to already populated data grid the event is not
dispatched. However when switching between different views of a heap snapshot we want to track
the moment when the data grid is shown and populated. I added
WebInspector.HeapSnapshotSortableDataGrid.Events.ContentShown for such cases. The event will always
be dispatched after the data grid is shown and its content is populated.
(WebInspector.HeapSnapshotSortableDataGrid.prototype.wasShown):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._sortingComplete):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.revealInDominatorsView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu.else.revealInSummaryView):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.populateContextMenu):
(WebInspector.HeapSnapshotView.prototype.changeView.dataGridContentShown):
(WebInspector.HeapSnapshotView.prototype.changeView):
(WebInspector.HeapSnapshotView.prototype._onSelectedViewChanged):
(WebInspector.HeapSnapshotView.prototype._changeView):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskipped a test and updated its expectation.
kkristof@inf.u-szeged.hu [Tue, 22 May 2012 09:24:14 +0000 (09:24 +0000)]
[Qt] Unskipped a test and updated its expectation.
https://bugs.webkit.org/show_bug.cgi?id=87099

Reviewed by Csaba Osztrogonác.

* css1/units/rounding-expected.txt:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: show more button node should have height multiple of row height
yurys@chromium.org [Tue, 22 May 2012 09:22:54 +0000 (09:22 +0000)]
Web Inspector: show more button node should have height multiple of row height
https://bugs.webkit.org/show_bug.cgi?id=87104

Reviewed by Vsevolod Vlasov.

Made "show more" button height multiple of the data grid row height.

* inspector/front-end/ShowMoreDataGridNode.js:
(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):
* inspector/front-end/dataGrid.css:
(.data-grid button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium windows rebaselines.
eae@chromium.org [Tue, 22 May 2012 09:04:39 +0000 (09:04 +0000)]
Unreviewed chromium windows rebaselines.

* platform/chromium-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323: Added.
* platform/chromium-win-xp/css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug131020-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug43854-2-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug59354-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening. Skip failing tests after r117815.
ossy@webkit.org [Tue, 22 May 2012 08:52:02 +0000 (08:52 +0000)]
[Qt] Gardening. Skip failing tests after r117815.
https://bugs.webkit.org/show_bug.cgi?id=87099

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-05-22
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] dumpAsText() output of Qt-DRT differs from other DRTs
ossy@webkit.org [Tue, 22 May 2012 08:48:01 +0000 (08:48 +0000)]
[Qt] dumpAsText() output of Qt-DRT differs from other DRTs
https://bugs.webkit.org/show_bug.cgi?id=69718

Gardening, add Qt specific expected file for svg/custom/bug86119.html
introduced in r117792, because it lacks a trailing whitespace on Qt platform.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-22
Reviewed by Csaba Osztrogonác.

* platform/qt/svg/custom/bug86119-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGCC 4.7 and C++11 support.
hausmann@webkit.org [Tue, 22 May 2012 08:46:00 +0000 (08:46 +0000)]
GCC 4.7 and C++11 support.
https://bugs.webkit.org/show_bug.cgi?id=86465

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-22
Reviewed by Darin Adler.

Source/WTF:

Detect C++11 mode in GCC 4.7 and set appropiate compiler feature flags.
Turn C++11 override control into a compiler feature flag.
Fix non-clang support of compiler feature CXX_DELETED_FUNCTIONS.

* wtf/Compiler.h:
* wtf/Noncopyable.h:

Tools:

Update detection of C++11 mode in GCC.

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add an optional 'isolate' argument to throwTypeError()
haraken@chromium.org [Tue, 22 May 2012 08:38:34 +0000 (08:38 +0000)]
[V8] Add an optional 'isolate' argument to throwTypeError()
https://bugs.webkit.org/show_bug.cgi?id=87070

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch adds an optional 'isolate' argument to throwTypeError(),
and passes Isolate to throwTypeError()s. In a following patch,
I'll pass Isolate to all throwTypeError("message")s.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::throwTypeError):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorSetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Style issue due to tests duplicated in Skipped in test_expectations.txt
commit-queue@webkit.org [Tue, 22 May 2012 08:36:20 +0000 (08:36 +0000)]
[EFL] Style issue due to tests duplicated in Skipped in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=87093

Unreviewed EFL gardening. Remove from Skipped file tests that are
already in test_expectations.txt to make the style script happy.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-22

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark two tests as skipped while we figure out why they are failing.
eae@chromium.org [Tue, 22 May 2012 08:01:30 +0000 (08:01 +0000)]
Mark two tests as skipped while we figure out why they are failing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms][Meter][Progress] Change function signature of parseToDoubleForNumberType
yosin@chromium.org [Tue, 22 May 2012 07:53:22 +0000 (07:53 +0000)]
[Forms][Meter][Progress] Change function signature of parseToDoubleForNumberType
https://bugs.webkit.org/show_bug.cgi?id=87077

Reviewed by Hajime Morita.

This patch changes function signature of parseToDoubleForNumberType and
parseToDoubleForNumberTypeWithDecimalPlaces to return double value instead
of bool for reducing code in call sites for ease of maintenance. This patch
also allows to use functional style of using these functions.

No new tests. This patch doesn't change behavior.

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::min): Changed for using double return value.
(WebCore::HTMLMeterElement::max): Changed for using double return value.
(WebCore::HTMLMeterElement::value): Changed for using double return value.
(WebCore::HTMLMeterElement::low): Changed for using double return value.
(WebCore::HTMLMeterElement::high): Changed for using double return value.
(WebCore::HTMLMeterElement::optimum): Changed for using double return value.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::value): Changed for using double return value.
(WebCore::HTMLProgressElement::max): Changed for using double return value.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::typeMismatchFor): Changed for using double return value.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed for using double return value.
(WebCore::NumberInputType::parseToDouble): Changed for using double return value.
(WebCore::NumberInputType::parseToDoubleWithDecimalPlaces): Changed for using double return value.
(WebCore::NumberInputType::visibleValue): Changed for using double return value.
(WebCore::NumberInputType::sanitizeValue): Changed for using double return value.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::parseToDouble): Changed for using double return value.
* html/StepRange.cpp:
(WebCore::StepRange::parseStep): Changed for using double return value.
* html/StepRange.h:
(WebCore::StepRange::defaultValue): Added "const" attribute
(WebCore::StepRange::proportionFromValue): Added "const" attribute
(WebCore::StepRange::valueFromProportion): Added "const" attribute
* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType): Changed for using double return value. Added one parameter function.
(WebCore::parseToDoubleForNumberTypeWithDecimalPlaces): Changed for using double return value. Added function for providing default fallback value.
* html/parser/HTMLParserIdioms.h: Changed function prototype and added one parameter prototypes.
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Changed for using double return value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION r110315: Event handler throws TypeError for an input element with name...
haraken@chromium.org [Tue, 22 May 2012 07:50:51 +0000 (07:50 +0000)]
REGRESSION r110315: Event handler throws TypeError for an input element with name="arguments"
https://bugs.webkit.org/show_bug.cgi?id=86991

Reviewed by Ojan Vafai.

Source/WebCore:

Original Chromium bug: http://code.google.com/p/chromium/issues/detail?id=128723

Consider the following html:

<html><body><form>
<input type="hidden" name="arguments"></input>
<div onclick="onclicked()" id="divInsideForm">Click here</div>
</form></body>
<script>
function onclicked() {
  alert("onclicked");
}
</script>
</html>

If we click "Click here", JavaScript throws "Uncaught TypeError: undefined has no properties".

This is a regression caused by r110315. V8LazyEventListener should not use
'arguments' to retrieve the execution contexts, since 'arguments' can be
shadowed by JavaScript.

This patch changes V8LazyEventListener so that it retrieves contexts
by this[2], this[1] and this[0].

Test: fast/forms/form-input-named-arguments.html

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

The added test checks whether an event handler is successfully invoked
for an input element with name="arguments".

* fast/forms/form-input-named-arguments-expected.txt: Added.
* fast/forms/form-input-named-arguments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium linux and mac rebaselines.
eae@chromium.org [Tue, 22 May 2012 07:47:26 +0000 (07:47 +0000)]
Chromium linux and mac rebaselines.

* css2.1/20110323/absolute-replaced-height-004-expected.txt: Added.
* platform/chromium-linux-x86/fast/dom/Document/CaretRangeFromPoint: Removed.
* platform/chromium-linux-x86/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
* platform/chromium-linux-x86/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
* platform/chromium-linux-x86/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/absolute-replaced-height-004-expected.txt: Removed.
* platform/chromium-linux/fast/dom/Document/CaretRangeFromPoint: Removed.
* platform/chromium-linux/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
* platform/chromium-linux/fast/repaint/reflection-repaint-test-expected.png: Added.
* platform/chromium-linux/fast/repaint/transform-layout-repaint-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/dom/Document/CaretRangeFromPoint: Removed.
* platform/chromium-mac-leopard/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug215629-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/Document/CaretRangeFromPoint: Removed.
* platform/chromium-mac-snowleopard/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Document/CaretRangeFromPoint: Removed.
* platform/chromium-mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug106816-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug131020-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug139524-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug159108-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug215629-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46480-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug46480-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/chromium-win-vista/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Added.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-32-expected.txt: Added.
* platform/chromium-win-vista/editing/inserting: Added.
* platform/chromium-win-vista/editing/inserting/4959067-expected.txt: Added.
* platform/chromium-win-vista/fast/dom/Document/CaretRangeFromPoint: Removed.
* platform/chromium-win-vista/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/chromium-win-vista/tables/mozilla_expected_failures/marvin: Removed.
* platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Removed.
* platform/chromium-win-xp/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Added.
* platform/chromium-win-xp/editing/inserting: Added.
* platform/chromium-win-xp/editing/inserting/4959067-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom: Added.
* platform/chromium-win-xp/svg/zoom/page: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/bugs/bug59354-expected.png: Added.
* platform/chromium-win/css2.1/20110323/absolute-replaced-height-004-expected.txt:
* platform/chromium-win/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt:
* platform/chromium-win/css3/selectors3/html/css3-modsel-32-expected.txt:
* platform/chromium-win/editing/inserting/4959067-expected.txt:
* platform/chromium-win/fast/dom/Document: Removed.
* platform/chromium-win/fast/repaint/reflection-repaint-test-expected.png:
* platform/chromium-win/fast/repaint/transform-layout-repaint-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug106816-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug131020-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug139524-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug159108-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug215629-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug39209-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug43854-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug46480-1-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug46480-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug83786-expected.png:
* platform/chromium-win/tables/mozilla/marvin/x_table_align_center-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/chromium-win/transforms/2d/zoom-menulist-expected.txt:
* platform/chromium-win/transforms/svg-vs-css-expected.png:
* platform/chromium/fast/dom/Document: Added.
* platform/chromium/fast/dom/Document/CaretRangeFromPoint: Added.
* platform/chromium/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
* platform/chromium/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt: Removed.
* platform/efl/css3/selectors3/html/css3-modsel-32-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug215629-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Removed.
* platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt: Removed.
* platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
* platform/efl/transforms/svg-vs-css-expected.txt: Removed.
* platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug215629-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug43854-2-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug83786-expected.txt: Removed.
* platform/gtk/tables/mozilla/marvin/x_table_align_center-expected.txt: Removed.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
* platform/gtk/transforms/svg-vs-css-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug83786-expected.txt: Removed.
* tables/mozilla/bugs/bug215629-expected.txt: Added.
* tables/mozilla/bugs/bug43854-2-expected.txt: Added.
* tables/mozilla/bugs/bug83786-expected.txt: Added.
* tables/mozilla/marvin/x_table_align_center-expected.txt: Added.
* tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
* transforms/svg-vs-css-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] setDOMException() should return v8::Handle<v8::Value>()
haraken@chromium.org [Tue, 22 May 2012 07:42:10 +0000 (07:42 +0000)]
[V8] setDOMException() should return v8::Handle<v8::Value>()
https://bugs.webkit.org/show_bug.cgi?id=87083

Reviewed by Adam Barth.

The following patterns are used here and there in V8 bindings:

    setDOMException();
    return v8::Handle<v8::Value>();

and

    setDOMException();
    return v8::Undefined();

By returning v8::Handle<v8::Value>() from setDOMException(), we can simplify the above patterns into this:

    return setDOMException();

This patch just replaces the code in CodeGeneratorV8.pm. I'll replace
all other custom bindings in a follow-up patch.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateSetDOMException):
(GenerateFunctionCallback):
(GenerateFunctionCallString):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed expectations update against r117989.
morrita@google.com [Tue, 22 May 2012 07:40:05 +0000 (07:40 +0000)]
Unreviewed expectations update against r117989.

* bindings/scripts/test/V8/V8Float64Array.cpp:
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
* bindings/scripts/test/V8/V8TestException.cpp:
* bindings/scripts/test/V8/V8TestInterface.cpp:
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
* bindings/scripts/test/V8/V8TestNode.cpp:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: migrate dominatorIndex code to the front-end calculated dominatorsTree.
loislo@chromium.org [Tue, 22 May 2012 07:30:20 +0000 (07:30 +0000)]
Web Inspector: migrate dominatorIndex code to the front-end calculated dominatorsTree.
https://bugs.webkit.org/show_bug.cgi?id=87024

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
(WebInspector.HeapSnapshot.prototype._init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Replace 'throwError(); return Undefined();' with 'return throwError()'
haraken@chromium.org [Tue, 22 May 2012 07:25:22 +0000 (07:25 +0000)]
[V8] Replace 'throwError(); return Undefined();' with 'return throwError()'
https://bugs.webkit.org/show_bug.cgi?id=87079

Reviewed by Adam Barth.

This patch replaces

    throwError();
    return v8::Undefined();

with

    return throwError();

No tests. No change in behavior.

* bindings/v8/DateExtension.cpp:
(WebCore::DateExtension::OnSleepDetected):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline of fast/loader/recursive-before-unload-crash.html
eae@chromium.org [Tue, 22 May 2012 07:18:33 +0000 (07:18 +0000)]
Unreviewed rebaseline of fast/loader/recursive-before-unload-crash.html

* platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117922 268f45cc-cd09-0410-ab3c-d52691b4dbfc