jhoneycutt@apple.com [Mon, 13 Dec 2010 06:31:55 +0000 (06:31 +0000)]
Unreviewed build fix.
* WebCore.vcproj/WebCore.vcproj:
Remove accidentally-committed conflict marker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 13 Dec 2010 06:06:19 +0000 (06:06 +0000)]
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
* editing/spelling/script-tests/spellcheck-paste.js: Added.
* editing/spelling/spellcheck-paste.html: Added.
* editing/spelling/spellcheck-paste-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
- Introduced SpellChecker class to encapsulate asynchronous spell
checker state: sequence id, requesting text and target node.
This is also the first step to decompose spell-check related
code to a separate class.
- Added EditorClient::isAsynchronousSpellCheckingEnabled()
to use async spellcheck API on the platform.
These APIs are touched by SpellChecker.
- Used SpellChecker to check a pasted test. Text to check is
collected from the subtree under the editingRoot.
- Added Setting::m_asynchronousSpellCheckingEnabled to control
async spell checking.
Test: editing/spelling/spellcheck-paste.html
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::showMarkers):
(showDocumentMarkers):
* dom/DocumentMarkerController.h:
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::setOffsetInLeafNode):
* dom/PositionIterator.h:
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::Editor):
(WebCore::findFirstMarkable):
(WebCore::Editor::selectionStartHasSpellingMarkerFor):
* editing/Editor.h:
(WebCore::Editor::spellChecker):
* editing/SpellChecker.cpp: Added.
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::~SpellChecker):
(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::isAsynchronousEnabled):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::isCheckable):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::forwardIterator):
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h: Added.
(WebCore::SpellCheckingResult::SpellCheckingResult):
(WebCore::SpellCheckingResult::type):
(WebCore::SpellCheckingResult::location):
(WebCore::SpellCheckingResult::length):
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::requestCheckingOfString):
* page/EditorClient.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAsynchronousSpellCheckingEnabled):
(WebCore::Settings::asynchronousSpellCheckingEnabled):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* src/EditorClientImpl.h:
(WebKit::EditorClientImpl::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebCoreSupport/EditorClientGtk.h:
(WebKit::EditorClient::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebCoreSupport/EditorClientHaiku.h:
(WebCore::EditorClientHaiku::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added asynchronous spell checking API to WebEditorClient using
-[NSSpellChecker requestCheckingOfString].
Note that WebEditorSpellCheckResponder is a small class to receive
requested spell-checking result. Note that this feature is
disabled at default.
Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
enable the feature from LayoutTestController.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
(-[WebEditorSpellCheckResponder perform]):
(toCoreSpellingResult):
(-[WebEditorSpellCheckResponder WTF::WebCore::]):
(WebEditorClient::requestCheckingOfString):
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
(-[WebPreferences asynchronousSpellCheckingEnabled]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebCoreSupport/EditorClientQt.h:
(WebCore::EditorClientQt::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebCoreSupport/EditorClientWinCE.h:
(WebKit::EditorClient::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebKitSupport/EditorClientWx.h:
(WebCore::EditorClientWx::requestCheckingOfString):
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::requestCheckingOfString):
* WebProcess/WebCoreSupport/WebEditorClient.h:
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
to control the setting.
* DumpRenderTree/LayoutTestController.cpp:
(setAsynchronousSpellCheckingEnabledCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setAsynchronousSpellCheckingEnabled):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAsynchronousSpellCheckingEnabled):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setAsynchronousSpellCheckingEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setAsynchronousSpellCheckingEnabled):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAsynchronousSpellCheckingEnabled):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setAsynchronousSpellCheckingEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Mon, 13 Dec 2010 05:52:40 +0000 (05:52 +0000)]
2010-12-09 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up (part II)
https://bugs.webkit.org/show_bug.cgi?id=50666
No new tests needed.
* page/FocusController.cpp: Removed static declaration of updateFocusCandidateIfNeeded() from
the top of FocusController.cpp, and added the 'static' keyword where the function is implemented;
* page/SpatialNavigation.cpp: In FocusCandidate constructor, renamed 'n' to 'node', and added an assert to it;
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::virtualRectForAreaElementAndDirection): Added an assert to 'node';
* page/SpatialNavigation.h:I reordered the declaration of some methods in order to group related ones;
Removed isScrollableContainerNode() function declaration since it is not used outside SpatialNavigation.cpp;
And removed the declaration of isNodeDeepDescendantOfDocument() since it does not exist anymore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Mon, 13 Dec 2010 04:41:20 +0000 (04:41 +0000)]
WebKit2: Implement WebInspector::localizedStringsURL on Windows
https://bugs.webkit.org/show_bug.cgi?id=50896
Reviewed by Tim Hatcher.
Find the localized strings file using CFBundleCopyResourceURL.
* WebProcess/WebPage/win/WebInspectorWin.cpp:
(WebKit::WebInspector::localizedStringsURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Dec 2010 00:49:26 +0000 (00:49 +0000)]
Update WebKit2 skipped list.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Dec 2010 00:30:20 +0000 (00:30 +0000)]
Give LogTextInput a sensible flag value.
Reviewed by Anders Carlsson.
* Platform/Logging.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Dec 2010 00:25:55 +0000 (00:25 +0000)]
Add missing bugzilla URL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Dec 2010 00:14:06 +0000 (00:14 +0000)]
Fix failing API test. It turns out that a pop-state event
is sent before every fragment navigation, so we have to test
for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
Reviewed by Anders Carlsson.
* TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
(TestWebKitAPI::didSameDocumentNavigationForFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Dec 2010 00:02:07 +0000 (00:02 +0000)]
Remove incorrect assertion that has been firing in the API tester.
Reviewed by Anders Carlsson.
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 13 Dec 2010 00:00:12 +0000 (00:00 +0000)]
Disable WebKit2 logging by default.
Reviewed by Anders Carlsson.
* Platform/Logging.cpp:
(initializeLogChannelsIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sun, 12 Dec 2010 20:15:51 +0000 (20:15 +0000)]
Web Inspector: Make inspector on Windows show and be usable in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50877
Reviewed by Sam Weinig.
Hook up the unimplemented methods in WebInspectorProxyWin to get the web inspector
showing and usable in WebKit2 on Windows.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize Windows-specific variables to 0.
* UIProcess/WebInspectorProxy.h:
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::registerInspectorViewWindowClass): Sets up the inspector view class.
(WebKit::WebInspectorProxy::InspectorViewWndProc): Calls through to the WebInspectorProxy's non-static
WndProc.
(WebKit::WebInspectorProxy::wndProc): Handles WM_SIZE, WM_CLOSE, and WM_GETMINMAXINFO, the rest go to
::DefWindowProc.
(WebKit::WebInspectorProxy::onSizeEvent): Resize the WKView that has the inspector page to match the
outer window that was just resized.
(WebKit::WebInspectorProxy::onMinMaxInfoEvent): Set the minimum size the window can be resized to.
(WebKit::WebInspectorProxy::onCloseEvent): Hide the window, and call WebInspectorProxy::close.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WKView and return its page.
(WebKit::WebInspectorProxy::platformOpen): Create an HWND for the inspector, put the inspector's WKView
inside of it, and show the window.
(WebKit::WebInspectorProxy::platformClose): Destroy the inspector's window (which destroys the child WKView),
and 0 out instance variables.
(WebKit::WebInspectorProxy::inspectorPageURL): Finds inspector/inspector.html in the WebKit bundle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Sun, 12 Dec 2010 16:25:50 +0000 (16:25 +0000)]
[Qt][WK2] Crash in WebPage constructor.
https://bugs.webkit.org/show_bug.cgi?id=50892
Reviewed by Andreas Kling.
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Disable runtime enabled features that have no WebKit2 implementation yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sun, 12 Dec 2010 12:00:49 +0000 (12:00 +0000)]
2010-12-12 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Martin Robinson.
* webkit/webkitwebplugin.h: add a note about the extension list
being a NULL-terminated array.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sun, 12 Dec 2010 12:00:36 +0000 (12:00 +0000)]
2010-12-12 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Stop checking for glib >= 2.16, we have dependend on a newer
version for a long time now.
* tests/testatk.c: Stop checking for glib >= 2.16.
* tests/testatkroles.c: ditto.
* tests/testdomdocument.c: ditto.
* tests/testdomdomwindow.c: ditto.
* tests/testdomnode.c: ditto.
* tests/testglobals.c: ditto.
* tests/testhttpbackend.c: ditto.
* tests/testloading.c: ditto.
* tests/testmimehandling.c: ditto.
* tests/testnetworkrequest.c: ditto.
* tests/testnetworkresponse.c: ditto.
* tests/testwebbackforwardlist.c: ditto.
* tests/testwebdatasource.c: ditto.
* tests/testwebframe.c: ditto.
* tests/testwebhistoryitem.c: ditto.
* tests/testwebresource.c: ditto.
* tests/testwebsettings.c: ditto.
* tests/testwebview.c: ditto.
* tests/testwindow.c: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 12 Dec 2010 11:46:01 +0000 (11:46 +0000)]
2010-12-12 Alejandro G. Castro <alex@igalia.com>
Reviewed by Eric Seidel.
[GTK] Add new-run-webkit-tests support to gtk
https://bugs.webkit.org/show_bug.cgi?id=50681
Adding the basic support to run the new-run-webkit-tests.
* Scripts/webkitpy/layout_tests/port/gtk.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Sun, 12 Dec 2010 11:30:56 +0000 (11:30 +0000)]
2010-12-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
build-webkit --gtk --minimal fails
https://bugs.webkit.org/show_bug.cgi?id=46267
No new tests, build fix only.
* GNUmakefile.am: Include some JS bindings generated headers in
the build even if their corresponding feature is disabled. They
are needed to make the DOM bindings build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Sun, 12 Dec 2010 11:02:41 +0000 (11:02 +0000)]
2010-12-12 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skipping failing tests in the bots.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 12 Dec 2010 11:00:55 +0000 (11:00 +0000)]
2010-12-12 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Eric Seidel.
[Qt] Compile with QT_NO_QUUID_STRING.
https://bugs.webkit.org/show_bug.cgi?id=49745
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 12 Dec 2010 10:58:59 +0000 (10:58 +0000)]
2010-12-12 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Eric Seidel.
[Qt] Missing style for date pickers on Qt Mobile theme
https://bugs.webkit.org/show_bug.cgi?id=50628
* css/themeQtMobile.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Sun, 12 Dec 2010 07:42:55 +0000 (07:42 +0000)]
Mac build fix.
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
Resolve string[0] ambiguity by passing 0U.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 12 Dec 2010 03:42:44 +0000 (03:42 +0000)]
2010-12-11 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Memory leaks for QWebPageClient
https://bugs.webkit.org/show_bug.cgi?id=50267
Use OwnPtr to solve this memory leak issue.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::overlay):
(QGraphicsWebViewPrivate::QWebViewPrivate::pageClient):
(QGraphicsWebViewPrivate::syncLayers):
(QGraphicsWebViewPrivate::updateResizesToContentsForPage):
(QGraphicsWebViewPrivate::_q_scaleChanged):
(QGraphicsWebViewPrivate::detachCurrentPage):
* Api/qwebpage_p.h:
* Api/qwebview.cpp:
(QWebViewPrivate::detachCurrentPage):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::platformPageClient):
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Sun, 12 Dec 2010 03:24:56 +0000 (03:24 +0000)]
2010-12-10 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION Hang inside Yarr::RegexCodeBlock::execute when visiting
bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=50816
First nested parentheses of the second or greater alternative
where backtracking to the prior parentheses. Changed the default
handling of initial parentheses for all alternatives to go back
to the immediate outer paren.
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail):
(JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState):
(JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm):
(JSC::Yarr::RegexGenerator::TermGenerationState::getTermIndex):
(JSC::Yarr::RegexGenerator::TermGenerationState::setParenthesesTail):
(JSC::Yarr::RegexGenerator::TermGenerationState::getParenthesesTail):
(JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail):
(JSC::Yarr::RegexGenerator::ParenthesesTail::processBacktracks):
(JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode):
(JSC::Yarr::RegexGenerator::generateParenthesesSingle):
2010-12-10 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION Hang inside Yarr::RegexCodeBlock::execute when visiting
bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=50816
New test to verify proper backtracking of alternative nested parens.
* fast/regex/parentheses-expected.txt:
* fast/regex/script-tests/parentheses.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 12 Dec 2010 03:21:51 +0000 (03:21 +0000)]
2010-12-11 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] QWebFrame does not support QNetworkRequest::CacheLoadControl
https://bugs.webkit.org/show_bug.cgi?id=35671
Make QWebFrame respect the QNetworkRequest::CacheLoadControl attribute
set on the request, if any.
* Api/qwebframe.cpp:
(cacheLoadControlToCachePolicy):
(QWebFrame::load):
* tests/qwebframe/tst_qwebframe.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 12 Dec 2010 00:35:15 +0000 (00:35 +0000)]
2010-12-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
[V8] Move to DOMWindow::setLocation
https://bugs.webkit.org/show_bug.cgi?id=50876
Recently, JavaScriptCore moved to implementing setLocation in WebCore.
This patch change V8 to use that common code path. I haven't removed
the old code path because it's still used for other things (like
assigning window.location.href), but I'll move the rest over in a
future patch.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
* bindings/v8/specialization/V8BindingState.cpp:
(WebCore::::getFirstWindow):
* bindings/v8/specialization/V8BindingState.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sat, 11 Dec 2010 20:55:05 +0000 (20:55 +0000)]
2010-12-11 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Updated chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
diegohcg@webkit.org [Sat, 11 Dec 2010 18:49:09 +0000 (18:49 +0000)]
[Qt] Mock DeviceOrientation client for DRT
https://bugs.webkit.org/show_bug.cgi?id=47490
Reviewed by Kenneth Rohde Christiansen.
WebCore:
* WebCore.pro:
WebKit/qt:
* WebCoreSupport/DeviceOrientationClientMockQt.cpp: Added.
(WebCore::DeviceOrientationClientMockQt::client):
(WebCore::DeviceOrientationClientMockQt::DeviceOrientationClientMockQt):
(WebCore::DeviceOrientationClientMockQt::~DeviceOrientationClientMockQt):
(WebCore::DeviceOrientationClientMockQt::setController):
(WebCore::DeviceOrientationClientMockQt::startUpdating):
(WebCore::DeviceOrientationClientMockQt::stopUpdating):
(WebCore::DeviceOrientationClientMockQt::lastOrientation):
(WebCore::DeviceOrientationClientMockQt::deviceOrientationControllerDestroyed):
(WebCore::DeviceOrientationClientMockQt::setOrientation):
* WebCoreSupport/DeviceOrientationClientMockQt.h: Added.
* WebCoreSupport/DeviceOrientationClientQt.cpp:
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::changeDeviceOrientation):
* WebCoreSupport/DeviceOrientationProviderQt.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::activeMockDeviceOrientationClient):
(DumpRenderTreeSupportQt::removeMockDeviceOrientation):
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
WebKitTools:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockDeviceOrientation):
LayoutTests:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sat, 11 Dec 2010 18:45:35 +0000 (18:45 +0000)]
2010-12-11 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 18:20:52 +0000 (18:20 +0000)]
2010-12-11 Joone Hur <joone@kldp.org>
Reviewed by Alexey Proskuryakov.
enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch
https://bugs.webkit.org/show_bug.cgi?id=50871
Fix the warning which occurs when enumeration value is not handled in switch.
No new tests, no change in behavior.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::response):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Sat, 11 Dec 2010 17:14:48 +0000 (17:14 +0000)]
2010-12-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] launcher: disable the Mozilla-style fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=50874
Disabling the fullscreen API until its implementation for GTK is
mature enough. The webview setting for it is already FALSE by
default.
* GtkLauncher/main.c:
(createWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sat, 11 Dec 2010 16:25:39 +0000 (16:25 +0000)]
2010-12-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add APIs for plugin management
https://bugs.webkit.org/show_bug.cgi?id=50827
Add WebKitWebPluginDatabase and WebKitWebPlugin classes for basic
plugin management at the client level. For now they provide
"read-only" access to the plugin list.
* GNUmakefile.am: add new files to the build.
* tests/testwebplugindatabase.c: Test that the database contains
the test plugin, which should always be loaded.
* webkit/webkit.h: add new headers.
* webkit/webkitdefines.h: add new defines.
* webkit/webkitwebplugin.cpp: An new class representing a plugin object.
* webkit/webkitwebplugin.h: ditto.
* webkit/webkitwebplugindatabase.cpp: A new class that contains the list of active plugins.
* webkit/webkitwebplugindatabase.h: ditto.
* webkit/webkitwebplugindatabaseprivate.h: Private header.
* webkit/webkitwebpluginprivate.h: Private header.
* webkit/webkitwebview.cpp:
(webkit_get_web_plugin_database): returns the WebKitWebPluginDatabase for this session.
* webkit/webkitwebview.h: add method to header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Sat, 11 Dec 2010 15:44:01 +0000 (15:44 +0000)]
2010-12-11 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skipping failing tests in the bots.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sat, 11 Dec 2010 15:38:51 +0000 (15:38 +0000)]
2010-12-11 Xan Lopez <xlopez@igalia.com>
Skip failing http test.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Sat, 11 Dec 2010 13:05:11 +0000 (13:05 +0000)]
2010-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Split private bits of several objects to their own private
headers, and to their implementation files.
* GNUmakefile.am:
* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/EditorClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchWillSendRequest):
* webkit/webkitdownload.cpp:
(webkit_download_set_response):
* webkit/webkitdownloadprivate.h: Added.
* webkit/webkithittestresult.cpp:
(WebKit::kit):
* webkit/webkithittestresultprivate.h: Added.
* webkit/webkitnetworkresponse.cpp:
(WebKit::core):
(WebKit::kitNew):
* webkit/webkitnetworkresponseprivate.h: Added.
* webkit/webkitprivate.cpp:
* webkit/webkitprivate.h:
* webkit/webkitsecurityorigin.cpp:
(webkit_security_origin_get_web_database):
(WebKit::core):
(WebKit::kit):
* webkit/webkitsecurityoriginprivate.h: Added.
* webkit/webkitviewportattributes.cpp:
* webkit/webkitviewportattributesprivate.h: Added.
* webkit/webkitwebbackforwardlist.cpp:
* webkit/webkitwebbackforwardlistprivate.h: Added.
* webkit/webkitwebdatabase.cpp:
* webkit/webkitwebframe.cpp:
(webkit_web_frame_get_network_response):
* webkit/webkitwebhistoryitem.cpp:
* webkit/webkitwebhistoryitemprivate.h: Added.
* webkit/webkitwebnavigationaction.cpp:
(WebKit::kit):
(WebKit::core):
* webkit/webkitwebnavigationactionprivate.h: Added.
* webkit/webkitwebpolicydecision.cpp:
* webkit/webkitwebpolicydecisionprivate.h: Added.
* webkit/webkitwebresource.cpp:
* webkit/webkitwebresourceprivate.h: Added.
* webkit/webkitwebsettings.cpp:
* webkit/webkitwebsettingsprivate.h: Added.
* webkit/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sat, 11 Dec 2010 12:51:12 +0000 (12:51 +0000)]
2010-12-11 Xan Lopez <xlopez@igalia.com>
Another crashing inspector test.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 11 Dec 2010 12:48:50 +0000 (12:48 +0000)]
2010-12-11 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Add an overload to makeString for Vector<char>
https://bugs.webkit.org/show_bug.cgi?id=50123
Also cleanup StringTypeAdapter.
* wtf/text/StringConcatenate.h:
2010-12-11 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Add an overload to makeString for Vector<char>
https://bugs.webkit.org/show_bug.cgi?id=50123
This also contains a segfault fix for ImageBuffer::toDataURL of the Haiku port.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/haiku/ImageBufferHaiku.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 11 Dec 2010 12:36:14 +0000 (12:36 +0000)]
Select menus with short option titles do not paint properly
https://bugs.webkit.org/show_bug.cgi?id=50860
<rdar://problem/8660807>
The backing stores used for painting the popup menu items were only as
wide as the widest option title, but the popup window that we create is
at least as wide as the <select> element. This adjusts the backing
stores to be at least as wide as the <select>, as well.
Reviewed by Sam Weinig.
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::paint):
Paint using the width of the backing store.
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::show):
Pass the page coordinates of the <select> element to
setUpPlatformData().
* WebProcess/WebCoreSupport/WebPopupMenu.h:
Added new parameter to setUpPlatformData().
* WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
Ditto.
* WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
Ditto.
* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
Fixed a typo in a comment. Adjust the backing store size to be at least
as wide as the <select> element, and use that width when painting the
items to the backing store.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sat, 11 Dec 2010 11:37:01 +0000 (11:37 +0000)]
2010-12-11 Xan Lopez <xlopez@igalia.com>
inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Sat, 11 Dec 2010 11:26:25 +0000 (11:26 +0000)]
2010-12-11 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskip some media tests on GTK that don't fail locally.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 11 Dec 2010 09:49:19 +0000 (09:49 +0000)]
Unreviewed Qt buildfix after r73808.
WebKit2: Need a WebKit2 equivalent of the WebKit1 WebDatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=50606
* DerivedSources.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 09:10:24 +0000 (09:10 +0000)]
2010-12-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73834.
http://trac.webkit.org/changeset/73834
https://bugs.webkit.org/show_bug.cgi?id=50866
It broke Qt-WebKit2 build, because of missing WK2_DIR variable
(Requested by Ossy on #webkit).
* WebKit2.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 11 Dec 2010 07:21:02 +0000 (07:21 +0000)]
Mac build fix.
* platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
Resolve string[0] ambiguity by passing 0U.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 07:14:32 +0000 (07:14 +0000)]
2010-12-10 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Eric Seidel.
[Qt] Build fix for Symbian: don't compile POSIX memory management implementation
https://bugs.webkit.org/show_bug.cgi?id=50707
* wtf/wtf.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sat, 11 Dec 2010 07:03:35 +0000 (07:03 +0000)]
Windows production build fix.
Only the vsprops are indirected through WebKitVSPropsRedirectionDir, not the scripts in WebKitLibraries/win/tools/scripts.
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
* WebCore.vcproj/build-generated-files.sh:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 06:50:13 +0000 (06:50 +0000)]
2010-12-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Eric Seidel.
Remove WebCore/platform/mac/GeolocationService.{h,mm}
https://bugs.webkit.org/show_bug.cgi?id=50074
Remove unused non-client-based geolocation code.
* platform/mac/GeolocationServiceMac.h: Removed.
* platform/mac/GeolocationServiceMac.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 11 Dec 2010 06:47:30 +0000 (06:47 +0000)]
2010-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue flaky test messages show cryptic version information for mac os x
https://bugs.webkit.org/show_bug.cgi?id=50864
Turns out platform.platform() returns kernel version information
which isn't helpful, and just plain confusing on Mac
(OS X 10.6.5 uses Darwin Kernel 10.5.0).
So I've updated PlatformInfo.display_name() to special case
mac. I also found a bad use of sys.platform in the process
and fixed that. (sys.platform always returns 'darwin' on mac).
* Scripts/webkitpy/common/system/platforminfo.py:
* Scripts/webkitpy/common/system/user.py:
* Scripts/webkitpy/tool/bot/flakytestreporter.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sat, 11 Dec 2010 06:40:56 +0000 (06:40 +0000)]
Windows production build fix.
Don't stop if react-to-vsprops-changes.py exits with an error,
since this will occur in production builds.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 11 Dec 2010 06:15:17 +0000 (06:15 +0000)]
2010-12-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46573
<rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work
* http/tests/mime/quoted-charset-expected.txt: Added.
* http/tests/mime/quoted-charset.php: Added.
2010-12-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46573
<rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work
Test: http/tests/mime/quoted-charset.php
* platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
Work around a CFNetwork issue, strip quotes if they are present.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 11 Dec 2010 05:34:49 +0000 (05:34 +0000)]
2010-12-10 Eric Seidel <eric@webkit.org>
Unreviewed.
Exception seen while reporting flaky test with commit-queue.
Just a missing include.
* Scripts/webkitpy/tool/bot/flakytestreporter.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 04:58:58 +0000 (04:58 +0000)]
2010-12-10 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Eric Seidel.
[Qt][WK2] Make WebKit2 static library compile on Symbian
https://bugs.webkit.org/show_bug.cgi?id=50861
* WebKit2.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Sat, 11 Dec 2010 03:25:05 +0000 (03:25 +0000)]
2010-12-10 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
https://bugs.webkit.org/show_bug.cgi?id=50796
Also updating the test code to use JSONResultsGeneratorBase and
to improve test coverage for incremental cases.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 03:00:41 +0000 (03:00 +0000)]
2010-12-10 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
Shader::loadShader() must initialize variable passed to getShaderiv
https://bugs.webkit.org/show_bug.cgi?id=50842
Test: fast/canvas/canvas-largedraws.html
* platform/graphics/gpu/Shader.cpp:
(WebCore::Shader::loadShader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 02:53:02 +0000 (02:53 +0000)]
2010-12-10 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
Texture::updateSubRect should pass IntRect by reference
https://bugs.webkit.org/show_bug.cgi?id=50845
No test, changing to pass by ref.
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::updateSubRect):
* platform/graphics/gpu/Texture.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Sat, 11 Dec 2010 02:43:02 +0000 (02:43 +0000)]
2010-12-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Attach more specific bug IDs to Philip canvas test suite failures.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 11 Dec 2010 02:20:00 +0000 (02:20 +0000)]
2010-12-10 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Move open and showModalDialog implementations from bindings into DOM class DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=50836
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open): Removed most of the code and changed to call
DOMWindow::open.
(WebCore::DialogHandler::DialogHandler): Added. Object is used to handle the
arguments and return value in showModalDialog.
(WebCore::DialogHandler::dialogCreated): Ditto.
(WebCore::DialogHandler::returnValue): Ditto.
(WebCore::setUpDialog): Added. Function passed to showModalDialog that just
casts pointer to DialogHandler can calls dialogCreated.
(WebCore::JSDOMWindow::showModalDialog): Removed most of the code and changed
to call DOMWindow::showModalDialog.
(WebCore::JSDOMWindow::postMessage): Made style match the rest of the file by
renaming local variables and getting rid of a needless ones.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parseModalDialogFeatures): Moved body of this function
to the WindowFeatures class.
(WebCore::DOMWindow::allowPopUp): Renamed argument from activeFrame to firstFrame,
because that's the frame we pass in here. Also added an overload so this can be
called on a window rather than a frame.
(WebCore::DOMWindow::setLocation): Renamed a couple variables so the names are
the same as in open and showModalDialog. Factored the JavaScript security check
into a new function named isInsecureScriptAccess.
(WebCore::DOMWindow::isInsecureScriptAccess): Here is the new function.
(WebCore::DOMWindow::createWindow): Added. Contains logic shared by open and
showModalDialog just as the function named createWindow in JSDOMWindowCustom.cpp
used to.
(WebCore::DOMWindow::open): Added. Code from JSDOMWindowCustom without the
JavaScript language binding part, and with a bit of refactoring to share code
with the rest of the DOMWindow class.
(WebCore::DOMWindow::showModalDialog): Ditto.
* page/DOMWindow.h: Moved conditional parts of the file into separate paragraphs
in alphabetical order so they are not scattered thorugh the file. Removed redundant
includes. Added some blank lines for clarity. Added an open function and a
showModalDialog function. Added private createWindow and isInsecureScriptAccess
functions.
* page/WindowFeatures.cpp:
(WebCore::isWindowFeaturesSeparator): Renamed from isSeparator for clarity.
(WebCore::WindowFeatures::WindowFeatures): Updated for name change. Used isEmpty
instead of checking length. Added a new constructor for use when making dialogs,
with code from the showModalDialog function.
(WebCore::WindowFeatures::boolFeature): Use DialogFeaturesMap typedef.
(WebCore::WindowFeatures::floatFeature): Use DialogFeaturesMap typedef.
Renamed a local variable and tweaked the comments a bit.
(WebCore::WindowFeatures::parseDialogFeatures): Added. Code moved here from
DOMWindow::parseDialogFeatures and refactored a bit.
* page/WindowFeatures.h: Added new constructor, new parseDialogFeatures
function, DialogFeaturesMap typedef, and made setWindowFeature function private.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 11 Dec 2010 02:14:22 +0000 (02:14 +0000)]
Ensure that we are not getting too many wheel events
<rdar://problem/7881465>
Reviewed by Anders Carlsson.
Add simple coalescing of wheel events being sent to the WebProcess. This
adds two models, one which drops interim events and one which merges events
together. For now, we are using the simpler dropping model.
* Shared/WebEvent.h:
(WebKit::WebEvent::modifiers):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::coalesceWheelEvents):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* UIProcess/WebPageProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Sat, 11 Dec 2010 02:08:07 +0000 (02:08 +0000)]
2010-12-10 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
prepare-ChangeLog --help doesn't mention --bug shorthand -b
https://bugs.webkit.org/show_bug.cgi?id=50835
* Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Sat, 11 Dec 2010 02:02:47 +0000 (02:02 +0000)]
2010-12-10 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
prepare-ChangeLog --help doesn't mention --bug shorthand -b
https://bugs.webkit.org/show_bug.cgi?id=50835
* Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Sat, 11 Dec 2010 02:00:46 +0000 (02:00 +0000)]
AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
https://bugs.webkit.org/show_bug.cgi?id=50574
Reviewed by Darin Adler.
WebCore:
Refactors accessibility hit testing to allow for a more flexible model when handling elements
with fake sub-elements (like sliders or list boxes).
Renamed doAccessibilityHitTest -> accessibilityHitTest, which is called on the root
accessibility render object. Then subclassers are able to override
elementAccessibilityHitTest to return their own specific elements.
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::elementAccessibilityHitTest):
* accessibility/AccessibilitySlider.h:
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_component_ref_accessible_at_point):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
WebKit/chromium:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::hitTest):
WebKit/win:
* AccessibleBase.cpp:
(AccessibleBase::accHitTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 01:48:20 +0000 (01:48 +0000)]
2010-12-10 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Ojan Vafai.
Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
https://bugs.webkit.org/show_bug.cgi?id=50233
First part of two-part patch to remove unnecessary pixel tests, and (in part two)
have a single set of text expectations for all platforms. The standardized text
expectations are added in this patch.
* platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.png: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.png: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.png: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.png: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.png: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
* platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.png: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.png: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.png: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.png: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
* platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.png: Removed.
* platform/mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
* platform/mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
* platform/mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
* platform/mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
* platform/mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
* platform/mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
* platform/mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
* platform/mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
* platform/mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
* platform/mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
* svg/custom/svg-parse-overflow-1-expected.txt: Added.
* svg/custom/svg-parse-overflow-1.html:
* svg/custom/svg-parse-overflow-2-expected.txt: Added.
* svg/custom/svg-parse-overflow-2.html:
* svg/custom/svg-parse-overflow-3-expected.txt: Added.
* svg/custom/svg-parse-overflow-3.html:
* svg/custom/svg-parse-overflow-4-expected.txt: Added.
* svg/custom/svg-parse-overflow-4.html:
* svg/custom/svg-parse-overflow-5-expected.txt: Added.
* svg/custom/svg-parse-overflow-5.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 11 Dec 2010 01:35:42 +0000 (01:35 +0000)]
2010-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
https://bugs.webkit.org/show_bug.cgi?id=50853
I also discovered when doing this that the code was posting
the comment on the wrong bug, but that's fixed here too.
* Scripts/webkitpy/common/net/bugzilla/bug.py:
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
* Scripts/webkitpy/tool/bot/flakytestreporter.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sat, 11 Dec 2010 01:31:54 +0000 (01:31 +0000)]
Unreviewed Chromium test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Sat, 11 Dec 2010 01:25:37 +0000 (01:25 +0000)]
2010-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Darin Adler.
Clean up assertion in Extensions3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=50852
Built Release mode to test. No functionality change.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 11 Dec 2010 01:23:26 +0000 (01:23 +0000)]
2010-12-10 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
Crash while processing ill-formed <textPath> ouside of <text>
https://bugs.webkit.org/show_bug.cgi?id=47759
Ensure that ill-formed text content child elements do not crash.
* svg/custom/invalid-text-content.svg: Added.
* svg/custom/invalid-text-content-expected.checksum: Added.
* svg/custom/invalid-text-content-expected.png: Added.
* svg/custom/invalid-text-content-expected.txt: Added.
2010-12-10 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
Crash while processing ill-formed <textPath> ouside of <text>
https://bugs.webkit.org/show_bug.cgi?id=47759
Renderers within a <text> subtree are created only when their corresponding elements
satisfy the content model.
Test: svg/custom/invalid-text-content.svg
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::childShouldCreateRenderer): Fixed to comply with the content model.
(WebCore::SVGTRefElement::rendererIsNeeded): Added.
* svg/SVGTRefElement.h:
* svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::childShouldCreateRenderer): Fixed to comply with the content model.
(WebCore::SVGTSpanElement::rendererIsNeeded): Added.
* svg/SVGTSpanElement.h: Changed indentation.
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::childShouldCreateRenderer): Reformatted.
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::childShouldCreateRenderer): Fixed to comply with the content model.
(WebCore::SVGTextPathElement::rendererIsNeeded): Added.
* svg/SVGTextPathElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Sat, 11 Dec 2010 01:19:20 +0000 (01:19 +0000)]
2010-12-10 Zhenyao Mo <zmo@google.com>
Reviewed by Adam Barth.
Use enums instead of booleans in ImageSource/ImageDecoder constructors
https://bugs.webkit.org/show_bug.cgi?id=50818
* src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::init): Use enums instead of boolean in ImageDecoder constructor.
2010-12-10 Zhenyao Mo <zmo@google.com>
Reviewed by Adam Barth.
Use enums instead of booleans in ImageSource/ImageDecoder constructors
https://bugs.webkit.org/show_bug.cgi?id=50818
This patch basically defines two enum type in ImageSource: AlphaOption
and GammaAndColorProfileOption and use them as ImageSource and ImageDecoder
constructor parameters instead of boolean typs.
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::setData):
* platform/graphics/ImageSource.h: Define the two enum types.
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::ImageDecoder):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::BMPImageDecoder):
* platform/image-decoders/bmp/BMPImageDecoder.h:
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::ICOImageDecoder):
(WebCore::ICOImageDecoder::decodeAtIndex):
* platform/image-decoders/ico/ICOImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::JPEGImageDecoder):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::PNGImageDecoder):
* platform/image-decoders/png/PNGImageDecoder.h:
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::WEBPImageDecoder):
* platform/image-decoders/webp/WEBPImageDecoder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 11 Dec 2010 00:30:14 +0000 (00:30 +0000)]
2010-12-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r73799): editing/execCommand/4920488.html fails
https://bugs.webkit.org/show_bug.cgi?id=50854
The regression was caused by Range::processContents's not extracting
m_end.container()->firstChild(). Fixed the bug by always adding the first child.
* dom/Range.cpp:
(WebCore::Range::processContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 11 Dec 2010 00:12:35 +0000 (00:12 +0000)]
2010-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Infinite redirect on developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=45627
Tests: fast/loader/form-submit-aborts-parsing.html
fast/loader/location-change-aborts-parsing.html
This patch is not pretty, but it fixes the bug. I stole this approach
from the old HTML parser (as suggested by Eric Seidel). The other
approaches that folks tried for this bug are better, but it's inclear
how to get them to work correctly. I've added a large FIXME comment.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::isParsingFragment):
2010-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Infinite redirect on developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=45627
Tests originally by Tony Gentilcore.
* fast/loader/form-submit-aborts-parsing-expected.txt: Added.
* fast/loader/form-submit-aborts-parsing.html: Added.
* fast/loader/location-change-aborts-parsing-expected.txt: Added.
* fast/loader/location-change-aborts-parsing.html: Added.
* fast/loader/resources/location-change-aborts-parsing-fail.html: Added.
* fast/loader/resources/location-change-aborts-parsing-pass.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 10 Dec 2010 23:49:59 +0000 (23:49 +0000)]
Make WKContextGetStatistics gather global statistics
https://bugs.webkit.org/show_bug.cgi?id=50850
Reviewed by John Sullivan.
WebKit2:
Change WKContextGetStatistics to work on all objects in the process, and
make it more robust by incrementing/decrementing the counts in the constructor
and destructor respectively.
Also, rename WKContextGetStatistics to WKContextGetGlobalStatistics to better match
what it's actually doing.
* UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
(-[WKView dealloc]):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::statistics):
* UIProcess/WebContext.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::~WebFrameProxy):
* UIProcess/WebPageNamespace.cpp:
* UIProcess/WebPageNamespace.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
* UIProcess/WebPageProxy.h:
WebKitTools:
Remove the code that gets the statistics and fills in the per context
statistics information for now.
* MiniBrowser/mac/BrowserStatisticsWindowController.m:
(-[BrowserStatisticsWindowController refreshStatistics:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 10 Dec 2010 23:43:44 +0000 (23:43 +0000)]
WebKit2: Context menu support on Windows
<https://bugs.webkit.org/show_bug.cgi?id=50514>
Reviewed by Darin Adler.
Implment showing of the context menu on Windows for WebKit2, and calling through to
WebPageProxy::contextMenuItemSelected.
* UIProcess/win/WebContextMenuProxyWin.cpp:
(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin): Initialize the member variables.
(WebKit::WebContextMenuProxyWin::populateMenu): Iterate over the vector of WebContextMenuItemData
that was passed in, adding the menu items and recursively calling back into this function to populate
any submenus that are needed. This function also sets up the map from action identifierss to WebContextMenuItemData,
to use to find the WebContextMenuItemData from a selected menu item.
(WebKit::WebContextMenuProxyWin::showContextMenu): Destroy any menu we have already created, populate the menu
to show, and show the context menu. Once TrackPopupMenuEx returns, it returns identifier of the selected menu item.
Look up that identifier in the map we created, and tell the WebPageProxy that a context menu item was selected.
(WebKit::WebContextMenuProxyWin::hideContextMenu): Destroy the HMENU if it is non-null, and clear the identifier map.
* UIProcess/win/WebContextMenuProxyWin.h:
(WebKit::WebContextMenuProxyWin::create): Call through to the constructor, and change the arguments that it takes.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::createContextMenuProxy): Call with the correct arguments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 10 Dec 2010 23:41:10 +0000 (23:41 +0000)]
Qt Build Fix. Unreviewed.
* WebKit2.pro:
Add the Messages.h and MessageReceivers.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 10 Dec 2010 23:41:04 +0000 (23:41 +0000)]
When we are creating a ContextMenuItem, only call setSubMenu if we have
a subMenu to set.
Reviewed by Ada Chan.
* platform/ContextMenuItem.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 10 Dec 2010 23:40:57 +0000 (23:40 +0000)]
2010-12-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Regression: fast/canvas/webgl/constants.html failing
https://bugs.webkit.org/show_bug.cgi?id=50851
* fast/canvas/webgl/constants.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 10 Dec 2010 23:33:48 +0000 (23:33 +0000)]
2010-12-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Attach more specific bug IDs to Philip canvas test suite failures (for
existing bugs only).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 10 Dec 2010 23:19:05 +0000 (23:19 +0000)]
2010-12-10 Kenneth Russell <kbr@google.com>
Unreviewed, another build fix. #include <wtf/UnusedParam.h> needed
for Release builds.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 10 Dec 2010 23:14:28 +0000 (23:14 +0000)]
2010-12-10 Kenneth Russell <kbr@google.com>
Unreviewed, build fix. Change #ifndef NDEBUG to #ifdef NDEBUG.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 10 Dec 2010 23:12:15 +0000 (23:12 +0000)]
WebKit2: Need a WebKit2 equivalent of the WebKit1 WebDatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=50606
Reviewed by Adam Roben and Sam Weinig.
Add a WebDatabaseManagerProxy owned by the WebContext.
Expose API (similar to the WebKit1 API) to get a list of origins for which there are
Databases, delete all the databases for a given origin, and delete all the databases.
Add WebDatabaseManager and WebDatabaseManagerProxy as messages receivers.
* DerivedSources.make:
* Platform/CoreIPC/MessageID.h:
Add the WebDatabaseManagerProxy as a UIProcess type (DatabaseManager).
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetDatabaseManager):
Expose API to get the DatabaseManager.
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKDatabaseManager.cpp: Added.
(WKDatabaseManagerGetTypeID):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
* UIProcess/API/C/WKDatabaseManager.h: Added.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
Create the WebDatabaseManagerProxy.
(WebKit::WebContext::processDidClose):
Invalidate the WebDatabaseManagerProxy.
(WebKit::WebContext::didReceiveMessage):
Forward messages to the WebDatabaseManagerProxy.
* UIProcess/WebContext.h:
(WebKit::WebContext::databaseManagerProxy):
* UIProcess/WebDatabaseManagerProxy.cpp: Added.
(WebKit::WebDatabaseManagerProxy::create):
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::invalidate):
Invalidate the map of callbacks for getDatabaseOrigins.
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
Store the callback and send the request for the origins which have databases to the
WebProcess.
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
Call the callback function with the SecurityOrigins created from the identifiers received.
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
If the origin exists, send the message on to the WebProcess to delete the databases
associated with that origin.
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
Send the message to the WebProcess to delete all the databases.
* UIProcess/WebDatabaseManagerProxy.h: Added.
(WebKit::WebDatabaseManagerProxy::type):
* UIProcess/WebDatabaseManagerProxy.messages.in: Added.
* UIProcess/WebPageProxy.cpp:
Move invalidateCallbackMap from here ...
* UIProcess/GenericCallback.h:
(WebKit::invalidateCallbackMap):
.. to here so that it can be used elsewhere (e.g. by WebDatabaseManagerProxy).
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
Forward on all messages destined for the WebDatabaseManagerProxy to the WebContext.
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::didReceiveMessage):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
Send an array of the identifiers for the SecurityOrigins for which there are databases to
the UIProcess.
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
If the SecurityOrigin with that identifier exists, tell the DatabaseTracker to delete the
databases for that origin.
(WebKit::WebDatabaseManager::deleteAllDatabases):
Tell the DatabaseTracker to delete the databases for that origin.
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
* WebProcess/WebCoreSupport/WebDatabaseManager.messages.in: Added.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
* WebKit2.pro:
Add WKDatabaseManager.cpp/.h and WebDatabaseManagerProxy.cpp/.h
* WebKit2.xcodeproj/project.pbxproj:
Ditto, also add WebDatabaseManagerProxy.messages.in and WebDatabaseManager.messages.in.
* win/WebKit2.vcproj:
Ditto.
* win/WebKit2Generated.make:
Make sure WKDatabaseManager.h is copied into WebKitBuild on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 10 Dec 2010 22:58:04 +0000 (22:58 +0000)]
Reviewed by Anders Carlsson.
Implement Download::start() and Download::startWithHandle() on Windows.
https://bugs.webkit.org/show_bug.cgi?id=50844
* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::start): Create a CFURLDownloadRef and schedule it.
(WebKit::Download::startWithHandle): Create a CFURLDownloadRef with the loading connection
retrieved from the ResourceHandle.
(WebKit::Download::platformInvalidate):
(WebKit::downloadFromClientInfo):
(WebKit::didStartCallback):
(WebKit::willSendRequestCallback):
(WebKit::didReceiveAuthenticationChallengeCallback):
(WebKit::didReceiveResponseCallback):
(WebKit::willResumeWithResponseCallback):
(WebKit::didReceiveDataCallback):
(WebKit::shouldDecodeDataOfMIMETypeCallback):
(WebKit::decideDestinationWithSuggestedObjectNameCallback):
(WebKit::didCreateDestinationCallback):
(WebKit::didFinishCallback):
(WebKit::didFailCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 10 Dec 2010 22:50:02 +0000 (22:50 +0000)]
2010-12-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Implement extension entry points and remove EXTENSIONS enum
https://bugs.webkit.org/show_bug.cgi?id=40316
Added support for ensuring that a particular OpenGL extension is
enabled.
* public/WebGraphicsContext3D.h:
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::ensureEnabled):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::initializeExtensions):
(WebCore::GraphicsContext3DInternal::supportsExtension):
(WebCore::GraphicsContext3DInternal::ensureExtensionEnabled):
* src/GraphicsContext3DInternal.h:
* src/WebGraphicsContext3DDefaultImpl.cpp:
(WebKit::WebGraphicsContext3DDefaultImpl::getRequestableExtensionsCHROMIUM):
(WebKit::WebGraphicsContext3DDefaultImpl::requestExtensionCHROMIUM):
* src/WebGraphicsContext3DDefaultImpl.h:
2010-12-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Implement extension entry points and remove EXTENSIONS enum
https://bugs.webkit.org/show_bug.cgi?id=40316
Implemented WebGLRenderingContext's getSupportedExtensions and
getExtensions entry points, and, to verify them, added support for
the first specified WebGL extension, OES_texture_float. This
extension is now advertised in the Chromium and WebKit ports when
the underlying hardware supports it.
The new OES_texture_float test in the WebGL conformance suite
verifies the allocation and population of floating point textures,
and their use as render targets. However, because this extension
is optional, it is not easily testable with a layout test; there
is only one set of expectations for a given test, and two would be
needed, one when the extension is available and one when it is not.
Tested with the oes-texture-float.html WebGL conformance test in
Chromium and WebKit on Mac OS X on hardware that supports the
extension. Also verified with a configuration that does not
advertise the extension that this same test passes.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::markChildren):
(WebCore::JSWebGLRenderingContext::getExtension):
(WebCore::JSWebGLRenderingContext::getSupportedExtensions):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
* html/canvas/OESTextureFloat.cpp: Added.
(WebCore::OESTextureFloat::OESTextureFloat):
(WebCore::OESTextureFloat::~OESTextureFloat):
(WebCore::OESTextureFloat::getName):
(WebCore::OESTextureFloat::create):
* html/canvas/OESTextureFloat.h: Added.
* html/canvas/OESTextureFloat.idl: Added.
* html/canvas/WebGLExtension.cpp: Added.
(WebCore::WebGLExtension::WebGLExtension):
(WebCore::WebGLExtension::~WebGLExtension):
* html/canvas/WebGLExtension.h: Added.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncData):
(WebCore::WebGLRenderingContext::getNumberOfExtensions):
(WebCore::WebGLRenderingContext::getExtensionNumber):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl:
* platform/graphics/Extensions3D.h:
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
(WebCore::GraphicsContext3D::extractTextureData):
(WebCore::doUnpackingAndPacking):
(WebCore::doPacking):
(WebCore::doFloatingPointPacking):
(WebCore::GraphicsContext3D::packPixels):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supports):
(WebCore::Extensions3DOpenGL::ensureEnabled):
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D):
* platform/graphics/qt/Extensions3DQt.cpp:
(WebCore::Extensions3DQt::ensureEnabled):
* platform/graphics/qt/Extensions3DQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 10 Dec 2010 22:30:41 +0000 (22:30 +0000)]
Try to fix Windows build.
* dom/Range.cpp:
(WebCore::Range::processContents): Put typedef of NodeVector inside the function
instead of at the top of the file, since the use is restricted to this function.
There's another NodeVector in ContainerNode.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 10 Dec 2010 22:30:29 +0000 (22:30 +0000)]
2010-12-10 Eric Seidel <eric@webkit.org>
Unreviewed.
commit-queue should report port/platform information when commenting on flaky test bugs
https://bugs.webkit.org/show_bug.cgi?id=50839
Renamed platform.py to platforminfo.py. This broke import platform in executive.py
which was only used by new run webkit tests (and clearly not unit tested).
* Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Fri, 10 Dec 2010 22:30:23 +0000 (22:30 +0000)]
Windows build fix. Unreviewed.
Adding a dummy synchronous message for platforms
that don't have any.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dummy):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 10 Dec 2010 22:21:00 +0000 (22:21 +0000)]
JavaScriptCore: Turn on USE(CROSS_PLATFORM_CONTEXT_MENUS) for Windows.
Reviewed by Adam Roben.
* wtf/Platform.h:
WebCore: Prep for WebKit2: Context menu support on Windows
https://bugs.webkit.org/show_bug.cgi?id=50514
Reviewed by Adam Roben.
Before this patch ContextMenu on Windows were backed by HMENUs, and ContextMenuItems
were backed by MENUITEMINFOs. This meant they couldn't be copied, and they needed to
be to work in WebKit2.
This patch adds a new USE flag - CROSS_PLATFORM_CONTEXT_MENUS that are for a cross-platform
representation of context menus. This patch also has Windows adopt them.
Cross-platform context menus change the API of context menus and the ContextMenuClient. There
is no more idea of a PlatformMenuDescription or a PlatformMenuItemDescription. Menus are backed
by a Vector of ContextMenuItems, and menu items are backed by the variables they need (enabled, checked
title, action, type, and submenu).
This patch also refactors the ContextMenuClient interface to use a variation on the getCustomMenuFromDefaultItems
function to allow for customization of the context menu.
For other ports to use CROSS_PLATFORM_CONTEXT_MENUS, all they need to do is write conversion functions from
a ContextMenu <-> native menu type, and ContextMenuItem <-> native menu item type. For Windows, this is done
in ContextMenuWin.cpp and ContextMenuItemWin.cpp.
No new tests, no change in behavior.
* WebCore.vcproj/WebCore.vcproj: Add new files (only needed on Windows for now).
* loader/EmptyClients.h:
(WebCore::EmptyContextMenuClient::customizeMenu): Define this function if CROSS_PLATFORM_CONTEXT_MENUS
is on.
* page/ContextMenuClient.h: Ditto.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu): Call customizeMenu instead of
getCustomMenuFromDefaultItems if CROSS_PLATFORM_CONTEXT_MENUS is on.
* platform/ContextMenu.cpp: Added.
(WebCore::ContextMenu::ContextMenu): Empty constructor.
(WebCore::ContextMenu::setItems): Sets the items in the menu.
(WebCore::ContextMenu::items): Returns the items in the menu.
(WebCore::ContextMenu::itemAtIndex):
(WebCore::itemWithActionInMenu): Returns the item with the correct action, recursively descending
into submenus.
(WebCore::ContextMenu::itemWithAction): Calls through to itemWithActionInMenu.
* platform/ContextMenu.h: Added a new set of functions and member variables that are defined for
CROSS_PLATFORM_CONTEXT_MENUS.
(WebCore::ContextMenu::appendItem): Appends an item to the menu.
* platform/ContextMenuItem.cpp: Added.
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::setSubMenu):
* platform/ContextMenuItem.h:
(WebCore::ContextMenuItem::type): Returns the type.
(WebCore::ContextMenuItem::setType): Sets the type.
(WebCore::ContextMenuItem::action): Returns the action.
(WebCore::ContextMenuItem::setAction): Sets the action.
(WebCore::ContextMenuItem::title): Returns the title.
(WebCore::ContextMenuItem::setTitle): Sets the title.
(WebCore::ContextMenuItem::checked): Returns whether or not the menu item is checked.
(WebCore::ContextMenuItem::setChecked): Sets whether ot not the menu item is checked.
(WebCore::ContextMenuItem::enabled): Returns whether or not the menu item is enabled.
(WebCore::ContextMenuItem::setEnabled): Sets whether or not the menu item is enabled.
(WebCore::ContextMenuItem::submenu): Returns the submenu.
* platform/PlatformMenuDescription.h: Remove the idea if a PlatformMenuDescription if
CROSS_PLATFORM_CONTEXT_MENUS is on.
* platform/win/ContextMenuItemWin.cpp:
(WebCore::ContextMenuItem::ContextMenuItem): Creates a ContextMenuItem from a MENUITEMINFO.
(WebCore::ContextMenuItem::nativeMenuItem): Creates and returns a MENUITEMINFO.
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::ContextMenu): Creates a ContextMenu from an HMENU.
(WebCore::ContextMenu::nativeMenu): Creates and returns an HMENU.
WebKit/win: Prep for WebKit2: Context menu support on Windows
https://bugs.webkit.org/show_bug.cgi?id=50514
Reviewed by Adam Roben.
Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
instead of getCustomMenuFromDefaultItems.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into
this function, with refactoring using nativeMenu instead of platformDescription.
(WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.
* WebCoreSupport/WebContextMenuClient.h:
* WebView.cpp:
(WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
(WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need
for the second.
WebKit2: Prep for WebKit2: Context menu support on Windows
https://bugs.webkit.org/show_bug.cgi?id=50514
Reviewed by Adam Roben.
Update WebKit2 to call the correct code when CROSS_PLATFORM_CONTEXT_MENUS is set.
* Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::WebContextMenuItemData): Add a branch based on whether or not
CROSS_PLATFORM_CONTEXT_MENUS is set.
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu): Define different functions based on
whether or not CROSS_PLATFORM_CONTEXT_MENUS. Both of these are stubs, so functionality
doesn't need to be shared.
* WebProcess/WebCoreSupport/WebContextMenuClient.h: Define different functions based on
whether or not CROSS_PLATFORM_CONTEXT_MENUS.
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show): Add a branch based on whether or not
CROSS_PLATFORM_CONTEXT_MENUS is set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 10 Dec 2010 22:09:37 +0000 (22:09 +0000)]
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Fix crash in ReplaceSelectionCommand::doApply when selection is modified
during execution.
https://bugs.webkit.org/show_bug.cgi?id=50840
Test: editing/execCommand/insertHTML-mutation-crash.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::copyStyleToChildren):
Replaced raw node pointer with RefPtr.
(WebCore::ReplaceSelectionCommand::doApply):
Replaced raw node pointer with RefPtr and added null check.
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Add testcase for ReplaceSelectionCommand crash.
https://bugs.webkit.org/show_bug.cgi?id=50840
* editing/execCommand/insertHTML-mutation-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 10 Dec 2010 22:02:42 +0000 (22:02 +0000)]
Unreviewed Chromium test expectations update.
Fix broken expectation from r73797.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 10 Dec 2010 21:42:36 +0000 (21:42 +0000)]
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Fix crash in Range::processContents when modified during mutation event.
https://bugs.webkit.org/show_bug.cgi?id=50710
Test: fast/dom/Range/range-extractContents.html
* dom/Range.cpp:
(WebCore::Range::processContents):
Replace raw pointers with RefPtrs and add checks.
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Add testcase for range.extractContents crash.
https://bugs.webkit.org/show_bug.cgi?id=50710
* fast/dom/Range/range-extractContents-expected.txt: Added.
* fast/dom/Range/range-extractContents.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 10 Dec 2010 21:42:04 +0000 (21:42 +0000)]
2010-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Tony Chang.
commit-queue should report port/platform information when commenting on flaky test bugs
https://bugs.webkit.org/show_bug.cgi?id=50839
This was a suggestion from Tony Chang this morning.
I added a platform.py class so I could easily mock the platform call,
but that may not be the final solution for this mocking.
We'll try it and see.
* Scripts/webkitpy/common/system/platform.py: Added.
* Scripts/webkitpy/tool/bot/flakytestreporter.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 10 Dec 2010 21:36:08 +0000 (21:36 +0000)]
Unreviewed Chromium test expectations update.
* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/fast/encoding: Added.
* platform/chromium/fast/encoding/meta-in-script-expected.txt: Added
V8-specific expectation.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Fri, 10 Dec 2010 21:24:09 +0000 (21:24 +0000)]
WebCore: Implement IME support for Mac.
<rdar://problem/7660589> WebKit2: Implement IME support for Mac.
https://bugs.webkit.org/show_bug.cgi?id=50788
Reviewed by Alexey Proskuryakov.
* dom/KeyboardEvent.h:
(WebCore::KeypressCommand::KeypressCommand): Removed ASSERT in constructor,
since it is now used for more than one command.
WebKit2: Implement IME support for Mac.
<rdar://problem/7660589> WebKit2: Implement IME support for Mac.
https://bugs.webkit.org/show_bug.cgi?id=50788
Reviewed by Alexey Proskuryakov.
This patch addes support for input methods in WebKit2.
In order to support IME, it was necessary to add synchronous calls from the UIProcess
to the WebProcess. These calls all have a timeout of 1 second.
The current implementation still uses the NSTextInput protocol, but the plan is to move
to the NSTextInputClient protocol. This has not been done yet for ease of comparison with
WebKit. attributedSubstringFromRange is the only method that has not been implemented, because
I have not yet decided what is the best way to send an NSAttributedString across the process
boundary.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Added template for member function.
with four reply arguments.
* Scripts/webkit2/messages.py: Added CompositionUnderline and relevant header.
* Shared/WebCoreArgumentCoders.h:
(CoreIPC::): Added encoder/decoder for CompositionUnderline.
* UIProcess/API/mac/PageClientImpl.h: Added parameters to interceptKeyEvent and selectionChanged.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::selectionChanged): Added parameters.
(WebKit::PageClientImpl::interceptKeyEvent): Added parameters.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]): Added initialization of new private members.
(-[WKView insertText:]):
(-[WKView _selectionChanged:isEditable:isPassword:hasMarkedText:range:]): Added parameters.
(-[WKView _interceptKeyEvent:hasComposition:start:end:lines:WebCore::]): Added parameters.
(-[WKView keyDown:]): Modified to reset state on each keyDown.
(-[WKView selectedRange]): Added.
(-[WKView hasMarkedText]): Added.
(-[WKView unmarkText]): Added.
(-[WKView validAttributesForMarkedText]): Added.
(extractUnderlines): Added.
(-[WKView setMarkedText:selectedRange:]): Added.
(-[WKView markedRange]): Added.
(-[WKView attributedSubstringFromRange:]): Added.
(-[WKView characterIndexForPoint:]): Added.
(-[WKView firstRectForCharacterRange:]): Added.
(-[WKView conversationIdentifier]): Added.
* UIProcess/API/mac/WKViewInternal.h: Added parameters to _interceptKeyEvent and _selectionChanged.
* UIProcess/PageClient.h: Added parameters to interpretKeyEvent and selectionChanged.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getMarkedRange): Added.
(WebKit::WebPageProxy::characterIndexForPoint): Added.
(WebKit::WebPageProxy::firstRectForCharacterRange): Added.
(WebKit::WebPageProxy::interpretKeyEvent): Additional parameters.
(WebKit::WebPageProxy::didSelectionChange): Additional parameters for Mac platform.
* UIProcess/WebPageProxy.h: Added new methods and parameters to didSelectionChange
and interpretKeyEvent.
* UIProcess/WebPageProxy.messages.in: Added parameters to interpretKeyEvent and selectionChanged messages.
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::sendSync): Added support for synchronous messages.
The default timeout is 1 second.
* WebProcess/WebCoreSupport/WebEditorClient.cpp: respondToChangedSelection is now
only for non Mac platform.
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::respondToChangedSelection): Added implementation for Mac platform.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveSyncMessage): Added.
* WebProcess/WebPage/WebPage.h: Added new methods and support for synchronous messages.
* WebProcess/WebPage/WebPage.messages.in: Added new messages.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::interceptEditingKeyboardEvent): Added parameters.
(WebKit::WebPage::convertRangeToPlatformRange): Added.
(WebKit::WebPage::getMarkedRange): Added.
(WebKit::characterRangeAtPoint): Added.
(WebKit::WebPage::characterIndexForPoint): Added.
(WebKit::convertToRange): Added.
(WebKit::WebPage::firstRectForCharacterRange): Added.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage): Added.
* WebProcess/WebProcess.h: Added didReceiveSyncMessage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Fri, 10 Dec 2010 21:05:42 +0000 (21:05 +0000)]
2010-12-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
Add CACFContextGetLastCommitTime to WebKitSystemInterface for Windows.
Also got rid of WebKitSystemInterface_debug.lib as recommended by
Adam Roben. No OpenSource builds use it since r72327.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Fri, 10 Dec 2010 21:01:31 +0000 (21:01 +0000)]
2010-12-10 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
Reviewed by Joseph Pecoraro.
Bug 43455 - [Qt]: Implement Application Cache Quotas
https://bugs.webkit.org/show_bug.cgi?id=43455
Added new signal to report ApplicationCache Database
quota.
* Api/qwebpage.cpp:
* Api/qwebpage.h:
Added new functions to accomodate new appcache layout
test origin-quota.html.
* Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::setApplicationCacheQuota):
* Api/qwebsecurityorigin.h:
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearAllApplicationCaches):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-12-10 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
Reviewed by Joseph Pecoraro.
[Qt]: Implement Application Cache Quotas
https://bugs.webkit.org/show_bug.cgi?id=43455
* platform/qt/Skipped: Unskip now passing test origin-quota.html
2010-12-10 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
Reviewed by Joseph Pecoraro.
Bug 43455 - [Qt]: Implement Application Cache Quotas
https://bugs.webkit.org/show_bug.cgi?id=43455
Introduce functions to allow new appcache layout test origin-quota.html
to work correctly under Qt.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::dumpApplicationCacheQuota):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
Introduce functions to allow new appcache layout test origin-quota.html
to be successful under qt. Changes required because LayoutTestControllerQt
does not inherit from LayoutController.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::setApplicationCacheOriginQuota):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
(LayoutTestController::dumpApplicationCacheDelegateCallbacks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 10 Dec 2010 20:29:17 +0000 (20:29 +0000)]
2010-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move buildbot.py into its own module so we can split it out into one-file-per-class
https://bugs.webkit.org/show_bug.cgi?id=50806
We're adding more buildbot logic these days, so it makes sense
to give buildbot its own module.
* Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
* Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
* Scripts/webkitpy/common/net/failuremap.py:
* Scripts/webkitpy/common/net/regressionwindow.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 10 Dec 2010 20:26:08 +0000 (20:26 +0000)]
Windows build fix. Unreviewed.
* WebCore.vcproj/WebCore.vcproj:
Remove duplicate </File> tag.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 10 Dec 2010 20:23:21 +0000 (20:23 +0000)]
2010-12-10 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Use FileSystem::remove when cleaning up http lock files
https://bugs.webkit.org/show_bug.cgi?id=50830
* Scripts/webkitpy/layout_tests/port/http_lock.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 10 Dec 2010 19:50:38 +0000 (19:50 +0000)]
2010-12-09 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Barth.
TextResourceDecoder::checkForHeadCharset can look way past the limit.
https://bugs.webkit.org/show_bug.cgi?id=47397
Replaced charset detection algorithm with real parser.
Added tests for parser bugs mentioned in the thread for this bug report.
Converted hixie's encoding parsing tests to a layout test.
Tests: fast/encoding/bracket-in-script.html
fast/encoding/bracket-in-tag.html
fast/encoding/escaped-bracket.html
fast/encoding/meta-in-body.html
fast/encoding/meta-in-script.html
fast/encoding/meta-in-title.html
fast/encoding/mismatched-end-tag.html
fast/encoding/namespace-meta.html
fast/encoding/not-http-equiv-content.html
fast/encoding/parser-tests.html
fast/encoding/quotes-in-title.html
fast/encoding/tag-name-digit.html
http/tests/misc/charset-sniffer-end-sniffing.html
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLMetaCharsetParser.cpp: Added.
(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):
(WebCore::HTMLMetaCharsetParser::~HTMLMetaCharsetParser):
(WebCore::HTMLMetaCharsetParser::extractCharset):
(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):
* html/parser/HTMLMetaCharsetParser.h: Added.
(WebCore::HTMLMetaCharsetParser::create):
(WebCore::HTMLMetaCharsetParser::encoding):
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset):
(WebCore::TextResourceDecoder::checkForMetaCharset):
* loader/TextResourceDecoder.h:
2010-12-09 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Barth.
TextResourceDecoder::checkForHeadCharset can look way past the limit.
https://bugs.webkit.org/show_bug.cgi?id=47397
Replaced charset detection algorithm with real parser.
Added tests for parser bugs mentioned in the thread for this bug report.
Converted hixie's encoding parsing tests to a layout test.
Added http-equiv attribute to meta tag in 2 existing tests.
* fast/encoding/bracket-in-script-expected.txt: Added.
* fast/encoding/bracket-in-script.html: Added.
* fast/encoding/bracket-in-tag-expected.txt: Added.
* fast/encoding/bracket-in-tag.html: Added.
* fast/encoding/escaped-bracket-expected.txt: Added.
* fast/encoding/escaped-bracket.html: Added.
* fast/encoding/meta-in-body-expected.txt: Added.
* fast/encoding/meta-in-body.html: Added.
* fast/encoding/meta-in-script-expected.txt: Added.
* fast/encoding/meta-in-script.html: Added.
* fast/encoding/meta-in-title-expected.txt: Added.
* fast/encoding/meta-in-title.html: Added.
* fast/encoding/mismatched-end-tag-expected.txt: Added.
* fast/encoding/mismatched-end-tag.html: Added.
* fast/encoding/namespace-meta-expected.txt: Added.
* fast/encoding/namespace-meta.html: Added.
* fast/encoding/namespace-tolerance.html:
* fast/encoding/not-http-equiv-content-expected.txt: Added.
* fast/encoding/not-http-equiv-content.html: Added.
* fast/encoding/parser-tests-expected.txt: Added.
* fast/encoding/parser-tests.html: Added.
* fast/encoding/quotes-in-title-expected.txt: Added.
* fast/encoding/quotes-in-title.html: Added.
* fast/encoding/resources/001.html: Added.
* fast/encoding/resources/002.html: Added.
* fast/encoding/resources/003.html: Added.
* fast/encoding/resources/004.html: Added.
* fast/encoding/resources/005.html: Added.
* fast/encoding/resources/006.html: Added.
* fast/encoding/resources/007.html: Added.
* fast/encoding/resources/008.html: Added.
* fast/encoding/resources/009.html: Added.
* fast/encoding/resources/010.html: Added.
* fast/encoding/resources/011.html: Added.
* fast/encoding/resources/012.html: Added.
* fast/encoding/resources/013.html: Added.
* fast/encoding/resources/014.html: Added.
* fast/encoding/resources/015.html: Added.
* fast/encoding/resources/016.html: Added.
* fast/encoding/resources/017.html: Added.
* fast/encoding/resources/018.html: Added.
* fast/encoding/resources/019.html: Added.
* fast/encoding/resources/020.html: Added.
* fast/encoding/resources/021.html: Added.
* fast/encoding/resources/022.html: Added.
* fast/encoding/resources/023.html: Added.
* fast/encoding/resources/024.html: Added.
* fast/encoding/resources/025.html: Added.
* fast/encoding/resources/026.html: Added.
* fast/encoding/resources/027.html: Added.
* fast/encoding/resources/028.html: Added.
* fast/encoding/resources/029.html: Added.
* fast/encoding/resources/030.html: Added.
* fast/encoding/resources/031.html: Added.
* fast/encoding/resources/032.html: Added.
* fast/encoding/resources/033.html: Added.
* fast/encoding/resources/034.html: Added.
* fast/encoding/resources/035.html: Added.
* fast/encoding/resources/036.html: Added.
* fast/encoding/resources/037.html: Added.
* fast/encoding/resources/038.html: Added.
* fast/encoding/resources/039.html: Added.
* fast/encoding/resources/040.html: Added.
* fast/encoding/resources/041.html: Added.
* fast/encoding/resources/042.html: Added.
* fast/encoding/resources/043.html: Added.
* fast/encoding/resources/044.html: Added.
* fast/encoding/resources/045.html: Added.
* fast/encoding/resources/046.html: Added.
* fast/encoding/resources/047.html: Added.
* fast/encoding/resources/048.html: Added.
* fast/encoding/resources/049.html: Added.
* fast/encoding/resources/050.html: Added.
* fast/encoding/resources/051.html: Added.
* fast/encoding/resources/052.html: Added.
* fast/encoding/resources/053.html: Added.
* fast/encoding/resources/054.html: Added.
* fast/encoding/resources/055.html: Added.
* fast/encoding/resources/056.html: Added.
* fast/encoding/resources/057.html: Added.
* fast/encoding/resources/058.html: Added.
* fast/encoding/resources/059.html: Added.
* fast/encoding/resources/060.html: Added.
* fast/encoding/resources/061.html: Added.
* fast/encoding/resources/062.html: Added.
* fast/encoding/resources/063.html: Added.
* fast/encoding/resources/064.html: Added.
* fast/encoding/resources/065.html: Added.
* fast/encoding/resources/066.html: Added.
* fast/encoding/resources/067.html: Added.
* fast/encoding/resources/068.html: Added.
* fast/encoding/resources/069.html: Added.
* fast/encoding/resources/070.html: Added.
* fast/encoding/resources/071.html: Added.
* fast/encoding/resources/072.html: Added.
* fast/encoding/resources/073.html: Added.
* fast/encoding/resources/074.html: Added.
* fast/encoding/resources/075.html: Added.
* fast/encoding/resources/076.html: Added.
* fast/encoding/resources/077.html: Added.
* fast/encoding/resources/078.html: Added.
* fast/encoding/resources/079.html: Added.
* fast/encoding/resources/080.html: Added.
* fast/encoding/resources/081.html: Added.
* fast/encoding/resources/082.html: Added.
* fast/encoding/resources/083.html: Added.
* fast/encoding/resources/084.html: Added.
* fast/encoding/resources/085.html: Added.
* fast/encoding/resources/086.html: Added.
* fast/encoding/resources/087.html: Added.
* fast/encoding/resources/088.html: Added.
* fast/encoding/resources/089.html: Added.
* fast/encoding/resources/090.html: Added.
* fast/encoding/resources/091.html: Added.
* fast/encoding/resources/092.html: Added.
* fast/encoding/resources/093.html: Added.
* fast/encoding/resources/094.html: Added.
* fast/encoding/resources/095.html: Added.
* fast/encoding/resources/096.html: Added.
* fast/encoding/resources/097.html: Added.
* fast/encoding/resources/098.html: Added.
* fast/encoding/resources/099.html: Added.
* fast/encoding/resources/100.html: Added.
* fast/encoding/resources/101.html: Added.
* fast/encoding/resources/102.html: Added.
* fast/encoding/resources/103.html: Added.
* fast/encoding/resources/104.html: Added.
* fast/encoding/resources/105.html: Added.
* fast/encoding/resources/106.html: Added.
* fast/encoding/resources/107.html: Added.
* fast/encoding/resources/108.html: Added.
* fast/encoding/resources/109.html: Added.
* fast/encoding/resources/110.html: Added.
* fast/encoding/resources/111.html: Added.
* fast/encoding/resources/112.html: Added.
* fast/encoding/resources/113.html: Added.
* fast/encoding/resources/114.html: Added.
* fast/encoding/resources/115.html: Added.
* fast/encoding/resources/116.html: Added.
* fast/encoding/resources/117.html: Added.
* fast/encoding/resources/118.html: Added.
* fast/encoding/resources/119.html: Added.
* fast/encoding/resources/120.html: Added.
* fast/encoding/resources/121.html: Added.
* fast/encoding/resources/122.html: Added.
* fast/encoding/resources/123.html: Added.
* fast/encoding/tag-name-digit-expected.txt: Added.
* fast/encoding/tag-name-digit.html: Added.
* fast/text/international/bidi-innertext.html:
* http/tests/misc/charset-sniffer-end-sniffing-expected.txt: Added.
* http/tests/misc/charset-sniffer-end-sniffing.html: Added.
* http/tests/misc/resources/charset-sniffer-end-sniffing.php: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 10 Dec 2010 19:41:02 +0000 (19:41 +0000)]
2010-12-10 Joone Hur <joone@kldp.org>
Reviewed by Martin Robinson.
[GTK] DRT needs layoutTestController.setCacheModel
https://bugs.webkit.org/show_bug.cgi?id=50705
webkit_set_cache_mode() is called to set the cache model.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setCacheModel): Set the cache model.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 10 Dec 2010 19:40:11 +0000 (19:40 +0000)]
2010-12-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Group Philip canvas test suite expectations better (by platform).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Fri, 10 Dec 2010 19:26:15 +0000 (19:26 +0000)]
2010-12-10 Nate Chapin <japhet@chromium.org>
Reviewed by Antti Koivisto.
Merge Loader and Request. Currently, Loader is a singleton attached
to MemoryCache. Our goal is to remove knowledge of the loading process
from MemoryCache, so we should attach Loader to CachedResourceLoader instead.
Once Loader is moved off of MemoryCache, there's no reason it needs to be a singleton,
which removes the main reason for Request existing as a separate class (to store per-request
state that Loader couldn't).
Loader will be given a more descriptive name in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=49837
Refactor only, no new tests.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* loader/FrameLoader.cpp:
* loader/Request.cpp:
* loader/Request.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone): Was setLoadInProgress(false),
plus other CachedResourceLoader cleanup that had been handled in Loader.
(WebCore::CachedResourceLoader::cancelRequests): Moved from Loader.
(WebCore::CachedResourceLoader::requestCount):
* loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::loadFinishing): Was setLoadInProgress(true)
* loader/cache/MemoryCache.h:
* loader/loader.cpp:
(WebCore::Loader::Loader):
(WebCore::Loader::~Loader):
(WebCore::Loader::load):
(WebCore::Loader::willSendRequest):
(WebCore::Loader::didFinishLoading):
(WebCore::Loader::didFail):
(WebCore::Loader::didReceiveResponse):
(WebCore::Loader::didReceiveData):
(WebCore::Loader::didReceiveCachedMetadata):
* loader/loader.h:
(WebCore::Loader::cachedResourceLoader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 10 Dec 2010 19:24:30 +0000 (19:24 +0000)]
2010-12-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] remove --use-drt and add --use-test-shell
https://bugs.webkit.org/show_bug.cgi?id=50701
Remove drt_expectations.txt since we don't need it anymore.
* platform/chromium/drt_expectations.txt: Removed.
2010-12-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] remove --use-drt and add --use-test-shell
https://bugs.webkit.org/show_bug.cgi?id=50701
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/style/checkers/test_expectations.py:
* Scripts/webkitpy/tool/commands/queries.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Fri, 10 Dec 2010 19:14:25 +0000 (19:14 +0000)]
2010-12-10 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r73743.
http://trac.webkit.org/changeset/73743
We need gtk+ specific results
* http/tests/misc/dns-prefetch-control-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 10 Dec 2010 19:10:29 +0000 (19:10 +0000)]
2010-12-10 Martin Robinson <mrobinson@igalia.com>
Unreviewed, rolling out r73703.
http://trac.webkit.org/changeset/73703
https://bugs.webkit.org/show_bug.cgi?id=49658
This patch is causing crashes on the GTK+ bots.
* wtf/PlatformRefPtr.h:
2010-12-10 Martin Robinson <mrobinson@igalia.com>
Unreviewed, rolling out r73703.
http://trac.webkit.org/changeset/73703
https://bugs.webkit.org/show_bug.cgi?id=49658
This patch is causing crashes on the GTK+ bots.
* platform/ContextMenuItem.h:
(WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::createNativeMenuItem):
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::setEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 10 Dec 2010 18:54:10 +0000 (18:54 +0000)]
2010-12-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
[Chromium] Implement mocks for client-based geolocation
https://bugs.webkit.org/show_bug.cgi?id=46895
* WebKit.gyp:
* public/WebGeolocationClientMock.h: Added.
(WebKit::WebGeolocationClientMock::~WebGeolocationClientMock):
(WebKit::WebGeolocationClientMock::WebGeolocationClientMock):
* src/WebGeolocationClientMock.cpp: Added.
(WebKit::WebGeolocationClientMock::create):
(WebKit::WebGeolocationClientMock::initialize):
(WebKit::WebGeolocationClientMock::reset):
(WebKit::WebGeolocationClientMock::setMockGeolocationPosition):
(WebKit::WebGeolocationClientMock::setMockGeolocationError):
(WebKit::WebGeolocationClientMock::setMockGeolocationPermission):
(WebKit::WebGeolocationClientMock::resetMock):
(WebKit::WebGeolocationClientMock::startUpdating):
(WebKit::WebGeolocationClientMock::stopUpdating):
(WebKit::WebGeolocationClientMock::setEnableHighAccuracy):
(WebKit::WebGeolocationClientMock::geolocationDestroyed):
(WebKit::WebGeolocationClientMock::setController):
(WebKit::WebGeolocationClientMock::lastPosition):
(WebKit::WebGeolocationClientMock::requestPermission):
(WebKit::WebGeolocationClientMock::cancelPermissionRequest):
* src/WebGeolocationServiceMock.cpp:
2010-12-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
[Chromium] Implement mocks for client-based geolocation
https://bugs.webkit.org/show_bug.cgi?id=46895
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationPosition):
(LayoutTestController::setMockGeolocationError):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::geolocationClient):
(WebViewHost::geolocationClientMock):
(WebViewHost::reset):
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc