WebKit-https.git
9 years ago2011-05-18 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 19 May 2011 00:16:40 +0000 (00:16 +0000)]
2011-05-18  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Change RenderTextControl::hitInnerTextElement to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61003

        Covered by existing tests.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::hitInnerTextElement):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWK2: VoiceOver cannot move focus into a web area programmatically
cfleizach@apple.com [Thu, 19 May 2011 00:10:38 +0000 (00:10 +0000)]
WK2: VoiceOver cannot move focus into a web area programmatically
https://bugs.webkit.org/show_bug.cgi?id=60661

Reviewed by Maciej Stachowiak.

Source/WebCore:

Accessibility code relies on the ability to bring focus to the containing widget view.
In WK2, that message needs to be propagated to the UI process.

* page/ChromeClient.h:
(WebCore::ChromeClient::makeFirstResponder):
* page/mac/ChromeMac.mm:
(WebCore::Chrome::focusNSView):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFocus):

Source/WebKit2:

Add a makeFirstResponder method that will bring focus to the widget view within the UI
process.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::makeFirstResponder):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::makeFirstResponder):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::makeFirstResponder):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Alok Priyadarshi <alokp@chromium.org> and Adrienne Walker <enne@google...
enne@google.com [Wed, 18 May 2011 23:53:12 +0000 (23:53 +0000)]
2011-05-18  Alok Priyadarshi  <alokp@chromium.org> and Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Split canvas from LayerTilerChromium
        https://bugs.webkit.org/show_bug.cgi?id=60719

        LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
        Also abstracted LayerTextureSubImage to upload texture pixels.

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::create):
        (WebCore::ContentLayerChromium::ContentLayerChromium):
        (WebCore::ContentLayerChromium::~ContentLayerChromium):
        (WebCore::ContentLayerChromium::paintContentsIfDirty):
        (WebCore::ContentLayerChromium::cleanupResources):
        (WebCore::ContentLayerChromium::setLayerRenderer):
        (WebCore::ContentLayerChromium::createTextureUpdater):
        (WebCore::ContentLayerChromium::drawsContent):
        (WebCore::ContentLayerChromium::createTilerIfNeeded):
        (WebCore::ContentLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
        (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater):
        (WebCore::ImageLayerTextureUpdater::orientation):
        (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
        (WebCore::ImageLayerTextureUpdater::updateTextureRect):
        (WebCore::ImageLayerTextureUpdater::imageRect):
        (WebCore::ImageLayerChromium::paintContentsIfDirty):
        (WebCore::ImageLayerChromium::updateCompositorResources):
        (WebCore::ImageLayerChromium::createTextureUpdater):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerPainterChromium.h: Added.
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTextureSubImage.cpp: Added.
        (WebCore::LayerTextureSubImage::LayerTextureSubImage):
        (WebCore::LayerTextureSubImage::~LayerTextureSubImage):
        (WebCore::LayerTextureSubImage::setSubImageSize):
        (WebCore::LayerTextureSubImage::upload):
        (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
        (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
        * platform/graphics/chromium/LayerTextureSubImage.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
        * platform/graphics/chromium/LayerTextureUpdater.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
        (WebCore::LayerTextureUpdater::LayerTextureUpdater):
        (WebCore::LayerTextureUpdater::~LayerTextureUpdater):
        (WebCore::LayerTextureUpdater::context):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added.
        (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
        (WebCore::LayerTextureUpdaterCanvas::paintContents):
        (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
        (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
        (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.
        (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas):
        (WebCore::LayerTextureUpdaterCanvas::contentRect):
        (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap):
        (WebCore::LayerTextureUpdaterBitmap::orientation):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::setTileSize):
        (WebCore::LayerTilerChromium::prepareToUpdate):
        (WebCore::LayerTilerChromium::updateRect):
        (WebCore::LayerTilerChromium::draw):
        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::Tile::Tile):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
2011-05-18  Alok Priyadarshi  <alokp@chromium.org> and Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        Split canvas from LayerTilerChromium
        https://bugs.webkit.org/show_bug.cgi?id=60719

        * src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Wed, 18 May 2011 23:43:23 +0000 (23:43 +0000)]
2011-05-18  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB put() should fail adding to object store that uses
        out-of-line keys and has no key generator and the key parameter
        was not provided
        https://bugs.webkit.org/show_bug.cgi?id=58609

        One new test and one fix to an existing test that relied on the old
        broken behavior.

        * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Added.
        * storage/indexeddb/mozilla/key-requirements-put-no-key.html: Added.
        * storage/indexeddb/objectstore-autoincrement-expected.txt:
        * storage/indexeddb/objectstore-autoincrement.html:
2011-05-18  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB put() should fail adding to object store that uses
        out-of-line keys and has no key generator and the key parameter
        was not provided
        https://bugs.webkit.org/show_bug.cgi?id=58609

        Out-of-line keys means that objectStore->m_keyPath is null in ::put(),
        no key generator means that objectStore->autoIncrement() is false, and
        key parameter was not provided means that prpKey will be a null pointer.
        The combination of these 3 should throw a DATA_ERR.

        Test: storage/indexeddb/mozilla/key-requirements-put-no-key.html

        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Wed, 18 May 2011 23:34:52 +0000 (23:34 +0000)]
2011-05-18  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Oliver Hunt.

        [Qt] fast/encoding/yentest.html and yentest2.html fail
        https://bugs.webkit.org/show_bug.cgi?id=39852

        * platform/qt/Skipped: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 23:28:54 +0000 (23:28 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium test expectations update for details element (Windows).
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 18 May 2011 23:14:25 +0000 (23:14 +0000)]
2011-05-18  Chris Rogers  <crogers@google.com>

        Reviewed by James Robinson.

        EqualPowerPanner is not using the correct azimuth range for stereo panning
        https://bugs.webkit.org/show_bug.cgi?id=61085

        No new tests since audio API is not yet implemented.

        * platform/audio/EqualPowerPanner.cpp:
        (WebCore::EqualPowerPanner::pan):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 23:14:24 +0000 (23:14 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update for SVG tests.

        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/filters: Added.
        * platform/chromium-linux-x86/svg/filters/feBlend-invalid-mode-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
        * platform/chromium-linux/svg/filters/feBlend-invalid-mode-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
        * platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/chromium-win-vista/svg/dynamic-updates: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/filters: Added.
        * platform/chromium-win-vista/svg/filters/feBlend-invalid-mode-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Wed, 18 May 2011 22:17:13 +0000 (22:17 +0000)]
2011-05-18  Brett Wilson  <brettw@chromium.org>

        Reviewed by Adam Barth.

        Don't create empty file objects if no download file path is specified.
        https://bugs.webkit.org/show_bug.cgi?id=60798

        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::setDownloadFilePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Wed, 18 May 2011 22:10:55 +0000 (22:10 +0000)]
2011-05-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Unskip the fast/events/onsearch-enter.html test.

        * platform/qt/Skipped:
2011-05-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Fill the missing key text for the EnterKey event.

        Tests: fast/events/onsearch-enter.html

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::keyTextForKeyEvent):
2011-05-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Remove the implementation of the handleInputMethodKeydown, which introduces
        a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods): Add more tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
beidson@apple.com [Wed, 18 May 2011 22:04:57 +0000 (22:04 +0000)]
<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

* Platform/unix/EnvironmentUtilities.cpp: Remove an unnecessary #include, as reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Wed, 18 May 2011 21:58:49 +0000 (21:58 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the the context menu to reflect the system search provider on Mac.
timothy@apple.com [Wed, 18 May 2011 21:47:33 +0000 (21:47 +0000)]
Update the the context menu to reflect the system search provider on Mac.

<rdar://problem/9198419>

Reviewed by Sam Weinig.

Source/WebCore:

* English.lproj/Localizable.strings: Updated.
* Source/WebCore/WebCore.exp.in: Added _wkCopyDefaultSearchProviderDisplayName.
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::contextMenuItemTagSearchWeb): Use wkCopyDefaultSearchProviderDisplayName to
create the string.
* platform/mac/WebCoreSystemInterface.h: Added wkCopyDefaultSearchProviderDisplayName.
* platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
create the web search context menu title.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle): Add a FIXME about using NSPerformService on Mac.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
beidson@apple.com [Wed, 18 May 2011 21:46:33 +0000 (21:46 +0000)]
<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

If the WebProcess or PluginProcess forks, it shouldn't pass WebKit2 shims along to the new process
in the DYLD_INSERT_LIBRARIES environment variable.

Add Environment Utilities helper to strip unwanted values from an environment variable:
* Platform/unix/EnvironmentUtilities.cpp: Added.
(WebKit::EnvironmentUtilities::stripValuesEndingWithString):
* Platform/unix/EnvironmentUtilities.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

Strip PluginProcessShim.dylib from DYLD_INSERT_LIBRARIES:
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):

Strip WebProcessShim.dylib from DYLD_INSERT_LIBRARIES:
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

Unprotect SnowLeopard now that it will behave and not spawn processes trying to use WebKit2 shims:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 18 May 2011 21:40:16 +0000 (21:40 +0000)]
2011-05-18  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        Marker test from ietestcenter fails
        https://bugs.webkit.org/show_bug.cgi?id=60721

        Change <marker> renderer creation behaviour to always create the renderer. This fixes
        the problem that no marker is rendered when display=none is set on the <marker>. The
        specification states that display=none should have no influence on <marker> usage:
        "The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
        elements are available for referencing even when the ‘display’ property on the ‘marker’
        element or any of its ancestors is set to none."

        Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
               svg/custom/painting-marker-07-f-inherit.svg

        * svg/SVGMarkerElement.h:
        (WebCore::SVGMarkerElement::rendererIsNeeded):
2011-05-18  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        Marker test from ietestcenter fails
        https://bugs.webkit.org/show_bug.cgi?id=60721

        Test cases where display=none is set on <marker>, i.e. directly or through ancestor.

        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/mac/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
        * platform/mac/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
        * svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg: Added.
        * svg/custom/painting-marker-07-f-inherit.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Alexis Menard <alexis.menard@openbossa.org>, Simon Hausmann <simon...
commit-queue@webkit.org [Wed, 18 May 2011 21:26:03 +0000 (21:26 +0000)]
2011-05-18  Alexis Menard  <alexis.menard@openbossa.org>, Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Eric Carlson.

        MediaElements fails to load the data in some cases.
        https://bugs.webkit.org/show_bug.cgi?id=60760

        This test creates an hidden video element and make sure the loading works.

        * http/tests/media/media-can-load-when-hidden-expected.txt: Added.
        * http/tests/media/media-can-load-when-hidden.html: Added.
2011-05-18  Alexis Menard  <alexis.menard@openbossa.org>, Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Eric Carlson.

        MediaElements fails to load the data in some cases.
        https://bugs.webkit.org/show_bug.cgi?id=60760

        WebKitWebSourceGStreamer is the interface between WebKit and GStreamer
        that uses the ResourceHandle API to request data and pass it down. For
        our builds it is absolutely essential that we have a NetworkingContext
        available there, in order to get access to the QNetworkAccessManager.
        No access means we basically cannot load the video. The WebSource gains
        access to the NetworkingContext through a WebCore::Frame pointer it has.

        MediaPlayerPrivateGStreamer is responsible for propagating a pointer of
        the WebCore::Frame to the WebKitWebSource in
        mediaPlayerPrivateSourceChangedCallback. In there we used the MediaPlayer's
        frameView() accessor to access the frame. However the frameView() member
        is only set through the render tree's RenderVideo, which is rather unreliable
        given that some sites create "fake" video tags initially that only become
        visible later (or never).

        A more reliable way is to simply use the document of the MediaPlayerClient,
        which is provided at constructor time.

        Test: http/tests/media/media-can-load-when-hidden.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 21:23:28 +0000 (21:23 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Fixing previous Chromium tests expectations update for details element.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 18 May 2011 21:16:15 +0000 (21:16 +0000)]
2011-05-18  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Check HUD texture reserve status before using texture
        https://bugs.webkit.org/show_bug.cgi?id=61082

        This only changes behavior behind a flag, so shouldn't impact any tests.

        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 18 May 2011 21:04:20 +0000 (21:04 +0000)]
2011-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Delete WTFURL
        https://bugs.webkit.org/show_bug.cgi?id=61084

        It's been a year and we've failed to complete this project.  It's time
        to throw in the towel.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/url: Removed.
        * wtf/url/api: Removed.
        * wtf/url/api/ParsedURL.cpp: Removed.
        * wtf/url/api/ParsedURL.h: Removed.
        * wtf/url/api/URLString.h: Removed.
        * wtf/url/src: Removed.
        * wtf/url/src/RawURLBuffer.h: Removed.
        * wtf/url/src/URLBuffer.h: Removed.
        * wtf/url/src/URLCharacterTypes.cpp: Removed.
        * wtf/url/src/URLCharacterTypes.h: Removed.
        * wtf/url/src/URLComponent.h: Removed.
        * wtf/url/src/URLEscape.cpp: Removed.
        * wtf/url/src/URLEscape.h: Removed.
        * wtf/url/src/URLParser.h: Removed.
        * wtf/url/src/URLQueryCanonicalizer.h: Removed.
        * wtf/url/src/URLSegments.cpp: Removed.
        * wtf/url/src/URLSegments.h: Removed.
        * wtf/url/wtfurl.gyp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 20:51:07 +0000 (20:51 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Another Chromium tests expectations update for details element.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 18 May 2011 20:41:54 +0000 (20:41 +0000)]
2011-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
        https://bugs.webkit.org/show_bug.cgi?id=61090

        Remove the Structure-free JSGlobalObject constructor and instead always
        pass the structure into the JSGlobalObject constructor.
        Stop DebuggerActivation creating a new structure every time, and simply
        use a single shared structure held by the GlobalData.

        * API/JSContextRef.cpp:
        * debugger/DebuggerActivation.cpp:
        (JSC::DebuggerActivation::DebuggerActivation):
        * jsc.cpp:
        (GlobalObject::GlobalObject):
        (functionRun):
        (jscmain):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::clearBuiltinStructures):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.h:
2011-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        JSGlobalObject and some others do GC allocation during initialization, which can cause heap corruption
        https://bugs.webkit.org/show_bug.cgi?id=61090

        Rather than having Constructor objects create their structure
        as part of initialisation, we now pass their expected structure
        in as an argument.  This required fixing the few custom Constructors
        and the code generator.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        * bindings/js/JSAudioConstructor.h:
        * bindings/js/JSDOMGlobalObject.h:
        (WebCore::getDOMConstructor):
          Pass the Constructor objects structure in as an argument
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        * bindings/js/JSImageConstructor.h:
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        * bindings/js/JSOptionConstructor.h:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 20:09:56 +0000 (20:09 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium tests expectations update for details element.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Jon Lee <jonlee@apple.com>
jonlee@apple.com [Wed, 18 May 2011 19:54:59 +0000 (19:54 +0000)]
2011-05-18  Jon Lee  <jonlee@apple.com>

        Reviewed by Simon Fraser.

        Crash in injected bundle client
        https://bugs.webkit.org/show_bug.cgi?id=61086

        * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
        (WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection): Check for existence of method in client prior to calling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Wed, 18 May 2011 19:35:25 +0000 (19:35 +0000)]
2011-05-18  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Expand layout test for testing the coords of a click on a label element
        https://bugs.webkit.org/show_bug.cgi?id=61080

        This expands the existing test to click on a label inside a scrolled element.

        * fast/events/simulated-click-coords-expected.txt:
        * fast/events/simulated-click-coords.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 18 May 2011 19:30:48 +0000 (19:30 +0000)]
2011-05-18  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Beth Dakin.

        Tests that we do not crash when prematurely calling removeChild,
        followed by destroy call on table caption.
        https://bugs.webkit.org/show_bug.cgi?id=61083

        * fast/table/table-captions-child-visible-crash-expected.txt: Added.
        * fast/table/table-captions-child-visible-crash.html: Added.
2011-05-18  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Beth Dakin.

        Remove removeChild on table caption since destroy call
        already does that.
        https://bugs.webkit.org/show_bug.cgi?id=61083

        Test: fast/table/table-captions-child-visible-crash.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::recalcCaption):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 18 May 2011 18:42:16 +0000 (18:42 +0000)]
2011-05-18  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] make action_derivedsourcesallinone.py quiet
        https://bugs.webkit.org/show_bug.cgi?id=61081

        In gyp, it's the responsibility of the build system to print what actions are doing;
        for example, the compile command is generally silent, while the build system prints
        "compiling".

        Make this program behave like a compiler: silent on success.

        * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
        delete a print statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 18 May 2011 18:28:38 +0000 (18:28 +0000)]
2011-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam Roben.

        Disable gc validation in release builds
        https://bugs.webkit.org/show_bug.cgi?id=60680

        Add back the NDEBUG check

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/61078> Use toHTTPPipeliningPriority() in initializeMaximumHTTPCo...
ddkilzer@apple.com [Wed, 18 May 2011 18:20:55 +0000 (18:20 +0000)]
<webkit.org/b/61078> Use toHTTPPipeliningPriority() in initializeMaximumHTTPConnectionCountPerHost()

Reviewed by Joseph Pecoraro.

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Use
toHTTPPipeliningPriority() to convert arguments passed to
wkSetHTTPPipeliningMaximumPriority() and
wkSetHTTPPipeliningMinimumFastLanePriority().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Wed, 18 May 2011 18:15:17 +0000 (18:15 +0000)]
2011-05-18  Chang Shu  <cshu@webkit.org>

        Reviewed by Csaba Osztrogonác.

        editing/style/apply-through-end-of-document.html is supposed to be dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=61077

        * editing/style/apply-through-end-of-document-expected.txt:
        * editing/style/apply-through-end-of-document.html:
        * platform/chromium-linux/editing/style/apply-through-end-of-document-expected.png: Removed.
        * platform/chromium-win/editing/style/apply-through-end-of-document-expected.png: Removed.
        * platform/chromium-win/editing/style/apply-through-end-of-document-expected.txt: Removed.
        * platform/gtk/editing/style/apply-through-end-of-document-expected.txt: Removed.
        * platform/mac-leopard/editing/style/apply-through-end-of-document-expected.png: Removed.
        * platform/mac/editing/style/apply-through-end-of-document-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Wed, 18 May 2011 17:47:25 +0000 (17:47 +0000)]
2011-05-18  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        event.clientX/clientY is 0/0 in a click generated through a label
        https://bugs.webkit.org/show_bug.cgi?id=56606

        This tests that clicking on a label for an input generates a click event on the input
        with the same coordinates as the original click.

        * fast/events/simulated-click-coords-expected.txt: Added.
        * fast/events/simulated-click-coords.html: Added.
2011-05-18  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        event.clientX/clientY is 0/0 in a click generated through a label
        https://bugs.webkit.org/show_bug.cgi?id=56606

        This copies the coordinates from the underlying event to the simulated mouse event if the underlying event
        is a mouse event.

        This makes us match Firefox and IE.

        Test: fast/events/simulated-click-coords.html

        * dom/MouseEvent.cpp:
        (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 18 May 2011 17:33:48 +0000 (17:33 +0000)]
2011-05-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Sorted XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 18 May 2011 17:15:29 +0000 (17:15 +0000)]
2011-05-18  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Non-color CSS property values can get a color-picker
        https://bugs.webkit.org/show_bug.cgi?id=61056

        * inspector/front-end/CSSKeywordCompletions.js:
        (WebInspector.CSSKeywordCompletions.forProperty):
        (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Pratik Solanki <psolanki@apple.com>
psolanki@apple.com [Wed, 18 May 2011 16:12:51 +0000 (16:12 +0000)]
2011-05-18  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Dan Bernstein.

        Don't use DEFINE_STATIC_LOCAL with an unsigned
        https://bugs.webkit.org/show_bug.cgi?id=61026

        * storage/StorageTracker.cpp:
        (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): DEFINE_STATIC_LOCAL is meant
        for objects, not unsigned ints. We can just use static here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 18 May 2011 16:08:39 +0000 (16:08 +0000)]
2011-05-18  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        NULL deref when SVG elements have table styles
        https://bugs.webkit.org/show_bug.cgi?id=45561

        Restrict computed CSS values for SVG display property to block, inline or none.

        Tests: svg/custom/display-table-caption-foreignObject.svg
               svg/custom/display-table-caption-inherit-foreignObject.xhtml
               svg/custom/display-table-caption-inherit-text.xhtml
               svg/custom/display-table-caption-text.svg

        * css/CSSStyleSelector.cpp:
        (WebCore::SVGDisplayPropertyGuard::SVGDisplayPropertyGuard):
        (WebCore::SVGDisplayPropertyGuard::~SVGDisplayPropertyGuard):
        (WebCore::isAcceptableForSVGElement):
        (WebCore::CSSStyleSelector::applyProperty):
2011-05-18  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        NULL deref when SVG elements have table styles
        https://bugs.webkit.org/show_bug.cgi?id=45561

        * svg/custom/display-table-caption-foreignObject-expected.txt: Added.
        * svg/custom/display-table-caption-foreignObject.svg: Added.
        * svg/custom/display-table-caption-inherit-foreignObject-expected.txt: Added.
        * svg/custom/display-table-caption-inherit-foreignObject.xhtml: Added.
        * svg/custom/display-table-caption-inherit-text-expected.txt: Added.
        * svg/custom/display-table-caption-inherit-text.xhtml: Added.
        * svg/custom/display-table-caption-text-expected.txt: Added.
        * svg/custom/display-table-caption-text.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a new test that fails due to unimplemented WTR features
aroben@apple.com [Wed, 18 May 2011 16:02:56 +0000 (16:02 +0000)]
Skip a new test that fails due to unimplemented WTR features

* platform/mac-wk2/Skipped: Added http/tests/loading/nested_bad_objects.php.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove mac-wk2 expected failure results for a plugins test that I fixed in r86456
aroben@apple.com [Wed, 18 May 2011 15:58:31 +0000 (15:58 +0000)]
Remove mac-wk2 expected failure results for a plugins test that I fixed in r86456

Fixes <http://webkit.org/b/57456> <rdar://problem/9209331>
plugins/embed-prefers-plugins-for-images.html failing on SnowLeopard Intel Release (WebKit2
Tests)

* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/win-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed. We don't
need this extra passing result now that mac-wk2's failing result is gone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 18 May 2011 15:52:57 +0000 (15:52 +0000)]
2011-05-18  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
        https://bugs.webkit.org/show_bug.cgi?id=60811

        * inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added.
        * inspector/debugger/debugger-completions-on-call-frame.html: Added.
2011-05-18  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
        https://bugs.webkit.org/show_bug.cgi?id=60811

        Test: inspector/debugger/debugger-completions-on-call-frame.html

        * inspector/InjectedScriptSource.js:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions.else.evaluated):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.PresenationCallFrame.prototype.get variables):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 18 May 2011 15:47:33 +0000 (15:47 +0000)]
2011-05-18  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Remove usage of ChunkedUpdateDrawingArea.
        https://bugs.webkit.org/show_bug.cgi?id=60901

        To prepare for the eventual removal of the ChunkedUpdateDrawingArea,
        make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl.

        * UIProcess/API/qt/qgraphicswkview.cpp:
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::createDrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a new page to build.webkit.org to help find when tests started failing
aroben@apple.com [Wed, 18 May 2011 15:38:14 +0000 (15:38 +0000)]
Add a new page to build.webkit.org to help find when tests started failing

The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
right now, but already shows some useful information. It's somewhat similar to webkit-patch
failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
little more convenient than either of them, though, because it's all done in the browser
(and thus it's easy to go directly to the relevant test results).

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
(Buildbot): This class represents a Buildbot server.
(Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Buildbot.prototype.builderNamed): Returns a Builder with the given name.
(Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
callback.
(Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
be implemented by a derived class that understands this server's build naming scheme.
(Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
(Builder): This class represents one builder on the buildbot.
(Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
(Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
information about a particular test failure.
(Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
information about when tests started failing.
(Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
particular build.
(Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
callback.
(Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
extracts all the failing tests listed in it, passing them to the callback.
(Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
build, merges them into the build history, and calls the callback telling it whether the
next build should be fetched to provide more information.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
Added. Just some simple styles.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
(createDefinitionList): Takes an array of pairs and turns them into a DL element.
(getResource): Wrapper around XMLHttpRequest.
(Array.prototype.findFirst): Finds the first element matching the given predicate and
returns it.
(Array.prototype.last): Returns the last element of the array.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
(ViewController): This class contains the main logic for displaying the page.
(ViewController.loaded): Just calls through to parseHash.
(ViewController.parseHash): Either starts analyzing failures on a particular builder, or
shows the list of all testers so one can be chosen. This function is called when the page
loads and whenever we get a hashchange event.
(ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
as it is fetched. The display ends up grouping tests by when they started failing.
(ViewController._displayTesters): Gets the list of testers and displays it.

(ViewController._domForBuildName):
(ViewController._domForFailedTest):
Helper functions to create descriptions and links for a particular build or failed test.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
(WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
(WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
loads all the files and sets up a ViewController, which does the rest.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 18 May 2011 15:35:36 +0000 (15:35 +0000)]
2011-05-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        All animated SVG enum properties are now ints
        https://bugs.webkit.org/show_bug.cgi?id=10749

        Add tests for all elements using SVGAnimatedEnumeration in the SVG DOM API.

        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Update result, progression.
        * svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt: Added.
        * svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html: Added.
        * svg/dom/SVGAnimatedEnumeration-expected.txt:
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGClipPathElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEBlendElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEColorMatrixElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFEMorphologyElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFETurbulenceElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGFilterElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGGradientElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGMarkerElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGMaskElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGPatternElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextContentElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration-SVGTextPathElement.js: Added.
        * svg/dom/script-tests/SVGAnimatedEnumeration.js:
        * svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt:
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js:
        (executeTest):
        * svg/filters/feBlend-invalid-mode-expected.txt:
        * svg/filters/feComponentTransfer-style-crash-expected.txt:
        * svg/filters/feComponentTransfer-style-crash.xhtml:
        * svg/filters/feDisplacementMap-crash-test-expected.txt:
        * svg/filters/feDisplacementMap-crash-test.xhtml:

2011-05-18  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        All animated SVG enum properties are now ints
        https://bugs.webkit.org/show_bug.cgi?id=10749

        DECLARE/DEFINE_ANIMATED_ENUMERATION created fooBaseVal()/setFooBaseVal() methods that take int parameters, and stored all enum types as integers.
        Modify the SVG DOM API to store real enums, and get rid of any int<->enum conversions. It's now impossible to change any enum values to undefined
        types, which is the root of several filter security bugs in the past, that were fixed by adding workarounds.
        (Usual workaround: svgAttributeChanged(): if fooAttr has been changed from SVG DOM, and if it's an enum, check whether the enum is in range, or fix it up.)

        Using a type-safe internal representation for these enum values we can get rid of ugly int<->enum conversions.
        A lot of parseMappedAttribute() functions duplicated the code for parsing enum values (eg. userSpaceOnUse/objectBoundingBox unit values, in pattern/filter/mask/etc..)
        Add dozens of new SVGPropertyTraits<EnumType> specializations for all enums we expose to JS, and offer static fromString/toString conversion methods in single places.
        Use the new SVGPropertyTraits everywhere in svg/.

        This also fixes SVG DOM <-> XML DOM synchronization for SVGAnimatedEnumeration types.
        Example: <clipPath clipPathUnits="objectBoundingBox">
        myClipPath.clipPathUnits.baseVal = SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE;
        alert(myClipPath.getAttribute('clipPathUnits')); <- without this patch it says "1", now it says "userSpaceOnUse" as expected, and as other browsers do.
        We're now properly converting the enum values to strings.

        Add testcases for all SVGAnimatedEnumeration objects used in the SVG DOM API. Found several small bugs:
        - SVGFEConvolveMatrix 'edgeMode' SVG DOM <-> XML DOM synchronization was not working, because of a typo: s/operatorAttr/edgeModeAttr
        - SVGFEConvolveMatrix was missing an synchronizeProperty() implementation, disabling SVG <-> XML DOM synchronization completly.

        Tests: svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html
               svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html
               svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html
               svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html
               svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html
               svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html
               svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html
               svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html
               svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html

        Fixes existing svg/dynamic-update/SVGTextContentElement-svgdom-lengthAdjust-prop.html where I found the bug initially.

        * GNUmakefile.list.am: Add svg/properties/SVGAnimatedEnumerationPropertyTearOff.h to build.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/scripts/CodeGeneratorV8.pm: Add V8 magic, to avoid ambigious conversion warning in toV8(PassRefPtr<SVGAnimatedEnumeration>).
        * platform/graphics/GraphicsTypes.h: Cleanup GradientSpreadMethod, as the SVG dependency is gone.
        * platform/graphics/filters/FEBlend.cpp:
        (WebCore::FEBlend::apply): Turn early-returns (introduce in security patches a while ago) into ASSERTs, as the underlying bug has been fixed.
        * platform/graphics/filters/FEDisplacementMap.cpp:
        (WebCore::FEDisplacementMap::apply): Ditto.
        * rendering/svg/RenderSVGResourceClipper.h: Remove toUnitType() usage, the clipPathUnits() provided by SVGClipPathElement have the correct enum type now.
        (WebCore::RenderSVGResourceClipper::clipPathUnits):
        * rendering/svg/RenderSVGResourceFilter.h: Remove toUnitType() usage, the filterUnits()/primitiveUnits() provided by SVGFilterElement have the correct enum type now.
        (WebCore::RenderSVGResourceFilter::filterUnits):
        (WebCore::RenderSVGResourceFilter::primitiveUnits):
        * rendering/svg/RenderSVGResourceGradient.cpp: Add helper method platformSpreadMethodFromSVGType() converting from SVGGradientElement::SVGSpreadMethodType to GradientSpreadMethod (platform).
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/svg/RenderSVGResourceGradient.h: Ditto.
        * rendering/svg/RenderSVGResourceLinearGradient.cpp:
        (WebCore::RenderSVGResourceLinearGradient::buildGradient): Use platformSpreadMethodFromSVGType().
        * rendering/svg/RenderSVGResourceMarker.h: Remove toUnitType() usage, the markerUnits() provided by SVGMarkerElement have the correct enum type now.
        (WebCore::RenderSVGResourceMarker::markerUnits):
        * rendering/svg/RenderSVGResourceMasker.h: Remove toUnitType() usage, the maskUnits()/maskContentUnits() provided by SVGMaskElement have the correct enum type now.
        (WebCore::RenderSVGResourceMasker::maskUnits):
        (WebCore::RenderSVGResourceMasker::maskContentUnits):
        * rendering/svg/RenderSVGResourceRadialGradient.cpp:
        (WebCore::RenderSVGResourceRadialGradient::buildGradient): Use platformSpreadMethodFromSVGType().
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<): Use SVGPropertyTraits<SomeSVGEnumType>::toString() to convert from enum to string, remove code duplication.
        (WebCore::writeCommonGradientProperties):
        * rendering/svg/SVGTextChunkBuilder.cpp:
        (WebCore::SVGTextChunkBuilder::addTextChunk): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        * rendering/svg/SVGTextLayoutEngine.cpp:
        (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): Ditto.
        (WebCore::SVGTextLayoutEngine::beginTextPathLayout): Ditto.
        * svg/GradientAttributes.h: Change spread method type from platform GradientSpreadMethod to SVGSpreadMethodType.
        (WebCore::GradientAttributes::GradientAttributes):
        (WebCore::GradientAttributes::spreadMethod):
        (WebCore::GradientAttributes::setSpreadMethod):
        * svg/SVGAnimatedBoolean.idl: Enable potential exception raising on baseVal setting for the primitive types.
        * svg/SVGAnimatedEnumeration.h: Switch from generic SVGAnimatedStaticPropertyTearOff<int> to new SVGAnimatedEnumerationPropertyTearOff<EnumType>.
        * svg/SVGAnimatedEnumeration.idl: Enable potential exception raising on baseVal setting for the primitive types.
                                          Only SVGAnimatedEnumeration makes use of this if the assigned value is out of range.
        * svg/SVGAnimatedInteger.idl: Ditto.
        * svg/SVGAnimatedNumber.idl: Ditto.
        * svg/SVGAnimatedString.idl: Ditto.
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
        * svg/SVGClipPathElement.h:
        * svg/SVGComponentTransferFunctionElement.cpp:
        (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): Initialize type to identity, not unknown, as per spec.
        (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
        (WebCore::SVGComponentTransferFunctionElement::transferFunction): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        * svg/SVGComponentTransferFunctionElement.h: Remove svgAttributeChanged() method, that verified the enum value is not out of range.
                                                     It's not possible anymore for these values to go out of range.
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<BlendModeType>::fromString(attr->value()).
        (WebCore::SVGFEBlendElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        (WebCore::SVGFEBlendElement::build): Ditto.
        * svg/SVGFEBlendElement.h: Add SVGPropertyTraits<BlendModeType> specializations.
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ColorMatrixType>::fromString(attr->value()).
        (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now..
        (WebCore::SVGFEColorMatrixElement::build): Ditto.
        * svg/SVGFEColorMatrixElement.h: Add SVGPropertyTraits<ColorMatrixType> specializations.
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<CompositeOperationType>::fromString(attr->value()).
        (WebCore::SVGFECompositeElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        (WebCore::SVGFECompositeElement::build): Ditto.
        * svg/SVGFECompositeElement.h: Add SVGPropertyTraits<CompositeOperationType> specializations.
        * svg/SVGFEConvolveMatrixElement.cpp: Fix typo, edgeMode needs to be associated with SVGNames::edgeModeAttr, not SVGNames::operatorAttr.
        (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EdgeModeType>::fromString(attr->value()).
        (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        (WebCore::SVGFEConvolveMatrixElement::synchronizeProperty): Add missing synchronizeProperty() implementation, otherwhise SVG DOM <-> XML DOM is not in sync.
        (WebCore::SVGFEConvolveMatrixElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        * svg/SVGFEConvolveMatrixElement.h: Add SVGPropertyTraits<EdgeModeType> specializations.
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<ChannelSelectorType>::fromString(attr->value()).
        (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Remove range validation for enum types, they are always in range now.
        (WebCore::SVGFEDisplacementMapElement::build): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        * svg/SVGFEDisplacementMapElement.h: Add SVGPropertyTraits<ChannelSelectorType> specializations.
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<MorphologyOperatorType>::fromString(attr->value()).
        (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        (WebCore::SVGFEMorphologyElement::build): Ditto.
        * svg/SVGFEMorphologyElement.h: Add SVGPropertyTraits<MorphologyOperatorType> specializations.
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGStitchOptions/TurbulenceType>::fromString(attr->value()).
        (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        (WebCore::SVGFETurbulenceElement::build): Ditto.
        * svg/SVGFETurbulenceElement.h: Add SVGPropertyTraits<SVGStitchOptions/TurbulenceType> specializations.
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType>::fromString(attr->value()).
        * svg/SVGFilterElement.h:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::SVGGradientElement): Missing spread method default initialization: set it to 'pad' as per spec.
        (WebCore::SVGGradientElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGUnitType/SVGSpreadMethodType>::fromString(attr->value()).
        * svg/SVGGradientElement.h: Add SVGPropertyTraits<SVGSpreadMethodType> specializations.
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
        (WebCore::SVGMarkerElement::synchronizeOrientType): Add a custom synchronization method, that handles orientType/orientAngle -> orientAttr synchronization, which is special
                                                            as it depends on to other SVG DOM objects (SVGAnimatedAngle and SVGAnimatedEnumeration). All covered by new tests.
        (WebCore::SVGMarkerElement::orientTypeAnimated): Custom tear off creation method, which would usually be generated by the DECLARE_ANIMATED_... macros.
        * svg/SVGMarkerElement.h: Add SVGPropertyTraits<SVGMarkerUnitsType/SVGMarkerOrientType> specializations.
        (WebCore::SVGMarkerElement::orientType): Add custom property handling for the 'orientType' SVGAnimatedEnumeration object, as it has special demands, based on 'orientAngle'.
        (WebCore::SVGMarkerElement::orientTypeBaseValue): Ditto.
        (WebCore::SVGMarkerElement::setOrientTypeBaseValue): Ditto.
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
        * svg/SVGMaskElement.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<EnumType>::fromString(attr->value()).
        * svg/SVGPatternElement.h:
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::collectGradientAttributes): Remove int->enum casting for SVGAnimatedEnumeration types, they are enums now.
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGLengthAdjustType>::fromString(attr->value()).
        * svg/SVGTextContentElement.h: Add SVGPropertyTraits<SVGLengthAdjustType> specializations.
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::parseMappedAttribute): Convert attribute parsing to use SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType>::fromString(attr->value()).
        * svg/SVGTextPathElement.h: Add SVGPropertyTraits<SVGTextPathMethodType/SVGTextPathSpacingType> specializations.
        * svg/SVGUnitTypes.h: Add SVGPropertyTraits<SVGUnitType> specializations.
        * svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Added. SVGAnimatedEnumerationPropertyTearOff inherits from SVGAnimatedStaticPropertyTearOff<int>.
                                                                  SVGAnimatedEnumeration remains a typedef to SVGAnimatedStaticPropertyTearOff<int>, to have a common base
                                                                  class for all enum types. This special tear off object, overrides setBaseVal, to verify the incoming int
                                                                  is within the enum range, otherwhise raise an SVG DOM exception. This makes it impossible to make any of
                                                                  the enums go out of range anymore (which lead to security bugs in the past).
        (WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
        (WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
        (WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):
        * svg/properties/SVGAnimatedStaticPropertyTearOff.h:
        (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Made this method virtual, to SVGAnimatedEnumerationPropertyTearOff can override the default behaviour. Also added an ExceptionCode param.
        (WebCore::SVGAnimatedStaticPropertyTearOff::~SVGAnimatedStaticPropertyTearOff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 18 May 2011 15:31:33 +0000 (15:31 +0000)]
2011-05-18  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
        https://bugs.webkit.org/show_bug.cgi?id=59681

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * storage/script-tests/storageinfo-request-quota.js: Added.
        * storage/storageinfo-request-quota-expected.txt: Added.
        * storage/storageinfo-request-quota.html: Added.
2011-05-18  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Expose webkitStorageInfo.requestQuota() for Quota API if QUOTA flag is enabled
        https://bugs.webkit.org/show_bug.cgi?id=59681

        Test: storage/storageinfo-request-quota.html

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/StorageInfo.idl: Added requestQuota().
        * storage/StorageInfoQuotaCallback.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Wed, 18 May 2011 15:20:04 +0000 (15:20 +0000)]
2011-05-18  Renata Hodovan  <reni@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Apply the ParallelJobs support to FEGaussianBlur
        https://bugs.webkit.org/show_bug.cgi?id=61049

        The Gaussian blur filter of SVG can consume lots of resources if it is
        applied to a large area. The computation can be distributed to multiple
        cores if the architecture supports.
        The average performance progression is about 15% on dual-core machines.

        Developed in cooperation with Gabor Loki and Zoltan Herczeg.

        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::platformApplyWorker):
        (WebCore::FEGaussianBlur::platformApply):
        * platform/graphics/filters/FEGaussianBlur.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Skip two failing tests.
ossy@webkit.org [Wed, 18 May 2011 15:06:14 +0000 (15:06 +0000)]
[Qt][WK2] Skip two failing tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 18 May 2011 15:04:23 +0000 (15:04 +0000)]
2011-05-18  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Don't lie about supporting accelerated compositing.
        https://bugs.webkit.org/show_bug.cgi?id=61054

        Until we have an implementation of LayerTreeHost, we shouldn't lie about it.

        * WebKit2.pro:
        * WebProcess/WebPage/LayerTreeHost.h:
        * WebProcess/WebPage/qt/LayerTreeHostQt.cpp: Added.
        (WebKit::LayerTreeHost::supportsAcceleratedCompositing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 18 May 2011 14:31:10 +0000 (14:31 +0000)]
2011-05-18  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make parentId for frame optional.
        https://bugs.webkit.org/show_bug.cgi?id=61032

        * inspector/Inspector.json:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::buildObjectForFrame):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype._addFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 18 May 2011 14:27:28 +0000 (14:27 +0000)]
2011-05-18  Gabor Loki  <loki@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Apply the ParallelJobs support to FELighting
        https://bugs.webkit.org/show_bug.cgi?id=61048

        The lighting filter of SVG can consume lots of resources if it is
        applied to a large area. The computation can be distributed to multiple
        cores if the architecture supports.
        The average performance progression is 10-20% on dual-core machines.

        Developed in cooperation with Zoltan Herczeg.

        * platform/graphics/filters/FELighting.cpp:
        (WebCore::FELighting::platformApplyGenericPaint):
        (WebCore::FELighting::platformApplyGenericWorker):
        (WebCore::FELighting::platformApplyGeneric):
        * platform/graphics/filters/FELighting.h:
        * platform/graphics/filters/arm/FELightingNEON.cpp:
        (WebCore::FELighting::platformApplyNeonWorker):
        * platform/graphics/filters/arm/FELightingNEON.h:
        (WebCore::FELighting::platformApplyNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Wed, 18 May 2011 14:12:56 +0000 (14:12 +0000)]
2011-05-18  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
        https://bugs.webkit.org/show_bug.cgi?id=60984

        The code for converting objects to QVariantMap was causing exception,
        that was "leaking" to the next evaluation. One situation was reading
        the property 'localStorage' when we do not have a proper security
        origin, which throws a SECURITY_ERR.

        Now, we will simply not include on the QVariantMap those properties,
        and make sure that we clean the exception if necessary.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariantMap):
        Extracted function that performs conversion from JSObject to a QVariantMap. This
        functions makes sure that exception is clean after its execution.

        (JSC::Bindings::convertValueToQVariant):
        Use the previous function. Add a comment explaining the choice of distance value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 18 May 2011 14:11:55 +0000 (14:11 +0000)]
2011-05-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: scripts panel file selector element doesn't track keyboard events
        https://bugs.webkit.org/show_bug.cgi?id=61047

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-16 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 18 May 2011 13:50:56 +0000 (13:50 +0000)]
2011-05-16  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactoring: ScriptDebugListener::didParseSource has too many parameters.
        https://bugs.webkit.org/show_bug.cgi?id=60900

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::getScriptSource):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/ScriptDebugListener.h:
        (WebCore::ScriptDebugListener::Script::Script):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove whitespace from the line of fast/forms/ValidityState-valueMissing-002.html
zoltan@webkit.org [Wed, 18 May 2011 13:42:24 +0000 (13:42 +0000)]
Remove whitespace from the line of fast/forms/ValidityState-valueMissing-002.html

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 18 May 2011 13:32:07 +0000 (13:32 +0000)]
2011-05-18  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
        https://bugs.webkit.org/show_bug.cgi?id=60966

        * inspector/styles/resources/styles-new-API-1.css:
        * inspector/styles/resources/styles-new-API-2.css: Copied from LayoutTests/inspector/styles/resources/styles-new-API-1.css.
        (@page):
        (@page :first):
        (#absent-id):
        (@font-face):
        (body):
        * inspector/styles/styles-new-API-expected.txt:
2011-05-18  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: model-based CSS editing does not update @import-ed stylesheet resources
        https://bugs.webkit.org/show_bug.cgi?id=60966

        Imported stylesheets didn't use to be returned by InspectorCSSAgent.

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getAllStyleSheets):
        (WebCore::InspectorCSSAgent::collectStyleSheets):
        * inspector/InspectorCSSAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd fast/forms/ValidityState-valueMissing-002.html to the Skipped list since
zoltan@webkit.org [Wed, 18 May 2011 12:56:22 +0000 (12:56 +0000)]
Add fast/forms/ValidityState-valueMissing-002.html to the Skipped list since
eventSender.keyDown is unimplemented.

Reviewed by Csaba Osztrogonác.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 18 May 2011 12:04:35 +0000 (12:04 +0000)]
2011-05-18  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make "Id" suffixes use consistent case.
        https://bugs.webkit.org/show_bug.cgi?id=61028

        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::addMessageToConsole):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorConsoleInstrumentation.h:
        (WebCore::InspectorInstrumentation::addMessageToConsole):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::parseLocation):
        (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::getScriptSource):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
        * inspector/InspectorInstrumentation.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):
        * inspector/ScriptDebugListener.h:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.scriptForSourceID):
        (WebInspector.DebuggerModel.prototype.queryScripts):
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
        (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
        (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
        (WebInspector.PresenationCallFrame):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
        * inspector/front-end/Script.js:
        (WebInspector.Script):
        (WebInspector.Script.prototype.requestSource):
        (WebInspector.Script.prototype.editSource):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.forceLoadContent):
        (WebInspector.SourceFile.prototype._concatenateScriptsContent):
        (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
        (WebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 18 May 2011 11:33:52 +0000 (11:33 +0000)]
2011-05-18  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86747.
        http://trac.webkit.org/changeset/86747
        https://bugs.webkit.org/show_bug.cgi?id=61039

        Breaks JSC debugger tests. (Requested by pfeldman on #webkit).

        * inspector/InjectedScriptSource.js:
        ():
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::addMessageToConsole):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorConsoleInstrumentation.h:
        (WebCore::InspectorInstrumentation::addMessageToConsole):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::parseLocation):
        (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::getScriptSource):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
        * inspector/InspectorInstrumentation.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):
        * inspector/ScriptDebugListener.h:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.scriptForSourceID):
        (WebInspector.DebuggerModel.prototype.queryScripts):
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
        (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
        (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
        (WebInspector.PresenationCallFrame):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
        * inspector/front-end/Script.js:
        (WebInspector.Script):
        (WebInspector.Script.prototype.requestSource):
        (WebInspector.Script.prototype.editSource):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.forceLoadContent):
        (WebInspector.SourceFile.prototype._concatenateScriptsContent):
        (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
        (WebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 18 May 2011 11:03:12 +0000 (11:03 +0000)]
2011-05-18  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        Removed duplcate entries added by r86749

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 18 May 2011 10:49:14 +0000 (10:49 +0000)]
2011-05-18  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        Since Chromium r85744, tests for <details> element pass on Mac and TEXT mismatch on Linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 18 May 2011 10:45:07 +0000 (10:45 +0000)]
2011-05-18  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dirk Schulze.

        Tests that we do not crash when trying to access a removed
        smil element in animated elements list.
        https://bugs.webkit.org/show_bug.cgi?id=60980

        * svg/animations/smil-element-not-removed-crash-expected.txt: Added.
        * svg/animations/smil-element-not-removed-crash.html: Added.
2011-05-18  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dirk Schulze.

        When SMIL element is getting removed, make sure to remove it
        from target's animation elements list.
        https://bugs.webkit.org/show_bug.cgi?id=60980

        Test: svg/animations/smil-element-not-removed-crash.html

        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::~SVGSMILElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 18 May 2011 09:48:35 +0000 (09:48 +0000)]
2011-05-18  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make "Id" suffixes use consistent case.
        https://bugs.webkit.org/show_bug.cgi?id=61028

        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::addMessageToConsole):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorConsoleInstrumentation.h:
        (WebCore::InspectorInstrumentation::addMessageToConsole):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::parseLocation):
        (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::getScriptSource):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
        * inspector/InspectorInstrumentation.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):
        * inspector/ScriptDebugListener.h:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.scriptForSourceID):
        (WebInspector.DebuggerModel.prototype.queryScripts):
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
        (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
        (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
        (WebInspector.PresenationCallFrame):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
        * inspector/front-end/Script.js:
        (WebInspector.Script):
        (WebInspector.Script.prototype.requestSource):
        (WebInspector.Script.prototype.editSource):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.forceLoadContent):
        (WebInspector.SourceFile.prototype._concatenateScriptsContent):
        (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
        (WebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 18 May 2011 09:46:51 +0000 (09:46 +0000)]
2011-05-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
        https://bugs.webkit.org/show_bug.cgi?id=60286

        * inspector/front-end/ProfilesPanel.js:

2011-05-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Enable detailed heap snapshots by default.
        https://bugs.webkit.org/show_bug.cgi?id=60286

        * src/js/DevTools.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 18 May 2011 09:45:17 +0000 (09:45 +0000)]
2011-05-18  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not reveal line -1 when navigating to anchor without line specified.
        https://bugs.webkit.org/show_bug.cgi?id=60971

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.showAnchorLocation.):
        (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
        * inspector/front-end/inspector.js:
        (WebInspector._showAnchorLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 18 May 2011 09:33:42 +0000 (09:33 +0000)]
2011-05-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        valueMissing validity for <select> is lame when selecting a value by a key operation
        https://bugs.webkit.org/show_bug.cgi?id=61021

        Add test cases for the bug.

        * fast/forms/ValidityState-valueMissing-002-expected.txt:
        * fast/forms/ValidityState-valueMissing-002.html:
2011-05-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        valueMissing validity for <select> is lame when selecting a value by a key operation
        https://bugs.webkit.org/show_bug.cgi?id=61021

        We missed updating validity in case that SelectElement::defaultEventHandler
        update selections.  So, SelectElement::setSelectedIndex() updates validity.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::setSelectedIndex): Call SelectElement::updateValidity().
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex):
          Remove unnecessary setNeedsValidityCheck() call.
          SelectElement::setSlectedIndex() calls it.
        (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 18 May 2011 09:31:32 +0000 (09:31 +0000)]
2011-05-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Make retaining paths list of the Detailed
        heap snapshots view resizable.
        https://bugs.webkit.org/show_bug.cgi?id=60960

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype.resize):
        (WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
        (WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging):
        (WebInspector.DetailedHeapshotView.prototype._endRetainersHeaderDragging):
        (WebInspector.DetailedHeapshotView.prototype._updateRetainmentViewHeight):
        * inspector/front-end/heapProfiler.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
commit-queue@webkit.org [Wed, 18 May 2011 09:10:49 +0000 (09:10 +0000)]
2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] Implement layoutTestController.setValueForUser()
        https://bugs.webkit.org/show_bug.cgi?id=60956

        * platform/qt/Skipped: Unskip fast/forms/onchange-setvalueforuser.html
2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] Implement layoutTestController.setValueForUser()
        https://bugs.webkit.org/show_bug.cgi?id=60956

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setValueForUser):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] Implement layoutTestController.setValueForUser()
        https://bugs.webkit.org/show_bug.cgi?id=60956

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setValueForUser):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-16 Jeremy Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 18 May 2011 07:38:30 +0000 (07:38 +0000)]
2011-05-16  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Disable keyboard input (with exceptions) in full-screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=60943

        * fullscreen/full-screen-keyboard-disabled-expected.txt: Added.
        * fullscreen/full-screen-keyboard-disabled.html: Added.
        * fullscreen/full-screen-keyboard-enabled-expected.txt: Added.
        * fullscreen/full-screen-keyboard-enabled.html: Added.
2011-05-16  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Disable keyboard input (with exceptions) in full-screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=60943

        Tests: fullscreen/full-screen-keyboard-disabled.html
               fullscreen/full-screen-keyboard-enabled.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::isKeyEventAllowedInFullScreen): Added.  Implements the
            list of allowed keyboard events in the proposed API.
        (WebCore::EventHandler::keyEvent): Discard events which are not allowed in
            full-screen mode.
        * page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 18 May 2011 07:34:07 +0000 (07:34 +0000)]
2011-05-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed. Fix build break.

        * Source/cmake/WebKitMacros.cmake: Add -i option in order to include Lookup.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago-2011-05-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 18 May 2011 07:19:48 +0000 (07:19 +0000)]
-2011-05-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Refactor TextRun creation
        https://bugs.webkit.org/show_bug.cgi?id=60255

        Add constructTextRun() methods to RenderBlock/InlineTextBox and use it in various places in rendering/.
        The long-term goal is to remove the ugly eight parameters catch-it-all TextRun constructor, and
        replace it with explicit setters/getters. To avoid expanding dozens of callsites, when removing
        the catch-it-all constructor, these helper functions are introduced, which hide the details of
        creating a TextRun.

        Furthermore it will be used to remove the platform layering violation, that TextRun stores
        RenderObject pointers for the sake of SVG Fonts support, see bug 60254.

        No change in functionaliy, no new tests.

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::selectionRect):
        (WebCore::EllipsisBox::paintSelection):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintCompositionBackground):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::offsetForPosition):
        (WebCore::InlineTextBox::positionForOffset):
        (WebCore::InlineTextBox::constructTextRun):
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::constructTextRunAllowTrailingExpansion):
        * rendering/RenderBlock.h:
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::setImageSizeForAltText):
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::updateFromElement):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::getAvgCharWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Jeremy Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 18 May 2011 06:16:29 +0000 (06:16 +0000)]
2011-05-17  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Exiting full screen will leave up invisible full-screen window, blocking all mouse clicks.
        https://bugs.webkit.org/show_bug.cgi?id=60982

        The GraphicsLayer tree has unparented m_fullScreenRootLayer behind our backs, replacing the
        tiled layer with a normal one.  Instead of holding on to a specific layer, assume that the
        w_rootLayer will only have 0 or 1 children, and if a child is present, then that is our full-
        screen layer.

        Additionally, check to see if the animating layer's presentationLayer is nil
        before calling it; asking a nil object for a CATransform3D will give back a struct full of
        garbage.

        In WKFullScreenWindowController, when the exit animation completes, ignore the "completed"
        parameter.  This eliminates the possibility that the full screen window will end up left
        on top of the screen if the animation is cancelled and a enter full screen animation isn't
        forthcoming.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Jeremy Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 18 May 2011 06:12:12 +0000 (06:12 +0000)]
2011-05-17  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=60997

        Updated the following tests with the new expectation that removing an element from the DOM will trigger
        full screen mode to exit.

        * fullscreen/full-screen-remove-ancestor-expected.txt:
        * fullscreen/full-screen-remove-ancestor.html:
        * fullscreen/full-screen-remove-children-expected.txt:
        * fullscreen/full-screen-remove-children.html:
        * fullscreen/full-screen-remove-expected.txt:
        * fullscreen/full-screen-remove.html:
2011-05-17  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Removing a full-screen element or ancestor from the DOM should trigger exiting full-screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=60997

        Tests: fullscreen/full-screen-remove-ancestor.html
               fullscreen/full-screen-remove-children.html
               fullscreen/full-screen-remove.html

        * dom/Document.cpp:
        (WebCore::Document::fullScreenChangeDelayTimerFired): If the target node was removed from the document
            make sure to message the documentElement() as well.
        (WebCore::Document::fullScreenElementRemoved): Cancel full screen mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Skip failing tests on minor Qt platforms.
ossy@webkit.org [Wed, 18 May 2011 05:50:53 +0000 (05:50 +0000)]
[Qt] Skip failing tests on minor Qt platforms.

* platform/qt-arm/Skipped:
* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 18 May 2011 05:22:47 +0000 (05:22 +0000)]
2011-05-17  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        The following tests now pass:
        fast/js/mozilla/eval/exhaustive-fun-normalcaller-direct-strictcode.html
        fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-normalcode.html
        fast/js/mozilla/eval/exhaustive-fun-strictcaller-direct-strictcode.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9458300> REGRESSION (r86724): Repro crash loading any webpage in...
mitz@apple.com [Wed, 18 May 2011 04:43:44 +0000 (04:43 +0000)]
<rdar://problem/9458300> REGRESSION (r86724): Repro crash loading any webpage in WebKit2 on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=61022

Reviewed by Alice Liu.

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain): As long as we are not loading the shim on Snow Leopard, we should not
try to initialize it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 18 May 2011 03:56:41 +0000 (03:56 +0000)]
2011-05-17  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        plugins/windowless_plugin_paint_test.html now passes on Linux, timeouts on Mac.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 18 May 2011 03:50:34 +0000 (03:50 +0000)]
2011-05-17  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Add CLOSING state
        https://bugs.webkit.org/show_bug.cgi?id=60878

        The value of WebSocket.CLOSED has been changed from 2 to 3, we have to update
        expected results of tests that dump WebSocket.readyState.

        * fast/dom/Window/window-properties-expected.txt:
        * http/tests/websocket/tests/bufferedAmount-after-close-expected.txt:
        * http/tests/websocket/tests/close-on-unload-reference-in-parent-expected.txt:
        * http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
        * http/tests/websocket/tests/handshake-error-expected.txt:
        * http/tests/websocket/tests/script-tests/bufferedAmount-after-close.js:
        (ws.onclose):
        * http/tests/websocket/tests/script-tests/handshake-error.js:
        (ws.onclose):
        * http/tests/websocket/tests/send-after-close-on-unload-expected.txt:
        * http/tests/websocket/tests/send-after-close-on-unload.html:
        * http/tests/websocket/tests/simple-expected.txt:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
2011-05-17  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Add CLOSING state
        https://bugs.webkit.org/show_bug.cgi?id=60878

        No new tests are added because there is no change in functionality.

        * platform/network/SocketStreamHandleBase.h:
        * websockets/WebSocket.h:
        * websockets/WebSocket.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 18 May 2011 03:47:01 +0000 (03:47 +0000)]
2011-05-17  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        plugins/invalidate_rect.html now passes on Linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRolled out attempts to fix EFL build because they're not enough -- the
ggaren@apple.com [Wed, 18 May 2011 03:23:10 +0000 (03:23 +0000)]
Rolled out attempts to fix EFL build because they're not enough -- the
build script needs to be fixed.

* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore attempts to work around the EFL build system being borken.
ggaren@apple.com [Wed, 18 May 2011 03:07:23 +0000 (03:07 +0000)]
More attempts to work around the EFL build system being borken.

* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the EFL build.
ggaren@apple.com [Wed, 18 May 2011 03:03:42 +0000 (03:03 +0000)]
Try to fix the EFL build.

* runtime/BooleanPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: Rolling back in r86653 with build fixed.
ggaren@apple.com [Wed, 18 May 2011 02:39:00 +0000 (02:39 +0000)]
Source/JavaScriptCore: Rolling back in r86653 with build fixed.

Reviewed by Gavin Barraclough and Oliver Hunt.

Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933

Changed a bunch of globals to allocate their properties lazily, and changed
the global object to allocate a bunch of its globals lazily.

This reduces the footprint of a global object from 287 objects with 58
functions for 24K to 173 objects with 20 functions for 15K.

Large patch, but it's all mechanical.

* DerivedSources.make:
* JavaScriptCore.exp: Build!

* create_hash_table: Added a special case for fromCharCode, since it uses
a custom "thunk generator".

* heap/Heap.cpp:
(JSC::TypeCounter::operator()): Fixed a bug where the type counter would
overcount objects that were owned through more than one mechanism because
it was getting in the way of counting the results for this patch.

* interpreter/CallFrame.h:
(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectPrototypeTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable): Added new tables.

* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::createStructure):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::createStructure):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
(JSC::DateConstructor::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::createStructure): Standardized these objects
to use static tables for function properties.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h: Added new tables.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSGlobalObjectFunctions.h: Changed JSGlobalObject to use a
static table for its global functions. This required uninlining some
things to avoid a circular header dependency. However, those things
probably shouldn't have been inlined in the first place.

Even more global object properties can be made lazy, but that requires
more in-depth changes.

* runtime/MathObject.cpp:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
(JSC::ObjectPrototype::createStructure):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::createStructure):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::createStructure): Standardized these objects
to use static tables for function properties.

LayoutTests: Global object initialization is expensive
https://bugs.webkit.org/show_bug.cgi?id=60933

Reviewed by Gavin Barraclough.

Added a few more expected failures, now that more code uses static hash
tables.

The fact that built-ins are not deletable, but should be, is covered by
https://bugs.webkit.org/show_bug.cgi?id=61014

* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-16 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 18 May 2011 01:48:39 +0000 (01:48 +0000)]
2011-05-16  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] ShadowContentElement should be part of dom/
        https://bugs.webkit.org/show_bug.cgi?id=59117

        - Moved html/shadow/ShadowContentElement.h to dom/ShadowContentElement.h
        - Pulled ShadowContentElement up to a subclass of StyledElement, from HTMLDivElement
        - Added ShadowContentElement.cpp
        - Extracted ShadowContentSelector.{cpp,h} from ShadowRoot.{cpp,h}

        No new tests, no behavior change.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DOMAllInOne.cpp: Added new ShadowContentSelector.cpp and ShadowContentElement.cpp.
        * dom/Node.h:
        (WebCore::Node::forceReattach): Moved from static local function to share between classes.
        * dom/ShadowContentElement.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentElement::attach):
        * dom/ShadowContentElement.h: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentElement::ShadowContentElement):
        (WebCore::ShadowContentElement::isShadowBoundary):
        (WebCore::ShadowContentElement::rendererIsNeeded):
        (WebCore::ShadowContentElement::createRenderer):
        * dom/ShadowContentSelector.cpp: Copied from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentSelector::ShadowContentSelector):
        (WebCore::ShadowContentSelector::~ShadowContentSelector):
        (WebCore::ShadowContentSelector::attachChildrenFor):
        * dom/ShadowContentSelector.h: Renamed from Source/WebCore/html/shadow/ShadowContentElement.h.
        (WebCore::ShadowContentSelector::shadowRoot):
        (WebCore::ShadowContentSelector::activeElement):
        (WebCore::ShadowContentSelector::currentInstance):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::recalcStyle):
        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsContentElement::DetailsContentElement):
        (WebCore::DetailsSummaryElement::DetailsSummaryElement):
        * html/HTMLSummaryElement.cpp:
        (WebCore::SummaryContentElement::SummaryContentElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Wed, 18 May 2011 00:53:22 +0000 (00:53 +0000)]
2011-05-17  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Clear the image from ImageLoader rather than clearing the ImageLoader in HTMLObjectElement::renderFallbackContent.
        https://bugs.webkit.org/show_bug.cgi?id=61005

        Test: http/tests/loading/nested_bad_objects.php

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::renderFallbackContent):
2011-05-17  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Tests for crash when two nested image objects with invalid data are loaded.
        https://bugs.webkit.org/show_bug.cgi?id=61005

        * http/tests/loading/nested_bad_objects-expected.txt: Added.
        * http/tests/loading/nested_bad_objects.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=60595
beidson@apple.com [Wed, 18 May 2011 00:29:36 +0000 (00:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60595
Fix the rampant WebProcess crashing because we're trying to install the WebProcess shim
into QTKitServer when we launch it.

Rubberstamped by Sam Weinig.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): This is only happening on SnowLeopard, so put
  SnowLeopard build guards around the shim install path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 18 May 2011 00:21:33 +0000 (00:21 +0000)]
2011-05-17  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Simon Fraser.

        Remove empty directory.

        * fast/inspector: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 18 May 2011 00:12:46 +0000 (00:12 +0000)]
2011-05-17  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Make sure that AudioNode gets re-enabled after having been disconnected and re-connected.
        https://bugs.webkit.org/show_bug.cgi?id=60995

        No new tests since audio API is not yet implemented.

        * webaudio/AudioNode.cpp:
        (WebCore::AudioNode::ref):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Tao Bai <michaelbai@chromium.org>
commit-queue@webkit.org [Wed, 18 May 2011 00:08:47 +0000 (00:08 +0000)]
2011-05-17  Tao Bai  <michaelbai@chromium.org>

        Reviewed by Darin Fisher.

        Clear deprecated icon APIs from chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=60989

        * public/WebFrame.h: Removed faviconURL()
        * public/WebFrameClient.h: Removed didChangeIcons()
        * src/FrameLoaderClientImpl.cpp:
             Removed the code to support deprecated API
        (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
        * src/WebFrameImpl.cpp: Removed faviconURL()
        * src/WebFrameImpl.h:  Removed faviconURL()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 17 May 2011 23:42:36 +0000 (23:42 +0000)]
2011-05-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/9366728> and https://webkit.org/b/60796
        Crash when code inside a ResourceLoadDelegate method calls [WebView stopLoading:]

        Break up ResourceLoader::didCancel() into willCancel() and didCancel(), and making them pure virtual.
        This change has the following benefits:
          - Managing ResourceLoader state can be in the base class; Subclasses no longer need to protect
            themselves, check these variables as often, or ASSERT them.
          - ResourceLoader subclasses no longer have to call the base class ::didCancel
          - ResourceLoader::cancel becomes more capable of handling reentrancy with the design that the
            cancellation is completed inside the last call.

        No new tests - No change in behavior for previous tests, and new test would require API usage outside
        the scope of DumpRenderTree.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::cancel): Moved from ResourceLoader::didCancel, and does all of that same work
          except it interposes calls to "willCancel" and "didCancel" as required to maintain the same behavior.
        * loader/ResourceLoader.h: Added pure virtual didCancel() and willCancel().

        Split-up into willCancel() and didCancel(), based on when the base class didCancel() used to be called:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willCancel):
        (WebCore::MainResourceLoader::didCancel):
        * loader/MainResourceLoader.h:

        Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Call the entry point cancel() instead of the old didCancel()
        (WebCore::NetscapePlugInStreamLoader::willCancel):
        (WebCore::NetscapePlugInStreamLoader::didCancel):
        * loader/NetscapePlugInStreamLoader.h:

        Split-up into willCancel() and didCancel(), based on when the "reached terminal state" flag used to be checked:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::willCancel):
        (WebCore::SubresourceLoader::didCancel):
        * loader/SubresourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 17 May 2011 23:39:57 +0000 (23:39 +0000)]
2011-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86668.
        http://trac.webkit.org/changeset/86668
        https://bugs.webkit.org/show_bug.cgi?id=61001

        It made 52 tests crash on Qt WK2 bot (Requested by Ossy on
        #webkit).

        * UIProcess/API/qt/qgraphicswkview.cpp:
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::createDrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r86717.
bweinstein@apple.com [Tue, 17 May 2011 23:21:39 +0000 (23:21 +0000)]
Build fix after r86717.

* UIProcess/API/C/win/WKView.h: Add a forward declaration of IDropTarget

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Needs API to set a custom drop target
bweinstein@apple.com [Tue, 17 May 2011 23:15:06 +0000 (23:15 +0000)]
WebKit2: Needs API to set a custom drop target
https://bugs.webkit.org/show_bug.cgi?id=60991
<rdar://problem/9090868>

Reviewed by Adam Roben.

Add API to set a custom drop target on a WKView.

* UIProcess/API/C/win/WKView.cpp:
(WKViewSetCustomDropTarget): Call through to WebView::setCustomDropTarget.
* UIProcess/API/C/win/WKView.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::setCustomDropTarget): Revoke the current drop target, and register the
    custom one.
* UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 17 May 2011 23:10:14 +0000 (23:10 +0000)]
2011-05-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        editing/pasteboard/paste-blockquote-2.html and paste-blockquote-3.html should be dump-as-markup tests
        https://bugs.webkit.org/show_bug.cgi?id=60998

        Converted the tests.

        * editing/pasteboard/paste-blockquote-2-expected.txt: Added.
        * editing/pasteboard/paste-blockquote-2.html:
        * editing/pasteboard/paste-blockquote-3-expected.txt: Added.
        * editing/pasteboard/paste-blockquote-3.html:
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-3-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 17 May 2011 23:03:43 +0000 (23:03 +0000)]
2011-05-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        editing/pasteboard/paste-text-012.html should be a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=60996

        Converted the test.

        * editing/pasteboard/paste-text-012-expected.txt: Added.
        * editing/pasteboard/paste-text-012.html:
        * platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-text-012-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/gtk/editing/pasteboard/paste-text-012-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-text-012-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-text-012-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 17 May 2011 22:49:36 +0000 (22:49 +0000)]
2011-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add API to determine if a frame has any form elements without going to javascript
        https://bugs.webkit.org/show_bug.cgi?id=60999

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameContainsAnyFormElements):
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::containsAnyFormElements):
        * WebProcess/WebPage/WebFrame.h:
        Add WKBundleFrameContainsAnyFormElements which does a walk of the document to determine
        if there are any form elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Tue, 17 May 2011 22:34:22 +0000 (22:34 +0000)]
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Always set layerRenderer, even on non-drawn-layers
        https://bugs.webkit.org/show_bug.cgi?id=60977

        This is a defensive fixe for crbug.com/82799, in which
        a RenderLayer could not prepare itself because its owning layerImpl
        had no associated layerRenderer. The underlying issue is that we
        sometimes put renderSurfaces onto the list that won't actually render.
        For now, the priority is to reduce fragility so that invisible layers
        dont lead to crashers. We do this by being more agressive about
        binding CCLayerImpls to the LayerRenderer, doing it all the time rather
        than only when we think it will get rendered.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::paintLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 17 May 2011 22:32:47 +0000 (22:32 +0000)]
2011-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        JSGlobalContextRelease should not trigger a synchronous garbage collection
        https://bugs.webkit.org/show_bug.cgi?id=60990

        * API/JSContextRef.cpp:
        Change synchronous call to collectAllGarbage to a call to trigger the
        activityCallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Tue, 17 May 2011 22:07:53 +0000 (22:07 +0000)]
2011-05-17  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Ryosuke Niwa.

        [chromium] Clipboard policy callbacks from EditorClientImpl are reversed
        https://bugs.webkit.org/show_bug.cgi?id=60994

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::canCopyCut):
        (WebKit::EditorClientImpl::canPaste):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 17 May 2011 22:00:31 +0000 (22:00 +0000)]
2011-05-17  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Csaba Osztrogonac.

        [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot

        Skip on qt-mac

        http://bugs.webkit.org/show_bug.cgi?id=60838

        * platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the clang build.
andersca@apple.com [Tue, 17 May 2011 21:45:07 +0000 (21:45 +0000)]
Fix the clang build.

* rendering/RenderText.h:
(WebCore::RenderText::nodeAtPoint):
nodeAtPoint should take a const IntPoint reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Tue, 17 May 2011 21:33:23 +0000 (21:33 +0000)]
2011-05-17  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ryosuke Niwa.

        document.activeElement doesn't point to the focused frame
        https://bugs.webkit.org/show_bug.cgi?id=49509

        This tests that an iframe is the activeElement when focus is inside that frame.

        * fast/dom/HTMLDocument/active-element-frames-expected.txt: Added.
        * fast/dom/HTMLDocument/active-element-frames.html: Added.
2011-05-17  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ryosuke Niwa.

        document.activeElement doesn't point to the focused frame
        https://bugs.webkit.org/show_bug.cgi?id=49509

        This makes us match IE and Firefox and there is an ongoing WHATWG discussion to make the spec match this.

        Test: fast/dom/HTMLDocument/active-element-frames.html

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::activeElement): Walk up the frame tree from the focusedFrame to find the active frame if any.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-16 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 17 May 2011 20:57:56 +0000 (20:57 +0000)]
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        https://bugs.webkit.org/show_bug.cgi?id=54051

       * platform/qt/Skipped: Unskip plugins/invalidate_rect.html
       * platform/qt-mac/Skipped: Skip plugins/invalidate_rect.html
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        Add ChromeClientQt::allowsAcceleratedCompositing().

        https://bugs.webkit.org/show_bug.cgi?id=54051

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
        * WebCoreSupport/ChromeClientQt.h:
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        - Make the unix test netscape plugin recognize the onPaintEvent
          and windowedPlugin parameters.

        https://bugs.webkit.org/show_bug.cgi?id=54051

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (handleEventX11):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::displayInvalidatedRegion):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance):
        (webkit_test_plugin_handle_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 17 May 2011 20:57:28 +0000 (20:57 +0000)]
2011-05-17  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Change nodeAtPoint to take IntPoint instead of int x, int y
        https://bugs.webkit.org/show_bug.cgi?id=60663

        Change nodeAtPoint to take a single const IntPoint& instead of a pair of
        ints for the location.

        Covered by existing tests.

        * platform/graphics/FloatPoint.h:
        (WebCore::flooredIntPoint):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/EllipsisBox.h:
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::nodeAtPoint):
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::nodeAtPoint):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::nodeAtPoint):
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::hitTestContents):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        * rendering/RenderBox.h:
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::nodeAtPoint):
        * rendering/RenderFrameSet.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::nodeAtPoint):
        * rendering/RenderImage.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::nodeAtPoint):
        * rendering/RenderInline.h:
        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::hitTest):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::nodeAtPoint):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::hitTest):
        (WebCore::RenderObject::nodeAtPoint):
        * rendering/RenderObject.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/RenderTable.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::nodeAtPoint):
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTableSection.h:
        * rendering/RenderText.h:
        (WebCore::RenderText::nodeAtPoint):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/RenderTextControlMultiLine.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::nodeAtPoint):
        * rendering/RenderWidget.h:
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::nodeAtPoint):
        * rendering/RootInlineBox.h:
        * rendering/svg/RenderSVGForeignObject.cpp:
        (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
        (WebCore::RenderSVGForeignObject::nodeAtPoint):
        * rendering/svg/RenderSVGForeignObject.h:
        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::nodeAtPoint):
        * rendering/svg/RenderSVGModelObject.h:
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/svg/RenderSVGRoot.h:
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::nodeAtFloatPoint):
        (WebCore::RenderSVGText::nodeAtPoint):
        * rendering/svg/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-17 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Tue, 17 May 2011 20:39:18 +0000 (20:39 +0000)]
2011-05-17  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86647.
        http://trac.webkit.org/changeset/86647
        https://bugs.webkit.org/show_bug.cgi?id=56814

        Broke tests downstream in Chromium

        * dom/DocumentMarker.h:
        (WebCore::DocumentMarker::operator==):
        (WebCore::DocumentMarker::operator!=):
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::addMarker):
        (WebCore::DocumentMarkerController::copyMarkers):
        (WebCore::DocumentMarkerController::removeMarkers):
        (WebCore::DocumentMarkerController::markerContainingPoint):
        (WebCore::DocumentMarkerController::markersInRange):
        (WebCore::DocumentMarkerController::renderedRectsForMarkers):
        (WebCore::DocumentMarkerController::removeMarkersFromList):
        (WebCore::DocumentMarkerController::repaintMarkers):
        (WebCore::DocumentMarkerController::shiftMarkers):
        (WebCore::DocumentMarkerController::setMarkersActive):
        (WebCore::DocumentMarkerController::hasMarkers):
        (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
        (WebCore::DocumentMarkerController::showMarkers):
        * dom/DocumentMarkerController.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
        * editing/Editor.cpp:
        (WebCore::Editor::selectionStartHasMarkerFor):
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::respondToChangedSelection):
        * editing/SpellingCorrectionController.h:
        (WebCore::SpellingCorrectionController::shouldStartTimerFor):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::spellingToolTip):
        (WebCore::HitTestResult::replacedString):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
2011-05-17  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86647.
        http://trac.webkit.org/changeset/86647
        https://bugs.webkit.org/show_bug.cgi?id=56814

        Broke tests downstream in Chromium

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::addMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86704 268f45cc-cd09-0410-ab3c-d52691b4dbfc