WebKit-https.git
7 years agodocument.execCommand('Indent') in the direct child of ShadowRoot causes a crash.
shinyak@chromium.org [Tue, 15 May 2012 08:24:22 +0000 (08:24 +0000)]
document.execCommand('Indent') in the direct child of ShadowRoot causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=86341

Reviewed by Ryosuke Niwa.

.:

Exports necessary symbols.

* Source/autotools/symbols.filter:

Source/WebCore:

When document.execCommand('Indent') is executed in the direct child of ShadowRoot,
the scope variable of TextIterator becomes ShadowRoot. However, an element is assumed for it,
so a crash happended.

This patch enables TextIterator to have ShadowRoot as a scope variable.

Test: editing/shadow/execcommand-indent-in-shadow.html

* WebCore.exp.in:
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
* editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength):
* editing/TextIterator.h:
(TextIterator):
* editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
(WebCore::visiblePositionForIndex):
* editing/htmlediting.h:
(WebCore):

Source/WebKit/chromium:

* src/WebRange.cpp:
(WebKit::WebRange::fromDocumentRange):

Source/WebKit2:

Exports necessary symbols.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* editing/shadow/execcommand-indent-in-shadow-expected.txt: Added.
* editing/shadow/execcommand-indent-in-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] 6 SVG tests assert after r107207
kkristof@inf.u-szeged.hu [Tue, 15 May 2012 08:15:09 +0000 (08:15 +0000)]
[Qt] 6 SVG tests assert after r107207
https://bugs.webkit.org/show_bug.cgi?id=78332

Reviewed by Csaba Osztrogonác.

Unskip these tests because they don't assert now.

* platform/qt/Skipped:
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip one more crashing/asserting test.
ossy@webkit.org [Tue, 15 May 2012 07:59:01 +0000 (07:59 +0000)]
[Qt] Unreviewed gardening, skip one more crashing/asserting test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update test expectations.
commit-queue@webkit.org [Tue, 15 May 2012 07:42:28 +0000 (07:42 +0000)]
[EFL] Update test expectations.

Unreviewed EFL gardening, add 2 failing tests to
test_expectations.txt and remove 1 test that no longer exists.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-15

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 15 May 2012 07:13:40 +0000 (07:13 +0000)]
2012-05-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Renegerate three pixel test results on Lion, so that the svg/ pixel tests pass with tolerance 0 again.

        * platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
        * platform/mac/svg/hixie/mixed/003-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNode::shadowTreeRootNode() should return ShadowRoot instead of Node.
shinyak@chromium.org [Tue, 15 May 2012 07:11:59 +0000 (07:11 +0000)]
Node::shadowTreeRootNode() should return ShadowRoot instead of Node.
https://bugs.webkit.org/show_bug.cgi?id=86428

Reviewed by Hajime Morita.

Source/WebCore:

Since Node::shadowTreeRootNode() returns only ShadowRoot or 0 now, its return type should be ShadowRoot.
This patch changes the return type and adds include directive to build.

No new tests, no change in behavior.

* dom/Node.cpp:
(WebCore::Node::shadowAncestorNode):
(WebCore::Node::shadowTreeRootNode):
* dom/Node.h:
(WebCore):
(Node):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/Range.cpp:
(WebCore::Range::shadowTreeRootNode):
* dom/Range.h:
(Range):
* editing/Editor.cpp:
* editing/TextIterator.cpp:
* editing/htmlediting.cpp:
* html/shadow/ContentSelectorQuery.cpp:
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::detach):
* page/EventHandler.cpp:

Source/WebKit/chromium:

Adds include directive to build.

* src/WebFrameImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContent Security Policy console error messages should include the violated directive.
commit-queue@webkit.org [Tue, 15 May 2012 07:04:00 +0000 (07:04 +0000)]
Content Security Policy console error messages should include the violated directive.
https://bugs.webkit.org/show_bug.cgi?id=86323

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-15
Reviewed by Adam Barth.

Update global expectations for 1 Content Security Policy test after r117006.

* http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake StyleResolver::applyMatchedProperties and ::applyProperties use enum template...
macpherson@chromium.org [Tue, 15 May 2012 06:36:25 +0000 (06:36 +0000)]
Make StyleResolver::applyMatchedProperties and ::applyProperties use enum template parameter instead of bool.
https://bugs.webkit.org/show_bug.cgi?id=86424

Reviewed by Dimitri Glazkov.

This patch changes from using a boolean template parameter for StyleResolver::applyMatchedProperties and
StyleResolver::applyProperties functions. The motivation for this change is that it paves the way for
CSS Variables to make the value tri-state, which is a requirement because variable definitions must occur
before high priority CSS properties such that they can be referenced by the latter. This change affects
only the type signatures of those functions, and not their behavior.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Get rid of ContentDistribution::Item
morrita@google.com [Tue, 15 May 2012 06:30:25 +0000 (06:30 +0000)]
[Refactoring] Get rid of ContentDistribution::Item
https://bugs.webkit.org/show_bug.cgi?id=86350

This change replaces the linked list on ContentDistribution with a Vector.
We no longer link item class ContentDistribution::Item.
This simplification also allows ContentDistribution to go.
ContentDistribution is now just a typedef of Vector<RefPtr<Node> >.

Reviewed by Dimitri Glazkov.

No new tests. Covered by existing tests.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
(ElementShadow):
* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findInsertionPointFor):
* html/shadow/ContentDistributor.h:
(WebCore):
(ContentDistributor):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::nextTo):
(WebCore):
(WebCore::InsertionPoint::previousTo):
* html/shadow/InsertionPoint.h: Added a set of delegate method to m_distribution.
(WebCore::InsertionPoint::hasDistribution):
(WebCore::InsertionPoint::indexOf):
(WebCore::InsertionPoint::size):
(WebCore::InsertionPoint::at):
(WebCore::InsertionPoint::first):
(WebCore::InsertionPoint::last):
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of compo...
timothy_horton@apple.com [Tue, 15 May 2012 06:12:05 +0000 (06:12 +0000)]
RenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of composited descendants
https://bugs.webkit.org/show_bug.cgi?id=86429
<rdar://problem/11445132>

Reviewed by Simon Fraser.

Change repaintRectIncludingDescendants to not include repaint rects for composited child layers,
and rename the function to make it more clear that that's what it does now.

No new tests, scrolling performance optimization.

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
* rendering/RenderLayer.h:
(RenderLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed morning gardening to paint the Qt bots green.
ossy@webkit.org [Tue, 15 May 2012 05:55:57 +0000 (05:55 +0000)]
[Qt] Unreviewed morning gardening to paint the Qt bots green.

* http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Updated after r117006.
* platform/qt/Skipped: Skip new failing/crashing tests.
* platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Updated after r117006.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update test expectations.
tkent@chromium.org [Tue, 15 May 2012 05:08:34 +0000 (05:08 +0000)]
[Chromium] Update test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Prerenderer, PrerenderHandle and a chromium interface for Prerendering.
gavinp@chromium.org [Tue, 15 May 2012 04:42:52 +0000 (04:42 +0000)]
Add Prerenderer, PrerenderHandle and a chromium interface for Prerendering.
https://bugs.webkit.org/show_bug.cgi?id=85005

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebPrerender.h:
(WebKit::WebPrerender::referrer):
(WebCore):
(WebPrerender):
* chromium/public/WebPrerenderingSupport.h:
(WebKit):
(WebPrerenderingSupport):
* chromium/public/WebURLRequest.h:
* chromium/src/WebPrerenderingSupport.cpp: Added.
(WebKit):
(WebKit::WebPrerenderingSupport::initialize):
(WebKit::WebPrerenderingSupport::shutdown):
(WebKit::WebPrerenderingSupport::current):

Source/WebCore:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

No new tests, as this interface requires a full platform to work, and doesn't affect layout.  Test
it with your platform when implemented for it.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::prerenderer):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::removedFrom):
* html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
* html/LinkRelAttribute.h:
(LinkRelAttribute):
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
(WebCore::LinkLoader::released):
* loader/LinkLoader.h:
(WebCore):
(LinkLoader):
* loader/Prerenderer.cpp: Added.
(WebCore):
(WebCore::Prerenderer::create):
(WebCore::Prerenderer::Prerenderer):
(WebCore::Prerenderer::~Prerenderer):
(WebCore::Prerenderer::render):
(WebCore::Prerenderer::stop):
(WebCore::Prerenderer::suspend):
(WebCore::Prerenderer::resume):
(WebCore::Prerenderer::document):
(WebCore::Prerenderer::client):
* loader/Prerenderer.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(Prerenderer):
* loader/PrerendererClient.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(WebCore::PrerendererClient::supplementName):
(WebCore::PrerendererClient::from):
(WebCore::providePrerendererClientTo):
* loader/PrerendererClient.h: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(PrerendererClient):
(WebCore::PrerendererClient::~PrerendererClient):
(WebCore::PrerendererClient::PrerendererClient):
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::load):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::ignoreForRequestCount):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
* platform/PrerenderHandle.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(PrerenderHandle):
* platform/chromium/Prerender.cpp: Added.
(WebCore):
(WebCore::Prerender::Prerender):
(WebCore::Prerender::~Prerender):
(WebCore::Prerender::setState):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
(WebCore::Prerender::suspend):
(WebCore::Prerender::resume):
* platform/chromium/Prerender.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(Prerender):
(ExtraData):
(WebCore::Prerender::ExtraData::~ExtraData):
(WebCore::Prerender::url):
(WebCore::Prerender::referrer):
(WebCore::Prerender::referrerPolicy):
(WebCore::Prerender::setExtraData):
(WebCore::Prerender::extraData):
* platform/chromium/PrerenderHandle.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(WebCore::PrerenderHandle::create):
(WebCore::PrerenderHandle::PrerenderHandle):
(WebCore::PrerenderHandle::~PrerenderHandle):
(WebCore::PrerenderHandle::prerender):
(WebCore::PrerenderHandle::add):
(WebCore::PrerenderHandle::cancel):
(WebCore::PrerenderHandle::abandon):
(WebCore::PrerenderHandle::suspend):
(WebCore::PrerenderHandle::resume):
(WebCore::PrerenderHandle::url):
(WebCore::PrerenderHandle::referrer):
(WebCore::PrerenderHandle::referrerPolicy):
* platform/chromium/support/WebPrerender.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebKit::WebPrerender::WebPrerender):
(WebKit):
(WebKit::WebPrerender::~WebPrerender):
(WebKit::WebPrerender::url):
(WebKit::WebPrerender::referrer):
(WebKit::WebPrerender::referrerPolicy):
(WebKit::WebPrerender::setExtraData):
(WebKit::WebPrerender::extraData):
* platform/network/blackberry/ResourceRequest.h:
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::platformTargetTypeForRequest):
* platform/network/chromium/ResourceRequest.h:

Source/WebKit/chromium:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

* WebKit.gyp:
* public/WebView.h:
* src/PrerendererClientImpl.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebKit):
(WebKit::PrerendererClientImpl::PrerendererClientImpl):
(WebKit::PrerendererClientImpl::willAddPrerender):
* src/PrerendererClientImpl.h: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(WebKit):
(PrerendererClientImpl):
* src/WebKit.cpp:
(WebKit::shutdown):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPrerendererClient):
(WebKit):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):

LayoutTests:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

These tests are being removed, and expectations updated, because the old phantom-load
prerendering interface was susceptible to layout testing, and the new interface requires
a full platform to test, so it can't really be a layout test.

* fast/dom/HTMLLinkElement/prerender-expected.txt: Removed.
* fast/dom/HTMLLinkElement/prerender.html: Removed.
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce ENABLE_CSS_VARIABLES compile flag.
macpherson@chromium.org [Tue, 15 May 2012 04:39:07 +0000 (04:39 +0000)]
Introduce ENABLE_CSS_VARIABLES compile flag.
https://bugs.webkit.org/show_bug.cgi?id=86338

Reviewed by Dimitri Glazkov.

Add a configuration option for CSS Variables support, disabling it by default.

.:

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. This patch only introduces an unused build flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._missing_symbol_to_skipped_tests):
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd WTF_USE_APPKIT to differentiate platforms that use AppKit.framework from other...
aestes@apple.com [Tue, 15 May 2012 04:36:26 +0000 (04:36 +0000)]
Add WTF_USE_APPKIT to differentiate platforms that use AppKit.framework from other Darwin platforms
https://bugs.webkit.org/show_bug.cgi?id=86432

Reviewed by Maciej Stachowiak.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStyles are not recalculated when the seamless attribute is dynamically added/removed
eric@webkit.org [Tue, 15 May 2012 04:36:22 +0000 (04:36 +0000)]
Styles are not recalculated when the seamless attribute is dynamically added/removed
https://bugs.webkit.org/show_bug.cgi?id=86315

Reviewed by Andreas Kling.

Source/WebCore:

Covered by fast/frames/seamless/seamless-css-cascade.html.

* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::isPresentationAttribute):
 - Make seamless a presentational attribute, which means style on the <iframe> will
   be forced to recalculate when it changes.  This is correct, but not observable
   until the layout changes are landed (as then the iframe should correctly revert to not
   being sized to fit its content if seamless is removed).
(WebCore::HTMLIFrameElement::parseAttribute):
 - When the seamless attribute is added or remove, force the content document to recalc
   its style resolver, which will refresh the list of inherited stylesheets from the
   parent.  This doesn't need to happen synchronously.  When the layout changes land
   the content document will actually cause that recalc to redirect to the parent document
   in the seamless case anyway, but it's more correct to ask the content document directly.

LayoutTests:

Add a subtest to cover this case.

* fast/frames/seamless/seamless-css-cascade-expected.txt:
* fast/frames/seamless/seamless-css-cascade.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCannot login to iCloud
barraclough@apple.com [Tue, 15 May 2012 03:43:54 +0000 (03:43 +0000)]
Cannot login to iCloud
https://bugs.webkit.org/show_bug.cgi?id=86321

Reviewed by Filip Pizlo.

This is a bug introduced by bug#85853, we shouldn't allow assignment to
the prototype property of functions to be cached, since we need to clear
the cached inheritorID.

* runtime/JSFunction.cpp:
(JSC::JSFunction::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update text expectations.
tkent@chromium.org [Tue, 15 May 2012 03:42:19 +0000 (03:42 +0000)]
[Chromium] Update text expectations.

* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
* platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Removed.
* platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] remove skia/third_party/glu from DEPS
gavinp@chromium.org [Tue, 15 May 2012 03:26:48 +0000 (03:26 +0000)]
[Chromium] remove skia/third_party/glu from DEPS
https://bugs.webkit.org/show_bug.cgi?id=86431

Chromium rev 136872 removed skia/third_party/glu, but nobody updated it in WebKit.  This
patch fixes that.

Unreviewed, remove bad Chromium repo.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
abarth@webkit.org [Tue, 15 May 2012 01:10:52 +0000 (01:10 +0000)]
[chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
https://bugs.webkit.org/show_bug.cgi?id=86415

Patch by Alexandre Elias <aelias@google.com> on 2012-05-14
Reviewed by Adam Barth.

The new enum values added in this file have been added in recent
versions of the NDK, so this file will fail to compile with duplicate
enum error when we roll NDK to r7c or higher.  A workaround is
to move our enum values to the WebCore namespace.  When the NDK
upgrade is complete, we can delete them.

No new tests. (No-op change.)

* platform/chromium/KeyCodeConversionAndroid.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=86420
bdakin@apple.com [Tue, 15 May 2012 01:06:42 +0000 (01:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86420
ScrollbarPainter should support expansionTransitionProgress

Reviewed by Sam Weinig.

expansionTransitionProgress works the same as
uiStateTransitionProgress. This code just echoes that code, but for
expansion instead of uiState.
* platform/mac/NSScrollerImpDetails.h:
* platform/mac/ScrollAnimatorMac.mm:
(supportsExpansionTransitionProgress):
(-[WebScrollbarPartAnimation setCurrentProgress:]):
(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate invalidate]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: Unreviewed, roll Chromium DEPS to r136942.
dpranke@chromium.org [Tue, 15 May 2012 00:22:21 +0000 (00:22 +0000)]
Source/WebKit/chromium: Unreviewed, roll Chromium DEPS to r136942.

LayoutTests: fast/loader/javascript-url-in-embed.html is failing after r115646
https://bugs.webkit.org/show_bug.cgi?id=86414

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix RunLoopCF.cpp's copyright string.
aestes@apple.com [Tue, 15 May 2012 00:11:23 +0000 (00:11 +0000)]
Fix RunLoopCF.cpp's copyright string.

* platform/cf/RunLoopCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
aestes@apple.com [Tue, 15 May 2012 00:05:12 +0000 (00:05 +0000)]
Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
https://bugs.webkit.org/show_bug.cgi?id=86411

Reviewed by Anders Carlsson.

Most of RunLoopMac.mm was written in terms of CF API. Move these bits
to a new file called RunLoopCF.cpp, leaving only the bits dealing with
NSApplication.

* WebCore.xcodeproj/project.pbxproj: Xcode decided to give
VisitedLinks.* new UUIDs. I'll allow it.
* platform/cf/RunLoopCF.cpp: Copied from Source/WebCore/platform/mac/RunLoopMac.mm.
* platform/mac/RunLoopMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add "stack" property to DOMException
arv@chromium.org [Mon, 14 May 2012 23:54:49 +0000 (23:54 +0000)]
[V8] Add "stack" property to DOMException
https://bugs.webkit.org/show_bug.cgi?id=85057

Reviewed by Kentaro Hara.

When we create a DOM exception we define a V8 accessor for the stack property. This
accessor uses a new Error object to get the underlying stack string.

Source/WebCore:

Test: fast/dom/DOMException/stack-trace.html

* bindings/v8/V8Proxy.cpp:
(WebCore::DOMExceptionStackGetter):
(WebCore):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8Proxy::setDOMException):

LayoutTests:

* fast/dom/DOMException/stack-trace-expected.txt: Added.
* fast/dom/DOMException/stack-trace.html: Added.
* platform/chromium/fast/dom/DOMException/stack-trace-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnh: Add the Ability to Disable / Enable JavaScript GC Timer
msaboff@apple.com [Mon, 14 May 2012 23:47:53 +0000 (23:47 +0000)]
Enh: Add the Ability to Disable / Enable JavaScript GC Timer
https://bugs.webkit.org/show_bug.cgi?id=86382

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add flag to GCActivityCallback to enable / disable activity timer.
Add api via Heap to set the flag's value.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Windows export
* heap/Heap.cpp:
(JSC::Heap::setGarbageCollectionTimerEnabled):
* heap/Heap.h:
* runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::isEnabled):
(JSC::GCActivityCallback::setEnabled):
(JSC::GCActivityCallback::GCActivityCallback):
* runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):

Source/WebCore:

Plumbing to set / clear JS GC activity timer enable flag.

* WebCore.exp.in:
* bindings/js/GCController.cpp:
(WebCore::GCController::setJavaScriptGarbageCollectorTimerEnabled):
* bindings/js/GCController.h:

Source/WebKit/mac:

Plumbing to set / clear JS GC activity timer enable flag.

* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]):

Source/WebKit2:

Plumbing to set / clear JS GC activity timer enable flag.

* UIProcess/API/C/WKContext.cpp:
(WKContextSetJavaScriptGarbageCollectorTimerEnabled):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setJavaScriptGarbageCollectorTimerEnabled):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setJavaScriptGarbageCollectorTimerEnabled):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/replaced/width100percent-searchfield is still failing on chromium leopard/snowle...
dpranke@chromium.org [Mon, 14 May 2012 23:47:22 +0000 (23:47 +0000)]
fast/replaced/width100percent-searchfield is still failing on chromium leopard/snowleopard
https://bugs.webkit.org/show_bug.cgi?id=86412

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncrease Debug Logging in MarkStack::validate()
msaboff@apple.com [Mon, 14 May 2012 23:45:45 +0000 (23:45 +0000)]
Increase Debug Logging in MarkStack::validate()
https://bugs.webkit.org/show_bug.cgi?id=86408

Rubber-stamped by Filip Pizlo.

Added some descriptive debug messages for the conditions and
values when a cell validation fails.

* heap/MarkStack.cpp:
(JSC::MarkStack::validate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [V8] Crash in npObjectGetProperty() in V8NPObject.cpp
japhet@chromium.org [Mon, 14 May 2012 23:37:39 +0000 (23:37 +0000)]
Source/WebCore: [V8] Crash in npObjectGetProperty() in V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=86131

Reviewed by Adam Barth.

Tests: plugins/npruntime/delete-plugin-within-getProperty.html
       plugins/npruntime/delete-plugin-within-hasProperty-return-false.html
       plugins/npruntime/delete-plugin-within-hasProperty-return-true.html
       plugins/npruntime/delete-plugin-within-invoke.html
       plugins/npruntime/delete-plugin-within-setProperty.html

* bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):
* bindings/v8/V8NPObject.cpp: Check NPN_IsAlive in a bunch of places we're not currently.
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):

Tools: Add end-of-life test cases for https://bugs.webkit.org/show_bug.cgi?id=86131.

Reviewed by Adam Barth.

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(callDeletePlugin):
(pluginHasProperty):
(pluginHasMethod):
(pluginGetProperty):
(pluginSetProperty):
(pluginInvoke):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=86131.

Reviewed by Adam Barth.

* plugins/npruntime/delete-plugin-within-getProperty-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-getProperty.html: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-false-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-false.html: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-true-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-true.html: Added.
* plugins/npruntime/delete-plugin-within-invoke-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-invoke.html: Added.
* plugins/npruntime/delete-plugin-within-setProperty-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-setProperty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build correction.
bfulgham@webkit.org [Mon, 14 May 2012 23:19:09 +0000 (23:19 +0000)]
[WinCairo] Unreviewed build correction.

* platform/win/DragImageCairoWin.cpp: Add missing include for
new NativeImageCairo.h type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRe-enable "drt mode" on chromium-mac-leopard
dpranke@chromium.org [Mon, 14 May 2012 23:19:04 +0000 (23:19 +0000)]
Re-enable "drt mode" on chromium-mac-leopard
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix (change?).

This change is another attempt to gather data on
the flakiness and timeouts we're seeing on Mac SL
now that we have another bot.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline http/tests/misc/will-send-request-returns-null-on-redirect on chromium.
dpranke@chromium.org [Mon, 14 May 2012 23:11:46 +0000 (23:11 +0000)]
Rebaseline http/tests/misc/will-send-request-returns-null-on-redirect on chromium.

https://bugs.webkit.org/show_bug.cgi?id=60121

Unreviewed, baselines change.

* platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<http://webkit.org/b/86320> WTF.xcodeproj builds with -O3 in debug builds
mrowe@apple.com [Mon, 14 May 2012 23:02:20 +0000 (23:02 +0000)]
<webkit.org/b/86320> WTF.xcodeproj builds with -O3 in debug builds

Reviewed by Simon Fraser.

* WTF.xcodeproj/project.pbxproj: Ensure that the debug configuration uses the
same settings as the debug variant would.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::RenderObject::repaint
commit-queue@webkit.org [Mon, 14 May 2012 22:36:03 +0000 (22:36 +0000)]
Crash in WebCore::RenderObject::repaint
https://bugs.webkit.org/show_bug.cgi?id=86162

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-14
Reviewed by Abhishek Arya.

Source/WebCore:

As RenderScrollbarPart has no parent renderer, we crash in
WebCore::RenderBoxModelObject::paddingLeft when paddingLeft has
percent value, e.g. 5%. However if we set the scrollbar's parent
renderer to a renderer owning the scrollbar by using setParent method,
RenderScrollbarPart::styleWillChange will invoke parent renderer's
repaint. This causes crash in WebCore::RenderObject::repaint if the
owning renderer is already destroyed.
To fix the first crash without the second crash, modify
RenderObject::containingBlock() to check isRenderScrollbarPart or not,
if parent() is 0.
If so, use scrollbar's owningRenderer from RenderScrollbarPart.

Test: scrollbars/scrollbar-percent-padding-crash.html
      scrollbars/scrollbar-scrollbarparts-repaint-crash.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
Modifying containingBlock. If parent() is 0 and isRenderScrollbarPart()
is true, use RenderScrollbarPart's m_scrollbar->owningRenderer()
instead of parent().
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderScrollbarPart):
(RenderObject):
Adding a new method, isRenderScrollbarPart.
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::rendererOwningScrollbar):
(WebCore):
Adding a new method, scrollbarOwningRenderer to obtain m_scrollar's
owningRenderer.
* rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
Removing "friend class RenderScrollbar".
(WebCore::RenderScrollbarPart::isRenderScrollbarPart):
(WebCore::toRenderScrollbarPart):
(WebCore):
Implementing isRenderScrollbarPart and toRenderScrollbarPart.

LayoutTests:

* scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt: Added.
* scrollbars/scrollbar-scrollbarparts-repaint-crash.html: Added.
* scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
* scrollbars/scrollbar-percent-padding-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContent Security Policy console errors include violated directive.
commit-queue@webkit.org [Mon, 14 May 2012 21:53:58 +0000 (21:53 +0000)]
Content Security Policy console errors include violated directive.
https://bugs.webkit.org/show_bug.cgi?id=86323

Source/WebCore:

Patch by Mike West <mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.

Console errors generated when resources, inline script/style, or eval
are blocked by Content Security Policy directives should include the
text of the directive that's been violated. This gives developers more
of the information they need to resolve the issue.

Test: http/tests/security/contentSecurityPolicy/*

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):

LayoutTests:

Sharded http/tests/security/contentSecurityPolicy/source-list-parsing.html
into four tests, and reworked it to have a well-defined order.

Patch by Mike West <mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.

* http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
* http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt:
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
* http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
* http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
* http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Removed
* http/tests/security/contentSecurityPolicy/source-list-parsing.html: Removed
* http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-01.html: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-02.html: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-03.html: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-04-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-04.html: Added
* http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt:
* http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
* media/csp-blocks-video-expected.txt:
* platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in FrameView::windowClipRectForFrameOwner after r116371
jchaffraix@webkit.org [Mon, 14 May 2012 21:50:42 +0000 (21:50 +0000)]
Crash in FrameView::windowClipRectForFrameOwner after r116371
https://bugs.webkit.org/show_bug.cgi?id=86035

Reviewed by David Hyatt.

Added a NULL-check for |parentView| as nothing guarantees it to be
non-NULL. Unfortunately no test as this is a crasher I couldn't
reproduce on my machine and the user logs were not helpful.

* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=86403
bdakin@apple.com [Mon, 14 May 2012 21:47:48 +0000 (21:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86403
ASSERTION FAILED: m_verticalScrollbarPainterDelegate on recent builds
-and corresponding-
<rdar://problem/11448841>

Reviewed by Simon Fraser.

http://trac.webkit.org/changeset/116476 accidentally started calling
these functions for custom scrollbars. This change replaces that
guard.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::destroyScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116981.
commit-queue@webkit.org [Mon, 14 May 2012 21:28:37 +0000 (21:28 +0000)]
Unreviewed, rolling out r116981.
http://trac.webkit.org/changeset/116981
https://bugs.webkit.org/show_bug.cgi?id=86402

Caused compositing and mathml tests to fail. (Requested by
rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix regressions in garden-o-matic after r116988.
dpranke@chromium.org [Mon, 14 May 2012 21:25:09 +0000 (21:25 +0000)]
Fix regressions in garden-o-matic after r116988.

Unreviewed, build fix.

I had a typo in a field name in checkout.js, and unfortunately
the unittests had the same typo :(.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert CSS and Parser tests to runs/s tests
rniwa@webkit.org [Mon, 14 May 2012 21:19:51 +0000 (21:19 +0000)]
Convert CSS and Parser tests to runs/s tests
https://bugs.webkit.org/show_bug.cgi?id=86399

Reviewed by Ojan Vafai.

Use runPerSecond instead of run to measure results in function calls per second (run/s) instead of time (ms).
This allows us to continue measuring performance reliably even when WebKit's performance improves and results
become too small for Date.now()'s precision (around 15 ms).

It should also reduce perf. bots cycle time for slower tests because we limit the number of function calls by time.

* CSS/CSSPropertySetterGetter.html:
* CSS/CSSPropertyUpdateValue.html:
* Parser/css-parser-yui.html:
* Parser/simple-url.html:
* Parser/tiny-innerHTML.html:
* Parser/url-parser.html:
* Parser/xml-parser.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant pixel snapping in calculateCompositedBounds()
simon.fraser@apple.com [Mon, 14 May 2012 21:12:38 +0000 (21:12 +0000)]
Remove redundant pixel snapping in calculateCompositedBounds()
https://bugs.webkit.org/show_bug.cgi?id=86400

Reviewed by Sam Weinig.

RenderLayer::calculateLayerBounds() returns a pixel-snapped rect,
so we don't need to pixel-snap it again.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Layout Test svg/carto.net/window.svg is failing
schenney@chromium.org [Mon, 14 May 2012 21:10:02 +0000 (21:10 +0000)]
[chromium] Layout Test svg/carto.net/window.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=84810

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/carto.net/window-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
* platform/chromium-mac/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/carto.net/window-expected.txt: Removed.
* platform/gtk/svg/carto.net/window-expected.txt: Removed.
* svg/carto.net/window-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
abarth@webkit.org [Mon, 14 May 2012 21:04:10 +0000 (21:04 +0000)]
[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
https://bugs.webkit.org/show_bug.cgi?id=86270

Reviewed by Eric Seidel.

* public/android/WebInputEventFactory.h:
* src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::keyboardEvent):
(WebKit::WebInputEventFactory::mouseEvent):
(WebKit):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid logging related to setting shadow-related properties on a transform-only layer
simon.fraser@apple.com [Mon, 14 May 2012 20:58:39 +0000 (20:58 +0000)]
Avoid logging related to setting shadow-related properties on a transform-only layer
https://bugs.webkit.org/show_bug.cgi?id=86398

Reviewed by Dan Bernstein.

When making a CATransformLayer to support transform-style: preserve-3d, avoid trying
to set filters on the transform layer. We should never have this combination,
because filters force flattening to occur.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116983.
commit-queue@webkit.org [Mon, 14 May 2012 20:52:05 +0000 (20:52 +0000)]
Unreviewed, rolling out r116983.
http://trac.webkit.org/changeset/116983
https://bugs.webkit.org/show_bug.cgi?id=86397

Does not compile on chromium-win (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

Source/WebCore:

* WebCore.gypi:
* page/TouchAdjustment.cpp:

Source/WebKit/chromium:

* features.gypi:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe "plug-in was blocked" callback needs to include enough info to uniquely identify...
andersca@apple.com [Mon, 14 May 2012 20:49:54 +0000 (20:49 +0000)]
The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version
https://bugs.webkit.org/show_bug.cgi?id=86395
<rdar://problem/11447652>

Reviewed by John Sullivan.

Add the plug-in identifier and version string to the didFail client callback.

* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
Pass a null plug-in identifier and version here since we don't have the plug-in information here.

(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] Nothing should be stroked when the stroke-width is 0
schenney@chromium.org [Mon, 14 May 2012 20:48:43 +0000 (20:48 +0000)]
[SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png:
* platform/chromium-mac/svg/custom/js-update-style-expected.png:
* platform/chromium-mac/svg/custom/path-zero-strokewidth-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/custom/js-update-style-expected.png:
* platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added more detail to marked test failure for chromium.
jianli@chromium.org [Mon, 14 May 2012 20:39:46 +0000 (20:39 +0000)]
Unreviewed. Added more detail to marked test failure for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo in expectations file causing lint to fail.
dpranke@chromium.org [Mon, 14 May 2012 20:20:49 +0000 (20:20 +0000)]
Fix typo in expectations file causing lint to fail.

Unreviewed, build fix.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a line layout performance test
mitz@apple.com [Mon, 14 May 2012 20:16:32 +0000 (20:16 +0000)]
Add a line layout performance test
https://bugs.webkit.org/show_bug.cgi?id=86216

Reviewed by Ryosuke Niwa.

* Layout/line-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogarden-o-matic should specify which types of baselines to rebaseline
dpranke@chromium.org [Mon, 14 May 2012 20:11:23 +0000 (20:11 +0000)]
garden-o-matic should specify which types of baselines to rebaseline
https://bugs.webkit.org/show_bug.cgi?id=86242

Reviewed by Adam Barth.

This change modifies garden-o-matic so that we are explicit
about whether to rebaseline the text file, the image file, or
both. This should prevent us from pulling incorrect or
unexpected baselines off the bots.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
(.):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.__init__):
(RebaselineTest):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
(OptimizeBaselines):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
(RebaselineExpectations._rebaseline_port):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline):
(GardeningServerTest.test_rebaseline_new_port):
(GardeningServerTest.test_optimizebaselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing www.thestar...
commit-queue@webkit.org [Mon, 14 May 2012 20:09:41 +0000 (20:09 +0000)]
[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing thestar.com/iphone
https://bugs.webkit.org/show_bug.cgi?id=86391

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-05-14
Reviewed by Adam Treat.

PR 156992
Request layout first if needed before painting contents.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPagination splits lines that could fit on a single page if it were not for their...
mitz@apple.com [Mon, 14 May 2012 20:04:37 +0000 (20:04 +0000)]
Pagination splits lines that could fit on a single page if it were not for their top leading
https://bugs.webkit.org/show_bug.cgi?id=86388

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/split-in-top-margin.html

When a line’s visible content fits on a page, but adding the top leading makes it taller than
a page, instead of giving up and splitting the line in an arbitrary position, add a strut
to push it downwards so that the split occurs in the top leading, and the visible content is
fully contained on a single page.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):

LayoutTests:

* fast/multicol/split-in-top-margin-expected.html: Added.
* fast/multicol/split-in-top-margin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
jsbell@chromium.org [Mon, 14 May 2012 19:52:16 +0000 (19:52 +0000)]
Unreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
the specific test (storage/indexeddb/noblobs.html) was fixed in r116337.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't append log lines while perf tests are running.
tony@chromium.org [Mon, 14 May 2012 19:28:47 +0000 (19:28 +0000)]
Don't append log lines while perf tests are running.
https://bugs.webkit.org/show_bug.cgi?id=86028

Reviewed by Ryosuke Niwa.

In some tests, the extra DOM nodes can cause the test timing to change.
Avoid adding DOM nodes until the test is over. When running in a browser,
we append nodes as we run so the user can have some feedback.

* resources/runner.js:
(PerfTestRunner.log): Store the log lines in an array until the test is finished.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Compute the best target node on a GestureTap event
commit-queue@webkit.org [Mon, 14 May 2012 19:24:16 +0000 (19:24 +0000)]
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-14
Reviewed by Adam Barth.

Source/WebCore:

Using tests in the touchadjustment/ directory.

* WebCore.gypi:
Include TouchAdjustment.* files.
* page/TouchAdjustment.cpp:
Included math.h because of an 'Undeclared identifier: INFINITY' when
this patch was landed before.

Source/WebKit/chromium:

* features.gypi:
Enable the touch adjustment code by default.
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

* platform/chromium/test_expectations.txt:
The flaky tests in touchadjustment/ have been addressed in WK86218.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Fix WebCore library path
commit-queue@webkit.org [Mon, 14 May 2012 19:14:03 +0000 (19:14 +0000)]
[EFL][DRT] Fix WebCore library path
https://bugs.webkit.org/show_bug.cgi?id=86355

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-14
Reviewed by Dirk Pranke.

Currently EFL DRT uses wrong WebCore library path when running DRT.
This patch simply adjusted it.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Mark one test as failed on chromium.
jianli@chromium.org [Mon, 14 May 2012 19:12:24 +0000 (19:12 +0000)]
Unreviewed. Mark one test as failed on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add compositor debug asserts for blocked main thread
enne@google.com [Mon, 14 May 2012 19:10:19 +0000 (19:10 +0000)]
[chromium] Add compositor debug asserts for blocked main thread
https://bugs.webkit.org/show_bug.cgi?id=86384

Reviewed by James Robinson.

Source/WebCore:

Where we depend for thread-safety that the main thread is blocked,
assert that this is actually the case.

* platform/graphics/chromium/cc/CCProxy.cpp:
(WebCore):
(WebCore::CCProxy::isMainThreadBlocked):
(WebCore::CCProxy::setMainThreadBlocked):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
(WebCore):
(DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::~DebugScopedSetMainThreadBlocked):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::stop):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrame):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):

Source/WebKit/chromium:

For tests that are just on the impl tree, pretend that the main thread
is always blocked.

* tests/CCLayerTreeHostImplTest.cpp:
(CCLayerTreeHostImplTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPatch by Swapna P <spottabathini@innominds.com> on 2012-05-14
commit-queue@webkit.org [Mon, 14 May 2012 19:06:54 +0000 (19:06 +0000)]
Patch by Swapna P <spottabathini@innominds.com> on 2012-05-14
Reviewed by Eric Seidel.

Bug: Cannot resize frames because frameborder=0
https://bugs.webkit.org/show_bug.cgi?id=23750

Source/WebCore:

Removed check for frameborder, in order to allow resize of frames even in case of frameborder=0.

Test: fast/frames/frames-with-frameborder-zero-can-be-resized.html

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::startResizing):
(WebCore::RenderFrameSet::canResizeRow):
(WebCore::RenderFrameSet::canResizeColumn):

LayoutTests:

Added test case to test whether the frame can be resized when frameborder=0.

* fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
* fast/frames/frames-with-frameborder-zero-can-be-resized.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore gardening after r115846.
jchaffraix@webkit.org [Mon, 14 May 2012 19:03:42 +0000 (19:03 +0000)]
More gardening after r115846.

The rebaselining was partially done. Removed the expected TEXT failures from our Mac bots
and rebaselined more platforms.

* platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Removed.
* platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Removed.
* platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
* platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-linux/fast/forms/input-value-expected.txt:
* platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Added.
* platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix. Don't adjust calls per iteration in the second run.
rniwa@webkit.org [Mon, 14 May 2012 18:59:03 +0000 (18:59 +0000)]
Build fix. Don't adjust calls per iteration in the second run.

* resources/runner.js:
(PerfTestRunner._perSecondRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
commit-queue@webkit.org [Mon, 14 May 2012 18:57:34 +0000 (18:57 +0000)]
Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=86319

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-14
Reviewed by Darin Adler.

Source/WebCore:

Most of RenderMathMLSquareRoot.cpp is duplicated in RenderMathMLRoot.cpp and can be
eliminated. We also define RenderMathMLRoot::computePreferredLogicalWidths().

Test: mathml/presentation/mroot-pref-width.html

* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
* rendering/mathml/RenderMathMLRoot.h:
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
(WebCore::RenderMathMLSquareRoot::addChild):
* rendering/mathml/RenderMathMLSquareRoot.h:

LayoutTests:

* mathml/presentation/mroot-pref-width.html: Added.
* platform/mac/mathml/presentation/mroot-pref-width-expected.png: Added.
* platform/mac/mathml/presentation/mroot-pref-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow DOM][Refactoring] HTMLContentSelector family should have better name
morrita@google.com [Mon, 14 May 2012 18:54:22 +0000 (18:54 +0000)]
[Shadow DOM][Refactoring] HTMLContentSelector family should have better name
https://bugs.webkit.org/show_bug.cgi?id=86064

Reviewed by Dimitri Glazkov.

This change renames classes around shadow content distribution.
- Renamed HTMLContentSelector to ContentDistributor
- Renamed HTMLContentSelectionList to ContentDistribution
- Renamed HTMLContentSelection to ContentDistribution::Item
- Inlined HTMLContentSelectionSet into ContentDistributor

Associated rename and inlining are also happening for method names.

No new tests. No behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::insertionPointFor):
(WebCore::ElementShadow::distributionItemFor):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsRedistributing):
(WebCore::ElementShadow::hostChildrenChanged):
(WebCore::ElementShadow::setNeedsRedistributing):
* dom/ElementShadow.h:
(WebCore):
(ElementShadow):
(WebCore::ElementShadow::distributor):
(WebCore::ElementShadow::clearNeedsRedistributing):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
* dom/ShadowRoot.cpp:
* dom/ShadowRoot.h:
(WebCore):
* html/shadow/ContentDistributor.cpp: Renamed from Source/WebCore/html/shadow/HTMLContentSelector.cpp.
(WebCore):
(WebCore::ContentDistribution::ContentDistribution):
(WebCore::ContentDistribution::~ContentDistribution):
(WebCore::ContentDistribution::find):
(WebCore::ContentDistribution::clear):
(WebCore::ContentDistribution::append):
(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findFor):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::willDistribute):
(WebCore::ContentDistributor::didDistribute):
(WebCore::ContentDistributor::preparePoolFor):
* html/shadow/ContentDistributor.h: Added.
(WebCore):
(ContentDistribution):
(Item):
(WebCore::ContentDistribution::Item::insertionPoint):
(WebCore::ContentDistribution::Item::node):
(WebCore::ContentDistribution::Item::next):
(WebCore::ContentDistribution::Item::previous):
(WebCore::ContentDistribution::Item::create):
(WebCore::ContentDistribution::Item::Item):
(WebCore::ContentDistribution::first):
(WebCore::ContentDistribution::last):
(WebCore::ContentDistribution::firstNode):
(WebCore::ContentDistribution::lastNode):
(WebCore::ContentDistribution::isEmpty):
(ContentDistributor):
(Translator):
(WebCore::ContentDistributor::Translator::hash):
(WebCore::ContentDistributor::Translator::equal):
(WebCore::ContentDistributor::Hash::hash):
(WebCore::ContentDistributor::Hash::equal):
(Hash):
(WebCore::ContentDistributor::inDistribution):
(WebCore::ContentDistributor::poolIsReady):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/HTMLContentSelector.h: Removed.
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::clearAssignment):
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::distribution):
(WebCore::InsertionPoint::hasDistribution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] ImageDiff should be build for host on Android
commit-queue@webkit.org [Mon, 14 May 2012 18:26:41 +0000 (18:26 +0000)]
[Chromium] ImageDiff should be build for host on Android
https://bugs.webkit.org/show_bug.cgi?id=82039

Patch by Wei James <james.wei@intel.com> on 2012-05-14
Reviewed by Adam Barth.

Source/WTF:

* WTF.gyp/WTF.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixup: Two of the touch-adjustment tests are flaky
commit-queue@webkit.org [Mon, 14 May 2012 18:18:50 +0000 (18:18 +0000)]
Fixup: Two of the touch-adjustment tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-14
Reviewed by Darin Adler.

One test cases was still not working all platforms.
Change used font to Ahem to have stable layout across platforms.

* touchadjustment/touch-inlines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r116796): Assertion failure in API tests
kling@webkit.org [Mon, 14 May 2012 18:17:02 +0000 (18:17 +0000)]
REGRESSION(r116796): Assertion failure in API tests
<http://webkit.org/b/86378>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116969.
kling@webkit.org [Mon, 14 May 2012 18:14:26 +0000 (18:14 +0000)]
Unreviewed, rolling out r116969.
http://trac.webkit.org/changeset/116969
https://bugs.webkit.org/show_bug.cgi?id=86386

i accidentally the icondatabase (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

Source/WebCore:

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
* loader/icon/IconDatabase.h:
(IconDatabase):

Source/WebKit2:

* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r116796): Assertion failure in API tests
kling@webkit.org [Mon, 14 May 2012 18:04:17 +0000 (18:04 +0000)]
REGRESSION(r116796): Assertion failure in API tests
<http://webkit.org/b/86378>
<rdar://problem/10777218>

Reviewed by Anders Carlsson.

Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed trivial buildfix after r116958.
ossy@webkit.org [Mon, 14 May 2012 17:54:58 +0000 (17:54 +0000)]
[Qt][WK2] Unreviewed trivial buildfix after r116958.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Updating email for committers.py script.
joone@webkit.org [Mon, 14 May 2012 17:48:40 +0000 (17:48 +0000)]
Unreviewed. Updating email for committers.py script.

Patch by Joone Hur <joone@webkit.org> on 2012-05-14

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline after r115846.
jchaffraix@webkit.org [Mon, 14 May 2012 17:46:33 +0000 (17:46 +0000)]
Unreviewed rebaseline after r115846.

Those are layers additions & baselines churns due to sharing or splitting
between ports.

* fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
* fast/repaint/lines-with-layout-delta-expected.txt: Added.
* fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
* fast/repaint/repaint-resized-overflow-expected.txt: Added.
* fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
* fast/repaint/subtree-root-clip-2-expected.png: Added.
* fast/repaint/subtree-root-clip-expected.png: Added.
* platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Added.
* platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Added.
* platform/chromium-linux-x86/fast/layers: Removed.
* platform/chromium-linux-x86/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Added.
* platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Added.
* platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Added.
* platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/inline-relative-positioned-expected.txt:
* platform/chromium-mac/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.txt: Removed.
* platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt: Removed.
* platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.txt: Removed.
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/chromium-win-vista/fast/layers: Removed.
* platform/chromium-win-vista/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-win-xp/fast/layers: Removed.
* platform/chromium-win-xp/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt:
* platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-win/fast/forms/input-value-expected.txt:
* platform/chromium-win/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/chromium-win/fast/repaint/inline-relative-positioned-expected.txt:
* platform/chromium-win/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/chromium-win/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/chromium-win/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
* platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
* platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium/fast/layers: Removed.
* platform/chromium/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
* platform/chromium/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/chromium/fast/repaint/subtree-root-clip-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
* platform/efl/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
* platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
* platform/efl/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/efl/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/efl/fast/repaint/subtree-root-clip-2-expected.png: Removed.
* platform/efl/fast/repaint/subtree-root-clip-expected.png: Removed.
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
* platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
* platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
* platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
* platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove ewk_view_core_page_get().
rakuco@webkit.org [Mon, 14 May 2012 17:45:05 +0000 (17:45 +0000)]
[EFL] Remove ewk_view_core_page_get().
https://bugs.webkit.org/show_bug.cgi?id=86326

Reviewed by Antonio Gomes.

Right now, we have both ewk_view_core_page_get() and
EWKPrivate::corePage() doing the same thing, but the latter is
better encapsulated.

Remove the former then.

* WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::syncLayersNow): Add
missing ewk_private.h and use EWKPrivate::corePage().
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow): Use
EWKPrivate::corePage().
* ewk/ewk_private.h: Remove ewk_view_core_page_get() declaration.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(EWKPrivate::corePage): Fix coding style while here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Unreviewed build fixes for wxMSW build.
kevino@webkit.org [Mon, 14 May 2012 17:30:40 +0000 (17:30 +0000)]
[wx] Unreviewed build fixes for wxMSW build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Unreviewed build fix. Fix for wxMSW windows.h load order bug.
kevino@webkit.org [Mon, 14 May 2012 17:27:24 +0000 (17:27 +0000)]
[wx] Unreviewed build fix. Fix for wxMSW windows.h load order bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<video> won't load when URL ends with .php
eric.carlson@apple.com [Mon, 14 May 2012 17:17:40 +0000 (17:17 +0000)]
<video> won't load when URL ends with .php
https://bugs.webkit.org/show_bug.cgi?id=86308

Source/WebCore:

Reviewed by NOBODY (OOPS!).

Test: http/tests/media/video-query-url.html

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Initialize m_typeInferredFromExtension.
(WebCore::MediaPlayer::load): Set m_typeInferredFromExtension appropriately.
(WebCore::MediaPlayer::loadWithNextMediaEngine): If we don't find a media engine registered
    for a MIME type, and the type was inferred from the extension, give the first registered
    media engine a chance anwyay just as we do when there is no MIME type at all.
* platform/graphics/MediaPlayer.h: Add m_typeInferredFromExtension.

LayoutTests:

Reviewed by Darin Adler.

* http/tests/media/resources/load-video.php: Added.
* http/tests/media/video-query-url-expected.txt: Added.
* http/tests/media/video-query-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: do not update $0-$4 console variables for the objects from loaded...
loislo@chromium.org [Mon, 14 May 2012 17:12:11 +0000 (17:12 +0000)]
Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=86371

When the user selects an object in HeapSnapshot we are updating $0 variable in console API.
But if the snapshot was loaded from file then we can't map object id for the selected obect
from the snapshot to the live objects in the inspected page.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel.prototype._loadFromFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Simplify OTHER_FILES for QML tests project files
vestbo@webkit.org [Mon, 14 May 2012 16:44:19 +0000 (16:44 +0000)]
[Qt] Simplify OTHER_FILES for QML tests project files

Reviewed by Jocelyn Turcotte.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
* UIProcess/API/qt/tests/qmltests/WebView.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Extensions API] allow extensions to evaluate in the context of their...
caseq@chromium.org [Mon, 14 May 2012 16:34:15 +0000 (16:34 +0000)]
Web Inspector: [Extensions API] allow extensions to evaluate in the context of their content scripts
https://bugs.webkit.org/show_bug.cgi?id=86361

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/extensions/extensions-eval-content-script.html

* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression): Added evaluateOptions optional parameter.
(injectedExtensionAPI.InspectedWindow.prototype.eval):
(injectedExtensionAPI.extractCallbackArgument): A helper to extract callback function from last argument.
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype.setExpression): Added evaluateOptions optional parameter.
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarContent): Use ExtensionServer.evaluate() wrapper.
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage): Ditto.
(WebInspector.ExtensionServer.prototype._normalizePath):
(WebInspector.ExtensionServer.prototype.evaluate): A wrapper for PageAgent.evaluate() that handles evaluateOptions.
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin): Expose interface to locate context id by frame and content script security origin.
(WebInspector.FrameEvaluationContext.prototype._addExecutionContext): Maintain contexts sorted by name.
(WebInspector.FrameEvaluationContext.prototype.isolatedContexts): ditto (skip sorting when returning contexts)
(WebInspector.FrameEvaluationContext.prototype.contextBySecurityOrigin):
* inspector/front-end/inspector.js: Hold/expose javaScriptContextManager.

LayoutTests:

* inspector/extensions/extensions-eval-content-script-expected.txt: Added.
* inspector/extensions/extensions-eval-content-script.html: Added.
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 14 May 2012 16:10:01 +0000 (16:10 +0000)]
Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing header file.

Source/WebKit2:

* GNUmakefile.am: Explicitly link WebProcess to
libjavascriptcoregtk to make sure it uses the non installed
library.
* GNUmakefile.list.am: Add missing header file.

Tools:

* GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
* gtk/run-api-tests:
(TestRunner._lookup_atspi2_binary): Handle the case when
pkg_config_file_variable() return None.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]Convert render-region-custom-style-mark to ref test
mihnea@adobe.com [Mon, 14 May 2012 16:06:41 +0000 (16:06 +0000)]
[CSSRegions]Convert render-region-custom-style-mark to ref test
https://bugs.webkit.org/show_bug.cgi?id=86289

Reviewed by Andreas Kling.

This test verifies that:
- If an element is displayed in a region with a region styling rule, that rule is applied.
- If an element is collected into a named flow and we add a region (with a region style rule) to display the named flow,
that region styling rule is applied.
- If an element is displayed in a region with a region styling rule, and the region element is changed into a non-region,
the region styling rule is not applied.

* fast/regions/render-region-custom-style-mark-expected.html: Added.
* fast/regions/render-region-custom-style-mark.html:
* platform/chromium-linux/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-mac-leopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/chromium-mac/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
* platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: preserve tab index while widening / shrinking tabbed pane area.
pfeldman@chromium.org [Mon, 14 May 2012 15:53:05 +0000 (15:53 +0000)]
Web Inspector: preserve tab index while widening / shrinking tabbed pane area.
https://bugs.webkit.org/show_bug.cgi?id=86359

Reviewed by Vsevolod Vlasov.

After the drag'n'drop reorder, we should preserve tab index while widening /
shrinking the tabbed pane area.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._innerCloseTab):
(WebInspector.TabbedPane.prototype._showTabElement):
(WebInspector.TabbedPane.prototype._hideTabElement):
(WebInspector.TabbedPane.prototype._updateTabsDropDown):
(WebInspector.TabbedPane.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.TabbedPane.prototype._insertBefore):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabDragging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update expectations after fix for 84846
schenney@chromium.org [Mon, 14 May 2012 15:48:17 +0000 (15:48 +0000)]
[Chromium] Update expectations after fix for 84846
https://bugs.webkit.org/show_bug.cgi?id=86374

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Request / response headers should be stored in name-value pairs array...
vsevik@chromium.org [Mon, 14 May 2012 15:44:05 +0000 (15:44 +0000)]
Web Inspector: Request / response headers should be stored in name-value pairs array, not a map on front-end.
https://bugs.webkit.org/show_bug.cgi?id=86357

Reviewed by Pavel Feldman.

Source/WebCore:

Storing headers as name-value pairs array information more accurate and allows
to treat Set-Cookie headers (which become not parseable when joined by comma) correctly.

* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._headersMapToHeadersArray):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype._headerValue):
* inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
(WebInspector.RequestHeadersView.prototype._refreshHeaders):
* platform/chromium/support/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):

LayoutTests:

* http/tests/inspector/resource-har-conversion.html:
* http/tests/inspector/resource-har-headers-expected.txt:
* http/tests/inspector/resource-har-headers.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/JavaScriptCore: DFG JIT didn't work with ARM EABI.
commit-queue@webkit.org [Mon, 14 May 2012 15:35:38 +0000 (15:35 +0000)]
Source/JavaScriptCore: DFG JIT didn't work with ARM EABI.
https://bugs.webkit.org/show_bug.cgi?id=84449

Patch by Yong Li <yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.

Add a 32-bit dummy argument for some callOperation()
methods to make it work for ARM EABI.

* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

Source/WTF: DFG JIT is not ARM EABI compatible
https://bugs.webkit.org/show_bug.cgi?id=84449

Patch by Yong Li <yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.

Add COMPILER_SUPPORTS(EABI) when __ARM_EABI__
or __EABI__ is defined.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WK2] Memory leaks in WebKitWebSettings
commit-queue@webkit.org [Mon, 14 May 2012 15:33:05 +0000 (15:33 +0000)]
[GTK] [WK2] Memory leaks in WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=86365

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fix memory leaks in WebKitWebSettings by adopting allocations
using adoptWK.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_init):
(webkit_settings_set_serif_font_family):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be...
commit-queue@webkit.org [Mon, 14 May 2012 15:28:24 +0000 (15:28 +0000)]
[Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be under condition guards
https://bugs.webkit.org/show_bug.cgi?id=86060

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-05-14
Reviewed by Martin Robinson.

Property set/get functions generated was referencing WebCore::interface without any condition guard.
This issue was triggered usually when an interface gets disabled; For instance; --disable-video, disables WebCore::HTMLMediaElement.
Also updated the GObject binding reference tests

No new tests - covered by existing bindings tests

* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties):
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(webkit_dom_test_active_dom_object_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(webkit_dom_test_event_constructor_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(webkit_dom_test_exception_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Wrong documentation for Web Database
commit-queue@webkit.org [Mon, 14 May 2012 15:23:43 +0000 (15:23 +0000)]
[GTK] Wrong documentation for Web Database
https://bugs.webkit.org/show_bug.cgi?id=86362

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fixed docs for webkit_set_default_web_database_quota().

* webkit/webkitwebdatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116935.
ossy@webkit.org [Mon, 14 May 2012 15:15:26 +0000 (15:15 +0000)]
Unreviewed, rolling out r116935.
http://trac.webkit.org/changeset/116935
https://bugs.webkit.org/show_bug.cgi?id=86373

Something is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

* Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
(PNGChecker):
(PNGChecker._config_file_path):
* Scripts/webkitpy/tool/commands/download.py:
(Land):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Styles] css properties copied into clipboard contain extra line break...
apavlov@chromium.org [Mon, 14 May 2012 14:49:18 +0000 (14:49 +0000)]
Web Inspector: [Styles] css properties copied into clipboard contain extra line breaks before color values
https://bugs.webkit.org/show_bug.cgi?id=86372

Reviewed by Vsevolod Vlasov.

The "display: block" property found in the ".swatch-inner" CSS class was causing the issue
(an additional \n was rendered in the plain text value).

* inspector/front-end/inspector.css:
(.swatch-inner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] fast/loader/null-request-after-willSendRequest.html and fast/loader/recursive...
commit-queue@webkit.org [Mon, 14 May 2012 14:05:50 +0000 (14:05 +0000)]
[EFL] fast/loader/null-request-after-willSendRequest.html and fast/loader/recursive-before-unload-crash.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86368

Unreviewed EFL gardening.

Remove fast/loader/null-request-after-willSendRequest.html and
fast/loader/recursive-before-unload-crash.html from skip list now that
EFL port has proper support for LayoutTestController's
dumpFrameLoadCallbacks.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-14

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Doesn't build with ENABLE_INSPECTOR=0
commit-queue@webkit.org [Mon, 14 May 2012 14:01:50 +0000 (14:01 +0000)]
[Qt] Doesn't build with ENABLE_INSPECTOR=0
https://bugs.webkit.org/show_bug.cgi?id=85056

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-14
Reviewed by Tor Arne Vestbø.

Source/WebKit2:

* Target.pri:
* UIProcess/qt/QtWebContext.cpp:
(WebKit::initInspectorServer):

Tools:

* WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Mon, 14 May 2012 13:58:56 +0000 (13:58 +0000)]
[Qt][WK2] Unreviewed gardening, unskip now passing tests.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Unskipping a set of remaining media failures
commit-queue@webkit.org [Mon, 14 May 2012 13:39:01 +0000 (13:39 +0000)]
[EFL][DRT] Unskipping a set of remaining media failures
https://bugs.webkit.org/show_bug.cgi?id=86104

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-14

* platform/efl/Skipped:
* platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
* platform/efl/media/audio-controls-rendering-expected.png:
* platform/efl/media/audio-controls-rendering-expected.txt:
* platform/efl/media/audio-repaint-expected.png:
* platform/efl/media/audio-repaint-expected.txt:
* platform/efl/media/controls-after-reload-expected.png:
* platform/efl/media/controls-after-reload-expected.txt:
* platform/efl/media/controls-strict-expected.png:
* platform/efl/media/controls-strict-expected.txt:
* platform/efl/media/controls-without-preload-expected.png:
* platform/efl/media/controls-without-preload-expected.txt:
* platform/efl/media/media-document-audio-repaint-expected.png: Added.
* platform/efl/media/media-document-audio-repaint-expected.txt: Added.
* platform/efl/media/video-controls-rendering-expected.png:
* platform/efl/media/video-controls-rendering-expected.txt:
* platform/efl/media/video-display-toggle-expected.png:
* platform/efl/media/video-display-toggle-expected.txt:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening; unskip tests fixed in r116929.
rakuco@webkit.org [Mon, 14 May 2012 13:36:17 +0000 (13:36 +0000)]
[EFL] Gardening; unskip tests fixed in r116929.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION (r116789): inspector/debugger/script-formatter-console.html fails
pfeldman@chromium.org [Mon, 14 May 2012 13:25:43 +0000 (13:25 +0000)]
[Qt] REGRESSION (r116789): inspector/debugger/script-formatter-console.html fails
https://bugs.webkit.org/show_bug.cgi?id=86336

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.location):

LayoutTests:

* inspector/debugger/script-formatter-breakpoints.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116932.
commit-queue@webkit.org [Mon, 14 May 2012 13:10:44 +0000 (13:10 +0000)]
Unreviewed, rolling out r116932.
http://trac.webkit.org/changeset/116932
https://bugs.webkit.org/show_bug.cgi?id=86364

It still fails on 32 bit platforms (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTiledBackingStore: Prevent partial tile updates when they intersect the keep rect.
jocelyn.turcotte@nokia.com [Mon, 14 May 2012 13:07:03 +0000 (13:07 +0000)]
TiledBackingStore: Prevent partial tile updates when they intersect the keep rect.
https://bugs.webkit.org/show_bug.cgi?id=85488

Reviewed by Kenneth Rohde Christiansen.

Right now an invalidate can cause problems for tiles on the boundary of the keep
rect. Intersecting the dirty rect causes only part of the tile to be updated,
and the glitch becomes visible if the user scrolls this tile back into the viewport.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] fast/viewport testcases are skipped
commit-queue@webkit.org [Mon, 14 May 2012 12:45:51 +0000 (12:45 +0000)]
[EFL][DRT] fast/viewport testcases are skipped
https://bugs.webkit.org/show_bug.cgi?id=86360

Unreviewed, unskipping now passing fast/viewport tests after
bug https://bugs.webkit.org/show_bug.cgi?id=70609 got fixed.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-14

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make sure dialogs have their parent and attached properties set before Component...
vestbo@webkit.org [Mon, 14 May 2012 12:38:01 +0000 (12:38 +0000)]
[Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted

https://bugs.webkit.org/show_bug.cgi?id=86222

The WebView QML api for dialogs is based on delegates for each dialog, which
are implemented as components. Since there's no explicit API to show the dialog,
the natural place to allow the dialog to choose how to display itself is in
Component.onCompleted.

The issue was that we were using QQmlComponent::create() when instantiating the
component, at which point the component did not have a parent or it's attached
WebView property set. That meant that we had to do some ugly workaround in our
test, using a 1ms timer, to get a callback once the parent was there.

We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
pair, which allows us to set the relevant properties before triggering the
Component.onCompleted callback. We were already doing this for the context
menus (except for setting the parent, which we did afterwards).

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116936 268f45cc-cd09-0410-ab3c-d52691b4dbfc