WebKit-https.git
10 years ago2009-08-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 5 Aug 2009 08:13:27 +0000 (08:13 +0000)]
2009-08-05  Xan Lopez  <xlopez@igalia.com>

        Revert r46714, it was making us build debug images by default.

        * autotools/webkit.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 5 Aug 2009 05:50:43 +0000 (05:50 +0000)]
2009-08-04  Simon Hausmann  <hausmann@webkit.org>

        Prospective build fix for Qt build bot: Fix dependency of HTMLNames.cpp
        to both source files, HTMLTagNames.in and HTMLAttributeNames.in

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 5 Aug 2009 05:40:57 +0000 (05:40 +0000)]
2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [V8] Teach ScheduledAction::execute about isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=27703

        Rename queueScriptInIsolatedWorld to evaluateScriptInIsolatedWorld
        because I've changed this API to be synchronous instead of asynchronous
        to work around some strange behavior in the work_queue_.  Turns out we
        don't need the complexity of an asynchronous API to test this feature.

        * http/tests/security/isolatedWorld/all-window-properties.html:
        * http/tests/security/isolatedWorld/all-window-prototypes.html:
        * http/tests/security/isolatedWorld/body-properties.html:
        * http/tests/security/isolatedWorld/body-prototype.html:
        * http/tests/security/isolatedWorld/click-event.html:
        * http/tests/security/isolatedWorld/document-open.html:
        * http/tests/security/isolatedWorld/document-properties.html:
        * http/tests/security/isolatedWorld/document-prototype.html:
        * http/tests/security/isolatedWorld/global-variables.html:
        * http/tests/security/isolatedWorld/image-properties.html:
        * http/tests/security/isolatedWorld/image-prototype.html:
        * http/tests/security/isolatedWorld/location-properties.html:
        * http/tests/security/isolatedWorld/location-prototype.html:
        * http/tests/security/isolatedWorld/number-prototype.html:
        * http/tests/security/isolatedWorld/object-prototype.html:
        * http/tests/security/isolatedWorld/string-prototype.html:
        * http/tests/security/isolatedWorld/window-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Wed, 5 Aug 2009 05:20:13 +0000 (05:20 +0000)]
2009-08-04  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adele Peterson.

        Keypress should exit from pan scrolling mode.
        https://bugs.webkit.org/show_bug.cgi?id=28005

        Change the logic from only exiting pan scrolling on escape to exiting on any key press,
        making it easier for users to back out of an accidental pan scroll.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 5 Aug 2009 04:36:06 +0000 (04:36 +0000)]
2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION (r45064): Drop caret remains in text control after the mouse exits
        https://bugs.webkit.org/show_bug.cgi?id=26787

        Fix some bogus comments noticed during testing.

        * fast/forms/drag-into-textarea.html:
        * fast/forms/drag-out-of-textarea.html:

2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION (r45064): Drop caret remains in text control after the mouse exits
        https://bugs.webkit.org/show_bug.cgi?id=26787

        Add back missing dragController()->clear() call.

        * manual-tests/drag-caret.html: Added.
        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Wed, 5 Aug 2009 02:22:37 +0000 (02:22 +0000)]
2009-08-04  Alice Liu  <alice.liu@apple.com>

        "Shift + Enter" should behave like "Enter" in editable fields.
        Affects backward search in find-in-page in Safari for Windows

        Reviewed by Jon Honeycutt.

        * WebView.cpp:
        Register shift+enter as InsertNewline command, similar to other
        modifier+Enter combinations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Chris Fleizach <cfleizach@apple.com>
eric@webkit.org [Wed, 5 Aug 2009 01:34:26 +0000 (01:34 +0000)]
2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
        https://bugs.webkit.org/show_bug.cgi?id=27994

        * platform/mac/accessibility/aria-valuetext-expected.txt: Added.
        * platform/mac/accessibility/aria-valuetext.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Wed, 5 Aug 2009 00:32:26 +0000 (00:32 +0000)]
2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
        https://bugs.webkit.org/show_bug.cgi?id=27994

        Forgot to commit attribute names.

        * html/HTMLAttributeNames.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
cfleizach@apple.com [Wed, 5 Aug 2009 00:29:06 +0000 (00:29 +0000)]
WebCore:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
        https://bugs.webkit.org/show_bug.cgi?id=27994

        Test: platform/mac/accessibility/aria-valuetext.html

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::valueDescription):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::valueDescription):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        * html/HTMLAttributeNames.in:

WebKitTools:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
        https://bugs.webkit.org/show_bug.cgi?id=27994

        Expose valueDescription for accessibility.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (getValueDescriptionCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::valueDescription):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::valueDescription):

LayoutTests:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
        https://bugs.webkit.org/show_bug.cgi?id=27994

        * platform/mac/accessibility/aria-valuetext-expected.txt: Added.
        * platform/mac/accessibility/aria-valuetext.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 5 Aug 2009 00:21:56 +0000 (00:21 +0000)]
2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
        https://bugs.webkit.org/show_bug.cgi?id=28006

        Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig

        * DumpRenderTree/mac/PerlSupport/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Michael Nordman <michaeln@google.com>
darin@chromium.org [Wed, 5 Aug 2009 00:18:28 +0000 (00:18 +0000)]
2009-08-04  Michael Nordman  <michaeln@google.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=27821

        No new features, no new tests. Existing layout tests pass.

        * WebCore.base.exp:

        Export AppliationCacheGroup::storeCopyOfCache

        * WebCore.xcodeproj/project.pbxproj:

        Restore DOMApplicationCache.h and ApplicationCacheHost.h to 'project' headers
        instead of 'private' headers since they're no longer in the DocumentLoader.h
        include graph.

        * html/HTMLHtmlElement.cpp:
        (WebCore::HTMLHtmlElement::insertedIntoDocument):

        Reinstate the test for manifest.isNull instead of .isEmtpty().
        Added a FIXME to revisit once the spec gets clarified.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::mainReceivedError):
        (WebCore::DocumentLoader::detachFromFrame):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::applicationCacheHost):

        ApplicationCacheHost is held in an OwnPtr<> by DocumentLoader. This was done
        for compile time friendliness, it results in a smaller include graph for files
        dependent on DocumentLoader.h.

        * loader/FrameLoader.cpp:
        * loader/MainResourceLoader.cpp:
        * loader/ResourceLoader.cpp:

        Cleanup ussage of ENABLE(xxx) around includes, generally remove those guards.
        This was done for readability at the include site. The included files contain appropriate guards,
        so they're not needed at the include site.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::selectCache):
        (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
        (WebCore::ApplicationCacheGroup::failedLoadingMainResource):
        (WebCore::ApplicationCacheGroup::update):
        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
        (WebCore::ApplicationCacheGroup::manifestNotFound):
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        (WebCore::ApplicationCacheGroup::startLoadingEntry):
        (WebCore::CallCacheListenerTask::create):
        (WebCore::CallCacheListenerTask::performTask):
        (WebCore::CallCacheListenerTask::CallCacheListenerTask):
        (WebCore::ApplicationCacheGroup::postListenerTask):
        * loader/appcache/ApplicationCacheGroup.h:

        Use ApplicationCachHost defined constants, no longer depends on DOMApplicationCache.

        * loader/appcache/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::ApplicationCacheHost):
        (WebCore::ApplicationCacheHost::setDOMApplicationCache):
        (WebCore::ApplicationCacheHost::notifyEventListener):
        (WebCore::ApplicationCacheHost::status):
        * loader/appcache/ApplicationCacheHost.h:
        (WebCore::ApplicationCacheHost::):
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::storeCopyOfCache):
        * loader/appcache/ApplicationCacheStorage.h:

        Merge recently added transferApplicationCache and pre-existing storeCopyOfCache methods.

        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::status):
        (WebCore::DOMApplicationCache::addEventListener):
        (WebCore::DOMApplicationCache::removeEventListener):
        (WebCore::DOMApplicationCache::callListener):
        (WebCore::DOMApplicationCache::toEventType):
        (WebCore::DOMApplicationCache::toEventID):
        * loader/appcache/DOMApplicationCache.h:
        (WebCore::DOMApplicationCache::setAttributeEventListener):
        (WebCore::DOMApplicationCache::getAttributeEventListener):
        (WebCore::DOMApplicationCache::clearAttributeEventListener):
        (WebCore::DOMApplicationCache::callEventListener):
        (WebCore::DOMApplicationCache::setOnchecking):
        (WebCore::DOMApplicationCache::onchecking):
        (WebCore::DOMApplicationCache::setOnerror):
        (WebCore::DOMApplicationCache::onerror):
        (WebCore::DOMApplicationCache::setOnnoupdate):
        (WebCore::DOMApplicationCache::onnoupdate):
        (WebCore::DOMApplicationCache::setOndownloading):
        (WebCore::DOMApplicationCache::ondownloading):
        (WebCore::DOMApplicationCache::setOnprogress):
        (WebCore::DOMApplicationCache::onprogress):
        (WebCore::DOMApplicationCache::setOnupdateready):
        (WebCore::DOMApplicationCache::onupdateready):
        (WebCore::DOMApplicationCache::setOncached):
        (WebCore::DOMApplicationCache::oncached):
        (WebCore::DOMApplicationCache::setOnobsolete):
        (WebCore::DOMApplicationCache::onobsolete):

        Use ApplicationCachHost defined constants for Status and EventIDs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 4 Aug 2009 23:31:25 +0000 (23:31 +0000)]
2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Add pkasting to bugzilla-tool as a committer
        https://bugs.webkit.org/show_bug.cgi?id=28002

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 4 Aug 2009 23:20:18 +0000 (23:20 +0000)]
2009-08-04  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.

        https://bugs.webkit.org/show_bug.cgi?id=27719

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
cfleizach@apple.com [Tue, 4 Aug 2009 23:04:31 +0000 (23:04 +0000)]
WebCore:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27993 - AXSliders are missing required attributes and actions
        https://bugs.webkit.org/show_bug.cgi?id=27993

        Expose appropriate actions and attributes for sliders.

        Test: platform/mac/accessibility/slider-supports-actions.html

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::orientation):
        * accessibility/AccessibilityObject.h:
        (WebCore::):
        * accessibility/AccessibilitySlider.cpp:
        (WebCore::AccessibilitySlider::orientation):
        * accessibility/AccessibilitySlider.h:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityActionNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

WebKitTools:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27993 - AXSliders are missing required attributes and actions
        https://bugs.webkit.org/show_bug.cgi?id=27993

        Add ability to check if any arbitrary action is supported.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (isActionSupportedCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::isActionSupported):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::isActionSupported):

LayoutTests:

2009-08-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 27993 - AXSliders are missing required attributes and actions
        https://bugs.webkit.org/show_bug.cgi?id=27993

        Update tests to use more generic isActionSupported.

        * accessibility/aria-link-supports-press.html:
        * accessibility/button-press-action.html:
        * accessibility/onclick-handlers.html:
        * platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
        * platform/mac/accessibility/slider-supports-actions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 4 Aug 2009 22:52:07 +0000 (22:52 +0000)]
2009-08-04  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        [V8] Fix an assert in WebCoreStringResource that causes worker script
        evaluation failed.
        https://bugs.webkit.org/show_bug.cgi?id=27996

        The fix is to check for the same thread, instead of the main thread.
        This is because Chromium's workers use v8 in a single thread that is
        not the main thread.

        * bindings/v8/V8Binding.cpp:
        (WebCore::WebCoreStringResource::WebCoreStringResource):
        (WebCore::WebCoreStringResource::~WebCoreStringResource):
        (WebCore::WebCoreStringResource::atomicString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 4 Aug 2009 22:46:23 +0000 (22:46 +0000)]
2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool unit tests need a test harness
        https://bugs.webkit.org/show_bug.cgi?id=27977

        * Scripts/run-webkit-unittests: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx build fix after InspectorClient API change.
kevino@webkit.org [Tue, 4 Aug 2009 22:19:24 +0000 (22:19 +0000)]
wx build fix after InspectorClient API change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 4 Aug 2009 21:43:45 +0000 (21:43 +0000)]
2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        LayoutTests are too slow
        https://bugs.webkit.org/show_bug.cgi?id=27995

        Shave 5 seconds off of run-webkit-tests.

        * fast/events/click-count.html: use eventSender.leapForward instead of setTimeout

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 4 Aug 2009 21:35:34 +0000 (21:35 +0000)]
2009-08-04  Gavin Barraclough  <barraclough@apple.com>

        Rubber Stamped by Oiver Hunt.

        Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
        https://bugs.webkit.org/show_bug.cgi?id=27874

        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::allocDisjunctionContext):
        (JSC::Yarr::Interpreter::freeDisjunctionContext):
        (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
        (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPPC64 Build fix
oliver@apple.com [Tue, 4 Aug 2009 20:54:09 +0000 (20:54 +0000)]
PPC64 Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Aug 2009 19:57:49 +0000 (19:57 +0000)]
2009-08-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Add support for transitions/animations of text-indent.

        Test: transitions/text-indent-transition.html

        * page/animation/AnimationBase.cpp:
        (WebCore::ensurePropertyMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnsure that DumpRenderTreeSupport is regenerated when switching between OS versions
mrowe@apple.com [Tue, 4 Aug 2009 19:52:42 +0000 (19:52 +0000)]
Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
by listing the DumpRenderTree binary as a dependency.  Xcode has the smarts to rebuild
DumpRenderTree itself when switching OS versions so this dependency removes the need
for any smarts in the Makefile.

Rubber-stamped by Gavin "Gavvy" Barraclough.

* DumpRenderTree/mac/PerlSupport/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate test results after addition of AXRequired in r46768.
mrowe@apple.com [Tue, 4 Aug 2009 19:46:45 +0000 (19:46 +0000)]
Update test results after addition of AXRequired in r46768.

* platform/mac/accessibility/lists-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Aug 2009 19:38:26 +0000 (19:38 +0000)]
2009-08-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Add support for transitions of min- and max-width, and min- and max-height.
        https://bugs.webkit.org/show_bug.cgi?id=27990

        Test: transitions/min-max-width-height-transitions.html

        * page/animation/AnimationBase.cpp:
        (WebCore::ensurePropertyMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 4 Aug 2009 19:17:38 +0000 (19:17 +0000)]
2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool needs unit tests
        https://bugs.webkit.org/show_bug.cgi?id=26916

        Add some basic unit testing for scm.py.

        * Scripts/modules/scm.py:
        * Scripts/modules/scm_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Mike Fenton <mike.fenton@torchmobile.com>
abarth@webkit.org [Tue, 4 Aug 2009 19:06:06 +0000 (19:06 +0000)]
2009-08-04  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
        to make sure the Skipped entries are not in the $ignoredDirectories array.  Directories commonly included
        are (http, media, compositing, wml, wcss).

        https://bugs.webkit.org/show_bug.cgi?id=27893

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 27964 - WAI-ARIA: radio button does not determine its label from text content
cfleizach@apple.com [Tue, 4 Aug 2009 18:15:47 +0000 (18:15 +0000)]
Bug 27964 - WAI-ARIA: radio button does not determine its label from text content
https://bugs.webkit.org/show_bug.cgi?id=27964

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 4 Aug 2009 17:28:16 +0000 (17:28 +0000)]
2009-08-04  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Missed a place that expects window.event to be hidden when it shouldn't be.

        https://bugs.webkit.org/show_bug.cgi?id=27719

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
cfleizach@apple.com [Tue, 4 Aug 2009 16:15:05 +0000 (16:15 +0000)]
Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
https://bugs.webkit.org/show_bug.cgi?id=27958

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Antonio Gomes <antonio.gomes@openbossa.org>
hausmann@webkit.org [Tue, 4 Aug 2009 15:20:52 +0000 (15:20 +0000)]
2009-08-04  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Simon Hausmann.

        [Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
        https://bugs.webkit.org/show_bug.cgi?id=27804

        * Api/qwebframe.cpp:
        (QWebFrame::requestedUrl):
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
ben@webkit.org [Tue, 4 Aug 2009 14:58:43 +0000 (14:58 +0000)]
2009-08-04  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Adam Treat

        Explicitly include limits.h header when using INT_MAX and INT_MIN

        * interpreter/Interpreter.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Tue, 4 Aug 2009 14:51:51 +0000 (14:51 +0000)]
2009-08-04  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Add passed test results, with pixel tests.

        * platform/qt/Skipped:
        * platform/qt/fast/canvas/canvas-composite-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-composite-expected.png: Added.
        * platform/qt/fast/canvas/canvas-composite-expected.txt: Added.
        * platform/qt/fast/canvas/drawImage-expected.checksum: Added.
        * platform/qt/fast/canvas/drawImage-expected.png: Added.
        * platform/qt/fast/canvas/drawImage-expected.txt: Added.
        * platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
        * platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 4 Aug 2009 14:50:34 +0000 (14:50 +0000)]
2009-08-04  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Rename QWebPlugin to QWebPluginInfo, as discussed on IRC.

        * Api/qwebplugindatabase.cpp:
        (QWebPluginInfoPrivate::QWebPluginInfoPrivate):
        (QWebPluginInfo::QWebPluginInfo):
        (QWebPluginInfo::~QWebPluginInfo):
        (QWebPluginInfo::name):
        (QWebPluginInfo::description):
        (QWebPluginInfo::mimeTypes):
        (QWebPluginInfo::supportsMimeType):
        (QWebPluginInfo::path):
        (QWebPluginInfo::isNull):
        (QWebPluginInfo::setEnabled):
        (QWebPluginInfo::isEnabled):
        (QWebPluginInfo::operator==):
        (QWebPluginInfo::operator!=):
        (QWebPluginInfo::operator=):
        (QWebPluginDatabase::plugins):
        (QWebPluginDatabase::pluginForMimeType):
        (QWebPluginDatabase::setPreferredPluginForMimeType):
        * Api/qwebplugindatabase.h:
        * Api/qwebplugindatabase_p.h:
        * tests/qwebplugindatabase/tst_qwebplugindatabase.cpp:
        (tst_QWebPluginDatabase::installedPlugins):
        (tst_QWebPluginDatabase::searchPaths):
        (tst_QWebPluginDatabase::null_data):
        (tst_QWebPluginDatabase::null):
        (tst_QWebPluginDatabase::pluginForMimeType):
        (tst_QWebPluginDatabase::enabled):
        (tst_QWebPluginDatabase::operatorequal_data):
        (tst_QWebPluginDatabase::operatorequal):
        (tst_QWebPluginDatabase::preferredPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 4 Aug 2009 14:50:23 +0000 (14:50 +0000)]
2009-08-04  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Adam Treat.

        Replace QWebPlugin::MimeType with a typedef to
        QWebPluginFactory::MimeType.

        * Api/qwebplugindatabase.cpp:
        * Api/qwebplugindatabase.h:
        * Api/qwebpluginfactory.cpp:
        (QWebPluginFactory::MimeType::operator==):
        * Api/qwebpluginfactory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
hausmann@webkit.org [Tue, 4 Aug 2009 14:50:13 +0000 (14:50 +0000)]
WebCore:

2009-08-04  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        Add QWebPluginDatabase API to the Qt API.

        https://bugs.webkit.org/show_bug.cgi?id=27651

        * WebCore.pro:

WebKit/qt:

2009-08-04  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        Add QWebPluginDatabase API to the Qt API.

        https://bugs.webkit.org/show_bug.cgi?id=27651

        * Api/headers.pri:
        * Api/qwebplugindatabase.cpp: Added.
        (QWebPluginPrivate::QWebPluginPrivate):
        (QWebPluginDatabasePrivate::QWebPluginDatabasePrivate):
        (QWebPlugin::MimeType::operator==):
        (QWebPlugin::QWebPlugin):
        (QWebPlugin::~QWebPlugin):
        (QWebPlugin::name):
        (QWebPlugin::description):
        (QWebPlugin::mimeTypes):
        (QWebPlugin::supportsMimeType):
        (QWebPlugin::path):
        (QWebPlugin::isNull):
        (QWebPlugin::setEnabled):
        (QWebPlugin::isEnabled):
        (QWebPlugin::operator==):
        (QWebPlugin::operator!=):
        (QWebPlugin::operator=):
        (QWebPluginDatabase::QWebPluginDatabase):
        (QWebPluginDatabase::~QWebPluginDatabase):
        (QWebPluginDatabase::plugins):
        (QWebPluginDatabase::defaultSearchPaths):
        (QWebPluginDatabase::searchPaths):
        (QWebPluginDatabase::setSearchPaths):
        (QWebPluginDatabase::addSearchPath):
        (QWebPluginDatabase::refresh):
        (QWebPluginDatabase::pluginForMimeType):
        (QWebPluginDatabase::setPreferredPluginForMimeType):
        * Api/qwebplugindatabase.h: Added.
        * Api/qwebplugindatabase_p.h: Added.
        * Api/qwebsettings.cpp:
        (QWebSettings::pluginDatabase):
        * Api/qwebsettings.h:
        * tests/qwebplugindatabase/qwebplugindatabase.pro: Added.
        * tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Added.
        (tst_QWebPluginDatabase::installedPlugins):
        (tst_QWebPluginDatabase::searchPaths):
        (tst_QWebPluginDatabase::null_data):
        (tst_QWebPluginDatabase::null):
        (tst_QWebPluginDatabase::pluginForMimeType):
        (tst_QWebPluginDatabase::enabled):
        (tst_QWebPluginDatabase::operatorequal_data):
        (tst_QWebPluginDatabase::operatorequal):
        (tst_QWebPluginDatabase::preferredPlugin):
        * tests/tests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Tue, 4 Aug 2009 14:34:03 +0000 (14:34 +0000)]
2009-08-04  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Adam Treat.

        [Qt] PlusDarker is not supported. Fall back to CompositionMode_Darken
        (as it is the closest match) instead of CompositionMode_SourceOver.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::toQtCompositionMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Tue, 4 Aug 2009 14:24:02 +0000 (14:24 +0000)]
2009-08-04  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Adam Treat.

        [Qt] Fix the metrics.

        * platform/qt/fast/canvas/canvas-before-css-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Tue, 4 Aug 2009 13:30:21 +0000 (13:30 +0000)]
2009-08-04  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Add pixel tests result.

        * platform/qt/Skipped:
        * platform/qt/fast/canvas/canvas-as-image-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-as-image-expected.png: Added.
        * platform/qt/fast/canvas/canvas-as-image-expected.txt: Added.
        * platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
        * platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
        * platform/qt/fast/canvas/canvas-before-css-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-before-css-expected.png: Added.
        * platform/qt/fast/canvas/canvas-before-css-expected.txt:
        * platform/qt/fast/canvas/canvas-bg-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-bg-expected.png: Added.
        * platform/qt/fast/canvas/canvas-bg-expected.txt: Added.
        * platform/qt/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
        * platform/qt/fast/canvas/canvas-bg-zoom-expected.png: Added.
        * platform/qt/fast/canvas/canvas-bg-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 4 Aug 2009 13:26:01 +0000 (13:26 +0000)]
2009-08-04  Adam Treat  <adam.treat@torchmobile.com>

        Fix buildbot. This was supposed to be part of the last commit r46757, but the hunk never made it in.

        * platform/qt/fast/block/float/033-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
hausmann@webkit.org [Tue, 4 Aug 2009 12:22:24 +0000 (12:22 +0000)]
2009-08-04  Renata Hodovan  <hodovan.renata@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Remove LayoutTests/fast/block/float/033.html from the Qt Skipped list

        The expected value was incorrect and it has been modified. The new expected value is similar to the MAC version as well.

        * platform/qt/Skipped:
        * platform/qt/fast/block/float/033-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
abarth@webkit.org [Tue, 4 Aug 2009 09:28:59 +0000 (09:28 +0000)]
2009-08-04  Christian Plesner Hansen  <christian.plesner.hansen@gmail.com>

        Reviewed by Adam Barth.

        [v8] Fix crash when converting empty v8 string to atomic webkit string.
        https://bugs.webkit.org/show_bug.cgi?id=27975

        collection-null-like-arguments.html tests for this.

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8StringToAtomicWebCoreString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 4 Aug 2009 09:26:54 +0000 (09:26 +0000)]
2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool --commit-queue should validate commit-queue setter is a committer
        https://bugs.webkit.org/show_bug.cgi?id=27974

        With a test!

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/bugzilla_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 4 Aug 2009 08:59:19 +0000 (08:59 +0000)]
2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
        https://bugs.webkit.org/show_bug.cgi?id=27973

        The trailing comma (suppresses newlines) was lost in r46700.

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 4 Aug 2009 08:54:21 +0000 (08:54 +0000)]
2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool has too many fatal errors
        https://bugs.webkit.org/show_bug.cgi?id=27969

        Replace several fatal errors with ScriptError exceptions.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 4 Aug 2009 08:34:17 +0000 (08:34 +0000)]
2009-08-04  Eric Seidel  <eric@webkit.org>

        No review, ChangeLog fix only.

        Fix a ChangeLog line-spacing disaster caused by:
        https://bugs.webkit.org/show_bug.cgi?id=27973

        Still unsure what the fix for bugzilla-tool will be.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 4 Aug 2009 08:18:08 +0000 (08:18 +0000)]
2009-08-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool --commit-queue should only land commit-queue+ patches
        https://bugs.webkit.org/show_bug.cgi?id=27970

        commit-queue mode for bugzilla-tool
        https://bugs.webkit.org/show_bug.cgi?id=27918

        Make bugzilla tool smart enough to find the commit-queue+ flags and
        land those patches.
        When we call land-patches with --commit-queue, we should filter the
        patches we land to only those that have the commit-queue+ flag set.
        That way, when we call bugzilla-tool from a main commit queue process,
        we won't land the wrong patches.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 4 Aug 2009 08:14:47 +0000 (08:14 +0000)]
2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        committer logic should be split out of bugzilla.py into its own module

        https://bugs.webkit.org/show_bug.cgi?id=27972

        I also added unit tests for the functionality I added.

        * Scripts/modules/bugzilla.py:

        * Scripts/modules/bugzilla_unittest.py: Added.

        * Scripts/modules/commiters_unittest.py: Added.

        * Scripts/modules/committers.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-04 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 4 Aug 2009 07:13:01 +0000 (07:13 +0000)]
2009-08-04  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        selectionHasStyle needs clean up to fix Bug 27858
        https://bugs.webkit.org/show_bug.cgi?id=27865

        This patch cleans up selectionStartHasStyle and selectionHasStyle.
        No test is added because the patch does not change any behavior.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::getPropertiesNotInComputedStyle): Used in triStateOfStyleInComputedStyle but will be used here as well
        * editing/ApplyStyleCommand.h: Added the prototype of getPropertiesNotInComputedStyle
        * editing/Editor.cpp:
        (WebCore::triStateOfStyleInComputedStyle): Determines if the specified style is present in the specified computed style.
        (WebCore::Editor::selectionStartHasStyle): Uses triStateOfStyleInComputedStyle
        (WebCore::Editor::selectionHasStyle): Uses triStateOfStyleInComputedStyle instead of updateState

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 John Abd-El-Malek <jam@chromium.org>
abarth@webkit.org [Tue, 4 Aug 2009 07:06:02 +0000 (07:06 +0000)]
2009-08-03  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by David Levin.

        Fix MessagePort construction in worker process.  Also make the other object constructions match this.

        https://bugs.webkit.org/show_bug.cgi?id=27906

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertToV8Object):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setDOMException):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::ToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixup ChangeLog
abarth@webkit.org [Tue, 4 Aug 2009 06:34:02 +0000 (06:34 +0000)]
Fixup ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Harald Fernengel <harald.fernengel@nokia.com>
abarth@webkit.org [Tue, 4 Aug 2009 06:14:33 +0000 (06:14 +0000)]
2009-08-03  Harald Fernengel  <harald.fernengel@nokia.com>

        Reviewed by NOBODY

        Fix ambiguity in abs(long int) call by calling labs() instead

        * wtf/DateMath.cpp: replace call to abs() with labs()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
levin@chromium.org [Tue, 4 Aug 2009 05:39:11 +0000 (05:39 +0000)]
2009-08-03  Christian Plesner Hansen  <christian.plesner.hansen@gmail.com>

        Reviewed by David Levin.

        [V8] Cache atomic strings in externalized v8 strings
        https://bugs.webkit.org/show_bug.cgi?id=27762

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Binding.cpp:
        (WebCore::WebCoreStringResource::WebCoreStringResource):
        (WebCore::WebCoreStringResource::~WebCoreStringResource):
        (WebCore::WebCoreStringResource::data):
        (WebCore::WebCoreStringResource::length):
        (WebCore::WebCoreStringResource::webcoreString):
        (WebCore::WebCoreStringResource::atomicString):
        (WebCore::WebCoreStringResource::toStringResource):
        (WebCore::v8StringToWebCoreString):
        (WebCore::v8StringToAtomicWebCoreString):
        (WebCore::v8ValueToWebCoreString):
        (WebCore::v8ValueToAtomicWebCoreString):
        * bindings/v8/V8Binding.h:
        (WebCore::):
        * dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Tue, 4 Aug 2009 02:21:57 +0000 (02:21 +0000)]
2009-08-03  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: DOM Storage Live Updating Should Not Affect Tabbing
        https://bugs.webkit.org/show_bug.cgi?id=27957

        * inspector/front-end/DOMStorageDataGrid.js:
        (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): disable storage event listener
        (WebInspector.DOMStorageDataGrid.prototype._startEditing): disable storage event listener
        (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): enable storage event listener
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): quick return if no listener

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
abarth@webkit.org [Tue, 4 Aug 2009 02:14:20 +0000 (02:14 +0000)]
2009-08-03  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Consolidate common gcc flags to WebKit.pri
        https://bugs.webkit.org/show_bug.cgi?id=27934

        * JavaScriptCore.pro:

2009-08-03  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Consolidate common gcc flags to WebKit.pri
        https://bugs.webkit.org/show_bug.cgi?id=27934

        * WebCore.pro:

2009-08-03  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Consolidate common gcc flags to WebKit.pri
        https://bugs.webkit.org/show_bug.cgi?id=27934

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Tue, 4 Aug 2009 01:29:29 +0000 (01:29 +0000)]
2009-08-03  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Handle any kind of line endings in svn-apply and svn-unapply, instead
        of assuming LF.

        * Scripts/svn-apply:
        * Scripts/svn-unapply:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 4 Aug 2009 01:08:54 +0000 (01:08 +0000)]
2009-08-03  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Chromium code sometimes isn't sandboxed and needs to access the FS.
        https://bugs.webkit.org/show_bug.cgi?id=27954

        These changes are the WebKit side of http://codereview.chromium.org/159778 which
        aims to make LocalStorage persistent.

        This change runs all FileSystem routines through the ChromiumBridge so that
        WebKitClients can handle them if they choose to.  For now, the only such client
        will be the one running in the browser process.

        It also adds a method called sandboxEnabled to the Chromium bridge so that the
        SQLite file system code can shift its behavior depending on whether we're
        inside a sandbox or not.

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/FileSystemChromium.cpp:
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileModificationTime):
        (WebCore::directoryName):
        (WebCore::pathByAppendingComponent):
        (WebCore::makeAllDirectories):
        (WebCore::fileExists):
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
        (WebCore::SQLiteFileSystem::openDatabase):
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
        (WebCore::SQLiteFileSystem::registerSQLiteVFS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Alpha Lam <hclam@chromium.org>
abarth@webkit.org [Tue, 4 Aug 2009 00:43:52 +0000 (00:43 +0000)]
2009-08-03  Alpha Lam  <hclam@chromium.org>

        Reviewed by David Levin.

        [chromium] Implement media slider for chromium
        https://bugs.webkit.org/show_bug.cgi?id=27859

        Implemented the media slider for chromium port. The implementation
        is using Skia for drawing the thumb and buffered region instead of
        using any native system controls so different platforms would have
        the same look and feel.

        No new tests because this is covered by existing tests.

        * css/mediaControlsChromium.css:
        * rendering/RenderThemeChromiumSkia.cpp:
        * rendering/RenderThemeChromiumSkia.h:
        * rendering/RenderThemeChromiumWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 4 Aug 2009 00:28:21 +0000 (00:28 +0000)]
2009-08-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool land-patches needs --queue mode
        https://bugs.webkit.org/show_bug.cgi?id=27961

        Add a --commit-queue command line option to suppress user interaction.

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-27 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Mon, 3 Aug 2009 23:48:26 +0000 (23:48 +0000)]
2009-07-27  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26460
        Plumbing and cleanup in advance of returning multiple frames from the
        ICOImageDecoder:
        * Make ImageDecoder::frameCount() return a size_t like
          ImageSource::frameCount() and BitmapImage::frameCount() already do.
        * Add ImageDecoder::frameSizeAtIndex() alongside size(), to report the
          size of a particular frame.  Hook all the
          ImageSource::frameSizeAtIndex() implementations to this.  No
          ImageDecoder implements this yet; that will come in my next change.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::frameCount): returns size_t.
        * platform/graphics/qt/ImageDecoderQt.h: frameCount() returns size_t.
        * platform/graphics/qt/ImageSourceQt.cpp:
        (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
        * platform/graphics/skia/ImageSourceSkia.cpp:
        (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
        * platform/graphics/win/ImageCGWin.cpp:
        (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
        * platform/graphics/win/ImageCairoWin.cpp:
        (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::size): Clarify comment.
        (WebCore::ImageDecoder::frameSizeAtIndex): Add.
        (WebCore::ImageDecoder::frameCount): returns size_t.
        (WebCore::ImageDecoder::frameBufferAtIndex): Remove unneeded param name.
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::frameCount): returns size_t.
        (WebCore::GIFImageDecoder::frameBufferAtIndex): frameCount() returns size_t.
        * platform/image-decoders/gif/GIFImageDecoder.h: frameCount() returns size_t.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Add installsrc, installhdrs and install targets.
mrowe@apple.com [Mon, 3 Aug 2009 23:42:56 +0000 (23:42 +0000)]
Build fix.  Add installsrc, installhdrs and install targets.

* DumpRenderTree/mac/PerlSupport/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Dumitru Daniliuc <dumi@chromium.org>
dglazkov@chromium.org [Mon, 3 Aug 2009 22:59:06 +0000 (22:59 +0000)]
2009-08-03  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that could cause an ASSERT to fail incorrectly, leading
        to a renderer crash in Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=27947

        All tests in storage/ pass.

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::~SQLiteTransaction):
        (WebCore::SQLiteTransaction::begin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate two WordPress plug-ins that we use.
mrowe@apple.com [Mon, 3 Aug 2009 22:05:41 +0000 (22:05 +0000)]
Update two WordPress plug-ins that we use.

* blog/wp-content/plugins/akismet/akismet.php:
* blog/wp-content/plugins/akismet/readme.txt:
* blog/wp-content/plugins/commentcontrol.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some missing files and delete some obsolete files.
mrowe@apple.com [Mon, 3 Aug 2009 22:02:30 +0000 (22:02 +0000)]
Add some missing files and delete some obsolete files.

* blog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Mon, 3 Aug 2009 21:55:14 +0000 (21:55 +0000)]
2009-08-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Simon Hausmann.

        Based on work by Yael Aharon.

        Implement keyboard event forwarding for windowless plugins
        for the Qt port.

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::dispatchNPEvent):
        (WebCore::setSharedXEventFields):
        (WebCore::setXKeyEventSpecificFields):
        (WebCore::PluginView::handleKeyboardEvent):
        (WebCore::PluginView::handleMouseEvent):
        * xml/NativeXPathNSResolver.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the bottom "drawer" of the Web Inspector more extensible to support other views.
timothy@apple.com [Mon, 3 Aug 2009 21:28:32 +0000 (21:28 +0000)]
Make the bottom "drawer" of the Web Inspector more extensible to support other views.

2009-08-03  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
        https://bugs.webkit.org/show_bug.cgi?id=27928

        * English.lproj/localizedStrings.js:

          "Show changes view", "Hide changes view", "Clear changes log", "%d style change", "%d style changes"

        * inspector/front-end/ChangesView.js: Added.
        (WebInspector.ChangesView):
        (WebInspector.ChangesView.prototype._clearButtonClicked):
        (WebInspector.ChangesView.prototype._toggleChangesButtonClicked):
        (WebInspector.ChangesView.prototype.attach):
        (WebInspector.ChangesView.prototype.show):
        (WebInspector.ChangesView.prototype.hide):

          To be a new view to show Changes made via the inspector.  DOM, CSS, or otherwise.

        * inspector/front-end/Console.js: Removed.

          Sliding View aspect moved to Drawer.js.  The "console" itself has moved to ConsoleView.js

        * inspector/front-end/ConsoleView.js: Added.

          Little has changed from its move from Console.js other then support for working with the Drawer.

        * inspector/front-end/Drawer.js: Added.
        (WebInspector.Drawer):
        (WebInspector.Drawer.prototype.get visibleView):
        (WebInspector.Drawer.prototype.set visibleView):
        (WebInspector.Drawer.prototype.show.animationFinished):
        (WebInspector.Drawer.prototype.show):
        (WebInspector.Drawer.prototype.hide.animationFinished):
        (WebInspector.Drawer.prototype.hide):
        (WebInspector.Drawer.prototype._safelyRemoveChildren):
        (WebInspector.Drawer.prototype._startStatusBarDragging):
        (WebInspector.Drawer.prototype._statusBarDragging):
        (WebInspector.Drawer.prototype._endStatusBarDragging):

          Allow for multiple views inside the Sliding Drawer.

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype.renameSelector):
        (WebInspector.ElementsPanel.prototype.addStyleChange):
        (WebInspector.ElementsPanel.prototype.removeStyleChange):
        (WebInspector.ElementsPanel.prototype.generateStylesheet):

          Starting work on the "Changes" Panel. The ability to generate a Stylesheet from Styles added via the Inspector.

        * inspector/front-end/Images/styleIcon.png: Added.

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype.isInspectorStylesheet):
        (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
        (WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
        (WebInspector.StylePropertyTreeElement.prototype):

          Interface with ElementsPanel for generating a Stylesheet of Changes.

        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css: Refactored to allow for multiple views in the drawer.
        * inspector/front-end/inspector.html: Refactored to allow for multiple views in the drawer.

        * inspector/front-end/inspector.js:
        (WebInspector.get styleChanges):
        (WebInspector.set styleChanges):
        (WebInspector._updateChangesCount):
        (WebInspector.loaded):
        (WebInspector.documentKeyDown):
        (WebInspector.showConsole):
        (WebInspector.showChanges):

          Support for the drawer and "styles changed icon" similar to the "errors and warnings" icons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate WordPress to the latest version.
mrowe@apple.com [Mon, 3 Aug 2009 21:24:34 +0000 (21:24 +0000)]
Update WordPress to the latest version.

* blog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Dean McNamee <deanm@chromium.org>
abarth@webkit.org [Mon, 3 Aug 2009 21:00:53 +0000 (21:00 +0000)]
2009-08-03  Dean McNamee  <deanm@chromium.org>

        Reviewed by Adam Barth.

        Correct an assert on a PassRefPtr in the v8 svg bindings.
        https://bugs.webkit.org/show_bug.cgi?id=27951

        * bindings/v8/V8SVGPODTypeWrapper.h:
        (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 3 Aug 2009 20:23:45 +0000 (20:23 +0000)]
2009-08-03  Jan Michael Alonzo  <jmalonzo@webkit.org>

        [Gtk] Skip accessibility/input-slider.html as it needs
        Accessibility support in DRT which the Gtk do not have an
        implementation at the moment.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
weinig@apple.com [Mon, 3 Aug 2009 20:00:47 +0000 (20:00 +0000)]
WebCore:

2009-08-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=27748
        crash w/ stack overflow when same CSS file loaded repeatedly

        Fix crash caused by a stack overflow when repeatedly loading very large
        CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
        recursively rather than iteratively.

        Test: fast/css/large-list-of-rules-crash.html

        * css/CSSStyleSelector.h:
        (WebCore::CSSRuleData::~CSSRuleData):
        (WebCore::CSSRuleDataList::~CSSRuleDataList):

LayoutTests:

2009-08-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Sam Weinig.

        Test for https://bugs.webkit.org/show_bug.cgi?id=27748
        crash w/ stack overflow when same CSS file loaded repeatedly

        Fix crash caused by a stack overflow when repeatedly loading very large
        CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
        recursively rather than iteratively.

        * fast/css/large-list-of-rules-crash-expected.txt: Added.
        * fast/css/large-list-of-rules-crash.html: Added.
        * fast/css/resources/large-list-of-rules-crash.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 3 Aug 2009 19:40:12 +0000 (19:40 +0000)]
2009-08-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Make the DRT APIs to pause transitions and animations work for accelerated animations
        <https://bugs.webkit.org/show_bug.cgi?id=27627>
        <rdar://problem/6442932>

        Fix the 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' APIs
        available to LayoutTests to work with accelerated animations and transitions. Done by sending
        the pause time down to the GraphicsLayer, and using it to stop time on the layer.

        I also added an assertion to check that the animation has actually started when we
        try to pause it, to check that the pause time we compute is valid. This revealed a number
        of tests that tried to pause before animations started, required some amount of test fixing.

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::freezeAtTime):
        * page/animation/AnimationBase.h:
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::pauseAnimationAtTime):
        (WebCore::CompositeAnimation::pauseTransitionAtTime):
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::suspendAnimations):
        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/mac/GraphicsLayerCA.h:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::suspendAnimations):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::suspendAnimations):
        * rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Tony Chang <tony@chromium.org>
abarth@webkit.org [Mon, 3 Aug 2009 18:47:26 +0000 (18:47 +0000)]
2009-08-03  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Fix Chromium build by removing PluginView.h from Page.cpp.
        Chromium doesn't use PluginView and the pointer is never
        dereferenced so the header doesn't need to be included.
        https://bugs.webkit.org/show_bug.cgi?id=27946

        No new tests because this is a build fix.

        * page/Page.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fixed the Tiger build.
adachan@apple.com [Mon, 3 Aug 2009 18:46:56 +0000 (18:46 +0000)]
    Fixed the Tiger build.

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
adachan@apple.com [Mon, 3 Aug 2009 18:34:19 +0000 (18:34 +0000)]
    Reviewed by Darin Adler.

        Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=27900

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 3 Aug 2009 18:00:05 +0000 (18:00 +0000)]
2009-08-03  Eric Carlson  <eric.carlson@apple.com>

        One more build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.

        Unreviewed.

        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 3 Aug 2009 17:34:13 +0000 (17:34 +0000)]
2009-08-03  Eric Carlson  <eric.carlson@apple.com>

        Build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.

        Unreviewed.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 27943 - Need to implement ARIA role="radiogroup"
cfleizach@apple.com [Mon, 3 Aug 2009 17:13:33 +0000 (17:13 +0000)]
Bug 27943 - Need to implement ARIA role="radiogroup"
https://bugs.webkit.org/show_bug.cgi?id=27943

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 3 Aug 2009 17:07:45 +0000 (17:07 +0000)]
2009-08-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        HTMLInputElement is not controllable by assistive technologies
        https://bugs.webkit.org/show_bug.cgi?id=27941

        Test: accessibility/input-slider.html

        * WebCore.xcodeproj/project.pbxproj:
            Add AccessibilitySlider.cpp/.h

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::getOrCreate):
            Create AccessibilitySlider and AccessibilitySliderThumb.

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::increment):
        (WebCore::AccessibilityObject::decrement):
            Add default, do nothing, base class methods.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
            Correct typo.

        * accessibility/AccessibilitySlider.cpp: Added.
        (WebCore::AccessibilitySlider::AccessibilitySlider):
        (WebCore::AccessibilitySlider::create):
        (WebCore::AccessibilitySlider::children):
        (WebCore::AccessibilitySlider::addChildren):
        (WebCore::AccessibilitySlider::getAttribute):
        (WebCore::AccessibilitySlider::valueForRange):
        (WebCore::AccessibilitySlider::maxValueForRange):
        (WebCore::AccessibilitySlider::minValueForRange):
        (WebCore::AccessibilitySlider::changeValue):
        (WebCore::AccessibilitySlider::setValue):
        (WebCore::AccessibilitySlider::increment):
        (WebCore::AccessibilitySlider::decrement):
        (WebCore::AccessibilitySlider::element):
        (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
        (WebCore::AccessibilitySliderThumb::create):
        (WebCore::AccessibilitySliderThumb::elementRect):
        (WebCore::AccessibilitySliderThumb::size):
        * accessibility/AccessibilitySlider.h: Added.
        (WebCore::AccessibilitySlider::~AccessibilitySlider):
        (WebCore::AccessibilitySlider::roleValue):
        (WebCore::AccessibilitySlider::accessibilityIsIgnored):
        (WebCore::AccessibilitySlider::isSlider):
        (WebCore::AccessibilitySlider::canSetValueAttribute):
        (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
        (WebCore::AccessibilitySliderThumb::roleValue):
        (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
        (WebCore::AccessibilitySliderThumb::setParentObject):
        (WebCore::AccessibilitySliderThumb::parentObject):

        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (RoleEntry::):
            SliderThumbRole -> NSAccessibilityValueIndicatorRole
        (-[AccessibilityObjectWrapper roleDescription]):
            Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
            Minor coding style correction.
        (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
            If attachement view handles press action, don't also call object wrapper.
        (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
            New, call object's increment() method.
        (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
            New, call object's decrement() method.
        (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
            Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.

        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::thumbRect):
            Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.
        (WebCore::RenderSlider::layout):
            Move code to thumbRect().
        * rendering/RenderSlider.h:

2009-08-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        HTMLInputElement is not controllable by assistive technologies
        https://bugs.webkit.org/show_bug.cgi?id=27941

        Accessibility control of a slider required adding increment() and decrement()
        methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (incrementCallback): New, call UI element increment method.
        (decrementCallback): New, call UI element decrement method.
        (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.

        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper.
        (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.

        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::increment): New, do nothing.
        (AccessibilityUIElement::decrement): New, do nothing.

2009-08-03  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        HTMLInputElement is not controllable by assistive technologies
        https://bugs.webkit.org/show_bug.cgi?id=27941

        Add test for <input type=range> accessibility .

        * accessibility/input-slider.html: Added.
        * platform/mac/accessibility/input-slider-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
kenneth@webkit.org [Mon, 3 Aug 2009 17:00:56 +0000 (17:00 +0000)]
2009-08-03  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Build fix if Netscape plugin support is turned off
        https://bugs.webkit.org/show_bug.cgi?id=27940

        * plugins/PluginView.cpp:
        (WebCore::PluginView::stop): Do not call NPN_MemFree if NPAPI is
        disabled
        * plugins/PluginViewNone.cpp:
        (WebCore::PluginView::platformStart): Empty stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-31 Joe Mason <joe.mason@torchmobile.com>
ben@webkit.org [Mon, 3 Aug 2009 16:12:38 +0000 (16:12 +0000)]
2009-07-31  Joe Mason  <joe.mason@torchmobile.com>

        Reviewed by George Staikos.

        WINCE port: LOAD_WITH_ALTERED_SEARCH_PATH param of
        LoadLibraryEx not supported on WINCE
        https://bugs.webkit.org/show_bug.cgi?id=27917

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::load):use LoadLibrary instead of LoadLibraryEx

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
hausmann@webkit.org [Mon, 3 Aug 2009 14:50:20 +0000 (14:50 +0000)]
2009-08-03  Balazs Kelemen  <kelemen.balazs.3@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Do memory cleanup when running robotized QtLauncher in debug as well.

        * QtLauncher/main.cpp:
        (launcherMain):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Fumitoshi Ukai <ukai@chromium.org>
jmalonzo@webkit.org [Mon, 3 Aug 2009 12:03:38 +0000 (12:03 +0000)]
2009-08-03  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Jan Alonzo.

        Fix build break on Gtk/x86_64.
        https://bugs.webkit.org/show_bug.cgi?id=27936

        Use JSVALUE64 for X86_64 LINUX, except Qt.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix ChangeLog - r46714 was rubber-stamped by Eric
jmalonzo@webkit.org [Mon, 3 Aug 2009 10:27:36 +0000 (10:27 +0000)]
Fix ChangeLog - r46714 was rubber-stamped by Eric

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 3 Aug 2009 10:23:43 +0000 (10:23 +0000)]
2009-08-03  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Eric Seidel.

        [Gtk] macros in webkit.m4 should be defined once only
        https://bugs.webkit.org/show_bug.cgi?id=27929

        The macros in webkit.m4 are not meant to be called multiple times
        so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
        AC_REQUIRE to remove the automake warnings when doing autogen.sh.

        * autotools/webkit.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove extra linebreaks in WebCore/ChangeLog introduced in r46711
vestbo@webkit.org [Mon, 3 Aug 2009 09:14:22 +0000 (09:14 +0000)]
Remove extra linebreaks in WebCore/ChangeLog introduced in r46711

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 3 Aug 2009 06:33:07 +0000 (06:33 +0000)]
2009-08-02  Xan Lopez  <xlopez@igalia.com>

        Fix the GTK+ build.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 3 Aug 2009 04:12:37 +0000 (04:12 +0000)]
2009-08-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        SVGElementInstance::scriptExecutionContext should call document() instead of scriptExecutionContext()

        https://bugs.webkit.org/show_bug.cgi?id=27932

        There's no reason to pay for a virtual function call in this case.  We

        can just call document() directly because we know that element is a

        Node*.

        * svg/SVGElementInstance.cpp:

        (WebCore::SVGElementInstance::scriptExecutionContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 3 Aug 2009 03:49:58 +0000 (03:49 +0000)]
2009-08-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        JSNodeCustom should call document() instead of scriptExecutionContext()
        https://bugs.webkit.org/show_bug.cgi?id=27931

        We want to call document() because it's in inline function, instead of
        scriptExecutionContext() because it's a virtual function.  If we have a
        Node*, then we know that the virtual function will always return the
        document anyway.

        There are more instance of this bug, but I'd like to start with a small
        patch and work up.

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::toJSDOMGlobalObject):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 2 Aug 2009 23:10:24 +0000 (23:10 +0000)]
2009-08-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Disabled JSVALUE32_64 on Qt builds, since all layout tests mysteriously
        crash with it enabled.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 2 Aug 2009 23:08:00 +0000 (23:08 +0000)]
2009-08-02  Sam Weinig  <sam@webkit.org>

        Land updated expected result.

        * fast/js/array-filter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 2 Aug 2009 22:48:47 +0000 (22:48 +0000)]
2009-08-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Speed up fast/js/array-filter.html by 10x in debug builds by not using an
        unnecessarily large sparse array.

        * fast/js/resources/array-filter.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 2 Aug 2009 22:10:21 +0000 (22:10 +0000)]
2009-08-02  Geoffrey Garen  <ggaren@apple.com>

        Qt build fix.

        Added JSAPIValueWrapper.cpp to the build.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 2 Aug 2009 22:00:05 +0000 (22:00 +0000)]
2009-08-02  Geoffrey Garen  <ggaren@apple.com>

        Windows build fix.

        Exported symbols for JSAPIValueWrapper.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 2 Aug 2009 21:56:23 +0000 (21:56 +0000)]
2009-08-02  Geoffrey Garen  <ggaren@apple.com>

        GTK build fix.

        * jit/JITStubs.cpp: #include <stdarg.h>, for a definition of va_start.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 2 Aug 2009 21:52:17 +0000 (21:52 +0000)]
2009-08-02  Geoffrey Garen  <ggaren@apple.com>

        Qt build fix.

        * runtime/Collector.cpp: #include <limits.h>, for a definition of ULONG_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 2 Aug 2009 21:45:45 +0000 (21:45 +0000)]
2009-08-02  Geoffrey Garen  <ggaren@apple.com>

        Windows build fix: Nixed JSImmediate::prototype, JSImmediate::toObject,
        and JSImmediate::toThisObject, and removed their exported symbols.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
        * runtime/JSImmediate.cpp:
        * runtime/JSImmediate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 2 Aug 2009 21:33:48 +0000 (21:33 +0000)]
2009-08-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Enabled JSVALUE32_64 by default on all platforms other than x86_64 (which uses JSVALUE64).

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-02 David D. Kilzer <ddkilzer@webkit.org>
ddkilzer@apple.com [Sun, 2 Aug 2009 14:26:57 +0000 (14:26 +0000)]
2009-08-02  David D. Kilzer  <ddkilzer@webkit.org>

        <http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø

        Reviewed by Tor Arne Vestbø.

        * Scripts/bugzilla-tool:
        (set_reviewer_in_changelog): Made sure reviewer is properly
        encoded when calling replace().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Sun, 2 Aug 2009 14:09:32 +0000 (14:09 +0000)]
2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Anders Carlsson.

        Share implementation of PluginView::userAgent() and userAgentStatic()

        https://bugs.webkit.org/show_bug.cgi?id=27706

        Differences to the original implementation are as follows:

            - The Win port used to return 0 for userAgentStatic, but now
              returns the quirk mode MozillaUserAgent as the other ports.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::userAgent):
        (WebCore::PluginView::userAgentStatic):
        * plugins/PluginViewNone.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/mac/PluginViewMac.cpp:
        * plugins/qt/PluginViewQt.cpp:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Sun, 2 Aug 2009 14:00:29 +0000 (14:00 +0000)]
2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Anders Carlsson.

        Unregister plugin from PluginMainThreadScheduler if NPP_New fails

        https://bugs.webkit.org/show_bug.cgi?id=27706

        Since the plugin has not been started yet (m_isStarted is not set),
        calling stop() will not have any affect, so we manually unregister
        in start() before returning.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-07-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Sun, 2 Aug 2009 13:47:51 +0000 (13:47 +0000)]
2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Anders Calsson.

        Join the various versions of PluginView::stop() into one shared implementation

        https://bugs.webkit.org/show_bug.cgi?id=27706

        The platform-dependent bits are now ifdef'ed in the shared implementation,
        using the XP_ defines (XP_WIN, XP_MACOSX, XP_UNIX) from npapi.h

        Differences to the original implementation are as follows:

            - The Qt port unregistered the plugin before calling NP_SetWindow
              with a 0 window handle. Now it's done after (similar to Win)

            - The GTK and Qt ports unregistered the plugin before clearing
              the m_npWindow.ws_info struct. Now it's done after.

            - The Win port constructed the DropAllLocks after unsubclassing
              the window. Now it's done before.

            - The Mac, Qt, and GTK ports did not pass a NPSavedData struct
              to NP_Destroy (like the Win port). Now all ports do.

            - The Win port did not call PluginView::setCurrentPluginView()
              before calling to NP-functions. Now it does.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::start):
        (WebCore::PluginView::~PluginView):
        (WebCore::PluginView::stop):
        * plugins/PluginViewNone.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/mac/PluginViewMac.cpp:
        (WebCore::PluginView::getValueStatic):
        * plugins/qt/PluginViewQt.cpp:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::handlePostReadFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46697 268f45cc-cd09-0410-ab3c-d52691b4dbfc