WebKit-https.git
17 years agoChecking in the layout test results using our current defaults and not ancient crufty...
hyatt [Fri, 24 Oct 2003 21:20:32 +0000 (21:20 +0000)]
Checking in the layout test results using our current defaults and not ancient crufty defaults.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Two fixes to the computation of min/max width for text runs.
hyatt [Fri, 24 Oct 2003 21:07:51 +0000 (21:07 +0000)]
Two fixes to the computation of min/max width for text runs.
(1) Make sure that pre runs don't add in word-spacing to the last word on a line (e.g., when a newline explicitly
breaks a pre).
(2) Fix a bug where breakable characters weren't getting factored into minwidth properly.  When a word got broken
because of a breakable character, we were treating the breakable character like a space, and not including its
width as part of the minimum width of the text run.

        Reviewed by john

        * khtml/rendering/render_text.cpp:
        (RenderText::calcMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3424039>: standalone plug-in content occasionaly redirects...
cblu [Fri, 24 Oct 2003 21:05:20 +0000 (21:05 +0000)]
Fixed: <rdar://problem/3424039>: standalone plug-in content occasionaly redirects to blank page

        Reviewed by john.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): don't honor JS requests from standalone plug-ins to workaround 3462628 which is a deeper issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3462256>: REGRESSION: Plain text is downloaded
cblu [Fri, 24 Oct 2003 16:06:56 +0000 (16:06 +0000)]
Fixed: <rdar://problem/3462256>: REGRESSION: Plain text is downloaded

        Reviewed by john.

        * WebView.subproj/WebView.m:
(+[WebView _viewClass:andRepresentationClass:forMIMEType:]): use _web_objectForMIMEType when getting an object for a MIME. Removed unnecessary code that checked for the document classes after loading the plug-in DB since it is not an optimization because the plug-in DB calls _viewTypesAllowImageTypeOmission:NO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3364036>: ER: Allow plug-ins to override built-in types such...
cblu [Thu, 23 Oct 2003 23:47:19 +0000 (23:47 +0000)]
Fixed: <rdar://problem/3364036>: ER: Allow plug-ins to override built-in types such as image/jpeg

        Reviewed by john.

        * Plugins.subproj/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]): Allow plug-ins to override built-in types except for our core HTML types and don't allow the QT plug-in to override any types because it handles many types that we already handle
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:): instead of asserting, handle the case where we ask a plug-in to map from an extension to a MIME type, but nil is returned
        (-[WebBridge frameRequiredForMIMEType:URL:]): no need to start up the plug-in DB because this is now handled by [WebView _viewClass:andRepresentationClass:forMIMEType:]
        * WebView.subproj/WebDataSource.m:
        (+[WebDataSource _representationClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:]
        (-[WebDataSource _makeRepresentation]): call _representationClassForMIMEType
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView _makeDocumentViewForDataSource:]): tweak
        (+[WebFrameView _viewClassForMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:]
        * WebView.subproj/WebView.m:
(+[WebView _viewClass:andRepresentationClass:forMIMEType:]): new, central place for mapping from a MIME to the document classes. We now load the plug-in DB when a non-HTML MIME type is encountered instead of loading the plug-in DB when the class for the MIME type is not found. This is required to fully fix 3364036.
        (+[WebView canShowMIMEType:]): call [WebView _viewClass:andRepresentationClass:forMIMEType:]
        (+[WebView registerViewClass:representationClass:forMIMEType:]): tweak
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding generated content tests for fancy first-letter/line combos.
hyatt [Thu, 23 Oct 2003 22:24:09 +0000 (22:24 +0000)]
Adding generated content tests for fancy first-letter/line combos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago This patch fixes the pseudo-elements ::first-line and ::first-letter to inherit...
hyatt [Thu, 23 Oct 2003 22:23:25 +0000 (22:23 +0000)]
This patch fixes the pseudo-elements ::first-line and ::first-letter to inherit styles properly.  More
specifically it does the following:

(1) Implements caching of pseudo-styles once computed off the style() which originated the pseudo-style.
The old code did this, and this was a regression from my previous patch.

(2) Fixes first-letter checking so that it happens at layout time rather than during render object
construction time, since that makes first-letter more dynamic and causes it to be discovered in cases
where it was being missed before.  This fixes the front page of meyerweb.com.

(3) Make first-letter inherit from first-line like it's supposed to, and also make first-line styles
cross blocks and inherit properly from enclosing containers.

(4) Make first-letter changes cause a detach/attach to fire just as when the display changes.  I generalized
the notion of needing to detach on a style change by making it a new kind of hint in dom_nodeimpl's style
diff function.

(5) Fixed isBlockFlow to return true for inline-blocks.

        Reviewed by john

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::addChildToFlow):
        (khtml::RenderBlock::layoutBlock):
        (khtml::RenderBlock::getFirstLineBox):
        (khtml::RenderBlock::firstLineBlock):
        (khtml::RenderBlock::updateFirstLetter):
        * khtml/rendering/render_block.h:
        (khtml::RenderBlock::isBlockFlow):
        * khtml/rendering/render_line.cpp:
        (InlineFlowBox::paintBackgroundAndBorder):
        * khtml/rendering/render_list.cpp:
        (RenderListItem::setStyle):
        * khtml/rendering/render_object.cpp:
        (RenderObject::RenderObject):
        (RenderObject::firstLineBlock):
        (RenderObject::updateFirstLetter):
        (RenderObject::dump):
        (RenderObject::setStyle):
        (RenderObject::recalcMinMaxWidths):
        (RenderObject::style):
        (RenderObject::getPseudoStyle):
        * khtml/rendering/render_object.h:
        (khtml::RenderObject::overhangingContents):
        * khtml/rendering/render_style.cpp:
        (pseudoBit):
        * khtml/rendering/render_style.h:
        (khtml::RenderStyle::):
        * khtml/rendering/render_table.cpp:
        (RenderTable::firstLineBlock):
        (RenderTable::updateFirstLetter):
        * khtml/rendering/render_table.h:
        * khtml/rendering/render_text.cpp:
        (RenderText::paintObject):
        (RenderText::htmlFont):
        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::recalcStyle):
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::diff):
        * khtml/xml/dom_nodeimpl.h:
        (DOM::NodeImpl::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed 3459272 -- Can't set up keyboard loop inside a
sullivan [Thu, 23 Oct 2003 19:25:24 +0000 (19:25 +0000)]
- fixed 3459272 -- Can't set up keyboard loop inside a
WebDocumentView without subclassing views
- fixed 3179062 -- can't tab back to address bar from image-only
page
- fixed 3252009 -- tabbing from address bar to content area does
not work with WebTextView
- fixed 3461398 -- Can't click on a standalone image to focus it
(for later keyboard scrolling)

I redid the way WebView and WebFrameView splice themselves into
the keyview loop in a way very similar to what NSScrollView and
NSClipView do. This means that contained and sibling views won't
need to do anything special to put themselves into the key loop.

        Reviewed by Chris.

        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView _scrollView]):
check for nil pointer before dereferencing; this can happen
during [super dealloc]'s keyview-loop-fixup code
(-[WebFrameView initWithFrame:]):
wire our nextKeyView link to the contained scrollview (so
previousKeyView will work correctly from scrollview)
        (-[WebFrameView acceptsFirstResponder]):
return what the contained scrollview says
        (-[WebFrameView becomeFirstResponder]):
in previous direction, use previousValidKeyView (follows normal
NSView keyview links); in forward direction, hand first
responder-ness to contained scrollview (which will in turn hand
it down to clipview, which will in turn hand it down to document)
        (-[WebFrameView setNextKeyView:]):
wire up scrollview instead of self, if it exists

        * WebView.subproj/WebImageView.m:
        (-[WebImageView acceptsFirstResponder]):
overridden to return YES; this fixes 3461398 and puts the finishing
touches on 3179062

        * WebView.subproj/WebView.m:
        (-[WebView _commonInitializationWithFrameName:groupName:]):
wire our nextKeyView link to the contained webframeview (so
previousKeyView will work correctly from webframeview). Also,
if there's a nextKeyView already set (in a nib, e.g.), wire
it to our contained webframeview.
        (-[WebView acceptsFirstResponder]):
return what the contained webframeview says
        (-[WebView becomeFirstResponder]):
in previous direction, use previousValidKeyView (follows normal
NSView keyview links); in forward direction, hand first
responder-ness to contained webframeview (which will in turn hand
it down to scrollview, etc.)
        (-[WebView setNextKeyView:]):
wire up webframeview instead of self, if it exists

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by David
kocienda [Thu, 23 Oct 2003 15:41:02 +0000 (15:41 +0000)]
    Reviewed by David

Fix for these bugs:

<rdar://problem/3171929>: Safari picks a different button in a
form when you hit return if the first button has no name
<rdar://problem/3200386>: investigate which button is activated
when hitting return in form text input fields

HTML spec says that buttons must have names to be considered
successful. However, other browsers do not impose this constraint.
Therefore, we behave differently, and can use different buttons than
the author intended.

        * khtml/html/html_formimpl.cpp:
        (HTMLButtonElementImpl::isSuccessfulSubmitButton)
        (HTMLInputElementImpl::isSuccessfulSubmitButton)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3460726, the user agent string was returning nil.
hyatt [Thu, 23 Oct 2003 02:03:57 +0000 (02:03 +0000)]
Fix for 3460726, the user agent string was returning nil.

Fix for 3386544, empty documents did not get a layout, and so they looked white.  Also fixed the positioning
of widgets to account for border/padding in updateWidgetPositions.

Fix for espn.com crasher, 3458143, caused by layout object not being properly cleared when layouts were
unscheduled.

        Reviewed by darin

        * khtml/khtmlview.cpp:
        * khtml/rendering/render_canvas.cpp:
        (RenderCanvas::RenderCanvas):
        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::updateWidgetPositions):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::userAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by
mjs [Thu, 23 Oct 2003 01:01:12 +0000 (01:01 +0000)]
    Reviewed by

- fixed 3460664 - Exception handlers not properly removed

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::mouseMoved): Don't return from exception block
        (KWQKHTMLPart::khtmlMouseReleaseEvent): Add exception blocking (whoops)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed 3460652 -- REGRESSION (100-110+): Can't tab out of a
sullivan [Thu, 23 Oct 2003 00:43:44 +0000 (00:43 +0000)]
- fixed 3460652 -- REGRESSION (100-110+): Can't tab out of a
frameset page

        Reviewed by Darin (actually he made the change on my machine)

        * khtml/html/html_baseimpl.cpp:
        (HTMLFrameSetElementImpl::defaultEventHandler):
only set defaultHandled for the one event that we actually
handle (mouse event to resize frame borders); this was always
being set, hence preventing key events from being used elsewhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoUpdated to account for change in metrics
rjw [Thu, 23 Oct 2003 00:27:15 +0000 (00:27 +0000)]
Updated to account for change in metrics

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Thu, 23 Oct 2003 00:10:53 +0000 (00:10 +0000)]
WebKit:
Match WebCore's notion of distributing linegap between top and bottom of
line.  WebKit used to put it all at the bottom of the line.

        Reviewed by Hyatt.

        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer initWithFont:usingPrinterFont:]):
        (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):

WebCore:
Fixed 3454067.  RenderText's repaint wasn't called because of recent changes to de-virtualize repaint.  Modified getAbsoluteRepaintRect() to return containing block's getAbsoluteRepaintRect().

Also removed the long standing +1 from QFontMetrics::height().

        Reviewed by Hyatt.

        * khtml/rendering/render_text.cpp:
        (RenderText::getAbsoluteRepaintRect):
        * khtml/rendering/render_text.h:
        * kwq/KWQFontMetrics.mm:
        (QFontMetrics::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix broken build.
mjs [Wed, 22 Oct 2003 23:18:37 +0000 (23:18 +0000)]
    Fix broken build.

        * kjs/simple_number.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix visibility to be done when widgets are added or when styles are set rather than...
hyatt [Wed, 22 Oct 2003 22:36:27 +0000 (22:36 +0000)]
Fix visibility to be done when widgets are added or when styles are set rather than at paint time.  Fixes
the ads painting on top of content at tvguide.com.

        Reviewed by cblu

        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::setQWidget):
        (RenderWidget::setStyle):
        (RenderWidget::paintObject):
        * kwq/KWQWidget.h:
        * kwq/KWQWidget.mm:
        (QWidget::QWidget):
        (QWidget::show):
        (QWidget::hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Merged 64-bit compilation fixes, and fixes for handling negative 0
mjs [Wed, 22 Oct 2003 21:31:46 +0000 (21:31 +0000)]
Merged 64-bit compilation fixes, and fixes for handling negative 0
from upstream kjs.

        * kjs/internal.cpp:
        * kjs/simple_number.h:
        (KJS::SimpleNumber): fixed constants; added negZero constant.
        (KJS::SimpleNumber::is): adjusted to use long and not int.
        (KJS::SimpleNumber::value): ditto.
(KJS::SimpleNumber::fits): ditto; also don't allow -0 to fit, so
we don't lose the distinction between -0 and +0.
        (KJS::SimpleNumber::make): adjusted to use long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
mjs [Wed, 22 Oct 2003 20:33:03 +0000 (20:33 +0000)]
WebCore:

        Reviewed by Dave.

Finished exception blocking changes, so now I can finally say:

- fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
- fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
- fixed 3311511 - nil deref inside KJS::Screen
- fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
- fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
- fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
- fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
- fixed 3413224 - unrepro crash in KJS::Window::mark
- fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
- fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
- fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
- fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()

        * WebCore.pbproj/project.pbxproj:
        * kwq/KWQFontMetrics.mm:
        * kwq/KWQPainter.mm:
        (QPainter::drawPixmap):
        (QPainter::drawTiledPixmap):
        (QPainter::_updateRenderer):
        * kwq/WebCoreTextRenderer.h:

WebKit:

        Reviewed by Dave.

Finished exception blocking changes, so now I can finally say:

- fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark
- fixed 3308848 - nil-deref in KHTMLView::topLevelWidget
- fixed 3311511 - nil deref inside KJS::Screen
- fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()
- fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark
- fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)
- fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background
- fixed 3413224 - unrepro crash in KJS::Window::mark
- fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com
- fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html
- fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).
- fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer ascent]):
        (-[WebTextRenderer descent]):
        (-[WebTextRenderer lineSpacing]):
        (-[WebTextRenderer xHeight]):
        (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
        (-[WebTextRenderer _smallCapsRenderer]):
        (-[WebTextRenderer _initializeATSUStyle]):
        (-[WebTextRenderer _createATSUTextLayoutForRun:]):
        (-[WebTextRenderer _trapezoidForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebBrowser:
rjw [Wed, 22 Oct 2003 20:25:39 +0000 (20:25 +0000)]
WebBrowser:
     Fixed 3458715.  Only update progress for current tab, and
     update progress when tab is switched.

        Reviewed by Chris.

        * BrowserWebController.m:
        (-[BrowserWebView _updateProgressBar]):
        (-[BrowserWebView progressStarted:]):
        (-[BrowserWebView progressChanged:]):
        (-[BrowserWebView progressFinished:]):
        * BrowserWindowController.m:
        (-[BrowserWindowController didSelectTabViewItem]):

WebKit:
Fixed 3458715.  Reset to 0, not .1 when done.

        Reviewed by Chris.

        * WebView.subproj/WebView.m:
        (-[WebView _resetProgress]):
        (-[WebView _progressStarted:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago http://placenamehere.com/safari/fixedbgtest.html is now fixed with a patch from...
hyatt [Wed, 22 Oct 2003 02:22:21 +0000 (02:22 +0000)]
placenamehere.com/safari/fixedbgtest.html is now fixed with a patch from the KHTML trunk.
Fixed backgrounds repeated when they weren't supposed to.

        * khtml/rendering/render_box.cpp:
        (RenderBox::paintBackgroundExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Don't use small caps font for characters that don't have an
rjw [Wed, 22 Oct 2003 00:10:17 +0000 (00:10 +0000)]
Don't use small caps font for characters that don't have an
uppercase counterpart (i.e. punctuation marks).

        Reviewed by Hyatt.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (widthForNextCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Change pseudo-element style resolution to be lazy and to not occur until the style...
hyatt [Tue, 21 Oct 2003 22:14:37 +0000 (22:14 +0000)]
Change pseudo-element style resolution to be lazy and to not occur until the style is actually asked
for by the front end render objects.  Also fix first-letter to inherit properly from first-line styles.

        Reviewed by mjs

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::initForStyleResolve):
        (khtml::CSSStyleSelector::styleForElement):
        (khtml::CSSStyleSelector::pseudoStyleForElement):
        (khtml::CSSStyleSelector::checkSelector):
        (khtml::CSSStyleSelector::checkOneSelector):
        * khtml/css/cssstyleselector.h:
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::addChildToFlow):
        * khtml/rendering/render_container.cpp:
        (RenderContainer::updatePseudoChild):
        * khtml/rendering/render_object.cpp:
        (RenderObject::setStyle):
        (RenderObject::createInlineBox):
        (RenderObject::style):
        (RenderObject::getPseudoStyle):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_style.cpp:
        (pseudoBit):
        (RenderStyle::hasPseudoStyle):
        (RenderStyle::setHasPseudoStyle):
        (RenderStyle::getPseudoStyle):
        (RenderStyle::addPseudoStyle):
        * khtml/rendering/render_style.h:
        (khtml::RenderStyle::NonInheritedFlags::operator==):
        (khtml::RenderStyle::setBitDefaults):
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paintSelection):
        (RenderText::paintObject):
        (RenderText::htmlFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
mjs [Tue, 21 Oct 2003 21:17:29 +0000 (21:17 +0000)]
    Reviewed by Dave.

More exception blocking.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::~KWQKHTMLPart):
        (KWQKHTMLPart::generateFrameName):
        (KWQKHTMLPart::openURL):
        (KWQKHTMLPart::openURLRequest):
        (regExpForLabels):
        (KWQKHTMLPart::clearRecordedFormValues):
        (KWQKHTMLPart::recordFormValue):
        (KWQKHTMLPart::submitForm):
        (KHTMLPart::frameDetached):
        (KWQKHTMLPart::urlSelected):
        (KWQKHTMLPart::createPart):
        (KWQKHTMLPart::setTitle):
        (KWQKHTMLPart::setStatusBarText):
        (KWQKHTMLPart::scheduleClose):
        (KWQKHTMLPart::unfocusWindow):
        (KWQKHTMLPart::jumpToSelection):
        (KWQKHTMLPart::redirectionTimerStartedOrStopped):
        (KWQKHTMLPart::userAgent):
        (KWQKHTMLPart::mimeTypeForFileName):
        (KWQKHTMLPart::nextKeyView):
        (KWQKHTMLPart::currentEventIsMouseDownInWidget):
        (KWQKHTMLPart::openURLFromPageCache):
        (KWQKHTMLPart::saveDocumentState):
        (KWQKHTMLPart::restoreDocumentState):
        (KWQKHTMLPart::requestedURLString):
        (KWQKHTMLPart::incomingReferrer):
        (KWQKHTMLPart::runJavaScriptAlert):
        (KWQKHTMLPart::runJavaScriptConfirm):
        (KWQKHTMLPart::runJavaScriptPrompt):
        (KWQKHTMLPart::createEmptyDocument):
        (KWQKHTMLPart::keyEvent):
        (KWQKHTMLPart::khtmlMousePressEvent):
        (KWQKHTMLPart::passWidgetMouseDownEventToWidget):
        (KWQKHTMLPart::lastEventIsMouseUp):
        (findViewInSubviews):
        (KWQKHTMLPart::khtmlMouseMoveEvent):
        (KWQKHTMLPart::passSubframeEventToSubframe):
        (KWQKHTMLPart::buttonForCurrentEvent):
        (KWQKHTMLPart::stateForCurrentEvent):
        (KWQKHTMLPart::mouseDown):
        (KWQKHTMLPart::mouseDragged):
        (KWQKHTMLPart::mouseUp):
        (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
        (KWQKHTMLPart::mouseMoved):
        (KWQKHTMLPart::sendContextMenuEvent):
        (fileWrapperForElement):
        (KWQKHTMLPart::attributedString):
        (KWQKHTMLPart::keyboardUIMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
cblu [Tue, 21 Oct 2003 18:47:50 +0000 (18:47 +0000)]
WebCore:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

        Reviewed by rjw.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::createPart): call renamed frameRequiredForMIMEType:URL:
        * kwq/WebCoreBridge.h: renamed frameRequiredForMIMEType: to frameRequiredForMIMEType:URL:

WebKit:

Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

        Reviewed by rjw.

        * Plugins.subproj/WebPluginDatabase.m:
        (-[WebPluginDatabase pluginForExtension:]): If no plug-in is found from the extension, attempt to map from the extension to a MIME type using our mappings and find a plug-in from the MIME type. This improves our chances of finding a plug-in when no MIME type is specified.
        * WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): If the passed MIME is empty, nil it out so that clients only need to check for nil. This avoids error sheets complaining about "" MIME types.
        (-[WebBridge frameRequiredForMIMEType:URL:]): Renamed to include URL. If no MIME is specified, only create a plug-in view if we can map from the extension.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3457627>: empty Flash plugin at tvguide.com
cblu [Mon, 20 Oct 2003 20:35:49 +0000 (20:35 +0000)]
Fixed: <rdar://problem/3457627>: empty Flash plugin at tvguide.com
Fixed issues with plug-in stream error handling.
Improved plug-in logging.

        Reviewed by kocienda.

        * Misc.subproj/WebKitLogging.h: added WebKitLogPluginEvents
        * Misc.subproj/WebKitLogging.m:
        * Plugins.subproj/WebBaseNetscapePluginStream.h:
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): improved logging
        (-[WebBaseNetscapePluginStream destroyStream]): improved logging
        (-[WebBaseNetscapePluginStream destroyStreamWithFailingReason:]): renamed from cancelWithReason to avoid confusion
        (-[WebBaseNetscapePluginStream receivedError:]): calls destroyStreamWithFailingReason after determining a reason from the NSError
        (-[WebBaseNetscapePluginStream cancelWithReason:]): calls destroyStreamWithFailingReason, this method is overriden by subclasses to cancel the actual load
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): call destroyStreamWithFailingReason, not cancelWithReason because the loaded has already ended here
        (-[WebBaseNetscapePluginStream deliverData]): improved logging
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendActivateEvent:]): use even logging
        (-[WebBaseNetscapePluginView sendUpdateEvent]): ditto
        (-[WebBaseNetscapePluginView becomeFirstResponder]): ditto
        (-[WebBaseNetscapePluginView resignFirstResponder]): ditto
        (-[WebBaseNetscapePluginView mouseDown:]): ditto
        (-[WebBaseNetscapePluginView mouseUp:]): ditto
        (-[WebBaseNetscapePluginView mouseEntered:]): ditto
        (-[WebBaseNetscapePluginView mouseExited:]): ditto
        (TSMEventHandler): ditto
        (-[WebBaseNetscapePluginView destroyStream:reason:]): call cancelWithReason so the reason is passed back to the plug-in
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]): tweak
        * Plugins.subproj/WebNetscapePluginRepresentation.m:
        (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call receivedError
        (-[WebNetscapePluginRepresentation cancelWithReason:]): override, cancel the load, call super
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream cancelWithReason:]): override, cancel the load, call super
        (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): be sure to call the stream before calling super because the stream can be cleared out when calling super
        (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): ditto
        (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto
        (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Conditionally excluded fix for 3446192. We'll enable the fix once 3446669
rjw [Mon, 20 Oct 2003 18:49:43 +0000 (18:49 +0000)]
Conditionally excluded fix for 3446192.  We'll enable the fix once 3446669
has been fixed.  This patch switches to the new UTI typing API for pasteboard types.

        Reviewed by Ken.

        * Misc.subproj/WebNSPasteboardExtras.m:
        (+[NSPasteboard initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdd test for floating/positioning generated content.
hyatt [Mon, 20 Oct 2003 18:22:04 +0000 (18:22 +0000)]
Add test for floating/positioning generated content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix generated content (before/after) so that it no longer has any restrictions on...
hyatt [Mon, 20 Oct 2003 18:18:02 +0000 (18:18 +0000)]
Fix generated content (before/after) so that it no longer has any restrictions on it.   CSS2.1 lifted
restrictions preventing the floating/positioning of generated content.

        Reviewed by rjw

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::adjustRenderStyle):
        * khtml/rendering/render_container.cpp:
        (RenderContainer::updatePseudoChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebBrowser
rjw [Mon, 20 Oct 2003 18:09:26 +0000 (18:09 +0000)]
WebBrowser
        Add a debug menu item to always use ATSU text drawing.  This will be helpful
        to the ATSU folks in performance tuning there API.  Right now I see approx.
        2X slowdown using ATSU.
        Reviewed by Chris.

        * Debug/DebugUtilities.m:
        (-[DebugUtilities createDebugMenu]):
        (-[BrowserDocument toggleAlternateProgress:]):
        (-[BrowserDocument toggleUseATSUForAllTextDrawing:]):

WebKit
Fixed 3456103.  Don't assert, just check for inappropriate state.
Reviewed by Hyatt

Add a debug menu item to always use ATSU text drawing.  This will be helpful
to the ATSU folks in performance tuning there API.  Right now I see approx.
2X slowdown using ATSU.

Also did some shuffling around of inline related stuff.

       Reviewed by Chris.

        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (isControlCharacter):
        (isAlternateSpace):
        (isSpace):
        (getUncachedWidth):
        (widthFromMap):
        (widthForGlyph):
        (+[WebTextRenderer _setAlwaysUseATSU:]):
        (glyphForCharacter):
        (glyphForUnicodeCharacter):
        (shouldUseATSU):
        * WebView.subproj/WebView.m:
        (+[WebView _setAlwaysUseATSU:]):
        (-[WebView _progressCompleted:]):
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by David
kocienda [Mon, 20 Oct 2003 17:28:10 +0000 (17:28 +0000)]
    Reviewed by David

        * khtml/dom/dom2_events.cpp:
        (UIEvent::keyCode): Change over to use ascii value for key code.
        (UIEvent::which): Ditto.
        (KeyboardEvent::KeyboardEvent): New key event class which
tracks the DOM Level 3 spec more closely.
        (KeyboardEvent::operator = ): New function.
        (KeyboardEvent::~KeyboardEvent): New function.
        (KeyboardEvent::ctrlKey): New function.
        (KeyboardEvent::shiftKey): New function.
        (KeyboardEvent::altKey): New function.
        (KeyboardEvent::metaKey): New function.
        (KeyboardEvent::altGraphKey): New function.
        (KeyboardEvent::initKeyboardEvent): New function.
        * khtml/dom/dom2_events.h: Ditto.
        * khtml/html/html_formimpl.cpp:
        (HTMLGenericFormElementImpl::defaultEventHandler): Use key
identifiers to test which key was pressed, instead of removed keyVal().
        (HTMLInputElementImpl::defaultEventHandler): Ditto.
        (HTMLSelectElementImpl::defaultEventHandler): Ditto.
        * khtml/html/html_inlineimpl.cpp:
        (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new
class name. Use key identifiers to test which key was pressed,
instead of removed keyVal(). Use new modifier accessors.
        * khtml/xml/dom2_eventsimpl.cpp:
        (EventImpl::typeToId): Some reorganization of the constants in the
switch statements. Name change for these to remove the KHTML_ prefix
from the key up and key down events will happen soon.
        (EventImpl::idToType): Ditto.
        (KeyboardEventImpl::KeyboardEventImpl): New key event class which
        tracks the DOM Level 3 spec more closely.
        (KeyboardEventImpl::~KeyboardEventImpl): Ditto.
        (KeyboardEventImpl::initKeyboardEvent): Ditto.
        * khtml/xml/dom2_eventsimpl.h:
        (DOM::EventImpl::): Some reorganization of the constants in the
        switch statements. Name change for these to remove the KHTML_ prefix
        from the key up and key down events will happen soon.
        (DOM::KeyboardEventImpl::keyIdentifier): New function.
        (DOM::KeyboardEventImpl::keyLocation): New function.
        (DOM::KeyboardEventImpl::ctrlKey): New function.
        (DOM::KeyboardEventImpl::shiftKey): New function.
        (DOM::KeyboardEventImpl::altKey): New function.
        (DOM::KeyboardEventImpl::metaKey): New function.
        (DOM::KeyboardEventImpl::altGraphKey): New function.
        (DOM::KeyboardEventImpl::qKeyEvent): New function.
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createEvent): Now can create keyboard events.
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::dispatchKeyEvent): Class name changes.
        * kwq/KWQEvent.h: Added QString identifier member.
        * kwq/KWQEvent.mm:
        (hexDigit): Added helper.
        (identifierForKeyText): Added new function to map keys to DOM
key identifiers as listed in the DOM spec.
        (QKeyEvent::identifier): Added accessor.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::stateForCurrentEvent): Added check to see if
a key press is on one of the numeric keypad keys.
        * kwq/KWQLogging.h: Added log constant for DOM events.
        * kwq/KWQLogging.m: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3442218>: crash due to infinite recursion trying to load...
cblu [Mon, 20 Oct 2003 15:42:35 +0000 (15:42 +0000)]
Fixed: <rdar://problem/3442218>: crash due to infinite recursion trying to load standalone plug-in content

        Reviewed by darin.

        * WebView.subproj/WebFrame.m:
        (-[WebFrame stopLoading]): manage the isStoppingLoad ivar, return if isStoppingLoad is YES
        * WebView.subproj/WebFramePrivate.h: added the isStoppingLoad ivar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave and Ken.
darin [Mon, 20 Oct 2003 14:59:25 +0000 (14:59 +0000)]
    Reviewed by Dave and Ken.

        - fixed 3457066 -- REGRESSION (91-92): command-left-arrow causes a scroll to the left before going back

        * WebView.subproj/WebFrameView.m: (-[WebFrameView keyDown:]): Add an else so that we don't fall into the
        scrolling code when the command key is down for right and left arrow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding first-letter/before text-transform tests.
hyatt [Mon, 20 Oct 2003 07:09:27 +0000 (07:09 +0000)]
Adding first-letter/before text-transform tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Make first-letter and before/after work with text transforms.
hyatt [Mon, 20 Oct 2003 07:07:54 +0000 (07:07 +0000)]
Make first-letter and before/after work with text transforms.

        Reviewed by mjs

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::addChildToFlow):
        * khtml/rendering/render_container.cpp:
        (RenderContainer::updatePseudoChild):
        * khtml/rendering/render_text.cpp:
        (RenderText::setStyle):
        (RenderText::isTextFragment):
        (RenderText::originalString):
        (RenderText::setText):
        (m_generatedContentStr):
        (m_start):
        (RenderTextFragment::~RenderTextFragment):
        (RenderTextFragment::isTextFragment):
        (RenderTextFragment::originalString):
        * khtml/rendering/render_text.h:
        (khtml::RenderTextFragment::start):
        (khtml::RenderTextFragment::end):
        (khtml::RenderTextFragment::contentString):
        * khtml/xml/dom_nodeimpl.h:
        (DOM::NodeImpl::setRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoLayout tests affected by the removal of the list float quirk.
hyatt [Mon, 20 Oct 2003 07:05:27 +0000 (07:05 +0000)]
Layout tests affected by the removal of the list float quirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Remove the "flow-around-floats" hack for lists. Other browsers don't do this.
hyatt [Mon, 20 Oct 2003 07:02:49 +0000 (07:02 +0000)]
Remove the "flow-around-floats" hack for lists.  Other browsers don't do this.

        Reviewed by darin

        * khtml/css/quirks.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse...
hyatt [Mon, 20 Oct 2003 06:57:29 +0000 (06:57 +0000)]
Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse code in the collapsedRightBorder
case.  I forgot to deal with colspans.

        Reviewed by darin

        * khtml/rendering/render_table.cpp:
        (RenderTable::cellRight):
        (RenderTableCell::collapsedRightBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch from KHTML trunk that makes textareas work properly even when they have no...
hyatt [Mon, 20 Oct 2003 04:16:16 +0000 (04:16 +0000)]
Patch from KHTML trunk that makes textareas work properly even when they have no render objects.

        * khtml/html/html_formimpl.cpp:
        (HTMLTextAreaElementImpl::encoding):
        (HTMLTextAreaElementImpl::value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Mon, 20 Oct 2003 00:45:54 +0000 (00:45 +0000)]
    Reviewed by Maciej.

        - fixed 3454444 -- contents of mailto form shows up in Mail title instead of body (IE sends mail directly)

        * kwq/KWQKURL.mm: (KURL::parse): Changed non-hierarchical code to consider everything
        after a question mark as a query, just the way the hierarchical code does. This makes
        the code that constructs the mailto URL work properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
cblu [Sun, 19 Oct 2003 18:08:32 +0000 (18:08 +0000)]
WebKit:

Fixed: <rdar://problem/3229530>: Dragging standalone image to desktop should save it, not re-download it

        Reviewed by darin.

* English.lproj/Localizable.strings:
        * WebKit.pbproj/project.pbxproj:
* WebView.subproj/WebDocumentPrivate.h: Added.
        * WebView.subproj/WebImageRepresentation.h:
        * WebView.subproj/WebImageRepresentation.m:
        (-[WebImageRepresentation dealloc]): release new filename and data ivars
        (-[WebImageRepresentation doneLoading]): return YES if data is non-nil
        (-[WebImageRepresentation setDataSource:]): store the filename
        (-[WebImageRepresentation receivedError:withDataSource:]): store the data
        (-[WebImageRepresentation finishedLoadingWithDataSource:]): store the data
        (-[WebImageRepresentation data]): new
        (-[WebImageRepresentation filename]): new
        * WebView.subproj/WebImageView.m:
        (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): just save the image, don't download it
(-[WebImageView image]): new

WebBrowser:

Fixed:
<rdar://problem/3456752>: Filename when saving a standalone image includes "nxn pixels"
<rdar://problem/3177870>: Context menu for standalone images should be "Save Image As..." not "Download Image to Disk"

        Reviewed by darin.

        * BrowserDocument.m:
        (-[BrowserDocument displayName]): If we are saving a standalone image, use the responses suggestedFilename
        * ContextMenuHandler.m:
        (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): If this is a context menu for a standalone image, provide "Save Image As..." and "Copy Image to Clipboard"
        (-[BrowserWebView saveDocumentAs:]): renamed from savePageAs to be more generic
        * English.lproj/StringsNotToBeLocalized.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoTweak some old log entries.
darin [Sun, 19 Oct 2003 03:09:42 +0000 (03:09 +0000)]
Tweak some old log entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdd minmax test for positioned elements.
hyatt [Sat, 18 Oct 2003 23:25:24 +0000 (23:25 +0000)]
Add minmax test for positioned elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix the intrinsic minmax width computation for blocks and XUL boxes to actually...
hyatt [Sat, 18 Oct 2003 23:23:10 +0000 (23:23 +0000)]
Fix the intrinsic minmax width computation for blocks and XUL boxes to actually check fixed min/max CSS widths.

        Reviewed by darin

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::calcMinMaxWidth):
        * khtml/rendering/render_flexbox.cpp:
        (khtml::RenderFlexibleBox::calcMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Change the names of the border-spacing properties to border-horizontal-spacing and...
hyatt [Sat, 18 Oct 2003 21:30:55 +0000 (21:30 +0000)]
Change the names of the border-spacing properties to border-horizontal-spacing and border-vertical-spacing.

        Reviewed by NOBODY (Straightforward).

        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        * khtml/css/cssproperties.c:
        (findProp):
        * khtml/css/cssproperties.h:
        * khtml/css/cssproperties.in:
        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::applyRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoRemove accidental commit of a ~ file.
hyatt [Sat, 18 Oct 2003 21:27:38 +0000 (21:27 +0000)]
Remove accidental commit of a ~ file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding another border-collapsing test.
hyatt [Sat, 18 Oct 2003 21:27:08 +0000 (21:27 +0000)]
Adding another border-collapsing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Sat, 18 Oct 2003 21:13:32 +0000 (21:13 +0000)]
    Reviewed by Dave.

        - fixed 3367015 -- interdependent variable declarations in for loop don't work (they go backwards)

        * kjs/nodes.h: (KJS::ForNode::ForNode): Add a new overload of the constructor for when the
        first parameter is a variable declaration list. Call reverseList as we do in other constructors
        that take lists that are built backwards.
        * kjs/nodes.cpp: (ForNode::reverseList): Added. New helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAccidentally removed a FIXME comment. Putting it back.
hyatt [Sat, 18 Oct 2003 20:54:11 +0000 (20:54 +0000)]
Accidentally removed a FIXME comment. Putting it back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding minmax width test for the mozilla web site beta bug.
hyatt [Sat, 18 Oct 2003 20:50:32 +0000 (20:50 +0000)]
Adding minmax width test for the mozilla web site beta bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding test for classname parsing bug.
hyatt [Sat, 18 Oct 2003 20:49:42 +0000 (20:49 +0000)]
Adding test for classname parsing bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for diveintomark className parsing bug. class="bigblue blue" would fail to...
hyatt [Sat, 18 Oct 2003 20:48:27 +0000 (20:48 +0000)]
Fix for diveintomark className parsing bug.  class="bigblue blue" would fail to match a rule with .blue.
The bug was in the selector matching code for class attributes.

Also fixing a minmax width bug for blocks on the mozilla.org Web site.  XUL boxes had the same bug as
well.

        Reviewed by darin

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::checkOneSelector):
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::calcMinMaxWidth):
        * khtml/rendering/render_flexbox.cpp:
        (khtml::RenderFlexibleBox::calcMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3443502, generated content sometimes doesn't generate. The bug is caused...
hyatt [Sat, 18 Oct 2003 09:28:56 +0000 (09:28 +0000)]
Fix for 3443502, generated content sometimes doesn't generate.  The bug is caused by an
uninitialized variable.  m_isContinuation needed to be set to false in the RenderInline
constructor.

        Reviewed by NOBODY (it's a simple obvious fix)

        * khtml/rendering/render_inline.cpp:
        (m_isContinuation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Fri, 17 Oct 2003 23:57:31 +0000 (23:57 +0000)]
    Reviewed by Maciej.

        - make text areas set the base writing direction based on the direction in the CSS style

        * kwq/KWQTextArea.h: Added setBaseWritingDirection method.
        * kwq/KWQTextArea.mm:
        (-[KWQTextArea _createTextView]): Use _KWQ_setTypingParagraphStyle.
        (-[KWQTextArea setWordWrap:]): Use _KWQ_setTypingParagraphStyle.
        (-[KWQTextArea setBaseWritingDirection:]): Added. New method that sets the base writing
        direction in both the style of the text and the typing attributes.
        (-[NSTextView _KWQ_typingParagraphStyle]): Added. Helper method to make setBaseWritingDirection:
        a little less gigantic.
        (-[NSTextView _KWQ_setTypingParagraphStyle:]): Ditto.
        (-[NSTextStorage _KWQ_setBaseWritingDirection:]): Ditto.

        * kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Set both alignment and base writing direction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
cblu [Fri, 17 Oct 2003 23:35:58 +0000 (23:35 +0000)]
WebKit:

Fixed: <rdar://problem/3456176>: Assertion failure when loading atomfilms.com

        Reviewed by kocienda.

        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:lengthReceived:]): call super before calling plug-in code as we do in other callbacks
        (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): ditto
        (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto

WebBrowser:

Fixed: <rdar://problem/3456246>: repro assertion failure in DowloadViewController pressing cmd-. when active download is not selected

        Reviewed by kocienda.

        * DownloadViewController.m:
        (-[DownloadViewController _stopSelection]): Removed the assertion because it is OK to call this method when there are no downloads to stop

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdd border-collapsing tests.
hyatt [Fri, 17 Oct 2003 23:06:54 +0000 (23:06 +0000)]
Add border-collapsing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Implement horizontal and vertical border-spacing. Allow them to be specified indivi...
hyatt [Fri, 17 Oct 2003 22:32:14 +0000 (22:32 +0000)]
Implement horizontal and vertical border-spacing.  Allow them to be specified individually.

        Reviewed by mjs

------

Fix the calcWidth method of tables to account for horizontal margins properly.

Reviewed by john

------

Implement border collapsing in tables.

Reviewed by kocienda

        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        * khtml/css/cssproperties.c:
        (hash_prop):
        (findProp):
        * khtml/css/cssproperties.h:
        * khtml/css/cssproperties.in:
        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::applyRule):
        * khtml/css/cssvalues.c:
        * khtml/css/cssvalues.h:
        * khtml/css/cssvalues.in:
        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::layoutInlineChildren):
        * khtml/rendering/render_box.cpp:
        (RenderBox::paintBoxDecorations):
        * khtml/rendering/render_form.cpp:
        (RenderFieldset::paintBorderMinusLegend):
        * khtml/rendering/render_object.cpp:
        (RenderObject::paintBorder):
        (RenderObject::collectBorders):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_style.cpp:
        (StyleInheritedData::StyleInheritedData):
        (StyleInheritedData::operator==):
        (RenderStyle::diff):
        * khtml/rendering/render_style.h:
        (khtml::):
        (khtml::CollapsedBorderValue::precedence):
        (khtml::CollapsedBorderValue::width):
        (khtml::CollapsedBorderValue::style):
        (khtml::CollapsedBorderValue::exists):
        (khtml::CollapsedBorderValue::color):
        (khtml::CollapsedBorderValue::isTransparent):
        (khtml::CollapsedBorderValue::operator==):
        (khtml::RenderStyle::borderLeft):
        (khtml::RenderStyle::borderRight):
        (khtml::RenderStyle::borderTop):
        (khtml::RenderStyle::borderBottom):
        (khtml::RenderStyle::horizontalBorderSpacing):
        (khtml::RenderStyle::verticalBorderSpacing):
        (khtml::RenderStyle::setHorizontalBorderSpacing):
        (khtml::RenderStyle::setVerticalBorderSpacing):
        * khtml/rendering/render_table.cpp:
        (RenderTable::RenderTable):
        (RenderTable::setStyle):
        (RenderTable::calcWidth):
        (RenderTable::paint):
        (RenderTable::borderLeft):
        (RenderTable::borderRight):
        (RenderTable::borderTop):
        (RenderTable::borderBottom):
        (RenderTable::cellAbove):
        (RenderTable::cellBelow):
        (RenderTable::cellLeft):
        (RenderTable::cellRight):
        (RenderTableSection::setCellWidths):
        (RenderTableSection::calcRowHeight):
        (RenderTableSection::layoutRows):
        (compareBorders):
        (RenderTableCell::collapsedLeftBorder):
        (RenderTableCell::collapsedRightBorder):
        (RenderTableCell::collapsedTopBorder):
        (RenderTableCell::collapsedBottomBorder):
        (RenderTableCell::borderLeft):
        (RenderTableCell::borderRight):
        (RenderTableCell::borderTop):
        (RenderTableCell::borderBottom):
        (collapsedBorderStyle):
        (CollapsedBorder::CollapsedBorder):
        (CollapsedBorders:::count):
        (CollapsedBorders::addBorder):
        (CollapsedBorders::nextBorder):
        (addBorderStyle):
        (RenderTableCell::collectBorders):
        (RenderTableCell::paintCollapsedBorder):
        (RenderTableCell::paintObject):
        (RenderTableCell::paintBoxDecorations):
        * khtml/rendering/render_table.h:
        (khtml::RenderTable::hBorderSpacing):
        (khtml::RenderTable::vBorderSpacing):
        (khtml::RenderTable::bordersPaddingAndSpacing):
        (khtml::RenderTable::currentBorderStyle):
        * khtml/rendering/table_layout.cpp:
        (FixedTableLayout::layout):
        (AutoTableLayout::calcEffectiveWidth):
        (AutoTableLayout::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
mjs [Fri, 17 Oct 2003 00:36:06 +0000 (00:36 +0000)]
    Reviewed by John.

More exception blocking.

        * kwq/KWQFont.mm:
        (QFont::isFixedPitch):
        (QFont::getNSFont):
        * kwq/KWQKJobClasses.mm:
        (KIO::TransferJob::~TransferJob):
        * kwq/KWQLoader.mm:
        (KWQServeRequest):
        (KWQCheckIfReloading):
        (KWQCheckCacheObjectStatus):
        (KWQRetainResponse):
        (KWQReleaseResponse):
        (KWQResponseMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3455306. Ensure that progress is correctly ended when a load is interupted...
rjw [Fri, 17 Oct 2003 00:17:24 +0000 (00:17 +0000)]
Fixed 3455306.  Ensure that progress is correctly ended when a load is interupted (i.e. becomes a download).

        Reviewed by mjs.

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _isLoadComplete]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug...
cblu [Thu, 16 Oct 2003 23:40:30 +0000 (23:40 +0000)]
Fixed: <rdar://problem/3455176>: Assertion failure when loading non-existant plug-in content

        Reviewed by rjw.

        * Misc.subproj/WebDownload.m: fixed build failure when using new Foundation. We are overriding and calling a renamed method. Continue to override the old method, override the new method and declare their interfaces to avoid build failures.
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): cancel the load before telling the plug-in about the error so plug-in code doesn't attempt to cancel the load twice

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agomove the Safari-110 marker in the ChangeLog
vicki [Thu, 16 Oct 2003 22:37:10 +0000 (22:37 +0000)]
move the Safari-110 marker in the ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by vicki.
vicki [Thu, 16 Oct 2003 22:27:08 +0000 (22:27 +0000)]
    Reviewed by vicki.

- fix buildit build failure

        * kwq/KWQScrollView.mm:
        (QScrollView::resizeContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3453991. We weren't setting the array cursor correctly after changing
rjw [Thu, 16 Oct 2003 21:59:13 +0000 (21:59 +0000)]
Fixed 3453991.  We weren't setting the array cursor correctly after changing
capacity.

        Reviewed by John.

        * ChangeLog:
        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList setCapacity:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agotree is open for Safari-111
vicki [Thu, 16 Oct 2003 21:50:04 +0000 (21:50 +0000)]
tree is open for Safari-111

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoThe rest of the Safari-110 stamp
vicki [Thu, 16 Oct 2003 21:44:46 +0000 (21:44 +0000)]
The rest of the Safari-110 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agotop level:
vicki [Thu, 16 Oct 2003 21:42:31 +0000 (21:42 +0000)]
top level:

        * configure.in: Add "OptimizedWithSymbols" build style.

Tools:

        * Scripts/autovicki: Renamed from run-tests.
        * Scripts/run-tests: Run autovicki passing all arguments (for
compatibility with the humor-impaired).

JavaScriptCore:

        * kjs/create_hash_table: Remove stray semicolon.

        * kjs/array_object.lut.h:
        * kjs/date_object.lut.h:
        * kjs/lexer.lut.h:
        * kjs/math_object.lut.h:
        * kjs/number_object.lut.h:
        * kjs/string_object.lut.h:
        Regenerated.

Tests:

        * JSUnit/jsunit/app/jsUnitTestManager.js: Commented the lines I changed to work
        around bug 3269212 in WebCore.

WebCore:

        Reviewed by Ken.

        - change "volatile X * volatile" to "X * volatile" in cases where the
          pointer needs to be volatile but the object pointed to do does not

        * kwq/KWQKConfigBase.mm: (KConfig::readEntry):
        * kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
        * kwq/KWQKLocale.mm:
        (inputElementAltText):
        (resetButtonDefaultLabel):
        (searchableIndexIntroduction):
        (submitButtonDefaultLabel):
        (KLocale::language):
        * kwq/KWQLineEdit.mm: (QLineEdit::text):
        * kwq/KWQScrollView.mm:
        (QScrollView::setContentsPos):
        (QScrollView::addChild):
        (QScrollView::updateContents):
        (QScrollView::contentsToViewport):
        (QScrollView::viewportToContents):
        (QScrollView::getDocumentView):
        * kwq/KWQTextEdit.mm:
        (QTextEdit::text):
        (QTextEdit::textWithHardLineBreaks):
        * kwq/KWQWidget.mm: (QWidget::getOuterView):
        Removed the excess volatiles and excess casts that go with them.

        * kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): Do the same, but also
        remove an unnecessary nil check that is the same as QString::fromNSString's
        default behavior.

WebKit:

Tweaked the progress behavior and factored cleanup of progress
related ivars.

        Reviewed by Hyatt.

        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _startLoading:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _isLoadComplete]):
        * WebView.subproj/WebView.m:
        (-[WebView _resetProgress]):
        (-[WebView _progressStarted:]):
        (-[WebView _finalProgressComplete]):
        (-[WebView _progressCompleted:]):
        (-[WebView _incrementProgressForConnection:data:]):
        * WebView.subproj/WebViewPrivate.h:

WebBrowser:

        Coalesce drawing of progress bar (like old behavior).  This fixes a performance regression.
        Always draw the progress at 100% for a short interval after loading a page (like the old behavior).

        Reviewed by Hyatt.

        * BrowserWebController.m:
        (-[BrowserWebView initWithDocument:request:frameName:]):
        (-[BrowserWebView progressStarted:]):
        (-[BrowserWebView progressChanged:]):
        (-[BrowserWebView progressFinished:]):
        * BrowserWindowController.h:
        * BrowserWindowController.m:
        (-[BrowserWindowController _newUpdateProgressBar]):
        (-[BrowserWindowController newUpdateProgressBar]):
        (-[BrowserWindowController showCompleteProgressBar]):
        (-[BrowserWindowController clearProgressBar]):
        * TextFieldWithControls.m:
        (-[TextFieldWithControls setProgressBarValue:]):

WebKitExamples:

        * CarbonDownloader/English.lproj/main.nib: Changed command key equivalent for Close to Cmd-W.
        Since this is example code and not localized, the localization freeze should not be an issue.
        * CarbonDownloader/English.lproj/main~.nib: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoRoll out earlier change, since the tree was closed.
mjs [Thu, 16 Oct 2003 21:11:05 +0000 (21:11 +0000)]
Roll out earlier change, since the tree was closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
mjs [Thu, 16 Oct 2003 20:55:47 +0000 (20:55 +0000)]
    Reviewed by John.

More exception blocking.

        * kwq/KWQFont.mm:
        (QFont::isFixedPitch):
        (QFont::getNSFont):
        * kwq/KWQKJobClasses.mm:
        (KIO::TransferJob::~TransferJob):
        * kwq/KWQLoader.mm:
        (KWQServeRequest):
        (KWQCheckIfReloading):
        (KWQCheckCacheObjectStatus):
        (KWQRetainResponse):
        (KWQReleaseResponse):
        (KWQResponseMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebBrowser:
rjw [Thu, 16 Oct 2003 19:56:17 +0000 (19:56 +0000)]
WebBrowser:
        Coalesce drawing of progress bar (like old behavior).  This fixes a performance regression.
        Always draw the progress at 100% for a short interval after loading a page (like the old behavior).

        Reviewed by Hyatt.

        * BrowserWebController.m:
        (-[BrowserWebView initWithDocument:request:frameName:]):
        (-[BrowserWebView progressStarted:]):
        (-[BrowserWebView progressChanged:]):
        (-[BrowserWebView progressFinished:]):
        * BrowserWindowController.h:
        * BrowserWindowController.m:
        (-[BrowserWindowController _newUpdateProgressBar]):
        (-[BrowserWindowController newUpdateProgressBar]):
        (-[BrowserWindowController showCompleteProgressBar]):
        (-[BrowserWindowController clearProgressBar]):
        * TextFieldWithControls.m:
        (-[TextFieldWithControls setProgressBarValue:]):

WebKit:
Tweaked the progress behavior and factored cleanup of progress
related ivars.

        Reviewed by Hyatt.

        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _startLoading:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _isLoadComplete]):
        * WebView.subproj/WebView.m:
        (-[WebView _resetProgress]):
        (-[WebView _progressStarted:]):
        (-[WebView _finalProgressComplete]):
        (-[WebView _progressCompleted:]):
        (-[WebView _incrementProgressForConnection:data:]):
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Wed, 15 Oct 2003 16:18:17 +0000 (16:18 +0000)]
    Reviewed by Ken.

        - change "volatile X * volatile" to "X * volatile" in cases where the
          pointer needs to be volatile but the object pointed to do does not

        * kwq/KWQKConfigBase.mm: (KConfig::readEntry):
        * kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
        * kwq/KWQKLocale.mm:
        (inputElementAltText):
        (resetButtonDefaultLabel):
        (searchableIndexIntroduction):
        (submitButtonDefaultLabel):
        (KLocale::language):
        * kwq/KWQLineEdit.mm: (QLineEdit::text):
        * kwq/KWQScrollView.mm:
        (QScrollView::setContentsPos):
        (QScrollView::addChild):
        (QScrollView::updateContents):
        (QScrollView::contentsToViewport):
        (QScrollView::viewportToContents):
        (QScrollView::getDocumentView):
        * kwq/KWQTextEdit.mm:
        (QTextEdit::text):
        (QTextEdit::textWithHardLineBreaks):
        * kwq/KWQWidget.mm: (QWidget::getOuterView):
        Removed the excess volatiles and excess casts that go with them.

        * kwq/KWQKCookieJar.mm: (KWQKCookieJar::cookie): Do the same, but also
        remove an unnecessary nil check that is the same as QString::fromNSString's
        default behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
mjs [Wed, 15 Oct 2003 07:05:52 +0000 (07:05 +0000)]
    Reviewed by Dave.

More objc-exception-blocking excitement.

        * kwq/KWQKConfigBase.mm:
        (KConfig::readEntry):
        (KConfig::readNumEntry):
        (RefreshPlugins):
        * kwq/KWQKCursor.mm:
        (+[NSCursor _WebCore_cursorWithName:hotSpot:]):
        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::showApplet):
        * kwq/KWQKLocale.mm:
        (inputElementAltText):
        (resetButtonDefaultLabel):
        (searchableIndexIntroduction):
        (submitButtonDefaultLabel):
        (KLocale::language):
        * kwq/KWQRegion.mm:
        (QRegion::QRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebBrowser:
rjw [Wed, 15 Oct 2003 01:32:11 +0000 (01:32 +0000)]
WebBrowser:
Use WebKit estimated progress scheme.  I've left the old
scheme in place.  You can get the old behavior by turning off the
"Use Alternate Progress" item in the debug menu.  The new code is
much simpler than the old code.  Once we decide to move ahead with the
new scheme we can do a serious root canal.

        Reviewed by Chris.

        * BrowserWebController.m:
        (-[BrowserWebView initWithDocument:request:frameName:]):
        (-[BrowserWebView dealloc]):
        (-[BrowserWebView isLoading]):
        (-[BrowserWebView progressStarted:]):
        (-[BrowserWebView progressChanged:]):
        (-[BrowserWebView progressFinished:]):
        * BrowserWindowController.h:
        * BrowserWindowController.m:
        (-[BrowserWindowController updateProgressBar]):
        (-[BrowserWindowController newUpdateProgressBar]):
        (-[BrowserWindowController clearProgressBar]):
        * Debug/DebugUtilities.h:
        * Debug/DebugUtilities.m:
        (-[DebugUtilities init]):
        (-[DebugUtilities useAlternateProgress]):
        (-[DebugUtilities setUseAlternateProgress:]):
        (-[DebugUtilities createDebugMenu]):
        (-[BrowserDocument toggleBackForwardEnabled:]):
        (-[BrowserDocument toggleAlternateProgress:]):
        * TextFieldWithControls.m:
        (-[TextFieldWithControls setProgressBarValue:]):

WebKit:
        Added logging for estimated progress.

        Added a time delta to the throttler, so we now send notifications
        if a delta amount has been exceeded OR a delta between notifications
        has been exceeded.

        Reviewed by Chris.

        * Misc.subproj/WebKitLogging.h:
        * Misc.subproj/WebKitLogging.m:
        * WebView.subproj/WebView.m:
        (-[WebViewPrivate init]):
        (-[WebView _progressStarted]):
        (-[WebView _progressCompleted]):
        (-[WebView _incrementProgressForConnection:data:]):
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix an obvious little typo with smallCaps inheritance. Richard reviewed.
hyatt [Tue, 14 Oct 2003 19:47:25 +0000 (19:47 +0000)]
Fix an obvious little typo with smallCaps inheritance.  Richard reviewed.

Also merge in Dirk's patch to fix a crasher caused by an obvious deref mistake.

        Reviewed by rjw and nobody

        * khtml/css/cssstyleselector.cpp:
        (khtml::convertToLength):
        (khtml::CSSStyleSelector::applyRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin
kocienda [Tue, 14 Oct 2003 16:01:33 +0000 (16:01 +0000)]
    Reviewed by Darin

Fix for this bug:

<rdar://problem/3450449>: assertion failure in WebBridge
_retrieveKeyboardUIModeFromPreferences

Can't assert that the preference always exists and is valid as I
thought you could. This could just mean that the a preference for full
keyboard access has not been specified by the user yet. If this is so,
just return the default keyboard access mode.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge _retrieveKeyboardUIModeFromPreferences:])

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Hyatt
kocienda [Tue, 14 Oct 2003 15:36:10 +0000 (15:36 +0000)]
    Reviewed by Hyatt

        * khtml/dom/dom_misc.h: Declared TristateFlag enum used to implement
inheritance behavior for inheritable attributes like designMode.
        * khtml/dom/html_document.cpp:
        (HTMLDocument::designMode): Added getter.
        (HTMLDocument::setDesignMode): Added setter.
        * khtml/dom/html_document.h: Added declarations for designMode getter and setter.
        * khtml/dom/html_element.cpp:
        (HTMLElement::isContentEditable): Added convenience.
        (HTMLElement::contentEditable): Added getter.
        (HTMLElement::setContentEditable): Added setter.
        * khtml/dom/html_element.h: Added declarations for contentEditable accessors.
        * khtml/ecma/kjs_html.cpp: Added js support for contentEditable and designMode.
        (KJS::HTMLDocument::tryGet)
        (KJS::HTMLDocument::putValue)
        (KJS::HTMLElement::getValueProperty)
        (KJS::HTMLElement::putValue)
        * khtml/ecma/kjs_html.h:
        (KJS::HTMLDocument::): Added DesignMode to attribuute enum.
        (KJS::HTMLElement::): Added ContentEditable to attribute enum.
        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::designMode): Added getter.
        (HTMLDocumentImpl::setDesignMode): Added setter.
        * khtml/html/html_documentimpl.h: Declared designMode accessors.
        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::HTMLElementImpl):
        (HTMLElementImpl::parseAttribute): Added support for contentEditable.
        (HTMLElementImpl::isContentEditable): Added. Implements inheritance feature
for this attribute.
        (HTMLElementImpl::contentEditable): Getter for contentEditable attribute.
        (HTMLElementImpl::setContentEditable): Setter for contentEditable attribute.
        * khtml/html/html_elementimpl.h:
        * khtml/khtml_part.cpp:
        (KHTMLPart::setEditMode): Added.
        (KHTMLPart::editMode): Added. Implements inheritance behavior for
attribute.
        (KHTMLPart::inEditMode): Helper that calls on editMode function.
        (KHTMLPart::parentPart): Made const.
        * khtml/khtml_part.h: Rolled in a couple of typo fixes. Added
declarations for the changes made in the implementation file.
        * khtml/khtmlpart_p.h:
        (KHTMLPartPrivate::KHTMLPartPrivate): Declared editMode flag.
Also added support for editMode flag in initializers and copy function.
        * khtml/misc/htmlattrs.in: Added contentEditable as an attribute name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for a small-caps rendering error when used in conjunction with ::first-line...
hyatt [Tue, 14 Oct 2003 01:56:53 +0000 (01:56 +0000)]
Fix for a small-caps rendering error when used in conjunction with ::first-line.  Always update
the Font variable even when QFonts are the same, since small-caps is not stored in QFonts.

        Reviewed by rjw

        * khtml/rendering/render_text.cpp:
        (RenderText::paintObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Updated layout tests actuals to reflect implementation of small-caps style.
rjw [Tue, 14 Oct 2003 00:52:16 +0000 (00:52 +0000)]
Updated layout tests actuals to reflect implementation of small-caps style.

        * layout-tests/css1/font_properties/font-expected.txt:
        * layout-tests/css1/font_properties/font_variant-expected.txt:
        * layout-tests/css1/pseudo/firstline-expected.txt:
        * layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Added support for small-caps.
rjw [Tue, 14 Oct 2003 00:44:29 +0000 (00:44 +0000)]
Added support for small-caps.

        Reviewed by John.

        * khtml/rendering/font.h:
        (khtml::Font::isSmallCaps):
        * khtml/rendering/render_text.cpp:
        (RenderText::shouldUseMonospaceCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Added support for small-caps.
rjw [Tue, 14 Oct 2003 00:39:11 +0000 (00:39 +0000)]
Added support for small-caps.

Reworked drawing and measuring to use new iterators.  Position checking was already using
the new iterator code, but I was reluctant to switch the mainline drawing and measuring
code over to the new approach until now.

Lots of other code cleanup.

        Reviewed by John.

        * Misc.subproj/WebUnicode.m:
        (initializeCharacterShapeIterator):
        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (+[WebTextRenderer shouldBufferTextDrawing]):
        (+[WebTextRenderer initialize]):
        (-[WebTextRenderer initWithFont:usingPrinterFont:]):
        (-[WebTextRenderer dealloc]):
        (-[WebTextRenderer widthForCharacters:length:]):
        (-[WebTextRenderer widthForString:]):
        (-[WebTextRenderer ascent]):
        (-[WebTextRenderer descent]):
        (-[WebTextRenderer lineSpacing]):
        (-[WebTextRenderer xHeight]):
        (-[WebTextRenderer drawRun:style:atPoint:]):
        (-[WebTextRenderer floatWidthForRun:style:widths:]):
        (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
        (-[WebTextRenderer drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer pointToOffset:style:position:reversed:]):
        (-[WebTextRenderer _setIsSmallCapsRenderer:]):
        (-[WebTextRenderer _isSmallCapsRenderer]):
        (-[WebTextRenderer _smallCapsRenderer]):
        (-[WebTextRenderer _smallCapsFont]):
        (-[WebTextRenderer _substituteFontForString:families:]):
        (-[WebTextRenderer _substituteFontForCharacters:length:families:]):
        (-[WebTextRenderer _convertCharacters:length:toGlyphs:skipControlCharacters:]):
        (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]):
        (-[WebTextRenderer _computeWidthForSpace]):
        (-[WebTextRenderer _setupFont]):
        (_drawGlyphs):
        (-[WebTextRenderer _CG_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _CG_drawRun:style:atPoint:]):
        (-[WebTextRenderer _floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]):
        (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]):
        (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]):
        (-[WebTextRenderer _updateGlyphEntryForCharacter:glyphID:font:]):
        (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]):
        (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):
        (-[WebTextRenderer _trapezoidForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_floatWidthForRun:style:]):
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):
        (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]):
        (freeWidthMap):
        (freeGlyphMap):
        (glyphForCharacter):
        (glyphForUnicodeCharacter):
        (mapForSubstituteFont):
        (widthFromMap):
        (widthForGlyph):
        (initializeCharacterWidthIterator):
        (widthAndGlyphForSurrogate):
        (ceilCurrentWidth):
        (widthForNextCharacter):
        (fillStyleWithAttributes):
        (findLengthOfCharacterCluster):
        (shouldUseATSU):
        (isControlCharacter):
        (isAlternateSpace):
        (isSpace):
        (fontContainsString):
        (GetScratchUniCharString):
        (toUpper):
        (isUpper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * layout-tests/fast/js/date-parse-test.html: Fixed a couple of silly mistakes.
darin [Mon, 13 Oct 2003 03:32:40 +0000 (03:32 +0000)]
    * layout-tests/fast/js/date-parse-test.html: Fixed a couple of silly mistakes.

        * kwq/character-sets.txt: New version of file from www.iana.org. No substantive change.
        Also, now that we don't use MIB numbers any more, I could leave out our one local change,
        the MIB number we added for ISO-10646-J-1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoA few more files from the Mozilla tests. Soon I will make it so we can
darin [Mon, 13 Oct 2003 02:13:28 +0000 (02:13 +0000)]
A few more files from the Mozilla tests. Soon I will make it so we can
run the tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoFirst commit of Mozilla JavaScript tests.
darin [Mon, 13 Oct 2003 02:05:37 +0000 (02:05 +0000)]
First commit of Mozilla JavaScript tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Beginning of work on border collapsing. This patch makes sure that cell spacing...
hyatt [Fri, 10 Oct 2003 23:22:10 +0000 (23:22 +0000)]
Beginning of work on border collapsing.  This patch makes sure that cell spacing between cells is
ignored and that padding on tables is ignored.  This ensures that there is no space between cells
or between the edges of cells and the border of the table itself.

        Reviewed by john

        * khtml/rendering/render_style.h:
        (khtml::RenderStyle::setBitDefaults):
        * khtml/rendering/render_table.cpp:
        (RenderTable::setStyle):
        (RenderTable::layout):
        * khtml/rendering/render_table.h:
        (khtml::RenderTable::collapseBorders):
        (khtml::RenderTable::bordersPaddingAndSpacing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoUpdate test to remove the padding from tables.
hyatt [Fri, 10 Oct 2003 23:05:46 +0000 (23:05 +0000)]
Update test to remove the padding from tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * English.lproj/StringsNotToBeLocalized.txt: Fixed for Private
mjs [Fri, 10 Oct 2003 22:35:48 +0000 (22:35 +0000)]
    * English.lproj/StringsNotToBeLocalized.txt: Fixed for Private
change from a while back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch to move widgets during layout instead of waiting until paint time.
hyatt [Fri, 10 Oct 2003 22:04:43 +0000 (22:04 +0000)]
Patch to move widgets during layout instead of waiting until paint time.

        Reviewed by darin

        * WebView.subproj/WebDataSource.m:
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _isLoadComplete]):
        * WebView.subproj/WebHTMLView.m:
        * WebView.subproj/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for table regression 3449444, as well as a patch to support padding on tables...
hyatt [Fri, 10 Oct 2003 22:03:14 +0000 (22:03 +0000)]
Fix for table regression 3449444, as well as a patch to support padding on tables and to stop
honoring borders on row groups (both of which are correct for the "separate" border model).

* khtml/rendering/render_table.cpp:
        (RenderTable::layout):
        (RenderTableSection::calcRowHeight):
        (RenderTableSection::layoutRows):
        * khtml/rendering/render_table.h:
        (khtml::RenderTable::bordersPaddingAndSpacing):
        * khtml/rendering/table_layout.cpp:
        (FixedTableLayout::calcMinMaxWidth):
        (FixedTableLayout::layout):
        (AutoTableLayout::calcMinMaxWidth):
        (AutoTableLayout::layout):

Reviewed by darin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John
kocienda [Fri, 10 Oct 2003 18:40:34 +0000 (18:40 +0000)]
    Reviewed by John

Fix for this bug:

<rdar://problem/3440703>: Textarea form controls do not respect disabled attribute

        * khtml/rendering/render_form.cpp:
        (RenderTextArea::updateFromElement): Check for disabled attribute.
        * kwq/KWQTextArea.h:
        * kwq/KWQTextArea.mm:
        (-[KWQTextArea setEnabled:]): Added.
        (-[KWQTextArea isEnabled]): Added.
        (-[KWQTextArea drawRect:]): Draws a disabled-looking  bezel when disabled.
        (-[KWQTextAreaTextView becomeFirstResponder]): Return NO if disabled.
        (-[KWQTextAreaTextView mouseDown:]): Block events if disabled.
        (-[KWQTextAreaTextView keyDown:]): Ditto.
        (-[KWQTextAreaTextView keyUp:]): Ditto.
        (-[KWQTextAreaTextView setEnabled:]): Added. Pass value through to editable
attribute on text view.
        (-[KWQTextAreaTextView isEnabled]): Added.
        (-[KWQTextAreaTextView drawRect:]): Set the text color to a disabled color
when disabled.
        * kwq/KWQTextEdit.h:
        * kwq/KWQTextEdit.mm:
        (QTextEdit::isDisabled): Added.
        (QTextEdit::setDisabled): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed 3449405 - REGRESSION: reproducible crash changing focus w/ button on page...
mjs [Fri, 10 Oct 2003 07:45:58 +0000 (07:45 +0000)]
- fixed 3449405 - REGRESSION: reproducible crash changing focus w/ button on page, e.g. on aa.com

More fallout from the exception blocking.

        * kwq/KWQButton.mm:
        (QButton::focusPolicy): Don't return from exception block (caught
by Darin).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Fri, 10 Oct 2003 05:49:43 +0000 (05:49 +0000)]
    Reviewed by Maciej.

        - fixed 3449280 -- REGRESSION: crash copying a selection that ends in a <br>

        * khtml/rendering/render_br.h: Add checkSelectionPointIgnoringContinuations.
        * khtml/rendering/render_br.cpp: (RenderBR::checkSelectionPointIgnoringContinuations):
        Override to never return an offset of 1. We can't use a character offset because the
        DOM doesn't know that we're implemented as a text object. So an offset of 1 turns into
        "after this element".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed crash I just added.
mjs [Fri, 10 Oct 2003 03:21:48 +0000 (03:21 +0000)]
    - fixed crash I just added.

        * kwq/KWQWidget.mm:
        (QWidget::setCursor): Move BLOCK_NS_EXCEPTIONS macros so
you don't `break' out of the blocking code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Ensure that the autoscroll timer is always stopped if a mouse up event is lost.
rjw [Fri, 10 Oct 2003 00:46:11 +0000 (00:46 +0000)]
Ensure that the autoscroll timer is always stopped if a mouse up event is lost.

        Reviewed by John.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLView _startAutoscrollTimer:]):
        (-[WebHTMLView _stopAutoscrollTimer]):
        (-[WebHTMLView _autoscroll]):
        (-[WebHTMLView mouseDown:]):
        * WebView.subproj/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
mjs [Thu, 9 Oct 2003 22:56:15 +0000 (22:56 +0000)]
    Reviewed by Ken.

More Cocoa exception blocking work.

        * kwq/KWQFrame.mm:
        (QFrame::setFrameStyle):
        * kwq/KWQLineEdit.mm:
        (QLineEdit::QLineEdit):
        (QLineEdit::~QLineEdit):
        (QLineEdit::setEchoMode):
        (QLineEdit::setFont):
        (QLineEdit::setText):
        (QLineEdit::text):
        (QLineEdit::isReadOnly):
        (QLineEdit::setReadOnly):
        (QLineEdit::maxLength):
        (QLineEdit::selectAll):
        (QLineEdit::edited):
        (QLineEdit::setEdited):
        (QLineEdit::sizeForCharacterWidth):
        (QLineEdit::baselinePosition):
        (QLineEdit::setAlignment):
        * kwq/KWQListBox.mm:
        (QListBox::QListBox):
        (QListBox::~QListBox):
        (QListBox::count):
        (QListBox::clear):
        (QListBox::setSelectionMode):
        (QListBox::insertItem):
        (QListBox::insertGroupLabel):
        (QListBox::endBatchInsert):
        (QListBox::setSelected):
        (QListBox::isSelected):
        (QListBox::setEnabled):
        (QListBox::sizeForNumberOfLines):
        (QListBox::focusPolicy):
        * kwq/KWQPushButton.mm:
        (QPushButton::QPushButton):
        (QPushButton::sizeHint):
        (QPushButton::baselinePosition):
        (QPushButton::dimensions):
        * kwq/KWQRadioButton.mm:
        (QRadioButton::QRadioButton):
        (QRadioButton::setChecked):
        (QRadioButton::isChecked):
        (QRadioButton::dimensions):
        * kwq/KWQScrollBar.mm:
        (-[KWQScrollBar initWithQScrollBar:]):
        (:m_valueChanged):
        (QScrollBar::~QScrollBar):
        (QScrollBar::setValue):
        (QScrollBar::setKnobProportion):
        (QScrollBar::scrollbarHit):
        * kwq/KWQScrollView.mm:
        (QScrollView::visibleWidth):
        (QScrollView::visibleHeight):
        (QScrollView::contentsWidth):
        (QScrollView::contentsHeight):
        (QScrollView::contentsX):
        (QScrollView::contentsY):
        (QScrollView::setContentsPos):
        (QScrollView::setVScrollBarMode):
        (QScrollView::setHScrollBarMode):
        (QScrollView::setScrollBarsMode):
        (QScrollView::vScrollBarMode):
        (QScrollView::hScrollBarMode):
        (QScrollView::hasVerticalScrollBar):
        (QScrollView::hasHorizontalScrollBar):
        (QScrollView::suppressScrollBars):
        (QScrollView::addChild):
        (QScrollView::removeChild):
        (QScrollView::resizeContents):
        (QScrollView::updateContents):
        (QScrollView::contentsToViewport):
        (QScrollView::viewportToContents):
        (QScrollView::setStaticBackground):
        (QScrollView::ensureVisible):
        (QScrollView::getDocumentView):
        * kwq/KWQTextEdit.mm:
        (QTextEdit::QTextEdit):
        (QTextEdit::setText):
        (QTextEdit::text):
        (QTextEdit::textWithHardLineBreaks):
        (QTextEdit::getCursorPosition):
        (QTextEdit::setCursorPosition):
        (QTextEdit::wordWrap):
        (QTextEdit::setWordWrap):
        (QTextEdit::isReadOnly):
        (QTextEdit::setReadOnly):
        (QTextEdit::selectAll):
        (QTextEdit::setFont):
        (QTextEdit::setAlignment):
        (QTextEdit::sizeWithColumnsAndRows):
        * kwq/KWQWidget.mm:
        (QWidget::QWidget):
        (QWidget::~QWidget):
        (QWidget::setActiveWindow):
        (QWidget::setEnabled):
        (QWidget::isEnabled):
        (QWidget::frameGeometry):
        (QWidget::hasFocus):
        (QWidget::setFocus):
        (QWidget::focusPolicy):
        (QWidget::isVisible):
        (QWidget::setCursor):
        (QWidget::cursor):
        (QWidget::setFrameGeometry):
        (QWidget::mapFromGlobal):
        (QWidget::setView):
        (QWidget::getOuterView):
        (QWidget::lockDrawingFocus):
        (QWidget::unlockDrawingFocus):
        (QWidget::disableFlushDrawing):
        (QWidget::enableFlushDrawing):
        (QWidget::setDrawingAlpha):
        (QWidget::paint):
        (QWidget::sendConsumedMouseUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Stop printing extra spaces before list items. Fixes ordered lists with list-style...
hyatt [Thu, 9 Oct 2003 22:20:53 +0000 (22:20 +0000)]
Stop printing extra spaces before list items.  Fixes ordered lists with list-style-position: inside.

        Reviewed by mjs

        * khtml/rendering/render_list.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Make definition of kMin and kMax match the KHTML trunk. Someone still needs to...
hyatt [Thu, 9 Oct 2003 21:59:59 +0000 (21:59 +0000)]
Make definition of kMin and kMax match the KHTML trunk.  Someone still needs to eliminate uses of QMIN
and QMAX from the code.

        * kwq/KWQDef.h:
        (kMin):
        (kMax):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
cblu [Thu, 9 Oct 2003 20:41:36 +0000 (20:41 +0000)]
WebCore:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

        Reviewed by rjw.

        * khtml/ecma/kjs_navigator.cpp:
        (PluginBase::refresh): new
        (PluginsFunc::tryCall): call refresh
        * kwq/KWQKConfigBase.h:
        * kwq/KWQKConfigBase.mm:
        (RefreshPlugins): new
        * kwq/WebCoreViewFactory.h:

WebKit:

Fixed: <rdar://problem/3333897>: should support navigator.plugins.refresh as a way to add a plugin without restarting Safari

        Reviewed by rjw.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView dealloc]): release the plug-in object
        * Plugins.subproj/WebBasePluginPackage.h:
        * Plugins.subproj/WebBasePluginPackage.m:
        (-[WebBasePluginPackage initWithPath:]): store the last mod date
        (-[WebBasePluginPackage dealloc]): release the last mod date
        (-[WebBasePluginPackage lastModifiedDate]): new
        (-[WebBasePluginPackage isEqual:]): new
        (-[WebBasePluginPackage hash]): new
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]): convert the NPP_Shutdown proc pointer so that we can use it later
        (-[WebNetscapePluginPackage unload]): added log message
        * Plugins.subproj/WebPluginDatabase.h:
        * Plugins.subproj/WebPluginDatabase.m:
        (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): tweak
        (-[WebPluginDatabase plugins]): tweak
        (-[WebPluginDatabase init]): call refresh
        (-[WebPluginDatabase refresh]): new
        (-[WebPluginDatabase loadPluginIfNeededForMIMEType:]): tweak
        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory refreshPlugins:]): new
        * WebView.subproj/WebControllerSets.h:
        * WebView.subproj/WebControllerSets.m:
        (+[WebViewSets makeWebViewsPerformSelector:]): new
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _reloadForPluginChanges]): new
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebView.m:
        (-[WebView _reloadForPluginChanges]): new
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agotree is open for Safari-110!
vicki [Thu, 9 Oct 2003 20:15:11 +0000 (20:15 +0000)]
tree is open for Safari-110!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoSafari-109 stamp
vicki [Thu, 9 Oct 2003 20:12:30 +0000 (20:12 +0000)]
Safari-109 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding layout test for section 10.3.7 of the CSS2.1 spec.
hyatt [Thu, 9 Oct 2003 01:35:21 +0000 (01:35 +0000)]
Adding layout test for section 10.3.7 of the CSS2.1 spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3436723, the shrink-to-fit algorithm for positioned elements did not match
hyatt [Thu, 9 Oct 2003 01:34:03 +0000 (01:34 +0000)]
Fix for 3436723, the shrink-to-fit algorithm for positioned elements did not match
the algorithm specified in section 10.3.7 of the CSS2.1 specification.  The min-width
of the element was not being taken into account like it should have been.

        Reviewed by mjs

        * khtml/rendering/render_box.cpp:
        (RenderBox::calcAbsoluteHorizontal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Implement min/max width and min/max height support for replaced elements.
hyatt [Thu, 9 Oct 2003 00:45:35 +0000 (00:45 +0000)]
Implement min/max width and min/max height support for replaced elements.

        Reviewed by ken

        * khtml/rendering/render_box.cpp:
        (RenderBox::calcReplacedWidth):
        (RenderBox::calcReplacedWidthUsing):
        (RenderBox::calcReplacedHeight):
        (RenderBox::calcReplacedHeightUsing):
        (RenderBox::availableHeight):
        (RenderBox::availableHeightUsing):
        * khtml/rendering/render_box.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5150 268f45cc-cd09-0410-ab3c-d52691b4dbfc