WebKit-https.git
11 years ago2008-08-08 Maxime Britto <britto@apple.com>
britto@apple.com [Sat, 9 Aug 2008 00:15:05 +0000 (00:15 +0000)]
2008-08-08  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        Test: fast/events/scroll-to-anchor-in-overflow-hidden.html
        https://bugs.webkit.org/show_bug.cgi?id=20270
        Jump to an anchor wasn't working when the overflow:hidden CSS attribute was set on the page.

        * WebCore.base.exp:
        * dom/Element.cpp:
        (WebCore::Element::scrollIntoView):
        (WebCore::Element::scrollIntoViewIfNeeded):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::gotoAnchor):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseDraggedEvent):
        * page/Frame.cpp:
        (WebCore::Frame::revealSelection):
        (WebCore::Frame::revealCaret):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): Takes a new parameter "scrollToAnchor" since it's a special case of scroll. It passes this new bool to canBeProgrammaticallyScrolled.
        (WebCore::RenderLayer::autoscroll):
        * rendering/RenderLayer.h:
        * rendering/RenderListBox.h:
        (WebCore::RenderListBox::canBeProgramaticallyScrolled):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled): If the call is coming from a scrollToAnchor we don't need scrollBars to accept.
        * rendering/RenderObject.h:
        * rendering/RenderTextControl.h:
        (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2008-08-08  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        * WebView/WebFrame.mm:
        (-[WebFrame _scrollDOMRangeToVisible:]):

2008-08-08  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.
        https://bugs.webkit.org/show_bug.cgi?id=20270
        This test is automatic and can also be run manually.

        * fast/events/scroll-to-anchor-in-overflow-hidden-expected.txt: Added.
        * fast/events/scroll-to-anchor-in-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-08 Maxime Britto <britto@apple.com>
britto@apple.com [Fri, 8 Aug 2008 23:40:54 +0000 (23:40 +0000)]
2008-08-08  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        <rdar://problem/6137022>
        <https://bugs.webkit.org/show_bug.cgi?id=20331>
        REGRESSION(r35177-r35203): Scrolling slowly over a scrollable field scrolls the page instead of the field (20331)

        * page/EventHandler.cpp:
        (WebCore::scrollAndAcceptEvent): fixed the wrong cast for the wheel delta which was truncated to 0 on slow wheel scrolls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoExecute CSS Animations using new AnimationController
dino@apple.com [Fri, 8 Aug 2008 20:44:14 +0000 (20:44 +0000)]
Execute CSS Animations using new AnimationController
https://bugs.webkit.org/show_bug.cgi?id=20119

I still need to file some follow-on bugs that EricS noticed.

Reviewed by Dave Hyatt

Some new tests:
* manual-tests/animate-duration.html: Added.
* manual-tests/animate-left.html: Added.
* manual-tests/animate-none.html: Added.

* css/CSSStyleSelector.cpp:
* dom/Document.cpp:
    - don't redo style when page is place into cache
* page/AnimationController.cpp:
* page/AnimationController.h:
    - execute the animations
* rendering/RenderObject.cpp:
* rendering/style/RenderStyle.h:
    - make border radii const (for blending)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-08 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 8 Aug 2008 20:25:05 +0000 (20:25 +0000)]
2008-08-08  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6136326> JSProfiler: Start/stop profiling button in the
        Web Inspector does not match the menu.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::toggleRecordButton): Toggle the record
        button in the webInspector.
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        * page/InspectorController.h:
        * page/inspector/ProfilesPanel.js: Move the UI part of the record button
        into its funtion so that it can be called from the Inspector controller.
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-08 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Fri, 8 Aug 2008 18:57:26 +0000 (18:57 +0000)]
2008-08-08  Matt Lilek  <webkit@mattlilek.com>

        Not reviewed, build fix.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-08 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 8 Aug 2008 18:48:26 +0000 (18:48 +0000)]
2008-08-08  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix for <rdar://problem/5865504>

        This bug was actually *largely* fixed by http://trac.webkit.org/changeset/35538.
        But with that same patch, it became possible for a WebResource to fail to initialize.
        Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
        Lets fix that, shall we?

        * WebView/WebArchive.mm:
        (-[WebArchive subresources]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-08 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 8 Aug 2008 18:21:26 +0000 (18:21 +0000)]
2008-08-08  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6131187> Profiles don't show up immediately when run
        with the UI.

        * page/InspectorController.cpp:
        (WebCore::startProfiling): Added so that the inspector's JS code could
        call through to the same function used by the Develop menu.  This way
        both can call didFinishAllExecution() which puts the profile in the
        Web Inspector.
        (WebCore::stopProfiling): Ditto
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::stopUserInitiatedProfiling): Now calls
        didFinishAllExecution() to put the profile in the Web Inspector.  This
        should be safe since the UIs shouldn't work if JS is still running.
        * page/inspector/ProfilesPanel.js: Use the new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 8 Aug 2008 17:38:45 +0000 (17:38 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/5961260> GDI text: transparent fill color text does not render if it it has a stroke or shadow

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove performance of arithmetic operators
oliver@apple.com [Fri, 8 Aug 2008 09:48:10 +0000 (09:48 +0000)]
Improve performance of arithmetic operators

Reviewed by Cameron Zwarich

Added a fast (non-virtual) mechanism to determine if a non-immediate JSValue*
is a JSNumberCell.  We then use this to allow improved specialisation in many
arithmetic operators.  SunSpider reports a 2.5% progression overall, with greater
than 10% progressions on a number of arithmetic heavy tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-08 Adam Treat <treat@kde.org>
hausmann@webkit.org [Fri, 8 Aug 2008 09:32:51 +0000 (09:32 +0000)]
2008-08-08  Adam Treat  <treat@kde.org>

        Reviewed by Simon.

        Return the canonical file path in Qt's listDirectory as WebCore::PluginDatabase
        uses this method to retrieve a list of possible plugins.  Many linux systems
        have nested symbolic links scattered throughout the plugin directories which
        resulted in the PluginDatabase loading the same plugin N times depending on
        the number of symbolic links.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix bug numbers.
timothy@apple.com [Fri, 8 Aug 2008 04:05:33 +0000 (04:05 +0000)]
Fix bug numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Change highlight time from 300ms to 500ms and fade effect from 1s to 2s
timothy@apple.com [Fri, 8 Aug 2008 03:56:09 +0000 (03:56 +0000)]
    Change highlight time from 300ms to 500ms and fade effect from 1s to 2s

        https://bugs.webkit.org/show_bug.cgi?id=17589

        Reviewed by Timothy Hatcher.

        * page/inspector/SourceFrame.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago The search is only performed if the field contains more than 3
timothy@apple.com [Fri, 8 Aug 2008 03:55:53 +0000 (03:55 +0000)]
    The search is only performed if the field contains more than 3
        letters or if Enter is pressed.

        Search is now performed through a keyup event.

        Added a WebInspector.lastQuery to remember the last query and not
        perform it again (eg. the user hits a modifier key).

        https://bugs.webkit.org/show_bug.cgi?id=18548

        Reviewed by Timothy Hatcher.

        * page/inspector/inspector.html: Removed the onsearch and incremental
        attributes
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Compile derived sources through an all-in-one cpp file.
sfalken@apple.com [Thu, 7 Aug 2008 23:38:25 +0000 (23:38 +0000)]
    Compile derived sources through an all-in-one cpp file.
        Fixes Windows release build on non-x64 systems by reducing the size of WebCore.lib from 1.5GB to 1GB.

        Reviewed by Mark Rowe.

        * DerivedSources.cpp: Added.
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-07 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 7 Aug 2008 22:29:24 +0000 (22:29 +0000)]
2008-08-07  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5712917> Confusing console error message clear
        behavior (16791)
        https://bugs.webkit.org/show_bug.cgi?id=16791
        <rdar://problem/5831899> The Web Inspector does not correctly clear the
        console messages

        * page/InspectorController.cpp: Clear the message so they don't show up
        in the inspector after it has cleared them.
        (WebCore::clearMessages):
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        * page/InspectorController.h:
        * page/inspector/Console.js: Tell the InspectorController to clear the
        messages it's holding onto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 Aug 2008 21:55:37 +0000 (21:55 +0000)]
2008-08-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig

        Rename Marquee to RenderMarquee and move to its own file.
        https://bugs.webkit.org/show_bug.cgi?id=20319

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/HTMLMarqueeElement.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderLayer.h:
        * rendering/RenderMarquee.cpp: Added.
        (WebCore::RenderMarquee::RenderMarquee):
        (WebCore::RenderMarquee::marqueeSpeed):
        (WebCore::RenderMarquee::direction):
        (WebCore::RenderMarquee::isHorizontal):
        (WebCore::RenderMarquee::computePosition):
        (WebCore::RenderMarquee::start):
        (WebCore::RenderMarquee::suspend):
        (WebCore::RenderMarquee::stop):
        (WebCore::RenderMarquee::updateMarqueePosition):
        (WebCore::RenderMarquee::updateMarqueeStyle):
        (WebCore::RenderMarquee::timerFired):
        * rendering/RenderMarquee.h: Added.
        (WebCore::RenderMarquee::speed):
        (WebCore::RenderMarquee::reverseDirection):
        (WebCore::RenderMarquee::setEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Thu, 7 Aug 2008 20:32:22 +0000 (20:32 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6118816> Initial empty page or bookmarks view window has white strip where vertical scrollbar would be (which vanishes on resize)

        * page/Frame.cpp:
        (WebCore::Frame::setZoomFactor): If the view has never had a layout with
        the old zoom factor, then there is no need to explicitly call layout()
        here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-07 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 7 Aug 2008 17:28:54 +0000 (17:28 +0000)]
2008-08-07  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6115981> Start the profiler in Heavy view

        * page/inspector/ProfileView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Delete backing stores before 5 second WM_TIMER fires if more than 2 are alrea...
sfalken@apple.com [Thu, 7 Aug 2008 16:04:57 +0000 (16:04 +0000)]
    Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.

        WM_TIMER-based timers can be starved if enough other events are keeping
        our message loop busy. This change prevents many backing store deletes from stacking
        up in this case.

        Reviewed by Geoff Garen.

        * WebView.cpp:
        (WebView::deleteBackingStore):
        (WebView::deleteBackingStoreSoon):
        (WebView::cancelDeleteBackingStoreSoon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-07 Alp Toker <alp@nuanti.com>
jmalonzo@webkit.org [Thu, 7 Aug 2008 12:09:19 +0000 (12:09 +0000)]
2008-08-07  Alp Toker  <alp@nuanti.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20313
        Add null check in String::fromUTF8()

        Make String::fromUTF8() consistent with other constructors by
        returning a null String when the input is null instead of crashing.

        * platform/text/String.cpp:
        (WebCore::String::fromUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-07 Kalle Vahlman <zuh@iki.fi>
jmalonzo@webkit.org [Thu, 7 Aug 2008 12:08:52 +0000 (12:08 +0000)]
2008-08-07  Kalle Vahlman  <zuh@iki.fi>

        Reviewed by David Kilzer.

        Check for correct flex version to avoid faulty builds

        A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it
        https://bugs.webkit.org/show_bug.cgi?id=20253

        acinclude.m4: Import AX_COMPARE_VERSION macro
        configure.ac: Check for flex version

        * acinclude.m4:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-07 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 7 Aug 2008 11:31:59 +0000 (11:31 +0000)]
2008-08-07  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Lars.

        Added API tests for QWebPage/QWebFrame based on QTestLib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Thu, 7 Aug 2008 03:52:05 +0000 (03:52 +0000)]
Reviewed by Kevin Ollivier.

Create a wxWebFrame API to match other ports and to prepare for frames support.
Also fixes a frame leak in wx port on trunk.

https://bugs.webkit.org/show_bug.cgi?id=19041

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Thu, 7 Aug 2008 00:46:58 +0000 (00:46 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix after Frame -> ScriptController moves. Also, remove a character which...
kevino@webkit.org [Wed, 6 Aug 2008 23:48:38 +0000 (23:48 +0000)]
wx build fix after Frame -> ScriptController moves. Also, remove a character which was in an unknown encoding and replace it with an ANSI representation (which the author used for their Bugzilla account too).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 6 Aug 2008 23:08:20 +0000 (23:08 +0000)]
2008-08-06  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - Make XHR console message clearer.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 6 Aug 2008 23:07:27 +0000 (23:07 +0000)]
2008-08-06  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - Created a new function to create DOM links from text without
        converting back and forth from HTML and messing with escaping special
        characters.

        * page/inspector/Console.js:
        * page/inspector/inspector.js:
        * page/inspector/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by hyatt.
eric@webkit.org [Wed, 6 Aug 2008 22:39:04 +0000 (22:39 +0000)]
    Reviewed by hyatt.

        Fix a large animation leak found on the buildbot
        (m_animations and m_transitions were never deleted)
        Drag RenderStyle (kicking and screaming) into the 21st century
        of memory management with a little application of OwnPtr.

        * rendering/style/RenderStyle.cpp:
        (WebCore::FillLayer::cullEmptyLayers):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::contentDataEquivalent):
        (WebCore::RenderStyle::setContent):
        (WebCore::BindingURI::BindingURI):
        (WebCore::RenderStyle::setBoxShadow):
        (WebCore::ShadowData::ShadowData):
        (WebCore::RenderStyle::counterDirectives):
        (WebCore::RenderStyle::accessCounterDirectives):
        (WebCore::RenderStyle::adjustAnimations):
        (WebCore::RenderStyle::adjustTransitions):
        (WebCore::RenderStyle::accessAnimations):
        (WebCore::RenderStyle::accessTransitions):
        * rendering/style/RenderStyle.h:
        (WebCore::RenderStyle::clearAnimations):
        (WebCore::RenderStyle::clearTransitions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 6 Aug 2008 22:17:52 +0000 (22:17 +0000)]
2008-08-06  Brady Eidson  <beidson@apple.com>

        Reviewed by MitzPettel

        <rdar://problem/6078543> - Many LocalStorageThreads may be started

        The original decision to key LocalStorage sets to PageGroups was a poor one.

        It seems a much better solution is to key them to the actual path of on-disk storage,
        which also solves all of the avenues that could lead to a boundless number of threads.

        In this patch, I am not attempting to completely sever the attachment of LocalStorage
        to PageGroups as that would require a more substantial re-working of the lifetime
        between pages, groups, and local storage threads.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::addPage):

        * storage/LocalStorage.cpp:
        (WebCore::localStorageMap):  Map paths to LocalStorage objects here.
        (WebCore::LocalStorage::localStorage): Return the shared LocalStorage object for this path,
          or create a new one if it doesn't yet exist.
        (WebCore::LocalStorage::LocalStorage):
        (WebCore::LocalStorage::~LocalStorage):  Add to remove the path->LocalStorage mapping
        * storage/LocalStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 6 Aug 2008 22:12:13 +0000 (22:12 +0000)]
2008-08-06  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6130724>

        Disconnected frames should not be allowed to resize the window.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::resizeBy):
        (WebCore::DOMWindow::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded bug URLs
mitz@apple.com [Wed, 6 Aug 2008 21:27:58 +0000 (21:27 +0000)]
Added bug URLs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ddkilzer@apple.com [Wed, 6 Aug 2008 21:15:39 +0000 (21:15 +0000)]
WebCore:

        Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com

        <https://bugs.webkit.org/show_bug.cgi?id=20038>
        <rdar://problem/6092270>

        Reviewed by Eric Seidel.

        Test: fast/forms/submit-to-url-fragment.html

        The problem was that isFormSubmission was not being set to true in
        FrameLoader::loadWithDocumentLoader() when we were actually
        submitting a form, causing the page to scroll instead of the form to
        be submitted.

        The isFormSubmission variable wasn't set to true because a FormState
        object was not being created in
        FrameLoader::loadFrameRequestWithFormAndValues().

        The FormState object was not being created because
        HTMLFormElement::submit(Event*, bool activateSubmitButton) would
        only set FrameLoader::m_formAboutToBeSubmitted to the current form
        if there was a "text field" element in the form (type = text,
        password, search or isindex).

        Thus when FrameLoader::submitForm(const FrameLoadRequest&, Event*)
        called FrameLoader::loadFrameRequestWithFormAndValues(), a null
        HTMLFormElement pointer would be sent and cause the above failures.

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submit): Call new
        FrameLoader::setFormAboutToBeSubmitted() method outside the for
        loop so we always set FrameLoader::m_formAboutToBeSubmitted exactly
        once for any form submission.  The FrameLoader::recordFormValue()
        method is only called with the name/value pair of each text field.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::setFormAboutToBeSubmitted): Added method that
        only sets m_formAboutToBeSubmitted.
        (WebCore::FrameLoader::recordFormValue): Removed
        PassRefPtr<HTMLFormElement> argument since this method only sets
        name/value pairs on m_formValuesAboutToBeSubmitted now.
        (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Create a
        FormState object as long as submitForm is not null so that other
        FrameLoader methods know when a form is being submitted.
        * loader/FrameLoader.h:

LayoutTests:

        Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com

        <https://bugs.webkit.org/show_bug.cgi?id=20038>
        <rdar://problem/6092270>

        Reviewed by Eric Seidel.

        * fast/forms/submit-to-url-fragment-expected.txt: Added.
        * fast/forms/submit-to-url-fragment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago BUILD FIX: Add HTMLPlugInImageElement.cpp to all other build systems
ddkilzer@apple.com [Wed, 6 Aug 2008 20:26:23 +0000 (20:26 +0000)]
    BUILD FIX: Add HTMLPlugInImageElement.cpp to all other build systems

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - Windows build fix
mitz@apple.com [Wed, 6 Aug 2008 20:22:33 +0000 (20:22 +0000)]
    - Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Added PlugInImageElement.*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by darin.
eric@webkit.org [Wed, 6 Aug 2008 20:01:35 +0000 (20:01 +0000)]
    Reviewed by darin.

        Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.

        I've made AccessibilityUIElement a stack object for now.  It could be
        made RefCounted, but I figured that might be overkill for the moment.
        Essentially it's just a RefPtr itself. :)

        I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
        which was causing additional leaks. :)

        I added toAXElement to remove a bunch of copy/paste code.

        * DumpRenderTree/AccessibilityController.h:
        * DumpRenderTree/AccessibilityUIElement.cpp:
        (toAXElement):
        (allAttributesCallback):
        (attributesOfLinkedUIElementsCallback):
        (attributesOfChildrenCallback):
        (lineForIndexCallback):
        (boundsForRangeCallback):
        (childAtIndexCallback):
        (getRoleCallback):
        (getTitleCallback):
        (getDescriptionCallback):
        (getWidthCallback):
        (getHeightCallback):
        (getIntValueCallback):
        (getMinValueCallback):
        (getMaxValueCallback):
        (getInsertionPointLineNumberCallback):
        (finalize):
        * DumpRenderTree/AccessibilityUIElement.h:
        (AccessibilityUIElement::platformUIElement):
        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::focusedElement):
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::AccessibilityUIElement):
        (AccessibilityUIElement::getLinkedUIElements):
        (AccessibilityUIElement::getChildren):
        (AccessibilityUIElement::getChildAtIndex):
        (AccessibilityUIElement::attributesOfLinkedUIElements):
        (AccessibilityUIElement::attributesOfChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 6 Aug 2008 18:47:43 +0000 (18:47 +0000)]
2008-08-06  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim and Darin.

        <rdar://problem/6126160> URLs in the console should be clickable.
        - Implemented and now use linkifyString() to parse console messages for
        URLs.

        * page/inspector/Console.js:
        * page/inspector/inspector.js:
        * page/inspector/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ddkilzer@apple.com [Wed, 6 Aug 2008 17:23:22 +0000 (17:23 +0000)]
WebCore:

        Images using QT plugin do not display correctly

        <https://bugs.webkit.org/show_bug.cgi?id=9214>
        <rdar://problem/5683413>

        Reviewed by Darin.

        Tests: fast/images/embed-image.html
               fast/images/object-image.html

        Use RenderImage instead of RenderPartObject for a renderer when
        the <embed> tag references an image.  Extract common code from
        HTMLEmbedElement and HTMLObjectElement into HTMLPlugInImageElement.

        * WebCore.xcodeproj/project.pbxproj: Added new source files.

        * html/HTMLEmbedElement.cpp: Cleaned up #include statements.
        (WebCore::HTMLEmbedElement::HTMLEmbedElement): Extend
        HTMLPlugInImageElement which extends HTMLPlugInElement.
        (WebCore::HTMLEmbedElement::parseMappedAttribute): Split codeAttr
        and srcAttr cases.  Create or clear HTMLImageLoader as needed for
        srcAttr.
        (WebCore::HTMLEmbedElement::rendererIsNeeded): Use
        HTMLPlugInElement::rendererIsNeeded() for images.
        (WebCore::HTMLEmbedElement::createRenderer): Create a
        RenderImage instead of a RenderPartObject for images.
        (WebCore::HTMLEmbedElement::attach): Create HTMLImageLoader,
        load image and populate RenderImage for images.
        (WebCore::HTMLEmbedElement::updateWidget): Don't call
        RenderPartObject::updateWidget() for images.
        (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
        * html/HTMLEmbedElement.h: Removed unneeded namespace and class
        declarations.  Extend HTMLPlugInImageElement which extends
        HTMLPlugInElement.
        (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
        (WebCore::HTMLEmbedElement::serviceType): Moved to
        HTMLPlugInImageElement.
        (WebCore::HTMLEmbedElement::url): Ditto.

        * html/HTMLObjectElement.cpp: Cleaned up #include statements.
        (WebCore::HTMLObjectElement::attach): Removed local variable.
        (WebCore::HTMLObjectElement::isImageType): Moved to
        HTMLPlugInImageElement.
        * html/HTMLObjectElement.h: Extend HTMLPlugInImageElement which
        extends HTMLPlugInElement.
        (WebCore::HTMLObjectElement::isImageType): Moved to
        HTMLPlugInImageElement.
        (WebCore::HTMLObjectElement::serviceType): Ditto.
        (WebCore::HTMLObjectElement::url): Ditto.

        * html/HTMLPlugInImageElement.cpp: Added.
        (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Added.
        (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): Added.
        (WebCore::HTMLPlugInImageElement::isImageType): Moved from
        HTMLObjectElement.
        * html/HTMLPlugInImageElement.h: Added.
        (WebCore::HTMLPlugInImageElement::isImageType): Added from
        HTMLObjectElement.
        (WebCore::HTMLPlugInImageElement::serviceType): Ditto.
        (WebCore::HTMLPlugInImageElement::url): Ditto.

        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteImageURL): Return urlString
        for embed elements with images.

LayoutTests:

        Images using QT plugin do not display correctly

        <https://bugs.webkit.org/show_bug.cgi?id=9214>
        <rdar://problem/5683413>

        Reviewed by Darin.

        Test images rendered by both embed and object elements.

        * fast/images/embed-image.html: Added.
        * fast/images/object-image.html: Added.
        * platform/mac/fast/images/embed-image-expected.checksum: Added.
        * platform/mac/fast/images/embed-image-expected.png: Added.
        * platform/mac/fast/images/embed-image-expected.txt: Added.
        * platform/mac/fast/images/object-image-expected.checksum: Added.
        * platform/mac/fast/images/object-image-expected.png: Added.
        * platform/mac/fast/images/object-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix an accessibility layout test that was failing on different platforms
cfleizach@apple.com [Wed, 6 Aug 2008 16:33:19 +0000 (16:33 +0000)]
Fix an accessibility layout test that was failing on different platforms

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Try to fix the Windows build bots
aroben@apple.com [Wed, 6 Aug 2008 14:50:00 +0000 (14:50 +0000)]
    Try to fix the Windows build bots

        * API/JSBase.cpp: Touch this to force JSC to rebuild and re-copy the
        WTF headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Benjamin C Meyer <ben@meyerhome.net>
hausmann@webkit.org [Wed, 6 Aug 2008 13:30:07 +0000 (13:30 +0000)]
2008-08-06  Benjamin C Meyer  <ben@meyerhome.net>

        Reviewed by Simon.

        During the drag operation only accept the event if the action is not ignore action.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert change 35595.
vestbo@webkit.org [Wed, 6 Aug 2008 13:02:27 +0000 (13:02 +0000)]
Revert change 35595.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Wed, 6 Aug 2008 12:46:40 +0000 (12:46 +0000)]
2008-08-06  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=20295
        RegularExpression::match should not crash when a null string is passed

        RegularExpression::match used to pass null subject strings to
        jsRegExpExecute causing an ASSERT failure and then a crash.
        There is no need to fix also RegularExpression:search and
        RegularExpression::searchRev as they just call
        RegularExpression::match.

        * platform/text/RegularExpression.cpp:
        (WebCore::RegularExpression::match): Return -1 if the string is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Wed, 6 Aug 2008 12:40:53 +0000 (12:40 +0000)]
2008-08-06  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=20276
        [GTK] Makefile rules for the enum GTypes files depend on Makefile
        instead of GNUmakefile

        The patch committed in revision 34649 added the code needed to
        generate GTypes for enums but the makefile rules for
        stamp-webkitenumtypes.h and webkitenumtypes.cpp were depending on
        Makefile (used by other ports) instead of GNUmakefile.

        * GNUmakefile.am: Depend on GNUmakefile instead of Makefile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 6 Aug 2008 12:35:28 +0000 (12:35 +0000)]
2008-08-06  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix only

        * bindings/js/ScriptControllerGtk.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::~PluginView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Cameron Zwarich.
eric@webkit.org [Wed, 6 Aug 2008 12:11:29 +0000 (12:11 +0000)]
    Reviewed by Cameron Zwarich.

        Fix warnings and errors seen on Qt bot.
        Including one correctness fix for ThreadingQt.
        According to the Qt 4.4 docs, we were always passing
        seconds to "wait()" when we should have been passing
        milliseconds.

        Lots of float <-> int conversion warnings.

        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        * dom/Element.cpp:
        (WebCore::adjustForLocalZoom):
        (WebCore::adjustForAbsoluteZoom):
        (WebCore::Element::setScrollLeft):
        (WebCore::Element::setScrollTop):
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::imageRect):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::innerHeight):
        (WebCore::DOMWindow::innerWidth):
        (WebCore::DOMWindow::scrollX):
        (WebCore::DOMWindow::scrollY):
        (WebCore::DOMWindow::scrollTo):
        * page/EventHandler.cpp:
        (WebCore::scrollAndAcceptEvent):
        * plugins/npapi.cpp:
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::~PluginView):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::intrinsicSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Wed, 6 Aug 2008 11:46:59 +0000 (11:46 +0000)]
2008-08-06  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Fix the Qt build due to recent ScriptController refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix non-Mac build.
vestbo@webkit.org [Wed, 6 Aug 2008 11:46:03 +0000 (11:46 +0000)]
Fix non-Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Wed, 6 Aug 2008 11:17:21 +0000 (11:17 +0000)]
2008-08-06  Ariya Hidayat  <ariya.hidayat@trolltech.com>

       Fix non-Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
cwzwarich@webkit.org [Wed, 6 Aug 2008 10:50:07 +0000 (10:50 +0000)]
2008-08-06  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Darin. Landed by Cameron.

        Bug 20272: typo in JavaScriptCore
        <https://bugs.webkit.org/show_bug.cgi?id=20272>

        Correct the documentation for op_not. (typo)
        Fix #undef. (typo)

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-06 Cameron Zwarich <cwzwarich@webkit.org>
cwzwarich@webkit.org [Wed, 6 Aug 2008 10:37:34 +0000 (10:37 +0000)]
2008-08-06  Cameron Zwarich  <cwzwarich@webkit.org>

        Reviewed by Maciej.

        Bug 20286: Load constants all at once instead of using op_load
        <https://bugs.webkit.org/show_bug.cgi?id=20286>

        Load constants all at once into temporary registers instead of using
        individual instances of op_load.

        This is a 2.6% speedup on SunSpider.

        JavaScriptCore:

        * JavaScriptCore.exp:
        * VM/CodeBlock.cpp:
        (KJS::CodeBlock::dump):
        (KJS::CodeBlock::mark):
        * VM/CodeBlock.h:
        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator):
        (KJS::CodeGenerator::newTemporary):
        (KJS::CodeGenerator::addConstant):
        (KJS::CodeGenerator::addUnexpectedConstant):
        (KJS::CodeGenerator::emitLoad):
        (KJS::CodeGenerator::emitUnexpectedLoad):
        (KJS::CodeGenerator::emitNewError):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::slideRegisterWindowForCall):
        (KJS::Machine::unwindCallFrame):
        (KJS::Machine::throwException):
        (KJS::Machine::execute):
        (KJS::Machine::privateExecute):
        * VM/Machine.h:
        * VM/Opcode.h:
        * VM/RegisterID.h:
        (KJS::RegisterID::RegisterID):
        (KJS::RegisterID::makeConstant):
        (KJS::RegisterID::isTemporary):
        * kjs/NodeInfo.h:
        * kjs/Parser.cpp:
        (KJS::Parser::didFinishParsing):
        * kjs/Parser.h:
        (KJS::Parser::parse):
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::NullNode::emitCode):
        (KJS::BooleanNode::emitCode):
        (KJS::NumberNode::emitCode):
        (KJS::StringNode::emitCode):
        (KJS::ArrayNode::emitCode):
        (KJS::DeleteResolveNode::emitCode):
        (KJS::DeleteValueNode::emitCode):
        (KJS::VoidNode::emitCode):
        (KJS::ConstDeclNode::emitCodeSingle):
        (KJS::ReturnNode::emitCode):
        (KJS::ScopeNode::ScopeNode):
        (KJS::ProgramNode::ProgramNode):
        (KJS::ProgramNode::create):
        (KJS::EvalNode::EvalNode):
        (KJS::EvalNode::create):
        (KJS::FunctionBodyNode::FunctionBodyNode):
        (KJS::FunctionBodyNode::create):
        (KJS::FunctionBodyNode::emitCode):
        * kjs/nodes.h:
        (KJS::ScopeNode::neededConstants):

        LayoutTests:

        * fast/js/constant-count-expected.txt: Added.
        * fast/js/constant-count.html: Added.
        * fast/js/deep-recursion-test.html:
        * fast/js/resources/constant-count.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix only, no review.
eric@webkit.org [Wed, 6 Aug 2008 10:34:57 +0000 (10:34 +0000)]
    Build fix only, no review.

        Attempt to fix the Windows and Qt builds.

        * bindings/js/ScriptControllerWin.cpp: add runtime.h include
        * bindings/js/ScriptControllerQt.cpp: add QWidget include
        * page/win/FrameWin.cpp: remove bogus using namespace
        * plugins/PluginView.cpp:
        (WebCore::PluginView::bindingInstance): use script()
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::getValue): use script()
        (WebCore::PluginView::~PluginView): use script()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix only, no review.
eric@webkit.org [Wed, 6 Aug 2008 10:17:05 +0000 (10:17 +0000)]
    Build fix only, no review.

        Attempt to fix the Linux and --no-svg builds.

        * bindings/js/ScriptController.h: wrap RetainPtr include in PLATFORM(MAC)
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): add missing CSSProperties to switch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Cameron Zwarich.
eric@webkit.org [Wed, 6 Aug 2008 10:01:35 +0000 (10:01 +0000)]
    Reviewed by Cameron Zwarich.

        Move more methods from Frame into ScriptController
        https://bugs.webkit.org/show_bug.cgi?id=20294

        Finally finish more of the work which Darin started long ago
        Move a few more Frame methods into ScriptController.
        I also took this opportunity to clean up some of the plugin
        code as well, and moved some of that into ScriptController.

        I removed Frame::clearScriptController() and ScriptController::clear() is now clearWindowShell()

        No functional changes, thus no test cases.

        * GNUmakefile.am:
        * WebCore.NPAPI.exp:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::bindingRootObject):
        (WebCore::ScriptController::createRootObject):
        (WebCore::ScriptController::windowScriptNPObject):
        (WebCore::ScriptController::createScriptObjectForPluginElement): New method.
        (WebCore::ScriptController::clearPlatformScriptObjects):
        (WebCore::ScriptController::disconnectPlatformScriptObjects):
        (WebCore::ScriptController::cleanupScriptObjectsForPlugin):
        (WebCore::ScriptController::clearScriptObjects):
        * bindings/js/ScriptController.h:
        (WebCore::ScriptController::sourceURL):
        (WebCore::ScriptController::clearFormerWindow):
        * bindings/js/ScriptControllerGtk.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp.
        (WebCore::Frame::createScriptInstanceForWidget):
        * bindings/js/ScriptControllerMac.mm: Added.
        (WebCore::ScriptController::createScriptInstanceForWidget):
        (WebCore::ScriptController::windowScriptObject):
        (WebCore::ScriptController::clearPlatformScriptObjects):
        (WebCore::ScriptController::disconnectPlatformScriptObjects):
        (WebCore::updateRenderingForBindings):
        (WebCore::ScriptController::initJavaJSBindings):
        * bindings/js/ScriptControllerQt.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp.
        (WebCore::ScriptController::createScriptInstanceForWidget):
        * bindings/js/ScriptControllerWin.cpp: Copied from WebCore/svg/graphics/cg/SVGResourceMaskerCg.cpp.
        (WebCore::ScriptController::createScriptInstanceForWidget):
        * bindings/objc/DOM.mm:
        (-[DOMNode KJS::Bindings::]):
        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        * bridge/jni/jni_jsobject.mm:
        (createRootObject):
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
        * html/HTMLAppletElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::findWidgetRenderer):
        (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::~HTMLObjectElement):
        (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
        (WebCore::HTMLObjectElement::detach):
        * html/HTMLObjectElement.h:
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::detach):
        (WebCore::HTMLPlugInElement::getInstance):
        (WebCore::HTMLPlugInElement::parseMappedAttribute):
        (WebCore::HTMLPlugInElement::getNPObject):
        * html/HTMLPlugInElement.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::~Frame):
        (WebCore::Frame::pageDestroyed):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/gtk/FrameGtk.cpp:
        * page/mac/FrameMac.mm:
        * page/qt/FrameQt.cpp:
        * page/win/FrameWin.cpp:
        (WebCore::computePageRectsForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Cameron Zwarich.
eric@webkit.org [Wed, 6 Aug 2008 09:06:11 +0000 (09:06 +0000)]
    Reviewed by Cameron Zwarich.

        Speculative fix for an error I keep seeing in my Cygwin build

        * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
mitz@apple.com [Wed, 6 Aug 2008 07:09:32 +0000 (07:09 +0000)]
    Reviewed by Mark Rowe.

        - fix an assertion failure in Cache::setCapacities()

        * Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize()
        to uint64_t.
        * Misc/WebKitSystemBits.m:
        (WebMemorySize):
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 6 Aug 2008 04:33:48 +0000 (04:33 +0000)]
2008-08-05  Steve Falkenburg  <sfalken@apple.com>

        Fix last timer fix.
        Add null check, clear timer using InterlockedExchange.

        Reviewed by Alice Liu.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::clearTimer):
        (WebCore::queueTimerProc):
        (WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 6 Aug 2008 04:29:57 +0000 (04:29 +0000)]
2008-08-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron.

        - add fast path for immediates to % operator, as we have for many other math ops

        This fixes handling for a 0 divisor relative to the last patch. Only an 0.2% speedup on SunSpider but
        still a 1.4x win on Oliver's prime test.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 6 Aug 2008 00:57:05 +0000 (00:57 +0000)]
2008-08-05  Steve Falkenburg  <sfalken@apple.com>

        Fix timer leak, flag.

        Timers need to be deleted explicitly, even if they fire.
        Also added WT_EXECUTEONLYONCE flag, since this is not a repeating timer.

        Reviewed by Ada Chan.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::queueTimerProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 6 Aug 2008 00:39:06 +0000 (00:39 +0000)]
2008-08-05  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 20293: Crash in JavaScript codegen for eval("const a;")
        <https://bugs.webkit.org/show_bug.cgi?id=20293>

        Correctly handle constant declarations in eval code with no initializer.

        JavaScriptCore:

        * kjs/nodes.cpp:
        (KJS::ConstDeclNode::emitCodeSingle):

        LayoutTests:

        * fast/js/const-expected.txt:
        * fast/js/resources/const.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 6 Aug 2008 00:36:28 +0000 (00:36 +0000)]
2008-08-05  Anders Carlsson  <andersca@apple.com>

        Pass in the correct class here.

        * WebView/WebResource.mm:
        (-[WebResourcePrivate dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
andersca@apple.com [Wed, 6 Aug 2008 00:19:55 +0000 (00:19 +0000)]
WebCore:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/6037398>
        ER: Deallocate WebKit objects on the main thread, even if released on secondary thread

        Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor dealloc]):
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject dealloc]):
        * platform/mac/SharedBufferMac.mm:
        (-[WebCoreSharedBufferData dealloc]):

WebKit/mac:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        <rdar://problem/6037398>
        ER: Deallocate WebKit objects on the main thread, even if released on secondary thread

        Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

        * Carbon/CarbonWindowAdapter.m:
        (-[CarbonWindowAdapter dealloc]):
        * History/WebBackForwardList.mm:
        (-[WebBackForwardList dealloc]):
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem dealloc]):
        * Misc/WebElementDictionary.mm:
        (+[WebElementDictionary initialize]):
        (-[WebElementDictionary dealloc]):
        * WebCoreSupport/WebEditorClient.mm:
        (-[WebEditCommand dealloc]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebArchive.mm:
        (-[WebArchivePrivate dealloc]):
        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLView dealloc]):
        * WebView/WebResource.mm:
        (-[WebResourcePrivate dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago../../../../../../WebCore:
andersca@apple.com [Tue, 5 Aug 2008 23:43:39 +0000 (23:43 +0000)]
../../../../../../WebCore:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Move the main thread deallocator here from WebKit.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/WebCoreObjCExtras.c:
        (method_getImplementation):
        (deallocCallback):
        (WebCoreObjCScheduleDeallocateOnMainThread):
        * platform/mac/WebCoreObjCExtras.h:

../../../../../../WebKit:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Remove MainThreadObjectDeallocator.{h|mm}.

        * WebKit.xcodeproj/project.pbxproj:

../../../../../../WebKit/mac:

2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Remove MainThreadObjectDeallocator.{h|mm}.

        * WebView/MainThreadObjectDeallocator.h: Removed.
        * WebView/MainThreadObjectDeallocator.mm: Removed.

        * WebView/WebView.mm:
        (-[WebView dealloc]):
        Call WebCoreObjCScheduleDeallocateOnMainThread instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoParse CSS Animations, including the new
dino@apple.com [Tue, 5 Aug 2008 23:01:41 +0000 (23:01 +0000)]
Parse CSS Animations, including the new
-webkit-animation properties and the @-webkit-keyframes rule.
Adds some new interfaces for the style rules.

https://bugs.webkit.org/show_bug.cgi?id=20088

Reviewed by David Hyatt.

* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
    build config for new files
* css/tokenizer.flex:
* css/CSSGrammar.y:
* css/CSSParser.cpp:
* css/CSSParser.h:
    new @-webkit-keyframes parsing
* css/CSSPropertyNames.in:
    -webkit-animation properties
* css/CSSRule.h:
* css/CSSStyleSelector.cpp:
* css/CSSStyleSelector.h:
* css/CSSValueKeywords.in:
* css/StyleBase.h:
* css/WebKitCSSKeyframeRule.cpp: Added.
* css/WebKitCSSKeyframeRule.h: Added.
* css/WebKitCSSKeyframesRule.cpp: Added.
* css/WebKitCSSKeyframesRule.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 5 Aug 2008 22:57:53 +0000 (22:57 +0000)]
2008-08-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Make the main thread object deallocator work with subclasses.

        * WebView/MainThreadObjectDeallocator.h:
        * WebView/MainThreadObjectDeallocator.mm:
        (deallocCallback):
        Call the correct dealloc method.

        (scheduleDeallocateOnMainThread):
        Store both the class and the instance, so we know which dealloc method to call.

        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]):
        Schedule deallocation on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add a getter for CFURLRequestRef in WebMutableURLRequest.
adachan@apple.com [Tue, 5 Aug 2008 22:50:46 +0000 (22:50 +0000)]
    Add a getter for CFURLRequestRef in WebMutableURLRequest.

        Reviewed by Anders Carlsson.

        * Interfaces/IWebMutableURLRequestPrivate.idl:
        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::cfRequest):
        * WebMutableURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 5 Aug 2008 22:35:14 +0000 (22:35 +0000)]
2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - LayoutTests fix.  Log only to the Inspector because other listeners may not want
        XHR notifications, including DRT and the numerous tests that don't expect them.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Makes DOM attribute editing start on double-click to match the styles
timothy@apple.com [Tue, 5 Aug 2008 22:34:09 +0000 (22:34 +0000)]
    Makes DOM attribute editing start on double-click to match the styles
        pane. Links in attributes are now triggered with a single click again.

        https://bugs.webkit.org/show_bug.cgi?id=20281

        Reviewed by Adam Roben.

        * English.lproj/localizedStrings.js: Removed some strings.
        * page/inspector/ElementsPanel.js:
        (WebInspector.DOMNodeTreeElement.prototype.onattach): Call
        _preventFollowingLinksOnDoubleClick.
        (WebInspector.DOMNodeTreeElement.prototype._preventFollowingLinksOnDoubleClick):
        Renamed from _makeURLsActivateOnModifiedClick. Simply sets the
        preventFollowOnDoubleClick property on all links.
        (WebInspector.DOMNodeTreeElement.prototype.onselect): Removed
        _selectedByCurrentMouseDown.
        (WebInspector.DOMNodeTreeElement.prototype.onmousedown): Moved
        editing code to ondblclick.
        (WebInspector.DOMNodeTreeElement.prototype.ondblclick): Calls
        _startEditing. Removed URL check.
        (WebInspector.DOMNodeTreeElement.prototype._updateTitle): Calls
        _preventFollowingLinksOnDoubleClick.
        * page/inspector/inspector.css:
        (.editing): Removed the text-decoration property.
        (.editing, .editing *): Added the text-decoration property here
        so it removes underlines on child elements.
        * page/inspector/inspector.js:
        (WebInspector.documentClick): Removed the followOnAltClick code.
        Added support for preventFollowOnDoubleClick, which sets a timeout
        on the first click where future clicks will cancel it (double click).
        If the timeout isn't canceled, the link is followed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 5 Aug 2008 22:10:44 +0000 (22:10 +0000)]
2008-08-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6112219> Video in standalone media document flashes when navigating away

        When navigating out from a page, MediaPlayer was set invisible and then immediately
        made visible again causing flicker in some cases.

        The document is not yet marked being in page cache when willSaveToCache() is called.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::willSaveToCache):
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::updatePlayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - fix typo
mitz@apple.com [Tue, 5 Aug 2008 22:06:34 +0000 (22:06 +0000)]
    - fix typo

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe and Anders Carlsson.
mitz@apple.com [Tue, 5 Aug 2008 22:04:20 +0000 (22:04 +0000)]
    Reviewed by Mark Rowe and Anders Carlsson.

        - fix WebMemorySize() reporting a value capped at 2GB

        * misc/WebKitSystemBits.m:
        (WebMemorySize): Changed to return the max_mem field, which, unlike
        memory_size, is not capped at 2GB.
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the
        same as for 2GB, so that behavior on machines that have more than 2GB
        RAM is not affected by the fix to WebMemorySize().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - try to fix the 64-bit build
mitz@apple.com [Tue, 5 Aug 2008 22:03:23 +0000 (22:03 +0000)]
    - try to fix the 64-bit build

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 5 Aug 2008 21:41:52 +0000 (21:41 +0000)]
2008-08-05  Alp Toker  <alp@nuanti.com>

        Remove leftover mark pragma from r35568 to fix compiler warning spew.

        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Marco Barisione <marco.barisione@collabora.co.uk>
alp@webkit.org [Tue, 5 Aug 2008 21:33:35 +0000 (21:33 +0000)]
2008-08-05  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=19045
        [gtk] ./configure doesn't check for x toolkit availability

        Check for the .pc file for Xt instead of hard coding -lXt in the
        GNUmakefile.am.

        Thanks to Dominik Röttsches for the initial patch.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 5 Aug 2008 19:15:30 +0000 (19:15 +0000)]
2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        - Added a test that checks for several edge cases (see description in
        test.

        * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Dave Hyatt
dino@apple.com [Tue, 5 Aug 2008 19:08:45 +0000 (19:08 +0000)]
Reviewed by Dave Hyatt

Add support for CSS Animation properties to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=20068

(also fix some minor whitespace issues and remove debugging code)

* css/CSSComputedStyleDeclaration.cpp:
* css/CSSStyleSelector.cpp:
* page/AnimationController.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 5 Aug 2008 19:07:27 +0000 (19:07 +0000)]
2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        - Updated a manual test to be an accurate description of what it is
        actually testing.

        * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 5 Aug 2008 19:06:07 +0000 (19:06 +0000)]
2008-08-05  Steve Falkenburg  <sfalken@apple.com>

        Don't invalidate a WebView in the process of being closed when prefs change.

        Reviewed by Ada Chan.

        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 5 Aug 2008 18:00:23 +0000 (18:00 +0000)]
2008-08-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5732836> XMLHttpRequest: Inspector should show network
        activity/XHR in Console (17233)

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the ChangeLog that was corrupted by r34545.
dino@apple.com [Tue, 5 Aug 2008 17:48:53 +0000 (17:48 +0000)]
Fix the ChangeLog that was corrupted by r34545.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Makes the selection surround just the name or value that was
timothy@apple.com [Tue, 5 Aug 2008 16:47:34 +0000 (16:47 +0000)]
    Makes the selection surround just the name or value that was
        double clicked when editing CSS properties. This regressed when
        the Inspector started using focus/blur events, since a focus on
        a content editable region changes the selection.

        https://bugs.webkit.org/show_bug.cgi?id=20280

        Reviewed by Adam Roben.

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.startEditing):
        Change the selection after calling WebInspector.startEditing,
        since WebInspector.startEditing will set an initial selection
        due to a focus event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Changes the editing behavior in the Inspector to commit changes
timothy@apple.com [Tue, 5 Aug 2008 16:47:22 +0000 (16:47 +0000)]
    Changes the editing behavior in the Inspector to commit changes
        when focus is lost, instead of reverting the changes.

        https://bugs.webkit.org/show_bug.cgi?id=20279

        Reviewed by Adam Roben.

        * page/inspector/inspector.js:
        (WebInspector.startEditing): Call editingCommitted in blurEventListener
        instead of editingCancelled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Adds the ability to increment/decrement numbers in editable style
timothy@apple.com [Tue, 5 Aug 2008 16:47:09 +0000 (16:47 +0000)]
    Adds the ability to increment/decrement numbers in editable style
        properties with the arrow and page keys.

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=20273

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateAll):
        Updates all properties in the current section, or all sections
        depending in the argument passed.
        (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
        Call updateAll instead of having duplicate code.
        (WebInspector.StylePropertyTreeElement.prototype.startEditing):
        Assign the list element's handleKeyEvent to editingKeyDown.
        (WebInspector.StylePropertyTreeElement.prototype.editingKeyDown):
        Handles the Up and Down arrows keys. Finds the word based on the
        selection and extracts the number, prefix and suffix. Increments
        or decrements the number based on the key and modifiers. Replaces
        the original word with the new value and selects it. Also applies
        the style so the page reflects the changes live.
        (WebInspector.StylePropertyTreeElement.prototype.editingEnded):
        Delete the handleKeyEvent and originalCSSText properties.
        (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
        If originalCSSText exists, set the cssText to that value and call
        updateAll. Otherwise just call updateTitle like before.
        (WebInspector.StylePropertyTreeElement.prototype.editingCommitted):
        Factored out the style applying code to applyStyleText.
        (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
        Factored out from editingCommitted. Takes an argument that specifies
        if the interface should be updated when the style is applied.
        * page/inspector/inspector.js:
        (WebInspector.startEditing): Call the original key handler, if one
        existed before interrupting key events.
        * page/inspector/utilities.js:
        (getStyleTextWithShorthands): Helper to return CSS text that preserves
        shorthand values, since the cssText property only outputs longhands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Factors out the TextPrompt.scanBackwards function into a generic
timothy@apple.com [Tue, 5 Aug 2008 16:46:56 +0000 (16:46 +0000)]
    Factors out the TextPrompt.scanBackwards function into a generic
        helper function on the Node prototype, named rangeOfWord.

        Reviewed by Adam Roben.

        * page/inspector/Console.js:
        (WebInspector.Console.prototype.completions): Use rangeOfWord.
        * page/inspector/TextPrompt.js:
        (WebInspector.TextPrompt.prototype.complete): Ditto.
        (WebInspector.TextPrompt.prototype.scanBackwards): Removed.
        * page/inspector/utilities.js:
        (Node.prototype.rangeOfWord): Added. Copied from TextPrompt.scanBackwards,
        and added a direction argument allowing scanning forward, backward or
        both directions from the offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixes a bug where the property toggle button would not be hidden
timothy@apple.com [Tue, 5 Aug 2008 16:46:45 +0000 (16:46 +0000)]
    Fixes a bug where the property toggle button would not be hidden
        during editing.

        Reviewed by Adam Roben.

        * page/inspector/inspector.css:
        (li.editing .swatch, li.editing .enabled-button):
        Make the display !important, since a more specific rule for
        .enabledbutton overrides display.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Tue, 5 Aug 2008 13:40:57 +0000 (13:40 +0000)]
2008-08-05  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Move event handling of the return-key from EditorClientQt to QWebPage.

        https://bugs.webkit.org/show_bug.cgi?id=20191

        This is a first step in refactoring the big switch block
        in EditorClientQt::handleKeyboardEvent to using WebActions
        instead.

        The new logic uses two new StandardKeys from QKeySequence:

        - InsertParagraphSeparator
        - InsertLineSeparator

        Which translate to the commands InsertNewline and InsertLineBreak
        respectivly. On Windows/X11 pressing the shift modifier will invoke
        the latter action. For Mac this is triggered by pressing the meta
        modifier (Ctrl).

        Initial patch by: Erik Bunce

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 5 Aug 2008 11:00:13 +0000 (11:00 +0000)]
2008-08-05  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Roll out r35555 because of correctness issues.

        JavaScriptCore:

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

        LayoutTests:

        * fast/js/mod-crash-expected.txt: Added.
        * fast/js/mod-crash.html: Added.
        * fast/js/resources/mod-crash.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Geoffrey Garen.
mitz@apple.com [Tue, 5 Aug 2008 07:40:00 +0000 (07:40 +0000)]
    Reviewed by Geoffrey Garen.

        - remove redundant #imports from FrameMac.mm

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 5 Aug 2008 07:15:04 +0000 (07:15 +0000)]
2008-08-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Geoff.

        - add fast path for immediates to % operator, as we have for many other math ops

        0.6% speedup on SunSpider. 1.4x speedup on a prime testing torture test that Oliver whipped up.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-04 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Tue, 5 Aug 2008 05:13:43 +0000 (05:13 +0000)]
2008-08-04  Alice Liu  <alice.liu@apple.com>

        Reviewed by Steve Falkenburg.

        Fix CFDictionary leak

        * CFDictionaryPropertyBag.cpp:
        (CFDictionaryPropertyBag::Write):
        m_dictionary is a RetainPtr and should adopt the CF type created

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Tue, 5 Aug 2008 04:09:26 +0000 (04:09 +0000)]
WebCore:

2008-08-04  Bernhard Kruepl  <kruepl@dbai.tuwien.ac.at>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
        Corrected offsetTop for table cells by subtracting borderTopExtra

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetTop):

LayoutTests:

2008-08-04  Bernhard Kruepl  <kruepl@dbai.tuwien.ac.at>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
        Tests for offsetTop of table cells updated so that they don't include borderExtraTop

        * fast/dom/Element/offsetTop-table-cell-expected.txt:
        * fast/dom/Element/offsetTop-table-cell.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 5 Aug 2008 03:58:02 +0000 (03:58 +0000)]
2008-08-04  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Dan Bernstein.

        Fix typo in Skipped lists.

        * platform/mac-tiger/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
mrowe@apple.com [Tue, 5 Aug 2008 03:16:05 +0000 (03:16 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdopt the formal protocols where necessary.
mrowe@apple.com [Tue, 5 Aug 2008 02:02:36 +0000 (02:02 +0000)]
Adopt the formal protocols where necessary.
Final part of fix for <rdar://problem/5853147>.

Reviewed by Kevin Decker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDeclare empty protocols when using versions of AppKit that do not use formal protocol...
mrowe@apple.com [Tue, 5 Aug 2008 02:02:33 +0000 (02:02 +0000)]
Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
Part one of fix for <rdar://problem/5853147>.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-04 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 5 Aug 2008 01:54:46 +0000 (01:54 +0000)]
2008-08-04  Dean Jackson  <dino@apple.com>

        Reviewed by Dave Hyatt.

        Improve AnimationController
        https://bugs.webkit.org/show_bug.cgi?id=19938

        - Transition class is now called Animation
        - new state-based AnimationController that can support CSS Animations
        - add support for -webkit-transition-delay
        - remove -webkit-transition-repeat-count (since it never existed officially)
        - updates the -webkit-transition shorthand to reflect removing repeat count
        - updates the Transition class so that properties can be shared with animations
        - adds a "now" keyword for -webkit-transition-delay
        - adds a new change type for style (changed by animation)
        - adds new event names (although they are not dispatched yet)
        - makes text stroke and text fill colors returned by RenderStyle const

        Tests:
        - manual-tests/transition-left.html
        - manual-tests/transition-delay.html
        - manual-tests/transition-timing-functions.html

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSParser.h:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * css/CSSTimingFunctionValue.h:
        * css/CSSValue.h:
        * css/CSSValueKeywords.in:
        * css/WebKitCSSTransformValue.cpp:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/Element.cpp:
        * dom/EventNames.h:
        * dom/Node.cpp:
        * dom/Node.h:
        * history/CachedPage.cpp:
        * page/AnimationController.cpp:
        * page/AnimationController.h:
        * page/Frame.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderWidget.cpp:
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Antti.
eric@webkit.org [Tue, 5 Aug 2008 00:39:22 +0000 (00:39 +0000)]
    Reviewed by Antti.

        Currently we create two copies of script in the HTMLTokenizer.
        One copy gets passed into the javascript engine, the other gets
        stored in the DOM.  Modify the HTMLParser so that it does not
        chunk the string into it's normal 64K chunks for script code,
        and modify the HTMLTokenizer to pass that same string into the
        JS engine.  On some sites (e.g. GMail), which have hundreds of
        KB of inline JS, this saves more than a MB of RAM to run the page.
        (Strings use 16bit strings, so 600KB of JS code == 1.2MB of memory)

        * html\HTMLParser.cpp
        * html\HTMLTokenizer.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Roben.
eric@webkit.org [Mon, 4 Aug 2008 23:01:37 +0000 (23:01 +0000)]
    Reviewed by Adam Roben.

        Fix warning seen in MSVC converting ints to floats.

        * rendering/Length.h:
        (WebCore::Length::calcFloatValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 4 Aug 2008 21:24:47 +0000 (21:24 +0000)]
2008-08-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove extra braces left in from JSLock removal.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::dropProtection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 4 Aug 2008 20:29:46 +0000 (20:29 +0000)]
2008-08-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Update skipped lists for renamed tests.

        * platform/mac-tiger/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Mon, 4 Aug 2008 20:21:19 +0000 (20:21 +0000)]
WebCore:

2008-08-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Implement the Access-control for Cross Site requests
        preflight cache.

        Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html
               http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html
               http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
               http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/KURL.h:
        (WTF::):
        * platform/KURLHash.h: Added.
        (WebCore::KURLHash::hash):
        (WebCore::KURLHash::equal):
        (WTF::):
        * xml/XMLHttpRequest.cpp:
        (WebCore::PreflightResultCacheItem::PreflightResultCacheItem):
        (WebCore::preflightResultCache):
        (WebCore::appendPreflightResultCacheEntry):
        (WebCore::canSkipPrelight):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
        (WebCore::parseAccessControlAllowList):
        (WebCore::parseAccessControlMaxAge):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-08-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Tests for the Access-control for Cross Site requests
        preflight cache.

        * ChangeLog:
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php: Added.
        * http/tests/xmlhttprequest/resources/portabilityLayer.php: Added.
        * http/tests/xmlhttprequest/resources/reset-temp-file.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35540 268f45cc-cd09-0410-ab3c-d52691b4dbfc