WebKit-https.git
11 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 17:27:28 +0000 (17:27 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25275
        This patch snuck in a re-definition of a local.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 17:16:17 +0000 (17:16 +0000)]
2009-04-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix a leak introduced yesterday.  Don't allocate a ScheduledAction
        if the toString()ing throws an exception.

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 30 Apr 2009 16:55:02 +0000 (16:55 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25379
        <rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails

        Test: fast/forms/multiple-selected-options-innerHTML.html

        This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
        For normal HTML parsing, it is called immediately after an element is inserted, but for
        innerHTML, it is only called after the whole subtree is inserted into a document.

        It may make sense to harmonize these cases one day, but for now, I only made the minimal
        changes necessary to fix the bug.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
        * html/HTMLSelectElement.h:
        Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide
        which one to keep selected themselves, because their logic assumes normal parsing, with
        insertedIntoTree() called after each element is inserted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Thu, 30 Apr 2009 16:41:14 +0000 (16:41 +0000)]
WebCore:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        Chromium async/out-of-process version of WebInspector is currently not based on
        InspectorController. The reason was that we did not want to interfere with
        the unforking effort, yet wanted to experiment. So we came up with these
        agents concept that basically mimic InspectorController, but separating 'agent'
        nature from the 'transport'. Now that InspectorController is unforked, I am
        planning to bring these concepts into the WebKit land and use what we have in
        Chromium as a proof of concept / experimental playground.

        * loader/EmptyClients.h: added MessageSource and MessageLevel parameters.
        (WebCore::EmptyChromeClient::addMessageToConsole): ditto
        * page/ChromeClient.h: ditto
        * page/Console.cpp: Used new method signature.
        (WebCore::Console::addMessage): ditto

WebKit/gtk:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::addMessageToConsole):
        * WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::addMessageToConsole):

WebKit/win:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::addMessageToConsole):
        * WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebKitSupport/ChromeClientWx.cpp:
        (WebCore::ChromeClientWx::addMessageToConsole):
        * WebKitSupport/ChromeClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 30 Apr 2009 16:36:04 +0000 (16:36 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - fix https://bugs.webkit.org/show_bug.cgi?id=25476
          <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
          animation is jittery

        Reverted r42987.

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

LayoutTests:

        Reviewed by Simon Fraser.

        - updated results for https://bugs.webkit.org/show_bug.cgi?id=25476
          <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
          animation is jittery

        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        * platform/mac/svg/custom/focus-ring-expected.checksum:
        * platform/mac/svg/custom/focus-ring-expected.png:
        * platform/mac/svg/custom/image-small-width-height-expected.checksum:
        * platform/mac/svg/custom/image-small-width-height-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Thu, 30 Apr 2009 16:20:49 +0000 (16:20 +0000)]
WebCore:

2009-04-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
        https://bugs.webkit.org/show_bug.cgi?id=21193

        Some websites use for attributes in script elements to specify events that the script
        should be run for.  One example is greekembassy.org which has the following in their <head>:

        <script for=window event=onresize>
            location.reload(false);
        </script>

        Since we don't support the full for attribute syntax, we would just blissfully ignore the
        condition and execute the code unconditionally.  This caused breakage on multiple real-world
        sites besides greekembassy.org.

        https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
        support for the for attribute in scripts.  In the meantime it's best to not execute them
        unconditionally.

        Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have
          passed, only return true if there is no for attribute in the script element.
        * dom/ScriptElement.h:

        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
        * html/HTMLScriptElement.h:

        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other
          attribute getters do for SVGScriptElement)
        * svg/SVGScriptElement.h:

LayoutTests:

2009-04-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        Test for <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
        https://bugs.webkit.org/show_bug.cgi?id=21193

        * fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt: Added.
        * fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 15:56:17 +0000 (15:56 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skip one more video test that sometimes fails.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add a sometimes-timing-out test to the Windows skipped file
aroben@apple.com [Thu, 30 Apr 2009 15:43:12 +0000 (15:43 +0000)]
    Add a sometimes-timing-out test to the Windows skipped file

        See Bug 25483: http/tests/navigation/redirect-cycle.html sometimes
        times out on Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25483>

        * platform/win/Skipped: Added
        http/tests/navigation/redirect-cycle.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
hausmann@webkit.org [Thu, 30 Apr 2009 15:01:22 +0000 (15:01 +0000)]
2009-04-30  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Implement encloseContentsWith and rename wrap to encloseWith.

Also in encloseWith, make sure that you cannot enclose with
non-enclosable elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 14:56:27 +0000 (14:56 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skip two more tests that I had accidentaly generated results for,
        locally.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 14:06:10 +0000 (14:06 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Also disable new tests, and tests that are using stderr.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 13:12:58 +0000 (13:12 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disabling more video tests that seem to come and go.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 12:06:34 +0000 (12:06 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Hopefully last try making the bot green.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 11:09:38 +0000 (11:09 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Exclude canvas-putImageData.html from the skipped list since
        Canvas's putImageData is implemented in r41355 already.

        * platform/qt/Skipped: Removed canvas-putImageData.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 30 Apr 2009 10:26:51 +0000 (10:26 +0000)]
2009-04-30  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again

        https://bugs.webkit.org/show_bug.cgi?id=20952

        The QtWebKit port made the mistake of exposing a global history. This broke
        with the addition of PageGroup and LinkHash. This needs to be repaired
        for Qt4.5.

        Add a function to LinkHash.cpp that is resolving a URL. Use this
        function from within CSSStyleSelector to forward the url to the
        QWebHistoryInterface API.

        It is sad that there is a path within visitedLinkHash which is now
        doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
        and using QtWebKit types within WebCore is a layering violation as well.

        PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
        Qt4.6 a second version of the QWebHistoryInterface is going to be
        added which will fix things up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Qt build.
hausmann@webkit.org [Thu, 30 Apr 2009 10:08:08 +0000 (10:08 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 10:04:53 +0000 (10:04 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed build fix, after r43035.

        Temporarily use Position::deprecatedEditingOffset().

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 10:00:23 +0000 (10:00 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreview build fix after r43037.

        Use MarkedArgumentBuffer instead of ArgList.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 30 Apr 2009 09:15:36 +0000 (09:15 +0000)]
2009-04-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey Proskuryakov.

        - speed up string concatenation by reorganizing some simple cases

        0.7% SunSpider speedup

        * runtime/UString.cpp:
        (JSC::concatenate): Put fast case for appending a single character
        before the empty string special cases; streamline code a bit to
        delay computing values that are not needed in the fast path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-30 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 30 Apr 2009 07:52:27 +0000 (07:52 +0000)]
2009-04-30  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Maciej Stachowiak.

        Add SamplingFlags mechanism.

        This mechanism allows fine-grained JSC and JavaScript program aware
        performance measurement.  The mechanism provides a set of 32 flags,
        numbered #1..#32.  Flag #16 is initially set, and all other flags
        are cleared.  Flags may be set and cleared from within

        Enable by setting ENABLE_SAMPLING_FLAGS to 1 in wtf/Platform.h.
        Disabled by default, no performance impact.  Flags may be modified
        by calling SamplingFlags::setFlag() and SamplingFlags::clearFlag()
        from within JSC implementation, or by calling setSamplingFlag() and
        clearSamplingFlag() from JavaScript.

        The flags are sampled with a frequency of 10000Hz, and the highest
        set flag in recorded, allowing multiple events to be measured (with
        the highest flag number representing the highest priority).

        Disabled by default; no performance impact.

        * JavaScriptCore.exp:
        * bytecode/SamplingTool.cpp:
        (JSC::SamplingFlags::sample):
        (JSC::SamplingFlags::start):
        (JSC::SamplingFlags::stop):
        (JSC::SamplingThread::threadStartFunc):
        (JSC::SamplingThread::start):
        (JSC::SamplingThread::stop):
        (JSC::ScopeSampleRecord::sample):
        (JSC::SamplingTool::doRun):
        (JSC::SamplingTool::sample):
        (JSC::SamplingTool::start):
        (JSC::SamplingTool::stop):
        * bytecode/SamplingTool.h:
        (JSC::SamplingFlags::setFlag):
        (JSC::SamplingFlags::clearFlag):
        (JSC::SamplingTool::SamplingTool):
        * jsc.cpp:
        (GlobalObject::GlobalObject):
        (functionSetSamplingFlag):
        (functionClearSamplingFlag):
        (runWithScripts):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Thu, 30 Apr 2009 06:47:58 +0000 (06:47 +0000)]
WebCore:

2009-04-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
        setTimeout should stringify non-string/non-function first arguments

        Test: fast/dom/Window/setTimeout-string-argument.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::setTimeout):
        (WebCore::JSWorkerContext::setInterval):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):
        * bindings/js/ScheduledAction.h:

LayoutTests:

2009-04-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=25440
        setTimeout should stringify non-string/non-function first arguments

        * fast/dom/Window/setTimeout-string-argument-expected.txt: Added.
        * fast/dom/Window/setTimeout-string-argument.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore build fixing after r43037.
mrowe@apple.com [Thu, 30 Apr 2009 03:38:57 +0000 (03:38 +0000)]
More build fixing after r43037.

* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 30 Apr 2009 03:03:29 +0000 (03:03 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - WebCore part of <rdar://problem/6609509> Select All and then Delete
          should put Mail editing back into the same state as a new message

        Test: editing/deleting/in-visibly-empty-root.html

        * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
        * editing/SelectionController.h:
        (WebCore::SelectionController::isAll): Added. Calls through to
        VisibleSelection.
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
        of the root editable element the selection is in, other than a
        placeholder. Returns true iff it did anything.
        (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
        visible position in the root editable element, but it has children other
        than a placeholder, remove those children.
        * editing/TypingCommand.h:
        * editing/VisiblePosition.h:
        Added a StayInEditableContent enum and a FIXME.
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::isAll): Added. Returns whether the
        selection encompasses all visible positions, either in the document or
        in the editable root.
        * editing/VisibleSelection.h:

WebKit/mac:

        Reviewed by Simon Fraser.

        - WebKit part of <rdar://problem/6609509> Select All and then Delete
          should put Mail editing back into the same state as a new message

        * WebView/WebView.mm:
        (-[WebView _selectionIsCaret]): Added.
        (-[WebView _selectionIsAll]): Added. Returns whether the selection
        encompasses the entire document.
        * WebView/WebViewPrivate.h:

LayoutTests:

        Reviewed by Simon Fraser.

        - test and updated results for <rdar://problem/6609509> Select All and
          then Delete should put Mail editing back into the same state as a new
          message

        * editing/deleting/in-visibly-empty-root-expected.txt: Added.
        * editing/deleting/in-visibly-empty-root.html: Added.
        * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 02:19:20 +0000 (02:19 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Another attempt to fix the windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 02:12:32 +0000 (02:12 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Fix style nit.

        * editing/visible_units.cpp:
        (WebCore::getLeafBoxesInLogicalOrder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 02:10:07 +0000 (02:10 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Try and fix the windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 30 Apr 2009 02:02:23 +0000 (02:02 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        For now just drop the deferred layout on the floor, since it causes an infinite hang in mail.  Even
        trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
        assertions.

        Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
        and not do it (which is basically what was happening before).

        * page/FrameView.cpp:
        (WebCore::FrameView::setContentsSize):
        (WebCore::FrameView::needsLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Thu, 30 Apr 2009 01:35:07 +0000 (01:35 +0000)]
WebCore:

2009-04-29  Douglas Davidson  <ddavidso@apple.com>

        Reviewed by Justin Garcia.

        <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly

        Updates to the text checking code to enable text checking even if spellchecking is turned off
        and fix an off-by-one error in selection handling.

        * editing/Editor.cpp:
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        * editing/Editor.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::markMisspellingsAfterTyping):

WebKit/mac:

2009-04-29  Douglas Davidson  <ddavidso@apple.com>

        Reviewed by Justin Garcia.

        <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView orderFrontSubstitutionsPanel:]):
        * WebView/WebView.mm:
        (-[WebView validateUserInterfaceItemWithoutDelegate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 30 Apr 2009 01:34:08 +0000 (01:34 +0000)]
2009-04-29  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver "Peg-Leg" Hunt.

        Coallesce input checking and reduce futzing with the index position
        between alternatives and iterations of the main loop of a regex,
        when run in YARR.

        Consider the following regex:  /foo|bar/

        Prior to this patch, this will be implemented something like this pseudo-code description:

        loop:
            check_for_available_input(3) // this increments the index by 3, for the first alterantive.
                if (available) { test "foo" }
            decrement_index(3)
            check_for_available_input(3) // this increments the index by 3, for the second alterantive.
                if (available) { test "bar" }
            decrement_index(3)
            check_for_available_input(1) // can we loop again?
                if (available) { goto loop }

        With these changes it will look more like this:

            check_for_available_input(3) // this increments the index by 3, for the first alterantive.
            if (!available) { goto fail }
        loop:
            test "foo"
            test "bar"
            check_for_available_input(1) // can we loop again?
                if (available) { goto loop }
        fail:

        This gives about a 5% gain on v8-regex, no change on Sunspider.

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo):
        (JSC::Yarr::RegexGenerator::generateDisjunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up ArgList to be a trivial type
oliver@apple.com [Thu, 30 Apr 2009 01:21:52 +0000 (01:21 +0000)]
Clean up ArgList to be a trivial type

Reviewed by Gavin Barraclough

Separate out old ArgList logic to handle buffering and marking arguments
into a distinct MarkedArgumentBuffer type.  ArgList becomes a trivial
struct of a pointer and length.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No review, build fix only.
eric@webkit.org [Thu, 30 Apr 2009 01:16:24 +0000 (01:16 +0000)]
    No review, build fix only.

        Fix m_offset uses added while I wasn't looking.

        * editing/visible_units.cpp:
        (WebCore::logicalStartPositionForLine):
        (WebCore::logicalEndPositionForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
eric@webkit.org [Thu, 30 Apr 2009 01:09:57 +0000 (01:09 +0000)]
    Reviewed by Darin Adler.

        Make m_offset private and change all callers to use deprecatedEditingOffset().
        https://bugs.webkit.org/show_bug.cgi?id=25472

        Per Darin's suggestion, this was just a simple search replace
        of .m_offset with .deprecatedEditingOffset().

        There was one change in InsertParagraphSeparatorCommand::doApply to use
        Position::moveToOffset(0) instead of .m_offset = 0;

        * dom/Position.cpp:
        (WebCore::Position::rendersInDifferentPosition):
        (WebCore::Position::leadingWhitespacePosition):
        * dom/Position.h:
        (WebCore::Position::deprecatedEditingOffset):
        (WebCore::Position::moveToOffset):
        (WebCore::operator==):
        * dom/PositionIterator.h:
        (WebCore::PositionIterator::PositionIterator):
        * dom/Range.cpp:
        (WebCore::Range::create):
        (WebCore::Range::compareBoundaryPoints):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::nodeFullySelected):
        (WebCore::ApplyStyleCommand::nodeFullyUnselected):
        (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
        (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
        (WebCore::ApplyStyleCommand::joinChildTextNodes):
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        (WebCore::CompositeEditCommand::positionOutsideTabSpan):
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
        (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
        (WebCore::CompositeEditCommand::deleteInsignificantText):
        (WebCore::CompositeEditCommand::moveParagraphs):
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForNodeRemoval):
        (WebCore::updatePositionForTextRemoval):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::fixupWhitespace):
        * editing/Editor.cpp:
        (WebCore::Editor::setComposition):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::getCompositionSelection):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::performTrivialReplace):
        (WebCore::InsertTextCommand::input):
        (WebCore::InsertTextCommand::insertTab):
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::debugRenderer):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter):
        (WebCore::VisiblePosition::debugPosition):
        (WebCore::makeRange):
        (WebCore::setStart):
        (WebCore::setEnd):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::toNormalizedRange):
        (WebCore::makeSearchRange):
        (WebCore::VisibleSelection::debugPosition):
        (WebCore::VisibleSelection::showTreeForThis):
        * editing/htmlediting.cpp:
        (WebCore::comparePositions):
        (WebCore::rangeCompliantEquivalent):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):
        (WebCore::startPositionForLine):
        (WebCore::startOfLine):
        (WebCore::endPositionForLine):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        (WebCore::logicalStartPositionForLine):
        (WebCore::logicalEndPositionForLine):
        * page/AccessibilityObject.cpp:
        (WebCore::updateAXLineStartForVisiblePosition):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::anchorOffset):
        (WebCore::DOMSelection::focusOffset):
        (WebCore::DOMSelection::baseOffset):
        (WebCore::DOMSelection::extentOffset):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        * page/Frame.cpp:
        (WebCore::Frame::selectionLayoutChanged):
        * page/mac/AccessibilityObjectWrapper.mm:
        (textMarkerForVisiblePosition):
        (visiblePositionForTextMarker):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::indexForVisiblePosition):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
eric@webkit.org [Thu, 30 Apr 2009 01:07:41 +0000 (01:07 +0000)]
    Reviewed by Oliver Hunt.

        Re-write image-clipped-hit.svg to be dumpAsText() (and clean up the code to be less insane)

        * platform/mac/svg/custom/image-clipped-hit-expected.checksum: Removed.
        * platform/mac/svg/custom/image-clipped-hit-expected.png: Removed.
        * platform/mac/svg/custom/image-clipped-hit-expected.txt: Removed.
        * platform/qt/svg/custom/image-clipped-hit-expected.txt: Removed.
        * svg/custom/image-clipped-hit.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 00:51:15 +0000 (00:51 +0000)]
2009-04-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Second try at making the bot green.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 30 Apr 2009 00:48:43 +0000 (00:48 +0000)]
WebCore:

2009-04-29  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24168
        RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

        Test: editing/selection/home-end.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary
        (WebCore::SelectionController::modifyExtendingBackward): Change calling
        startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
        to logicalStartOfLine() when granularity is LineBoundary.
        * editing/visible_units.cpp:
        (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
        (WebCore::getLogicalStartBoxAndNode): Added.
        (WebCore::getLogicalEndBoxAndNode): Added.
        (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
        (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
        (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
        (WebCore::inSameLogicalLine): Added.
        (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
        * editing/visible_units.h:

LayoutTests:

2009-04-29  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24168
        RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

        * editing/selection/extend-selection-expected.txt: Added result for extend in
        lineBoundary.
        * editing/selection/extend-selection.html: Added test cases and script for extend
        in lineBoundary.
        * editing/selection/home-end-expected.txt: Added.
        * editing/selection/home-end.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 30 Apr 2009 00:24:57 +0000 (00:24 +0000)]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Fix this test to only use a setTimeout in IE.
        It doesn't need a timeout in WebKit and the
        timeout requires using waitUntilDone/notifyDone,
        which doesn't play nicely with JS tests.

        See https://bugs.webkit.org/show_bug.cgi?id=25471

        * fast/forms/resources/textarea-metrics.js:
        (assertTextareaMetrics):
        * fast/forms/textarea-metrics-expected.txt:
        * platform/win/fast/forms/textarea-metrics-expected.txt:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOjan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 29 Apr 2009 23:52:40 +0000 (23:52 +0000)]
Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Put this file in the right place to fix the bot failure.

        * platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/platform/mac-tiger/text-control-intrinsic-widths-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 29 Apr 2009 23:50:11 +0000 (23:50 +0000)]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Skip fast/forms/textarea-metrics.html. It's printing the TEST PASSED
        before the test is finished. There's a race with any JS tests that
        use setTimeout. Fortunately, this test doesn't need the setTimeout,
        so it's easy to fix.

        See https://bugs.webkit.org/show_bug.cgi?id=25471

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 29 Apr 2009 23:34:26 +0000 (23:34 +0000)]
2009-04-29  Eric Seidel  <eric@webkit.org>

        No review, rolling out a patch.

        Revert http://trac.webkit.org/changeset/43019

        New tests failed because I removed the tabs from them
        when landing (since we avoid tabs in WebKit files).
        I couldn't tell if the new results were correct with
        spaces or not.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingForward):
        (WebCore::SelectionController::modifyMovingForward):
        (WebCore::SelectionController::modifyExtendingBackward):
        (WebCore::SelectionController::modifyMovingBackward):
        * editing/visible_units.cpp:
        * editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 29 Apr 2009 23:27:29 +0000 (23:27 +0000)]
2009-04-29  Eric Seidel  <eric@webkit.org>

        No review, rolling out a patch.

        Revert 43020 as it caused accessibility/lists.html to fail
        and no one is around to tell me if it's a progression or not.

        * page/AccessibilityObject.h:
        (WebCore::):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::roleValue):
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
        * page/mac/AccessibilityObjectWrapper.mm:
        (RoleEntry::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 29 Apr 2009 23:21:06 +0000 (23:21 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
        when the FrameView is resized.  This bug was exposed by the elimination of the separate WebKit layout
        flag on Mac.

        FrameView now defers setNeedsLayouts during size changes.  Once all of the size changes are finished (including re-entrant ones
        from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::setContentsSize):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::needsLayout):
        (WebCore::FrameView::setNeedsLayout):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 29 Apr 2009 23:20:03 +0000 (23:20 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        Fix a bug in the bounds checking for setNeedsLayout dirtying when a WebView's size changes.  The superview
        of the WebView was being incorrectly checked instead of the WebView itself.

        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix ChangeLog description.
ojan@chromium.org [Wed, 29 Apr 2009 23:09:11 +0000 (23:09 +0000)]
Fix ChangeLog description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 29 Apr 2009 23:04:50 +0000 (23:04 +0000)]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Add expected results for failing tests.

        * platform/win/fast/forms/textarea-metrics-expected.txt:
        Issue with running JS tests that use setTimeout.
        See https://bugs.webkit.org/show_bug.cgi?id=25469

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Antony Sargent <asargent@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 22:48:44 +0000 (22:48 +0000)]
2009-04-29  Antony Sargent  <asargent@chromium.org>

        Reviewed by Dimitri Glazkov and Eric Seidel.

        Use AtomicString to speed up window and document interceptors.
        https://bugs.webkit.org/show_bug.cgi?id=25275

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER):
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::NAMED_PROPERTY_DELETER):
        (WebCore::NAMED_PROPERTY_GETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate build.webkit.org configuration for the addition of the new GTK buildbot.
mrowe@apple.com [Wed, 29 Apr 2009 22:28:21 +0000 (22:28 +0000)]
Update build.webkit.org configuration for the addition of the new GTK buildbot.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
eric@webkit.org [Wed, 29 Apr 2009 22:22:45 +0000 (22:22 +0000)]
2009-04-29  Sankar Aditya Tanguturi  <sankaraditya@gmail.com>

        Reviewed by Jon Honeycutt.

        Add a new accessibility role for list items. Part of
        http://bugs.webkit.org/show_id.cgi?id=20013

        * win/AccessibleBase.cpp:
        (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Xiaomei Ji <xji@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 22:16:38 +0000 (22:16 +0000)]
2009-04-29  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24168
        RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

        Test: editing/selection/home-end.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary
        (WebCore::SelectionController::modifyExtendingBackward): Change calling
        startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
        to logicalStartOfLine() when granularity is LineBoundary.
        * editing/visible_units.cpp:
        (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
        (WebCore::getLogicalStartBoxAndNode): Added.
        (WebCore::getLogicalEndBoxAndNode): Added.
        (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
        (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
        (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
        (WebCore::inSameLogicalLine): Added.
        (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
        * editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
eric@webkit.org [Wed, 29 Apr 2009 22:14:52 +0000 (22:14 +0000)]
2009-04-29  Sankar Aditya Tanguturi  <sankaraditya@gmail.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=23583
        Populate role attribute for document objects correctly
        on Windows platform.

        * AccessibleDocument.cpp:
        (AccessibleDocument::role): Return ROLE_SYSTEM_DOCUMENT for
        document objects on windows. (Matching Firefox).
        * AccessibleDocument.h: Add the role function prototype in
        header file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoIgnore the --use-remote-links-to-tests option for GTK as it leads to
mrowe@apple.com [Wed, 29 Apr 2009 22:11:22 +0000 (22:11 +0000)]
Ignore the --use-remote-links-to-tests option for GTK as it leads to
perl errors being spewed at the end of run-webkit-tests.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement test-result-archive for GTK.
mrowe@apple.com [Wed, 29 Apr 2009 21:54:57 +0000 (21:54 +0000)]
Implement test-result-archive for GTK.

* BuildSlaveSupport/test-result-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-03-27 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
eric@webkit.org [Wed, 29 Apr 2009 21:38:14 +0000 (21:38 +0000)]
2009-03-27  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Simon Hausmann.

        Update the page actions when a finishing loading even if the frame is
        not the top frame such as when browsing inside of a website with frames.
        https://bugs.webkit.org/show_bug.cgi?id=24890

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
        * tests/qwebpage/frametest/frame_a.html: Added.
        * tests/qwebpage/frametest/index.html: Added.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::backActionUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Mike Belshe <mike@belshe.com>
eric@webkit.org [Wed, 29 Apr 2009 21:31:41 +0000 (21:31 +0000)]
2009-04-29  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Update location while page is loading.
        https://bugs.webkit.org/show_bug.cgi?id=21597

        Tested by:
        - fast/dom/location-new-window-no-crash
        - fast/dom/Window/window-open-pending-url

        * page/Location.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 29 Apr 2009 21:28:25 +0000 (21:28 +0000)]
2009-04-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Mark Rowe.

        Disable failing tests to make the bot green for its new debut, so
        that we can more easily track regressions.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Feng Qian <feng@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:25:45 +0000 (21:25 +0000)]
2009-04-29  Feng Qian  <feng@chromium.org>

        Reviewed by Darin Adler.

        Add Android port files to WebCore/platform.
        https://bugs.webkit.org/show_bug.cgi?id=23296

        * platform/android: Added.
        * platform/android/ClipboardAndroid.cpp: Added.
        * platform/android/ClipboardAndroid.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Feng Qian <feng@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:23:31 +0000 (21:23 +0000)]
2009-04-29  Feng Qian  <feng@chromium.org>

        Reviewed by Darin Adler.

        Add Android-specific files to the WebCore/page directory.
        https://bugs.webkit.org/show_bug.cgi?id=23295

        * page/android: Added.
        * page/android/DragControllerAndroid.cpp: Added.
        * page/android/EventHandlerAndroid.cpp: Added.
        * page/android/InspectorControllerAndroid.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:00:42 +0000 (21:00 +0000)]
2009-04-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Extract PageGroupLoadDeferrer from Chrome.cpp

        * GNUmakefile.am: added PageGroupLoadDeferrer
        * WebCore.pro: ditto
        * WebCore.scons: ditto
        * WebCore.vcproj/WebCore.vcproj: ditto
        * WebCore.xcodeproj/project.pbxproj: ditto
        * WebCoreSources.bkl: ditto
        * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
        * page/PageGroupLoadDeferrer.cpp: Added.
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        * page/PageGroupLoadDeferrer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlson.
kdecker@apple.com [Wed, 29 Apr 2009 20:55:39 +0000 (20:55 +0000)]
    Reviewed by Anders Carlson.

        Allow WKN_CheckIfAllowedToLoadURL() to take an optional void* context parameter.

        * Plugins/WebNetscapeContainerCheckContextInfo.h:
        * Plugins/WebNetscapeContainerCheckContextInfo.mm:
        (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
        (-[WebNetscapeContainerCheckContextInfo callback]):
        (-[WebNetscapeContainerCheckContextInfo context]):
        * Plugins/WebNetscapeContainerCheckPrivate.h:
        * Plugins/WebNetscapeContainerCheckPrivate.mm:
        (browserContainerCheckFuncs):
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
        (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
        * Plugins/npapi.mm:
        (WKN_CheckIfAllowedToLoadURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 29 Apr 2009 20:43:34 +0000 (20:43 +0000)]
2009-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25334

        Fix Qt build when ENABLE_JIT is explicitly set to 1
        to overrule defaults.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ojan@chromium.org [Wed, 29 Apr 2009 20:31:53 +0000 (20:31 +0000)]
    Reviewed by Dan Bernstein.

        Make textarea and text input metrics more closely match IEs.

        This involves:
        -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
        -set textarea width to cols*avgCharWidth
        -Make default CSS match IEs
        -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.

        Those values for textarea and inputs were derived by doing a ton of manual
        testing of IE's width values for various textareas and fonts. On Windows we match
        IE exactly except for a couple fonts of the ~12 tested.

        To get the average and max character width of a font, we do the following
        for each platform:
        -Win: TextMetrics expose avgCharWidth and maxCharWidth
        -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
            maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
        -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
            maxCharWidth = max of avgCharWidth and m_ascent
        -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
            If either one is non-positive, then calculate the value using the Linux approach.

        Tests: fast/forms/text-control-intrinsic-widths.html
               fast/forms/textarea-metrics.html
               svg/custom/svg-fonts-in-text-controls.html

        * css/html4.css:
        * css/themeWin.css:
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData):
        (WebCore::SimpleFontData::initCharWidths):
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::maxCharWidth):
        (WebCore::SimpleFontData::avgCharWidth):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::initGDIFont):
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::preferredContentWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash in profiler due to incorrect assuming displayName would be a string.
oliver@apple.com [Wed, 29 Apr 2009 20:25:09 +0000 (20:25 +0000)]
Crash in profiler due to incorrect assuming displayName would be a string.

Reviewed by Steve Falkenburg

Fixed by adding a type guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Apr 2009 20:23:22 +0000 (20:23 +0000)]
2009-04-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        * bindings/objc/DOMCSS.mm:
        (kitClass):  Added CSS_INITIAL to the switch statement, and changed to use the WebCore
          type and not the binding type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 John Abd-El-Malek <jam@google.com>
eric@webkit.org [Wed, 29 Apr 2009 20:21:48 +0000 (20:21 +0000)]
2009-04-29  John Abd-El-Malek  <jam@google.com>

        Reviewed by Dimitri Glazkov.

        Reverted my previous change to add resetChromiumPluginCache().
        https://bugs.webkit.org/show_bug.cgi?id=25318

        * plugins/chromium/PluginDataChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Apr 2009 20:21:03 +0000 (20:21 +0000)]
2009-04-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail

        Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>

        Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Remove the preload referenced check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 20:14:25 +0000 (20:14 +0000)]
2009-04-29  Alpha Lam  <hclam@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25430

        Provide style sheet for UI controls of media elements for Chromium port.

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 John Abd-El-Malek <jam@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 20:12:54 +0000 (20:12 +0000)]
2009-04-29  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Adler.

        Expose sudden termination to Chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=25457

        * platform/SuddenTermination.h:
        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/SuddenTerminationChromium.cpp: Added.
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 29 Apr 2009 20:00:08 +0000 (20:00 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Dimitri Glazkov.

        Remove unused EventListeners.

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 29 Apr 2009 18:38:35 +0000 (18:38 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by John Sullivan.

        Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized.  Make sure
        not to resize the interior views of a WebView in response to its bounds changing when not using
        viewless WebKit.  Auto-resizing rules were already in place to handle size adjustments for us.
        Just mark as needing layout and do nothing else.

        This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
        Safari change (using a new API that will enable clients to define the edges of the content area as offsets
        from the sides of the WebView).

        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 29 Apr 2009 17:41:11 +0000 (17:41 +0000)]
2009-04-29  Eric Carlson  <eric.carlson@apple.com>

        Disable media/video-zoom-controls.html on Windows for now.

        * platform/win/Skipped: add media/video-zoom-controls.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reveal current execution line once SourceFrame content is loaded.
timothy@apple.com [Wed, 29 Apr 2009 17:38:15 +0000 (17:38 +0000)]
    Reveal current execution line once SourceFrame content is loaded.

        https://bugs.webkit.org/show_bug.cgi?id=25448

        Reviewed by Timothy Hatcher.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
ariya@webkit.org [Wed, 29 Apr 2009 17:27:14 +0000 (17:27 +0000)]
WebCore:

2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Fraser.

        [Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
        the default values of canvas attributes.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBufferData::ImageBufferData):

LayoutTests:

2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Fraser.

        Updated expected results after Qt's GraphicsContext fixes.

        * platform/qt/fast/canvas/set-colors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Wed, 29 Apr 2009 13:55:38 +0000 (13:55 +0000)]
2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        Implement QWebElement::evaluateScript.

        * Api/qwebelement.cpp:
        (setupScriptContext):
        (QWebElement::evaluateScript):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::evaluateScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-29 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 29 Apr 2009 13:46:46 +0000 (13:46 +0000)]
2009-04-29  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Replaced QWebElementCollection with QList<QWebElement>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Qt build
hausmann@webkit.org [Wed, 29 Apr 2009 06:38:48 +0000 (06:38 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix the test for <https://bugs.webkit.org/show_bug.cgi?id=25420> - I broke...
ap@webkit.org [Wed, 29 Apr 2009 06:31:38 +0000 (06:31 +0000)]
    Fix the test for <https://bugs.webkit.org/show_bug.cgi?id=25420> - I broke it when
        experimenting with other aspects of the issue, so it didn't check what it should have checked.

        * http/tests/xmlhttprequest/detaching-frame-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 29 Apr 2009 06:19:46 +0000 (06:19 +0000)]
2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Missed one.

        * UserObjectImp.cpp:
        (UserObjectImp::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 29 Apr 2009 06:08:37 +0000 (06:08 +0000)]
2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Missed one.

        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Wed, 29 Apr 2009 06:07:26 +0000 (06:07 +0000)]
JavaScriptCore:

2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Removed scaffolding supporting dynamically converting between 32bit and
        64bit value representations.

        * API/JSCallbackConstructor.cpp:
        (JSC::constructJSCallback):
        * API/JSCallbackFunction.cpp:
        (JSC::JSCallbackFunction::call):
        * API/JSCallbackObjectFunctions.h:
        (JSC::::construct):
        (JSC::::call):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::getConstant):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitEqualityOp):
        * interpreter/CallFrame.cpp:
        (JSC::CallFrame::thisValue):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::callEval):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::createExceptionScope):
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::retrieveArguments):
        * interpreter/Register.h:
        (JSC::Register::):
        (JSC::Register::Register):
        (JSC::Register::jsValue):
        (JSC::Register::marked):
        (JSC::Register::mark):
        (JSC::Register::i):
        (JSC::Register::activation):
        (JSC::Register::arguments):
        (JSC::Register::callFrame):
        (JSC::Register::codeBlock):
        (JSC::Register::function):
        (JSC::Register::propertyNameIterator):
        (JSC::Register::scopeChain):
        (JSC::Register::vPC):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_op_call_NotJSFunction):
        (JSC::JITStubs::cti_op_load_varargs):
        (JSC::JITStubs::cti_op_call_eval):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (functionRun):
        (functionLoad):
        * runtime/ArgList.h:
        (JSC::ArgList::at):
        * runtime/Arguments.cpp:
        (JSC::Arguments::copyToRegisters):
        (JSC::Arguments::fillArgList):
        (JSC::Arguments::getOwnPropertySlot):
        * runtime/ArrayConstructor.cpp:
        (JSC::constructArrayWithSizeQuirk):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncJoin):
        (JSC::arrayProtoFuncConcat):
        (JSC::arrayProtoFuncPush):
        (JSC::arrayProtoFuncSlice):
        (JSC::arrayProtoFuncSort):
        (JSC::arrayProtoFuncSplice):
        (JSC::arrayProtoFuncUnShift):
        (JSC::arrayProtoFuncFilter):
        (JSC::arrayProtoFuncMap):
        (JSC::arrayProtoFuncEvery):
        (JSC::arrayProtoFuncForEach):
        (JSC::arrayProtoFuncSome):
        (JSC::arrayProtoFuncReduce):
        (JSC::arrayProtoFuncReduceRight):
        (JSC::arrayProtoFuncIndexOf):
        (JSC::arrayProtoFuncLastIndexOf):
        * runtime/BooleanConstructor.cpp:
        (JSC::constructBoolean):
        (JSC::callBooleanConstructor):
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        (JSC::dateParse):
        (JSC::dateUTC):
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):
        (JSC::fillStructuresUsingTimeArgs):
        (JSC::fillStructuresUsingDateArgs):
        (JSC::dateProtoFuncSetTime):
        (JSC::dateProtoFuncSetYear):
        * runtime/ErrorConstructor.cpp:
        (JSC::constructError):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/FunctionPrototype.cpp:
        (JSC::functionProtoFuncApply):
        (JSC::functionProtoFuncCall):
        * runtime/JSArray.cpp:
        (JSC::JSArray::JSArray):
        (JSC::constructArray):
        * runtime/JSArray.h:
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::decode):
        (JSC::globalFuncEval):
        (JSC::globalFuncParseInt):
        (JSC::globalFuncParseFloat):
        (JSC::globalFuncIsNaN):
        (JSC::globalFuncIsFinite):
        (JSC::globalFuncEscape):
        (JSC::globalFuncUnescape):
        (JSC::globalFuncJSCPrint):
        * runtime/MathObject.cpp:
        (JSC::mathProtoFuncAbs):
        (JSC::mathProtoFuncACos):
        (JSC::mathProtoFuncASin):
        (JSC::mathProtoFuncATan):
        (JSC::mathProtoFuncATan2):
        (JSC::mathProtoFuncCeil):
        (JSC::mathProtoFuncCos):
        (JSC::mathProtoFuncExp):
        (JSC::mathProtoFuncFloor):
        (JSC::mathProtoFuncLog):
        (JSC::mathProtoFuncMax):
        (JSC::mathProtoFuncMin):
        (JSC::mathProtoFuncPow):
        (JSC::mathProtoFuncRound):
        (JSC::mathProtoFuncSin):
        (JSC::mathProtoFuncSqrt):
        (JSC::mathProtoFuncTan):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::construct):
        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor):
        (JSC::callNumberConstructor):
        * runtime/NumberPrototype.cpp:
        (JSC::numberProtoFuncToString):
        (JSC::numberProtoFuncToFixed):
        (JSC::numberProtoFuncToExponential):
        (JSC::numberProtoFuncToPrecision):
        * runtime/ObjectConstructor.cpp:
        (JSC::constructObject):
        * runtime/ObjectPrototype.cpp:
        (JSC::objectProtoFuncHasOwnProperty):
        (JSC::objectProtoFuncIsPrototypeOf):
        (JSC::objectProtoFuncDefineGetter):
        (JSC::objectProtoFuncDefineSetter):
        (JSC::objectProtoFuncLookupGetter):
        (JSC::objectProtoFuncLookupSetter):
        (JSC::objectProtoFuncPropertyIsEnumerable):
        * runtime/PropertySlot.h:
        (JSC::PropertySlot::getValue):
        * runtime/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::match):
        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncCompile):
        * runtime/StringConstructor.cpp:
        (JSC::stringFromCharCodeSlowCase):
        (JSC::stringFromCharCode):
        (JSC::constructWithStringConstructor):
        (JSC::callStringConstructor):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncCharAt):
        (JSC::stringProtoFuncCharCodeAt):
        (JSC::stringProtoFuncConcat):
        (JSC::stringProtoFuncIndexOf):
        (JSC::stringProtoFuncLastIndexOf):
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        (JSC::stringProtoFuncSlice):
        (JSC::stringProtoFuncSplit):
        (JSC::stringProtoFuncSubstr):
        (JSC::stringProtoFuncSubstring):
        (JSC::stringProtoFuncLocaleCompare):
        (JSC::stringProtoFuncFontcolor):
        (JSC::stringProtoFuncFontsize):
        (JSC::stringProtoFuncAnchor):
        (JSC::stringProtoFuncLink):

WebCore:

2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Removed scaffolding supporting dynamically converting between 32bit and
        64bit value representations.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::setFillColor):
        (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
        (WebCore::JSCanvasRenderingContext2D::strokeRect):
        (WebCore::JSCanvasRenderingContext2D::drawImage):
        (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
        (WebCore::JSCanvasRenderingContext2D::setShadow):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        (WebCore::JSCanvasRenderingContext2D::putImageData):
        (WebCore::JSCanvasRenderingContext2D::fillText):
        (WebCore::JSCanvasRenderingContext2D::strokeText):
        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::clearData):
        (WebCore::JSClipboard::getData):
        (WebCore::JSClipboard::setData):
        (WebCore::JSClipboard::setDragImage):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::hasItem):
        (WebCore::JSDOMApplicationCache::add):
        (WebCore::JSDOMApplicationCache::remove):
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMStringListCustom.cpp:
        (WebCore::JSDOMStringList::item):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::open):
        (WebCore::JSDOMWindow::showModalDialog):
        (WebCore::JSDOMWindow::postMessage):
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        (WebCore::JSDOMWindow::atob):
        (WebCore::JSDOMWindow::btoa):
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener):
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::setAttribute):
        (WebCore::JSElement::setAttributeNode):
        (WebCore::JSElement::setAttributeNS):
        (WebCore::JSElement::setAttributeNodeNS):
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::callHTMLCollection):
        (WebCore::JSHTMLCollection::item):
        (WebCore::JSHTMLCollection::namedItem):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::documentWrite):
        * bindings/js/JSHTMLInputElementCustom.cpp:
        (WebCore::JSHTMLInputElement::setSelectionRange):
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        (WebCore::JSHTMLOptionsCollection::add):
        * bindings/js/JSHTMLSelectElementCustom.cpp:
        (WebCore::JSHTMLSelectElement::remove):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::constructImage):
        * bindings/js/JSInspectorControllerCustom.cpp:
        (WebCore::JSInspectorController::highlightDOMNode):
        (WebCore::JSInspectorController::addResourceSourceToFrame):
        (WebCore::JSInspectorController::addSourceToFrame):
        (WebCore::JSInspectorController::getResourceDocumentNode):
        (WebCore::JSInspectorController::search):
        (WebCore::JSInspectorController::databaseTableNames):
        (WebCore::JSInspectorController::setting):
        (WebCore::JSInspectorController::setSetting):
        (WebCore::JSInspectorController::wrapCallback):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::evaluate):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::replace):
        (WebCore::JSLocation::assign):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::startConversation):
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::insertBefore):
        (WebCore::JSNode::replaceChild):
        (WebCore::JSNode::removeChild):
        (WebCore::JSNode::appendChild):
        (WebCore::JSNode::addEventListener):
        (WebCore::JSNode::removeEventListener):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::acceptNode):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::callNodeList):
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::constructHTMLOptionElement):
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::construct):
        (WebCore::JSQuarantinedObjectWrapper::call):
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        (WebCore::JSSQLResultSetRowList::item):
        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        (WebCore::JSSVGElementInstance::removeEventListener):
        * bindings/js/JSSVGLengthCustom.cpp:
        (WebCore::JSSVGLength::convertToSpecifiedUnits):
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::rotateFromVector):
        * bindings/js/JSSVGPathSegListCustom.cpp:
        (WebCore::JSSVGPathSegList::initialize):
        (WebCore::JSSVGPathSegList::getItem):
        (WebCore::JSSVGPathSegList::insertItemBefore):
        (WebCore::JSSVGPathSegList::replaceItem):
        (WebCore::JSSVGPathSegList::removeItem):
        (WebCore::JSSVGPathSegList::appendItem):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::JSSVGPointList::initialize):
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        (WebCore::JSSVGPointList::appendItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::initialize):
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        (WebCore::JSSVGTransformList::appendItem):
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::constructWebKitCSSMatrix):
        * bindings/js/JSWebKitPointConstructor.cpp:
        (WebCore::constructWebKitPoint):
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::constructWorker):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::importScripts):
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        (WebCore::JSWorkerContext::setTimeout):
        (WebCore::JSWorkerContext::setInterval):
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::addEventListener):
        (WebCore::JSWorker::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::open):
        (WebCore::JSXMLHttpRequest::setRequestHeader):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::getResponseHeader):
        (WebCore::JSXMLHttpRequest::overrideMimeType):
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/js/JSXSLTProcessorCustom.cpp:
        (WebCore::JSXSLTProcessor::importStylesheet):
        (WebCore::JSXSLTProcessor::transformToFragment):
        (WebCore::JSXSLTProcessor::transformToDocument):
        (WebCore::JSXSLTProcessor::setParameter):
        (WebCore::JSXSLTProcessor::getParameter):
        (WebCore::JSXSLTProcessor::removeParameter):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):
        (WebCore::ScheduledAction::ScheduledAction):
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptCallFrame.cpp:
        (WebCore::ScriptCallFrame::ScriptCallFrame):
        * bindings/js/ScriptCallFrame.h:
        * bindings/js/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::ScriptCallStack):
        (WebCore::ScriptCallStack::initialize):
        * bridge/c/c_instance.cpp:
        (JSC::Bindings::CInstance::invokeMethod):
        (JSC::Bindings::CInstance::invokeDefaultMethod):
        (JSC::Bindings::CInstance::invokeConstruct):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        (ObjcInstance::invokeDefaultMethod):

WebKit/mac:

2009-04-28  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Beth Dakin.

        Removed scaffolding supporting dynamically converting between 32bit and
        64bit value representations.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::marshalValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago A little more hardening for UString
ddkilzer@apple.com [Wed, 29 Apr 2009 05:56:18 +0000 (05:56 +0000)]
    A little more hardening for UString

        Reviewed by Maciej Stachowiak.

        Revised fix for <rdar://problem/5861045> in r42644.

        * runtime/UString.cpp:
        (JSC::newCapacityWithOverflowCheck): Added.
        (JSC::concatenate): Used newCapacityWithOverflowCheck().
        (JSC::UString::append): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 David Carson <dacarson@apple.com>
ddkilzer@apple.com [Wed, 29 Apr 2009 05:52:23 +0000 (05:52 +0000)]
2009-04-28  David Carson  <dacarson@apple.com>

        Reviewed by David Hyatt.

        Restore alignment to device pixel boundaries.
        https://bugs.webkit.org/show_bug.cgi?id=25458

        Adjust the adjusted destination rect to be device pixel aligned.

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

2009-04-28  David Carson  <dacarson@apple.com>

        Reviewed by David Kilzer.

        Restore alignment to device pixel boundaries.
        https://bugs.webkit.org/show_bug.cgi?id=25458

        Updated test results with progressions.

        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        Yin-yang image shifted slightly to pixel boundaries.

        * platform/mac/svg/custom/focus-ring-expected.checksum:
        * platform/mac/svg/custom/focus-ring-expected.png:
        Focus rings drawn around rotated "focus text" and checkered
        images shifted slightly to pixel boundaries.

        * platform/mac/svg/custom/image-small-width-height-expected.checksum:
        * platform/mac/svg/custom/image-small-width-height-expected.png:
        Checkered images shifted slightly to pixel boundaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added missing pixel test results.
ddkilzer@apple.com [Wed, 29 Apr 2009 05:49:24 +0000 (05:49 +0000)]
    Added missing pixel test results.

        * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.png: Added.
        * platform/mac/fast/table/cell-coalescing-expected.checksum: Added.
        * platform/mac/fast/table/cell-coalescing-expected.png: Added.
        * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.checksum: Added.
        * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
        * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.checksum: Added.
        * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.png: Added.
        * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.checksum: Added.
        * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 29 Apr 2009 05:39:21 +0000 (05:39 +0000)]
2009-04-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Move unimplemented captureEvents and releaseEvents from JSDOMWindow
        to DOMWindow.

        * bindings/js/JSDOMWindowCustom.cpp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::captureEvents):
        (WebCore::DOMWindow::releaseEvents):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrecting ChangeLogs - Sam talked to me about the patch, but it was Darin who review...
ap@webkit.org [Wed, 29 Apr 2009 05:30:46 +0000 (05:30 +0000)]
Correcting ChangeLogs - Sam talked to me about the patch, but it was Darin who reviewed it!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@webkit.org [Wed, 29 Apr 2009 05:25:31 +0000 (05:25 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25420
        <rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin

        Test: http/tests/xmlhttprequest/detaching-frame-2.html

        This was caused by faulty DOMWindow::document(), which could return a new document from
        the window's frame after navigation.

        * bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
        Removed an obsolete check that allowed access when document was null. Contrary to what a
        comment said, that can happen for a window that is no longer in frame, not to one whose
        document is not constructed yet.

        * bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail
        out if context was not found. This currently happens due to a shortcoming in
        DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression
        test will be constructed successfully, but won't be sent, because its context will be
        frameless.

        * page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't
        been replaced yet. Added FIXME comments about how this may be better fixed in the future.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::document):
        (WebCore::constructAudio):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::document):
        (WebCore::constructImage):
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::construct):
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::document):
        (WebCore::constructHTMLOptionElement):
        Make matching changes to other constructors that hold a reference to global object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBring back r42969, this time with correct codegen
oliver@apple.com [Wed, 29 Apr 2009 04:54:47 +0000 (04:54 +0000)]
Bring back r42969, this time with correct codegen

Reviewed by Gavin Barraclough.

Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowxMSW build fix. Switch JSCore build back to static.
kevino@webkit.org [Wed, 29 Apr 2009 04:02:54 +0000 (04:02 +0000)]
wxMSW build fix. Switch JSCore build back to static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
ddkilzer@apple.com [Wed, 29 Apr 2009 03:03:12 +0000 (03:03 +0000)]
2009-04-28  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=25462

        Make sure "--pixel --add-platform-exceptions" produces platform
        specific pixel test results.

        * Scripts/run-webkit-tests: Support "--pixel
        --add-platform-exceptions"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll out r42969, due to hangs in build bot.
oliver@apple.com [Wed, 29 Apr 2009 01:24:00 +0000 (01:24 +0000)]
Roll out r42969, due to hangs in build bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Wed, 29 Apr 2009 01:00:31 +0000 (01:00 +0000)]
    Reviewed by Simon Fraser.

        Add a couple table hit tests
        https://bugs.webkit.org/show_bug.cgi?id=21892

        * svg/hittest/svg-inside-display-table-expected.txt: Added.
        * svg/hittest/svg-inside-display-table.xhtml: Added.
        * svg/hittest/svg-inside-table-expected.txt: Added.
        * svg/hittest/svg-inside-table.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove performance of string indexing
oliver@apple.com [Wed, 29 Apr 2009 00:38:23 +0000 (00:38 +0000)]
Improve performance of string indexing

Reviewed by Geoff Garen

Add a cti_get_by_val_string function to specialise indexing into a string object.
This gives us a slight performance win on a number of string tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
eric.carlson@apple.com [Wed, 29 Apr 2009 00:29:21 +0000 (00:29 +0000)]
2009-04-28  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6834830>

        Make sure we cover the two possible values reported by event.total that are playback engine
        specific.

        * media/progress-event-total-expected.txt: Match the new test.
        * media/progress-event-total.html: Test the two values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
timothy@apple.com [Wed, 29 Apr 2009 00:17:07 +0000 (00:17 +0000)]
    Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
        collects the individual rects, making sure to only include RenderText.

        <rdar://problem/6810061>

        Reviewed by Sam Weinig.

        * bindings/objc/DOM.mm:
        (-[DOMNode textRects]): Added. Make a Range and call textRects.
        (-[DOMNode lineBoxRects]): Call textRects method.
        (-[DOMRange textRects]): Call Range::textRects.
        (-[DOMRange lineBoxRects]): Call textRects method.
        * bindings/objc/DOMPrivate.h: Add the new methods and a comment
        about lineBoxRects being deprecated.
        * dom/Range.cpp:
        (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects).
        (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the
        nodes instead of the RenderObjects to correctly account for offsets. Also
        only call absoluteRectsForRange on RenderText.
        * dom/Range.h: Renamed addLineBoxRects to textRects.
        * page/Frame.cpp:
        (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this
        function very specific for the lineBoxRects API. These functions are still used
        by the InspectorController, and this change improves what the Inspector shows.
        (WebCore::RenderObject::absoluteQuadsForRange): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove the topLevel boolean argument from absolute{Rects,Quads}.
timothy@apple.com [Wed, 29 Apr 2009 00:11:15 +0000 (00:11 +0000)]
    Remove the topLevel boolean argument from absolute{Rects,Quads}.
        This argument was default to true and no one ever passed false.

        Reviewed by Sam Weinig.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::absoluteRects):
        (WebCore::RenderBlock::absoluteQuads):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absoluteRects):
        (WebCore::RenderBox::absoluteQuads):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::absoluteQuads):
        * rendering/RenderInline.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::absoluteRects):
        (WebCore::RenderObject::absoluteQuads):
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::absoluteRects):
        (WebCore::RenderSVGHiddenContainer::absoluteQuads):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::absoluteRects):
        (WebCore::RenderSVGImage::absoluteQuads):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::absoluteRects):
        (WebCore::RenderSVGInlineText::absoluteQuads):
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::absoluteRects):
        (WebCore::RenderSVGModelObject::absoluteQuads):
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGTSpan.cpp:
        (WebCore::RenderSVGTSpan::absoluteRects):
        (WebCore::RenderSVGTSpan::absoluteQuads):
        * rendering/RenderSVGTSpan.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::absoluteQuads):
        * rendering/RenderSVGText.h:
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::absoluteQuads):
        * rendering/RenderSVGTextPath.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::absoluteRects):
        * rendering/RenderText.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::absoluteRects):
        (WebCore::RenderView::absoluteQuads):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 28 Apr 2009 23:50:42 +0000 (23:50 +0000)]
2009-04-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6794691> Media documents and <video controls> never show controls on Windows

        RenderThemeWin doesn't implement the media element controller rendering methods, so media
        controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
        of the code in both places, the logic is in a new class that is called from both.

        * WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.

        * rendering/RenderMediaControls.cpp: Added.
        (WebCore::determineState): Translate renderer state to ThemeControlState.
        (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb.
        (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element.
        (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
        * rendering/RenderMediaControls.h: Added.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never
        called for the media slider.
        (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function.
        (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto.
        (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto.
        (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto.
        (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Tue, 28 Apr 2009 23:12:12 +0000 (23:12 +0000)]
2009-04-28  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
        images with % height are collapsed when printing

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight): Make sure we don't ignore
        printing here!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 22:36:21 +0000 (22:36 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: fix distcheck build, add (even more) missing files to list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove performance of right shifts of large or otherwise floating point values.
oliver@apple.com [Tue, 28 Apr 2009 22:22:35 +0000 (22:22 +0000)]
Improve performance of right shifts of large or otherwise floating point values.

Reviewed by Geoff Garen.

Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Tue, 28 Apr 2009 22:17:29 +0000 (22:17 +0000)]
WebCore:

2009-04-28  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

        Test: editing/deleting/type-delete-after-quote.html

        When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
        since it is unclear to most users that such a selection actually ends at the start of the next paragraph.  However, when a user hits delete
        with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it.  We can tell that
        we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection.  So we can tell
        that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
        from deleting a range they selected.

        * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):

LayoutTests:

2009-04-28  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

        * editing/deleting/type-delete-after-quote.html: Added.
        * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done,
          but the document structure remains the same, and there are no visible changes to the result.
        * platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
        * platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
        * platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 28 Apr 2009 22:15:28 +0000 (22:15 +0000)]
2009-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: fix distcheck build, add (more) missing files to list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Tue, 28 Apr 2009 22:12:13 +0000 (22:12 +0000)]
    Reviewed by Simon Fraser.

        Add text gradient test to cover
        https://bugs.webkit.org/show_bug.cgi?id=25403

        * platform/mac/svg/text/text-gradient-positioning-expected.checksum: Added.
        * platform/mac/svg/text/text-gradient-positioning-expected.png: Added.
        * platform/mac/svg/text/text-gradient-positioning-expected.txt: Added.
        * svg/text/text-gradient-positioning.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42966 268f45cc-cd09-0410-ab3c-d52691b4dbfc