WebKit-https.git
10 years agoVersioning.
timothy@apple.com [Thu, 14 May 2009 22:18:47 +0000 (22:18 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
kmccullough@apple.com [Thu, 14 May 2009 21:56:09 +0000 (21:56 +0000)]
WebCore:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Rolling out to fix a bug and the build

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):

LayoutTests:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        - Rolled out for bug and build fix.

        * editing/execCommand/outdent-blockquote-test1.html: Removed.
        * editing/execCommand/outdent-blockquote-test2.html: Removed.
        * editing/execCommand/outdent-blockquote-test3.html: Removed.
        * editing/execCommand/outdent-blockquote-test4.html: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Removed.
        * platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
kmccullough@apple.com [Thu, 14 May 2009 21:28:45 +0000 (21:28 +0000)]
WebCore:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6510362> In some situations message content is messed up
        when indentation is decreased

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively
        here served to do nothing because this function will return if the
        second argument is the parent of the first.  Not only does this now work
        as intended, but is necessary for the rest of this fix.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we
        are the last node in a <blockquote>, and can therefore remove the
        <blockquote> we need the endOfEnclosingBlock to extend to the end of
        the <blockquote> not just the next block, which could be a <div>, for
        example.
        - Also If a <blockquote> is removed, but it's the child of another
        <blockquote> then its children are now children of the top <blockquote>.
        In this case we want to split the parent <blockquote> because the next
        paragraph assumes that it is the first node in its <blockquote> and if
        that is not true, various bugs arise.

LayoutTests:

2009-05-14  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6510362> In some situations message content is messed up
        when indentation is decreased

        - These tests are the various combinations of <blockquote>s that
        revealed bugs in our old logic.

        * editing/execCommand/outdent-blockquote-test1.html: Added.
        * editing/execCommand/outdent-blockquote-test2.html: Added.
        * editing/execCommand/outdent-blockquote-test3.html: Added.
        * editing/execCommand/outdent-blockquote-test4.html: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
        * platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 14 May 2009 20:47:56 +0000 (20:47 +0000)]
2009-05-14  David Hyatt  <hyatt@apple.com>

        Reviewed by Tim Hatcher.

        Fix for <rdar://problem/6886217> REGRESSION (S4 beta-ToT): Adium chat window contents no longer resize.

        Technically this is a bug in Adium.  It appears that Adium has subclassed the WebView and implemented
        viewDidMoveToWindow in its subclass improperly.  It doesn't call up to the base class WebView like it
        should and so our boundsChanged notification never gets added.

        Reduce the dependence on viewDidMoveToWindow by moving the registration of observers into
        viewWillMoveToWindow instead.

        * WebView/WebView.mm:
        (-[WebView addSizeObserversForWindow:]):
        (-[WebView removeWindowObservers]):
        (-[WebView addWindowObserversForWindow:]):
        (-[WebView viewWillMoveToWindow:]):
        (-[WebView viewDidMoveToWindow]):
        (-[WebView viewDidMoveToSuperview]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 14 May 2009 20:42:30 +0000 (20:42 +0000)]
2009-05-14  Brady Eidson  <beidson@apple.com>

        Build fix.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::setDefaultMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 14 May 2009 20:09:22 +0000 (20:09 +0000)]
2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben.

        Fix http/tests/xmlhttprequest/cache-override.html on Windows

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data.
        (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed.
        (WebCore::WebCoreSynchronousLoader::load): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Paul Godavari <paul@chromium.org>
levin@chromium.org [Thu, 14 May 2009 19:55:16 +0000 (19:55 +0000)]
2009-05-14  Paul Godavari  <paul@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug: Mac Chromium popup menus are not positioned correctly
        on scrolled pages:
        https://bugs.webkit.org/show_bug.cgi?id=25772

        Fix Mac Chromium popup menu placement by taking into
        account any scrolling in the current window. This mirrors
        the positioning done in PopupContainer::show(), which is
        used on Chromium Windows and linux.

        Also fixed indenting for this method.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showExternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Drew Wilson <atwilson@google.com>
levin@chromium.org [Thu, 14 May 2009 19:55:07 +0000 (19:55 +0000)]
2009-05-14  Drew Wilson  <atwilson@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25774
        Upstream V8MessagePortCustom.cpp from the chromium repository.

        * bindings/v8/custom/V8MessagePortCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/mac:
levin@chromium.org [Thu, 14 May 2009 19:54:58 +0000 (19:54 +0000)]
WebKit/mac:

2009-05-14  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24704

        Allow the local cache directory to be set using a defaults key.

        * Misc/WebKitNSStringExtras.h:
        * Misc/WebKitNSStringExtras.m:
        (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
        * WebKit.exp:

WebKitTools:

2009-05-14  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24704

        Make paths where data is saved be scoped to the ~ directory,
        so that one can run independent instances by setting CFFIXED_USER_HOME.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (libraryPath):
        (setDefaultsToConsistentValuesForTesting):
        (dumpFrameAsPDF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 May 2009 19:21:30 +0000 (19:21 +0000)]
2009-05-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=25777

        StyleGeneratedImage::imageSize() needs to take zooming into account for
        fixed-size images (i.e. canvas) so that canvas-as-image-background
        renders correctly with zooming.

        Test: fast/canvas/canvas-bg-zoom.html

        * rendering/style/StyleGeneratedImage.cpp:
        (WebCore::StyleGeneratedImage::imageSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 14 May 2009 19:09:40 +0000 (19:09 +0000)]
    Reviewed by Darin Adler.

        Patch originally by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25796
        <rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().

        Test: http/tests/security/credentials-in-referer.html

        * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in
        SubresourceLoader::create() anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 14 May 2009 19:07:47 +0000 (19:07 +0000)]
2009-05-14  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disabling tests that are failing intermittently.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 25797: Pages with image maps are not properly read with Voiceover
cfleizach@apple.com [Thu, 14 May 2009 19:01:05 +0000 (19:01 +0000)]
Bug 25797: Pages with image maps are not properly read with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=25797

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
beidson@apple.com [Thu, 14 May 2009 18:56:14 +0000 (18:56 +0000)]
WebCore:

2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790

        Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::shouldContentSniff):
        * platform/network/ResourceHandle.h:

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::createCFURLResponseWithDefaultMIMEType):
        (WebCore::didReceiveResponse):

LayoutTests:

2009-05-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790

        * platform/win/Skipped: Renable these tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 14 May 2009 17:51:28 +0000 (17:51 +0000)]
2009-05-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25791
        Bug 25791: HTMLMediaElement: implement 'startTime' attribute

        Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
        value that only the media engine can know, so we just need to add the attribute
        to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
        the engine can make it available.

        Test: media/media-startTime.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::startTime): New.
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::startTime): New.
        * platform/graphics/MediaPlayer.h:

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::startTime): New.

2009-05-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25791
        Bug 25791: HTMLMediaElement: implement 'startTime' attribute

        Add test for 'startTime' attribute.

        * media/media-startTime-expected.txt: Added.
        * media/media-startTime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
ariya@webkit.org [Thu, 14 May 2009 17:44:14 +0000 (17:44 +0000)]
2009-05-14  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Ariya Hidayat.

        Add a comment to QWebView::iconChanged(), mentioning that you will
        need to set the icon database path for icons to be loaded, and thus
        receive the signal.

        * Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Tony Chang <tony@chromium.org>
dglazkov@chromium.org [Thu, 14 May 2009 17:35:51 +0000 (17:35 +0000)]
2009-05-14  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        Move iframe content to a file because Chromium has
        AllowLocalLoadsForLocalOnly enabled.  This prevents the parent
        frame from modifying the iframe content if it is a data: URL.

        https://bugs.webkit.org/show_bug.cgi?id=25766

        * fast/frames/content-opacity-2.html:
        * fast/frames/resources/empty-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Add a failing text control metrics test to the Windows Skipped file
aroben@apple.com [Thu, 14 May 2009 17:34:04 +0000 (17:34 +0000)]
    Add a failing text control metrics test to the Windows Skipped file

        See Bug 25794: fast/replaced/table-percent-height-text-controls fails
        on Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25794>

        * platform/win/Skipped: Added
        fast/replaced/table-percent-height-text-controls.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows build fix
sfalken@apple.com [Thu, 14 May 2009 17:29:09 +0000 (17:29 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
ariya@webkit.org [Thu, 14 May 2009 17:27:09 +0000 (17:27 +0000)]
2009-05-14  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Ariya Hidayat.

        Only create a QWidget wrapper for the plugin in the case it is not
        in the Qt window mapper, and thus receiving events from the Qt
        event system. Native Qt based plugins running in process, will
        already be in the window mapper, and thus creating a wrapper,
        stops them from getting events from Qt, as they are redirected
        to the wrapper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 14 May 2009 16:45:39 +0000 (16:45 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25784
        Leaks seen on HTTP tests

        We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for
        disabling content sniffing, matching the normal code path.
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user
        and m_pass before overwriting.
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 14 May 2009 16:39:48 +0000 (16:39 +0000)]
2009-05-14  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6879999> Automator actions that use WebKit on a background thread fail when run outside of Automator

        * WebView/WebView.mm:
        (clientNeedsWebViewInitThreadWorkaround): Added. Contains new broader rule.
        (needsWebViewInitThreadWorkaround): Changed to call clientNeedsWebViewInitThreadWorkaround.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Yury Semikhatsky <yurys@chromium.org>
dglazkov@chromium.org [Thu, 14 May 2009 16:14:28 +0000 (16:14 +0000)]
2009-05-14  Yury Semikhatsky <yurys@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25418
        Remove new lines from event handler wrapper to make line numbers
        in the wrapped script conside with the lines in the original script.

        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::getListenerFunction):
        (WebCore::V8LazyEventListener::getWrappedListenerFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Add a timing-out test to the Windows Skipped file
aroben@apple.com [Thu, 14 May 2009 16:11:44 +0000 (16:11 +0000)]
    Add a timing-out test to the Windows Skipped file

        See Bug 25792: fast/encoding/percent-escaping.html times out on
        Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25792>

        * platform/win/Skipped: Added fast/encoding/percent-escaping.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 14 May 2009 16:11:25 +0000 (16:11 +0000)]
2009-05-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Remove a JSC-specific include that is already added by including
        ScriptController.

        No change in behavior, so no tests.

        * dom/Document.cpp: Removed JSDOMBinding include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Brady Eidson.
ap@webkit.org [Thu, 14 May 2009 16:05:05 +0000 (16:05 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled

        Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
        CFString function was used, so a user-friendly name was stored in encoding fallback array.

        * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
        * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Add new Hebrew-using tests to the Windows Skipped file
aroben@apple.com [Thu, 14 May 2009 15:59:44 +0000 (15:59 +0000)]
    Add new Hebrew-using tests to the Windows Skipped file

        See Bug 23925: Tests that use Hebrew text fail on Windows because
        Lucida Grande is not used for Hebrew
        <https://bugs.webkit.org/show_bug.cgi?id=23925>

        * platform/win/Skipped: Added tests added in r43664.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Skip XHR tests that crash in Windows Debug builds
aroben@apple.com [Thu, 14 May 2009 15:23:35 +0000 (15:23 +0000)]
    Skip XHR tests that crash in Windows Debug builds

        See:

        Bug 25790: REGRESSION (r43518): Multiple XHR tests asserting in
        createCFURLResponseWithDefaultMIMEType on Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25790>

        Bug 25344: Some http tests crash in Debug Windows builds due to an
        assertion in CFNetwork when releasing a CFURLConnection
        <https://bugs.webkit.org/show_bug.cgi?id=25344>

        * platform/win/Skipped: Added crashing XHR tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Yael Aharon <yael.aharon@nokia.com>
ariya@webkit.org [Thu, 14 May 2009 15:19:51 +0000 (15:19 +0000)]
2009-05-14  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Ariya Hidayat.

        Fix setHtml test case by adding <head> tag to the expected result. This tag is automatically added by WebKit.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows jsc build fix
aroben@apple.com [Thu, 14 May 2009 15:04:55 +0000 (15:04 +0000)]
    Windows jsc build fix

        r43648 modified jsc.vcproj's post-build event not to try to copy files
        that aren't present. Then r43661 mistakenly un-did that modification.
        This patch restores the modification from r43648, but puts the code in
        jscCommon.vsprops (where it should have been added in r43648).

        * JavaScriptCore.vcproj/jsc/jsc.vcproj: Restored empty
        VCPostBuildEventTool tags.
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Modified the post-build
        event command line to match the one in jsc.vcproj from r43648.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Ben Murdoch <benm@google.com>
kov@webkit.org [Thu, 14 May 2009 14:49:32 +0000 (14:49 +0000)]
2009-05-14  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        Add more ENABLE_DATABASE guards.
        https://bugs.webkit.org/show_bug.cgi?id=25616

        See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)

        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        * bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
        * bindings/v8/custom/V8CustomSQLStatementCallback.h:
        * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
        * bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
        * bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
        * bindings/v8/custom/V8CustomSQLTransactionCallback.h:
        * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
        * bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
        * bindings/v8/custom/V8DatabaseCustom.cpp:
        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
        * bindings/v8/custom/V8SQLTransactionCustom.cpp:
        * storage/Database.cpp:
        * storage/DatabaseDetails.h:
        * storage/OriginUsageRecord.cpp:
        * storage/OriginUsageRecord.h:
        * storage/SQLError.h:
        * storage/SQLError.idl:
        * storage/SQLResultSet.cpp:
        * storage/SQLResultSet.h:
        * storage/SQLResultSet.idl:
        * storage/SQLResultSetRowList.cpp:
        * storage/SQLResultSetRowList.h:
        * storage/SQLResultSetRowList.idl:
        * storage/SQLStatementCallback.h:
        * storage/SQLStatementErrorCallback.h:
        * storage/SQLTransactionCallback.h:
        * storage/SQLTransactionErrorCallback.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
zecke@webkit.org [Thu, 14 May 2009 14:23:11 +0000 (14:23 +0000)]
2009-05-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25325

        Make sure pthread_self() is declared before it gets called in Collector.cpp

        * runtime/Collector.cpp: Include pthread.h in most Unix-like platforms
        (not just for OPENBSD)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Thu, 14 May 2009 14:22:51 +0000 (14:22 +0000)]
2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25787

        Gtk was the last platform to not unregister plugins when
        the plugin is stopped. Catch up with r43550.

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Yael Aharon <yael.aharon@nokia.com>
ariya@webkit.org [Thu, 14 May 2009 14:17:30 +0000 (14:17 +0000)]
2009-05-14  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Ariya Hidayat.

        Add a test case for the signal urlChanged().
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Make WebCore.vcproj's pre-build event work again
aroben@apple.com [Thu, 14 May 2009 14:10:43 +0000 (14:10 +0000)]
    Make WebCore.vcproj's pre-build event work again

        * WebCore.vcproj/WebCore.vcproj: Removed empty override of the
        pre-build event that was accidentally left in when the pre-build event
        was moved to WebCoreCommon.vsprops.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Remove old render tree dumps for http tests that are now text-only
aroben@apple.com [Thu, 14 May 2009 13:29:04 +0000 (13:29 +0000)]
    Remove old render tree dumps for http tests that are now text-only

        Beth made the tests text-only in r43677 but forgot to remove these
        Windows-specific render tree dumps.

        Rubber-stamped by Dave Hyatt.

        * platform/win/http/tests/navigation/anchor-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/anchor-goback-expected.txt: Removed.
        * platform/win/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
        * platform/win/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
        * platform/win/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
        * platform/win/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
        * platform/win/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
        * platform/win/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
        * platform/win/http/tests/navigation/post-goback2-expected.txt: Removed.
        * platform/win/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
        * platform/win/http/tests/navigation/redirect302-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/redirect302-frames-expected.txt: Removed.
        * platform/win/http/tests/navigation/redirect302-goback-expected.txt: Removed.
        * platform/win/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
        * platform/win/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
        * platform/win/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
        * platform/win/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/success200-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/success200-frames-expected.txt: Removed.
        * platform/win/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
        * platform/win/http/tests/navigation/success200-goback-expected.txt: Removed.
        * platform/win/http/tests/navigation/success200-loadsame-expected.txt: Removed.
        * platform/win/http/tests/navigation/success200-reload-expected.txt: Removed.
        * platform/win/http/tests/navigation/success200-subframeload-expected.txt: Removed.
        * platform/win/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
        * platform/win/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
        * platform/win/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
        * platform/win/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
darin@apple.com [Thu, 14 May 2009 11:50:30 +0000 (11:50 +0000)]
WebCore:

2009-05-14  Darin Adler  <darin@apple.com>

        * manual-tests/right-click-crash.html: Added.

WebKit/mac:

2009-05-14  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        Bug 24049: Second right-click crashes safari when alert invoked
        https://bugs.webkit.org/show_bug.cgi?id=24049
        rdar://problem/6878977

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView rightMouseUp:]): Added a retain/autorelease of the event.
        (-[WebHTMLView menuForEvent:]): Ditto. Also cleaned up the logic here and
        eliminated some use of pointers that might be invalid after calling through
        to WebCore.
        (-[WebHTMLView scrollWheel:]): Ditto.
        (-[WebHTMLView acceptsFirstMouse:]): Ditto.
        (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Ditto.
        (-[WebHTMLView mouseDown:]): Ditto.
        (-[WebHTMLView mouseDragged:]): Ditto.
        (-[WebHTMLView mouseUp:]): Ditto.
        (-[WebHTMLView keyDown:]): Ditto.
        (-[WebHTMLView keyUp:]): Ditto.
        (-[WebHTMLView flagsChanged:]): Ditto.
        (-[WebHTMLView performKeyEquivalent:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=25785>. Bug 25785: Segfault in mark...
mrowe@apple.com [Thu, 14 May 2009 11:14:52 +0000 (11:14 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=25785>. Bug 25785: Segfault in mark when using JSObjectMakeConstructor

Reviewed by Oliver Hunt.

* API/JSObjectRef.cpp:
(JSObjectMakeConstructor): OpaqueJSClass::prototype can return 0.  We need to use the default object prototype when it does.
* API/tests/testapi.c:
(main): Add a test case.
* runtime/JSObject.h:
(JSC::JSObject::putDirect): Add a clearer assertion for a null value.  The assertion on the next line does catch this,
but the cause of the failure is not clear from the assertion itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
mrowe@apple.com [Thu, 14 May 2009 11:14:43 +0000 (11:14 +0000)]
<rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2

Rubber-stamped by Darin Adler.

The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 14 May 2009 10:55:17 +0000 (10:55 +0000)]
2009-05-14  Darin Adler  <darin@apple.com>

        * platform/gtk/Skipped: Added new tests to the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-14 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 14 May 2009 08:58:06 +0000 (08:58 +0000)]
2009-05-14  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Checking register file bounds should be a ptr comparison (m_end is a Register*).
        Also, the compare should be unsigned, pointers don'ts go negative.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 May 2009 05:44:17 +0000 (05:44 +0000)]
2009-05-13  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Fix pixel result after test was changed in r43664.

        * platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
        * platform/mac/fast/css/text-overflow-ellipsis-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 14 May 2009 02:38:33 +0000 (02:38 +0000)]
2009-05-13  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * WebCore.NPAPI.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Oliver Hunt.
eric@webkit.org [Thu, 14 May 2009 01:44:27 +0000 (01:44 +0000)]
    Reviewed by Oliver Hunt.

        Fix invalid memory write seen in HTMLCanvasElement by Valgrind
        https://bugs.webkit.org/show_bug.cgi?id=25759

        I can't think of any way to catch this with a layout test, so no test.

        * css/CSSCanvasValue.cpp:
        (WebCore::CSSCanvasValue::canvasDestroyed):
        * css/CSSCanvasValue.h:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
        * html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 14 May 2009 01:14:34 +0000 (01:14 +0000)]
2009-05-13  Beth Dakin  <bdakin@apple.com>

        Rubber-stamped by Oliver Hunt.

        Change a bunch of http tests to dumpAsText(). They are currently
        failing on the Windown Build Bot because of textarea metrics
        changes, and we have decided that these tests are most valuable as
        text test anyway.

        * http/tests/navigation/anchor-basic-expected.txt: Added.
        * http/tests/navigation/anchor-basic.html:
        * http/tests/navigation/anchor-goback-expected.txt: Added.
        * http/tests/navigation/anchor-goback.html:
        * http/tests/navigation/anchor-subframeload-expected.txt: Added.
        * http/tests/navigation/anchor-subframeload.html:
        * http/tests/navigation/javascriptlink-basic-expected.txt: Added.
        * http/tests/navigation/javascriptlink-basic.html:
        * http/tests/navigation/javascriptlink-goback-expected.txt: Added.
        * http/tests/navigation/javascriptlink-goback.html:
        * http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
        * http/tests/navigation/javascriptlink-subframeload.html:
        * http/tests/navigation/metaredirect-basic-expected.txt: Added.
        * http/tests/navigation/metaredirect-basic.html:
        * http/tests/navigation/metaredirect-frames-expected.txt: Added.
        * http/tests/navigation/metaredirect-frames.html:
        * http/tests/navigation/metaredirect-goback-expected.txt: Added.
        * http/tests/navigation/metaredirect-goback.html:
        * http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
        * http/tests/navigation/metaredirect-subframeload.html:
        * http/tests/navigation/post-goback2-expected.txt: Added.
        * http/tests/navigation/post-goback2.html:
        * http/tests/navigation/postredirect-goback2-expected.txt: Added.
        * http/tests/navigation/postredirect-goback2.html:
        * http/tests/navigation/redirect302-basic-expected.txt: Added.
        * http/tests/navigation/redirect302-basic.html:
        * http/tests/navigation/redirect302-frames-expected.txt: Added.
        * http/tests/navigation/redirect302-frames.html:
        * http/tests/navigation/redirect302-goback-expected.txt: Added.
        * http/tests/navigation/redirect302-goback.html:
        * http/tests/navigation/redirect302-subframeload-expected.txt: Added.
        * http/tests/navigation/redirect302-subframeload.html:
        * http/tests/navigation/relativeanchor-basic-expected.txt: Added.
        * http/tests/navigation/relativeanchor-basic.html:
        * http/tests/navigation/relativeanchor-frames-expected.txt: Added.
        * http/tests/navigation/relativeanchor-frames.html:
        * http/tests/navigation/relativeanchor-goback-expected.txt: Added.
        * http/tests/navigation/relativeanchor-goback.html:
        * http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
        * http/tests/navigation/slowmetaredirect-basic.html:
        * http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
        * http/tests/navigation/slowtimerredirect-basic.html:
        * http/tests/navigation/success200-basic-expected.txt: Added.
        * http/tests/navigation/success200-basic.html:
        * http/tests/navigation/success200-frames-expected.txt: Added.
        * http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
        * http/tests/navigation/success200-frames-loadsame.html:
        * http/tests/navigation/success200-frames.html:
        * http/tests/navigation/success200-goback-expected.txt: Added.
        * http/tests/navigation/success200-goback.html:
        * http/tests/navigation/success200-loadsame-expected.txt: Added.
        * http/tests/navigation/success200-loadsame.html:
        * http/tests/navigation/success200-reload-expected.txt: Added.
        * http/tests/navigation/success200-reload.html:
        * http/tests/navigation/success200-subframeload-expected.txt: Added.
        * http/tests/navigation/success200-subframeload.html:
        * http/tests/navigation/timerredirect-basic-expected.txt: Added.
        * http/tests/navigation/timerredirect-basic.html:
        * http/tests/navigation/timerredirect-frames-expected.txt: Added.
        * http/tests/navigation/timerredirect-frames.html:
        * http/tests/navigation/timerredirect-goback-expected.txt: Added.
        * http/tests/navigation/timerredirect-goback.html:
        * http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
        * http/tests/navigation/timerredirect-subframeload.html:
        * platform/mac/http/tests/navigation/anchor-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/anchor-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/anchor-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/anchor-goback-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/anchor-goback-expected.png: Removed.
        * platform/mac/http/tests/navigation/anchor-goback-expected.txt: Removed.
        * platform/mac/http/tests/navigation/anchor-subframeload-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/anchor-subframeload-expected.png: Removed.
        * platform/mac/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.png: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png: Removed.
        * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.png: Removed.
        * platform/mac/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.png: Removed.
        * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png: Removed.
        * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
        * platform/mac/http/tests/navigation/post-goback2-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/post-goback2-expected.png: Removed.
        * platform/mac/http/tests/navigation/post-goback2-expected.txt: Removed.
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.png: Removed.
        * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
        * platform/mac/http/tests/navigation/redirect302-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/redirect302-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/redirect302-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/redirect302-frames-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/redirect302-frames-expected.png: Removed.
        * platform/mac/http/tests/navigation/redirect302-frames-expected.txt: Removed.
        * platform/mac/http/tests/navigation/redirect302-goback-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/redirect302-goback-expected.png: Removed.
        * platform/mac/http/tests/navigation/redirect302-goback-expected.txt: Removed.
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.png: Removed.
        * platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-frames-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-frames-expected.png: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-goback-expected.png: Removed.
        * platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/success200-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/success200-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/success200-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/success200-frames-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/success200-frames-expected.png: Removed.
        * platform/mac/http/tests/navigation/success200-frames-expected.txt: Removed.
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png: Removed.
        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
        * platform/mac/http/tests/navigation/success200-goback-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/success200-goback-expected.png: Removed.
        * platform/mac/http/tests/navigation/success200-goback-expected.txt: Removed.
        * platform/mac/http/tests/navigation/success200-loadsame-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/success200-loadsame-expected.png: Removed.
        * platform/mac/http/tests/navigation/success200-loadsame-expected.txt: Removed.
        * platform/mac/http/tests/navigation/success200-reload-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/success200-reload-expected.png: Removed.
        * platform/mac/http/tests/navigation/success200-reload-expected.txt: Removed.
        * platform/mac/http/tests/navigation/success200-subframeload-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/success200-subframeload-expected.png: Removed.
        * platform/mac/http/tests/navigation/success200-subframeload-expected.txt: Removed.
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.png: Removed.
        * platform/mac/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.png: Removed.
        * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png: Removed.
        * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 14 May 2009 01:10:55 +0000 (01:10 +0000)]
2009-05-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebKit side of <rdar://problem/6884476>.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetLocation):
        Forward this to the plug-in instance proxy.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::getLocation):
        Ask the plug-in view for the location.

        * Plugins/Hosted/WebKitPluginClient.defs:
        Add MIG definition.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView locationStringForTarget:]):
        Return the URL for a given frame.

        * Plugins/WebNetscapeContainerCheckPrivate.h:
        Bump version. Add new declaration to the vtable.

        * Plugins/WebNetscapeContainerCheckPrivate.mm:
        (browserContainerCheckFuncs):
        Add new declaration to the vtable.

        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView locationForTarget:]):
        Call the base class method.

        * Plugins/npapi.mm:
        (WKN_GetLocation):
        Forward this to the plug-in view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
darin@apple.com [Thu, 14 May 2009 01:02:35 +0000 (01:02 +0000)]
2009-05-13  Douglas R. Davidson  <ddavidso@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6871587> Smart Copy/Paste setting should persist as continuous
        spell checking setting does

        * WebView/WebPreferenceKeysPrivate.h: Added WebSmartInsertDeleteEnabled.

        * WebView/WebView.mm:
        (-[WebViewPrivate init]): Initialize based on WebSmartInsertDeleteEnabled
        default.
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        Removed code that initialized here.
        (-[WebView setSmartInsertDeleteEnabled:]): Set default here was with
        continuous spell checking setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
mitz@apple.com [Thu, 14 May 2009 00:44:35 +0000 (00:44 +0000)]
WebCore:

        Reviewed by Anders Carlsson.

        - fix <rdar://problem/5483015> Replies in Mail are drawn first without
          the user style sheet and then redrawn with the style sheet

        Test: platform/mac/fast/loader/user-stylesheet-fast-path.html

        * page/mac/FrameMac.mm:
        (WebCore::Frame::setUserStyleSheetLocation): For data URLs with
        base64-encoded UTF-8 data, just decode the style sheet here an apply
        it synchronously instead of invoking an asynchronous loader.

LayoutTests:

        Reviewed by Anders Carlsson.

        - test for <rdar://problem/5483015> Replies in Mail are drawn first
          without the user style sheet and then redrawn with the style sheet

        * platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Added.
        * platform/mac/fast/loader/user-stylesheet-fast-path.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 25755: Implement ARIA grid role
cfleizach@apple.com [Wed, 13 May 2009 23:50:40 +0000 (23:50 +0000)]
Bug 25755: Implement ARIA grid role
https://bugs.webkit.org/show_bug.cgi?id=25755

Fix windows build bustage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 25755: Implement ARIA grid role
cfleizach@apple.com [Wed, 13 May 2009 23:44:44 +0000 (23:44 +0000)]
Bug 25755: Implement ARIA grid role
https://bugs.webkit.org/show_bug.cgi?id=25755

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 13 May 2009 23:08:03 +0000 (23:08 +0000)]
2009-05-13  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Fix <rdar://problem/6882919> REGRESSION: page at Metroauto site crashes in cti_op_loop_if_less (25730)

        op_loop_if_less (imm < op) was loading op into regT1, but in the slow path spills regT0.
        This leads to bad happen.

        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_loop_if_less):
        (JSC::JIT::emitSlow_op_loop_if_less):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 13 May 2009 22:44:55 +0000 (22:44 +0000)]
2009-05-13  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 25763: Need to move v8 custom binding to the custom directory.
        https://bugs.webkit.org/show_bug.cgi?id=25763

        No test due to no change in behavior.

        * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Nate Chapin <japhet@google.com>
dglazkov@chromium.org [Wed, 13 May 2009 22:39:18 +0000 (22:39 +0000)]
2009-05-13  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
        https://bugs.webkit.org/show_bug.cgi?id=25758

        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
dglazkov@chromium.org [Wed, 13 May 2009 22:30:10 +0000 (22:30 +0000)]
WebCore:

2009-05-13  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Dave Hyatt.

        Fix a number of bugs relating to RTL and text-overflow:ellipsis.
        Also refactor the relevant code to make it a little clearer.

        This CL fixes 3 fundamental issues:
        - Corrects behavior if the truncated InlineTextBox's directionality is
          different from the overall flow direction - bug 25135.
        - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
        - Full truncation on InlineBoxes in RTL flow - bug 24186
        - Add tests for the above + reorder/cleanup tests for easier
          interpretation of outcome.

        The code for placing ellipsis has been refactored to use
        left/right notation rather than a single variable whose meaning
        could differ based on flow directionality.

        To support differing inline directionality vs flow directionality,
        different variables are now used in InlineTextBox::placeEllipsisBox to
        track the two.

        The drawing mode for underlines in standards mode now correctly handles
        RTL truncation and relevant test where added.

        https://bugs.webkit.org/show_bug.cgi?id=24186
        https://bugs.webkit.org/show_bug.cgi?id=25135
        https://bugs.webkit.org/show_bug.cgi?id=24206

        Tests: fast/css/text-overflow-ellipsis-bidi.html
               fast/css/text-overflow-ellipsis-strict.html

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::placeEllipsisBox):
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintTextDecorations):
        (WebCore::InlineFlowBox::placeEllipsisBox):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::placeEllipsisBox):
        (WebCore::InlineTextBox::paint):
        * rendering/InlineTextBox.h:
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::placeEllipsis):
        (WebCore::RootInlineBox::placeEllipsisBox):
        * rendering/RootInlineBox.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

2009-05-13  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Dave Hyatt.

        Fix a number of bugs relating to RTL and text-overflow:ellipsis.
        Also refactor the relevant code to make it a little clearer.

        This CL fixes 3 fundamental issues:
        - Corrects behavior if the truncated InlineTextBox's directionality is
          different from the overall flow direction - bug 25135.
        - Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
        - Full truncation on InlineBoxes in RTL flow - bug 24186
        - Add tests for the above + reorder/cleanup tests for easier
          interpretation of outcome.

        The code for placing ellipsis has been refactored to use
        left/right notation rather than a single variable whose meaning
        could differ based on flow directionality.

        To support differing inline directionality vs flow directionality,
        different variables are now used in InlineTextBox::placeEllipsisBox to
        track the two.

        The drawing mode for underlines in standards mode now correctly handles
        RTL truncation and relevant test where added.

        https://bugs.webkit.org/show_bug.cgi?id=24186
        https://bugs.webkit.org/show_bug.cgi?id=25135
        https://bugs.webkit.org/show_bug.cgi?id=24206

        * fast/css/text-overflow-ellipsis-bidi.html: Added.
        * fast/css/text-overflow-ellipsis-strict.html: Added.
        * fast/css/text-overflow-ellipsis.html:
        * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
        * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
        * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
        * platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
        * platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
        * platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
        * platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore:
dimich@chromium.org [Wed, 13 May 2009 22:09:21 +0000 (22:09 +0000)]
JavaScriptCore:

2009-05-13  Dmitry Titov  <dimich@chromium.org>

        Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25746
        Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
        * bytecode/SamplingTool.cpp:
        (JSC::SamplingThread::start):
        (JSC::SamplingThread::stop):
        * bytecode/SamplingTool.h:
        * wtf/CrossThreadRefCounted.h:
        (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
        (WTF::::ref):
        (WTF::::deref):
        * wtf/Threading.h:
        * wtf/ThreadingNone.cpp:
        * wtf/ThreadingPthreads.cpp:
        (WTF::threadMapMutex):
        (WTF::initializeThreading):
        (WTF::threadMap):
        (WTF::identifierByPthreadHandle):
        (WTF::establishIdentifierForPthreadHandle):
        (WTF::pthreadHandleForIdentifier):
        (WTF::clearPthreadHandleForIdentifier):
        (WTF::createThreadInternal):
        (WTF::waitForThreadCompletion):
        (WTF::detachThread):
        (WTF::currentThread):
        * wtf/ThreadingWin.cpp:
        (WTF::threadMapMutex):
        (WTF::initializeThreading):
        (WTF::threadMap):
        (WTF::storeThreadHandleByIdentifier):
        (WTF::threadHandleForIdentifier):
        (WTF::clearThreadHandleForIdentifier):
        (WTF::createThreadInternal):
        (WTF::waitForThreadCompletion):
        (WTF::detachThread):
        (WTF::currentThread):
        * wtf/gtk/ThreadingGtk.cpp:
        (WTF::threadMapMutex):
        (WTF::initializeThreading):
        (WTF::threadMap):
        (WTF::identifierByGthreadHandle):
        (WTF::establishIdentifierForThread):
        (WTF::threadForIdentifier):
        (WTF::clearThreadForIdentifier):
        (WTF::createThreadInternal):
        (WTF::waitForThreadCompletion):
        (WTF::currentThread):
        * wtf/qt/ThreadingQt.cpp:
        (WTF::threadMapMutex):
        (WTF::threadMap):
        (WTF::identifierByQthreadHandle):
        (WTF::establishIdentifierForThread):
        (WTF::clearThreadForIdentifier):
        (WTF::threadForIdentifier):
        (WTF::initializeThreading):
        (WTF::createThreadInternal):
        (WTF::waitForThreadCompletion):
        (WTF::currentThread):

WebCore:

2009-05-13  Dmitry Titov  <dimich@chromium.org>

        Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25746
        Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::matchFunc):
        (WebCore::openFunc):
        (WebCore::createStringParser):
        (WebCore::createMemoryParser):
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::SQLiteDatabase):
        (WebCore::SQLiteDatabase::close):
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::DatabaseThread):
        (WebCore::DatabaseThread::start):
        (WebCore::DatabaseThread::databaseThread):
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::LocalStorageThread):
        (WebCore::LocalStorageThread::start):
        (WebCore::LocalStorageThread::localStorageThread):
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        (WebCore::LocalStorageThread::terminate):
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::WorkerThread):
        (WebCore::WorkerThread::start):

WebKit/win:

2009-05-13  Dmitry Titov  <dimich@chromium.org>

        Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25746
        Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
hyatt@apple.com [Wed, 13 May 2009 21:55:58 +0000 (21:55 +0000)]
WebCore:

2009-05-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Beth Dakin.

        Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus

        Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
        (which is typically clipped to the padding or content box).  Doing so was causing rounded clips to be incorrectly applied to padding and
        content.

        Added fast/overflow/border-radius-clipping.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):

LayoutTests:

2009-05-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Beth Dakin.

        Add layout test for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus.

        * fast/overflow/border-radius-clipping.html: Added.
        * platform/mac/fast/overflow/border-radius-clipping-expected.checksum: Added.
        * platform/mac/fast/overflow/border-radius-clipping-expected.png: Added.
        * platform/mac/fast/overflow/border-radius-clipping-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore:
darin@apple.com [Wed, 13 May 2009 21:53:59 +0000 (21:53 +0000)]
JavaScriptCore:

2009-05-13  Darin Adler  <darin@apple.com>

        Revert the parser arena change. It was a slowdown, not a speedup.
        Better luck next time (I'll break it up into pieces).

WebCore:

2009-05-13  Darin Adler  <darin@apple.com>

        Revert the parser arena change. It was a slowdown, not a speedup.
        Better luck next time (I'll break it up into pieces).

WebKit/mac:

2009-05-13  Darin Adler  <darin@apple.com>

        Revert the parser arena change. It was a slowdown, not a speedup.
        Better luck next time (I'll break it up into pieces).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agouploading new results. when I added this test, i committed outdated results.
alice.liu@apple.com [Wed, 13 May 2009 21:08:23 +0000 (21:08 +0000)]
uploading new results.  when I added this test, i committed outdated results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
hyatt@apple.com [Wed, 13 May 2009 20:56:54 +0000 (20:56 +0000)]
WebCore:

2009-05-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Beth Dakin and Darin Adler.

        Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.

        Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
        to a non-self-painting layer (and vice versa).

        Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
        repaint properly on opacity changes, etc.

        Added fast/repaint/opacity-change-on-overflow-float.html.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleWillChange):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::styleWillChange):
        (WebCore::RenderBoxModelObject::styleDidChange):
        * rendering/RenderBoxModelObject.h:

LayoutTests:

2009-05-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Beth Dakin and Darin Adler.

        Add a repaint test for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.

        * fast/repaint/opacity-change-on-overflow-float.html: Added.
        * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum: Added.
        * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
        * platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 13 May 2009 20:46:05 +0000 (20:46 +0000)]
2009-05-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disable new tests. We are not going to be adding more new test
        results for now, for we want to better sort out things such as
        fixed DPI, and easily reproducible font configuration.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 13 May 2009 20:38:58 +0000 (20:38 +0000)]
2009-05-13  Darin Adler  <darin@apple.com>

        Tiger build fix.

        * parser/Grammar.y: Add back empty code blocks, needed by older
        versions of bison on certain rules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 13 May 2009 19:40:52 +0000 (19:40 +0000)]
2009-05-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Not reviewed, build fix.

        Move an include, needed by Debugger under the corresponding guard.

        * inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER
            guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
levin@chromium.org [Wed, 13 May 2009 19:15:09 +0000 (19:15 +0000)]
WebCore:

2009-05-13  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
        https://bugs.webkit.org/show_bug.cgi?id=25394

        Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html

        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        Add another check to subresource loader to avoid doing any loads in frames
        when the loaders are being stopped.

LayoutTests:

2009-05-13  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
        https://bugs.webkit.org/show_bug.cgi?id=25394

        Request a subresource load for an IMG after 'unload' and before the next
        page load completes to expose the crash.

        * http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt: Added.
        * http/tests/xmlhttprequest/frame-unload-abort-crash.html: Added.
        * http/tests/xmlhttprequest/resources/xmlhttprequest-in-unload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Stephan Haller <nomad@froevel.de>
kov@webkit.org [Wed, 13 May 2009 19:13:09 +0000 (19:13 +0000)]
2009-05-13  Stephan Haller  <nomad@froevel.de>

        Reviewed by Gustavo Noronha.

        Wrong handling of file upload if no file selected
        https://bugs.webkit.org/show_bug.cgi?id=25649

        Fixed returned path if path is empty

        * WebCore/platform/gtk/FileSystemGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows build fix.
sfalken@apple.com [Wed, 13 May 2009 19:08:21 +0000 (19:08 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/jsc/jsc.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows build fixes after r43642
aroben@apple.com [Wed, 13 May 2009 18:42:22 +0000 (18:42 +0000)]
    Windows build fixes after r43642

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
        Updated.

        * debugger/Debugger.cpp:
        * runtime/ArrayConstructor.cpp:
        * runtime/JSArray.cpp:
        * runtime/RegExp.cpp:
        * runtime/RegExpConstructor.cpp:
        * runtime/RegExpPrototype.cpp:
        * runtime/StringPrototype.cpp:
        Added missing #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
mitz@apple.com [Wed, 13 May 2009 18:33:07 +0000 (18:33 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white
          when loading

        Tests: fast/frames/content-opacity-1.html
               fast/frames/content-opacity-2.html

        * page/FrameView.cpp:
        (WebCore::FrameView::reset): Reset m_contentIsOpaque to false.
        (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content
        is not known to be opaque.
        (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque
        and enables or disables fast repaints accordingly.
        * page/FrameView.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the
        document()->haveStylesheetsLoaded() condition in determining whether the
        root is opaque. This is what was causing the bug, as iframes were
        considered to be opaque, and thus painted an opaque white background,
        whenever they were pending a style sheet load.
        Changed to call FrameView::setContentIsOpaqe() instead of
        setUseSlowRepaints(), which allows the frame to go back to fast repaints
        if the content becomes opaque.
        Corrected the check for background color opacity: any alpha value other
        than 255--not just zero--is not opaque.

LayoutTests:

        Reviewed by Dave Hyatt.

        - tests for <rdar://problem/6805567> REGRESSION (r42348): Notes flicker
          white when loading

        * fast/frames/content-opacity-1.html: Added.
        * fast/frames/content-opacity-2.html: Added.
        * platform/mac/fast/frames/content-opacity-1-expected.checksum: Added.
        * platform/mac/fast/frames/content-opacity-1-expected.png: Added.
        * platform/mac/fast/frames/content-opacity-1-expected.txt: Added.
        * platform/mac/fast/frames/content-opacity-2-expected.checksum: Added.
        * platform/mac/fast/frames/content-opacity-2-expected.png: Added.
        * platform/mac/fast/frames/content-opacity-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Wed, 13 May 2009 18:30:52 +0000 (18:30 +0000)]
2009-05-13  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Sam Weinig.

        [Qt] Fix "lighther" composition mode.
        QPainter::CompositionMode_Plus is the right match.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::toQtCompositionMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 13 May 2009 18:19:03 +0000 (18:19 +0000)]
2009-05-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Do not handle KeyEvents with Ctrl or Alt modifiers that we
        otherwise know nothing about. Otherwise shortcuts defined in the
        WebView will never be executed.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::handleEditingKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDarn, Cameron caught it but I forgot to fix it.
darin@apple.com [Wed, 13 May 2009 18:15:57 +0000 (18:15 +0000)]
Darn, Cameron caught it but I forgot to fix it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore:
darin@apple.com [Wed, 13 May 2009 18:14:48 +0000 (18:14 +0000)]
JavaScriptCore:

2009-05-13  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 25674: syntax tree nodes should use arena allocation
        https://bugs.webkit.org/show_bug.cgi?id=25674

        Step 3: Add some actual arena allocation. About 1% SunSpider speedup.

        * JavaScriptCore.exp: Updated.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack
        contains const Identifier* now.
        (JSC::BytecodeGenerator::emitPushNewScope): Updated to take a const
        Identifier&.
        * bytecompiler/BytecodeGenerator.h: Ditto

        * bytecompiler/SegmentedVector.h: Added isEmpty.

        * debugger/Debugger.cpp:
        (JSC::Debugger::recompileAllJSFunctions): Moved this function here from
        WebCore so WebCore doesn't need the details of FunctionBodyNode.
        * debugger/Debugger.h: Ditto.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::execute): Updated since VarStack contains const
        Identifier* now.

        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_vm_lazyLinkCall): Call isHostFunction on the body
        rather than on the function object, since we can't easily have inlined
        access to the FunctionBodyNode in JSFunction.h since WebCore needs
        access to that header.
        (JSC::JITStubs::cti_op_construct_JSConstruct): Ditto.
        * profiler/Profiler.cpp:
        (JSC::Profiler::createCallIdentifier): Ditto.

        * parser/Grammar.y: Use JSGlobalData* to pass the global data pointer
        around whenever possible instead of using void*. Changed
        SET_EXCEPTION_LOCATION from a macro to an inline function. Marked
        the structure-creating functions inline. Changed the VarStack to use
        identifier pointers instead of actual identifiers. This takes
        advantage of the fact that all identifier pointers come from the
        arena and avoids referenc count churn. Changed Identifier* to
        const Identifier* to make sure we don't modify any by accident.
        Used identifiers for regular expression strings too, using the new
        scanRegExp that has out parameters instead of the old one that relied
        on side effects in the Lexer. Move the creation of numeric identifiers
        out of this file and into the PropertyNode constructor.

        * parser/Lexer.cpp:
        (JSC::Lexer::setCode): Pass in ParserArena, used for identifiers.
        (JSC::Lexer::makeIdentifier): Changed return type to const Identifier*
        and changed to call ParserArena.
        (JSC::Lexer::scanRegExp): Added out arguments that are const Identifier*
        as well as a prefix character argument so we can handle the /= case
        without a string append.
        (JSC::Lexer::skipRegExp): Added. Skips a regular expression without
        allocating Identifier objects.
        (JSC::Lexer::clear): Removed the code to manage m_identifiers, m_pattern,
        and m_flags, and added code to set m_arena to 0.
        * parser/Lexer.h: Updated for changes above.

        * parser/NodeConstructors.h:
        (JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable
        on the arena.
        (JSC::ParserArenaDeletable::operator new): Changed to call the
        allocateDeletable function on the arena instead of deleteWithArena.
        (JSC::RegExpNode::RegExpNode): Changed arguments to Identifier instead
        of UString since these come from the parser which makes identifiers.
        (JSC::PropertyNode::PropertyNode): Added new constructor that makes
        numeric identifiers. Some day we might want to optimize this for
        integers so it doesn't create a string for each one.
        (JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier
        since it's now a const Identifier& so it can't be left uninitialized.
        (JSC::BreakNode::BreakNode): Ditto.
        (JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements*
        to keep track of the statements rather than a separate statement vector.
        (JSC::BlockNode::BlockNode): Ditto.
        (JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.

        * parser/Nodes.cpp: Moved the comment explaining emitBytecode in here.
        It seemed strangely out of place in the header.
        (JSC::ThrowableExpressionData::emitThrowError): Added an overload for
        UString as well as Identifier.
        (JSC::SourceElements::singleStatement): Added.
        (JSC::SourceElements::lastStatement): Added.
        (JSC::RegExpNode::emitBytecode): Updated since the pattern and flags
        are now Identifier instead of UString. Also changed the throwError code
        to use the substitution mechanism instead of doing a string append.
        (JSC::SourceElements::emitBytecode): Added. Replaces the old
        statementListEmitCode function, since we now keep the SourceElements
        objects around.
        (JSC::BlockNode::lastStatement): Added.
        (JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of
        statementListEmitCode.
        (JSC::CaseClauseNode::emitBytecode): Added.
        (JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode
        instead of statementListEmitCode.
        (JSC::ScopeNodeData::ScopeNodeData): Changed to store the
        SourceElements* instead of using releaseContentsIntoVector.
        (JSC::ScopeNode::emitStatementsBytecode): Added.
        (JSC::ScopeNode::singleStatement): Added.
        (JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead
        of statementListEmitCode.
        (JSC::EvalNode::emitBytecode): Ditto.
        (JSC::EvalNode::generateBytecode): Removed code to clear the children
        vector. This optimization is no longer possible since everything is in
        a single arena.
        (JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode
        insetad of statementListEmitCode and check for the return node using
        the new functions.

        * parser/Nodes.h: Changed VarStack to store const Identifier* instead
        of Identifier and rely on the arena to control lifetime. Added a new
        ParserArenaFreeable class. Made ParserArenaDeletable inherit from
        FastAllocBase instead of having its own operator new. Base the Node
        class on ParserArenaFreeable. Changed the various Node classes
        to use const Identifier& instead of Identifier to avoid the need to
        call their destructors and allow them to function as "freeable" in the
        arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions.
        Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode,
        CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable
        as a base class since they do not descend from Node. Eliminated the
        StatementVector type and instead have various classes use SourceElements*
        instead of StatementVector. This prevents those classes from having th
        use ParserArenaDeletable to make sure the vector destructor is called.

        * parser/Parser.cpp:
        (JSC::Parser::parse): Pass the arena to the lexer.

        * parser/Parser.h: Added an include of ParserArena.h, which is no longer
        included by Nodes.h.

        * parser/ParserArena.cpp:
        (JSC::ParserArena::ParserArena): Added. Initializes the new members,
        m_freeableMemory, m_freeablePoolEnd, and m_identifiers.
        (JSC::ParserArena::freeablePool): Added. Computes the pool pointer,
        since we store only the current pointer and the end of pool pointer.
        (JSC::ParserArena::deallocateObjects): Added. Contains the common
        memory-deallocation logic used by both the destructor and the
        reset function.
        (JSC::ParserArena::~ParserArena): Changed to call deallocateObjects.
        (JSC::ParserArena::reset): Ditto. Also added code to zero out the
        new structures, and switched to use clear() instead of shrink(0) since
        we don't really reuse arenas.
        (JSC::ParserArena::makeNumericIdentifier): Added.
        (JSC::ParserArena::allocateFreeablePool): Added. Used when the pool
        is empty.
        (JSC::ParserArena::isEmpty): Added. No longer inline, which is fine
        since this is used only for assertions at the moment.

        * parser/ParserArena.h: Added an actual arena of "freeable" objects,
        ones that don't need destructors to be called. Also added the segmented
        vector of identifiers that used to be in the Lexer.

        * runtime/FunctionConstructor.cpp:
        (JSC::extractFunctionBody): Use singleStatement function rather than
        getting at a StatementVector.

        * runtime/FunctionPrototype.cpp:
        (JSC::functionProtoFuncToString): Call isHostFunction on the body
        rather than the function object.

        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction): Moved the structure version of this in
        here from the header. It's not hot enough that it needs to be inlined.
        (JSC::JSFunction::isHostFunction): Moved this in here from the header.
        It's now a helper to be used only within the class.
        (JSC::JSFunction::setBody): Moved this in here. It's not hot enough that
        it needs to be inlined, and we want to be able to compile the header
        without the definition of FunctionBodyNode.

        * runtime/JSFunction.h: Eliminated the include of "Nodes.h". This was
        exposing too much JavaScriptCore dependency to WebCore. Because of this
        change and some changes made to WebCore, we could now export a lot fewer
        headers from JavaScriptCore, but I have not done that yet in this check-in.
        Made a couple functions non-inline. Removes some isHostFunction() assertions.

        * wtf/FastAllocBase.h: Added the conventional using statements we use in
        WTF so we can use identifiers from the WTF namespace without explicit
        namespace qualification or namespace directive. This is the usual WTF style,
        although it's unconventional in the C++ world. We use the namespace primarily
        for link-time disambiguation, not compile-time.

        * wtf/FastMalloc.cpp: Fixed an incorrect comment.

WebCore:

2009-05-13  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 25674: syntax tree nodes should use arena allocation
        https://bugs.webkit.org/show_bug.cgi?id=25674

        * bindings/js/JSDOMBinding.h: Removed include of JSFunction.h.
        We don't want the entire DOM binding to depend on that file.

        * bindings/js/JSAudioConstructor.cpp: Added include of Error.h.
        Before we inherited this automatically because JDDOMBinding.h
        included JSFunction.h, but that was excessive.
        * bindings/js/JSDOMWindowCustom.cpp: Ditto.
        * bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
        * bindings/js/JSImageConstructor.cpp: Ditto.
        * bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
        * bindings/js/JSMessageChannelConstructor.cpp: Ditto.
        * bindings/js/JSOptionConstructor.cpp: Ditto.
        * bindings/js/JSWorkerConstructor.cpp: Ditto.
        * bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
        * bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
        * inspector/InspectorController.cpp: Ditto.

        * inspector/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
        Moved mose of this function into the base class in JavaScriptCore,
        so the details of compilation don't have to be exposed.

WebKit/mac:

2009-05-13  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        Bug 25674: syntax tree nodes should use arena allocation
        https://bugs.webkit.org/show_bug.cgi?id=25674

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes.
        New ones needed due to reducing includes of JSDOMBinding.h.
        * WebView/WebScriptDebugger.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForgot to add ChangeLog.
xan@webkit.org [Wed, 13 May 2009 18:05:46 +0000 (18:05 +0000)]
Forgot to add ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 13 May 2009 18:03:06 +0000 (18:03 +0000)]
2009-05-13  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix: add JITStubCall.h to files list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
darin@apple.com [Wed, 13 May 2009 18:02:40 +0000 (18:02 +0000)]
WebCore:

2009-05-13  Douglas R. Davidson  <ddavidso@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6879145>
        Generate a contextual menu item allowing autocorrections to
        easily be changed back.  Refrain from re-correcting items
        that have already been autocorrected once.

        * dom/DocumentMarker.h:
        * editing/Editor.cpp:
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::changeBackToReplacedString):
        * editing/Editor.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/mac/WebCoreViewFactory.h:
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        * platform/ContextMenuItem.h:
        * platform/LocalizedStrings.h:
        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::contextMenuItemTagChangeBack):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::replacedString):
        * rendering/HitTestResult.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/InlineTextBox.h:

WebKit/mac:

2009-05-13  Douglas R. Davidson  <ddavidso@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6879145>
        Generate a contextual menu item allowing autocorrections to
        easily be changed back.  Refrain from re-correcting items
        that have already been autocorrected once.

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory contextMenuItemTagChangeBack:]):
        * WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Yael Aharon <yael.aharon@nokia.com>
ariya@webkit.org [Wed, 13 May 2009 17:56:33 +0000 (17:56 +0000)]
2009-05-13  Yael Aharon <yael.aharon@nokia.com>

        Reviewed by Ariya Hidayat.

        Move emitting the signal QWebFrame::urlChanged to FrameLoaderClientQt::dispatchDidCommitLoad().
        This is to ensure that urlChanged() is emitted even if the frame has no title.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Wed, 13 May 2009 17:13:45 +0000 (17:13 +0000)]
2009-05-13  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed build fix, as suggested by Yael Aharon <yael.aharon@nokia.com>.

        * wtf/qt/ThreadingQt.cpp:
        (WTF::waitForThreadCompletion): renamed IsValid to isValid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fix resolve-ChangeLogs when used with Subversion
ddkilzer@apple.com [Wed, 13 May 2009 16:35:19 +0000 (16:35 +0000)]
    Fix resolve-ChangeLogs when used with Subversion

        Reviewed by Darin Adler.

        Fixes the following issue when run on a Subversion repository:

            $ ./WebKitTools/Scripts/resolve-ChangeLogs
            ERROR: --continue may only be used with a git repository

        * Scripts/resolve-ChangeLogs: Check for the boolean value of
        $gitRebaseContinue, not whether it's defined, when validating
        command-line switches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 13 May 2009 16:21:46 +0000 (16:21 +0000)]
2009-05-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Add information about the SVG index bounds check committed in
        r43590.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Fix Gtk+/X11 build on OSX
zecke@webkit.org [Wed, 13 May 2009 16:19:43 +0000 (16:19 +0000)]
[GTK] Fix Gtk+/X11 build on OSX

Including the CoreFoundation header here and X11 headers
later will result in different definitions for Boolean. The
CoreFoundation include does not seem to be necessary here
and my mac build was successfull without it. I will remove
it for now. If the build bots disagree this will be replaced
by a #if PLATFORM(CF).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX
zecke@webkit.org [Wed, 13 May 2009 16:19:24 +0000 (16:19 +0000)]
[GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX

When building Gtk+ on OSX we ended up declaring
setNPWindowIfNeeded twice. Fix that by moving
the #if PLATFORM(GTK) up and using elif instead of
else.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSmall typo fix superseed -> supersede
kov@webkit.org [Wed, 13 May 2009 16:15:25 +0000 (16:15 +0000)]
Small typo fix superseed -> supersede

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 13 May 2009 16:08:16 +0000 (16:08 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25749
        Add a test for non-same origin appcache manifest URL

        * http/tests/appcache/different-origin-manifest-expected.txt: Added.
        * http/tests/appcache/different-origin-manifest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 13 May 2009 16:08:01 +0000 (16:08 +0000)]
2009-05-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Note changes since 1.1.6.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 13 May 2009 15:25:00 +0000 (15:25 +0000)]
2009-05-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Updated control file, and main file for the 1.1.7
        release.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 13 May 2009 14:54:33 +0000 (14:54 +0000)]
2009-05-13  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: bump versions in preparation for 1.1.7 release.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Luca Ferretti <elle.uca@libero.it>
xan@webkit.org [Wed, 13 May 2009 14:49:59 +0000 (14:49 +0000)]
2009-05-13  Luca Ferretti  <elle.uca@libero.it>

        Rubber-stamped by Xan Lopez.

        New Italian translation.

        * it.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert "2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>"
jmalonzo@webkit.org [Wed, 13 May 2009 14:22:00 +0000 (14:22 +0000)]
Revert "2009-05-12  Jan Michael Alonzo  <jmalonzo@webkit.org>"

This reverts commit Revert r43562 - [Gtk] WTF_USE_JSC is already defined in
WebCore/config.h.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
ariya@webkit.org [Wed, 13 May 2009 14:20:35 +0000 (14:20 +0000)]
2009-05-13  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

    Rubberstamped by Ariya Hidayat.

    Fix coding style: Add {} to contents of if, containing a for loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
xan@webkit.org [Wed, 13 May 2009 14:04:33 +0000 (14:04 +0000)]
WebCore:

2009-05-13  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25685
        [GTK] Middle click paste form the pasteboard

        The kit wants to paste from at least two different
        clipboards. By introducing getCurrentTarget to the
        PasteboardHelper interface we can make this decision
        in the kit.
        Use the new method in PasteboardGtk to get the right
        GdkClipboard for the paste operation.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::documentFragment):
        (WebCore::Pasteboard::plainText):
        * platform/gtk/PasteboardHelper.h:

WebKit/gtk:

2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25685
        [GTK] Middle click paste form the pasteboard

        For paste from middle button (button==2) we want to use
        the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget
        method in PasteboardHelperGtk by asking the WebView which
        clipboard to use.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::getCurrentTarget):
        * WebCoreSupport/PasteboardHelperGtk.h:
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event):
        (webkit_web_view_use_primary_for_paste):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 13 May 2009 13:49:06 +0000 (13:49 +0000)]
2009-05-13  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Gustavo Noronha.

        Revert commit r43563, since it breaks WebKitGTK+ when compiled
        with gcc 4.4.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-13 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 13 May 2009 13:34:07 +0000 (13:34 +0000)]
2009-05-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
        <rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard

        QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
        on Tiger or Leopard.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute
        when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD.
        (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute
        when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-12 Antonio Gomes <antonio.gomes@openbossa.org>
ariya@webkit.org [Wed, 13 May 2009 12:12:52 +0000 (12:12 +0000)]
2009-05-12  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Ariya Hidayat.

        Fixed a possible crash @styleProperty when there is no embedded/external CSS set.

        * Api/qwebelement.cpp:
        (QWebElement::styleProperty):
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::style):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-12 Antonio Gomes <antonio.gomes@openbossa.org>
ariya@webkit.org [Wed, 13 May 2009 12:07:29 +0000 (12:07 +0000)]
2009-05-12  Antonio Gomes   <antonio.gomes@openbossa.org>

    Reviewed by Ariya Hidayat.

    Added external CSS test cases to QWebElement::styleProperty() method.

    Also some ::styleProperty() tests cleanup.

    * tests/qwebelement/tst_qwebelement.cpp:
    (tst_QWebElement::style):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-12 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 13 May 2009 09:10:02 +0000 (09:10 +0000)]
2009-05-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Add SamplingCounter tool to provide a simple mechanism for counting events in JSC
        (enabled using ENABLE(SAMPLING_COUNTERS)).  To count events within a single function
        use the class 'SamplingCounter', where the counter may be incremented from multiple
        functions 'GlobalSamplingCounter' may be convenient; all other counters (stack or
        heap allocated, rather than statically declared) should use the DeletableSamplingCounter.
        Further description of these classes is provided alongside their definition in
        SamplingTool.h.

        Counters may be incremented from c++ by calling the 'count()' method on the counter,
        or may be incremented by JIT code by using the 'emitCount()' method within the JIT.

        This patch also fixes CODEBLOCK_SAMPLING, which was missing a null pointer check.

        * JavaScriptCore.exp:
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::addWithCarry32):
        (JSC::MacroAssemblerX86::and32):
        (JSC::MacroAssemblerX86::or32):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::and32):
        (JSC::MacroAssemblerX86Common::or32):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::and32):
        (JSC::MacroAssemblerX86_64::or32):
        (JSC::MacroAssemblerX86_64::addPtr):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::adcl_im):
        (JSC::X86Assembler::addq_im):
        (JSC::X86Assembler::andl_im):
        (JSC::X86Assembler::orl_im):
        * bytecode/SamplingTool.cpp:
        (JSC::AbstractSamplingCounter::dump):
        * bytecode/SamplingTool.h:
        (JSC::AbstractSamplingCounter::count):
        (JSC::GlobalSamplingCounter::name):
        (JSC::SamplingCounter::SamplingCounter):
        * jit/JIT.h:
        * jit/JITCall.cpp:
        (JSC::):
        * jit/JITInlineMethods.h:
        (JSC::JIT::setSamplingFlag):
        (JSC::JIT::clearSamplingFlag):
        (JSC::JIT::emitCount):
        * jsc.cpp:
        (runWithScripts):
        * parser/Nodes.cpp:
        (JSC::ScopeNode::ScopeNode):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows build fix.
sfalken@apple.com [Wed, 13 May 2009 07:05:41 +0000 (07:05 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows build fix.
sfalken@apple.com [Wed, 13 May 2009 05:46:24 +0000 (05:46 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-12 Roland Steiner <rolandsteiner@google.com>
eric@webkit.org [Wed, 13 May 2009 04:46:58 +0000 (04:46 +0000)]
2009-05-12  Roland Steiner <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        Bug 25738: Skia: CSS border style not cleared for SVG object
        https://bugs.webkit.org/show_bug.cgi?id=25738

        If no dashing is set, this change reverts to solid stroke
        (previously the code bailed and left the old setting, whatever it was)

        Test case listed in above bug entry.
        (Additional complications due to each platform rendering dotted lines differently -
        c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setLineDash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Build fix.
sfalken@apple.com [Wed, 13 May 2009 04:36:22 +0000 (04:36 +0000)]
    Build fix.

        * SunSpider.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6881457> Crash occurs at JSC::Interpreter::execute() when loading...
oliver@apple.com [Wed, 13 May 2009 03:53:32 +0000 (03:53 +0000)]
<rdar://problem/6881457> Crash occurs at JSC::Interpreter::execute() when loading sears.com

Reviewed by Gavin Barraclough

We created the arguments objects before an op_push_scope but not
before op_push_new_scope, this meant a null arguments object could
be resolved inside catch blocks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-05-11 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Wed, 13 May 2009 03:38:18 +0000 (03:38 +0000)]
2009-05-11  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Eric Seidel.

        Bug 21903: Adds DOM bindings for the placeholder property of the
        HTMLInputElement.
        https://bugs.webkit.org/show_bug.cgi?id=21903

        Test: fast/forms/placeholder-dom-property.html

        * dom/InputElement.cpp:
        (WebCore::InputElement::updatePlaceholderVisibility):
        * dom/InputElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::placeholder):
        (WebCore::HTMLInputElement::setPlaceholder):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::updateFromElement):
        * wml/WMLInputElement.h:
        (WebCore::WMLInputElement::placeholder):
        (WebCore::WMLInputElement::setPlaceholder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43605 268f45cc-cd09-0410-ab3c-d52691b4dbfc