WebKit-https.git
14 years ago Reviewed by Justin.
harrison [Mon, 22 Aug 2005 20:24:39 +0000 (20:24 +0000)]
    Reviewed by Justin.

        <rdar://problem/4221384> Denver Regression: stickies widget crashed on 8F15 when pasting text

        Test cases added:  None.  Problem triggered by simple paste, which lots of the
        editing tests already do, but also required particular memory layout/cleanup state, which
        is not specifiable in our tests.

        * khtml/editing/markup.cpp:
        (khtml::createFragmentFromText):
        Ref the new paragraph element right away, rather than allocating more memory first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4554
eseidel [Mon, 22 Aug 2005 18:53:29 +0000 (18:53 +0000)]
Bug #: 4554
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::inputImage): null check
        (KCanvasFEBlendQuartz::getCIFilter): ditto
        (KCanvasFEColorMatrixQuartz::getCIFilter): ditto
        (KCanvasFEMergeQuartz::getCIFilter): ditto
        Added NULL checks to avoid throwing Obj-C exceptions from
        CoreImage either when rendering bad SVGs or in cases where
        we do not yet implement a certain SVG filter element.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4554

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4585
eseidel [Mon, 22 Aug 2005 18:43:30 +0000 (18:43 +0000)]
Bug #: 4585
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: darin
        * Scripts/run-webkit-tests: hides "expected actual diffs" links
        when they are not needed (for pixel-only failures)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4584

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4581
eseidel [Mon, 22 Aug 2005 18:24:48 +0000 (18:24 +0000)]
Bug #: 4581
Submitted by: eseidel
Reviewed by: darin
        * Scripts/run-webkit-tests: Added the ability to display more than
        just two images as part of the image-diff "slideshow".
        Added display of "-w3c.png" baseline images for SVG.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4581

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4580
eseidel [Mon, 22 Aug 2005 18:17:53 +0000 (18:17 +0000)]
Bug #: 4580
Submitted by: eseidel
Reviewed by: darin
        * ksvg2/impl/SVGScriptElementImpl.cpp:
        (SVGScriptElementImpl::executeScript):
        Added necessary Interpreter::lock()/unlock() calls to prevent
        assertion failure when loading SVGs with JavaScript.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4580

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4577
eseidel [Mon, 22 Aug 2005 18:13:45 +0000 (18:13 +0000)]
Bug #: 4577
Submitted by: eseidel
Reviewed by: darin
        * WebCore.xcodeproj/project.pbxproj:
        Applied Darin's nmedit workaround/build-speedup to WebCore+SVG.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4577

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4463
eseidel [Mon, 22 Aug 2005 10:45:15 +0000 (10:45 +0000)]
Bug #: 4463
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        * kcanvas/device/KRenderingPaintServerSolid.h:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (KRenderingPaintServerSolidQuartz::draw):
        * svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.png:
        * svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.png:
        Group opacity was doubly-applied.  This patch fixes that.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4463

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4553
eseidel [Mon, 22 Aug 2005 09:30:42 +0000 (09:30 +0000)]
Bug #: 4553
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/device/quartz/QuartzSupport.mm:
        (CGPathToCFStringApplierFunction): Fixed output for curves.
        * svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-path-01-b-expected.txt:
        Fixed output for curves and updated tests accordingly.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4553

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4550
eseidel [Mon, 22 Aug 2005 07:45:28 +0000 (07:45 +0000)]
Bug #: 4550
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::prepareFilter):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (KRenderingDeviceQuartz::filtersEnabled):
        (KRenderingDeviceQuartz::setFiltersEnabled):
        (KRenderingDeviceQuartz::hardwareRenderingEnabled):
        (KRenderingDeviceQuartz::setHardwareRenderingEnabled):
        Added ability to disable hardware rendering (for testing).
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4550

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * khtml/xml/xml_namespace_table.cpp: Removed this file that's been obsolete and
darin [Sun, 21 Aug 2005 02:21:42 +0000 (02:21 +0000)]
    * khtml/xml/xml_namespace_table.cpp: Removed this file that's been obsolete and
        unused for a while.
        * khtml/xml/xml_namespace_table.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSubmitted by: eseidel
eseidel [Sun, 21 Aug 2005 00:45:04 +0000 (00:45 +0000)]
Submitted by: eseidel
        * Scripts/run-webkit-tests:
        "build" fix after committing incorrect version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4542
eseidel [Sun, 21 Aug 2005 00:16:01 +0000 (00:16 +0000)]
Bug #: 4542
Submitted by: eseidel
Reviewed by: darin
        * DumpRenderTree/DumpRenderTree.m:
        (main): cleans up delegates
        (dumpRenderTree): closes CFString/CFURL leak
        * Scripts/run-webkit-tests:
        Adds --leaks option to run-webkit-tests
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4542

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Sat, 20 Aug 2005 16:27:39 +0000 (16:27 +0000)]
    Reviewed by Darin Adler.

        - WebKit part of fix for
        <rdar://problem/3977607> ER: Safari should check framework versions at launch

        * WebView.subproj/WebViewPrivate.h:
        * WebView.subproj/WebView.m:
        (+[WebView _minimumRequiredSafariBuildNumber]):
        new method, returns the minimum build number of Safari that this WebKit is
        willing to work with. (The Safari version has to be new enough to check
        for this value in order for this to have any effect.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by rjw
justing [Sat, 20 Aug 2005 01:13:49 +0000 (01:13 +0000)]
    Reviewed by rjw

        The boolean justOpenedForTargetedLink is never used to determine a course of action.
        It was added long ago for findOrCreateFramedNamed, which has since been removed.

        * WebView.subproj/WebDataSource.m:
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _loadDataSource:withLoadType:formState:]):
        * WebView.subproj/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Fri, 19 Aug 2005 23:58:28 +0000 (23:58 +0000)]
    Reviewed by Darin.
        Landed by David Harrison.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4475
          <noscript>, <noframes>, <nolayer> and <noembed> elements should be in the DOM

        Test cases added:
        * layout-tests/fast/dom/no-elements-expected.txt: Added.
        * layout-tests/fast/dom/no-elements.html: Added.

        * khtml/html/html_elementimpl.cpp:
        (blockTagList):
        Add noembed and nolayer to the list of block tags.

        * khtml/html/htmlparser.cpp:
        (HTMLParser::noembedCreateErrorCheck):
        (HTMLParser::noframesCreateErrorCheck):
        (HTMLParser::noscriptCreateErrorCheck):
        (HTMLParser::nolayerCreateErrorCheck):
        Make sure these elements are created, but that they won't have any children.
        (Except for <noscript> when JavaScript is turned off).

        * layout-tests/dom/html/level2/html/HTMLElement113-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement114-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement142-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement143-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement26-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement27-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement55-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement56-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement84-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLElement85-expected.txt:
        These tests pass now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
harrison [Fri, 19 Aug 2005 23:38:40 +0000 (23:38 +0000)]
    Reviewed by Maciej.
        Landed by David Harrison.

        Test cases added: Manual test because Darin saw no way to exercise the hit testing code from JavaScript.
manual-tests/onclick_in_noncontent.html: Added.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3662
          onClick event for TD element doesn't fire unless its contents are clicked

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::nodeAtPoint):
        Take the border extra into account when hit testing just as we do when
        painting the background of a table cell. OK for other renderers because
        they have a border extra of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Fri, 19 Aug 2005 23:09:20 +0000 (23:09 +0000)]
    Reviewed by Darin.
        Landed by David Harrison.

        Test cases added: None.  Fixes existing tests.

        * khtml/ecma/kjs_dom.cpp:
        Attribute values are writable

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createAttributeNS):
        Update for new AttrImpl constructor.

        * khtml/xml/dom_elementimpl.cpp:
        (AttributeImpl::allocateImpl):
        Update for new AttrImpl constructor.

        (AttrImpl::AttrImpl):
        Initialize m_ignoreChildCount to 0. If createTextChild.
        is true, create a child text node with the contents
        of the attribute value.

        (AttrImpl::setValue):
        Remove all children and create a new text node with the contents
        of the attribute value.

        (AttrImpl::cloneNode):
        Make sure to clone any children.

        (AttrImpl::childrenChanged):
        If m_ignoreChildrenChanged is 0, update the attribute value.

        * khtml/xml/dom_elementimpl.h:
        Add childrenChanged, update AttrImpl constructor and
        add m_ignoreChildrenChanged to AttrImpl.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::normalize):
        If an element has attributes, make sure to normalize them.

        * layout-tests/dom/html/level1/core/hc_attrappendchild1-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrappendchild3-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrappendchild6-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrchildnodes1-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrchildnodes2-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrclonenode1-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrcreatetextnode-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrfirstchild-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrhaschildnodes-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrlastchild-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrnormalize-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrremovechild1-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrreplacechild1-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrreplacechild2-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrsetvalue1-expected.txt:
        * layout-tests/dom/html/level1/core/hc_attrsetvalue2-expected.txt:
        * layout-tests/dom/html/level1/core/hc_elementnormalize2-expected.txt:
        These tests pass now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Fri, 19 Aug 2005 22:29:54 +0000 (22:29 +0000)]
    Reviewed by Darin.
        Landed by David Harrison

- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=4523>
          REGRESSION assertion failure in Window::getValueProperty accessing window.konqueror

        Test cases added: N/A for this code removal

        Remove all traces of the konqueror property

        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * khtml/ecma/kjs_window.h:
        (KJS::Window::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
harrison [Fri, 19 Aug 2005 22:07:42 +0000 (22:07 +0000)]
    Reviewed by Darin
        Landed by David Harrison

- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=4379>
          negative margins allowed where they should not

        Test cases added:
layout-tests/fast/block/margin-collapse/104.html: Added.
layout-tests/fast/block/margin-collapse/104-expected.txt: Added.

        * khtml/rendering/render_box.cpp:
        (RenderBox::calcHorizontalMargins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4459
eseidel [Fri, 19 Aug 2005 22:06:02 +0000 (22:06 +0000)]
Bug #: 4459
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/KCanvasContainer.cpp:
        (KCanvasContainer::bbox): avoid unnecessary computation.
        (KCanvasContainer::collisions):
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (KCanvasItemQuartz::draw):
        (KCanvasItemQuartz::hitsPath): use untranslated point
        * svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        Performance improvements to bbox and hit-testing fix.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4459

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: 4529
eseidel [Fri, 19 Aug 2005 21:37:41 +0000 (21:37 +0000)]
Bug #: 4529
Submitted by: eseidel
Reviewed by: darin
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (cgGradientCallback):
        Fixes forgotten memcopy.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4529

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Fri, 19 Aug 2005 20:24:17 +0000 (20:24 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4435
          speed up JavaScript by tweaking the Identifier class

        * kjs/identifier.h: Add a new global nullIdentifier and make Identifier::null a function
        that returns it.
        * kjs/identifier.cpp: (KJS::Identifier::init): Initialize a global for the null identifier
        as well as all the other globals for special identifiers.

        * kjs/ustring.h: (KJS::UString::UString): Make this empty constructor inline.
        * kjs/ustring.cpp: Remove the old non-inline version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
darin [Fri, 19 Aug 2005 17:58:05 +0000 (17:58 +0000)]
    Reviewed by John.

        * English.lproj/Localizable.strings: Updated to include a new localizable string
        that was added a long while back. Apprently no one has run into the code using
        this string, because if they had, they'd have seen an assert.
        * English.lproj/StringsNotToBeLocalized.txt: Updated for various recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Fri, 19 Aug 2005 17:15:24 +0000 (17:15 +0000)]
    Reviewed by Darin.

        * Scripts/cvs-create-patch: Add an --include-unknowns option that will cause
        new files to be included in the patch even without "cvs add".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - remove this test, I disabled it in my last checkin
vicki [Fri, 19 Aug 2005 17:10:16 +0000 (17:10 +0000)]
- remove this test, I disabled it in my last checkin

        * layout-tests/dom/html/level2/html/HTMLFormElement10.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
vicki [Fri, 19 Aug 2005 17:01:40 +0000 (17:01 +0000)]
    Reviewed by Geoff.

        - fixed <rdar://problem/4223107> frame tests in layout-tests/dom/html/level2/html
        have empty expected results

        * layout-tests/dom/html/level2/html/selfhtml.js: wait until done before
        dumping the render tree

        * layout-tests/dom/html/level2/html/HTMLFormElement10.html-disabled: Disable this
        test for now - its causing all tests after it to dump the render tree, even though
        dumpAsText is enabled

        Update expected results for these tests:

        * layout-tests/dom/html/level2/html/HTMLFrameElement01-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameElement02-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameElement03-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameElement04-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameElement05-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameElement06-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameElement07-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameElement08-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameSetElement01-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLFrameSetElement02-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement01-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement02-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement03-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement04-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement05-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement06-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement07-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement08-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement09-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLIFrameElement10-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Fri, 19 Aug 2005 16:27:01 +0000 (16:27 +0000)]
    Reviewed by Maciej.
        Landed by Darin.

- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3301>
innerHTML does not work for xhtml documents.

        Test cases added:
layout-tests/fast/dom/set-innerHTML.xhtml: Added.
layout-tests/fast/dom/set-innerHTML-expected.txt: Added.

        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::createContextualFragment):
Call parseXMLDocumentFragment if we're an xml document.

        * khtml/xml/xml_tokenizer.cpp:
        (khtml::XMLTokenizer::pushNamespaces):
New function that takes an element.

        (khtml::XMLTokenizer::XMLTokenizer):
New constructor that takes a DocumentFragmentImpl and fills it.

        (khtml::parseXMLDocumentFragment):
New function that parses a document fragment.

        (khtml::XMLNamespaceStack::pushNamespaces):
New function that takes an element and pushes namespaces based on its
xmlns attributes.

        * khtml/xml/xml_tokenizer.h:
Add parseXMLDocumentFragment declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/cvs-apply: Fix to not garble patches that are mix of cvs-style and
darin [Fri, 19 Aug 2005 16:09:58 +0000 (16:09 +0000)]
    * Scripts/cvs-apply: Fix to not garble patches that are mix of cvs-style and
        non-cvs-generated patches. Anders has been creating these, so it's bad that
        the script can't handle them.
        * Scripts/cvs-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Fri, 19 Aug 2005 16:01:56 +0000 (16:01 +0000)]
    Reviewed by Maciej.
        Revised and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4474
          REGRESSION: Crash when using in-place operator on uninitialized array element

        * kjs/nodes.cpp:
        (AssignResolveNode::evaluate): Remove unneeded "isSet" assertion.
        (AssignBracketNode::evaluate): Replace code that tested "isSet" with code that
        tests the return value of getPropertySlot.

        * kjs/property_slot.h: Removed unneeded "isSet" function. Property slots are
        either uninitialized or set. There's no "initialized and not set" state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Checked "Inline Functions Hidden" box
adele [Fri, 19 Aug 2005 01:39:37 +0000 (01:39 +0000)]
    Checked "Inline Functions Hidden" box

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/webkitdirs.pm: Fix version checking to work on Xcode versions with
darin [Thu, 18 Aug 2005 17:45:52 +0000 (17:45 +0000)]
    * Scripts/webkitdirs.pm: Fix version checking to work on Xcode versions with
        "." in them -- based on complaint by someone here at Apple.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Thu, 18 Aug 2005 08:33:49 +0000 (08:33 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        * Scripts/run-webkit-tests:
        Made --svg imply --pixel-tests (pixel tests on-by-default for svg).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug #: none
eseidel [Thu, 18 Aug 2005 08:33:36 +0000 (08:33 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none (mjs acknowledged change)
        No review needed, affects only SVGSupport.

        Test cases added:
        * svg-tests/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/coords-units-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/coords-units-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/ext-TestComic-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/ext-TestComic-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-color-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-color-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/linkingCircle-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/linkingCircle-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/linkingToc-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/linkingToc-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-04-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-04-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/rects-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/rects-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/rects_b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/rects_b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-align-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-align-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-align-02-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-align-02-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-align-03-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-align-03-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-intro-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-intro-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-tref-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-tref-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-ws-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/text-ws-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/toc-sv-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/toc-sv-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/Resources/toc-svcmp-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/Resources/toc-svcmp-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-05-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-09-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-09-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-10-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-10-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-11-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-11-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-12-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-13-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-14-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-15-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-15-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-16-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-17-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-17-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-18-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-18-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-19-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-19-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-20-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-20-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-21-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-21-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-23-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-24-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-25-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-25-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-26-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-27-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-27-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-29-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/color-prof-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/color-prof-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/color-prop-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/color-prop-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/color-prop-02-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/color-prop-02-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/color-prop-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/color-prop-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-05-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-06-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-units-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-units-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-units-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-viewattr-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-composite-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-displace-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-image-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-offset-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/filters-tile-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/interact-dom-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/interact-dom-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/interact-events-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/interact-order-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/interact-order-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/interact-order-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/interact-order-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/interact-order-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/interact-zoom-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/linking-a-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/linking-uri-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/linking-uri-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/linking-uri-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/linking-uri-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/masking-mask-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-04-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-05-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/masking-path-05-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-fill-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-marker-01-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-marker-02-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-render-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-render-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-05-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-06-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-07-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-04-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-05-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-06-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-07-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-08-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-groups-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/render-groups-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/shapes-circle-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/shapes-line-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/shapes-line-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/shapes-polygon-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/shapes-polygon-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/shapes-polyline-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-cond-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-cond-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-cond-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-defs-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-frag-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-group-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-group-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-group-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-group-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-03-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-05-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-image-05-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/styling-css-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/styling-css-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/styling-css-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/styling-css-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/styling-css-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/styling-pres-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-align-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-align-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-align-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-align-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-align-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-align-04-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-align-05-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-align-06-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-altglyph-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-altglyph-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-deco-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-fonts-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-fonts-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-fonts-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-path-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-path-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-spacing-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-spacing-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-text-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-text-03-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-tref-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-tselect-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-tselect-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-tspan-01-b-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-ws-01-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-ws-01-t-expected.png: Added.
        * svg-tests/W3C-SVG-1.1/text-ws-02-t-expected.checksum: Added.
        * svg-tests/W3C-SVG-1.1/text-ws-02-t-expected.png: Added.
        Add pixel test results for SVG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - add file that I forgot in the last checkin
mjs [Thu, 18 Aug 2005 06:17:03 +0000 (06:17 +0000)]
    - add file that I forgot in the last checkin

        * DumpRenderTree/ImageDiff.m: Added.
        (main):
        (getImageFromStdin):
        (compareImages):
        (getDifferenceBitmap):
        (computePercentageDifferent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Changes by Ben Lamonica and Eric Seidel, reviewed mostly by Eric and
mjs [Thu, 18 Aug 2005 05:59:07 +0000 (05:59 +0000)]
    Changes by Ben Lamonica and Eric Seidel, reviewed mostly by Eric and
somewhat by me, and also tweaked by me a little bit.

- better support for pixel-dumping
- use checksums of the images so the tests are fast
- change output format to make the tests run faster
- don't dump pixel results for tests that dump as text

        * DumpKCanvasTree/DumpKCanvasTree.m:
        (main):
        (dumpRenderTree):
        (md5HashStringForBitmap):
        (dumpPixelTests):
        (constrainSizeToMaximum):
        (getBitmapImageRepForSVGDocument):
        * DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/DumpRenderTree.m:
        (main):
        (dump):
        (dumpRenderTree):
        (md5HashStringForBitmap):
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Thu, 18 Aug 2005 04:23:11 +0000 (04:23 +0000)]
    Reviewed by Darin.

        * layout-tests/fast/css/acid2.html: Replaced nonexistent remote URL that takes
a very long time to time out, with a nonexistent local URL.

        * kwq/KWQRenderTreeDebug.cpp:
        (externalRepresentation): Remove hack to turn off scrollbars.

- Updated many test results now that the layout tests properly do scrollbars when
appropriate

        * layout-tests/css1/basic/comments-expected.txt:
        * layout-tests/css1/basic/containment-expected.txt:
        * layout-tests/css1/basic/id_as_selector-expected.txt:
        * layout-tests/css1/basic/inheritance-expected.txt:
        * layout-tests/css1/box_properties/border-expected.txt:
        * layout-tests/css1/box_properties/border_bottom-expected.txt:
        * layout-tests/css1/box_properties/border_bottom_width-expected.txt:
        * layout-tests/css1/box_properties/border_left-expected.txt:
        * layout-tests/css1/box_properties/border_left_width-expected.txt:
        * layout-tests/css1/box_properties/border_right_inline-expected.txt:
        * layout-tests/css1/box_properties/border_right_width-expected.txt:
        * layout-tests/css1/box_properties/border_style-expected.txt:
        * layout-tests/css1/box_properties/border_top-expected.txt:
        * layout-tests/css1/box_properties/border_top_width-expected.txt:
        * layout-tests/css1/box_properties/border_width-expected.txt:
        * layout-tests/css1/box_properties/clear-expected.txt:
        * layout-tests/css1/box_properties/clear_float-expected.txt:
        * layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
        * layout-tests/css1/box_properties/float_margin-expected.txt:
        * layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
        * layout-tests/css1/box_properties/height-expected.txt:
        * layout-tests/css1/box_properties/margin-expected.txt:
        * layout-tests/css1/box_properties/margin_bottom-expected.txt:
        * layout-tests/css1/box_properties/margin_inline-expected.txt:
        * layout-tests/css1/box_properties/margin_left-expected.txt:
        * layout-tests/css1/box_properties/margin_right-expected.txt:
        * layout-tests/css1/box_properties/margin_top-expected.txt:
        * layout-tests/css1/box_properties/padding-expected.txt:
        * layout-tests/css1/box_properties/padding_bottom-expected.txt:
        * layout-tests/css1/box_properties/padding_inline-expected.txt:
        * layout-tests/css1/box_properties/padding_left-expected.txt:
        * layout-tests/css1/box_properties/padding_right-expected.txt:
        * layout-tests/css1/box_properties/padding_top-expected.txt:
        * layout-tests/css1/box_properties/width-expected.txt:
        * layout-tests/css1/cascade/cascade_order-expected.txt:
        * layout-tests/css1/classification/display-expected.txt:
        * layout-tests/css1/classification/list_style_type-expected.txt:
        * layout-tests/css1/classification/white_space-expected.txt:
        * layout-tests/css1/color_and_background/background-expected.txt:
        * layout-tests/css1/color_and_background/background_attachment-expected.txt:
        * layout-tests/css1/color_and_background/background_position-expected.txt:
        * layout-tests/css1/color_and_background/background_repeat-expected.txt:
        * layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
        * layout-tests/css1/font_properties/font-expected.txt:
        * layout-tests/css1/font_properties/font_family-expected.txt:
        * layout-tests/css1/font_properties/font_size-expected.txt:
        * layout-tests/css1/font_properties/font_weight-expected.txt:
        * layout-tests/css1/formatting_model/floating_elements-expected.txt:
        * layout-tests/css1/formatting_model/height_of_lines-expected.txt:
        * layout-tests/css1/formatting_model/horizontal_formatting-expected.txt:
        * layout-tests/css1/formatting_model/inline_elements-expected.txt:
        * layout-tests/css1/formatting_model/replaced_elements-expected.txt:
        * layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
        * layout-tests/css1/pseudo/anchor-expected.txt:
        * layout-tests/css1/pseudo/firstletter-expected.txt:
        * layout-tests/css1/pseudo/firstline-expected.txt:
        * layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
        * layout-tests/css1/text_properties/letter_spacing-expected.txt:
        * layout-tests/css1/text_properties/line_height-expected.txt:
        * layout-tests/css1/text_properties/text-transCapitalize-expected.txt:
        * layout-tests/css1/text_properties/text_decoration-expected.txt:
        * layout-tests/css1/text_properties/text_indent-expected.txt:
        * layout-tests/css1/text_properties/text_transform-expected.txt:
        * layout-tests/css1/text_properties/vertical_align-expected.txt:
        * layout-tests/css1/text_properties/word_spacing-expected.txt:
        * layout-tests/css1/units/color_units-expected.txt:
        * layout-tests/css1/units/length_units-expected.txt:
        * layout-tests/dom/html/level2/html/HTMLBaseElement02-expected.txt:
        * layout-tests/editing/inserting/insert-div-023-expected.txt:
        * layout-tests/editing/selection/select-all-001-expected.txt:
        * layout-tests/editing/selection/select-all-002-expected.txt:
        * layout-tests/editing/selection/select-all-003-expected.txt:
        * layout-tests/editing/selection/select-all-004-expected.txt:
        * layout-tests/editing/selection/unrendered-001-expected.txt:
        * layout-tests/editing/selection/unrendered-002-expected.txt:
        * layout-tests/editing/selection/unrendered-003-expected.txt:
        * layout-tests/editing/selection/unrendered-004-expected.txt:
        * layout-tests/editing/selection/unrendered-005-expected.txt:
        * layout-tests/fast/block/basic/013-expected.txt:
        * layout-tests/fast/block/basic/016-expected.txt:
        * layout-tests/fast/block/float/008-expected.txt:
        * layout-tests/fast/block/float/013-expected.txt:
        * layout-tests/fast/block/float/019-expected.txt:
        * layout-tests/fast/block/float/021-expected.txt:
        * layout-tests/fast/block/float/025-expected.txt:
        * layout-tests/fast/block/float/026-expected.txt:
        * layout-tests/fast/block/float/027-expected.txt:
        * layout-tests/fast/block/float/028-expected.txt:
        * layout-tests/fast/block/float/032-expected.txt:
        * layout-tests/fast/block/float/033-expected.txt:
        * layout-tests/fast/block/margin-collapse/103-expected.txt:
        * layout-tests/fast/block/positioning/047-expected.txt:
        * layout-tests/fast/block/positioning/051-expected.txt:
        * layout-tests/fast/block/positioning/055-expected.txt:
        * layout-tests/fast/block/positioning/auto/007-expected.txt:
        * layout-tests/fast/css/005-expected.txt:
        * layout-tests/fast/css/MarqueeLayoutTest-expected.txt:
        * layout-tests/fast/css/word-space-extra-expected.txt:
        * layout-tests/fast/dom/attr_dead_doc-expected.txt:
        * layout-tests/fast/dom/features-expected.txt:
        * layout-tests/fast/dynamic/008-expected.txt:
        * layout-tests/fast/dynamic/flash-replacement-test-expected.txt:
        * layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
        * layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
        * layout-tests/fast/flexbox/016-expected.txt:
        * layout-tests/fast/forms/form-element-geometry-expected.txt:
        * layout-tests/fast/frames/001-expected.txt:
        * layout-tests/fast/frames/002-expected.txt:
        * layout-tests/fast/frames/contentWindow_Frame-expected.txt:
        * layout-tests/fast/frames/contentWindow_iFrame-expected.txt:
        * layout-tests/fast/frames/empty-frame-src-expected.txt:
        * layout-tests/fast/frames/frameElement-frame-expected.txt:
        * layout-tests/fast/frames/frameElement-iframe-expected.txt:
        * layout-tests/fast/frames/invalid-expected.txt:
        * layout-tests/fast/frames/valid-expected.txt:
        * layout-tests/fast/inline-block/003-expected.txt:
        * layout-tests/fast/js/window-object-cross-frame-calls-expected.txt:
        * layout-tests/fast/lists/008-expected.txt:
        * layout-tests/fast/replaced/005-expected.txt:
        * layout-tests/fast/replaced/007-expected.txt:
        * layout-tests/fast/selectors/166-expected.txt:
        * layout-tests/fast/table/023-expected.txt:
        * layout-tests/fast/table/034-expected.txt:
        * layout-tests/fast/table/040-expected.txt:
        * layout-tests/fast/table/border-collapsing/004-expected.txt:
        * layout-tests/fast/table/height-percent-test-expected.txt:
        * layout-tests/fast/table/wide-colspan-expected.txt:
        * layout-tests/fast/table/wide-column-expected.txt:
        * layout-tests/fast/text/whitespace/024-expected.txt:
        * layout-tests/fast/tokenizer/004-expected.txt:
        * layout-tests/traversal/tree-walker-004-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
bdakin [Thu, 18 Aug 2005 00:31:23 +0000 (00:31 +0000)]
    Reviewed by Maciej

        Test cases added: (NONE)

This is a fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4499
which describes a memory leak that happens on bugzilla after
searching for all open WebKit bugs.

        * kwq/KWQArrayImpl.mm:
        (KWQArrayImpl::resize): When resizing to 0, free the old data after setting it
to NULL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Thu, 18 Aug 2005 00:25:04 +0000 (00:25 +0000)]
    Reviewed by Darin.

- fix mysterious CGImageSource error message and possibly crash on layout tests.

        * WebView.subproj/WebMainResourceLoader.m:
        (-[WebMainResourceLoader receivedError:]): Retain the data source since it may
prematurely self-destruct otherwise.
        (-[WebMainResourceLoader cancelWithError:]): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by darin, adele
justing [Thu, 18 Aug 2005 00:03:57 +0000 (00:03 +0000)]
    Reviewed by darin, adele

        Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed
            A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
            was not reset to true, preventing later layouts from occuring.

        * khtml/khtmlview.cpp:
        (KHTMLView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and landed by Darin.
darin [Wed, 17 Aug 2005 21:08:18 +0000 (21:08 +0000)]
    Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4491
          DOM L2 Events tests using addEventListener broken

        * layout-tests/dom/html/level2/events/dispatchEvent08.js: Updated.
        * layout-tests/dom/html/level2/events/dispatchEvent09.js: Ditto.
        * layout-tests/dom/html/level2/events/dispatchEvent10.js: Ditto.
        * layout-tests/dom/html/level2/events/dispatchEvent11.js: Ditto.
        * layout-tests/dom/html/level2/events/dispatchEvent12.js: Ditto.
        * layout-tests/dom/html/level2/events/dispatchEvent13.js: Ditto.

        * layout-tests/dom/html/level2/events/dispatchEvent11-expected.txt: Now succeeds.
        * layout-tests/dom/html/level2/events/dispatchEvent12-expected.txt: Now fails.
        * layout-tests/dom/html/level2/events/dispatchEvent13-expected.txt: Now succeeds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by rjw
justing [Wed, 17 Aug 2005 20:12:15 +0000 (20:12 +0000)]
    Reviewed by rjw

        Addresses <rdar://problem/4192534> new frame load delegate SPI needed for Dashboard
            Call handledOnloadEvents bridge method after load events are dispatched in a frame

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::implicitClose):
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::handledOnloadEvents):
        * kwq/WebCoreBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by rjw
justing [Wed, 17 Aug 2005 20:11:00 +0000 (20:11 +0000)]
    Reviewed by rjw

        Addresses <rdar://problem/4192534> new frame load delegate SPI needed for Dashboard
            Added handledOnloadEvents delegate method (private for now)

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge handledOnloadEvents]):
        * WebView.subproj/WebDefaultFrameLoadDelegate.m:
        (-[WebDefaultFrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _handledOnloadEvents]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff Garen.
sullivan [Wed, 17 Aug 2005 18:14:38 +0000 (18:14 +0000)]
    Reviewed by Geoff Garen.

        - fixed <rdar://problem/4219817> Particular icon database + bookmarks + history crashes Safari on launch

        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase releaseIconForURL:]):
        Move line that might remove last reference to iconURL to the end of the block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
vicki [Wed, 17 Aug 2005 08:07:32 +0000 (08:07 +0000)]
    Reviewed by Maciej.

        - fix <rdar://problem/4175734> Crash trying to retrieve data with
        XMLHttpRequest with Content-Type: empty

        Test cases added:
* manual-tests/xmlhttprequest-contenttype-empty.html: Added.

* khtml/ecma/xmlhttprequest.cpp:
(KJS::XMLHttpRequest::getValueProperty): allow empty entries when splitting to
create the mime type string, otherwise we access a garbage pointer when stripping
whitespace

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Trey.
darin [Wed, 17 Aug 2005 05:01:29 +0000 (05:01 +0000)]
    Reviewed by Trey.

- improved fix for <rdar://problem/4211631>, tiled images tiled incorrectly when printing or
  drawing offscreen

        * WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]):
        Fix pattern phase origin to use the image tile origin, which is clearly right, rather than
        the image rectangle, which isn't right, but often is the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Wed, 17 Aug 2005 04:06:09 +0000 (04:06 +0000)]
    Reviewed by Maciej.

        - fixed bug that was causing a crash when running layout tests

        * khtml/ecma/kjs_binding.h: Remove unused deleteDOMObject.
        * khtml/ecma/kjs_binding.cpp:
        (KJS::ScriptInterpreter::forgetDOMObject): Move code in here from forgetDOMObject.
        (KJS::ScriptInterpreter::getDOMNodeForDocument): For the null-document case, use the general
        DOM objects map rather than a per-document map.
        (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto.
        (KJS::ScriptInterpreter::putDOMNodeForDocument): Ditto.
        (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Assert that document is not null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
adele [Wed, 17 Aug 2005 01:29:10 +0000 (01:29 +0000)]
    Reviewed by John.

        - fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms

        When the setShowsURLsInToolTips preference is set, we will display a tooltip containing
        the form's url when you mouse over a submit button.

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Wed, 17 Aug 2005 01:07:26 +0000 (01:07 +0000)]
    Reviewed by Geoff.

        - changed main_thread_malloc so we don't have two conflicting versions of the same function
          This fixes a crash I was seeing running the WebKit tests.

        * khtml/misc/main_thread_malloc.h: Took out all the ifdefs from this header.
        * khtml/misc/main_thread_malloc.cpp: Added non-NDEBUG versions of the functions that just call
        the system malloc, and put the NDEBUG versions in an #else.

        * WebCore-tests.exp: Export the new stuff so the tests still work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Wed, 17 Aug 2005 01:00:00 +0000 (01:00 +0000)]
    Reviewed by Geoff.

        - fixed crash in one of the JavaScript tests (introduced by my throwError change)

        * kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded): Check if the exception is an
        object before setting the file and line number properties on it. Something to think
        about in the future -- do we really want to do this on any object that's thrown?
        How about limiting it to error objects that were created by the JavaScript engine?

        - changed kjs_fast_malloc so we don't have two conflicting versions of the same function

        * kjs/fast_malloc.h: Took out all the ifdefs from this header.
        * kjs/fast_malloc.cpp: Added non-NDEBUG versions of the functions that just call
        the system malloc, and put the NDEBUG versions in an #else.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
mjs [Tue, 16 Aug 2005 23:57:07 +0000 (23:57 +0000)]
    Reviewed by John.

- fixed leak of HTML collection info - this can build up to
hundreds of leaks pretty quickly

http://bugzilla.opendarwin.org/show_bug.cgi?id=4450

        * khtml/html/html_miscimpl.cpp:
        (DOM::HTMLCollectionImpl::HTMLCollectionImpl): Initialize new
m_ownsInfo member.
        (DOM::HTMLCollectionImpl::~HTMLCollectionImpl): Delete info if
owned.
        (DOM::HTMLCollectionImpl::resetCollectionInfo): When creating new
info, indicate that it's owned.
        * khtml/html/html_miscimpl.h: Declare new member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Tue, 16 Aug 2005 22:01:31 +0000 (22:01 +0000)]
    Reviewed by Geoff.

        - clean up exported symbols that are not in a "KJS" namespace

        * bindings/NP_jsobject.cpp: (identiferFromNPIdentifier): Marked this function static
        so it no longer has external linkage.
        * bindings/c/c_utility.h: Put all this stuff inside the KJS namespace.
        * bindings/c/c_utility.cpp: Also marked some globals static so they don't have external
        linkage; not as important given the namespace.
        * bindings/npruntime.cpp: Marked functions static so they no longer have internal linkage.
        Also removed unused _NPN_SetExceptionWithUTF8 function (not in header, had C++ linkage!).

        * bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Call KJS_GetCreatedJavaVMs
        using the soft linking header, instead of calling the JNI call. This allows processes
        to link both JavaScriptCore and JavaVM without a symbol conflict.
        * bindings/softlinking.c:
        (loadFramework): Marked this function static so it no longer has external linkage.
        (getFunctionPointer): Ditto.
        (KJS_GetCreatedJavaVMs): Renamed this so it has a KJS prefix.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added softlinking.h.
        * bindings/softlinking.h: Added.

        * kjs/nodes2string.cpp: (streamAssignmentOperatorTo): Marked this function static so it
        no longer has external linkage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/4119646> assertion failure in DOM::Position::upstream at...
harrison [Tue, 16 Aug 2005 21:53:53 +0000 (21:53 +0000)]
    <rdar://problem/4119646> assertion failure in DOM::Position::upstream at babelfish.com
        <rdar://problem/4125949> Assertion failure clicking outside of textarea in page containing only textarea

        Removed asserts that did not account for iterating from a nested node to its parent.

        Test cases added: n/a for assert removal

        * khtml/xml/dom_position.cpp:
        (DOM::Position::upstream):
        (DOM::Position::downstream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Tue, 16 Aug 2005 19:03:35 +0000 (19:03 +0000)]
WebCore:

        Reviewed by Beth Dakin.

        - removed Panther-only code that was not being compiled and was
          simply "bit-rotting"

        * WebCorePrefix.h:
        * khtml/misc/loader.cpp:
        (CachedImage::CachedImage):
        * khtml/rendering/render_canvasimage.cpp:
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject roleDescription]):
        (-[KWQAccObject accessibilityAttributeNames]):
        (-[KWQAccObject accessibilityActionDescription:]):
        (-[KWQAccObject accessibilityAttributeValue:]):
        (-[KWQAccObject accessibilityIsAttributeSettable:]):
        * kwq/KWQComboBox.mm:
        (QComboBox::QComboBox):
        * kwq/KWQFoundationExtras.h:
        (KWQCFAutorelease):
        * kwq/KWQPixmap.mm:
        (QPixmap::QPixmap):
        (QPixmap::receivedData):
        * kwq/KWQString.h:
        (QChar::direction):
        * kwq/KWQTextArea.mm:
        (-[KWQTextArea tile]):
        * kwq/KWQTextEdit.mm:
        (QTextEdit::setScrollBarModes):
        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController string]):
        * kwq/KWQTextUtilities.mm:
        (currentTextBreakLocaleID):
        * kwq/WebCoreScrollView.m:

WebKit:

        Reviewed by Beth Dakin.

        - removed Panther-only code that was not being compiled and was
          simply "bit-rotting"

        * Misc.subproj/WebFileDatabase.m:
        (-[WebFileDatabase _createLRUList:]):
        (+[WebFileDatabase _syncLoop:]):
        * Misc.subproj/WebKitErrors.m:
        (registerErrors):
        * Misc.subproj/WebNSObjectExtras.h:
        (WebCFAutorelease):
        * Misc.subproj/WebNSPasteboardExtras.m:
        (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
        * WebCoreSupport.subproj/WebImageData.h:
        * WebCoreSupport.subproj/WebImageDecodeItem.h:
        * WebCoreSupport.subproj/WebImageDecodeItem.m:
        * WebCoreSupport.subproj/WebImageDecoder.h:
        * WebCoreSupport.subproj/WebImageDecoder.m:
        (decoderThread):
        (startDecoderThread):
        * WebCoreSupport.subproj/WebKeyGeneration.cpp: Removed.
        * WebCoreSupport.subproj/WebKeyGeneration.h: Removed.
        * WebCoreSupport.subproj/WebKeyGenerator.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (getUncachedWidth):
        (_drawGlyphs):
        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory getBytes:fromTextMarker:length:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebKitPrefix.h:
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        (-[WebDataSource isLoading]):
        * WebView.subproj/WebDefaultContextMenuDelegate.m:
        (localizedMenuTitleFromAppKit):
        (-[WebDefaultUIDelegate menuItemWithTag:]):
        (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
        (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
        * WebView.subproj/WebFormDataStream.m:
        (formCanRead):
        (webSetHTTPBody):
        * WebView.subproj/WebFrameView.m:
        (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:chosePlainText:]):
        (-[WebHTMLView resourceForData:preferredFilename:]):
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[WebHTMLView validateUserInterfaceItem:]):
        (-[WebHTMLView _attributeStringFromDOMRange:]):
        (-[WebHTMLView toggleBaseWritingDirection:]):
        (-[WebHTMLView changeBaseWritingDirection:]):
        * WebView.subproj/WebPDFRepresentation.h:
        * WebView.subproj/WebPDFRepresentation.m:
        * WebView.subproj/WebPDFView.h:
        * WebView.subproj/WebPDFView.m:
        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences _systemCFStringEncoding]):
        * WebView.subproj/WebView.m:
        (-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix ChangeLog typo from my last checkin. Remove NONE from the layout-test section.
vicki [Tue, 16 Aug 2005 18:28:56 +0000 (18:28 +0000)]
Fix ChangeLog typo from my last checkin.  Remove NONE from the layout-test section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Tue, 16 Aug 2005 17:36:37 +0000 (17:36 +0000)]
WebCore:

        Reviewed by Beth Dakin.

        - removed some unnecessary code

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::imageFromRect): Remove code to call
        setAdditionalPatternPhase since that is no longer needed.

        * kwq/WebCoreGraphicsBridge.h: Remove unused setAdditionalPatternPhase,
        createRGBColorSpace, createGrayColorSpace, and createCMYKColorSpace methods.
        * kwq/WebCoreGraphicsBridge.m: Ditto.

WebKit:

        Reviewed by Beth Dakin.

        - removed some unnecessary code

        * WebCoreSupport.subproj/WebGraphicsBridge.h: Removed pattern-phase related field and methods.
        * WebCoreSupport.subproj/WebGraphicsBridge.m: Ditto.

        * WebCoreSupport.subproj/WebImageData.m: Tweaked formatting and removed some unused code
        inside #if and comments.

        * WebCoreSupport.subproj/WebImageRenderer.h: Removed USE_CGIMAGEREF (which is always true now).
        * WebCoreSupport.subproj/WebImageRenderer.m: Removed old non-CGImageRef code.

        * WebCoreSupport.subproj/WebImageRendererFactory.m:
        (-[WebImageRendererFactory imageRendererWithMIMEType:]): Removed non-USE_CGIMAGEREF code.
        (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): Ditto.
        (-[WebImageRendererFactory imageRendererWithSize:]): Ditto.
        (-[WebImageRendererFactory imageRendererWithName:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4445
eseidel [Tue, 16 Aug 2005 09:17:41 +0000 (09:17 +0000)]
Bug #: 4445
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/KCanvasItem.cpp:
        (KCanvasItem::bbox):
        (KCanvasItem::invalidate):
        Now caches both stroke and fill bboxes for better performance.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4445

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4431
eseidel [Tue, 16 Aug 2005 08:58:06 +0000 (08:58 +0000)]
Bug #: 4431
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/KCanvasContainer.cpp:
        (KCanvasContainer::needsTemporaryBuffer):
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        (KRenderingPaintServerSolid::opacity):
        * kcanvas/device/KRenderingPaintServerSolid.h:
        * kcanvas/device/KRenderingStyle.cpp:
        (KRenderingStyle::Private::Private):
        (KRenderingStyle::opacity):
        (KRenderingStyle::setOpacity):
        * kcanvas/device/KRenderingStyle.h:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (KCanvasContainerQuartz::draw):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (KRenderingPaintServerSolidQuartz::draw):
        (KRenderingPaintServerPatternQuartz::draw):
        * kcanvas/device/quartz/QuartzSupport.mm:
        (applyStyleToContext):
        * ksvg2/core/KCanvasRenderingStyle.cpp:
        (KCanvasRenderingStyle::opacity):
        (KCanvasRenderingStyle::setOpacity):
        * ksvg2/core/KCanvasRenderingStyle.h:
        Change all references to Opacity to use floats.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4431

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4453
eseidel [Tue, 16 Aug 2005 07:39:41 +0000 (07:39 +0000)]
Bug #: 4453
Submitted by: eseidel
Reviewed by: mjs
        * WebCore.xcodeproj/project.pbxproj: bison cleanup.
        * kdom/ecma/DOMLookup.h: now uses throwError
        * kdom/ecma/Ecma.cpp:
        (Ecma::~Ecma): now uses clearProperties
        * kdom/ecma/GlobalObject.cpp: now uses throwError
        (GlobalObject::clear): now uses clearProperties
        (GlobalObjectFunc::callAsFunction): now uses throwError
        Fixes necessary for WebCore+SVG after 4437.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4453

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
vicki [Tue, 16 Aug 2005 04:42:44 +0000 (04:42 +0000)]
    Reviewed by Maciej.

- fixed <rdar://problem/4094363> Can't re-open a window at capripalace.com website because
"close" fails on already-closed window

        Test cases added: (NONE)
        * manual-tests/close-on-closedWindow.html: Added.

        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getOwnPropertySlot): allow close calls on windows that have already been closed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin [Tue, 16 Aug 2005 00:47:46 +0000 (00:47 +0000)]
JavaScriptCore:

        Reviewed by Geoff.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4437
          clean up error creation with new throwError function

        * bindings/NP_jsobject.cpp:
        (_NPN_SetException):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_runtime.cpp:
        (JavaField::dispatchValueFromInstance):
        (JavaField::dispatchSetValueToInstance):
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject _initializeWithObjectImp:originExecutionContext:executionContext:]):
        (-[WebScriptObject _initWithObjectImp:originExecutionContext:executionContext:]):
        (+[WebScriptObject throwException:]):
        (-[WebScriptObject setException:]):
        (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
        * bindings/objc/objc_class.h:
        (KJS::Bindings::ObjcClass::~ObjcClass):
        (KJS::Bindings::ObjcClass::ObjcClass):
        (KJS::Bindings::ObjcClass::operator=):
        (KJS::Bindings::ObjcClass::constructorAt):
        (KJS::Bindings::ObjcClass::numConstructors):
        * bindings/objc/objc_header.h:
        * bindings/objc/objc_runtime.h:
        (KJS::Bindings::ObjcField::~ObjcField):
        (KJS::Bindings::ObjcField::ObjcField):
        (KJS::Bindings::ObjcField::operator=):
        (KJS::Bindings::ObjcMethod::ObjcMethod):
        (KJS::Bindings::ObjcMethod::~ObjcMethod):
        (KJS::Bindings::ObjcMethod::operator=):
        * bindings/objc/objc_runtime.mm:
        (ObjcField::valueFromInstance):
        (ObjcField::setValueToInstance):
        (ObjcArray::setValueAt):
        (ObjcArray::valueAt):
        * bindings/objc/objc_utility.h:
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::JSMethodNameToObjCMethodName):
        (KJS::Bindings::convertValueToObjcValue):
        (KJS::Bindings::convertNSStringToString):
        (KJS::Bindings::convertObjcValueToValue):
        (KJS::Bindings::objcValueTypeForType):
        (KJS::Bindings::createObjcInstanceForValue):
        (KJS::Bindings::throwError):
        * bindings/runtime.h:
        (KJS::Bindings::Parameter::~Parameter):
        (KJS::Bindings::Method::~Method):
        (KJS::Bindings::Instance::Instance):
        (KJS::Bindings::Instance::begin):
        (KJS::Bindings::Instance::end):
        (KJS::Bindings::Instance::getValueOfUndefinedField):
        (KJS::Bindings::Instance::supportsSetValueOfUndefinedField):
        (KJS::Bindings::Instance::setValueOfUndefinedField):
        (KJS::Bindings::Instance::valueOf):
        * bindings/runtime_array.cpp:
        (RuntimeArrayImp::put):
        * bindings/runtime_object.h:
        (KJS::RuntimeObjectImp::setInternalInstance):
        (KJS::RuntimeObjectImp::getInternalInstance):
        * kjs/array_object.cpp:
        (getProperty):
        (ArrayProtoFuncImp::callAsFunction):
        (ArrayObjectImp::construct):
        * kjs/bool_object.cpp:
        (BooleanProtoFuncImp::callAsFunction):
        * kjs/date_object.cpp:
        (KJS::DateProtoFuncImp::callAsFunction):
        * kjs/function.cpp:
        (KJS::decode):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/function_object.cpp:
        (FunctionProtoFuncImp::callAsFunction):
        (FunctionObjectImp::construct):
        * kjs/internal.cpp:
        (KJS::UndefinedImp::toObject):
        (KJS::NullImp::toObject):
        (KJS::InterpreterImp::evaluate):
        (KJS::InternalFunctionImp::hasInstance):
        * kjs/nodes.cpp:
        (Node::throwError):
        (substitute):
        (Node::setExceptionDetailsIfNeeded):
        (undefinedVariableError):
        (ProgramNode::ProgramNode):
        * kjs/number_object.cpp:
        (NumberProtoFuncImp::callAsFunction):
        * kjs/object.cpp:
        (KJS::ObjectImp::call):
        (KJS::ObjectImp::defaultValue):
        (KJS::Error::create):
        (KJS::throwError):
        * kjs/object.h:
        (KJS::ObjectImp::clearProperties):
        (KJS::ObjectImp::getPropertySlot):
        (KJS::ObjectImp::getOwnPropertySlot):
        * kjs/object_object.cpp:
        (ObjectProtoFuncImp::callAsFunction):
        * kjs/reference.cpp:
        (KJS::Reference::getBase):
        (KJS::Reference::getValue):
        (KJS::Reference::putValue):
        (KJS::Reference::deleteValue):
        * kjs/regexp_object.cpp:
        (RegExpProtoFuncImp::callAsFunction):
        (RegExpObjectImp::construct):
        * kjs/string_object.cpp:
        (StringProtoFuncImp::callAsFunction):

WebCore:

        Reviewed by Geoff.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4437
          clean up error creation with new throwError function

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::CSSStyleSelector):
        (khtml::parseUASheet):
        (khtml::CSSStyleSelector::initElementAndPseudoState):
        (khtml::checkPseudoState):
        (khtml::CSSStyleSelector::locateCousinList):
        (khtml::CSSStyleSelector::locateSharedStyle):
        (khtml::CSSStyleSelector::adjustRenderStyle):
        (khtml::CSSStyleSelector::checkOneSelector):
        (khtml::CSSRuleSet::addToRuleSet):
        (khtml::colorForCSSValue):
        (khtml::CSSStyleSelector::applyProperty):
        (khtml::CSSStyleSelector::mapBackgroundAttachment):
        (khtml::CSSStyleSelector::mapBackgroundImage):
        (khtml::CSSStyleSelector::mapBackgroundRepeat):
        (khtml::CSSStyleSelector::mapBackgroundXPosition):
        (khtml::CSSStyleSelector::mapBackgroundYPosition):
        (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
        * khtml/ecma/domparser.cpp:
        (KJS::DOMParserProtoFunc::callAsFunction):
        * khtml/ecma/kjs_binding.cpp:
        (KJS::ScriptInterpreter::putDOMObject):
        (KJS::ScriptInterpreter::putDOMNodeForDocument):
        (KJS::setDOMException):
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
        (KJS::DOMStyleSheetListFunc::callAsFunction):
        (KJS::KJS::DOMMediaListProtoFunc::callAsFunction):
        (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
        (KJS::DOMCSSRuleListFunc::callAsFunction):
        (KJS::DOMCSSRuleFunc::callAsFunction):
        (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction):
        (KJS::DOMCSSValueListFunc::callAsFunction):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction):
        (KJS::DOMNodeListFunc::callAsFunction):
        (KJS::DOMDocumentProtoFunc::callAsFunction):
        (KJS::DOMElementProtoFunc::callAsFunction):
        (KJS::DOMDOMImplementationProtoFunc::callAsFunction):
        (KJS::DOMNamedNodeMapProtoFunc::callAsFunction):
        (KJS::DOMCharacterDataProtoFunc::callAsFunction):
        (KJS::DOMTextProtoFunc::callAsFunction):
        * khtml/ecma/kjs_events.cpp:
        (KJS::DOMEventProtoFunc::callAsFunction):
        (KJS::DOMUIEventProtoFunc::callAsFunction):
        (KJS::DOMMouseEventProtoFunc::callAsFunction):
        (KJS::DOMKeyboardEventProtoFunc::callAsFunction):
        (KJS::DOMMutationEventProtoFunc::callAsFunction):
        (KJS::DOMWheelEventProtoFunc::callAsFunction):
        (KJS::ClipboardProtoFunc::callAsFunction):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLDocFunction::callAsFunction):
        (KJS::KJS::HTMLElementFunction::callAsFunction):
        (KJS::KJS::HTMLCollectionProtoFunc::callAsFunction):
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::Context2D::putValueProperty):
        (KJS::GradientFunction::callAsFunction):
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::NavigatorFunc::callAsFunction):
        * khtml/ecma/kjs_range.cpp:
        (KJS::DOMRangeProtoFunc::callAsFunction):
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::DOMNodeIteratorProtoFunc::callAsFunction):
        (KJS::DOMNodeFilterProtoFunc::callAsFunction):
        (KJS::DOMTreeWalkerProtoFunc::callAsFunction):
        * khtml/ecma/kjs_views.cpp:
        (KJS::DOMAbstractViewFunc::callAsFunction):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::interpreter):
        (KJS::Window::retrieveWindow):
        (KJS::Window::retrieveActive):
        (KJS::Window::isSafeScript):
        (KJS::Window::clear):
        (KJS::WindowFunc::callAsFunction):
        (KJS::ScheduledAction::execute):
        (KJS::WindowQObject::pauseTimeouts):
        (KJS::LocationFunc::callAsFunction):
        (KJS::Selection::toString):
        (KJS::SelectionFunc::callAsFunction):
        (KJS::HistoryFunc::callAsFunction):
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequestProtoFunc::callAsFunction):
        * khtml/ecma/xmlserializer.cpp:
        (KJS::XMLSerializerProtoFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
harrison [Mon, 15 Aug 2005 23:31:16 +0000 (23:31 +0000)]
    Reviewed by Darin.

        <rdar://problem/4202641> Line breaks do not happen inside whitespace:pre; word-wrap: break-word

        Test cases added: fast/text/whitespace/tab-character-basics.html

        Refined Dave's earlier patch for this bug to handle whitespace:pre that is not at the beginning of a line.

        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::findNextLineBreak):
        * layout-tests/fast/text/whitespace/tab-character-basics-expected.txt: Added.
        * layout-tests/fast/text/whitespace/tab-character-basics.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
darin [Mon, 15 Aug 2005 21:57:16 +0000 (21:57 +0000)]
    Reviewed by Justin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4324
          WebCore build does a slow "nmedit -s" step that's unnecessary

        * WebCore.xcodeproj/project.pbxproj: Stop using EXPORTED_SYMBOLS_FILE, since it does an
        unneccessary nmedit step that is particularly slow for WebCore. Instead, define
        WEBCORE_EXPORTED_SYMBOLS_FILE and put a flag into OTHER_LDFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
bdakin [Mon, 15 Aug 2005 21:29:00 +0000 (21:29 +0000)]
    Reviewed by Beth.

This is a fix for <rdar://problem/4211631> tiled images tiled incorrectly when printing or
drawing offscreen.

Cayenne found there was a problem when they were trying to take screen shots of widgets, and
it was ultimately a problem with the way we tile images. Darin was able to fix the problem
by replacing some confusing hacked code with CG calls.

        * WebCoreSupport.subproj/WebImageData.m:
        (-[WebImageData tileInRect:fromPoint:context:]):
        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebInternalImage tileInRect:fromPoint:context:]):
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawLineForMisspelling:withWidth:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
darin [Mon, 15 Aug 2005 20:37:10 +0000 (20:37 +0000)]
    Reviewed by Darin.

        * tests/mozilla/ecma_3/Date/15.9.5.5.js:
Remove the code which tests that Date.toLocaleString should be parsable
by Date.parse. That is not true according to the spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin [Mon, 15 Aug 2005 18:47:49 +0000 (18:47 +0000)]
    Reviewed by Geoff.

        * kjs/collector.cpp: (KJS::Collector::allocate): Use a local instead of a global in one
        more place; slight speedup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agotiny tiny ChangeLog formatting fix
darin [Mon, 15 Aug 2005 18:45:08 +0000 (18:45 +0000)]
tiny tiny ChangeLog formatting fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Mon, 15 Aug 2005 05:01:53 +0000 (05:01 +0000)]
    Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3429
          Text transformed with text-transform does not copy with transform applied

        Test cases added:
        * layout-tests/editing/pasteboard/paste-text-019-expected.txt: Added.
        * layout-tests/editing/pasteboard/paste-text-019.html: Added.

        * khtml/editing/visible_text.cpp:
        (khtml::TextIterator::handleTextNode): Use the DOMString from the RenderText, not the DOM text node.
        (khtml::TextIterator::handleTextBox): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed build of some unit tests
darin [Mon, 15 Aug 2005 04:58:51 +0000 (04:58 +0000)]
    - fixed build of some unit tests

        * khtml/misc/main_thread_malloc.h: We use functions from <stdlib.h> here in
        debug mode, so #include <stdlib.h>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 15 Aug 2005 04:36:51 +0000 (04:36 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4422
          QFont has mistake where it caches computed pitch value incorrectly

        * kwq/KWQFont.mm:
        (QFont::setFamily): Set _pitch to Unknown when setting _NSFont to nil.
        (QFont::setFirstFamily): Ditto.
        (QFont::setPixelSize): Ditto. Might be unneeded; it would be bad to have the same font
        with different pitch settings at different sizes. But better to be safe.
        (QFont::setWeight): Ditto. Same caveat.
        (QFont::setItalic): Ditto. Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Mon, 15 Aug 2005 04:31:09 +0000 (04:31 +0000)]
    Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3692
          Word-spacing doesn't work as expected

        Test cases added:
        * layout-tests/fast/css/word-space-extra-expected.txt: Added.
        * layout-tests/fast/css/word-space-extra.html: Added.

        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::constructLine):
        (khtml::RenderBlock::computeHorizontalPositionsForLine):
        (khtml::RenderBlock::findNextLineBreak):
        * khtml/rendering/font.cpp:
        (Font::drawText):
        * khtml/rendering/font.h:
        (khtml::Font::getWordSpacing):
        * khtml/rendering/render_line.cpp:
        (khtml::InlineFlowBox::placeBoxesHorizontally):
        * khtml/rendering/render_line.h:
        * khtml/rendering/render_text.cpp:
        (RenderText::widthFromCache):
        (RenderText::trimmedMinMaxWidth):
        (RenderText::calcMinMaxWidth):
        * khtml/rendering/render_text.h:
        (khtml::InlineTextBox::setStart):
        (khtml::InlineTextBox::setLen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated test cases for new editing delegate output
mjs [Mon, 15 Aug 2005 03:40:09 +0000 (03:40 +0000)]
    - updated test cases for new editing delegate output

        * layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3608430-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3608445-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3608462-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3775172-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3800834-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3857753-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3865854-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3928305-fix-expected.txt:
        * layout-tests/editing/deleting/delete-3959464-fix-expected.txt:
        * layout-tests/editing/deleting/delete-4038408-fix-expected.txt:
        * layout-tests/editing/deleting/delete-4083333-fix-expected.txt:
        * layout-tests/editing/deleting/delete-after-span-ws-001-expected.txt:
        * layout-tests/editing/deleting/delete-after-span-ws-002-expected.txt:
        * layout-tests/editing/deleting/delete-after-span-ws-003-expected.txt:
        * layout-tests/editing/deleting/delete-and-undo-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
        * layout-tests/editing/deleting/delete-block-contents-001-expected.txt:
        * layout-tests/editing/deleting/delete-block-contents-002-expected.txt:
        * layout-tests/editing/deleting/delete-block-contents-003-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-001-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-002-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-003-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-004-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-005-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-006-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-007-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-008-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-009-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-012-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-013-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-014-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-015-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-018-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-019-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-020-expected.txt:
        * layout-tests/editing/deleting/delete-block-merge-contents-021-expected.txt:
        * layout-tests/editing/deleting/delete-br-001-expected.txt:
        * layout-tests/editing/deleting/delete-br-002-expected.txt:
        * layout-tests/editing/deleting/delete-br-003-expected.txt:
        * layout-tests/editing/deleting/delete-br-004-expected.txt:
        * layout-tests/editing/deleting/delete-br-005-expected.txt:
        * layout-tests/editing/deleting/delete-br-006-expected.txt:
        * layout-tests/editing/deleting/delete-br-007-expected.txt:
        * layout-tests/editing/deleting/delete-br-008-expected.txt:
        * layout-tests/editing/deleting/delete-br-009-expected.txt:
        * layout-tests/editing/deleting/delete-br-010-expected.txt:
        * layout-tests/editing/deleting/delete-br-011-expected.txt:
        * layout-tests/editing/deleting/delete-character-001-expected.txt:
        * layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * layout-tests/editing/deleting/delete-image-001-expected.txt:
        * layout-tests/editing/deleting/delete-image-002-expected.txt:
        * layout-tests/editing/deleting/delete-image-003-expected.txt:
        * layout-tests/editing/deleting/delete-image-004-expected.txt:
        * layout-tests/editing/deleting/delete-leading-ws-001-expected.txt:
        * layout-tests/editing/deleting/delete-line-001-expected.txt:
        * layout-tests/editing/deleting/delete-line-002-expected.txt:
        * layout-tests/editing/deleting/delete-line-003-expected.txt:
        * layout-tests/editing/deleting/delete-line-004-expected.txt:
        * layout-tests/editing/deleting/delete-line-005-expected.txt:
        * layout-tests/editing/deleting/delete-line-006-expected.txt:
        * layout-tests/editing/deleting/delete-line-007-expected.txt:
        * layout-tests/editing/deleting/delete-line-008-expected.txt:
        * layout-tests/editing/deleting/delete-line-009-expected.txt:
        * layout-tests/editing/deleting/delete-line-010-expected.txt:
        * layout-tests/editing/deleting/delete-line-011-expected.txt:
        * layout-tests/editing/deleting/delete-line-012-expected.txt:
        * layout-tests/editing/deleting/delete-line-013-expected.txt:
        * layout-tests/editing/deleting/delete-line-014-expected.txt:
        * layout-tests/editing/deleting/delete-line-015-expected.txt:
        * layout-tests/editing/deleting/delete-line-016-expected.txt:
        * layout-tests/editing/deleting/delete-line-017-expected.txt:
        * layout-tests/editing/deleting/delete-line-end-ws-001-expected.txt:
        * layout-tests/editing/deleting/delete-line-end-ws-002-expected.txt:
        * layout-tests/editing/deleting/delete-select-all-001-expected.txt:
        * layout-tests/editing/deleting/delete-select-all-002-expected.txt:
        * layout-tests/editing/deleting/delete-select-all-003-expected.txt:
        * layout-tests/editing/deleting/delete-selection-001-expected.txt:
        * layout-tests/editing/deleting/delete-tab-001-expected.txt:
        * layout-tests/editing/deleting/delete-tab-002-expected.txt:
        * layout-tests/editing/deleting/delete-tab-003-expected.txt:
        * layout-tests/editing/deleting/delete-tab-004-expected.txt:
        * layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
        * layout-tests/editing/deleting/delete-trailing-ws-002-expected.txt:
        * layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt:
        * layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt:
        * layout-tests/editing/deleting/delete-ws-fixup-003-expected.txt:
        * layout-tests/editing/deleting/delete-ws-fixup-004-expected.txt:
        * layout-tests/editing/deleting/forward-delete-expected.txt:
        * layout-tests/editing/deleting/smart-delete-001-expected.txt:
        * layout-tests/editing/deleting/smart-delete-002-expected.txt:
        * layout-tests/editing/execCommand/boldSelection-expected.txt:
        * layout-tests/editing/execCommand/italicizeByCharacter-expected.txt:
        * layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt:
        * layout-tests/editing/execCommand/selectAll-expected.txt:
        * layout-tests/editing/inserting/insert-3654864-fix-expected.txt:
        * layout-tests/editing/inserting/insert-3659587-fix-expected.txt:
        * layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
        * layout-tests/editing/inserting/insert-3778059-fix-expected.txt:
        * layout-tests/editing/inserting/insert-3786362-fix-expected.txt:
        * layout-tests/editing/inserting/insert-3800346-fix-expected.txt:
        * layout-tests/editing/inserting/insert-3851164-fix-expected.txt:
        * layout-tests/editing/inserting/insert-3907422-fix-expected.txt:
        * layout-tests/editing/inserting/insert-after-delete-001-expected.txt:
        * layout-tests/editing/inserting/insert-br-001-expected.txt:
        * layout-tests/editing/inserting/insert-br-002-expected.txt:
        * layout-tests/editing/inserting/insert-br-003-expected.txt:
        * layout-tests/editing/inserting/insert-br-004-expected.txt:
        * layout-tests/editing/inserting/insert-br-005-expected.txt:
        * layout-tests/editing/inserting/insert-br-006-expected.txt:
        * layout-tests/editing/inserting/insert-br-007-expected.txt:
        * layout-tests/editing/inserting/insert-br-008-expected.txt:
        * layout-tests/editing/inserting/insert-div-001-expected.txt:
        * layout-tests/editing/inserting/insert-div-002-expected.txt:
        * layout-tests/editing/inserting/insert-div-003-expected.txt:
        * layout-tests/editing/inserting/insert-div-004-expected.txt:
        * layout-tests/editing/inserting/insert-div-005-expected.txt:
        * layout-tests/editing/inserting/insert-div-006-expected.txt:
        * layout-tests/editing/inserting/insert-div-007-expected.txt:
        * layout-tests/editing/inserting/insert-div-008-expected.txt:
        * layout-tests/editing/inserting/insert-div-009-expected.txt:
        * layout-tests/editing/inserting/insert-div-010-expected.txt:
        * layout-tests/editing/inserting/insert-div-011-expected.txt:
        * layout-tests/editing/inserting/insert-div-012-expected.txt:
        * layout-tests/editing/inserting/insert-div-013-expected.txt:
        * layout-tests/editing/inserting/insert-div-014-expected.txt:
        * layout-tests/editing/inserting/insert-div-015-expected.txt:
        * layout-tests/editing/inserting/insert-div-016-expected.txt:
        * layout-tests/editing/inserting/insert-div-017-expected.txt:
        * layout-tests/editing/inserting/insert-div-018-expected.txt:
        * layout-tests/editing/inserting/insert-div-019-expected.txt:
        * layout-tests/editing/inserting/insert-div-020-expected.txt:
        * layout-tests/editing/inserting/insert-div-021-expected.txt:
        * layout-tests/editing/inserting/insert-div-022-expected.txt:
        * layout-tests/editing/inserting/insert-div-023-expected.txt:
        * layout-tests/editing/inserting/insert-div-024-expected.txt:
        * layout-tests/editing/inserting/insert-div-025-expected.txt:
        * layout-tests/editing/inserting/insert-div-026-expected.txt:
        * layout-tests/editing/inserting/insert-div-027-expected.txt:
        * layout-tests/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * layout-tests/editing/inserting/insert-tab-001-expected.txt:
        * layout-tests/editing/inserting/insert-tab-002-expected.txt:
        * layout-tests/editing/inserting/insert-tab-003-expected.txt:
        * layout-tests/editing/inserting/insert-tab-004-expected.txt:
        * layout-tests/editing/inserting/insert-text-with-newlines-expected.txt:
        * layout-tests/editing/inserting/return-key-with-selection-001-expected.txt:
        * layout-tests/editing/inserting/return-key-with-selection-002-expected.txt:
        * layout-tests/editing/inserting/return-key-with-selection-003-expected.txt:
        * layout-tests/editing/inserting/typing-001-expected.txt:
        * layout-tests/editing/inserting/typing-002-expected.txt:
        * layout-tests/editing/inserting/typing-003-expected.txt:
        * layout-tests/editing/inserting/typing-around-br-001-expected.txt:
        * layout-tests/editing/inserting/typing-around-image-001-expected.txt:
        * layout-tests/editing/pasteboard/cut-text-001-expected.txt:
        * layout-tests/editing/pasteboard/paste-4035648-fix-expected.txt:
        * layout-tests/editing/pasteboard/paste-4038267-fix-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-001-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-002-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-003-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-004-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-005-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-006-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-007-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-008-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-009-expected.txt:
        * layout-tests/editing/pasteboard/paste-line-endings-010-expected.txt:
        * layout-tests/editing/pasteboard/paste-match-style-001-expected.txt:
        * layout-tests/editing/pasteboard/paste-match-style-002-expected.txt:
        * layout-tests/editing/pasteboard/paste-pre-001-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-001-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-002-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-003-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-004-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-005-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-006-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-007-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-008-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-009-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-010-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-011-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-012-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-013-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-014-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-015-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-016-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-017-expected.txt:
        * layout-tests/editing/pasteboard/paste-text-018-expected.txt:
        * layout-tests/editing/pasteboard/smart-paste-001-expected.txt:
        * layout-tests/editing/pasteboard/smart-paste-002-expected.txt:
        * layout-tests/editing/pasteboard/smart-paste-003-expected.txt:
        * layout-tests/editing/pasteboard/smart-paste-004-expected.txt:
        * layout-tests/editing/pasteboard/smart-paste-005-expected.txt:
        * layout-tests/editing/pasteboard/smart-paste-006-expected.txt:
        * layout-tests/editing/pasteboard/smart-paste-007-expected.txt:
        * layout-tests/editing/selection/move-between-blocks-no-001-expected.txt:
        * layout-tests/editing/selection/select-all-001-expected.txt:
        * layout-tests/editing/selection/select-all-002-expected.txt:
        * layout-tests/editing/selection/select-all-003-expected.txt:
        * layout-tests/editing/selection/select-all-004-expected.txt:
        * layout-tests/editing/style/block-style-001-expected.txt:
        * layout-tests/editing/style/block-style-002-expected.txt:
        * layout-tests/editing/style/block-style-003-expected.txt:
        * layout-tests/editing/style/block-style-004-expected.txt:
        * layout-tests/editing/style/block-style-005-expected.txt:
        * layout-tests/editing/style/block-style-006-expected.txt:
        * layout-tests/editing/style/block-styles-007-expected.txt:
        * layout-tests/editing/style/create-block-for-style-001-expected.txt:
        * layout-tests/editing/style/create-block-for-style-002-expected.txt:
        * layout-tests/editing/style/create-block-for-style-003-expected.txt:
        * layout-tests/editing/style/create-block-for-style-004-expected.txt:
        * layout-tests/editing/style/create-block-for-style-005-expected.txt:
        * layout-tests/editing/style/create-block-for-style-006-expected.txt:
        * layout-tests/editing/style/create-block-for-style-007-expected.txt:
        * layout-tests/editing/style/create-block-for-style-008-expected.txt:
        * layout-tests/editing/style/create-block-for-style-009-expected.txt:
        * layout-tests/editing/style/create-block-for-style-010-expected.txt:
        * layout-tests/editing/style/create-block-for-style-011-expected.txt:
        * layout-tests/editing/style/create-block-for-style-012-expected.txt:
        * layout-tests/editing/style/create-block-for-style-013-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-001-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-002-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-003-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-004-expected.txt:
        * layout-tests/editing/style/remove-underline-across-paragraph-expected.txt:
        * layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
        * layout-tests/editing/style/remove-underline-after-paragraph-expected.txt:
        * layout-tests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
        * layout-tests/editing/style/remove-underline-expected.txt:
        * layout-tests/editing/style/remove-underline-from-stylesheet-expected.txt:
        * layout-tests/editing/style/remove-underline-in-bold-expected.txt:
        * layout-tests/editing/style/smoosh-styles-001-expected.txt:
        * layout-tests/editing/style/smoosh-styles-002-expected.txt:
        * layout-tests/editing/style/smoosh-styles-003-expected.txt:
        * layout-tests/editing/style/style-3681552-fix-001-expected.txt:
        * layout-tests/editing/style/style-3681552-fix-002-expected.txt:
        * layout-tests/editing/style/style-3690704-fix-expected.txt:
        * layout-tests/editing/style/style-3998892-fix-expected.txt:
        * layout-tests/editing/style/style-boundary-001-expected.txt:
        * layout-tests/editing/style/style-boundary-002-expected.txt:
        * layout-tests/editing/style/style-boundary-003-expected.txt:
        * layout-tests/editing/style/style-boundary-004-expected.txt:
        * layout-tests/editing/style/typing-style-001-expected.txt:
        * layout-tests/editing/style/typing-style-002-expected.txt:
        * layout-tests/editing/style/typing-style-003-expected.txt:
        * layout-tests/editing/style/unbold-in-bold-expected.txt:
        * layout-tests/editing/style/underline-expected.txt:
        * layout-tests/editing/undo/redo-typing-001-expected.txt:
        * layout-tests/editing/undo/undo-typing-001-expected.txt:
        * layout-tests/editing/unsupported-content/list-delete-001-expected.txt:
        * layout-tests/editing/unsupported-content/list-delete-002-expected.txt:
        * layout-tests/editing/unsupported-content/list-delete-003-expected.txt:
        * layout-tests/editing/unsupported-content/list-type-after-expected.txt:
        * layout-tests/editing/unsupported-content/list-type-before-expected.txt:
        * layout-tests/editing/unsupported-content/table-delete-001-expected.txt:
        * layout-tests/editing/unsupported-content/table-delete-002-expected.txt:
        * layout-tests/editing/unsupported-content/table-delete-003-expected.txt:
        * layout-tests/editing/unsupported-content/table-type-after-expected.txt:
        * layout-tests/editing/unsupported-content/table-type-before-expected.txt:
        * layout-tests/fast/selectors/159-expected.txt:
        * layout-tests/fast/selectors/177a-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Mon, 15 Aug 2005 03:35:59 +0000 (03:35 +0000)]
    Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4251
          Ideally would be able to pass arguments to apps using run-safari and run-webkit-app scripts

        * Scripts/run-safari: Pass arguments through to Safari on command line.
        * Scripts/run-webkit-app: Pass arguments through to "open" tool on command line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 15 Aug 2005 02:57:27 +0000 (02:57 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4420
          make border drawing faster by removing code to alloc/dealloc NSBezierPath

        * kwq/KWQPainter.h: Remove unused drawLineSegments, drawPolyline, and drawPolygon.
        * kwq/KWQPainter.mm:
        (QPainter::drawConvexPolygon): Move the body of _drawPoints into here, and remove the
        various unused code paths. Use CoreGraphics calls instead of NSBezierPath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 15 Aug 2005 02:55:14 +0000 (02:55 +0000)]
    Reviewed by Maciej.

        - fixed crash observed on one of the Apple-only layout tests

        * kjs/property_map.cpp: (KJS::PropertyMap::mark): Change code to understand that deleted
        entries have a value of NULL, so the deleted sentinel count doesn't need to be included
        in the count of things to mark since we're ignoring the keys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Mon, 15 Aug 2005 00:58:25 +0000 (00:58 +0000)]
    Reviewed by Darin.

- 1% speedup on HTML load speed iBench by avoiding icon database thrash
http://bugzilla.opendarwin.org/show_bug.cgi?id=4423

        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase _setIconURL:forURL:]): Be more aggressive about returning early, because
updating the database does some expensive data structure copies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Mon, 15 Aug 2005 00:32:41 +0000 (00:32 +0000)]
    Reviewed by Darin.

        - apply a tasty candy shell of inlining and main_thread_malloc for a 1% speedup on HTML iBench
http://bugzilla.opendarwin.org/show_bug.cgi?id=4425

        * kwq/KWQArrayImpl.h:
        (KWQArrayImpl::size):
        * kwq/KWQArrayImpl.mm:
        * kwq/KWQMapImpl.h:
        * kwq/KWQMapImpl.mm:
        * kwq/KWQRefPtr.h:
        (::KWQRefPtr):
        (::operator):
        (::ref):
        (::unref):
        * kwq/KWQValueListImpl.h:
        (KWQValueListIteratorImpl::KWQValueListIteratorImpl):
        (KWQValueListIteratorImpl::operator==):
        (KWQValueListIteratorImpl::operator!=):
        (KWQValueListIteratorImpl::node):
        (KWQValueListIteratorImpl::operator++):
        (KWQValueListIteratorImpl::operator--):
        (KWQValueListNodeImpl::KWQValueListNodeImpl):
        * kwq/KWQValueListImpl.mm:
        (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate):
        (KWQValueListImpl::KWQValueListPrivate::~KWQValueListPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 14 Aug 2005 16:41:47 +0000 (16:41 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4421
          speed up JavaScript by inlining some label stack functions

        * kjs/internal.h: Removed the copy constructor and assignment operator for LabelStack.
        They were unused, and the implementations had bugs; I removed them rather than fixing them.
        Also removed the clear function, since that was only needed to help the assignment operator
        share code with the destructor, and was not efficient enough for the destructor.
        (KJS::LabelStack::~LabelStack): Made this inline. Also used an efficient implementation
        that's nice and fast when the stack is empty, better than the old clear() function which
        used to keep updating and refetching "tos" each time through the loop.
        (KJS::LabelStack::pop): Made this inline.

        * kjs/internal.cpp: Deleted the now-inline functions and the obsolete functions. Also
        deleted a commented-out line of code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 14 Aug 2005 16:34:02 +0000 (16:34 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4419
          speed up JavaScript by improving KJS::List

        my measurements show an improvement of 1% on iBench JavaScript

        * kjs/list.cpp: Rearrange list to make the values and free list share the same storage,
        which saves 4 bytes per list. Also remove the pointers used only on the heap from the
        lists that are in the pool, which saves 8 bytes per list. Moving the free list pointer
        closer to the start of the list object also speeds up access to the free list. New
        "HeapListImp" struct is used only for the lists on the heap.
        (KJS::List::markProtectedLists): Shadowed global variable in local and updated for the
        new terminology ("heap" instead of "outside pool").
        (KJS::allocateListImp): Updated for new terminology.
        (KJS::List::release): Moved the code from deallocateListImp in here -- it wasn't being
        inlined and didn't need to be in a separate function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 14 Aug 2005 16:27:13 +0000 (16:27 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4417
          speed up JavaScript with some small changes to the property map code

        my measurements show an improvement of 2% on iBench JavaScript

        * kjs/property_map.h: (KJS::PropertyMap::PropertyMap): Made the default constructor inline.
        * kjs/property_map.cpp:
        (KJS::PropertyMap::~PropertyMap): Changed loop to exit early once we know we've processed
        all the hash table entries, based on the count.
        (KJS::PropertyMap::mark): Ditto.

        * kjs/object.h: Made an arbitrary change here to force recompiling so we pick up changes to
        property_map.h. Works around what seems to be an Xcode header dependency bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 14 Aug 2005 16:17:11 +0000 (16:17 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4416
          speed up JavaScript with some improvements to the garbage collector

        seems to give about 2% on iBench JavaScript

        * kjs/collector.cpp:
        (KJS::Collector::allocate): Use local variables to shadow globals instead of repeatedly
        going at global variables. Tighten up loop implementations to make the common case fast.
        (KJS::Collector::markStackObjectsConservatively): Use local variables to shadow globals.
        Used a goto to eliminate a boolean since it was showing up in the profile.
        (KJS::Collector::markProtectedObjects): Iterate through the table using pointer rather
        than an index since the profile showed that generating better code.
        (KJS::Collector::collect): Added a special case for blocks where all cells are used,
        Use local variables to shadow globals. Eliminated a boolean by computing it another
        way (checking to see if the number of live objects changed). Also used local variables
        to shadow fields in the current cell when sweeping.
        (KJS::Collector::numReferencedObjects): Use AllocatedValueImp instead of ValueImp
        in one place -- means we get faster versions of various functions that don't worry
        about SimpleNumber.
        (KJS::className): Ditto.
        (KJS::Collector::rootObjectClasses): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4344
darin [Sun, 14 Aug 2005 16:04:19 +0000 (16:04 +0000)]
    - fixed bugzilla.opendarwin.org/show_bug.cgi?id=4344
          REGRESSION: JavaScript crash when going back from viewing a thread (NULL protoype)

        * kjs/error_object.cpp: (NativeErrorImp::NativeErrorImp): Set proto in a more
        straightforward way. The old code set the proto to 0 and then to the correct value.
        This showed up as a "false positive" when searching for places that set prototype
        to NULL/0 so I fixed it.

        * kjs/function_object.cpp: (FunctionPrototypeImp::FunctionPrototypeImp): Change to
        not pass an explicit "0" to the base class (InternalFunctionImp) constructor.

        * kjs/internal.h: Added a default constructor for InternalFunctionImp.
        * kjs/internal.cpp: (KJS::InternalFunctionImp::InternalFunctionImp): Added the
        default constructor (empty body, just calls base class's default constructor).

        * kjs/object.h:
        (KJS::ObjectImp::ObjectImp): Add an assertion to catch NULL prototypes earlier
        in Development builds.
        (KJS::ObjectImp::setPrototype): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Sun, 14 Aug 2005 09:12:48 +0000 (09:12 +0000)]
WebCore:

        Reviewed and landed by Darin.

        WebCore part of fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=4011>:
        "Editing delegate selection methods not called when using mouse"

        Clicking on editable content would move the cursor or alter the selection without
        calling the appropriate editing delegate method
        (webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:). The
        core of the patch is in the KHTMLPart::hadnleMousePressEvent* methods, the rest
        is glue needed to drill through all the layers.

        * khtml/khtml_part.cpp:
        * khtml/khtml_part.cpp:
        (KHTMLPart::shouldChangeSelection): Glue to call editing delegate.
        (KHTMLPart::findTextNext): Call editing delegate before changing selection.
        (KHTMLPart::selectClosestWordFromMouseEvent): Ditto.
        (KHTMLPart::handleMousePressEventTripleClick): Ditto.
        (KHTMLPart::handleMousePressEventSingleClick): Ditto.
        (KHTMLPart::handleMouseMoveEventSelection): Ditto.
        (KHTMLPart::khtmlMouseReleaseEvent): Ditto.
        (KHTMLPart::selectAll): Ditto.
        (KHTMLPart::appliedEditing): Ditto.
        (KHTMLPart::unappliedEditing): Ditto.
        (KHTMLPart::reappliedEditing): Ditto.
        (KHTMLPart::selectFrameElementInParentIfFullySelected): Ditto.

        * khtml/khtml_part.h: Added shouldChangeSelection glue method.
        * kwq/KWQKHTMLPart.h: Ditto.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::shouldChangeSelection): Glue to call editing delegate.

        * kwq/WebCoreBridge.h: Added shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting: glue method.

WebKit:

        Reviewed and landed by Darin.

        WebKit part of fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=4011>:
        "Editing delegate selection methods not called when using mouse"

        Clicking on editable content would move the cursor or alter the selection without
        calling the appropriate editing delegate method
        (webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:). The
        core of the patch is in the KHTMLPart::handleMousePressEvent* methods, the rest
        is glue needed to drill through all the layers.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        Bridge glue.

        * WebView.subproj/WebView.m:
        (-[WebView(WebViewEditingExtras) _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        Final step in glue, calling editing delegate.

        * WebView.subproj/WebViewInternal.h:
        Added _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting: private method to WebViewEditingExtras
        category.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed by Alexey Proskuryakov <ap@nypop.com>.
darin [Sun, 14 Aug 2005 08:47:14 +0000 (08:47 +0000)]
    Fixed by Alexey Proskuryakov <ap@nypop.com>.
        Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3590
          should allow <meta> tags for encoding even after </head>

        Test cases added:
        * layout-tests/fast/encoding/mispositioned-meta-expected.txt: Added.
        * layout-tests/fast/encoding/mispositioned-meta.html: Added.

        * khtml/misc/decoder.cpp: (Decoder::decode): Don't stop scanning when seeing </head>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Sun, 14 Aug 2005 08:28:01 +0000 (08:28 +0000)]
    Reviewed and landed by Darin.

        Test cases added:
        * layout-tests/dom/html/level2/events/dispatchEvent08-expected.txt:
        * layout-tests/dom/html/level2/events/dispatchEvent10-expected.txt:
        * layout-tests/dom/html/level2/events/dispatchEvent12-expected.txt:
These pass now.

        * layout-tests/dom/html/level2/events/dispatchEvent11-expected.txt:
        * layout-tests/dom/html/level2/events/dispatchEvent13-expected.txt:
These fail someplace else now.

        * khtml/ecma/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
Check if the listener has a "handleEvent" function property and
call that.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::dispatchGenericEvent):
A capturing event listener should not be triggered if an event is
dispatched directly to the node to which the listener has been added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Sun, 14 Aug 2005 08:18:51 +0000 (08:18 +0000)]
    Reviewed and landed by Darin.

        Test cases added:
        * layout-tests/dom/html/level2/core/hc_nodedocumentfragmentnormalize2-expected.txt:
This passes now.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::normalize):
If there's a single empty text child, remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Sun, 14 Aug 2005 08:07:23 +0000 (08:07 +0000)]
    Reviewed and landed by Darin.

        Test cases added:
        * layout-tests/dom/html/level2/html/HTMLSelectElement20-expected.txt:
This passes now.

        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLElementFunction::callAsFunction):
        (KJS::KJS::HTMLSelectCollection::put):
Handle exceptions.

        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLSelectElementImpl::add):
        * khtml/html/html_formimpl.h:
Make ::add raise an exception if before isn't a descendant
of the select element.

        * kwq/DOMHTML.mm:
        (-[DOMHTMLSelectElement add::]):
Handle the exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
mjs [Fri, 12 Aug 2005 23:20:48 +0000 (23:20 +0000)]
    Reviewed by John.

- two simple speed improvements for a 3% speed gain

        * JavaScriptCore.xcodeproj/project.pbxproj: turn on -fstrict-aliasing

        * kjs/scope_chain.h:
        (KJS::ScopeChainIterator::ScopeChainIterator): Add a scope chain iterator
so you can walk a scope chain without having to make a copy that you then mutate.
        (KJS::ScopeChainIterator::operator*): standard iterator operation
        (KJS::ScopeChainIterator::operator->): ditto
        (KJS::ScopeChainIterator::operator++): ditto
        (KJS::ScopeChainIterator::operator==): ditto
        (KJS::ScopeChainIterator::operator!=): ditto
        (KJS::ScopeChain::begin): Iterator for the top of the scope chain
        (KJS::ScopeChain::end): Iterator for one past the bottom (i.e. null)
        * kjs/nodes.cpp:
        (ResolveNode::evaluate): Use scope chain iterator instead of copying
a scope chain and then modifying the copy
        (ResolveNode::evaluateReference): ditto
        (FunctionCallResolveNode::evaluate): ditto
        (AssignResolveNode::evaluate): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by adele.
ggaren [Fri, 12 Aug 2005 22:43:40 +0000 (22:43 +0000)]
    Reviewed by adele.

        * manual-tests/liveconnect-security-exception.html:
            - fixed wrong codebase path
            - added instruction to disable popup blocking

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoremove files from TOT that should only have been on the branch
darin [Fri, 12 Aug 2005 22:26:44 +0000 (22:26 +0000)]
remove files from TOT that should only have been on the branch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agooops; roll back, this was supposed to be on a branch
darin [Fri, 12 Aug 2005 22:18:08 +0000 (22:18 +0000)]
oops; roll back, this was supposed to be on a branch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agochecking in PCRE 6.1 sources with no changes yet
darin [Fri, 12 Aug 2005 22:13:27 +0000 (22:13 +0000)]
checking in PCRE 6.1 sources with no changes yet

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoanother unneeded file
darin [Fri, 12 Aug 2005 22:03:41 +0000 (22:03 +0000)]
another unneeded file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agomore unneeded files
darin [Fri, 12 Aug 2005 22:02:45 +0000 (22:02 +0000)]
more unneeded files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoremoved another unneeded file
darin [Fri, 12 Aug 2005 22:02:12 +0000 (22:02 +0000)]
removed another unneeded file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoremove some files -- we should remove them on TOT too later
darin [Fri, 12 Aug 2005 22:01:14 +0000 (22:01 +0000)]
remove some files -- we should remove them on TOT too later

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Patch from Anders Carlsson, reviewed by me.
mjs [Fri, 12 Aug 2005 19:58:17 +0000 (19:58 +0000)]
    Patch from Anders Carlsson, reviewed by me.

        * kjs/nodes.h: Fix build breakage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by hyatt.
mjs [Fri, 12 Aug 2005 07:36:00 +0000 (07:36 +0000)]
    Reviewed by hyatt.

- refactor function calls, 3% speedup on JS iBench.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (Node::throwError): Added new useful variants.
        (FunctionCallValueNode::evaluate): New node to handle calls on expressions
that are strictly values, not references.
        (FunctionCallValueNode::ref):  ditto
        (FunctionCallValueNode::deref): ditto
        (FunctionCallResolveNode::evaluate): New node to handle calls on identifier
expressions, so that they are looked up in the scope chain.
        (FunctionCallResolveNode::ref): ditto
        (FunctionCallResolveNode::deref): ditto
        (FunctionCallBracketNode::evaluate): New node to handle calls on bracket
dereferences, so that the expression before brackets is used as the this
object.
        (FunctionCallBracketNode::ref): ditto
        (FunctionCallBracketNode::deref): ditto
        (FunctionCallDotNode::evaluate): New node to handle calls on dot
dereferences, so that the expression before the dot is used as the this
object.
        (FunctionCallDotNode::ref): ditto
        (FunctionCallDotNode::deref): ditto
        (dotExprNotAnObjectString): helper function to avoid global variable access.
        (dotExprDoesNotAllowCallsString): ditto
        * kjs/nodes.h: Declared new classes.
        * kjs/nodes2string.cpp:
        (FunctionCallValueNode::streamTo): Added - serializes the appropriate function call
        (FunctionCallResolveNode::streamTo): ditto
        (FunctionCallBracketNode::streamTo): ditto
        (FunctionCallParenBracketNode::streamTo): ditto
        (FunctionCallDotNode::streamTo): ditto
        (FunctionCallParenDotNode::streamTo): ditto
        * kjs/object.h:
        (KJS::ObjectImp::isActivation): Change how activation objects are
detected in the scope chain, a virtual function is cheaper than the
old inheritance test.
        * kjs/function.h:
        (KJS::ActivationImp::isActivation): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele [Fri, 12 Aug 2005 01:30:35 +0000 (01:30 +0000)]
    Reviewed by Darin.

        Test cases added: (NONE)

        -fixed <rdar://problem/4166839> CSS font-family and font-size ignored on <select> element with size > 1

        Changed KWQListBox to get the font from the widget.

        * kwq/KWQListBox.h: added setFont method
        * kwq/KWQListBox.mm:
        (QListBox::setFont): Added.
        (QListBox::sizeForNumberOfLines): if the new font is the same as the system font, use the old system for cacheing the text renderer.
        Otherwise, create a text renderer based on the new font, and a bold version of the new font.
        (-[KWQTableView drawRow:clipRect:]): ditto.
        (-[KWQTableView initWithListBox:]): moved setRowHeight call to fontChanged, so the height will reflect the new font.
        (-[KWQTableView fontChanged]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Vicki
bdakin [Thu, 11 Aug 2005 23:10:56 +0000 (23:10 +0000)]
    Reviewed by Vicki

This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
I basically did what Troy suggests in his bug comments, and everything seems to work fine!

        * Carbon.subproj/HIViewAdapter.m:
        (-[HIViewAdapter setNeedsDisplayInRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Refine the baseline alignment rule for inline blocks to cover for a hole in the...
hyatt [Thu, 11 Aug 2005 21:37:03 +0000 (21:37 +0000)]
Refine the baseline alignment rule for inline blocks to cover for a hole in the spec.  The spec doesnt say what to do
for overflow cases, e.g., when the last line is clipped, when the overflow box is scrolled, or even when overflow is
visible but the last line is outside your content box.  We just revert to the old behavior in those cases.  Hopefully
the spec will be clarified to explain what the right behavior is.

        Reviewed by beth

        Test cases added: fast/inline-block/tricky-baseline.html

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10143 268f45cc-cd09-0410-ab3c-d52691b4dbfc