mrobinson@webkit.org [Fri, 20 Apr 2012 23:47:03 +0000 (23:47 +0000)]
[Gtk][WK1] Use mock scrollbars when testing
https://bugs.webkit.org/show_bug.cgi?id=79577
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-20
Reviewed by Daniel Bates.
Enable mock scrollbars if running DumpRenderTree.
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 20 Apr 2012 23:32:16 +0000 (23:32 +0000)]
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Reviewed by Simon Fraser.
Add -webkit-filter results to the platforms on which it is enabled.
This required a new platform result for WebKit mac.
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt.
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pilgrim@chromium.org [Fri, 20 Apr 2012 23:31:23 +0000 (23:31 +0000)]
[Chromium] Call memoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84376
Reviewed by Kentaro Hara.
Source/WebCore:
Now that memoryUsageMB has been moved from PlatformSupport.h to
Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/V8GCController.cpp.
That means we need a new MemoryUsageSupport class in
WebCore/platform/ and an implementation in
WebCore/platform/chromium/MemoryUsageSupportChromium.cpp.
Other ports are welcome to implement their memory usage
functions if they wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.
Part of a refactoring series. See tracking bug 82948.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/V8GCController.cpp:
(WebCore):
* platform/MemoryUsageSupport.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
* platform/MemoryUsageSupport.h: Added.
(WebCore):
(MemoryUsageSupport):
* platform/chromium/MemoryUsageSupportChromium.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
Part of a refactoring series. See tracking bug 82948.
* src/PlatformSupport.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 20 Apr 2012 23:18:16 +0000 (23:18 +0000)]
[GTK] Revert changes that disabled Cairo fonts metrics hinting
https://bugs.webkit.org/show_bug.cgi?id=84502
Reviewed by Daniel Bates.
Re-enable Cairo metrics hinting, which seems to ensure consistent results in
reference and pixel test results. This makes our font metrics a bit different
than the Mac port's, but it's a decent price to pay for consistent results.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 20 Apr 2012 23:04:39 +0000 (23:04 +0000)]
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505
Unreviewed; add new crashing test result to test_expectations.txt.
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 23:03:05 +0000 (23:03 +0000)]
[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=84440
Unreviewed, added EFL baselines for passing tests and also skipped two tests
which are failing due to missing implementation.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
* platform/efl/Skipped:
* platform/efl/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/efl/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 20 Apr 2012 22:52:53 +0000 (22:52 +0000)]
Inline the JSArray constructor
https://bugs.webkit.org/show_bug.cgi?id=84416
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-20
Reviewed by Geoffrey Garen.
The constructor is trivial, no reason to jump for it.
This makes the creation of array ~5% faster (on non-trivial cases, no empty arrays).
* runtime/JSArray.cpp:
(JSC):
* runtime/JSArray.h:
(JSC::JSArray::JSArray):
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Apr 2012 22:38:49 +0000 (22:38 +0000)]
Re-land. The non-fast scrollable region is now always updated after layout, and frameViewScrollableAreasDidChange has been removed.
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/
11285741>
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 20 Apr 2012 22:35:40 +0000 (22:35 +0000)]
[chromium] Clip TransparencyWin to prevent OOM from large Skia canvas
https://bugs.webkit.org/show_bug.cgi?id=84289
Reviewed by James Robinson.
Source/WebCore:
TransparencyWin will create a Skia canvas of whatever size is passed
in, even if the result will ultimately be clipped. Handle the clip
implicitly and try (in some cases) to create a smaller canvas. This
can happen due to RenderBox::paintBoxDecorations passing a paint rect
down of the entire element's size.
Modes with more complicated transforms (ScaleTransform, UnTransform)
are not handled yet.
Tests: TransparencyWin.ClippedKeepTransformNoLayer
TransparencyWin.ClippedKeepTransformOpaqueCompositeLayer
TransparencyWin.ClippedKeepTransformOpaqueWhiteLayer
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::computeLayerSize):
Source/WebKit/chromium:
Add a test that would OOM if the layer wasn't clipped. Also, verify
that clipping the canvas doesn't shift pixels around incorrectly.
* tests/TransparencyWinTest.cpp:
(WebCore::testClippedLayerKeepTransform):
(WebCore):
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 20 Apr 2012 22:33:46 +0000 (22:33 +0000)]
apple.com top navigation bar appears inside video during full screen exit animation
https://bugs.webkit.org/show_bug.cgi?id=83095
Reviewed by Eric Carlson.
Source/WebCore:
Test: fullscreen/full-screen-exit-animation-stacking-context.html
Only tell ancestors of the full screen element that they are no longer ancestors once
the full screen animation is complete:
* dom/Document.cpp:
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
To facilitate writing reproducible LayoutTests, expose webkitWill/Did/Enter/ExitFullScreen
from the Internals object, so scripts can call them explicitly:
* testing/Internals.cpp:
(WebCore::Internals::webkitWillEnterFullScreenForElement): Call the Document equivalent.
(WebCore::Internals::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Internals::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Internals::webkitDidExitFullScreenForElement): Ditto.
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
Add new WebCore symbols needed by DumpRenderTree to exported symbol list.
* win/WebKit2.def:
* win/WebKit2CFLite.def:
Tools:
Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
Document methods from within the script. This allows subtle timing bugs to be consistently reproduced
from within LayoutTests.
Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
* DumpRenderTree/LayoutTestController.cpp:
(setHasCustomFullScreenBehaviorCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::setHasCustomFullScreenBehavior):
(WTR::LayoutTestController::hasCustomFullScreenBehavior):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
Query the new methods before calling will/did/Enter/ExitFullScreen:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::enterFullScreenNow):
(WebViewHost::exitFullScreenNow):
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:enterFullScreenForElement:listener:]):
(-[UIDelegate webView:exitFullScreenForElement:listener:]):
LayoutTests:
* fullscreen/full-screen-exit-animation-stacking-context-expected.txt: Added.
* fullscreen/full-screen-exit-animation-stacking-context.html: Added.
* platform/mac/fullscreen/full-screen-exit-animation-stacking-context-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 20 Apr 2012 22:33:35 +0000 (22:33 +0000)]
media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=84162
Reviewed by Eric Carlson.
No new tests; no change in functionality so covered by existing tests.
Remove the media-exit-fullscreen-button keyword, and rename media-enter-fullscreen-button to
media-fullscreen-button.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
* platform/ThemeTypes.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 20 Apr 2012 22:32:04 +0000 (22:32 +0000)]
NRWT: option --skip-pixel-test-if-no-baseline support on DRT
https://bugs.webkit.org/show_bug.cgi?id=72841
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-20
Reviewed by Dirk Pranke
This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
and 'reference_files' fields to the TestInput objects, and use those flags
to select the right driver to use in the DriverProxy.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__):
(SingleTestRunner._driver_input):
(SingleTestRunner._run_reftest):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
(Worker._update_test_input):
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput):
(TestInput.__init__):
(TestInput.__repr__):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
(ChromiumDriver.run_test):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverInput.__init__):
(Driver.__init__):
(DriverProxy.__init__):
(DriverProxy.run_test):
(DriverProxy.start):
(DriverProxy.cmd_line):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRT.run):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.write_test_output):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.write_test_output):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.cmd_line):
(WebKitDriver.run_test):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
(TestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
* WebKitTestRunner/TestInvocation.h:
(TestInvocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 22:18:04 +0000 (22:18 +0000)]
[chromium] Fix compile errors when DEBUG_GL_CALLS is enabled
https://bugs.webkit.org/show_bug.cgi?id=84491
Patch by Alexandre Elias <aelias@google.com> on 2012-04-20
Reviewed by Ojan Vafai.
DEBUG_GL_CALLS had not been used in a while and the mode no longer
compiled when I tried it. I improved the GLC macro to support either
raw pointers or RefPtrs, and to be a single expression in order to
interact properly with if/else blocks. I fixed the cases where we
were passing in the "context" method pointer by mistake, and removed the
now-unnecessary "get()" calls for the RefPtrs.
No new tests. (No-op change in release builds.)
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::doNoOp):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Apr 2012 22:15:48 +0000 (22:15 +0000)]
Fix build.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 20 Apr 2012 21:54:45 +0000 (21:54 +0000)]
Set m_compositingDependsOnGeometry to false if possible
https://bugs.webkit.org/show_bug.cgi?id=84391
Reviewed by James Robinson.
For some kinds of elements, RenderLayerCompositor has to delay decisions about
compositing until the element's size and/or position are known. This was previsouly
based on the confusingly named m_compositingDependsOnGeometry flag, but another
variant of the same technique, with an additional flag m_compositingNeedsUpdate,
was added in r98627.
Also, once the m_compositingDependsOnGeometry flag was set to true, nothing
set it to false, so every compositing layer update resulted in a computeCompositingRequirements()
pass over the layers.
Rename the m_compositingDependsOnGeometry flag to m_reevaluateCompositingAfterLayout,
and clear the flag when we do a layout-related compositing layer update.
Use the same flag for position:fixed compositing.
This requires RenderLayerCompositor to distinguish between style- and layout-
related updates, requiring some minor refactoring in FrameView.
Should not change behavior.
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):
* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layout):
* page/FrameView.h:
(FrameView):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 20 Apr 2012 21:40:26 +0000 (21:40 +0000)]
Source/WebCore: <rdar://problem/
10786000> Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
Test: fast/block/line-layout/selection-highlight-overlap.html
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::selectionRect): Changed to use
selection{Top,Height}AdjustedForPrecedingBlock().
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Ditto.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::inlineSelectionGaps): Ditto.
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Added. Returns the block which is
likely to contain the selected line just before the first line in this block, if it is
within the same selection root.
* rendering/RenderBlock.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock): Added. If the selection
starts before our block, finds the last line in the preceding block and adjusts the selection
top to avoid overlap with that line’s selection bottom.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock): Added. Like
selectionHeight(), but uses selectionTopAdjustedForPrecedingBlock().
LayoutTests: Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
* fast/block/line-layout/selection-highlight-overlap-expected.html: Added.
* fast/block/line-layout/selection-highlight-overlap.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 20 Apr 2012 21:37:03 +0000 (21:37 +0000)]
Crash in getOrDrawNodeHighlight after r114659
https://bugs.webkit.org/show_bug.cgi?id=84486
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-04-20
Reviewed by Daniel Bates.
No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.
* inspector/DOMNodeHighlighter.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 20 Apr 2012 21:29:00 +0000 (21:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=84490
PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. (Refactor, no change in behavior)
- Make PageGroupLoadDeferrer take a ReasonForSuspension argument so it can pass it along.
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
* page/PageGroupLoadDeferrer.h:
- Change suspendScheduledTasks to take a ReasonForSuspension.
- As long as we're changing Document.h, add a m_suspendedScheduledTasks flag and some
ASSERTs to catch what would be epically wrong behavior in the future.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
* dom/Document.h:
- Pass ActiveDOMObject::WillShowDialog along to all PageGroupLoadDeferrers, as it used
to be the default behavior
* page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):
Source/WebKit/blackberry:
* Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,
which used to be the default
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
(WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop): Pass along ActiveDOMObject::WillShowDialog, which used
to be the default.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Apr 2012 21:25:27 +0000 (21:25 +0000)]
Scrolling after going to a find-in-page result jumps to the top of the page
https://bugs.webkit.org/show_bug.cgi?id=84485
<rdar://problem/
11273734>
Reviewed by Beth Dakin.
If we're both updating the requested scroll position and entering slow mode in the same commit, the
probable main thread scroll position should be the requested scroll position.
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 21:19:52 +0000 (21:19 +0000)]
[BlackBerry] Expose WebViewportArguments to WebPageClient
https://bugs.webkit.org/show_bug.cgi?id=84471
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-20
Reviewed by Antonio Gomes.
Source/WebKit:
* PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Implement the ability for the WebPageClient to specify a fallback
virtual viewport to be used whenever a meta viewport tag is not
present in the HTML. This can drastically impact apparent layout.
This patch is designed to provide a classic "Column View" style of
layout without breaking the web by simply exposing meta viewport
arguments to WebPageClients.
Note: As a side effect of this change. the WebPagePrivate::
recomputeVirtualViewportFromViewportArguments method no longer
modifies the targetDensityDpi property of the m_viewportArguments.
However this does not affect the class because that property itself
means nothing to us. Only the computeViewportArguments method from
WebCore uses it, and the currentViewportArguments object we pass
into that method has the adjusted targetDensityDpi value as before.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setUserViewportArguments):
(WebKit):
(BlackBerry::WebKit::WebPage::resetUserViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
* Api/WebPage.h:
(WebKit):
* Api/WebPage_p.h:
(WebPagePrivate):
* Api/WebViewportArguments.cpp: Added.
(WebKit):
(BlackBerry::WebKit:::d):
(BlackBerry::WebKit::WebViewportArguments::~WebViewportArguments):
(BlackBerry::WebKit::WebViewportArguments::initialScale):
(BlackBerry::WebKit::WebViewportArguments::setInitialScale):
(BlackBerry::WebKit::WebViewportArguments::minimumScale):
(BlackBerry::WebKit::WebViewportArguments::setMinimumScale):
(BlackBerry::WebKit::WebViewportArguments::maximumScale):
(BlackBerry::WebKit::WebViewportArguments::setMaximumScale):
(BlackBerry::WebKit::WebViewportArguments::width):
(BlackBerry::WebKit::WebViewportArguments::setWidth):
(BlackBerry::WebKit::WebViewportArguments::height):
(BlackBerry::WebKit::WebViewportArguments::setHeight):
(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::userScalable):
(BlackBerry::WebKit::WebViewportArguments::setUserScalable):
(BlackBerry::WebKit::WebViewportArguments::operator==):
(BlackBerry::WebKit::WebViewportArguments::operator!=):
* Api/WebViewportArguments.h: Added.
(WebCore):
(WebKit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 21:17:54 +0000 (21:17 +0000)]
Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes
https://bugs.webkit.org/show_bug.cgi?id=84470
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Anders Carlsson.
Source/WebCore:
When a scrollable area is added or removed, we shouldn't recalculate the nonFastScrollableRegion synchronously
since this is slow, the RenderObject tree might not be in an up-to-date state, and we'll typically do layout
soon anyway.
* page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
* page/scrolling/ScrollingCoordinator.cpp:
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Source/WebKit/chromium:
Trigger a layout when a plugin becomes or stops being scrollable so the nonFastScrollableRegion
can be updated.
* src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 20 Apr 2012 21:02:19 +0000 (21:02 +0000)]
Rebaselining svg/css/getComputedStyle-basic.html after
http://trac.webkit.org/changeset/114766
Not reviewed.
* platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
* platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
* platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
* platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 20:28:03 +0000 (20:28 +0000)]
[EFL] Make it possible to define offline storage quota per origin
https://bugs.webkit.org/show_bug.cgi?id=84170
Improved LayoutTestController::setDatabaseQuota to set quota based on
origin which was causing some tests to fail. Also align the default
quota for testing (5MB) with others ports.
When dumpDatabaseCallbacks is set to true by, also dump some database
information when quota is exceed, which is also required by some tests.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
(drtViewAdd):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDatabaseQuota):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Fri, 20 Apr 2012 20:22:03 +0000 (20:22 +0000)]
Fix use of LayoutUnits in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=84472
Reviewed by Eric Seidel.
Fix use of subpixel units and rounding in new code introduced in r114659.
No new tests, no change in functionality.
* inspector/DOMNodeHighlighter.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 20:07:16 +0000 (20:07 +0000)]
Enable Encrypted Media tests on Chromium now that Chromium side is committed
https://bugs.webkit.org/show_bug.cgi?id=84474
Unreviewed enabling of layout tests.
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-20
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 20 Apr 2012 20:03:01 +0000 (20:03 +0000)]
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Unreviewed; add new failing test to expected results.
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Fri, 20 Apr 2012 19:55:21 +0000 (19:55 +0000)]
Heap should cancel GC timer at the start of the collection
https://bugs.webkit.org/show_bug.cgi?id=84477
Reviewed by Geoffrey Garen.
Currently the Heap cancels the GC timer at the conclusion of a collection.
We should change this to be at the beginning because something (e.g. a finalizer)
could call didAbandonObjectGraph(), which will schedule the timer, but then
we'll immediately unschedule the timer at the conclusion of the collection,
thus potentially preventing large swaths of memory from being reclaimed in a timely manner.
* API/JSBase.cpp:
(JSGarbageCollect): Remove outdated fix-me and remove check for whether the Heap is
busy or not, since we're just scheduling a timer to run a GC in the future.
* heap/Heap.cpp:
(JSC::Heap::collect): Rename didCollect to willCollect and move the call to the
top of Heap::collect.
* runtime/GCActivityCallback.cpp: Renamed didCollect to willCollect.
(JSC::DefaultGCActivityCallback::willCollect):
* runtime/GCActivityCallback.h: Ditto.
(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):
* runtime/GCActivityCallbackCF.cpp: Ditto.
(JSC::DefaultGCActivityCallback::willCollect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Fri, 20 Apr 2012 19:36:13 +0000 (19:36 +0000)]
JSGarbageCollect should not call collectAllGarbage()
https://bugs.webkit.org/show_bug.cgi?id=84476
Reviewed by Geoffrey Garen.
* API/JSBase.cpp:
(JSGarbageCollect): Notify the Heap's GCActivityCallback using didAbandonObjectGraph.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 20 Apr 2012 19:11:52 +0000 (19:11 +0000)]
Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false
https://bugs.webkit.org/show_bug.cgi?id=84178
Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>
No new tests since it is not easily testable.
When a port has both delegatesScrolling and constrainsScrollingToContentEdge set to FALSE
(i.e. it accepts overscrolled position), calling ScrollView::setScrollPosition with an overscrolled
position still gets the position clamped to the content size edges.
Patch relaxes ::adjustScrollPositionWithinRange in that sense in order to track the actual scroll
position.
Note: ScrollView::setScrollOffset already does something similar.
* platform/ScrollView.cpp:
(WebCore::ScrollView::adjustScrollPositionWithinRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 19:04:09 +0000 (19:04 +0000)]
Unreviewed, rolling out r114535.
http://trac.webkit.org/changeset/114535
https://bugs.webkit.org/show_bug.cgi?id=84475
It might have caused V8 crashes. (Requested by pfeldman_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):
* bindings/v8/V8Proxy.h:
(V8Proxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 20 Apr 2012 18:41:15 +0000 (18:41 +0000)]
-webkit-filter missing from computed style enumeration
https://bugs.webkit.org/show_bug.cgi?id=84468
Source/WebCore:
Reviewed by Timothy Hatcher.
CSSComputedStyleDeclaration has a list of properties that it exposes.
While the computed style for filter was available, the property wasn't
listed and hence missing in clients like the Web Inspector.
Covered by existing tests.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore): add CSSPropertyWebkitFilter
LayoutTests:
Reviewed by Timothy Hatcher.
Added new results for platforms that have filters enabled. Hopefully
I got them all. Luckily there were already platform results for this
test in each case.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Fri, 20 Apr 2012 18:13:53 +0000 (18:13 +0000)]
Move bot to Lion Debug to help catch up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Fri, 20 Apr 2012 18:12:47 +0000 (18:12 +0000)]
[win] Update windows platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=84283
Reviewed by Eric Seidel.
Source/WebCore:
No new tests, no change in functionality.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::pixelSnappedElementRect):
Use pixel snapped values when computing screenRect.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
Cast client padding to ints as they are guaranteed to align with device pixels.
Source/WebKit/win:
* AccessibleBase.cpp:
(AccessibleBase::accLocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Fri, 20 Apr 2012 17:57:18 +0000 (17:57 +0000)]
[chromium] Some filters require inflating damage rect in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=84373
Reviewed by James Robinson.
Source/WebCore:
When a layer is blurred, damaged pixels are blurred out into a radius
and their damage should be expanded to include total blurred region.
Unit test: CCDamageTrackerTest.verifyDamageForBlurredSurface
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::expandDamageRectWithForegroundFilters):
(WebCore):
* platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore):
(CCDamageTracker):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
Source/WebKit/chromium:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 17:53:10 +0000 (17:53 +0000)]
[chromium] Don't crash when scrolling empty layer tree
https://bugs.webkit.org/show_bug.cgi?id=84455
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-20
Reviewed by James Robinson.
Source/WebCore:
Do not try to calculate render passes when there are no layers in the
layer tree.
Added new unit test.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
Source/WebKit/chromium:
Try to scroll an empty layer tree.
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 17:46:09 +0000 (17:46 +0000)]
Ensure text is centered for default captions
https://bugs.webkit.org/show_bug.cgi?id=84450
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-20
Reviewed by Eric Carlson.
Source/WebCore:
Updated existing test.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getDisplayTree): Added default width.
LayoutTests:
Updated test to cover default positioning of captions.
* media/track/track-cue-rendering-expected.txt: Updated.
* media/track/track-cue-rendering.html: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 17:31:00 +0000 (17:31 +0000)]
[EFL][DRT] Gardening SVG tests and timeouts
https://bugs.webkit.org/show_bug.cgi?id=84462
Unreviewed, EFL gardening.
A number of SVG Batik text tests needed rebaselining likely due to bug 83264.
Also, moving some tests that fail to call notifyDone to test_expectations with appropriate bugs filed.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-20
* platform/efl/svg/batik/text/longTextOnPath-expected.png: Added.
* platform/efl/svg/batik/text/longTextOnPath-expected.txt:
* platform/efl/svg/batik/text/smallFonts-expected.png: Added.
* platform/efl/svg/batik/text/smallFonts-expected.txt:
* platform/efl/svg/batik/text/textAnchor2-expected.png: Added.
* platform/efl/svg/batik/text/textAnchor3-expected.png: Added.
* platform/efl/svg/batik/text/textDecoration-expected.png: Added.
* platform/efl/svg/batik/text/textDecoration-expected.txt:
* platform/efl/svg/batik/text/textDecoration2-expected.png: Added.
* platform/efl/svg/batik/text/textEffect-expected.png: Added.
* platform/efl/svg/batik/text/textEffect-expected.txt:
* platform/efl/svg/batik/text/textEffect2-expected.png: Added.
* platform/efl/svg/batik/text/textEffect2-expected.txt:
* platform/efl/svg/batik/text/textEffect3-expected.png: Added.
* platform/efl/svg/batik/text/textEffect3-expected.txt:
* platform/efl/svg/batik/text/textFeatures-expected.png: Added.
* platform/efl/svg/batik/text/textFeatures-expected.txt:
* platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
* platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* platform/efl/svg/batik/text/textLayout-expected.png: Added.
* platform/efl/svg/batik/text/textLayout-expected.txt:
* platform/efl/svg/batik/text/textLayout2-expected.png: Added.
* platform/efl/svg/batik/text/textLayout2-expected.txt:
* platform/efl/svg/batik/text/textLength-expected.png: Added.
* platform/efl/svg/batik/text/textLength-expected.txt:
* platform/efl/svg/batik/text/textOnPath2-expected.png: Added.
* platform/efl/svg/batik/text/textOnPath2-expected.txt:
* platform/efl/svg/batik/text/textOnPathSpaces-expected.png: Added.
* platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/efl/svg/batik/text/textPCDATA-expected.png: Added.
* platform/efl/svg/batik/text/textPosition-expected.png: Added.
* platform/efl/svg/batik/text/textPosition-expected.txt:
* platform/efl/svg/batik/text/textPosition2-expected.png: Added.
* platform/efl/svg/batik/text/textPosition2-expected.txt:
* platform/efl/svg/batik/text/textProperties-expected.png: Added.
* platform/efl/svg/batik/text/textProperties-expected.txt:
* platform/efl/svg/batik/text/textStyles-expected.png: Added.
* platform/efl/svg/batik/text/textStyles-expected.txt:
* platform/efl/svg/batik/text/verticalText-expected.png: Added.
* platform/efl/svg/batik/text/verticalText-expected.txt:
* platform/efl/svg/batik/text/xmlSpace-expected.png: Added.
* platform/efl/svg/batik/text/xmlSpace-expected.txt:
* platform/efl/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 17:13:47 +0000 (17:13 +0000)]
Web Inspector: open file dialog is not centered.
https://bugs.webkit.org/show_bug.cgi?id=84464
Reviewed by Yury Semikhatsky.
There was an error in the positioning logic.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.position):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 20 Apr 2012 17:07:38 +0000 (17:07 +0000)]
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as TIMEOUT since it's too slow for even SLOW at the moment.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 17:05:12 +0000 (17:05 +0000)]
[Qt] PlatformMouseEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84437
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-20
Reviewed by Kenneth Rohde Christiansen.
* platform/qt/PlatformMouseEventQt.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 16:28:07 +0000 (16:28 +0000)]
Web Inspector: follow up to r114729: more @return annotations added.
https://bugs.webkit.org/show_bug.cgi?id=84447
Reviewed by Yury Semikhatsky.
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.ResourceRevision.prototype.get content):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame.prototype._addRequest):
* inspector/front-end/ResourceUtils.js:
(String.prototype.asParsedURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 16:24:41 +0000 (16:24 +0000)]
Web Inspector: migrate from ScriptsNavigator to NavigatorView in the Styles panel
https://bugs.webkit.org/show_bug.cgi?id=84459
Reviewed by Yury Semikhatsky.
Now that NavigatorView has all the functionality we need, we can use it.
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._itemSelected):
(WebInspector.StylesPanel.prototype._showFile):
* inspector/front-end/navigatorView.css:
(.navigator-tabbed-pane .tabbed-pane-content):
(.navigator-tabbed-pane .navigator-container):
(.navigator-tabbed-pane .navigator):
(.navigator-tabbed-pane .tabbed-pane-header):
(.navigator-tabbed-pane .tabbed-pane-header-contents):
* inspector/front-end/scriptsPanel.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Fri, 20 Apr 2012 16:15:48 +0000 (16:15 +0000)]
Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203
Reviewed by Simon Fraser.
This test compares CSS div's n a ref-test with a single spec for transform-origin
to SVG rects with multipe specs for transform-origin that are supposed
to all be equivalent, such as [50%,50%] and [center, center]. It fails
due to one-pixel differences on Chromium.
This change renders as many divs in the ref-test as SVG rects in the
test, and ends up with the same result. It seems likely that one of
the several specs that are used is computed slightly differently
(maybe 50% is not the same as center).
* platform/chromium/test_expectations.txt:
* svg/transforms/transform-origin-css-property-expected.xhtml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Fri, 20 Apr 2012 16:13:05 +0000 (16:13 +0000)]
Remove empty svg/misc directory
https://bugs.webkit.org/show_bug.cgi?id=79917
Unreviewed test directory cleanup.
* svg/misc: Removed.
* svg/misc/resources: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Fri, 20 Apr 2012 16:11:03 +0000 (16:11 +0000)]
SVG anchor on use fails
https://bugs.webkit.org/show_bug.cgi?id=81122
Reviewed by Rob Buis.
Adding a ref test for this bug. This seems to have been fixed, but a
regression test is in order.
* svg/custom/anchor-on-use-expected.svg: Added.
* svg/custom/anchor-on-use.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 16:08:08 +0000 (16:08 +0000)]
[EFL] Add Security Origin API
https://bugs.webkit.org/show_bug.cgi?id=84023
Source/WebKit:
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
* PlatformEfl.cmake:
Source/WebKit/efl:
Added an API to get a Security Origin handle from a Ewk_Frame. This is
needed for fine grained security policy. This new API will also allow
to define quota and get usage information of a Web Storage based on its
Security Origin.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
* ewk/EWebKit.h:
* ewk/ewk_frame.cpp:
(ewk_frame_security_origin_get):
* ewk/ewk_frame.h:
* ewk/ewk_security_origin.cpp: Added.
(ewk_security_origin_protocol_get):
(ewk_security_origin_host_get):
(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_free):
(ewk_security_origin_new):
* ewk/ewk_security_origin.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 15:45:52 +0000 (15:45 +0000)]
Web Inspector: Does not have search navigation button for going through matches in either direction (prev, next)
https://bugs.webkit.org/show_bug.cgi?id=84235
Added buttons for navigating on seiarch matches in inspector panel
through button clicks as well.
Patch by Sam D <dsam2912@gmail.com> on 2012-04-20
Reviewed by Pavel Feldman.
No new tests / ux enhanced for search functionality
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* inspector/front-end/Images/searchNext.png: Added.
* inspector/front-end/Images/searchPrev.png: Added.
* inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
(WebInspector.SearchController.prototype._populateSearchNavigationButtons):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.toolbar-search-item):
(#search):
(#toolbar-search-navigation-control):
(.toolbar-search-navigation-label):
(.toolbar-search-navigation-label:hover):
(.toolbar-search-navigation-icon-prev , .toolbar-search-navigation-icon-next):
(.toolbar-search-navigation-icon-prev):
(.toolbar-search-navigation-icon-next):
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 20 Apr 2012 15:38:07 +0000 (15:38 +0000)]
2012-04-20 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as slow in release mode.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 14:54:25 +0000 (14:54 +0000)]
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=73991
Unmark passing tests (Vista & Win7):
fast/text/international/complex-character-based-fallback.html
fast/text/international/danda-space.html
fast/text/international/thai-baht-space.html
fast/text/international/chromium-complex-text-non-printable.html
platform/win/fast/text/uniscribe-missing-glyph.html
fast/text/international/bidi-neutral-run.html
fast/text/international/thai-line-breaks.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 14:36:21 +0000 (14:36 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 13:33:02 +0000 (13:33 +0000)]
Web Inspector: extract NavigatorView and NavigatorOverlayController from ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=84441
Reviewed by Yury Semikhatsky.
Source/WebCore:
- Moves NavigatorOverlayController out of ScriptsNavigator
- Extracts NavigatorView from ScriptsNavigator and makes ScriptsNavigator contain 3 NavigatorView instances (one per tab)
- Subclasses SnippetsNavigatorView and leaves it within ScriptsNavigator.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/NavigatorOverlayController.js: Added.
(WebInspector.NavigatorOverlayController.prototype.wasShown):
(WebInspector.NavigatorOverlayController.prototype._createNavigatorControlButton):
(WebInspector.NavigatorOverlayController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
* inspector/front-end/NavigatorView.js: Added.
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype._updateScriptTitle.get if):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._scriptSelected):
(WebInspector.NavigatorView.prototype._removeUISourceCode.get while):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._showScriptFoldersSettingChanged):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.get titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.get folderIdentifier):
(WebInspector.NavigatorFolderTreeElement.prototype.get isDomain):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement):
(WebInspector.NavigatorScriptTreeElement.prototype.get uiSourceCode):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onspace):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype._scriptSelected):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.SnippetsNavigatorView):
(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
(WebInspector.SnippetsNavigatorView.prototype._fileRenamed):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/navigatorView.css: Added.
(.navigator-domain-tree-item .icon):
(.navigator-folder-tree-item .icon):
(.navigator-script-tree-item .icon):
(.navigator li):
(.navigator :focus li.selected):
(.navigator li.selected .selection):
(.navigator :focus li.selected .selection):
(.navigator .search-match-found li.selected .selection):
(.navigator .search-match-not-found li.selected .selection):
(.navigator .searching li.selected .selection):
(.navigator .icon):
(.navigator .base-navigator-tree-element-title):
(.navigator .base-navigator-tree-element-title.editing):
(.navigator-tree-search-box):
(.navigator-tree-search-box.visible):
(.navigator-tree-search-box > input):
* inspector/front-end/scriptsPanel.css:
LayoutTests:
* http/tests/inspector/debugger-test.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 12:59:51 +0000 (12:59 +0000)]
[Chromium] Unreviewed test results update
http://code.google.com/p/chromium/issues/detail?id=123809
Rebaseline tests after Skia roll. There was a comment saying
"Rebaseline after Skia rev. 3695 lands", while Skia is
already at r3729.
* platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
* platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
* platform/chromium-linux/fast/backgrounds/background-leakage-expected.png:
* platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-linux/svg/hixie/perf/001-expected.png:
* platform/chromium-linux/svg/hixie/perf/002-expected.png:
* platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png:
* platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
* platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
* platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
* platform/chromium-mac/fast/borders/border-styles-split-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Removed.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Removed.
* platform/chromium-mac/svg/hixie/perf/001-expected.png:
* platform/chromium-mac/svg/hixie/perf/002-expected.png:
* platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
* platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
* platform/chromium-win/fast/borders/border-styles-split-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-win/svg/hixie/perf/001-expected.png:
* platform/chromium-win/svg/hixie/perf/002-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/borders/border-radius-complex-inner-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 12:30:48 +0000 (12:30 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=29359
Unmark passing fast/forms/date/date-appearance.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 12:07:25 +0000 (12:07 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=83826
Remove now passing test from expectations:
fast/text/drawBidiText.html
fast/text/international/bidi-listbox-atsui.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 11:58:21 +0000 (11:58 +0000)]
Web Inspector: make ScriptNavigatorController use views only, rename to NavigatorOverlayController.
https://bugs.webkit.org/show_bug.cgi?id=84352
Reviewed by Vsevolod Vlasov.
This change makes navigator controller use view interfaces only. Focus machinery has been refactored in order
to make it possible: now all view ancestors can either override "focus" or "defaultFocusedElement" method
with latter method being preferred.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.defaultFocusedElement):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.defaultFocusedElement):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):
* inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.defaultFocusedElement):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.get view):
(WebInspector.TabbedEditorContainer.prototype.get visibleView):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.defaultFocusedElement):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.defaultFocusedElement):
(WebInspector.TextEditorMainPanel.prototype.defaultFocusedElement):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.defaultFocusedElement):
* inspector/front-end/View.js:
(WebInspector.View.prototype._collectViewHierarchy):
(WebInspector.View.prototype.defaultFocusedElement):
(WebInspector.View.prototype.setDefaultFocusedElement):
(WebInspector.View.prototype.focus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 11:57:56 +0000 (11:57 +0000)]
[Chromium] Unreviewed test expectations update.
http://code.google.com/p/chromium/issues/detail?id=124313
Mark fast/css/font-face-opentype.html and fast/css/font-face-woff.html
as crashing on Debug XP.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 11:48:06 +0000 (11:48 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84432
Mark several fast/filesystem tests as failing on Windows.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 10:56:43 +0000 (10:56 +0000)]
[EFL] [DRT] Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=82867
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
Reviewed by Daniel Bates.
Tools:
Add support for EFL DumpRenderTree EventSender to send
double click events.
* DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
LayoutTests:
Unskip tests connected with double click simulation.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 20 Apr 2012 10:54:06 +0000 (10:54 +0000)]
[GTK] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=42432
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Added WebTiming support to the GTK+ port. WebTiming allows
developers to collect detailed network timing information per
resource. It requires the new SoupMessage's "network-event"
signal.
* GNUmakefile.am:
* bindings/gobject/GNUmakefile.am:
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::milisecondsSinceRequest):
(WebCore::wroteBodyCallback):
(WebCore::requestStartedCallback):
(WebCore::networkEventCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::defaultSession):
Tools:
Build web timing by default whenever build-webkit is used.
* Scripts/build-webkit:
LayoutTests:
Removed some tests that are working fine now after adding Web
Timing support.
* platform/gtk/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 10:28:14 +0000 (10:28 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
PASS/TIMEOUT on Mac and Win debug.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 10:02:33 +0000 (10:02 +0000)]
Not reviewed: fixed chromium sanity tests for inspector via assigning last path component
to entire url for parsed urls with invalid specs.
Source/WebCore:
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
Source/WebKit/chromium:
* src/js/Tests.js:
(.TestSuite.prototype._scriptsAreParsed):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Fri, 20 Apr 2012 09:44:46 +0000 (09:44 +0000)]
[EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
https://bugs.webkit.org/show_bug.cgi?id=84430
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 20 Apr 2012 09:30:35 +0000 (09:30 +0000)]
Unreviewed, rolling out r114401.
http://trac.webkit.org/changeset/114401
https://bugs.webkit.org/show_bug.cgi?id=84161
Chromium crash
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(NativeToJSValue):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 20 Apr 2012 09:29:18 +0000 (09:29 +0000)]
Unreviewed, rolling out r114440.
http://trac.webkit.org/changeset/114440
https://bugs.webkit.org/show_bug.cgi?id=84173
Chromium crash
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 20 Apr 2012 09:28:13 +0000 (09:28 +0000)]
Unreviewed, rolling out r114519.
http://trac.webkit.org/changeset/114519
https://bugs.webkit.org/show_bug.cgi?id=84202
Chromium crash
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* dom/make_names.pl:
(printWrapperFactoryCppFile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 20 Apr 2012 09:15:13 +0000 (09:15 +0000)]
Web Inspector: replace @type annotation with @return annotation for getters
https://bugs.webkit.org/show_bug.cgi?id=84362
Reviewed by Yury Semikhatsky.
Otherwise, compiler does not check for errors.
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.get searchConfig):
* inspector/front-end/BreakpointManager.js:
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.requestContent):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
* inspector/front-end/ScriptsNavigator.js:
* inspector/front-end/Settings.js:
* inspector/front-end/SnippetsModel.js:
* inspector/front-end/SplitView.js:
* inspector/front-end/TabbedEditorContainer.js:
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab):
* inspector/front-end/TextEditorModel.js:
* inspector/front-end/TimelinePresentationModel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pilgrim@chromium.org [Fri, 20 Apr 2012 08:49:18 +0000 (08:49 +0000)]
[Chromium] Call cacheMetadata directly
https://bugs.webkit.org/show_bug.cgi?id=84415
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pilgrim@chromium.org [Fri, 20 Apr 2012 08:41:08 +0000 (08:41 +0000)]
[Chromium] Call stopSharedTimer directly
https://bugs.webkit.org/show_bug.cgi?id=84418
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/SharedTimerChromium.cpp:
(WebCore::stopSharedTimer):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 07:50:54 +0000 (07:50 +0000)]
[Chromium] Unreviewed test results update.
Remove unneeded test results.
* platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 20 Apr 2012 07:42:27 +0000 (07:42 +0000)]
REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
https://bugs.webkit.org/show_bug.cgi?id=84424
Reviewed by Mark Rowe.
Let Windows and Chromium have their own list of files to copy.
* BuildSlaveSupport/built-product-archive:
(removeDirectoryIfExists):
(copyBuildFiles):
(archiveBuiltProduct):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 07:40:12 +0000 (07:40 +0000)]
DOMFileSystem::scheduleCallback() crashes on file() call after reload.
https://bugs.webkit.org/show_bug.cgi?id=76461
DOMFileSystem::scheduleCallback() is unavailable when the page in unloading, so we should
avoid using it in callback.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-04-20
Reviewed by David Levin.
Source/WebCore:
Test: fast/filesystem/file-after-reload-crash.html
* Modules/filesystem/DOMFileSystem.cpp:
(WebCore):
LayoutTests:
* fast/filesystem/file-after-reload-crash-expected.txt: Added.
* fast/filesystem/file-after-reload-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 20 Apr 2012 07:33:05 +0000 (07:33 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
timing out on Linux debug.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 07:27:27 +0000 (07:27 +0000)]
[EFL] Add setting API for author and user styles.
https://bugs.webkit.org/show_bug.cgi?id=82860
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
Source/WebKit/efl:
Add missing implementation setAuthorAndUserStylesEnabled to EFL's
DumpRenderTreeSupport.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
Tools:
Implementation of setAuthorAndUserStylesEnabled.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled):
LayoutTests:
Enable test connected with setAuthorAndUserStylesEnabled.
* platform/efl/Skipped:
* platform/efl/fast/css/disabled-author-styles-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 06:58:15 +0000 (06:58 +0000)]
[EFL] Missing keycode translation for space key
https://bugs.webkit.org/show_bug.cgi?id=84153
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19
Reviewed by Antonio Gomes.
Source/WebCore:
Map space key to Unicode value in createKeyMap(), and also set
correct keyname 'space' for space key in createWindowsKeyMap().
Tests: fast/html/details-keyboard-show-hide.html
fast/forms/button-spacebar-click.html
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap):
Tools:
Set keyname for space key before dispatching event.
* DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue):
LayoutTests:
Unskip tests connected with space key.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 20 Apr 2012 06:47:52 +0000 (06:47 +0000)]
[GTK] Allow to use WebInspector in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=84143
Reviewed by Martin Robinson.
* GNUmakefile.am: Add new files to compilation.
* GtkLauncher/LauncherInspectorWindow.c: Added.
(launcherInspectorWindowFinalize):
(launcher_inspector_window_init):
(launcher_inspector_window_class_init):
(inspectedURIChanged): Update the window title based on current
inspected URI.
(showInspectorWindow): Show inspector window.
(closeInspectorWindow): Hide inspector window.
(launcherInspectorWindowNew): Create an inspector window.
(launcherInspectorWindowGetWebView): Return the inspected web view.
* GtkLauncher/LauncherInspectorWindow.h: Added.
* GtkLauncher/main.c:
(inspectorInspectWebViewCb): Create an inspector window.
(createBrowser): Connect to inspect-web-view signal of the view
inspector.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 20 Apr 2012 06:44:45 +0000 (06:44 +0000)]
[GTK] Ignore resources while replacing content in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79777
Reviewed by Philippe Normand.
* UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
(didSendRequestForResource): Return early if resources is Null.
(didReceiveResponseForResource): Ditto.
(didReceiveContentLengthForResource): Ditto.
(didFinishLoadForResource): Ditto.
(didFailLoadForResource): Ditto.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged): Clear resources before checking
whether we are replacing content.
(webkitWebViewIsReplacingContentOrDidReplaceContent): Helper
function to check whether view is replacing content or current
content is replaced.
(webkitWebViewResourceLoadStarted): Do not create resources when
replacing content.
(webkitWebViewGetLoadingWebResource): Ignore when replacing
content. Also add an assert when getting a loading resources to
make sure we only return Null when replacing content.
(webkitWebViewRemoveLoadingWebResource): Ditto.
(webkitWebViewResourceLoadFinished): Ditto.
* UIProcess/API/gtk/tests/TestResources.cpp:
(replacedContentResourceLoadStartedCallback):
(testWebViewResourcesReplacedContent):
(beforeAll):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 06:18:46 +0000 (06:18 +0000)]
Inserting empty html moves caret.
https://bugs.webkit.org/show_bug.cgi?id=71771
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-04-19
Reviewed by Ryosuke Niwa.
Source/WebCore:
When we place the cursor in the middle of a text node and try to insert some text
between, then we split text node. But in this case we have nothing to insert since
the string to be inserted is empty. So the check for fragments should precedes the
call to code block containing splitTextNode.
Test: editing/inserting/insert-empty-html.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
LayoutTests:
Test inserting empty html.
* editing/inserting/insert-empty-html-expected.txt: Added.
* editing/inserting/insert-empty-html.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Fri, 20 Apr 2012 05:35:07 +0000 (05:35 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 03:35:56 +0000 (03:35 +0000)]
[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=84380
Patch by Tay Grigg <tgrigg@rim.com> on 2012-04-19
Reviewed by George Staikos.
Reviewed Internally by: George Rizkalla, Lyon Chen
Set the limit on the http connection count per host to the default
of 10000, queue the requests in the networking layer instead,
this should increase parallelism at the WebKit layer to remove
any potential bottlenecks.
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 03:29:35 +0000 (03:29 +0000)]
Media Stream API: Piece of code cleanup for the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84328
Patch by Jeremy Mao <yujie.mao@intel.com> on 2012-04-19
Reviewed by Kent Tamura.
Source/WebKit/chromium:
Remove some deprecated interfaces.
No new tests. No behavior changes.
* public/WebUserMediaClient.h:
Remove deprecated requestUserMedia interface.
* public/WebUserMediaRequest.h:
Remove deprecated requestSucceeded interface.
* src/UserMediaClientImpl.cpp:
(WebKit::UserMediaClientImpl::requestUserMedia):
Use the requestUserMedia split sources implementation.
* src/WebUserMediaRequest.cpp:
Remove deprecated requestSucceeded implementation.
Tools:
WebUserMediaClientMock use an old requestUserMedia interface and
Replace it with the new interface.
* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):
Remove the old requestUserMedia and replace it with the new.
* DumpRenderTree/chromium/WebUserMediaClientMock.h:
(WebUserMediaClientMock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 20 Apr 2012 02:32:34 +0000 (02:32 +0000)]
Unreviewed, rolling out r114711.
http://trac.webkit.org/changeset/114711
https://bugs.webkit.org/show_bug.cgi?id=84412
Many tests crash in RenderObject::container() (Requested by
dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 20 Apr 2012 02:07:51 +0000 (02:07 +0000)]
Not reviewed, re-update baselines for new tests
added in http://trac.webkit.org/changeset/114666
and then modified in http://trac.webkit.org/changeset/114685
* platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Removed.
* platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt.
* platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Apr 2012 01:40:56 +0000 (01:40 +0000)]
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/
11285741>
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
in the set if they have scrollbars that are enabled.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
computeNonFastScrollableRegion now takes the main frame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Fri, 20 Apr 2012 00:58:09 +0000 (00:58 +0000)]
[Chromium] IndexedDB: Prep for changing keyPath return type
https://bugs.webkit.org/show_bug.cgi?id=84208
To introduce Array-type key paths (see http://webkit.org/b/84207) the keyPath() accessors
on WebIDBObjectStore and WebIDBIndex need to change return type. To do so requires temporarily
changing the method names to keyPathString with compatibility shims (on the WebKit side)
then switching the implementation in the Chromium port in a follow-up patch.
Reviewed by Kent Tamura.
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPathString):
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPathString):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 20 Apr 2012 00:50:19 +0000 (00:50 +0000)]
Focus ring on wikipedia gets blobs when you type
https://bugs.webkit.org/show_bug.cgi?id=84407
<rdar://problem/
11011847>
Reviewed by Dan Bernstein.
Make it possible to override the focus ring visible rect from layer drawing code.
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.
* platform/mac/ThemeMac.h:
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
and just return the view's visible rect.
(WebCore::ThemeMac::setFocusRingClipRect):
Update the focus clip rect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 20 Apr 2012 00:48:27 +0000 (00:48 +0000)]
Rollout r114674.
New tests added in http://trac.webkit.org/changeset/114685 made the
platform results added in http://trac.webkit.org/changeset/114674
unnecessary.
* platform/mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
* platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ostapenko.viatcheslav@nokia.com [Fri, 20 Apr 2012 00:37:02 +0000 (00:37 +0000)]
[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled for the Qt scenegraph
https://bugs.webkit.org/show_bug.cgi?id=84278
Reviewed by Noam Rosenthal.
Delete the whole layer tree on UI side when paint node is deleted and force resync of the layers when
page becomes visible again.
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::purgeBackingStores):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::appendUpdate):
(WebKit::WebLayerTreeRenderer::setActive):
(WebKit):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::ContentsSGNode):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::purgeBackingStores):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 20 Apr 2012 00:33:11 +0000 (00:33 +0000)]
Partial rollout of r114673.
Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2,
but fails on mac. Update test_expectations so that both results are expected.
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 20 Apr 2012 00:33:05 +0000 (00:33 +0000)]
Unreviewed, rolling out r114690.
http://trac.webkit.org/changeset/114690
https://bugs.webkit.org/show_bug.cgi?id=84408
Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
test_shell_tests (Requested by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 20 Apr 2012 00:17:41 +0000 (00:17 +0000)]
Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.
Also fixed a few LLInt paths that failed to correctly update the
topCallFrame.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* dfg/DFGJITCompiler.h:
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jsc.cpp:
(functionJSCStack):
* llint/LLIntExceptions.cpp:
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* parser/Parser.h:
(JSC::::parse):
* runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
* runtime/Error.h:
(JSC):
LayoutTests:
Update tests to show complete trace information
* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js:
(selfRecursive1):
* fast/js/stack-trace-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 20 Apr 2012 00:12:17 +0000 (00:12 +0000)]
[Chromium] Rebaselining new tests added in trac.webkit.org/changeset/114666
Not reviewed.
* platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Added.
* platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Added.
* platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Fri, 20 Apr 2012 00:11:11 +0000 (00:11 +0000)]
ElementAttributeData should be fast-malloc'd.
<http://webkit.org/b/84405>
Reviewed by Antti Koivisto.
Sprinkle missing WTF_MAKE_FAST_ALLOCATED.
* dom/ElementAttributeData.h:
(ElementAttributeData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Apr 2012 00:08:22 +0000 (00:08 +0000)]
REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
LayoutTests:
* css3/flexbox/css-properties.html:
* fast/css/cssText-shorthand.html:
* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:
* fast/dom/css-dom-read-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Fri, 20 Apr 2012 00:05:37 +0000 (00:05 +0000)]
We're collecting pathologically due to small allocations
https://bugs.webkit.org/show_bug.cgi?id=84404
Reviewed by Geoffrey Garen.
No change in performance on run-jsc-benchmarks.
* dfg/DFGSpeculativeJIT.h: Replacing m_firstFreeCell with m_freeList.
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
* heap/CopiedSpace.cpp: Getting rid of any water mark related stuff, since it's no
longer useful.
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::tryAllocateSlowCase): We now only call didAllocate here rather than
carrying out a somewhat complicated accounting job for our old water mark throughout CopiedSpace.
(JSC::CopiedSpace::tryAllocateOversize): Call the new didAllocate to notify the Heap of
newly allocated stuff.
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::destroy):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying):
* heap/Heap.cpp: Removed water mark related stuff, replaced with new bytesAllocated and
bytesAllocatedLimit to track how much memory has been allocated since the last collection.
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::collect): We now set the new limit of bytes that we can allocate before triggering
a collection to be the size of the Heap after the previous collection. Thus, we still have our
2x allocation amount.
(JSC::Heap::didAllocate): Notifies the GC activity timer of how many bytes have been allocated
thus far and then adds the new number of bytes to the current total.
(JSC):
* heap/Heap.h: Removed water mark related stuff.
(JSC::Heap::notifyIsSafeToCollect):
(Heap):
(JSC::Heap::shouldCollect):
(JSC):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): Refactored to use MarkedBlock's new FreeList struct.
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::zapFreeList): Refactored to take in a FreeList instead of a FreeCell.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
(JSC::MarkedBlock::zapFreeList):
* heap/MarkedBlock.h:
(FreeList): Added a new struct that keeps track of the current MarkedAllocator's
free list including the number of bytes of stuff in the free list so that when the free list is
exhausted, the correct amount can be reported to Heap.
(MarkedBlock):
(JSC::MarkedBlock::FreeList::FreeList):
(JSC):
* heap/MarkedSpace.cpp: Removing all water mark related stuff.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
* heap/MarkedSpace.h:
(MarkedSpace):
(JSC):
* heap/WeakSet.cpp:
(JSC::WeakSet::findAllocator): Refactored to use the didAllocate interface with the Heap. This
function still needs work though now that the Heap knows how many bytes have been allocated
since the last collection.
* jit/JITInlineMethods.h: Refactored to use MarkedBlock's new FreeList struct.
(JSC::JIT::emitAllocateBasicJSObject): Ditto.
* llint/LowLevelInterpreter.asm: Ditto.
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::didAllocate):
* runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::didAllocate): Renamed willAllocate to didAllocate to indicate that
the allocation that is being reported has already taken place.
(DefaultGCActivityCallback):
* runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::didAllocate): Refactored to return early if the amount of
allocation since the last collection is not above a threshold (initially arbitrarily chosen to
be 128KB).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Fri, 20 Apr 2012 00:05:36 +0000 (00:05 +0000)]
[Chromium] Don't compile FontCacheSkia for Android
https://bugs.webkit.org/show_bug.cgi?id=84392
Reviewed by Kent Tamura.
Chromium for the Android platform uses its own FontCacheAndroid
implementation. Compile errors show up when trying to build the
content shell.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Apr 2012 23:54:49 +0000 (23:54 +0000)]
[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
https://bugs.webkit.org/show_bug.cgi?id=83475
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-19
Reviewed by Daniel Bates.
No new tests. This does not change functionality.
Remove some obsolete patch files for Cairo that were used in some
very old versions of Safari for Windows.
* platform/graphics/cairo/rgb24-hacks.txt: Removed.
* platform/graphics/cairo/scale-removal.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 19 Apr 2012 23:52:46 +0000 (23:52 +0000)]
MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
https://bugs.webkit.org/show_bug.cgi?id=84401
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Apr 2012 23:50:39 +0000 (23:50 +0000)]
[EFL] DRT console messages should contain only the file name part of local URIs
https://bugs.webkit.org/show_bug.cgi?id=84236
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-19
Reviewed by Kentaro Hara.
Tools:
Process console messages before printing them in EFL's DumpRenderTree
them so that they contain only the file name part of local URIs. This
is what is expected by test cases.
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(urlSuitableForTestResult):
(onConsoleMessage):
LayoutTests:
Remove from the skip list the tests which expect only the file name
part of local URIs to be displayed in console messages now that it has
been fixed in EFL's DumpRenderTree.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Apr 2012 23:46:20 +0000 (23:46 +0000)]
transforms/no_transform_hit_testing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82415
Patch by Florin Malita <fmalita@google.com> on 2012-04-19
Reviewed by Simon Fraser.
Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results.
* platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/mac/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt/transforms/no_transform_hit_testing-expected.png: Removed.
* platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed.
* transforms/no_transform_hit_testing-expected.txt: Added.
* transforms/no_transform_hit_testing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 19 Apr 2012 23:41:01 +0000 (23:41 +0000)]
[chromium] Unreviewed, update chromium expectations for various compositing layout tests
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc