johnnyg@google.com [Thu, 27 Oct 2011 23:14:18 +0000 (23:14 +0000)]
Unreviewed, new chromium expectations for shading/anti-aliasing changes.
* fast/borders/borderRadiusDashed06-expected.txt: Added.
* platform/chromium-cg-mac-leopard/fast/table/028-vertical-expected.png: Added.
* platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/background-leakage-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size: Added.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/shadow-multiple-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/menulist-clip-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/select-baseline-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/media/audio-repaint-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/media/video-zoom-controls-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/clip-path: Added.
* platform/chromium-cg-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/filters: Added.
* platform/chromium-cg-mac-snowleopard/svg/filters/filter-clip-expected.png: Added.
* platform/chromium-cg-mac/fast/backgrounds/background-leakage-expected.png: Removed.
* platform/chromium-cg-mac/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
* platform/chromium-cg-mac/fast/borders/borderRadiusDashed06-expected.png: Removed.
* platform/chromium-cg-mac/fast/css/shadow-multiple-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/menulist-clip-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/menulist-separator-painting-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/menulist-style-color-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/select-baseline-expected.png: Removed.
* platform/chromium-cg-mac/fast/forms/select-empty-option-height-expected.png: Removed.
* platform/chromium-cg-mac/media/audio-repaint-expected.png: Removed.
* platform/chromium-cg-mac/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-cg-mac/media/video-zoom-controls-expected.txt: Removed.
* platform/chromium-cg-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
* platform/chromium-cg-mac/svg/custom/focus-ring-expected.png: Removed.
* platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/box-shadow: Added.
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/menulist-narrow-width-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/menulist-separator-painting-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select-empty-option-height-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text: Added.
* platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png: Added.
* platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-zoom-controls-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/clip-path: Added.
* platform/chromium-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom: Added.
* platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/filter-clip-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/background-leakage-expected.png: Removed.
* platform/chromium-mac/fast/borders/borderRadiusDashed06-expected.png: Removed.
* platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
* platform/chromium-mac/fast/css/shadow-multiple-expected.png: Removed.
* platform/chromium-mac/fast/forms/menulist-clip-expected.png: Removed.
* platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Removed.
* platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Removed.
* platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Removed.
* platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Removed.
* platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Removed.
* platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
* platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Removed.
* platform/chromium-mac/fast/text/emphasis-overlap-expected.png: Removed.
* platform/chromium-mac/media/audio-repaint-expected.png: Removed.
* platform/chromium-mac/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-mac/media/video-zoom-controls-expected.txt: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Removed.
* platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
* platform/chromium-mac/svg/custom/focus-ring-expected.png: Removed.
* platform/chromium-mac/svg/filters/filter-clip-expected.png: Removed.
* platform/chromium-win-xp/media: Added.
* platform/chromium-win-xp/media/video-zoom-controls-expected.png: Added.
* platform/chromium-win-xp/media/video-zoom-controls-expected.txt: Added.
* platform/chromium/media/video-zoom-controls-expected.txt: Added.
* platform/gtk/fast/borders/borderRadiusDashed06-expected.txt: Removed.
* platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
* platform/mac/fast/borders/borderRadiusDashed06-expected.txt: Removed.
* platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
* platform/qt/fast/borders/borderRadiusDashed06-expected.txt: Removed.
* platform/qt/svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
* platform/win-xp/media/audio-repaint-expected.txt: Removed.
* svg/clip-path/clip-path-childs-clipped-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 23:06:26 +0000 (23:06 +0000)]
[GStreamer] Prevent memory leak when fullscreening a video
https://bugs.webkit.org/show_bug.cgi?id=71043
Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2011-10-27
Reviewed by Gustavo Noronha Silva.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::GStreamerGWorld):
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/GStreamerGWorld.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 22:51:40 +0000 (22:51 +0000)]
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-10-27
Reviewed by David Kilzer.
Make FeatureDefines Identical Across OS X Projects
https://bugs.webkit.org/show_bug.cgi?id=71051
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 27 Oct 2011 22:38:31 +0000 (22:38 +0000)]
Web Inspector: HTTP headers merged incorrect in Chrome
https://bugs.webkit.org/show_bug.cgi?id=69674
Reviewed by Pavel Feldman.
* src/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 22:34:59 +0000 (22:34 +0000)]
Correctly Guard Exported REQUEST_ANIMATION_FRAME Symbols
https://bugs.webkit.org/show_bug.cgi?id=71047
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-10-27
Reviewed by David Kilzer.
* WebCore.exp.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 27 Oct 2011 22:19:14 +0000 (22:19 +0000)]
Crash in JSC::Structure::materializePropertyMap when viewing Garden-O-Matic
https://bugs.webkit.org/show_bug.cgi?id=71045
Reviewed by Geoff Garen.
Make sure that if a structure is pinned, it also has a property map.
* runtime/Structure.cpp:
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTableForPinning):
* runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 27 Oct 2011 22:07:32 +0000 (22:07 +0000)]
Rename Plugin::geometryDidChange to Plugin::deprecatedGeometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71065
Reviewed by Simon Fraser.
In preparation for adding a version of geometryDidChange that doesn't take window coordinates.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::deprecatedGeometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::deprecatedGeometryDidChange):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::deprecatedGeometryDidChange):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 22:05:17 +0000 (22:05 +0000)]
Unreviewed, rolling out r98626.
http://trac.webkit.org/changeset/98626
https://bugs.webkit.org/show_bug.cgi?id=71066
Does not compile on cr-win (Requested by jamesr_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-27
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 27 Oct 2011 21:56:57 +0000 (21:56 +0000)]
Fix a compiler warning caught by gcc 4.6.1. Need to return something.
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::nextAction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Thu, 27 Oct 2011 21:54:11 +0000 (21:54 +0000)]
32bit build failure after r98624
https://bugs.webkit.org/show_bug.cgi?id=71064
Disambiguated operator overload with unsigned index (0u).
Reviewed by Sam Weinig.
* runtime/UString.h:
(JSC::operator==):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
annacc@chromium.org [Thu, 27 Oct 2011 21:48:34 +0000 (21:48 +0000)]
Individually Skip track-related LayoutTests rather than block-Skipping them.
https://bugs.webkit.org/show_bug.cgi?id=71037
Reviewed by Adam Barth.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 27 Oct 2011 21:42:48 +0000 (21:42 +0000)]
Web Inspector: Advanced search style fixes.
https://bugs.webkit.org/show_bug.cgi?id=71036
Reviewed by Pavel Feldman.
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView):
* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/inspector.css:
(.search-view .search-panel):
(.search-view .search-panel input[type="search"].search-config-search):
(.search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body:not(.platform-mac) .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body.platform-mac .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(#drawer-status-bar .search-status-bar-progress):
(body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress):
(body.platform-mac #drawer-status-bar .search-status-bar-progress):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 27 Oct 2011 21:29:53 +0000 (21:29 +0000)]
REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=66227
Reviewed by Adam Roben.
I believe this should fix the bug.
* Scripts/run-webkit-tests: make NRWT default for --leaks
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
(LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
(LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
(LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
* Scripts/webkitpy/layout_tests/port/mac.py:
Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 27 Oct 2011 21:21:32 +0000 (21:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71061
[CSS Line Grid] Add support for parsing the line-grid property.
Source/WebCore:
New tests in fast/line-grid.
Reviewed by Dan Bernstein.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::lineGrid):
(WebCore::InheritedFlags::setLineGrid):
(WebCore::InheritedFlags::initialLineGrid):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
LayoutTests:
Reviewed by Dan Bernstein.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/line-grid: Added.
* fast/line-grid/line-grid-parsing-expected.txt: Added.
* fast/line-grid/line-grid-parsing.html: Added.
* fast/line-grid/script-tests: Added.
* fast/line-grid/script-tests/line-grid-parsing.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fsamuel@chromium.org [Thu, 27 Oct 2011 21:09:24 +0000 (21:09 +0000)]
iframes seem to occasionally doubly scale or scale incorrectly when pageScaleFactor != 1.0
https://bugs.webkit.org/show_bug.cgi?id=70552
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/frames/iframe-double-scale-contents.html
The iframe's document style was using the page's scale factor, rather than the frame's (1.0).
If the page scale factor was set after layout was complete, then this would have no impact because the iframe's document style and layout is not recomputed,
but if the page scale factor is set prior to creating and laying out the iframe, the iframe's content would be doubly scaled.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
LayoutTests:
* fast/frames/iframe-double-scale-contents-expected.png: Added.
* fast/frames/iframe-double-scale-contents-expected.txt: Added.
* fast/frames/iframe-double-scale-contents.html: Added.
* fast/frames/resources/iframe-content-scaling-bug-iframe.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Thu, 27 Oct 2011 21:04:32 +0000 (21:04 +0000)]
test_rebaseline_expectations failing
https://bugs.webkit.org/show_bug.cgi?id=71033
Reviewed by Adam Barth.
Resolve overlaps
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 27 Oct 2011 20:55:01 +0000 (20:55 +0000)]
Updated expected results after r98608.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 20:53:53 +0000 (20:53 +0000)]
[Chromium] Need setPrinting
https://bugs.webkit.org/show_bug.cgi?id=46152
Patch by Stephen Chenney <schenney@chromium.org> on 2011-10-27
Reviewed by Hajime Morita.
Source/WebKit/chromium:
* public/WebFrame.h: Added pure virtual prototype for printPagesWithBoundaries. Added enum
and changed parameters for renderTreeAsText.
* src/WebFrameImpl.cpp:
(WebKit::ChromePrintContext::spoolAllPagesWithBoundaries): Added this method, based on
the static in PrintContext. This uses Chromium specific page spooling and transforms.
(WebKit::WebFrameImpl::renderTreeAsText): Updated to allow text dump in printed format.
(WebKit::WebFrameImpl::printPagesWithBoundaries): Added method for testing printing page
breaks.
* src/WebFrameImpl.h: Added prototype.
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
(LayoutTestController::reset): Clearing flags for setPrinting.
(LayoutTestController::setPrinting): Set flags for setPrinting.
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
(LayoutTestController::isPrinting): Method to return the setPrinting status.
* DumpRenderTree/chromium/TestShell.cpp:
(dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
(TestShell::dump): Modified to dump setPrinting-specific output.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
active.
* DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
LayoutTests:
* platform/chromium/test_expectations.txt: Removing setPrinting tests from the expected failures.
* platform/chromium-linux/printing/setPrinting-expected.png: Added.
* platform/chromium-linux/printing/setPrinting-expected.txt: Added.
* platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
* platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
* platform/chromium-mac/printing/setPrinting-expected.png: Added.
* platform/chromium-mac/printing/setPrinting-expected.txt: Added.
* platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
* platform/chromium-mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
* platform/chromium-win/printing/setPrinting-expected.png: Added.
* platform/chromium-win/printing/setPrinting-expected.txt: Added.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
* platform/mac/printing/setPrinting-expected.png: Rebaselined for the change to the test html.
* platform/mac/printing/setPrinting-expected.txt: Rebaselined for the change to the test html.
* printing/setPrinting.html: Modified the test to make the box have a colored border
instead of the solid background, as the solid background does not print on chromium.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Thu, 27 Oct 2011 20:52:56 +0000 (20:52 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Thu, 27 Oct 2011 20:43:41 +0000 (20:43 +0000)]
[EFL] Unreviewed. Add pixel test baselines for animations,
compositing, dom, editing, fonts, mathml, media, printing,
transforms and transitions.
* platform/efl/animations: [...]
* platform/efl/compositing: [...]
* platform/efl/dom: [...]
* platform/efl/editing: [...]
* platform/efl/fonts: [...]
* platform/efl/mathml: [...]
* platform/efl/media: [...]
* platform/efl/printing: [...]
* platform/efl/transforms: [...]
* platform/efl/transitions: [...]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Thu, 27 Oct 2011 20:42:54 +0000 (20:42 +0000)]
Unreviewed, fix CCSchedulerStateMachine build errors.
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 27 Oct 2011 20:41:05 +0000 (20:41 +0000)]
Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431
Patch by Antoine Labour <piman@chromium.org> on 2011-10-27
Reviewed by James Robinson.
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::~WebLayerImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 20:40:29 +0000 (20:40 +0000)]
Fix building on GNU/kFreeBSD
https://bugs.webkit.org/show_bug.cgi?id=71005
Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-10-27
Reviewed by Darin Adler.
* config.h:
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 27 Oct 2011 20:30:08 +0000 (20:30 +0000)]
fix sizing of auto sized flexbox
https://bugs.webkit.org/show_bug.cgi?id=70839
Reviewed by David Hyatt.
Source/WebCore:
Correctly set the height of the flexbox when we have a column flow
and the height is auto.
Tests: css3/flexbox/columns-auto-size.html
css3/flexbox/flex-flow-margins-auto-size.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Always computeLogicalHeight() after we're done placing children.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): Set the height as we place children.
LayoutTests:
* css3/flexbox/columns-auto-size-expected.txt: Added.
* css3/flexbox/columns-auto-size.html: Added.
* css3/flexbox/flex-flow-margins-auto-size-expected.txt: Added.
* css3/flexbox/flex-flow-margins-auto-size.html: Added.
A bunch of these cases fail, but that's because of bug 70769.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Thu, 27 Oct 2011 20:28:40 +0000 (20:28 +0000)]
Source/WebCore: Add support for creating compositing layers for fixed position elements.
https://bugs.webkit.org/show_bug.cgi?id=69796
position:fixed elements will get a compositing layer if:
1. Settings:acceleratedCompositingForFixedPositionEnabled() returns true,
2. The element has its own stacking context (e.g. has a z-index), and
3. The element's container is the RenderView (e.g. not a descendant of a transformed element)
Reviewed by Simon Fraser.
Test: compositing/geometry/fixed-position-composited-switch.html
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForFixedPositionEnabled):
(WebCore::Settings::acceleratedCompositingForFixedPositionEnabled):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderLayerCompositor.h:
* testing/Internals.cpp:
(WebCore::Internals::setEnableCompositingForFixedPosition):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests: Adding tests for fixed positioned elements getting their own composited layer.
https://bugs.webkit.org/show_bug.cgi?id=69796
Reviewed by Simon Fraser.
* compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* compositing/geometry/fixed-position-composited-switch.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 20:20:27 +0000 (20:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70390
Ensure font load for Skia backend during printing.
Patch by Arthur Hsu <arthurhsu@chromium.org> on 2011-10-27
Reviewed by James Robinson.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Thu, 27 Oct 2011 20:16:20 +0000 (20:16 +0000)]
Investigate storing strings in 8-bit buffers when possible
https://bugs.webkit.org/show_bug.cgi?id=66161
Source/JavaScriptCore:
Investigate storing strings in 8-bit buffers when possible
https://bugs.webkit.org/show_bug.cgi?id=66161
Added support for 8 bit string data in StringImpl. Changed
(UChar*) m_data to m_data16. Added char* m_data8 as a union
with m_data16. Added UChar* m_copyData16 to the other union
to store a 16 bit copy of an 8 bit string when needed.
Added characters8() and characters16() accessor methods
that assume the caller has checked the underlying string type
via the new is8Bit() method. The characters() method will
return a UChar* of the string, materializing a 16 bit copy if the
string is an 8 bit string. Added two flags, one for 8 bit buffer
and a second for a 16 bit copy for an 8 bit string.
Fixed method name typo (StringHasher::defaultCoverter()).
Over time the goal is to eliminate calls to characters() and
us the character8() and characters16() accessors.
This patch does not include changes that actually create 8 bit
strings. This is the first of at least 8 patches. Subsequent
patches will be submitted for JIT changes, making the JSC lexer,
parser and literal parser, JavaScript string changes and
then changes in webcore to take advantage of the 8 bit strings.
This change is performance neutral for SunSpider and V8 when
run from the command line with "jsc".
Reviewed by Geoffrey Garen.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::UStringSourceProvider):
* runtime/Identifier.cpp:
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::Identifier::toUInt32):
* runtime/Identifier.h:
(JSC::Identifier::equal):
(JSC::operator==):
(JSC::operator!=):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstringsWithSeparators):
* runtime/UString.cpp:
(JSC::UString::UString):
(JSC::equalSlowCase):
(JSC::UString::utf8):
* runtime/UString.h:
(JSC::UString::characters):
(JSC::UString::characters8):
(JSC::UString::characters16):
(JSC::UString::is8Bit):
(JSC::UString::operator[]):
(JSC::UString::find):
(JSC::operator==):
* wtf/StringHasher.h:
(WTF::StringHasher::computeHash):
(WTF::StringHasher::defaultConverter):
* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::AtomicString::add):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::contains):
(WTF::AtomicString::find):
(WTF::AtomicString::add):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):
* wtf/text/StringConcatenate.h:
* wtf/text/StringHash.h:
(WTF::StringHash::equal):
(WTF::CaseFoldingHash::hash):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::create):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::containsOnlyWhitespace):
(WTF::StringImpl::substring):
(WTF::StringImpl::characterStartingAt):
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
(WTF::StringImpl::fill):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::stripMatchedCharacters):
(WTF::StringImpl::removeCharacters):
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::replace):
(WTF::StringImpl::defaultWritingDirection):
(WTF::StringImpl::adopt):
(WTF::StringImpl::createWithTerminatingNullCharacter):
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::create):
(WTF::StringImpl::create8):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::flagsOffset):
(WTF::StringImpl::flagIs8Bit):
(WTF::StringImpl::dataOffset):
(WTF::StringImpl::is8Bit):
(WTF::StringImpl::characters8):
(WTF::StringImpl::characters16):
(WTF::StringImpl::characters):
(WTF::StringImpl::has16BitShadow):
(WTF::StringImpl::setHash):
(WTF::StringImpl::hash):
(WTF::StringImpl::copyChars):
(WTF::StringImpl::operator[]):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::equal):
(WTF::equalIgnoringCase):
(WTF::StringImpl::isolatedCopy):
* wtf/text/WTFString.cpp:
(WTF::String::String):
(WTF::String::append):
(WTF::String::format):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
* wtf/text/WTFString.h:
(WTF::String::find):
(WTF::String::findIgnoringCase):
(WTF::String::contains):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::operator==):
(WTF::operator!=):
(WTF::equalIgnoringCase):
* wtf/unicode/Unicode.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::execute):
* yarr/YarrJIT.h:
(JSC::Yarr::YarrCodeBlock::execute):
* yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
Source/WebCore:
Changes to support 8 bit StringImpl changes.
Reviewed by Geoffrey Garen.
No new tests, refactored StringImpl for 8 bit strings.
* platform/text/cf/StringImplCF.cpp:
(WTF::StringImpl::createCFString):
Source/WebKit2:
Added export of StringImpl::getData16SlowCase for linking tests.
Reviewed by Geoffrey Garen.
* win/WebKit2.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 27 Oct 2011 20:08:14 +0000 (20:08 +0000)]
Unreviewed, more chromium baselines for new multicol tests.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol: Removed.
* platform/chromium-linux/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-linux/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-linux/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-linux/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 27 Oct 2011 20:01:59 +0000 (20:01 +0000)]
Add allowsPlugIns property to WKBrowsingContextGroup
https://bugs.webkit.org/show_bug.cgi?id=70987
Reviewed by Anders Carlsson.
Source/WebKit2:
Test: WKBrowsingContextGroupTest.GetSetPluginsEnabled
* UIProcess/API/mac/WKBrowsingContextGroup.h:
* UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
Rename to allowsJavaScript/setAllowsJavaScript.
(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
Add allowsPlugIns/setAllowsPlugIns.
Tools:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
Add basic test for WKBrowsingContextGroup.allowsPlugIns.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 27 Oct 2011 19:57:39 +0000 (19:57 +0000)]
Unreviewed, rebaselines after multi-col changes.
* platform/chromium-win-vista/fast/css/getComputedStyle: Added.
* platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/chromium-win-xp/fast/css/getComputedStyle: Added.
* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/chromium/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
* platform/chromium/svg/css: Added.
* platform/chromium/svg/css/getComputedStyle-basic-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 19:52:48 +0000 (19:52 +0000)]
[Qt] Failure to build when QT_NO_MENU defined
https://bugs.webkit.org/show_bug.cgi?id=70970
Patch by Helder Correia <helder.correia@palm.com> on 2011-10-27
Reviewed by Andreas Kling.
iterateContextMenu() must be wrapped around #ifndef QT_NO_MENU.
Build fix, no new tests.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Thu, 27 Oct 2011 19:33:29 +0000 (19:33 +0000)]
[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
https://bugs.webkit.org/show_bug.cgi?id=70714
Source/WebCore:
Reland of ill-fated r98612.
Reviewed by James Robinson.
* WebCore.gypi:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):
Source/WebKit/chromium:
Reviewed by James Robinson.
* WebKit.gypi:
* tests/CCSchedulerStateMachineTest.cpp: Added.
(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 27 Oct 2011 19:22:31 +0000 (19:22 +0000)]
Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816
Reviewed by Adam Barth.
Optional parameters in the middle are prohibited by WebIDL spec.
Source/WebCore:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:
LayoutTests:
* fast/canvas/canvas-putImageData-expected.txt: expectation was wrong, context.putImageData({}, 0, 0) should throw Type Error.
* fast/canvas/canvas-putImageData.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 27 Oct 2011 19:16:15 +0000 (19:16 +0000)]
unreviewed, test expectations
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 27 Oct 2011 19:15:05 +0000 (19:15 +0000)]
REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
https://bugs.webkit.org/show_bug.cgi?id=71032
Reviewed by Dave Hyatt.
If we apply an explicitly inherited property, we need to apply any further
non-inherited properties as the property might get overridden again.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
* css/CSSStyleSelector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 27 Oct 2011 19:12:39 +0000 (19:12 +0000)]
Remove RenderTableSection::m_gridRows
https://bugs.webkit.org/show_bug.cgi?id=70570
Reviewed by Darin Adler.
No new test, refactoring only.
Just nuke the old field that was duplicating
m_grid.size().
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::numRows):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paint):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::clearGrid):
(WebCore::RenderTableSection::numColumns):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
s/m_gridRows/m_grid.size()/.
Also updated the code as m_grid.size() is unsigned.
(WebCore::RenderTableSection::recalcCells):
The old code would keep the grid's memory but we have to clear it to properly
count the elements. To avoid lots of small reallocations, we reallocate the
buffer at the old capacity upfront.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Thu, 27 Oct 2011 18:45:28 +0000 (18:45 +0000)]
Unreviewed, rolling out r98612.
http://trac.webkit.org/changeset/98612
https://bugs.webkit.org/show_bug.cgi?id=70714
Broke build
Source/WebCore:
* WebCore.gypi:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.
Source/WebKit/chromium:
* WebKit.gypi:
* tests/CCSchedulerStateMachineTest.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nduca@chromium.org [Thu, 27 Oct 2011 18:29:40 +0000 (18:29 +0000)]
[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
https://bugs.webkit.org/show_bug.cgi?id=70714
Reviewed by James Robinson.
Source/WebCore:
* WebCore.gypi:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):
Source/WebKit/chromium:
* WebKit.gypi:
* tests/CCSchedulerStateMachineTest.cpp: Added.
(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 27 Oct 2011 17:59:32 +0000 (17:59 +0000)]
<rdar://problem/
10262205> Allow column progression to be independent of writing mode
https://bugs.webkit.org/show_bug.cgi?id=71028
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/multicol/block-axis-horizontal-bt.html
fast/multicol/block-axis-horizontal-tb.html
fast/multicol/block-axis-vertical-lr.html
fast/multicol/block-axis-vertical-rl.html
fast/multicol/flipped-blocks-hit-test.html
Allow “columns” to be stacked along the block axis rather than the inline axis. This can facilitate
paginated interfaces. A column-axis property is added in order to enable this mode.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the column-axis property.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Ditto.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map ColumnAxis values to identifiers.
(WebCore::CSSPrimitiveValue::operator ColumnAxis): Map identifiers to ColumnAxis values.
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): Updated to return false for the column-axis property.
* css/CSSPropertyNames.in: Added -webkit-column-axis.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Handle column-axis.
* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo): Added m_progressionAxis to the initialization list.
(WebCore::ColumnInfo::progressionAxis): Added this getter.
(WebCore::ColumnInfo::setProgressionAxis): Added this setter.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren): Simplified, and thus also made this function work
with block-axis column progression.
(WebCore::RenderBlock::paintColumnRules): Added code to paint rules between columns with block-axis
progression.
(WebCore::RenderBlock::paintColumnContents): Adjusted the painting offset for the block-axis
column progression case.
(WebCore::RenderBlock::nodeAtPoint): Fixed hit-testing in flipped-blocks writing modes. This is
covered by flipped-blocks-hit-test.html.
(WebCore::RenderBlock::hitTestColumns): Adjusted the offset for the block-axis column progression
case.
(WebCore::RenderBlock::calcColumnWidth): Set the column width to the content logical width in
the block-axis column progression case. The column-width and column-count properties are ignored.
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): Set the column progression axis based on
the style.
(WebCore::RenderBlock::columnCount): Broke up an assertion into two.
(WebCore::RenderBlock::columnRectAt): Updated for block-axis column progression.
(WebCore::RenderBlock::adjustPointToColumnContents): Ditto.
(WebCore::RenderBlock::adjustRectForColumns): Ditto.
(WebCore::RenderBlock::adjustForColumns): Ditto.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns): Adjusted the offser for the block-axis column
progression case.
(WebCore::RenderLayer::hitTestChildLayerColumns): Ditto.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::columnAxis): Added this getter.
(WebCore::InheritedFlags::hasInlineColumnAxis): Added. Checks the column axis against the writing
mode.
(WebCore::InheritedFlags::specifiesColumns): Changed to return true if the specified column axis
is the block axis.
(WebCore::InheritedFlags::setColumnAxis): Added this setter.
(WebCore::InheritedFlags::initialColumnAxis): Added. Returns AutoColumnAxis.
* rendering/style/RenderStyleConstants.h: Added a ColumnAxis enum.
* rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData): Added m_axis to the initialization list.
(WebCore::StyleMultiColData::operator==): Compare m_axis.
* rendering/style/StyleMultiColData.h: Added m_axis member variable.
LayoutTests:
* fast/multicol/block-axis-horizontal-bt.html: Added.
* fast/multicol/block-axis-horizontal-tb.html: Added.
* fast/multicol/block-axis-vertical-lr.html: Added.
* fast/multicol/block-axis-vertical-rl.html: Added.
* fast/multicol/flipped-blocks-hit-test-expected.txt: Added.
* fast/multicol/flipped-blocks-hit-test.html: Added.
* fast/multicol/resources/block-axis.css: Added.
* platform/mac/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/mac/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/mac/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/mac/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/mac/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 27 Oct 2011 17:58:02 +0000 (17:58 +0000)]
Unreviewed, adding additional expected failures.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Thu, 27 Oct 2011 17:55:26 +0000 (17:55 +0000)]
Fixing windows build
Unreviewed build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 27 Oct 2011 17:42:39 +0000 (17:42 +0000)]
Unreviewed, fixing duplicate entries in test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Thu, 27 Oct 2011 17:38:19 +0000 (17:38 +0000)]
Add ability to check for presence of static members at compile time
https://bugs.webkit.org/show_bug.cgi?id=70986
Reviewed by Geoffrey Garen.
Added new CREATE_MEMBER_CHECKER macro to instantiate the template and the
HAS_MEMBER_NAMED macro to use that template to check if the specified class
does indeed have a method with that name. This mechanism is not currently
used anywhere, but will be in the future when adding virtual methods from
JSObject to the MethodTable.
* runtime/ClassInfo.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Thu, 27 Oct 2011 17:33:07 +0000 (17:33 +0000)]
[CSSRegions]Flag regions with custom styling
https://bugs.webkit.org/show_bug.cgi?id=70733
Reviewed by David Hyatt.
Region elements that have custom region styling are now marked accordingly.
Source/WebCore:
Test: fast/regions/render-region-custom-style-mark.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkRegionStyle):
* css/CSSStyleSelector.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::styleDidChange):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::hasCustomRegionStyle):
(WebCore::RenderRegion::setHasCustomRegionStyle):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):
LayoutTests:
* fast/regions/render-region-custom-style-mark.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 27 Oct 2011 17:27:15 +0000 (17:27 +0000)]
[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
https://bugs.webkit.org/show_bug.cgi?id=71027
Reviewed by Martin Robinson.
Fixes windowless plugins in GTK+ port.
* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::paint): When scaleFactor is 1, simply
call the paint method that doesn't receive a scaleFactor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 17:24:49 +0000 (17:24 +0000)]
Unreviewed, rolling out r98556.
http://trac.webkit.org/changeset/98556
https://bugs.webkit.org/show_bug.cgi?id=71031
The test added by the patch doesn't pass on Snow Leopard
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-27
.:
* Source/autotools/symbols.filter:
Source/WebCore:
* editing/TextCheckingHelper.cpp:
(WebCore::checkTextOfParagraph):
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
* editing/spelling/spelling-unified-emulation-expected.txt: Removed.
* editing/spelling/spelling-unified-emulation.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 27 Oct 2011 17:22:18 +0000 (17:22 +0000)]
Temporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
since r98542 regressed it. The failure is tracked by the bug 71032.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Thu, 27 Oct 2011 17:19:28 +0000 (17:19 +0000)]
[skia] replace offscreen technique with native support for antialiased clipping
https://bugs.webkit.org/show_bug.cgi?id=70748
Reviewed by Stephen White.
~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.
Source/WebCore:
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):
* platform/graphics/skia/PlatformContextSkia.h:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Thu, 27 Oct 2011 17:17:39 +0000 (17:17 +0000)]
[EFL] Unreviewed. Add pixel baselines for table tests.
* platform/efl/tables: [...]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 27 Oct 2011 17:04:03 +0000 (17:04 +0000)]
use main/cross instead of logical width/height when talking about flow direction
https://bugs.webkit.org/show_bug.cgi?id=70977
Reviewed by Ojan Vafai.
Flexbox code uses logical in function names to refer to the flow
direction. This is confusing because writing mode also uses logical,
but this is a diffent usage. To avoid confusion, be explicit about
main vs cross axis. Extent is used instead of width/height.
No new tests, just a refactoring.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisLengthForChild):
(WebCore::RenderFlexibleBox::crossAxisLength):
(WebCore::RenderFlexibleBox::setCrossExtent):
(WebCore::RenderFlexibleBox::crossExtentForChild):
(WebCore::RenderFlexibleBox::mainExtentForChild):
(WebCore::RenderFlexibleBox::crossAxisExtent):
(WebCore::RenderFlexibleBox::mainAxisExtent):
(WebCore::RenderFlexibleBox::crossAxisContentExtent):
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent):
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
(WebCore::RenderFlexibleBox::flowAwareLocationForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only
matters in the main axis, there's no reason to deambiguate it here.
(WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment is always
in the cross axis direction, so don't include that in the method name.
(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild): Alignment is always
in the cross axis direction, so don't include that in the method name.
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
* rendering/RenderFlexibleBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Thu, 27 Oct 2011 17:01:38 +0000 (17:01 +0000)]
De-virtualize JSCell::toThisObject
https://bugs.webkit.org/show_bug.cgi?id=70958
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::toThisObject):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::toThisObject):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::toThisObject):
* runtime/JSObject.h:
(JSC::JSValue::toThisObject):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::toThisObject):
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::toThisObject):
* runtime/JSString.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::toThisObject):
* runtime/StrictEvalActivation.h:
Source/WebCore:
No new tests.
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::toThisObject):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bridge/NP_jsobject.cpp:
(_NPN_Invoke):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):
Source/WebKit/mac:
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
Source/WebKit2:
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::invoke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Oct 2011 16:41:50 +0000 (16:41 +0000)]
Windows build fix after r98512
* html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside an appropriate ENABLE
guard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Oct 2011 16:32:00 +0000 (16:32 +0000)]
Regenerate WebCore's Localizable.strings file
All I did was run update-webkit-localizable-strings. A few localizer comments changed, and
some strings (which must have been hand-added) got moved to a different part of the file.
* English.lproj/Localizable.strings:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 27 Oct 2011 16:24:41 +0000 (16:24 +0000)]
Add WKBundlePageGetBackingScaleFactor
Fixes <http://webkit.org/b/71025> <rdar://problem/
10355037> REGRESSION (r97191): Clients
can't reliably determine the scale factor of snapshots returned via
WKBundlePageCreateSnapshot* API
Reviewed by Sam Weinig.
Source/WebKit2:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetBackingScaleFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Added. Calls through to WebPage::deviceScaleFactor.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::deviceScaleFactor):
* WebProcess/WebPage/WebPage.h:
Added. Calls through to Page::deviceScaleFactor.
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
(TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
(TestWebKitAPI::createWindow): Conjure up a window.
(TestWebKitAPI::TEST): Ask the injected bundle code to call the new
WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
factors and when using a custom scale factor, and check that we get those same scale factors
back.
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
(TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
members.
(TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
(TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
from the page using the new API and send it back.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 27 Oct 2011 16:18:11 +0000 (16:18 +0000)]
Unreviewed, GTK rebaseline.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 27 Oct 2011 16:00:29 +0000 (16:00 +0000)]
Unreviewed, skipping 2 new failing tests in GTK.
* platform/gtk/Skipped: Skip
fast/canvas/canvas-composite-image.html and editing/spelling/spelling-unified-emulation.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 27 Oct 2011 15:41:55 +0000 (15:41 +0000)]
2011-10-27 Yury Semikhatsky <yurys@chromium.org>
Rebaseline tables/mozilla_expected_failures/bugs/bug14007-2.html after r98542.
* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Removed.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 15:24:44 +0000 (15:24 +0000)]
Microdata: Add test cases for itemscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=71014
Patch by Arko Saha <arko@motorola.com> on 2011-10-27
Reviewed by Ryosuke Niwa.
* fast/dom/MicroData/itemscope-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemscope-attribute-test.html: Added.
* fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Added.
* fast/dom/MicroData/itemscope-must-be-read-write.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 15:19:22 +0000 (15:19 +0000)]
[Qt][WK2]Add setViewportSize API to WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=71006
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.
Fixed layout rendering needs the viewport size information on the WebProcess
side to be able to do viewport attribute calculations.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewportSize):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::viewportSize):
* WebProcess/WebPage/WebPage.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Thu, 27 Oct 2011 15:14:55 +0000 (15:14 +0000)]
Clean up MicroDataItemValue to use const String& instead of String
https://bugs.webkit.org/show_bug.cgi?id=70978
Reviewed by Tony Chang.
* html/MicroDataItemValue.cpp:
(WebCore::MicroDataItemValue::MicroDataItemValue):
* html/MicroDataItemValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 27 Oct 2011 15:12:04 +0000 (15:12 +0000)]
2011-10-27 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 27 Oct 2011 15:09:10 +0000 (15:09 +0000)]
MiniBrowser crashes when started with 0 arguments
Rubber-stamped by Simon Hausmann.
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
Fix typo error.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 15:06:18 +0000 (15:06 +0000)]
[WebSocket] update pywebsocket to 0.7.
https://bugs.webkit.org/show_bug.cgi?id=70992
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-10-27
Reviewed by Kent Tamura.
pywebsocket 0.7 fixed the bug on dual stack support on OS X.
* Scripts/webkitpy/thirdparty/__init__.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 15:05:47 +0000 (15:05 +0000)]
Fix a small bug in callOperation after r98431
https://bugs.webkit.org/show_bug.cgi?id=70984
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-27
Reviewed by Geoffrey Garen.
TrustedImmPtr is not expecting "int" type parameters.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 27 Oct 2011 15:03:48 +0000 (15:03 +0000)]
Use StringHasher to generate the matched declaration cache hash
https://bugs.webkit.org/show_bug.cgi?id=71012
Reviewed by Kenneth Rohde Christiansen and Andreas Kling.
It is faster and better than the current custom function.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::computeDeclarationHash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 27 Oct 2011 14:51:52 +0000 (14:51 +0000)]
Refactor OptionsObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=70572
Reviewed by Adam Barth.
For example, OptionsObject::getKeyBool() is an alias of
OptionsObject::getKeyValue(const String& key, bool& value).
We should remove OptionsObject::getKeyXXXX() (XXXX is some specific type)
and unify them into OptionsObject::get(const String& key, XXXX& value).
c.f. Corresponding JSC methods are unified into
JSDictionary::convertValue(JSC::ExecState*, JSC::JSValue, XXXX&).
The result of git diff is weird, but this patch is making just the following changes:
- Replaced getKeyBool(), getKeyInt32(), getKeyDouble() and getKeyString() with get().
- Renamed getKeyStringWithUndefinedOrNullCheck() to getWithUndefinedOrNullCheck().
- Removed getKeyDOMStringList() and getKeyKeyRange(), since these are not used.
- Move definitions of get() from .h to .cpp.
No new tests. No change in behavior.
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get): Renamed from getKeyValue().
(WebCore::OptionsObject::getKey): No change to this method. git diff seems to misunderstand as if it is modified.
(WebCore::OptionsObject::getKeyDOMStringList): Removed, since no one is using it.
(WebCore::OptionsObject::getKeyKeyRange): Ditto.
(WebCore::OptionsObject::getWithUndefinedOrNullCheck): No change to this method. git diff seems to misunderstand as if it is modified.
* bindings/v8/OptionsObject.h: Moved definitions of get() to OptionsObject.cpp
* bindings/v8/custom/V8EventConstructors.cpp:
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback): Replaced getKeyXXXX() to get();
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore): Ditto.
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 27 Oct 2011 14:36:59 +0000 (14:36 +0000)]
[Qt][WK2] Move the C API callback setup out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=70965
Reviewed by Andreas Kling.
Move out the setup of C API callback into ClientImpl file
so that QtWebPageProxy will be less polluted.
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didSameDocumentNavigationForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(qt_wk_decidePolicyForNavigationAction):
(qt_wk_decidePolicyForResponse):
(setupPageLoaderClient):
(setupPageUiClient):
(setupPagePolicyClient):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::viewInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Thu, 27 Oct 2011 14:33:11 +0000 (14:33 +0000)]
need to rebaseline after skia 2527 lands, fixing an off-by-1 bug in blending (with alpha==0)
https://bugs.webkit.org/show_bug.cgi?id=70963
Reviewed by James Robinson.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 14:26:04 +0000 (14:26 +0000)]
StyleSheet.parentStyleSheet does not work.
https://bugs.webkit.org/show_bug.cgi?id=70956
Patch by Andreas Kling <kling@webkit.org> on 2011-10-27
Reviewed by Antti Koivisto.
Source/WebCore:
Since StyleSheet is only ever parented by a CSSRule, we need
to go through that rule when resolving the StyleSheet's parent.
Test: fast/css/stylesheet-parentStyleSheet.html
* css/StyleSheet.cpp:
(WebCore::StyleSheet::parentStyleSheet):
LayoutTests:
* fast/css/stylesheet-parentStyleSheet-expected.txt: Added.
* fast/css/stylesheet-parentStyleSheet.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 14:23:49 +0000 (14:23 +0000)]
Disable blending when drawing opaque layers
https://bugs.webkit.org/show_bug.cgi?id=70085
Patch by Antoine Labour <piman@chromium.org> on 2011-10-27
Reviewed by James Robinson.
Covered by compositing/ tests, as well as a new unit test:
CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::opaque):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 14:03:32 +0000 (14:03 +0000)]
Chromium ui_tests WorkerTest.WorkerMessagePort[GC] were broken by https://bugs.webkit.org/attachment.cgi?id=112342
https://bugs.webkit.org/show_bug.cgi?id=70953
Patch by Dave Michael <dmichael@chromium.org> on 2011-10-27
Reviewed by David Levin.
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 27 Oct 2011 14:00:48 +0000 (14:00 +0000)]
2011-10-27 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 13:35:53 +0000 (13:35 +0000)]
make lion observe MAC lines in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=70941
Patch by Elliot Poger <epoger@google.com> on 2011-10-27
Reviewed by Ojan Vafai.
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 13:35:51 +0000 (13:35 +0000)]
IndexedDB: Passing empty array to IDBDatabase.transaction should raise exception
https://bugs.webkit.org/show_bug.cgi?id=70251
Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-27
Reviewed by Adam Barth.
Source/WebCore:
IDBDatabase.transaction() supported being called with an empty array to
lock all object stores. Support for this was rejected from inclusion in
the IDB spec due to performance concerns. This patch removes that
functionality.
A special case in the spec (passing a string instead of an array) worked
in WebKit accidentally, by resolving the string to an empty array. This
needed explicit support. Support for DOMString[] is added to the binding
code generators (reliant on DOMStringList) to ensure JS arrays are not
coerced to DOMStrings. This matches the proposed IDL.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheckExpression):
(GetNativeType):
(JSValueToNative):
(IsArrayType):
* bindings/scripts/IDLStructure.pm:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::objectStore):
LayoutTests:
Many tests relied on the non-specified behavior of passing an empty
array into IDBDatabase.transaction() to include all object stores in
scopes. Worse, non-arrays would be treated as empty arrays, and hence
"just worked".
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-inconsistency.html:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-skip-deleted.html:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/error-causes-abort-by-default.html:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/index-unique.html:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/mutating-cursor.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/objectstore-clear-expected.txt:
* storage/indexeddb/objectstore-clear.html:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/request-event-propagation.html:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-abort.html:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-after-close.html:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:
* storage/indexeddb/transaction-crash-on-abort-expected.txt:
* storage/indexeddb/transaction-crash-on-abort.html:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-event-propagation.html:
* storage/indexeddb/transaction-read-only-expected.txt:
* storage/indexeddb/transaction-read-only.html:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/tutorial.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 13:31:28 +0000 (13:31 +0000)]
Enable MEDIA_SOURCE feature for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70745
Patch by Aaron Colwell <acolwell@chromium.org> on 2011-10-27
Reviewed by David Levin.
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 13:22:56 +0000 (13:22 +0000)]
Crash due to nested first-letter selectors
https://bugs.webkit.org/show_bug.cgi?id=70457
Source/WebCore:
Now only the lowest-level first-letter pseudostyle will be applied to
a given piece of text. Previously the last renderer to have layout
done would have its pseudostyle applied, no matter where it was in the
tree.
Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.
* renderer/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter): Use the pseudostyle from
the lowest level node to have one
LayoutTests:
Adding layout test for nested first-letter pseudostyles causing a crash.
Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.
* fast/css/nested-first-letter-with-float-crash.html: Added
* fast/css/nested-first-letter-with-float-crash-expected.txt: Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 27 Oct 2011 13:19:53 +0000 (13:19 +0000)]
[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525
This fixes the commonview tests that were failing
after r98447.
WebViewAbstraction must forward actions to both
the TouchWebView and the DesktopWebView.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jknotten@chromium.org [Thu, 27 Oct 2011 13:07:23 +0000 (13:07 +0000)]
[Chromium] Allow DRT to be built without notifications enabled.
https://bugs.webkit.org/show_bug.cgi?id=70919
Reviewed by Tony Gentilcore.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):
* DumpRenderTree/chromium/NotificationPresenter.cpp:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetTestController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 13:05:47 +0000 (13:05 +0000)]
[Qt][WK2]Content size changed event does not require viewport attribute calculation.
https://bugs.webkit.org/show_bug.cgi?id=70920
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.
Remove unnecessary recalculation of viewport attributes.
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::contentSizeChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 27 Oct 2011 13:02:42 +0000 (13:02 +0000)]
Fix the build if NO_LISTBOX_RENDERING is enabled
https://bugs.webkit.org/show_bug.cgi?id=71009
Reviewed by Kenneth Rohde Christiansen.
If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem uses the
HTMLSelectElement::listBoxSelectItem function which was accidentally removed in r97533.
Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDERING guard to unbreak this setup.
This is covered by:
Source/WebCore/manual-tests/no-listbox-rendering.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxSelectItem): Reintroduce.
* html/HTMLSelectElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Oct 2011 12:52:16 +0000 (12:52 +0000)]
Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-27
Reviewed by Hajime Morita.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.
This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.
Test: editing/spelling/spelling-unified-emulation.html
* editing/TextCheckingHelper.cpp:
(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):
Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.
* testing/Internals.cpp:
(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.
* editing/spelling/spelling-unified-emulation-expected.txt: Added.
* editing/spelling/spelling-unified-emulation.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 27 Oct 2011 12:37:41 +0000 (12:37 +0000)]
Unreviewed, remove those un-needed files committed by error in
r98554.
* platform/audio/gstreamer/#AudioFileReaderGStreamer.h#: Removed.
* platform/audio/gstreamer/.#AudioFileReaderGStreamer.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 27 Oct 2011 12:31:44 +0000 (12:31 +0000)]
[GStreamer] WebAudio AudioFileReader implementation
https://bugs.webkit.org/show_bug.cgi?id=69834
.:
Patch by Philippe Normand <pnormand@igalia.com> and Zan Dobersek <zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.
* configure.ac: Check for libfftw and gstreamer-audio if WebAudio
build is enabled.
Source/WebCore:
Patch by Philippe Normand <pnormand@igalia.com> and Zan Dobersek <zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.
Basic FileReader implementation, supporting one or 2 audio
channels. An empty AudioDestination is also provided, its complete
implementation is handled in bug 69835.
* GNUmakefile.am:
* GNUmakefile.list.am:
* platform/audio/gstreamer/AudioDestinationGStreamer.cpp: Added.
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::start):
(WebCore::AudioDestinationGStreamer::stop):
* platform/audio/gstreamer/AudioDestinationGStreamer.h: Added.
(WebCore::AudioDestinationGStreamer::isPlaying):
(WebCore::AudioDestinationGStreamer::sampleRate):
(WebCore::AudioDestinationGStreamer::sourceProvider):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: Added.
(WebCore::getGStreamerAudioCaps):
(WebCore::getFloatFromByteReader):
(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkNewBufferCallback):
(WebCore::messageCallback):
(WebCore::onGStreamerDeinterleavePadAddedCallback):
(WebCore::onGStreamerDeinterleaveReadyCallback):
(WebCore::onGStreamerDecodebinPadAddedCallback):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::handleBuffer):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::deinterleavePadsConfigured):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
* platform/audio/gtk/AudioBusGtk.cpp: Added.
(WebCore::AudioBus::loadPlatformResource):
Source/WebKit/gtk:
Reviewed by Martin Robinson.
* GNUmakefile.am: Link against libfftw.
Source/WebKit2:
Reviewed by Martin Robinson.
* GNUmakefile.am: Link against libfftw.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 27 Oct 2011 12:23:26 +0000 (12:23 +0000)]
Unreviewed, GTK rebaseline after r98507.
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 27 Oct 2011 12:19:19 +0000 (12:19 +0000)]
Unreviewed, rebaseline of the bindings tests after r98501 which
removed getOwnPropertySlotVirtual.
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 27 Oct 2011 11:51:59 +0000 (11:51 +0000)]
http/tests/inspector/search/search-in-resources.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=70993
Reviewed by Pavel Feldman.
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.dumpSearchResults):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 27 Oct 2011 11:50:53 +0000 (11:50 +0000)]
WebInspector: View throughs the exception when a child view are removed by removeChildren call.
https://bugs.webkit.org/show_bug.cgi?id=71002
Another followup fix after r98225.
Reviewed by Pavel Feldman.
* inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView.prototype._queryFinished):
(WebInspector.DatabaseTableView.prototype._queryError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 27 Oct 2011 11:49:18 +0000 (11:49 +0000)]
Web Inspector: Execution line in selected call frame should keep showing after toggling format source.
https://bugs.webkit.org/show_bug.cgi?id=70906
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/selected-call-frame-after-formatting-source.html
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
LayoutTests:
* inspector/debugger/selected-call-frame-after-formatting-source-expected.txt: Added.
* inspector/debugger/selected-call-frame-after-formatting-source.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Thu, 27 Oct 2011 11:47:51 +0000 (11:47 +0000)]
Numerous debug build fixes
Unreviewed build fix.
No new tests, buuld fix only.
* loader/icon/IconDatabase.cpp: urlForLogging() is used by both LOG() and LOG_ERROR()
* storage/AbstractDatabase.h: databaseDebugName() is used by both LOG() and LOG_ERROR()
* storage/DatabaseTask.cpp: m_complete is only available when !LOG_DISABLED
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Thu, 27 Oct 2011 11:43:39 +0000 (11:43 +0000)]
[Qt] Improve command line arguments handling for MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=70616
Reviewed by Kenneth Rohde Christiansen.
- Use two dashes for word arguments.
- Return with an error when an unsupported argument is given.
- Allow the URL to be placed before option arguments.
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(printHelp):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/utils.cpp:
(takeOptionFlag):
(takeOptionValue):
* MiniBrowser/qt/utils.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 27 Oct 2011 11:36:09 +0000 (11:36 +0000)]
Web Inspector: Refactor ScriptsPanel so that ConsoleView does not depend on it.
https://bugs.webkit.org/show_bug.cgi?id=70899
Moved methods used in console view to DebuggerPresentationModel.
Changed debuggerPaused handler logic so that selectedCallFrame is never null when debugger is paused.
Reviewed by Pavel Feldman.
* inspector/front-end/ConsoleView.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables.propertiesCollected):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables):
(WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._updateCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 27 Oct 2011 11:30:44 +0000 (11:30 +0000)]
Web Inspector: Add support for advanced search in content scripts.
https://bugs.webkit.org/show_bug.cgi?id=70923
Reviewed by Yury Semikhatsky.
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsSearchScope.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 27 Oct 2011 11:30:14 +0000 (11:30 +0000)]
[Qt] NRWT doesn't work on qt-mac platform
https://bugs.webkit.org/show_bug.cgi?id=64445
Reviewed by Adam Barth.
* Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
(useNewRunWebKitTests):
* Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 27 Oct 2011 09:55:32 +0000 (09:55 +0000)]
Unreviewed one line fix for DOMStorageItemsView.
It have to use this.detachChildViews instead of this.element.removeChildren after r98225.
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype.update):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 27 Oct 2011 09:39:48 +0000 (09:39 +0000)]
Matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=70931
Reviewed by Darin Adler.
Sets of style declarations are applied repeatedly for different elements when calculating the document style.
The same set of applied declarations results in the same non-inherited style, independent of the element and
its context. We can use this to build a cache to speed up style applying and to share more style data for
reduced memory usage.
The patch reduces RenderStyle memory use ~40% and total memory use by ~7% over HTML5 spec load.
It is also ~10% progression in PerformanceTests/Parser/html5-full-render.html.
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::isInherited):
We need to know which properties are inherited, something we didn't have available so far.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
A set of declarations is only cacheable if it contains no element specific style. This way we
don't need to worry about cache invalidation. The whole style selector is reconstructed if the
stylesheets change, invalidating the cache too.
(WebCore::CSSStyleSelector::styleForElement):
Trigger image loads bit earlier so cached style will have them too.
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
Allow skipping over non-inherited properties.
(WebCore::CSSStyleSelector::computeDeclarationHash):
Hash function for declartion cache lookups.
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):
Lookup from cache.
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
Add to cache.
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
If cached style is found, copy the non-inherited properties from the cache and apply the inherited properties (if any) only.
Font and zoom changes force full applying as they can affect values of other properties (this can be relaxed later).
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::MatchResult::MatchResult):
Cacheability bit.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::copyNonInheritedFrom):
* rendering/style/RenderStyle.h:
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::copyNonInheritedFrom):
* rendering/style/SVGRenderStyle.h:
Functions for assembling RenderStyle from non-inherited parts of the cached style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 27 Oct 2011 09:37:00 +0000 (09:37 +0000)]
Web Inspector: [Extensions API] add ignoreCache flag to options of inspectedWindow.reload()
https://bugs.webkit.org/show_bug.cgi?id=70926
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/extensions-ignore-cache.html
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/externs.js:
():
LayoutTests:
* http/tests/inspector/extensions-ignore-cache-expected.txt: Added.
* http/tests/inspector/extensions-ignore-cache.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Thu, 27 Oct 2011 09:33:59 +0000 (09:33 +0000)]
Unreviewed, fix typo in skiplist.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Thu, 27 Oct 2011 08:54:57 +0000 (08:54 +0000)]
Unreviewed. Add bugzilla link to skipped test.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 27 Oct 2011 07:53:44 +0000 (07:53 +0000)]
inspector/storage-panel-dom-storage.html has results platform dependant?
https://bugs.webkit.org/show_bug.cgi?id=70985
The items set in DOM storage is unsorted and as result the test is platform dependant.
We will sort it before the dumping.
Patch by Ilya Tikhonovsky <loislo@chromium.org> on 2011-10-27
Reviewed by Yury Semikhatsky.
* inspector/storage-panel-dom-storage-expected.txt:
* inspector/storage-panel-dom-storage.html:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 27 Oct 2011 06:50:04 +0000 (06:50 +0000)]
2011-10-26 Yury Semikhatsky <yurys@chromium.org>
Unreviewed, gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc