WebKit-https.git
7 years agoAdd per-HashTable stats
weinig@apple.com [Wed, 25 Jul 2012 01:07:21 +0000 (01:07 +0000)]
Add per-HashTable stats
https://bugs.webkit.org/show_bug.cgi?id=92185

Reviewed by Anders Carlsson.

Add per-HashTable stats, so we can look at the effectiveness of an individual HashTable.

* wtf/HashTable.h:
(WTF::HashTable::Stats::Stats):
Add a HashTable::Stats to hold the stats.

(WTF::HashTable::Stats::recordCollisionAtCount):
(WTF::HashTable::Stats::dumpStats):
Add versions of recordCollisionAtCount and dumpStats for per-HashTable version.

(WTF::HashTable):
Keep the stats, if enabled, in an OwnPtr, to not blow JSCell max size restrictions.

(WTF::lookup):
(WTF::lookupForWriting):
(WTF::fullLookupForWriting):
(WTF::add):
(WTF::reinsert):
(WTF::remove):
(WTF::rehash):
Keep track of the stats as the table is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGardening stuff, rebaseline.
zmo@google.com [Wed, 25 Jul 2012 00:48:31 +0000 (00:48 +0000)]
Gardening stuff, rebaseline.

Unreviewed.

* platform/chromium-mac/fast/hidpi: Added.
* platform/chromium-mac/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
* platform/chromium-mac/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
* platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
* platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Added.
* platform/chromium-mac/fast/hidpi/focus-rings-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-simple-expected.png: Added.
* platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png: Added.
* platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png: Added.
* platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
* platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
* platform/chromium-win/fast/hidpi: Added.
* platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
* platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
* platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
* platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
* platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
* platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
* platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png: Added.
* platform/chromium-win/fast/hidpi/focus-rings-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-as-background-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-as-background-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-simple-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-simple-expected.txt: Added.
* platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png: Added.
* platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
* platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png: Added.
* platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
* platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
* platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWKContextGetGlobalStatistics() assigns wrong value to wkFrameCount in WKContextStatistics
commit-queue@webkit.org [Wed, 25 Jul 2012 00:46:42 +0000 (00:46 +0000)]
WKContextGetGlobalStatistics() assigns wrong value to wkFrameCount in WKContextStatistics
https://bugs.webkit.org/show_bug.cgi?id=92173

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-07-24
Reviewed by John Sullivan.

In WKContextGetGlobalStatistics(), wkViewCount in WebContext::Statistics
is assigned to wkFrameCount in WKContextStatistics.
wkFrameCount in WebContext:Statistics should be assigned to wkFrameCount in WKContextStatistics.

* UIProcess/API/C/WKContext.cpp:
(WKContextGetGlobalStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Hint garbage collector to run if page uses Canvas contexts
kbr@google.com [Wed, 25 Jul 2012 00:37:11 +0000 (00:37 +0000)]
[chromium] Hint garbage collector to run if page uses Canvas contexts
https://bugs.webkit.org/show_bug.cgi?id=76225

Reviewed by Kentaro Hara.

Source/WebCore:

Upon creating a canvas context, set a hint in the current isolate
indicating that a full GC should be done upon the next page
navigation.

This improves Chrome's robustness on some WebGL stress tests which
simulate real-world behavior by repeatedly navigating among
several samples. More general measures are being investigated, but
this change makes V8 behave the same as JSC on these stress tests.
JSC doesn't currently use generational garbage collection, so it
has more opportunities to discover unreferenced canvas contexts.

Test: fast/canvas/webgl/context-creation-and-destruction.html

* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
    Initialize per-isolate low memory hint.
* bindings/v8/V8Binding.h:
(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::setLowMemoryNotificationHint):
    Set a per-isolate hint to signal a low memory condition upon the next page navigation.
(WebCore::V8BindingPerIsolateData::clearLowMemoryNotificationHint):
    Clear the previously set hint.
(WebCore::V8BindingPerIsolateData::isLowMemoryNotificationHint):
    Get the previously set hint.
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::hintForGCIfNecessary):
    If necessary, send V8 a hint that it should GC.
(WebCore):
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):
    Call hintForGCIfNecessary.
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
    Set a hint that we should GC upon the next page navigation.

LayoutTests:

This test doesn't directly exercise this code path yet, but it
needs to work regardless and also needs to be expanded.

* fast/canvas/webgl/context-creation-and-destruction-expected.txt: Added.
* fast/canvas/webgl/context-creation-and-destruction.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] svg/as-background-image rebaseline after new test fonts
alexis.menard@openbossa.org [Wed, 25 Jul 2012 00:28:46 +0000 (00:28 +0000)]
[Qt] svg/as-background-image rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92180

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

* platform/qt-5.0/Skipped:
* platform/qt/svg/as-background-image/animated-svg-as-background-expected.png: Added.
* platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt:
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-1-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-2-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-3-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-4-expected.png: Added.
* platform/qt/svg/as-background-image/svg-as-background-4-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-5-expected.png: Added.
* platform/qt/svg/as-background-image/svg-as-background-5-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-6-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt:
* platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt:
* platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt:
* platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Support scrolling and zooming to focused input elements
abarth@webkit.org [Wed, 25 Jul 2012 00:27:19 +0000 (00:27 +0000)]
[Chromium] Support scrolling and zooming to focused input elements
https://bugs.webkit.org/show_bug.cgi?id=91661

Reviewed by Darin Fisher.

This patch introduces saveScrollAndScaleState and
restoreScrollAndScaleState, which can be used to save and restore the
scroll and scale state of the WebView, respectively.  These functions
will be used by Chromium on Android to save the scale and scrolls state
before zoom into a text field so that we can "undo" the zoom if the
user didn't mean to zoom into the text field.

I wanted to write unit tests for these functions, but it wasn't clear
to me how to write the test because startPageScaleAnimation appears to
complete asynchronously.

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::saveScrollAndScaleState):
(WebKit):
(WebKit::WebViewImpl::restoreScrollAndScaleState):
(WebKit::WebViewImpl::resetSavedScrollAndScaleState):
(WebKit::WebViewImpl::didCommitLoad):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add time spent painting to GPU benchmarking renderingStats() API.
commit-queue@webkit.org [Wed, 25 Jul 2012 00:25:53 +0000 (00:25 +0000)]
[chromium] Add time spent painting to GPU benchmarking renderingStats() API.
https://bugs.webkit.org/show_bug.cgi?id=90019

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebRenderingStats.h:
(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):

Source/WebCore:

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(BitmapCanvasLayerTextureUpdater):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):
* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
* platform/graphics/chromium/CanvasLayerTextureUpdater.h:
(CanvasLayerTextureUpdater):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::update):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::update):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(WebCore::LayerChromium::update):
* platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
(SkPictureCanvasLayerTextureUpdater):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateContentRect):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::renderingStats):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCRenderingStats.h:
(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):

Source/WebKit/chromium:

* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::renderingStats):
* tests/CCLayerTreeHostTest.cpp:
* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect):
(WebKitTests::FakeTiledLayerChromium::update):
* tests/CCTiledLayerTestCommon.h:
(Texture):
(FakeTiledLayerChromium):
* tests/Canvas2DLayerBridgeTest.cpp:
* tests/ContentLayerChromiumTest.cpp:
(WebKit::TEST):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/block/positioning rebaseline after new test fonts
caio.oliveira@openbossa.org [Wed, 25 Jul 2012 00:16:52 +0000 (00:16 +0000)]
[Qt] fast/block/positioning rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92174

Unreviewed.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/fast/block/positioning/003-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/004-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/005-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/006-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/007-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/008-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/009-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/010-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/011-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/012-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/013-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/014-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/015-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/017-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/018-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/019-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/020-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/021-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/022-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/023-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/024-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/025-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/026-expected.png: Added.
* platform/qt/fast/block/positioning/027-expected.png: Added.
* platform/qt/fast/block/positioning/028-expected.png: Added.
* platform/qt/fast/block/positioning/029-expected.png: Added.
* platform/qt/fast/block/positioning/030-expected.png: Added.
* platform/qt/fast/block/positioning/031-expected.png: Added.
* platform/qt/fast/block/positioning/032-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/033-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/034-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/035-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/036-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/037-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/038-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/039-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/040-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/041-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/042-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/043-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/044-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/045-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/046-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/047-expected.png:
* platform/qt/fast/block/positioning/047-expected.txt:
* platform/qt/fast/block/positioning/048-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/050-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
* platform/qt/fast/block/positioning/052-expected.txt:
* platform/qt/fast/block/positioning/053-expected.png:
* platform/qt/fast/block/positioning/053-expected.txt:
* platform/qt/fast/block/positioning/054-expected.txt:
* platform/qt/fast/block/positioning/055-expected.png:
* platform/qt/fast/block/positioning/055-expected.txt:
* platform/qt/fast/block/positioning/057-expected.png:
* platform/qt/fast/block/positioning/057-expected.txt:
* platform/qt/fast/block/positioning/058-expected.png:
* platform/qt/fast/block/positioning/058-expected.txt:
* platform/qt/fast/block/positioning/059-expected.png:
* platform/qt/fast/block/positioning/059-expected.txt:
* platform/qt/fast/block/positioning/060-expected.png:
* platform/qt/fast/block/positioning/060-expected.txt:
* platform/qt/fast/block/positioning/061-expected.txt:
* platform/qt/fast/block/positioning/062-expected.png: Added.
* platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.png:
* platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.txt:
* platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.png:
* platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
* platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.png:
* platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
* platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.png:
* platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
* platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.png:
* platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.txt:
* platform/qt/fast/block/positioning/absolute-position-direction-expected.png:
* platform/qt/fast/block/positioning/absolute-position-direction-expected.txt:
* platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.png:
* platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.txt:
* platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
* platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
* platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.png:
* platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.txt:
* platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.png:
* platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.txt:
* platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.png:
* platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
* platform/qt/fast/block/positioning/auto/001-expected.png:
* platform/qt/fast/block/positioning/auto/001-expected.txt:
* platform/qt/fast/block/positioning/auto/002-expected.png:
* platform/qt/fast/block/positioning/auto/002-expected.txt:
* platform/qt/fast/block/positioning/auto/003-expected.png:
* platform/qt/fast/block/positioning/auto/003-expected.txt:
* platform/qt/fast/block/positioning/auto/004-expected.png:
* platform/qt/fast/block/positioning/auto/004-expected.txt:
* platform/qt/fast/block/positioning/auto/005-expected.png:
* platform/qt/fast/block/positioning/auto/005-expected.txt:
* platform/qt/fast/block/positioning/auto/006-expected.png:
* platform/qt/fast/block/positioning/auto/006-expected.txt:
* platform/qt/fast/block/positioning/auto/007-expected.png:
* platform/qt/fast/block/positioning/auto/007-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.txt:
* platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.txt:
* platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.png:
* platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.txt:
* platform/qt/fast/block/positioning/differing-writing-modes-expected.png:
* platform/qt/fast/block/positioning/differing-writing-modes-expected.txt:
* platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.png:
* platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
* platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
* platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
* platform/qt/fast/block/positioning/height-change-expected.png:
* platform/qt/fast/block/positioning/height-change-expected.txt:
* platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png:
* platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt:
* platform/qt/fast/block/positioning/inline-block-relposition-expected.png:
* platform/qt/fast/block/positioning/inline-block-relposition-expected.txt:
* platform/qt/fast/block/positioning/leftmargin-topmargin-expected.png:
* platform/qt/fast/block/positioning/leftmargin-topmargin-expected.txt:
* platform/qt/fast/block/positioning/negative-right-pos-expected.png:
* platform/qt/fast/block/positioning/negative-right-pos-expected.txt:
* platform/qt/fast/block/positioning/padding-percent-expected.png:
* platform/qt/fast/block/positioning/padding-percent-expected.txt:
* platform/qt/fast/block/positioning/pref-width-change-expected.txt:
* platform/qt/fast/block/positioning/relative-overconstrained-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
* platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
* platform/qt/fast/block/positioning/relative-overflow-block-expected.txt:
* platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
* platform/qt/fast/block/positioning/relative-overflow-replaced-expected.txt:
* platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
* platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.txt:
* platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
* platform/qt/fast/block/positioning/relayout-on-position-change-expected.txt:
* platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.png:
* platform/qt/fast/block/positioning/rtl-static-positioning-expected.png:
* platform/qt/fast/block/positioning/rtl-static-positioning-expected.txt:
* platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.png:
* platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt:
* platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png:
* platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt:
* platform/qt/fast/block/positioning/table-cell-static-position-expected.png:
* platform/qt/fast/block/positioning/table-cell-static-position-expected.txt:
* platform/qt/fast/block/positioning/trailing-space-test-expected.png:
* platform/qt/fast/block/positioning/trailing-space-test-expected.txt:
* platform/qt/fast/block/positioning/vertical-lr/001-expected.png:
* platform/qt/fast/block/positioning/vertical-lr/001-expected.txt:
* platform/qt/fast/block/positioning/vertical-rl/001-expected.png:
* platform/qt/fast/block/positioning/vertical-rl/001-expected.txt:
* platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
* platform/qt/fast/block/positioning/window-height-change-expected.png:
* platform/qt/fast/block/positioning/window-height-change-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/block/float needs rebaseline after new test fonts
commit-queue@webkit.org [Tue, 24 Jul 2012 23:58:07 +0000 (23:58 +0000)]
[Qt] fast/block/float needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92150

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-24
Reviewed by Alexis Menard.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/fast/block/float/001-expected.txt:
* platform/qt/fast/block/float/002-expected.png:
* platform/qt/fast/block/float/002-expected.txt:
* platform/qt/fast/block/float/003-expected.png:
* platform/qt/fast/block/float/003-expected.txt:
* platform/qt/fast/block/float/004-expected.png:
* platform/qt/fast/block/float/004-expected.txt:
* platform/qt/fast/block/float/005-expected.png:
* platform/qt/fast/block/float/005-expected.txt:
* platform/qt/fast/block/float/006-expected.png:
* platform/qt/fast/block/float/006-expected.txt:
* platform/qt/fast/block/float/007-expected.png:
* platform/qt/fast/block/float/007-expected.txt:
* platform/qt/fast/block/float/010-expected.png:
* platform/qt/fast/block/float/010-expected.txt:
* platform/qt/fast/block/float/011-expected.png:
* platform/qt/fast/block/float/011-expected.txt:
* platform/qt/fast/block/float/012-expected.png:
* platform/qt/fast/block/float/012-expected.txt:
* platform/qt/fast/block/float/013-expected.png:
* platform/qt/fast/block/float/013-expected.txt:
* platform/qt/fast/block/float/014-expected.png:
* platform/qt/fast/block/float/014-expected.txt:
* platform/qt/fast/block/float/015-expected.png:
* platform/qt/fast/block/float/015-expected.txt:
* platform/qt/fast/block/float/016-expected.png:
* platform/qt/fast/block/float/016-expected.txt:
* platform/qt/fast/block/float/017-expected.png:
* platform/qt/fast/block/float/017-expected.txt:
* platform/qt/fast/block/float/018-expected.png:
* platform/qt/fast/block/float/018-expected.txt:
* platform/qt/fast/block/float/020-expected.png:
* platform/qt/fast/block/float/020-expected.txt:
* platform/qt/fast/block/float/021-expected.png:
* platform/qt/fast/block/float/021-expected.txt:
* platform/qt/fast/block/float/022-expected.png:
* platform/qt/fast/block/float/022-expected.txt:
* platform/qt/fast/block/float/023-expected.png:
* platform/qt/fast/block/float/023-expected.txt:
* platform/qt/fast/block/float/024-expected.png:
* platform/qt/fast/block/float/024-expected.txt:
* platform/qt/fast/block/float/025-expected.png:
* platform/qt/fast/block/float/025-expected.txt:
* platform/qt/fast/block/float/027-expected.png:
* platform/qt/fast/block/float/027-expected.txt:
* platform/qt/fast/block/float/029-expected.png:
* platform/qt/fast/block/float/029-expected.txt:
* platform/qt/fast/block/float/030-expected.png:
* platform/qt/fast/block/float/030-expected.txt:
* platform/qt/fast/block/float/031-expected.png:
* platform/qt/fast/block/float/031-expected.txt:
* platform/qt/fast/block/float/032-expected.png:
* platform/qt/fast/block/float/032-expected.txt:
* platform/qt/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
* platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
* platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
* platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
* platform/qt/fast/block/float/avoiding-float-centered-expected.png:
* platform/qt/fast/block/float/avoiding-float-centered-expected.txt:
* platform/qt/fast/block/float/br-with-clear-expected.txt:
* platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png:
* platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt:
* platform/qt/fast/block/float/clamped-right-float-expected.png:
* platform/qt/fast/block/float/clamped-right-float-expected.txt:
* platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.png:
* platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt:
* platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.png:
* platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.txt:
* platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
* platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt:
* platform/qt/fast/block/float/fit_line_below_floats-expected.png:
* platform/qt/fast/block/float/fit_line_below_floats-expected.txt:
* platform/qt/fast/block/float/float-avoidance-expected.png:
* platform/qt/fast/block/float/float-avoidance-expected.txt:
* platform/qt/fast/block/float/float-in-float-hit-testing-expected.png:
* platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
* platform/qt/fast/block/float/float-in-float-painting-expected.png:
* platform/qt/fast/block/float/float-in-float-painting-expected.txt:
* platform/qt/fast/block/float/floats-and-text-indent-expected.png:
* platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
* platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
* platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
* platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt:
* platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt:
* platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt:
* platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt:
* platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt:
* platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt:
* platform/qt/fast/block/float/intruding-painted-twice-expected.png:
* platform/qt/fast/block/float/intruding-painted-twice-expected.txt:
* platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
* platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
* platform/qt/fast/block/float/multiple-float-positioning-expected.png:
* platform/qt/fast/block/float/multiple-float-positioning-expected.txt:
* platform/qt/fast/block/float/nested-clearance-expected.png:
* platform/qt/fast/block/float/nested-clearance-expected.txt:
* platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
* platform/qt/fast/block/float/nestedAnonymousBlocks-expected.txt:
* platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
* platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.txt:
* platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.png:
* platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.txt:
* platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.png:
* platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
* platform/qt/fast/block/float/overhanging-after-height-decrease-expected.png:
* platform/qt/fast/block/float/overhanging-after-height-decrease-expected.txt:
* platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt:
* platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt:
* platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt:
* platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt:
* platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png:
* platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt:
* platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png:
* platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt:
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
* platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png:
* platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
* platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
* platform/qt/fast/block/float/shrink-to-fit-width-expected.txt:
* platform/qt/fast/block/float/table-relayout-expected.png:
* platform/qt/fast/block/float/table-relayout-expected.txt:
* platform/qt/fast/block/float/vertical-move-relayout-expected.png:
* platform/qt/fast/block/float/vertical-move-relayout-expected.txt:
* platform/qt/fast/block/float/width-update-after-clear-expected.png:
* platform/qt/fast/block/float/width-update-after-clear-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Correct WebIDL type should be used in the testing IDL file
jianli@chromium.org [Tue, 24 Jul 2012 23:51:23 +0000 (23:51 +0000)]
[V8] Correct WebIDL type should be used in the testing IDL file
https://bugs.webkit.org/show_bug.cgi?id=92168

Reviewed by Kentaro Hara.

Updated bindings test.

* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_strict_function):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123191.
tkent@chromium.org [Tue, 24 Jul 2012 23:12:35 +0000 (23:12 +0000)]
Unreviewed, rolling out r123191.
http://trac.webkit.org/changeset/123191
https://bugs.webkit.org/show_bug.cgi?id=91804

It might cause another performance regression.
http://code.google.com/p/chromium/issues/detail?id=138410

* html/FormController.cpp:
(FormKeyGenerator):
(WebCore::createKey):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormKeyGenerator::willDeleteForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits.
commit-queue@webkit.org [Tue, 24 Jul 2012 22:55:34 +0000 (22:55 +0000)]
[JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits.
https://bugs.webkit.org/show_bug.cgi?id=90381

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-24
Reviewed by Kentaro Hara.

We can remove jsUnsignedLongArrayToVector() implementaion
merging it to current and toNativeArray() traits.

Tests: TestObj.idl
There should be no behavoiral changes as just refactoring.

* Modules/vibration/NavigatorVibration.idl: Use sequence<T> as method param than T[]
* bindings/js/JSDOMBinding.cpp: Moved toJSSequence() to header file.
* bindings/js/JSDOMBinding.h:
(WebCore::toJSSequence): Moved toJSSequence() to header file.
(WebCore::jsArray): Renamed Traits to JSValueTraits
(WebCore::toNativeArray): Using traits.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
* bindings/scripts/CodeGeneratorJS.pm: Removed unsigned long[] specific binding code.
(AddIncludesForType):
(GenerateParametersCheckExpression):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheckExpression): Added check sequence<T> check for overloaded methods.
* bindings/scripts/test/JS/JSTestObj.cpp: Rebased binding test.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
* bindings/scripts/test/JS/JSTestObj.h: Rebased binding test.
* bindings/scripts/test/TestObj.idl: Added test for sequence<T> as method parameter.
* bindings/scripts/test/V8/V8TestObj.cpp: Rebased binding test.
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add unit tests for custom text encoding setting
commit-queue@webkit.org [Tue, 24 Jul 2012 22:54:03 +0000 (22:54 +0000)]
[EFL][WK2] Add unit tests for custom text encoding setting
https://bugs.webkit.org/show_bug.cgi?id=91983

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-24
Reviewed by Dirk Pranke.

Add unit tests for get and set custom text encoding methods. Also, fix
a style nit for r123177.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_setting_encoding_custom_set): Fix a style nit - add newline
before return.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWinCairo build fix attempt.
rniwa@webkit.org [Tue, 24 Jul 2012 22:51:05 +0000 (22:51 +0000)]
WinCairo build fix attempt.

* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix attempt.
rniwa@webkit.org [Tue, 24 Jul 2012 22:34:51 +0000 (22:34 +0000)]
Windows build fix attempt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove an invalid assertion introduced in r123536. Unreviewed.
kseo@webkit.org [Tue, 24 Jul 2012 22:34:31 +0000 (22:34 +0000)]
Remove an invalid assertion introduced in r123536. Unreviewed.

* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123504.
zmo@google.com [Tue, 24 Jul 2012 22:33:14 +0000 (22:33 +0000)]
Unreviewed, rolling out r123504.
http://trac.webkit.org/changeset/123504
https://bugs.webkit.org/show_bug.cgi?id=92169

broke a bunch of text-related tests in chromium mac debug
(Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

* platform/text/cf/StringCF.cpp:
(WTF::String::createCFString):
* platform/text/cf/StringImplCF.cpp:
(WTF::StringImpl::createCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations change stop ignoring fast/hidpi changes.
atwilson@chromium.org [Tue, 24 Jul 2012 22:26:34 +0000 (22:26 +0000)]
Unreviewed chromium expectations change stop ignoring fast/hidpi changes.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomake test-webkitpy at least kinda work in parallel on win32
dpranke@chromium.org [Tue, 24 Jul 2012 22:20:10 +0000 (22:20 +0000)]
make test-webkitpy at least kinda work in parallel on win32
https://bugs.webkit.org/show_bug.cgi?id=91700

Reviewed by Adam Barth.

This change makes the hoop-jumping we have to do to make running
new-run-webkit-tests in parallel on win32 generic so that we can
re-use it for test-webkitpy as well.

* Scripts/new-run-webkit-tests:
* Scripts/test-webkitpy:
* Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
(run):
* Scripts/webkitpy/test/main.py:
(main):
(Tester._log_exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnsure Noah's ark without reading the DOM tree.
kseo@webkit.org [Tue, 24 Jul 2012 22:19:44 +0000 (22:19 +0000)]
Ensure Noah's ark without reading the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=92065

Reviewed by Adam Barth.

Technically we shouldn't read attributes back from the DOM. If JavaScript changes
the attributes values, we could get a slightly wrong output here.

Read attributes from tokens saved in the active formatting element list.

No new tests, covered by existing tests.

* html/parser/HTMLFormattingElementList.cpp:
(WebCore::attributeCount):
(WebCore::HTMLFormattingElementList::append):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):
* html/parser/HTMLFormattingElementList.h:
(HTMLFormattingElementList):
* html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::localName):
(HTMLStackItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClear the external characters pointer of an AtomicHTMLToken before the raw token...
kseo@webkit.org [Tue, 24 Jul 2012 22:12:54 +0000 (22:12 +0000)]
Clear the external characters pointer of an AtomicHTMLToken before the raw token is cleared.
https://bugs.webkit.org/show_bug.cgi?id=92056

Reviewed by Adam Barth.

AtomicHTMLToken keeps a pointer to the HTMLToken's buffer instead of copying the
characters for performance. Clear the external characters pointer before the raw token
is cleared to make sure that we won't have a dangling pointer.

No new tests - no functional changes.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
(AtomicMarkupTokenBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd per-context setting for html notifications
jianli@chromium.org [Tue, 24 Jul 2012 22:08:52 +0000 (22:08 +0000)]
Add per-context setting for html notifications
https://bugs.webkit.org/show_bug.cgi?id=91295

Reviewed by Adam Barth.

Source/WebCore:

Added a new per-context setting to control the enabling of html notifications.
For chromium port, we're going to disable html notifications for web
pages, but still keep it enabled for extensions.

Also enhance V8 code generator to support V8EnabledPerContext attribute
for methods.

Updated the binding tests.

* Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::document): Expose document for being used by installPerContextProperties.
(WebCore):
* Modules/notifications/NotificationCenter.h:
(NotificationCenter):
* Modules/notifications/NotificationCenter.idl: Add V8EnabledPerContext attribute.
* bindings/scripts/CodeGeneratorV8.pm: V8EnabledPerContext now supports methods.
(GenerateHeader):
(IsStandardFunction):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateToV8Converters):
(GetContextEnableFunction):
* bindings/scripts/test/TestObj.idl: Add test case for V8EnabledPerContext methods.
* bindings/scripts/test/V8/V8TestObj.cpp: Update test result.
(WebCore::TestObjV8Internal::enabledAtContextMethod1Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enabledAtContextMethod2Callback):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::wrapSlow):
* dom/ContextFeatures.cpp: Add a new per-context feature.
(WebCore::ContextFeatures::htmlNotificationsEnabled):
(WebCore):
* dom/ContextFeatures.h: Add a new per-context feature.

Source/WebKit/chromium:

Add new per-context feature for chromium port.

* public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowHTMLNotifications):
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123499.
zmo@google.com [Tue, 24 Jul 2012 22:07:17 +0000 (22:07 +0000)]
Unreviewed, rolling out r123499.
http://trac.webkit.org/changeset/123499
https://bugs.webkit.org/show_bug.cgi?id=92161

Android fails to compile (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

Source/Platform:

* chromium/public/WebMediaStreamDescriptor.h:
(WebMediaStreamDescriptor):
* chromium/public/WebMediaStreamSource.h:
(WebMediaStreamSource):

Source/WebCore:

* GNUmakefile.list.am:
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
* Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
* Modules/mediastream/MediaStreamTrack.idl:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/EventTargetFactory.in:
* platform/chromium/support/WebMediaStreamDescriptor.cpp:
(WebKit):
(WebKit::WebMediaStreamDescriptor::sources):
* platform/chromium/support/WebMediaStreamSource.cpp:
* platform/mediastream/MediaStreamSource.cpp: Removed.
* platform/mediastream/MediaStreamSource.h:
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::muted):
(WebCore::MediaStreamSource::setMuted):
(WebCore::MediaStreamSource::MediaStreamSource):
(MediaStreamSource):
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

Tools:

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::createMediaStreamCenter):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
(MockWebKitPlatformSupport):
* DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
* DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.

LayoutTests:

* fast/mediastream/MediaStreamTrack-expected.txt: Removed.
* fast/mediastream/MediaStreamTrack.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations update from r123490.
atwilson@chromium.org [Tue, 24 Jul 2012 22:01:02 +0000 (22:01 +0000)]
Unreviewed chromium expectations update from r123490.

* platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: never finds binaries in the 'out' dir on chromium win
dpranke@chromium.org [Tue, 24 Jul 2012 21:44:50 +0000 (21:44 +0000)]
nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Reviewed by Tony Chang.

Attempt to fix this bug yet again; it turns out that --root and
--build-directory don't have the same meaning (--root should
include the configuration, --build-directory should not).

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._build_path):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort):
(ChromiumPort._build_path_with_configuration):
(ChromiumPort._build_path_with_configuration.does):
(ChromiumPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path_with_configuration):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_build_path):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_build_path):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] svg/batik rebaseline after new test fonts
caio.oliveira@openbossa.org [Tue, 24 Jul 2012 21:26:37 +0000 (21:26 +0000)]
[Qt] svg/batik rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92162

Unreviewed.

* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Removed.
* platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Removed.
* platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Removed.
* platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Removed.
* platform/qt-5.0/svg/batik/text/textEffect-expected.png: Removed.
* platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Removed.
* platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Removed.
* platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Removed.
* platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Removed.
* platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Removed.
* platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Removed.
* platform/qt/svg/batik/filters/filterRegions-expected.png:
* platform/qt/svg/batik/filters/filterRegions-expected.txt:
* platform/qt/svg/batik/masking/maskRegions-expected.png:
* platform/qt/svg/batik/masking/maskRegions-expected.txt:
* platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/qt/svg/batik/paints/patternRegionA-expected.png:
* platform/qt/svg/batik/paints/patternRegionA-expected.txt:
* platform/qt/svg/batik/paints/patternRegions-expected.png:
* platform/qt/svg/batik/paints/patternRegions-expected.txt:
* platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/qt/svg/batik/text/longTextOnPath-expected.png:
* platform/qt/svg/batik/text/longTextOnPath-expected.txt:
* platform/qt/svg/batik/text/smallFonts-expected.png:
* platform/qt/svg/batik/text/smallFonts-expected.txt:
* platform/qt/svg/batik/text/textAnchor-expected.png:
* platform/qt/svg/batik/text/textAnchor-expected.txt:
* platform/qt/svg/batik/text/textAnchor2-expected.png:
* platform/qt/svg/batik/text/textAnchor2-expected.txt:
* platform/qt/svg/batik/text/textAnchor3-expected.png:
* platform/qt/svg/batik/text/textAnchor3-expected.txt:
* platform/qt/svg/batik/text/textDecoration-expected.png:
* platform/qt/svg/batik/text/textDecoration-expected.txt:
* platform/qt/svg/batik/text/textDecoration2-expected.png:
* platform/qt/svg/batik/text/textDecoration2-expected.txt:
* platform/qt/svg/batik/text/textEffect-expected.png:
* platform/qt/svg/batik/text/textEffect-expected.txt:
* platform/qt/svg/batik/text/textEffect2-expected.png:
* platform/qt/svg/batik/text/textEffect2-expected.txt:
* platform/qt/svg/batik/text/textEffect3-expected.png:
* platform/qt/svg/batik/text/textEffect3-expected.txt:
* platform/qt/svg/batik/text/textFeatures-expected.png:
* platform/qt/svg/batik/text/textFeatures-expected.txt:
* platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
* platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* platform/qt/svg/batik/text/textLayout2-expected.png:
* platform/qt/svg/batik/text/textLayout2-expected.txt:
* platform/qt/svg/batik/text/textLength-expected.png:
* platform/qt/svg/batik/text/textLength-expected.txt:
* platform/qt/svg/batik/text/textOnPath-expected.png:
* platform/qt/svg/batik/text/textOnPath-expected.txt:
* platform/qt/svg/batik/text/textOnPath2-expected.png:
* platform/qt/svg/batik/text/textOnPath2-expected.txt:
* platform/qt/svg/batik/text/textOnPath3-expected.png:
* platform/qt/svg/batik/text/textOnPath3-expected.txt:
* platform/qt/svg/batik/text/textPCDATA-expected.png:
* platform/qt/svg/batik/text/textPCDATA-expected.txt:
* platform/qt/svg/batik/text/textPosition-expected.png:
* platform/qt/svg/batik/text/textPosition-expected.txt:
* platform/qt/svg/batik/text/textPosition2-expected.png:
* platform/qt/svg/batik/text/textPosition2-expected.txt:
* platform/qt/svg/batik/text/textProperties-expected.png:
* platform/qt/svg/batik/text/textProperties-expected.txt:
* platform/qt/svg/batik/text/textProperties2-expected.png:
* platform/qt/svg/batik/text/textProperties2-expected.txt:
* platform/qt/svg/batik/text/verticalTextOnPath-expected.png:
* platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Do not call settings setters twice on page construction
rwlbuis@webkit.org [Tue, 24 Jul 2012 21:09:44 +0000 (21:09 +0000)]
[BlackBerry] Do not call settings setters twice on page construction
https://bugs.webkit.org/show_bug.cgi?id=92157

Reviewed by Yong Li.

The WebPagePrivate init method sets some settings value that were
already set in didChangeSettings.
Also call didChangeSettings explicitly from init, before that we are
not calling it since the delegate is not set yet.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in RenderTableSection::layoutRows
jchaffraix@webkit.org [Tue, 24 Jul 2012 20:59:14 +0000 (20:59 +0000)]
Crash in RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=92145

Reviewed by Abhishek Arya.

Source/WebCore:

The crash came from the insertChildNode logic being confused and choosing the wrong
renderer for insertion. This is because after r123159, table anonymous wrappers can
be created as 'inline-table' and wouldn't pass the isAnonymousBlock() check.

This change also aligns the ancestor iteration with RenderBlock::addChildToAnonymousColumnBlocks.

Test: fast/table/crash-table-section-layoutRows.html

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):
Changed the code to always get the right child. There is no justification to not
walking up to the |owner|'s direct child in all cases.

LayoutTests:

* fast/table/crash-table-section-layoutRows-expected.txt: Added.
* fast/table/crash-table-section-layoutRows.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake RenderBlock::paintChildren virtual so sub classes can change the paint order
tony@chromium.org [Tue, 24 Jul 2012 20:53:19 +0000 (20:53 +0000)]
Make RenderBlock::paintChildren virtual so sub classes can change the paint order
https://bugs.webkit.org/show_bug.cgi?id=92042

Reviewed by Ojan Vafai.

The flexbox spec says that the order property should change the paint order of flex children.
To make that possible, make paintChildren virtual so RenderFlexibleBox can override it.

No new tests, this is just a refactoring.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContents): Move some code out of paintChildren into paintContents.
(WebCore::RenderBlock::paintChildren): Make virtual and just have it be a simple for loop.
(WebCore::RenderBlock::paintChild): Move code out of paintChildren so subclasses can reuse.
* rendering/RenderBlock.h:
(RenderBlock): Make paintChildren virtual and protected so sub classes can call paintChild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] svg/clip-path rebaseline after new test fonts
caio.oliveira@openbossa.org [Tue, 24 Jul 2012 20:46:31 +0000 (20:46 +0000)]
[Qt] svg/clip-path rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92158

Unreviewed.

Create a separate bug to track two tests that had wrong expected results before
the font change.

* platform/qt-5.0/Skipped:
* platform/qt/svg/clip-path/clip-path-pixelation-expected.png:
* platform/qt/svg/clip-path/clip-path-pixelation-expected.txt:
* platform/qt/svg/clip-path/clip-path-text-and-shape-expected.png:
* platform/qt/svg/clip-path/clip-path-text-and-shape-expected.txt:
* platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.png:
* platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.txt:
* platform/qt/svg/clip-path/clip-path-text-expected.png:
* platform/qt/svg/clip-path/clip-path-text-expected.txt:
* platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.png:
* platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.txt:
* platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.png:
* platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.txt:
* platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
* platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
* platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
* platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
* platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
* platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate SourceBuffer and SourceBufferList objects
annacc@chromium.org [Tue, 24 Jul 2012 20:44:43 +0000 (20:44 +0000)]
Create SourceBuffer and SourceBufferList objects
https://bugs.webkit.org/show_bug.cgi?id=91771

Reviewed by Eric Carlson.

SourceBuffer and SourceBufferList objects are needed in order to
implement the new object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing BUGWK91775

Adding new files to build files:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:

New objects:
* Modules/mediasource/SourceBuffer.cpp: Added.
* Modules/mediasource/SourceBuffer.h: Added.
* Modules/mediasource/SourceBuffer.idl: Added.
* Modules/mediasource/SourceBufferList.cpp: Added.
* Modules/mediasource/SourceBufferList.h: Added.
* Modules/mediasource/SourceBufferList.idl: Added.

New events:
* dom/EventNames.h:
(WebCore):
* dom/EventTarget.h:
(WebCore):
* dom/EventTargetFactory.in:

Object constructors:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline - gardening stuff.
zmo@google.com [Tue, 24 Jul 2012 20:33:13 +0000 (20:33 +0000)]
Rebaseline - gardening stuff.

Unreviewed.

* fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
* fast/canvas/webgl/framebuffer-object-attachment.html:
* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
* platform/chromium-linux-x86/css3/selectors3/html: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
* platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
* platform/chromium-linux/css1/box_properties/acid_test-expected.png:
* platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
* platform/chromium-linux/fast/block/basic/011-expected.png:
* platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
* platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
* platform/chromium-linux/fast/forms/001-expected.png:
* platform/chromium-linux/fast/forms/basic-inputs-expected.png:
* platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
* platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
* platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
* platform/chromium-linux/fast/forms/formmove-expected.png:
* platform/chromium-linux/fast/forms/formmove2-expected.png:
* platform/chromium-linux/fast/forms/indeterminate-expected.png:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
* platform/chromium-linux/fast/forms/input-value-expected.png:
* platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
* platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
* platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
* platform/chromium-win-xp/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
* platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
* platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a bounding box member in WebGestureEvent
commit-queue@webkit.org [Tue, 24 Jul 2012 20:32:39 +0000 (20:32 +0000)]
[chromium] Add a bounding box member in WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=92144

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

The new |boundingBox| member will be used to store the touch region for a WebGestureEvent.
This will be useful for gesture target fuzzing across multiple different gesture types
(tap, long press, scroll, etc.)

* public/WebInputEvent.h:
(WebGestureEvent):
* src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/block/basic needs rebaseline after new test fonts
commit-queue@webkit.org [Tue, 24 Jul 2012 20:29:31 +0000 (20:29 +0000)]
[Qt] fast/block/basic needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92149

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-24
Reviewed by Alexis Menard.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/fast/block/basic/001-expected.png:
* platform/qt/fast/block/basic/001-expected.txt:
* platform/qt/fast/block/basic/002-expected.png:
* platform/qt/fast/block/basic/002-expected.txt:
* platform/qt/fast/block/basic/003-expected.png:
* platform/qt/fast/block/basic/003-expected.txt:
* platform/qt/fast/block/basic/004-expected.png:
* platform/qt/fast/block/basic/004-expected.txt:
* platform/qt/fast/block/basic/005-expected.png:
* platform/qt/fast/block/basic/005-expected.txt:
* platform/qt/fast/block/basic/006-expected.png:
* platform/qt/fast/block/basic/006-expected.txt:
* platform/qt/fast/block/basic/007-expected.png:
* platform/qt/fast/block/basic/007-expected.txt:
* platform/qt/fast/block/basic/008-expected.png:
* platform/qt/fast/block/basic/008-expected.txt:
* platform/qt/fast/block/basic/009-expected.png:
* platform/qt/fast/block/basic/009-expected.txt:
* platform/qt/fast/block/basic/010-expected.png:
* platform/qt/fast/block/basic/010-expected.txt:
* platform/qt/fast/block/basic/011-expected.png:
* platform/qt/fast/block/basic/011-expected.txt:
* platform/qt/fast/block/basic/012-expected.png:
* platform/qt/fast/block/basic/012-expected.txt:
* platform/qt/fast/block/basic/013-expected.png:
* platform/qt/fast/block/basic/013-expected.txt:
* platform/qt/fast/block/basic/014-expected.png:
* platform/qt/fast/block/basic/014-expected.txt:
* platform/qt/fast/block/basic/015-expected.png:
* platform/qt/fast/block/basic/015-expected.txt:
* platform/qt/fast/block/basic/016-expected.png:
* platform/qt/fast/block/basic/016-expected.txt:
* platform/qt/fast/block/basic/018-expected.png:
* platform/qt/fast/block/basic/018-expected.txt:
* platform/qt/fast/block/basic/019-expected.png:
* platform/qt/fast/block/basic/019-expected.txt:
* platform/qt/fast/block/basic/020-expected.txt:
* platform/qt/fast/block/basic/021-expected.png:
* platform/qt/fast/block/basic/021-expected.txt:
* platform/qt/fast/block/basic/adding-near-anonymous-block-expected.png:
* platform/qt/fast/block/basic/adding-near-anonymous-block-expected.txt:
* platform/qt/fast/block/basic/minheight-expected.png:
* platform/qt/fast/block/basic/minheight-expected.txt:
* platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.png:
* platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.txt:
* platform/qt/fast/block/basic/quirk-height-expected.png:
* platform/qt/fast/block/basic/quirk-height-expected.txt:
* platform/qt/fast/block/basic/truncation-rtl-expected.png:
* platform/qt/fast/block/basic/truncation-rtl-expected.txt:
* platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
* platform/qt/fast/block/basic/white-space-pre-wraps-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium/mac] Add cursor resource pngs to the pak file.
thakis@chromium.org [Tue, 24 Jul 2012 20:22:49 +0000 (20:22 +0000)]
[chromium/mac] Add cursor resource pngs to the pak file.
https://bugs.webkit.org/show_bug.cgi?id=92148

Reviewed by Tony Chang.

Once https://chromiumcodereview.appspot.com/10817031/ has landed, they can be
removed from WebCore.gyp's mac_bundle_resources. Part of http://crbug.com/137588

* WebKit.grd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] svg/carto.net rebaseline after new test fonts
caio.oliveira@openbossa.org [Tue, 24 Jul 2012 20:20:51 +0000 (20:20 +0000)]
[Qt] svg/carto.net rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92152

Unreviewed.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/carto.net/window-expected.png: Removed.
* platform/qt-5.0/svg/carto.net/window-expected.txt: Removed.
* platform/qt/svg/carto.net/button-expected.png:
* platform/qt/svg/carto.net/button-expected.txt:
* platform/qt/svg/carto.net/colourpicker-expected.png:
* platform/qt/svg/carto.net/colourpicker-expected.txt:
* platform/qt/svg/carto.net/scrollbar-expected.png:
* platform/qt/svg/carto.net/scrollbar-expected.txt:
* platform/qt/svg/carto.net/selectionlist-expected.png:
* platform/qt/svg/carto.net/selectionlist-expected.txt:
* platform/qt/svg/carto.net/slider-expected.png:
* platform/qt/svg/carto.net/slider-expected.txt:
* platform/qt/svg/carto.net/tabgroup-expected.png:
* platform/qt/svg/carto.net/tabgroup-expected.txt:
* platform/qt/svg/carto.net/textbox-expected.png:
* platform/qt/svg/carto.net/textbox-expected.txt:
* platform/qt/svg/carto.net/window-expected.png:
* platform/qt/svg/carto.net/window-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make sure that an AC sync is triggered when the canvas contents is updated.
jocelyn.turcotte@nokia.com [Tue, 24 Jul 2012 20:17:36 +0000 (20:17 +0000)]
[Qt] Make sure that an AC sync is triggered when the canvas contents is updated.
https://bugs.webkit.org/show_bug.cgi?id=92128

Reviewed by Kenneth Rohde Christiansen.

This would cause missed frames when animating an accelerated 2D canvas without
touching the document.

* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac WK2] Improve text input logging
ap@apple.com [Tue, 24 Jul 2012 20:15:40 +0000 (20:15 +0000)]
[Mac WK2] Improve text input logging
https://bugs.webkit.org/show_bug.cgi?id=92147

Reviewed by Andreas Kling.

* UIProcess/API/mac/WKView.mm:
(-[WKView insertText:replacementRange:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
(-[WKView _executeSavedKeypressCommands]):
(-[WKView _notifyInputContextAboutDiscardedComposition]):
(-[WKView _interpretKeyEvent:savingCommandsTo:WebCore::]):
(-[WKView _updateSecureInputState]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] platform, plugins and printing need rebaseline after new test fonts
commit-queue@webkit.org [Tue, 24 Jul 2012 20:11:04 +0000 (20:11 +0000)]
[Qt] platform, plugins and printing need rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92016

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-24
Reviewed by Alexis Menard.

Updating skipped tests inside platform, plugins and printing. The following tests
remain skipped:
/platform/qt/plugins/qt-qwidget-plugin.html (bug #92141)
/plugins/netscape-dom-access.html (already skipped inside qt/Skipped)

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
* platform/qt/platform/qt/fast/forms/button-line-break-expected.txt:
* platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.png: Added.
* platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
* platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.png: Added.
* platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
* platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
* platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/qt/printing/compositing-layer-printing-expected.png:
* platform/qt/printing/compositing-layer-printing-expected.txt:
* platform/qt/printing/iframe-print-expected.png:
* platform/qt/printing/iframe-print-expected.txt:
* platform/qt/printing/media-queries-print-expected.png:
* platform/qt/printing/media-queries-print-expected.txt:
* platform/qt/printing/page-rule-in-media-query-expected.png:
* platform/qt/printing/page-rule-in-media-query-expected.txt:
* platform/qt/printing/simultaneous-position-float-change-expected.txt:
* platform/qt/printing/width-overflow-expected.png:
* platform/qt/printing/width-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThrottle calls to request the virtual keyboard be shown.
mifenton@rim.com [Tue, 24 Jul 2012 19:59:45 +0000 (19:59 +0000)]
Throttle calls to request the virtual keyboard be shown.
https://bugs.webkit.org/show_bug.cgi?id=92138

Reviewed by Rob Buis.

PR 178465.

Do not request keyboard visibility change when
we are actively processing an input event.

Reviewed Internally by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Enable conversion between WebFloatRect and gfx::RectF.
leandrogracia@chromium.org [Tue, 24 Jul 2012 19:48:07 +0000 (19:48 +0000)]
[Chromium] Enable conversion between WebFloatRect and gfx::RectF.
https://bugs.webkit.org/show_bug.cgi?id=92117

Reviewed by Adam Barth.

Introduce WebFloatRect <--> gfx::RectF conversion as we already do with WebRect <--> gfx::Rect.

* chromium/public/WebFloatRect.h:
(WebKit::WebFloatRect::WebFloatRect):
(WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator gfx::RectF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r123417): It made tests assert/crash on 32 bit
fpizlo@apple.com [Tue, 24 Jul 2012 19:47:18 +0000 (19:47 +0000)]
REGRESSION(r123417): It made tests assert/crash on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=92088

Reviewed by Mark Hahnenberg.

The pointer arithmetic was wrong, because negative numbers are hard to think about.

* dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutTransitionStub):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Provide more useful output when an injected bundle cannot be loaded
commit-queue@webkit.org [Tue, 24 Jul 2012 19:45:17 +0000 (19:45 +0000)]
[EFL][WK2] Provide more useful output when an injected bundle cannot be loaded
https://bugs.webkit.org/show_bug.cgi?id=92136

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Call eina_error_get() in case an injected bundle cannot be
loaded in order to print more information about the error.

* WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAndroid-chromium layout tests failing with GPU related crash
peter@chromium.org [Tue, 24 Jul 2012 19:40:26 +0000 (19:40 +0000)]
Android-chromium layout tests failing with GPU related crash
https://bugs.webkit.org/show_bug.cgi?id=92126

Reviewed by Adam Barth.

Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
as it's not being used by any port anymore, and neither is being passed
on to the test runner. Instead, append the flag directly to DRT for the
Chromium Android port, which does rely on this functionality.

The ChromiumAndroidUnitTest tests didn't catch this as the property was
set to True, but it's unable to detect whether they'll actually be used.
No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_attributes):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
commit-queue@webkit.org [Tue, 24 Jul 2012 19:32:52 +0000 (19:32 +0000)]
[WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
https://bugs.webkit.org/show_bug.cgi?id=92107

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Fixes mouse click events in EventSenderProxyEfl.

* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::dispatchMouseDownEvent):
(WTR::EventSenderProxy::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStore the full year in GregorianDateTime
paroga@webkit.org [Tue, 24 Jul 2012 19:25:30 +0000 (19:25 +0000)]
Store the full year in GregorianDateTime
https://bugs.webkit.org/show_bug.cgi?id=92067

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

* runtime/DateConstructor.cpp:
(JSC::constructDate):
(JSC::dateUTC):
* runtime/DateConversion.cpp:
(JSC::formatDate):
(JSC::formatDateUTCVariant):
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncSetYear):
* runtime/JSDateMath.cpp:
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):

Source/WebCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
* bridge/qt/qt_runtime_qt4.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

Source/WTF:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

* wtf/GregorianDateTime.h:
(WTF::GregorianDateTime::operator tm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo not perform 8 to 16bits characters conversion when converting a WTFString to NSStr...
benjamin@webkit.org [Tue, 24 Jul 2012 19:12:42 +0000 (19:12 +0000)]
Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-24
Reviewed by Geoffrey Garen.

In most String to CFString conversion, we should be able to use the "NoCopy" constructor and have
a relatively cheap conversion from WTF::String to CFString.

When the String is 8 bits, it was converted to 16 bits by getData16SlowCase() because of the call
to String::characters().

This patch adds a path for creating a CFString from a 8bits string using CFStringCreateWithBytes.

This is covered by existing tests.

* platform/text/cf/StringCF.cpp:
(WTF::String::createCFString): CFSTR() create static CFString, it is unecessary to retain it.
* platform/text/cf/StringImplCF.cpp:
(WTF::StringImpl::createCFString): The logic to avoid the StringWrapperCFAllocator has also been simplified.
The allocator creation is now closer to where it is useful.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Build fix after r123417.
paroga@webkit.org [Tue, 24 Jul 2012 19:03:57 +0000 (19:03 +0000)]
[WIN] Build fix after r123417.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Re-skip failing tests for Qt 4.8 platform
commit-queue@webkit.org [Tue, 24 Jul 2012 18:55:32 +0000 (18:55 +0000)]
[Qt] Re-skip failing tests for Qt 4.8 platform
https://bugs.webkit.org/show_bug.cgi?id=92119

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

The following tests, after unskipping, are now passing on Qt-5.0 build bot
variations, but still failing for Qt-4.8 ones:

Regressions: Unexpected text diff mismatch : (1)
  http/tests/misc/acid3.html = TEXT

Regressions: Unexpected image mismatch : (2)
  fast/css/tab-size.html = IMAGE
  fast/text/international/bdi-dir-default-to-auto.html = IMAGE

This patch adds these to Skipped list of qt-4.8 platform.

* platform/qt-4.8/Skipped: Added 3 layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] String wrappers should be marked Independent
haraken@chromium.org [Tue, 24 Jul 2012 18:42:54 +0000 (18:42 +0000)]
[V8] String wrappers should be marked Independent
https://bugs.webkit.org/show_bug.cgi?id=91251

Reviewed by Adam Barth.

Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.
Although I couldn't find a case where this change reduces memory usage,
this change would be important for upcoming changes in string conversion
between V8 and WebKit (https://bugs.webkit.org/show_bug.cgi?id=91850).

'm_lastStringImpl = 0' in StringCache::remove() is important.
Look at the following code:

    static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void* parameter)
    {
        ...;
        stringCache()->remove(stringImpl);
        wrapper.Dispose();
    }

    void StringCache::remove(StringImpl* stringImpl)
    {
        ...
        if (m_lastStringImpl.get() == stringImpl)
            m_lastStringImpl = 0;
    }

    v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl, v8::Isolate* isolate)
    {
        if (m_lastStringImpl.get() == stringImpl) {
            return v8::Local<v8::String>::New(m_lastV8String); // m_lastV8String points to a wrapper object that was accessed most recently.
        }
        return v8ExternalStringSlow(stringImpl, isolate);
    }

Without 'm_lastStringImpl = 0', already disposed m_lastV8String can be used
in v8ExternalString(). This was a cause of the crashes of r122614.

Tests: At the initial commit of this patch (r122614),
       the following tests had been broken due to missing 'm_lastStringImpl = 0'.
       fast/workers/worker-location.html
       Dromaeo/cssquery-jquery.html
       Dromaeo/jslib-event-jquery.html
       Dromaeo/jslib-style-jquery.html
       Dromaeo/jslib-style-prototype.html

* bindings/v8/V8Binding.cpp:
(WebCore::StringCache::remove):
(WebCore::StringCache::v8ExternalStringSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Update MediaStreamTrack to match the specification
tommyw@google.com [Tue, 24 Jul 2012 18:33:18 +0000 (18:33 +0000)]
MediaStream API: Update MediaStreamTrack to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90180

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebMediaStreamDescriptor.h:
(WebMediaStreamDescriptor):
* chromium/public/WebMediaStreamSource.h:
(WebMediaStreamSource):

Source/WebCore:

MediaStreamTracks are now required to show the status of the underlying source,
and trigger events when that status changes.

Test: fast/mediastream/MediaStreamTrack.html

* GNUmakefile.list.am:
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::readyState):
(WebCore):
(WebCore::MediaStreamTrack::sourceChangedState):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::interfaceName):
(WebCore::MediaStreamTrack::scriptExecutionContext):
(WebCore::MediaStreamTrack::eventTargetData):
(WebCore::MediaStreamTrack::ensureEventTargetData):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/EventTargetFactory.in:
* platform/chromium/support/WebMediaStreamDescriptor.cpp:
* platform/chromium/support/WebMediaStreamSource.cpp:
(WebKit::WebMediaStreamSource::setReadyState):
(WebKit):
(WebKit::WebMediaStreamSource::readyState):
* platform/mediastream/MediaStreamSource.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamSource.h.
(WebCore):
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::setReadyState):
(WebCore::MediaStreamSource::addObserver):
(WebCore::MediaStreamSource::removeObserver):
* platform/mediastream/MediaStreamSource.h:
(Observer):
(WebCore::MediaStreamSource::Observer::~Observer):
(MediaStreamSource):
(WebCore::MediaStreamSource::readyState):
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Tools:

Adding a Mock WebMediaStreamCenter to enable better LayoutTests.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::createMediaStreamCenter):
* DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
(WebKit):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
(WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
(WebKit::MockWebMediaStreamCenter::constructSDP):
* DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
(WebKit):
(MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

LayoutTests:

* fast/mediastream/MediaStreamTrack-expected.txt: Added.
* fast/mediastream/MediaStreamTrack.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix regressions in replay performance tests
rniwa@webkit.org [Tue, 24 Jul 2012 18:30:00 +0000 (18:30 +0000)]
Fix regressions in replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92052

Reviewed by Dirk Pranke.

Fix regression that accumulated over time to make replay tests work again.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
URL hadn't been updated yet When requesting a new URL on the main frame.
* Scripts/webkitpy/performance_tests/perftest.py:
(ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
(ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
(ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestReplayPerfTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed expectations change for chromium to address lint error from r90190.
atwilson@chromium.org [Tue, 24 Jul 2012 18:25:02 +0000 (18:25 +0000)]
Unreviewed expectations change for chromium to address lint error from r90190.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse native (non-cygwin) binaries for perl, gperf, and bison in Chromium
tony@chromium.org [Tue, 24 Jul 2012 18:23:41 +0000 (18:23 +0000)]
Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).

Also, use - instead of / for cl flags, otherwise preprocessing fails
very slowly (due to retry loop). And, replace \ with / in gperf
command line. Without this, gperf emits the filename literally in
#line directives which causes VS to error with "unescaped \ in
string". Bizarrely, building ColorData.cpp with those \ in place
causes the IDE to exit with no error message, which was the cause of
the previous canary failures.

No new tests.

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/rule_bison.py:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
* make-hash-tools.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFiles from drag and file <input> should use getMIMETypeForExtension to determine...
dcheng@chromium.org [Tue, 24 Jul 2012 18:17:44 +0000 (18:17 +0000)]
Files from drag and file <input> should use getMIMETypeForExtension to determine content type.
https://bugs.webkit.org/show_bug.cgi?id=91702

Reviewed by Jian Li.

Awhile back, we changed File to only use getWellKnownMIMETypeForExtension to prevent web
pages from being able to detect what applications a user has installed indirectly through
the MIME types. However, some sites like YouTube's drag and drop uploader use MIME types
that aren't in WebKit's internal list, so we relax the restriction for Files that originate
from an user action.

* fileapi/File.cpp:
(WebCore::getContentTypeFromFileName):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
(WebCore::createBlobDataForFileWithMetadata):
(WebCore::File::createWithRelativePath):
(WebCore::File::File):
* fileapi/File.h:
(File):
(WebCore::File::create):
(WebCore::File::createWithName):
* html/FileInputType.cpp:
(WebCore::FileInputType::createFileList):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::addFilename):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::files):
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::files):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::files):
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Snippets UI polish
vsevik@chromium.org [Tue, 24 Jul 2012 18:05:14 +0000 (18:05 +0000)]
Web Inspector: Snippets UI polish
https://bugs.webkit.org/show_bug.cgi?id=92142

Reviewed by Pavel Feldman.

Changed snippets context menu items.
Added run snippet status bar button.
Removed unused edit source button.

* English.lproj/localizedStrings.js:
* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.statusBarItems):
* inspector/front-end/inspector.css:
* inspector/front-end/scriptsPanel.css:
(.evaluate-snippet-status-bar-item .glyph):
(.evaluate-snippet-status-bar-item.toggled .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium/mac] Remove webcore_resource_files from WebCore.gypi
thakis@chromium.org [Tue, 24 Jul 2012 17:47:48 +0000 (17:47 +0000)]
[chromium/mac] Remove webcore_resource_files from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=92129

Reviewed by Adam Barth.

It was added in http://trac.webkit.org/changeset/81706/trunk/Source/WebCore/WebCore.gypi .
The changes in that revision were mostly reverted in http://trac.webkit.org/changeset/119921 ,
but this block was forgotten. Since it just confused me for a bit, remove it.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinline-table wrapper should be generated for display: inline element only
jchaffraix@webkit.org [Tue, 24 Jul 2012 17:44:29 +0000 (17:44 +0000)]
inline-table wrapper should be generated for display: inline element only
https://bugs.webkit.org/show_bug.cgi?id=92054

Reviewed by Abhishek Arya.

Source/WebCore:

CSS 2.1 only takes into account the display when determining if we should generate
an inline-table. My misreading of the spec would make us generate an inline-table
wrapper for any inline formatting context.

Test: fast/table/inline-block-generates-table-wrapper.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::createAnonymousWithParentRenderer):
Changed to use display instead of isInline to properly match the spec.

LayoutTests:

For some reason, using dumpAsText didn't dump the 2 lines properly so the test
is a reftest to work-around that.

* fast/table/inline-block-generates-table-wrapper-expected.html: Added.
* fast/table/inline-block-generates-table-wrapper.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123472.
commit-queue@webkit.org [Tue, 24 Jul 2012 17:19:15 +0000 (17:19 +0000)]
Unreviewed, rolling out r123472.
http://trac.webkit.org/changeset/123472
https://bugs.webkit.org/show_bug.cgi?id=92134

Revert roll to v8 version that crashes sporadically (Requested
by atwilson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unskip tests in fast/hidpi
commit-queue@webkit.org [Tue, 24 Jul 2012 17:16:43 +0000 (17:16 +0000)]
[chromium] Unskip tests in fast/hidpi
https://bugs.webkit.org/show_bug.cgi?id=90190

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

Adding cr-linux baselines so that the EWS will go green. Will be adding new
baselines for the chromium ports with WebKit gardener atwilson@.

* platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
* platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
* platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
* platform/chromium-linux/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/device-scale-factor-paint-expected.png: Added.
* platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-as-background-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-as-background-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-background-dynamic-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-background-repeat-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-background-repeat-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-border-image-simple-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-out-of-order-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-out-of-order-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-simple-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-simple-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/image-set-without-specified-width-expected.png: Added.
* platform/chromium-linux/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/resize-corner-hidpi-expected.png: Added.
* platform/chromium-linux/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
* platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
* platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Temporarily continue generating backend keys for empty key lists
commit-queue@webkit.org [Tue, 24 Jul 2012 17:11:17 +0000 (17:11 +0000)]
IndexedDB: Temporarily continue generating backend keys for empty key lists
https://bugs.webkit.org/show_bug.cgi?id=92012

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Temporarily change key behavior to allow chromium in_process_webkit
to call putWithIndexKeys without inadvertently preventing index
key generation. Note this is temporary until frontend key generation
patch lands.

No new tests, this is part of a refactor that doesn't change behavior.

* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: introduce UISourceCodeFrame.
pfeldman@chromium.org [Tue, 24 Jul 2012 17:09:07 +0000 (17:09 +0000)]
Web Inspector: introduce UISourceCodeFrame.
https://bugs.webkit.org/show_bug.cgi?id=92124

Reviewed by Vsevolod Vlasov.

Generic implementation of SourceFrame over UISourceCode added.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/StylesPanel.js:
* inspector/front-end/UISourceCodeFrame.js: Added.
(WebInspector.UISourceCodeFrame):
(WebInspector.UISourceCodeFrame.prototype.canEditSource):
(WebInspector.UISourceCodeFrame.prototype.commitEditing):
(WebInspector.UISourceCodeFrame.prototype.afterTextChanged):
(WebInspector.UISourceCodeFrame.prototype._didEditContent):
(WebInspector.UISourceCodeFrame.prototype._onContentChanged):
(WebInspector.UISourceCodeFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update about:config lists
commit-queue@webkit.org [Tue, 24 Jul 2012 17:05:44 +0000 (17:05 +0000)]
[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=92118

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-24
Reviewed by Rob Buis.

We want to have all flags which could be used / have been used by any platform. These lists were created by running:

* WebCoreSupport/AboutDataEnableFeatures.in: `git grep "ENABLE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
* WebCoreSupport/AboutDataHaveFeatures.in: `git grep "HAVE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`
* WebCoreSupport/AboutDataUseFeatures.in: `git grep "USE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u`

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11945102> REGRESSION (r109451): Overlay scrollbars always use the...
mitz@apple.com [Tue, 24 Jul 2012 16:17:57 +0000 (16:17 +0000)]
<rdar://problem/11945102> REGRESSION (r109451): Overlay scrollbars always use the default style, regardless of background color
https://bugs.webkit.org/show_bug.cgi?id=92115

Reviewed by Mark Rowe.

* platform/Scrollbar.cpp:
(WebCore::Scrollbar::scrollbarOverlayStyle): Reversed an incorrect null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother prospective build fix for Chromium. Unreviewed.
atwilson@chromium.org [Tue, 24 Jul 2012 16:00:22 +0000 (16:00 +0000)]
Another prospective build fix for Chromium. Unreviewed.

* platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove unused variable in BackingStore.cpp
commit-queue@webkit.org [Tue, 24 Jul 2012 15:51:22 +0000 (15:51 +0000)]
[BlackBerry] Remove unused variable in BackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=91987

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-24
Reviewed by Antonio Gomes.

PR: 141439
This is done as part of some general BackingStorePrivate::render()
cleanup in PR 141439.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add pixel expectations for new test scrollbar-tickmarks-styled.html
commit-queue@webkit.org [Tue, 24 Jul 2012 15:44:26 +0000 (15:44 +0000)]
[chromium] Add pixel expectations for new test scrollbar-tickmarks-styled.html
https://bugs.webkit.org/show_bug.cgi?id=92116

Unreviewed.

Patch by Nico Weber <nicolasweber@gmx.de> on 2012-07-24

* platform/chromium-win/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add vibration client
commit-queue@webkit.org [Tue, 24 Jul 2012 15:40:05 +0000 (15:40 +0000)]
[EFL][WK2] Add vibration client
https://bugs.webkit.org/show_bug.cgi?id=91371

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-24
Reviewed by Antonio Gomes.

Implement Vibration provider for WebKit2 EFL and add an API to set
vibration client callbacks by application to handle the tactile
feedback in the application when the page content ask for vibration.

* CMakeLists.txt: Add WebCore/Modules/vibration to include path.
* PlatformEfl.cmake: Add VibrationProvider.cpp file to the build
system.
* UIProcess/API/efl/VibrationProvider.cpp: Added.
(_Ewk_Vibration_Client): Structure contains the vibration client
callbacks.
(_Ewk_Vibration_Client::_Ewk_Vibration_Client):
(toVibrationProvider): Helper function to cast the clientinfo to
VibrationProvider.
(vibrateCallback):
(cancelVibrationCallback):
(VibrationProvider::create):
(VibrationProvider::VibrationProvider):
(VibrationProvider::~VibrationProvider):
(VibrationProvider::vibrate):
(VibrationProvider::cancelVibration):
(VibrationProvider::setVibrationClientCallbacks):
* UIProcess/API/efl/VibrationProvider.h: Added.
(VibrationProvider):
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(createDefaultEwkContext):
(ewk_context_vibration_client_callbacks_set): API to set vibration
client callbacks.
* UIProcess/API/efl/ewk_context.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing and flaky tests
commit-queue@webkit.org [Tue, 24 Jul 2012 15:38:10 +0000 (15:38 +0000)]
[EFL] Gardening of failing and flaky tests
https://bugs.webkit.org/show_bug.cgi?id=92105

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-24

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed prospective build fix for Chromium. Changed include of hb.h in HarfBuzzNGF...
atwilson@chromium.org [Tue, 24 Jul 2012 15:37:34 +0000 (15:37 +0000)]
Unreviewed prospective build fix for Chromium. Changed include of hb.h in HarfBuzzNGFace.h

* platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Page popup should close on mouse down
keishi@webkit.org [Tue, 24 Jul 2012 15:31:29 +0000 (15:31 +0000)]
[Chromium] Page popup should close on mouse down
https://bugs.webkit.org/show_bug.cgi?id=92092

Reviewed by Kent Tamura.

Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that
we can hook to hide the page popup when the user clicks on the page.

* src/WebPagePopupImpl.h:
(WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the
mouse down event opened the same popup we just closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip layout test after monospace-font fix
commit-queue@webkit.org [Tue, 24 Jul 2012 15:25:21 +0000 (15:25 +0000)]
[Qt] Unskip layout test after monospace-font fix
https://bugs.webkit.org/show_bug.cgi?id=86179

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

This test has been skipped because monospace fonts weren't properly to
HTML tags like <pre>, for instance. After r121971, the test results are
normal again.

* platform/qt/Skipped: Unskipped fast/css/tab-size.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Tue, 24 Jul 2012 14:58:12 +0000 (14:58 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix compilation after QtQuick API changes
ossy@webkit.org [Tue, 24 Jul 2012 14:47:33 +0000 (14:47 +0000)]
[Qt] Fix compilation after QtQuick API changes
https://bugs.webkit.org/show_bug.cgi?id=91822

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

QQuickCanvas is now QQuickWindow, QQuickItem::canvas() is window() and rootItem()
is contentItem(). Also QQuickWindow::grabFrameBuffer() is now grabWindow().

* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::updateIcon):
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::basicRenderingSanity):
(tst_QQuickWebView::transparentWebViews):
* UIProcess/API/qt/tests/testwindow.h:
(TestWindow::TestWindow):
* UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::isViewVisible):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz
commit-queue@webkit.org [Tue, 24 Jul 2012 14:40:48 +0000 (14:40 +0000)]
HarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=92103

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-24
Reviewed by Philippe Normand.

As preparation for enabling harfbuzz-ng for EFL, I would like to include the header
here since the forward declarations are conflicting with the harfbuzz version
we will use for EFL.

No new tests, no change in behavior.

* platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Updated acid3 layout test results after monospace fix
commit-queue@webkit.org [Tue, 24 Jul 2012 14:33:40 +0000 (14:33 +0000)]
[Qt] Updated acid3 layout test results after monospace fix
https://bugs.webkit.org/show_bug.cgi?id=87501

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

Updated Qt (same for WK1 and WK2) layout test results for
http/tests/misc/acid3.html after monospace font fix landed in r121971.

* platform/qt/Skipped: Unskip http/tests/misc/acid3.html.
* platform/qt/http/tests/misc/acid3-expected.png: Added.
* platform/qt/http/tests/misc/acid3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip layout test after monospace-font fix
commit-queue@webkit.org [Tue, 24 Jul 2012 14:17:15 +0000 (14:17 +0000)]
[Qt] Unskip layout test after monospace-font fix
https://bugs.webkit.org/show_bug.cgi?id=81899

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

This test has been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

* platform/qt/Skipped: Unskipped layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
jochen@chromium.org [Tue, 24 Jul 2012 14:07:41 +0000 (14:07 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r123100. Added baseline to tests that have been unski...
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 13:50:08 +0000 (13:50 +0000)]
[Qt] Unreviewed gardening after r123100. Added baseline to tests that have been unskipped.
https://bugs.webkit.org/show_bug.cgi?id=91739

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24

* platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
* platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
* platform/qt-5.0/fast/events/onload-re-entry-expected.png: Added.
* platform/qt-5.0/fast/events/onload-re-entry-expected.txt: Added.
* platform/qt-5.0/fast/events/touch/touch-slider-expected.txt: Added.
* platform/qt-5.0/fast/events/touch/touch-slider-no-js-touch-listener-expected.txt: Added.
* platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
* platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123463.
commit-queue@webkit.org [Tue, 24 Jul 2012 13:42:56 +0000 (13:42 +0000)]
Unreviewed, rolling out r123463.
http://trac.webkit.org/changeset/123463
https://bugs.webkit.org/show_bug.cgi?id=92110

Broke Android build (Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

* src/WebPagePopupImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r123432. Added baseline to fast/text/whitespace/028...
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 13:41:32 +0000 (13:41 +0000)]
[Qt] Unreviewed gardening after r123432. Added baseline to fast/text/whitespace/028.html
after is has been unskipped.
https://bugs.webkit.org/show_bug.cgi?id=91971

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24

* platform/qt.5-0/fast/text/whitespace/028-expected.png: Added.
* platform/qt.5-0/fast/text/whitespace/028-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd some Japanese and Swedish websites to replay tests
rniwa@webkit.org [Tue, 24 Jul 2012 13:40:52 +0000 (13:40 +0000)]
Add some Japanese and Swedish websites to replay tests
https://bugs.webkit.org/show_bug.cgi?id=92076

Reviewed by Andreas Kling.

Added new replay tests as follows.

* Replay/Japanese: Added.
* Replay/Japanese/2ch.net-newsplus.replay: Added.
* Replay/Japanese/ja.wikipedia.org.replay: Added.
* Replay/Japanese/www.livedoor.com.replay: Added.
* Replay/Japanese/www.rakuten.co.jp.replay: Added.
* Replay/Japanese/www.yahoo.co.jp.replay: Added.
* Replay/Swedish: Added.
* Replay/Swedish/www.flashback.se.replay: Added.
* Replay/Swedish/www.tradera.com.replay: Added.
* Replay/www.techcrunch.com.replay: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix blend filter for autovectorizing
allan.jensen@nokia.com [Tue, 24 Jul 2012 13:37:43 +0000 (13:37 +0000)]
Fix blend filter for autovectorizing
https://bugs.webkit.org/show_bug.cgi?id=91398

Reviewed by Nikolas Zimmermann.

To support auto-vectorizing, the loop had to be unswitched, and regular arrays used that
did not do boundary-checks in the inner loop. Finally the integer division by 255
was optimized not use integer division intrinsics.

On a X86-64 architechture using GCC -O3 on the file, this gives a speed-up of 2.9x.

* platform/graphics/filters/FEBlend.cpp:
(WebCore::fastDivideBy255):
(BlendNormal):
(WebCore::BlendNormal::apply):
(BlendMultiply):
(WebCore::BlendMultiply::apply):
(BlendScreen):
(WebCore::BlendScreen::apply):
(BlendDarken):
(WebCore::BlendDarken::apply):
(BlendLighten):
(WebCore::BlendLighten::apply):
(BlendUnknown):
(WebCore::BlendUnknown::apply):
(WebCore::platformApply):
(WebCore::FEBlend::platformApplyGeneric):
(WebCore::FEBlend::platformApplySoftware):
* platform/graphics/filters/FEBlend.h:
(FEBlend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Update expectations after r122988 and r122712.
kkristof@inf.u-szeged.hu [Tue, 24 Jul 2012 13:33:57 +0000 (13:33 +0000)]
[Qt] Unreviewed gardening. Update expectations after r122988 and r122712.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-24

* platform/qt-5.0-wk2/editing/deleting/5144139-2-expected.txt: Added after r122712.
* platform/qt-5.0/editing/deleting/5144139-2-expected.txt: Removed.
* platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.png: Added after r122988.
* platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.txt: Added after r122988.
* platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added after r122988.
* platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added after r122988.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
hausmann@webkit.org [Tue, 24 Jul 2012 13:24:30 +0000 (13:24 +0000)]
[Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
https://bugs.webkit.org/show_bug.cgi?id=91229

Reviewed by Jocelyn Turcotte.

In order to successfully link a DLL on Windows we need to have at least
one object file (or compilation unit). The forward export header files were
supposed to be that, but unfortunately the rule in win32/default_post.prf for
creating the header files had some bugs, among others that it did an exists()
check on the depending static library. At the time qmake is ran those libraries
do not exist yet and therefore the corresponding extra compiler rules were never
created, resulting in empty OBJECTS/SOURCES.

Even without such an exists() check, qmake extra compilers require the files
referred to in the .input variable to exist at qmake time. In this case the input
files were the static libraries, which do not exist yet.

This patch solves this by using a qmake extra target instead of extra
compiler, which does not have this limitation. The target is referenced
through the extension of GENERATED_SOURCES.

The patch also adds a d/_debug suffix for debug builds, do allow for separate
symbol exports if necessary.

* Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
consider the last argument to be the output file and everything else input.
* qmake/mkspecs/features/win32/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add quirks for running the web process in a profiler shell, like valgrind
kbalazs@webkit.org [Tue, 24 Jul 2012 13:14:46 +0000 (13:14 +0000)]
[Qt] Add quirks for running the web process in a profiler shell, like valgrind
https://bugs.webkit.org/show_bug.cgi?id=87672

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

If environment variables QT_WEBKIT_WEB_PROCESS_COMMAND_PREFIX
and/or QT_WEBKIT_PLUGIN_PROCESS_COMMAND_PREFIX are set, use their
values as the prefix of the command when launching the child process.
Example usage:
    export QT_WEB_PROCESS_COMMAND_PREFIX="valgrind --smc-check=all"
    ./MiniBrowser http://somepage.html
    ./WebKitTestRunner --no-timeout-at-all some_layouttest.html

* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):

Tools:

Add --no-timeout-at-all command line switch to not time out no matter how
long the web process does it's job. --no-timeout is not enough for profiling
purposes because it only affects the timeout when we are waiting for the end
of the test. We use another timeout to control how much we wait for the web
process to initialize before and reset after the test and it could also easily
expire when running under valgrind. We should keep the behavior of --no-timeout
to not disable this timout check because --no-timeout is used by performace tests
and those should not wait for the web process to initialize and reset more than
normal tests.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runUntil):
* WebKitTestRunner/TestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Page popup should close on mouse down
keishi@webkit.org [Tue, 24 Jul 2012 12:38:02 +0000 (12:38 +0000)]
[Chromium] Page popup should close on mouse down
https://bugs.webkit.org/show_bug.cgi?id=92092

Reviewed by Kent Tamura.

Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that
we can hook to hide the page popup when the user clicks on the page.

* src/WebPagePopupImpl.h:
(WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the
mouse down event opened the same popup we just closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/css/text-transform-select.html should be rebaselined for WK1 and WK2 on...
caio.oliveira@openbossa.org [Tue, 24 Jul 2012 12:26:48 +0000 (12:26 +0000)]
[Qt] fast/css/text-transform-select.html should be rebaselined for WK1 and WK2 on Qt 5.0
https://bugs.webkit.org/show_bug.cgi?id=77377

Reviewed by Simon Hausmann.

Test now pass in both WK1 and WK2.

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeech JavaScript API: Add the SpeechRecognitionResult.emma attribute
hans@chromium.org [Tue, 24 Jul 2012 12:25:13 +0000 (12:25 +0000)]
Speech JavaScript API: Add the SpeechRecognitionResult.emma attribute
https://bugs.webkit.org/show_bug.cgi?id=91743

Reviewed by Adam Barth.

Source/WebCore:

Implement the 'emma' attribute as described in the spec draft at
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html

Test: fast/speech/scripted/emma.html

* Modules/speech/SpeechRecognitionResult.cpp:
(WebCore::SpeechRecognitionResult::~SpeechRecognitionResult):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):
* Modules/speech/SpeechRecognitionResult.h:
(WebCore):
(SpeechRecognitionResult):
* Modules/speech/SpeechRecognitionResult.idl:
* WebCore.gypi:
* bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp:
(WebCore):
(WebCore::V8SpeechRecognitionResult::visitDOMWrapper):
  We need to add an implicit reference from the result object to the
  emma object to keep the latters DOM tree alive across
  garbage-collection.

LayoutTests:

Add layout test for the SpeechRecognitionResult.emma attribute.

* fast/speech/scripted/emma.html: Added.
* fast/speech/scripted/emma-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 24 Jul 2012 12:09:49 +0000 (12:09 +0000)]
Unreviewed GTK gardening.

Skipping tests added in r123343 and adding a test expectation for
an accessibility test added in r123428.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Protocol Extension: add getFlowByName command
commit-queue@webkit.org [Tue, 24 Jul 2012 12:00:33 +0000 (12:00 +0000)]
Web Inspector: Protocol Extension: add getFlowByName command
https://bugs.webkit.org/show_bug.cgi?id=91855

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-24
Reviewed by Pavel Feldman.

Source/WebCore:

The "getFlowByName" command should return a NamedFlow for a given document and name.

Test: inspector/styles/protocol-css-regions-commands.html

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayload):

LayoutTests:

Created a single test suite for the WebInspector protocol extension for CSS Regions.

* inspector/styles/protocol-css-regions-commands-expected.txt: Added.
* inspector/styles/protocol-css-regions-commands.html: Added.
* inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Removed.
* inspector/styles/protocol-getNamedFlowCollection-command.html: Removed.
* platform/efl/TestExpectations:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK1] color input type support
pierre.rossi@gmail.com [Tue, 24 Jul 2012 11:48:20 +0000 (11:48 +0000)]
[Qt][WK1] color input type support
https://bugs.webkit.org/show_bug.cgi?id=91998

Reviewed by Simon Hausmann.

Using QColorDialog. This is private for now, but
it could be exposed via a virtual function in
QWebPage at a later point in a Qt 5 minor release
if there are requests for that.

* Api/qwebpage.cpp:
(QWebPagePrivate::colorSelectionRequested):
* Api/qwebpage_p.h:
(QWebPagePrivate):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createColorChooser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
peter@chromium.org [Tue, 24 Jul 2012 11:37:15 +0000 (11:37 +0000)]
[Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
https://bugs.webkit.org/show_bug.cgi?id=92097

Unreviewed build fix.

WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
but TestDelegate.h forward declares it as a class.

* DumpRenderTree/chromium/TestRunner/TestDelegate.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix compilation against namespaced Qt
hausmann@webkit.org [Tue, 24 Jul 2012 11:33:43 +0000 (11:33 +0000)]
[Qt] Fix compilation against namespaced Qt

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-23
Reviewed by Simon Hausmann.

Source/WebCore:

* platform/graphics/Font.h:
* platform/network/ResourceHandleInternal.h:
* platform/qt/ThirdPartyCookiesQt.h:

Source/WebKit/qt:

* WebCoreSupport/GeolocationClientQt.h:
* examples/platformplugin/WebPlugin.h:

Source/WebKit2:

* Platform/CoreIPC/Connection.h:
* Platform/PlatformProcessIdentifier.h:
* Platform/WorkQueue.h:
* Shared/qt/QtNetworkRequestData.h:
* Shared/qt/WebEventFactoryQt.h:
* UIProcess/API/C/qt/WKNativeEvent.h:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebnavigationhistory_p.h:
* UIProcess/API/qt/raw/qrawwebview_p.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/Launcher/ThreadLauncher.h:
* UIProcess/LayerTreeCoordinatorProxy.h:
* UIProcess/qt/QtViewportHandler.h:
* UIProcess/qt/QtWebPageSGNode.h:
* UIProcess/qt/WebColorChooserProxyQt.h:
* UIProcess/qt/WebGeolocationProviderQt.h:
* UIProcess/qt/WebPopupMenuProxyQt.h:
* WebProcess/WebProcess.h:

Tools:

* QtTestBrowser/launcherwindow.h:
* WebKitTestRunner/PlatformWebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate a few Chromium Android contributors in committers.py
peter@chromium.org [Tue, 24 Jul 2012 11:23:03 +0000 (11:23 +0000)]
Update a few Chromium Android contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=92090

Reviewed by Kent Tamura.

Add Sami Kyostila, who has been doing significant work on Chromium's
compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
remove John Grabowski who changed projects, and add my webkit.org alias.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Remove unneeded WebURLRequestEfl and WebURLResponseEfl
commit-queue@webkit.org [Tue, 24 Jul 2012 11:18:12 +0000 (11:18 +0000)]
[EFL][WK2] Remove unneeded WebURLRequestEfl and WebURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=92087

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Remove WebURLRequestEfl and WebURLResponseEfl classes
and their corresponding C APIs since we don't need / use
them.

* Shared/API/c/efl/WKURLRequestEfl.cpp: Removed.
* Shared/API/c/efl/WKURLRequestEfl.h: Removed.
* Shared/API/c/efl/WKURLResponseEfl.cpp: Removed.
* Shared/API/c/efl/WKURLResponseEfl.h: Removed.
* Shared/efl/WebURLRequestEfl.cpp: Removed.
* Shared/efl/WebURLRequestEfl.h: Removed.
* Shared/efl/WebURLResponseEfl.cpp: Removed.
* Shared/efl/WebURLResponseEfl.h: Removed.
* UIProcess/API/efl/ewk_url_request.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable touch slider when touch events are enabled
pierre.rossi@gmail.com [Tue, 24 Jul 2012 11:08:39 +0000 (11:08 +0000)]
[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013

Reviewed by Kenneth Rohde Christiansen.

TOUCH_SLIDER guards are used in WebCore, so we should really
be setting the corresponding ENABLE define in features.prf.

Source/WebKit2:

* Target.pri:

Tools:

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector [JSC]: Enable initiator column in network panel.
commit-queue@webkit.org [Tue, 24 Jul 2012 10:33:10 +0000 (10:33 +0000)]
Web Inspector [JSC]: Enable initiator column in network panel.
https://bugs.webkit.org/show_bug.cgi?id=65533

Patch by Anthony Scian <ascian@rim.com> on 2012-07-24
Reviewed by Vsevolod Vlasov.

Source/WebCore:

With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.

Test: http/tests/inspector/network/network-initiator.html

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
* inspector/front-end/Settings.js:

Source/WebKit/chromium:

With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.

Test: http/tests/inspector/network/network-initiator.html

* src/js/DevTools.js:

LayoutTests:

Bug https://bugs.webkit.org/show_bug.cgi?id=65105 caused
network-initiator.html to be disabled due to caching CSS information.
Tweaked the test so that reloads could be forced to avoid the cache
copy (thanks to Vsevolod Vlasov for help on this); test works now and
is updated for availability of stack traces fixed in 40118. Consolidated
results into common expected results output.

* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.hardReloadPage):
(initialize_InspectorTest.InspectorTest.reloadPage):
(initialize_InspectorTest.InspectorTest._innerReloadPage):
* http/tests/inspector/network/network-initiator-expected.txt:
* http/tests/inspector/network/network-initiator.html:
* platform/chromium/TestExpectations:
* platform/chromium/http/tests/inspector/network/network-initiated-expected.txt: Removed.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMissing *explicit* keyword in dom and page.
gyuyoung.kim@samsung.com [Tue, 24 Jul 2012 10:27:51 +0000 (10:27 +0000)]
Missing *explicit* keyword in dom and page.
https://bugs.webkit.org/show_bug.cgi?id=92074

Reviewed by Kentaro Hara.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

Some files in dom directory can't use explicit keyword because of build breaks.

No new tests. Covered by existing tests.

* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
* dom/BeforeTextInsertedEvent.h:
(BeforeTextInsertedEvent):
* dom/ChildListMutationScope.h:
(WebCore::ChildListMutationScope::ChildListMutationScope):
* dom/ChildNodeList.h:
(ChildNodeList):
* dom/ClientRect.h:
(ClientRect):
* dom/ClientRectList.h:
(ClientRectList):
* dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeParentWalker):
* dom/DOMCoreException.h:
(WebCore::DOMCoreException::DOMCoreException):
* dom/DOMImplementation.h:
(DOMImplementation):
* dom/DatasetDOMStringMap.h:
(WebCore::DatasetDOMStringMap::DatasetDOMStringMap):
* dom/DeviceMotionController.h:
(DeviceMotionController):
* dom/DeviceOrientationController.h:
(DeviceOrientationController):
* dom/DocumentParser.h:
(DocumentParser):
* dom/EventException.h:
(WebCore::EventException::EventException):
* dom/EventListener.h:
(WebCore::EventListener::EventListener):
* dom/ExceptionBase.h:
(ExceptionBase):
* dom/GenericEventQueue.h:
(GenericEventQueue):
* dom/KeyboardEvent.h:
(WebCore::KeypressCommand::KeypressCommand):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
* dom/MessageChannel.h:
(MessageChannel):
* dom/MessagePort.h:
(MessagePort):
* dom/MessagePortChannel.h:
(MessagePortChannel):
* dom/MutationObserver.h:
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::NamedNodeMap):
* dom/NodeFilter.h:
(WebCore::NodeFilter::NodeFilter):
* dom/NodeWithIndex.h:
(WebCore::NodeWithIndex::NodeWithIndex):
* dom/Range.h:
* dom/RangeException.h:
(WebCore::RangeException::RangeException):
* dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::RawDataDocumentParser):
* dom/ScriptRunner.h:
(ScriptRunner):
* dom/SelectorQuery.h:
(SelectorQuery):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/SpaceSplitString.h:
(SpaceSplitStringData):
* dom/StaticHashSetNodeList.h:
(StaticHashSetNodeList):
* dom/StaticNodeList.h:
(WebCore::StaticNodeList::StaticNodeList):
* dom/TransformSource.h:
(TransformSource):
* dom/TreeScope.h:
(TreeScope):
* dom/WebKitNamedFlowCollection.h:
(WebKitNamedFlowCollection):
* page/EventHandler.h:
(EventHandler):
* page/FocusController.h:
(FocusController):
* page/FrameView.h:
(FrameView):
* page/MemoryInfo.h:
(MemoryInfo):
* page/Page.h:
(Page):
* page/PageGroup.h:
(PageGroup):
* page/PrintContext.h:
(PrintContext):
* page/Settings.h:
(Settings):
* page/SpeechInput.h:
(SpeechInput):
* page/SpeechInputResultList.h:
(SpeechInputResultList):
* page/WebKitAnimation.h:
* page/WindowFeatures.h:
(WindowFeatures):
* page/WorkerNavigator.h:
(WorkerNavigator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EWebLauncher should not require config.h in the style check
ryuan.choi@samsung.com [Tue, 24 Jul 2012 10:27:07 +0000 (10:27 +0000)]
[EFL] EWebLauncher should not require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=92070

Reviewed by Kentaro Hara.

* Scripts/webkitpy/style/checker.py:
Remove the include rules from the style-check for EWebLauncher because
EWebLauncher is simple EFL application.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123450 268f45cc-cd09-0410-ab3c-d52691b4dbfc